https://git.reactos.org/?p=reactos.git;a=commitdiff;h=767d424b0aafd0eb49eb9…
commit 767d424b0aafd0eb49eb91ce3dc18d88bdf69ccf
Author: Timo Kreuzer <timo.kreuzer(a)reactos.org>
AuthorDate: Sat Aug 17 20:29:16 2019 +0200
Commit: Timo Kreuzer <timo.kreuzer(a)reactos.org>
CommitDate: Fri Aug 23 14:47:39 2019 +0200
[CMAKE] Turn C4715: "'function': not all control paths return a value" into an error on MSVC builds
---
sdk/cmake/msvc.cmake | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/sdk/cmake/msvc.cmake b/sdk/cmake/msvc.cmake
index 44b72771af0..419984b5d11 100644
--- a/sdk/cmake/msvc.cmake
+++ b/sdk/cmake/msvc.cmake
@@ -97,8 +97,9 @@ add_compile_flags("/wd4018")
# - C4312: conversion from '<integer>' to '<pointer>' of greater size
# - C4603: macro is not defined or definition is different after precompiled header use
# - C4700: uninitialized variable usage
+# - C4715: 'function': not all control paths return a value
# - C4716: function must return a value
-add_compile_flags("/we4013 /we4020 /we4022 /we4028 /we4047 /we4098 /we4113 /we4129 /we4133 /we4163 /we4229 /we4311 /we4312 /we4603 /we4700 /we4716")
+add_compile_flags("/we4013 /we4020 /we4022 /we4028 /we4047 /we4098 /we4113 /we4129 /we4133 /we4163 /we4229 /we4311 /we4312 /we4603 /we4700 /we4715 /we4716")
# - C4189: local variable initialized but not referenced
# Not in Release mode and not with MSVC 2010
https://git.reactos.org/?p=reactos.git;a=commitdiff;h=1539fb1414d099096475e…
commit 1539fb1414d099096475ee7a859e8da54379ad79
Author: Mark Jansen <mark.jansen(a)reactos.org>
AuthorDate: Tue Aug 20 14:20:17 2019 +0200
Commit: Mark Jansen <mark.jansen(a)reactos.org>
CommitDate: Fri Aug 23 13:03:36 2019 +0200
[NTOSKRNL] Demote some noisy dprints
---
ntoskrnl/io/pnpmgr/plugplay.c | 4 ++--
ntoskrnl/po/power.c | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/ntoskrnl/io/pnpmgr/plugplay.c b/ntoskrnl/io/pnpmgr/plugplay.c
index 8526817c3c7..7782c3ee135 100644
--- a/ntoskrnl/io/pnpmgr/plugplay.c
+++ b/ntoskrnl/io/pnpmgr/plugplay.c
@@ -1077,7 +1077,7 @@ IopResetDevice(PPLUGPLAY_CONTROL_RESET_DEVICE_DATA ResetDeviceData)
#endif
{
/* A driver has already been loaded for this device */
- DPRINT1("A reboot is required for the current driver for '%wZ' to be replaced\n", &DeviceNode->InstancePath);
+ DPRINT("A reboot is required for the current driver for '%wZ' to be replaced\n", &DeviceNode->InstancePath);
DeviceNode->Problem = CM_PROB_NEED_RESTART;
}
}
@@ -1093,7 +1093,7 @@ IopResetDevice(PPLUGPLAY_CONTROL_RESET_DEVICE_DATA ResetDeviceData)
if (NT_SUCCESS(Status))
{
/* Start the service and begin PnP initialization of the device again */
- DPRINT1("A new driver will be loaded for '%wZ' (no FDO above)\n", &DeviceNode->InstancePath);
+ DPRINT("A new driver will be loaded for '%wZ' (no FDO above)\n", &DeviceNode->InstancePath);
Status = IopActionInitChildServices(DeviceNode, DeviceNode->Parent);
}
}
diff --git a/ntoskrnl/po/power.c b/ntoskrnl/po/power.c
index 121a41cdda3..fe26c0f4620 100644
--- a/ntoskrnl/po/power.c
+++ b/ntoskrnl/po/power.c
@@ -625,7 +625,7 @@ VOID
NTAPI
PoStartNextPowerIrp(IN PIRP Irp)
{
- UNIMPLEMENTED;
+ UNIMPLEMENTED_ONCE;
}
/*