Ros-diffs September 2019

ros-diffs@reactos.org

21 participants
115 discussions

[reactos] 01/01: [SYSDM] Only Administrators should see all user profiles and be able to copy or delete them

by Eric Kohl

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=12e2039743a659fe5bc36… commit 12e2039743a659fe5bc36befbd26ff48d935c11d Author: Eric Kohl <eric.kohl(a)reactos.org> AuthorDate: Sun Sep 1 19:35:15 2019 +0200 Commit: Eric Kohl <eric.kohl(a)reactos.org> CommitDate: Sun Sep 1 19:39:28 2019 +0200 [SYSDM] Only Administrators should see all user profiles and be able to copy or delete them --- dll/cpl/sysdm/precomp.h | 1 + dll/cpl/sysdm/startrec.c | 1 - dll/cpl/sysdm/userprofile.c | 100 ++++++++++++++++++++++++++++---------------- 3 files changed, 65 insertions(+), 37 deletions(-) diff --git a/dll/cpl/sysdm/precomp.h b/dll/cpl/sysdm/precomp.h index bc27dd9c77f..5eb66604bb5 100644 --- a/dll/cpl/sysdm/precomp.h +++ b/dll/cpl/sysdm/precomp.h @@ -17,6 +17,7 @@ #include <tchar.h> #include <shellapi.h> #include <shlobj.h> +#include <setupapi.h> #include "resource.h" diff --git a/dll/cpl/sysdm/startrec.c b/dll/cpl/sysdm/startrec.c index 479db29ad76..ab29f89b745 100644 --- a/dll/cpl/sysdm/startrec.c +++ b/dll/cpl/sysdm/startrec.c @@ -11,7 +11,6 @@ #include "precomp.h" #include <shlwapi.h> -#include <setupapi.h> typedef struct _STARTINFO { diff --git a/dll/cpl/sysdm/userprofile.c b/dll/cpl/sysdm/userprofile.c index ff0e08ba3e7..fb49a204874 100644 --- a/dll/cpl/sysdm/userprofile.c +++ b/dll/cpl/sysdm/userprofile.c @@ -325,7 +325,7 @@ SetListViewColumns( static VOID AddUserProfile( _In_ HWND hwndListView, - _In_ LPTSTR lpProfileSid, + _In_ PSID pProfileSid, _In_ PSID pMySid, _In_ HKEY hProfileKey) { @@ -336,18 +336,13 @@ AddUserProfile( DWORD dwAccountNameSize, dwDomainNameSize; DWORD dwProfileData, dwSize, dwType, dwState = 0; PWSTR ptr; - PSID pSid = NULL; INT nId, iItem; LV_ITEM lvi; - if (!ConvertStringSidToSid(lpProfileSid, - &pSid)) - return; - dwAccountNameSize = ARRAYSIZE(szAccountName); dwDomainNameSize = ARRAYSIZE(szDomainName); if (!LookupAccountSidW(NULL, - pSid, + pProfileSid, szAccountName, &dwAccountNameSize, szDomainName, @@ -361,7 +356,7 @@ AddUserProfile( { /* Show only the user accounts */ if (Use != SidTypeUser) - goto done; + return; if (szAccountName[0] == UNICODE_NULL) { @@ -394,9 +389,9 @@ AddUserProfile( 0, dwProfileData); if (pProfileData == NULL) - goto done; + return; - pProfileData->bMyProfile = EqualSid(pMySid, pSid); + pProfileData->bMyProfile = EqualSid(pMySid, pProfileSid); pProfileData->dwState = dwState; ptr = (PWSTR)((ULONG_PTR)pProfileData + sizeof(PROFILEDATA)); @@ -423,10 +418,6 @@ AddUserProfile( LoadStringW(hApplet, nId, szAccountName, ARRAYSIZE(szAccountName)); ListView_SetItemText(hwndListView, iItem, 2, szAccountName); - -done: - if (pSid != NULL) - LocalFree(pSid); } @@ -450,7 +441,7 @@ UpdateButtonState( if (Item.lParam != 0) { bMyProfile = ((PPROFILEDATA)Item.lParam)->bMyProfile; - if (/*IsUserAnAdmin() &&*/ !bMyProfile) + if (!bMyProfile) { EnableWindow(GetDlgItem(hwndDlg, IDC_USERPROFILE_DELETE), TRUE); EnableWindow(GetDlgItem(hwndDlg, IDC_USERPROFILE_COPY), TRUE); @@ -471,7 +462,8 @@ UpdateButtonState( static VOID AddUserProfiles( _In_ HWND hwndDlg, - _In_ HWND hwndListView) + _In_ HWND hwndListView, + _In_ BOOL bAdmin) { HKEY hKeyUserProfiles = INVALID_HANDLE_VALUE; HKEY hProfileKey; @@ -482,6 +474,8 @@ AddUserProfiles( DWORD dwSize; HANDLE hToken = NULL; PTOKEN_USER pTokenUser = NULL; + PSID pProfileSid; + PWSTR pszProfileSid; if (!OpenProcessToken(GetCurrentProcess(), TOKEN_QUERY, &hToken)) return; @@ -504,32 +498,57 @@ AddUserProfiles( &hKeyUserProfiles)) goto done; - for (dwIndex = 0; ; dwIndex++) + if (bAdmin) { - dwSidLength = ARRAYSIZE(szProfileSid); - if (RegEnumKeyExW(hKeyUserProfiles, - dwIndex, - szProfileSid, - &dwSidLength, - NULL, - NULL, - NULL, - &ftLastWrite)) - break; + for (dwIndex = 0; ; dwIndex++) + { + dwSidLength = ARRAYSIZE(szProfileSid); + if (RegEnumKeyExW(hKeyUserProfiles, + dwIndex, + szProfileSid, + &dwSidLength, + NULL, + NULL, + NULL, + &ftLastWrite)) + break; + + if (RegOpenKeyExW(hKeyUserProfiles, + szProfileSid, + 0, + KEY_READ, + &hProfileKey) == ERROR_SUCCESS) + { + if (ConvertStringSidToSid(szProfileSid, &pProfileSid)) + { + AddUserProfile(hwndListView, pProfileSid, pTokenUser->User.Sid, hProfileKey); + LocalFree(pProfileSid); + } - if (RegOpenKeyExW(hKeyUserProfiles, - szProfileSid, - 0, - KEY_READ, - &hProfileKey) == ERROR_SUCCESS) + RegCloseKey(hProfileKey); + } + } + } + else + { + if (ConvertSidToStringSidW(pTokenUser->User.Sid, &pszProfileSid)) { - AddUserProfile(hwndListView, szProfileSid, pTokenUser->User.Sid, hProfileKey); - RegCloseKey(hProfileKey); + if (RegOpenKeyExW(hKeyUserProfiles, + pszProfileSid, + 0, + KEY_READ, + &hProfileKey) == ERROR_SUCCESS) + { + AddUserProfile(hwndListView, pTokenUser->User.Sid, pTokenUser->User.Sid, hProfileKey); + RegCloseKey(hProfileKey); + } + + LocalFree(pszProfileSid); } } if (ListView_GetItemCount(hwndListView) != 0) - ListView_SetItemState(hwndListView, 0, LVIS_SELECTED, LVIS_SELECTED); + ListView_SetItemState(hwndListView, 0, LVIS_SELECTED | LVIS_FOCUSED, LVIS_SELECTED | LVIS_FOCUSED); UpdateButtonState(hwndDlg, hwndListView); @@ -548,10 +567,19 @@ done: static VOID OnInitUserProfileDialog(HWND hwndDlg) { + BOOL bAdmin; + + bAdmin = IsUserAdmin(); + /* Initialize the list view control */ SetListViewColumns(GetDlgItem(hwndDlg, IDC_USERPROFILE_LIST)); - AddUserProfiles(hwndDlg, GetDlgItem(hwndDlg, IDC_USERPROFILE_LIST)); + /* Hide the delete and copy buttons for non-admins */ + ShowWindow(GetDlgItem(hwndDlg, IDC_USERPROFILE_DELETE), bAdmin ? SW_SHOW : SW_HIDE); + ShowWindow(GetDlgItem(hwndDlg, IDC_USERPROFILE_COPY), bAdmin ? SW_SHOW : SW_HIDE); + + /* Add the profiles to the list view */ + AddUserProfiles(hwndDlg, GetDlgItem(hwndDlg, IDC_USERPROFILE_LIST), bAdmin); }

5 years, 3 months

[reactos] 01/01: [HAL] Return correct bus handler in HaliFindBusAddressTranslation

by Stanislav Motylkov

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=17bb6d10eb6ec671aea08… commit 17bb6d10eb6ec671aea08885ef80bfcd7c9a91d5 Author: Stanislav Motylkov <x86corez(a)gmail.com> AuthorDate: Sun Sep 1 13:04:15 2019 +0300 Commit: Hermès BÉLUSCA - MAÏTO <hermes.belusca-maito(a)reactos.org> CommitDate: Sun Sep 1 16:37:56 2019 +0200 [HAL] Return correct bus handler in HaliFindBusAddressTranslation This fixes the bug when VidInitialize asks for different translated addresses and VgaIsPresent always returns FALSE either because the machine does not have VGA controller at all (e.g. 86Duino Zero), or it does have video hardware that is not compatible with VGA standard (e.g. Original Xbox). The problem investigated by Stanislav Motylkov. Suggested fix by Thomas Faber. CORE-14625 CORE-16216 CORE-16222 Co-authored-by: Thomas Faber <thomas.faber(a)reactos.org> --- hal/halx86/legacy/bussupp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hal/halx86/legacy/bussupp.c b/hal/halx86/legacy/bussupp.c index 7fff59f235c..b8a7cb888d9 100644 --- a/hal/halx86/legacy/bussupp.c +++ b/hal/halx86/legacy/bussupp.c @@ -1319,7 +1319,7 @@ HaliFindBusAddressTranslation(IN PHYSICAL_ADDRESS BusAddress, } /* If we made it, we're done */ - *Context = (ULONG_PTR)Handler; + *Context = (ULONG_PTR)&BusHandler->Handler; return TRUE; }

5 years, 3 months

[reactos] 01/01: [CRT][MSVCRT] Add __DestructExceptionObject from wine

by Timo Kreuzer

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=99fe069ce64f9b079b51e… commit 99fe069ce64f9b079b51e083ebb4e1b4092f71ff Author: Timo Kreuzer <timo.kreuzer(a)reactos.org> AuthorDate: Fri Aug 23 12:08:00 2019 +0200 Commit: Timo Kreuzer <timo.kreuzer(a)reactos.org> CommitDate: Sun Sep 1 16:29:26 2019 +0200 [CRT][MSVCRT] Add __DestructExceptionObject from wine --- dll/win32/msvcrt/msvcrt.spec | 2 +- sdk/lib/crt/except/cppexcept.h | 222 +++++++++++++++++++++++++++++++++++++++++ sdk/lib/crt/except/except.c | 36 +++++++ 3 files changed, 259 insertions(+), 1 deletion(-) diff --git a/dll/win32/msvcrt/msvcrt.spec b/dll/win32/msvcrt/msvcrt.spec index 196937908fd..576b9800eb0 100644 --- a/dll/win32/msvcrt/msvcrt.spec +++ b/dll/win32/msvcrt/msvcrt.spec @@ -212,7 +212,7 @@ @ cdecl -i386 __CxxQueryExceptionSize() # stub -i386 __CxxRegisterExceptionObject # stub -i386 __CxxUnregisterExceptionObject -# stub __DestructExceptionObject +@ cdecl -version=0x600+ __DestructExceptionObject(ptr) @ cdecl __RTCastToVoid(ptr) MSVCRT___RTCastToVoid @ cdecl __RTDynamicCast(ptr long ptr ptr long) MSVCRT___RTDynamicCast @ cdecl __RTtypeid(ptr) MSVCRT___RTtypeid diff --git a/sdk/lib/crt/except/cppexcept.h b/sdk/lib/crt/except/cppexcept.h new file mode 100644 index 00000000000..254d3ddd1be --- /dev/null +++ b/sdk/lib/crt/except/cppexcept.h @@ -0,0 +1,222 @@ +/* + * msvcrt C++ exception handling + * + * Copyright 2002 Alexandre Julliard + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library; if not, write to the Free Software + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA + */ + +#ifndef __MSVCRT_CPPEXCEPT_H +#define __MSVCRT_CPPEXCEPT_H + +#define CXX_FRAME_MAGIC_VC6 0x19930520 +#define CXX_FRAME_MAGIC_VC7 0x19930521 +#define CXX_FRAME_MAGIC_VC8 0x19930522 +#define CXX_EXCEPTION 0xe06d7363 + +#define FUNC_DESCR_SYNCHRONOUS 1 /* synchronous exceptions only (built with /EHs and /EHsc) */ + +typedef void (*vtable_ptr)(void); + +/* type_info object, see cpp.c for implementation */ +typedef struct __type_info +{ + const vtable_ptr* vtable; + char* name; /* Unmangled name, allocated lazily */ + char mangled[64]; /* Variable length, but we declare it large enough for static RTTI */ +} type_info; + +/* exception object */ +typedef struct __exception +{ + const vtable_ptr* vtable; + char* name; /* Name of this exception, always a new copy for each object */ + BOOL do_free; /* Whether to free 'name' in our dtor */ +} exception; + +typedef void (*cxx_copy_ctor)(void); + +/* offsets for computing the this pointer */ +typedef struct +{ + int this_offset; /* offset of base class this pointer from start of object */ + int vbase_descr; /* offset of virtual base class descriptor */ + int vbase_offset; /* offset of this pointer offset in virtual base class descriptor */ +} this_ptr_offsets; + +/* complete information about a C++ type */ +#ifndef __x86_64__ +typedef struct __cxx_type_info +{ + UINT flags; /* flags (see CLASS_* flags below) */ + const type_info* type_info; /* C++ type info */ + this_ptr_offsets offsets; /* offsets for computing the this pointer */ + unsigned int size; /* object size */ + cxx_copy_ctor copy_ctor; /* copy constructor */ +} cxx_type_info; +#else +typedef struct __cxx_type_info +{ + UINT flags; + unsigned int type_info; + this_ptr_offsets offsets; + unsigned int size; + unsigned int copy_ctor; +} cxx_type_info; +#endif + +#define CLASS_IS_SIMPLE_TYPE 1 +#define CLASS_HAS_VIRTUAL_BASE_CLASS 4 + +/* table of C++ types that apply for a given object */ +#ifndef __x86_64__ +typedef struct __cxx_type_info_table +{ + UINT count; /* number of types */ + const cxx_type_info* info[3]; /* variable length, we declare it large enough for static RTTI */ +} cxx_type_info_table; +#else +typedef struct __cxx_type_info_table +{ + UINT count; + unsigned int info[3]; +} cxx_type_info_table; +#endif + +struct __cxx_exception_frame; +struct __cxx_function_descr; + +typedef DWORD(*cxx_exc_custom_handler)(PEXCEPTION_RECORD, struct __cxx_exception_frame*, + PCONTEXT, EXCEPTION_REGISTRATION_RECORD**, + const struct __cxx_function_descr*, int nested_trylevel, + EXCEPTION_REGISTRATION_RECORD* nested_frame, DWORD unknown3); + +/* type information for an exception object */ +#ifndef __x86_64__ +typedef struct __cxx_exception_type +{ + UINT flags; /* TYPE_FLAG flags */ + void (*destructor)(void);/* exception object destructor */ + cxx_exc_custom_handler custom_handler; /* custom handler for this exception */ + const cxx_type_info_table* type_info_table; /* list of types for this exception object */ +} cxx_exception_type; +#else +typedef struct +{ + UINT flags; + unsigned int destructor; + unsigned int custom_handler; + unsigned int type_info_table; +} cxx_exception_type; +#endif + +void WINAPI _CxxThrowException(exception*, const cxx_exception_type*); +int CDECL _XcptFilter(NTSTATUS, PEXCEPTION_POINTERS); + +static inline const char* dbgstr_type_info(const type_info* info) +{ + if (!info) return "{}"; + return wine_dbg_sprintf("{vtable=%p name=%s (%s)}", + info->vtable, info->mangled, info->name ? info->name : ""); +} + +/* compute the this pointer for a base class of a given type */ +static inline void* get_this_pointer(const this_ptr_offsets* off, void* object) +{ + if (!object) return NULL; + + if (off->vbase_descr >= 0) + { + int* offset_ptr; + + /* move this ptr to vbase descriptor */ + object = (char*)object + off->vbase_descr; + /* and fetch additional offset from vbase descriptor */ + offset_ptr = (int*)(*(char**)object + off->vbase_offset); + object = (char*)object + *offset_ptr; + } + + object = (char*)object + off->this_offset; + return object; +} + +#ifndef __x86_64__ +#define DEFINE_EXCEPTION_TYPE_INFO(type, base_no, cl1, cl2) \ +\ +static const cxx_type_info type ## _cxx_type_info = { \ + 0, \ + & type ##_type_info, \ + { 0, -1, 0 }, \ + sizeof(type), \ + (cxx_copy_ctor)THISCALL(MSVCRT_ ## type ##_copy_ctor) \ +}; \ +\ +static const cxx_type_info_table type ## _type_info_table = { \ + base_no+1, \ + { \ + & type ## _cxx_type_info, \ + cl1, \ + cl2 \ + } \ +}; \ +\ +static const cxx_exception_type type ## _exception_type = { \ + 0, \ + (cxx_copy_ctor)THISCALL(MSVCRT_ ## type ## _dtor), \ + NULL, \ + & type ## _type_info_table \ +}; + +#else + +#define DEFINE_EXCEPTION_TYPE_INFO(type, base_no, cl1, cl2) \ +\ +static cxx_type_info type ## _cxx_type_info = { \ + 0, \ + 0xdeadbeef, \ + { 0, -1, 0 }, \ + sizeof(type), \ + 0xdeadbeef \ +}; \ +\ +static cxx_type_info_table type ## _type_info_table = { \ + base_no+1, \ + { \ + 0xdeadbeef, \ + 0xdeadbeef, \ + 0xdeadbeef \ + } \ +}; \ +\ +static cxx_exception_type type ##_exception_type = { \ + 0, \ + 0xdeadbeef, \ + 0, \ + 0xdeadbeef \ +}; \ +\ +static void init_ ## type ## _cxx(char *base) \ +{ \ + type ## _cxx_type_info.type_info = (char *)&type ## _type_info - base; \ + type ## _cxx_type_info.copy_ctor = (char *)MSVCRT_ ## type ## _copy_ctor - base; \ + type ## _type_info_table.info[0] = (char *)&type ## _cxx_type_info - base; \ + type ## _type_info_table.info[1] = (char *)cl1 - base; \ + type ## _type_info_table.info[2] = (char *)cl2 - base; \ + type ## _exception_type.destructor = (char *)MSVCRT_ ## type ## _dtor - base; \ + type ## _exception_type.type_info_table = (char *)&type ## _type_info_table - base; \ +} +#endif + +#endif /* __MSVCRT_CPPEXCEPT_H */ diff --git a/sdk/lib/crt/except/except.c b/sdk/lib/crt/except/except.c index cde9c1d9b1a..a3ed19bf545 100644 --- a/sdk/lib/crt/except/except.c +++ b/sdk/lib/crt/except/except.c @@ -23,6 +23,7 @@ #include <precomp.h> #include "excpt.h" +#include "cppexcept.h" #include <wine/exception.h> void CDECL _global_unwind2(EXCEPTION_REGISTRATION_RECORD* frame); @@ -300,3 +301,38 @@ MSVCRT_security_error_handler CDECL _set_security_error_handler( security_error_handler = handler; return old; } + +/********************************************************************* + * __DestructExceptionObject (MSVCRT.@) + */ +void CDECL __DestructExceptionObject(EXCEPTION_RECORD* rec) +{ + cxx_exception_type* info = (cxx_exception_type*)rec->ExceptionInformation[2]; + void* object = (void*)rec->ExceptionInformation[1]; + + TRACE("(%p)\n", rec); + + if (rec->ExceptionCode != CXX_EXCEPTION) return; +#ifndef __x86_64__ + if (rec->NumberParameters != 3) return; +#else + if (rec->NumberParameters != 4) return; +#endif + if (rec->ExceptionInformation[0] < CXX_FRAME_MAGIC_VC6 || + rec->ExceptionInformation[0] > CXX_FRAME_MAGIC_VC8) return; + + if (!info || !info->destructor) + return; + +#if defined(__i386__) + #ifdef _MSC_VER + ((void(__fastcall*)(void*))info->destructor)(object); + #else + __asm__ __volatile__("call *%0" : : "r" (info->destructor), "c" (object) : "eax", "edx", "memory"); + #endif +#elif defined(__x86_64__) + ((void(__cdecl*)(void*))(info->destructor + rec->ExceptionInformation[3]))(object); +#else + ((void(__cdecl*)(void*))info->destructor)(object); +#endif +}

5 years, 3 months

[reactos] 01/01: Revert "[CABMAN] Fix a problem with creating temp files on some Windows system"

by Timo Kreuzer

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=43c93faa1626ea337bd9a… commit 43c93faa1626ea337bd9a6b3dbc6e39684bc4cc5 Author: Timo Kreuzer <timo.kreuzer(a)reactos.org> AuthorDate: Sun Sep 1 16:23:17 2019 +0200 Commit: Timo Kreuzer <timo.kreuzer(a)reactos.org> CommitDate: Sun Sep 1 16:26:01 2019 +0200 Revert "[CABMAN] Fix a problem with creating temp files on some Windows system" This reverts commit bcb0d7c6c9f5577a64e5abdc3c1cedd95eeff6a3. --- sdk/tools/cabman/CCFDATAStorage.cxx | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/sdk/tools/cabman/CCFDATAStorage.cxx b/sdk/tools/cabman/CCFDATAStorage.cxx index b02551fbe76..1d7ef5e64f4 100644 --- a/sdk/tools/cabman/CCFDATAStorage.cxx +++ b/sdk/tools/cabman/CCFDATAStorage.cxx @@ -56,12 +56,7 @@ CCFDATAStorage::~CCFDATAStorage() ULONG CCFDATAStorage::Create() { if ((FileHandle = tmpfile()) == NULL) - { - /* Workaround for breakage on some Windows system */ - FileHandle = fopen(tmpnam(NULL) + 1, "wb"); - if (FileHandle == NULL) - return CAB_STATUS_CANNOT_CREATE; - } + return CAB_STATUS_CANNOT_CREATE; return CAB_STATUS_SUCCESS; }

5 years, 3 months

[reactos] 01/01: [NTOS:MM] Fix MmspCompareSegments

by Timo Kreuzer

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=41250d1028b2decd97c28… commit 41250d1028b2decd97c282f03f21a9c83d4c1e9b Author: Timo Kreuzer <timo.kreuzer(a)reactos.org> AuthorDate: Mon Apr 15 23:22:01 2019 +0200 Commit: Timo Kreuzer <timo.kreuzer(a)reactos.org> CommitDate: Sun Sep 1 14:15:07 2019 +0200 [NTOS:MM] Fix MmspCompareSegments On x64 the previous implementation would only compare the upper 32 bits and ignore the lower 32 bits. --- ntoskrnl/mm/section.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/ntoskrnl/mm/section.c b/ntoskrnl/mm/section.c index 69ffe53f6dc..1d7a043c2a1 100644 --- a/ntoskrnl/mm/section.c +++ b/ntoskrnl/mm/section.c @@ -3306,9 +3306,12 @@ MmspCompareSegments(const void * x, const MM_SECTION_SEGMENT *Segment1 = (const MM_SECTION_SEGMENT *)x; const MM_SECTION_SEGMENT *Segment2 = (const MM_SECTION_SEGMENT *)y; - return - (Segment1->Image.VirtualAddress - Segment2->Image.VirtualAddress) >> - ((sizeof(ULONG_PTR) - sizeof(int)) * 8); + if (Segment1->Image.VirtualAddress > Segment2->Image.VirtualAddress) + return 1; + else if (Segment1->Image.VirtualAddress < Segment2->Image.VirtualAddress) + return -1; + else + return 0; } /*

5 years, 3 months

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs September 2019