Ros-diffs October 2020

ros-diffs@reactos.org

22 participants
156 discussions

[reactos] 01/01: [RAPPS] Abort screenshot iteration on the first not found This should decrease startup time / db parse time

by Mark Jansen

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=c3b3fcd11129a4ef36edf… commit c3b3fcd11129a4ef36edfacb97b0c92fe745577d Author: Mark Jansen <mark.jansen(a)reactos.org> AuthorDate: Sun Oct 25 20:30:03 2020 +0100 Commit: Mark Jansen <mark.jansen(a)reactos.org> CommitDate: Sun Oct 25 20:30:03 2020 +0100 [RAPPS] Abort screenshot iteration on the first not found This should decrease startup time / db parse time --- base/applications/rapps/available.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/base/applications/rapps/available.cpp b/base/applications/rapps/available.cpp index fa266d7f5e1..075afd7063a 100644 --- a/base/applications/rapps/available.cpp +++ b/base/applications/rapps/available.cpp @@ -67,7 +67,9 @@ VOID CAvailableApplicationInfo::RetrieveGeneralInfo(AvailableStrings& AvlbString CStringW ScrnshotLocation; if (!GetString(ScrnshotField, ScrnshotLocation)) { - continue; + // We stop at the first screenshot not found, + // so screenshots _have_ to be consecutive + break; }

3 years, 10 months

[reactos] 01/01: [RAPPS][RAPPS.COM] Introduce a rapps console shim rapps.com will be launched when running 'rapps' from cmd or from run, and since it is a console application, explorer/ cmd will wait for it. This rapps.com passes the commandline to rapps.exe, and wait for rapps.exe to exit before closing.

by Mark Jansen

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=964c22c1cae372ad65622… commit 964c22c1cae372ad6562207fcbffa67c193dd501 Author: Mark Jansen <mark.jansen(a)reactos.org> AuthorDate: Sun Sep 20 22:18:08 2020 +0200 Commit: Mark Jansen <mark.jansen(a)reactos.org> CommitDate: Sun Oct 25 15:44:33 2020 +0100 [RAPPS][RAPPS.COM] Introduce a rapps console shim rapps.com will be launched when running 'rapps' from cmd or from run, and since it is a console application, explorer/ cmd will wait for it. This rapps.com passes the commandline to rapps.exe, and wait for rapps.exe to exit before closing. CORE-17281 --- base/applications/CMakeLists.txt | 1 + base/applications/rapps/CMakeLists.txt | 2 +- base/applications/rapps/appview.cpp | 10 +++- base/applications/rapps/available.cpp | 4 +- base/applications/rapps/include/unattended.h | 2 + base/applications/rapps/unattended.cpp | 55 ++++++++++---------- base/applications/rapps/winmain.cpp | 11 ++-- base/applications/rapps_com/CMakeLists.txt | 7 +++ base/applications/rapps_com/main.c | 73 +++++++++++++++++++++++++++ base/applications/rapps_com/main.ico | Bin 0 -> 29926 bytes base/applications/rapps_com/rapps.rc | 5 ++ 11 files changed, 128 insertions(+), 42 deletions(-) diff --git a/base/applications/CMakeLists.txt b/base/applications/CMakeLists.txt index 74ddde5815c..082b2121b35 100644 --- a/base/applications/CMakeLists.txt +++ b/base/applications/CMakeLists.txt @@ -30,6 +30,7 @@ add_subdirectory(network) add_subdirectory(notepad) add_subdirectory(osk) add_subdirectory(rapps) +add_subdirectory(rapps_com) add_subdirectory(regedit) add_subdirectory(regedt32) add_subdirectory(sc) diff --git a/base/applications/rapps/CMakeLists.txt b/base/applications/rapps/CMakeLists.txt index cb559b5509d..4da7397229f 100644 --- a/base/applications/rapps/CMakeLists.txt +++ b/base/applications/rapps/CMakeLists.txt @@ -41,7 +41,7 @@ add_definitions( file(GLOB_RECURSE rapps_rc_deps res/*.*) add_rc_deps(rapps.rc ${rapps_rc_deps}) add_executable(rapps ${SOURCE} rapps.rc) -set_module_type(rapps win32cui UNICODE) +set_module_type(rapps win32gui UNICODE) target_link_libraries(rapps conutils ${PSEH_LIB} uuid wine cpprt atl_classes) add_importlibs(rapps advapi32 comctl32 gdi32 wininet user32 shell32 shlwapi ole32 setupapi gdiplus msvcrt kernel32 ntdll) add_pch(rapps include/rapps.h SOURCE) diff --git a/base/applications/rapps/appview.cpp b/base/applications/rapps/appview.cpp index 0bdcc67cdbc..947df04d0bd 100644 --- a/base/applications/rapps/appview.cpp +++ b/base/applications/rapps/appview.cpp @@ -58,8 +58,14 @@ HIMAGELIST CMainToolbar::InitImageList() return hImageList; } -CMainToolbar::CMainToolbar() : m_iToolbarHeight(24) -{ +CMainToolbar::CMainToolbar() + : m_iToolbarHeight(24) + , m_dButtonsWidthMax(0) +{ + memset(szInstallBtn, 0, sizeof(szInstallBtn)); + memset(szUninstallBtn, 0, sizeof(szUninstallBtn)); + memset(szModifyBtn, 0, sizeof(szModifyBtn)); + memset(szSelectAll, 0, sizeof(szSelectAll)); } VOID CMainToolbar::OnGetDispInfo(LPTOOLTIPTEXT lpttt) diff --git a/base/applications/rapps/available.cpp b/base/applications/rapps/available.cpp index 6de168024dd..fa266d7f5e1 100644 --- a/base/applications/rapps/available.cpp +++ b/base/applications/rapps/available.cpp @@ -7,15 +7,13 @@ * Copyright 2017 Alexander Shaposhnikov (sanchaez(a)reactos.org) * Copyright 2020 He Yang (1160386205(a)qq.com) */ + #include "rapps.h" #include "available.h" #include "misc.h" #include "dialogs.h" -#include <atlcoll.h> -#include <atlsimpcoll.h> -#include <atlstr.h> // CAvailableApplicationInfo CAvailableApplicationInfo::CAvailableApplicationInfo(const ATL::CStringW& sFileNameParam, AvailableStrings& AvlbStrings) diff --git a/base/applications/rapps/include/unattended.h b/base/applications/rapps/include/unattended.h index 301f54ab9e7..83aa2e06b9f 100644 --- a/base/applications/rapps/include/unattended.h +++ b/base/applications/rapps/include/unattended.h @@ -5,6 +5,8 @@ #define CMD_KEY_FIND L"FIND" #define CMD_KEY_INFO L"INFO" #define CMD_KEY_HELP L"?" +#define CMD_KEY_HELP_ALT L"HELP" + const WCHAR UsageString[] = L"RAPPS \ [/" CMD_KEY_HELP L"] \ diff --git a/base/applications/rapps/unattended.cpp b/base/applications/rapps/unattended.cpp index f1589a3b544..885c604fd5e 100644 --- a/base/applications/rapps/unattended.cpp +++ b/base/applications/rapps/unattended.cpp @@ -20,28 +20,36 @@ BOOL MatchCmdOption(LPWSTR argvOption, LPCWSTR szOptToMacth) { if (argvOption[0] == FirstCharList[i]) { - if (StrCmpIW(argvOption + 1, szOptToMacth) == 0) - { - return TRUE; - } - else - { - return FALSE; - } + return StrCmpIW(argvOption + 1, szOptToMacth) == 0; } } return FALSE; } +void InitRappsConsole() +{ + // First, try to attach to our parent's console + if (!AttachConsole(ATTACH_PARENT_PROCESS)) + { + // Did we already have a console? + if (GetLastError() != ERROR_ACCESS_DENIED) + { + // No, try to open a new one + AllocConsole(); + } + } + ConInitStdStreams(); // Initialize the Console Standard Streams +} + + BOOL HandleInstallCommand(LPWSTR szCommand, int argcLeft, LPWSTR * argvLeft) { if (argcLeft == 0) { - ConInitStdStreams(); // Initialize the Console Standard Streams + InitRappsConsole(); ConResMsgPrintf(StdOut, NULL, IDS_CMD_NEED_PACKAGE_NAME, szCommand); return FALSE; } - FreeConsole(); ATL::CSimpleArray<ATL::CStringW> PkgNameList; @@ -70,11 +78,10 @@ BOOL HandleSetupCommand(LPWSTR szCommand, int argcLeft, LPWSTR * argvLeft) { if (argcLeft != 1) { - ConInitStdStreams(); // Initialize the Console Standard Streams + InitRappsConsole(); ConResMsgPrintf(StdOut, NULL, IDS_CMD_NEED_FILE_NAME, szCommand); return FALSE; } - FreeConsole(); ATL::CSimpleArray<ATL::CStringW> PkgNameList; HINF InfHandle = SetupOpenInfFileW(argvLeft[0], NULL, INF_STYLE_WIN4, NULL); @@ -218,20 +225,14 @@ BOOL HandleInfoCommand(LPWSTR szCommand, int argcLeft, LPWSTR *argvLeft) return TRUE; } -BOOL HandleHelpCommand(LPWSTR szCommand, int argcLeft, LPWSTR * argvLeft) +VOID PrintHelpCommand() { - if (argcLeft != 0) - { - return FALSE; - } - ConPrintf(StdOut, L"\n"); ConResPuts(StdOut, IDS_APPTITLE); ConPrintf(StdOut, L"\n\n"); ConResPuts(StdOut, IDS_CMD_USAGE); ConPrintf(StdOut, L"%ls\n", UsageString); - return TRUE; } BOOL ParseCmdAndExecute(LPWSTR lpCmdLine, BOOL bIsFirstLaunch, int nCmdShow) @@ -246,10 +247,6 @@ BOOL ParseCmdAndExecute(LPWSTR lpCmdLine, BOOL bIsFirstLaunch, int nCmdShow) if (argc == 1) // RAPPS is launched without options { - // Close the console, and open MainWindow - FreeConsole(); - - // Check for if rapps MainWindow is already launched in another process HANDLE hMutex; @@ -275,7 +272,8 @@ BOOL ParseCmdAndExecute(LPWSTR lpCmdLine, BOOL bIsFirstLaunch, int nCmdShow) return TRUE; } - else if (MatchCmdOption(argv[1], CMD_KEY_INSTALL)) + + if (MatchCmdOption(argv[1], CMD_KEY_INSTALL)) { return HandleInstallCommand(argv[1], argc - 2, argv + 2); } @@ -283,9 +281,8 @@ BOOL ParseCmdAndExecute(LPWSTR lpCmdLine, BOOL bIsFirstLaunch, int nCmdShow) { return HandleSetupCommand(argv[1], argc - 2, argv + 2); } - - ConInitStdStreams(); // Initialize the Console Standard Streams + InitRappsConsole(); if (MatchCmdOption(argv[1], CMD_KEY_FIND)) { @@ -295,14 +292,16 @@ BOOL ParseCmdAndExecute(LPWSTR lpCmdLine, BOOL bIsFirstLaunch, int nCmdShow) { return HandleInfoCommand(argv[1], argc - 2, argv + 2); } - else if (MatchCmdOption(argv[1], CMD_KEY_HELP)) + else if (MatchCmdOption(argv[1], CMD_KEY_HELP) || MatchCmdOption(argv[1], CMD_KEY_HELP_ALT)) { - return HandleHelpCommand(argv[1], argc - 2, argv + 2); + PrintHelpCommand(); + return TRUE; } else { // unrecognized/invalid options ConResPuts(StdOut, IDS_CMD_INVALID_OPTION); + PrintHelpCommand(); return FALSE; } } diff --git a/base/applications/rapps/winmain.cpp b/base/applications/rapps/winmain.cpp index 9d36df598eb..c8604ca6c9e 100644 --- a/base/applications/rapps/winmain.cpp +++ b/base/applications/rapps/winmain.cpp @@ -7,15 +7,10 @@ * Copyright 2017 Alexander Shaposhnikov (sanchaez(a)reactos.org) */ #include "rapps.h" - #include "unattended.h" - #include "winmain.h" - #include <atlcom.h> - #include <gdiplus.h> - #include <conutils.h> LPCWSTR szWindowClass = L"ROSAPPMGR"; @@ -63,11 +58,11 @@ VOID InitializeGDIPlus(BOOL bInitialize) } } -int wmain(int argc, wchar_t *argv[]) +INT WINAPI wWinMain(HINSTANCE hInstance, HINSTANCE hPrevInstance, LPWSTR lpCmdLine, INT nShowCmd) { BOOL bIsFirstLaunch; - InitializeAtlModule(GetModuleHandle(NULL), TRUE); + InitializeAtlModule(hInstance, TRUE); InitializeGDIPlus(TRUE); if (GetUserDefaultUILanguage() == MAKELANGID(LANG_HEBREW, SUBLANG_DEFAULT)) @@ -75,7 +70,7 @@ int wmain(int argc, wchar_t *argv[]) SetProcessDefaultLayout(LAYOUT_RTL); } - hInst = GetModuleHandle(NULL); + hInst = hInstance; bIsFirstLaunch = !LoadSettings(&SettingsInfo); if (bIsFirstLaunch) diff --git a/base/applications/rapps_com/CMakeLists.txt b/base/applications/rapps_com/CMakeLists.txt new file mode 100644 index 00000000000..4e2ff5599cd --- /dev/null +++ b/base/applications/rapps_com/CMakeLists.txt @@ -0,0 +1,7 @@ +project(rapps) + +add_executable(rapps.com main.c rapps.rc) +set_module_type(rapps.com win32cui UNICODE) +set_target_properties(rapps.com PROPERTIES SUFFIX "") +add_importlibs(rapps.com msvcrt kernel32 ntdll) +add_cd_file(TARGET rapps.com DESTINATION reactos/system32 FOR all) diff --git a/base/applications/rapps_com/main.c b/base/applications/rapps_com/main.c new file mode 100644 index 00000000000..fdb583f053d --- /dev/null +++ b/base/applications/rapps_com/main.c @@ -0,0 +1,73 @@ +/* + * PROJECT: ReactOS Applications Manager Command-Line Launcher (rapps.com) + * LICENSE: GPL-2.0-or-later (https://spdx.org/licenses/GPL-2.0-or-later) + * PURPOSE: Allow explorer / cmd to wait for rapps.exe when passing commandline arguments + * COPYRIGHT: Copyright 2020 Mark Jansen (mark.jansen(a)reactos.org) + */ + +#include <windef.h> +#include <winbase.h> +#include <strsafe.h> + + +int run_rapps(LPWSTR cmdline) +{ + STARTUPINFOW si = { sizeof(si) }; + PROCESS_INFORMATION pi = { 0 }; + SetLastError(0); + if (!CreateProcessW(NULL, cmdline, NULL, NULL, FALSE, 0, NULL, NULL, &si, &pi)) + { + fprintf(stderr, "Unable to create rapps.exe process...\n"); + return -1; + } + CloseHandle(pi.hThread); + WaitForSingleObject(pi.hProcess, INFINITE); + DWORD dwExit; + GetExitCodeProcess(pi.hProcess, &dwExit); + CloseHandle(pi.hProcess); + return dwExit; +} + +int wmain(int argc, wchar_t* argv[]) +{ + WCHAR RappsExe[MAX_PATH] = { 0 }; + + GetModuleFileNameW(NULL, RappsExe, ARRAYSIZE(RappsExe)); + size_t arglen = wcslen(RappsExe); + if (arglen > 4 && !wcsicmp(RappsExe + arglen - 4, L".com")) + { + wcscpy(RappsExe + arglen - 4, L".exe"); + } + else + { + fprintf(stderr, "Unable to build rapps.exe path...\n"); + return - 1; + } + + arglen += (1 + 2); // nullterminator + 2 quotes + + for (int n = 1; n < argc; ++n) + { + arglen += wcslen(argv[n]); + arglen += 3; // Surrounding quotes + space + } + + wchar_t* cmdline = LocalAlloc(LMEM_ZEROINIT, arglen * sizeof(WCHAR)); + if (cmdline) + { + wchar_t* ptr = cmdline; + size_t cchRemaining = arglen; + + StringCchPrintfExW(ptr, cchRemaining, &ptr, &cchRemaining, 0, L"\"%s\"", RappsExe); + + for (int n = 1; n < argc; ++n) + { + StringCchPrintfExW(ptr, cchRemaining, &ptr, &cchRemaining, 0, L" \"%s\"", argv[n]); + } + } + + int iRet = run_rapps(cmdline); + if (cmdline) + LocalFree(cmdline); + return iRet; +} diff --git a/base/applications/rapps_com/main.ico b/base/applications/rapps_com/main.ico new file mode 100644 index 00000000000..27f227da3b1 Binary files /dev/null and b/base/applications/rapps_com/main.ico differ diff --git a/base/applications/rapps_com/rapps.rc b/base/applications/rapps_com/rapps.rc new file mode 100644 index 00000000000..9282aae2b8c --- /dev/null +++ b/base/applications/rapps_com/rapps.rc @@ -0,0 +1,5 @@ +#define REACTOS_STR_FILE_DESCRIPTION "ReactOS Applications Manager console shim" +#define REACTOS_STR_INTERNAL_NAME "rapps" +#define REACTOS_STR_ORIGINAL_FILENAME "rapps.com" + +#include <reactos/version.rc>

3 years, 10 months

[reactos] 01/01: [DBGHELP] Add missing support for AMD64. (#3083)

by Carlo Bramini

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=4ffd9fb3a0489ad93ab36… commit 4ffd9fb3a0489ad93ab36d65298f056650120b25 Author: Carlo Bramini <30959007+carlo-bramini(a)users.noreply.github.com> AuthorDate: Sun Oct 25 12:30:37 2020 +0100 Commit: GitHub <noreply(a)github.com> CommitDate: Sun Oct 25 12:30:37 2020 +0100 [DBGHELP] Add missing support for AMD64. (#3083) See: https://docs.microsoft.com/en-us/windows/win32/api/winnt/ns-winnt-context --- dll/win32/dbghelp/compat.h | 115 ++++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 113 insertions(+), 2 deletions(-) diff --git a/dll/win32/dbghelp/compat.h b/dll/win32/dbghelp/compat.h index 2711bca953a..f7bef66bc91 100644 --- a/dll/win32/dbghelp/compat.h +++ b/dll/win32/dbghelp/compat.h @@ -335,11 +335,120 @@ typedef struct _CONTEXT { DWORD Esp; DWORD SegSs; BYTE ExtendedRegisters[MAXIMUM_SUPPORTED_EXTENSION]; -} CONTEXT, *PCONTEXT; +} CONTEXT; #elif defined TARGET_amd64 -#error "Please define the CONTEXT structure for amd64 platform" +typedef struct _M128A { + ULONGLONG Low; + LONGLONG High; +} M128A, *PM128A; + +typedef struct _XMM_SAVE_AREA32 { + WORD ControlWord; + WORD StatusWord; + BYTE TagWord; + BYTE Reserved1; + WORD ErrorOpcode; + DWORD ErrorOffset; + WORD ErrorSelector; + WORD Reserved2; + DWORD DataOffset; + WORD DataSelector; + WORD Reserved3; + DWORD MxCsr; + DWORD MxCsr_Mask; + M128A FloatRegisters[8]; + M128A XmmRegisters[16]; + BYTE Reserved4[96]; +} XMM_SAVE_AREA32, *PXMM_SAVE_AREA32; + +typedef struct _CONTEXT { + DWORD64 P1Home; + DWORD64 P2Home; + DWORD64 P3Home; + DWORD64 P4Home; + DWORD64 P5Home; + DWORD64 P6Home; + + /* Control flags */ + DWORD ContextFlags; + DWORD MxCsr; + + /* Segment */ + WORD SegCs; + WORD SegDs; + WORD SegEs; + WORD SegFs; + WORD SegGs; + WORD SegSs; + DWORD EFlags; + + /* Debug */ + DWORD64 Dr0; + DWORD64 Dr1; + DWORD64 Dr2; + DWORD64 Dr3; + DWORD64 Dr6; + DWORD64 Dr7; + + /* Integer */ + DWORD64 Rax; + DWORD64 Rcx; + DWORD64 Rdx; + DWORD64 Rbx; + DWORD64 Rsp; + DWORD64 Rbp; + DWORD64 Rsi; + DWORD64 Rdi; + DWORD64 R8; + DWORD64 R9; + DWORD64 R10; + DWORD64 R11; + DWORD64 R12; + DWORD64 R13; + DWORD64 R14; + DWORD64 R15; + + /* Counter */ + DWORD64 Rip; + + /* Floating point */ + union { + XMM_SAVE_AREA32 FltSave; + struct { + M128A Header[2]; + M128A Legacy[8]; + M128A Xmm0; + M128A Xmm1; + M128A Xmm2; + M128A Xmm3; + M128A Xmm4; + M128A Xmm5; + M128A Xmm6; + M128A Xmm7; + M128A Xmm8; + M128A Xmm9; + M128A Xmm10; + M128A Xmm11; + M128A Xmm12; + M128A Xmm13; + M128A Xmm14; + M128A Xmm15; + } DUMMYSTRUCTNAME; + } DUMMYUNIONNAME; + + /* Vector */ + M128A VectorRegister[26]; + DWORD64 VectorControl; + + /* Debug control */ + DWORD64 DebugControl; + DWORD64 LastBranchToRip; + DWORD64 LastBranchFromRip; + DWORD64 LastExceptionToRip; + DWORD64 LastExceptionFromRip; +} CONTEXT; #elif defined TARGET_arm /* ARM? */ @@ -446,6 +555,8 @@ PRUNTIME_FUNCTION WINAPI RtlLookupFunctionEntry(ULONG_PTR,DWORD*,UNWIND_HISTORY_ #endif +typedef CONTEXT *PCONTEXT; + typedef EXCEPTION_DISPOSITION NTAPI

3 years, 10 months

[reactos] 01/01: [WIN32SS] Repaint the whole window frame on some style bits set (#3199)

by Doug Lyons

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=8081ba93321e04916f854… commit 8081ba93321e04916f854ba85f3ab512254c1b04 Author: Doug Lyons <douglyons(a)douglyons.com> AuthorDate: Sat Oct 24 14:35:45 2020 -0500 Commit: GitHub <noreply(a)github.com> CommitDate: Sat Oct 24 22:35:45 2020 +0300 [WIN32SS] Repaint the whole window frame on some style bits set (#3199) This fixes the ReactOS Calculator buttons disappearing in CORE-16827 --- win32ss/user/ntuser/winpos.c | 26 +++++++++++++++++++------- 1 file changed, 19 insertions(+), 7 deletions(-) diff --git a/win32ss/user/ntuser/winpos.c b/win32ss/user/ntuser/winpos.c index 9a74a16e45b..bbe6ac5f904 100644 --- a/win32ss/user/ntuser/winpos.c +++ b/win32ss/user/ntuser/winpos.c @@ -2112,13 +2112,25 @@ co_WinPosSetWindowPos( if ( !(pwnd->style & WS_CHILD) ) { - HRGN DcRgn = NtGdiCreateRectRgn(0, 0, 0, 0); - PREGION DcRgnObj = REGION_LockRgn(DcRgn); - TRACE("SWP_FRAMECHANGED win %p hRgn %p\n",pwnd, DcRgn); - IntGdiCombineRgn(DcRgnObj, VisBefore, NULL, RGN_COPY); - REGION_UnlockRgn(DcRgnObj); - ForceNCPaintErase(pwnd, DcRgn, DcRgnObj); - GreDeleteObject(DcRgn); + /* + * Check if we have these specific windows style bits set/reset. + * FIXME: There may be other combinations of styles that need this handling as well. + * This fixes the ReactOS Calculator buttons disappearing in CORE-16827. + */ + if ((Window->style & WS_CLIPSIBLINGS) && !(Window->style & (WS_POPUP | WS_CLIPCHILDREN | WS_SIZEBOX))) + { + IntSendNCPaint(pwnd, HRGN_WINDOW); // Paint the whole frame. + } + else // Use region handling + { + HRGN DcRgn = NtGdiCreateRectRgn(0, 0, 0, 0); + PREGION DcRgnObj = REGION_LockRgn(DcRgn); + TRACE("SWP_FRAMECHANGED win %p hRgn %p\n",pwnd, DcRgn); + IntGdiCombineRgn(DcRgnObj, VisBefore, NULL, RGN_COPY); + REGION_UnlockRgn(DcRgnObj); + ForceNCPaintErase(pwnd, DcRgn, DcRgnObj); + GreDeleteObject(DcRgn); + } } } }

3 years, 10 months

[reactos] 01/01: [FASTFAT] Implement the overflow queue. CORE-17344 CORE-17328

by Thomas Faber

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=303f17f884513ebf89d4c… commit 303f17f884513ebf89d4c10744219382fea1d1d1 Author: Thomas Faber <thomas.faber(a)reactos.org> AuthorDate: Sun Oct 18 15:23:52 2020 +0200 Commit: Thomas Faber <thomas.faber(a)reactos.org> CommitDate: Sat Oct 24 19:53:36 2020 +0200 [FASTFAT] Implement the overflow queue. CORE-17344 CORE-17328 This avoids blocking all Ex worker threads in fastfat, thereby making Cc unable to issue the lazy writes that would unblock those workers. This is more or less directly taken from fastfat_new. --- drivers/filesystems/fastfat/fsctl.c | 5 ++ drivers/filesystems/fastfat/misc.c | 92 ++++++++++++++++++++++++++++++++++--- drivers/filesystems/fastfat/vfat.h | 6 +++ 3 files changed, 97 insertions(+), 6 deletions(-) diff --git a/drivers/filesystems/fastfat/fsctl.c b/drivers/filesystems/fastfat/fsctl.c index a8cbca4670f..6764a67d329 100644 --- a/drivers/filesystems/fastfat/fsctl.c +++ b/drivers/filesystems/fastfat/fsctl.c @@ -600,6 +600,11 @@ VfatMount( DeviceExt->HashTableSize = HashTableSize; DeviceExt->VolumeDevice = DeviceObject; + KeInitializeSpinLock(&DeviceExt->OverflowQueueSpinLock); + InitializeListHead(&DeviceExt->OverflowQueue); + DeviceExt->OverflowQueueCount = 0; + DeviceExt->PostedRequestCount = 0; + /* use same vpb as device disk */ DeviceObject->Vpb = Vpb; DeviceToMount->Vpb = Vpb; diff --git a/drivers/filesystems/fastfat/misc.c b/drivers/filesystems/fastfat/misc.c index 443ad290817..76b17f1db36 100644 --- a/drivers/filesystems/fastfat/misc.c +++ b/drivers/filesystems/fastfat/misc.c @@ -336,12 +336,53 @@ static VOID NTAPI VfatDoRequest( - PVOID IrpContext) + PVOID Context) { + PVFAT_IRP_CONTEXT IrpContext = Context; + PDEVICE_EXTENSION DeviceExt; + KIRQL OldIrql; + InterlockedDecrement(&QueueCount); - DPRINT("VfatDoRequest(IrpContext %p), MajorFunction %x, %d\n", - IrpContext, ((PVFAT_IRP_CONTEXT)IrpContext)->MajorFunction, QueueCount); - VfatDispatchRequest((PVFAT_IRP_CONTEXT)IrpContext); + + if (IrpContext->Stack->FileObject != NULL) + { + DeviceExt = IrpContext->Stack->DeviceObject->DeviceExtension; + ObReferenceObject(DeviceExt->VolumeDevice); + } + + do + { + DPRINT("VfatDoRequest(IrpContext %p), MajorFunction %x, %d\n", + IrpContext, IrpContext->MajorFunction, QueueCount); + VfatDispatchRequest(IrpContext); + IrpContext = NULL; + + /* Now process any overflow items */ + if (DeviceExt != NULL) + { + KeAcquireSpinLock(&DeviceExt->OverflowQueueSpinLock, &OldIrql); + if (DeviceExt->OverflowQueueCount != 0) + { + IrpContext = CONTAINING_RECORD(RemoveHeadList(&DeviceExt->OverflowQueue), + VFAT_IRP_CONTEXT, + WorkQueueItem.List); + DeviceExt->OverflowQueueCount--; + DPRINT("Processing overflow item for IRP %p context %p (%lu)\n", + IrpContext->Irp, IrpContext, DeviceExt->OverflowQueueCount); + } + else + { + ASSERT(IsListEmpty(&DeviceExt->OverflowQueue)); + DeviceExt->PostedRequestCount--; + } + KeReleaseSpinLock(&DeviceExt->OverflowQueueSpinLock, OldIrql); + } + } while (IrpContext != NULL); + + if (DeviceExt != NULL) + { + ObDereferenceObject(DeviceExt->VolumeDevice); + } } static @@ -349,6 +390,10 @@ NTSTATUS VfatQueueRequest( PVFAT_IRP_CONTEXT IrpContext) { + PDEVICE_EXTENSION DeviceExt; + KIRQL OldIrql; + BOOLEAN Overflow; + InterlockedIncrement(&QueueCount); DPRINT("VfatQueueRequest(IrpContext %p), %d\n", IrpContext, QueueCount); @@ -357,10 +402,41 @@ VfatQueueRequest( ASSERT(!(IrpContext->Flags & IRPCONTEXT_QUEUE) && (IrpContext->Flags & IRPCONTEXT_COMPLETE)); + Overflow = FALSE; IrpContext->Flags |= IRPCONTEXT_CANWAIT; IoMarkIrpPending(IrpContext->Irp); - ExInitializeWorkItem(&IrpContext->WorkQueueItem, VfatDoRequest, IrpContext); - ExQueueWorkItem(&IrpContext->WorkQueueItem, CriticalWorkQueue); + + /* We should not block more than two worker threads per volume, + * or we might stop Cc from doing the work to unblock us. + * Add additional requests into the overflow queue instead and process + * them all in an existing worker thread (see VfatDoRequest above). + */ + if (IrpContext->Stack->FileObject != NULL) + { + DeviceExt = IrpContext->Stack->DeviceObject->DeviceExtension; + KeAcquireSpinLock(&DeviceExt->OverflowQueueSpinLock, &OldIrql); + if (DeviceExt->PostedRequestCount > 2) + { + DeviceExt->OverflowQueueCount++; + DPRINT("Queue overflow. Adding IRP %p context %p to overflow queue (%lu)\n", + IrpContext->Irp, IrpContext, DeviceExt->OverflowQueueCount); + InsertTailList(&DeviceExt->OverflowQueue, + &IrpContext->WorkQueueItem.List); + Overflow = TRUE; + } + else + { + DeviceExt->PostedRequestCount++; + } + KeReleaseSpinLock(&DeviceExt->OverflowQueueSpinLock, OldIrql); + } + + if (!Overflow) + { + ExInitializeWorkItem(&IrpContext->WorkQueueItem, VfatDoRequest, IrpContext); + ExQueueWorkItem(&IrpContext->WorkQueueItem, CriticalWorkQueue); + } + return STATUS_PENDING; } @@ -552,6 +628,10 @@ VfatCheckForDismount( vfatDestroyFCB(Fcb); } + ASSERT(DeviceExt->OverflowQueueCount == 0); + ASSERT(IsListEmpty(&DeviceExt->OverflowQueue)); + ASSERT(DeviceExt->PostedRequestCount == 0); + /* * Now that the closing of the internal opened meta-files has been * handled, we can now set the VPB's DeviceObject to NULL. diff --git a/drivers/filesystems/fastfat/vfat.h b/drivers/filesystems/fastfat/vfat.h index fcb3a25cca7..943c6b76ab1 100644 --- a/drivers/filesystems/fastfat/vfat.h +++ b/drivers/filesystems/fastfat/vfat.h @@ -330,6 +330,12 @@ typedef struct DEVICE_EXTENSION struct _VFATFCB *RootFcb; PSTATISTICS Statistics; + /* Overflow request queue */ + KSPIN_LOCK OverflowQueueSpinLock; + LIST_ENTRY OverflowQueue; + ULONG OverflowQueueCount; + ULONG PostedRequestCount; + /* Pointers to functions for manipulating FAT. */ PGET_NEXT_CLUSTER GetNextCluster; PFIND_AND_MARK_AVAILABLE_CLUSTER FindAndMarkAvailableCluster;

3 years, 10 months

[reactos] 01/01: [SHELL32] Stub SHGetShellStyleHInstance and SHGetAttributesFromDataObject CORE-17337 (#3295)

by Oleg Dubinskiy

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=cdb48b8219bafcf533b8d… commit cdb48b8219bafcf533b8ddd9908c857d89976fec Author: Oleg Dubinskiy <oleg.dubinskij2013(a)yandex.ua> AuthorDate: Sat Oct 24 18:04:54 2020 +0300 Commit: GitHub <noreply(a)github.com> CommitDate: Sat Oct 24 18:04:54 2020 +0300 [SHELL32] Stub SHGetShellStyleHInstance and SHGetAttributesFromDataObject CORE-17337 (#3295) They are required by MS Picture and Fax Viewer (shimgvw.dll), together with MS browseui.dll. CORE-17337 --- dll/win32/shell32/shell32.spec | 4 ++-- dll/win32/shell32/stubs.cpp | 25 +++++++++++++++++++++++++ 2 files changed, 27 insertions(+), 2 deletions(-) diff --git a/dll/win32/shell32/shell32.spec b/dll/win32/shell32/shell32.spec index b96c0f209d5..fc9df55855b 100644 --- a/dll/win32/shell32/shell32.spec +++ b/dll/win32/shell32/shell32.spec @@ -456,8 +456,8 @@ 745 stub -noname Create_IUIElement 747 stdcall SHLimitInputEdit(ptr ptr) 748 stdcall -noname SHLimitInputCombo(ptr ptr) -749 stub SHGetShellStyleHInstance -750 stub SHGetAttributesFromDataObject +749 stdcall -noname -version=0x501-0x502 SHGetShellStyleHInstance() +750 stdcall -noname SHGetAttributesFromDataObject(ptr long long long) 751 stub -noname SHSimulateDropOnClsid 752 stdcall -noname SHGetComputerDisplayNameW(long long long long) 753 stdcall -noname CheckStagingArea() diff --git a/dll/win32/shell32/stubs.cpp b/dll/win32/shell32/stubs.cpp index a995e395509..a5061ad1a9d 100644 --- a/dll/win32/shell32/stubs.cpp +++ b/dll/win32/shell32/stubs.cpp @@ -1301,3 +1301,28 @@ DWORD WINAPI SHGetComputerDisplayNameW(DWORD param1, DWORD param2, DWORD param3, FIXME("SHGetComputerDisplayNameW() stub\n"); return E_FAIL; } + +/* + * Unimplemented + */ +EXTERN_C HRESULT +WINAPI +SHGetAttributesFromDataObject(IDataObject *pdo, + DWORD dwAttributeMask, + DWORD *pdwAttributes, + UINT *pcItems) +{ + FIXME("SHGetAttributesFromDataObject() stub\n"); + return E_NOTIMPL; +} + +/* + * Unimplemented + */ +EXTERN_C HINSTANCE +WINAPI +SHGetShellStyleHInstance(VOID) +{ + FIXME("SHGetShellStyleHInstance() stub\n"); + return NULL; +}

3 years, 10 months

[reactos] 01/01: [BROWSEUI] CCommonBrowser class should support aggregation (#3308)

by Oleg Dubinskiy

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=d0a7df49fa8faf997d393… commit d0a7df49fa8faf997d393832a500903a165e2bff Author: Oleg Dubinskiy <oleg.dubinskij2013(a)yandex.ua> AuthorDate: Sat Oct 24 18:02:18 2020 +0300 Commit: GitHub <noreply(a)github.com> CommitDate: Sat Oct 24 18:02:18 2020 +0300 [BROWSEUI] CCommonBrowser class should support aggregation (#3308) It will remove the following error from the log when use MS shell32.dll in ReactOS: `fixme:(dll/win32/ole32/compobj.c:3454) Class {af604efe-8897-11d1-b944-00a0c90312e1} does not support aggregation`. References: https://www.geoffchappell.com/studies/windows/ie/browseui/classes/ccommonbr… https://docs.microsoft.com/en-us/cpp/atl/reference/aggregation-and-class-fa… CORE-17345 --- dll/win32/browseui/commonbrowser.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dll/win32/browseui/commonbrowser.h b/dll/win32/browseui/commonbrowser.h index c482bb154e3..c6060b7a093 100644 --- a/dll/win32/browseui/commonbrowser.h +++ b/dll/win32/browseui/commonbrowser.h @@ -187,7 +187,7 @@ public: virtual HRESULT STDMETHODCALLTYPE Drop(IDataObject *pDataObj, DWORD grfKeyState, POINTL pt, DWORD *pdwEffect); DECLARE_REGISTRY_RESOURCEID(IDR_COMMONBROWSER) - DECLARE_NOT_AGGREGATABLE(CCommonBrowser) + DECLARE_AGGREGATABLE(CCommonBrowser) DECLARE_PROTECT_FINAL_CONSTRUCT()

3 years, 10 months

[reactos] 01/01: [DOC] Add more files to "3rd Party Files.txt"

by Victor Perevertkin

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=dcfb80c47adc8d3b87648… commit dcfb80c47adc8d3b876486b956403fed3077b8e6 Author: Victor Perevertkin <victor.perevertkin(a)reactos.org> AuthorDate: Sat Oct 24 17:07:13 2020 +0300 Commit: Victor Perevertkin <victor.perevertkin(a)reactos.org> CommitDate: Sat Oct 24 17:07:13 2020 +0300 [DOC] Add more files to "3rd Party Files.txt" --- media/doc/3rd Party Files.txt | 37 +++++++++++++++++++++++++++++++------ 1 file changed, 31 insertions(+), 6 deletions(-) diff --git a/media/doc/3rd Party Files.txt b/media/doc/3rd Party Files.txt index 346d8dbd84d..322c063191f 100644 --- a/media/doc/3rd Party Files.txt +++ b/media/doc/3rd Party Files.txt @@ -6,6 +6,13 @@ SPDX identifier of a license was used where possible. Please update this file when you port/sync an external project. +Title: TreeList +Path: base/setup/reactos/treelist.c +Path: base/setup/reactos/treelist.h +Used Version: ??? +License: GPL-3.0-or-later (https://spdx.org/licenses/GPL-3.0-or-later.html) +URL: https://github.com/sebkirche/treelist + Title: DXTN OpenGL Compression Libs Path: dll/3rdparty/dxtn Used Version: 1.1 @@ -108,6 +115,12 @@ Used Version: git commit 16022c5 License: MS-PL (https://spdx.org/licenses/MS-PL.html) URL: https://github.com/microsoft/Windows-driver-samples/tree/master/filesys +Title: VirtIO NetKVM Windows guest driver +Path: drivers/network/dd/netkvm +Used Version: git commit 5e01b36 +License: BSD-3-Clause (https://spdx.org/licenses/BSD-3-Clause.html) +URL: https://github.com/virtio-win/kvm-guest-drivers-windows/tree/master/NetKVM/… + Title: Microsoft CDROM Storage Class Driver Path: drivers/storage/class/cdrom_new Used Version: git commit 96eb96d @@ -132,6 +145,18 @@ Used Version: git commit 8fb512a License: MS-PL (https://spdx.org/licenses/MS-PL.html) URL: https://github.com/microsoft/Windows-driver-samples/tree/master/storage +Title: Universal ATA driver for Windows +Path: drivers/storage/ide/uniata +Used Version: 0.47a +License: BSD-like +URL: http://alter.org.ua/soft/win/uni_ata/ + +Title: Miniport driver for the Buslogic BT 958 SCSI Controller +Path: drivers/storage/port/buslogic +Used Version: ??? +License: GPL-2.0-or-later (https://spdx.org/licenses/GPL-2.0-or-later.html) +URL: http://www.vmware.com/download/open_sources.html + Title: DejaVu Fonts Path: media/fonts Used Version: 2.37 @@ -216,15 +241,15 @@ Used Version: 1.2.11 License: Zlib (https://spdx.org/licenses/Zlib.html) URL: http://www.zlib.net -Title: Schily Tools, mkisofs -Path: sdk/tools/mkisofs/schilytools -Used Version: schily-2017-09-07 -License: CDDL-1.0 (https://spdx.org/licenses/CDDL-1.0.html) -URL: https://sourceforge.net/projects/schilytools/ - Title: chmc and lzxcomp Path: sdk/tools/hhpcomp/chmc Path: sdk/tools/hhpcomp/lzx_compress Used Version: ??? (Imported on 2015.08.11.) License: GPL-3.0-or-later (https://spdx.org/licenses/GPL-3.0-or-later.html) URL: https://sourceforge.net/projects/chmc/ + +Title: Schily Tools, mkisofs +Path: sdk/tools/mkisofs/schilytools +Used Version: schily-2017-09-07 +License: CDDL-1.0 (https://spdx.org/licenses/CDDL-1.0.html) +URL: https://sourceforge.net/projects/schilytools/

3 years, 10 months

[reactos] 03/03: [COMPILER_APITEST] Add new compiler_apitest, using pseh tests

by Timo Kreuzer

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=a713e63b8bb8e3b9495f7… commit a713e63b8bb8e3b9495f75c262c9ffd0157305a6 Author: Timo Kreuzer <timo.kreuzer(a)reactos.org> AuthorDate: Tue Mar 10 01:27:59 2020 +0100 Commit: Timo Kreuzer <timo.kreuzer(a)reactos.org> CommitDate: Sat Oct 24 13:26:33 2020 +0200 [COMPILER_APITEST] Add new compiler_apitest, using pseh tests --- modules/rostests/apitests/compiler/CMakeLists.txt | 31 ++++++++-------------- .../apitests/compiler/{psehtest.c => pseh.c} | 8 +----- modules/rostests/apitests/compiler/pseh_cpp.cpp | 3 +++ .../rostests/apitests/compiler/psehtest_cpp.cpp | 3 --- modules/rostests/apitests/compiler/testlist.c | 12 +++++++++ 5 files changed, 27 insertions(+), 30 deletions(-) diff --git a/modules/rostests/apitests/compiler/CMakeLists.txt b/modules/rostests/apitests/compiler/CMakeLists.txt index fe5ee66e0b0..1cff26dbe19 100644 --- a/modules/rostests/apitests/compiler/CMakeLists.txt +++ b/modules/rostests/apitests/compiler/CMakeLists.txt @@ -1,21 +1,12 @@ -add_executable(pseh2_test psehtest.c psehtest2.c) -target_link_libraries(pseh2_test wine ${PSEH_LIB}) -set_module_type(pseh2_test win32cui) -add_importlibs(pseh2_test msvcrt kernel32 ntdll) -add_rostests_file(TARGET pseh2_test) - -if(NOT MSVC) - target_compile_options(pseh2_test PRIVATE "-Wno-format") -endif() - - -add_executable(pseh2_test_cpp psehtest_cpp.cpp psehtest2.c) -target_link_libraries(pseh2_test_cpp wine ${PSEH_LIB}) -set_module_type(pseh2_test_cpp win32cui) -add_importlibs(pseh2_test_cpp msvcrt kernel32 ntdll) -add_rostests_file(TARGET pseh2_test_cpp) - -if(NOT MSVC) - target_compile_options(pseh2_test_cpp PRIVATE "-Wno-format") -endif() +list(APPEND SOURCE + pseh.c + pseh_cpp.cpp + psehtest2.c + testlist.c) + +add_executable(compiler_apitest ${SOURCE}) +target_link_libraries(compiler_apitest wine ${PSEH_LIB}) +set_module_type(compiler_apitest win32cui) +add_importlibs(compiler_apitest msvcrt kernel32 ntdll) +add_rostests_file(TARGET compiler_apitest) diff --git a/modules/rostests/apitests/compiler/psehtest.c b/modules/rostests/apitests/compiler/pseh.c similarity index 99% rename from modules/rostests/apitests/compiler/psehtest.c rename to modules/rostests/apitests/compiler/pseh.c index 242b3ecff8e..61800b17cf6 100644 --- a/modules/rostests/apitests/compiler/psehtest.c +++ b/modules/rostests/apitests/compiler/pseh.c @@ -26,7 +26,6 @@ extern "C" { #endif -#define STANDALONE #include <wine/test.h> extern void no_op(void); @@ -2760,7 +2759,7 @@ struct subtest int (* func)(void); }; -void testsuite_syntax(void) +START_TEST(pseh) { const struct subtest testsuite[] = { @@ -2893,9 +2892,4 @@ void testsuite_syntax(void) ok(call_test(testsuite[i].func), "%s failed\n", testsuite[i].name); } -const struct test winetest_testlist[] = { - { "pseh2_syntax", testsuite_syntax }, - { 0, 0 } -}; - /* EOF */ diff --git a/modules/rostests/apitests/compiler/pseh_cpp.cpp b/modules/rostests/apitests/compiler/pseh_cpp.cpp new file mode 100644 index 00000000000..8a638741e64 --- /dev/null +++ b/modules/rostests/apitests/compiler/pseh_cpp.cpp @@ -0,0 +1,3 @@ + +#define func_pseh func_pseh_cpp +#include "pseh.c" diff --git a/modules/rostests/apitests/compiler/psehtest_cpp.cpp b/modules/rostests/apitests/compiler/psehtest_cpp.cpp deleted file mode 100644 index d6fe2e51d75..00000000000 --- a/modules/rostests/apitests/compiler/psehtest_cpp.cpp +++ /dev/null @@ -1,3 +0,0 @@ - - -#include "psehtest.c" diff --git a/modules/rostests/apitests/compiler/testlist.c b/modules/rostests/apitests/compiler/testlist.c new file mode 100644 index 00000000000..998fc1642e0 --- /dev/null +++ b/modules/rostests/apitests/compiler/testlist.c @@ -0,0 +1,12 @@ +#define STANDALONE +#include <apitest.h> + +extern void func_pseh(void); +extern void func_pseh_cpp(void); + +const struct test winetest_testlist[] = +{ + { "pseh", func_pseh }, + { "pseh_cpp", func_pseh_cpp }, + { 0, 0 } +};

3 years, 10 months

[reactos] 02/03: [PSEH2_TEST] Move it to apitests

by Timo Kreuzer

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=69e80a1e74e12db1dfc27… commit 69e80a1e74e12db1dfc27938faab10a715b1ce34 Author: Timo Kreuzer <timo.kreuzer(a)reactos.org> AuthorDate: Mon Mar 9 22:42:51 2020 +0100 Commit: Timo Kreuzer <timo.kreuzer(a)reactos.org> CommitDate: Sat Oct 24 13:26:33 2020 +0200 [PSEH2_TEST] Move it to apitests The folder name is compiler, because it is going to be part of a new compiler_apitest. --- modules/rostests/apitests/CMakeLists.txt | 1 + modules/rostests/{tests/pseh2 => apitests/compiler}/CMakeLists.txt | 0 modules/rostests/{tests/pseh2 => apitests/compiler}/psehtest.c | 0 modules/rostests/{tests/pseh2 => apitests/compiler}/psehtest2.c | 0 modules/rostests/{tests/pseh2 => apitests/compiler}/psehtest_cpp.cpp | 0 modules/rostests/tests/CMakeLists.txt | 1 - 6 files changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/rostests/apitests/CMakeLists.txt b/modules/rostests/apitests/CMakeLists.txt index c0a6e85ad17..18e4a148a28 100644 --- a/modules/rostests/apitests/CMakeLists.txt +++ b/modules/rostests/apitests/CMakeLists.txt @@ -13,6 +13,7 @@ add_subdirectory(browseui) add_subdirectory(cmd) add_subdirectory(com) add_subdirectory(comctl32) +add_subdirectory(compiler) add_subdirectory(crt) add_subdirectory(dbghelp) add_subdirectory(dciman32) diff --git a/modules/rostests/tests/pseh2/CMakeLists.txt b/modules/rostests/apitests/compiler/CMakeLists.txt similarity index 100% rename from modules/rostests/tests/pseh2/CMakeLists.txt rename to modules/rostests/apitests/compiler/CMakeLists.txt diff --git a/modules/rostests/tests/pseh2/psehtest.c b/modules/rostests/apitests/compiler/psehtest.c similarity index 100% rename from modules/rostests/tests/pseh2/psehtest.c rename to modules/rostests/apitests/compiler/psehtest.c diff --git a/modules/rostests/tests/pseh2/psehtest2.c b/modules/rostests/apitests/compiler/psehtest2.c similarity index 100% rename from modules/rostests/tests/pseh2/psehtest2.c rename to modules/rostests/apitests/compiler/psehtest2.c diff --git a/modules/rostests/tests/pseh2/psehtest_cpp.cpp b/modules/rostests/apitests/compiler/psehtest_cpp.cpp similarity index 100% rename from modules/rostests/tests/pseh2/psehtest_cpp.cpp rename to modules/rostests/apitests/compiler/psehtest_cpp.cpp diff --git a/modules/rostests/tests/CMakeLists.txt b/modules/rostests/tests/CMakeLists.txt index 0fc1ed4c2bd..d29a8adf65d 100644 --- a/modules/rostests/tests/CMakeLists.txt +++ b/modules/rostests/tests/CMakeLists.txt @@ -1,4 +1,3 @@ add_subdirectory(mmixer_test) -add_subdirectory(pseh2) add_subdirectory(dllexport) add_subdirectory(spec2def)

3 years, 10 months

← Newer
1
2
3
4
5
6
7
...
16
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs October 2020