Ros-diffs March 2020

ros-diffs@reactos.org

25 participants
156 discussions

[reactos] 01/01: [SPEC2DEF] Omit skipped exports from ordinal numbering. CORE-16769
by Mark Jansen 31 Mar '20

31 Mar '20

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=c1464a4030c6f9438becb… commit c1464a4030c6f9438becbbeffb83e1d5de100454 Author: Mark Jansen <mark.jansen(a)reactos.org> AuthorDate: Mon Mar 30 19:41:14 2020 +0200 Commit: Mark Jansen <mark.jansen(a)reactos.org> CommitDate: Tue Mar 31 22:49:44 2020 +0200 [SPEC2DEF] Omit skipped exports from ordinal numbering. CORE-16769 --- sdk/tools/spec2def/spec2def.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sdk/tools/spec2def/spec2def.c b/sdk/tools/spec2def/spec2def.c index b929487069d..c1ac211ccc0 100644 --- a/sdk/tools/spec2def/spec2def.c +++ b/sdk/tools/spec2def/spec2def.c @@ -1332,7 +1332,7 @@ ApplyOrdinals(EXPORT* pexports, unsigned cExports) /* Pass 2: apply available ordinals */ for (i = 0, j = 1; i < cExports; i++) { - if ((pexports[i].uFlags & FL_ORDINAL) == 0) + if ((pexports[i].uFlags & FL_ORDINAL) == 0 && pexports[i].bVersionIncluded) { while (used[j] != 0) j++;

1 0

[reactos] 01/01: [HOTPLUG] Display class icons for removable devices
by Eric Kohl 31 Mar '20

31 Mar '20

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=45e79efd06adc2348d566… commit 45e79efd06adc2348d56627689b37bbcaa05eea5 Author: Eric Kohl <eric.kohl(a)reactos.org> AuthorDate: Tue Mar 31 22:43:42 2020 +0200 Commit: Eric Kohl <eric.kohl(a)reactos.org> CommitDate: Tue Mar 31 22:44:31 2020 +0200 [HOTPLUG] Display class icons for removable devices --- dll/cpl/hotplug/hotplug.c | 82 +++++++++++++++++++++++++++++++++++++++++++---- 1 file changed, 75 insertions(+), 7 deletions(-) diff --git a/dll/cpl/hotplug/hotplug.c b/dll/cpl/hotplug/hotplug.c index 7152e487075..17788fc8212 100644 --- a/dll/cpl/hotplug/hotplug.c +++ b/dll/cpl/hotplug/hotplug.c @@ -11,6 +11,12 @@ #define NDEBUG #include <debug.h> +typedef struct _HOTPLUG_DATA +{ + SP_CLASSIMAGELIST_DATA ImageListData; +} HOTPLUG_DATA, *PHOTPLUG_DATA; + + // globals HINSTANCE hApplet = 0; @@ -23,7 +29,9 @@ APPLET Applets[NUM_APPLETS] = static VOID -EnumHotpluggedDevices(HWND hwndDeviceTree) +EnumHotpluggedDevices( + HWND hwndDeviceTree, + PHOTPLUG_DATA pHotplugData) { WCHAR szDisplayName[40]; SP_DEVINFO_DATA did = { 0 }; @@ -32,6 +40,10 @@ EnumHotpluggedDevices(HWND hwndDeviceTree) DWORD dwCapabilities, dwSize; ULONG ulStatus, ulProblem; TVINSERTSTRUCTW tvItem; +// HTREEITEM hTreeItem; + WCHAR szGuidString[MAX_GUID_STRING_LEN]; + GUID ClassGuid; + INT nClassImage; CONFIGRET cr; TreeView_DeleteAllItems(hwndDeviceTree); @@ -84,20 +96,42 @@ EnumHotpluggedDevices(HWND hwndDeviceTree) if (cr != CR_SUCCESS) wcscpy(szDisplayName, L"Unknown Device"); + /* Get the class GUID */ + dwSize = sizeof(szGuidString); + cr = CM_Get_DevNode_Registry_Property(did.DevInst, + CM_DRP_CLASSGUID, + NULL, + szGuidString, + &dwSize, + 0); + if (cr == CR_SUCCESS) + { + pSetupGuidFromString(szGuidString, &ClassGuid); + } + else + { +// memcpy(&ClassGuid, GUID_DEVCLASS_UNKNOWN, sizeof(GUID)); + } + + /* Get the image for the class this device is in */ + SetupDiGetClassImageIndex(&pHotplugData->ImageListData, + &ClassGuid, + &nClassImage); + /* Add it to the device tree */ ZeroMemory(&tvItem, sizeof(tvItem)); tvItem.hParent = TVI_ROOT; tvItem.hInsertAfter = TVI_FIRST; - tvItem.item.mask = TVIF_STATE | TVIF_TEXT /*| TVIF_PARAM | TVIF_IMAGE | TVIF_SELECTEDIMAGE */; + tvItem.item.mask = TVIF_STATE | TVIF_TEXT /*| TVIF_PARAM*/ | TVIF_IMAGE | TVIF_SELECTEDIMAGE; tvItem.item.state = TVIS_EXPANDED; tvItem.item.stateMask = TVIS_EXPANDED; tvItem.item.pszText = szDisplayName; -// tvItem.item.iImage = IMAGE_SOUND_SECTION; -// tvItem.item.iSelectedImage = IMAGE_SOUND_SECTION; + tvItem.item.iImage = nClassImage; + tvItem.item.iSelectedImage = nClassImage; tvItem.item.lParam = (LPARAM)NULL; - /*hTreeItem = */ TreeView_InsertItem(hwndDeviceTree, &tvItem); + /*hTreeItem =*/ TreeView_InsertItem(hwndDeviceTree, &tvItem); @@ -116,12 +150,31 @@ SafeRemovalDlgProc( WPARAM wParam, LPARAM lParam) { + PHOTPLUG_DATA pHotplugData; + UNREFERENCED_PARAMETER(lParam); + + pHotplugData = (PHOTPLUG_DATA)GetWindowLongPtr(hwndDlg, DWLP_USER); + switch (uMsg) { case WM_INITDIALOG: - EnumHotpluggedDevices(GetDlgItem(hwndDlg, IDC_SAFE_REMOVE_DEVICE_TREE)); + pHotplugData = HeapAlloc(GetProcessHeap(), 0, sizeof(HOTPLUG_DATA)); + if (pHotplugData != NULL) + { + SetWindowLongPtr(hwndDlg, DWLP_USER, (LONG_PTR)pHotplugData); + + pHotplugData->ImageListData.cbSize = sizeof(pHotplugData->ImageListData); + SetupDiGetClassImageList(&pHotplugData->ImageListData); + + TreeView_SetImageList(GetDlgItem(hwndDlg, IDC_SAFE_REMOVE_DEVICE_TREE), + pHotplugData->ImageListData.ImageList, + TVSIL_NORMAL); + + EnumHotpluggedDevices(GetDlgItem(hwndDlg, IDC_SAFE_REMOVE_DEVICE_TREE), + pHotplugData); + } return TRUE; case WM_COMMAND: @@ -148,7 +201,12 @@ SafeRemovalDlgProc( if (wParam == 1) { KillTimer(hwndDlg, 1); - EnumHotpluggedDevices(GetDlgItem(hwndDlg, IDC_SAFE_REMOVE_DEVICE_TREE)); + + if (pHotplugData != NULL) + { + EnumHotpluggedDevices(GetDlgItem(hwndDlg, IDC_SAFE_REMOVE_DEVICE_TREE), + pHotplugData); + } } break; @@ -156,6 +214,16 @@ SafeRemovalDlgProc( KillTimer(hwndDlg, 1); EndDialog(hwndDlg, TRUE); break; + + case WM_DESTROY: + if (pHotplugData != NULL) + { + SetupDiDestroyClassImageList(&pHotplugData->ImageListData); + + HeapFree(GetProcessHeap(), 0, pHotplugData); + SetWindowLongPtr(hwndDlg, DWLP_USER, (LONG_PTR)NULL); + } + break; } return FALSE;

1 0

[reactos] 01/01: [CONFIGURE] Simplify version detection for modern Visual Studio
by Victor Perevertkin 31 Mar '20

31 Mar '20

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=d37799ea3e52a74493eae… commit d37799ea3e52a74493eae40f861b4a5f6a3b8b8f Author: Victor Perevertkin <victor.perevertkin(a)reactos.org> AuthorDate: Tue Mar 31 12:29:56 2020 +0300 Commit: Victor Perevertkin <victor.perevertkin(a)reactos.org> CommitDate: Tue Mar 31 12:29:56 2020 +0300 [CONFIGURE] Simplify version detection for modern Visual Studio --- configure.cmd | 14 ++------------ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/configure.cmd b/configure.cmd index acbf3da1bd2..1cee20afc3f 100755 --- a/configure.cmd +++ b/configure.cmd @@ -54,18 +54,8 @@ if defined ROS_ARCH ( cl 2>&1 | find "17.00." > NUL && set VS_VERSION=11 cl 2>&1 | find "18.00." > NUL && set VS_VERSION=12 cl 2>&1 | find "19.00." > NUL && set VS_VERSION=14 - cl 2>&1 | find "19.10." > NUL && set VS_VERSION=15 - cl 2>&1 | find "19.11." > NUL && set VS_VERSION=15 - cl 2>&1 | find "19.12." > NUL && set VS_VERSION=15 - cl 2>&1 | find "19.13." > NUL && set VS_VERSION=15 - cl 2>&1 | find "19.14." > NUL && set VS_VERSION=15 - cl 2>&1 | find "19.15." > NUL && set VS_VERSION=15 - cl 2>&1 | find "19.16." > NUL && set VS_VERSION=15 - cl 2>&1 | find "19.20." > NUL && set VS_VERSION=16 - cl 2>&1 | find "19.21." > NUL && set VS_VERSION=16 - cl 2>&1 | find "19.22." > NUL && set VS_VERSION=16 - cl 2>&1 | find "19.23." > NUL && set VS_VERSION=16 - cl 2>&1 | find "19.24." > NUL && set VS_VERSION=16 + cl 2>&1 | findstr /R /c:"19\.1.\." > NUL && set VS_VERSION=15 + cl 2>&1 | findstr /R /c:"19\.2.\." > NUL && set VS_VERSION=16 if not defined VS_VERSION ( echo Error: Visual Studio version too old ^(before 10 ^(2010^)^) or version detection failed. goto quit

1 0

[reactos] 01/01: [HOTPLUG] Add 32 pixel icon. (#2486)
by Jared Smudde 30 Mar '20

30 Mar '20

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=8aa58c19a607658a61a83… commit 8aa58c19a607658a61a833fab84775ee72f061cb Author: Jared Smudde <computerwhiz02(a)hotmail.com> AuthorDate: Mon Mar 30 16:54:17 2020 -0500 Commit: GitHub <noreply(a)github.com> CommitDate: Mon Mar 30 23:54:17 2020 +0200 [HOTPLUG] Add 32 pixel icon. (#2486) Add a 32 pixel icon to the main icon for hotplug.cpl so the Safely Remove Hardware dialog looks normal. --- dll/cpl/hotplug/resources/1.ico | Bin 2550 -> 9062 bytes 1 file changed, 0 insertions(+), 0 deletions(-) diff --git a/dll/cpl/hotplug/resources/1.ico b/dll/cpl/hotplug/resources/1.ico index f615f0ebd3c..8e5ba04caa9 100644 Binary files a/dll/cpl/hotplug/resources/1.ico and b/dll/cpl/hotplug/resources/1.ico differ

1 0

[reactos] 01/01: [HOTPLUG] Show removable devices and update the list on arrival and removal.
by Eric Kohl 30 Mar '20

30 Mar '20

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=cbdf649f2cb6ee27b8333… commit cbdf649f2cb6ee27b8333860b916a05037e9d211 Author: Eric Kohl <eric.kohl(a)reactos.org> AuthorDate: Mon Mar 30 23:11:44 2020 +0200 Commit: Eric Kohl <eric.kohl(a)reactos.org> CommitDate: Mon Mar 30 23:11:44 2020 +0200 [HOTPLUG] Show removable devices and update the list on arrival and removal. --- dll/cpl/hotplug/hotplug.c | 111 ++++++++++++++++++++++++++++++++++++++++++++++ dll/cpl/hotplug/hotplug.h | 4 ++ 2 files changed, 115 insertions(+) diff --git a/dll/cpl/hotplug/hotplug.c b/dll/cpl/hotplug/hotplug.c index c67d0d80376..7152e487075 100644 --- a/dll/cpl/hotplug/hotplug.c +++ b/dll/cpl/hotplug/hotplug.c @@ -21,6 +21,93 @@ APPLET Applets[NUM_APPLETS] = }; +static +VOID +EnumHotpluggedDevices(HWND hwndDeviceTree) +{ + WCHAR szDisplayName[40]; + SP_DEVINFO_DATA did = { 0 }; + HDEVINFO hdev; + int idev; + DWORD dwCapabilities, dwSize; + ULONG ulStatus, ulProblem; + TVINSERTSTRUCTW tvItem; + CONFIGRET cr; + + TreeView_DeleteAllItems(hwndDeviceTree); + + hdev = SetupDiGetClassDevs(NULL, NULL, 0, DIGCF_ALLCLASSES | DIGCF_PRESENT); + if (hdev == INVALID_HANDLE_VALUE) + return; + + did.cbSize = sizeof(did); + + /* Enumerate all the attached devices */ + for (idev = 0; SetupDiEnumDeviceInfo(hdev, idev, &did); idev++) + { + ulStatus = 0; + ulProblem = 0; + + cr = CM_Get_DevNode_Status(&ulStatus, + &ulProblem, + did.DevInst, + 0); + if (cr != CR_SUCCESS) + continue; + + dwCapabilities = 0, + dwSize = sizeof(dwCapabilities); + cr = CM_Get_DevNode_Registry_Property(did.DevInst, + CM_DRP_CAPABILITIES, + NULL, + &dwCapabilities, + &dwSize, + 0); + if (cr != CR_SUCCESS) + continue; + + /* Add devices that require safe removal to the device tree */ + if ( (dwCapabilities & CM_DEVCAP_REMOVABLE) && + !(dwCapabilities & CM_DEVCAP_DOCKDEVICE) && + !(dwCapabilities & CM_DEVCAP_SURPRISEREMOVALOK) && + ((dwCapabilities & CM_DEVCAP_EJECTSUPPORTED) || (ulStatus & DN_DISABLEABLE)) && + ulProblem == 0) + { + /* Get the device description */ + dwSize = sizeof(szDisplayName); + cr = CM_Get_DevNode_Registry_Property(did.DevInst, + CM_DRP_DEVICEDESC, + NULL, + szDisplayName, + &dwSize, + 0); + if (cr != CR_SUCCESS) + wcscpy(szDisplayName, L"Unknown Device"); + + /* Add it to the device tree */ + ZeroMemory(&tvItem, sizeof(tvItem)); + tvItem.hParent = TVI_ROOT; + tvItem.hInsertAfter = TVI_FIRST; + + tvItem.item.mask = TVIF_STATE | TVIF_TEXT /*| TVIF_PARAM | TVIF_IMAGE | TVIF_SELECTEDIMAGE */; + tvItem.item.state = TVIS_EXPANDED; + tvItem.item.stateMask = TVIS_EXPANDED; + tvItem.item.pszText = szDisplayName; +// tvItem.item.iImage = IMAGE_SOUND_SECTION; +// tvItem.item.iSelectedImage = IMAGE_SOUND_SECTION; + tvItem.item.lParam = (LPARAM)NULL; + + /*hTreeItem = */ TreeView_InsertItem(hwndDeviceTree, &tvItem); + + + + } + } + + SetupDiDestroyDeviceInfoList(hdev); +} + + INT_PTR CALLBACK SafeRemovalDlgProc( @@ -34,17 +121,41 @@ SafeRemovalDlgProc( switch (uMsg) { case WM_INITDIALOG: + EnumHotpluggedDevices(GetDlgItem(hwndDlg, IDC_SAFE_REMOVE_DEVICE_TREE)); return TRUE; case WM_COMMAND: switch (LOWORD(wParam)) { case IDCLOSE: + KillTimer(hwndDlg, 1); EndDialog(hwndDlg, TRUE); break; } break; + + case WM_DEVICECHANGE: + switch (wParam) + { + case DBT_DEVNODES_CHANGED: + SetTimer(hwndDlg, 1, 500, NULL); + break; + } + break; + + case WM_TIMER: + if (wParam == 1) + { + KillTimer(hwndDlg, 1); + EnumHotpluggedDevices(GetDlgItem(hwndDlg, IDC_SAFE_REMOVE_DEVICE_TREE)); + } + break; + + case WM_CLOSE: + KillTimer(hwndDlg, 1); + EndDialog(hwndDlg, TRUE); + break; } return FALSE; diff --git a/dll/cpl/hotplug/hotplug.h b/dll/cpl/hotplug/hotplug.h index b21d59a0235..38beaac69c3 100644 --- a/dll/cpl/hotplug/hotplug.h +++ b/dll/cpl/hotplug/hotplug.h @@ -7,10 +7,14 @@ #include <wingdi.h> #include <winuser.h> #include <wincon.h> +#include <winreg.h> #include <commctrl.h> #include <cpl.h> #include <tchar.h> #include <limits.h> +#include <setupapi.h> +#include <cfgmgr32.h> +#include <dbt.h> #include "resource.h"

1 0

[reactos] 01/01: [ROSAPPS][PICE] Fix ROSAPPS-355 Unreachable code
by Joachim Henze 30 Mar '20

30 Mar '20

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=30dcc229f06f395e55f3f… commit 30dcc229f06f395e55f3f94df5db310afdf56a42 Author: Joachim Henze <Joachim.Henze(a)reactos.org> AuthorDate: Mon Mar 30 17:18:16 2020 +0200 Commit: Joachim Henze <Joachim.Henze(a)reactos.org> CommitDate: Mon Mar 30 17:18:16 2020 +0200 [ROSAPPS][PICE] Fix ROSAPPS-355 Unreachable code Just to satisfy static code analysis. No change in behavior expected. The same way as the external applications maintainers fixed it in their latest version https://sourceforge.net/projects/pice/files/pICE%20source/build_20/ By killing the whole function ScrollUp() with the disabled code. Like the original authors I left the functions unused declaration existing within hardware.h --- .../sysutils/utils/pice/module/hardware.c | 22 ---------------------- 1 file changed, 22 deletions(-) diff --git a/modules/rosapps/applications/sysutils/utils/pice/module/hardware.c b/modules/rosapps/applications/sysutils/utils/pice/module/hardware.c index 65864a0373e..7d49b793eda 100644 --- a/modules/rosapps/applications/sysutils/utils/pice/module/hardware.c +++ b/modules/rosapps/applications/sysutils/utils/pice/module/hardware.c @@ -664,27 +664,6 @@ void ClrLine(ULONG line) ohandlers.ClrLine(line); } -//************************************************************************* -// ScrollUp() -// -// Scroll a specific window up one line -//************************************************************************* -void ScrollUp(USHORT Window) -{ - USHORT i; - - return; - - if(!wWindow[Window].bScrollDisabled) - { - for(i=1;i<wWindow[Window].cy;i++) - { - CopyLineTo((USHORT)(wWindow[Window].y+i-1),(USHORT)(wWindow[Window].y+i)); - } - ClrLine((USHORT)(wWindow[Window].y+wWindow[Window].cy-1)); - } -} - //************************************************************************* // Home() // @@ -848,7 +827,6 @@ void Print(USHORT Window,LPSTR p) if(wWindow[Window].usCurY>=wWindow[Window].cy) { wWindow[Window].usCurY=wWindow[Window].cy-1; - ScrollUp(Window); } if(wWindow[Window].bScrollDisabled==TRUE)break; }

1 0

[reactos] 04/04: [NTOS:KD] Move dump of stack trace on crash to debugger
by Hervé Poussineau 30 Mar '20

30 Mar '20

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=76a41370d0199c99d9857… commit 76a41370d0199c99d9857adbb3da3b9a67df5579 Author: Hervé Poussineau <hpoussin(a)reactos.org> AuthorDate: Mon Mar 30 00:03:02 2020 +0200 Commit: Hervé Poussineau <hpoussin(a)reactos.org> CommitDate: Mon Mar 30 15:23:34 2020 +0200 [NTOS:KD] Move dump of stack trace on crash to debugger Release builds now show again the bugcheck screen, instead of freezing. --- ntoskrnl/kd/kdmain.c | 3 +++ ntoskrnl/ke/bug.c | 9 --------- 2 files changed, 3 insertions(+), 9 deletions(-) diff --git a/ntoskrnl/kd/kdmain.c b/ntoskrnl/kd/kdmain.c index 25a63a1c0cb..5749cc8701d 100644 --- a/ntoskrnl/kd/kdmain.c +++ b/ntoskrnl/kd/kdmain.c @@ -277,6 +277,9 @@ KdpEnterDebuggerException(IN PKTRAP_FRAME TrapFrame, Context, TrapFrame); } + + /* We'll manually dump the stack for the user... */ + KeRosDumpStackFrames(NULL, 0); #endif /* not KDBG */ /* Debugger didn't handle it, please handle! */ diff --git a/ntoskrnl/ke/bug.c b/ntoskrnl/ke/bug.c index 7df5c21ed22..47b1f4b5ca3 100644 --- a/ntoskrnl/ke/bug.c +++ b/ntoskrnl/ke/bug.c @@ -1067,15 +1067,6 @@ KeBugCheckWithTf(IN ULONG BugCheckCode, /* Break in the debugger */ KiBugCheckDebugBreak(DBG_STATUS_BUGCHECK_FIRST); } - else - { - /* - * ROS HACK. - * Ok, so debugging is enabled, but KDBG isn't there. - * We'll manually dump the stack for the user. - */ - KeRosDumpStackFrames(NULL, 0); - } } /* Raise IRQL to HIGH_LEVEL */

1 0

[reactos] 03/04: [NTOS:KE] Remove dead code
by Hervé Poussineau 30 Mar '20

30 Mar '20

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=fd8cacae4c67cd8a9af3d… commit fd8cacae4c67cd8a9af3d1e26e7916093ac9fad6 Author: Hervé Poussineau <hpoussin(a)reactos.org> AuthorDate: Sun Mar 29 23:58:21 2020 +0200 Commit: Hervé Poussineau <hpoussin(a)reactos.org> CommitDate: Mon Mar 30 15:23:25 2020 +0200 [NTOS:KE] Remove dead code --- ntoskrnl/ke/bug.c | 71 ------------------------------------------------------- 1 file changed, 71 deletions(-) diff --git a/ntoskrnl/ke/bug.c b/ntoskrnl/ke/bug.c index a92eb9297b9..7df5c21ed22 100644 --- a/ntoskrnl/ke/bug.c +++ b/ntoskrnl/ke/bug.c @@ -294,74 +294,6 @@ KeRosDumpStackFrames(IN PULONG_PTR Frame OPTIONAL, } } -VOID -NTAPI -KeRosDumpTriageForBugZillaReport(VOID) -{ -#if 0 - extern BOOLEAN KiFastSystemCallDisable, KiSMTProcessorsPresent; - extern ULONG KeI386MachineType, MxcsrFeatureMask; - extern BOOLEAN Ke386Pae, Ke386NoExecute; - - DbgPrint("ReactOS has crashed! Please go to http://jira.reactos.org/ to file a bug!\n"); - DbgPrint("\nHardware Information\n"); - DbgPrint("Processor Architecture: %d\n" - "Feature Bits: %d\n" - "System Call Disabled: %d\n" - "NPX Present: %d\n" - "MXCsr Mask: %d\n" - "MXCsr Feature Mask: %d\n" - "XMMI Present: %d\n" - "FXSR Present: %d\n" - "Machine Type: %d\n" - "PAE: %d\n" - "NX: %d\n" - "Processors: %d\n" - "Active Processors: %d\n" - "Pentium LOCK Bug: %d\n" - "Hyperthreading: %d\n" - "CPU Manufacturer: %s\n" - "CPU Name: %wZ\n" - "CPUID: %d\n" - "CPU Type: %d\n" - "CPU Stepping: %d\n" - "CPU Speed: %d\n" - "CPU L2 Cache: %d\n" - "BIOS Date: %wZ\n" - "BIOS Version: %wZ\n" - "Video BIOS Date: %wZ\n" - "Video BIOS Version: %wZ\n" - "Memory: %d\n", - KeProcessorArchitecture, - KeFeatureBits, - KiFastSystemCallDisable, - KeI386NpxPresent, - KiMXCsrMask, - MxcsrFeatureMask, - KeI386XMMIPresent, - KeI386FxsrPresent, - KeI386MachineType, - Ke386Pae, - Ke386NoExecute, - KeNumberProcessors, - KeActiveProcessors, - KiI386PentiumLockErrataPresent, - KiSMTProcessorsPresent, - KeGetCurrentPrcb()->VendorString, - &KeRosProcessorName, - KeGetCurrentPrcb()->CpuID, - KeGetCurrentPrcb()->CpuType, - KeGetCurrentPrcb()->CpuStep, - KeGetCurrentPrcb()->MHz, - ((PKIPCR)KeGetPcr())->SecondLevelCacheSize, - &KeRosBiosDate, - &KeRosBiosVersion, - &KeRosVideoBiosDate, - &KeRosVideoBiosVersion, - MmNumberOfPhysicalPages * PAGE_SIZE); -#endif -} - VOID INIT_FUNCTION NTAPI @@ -1143,9 +1075,6 @@ KeBugCheckWithTf(IN ULONG BugCheckCode, * We'll manually dump the stack for the user. */ KeRosDumpStackFrames(NULL, 0); - - /* ROS HACK 2: Generate something useful for Bugzilla */ - KeRosDumpTriageForBugZillaReport(); } }

1 0

[reactos] 02/04: [NTOS:KD] Fix compilation with CMAKE_BUILD_TYPE=Release
by Hervé Poussineau 30 Mar '20

30 Mar '20

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=8b6e441a6e534c6b5ecf5… commit 8b6e441a6e534c6b5ecf52023b65cfd70e446e3a Author: Hervé Poussineau <hpoussin(a)reactos.org> AuthorDate: Sun Mar 29 00:30:53 2020 +0100 Commit: Hervé Poussineau <hpoussin(a)reactos.org> CommitDate: Mon Mar 30 15:23:25 2020 +0200 [NTOS:KD] Fix compilation with CMAKE_BUILD_TYPE=Release This was broken by commit a890fc64d17e7c4a09a3cbe24e0dfc972d743dda --- ntoskrnl/kd/kdio.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/ntoskrnl/kd/kdio.c b/ntoskrnl/kd/kdio.c index 4921d6af7c2..52dd45b7ccd 100644 --- a/ntoskrnl/kd/kdio.c +++ b/ntoskrnl/kd/kdio.c @@ -626,6 +626,7 @@ KdpPromptString( _In_ PSTRING PromptString, _In_ PSTRING ResponseString) { +#ifdef KDBG KIRQL OldIrql; STRING StringChar; CHAR Response; @@ -720,6 +721,7 @@ KdpPromptString( /* Print a new line */ *StringChar.Buffer = '\n'; KdpPrintString(&StringChar); +#endif /* Success; we don't need to resend */ return FALSE;

1 0

[reactos] 01/04: [NTOS:KD] Fix compilation with CMAKE_BUILD_TYPE=Release
by Hervé Poussineau 30 Mar '20

30 Mar '20

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=38e53eea4fb1850711292… commit 38e53eea4fb18507112925c32e98981e2f76c2c8 Author: Hervé Poussineau <hpoussin(a)reactos.org> AuthorDate: Sat Mar 28 23:51:03 2020 +0100 Commit: Hervé Poussineau <hpoussin(a)reactos.org> CommitDate: Mon Mar 30 15:23:25 2020 +0200 [NTOS:KD] Fix compilation with CMAKE_BUILD_TYPE=Release This was broken by commit f7ec84eea0790899ca34b79f2ec5a308204254ac --- ntoskrnl/include/internal/ntoskrnl.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/ntoskrnl/include/internal/ntoskrnl.h b/ntoskrnl/include/internal/ntoskrnl.h index b3dd74f196b..1fd0d8379c3 100644 --- a/ntoskrnl/include/internal/ntoskrnl.h +++ b/ntoskrnl/include/internal/ntoskrnl.h @@ -61,6 +61,9 @@ #include "po.h" #include "se.h" #include "ldr.h" +#ifndef _WINKD_ +#include "kd.h" +#endif #include "kd64.h" #include "fsrtl.h" #include "lpc.h"

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs March 2020