Ros-diffs September 2020

ros-diffs@reactos.org

25 participants
382 discussions

[reactos] 01/07: [CMD] Code style and formatting fixes for assoc.c and path.c

by Hermès Bélusca-Maïto

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=a5d7a2cd619853eb6ad1f… commit a5d7a2cd619853eb6ad1fb1f912eb1d69e9645a9 Author: Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org> AuthorDate: Sun Jul 26 20:29:34 2020 +0200 Commit: Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org> CommitDate: Wed Sep 23 00:22:45 2020 +0200 [CMD] Code style and formatting fixes for assoc.c and path.c --- base/shell/cmd/assoc.c | 195 +++++++++++++++++++++++++------------------------ base/shell/cmd/path.c | 26 +++---- 2 files changed, 112 insertions(+), 109 deletions(-) diff --git a/base/shell/cmd/assoc.c b/base/shell/cmd/assoc.c index 0e3d6f18f9c..a9ce5c6682a 100644 --- a/base/shell/cmd/assoc.c +++ b/base/shell/cmd/assoc.c @@ -1,20 +1,20 @@ /* - * Assoc.C - assoc internal command. + * ASSOC.C - assoc internal command. * * * History: * * 14-Mar-2009 Lee C. Baker - * - initial implementation + * - initial implementation. * * 15-Mar-2009 Lee C. Baker - * - Don't write to (or use) HKEY_CLASSES_ROOT directly - * - Externalize strings + * - Don't write to (or use) HKEY_CLASSES_ROOT directly. + * - Externalize strings. * * TODO: - * - PrintAllAssociations might could be optimized to not fetch all registry subkeys under 'Classes', just the ones that start with '.' + * - PrintAllAssociations could be optimized to not fetch all registry subkeys under 'Classes', just the ones that start with '.' * - Make sure that non-administrator users can list associations, and get appropriate error messages when they don't have sufficient - * privileges to perform an operation + * privileges to perform an operation. */ #include "precomp.h" @@ -22,37 +22,36 @@ #ifdef INCLUDE_CMD_ASSOC static INT -PrintAssociation(LPTSTR extension) +PrintAssociation( + IN LPCTSTR extension) { - DWORD return_val; - HKEY hKey = NULL, hInsideKey = NULL; - + DWORD lRet; + HKEY hKey = NULL, hSubKey = NULL; DWORD fileTypeLength = 0; LPTSTR fileType = NULL; - return_val = RegOpenKeyEx(HKEY_LOCAL_MACHINE, _T("SOFTWARE\\Classes"), 0, KEY_READ, &hKey); - - if (return_val != ERROR_SUCCESS) + lRet = RegOpenKeyEx(HKEY_LOCAL_MACHINE, _T("SOFTWARE\\Classes"), 0, KEY_READ, &hKey); + if (lRet != ERROR_SUCCESS) return -1; - return_val = RegOpenKeyEx(hKey, extension, 0, KEY_READ, &hInsideKey); + lRet = RegOpenKeyEx(hKey, extension, 0, KEY_READ, &hSubKey); RegCloseKey(hKey); - if (return_val != ERROR_SUCCESS) + if (lRet != ERROR_SUCCESS) return 0; - /* obtain string length */ - return_val = RegQueryValueEx(hInsideKey, NULL, NULL, NULL, NULL, &fileTypeLength); + /* Obtain string length */ + lRet = RegQueryValueEx(hSubKey, NULL, NULL, NULL, NULL, &fileTypeLength); - if (return_val == ERROR_FILE_NOT_FOUND) /* no default value, don't display */ + /* If there is no default value, don't display */ + if (lRet == ERROR_FILE_NOT_FOUND) { - RegCloseKey(hInsideKey); + RegCloseKey(hSubKey); return 0; } - - if (return_val != ERROR_SUCCESS) + if (lRet != ERROR_SUCCESS) { - RegCloseKey(hInsideKey); + RegCloseKey(hSubKey); return -2; } @@ -60,21 +59,22 @@ PrintAssociation(LPTSTR extension) if (!fileType) { WARN("Cannot allocate memory for fileType!\n"); - RegCloseKey(hInsideKey); + RegCloseKey(hSubKey); return -2; } - /* obtain actual file type */ - return_val = RegQueryValueEx(hInsideKey, NULL, NULL, NULL, (LPBYTE)fileType, &fileTypeLength); - RegCloseKey(hInsideKey); + /* Obtain actual file type */ + lRet = RegQueryValueEx(hSubKey, NULL, NULL, NULL, (LPBYTE)fileType, &fileTypeLength); + RegCloseKey(hSubKey); - if (return_val != ERROR_SUCCESS) + if (lRet != ERROR_SUCCESS) { cmd_free(fileType); return -2; } - if (fileTypeLength != 0) /* if there is a default key, display relevant information */ + /* If there is a default key, display relevant information */ + if (fileTypeLength != 0) { ConOutPrintf(_T("%s=%s\n"), extension, fileType); } @@ -86,7 +86,7 @@ PrintAssociation(LPTSTR extension) static INT PrintAllAssociations(VOID) { - DWORD return_val = 0; + DWORD lRet = 0; HKEY hKey = NULL; DWORD numKeys = 0; @@ -94,14 +94,13 @@ PrintAllAssociations(VOID) LPTSTR extName = NULL; DWORD keyCtr = 0; - return_val = RegOpenKeyEx(HKEY_LOCAL_MACHINE, _T("SOFTWARE\\Classes"), 0, KEY_READ, &hKey); - - if (return_val != ERROR_SUCCESS) + lRet = RegOpenKeyEx(HKEY_LOCAL_MACHINE, _T("SOFTWARE\\Classes"), 0, KEY_READ, &hKey); + if (lRet != ERROR_SUCCESS) return -1; - return_val = RegQueryInfoKey(hKey, NULL, NULL, NULL, &numKeys, &extLength, NULL, NULL, NULL, NULL, NULL, NULL); - - if (return_val != ERROR_SUCCESS) + lRet = RegQueryInfoKey(hKey, NULL, NULL, NULL, &numKeys, &extLength, + NULL, NULL, NULL, NULL, NULL, NULL); + if (lRet != ERROR_SUCCESS) { RegCloseKey(hKey); return -2; @@ -116,12 +115,13 @@ PrintAllAssociations(VOID) return -2; } - for (keyCtr = 0; keyCtr < numKeys; keyCtr++) + for (keyCtr = 0; keyCtr < numKeys; ++keyCtr) { - DWORD buffer_size = extLength; - return_val = RegEnumKeyEx(hKey, keyCtr, extName, &buffer_size, NULL, NULL, NULL, NULL); + DWORD dwBufSize = extLength; + lRet = RegEnumKeyEx(hKey, keyCtr, extName, &dwBufSize, + NULL, NULL, NULL, NULL); - if (return_val == ERROR_SUCCESS || return_val == ERROR_MORE_DATA) + if (lRet == ERROR_SUCCESS || lRet == ERROR_MORE_DATA) { if (*extName == _T('.')) PrintAssociation(extName); @@ -141,58 +141,63 @@ PrintAllAssociations(VOID) } static INT -AddAssociation(LPTSTR extension, LPTSTR type) +AddAssociation( + IN LPCTSTR extension, + IN LPCTSTR type) { - DWORD return_val; - HKEY hKey = NULL, insideKey = NULL; - - return_val = RegOpenKeyEx(HKEY_LOCAL_MACHINE, _T("SOFTWARE\\Classes"), 0, KEY_ALL_ACCESS, &hKey); + DWORD lRet; + HKEY hKey = NULL, hSubKey = NULL; - if (return_val != ERROR_SUCCESS) + lRet = RegOpenKeyEx(HKEY_LOCAL_MACHINE, _T("SOFTWARE\\Classes"), 0, KEY_ALL_ACCESS, &hKey); + if (lRet != ERROR_SUCCESS) return -1; - return_val = RegCreateKeyEx(hKey, extension, 0, NULL, REG_OPTION_NON_VOLATILE, KEY_ALL_ACCESS, NULL, &insideKey, NULL); + lRet = RegCreateKeyEx(hKey, extension, 0, NULL, REG_OPTION_NON_VOLATILE, + KEY_ALL_ACCESS, NULL, &hSubKey, NULL); RegCloseKey(hKey); - if (return_val != ERROR_SUCCESS) + if (lRet != ERROR_SUCCESS) return -1; - return_val = RegSetValueEx(insideKey, NULL, 0, REG_SZ, (LPBYTE)type, (_tcslen(type) + 1) * sizeof(TCHAR)); - RegCloseKey(insideKey); + lRet = RegSetValueEx(hSubKey, NULL, 0, REG_SZ, + (LPBYTE)type, (_tcslen(type) + 1) * sizeof(TCHAR)); + RegCloseKey(hSubKey); - if (return_val != ERROR_SUCCESS) + if (lRet != ERROR_SUCCESS) return -2; return 0; } -static int -RemoveAssociation(LPTSTR extension) +static INT +RemoveAssociation( + IN LPCTSTR extension) { - DWORD return_val; + DWORD lRet; HKEY hKey; - return_val = RegOpenKeyEx(HKEY_LOCAL_MACHINE, _T("SOFTWARE\\Classes"), 0, KEY_ALL_ACCESS, &hKey); - - if (return_val != ERROR_SUCCESS) + lRet = RegOpenKeyEx(HKEY_LOCAL_MACHINE, _T("SOFTWARE\\Classes"), 0, KEY_ALL_ACCESS, &hKey); + if (lRet != ERROR_SUCCESS) return -1; - return_val = RegDeleteKey(hKey, extension); + lRet = RegDeleteKey(hKey, extension); RegCloseKey(hKey); - if (return_val != ERROR_SUCCESS) + if (lRet != ERROR_SUCCESS) return -2; return 0; } -INT CommandAssoc (LPTSTR param) +INT CommandAssoc(LPTSTR param) { - /* print help */ - if (!_tcsncmp (param, _T("/?"), 2)) + LPTSTR lpEqualSign; + + /* Print help */ + if (!_tcsncmp(param, _T("/?"), 2)) { - ConOutResPaging(TRUE,STRING_ASSOC_HELP); + ConOutResPaging(TRUE, STRING_ASSOC_HELP); return 0; } @@ -201,47 +206,45 @@ INT CommandAssoc (LPTSTR param) if (_tcslen(param) == 0) { PrintAllAssociations(); + return 0; } - else + + lpEqualSign = _tcschr(param, _T('=')); + if (lpEqualSign != NULL) { - LPTSTR lpEqualSign = _tcschr(param, _T('=')); - if (lpEqualSign != NULL) + LPTSTR fileType = lpEqualSign + 1; + LPTSTR extension = cmd_alloc((lpEqualSign - param + 1) * sizeof(TCHAR)); + if (!extension) + { + WARN("Cannot allocate memory for extension!\n"); + error_out_of_memory(); + return 1; + } + + _tcsncpy(extension, param, lpEqualSign - param); + extension[lpEqualSign - param] = _T('\0'); + + /* If the equal sign is the last character + * in the string, then delete the key. */ + if (_tcslen(fileType) == 0) { - LPTSTR fileType = lpEqualSign + 1; - LPTSTR extension = cmd_alloc((lpEqualSign - param + 1) * sizeof(TCHAR)); - if (!extension) - { - WARN("Cannot allocate memory for extension!\n"); - error_out_of_memory(); - return 1; - } - - _tcsncpy(extension, param, lpEqualSign - param); - extension[lpEqualSign - param] = _T('\0'); - - if (_tcslen(fileType) == 0) - /* if the equal sign is the last character - in the string, then delete the key */ - { - RemoveAssociation(extension); - } - else - /* otherwise, add the key and print out the association*/ - { - AddAssociation(extension, fileType); - PrintAssociation(extension); - } - - cmd_free(extension); + RemoveAssociation(extension); } else + /* Otherwise, add the key and print out the association */ { - /* no equal sign, print all associations */ - INT retval = PrintAssociation(param); - - if (retval == 0) /* if nothing printed out */ - ConOutResPrintf(STRING_ASSOC_ERROR, param); + AddAssociation(extension, fileType); + PrintAssociation(extension); } + + cmd_free(extension); + } + else + { + /* No equal sign, print all associations */ + INT retval = PrintAssociation(param); + if (retval == 0) /* If nothing printed out */ + ConOutResPrintf(STRING_ASSOC_ERROR, param); } return 0; diff --git a/base/shell/cmd/path.c b/base/shell/cmd/path.c index 1faed8ea29c..6235b459362 100644 --- a/base/shell/cmd/path.c +++ b/base/shell/cmd/path.c @@ -29,34 +29,34 @@ #ifdef INCLUDE_CMD_PATH -/* size of environment variable buffer */ +/* Size of environment variable buffer */ #define ENV_BUFFER_SIZE 1024 -INT cmd_path (LPTSTR param) +INT cmd_path(LPTSTR param) { - if (!_tcsncmp (param, _T("/?"), 2)) + if (!_tcsncmp(param, _T("/?"), 2)) { - ConOutResPaging(TRUE,STRING_PATH_HELP1); + ConOutResPaging(TRUE, STRING_PATH_HELP1); return 0; } nErrorLevel = 0; - /* if param is empty, display the PATH environment variable */ + /* If param is empty, display the PATH environment variable */ if (!param || !*param) { DWORD dwBuffer; LPTSTR pszBuffer; - pszBuffer = (LPTSTR)cmd_alloc (ENV_BUFFER_SIZE * sizeof(TCHAR)); + pszBuffer = (LPTSTR)cmd_alloc(ENV_BUFFER_SIZE * sizeof(TCHAR)); if (!pszBuffer) { WARN("Cannot allocate memory for pszBuffer!\n"); return 1; } - dwBuffer = GetEnvironmentVariable (_T("PATH"), pszBuffer, ENV_BUFFER_SIZE); + dwBuffer = GetEnvironmentVariable(_T("PATH"), pszBuffer, ENV_BUFFER_SIZE); if (dwBuffer == 0) { cmd_free(pszBuffer); @@ -66,28 +66,28 @@ INT cmd_path (LPTSTR param) else if (dwBuffer > ENV_BUFFER_SIZE) { LPTSTR pszOldBuffer = pszBuffer; - pszBuffer = (LPTSTR)cmd_realloc (pszBuffer, dwBuffer * sizeof (TCHAR)); + pszBuffer = (LPTSTR)cmd_realloc(pszBuffer, dwBuffer * sizeof (TCHAR)); if (!pszBuffer) { WARN("Cannot reallocate memory for pszBuffer!\n"); cmd_free(pszOldBuffer); return 1; } - GetEnvironmentVariable (_T("PATH"), pszBuffer, dwBuffer); + GetEnvironmentVariable(_T("PATH"), pszBuffer, dwBuffer); } ConOutPrintf(_T("PATH=%s\n"), pszBuffer); - cmd_free (pszBuffer); + cmd_free(pszBuffer); return 0; } - /* skip leading '=' */ + /* Skip leading '=' */ if (*param == _T('=')) param++; - /* set PATH environment variable */ - if (!SetEnvironmentVariable (_T("PATH"), param)) + /* Set PATH environment variable */ + if (!SetEnvironmentVariable(_T("PATH"), param)) { nErrorLevel = 1; return 1;

3 years, 12 months

[reactos] 01/01: [CMD_ROSTEST] Add tests for the FOR /F "tokens=" command. See commit 0695ecbf.

by Hermès Bélusca-Maïto

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=69258973e034168a609c3… commit 69258973e034168a609c37f112c15288774fb75e Author: Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org> AuthorDate: Tue Sep 22 23:02:55 2020 +0200 Commit: Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org> CommitDate: Tue Sep 22 23:08:13 2020 +0200 [CMD_ROSTEST] Add tests for the FOR /F "tokens=" command. See commit 0695ecbf. --- modules/rostests/win32/cmd/test_builtins.cmd | 39 ++++++++++++++++++++++++ modules/rostests/win32/cmd/test_builtins.cmd.exp | 16 ++++++++++ 2 files changed, 55 insertions(+) diff --git a/modules/rostests/win32/cmd/test_builtins.cmd b/modules/rostests/win32/cmd/test_builtins.cmd index 9d03f175dc6..7e232ca7ca6 100644 --- a/modules/rostests/win32/cmd/test_builtins.cmd +++ b/modules/rostests/win32/cmd/test_builtins.cmd @@ -33,6 +33,45 @@ N, O ) do echo %%j +echo --- FOR /F token parsing +:: This test requires extensions being enabled +setlocal enableextensions + +set TEST_STRING="_ ` a b c d e f g h i j k l m n o p q r s t u v w x y z { | } ~ ? @ [ \ ] _ ` a b c d e f g h i j k l m n o p q r s t u v w x y z { | } ~ ? @ [ \ ]" +set "ECHO_STRING=?=%%? @=%%@ A=%%A B=%%B C=%%C D=%%D E=%%E F=%%F G=%%G H=%%H I=%%I J=%%J K=%%K L=%%L M=%%M N=%%N O=%%O P=%%P Q=%%Q R=%%R S=%%S T=%%T U=%%U V=%%V W=%%W X=%%X Y=%%Y Z=%%Z [=%%[ \=%%\ ]=%%] ^^=%%^^ _=%%_ `=%%` a=%%a b=%%b c=%%c d=%%d e=%%e f=%%f g=%%g h=%%h i=%%i j=%%j k=%%k l=%%l m=%%m n=%%n o=%%o p=%%p q=%%q r=%%r s=%%s t=%%t u=%%u v=%%v w=%%w x=%%x y=%%y z=%%z {=%%{ ^|=%%^| }=%%} ^~=%%^~" + +echo. + +:: Bug 1: Ranges that are not specified in increasing order are ignored. +:: Token numbers strictly greater than 31 are just ignored, and if they +:: appear in a range, the whole range is ignored. + +for /f "tokens=30-32" %%? in (%TEST_STRING%) do echo %ECHO_STRING% +echo. +for /f "tokens=5-1" %%? in (%TEST_STRING%) do echo %ECHO_STRING% +echo. + +:: Bug 2: Ranges that partially overlap: too many variables are being allocated, +:: while only a subset is actually used. This leads to the extra variables returning +:: empty strings. + +for /f "tokens=1-31,31,31" %%? in (%TEST_STRING%) do echo %ECHO_STRING% +echo. +for /f "tokens=1-31,1-31" %%? in (%TEST_STRING%) do echo %ECHO_STRING% +echo. +for /f "tokens=1-5,3,5,6" %%? in (%TEST_STRING%) do echo %ECHO_STRING% +echo. +for /f "tokens=1-31,* tokens=1-31 tokens=1-20,*" %%? in (%TEST_STRING%) do echo %ECHO_STRING% +echo. + +:: For comparison, this works: +for /f "tokens=1-5,6" %%? in (%TEST_STRING%) do echo %ECHO_STRING% +echo. +for /f "tokens=1-5,6-10" %%? in (%TEST_STRING%) do echo %ECHO_STRING% +echo. + +endlocal + echo ---------- Testing AND operator ---------- :: Test for TRUE condition - Should be displayed diff --git a/modules/rostests/win32/cmd/test_builtins.cmd.exp b/modules/rostests/win32/cmd/test_builtins.cmd.exp index e2d609e8e03..98f084e90a4 100644 --- a/modules/rostests/win32/cmd/test_builtins.cmd.exp +++ b/modules/rostests/win32/cmd/test_builtins.cmd.exp @@ -19,6 +19,22 @@ I %j %j %j +--- FOR /F token parsing + + + +?=_ @=` A=a B=b C=c D=d E=e F=f G=g H=h I=i J=j K=k L=l M=m N=n O=o P=p Q=q R=r S=s T=t U=u V=v W=w X=x Y=y Z=z [={ \=| ]=} ^= _= `=%` a=%a b=%b c=%c d=%d e=%e f=%f g=%g h=%h i=%i j=%j k=%k l=%l m=%m n=%n o=%o p=%p q=%q r=%r s=%s t=%t u=%u v=%v w=%w x=%x y=%y z=%z {=%{ |=%| }=%} ~=%~ + +?=_ @=` A=a B=b C=c D=d E=e F=f G=g H=h I=i J=j K=k L=l M=m N=n O=o P=p Q=q R=r S=s T=t U=u V=v W=w X=x Y=y Z=z [={ \=| ]=} ^= _= `= a= b= c= d= e= f= g= h= i= j= k= l= m= n= o= p= q= r= s= t= u= v= w= x= y= z= {= |= }=%} ~=%~ + +?=_ @=` A=a B=b C=c D=d E= F= G=%G H=%H I=%I J=%J K=%K L=%L M=%M N=%N O=%O P=%P Q=%Q R=%R S=%S T=%T U=%U V=%V W=%W X=%X Y=%Y Z=%Z [=%[ \=%\ ]=%] ^=%^ _=%_ `=%` a=%a b=%b c=%c d=%d e=%e f=%f g=%g h=%h i=%i j=%j k=%k l=%l m=%m n=%n o=%o p=%p q=%q r=%r s=%s t=%t u=%u v=%v w=%w x=%x y=%y z=%z {=%{ |=%| }=%} ~=%~ + +?=_ @=` A=a B=b C=c D=d E=e F=f G=g H=h I=i J=j K=k L=l M=m N=n O=o P=p Q=q R=r S=s t u v w x y z { | } ~ ? @ [ \ ] _ ` a b c d e f g h i j k l m n o p q r s t u v w x y z { | } ~ ? @ [ \ ] T= U= V= W= X= Y= Z= [= \= ]= ^= _=%_ `=%` a=%a b=%b c=%c d=%d e=%e f=%f g=%g h=%h i=%i j=%j k=%k l=%l m=%m n=%n o=%o p=%p q=%q r=%r s=%s t=%t u=%u v=%v w=%w x=%x y=%y z=%z {=%{ |=%| }=%} ~=%~ + +?=_ @=` A=a B=b C=c D=d E=%E F=%F G=%G H=%H I=%I J=%J K=%K L=%L M=%M N=%N O=%O P=%P Q=%Q R=%R S=%S T=%T U=%U V=%V W=%W X=%X Y=%Y Z=%Z [=%[ \=%\ ]=%] ^=%^ _=%_ `=%` a=%a b=%b c=%c d=%d e=%e f=%f g=%g h=%h i=%i j=%j k=%k l=%l m=%m n=%n o=%o p=%p q=%q r=%r s=%s t=%t u=%u v=%v w=%w x=%x y=%y z=%z {=%{ |=%| }=%} ~=%~ + +?=_ @=` A=a B=b C=c D=d E=e F=f G=g H=h I=%I J=%J K=%K L=%L M=%M N=%N O=%O P=%P Q=%Q R=%R S=%S T=%T U=%U V=%V W=%W X=%X Y=%Y Z=%Z [=%[ \=%\ ]=%] ^=%^ _=%_ `=%` a=%a b=%b c=%c d=%d e=%e f=%f g=%g h=%h i=%i j=%j k=%k l=%l m=%m n=%n o=%o p=%p q=%q r=%r s=%s t=%t u=%u v=%v w=%w x=%x y=%y z=%z {=%{ |=%| }=%} ~=%~ + ---------- Testing AND operator ---------- TRUE AND condition ---------- Testing OR operator -----------

3 years, 12 months

[reactos] 01/01: [IPHLPAPI] Fix for hasArp which crashes some iphlpapi tests. (#3216)

by Doug Lyons

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=90be2f4e1b139daef408b… commit 90be2f4e1b139daef408ba1472532ae8bbbc4f2b Author: Doug Lyons <douglyons(a)douglyons.com> AuthorDate: Tue Sep 22 08:50:41 2020 -0500 Commit: GitHub <noreply(a)github.com> CommitDate: Tue Sep 22 15:50:41 2020 +0200 [IPHLPAPI] Fix for hasArp which crashes some iphlpapi tests. (#3216) CORE-16513 --- dll/win32/iphlpapi/ifenum_reactos.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/dll/win32/iphlpapi/ifenum_reactos.c b/dll/win32/iphlpapi/ifenum_reactos.c index 77fe4cf73d3..cff14cdfe5c 100644 --- a/dll/win32/iphlpapi/ifenum_reactos.c +++ b/dll/win32/iphlpapi/ifenum_reactos.c @@ -149,7 +149,8 @@ BOOL hasArp( HANDLE tcpFile, TDIEntityID *arp_maybe ) { NULL ); if( !NT_SUCCESS(status) ) return FALSE; - return (type & AT_ARP); + /* AT_ARP corresponds to an individual TDI entity type */ + return (type == AT_ARP); } static NTSTATUS getInterfaceInfoSet( HANDLE tcpFile,

3 years, 12 months

[reactos] 01/01: [PORTCLS] Fix audio stutter with official AC97 driver (#3225)

by Michael Stamper

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=e45bacda07bd73be9e630… commit e45bacda07bd73be9e630fcd795640ad978c2c54 Author: Michael Stamper <michaelstamper1(a)gmail.com> AuthorDate: Tue Sep 22 13:49:34 2020 +0000 Commit: GitHub <noreply(a)github.com> CommitDate: Tue Sep 22 15:49:34 2020 +0200 [PORTCLS] Fix audio stutter with official AC97 driver (#3225) Replace call to AllocatedBufferSize(), with BufferSize(). Indeed (quoting https://docs.microsoft.com/en-us/windows-hardware/drivers/ddi/portcls/nf-po… ): > The BufferSize() method returns the buffer size that was set by the previous call to IDmaChannel::SetBufferSize(). If SetBufferSize() has not been called since the IDmaChannel::AllocateBuffer() call, BufferSize returns the allocated buffer size. The DMA-channel object does not actually use this value internally. This value is maintained by the object to **allow its various clients to communicate the intended size of the buffer**. And this is exactly what we want to do. --- drivers/wdm/audio/backpln/portcls/pin_wavecyclic.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/wdm/audio/backpln/portcls/pin_wavecyclic.cpp b/drivers/wdm/audio/backpln/portcls/pin_wavecyclic.cpp index e57fbefda74..31d787d08b0 100644 --- a/drivers/wdm/audio/backpln/portcls/pin_wavecyclic.cpp +++ b/drivers/wdm/audio/backpln/portcls/pin_wavecyclic.cpp @@ -1300,7 +1300,7 @@ CPortPinWaveCyclic::Init( m_Stream->SetState(KSSTATE_STOP); m_State = KSSTATE_STOP; m_CommonBufferOffset = 0; - m_CommonBufferSize = m_DmaChannel->AllocatedBufferSize(); + m_CommonBufferSize = m_DmaChannel->BufferSize(); m_CommonBuffer = m_DmaChannel->SystemAddress(); m_Capture = Capture; // delay of 10 millisec

3 years, 12 months

[reactos] 02/02: [CMD] FOR: Additional Windows' CMD compatibility "fixes" for FOR /F token parsing command.

by Hermès Bélusca-Maïto

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=0695ecbfd641306f9912a… commit 0695ecbfd641306f9912af865010dbb0ccf20fbd Author: Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org> AuthorDate: Sun Jul 26 20:15:25 2020 +0200 Commit: Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org> CommitDate: Mon Sep 21 03:31:01 2020 +0200 [CMD] FOR: Additional Windows' CMD compatibility "fixes" for FOR /F token parsing command. This compatibility behaviour implements the buggy behaviour of FOR /F token parsing that can be observed in Windows' CMD, and that is tested by the cmd_winetests. It can be disabled at compile time via the MSCMD_FOR_QUIRKS define. It fixes additional cmd_winetests, in concert with commit cb2a9c31. Explanation of the implemented buggy behaviour ============================================== In principle, the "tokens=x,y,m-n[*]" option describes a list of token numbers (must be between 1 and 31) that will be assigned into variables. Theoretically this option does not cumulate: only the latest 'tokens=' specification should be taken into account. However things are not that simple in practice. First, not all of the "tokens=" option state is reset when more than one specification is provided. Second, when specifying a token range, e.g. "1-5", Windows' CMD just ignores without error ranges that are not specified in increasing order. Thus for example, a range "5-1" is ignored without error. Then, token numbers strictly greater than 31 are just ignored, and if they appear in a range, the whole range is ignored. Another bug is the following one: suppose that the 'tokens' specification reads: "tokens=1-5,1-30" , or: "tokens=1-5,3" , i.e. more than one range, that overlap partially. Then the actual total number of variables will not be of the larger range size, but will be the sum, instead. Thus, in the first example, a total of 5 + 30 == 35 variables (> 31) is allocated, while in the second example, a total of 5 + 1 == 6 variables is allocated, even if they won't all store data !! In the first example, only the first 30 FOR variables will be used, and the 5 others will contain an empty string. In the second example, only the first 5 FOR variables will be used, and the other one will be empty. We also see that due to that, the "Variables" buffer of fixed size cannot always be used (since it can contain at most 32 variables). Last but not least, when more than one "tokens=" specification is provided, for example: "tokens=1-31 tokens=1-20" a total number of 31 FOR variables (because 31 is the max of 31 and 20) is allocated, **but** only 20 are actually used, and the 11 others return an empty string. And in the specification: "tokens=1-31,* tokens=1-20", a total of 31 + 1 + 20 = 52 variables is initialized, but only the first 20 will be used, and no "remaining-line" token (the '*' one) is used. --- base/shell/cmd/for.c | 165 +++++++++++++++++++++++++++++++++++++++++---------- 1 file changed, 135 insertions(+), 30 deletions(-) diff --git a/base/shell/cmd/for.c b/base/shell/cmd/for.c index 300588bed31..151be0ca2c8 100644 --- a/base/shell/cmd/for.c +++ b/base/shell/cmd/for.c @@ -32,6 +32,10 @@ #include "precomp.h" +/* Enable this define for "buggy" Windows' CMD FOR-command compatibility. + * Currently, this enables the buggy behaviour of FOR /F token parsing. */ +#define MSCMD_FOR_QUIRKS + /* FOR is a special command, so this function is only used for showing help now */ INT cmd_for(LPTSTR param) @@ -121,23 +125,27 @@ static LPTSTR ReadFileContents(FILE *InputFile, TCHAR *Buffer) static INT ForF(PARSED_COMMAND *Cmd, LPTSTR List, TCHAR *Buffer) { LPTSTR Delims = _T(" \t"); - LPTSTR DelimsEndPtr = NULL; + PTCHAR DelimsEndPtr = NULL; TCHAR DelimsEndChr = _T('\0'); TCHAR Eol = _T(';'); INT SkipLines = 0; - DWORD Tokens = (1 << 1); - BOOL RemainderVar = FALSE; + DWORD TokensMask = (1 << 1); +#ifdef MSCMD_FOR_QUIRKS + DWORD NumTokens = 1; + DWORD RemainderVar = 0; +#else + DWORD NumTokens = 0; +#endif TCHAR StringQuote = _T('"'); TCHAR CommandQuote = _T('\''); LPTSTR Variables[32]; - TCHAR *Start, *End; - INT i; + PTCHAR Start, End; INT Ret = 0; if (Cmd->For.Params) { TCHAR Quote = 0; - TCHAR *Param = Cmd->For.Params; + PTCHAR Param = Cmd->For.Params; if (*Param == _T('"') || *Param == _T('\'')) Quote = *Param++; @@ -161,7 +169,7 @@ static INT ForF(PARSED_COMMAND *Cmd, LPTSTR List, TCHAR *Buffer) { if (*Param == _T(' ')) { - TCHAR *FirstSpace = Param; + PTCHAR FirstSpace = Param; Param += _tcsspn(Param, _T(" ")); /* Exclude trailing spaces if this is not the last parameter */ if (*Param && *Param != Quote) @@ -197,24 +205,59 @@ static INT ForF(PARSED_COMMAND *Cmd, LPTSTR List, TCHAR *Buffer) } else if (_tcsnicmp(Param, _T("tokens="), 7) == 0) { +#ifdef MSCMD_FOR_QUIRKS + DWORD NumToksInSpec = 0; // Number of tokens in this specification. +#endif Param += 7; - /* tokens=x,y,m-n: List of token numbers (must be between - * 1 and 31) that will be assigned into variables. */ - Tokens = 0; + /* + * tokens=x,y,m-n: List of token numbers (must be between 1 and 31) + * that will be assigned into variables. This option does not cumulate: + * only the latest 'tokens=' specification is taken into account. + * + * NOTE: In MSCMD_FOR_QUIRKS mode, for Windows' CMD compatibility, + * not all the tokens-state is reset. This leads to subtle bugs. + */ + TokensMask = 0; +#ifdef MSCMD_FOR_QUIRKS + NumToksInSpec = 0; + // Windows' CMD compatibility: bug: the asterisk-token's position is not reset! + // RemainderVar = 0; +#else + NumTokens = 0; +#endif + while (*Param && *Param != Quote && *Param != _T('*')) { INT First = _tcstol(Param, &Param, 0); INT Last = First; +#ifdef MSCMD_FOR_QUIRKS if (First < 1) +#else + if ((First < 1) || (First > 31)) +#endif goto error; if (*Param == _T('-')) { /* It's a range of tokens */ Last = _tcstol(Param + 1, &Param, 0); - if (Last < First || Last > 31) +#ifdef MSCMD_FOR_QUIRKS + /* Ignore the range if the endpoints are not in correct order */ + if (Last < 1) +#else + if ((Last < First) || (Last > 31)) +#endif goto error; } - Tokens |= (2 << Last) - (1 << First); +#ifdef MSCMD_FOR_QUIRKS + /* Ignore the range if the endpoints are not in correct order */ + if ((First <= Last) && (Last <= 31)) + { +#endif + TokensMask |= (2 << Last) - (1 << First); +#ifdef MSCMD_FOR_QUIRKS + NumToksInSpec += (Last - First + 1); + } +#endif if (*Param != _T(',')) break; @@ -222,12 +265,19 @@ static INT ForF(PARSED_COMMAND *Cmd, LPTSTR List, TCHAR *Buffer) } /* With an asterisk at the end, an additional variable * will be created to hold the remainder of the line - * (after the last token specified). */ + * (after the last specified token). */ if (*Param == _T('*')) { - RemainderVar = TRUE; +#ifdef MSCMD_FOR_QUIRKS + RemainderVar = ++NumToksInSpec; +#else + ++NumTokens; +#endif Param++; } +#ifdef MSCMD_FOR_QUIRKS + NumTokens = max(NumTokens, NumToksInSpec); +#endif } else if (_tcsnicmp(Param, _T("useback"), 7) == 0) { @@ -248,12 +298,31 @@ static INT ForF(PARSED_COMMAND *Cmd, LPTSTR List, TCHAR *Buffer) } } +#ifdef MSCMD_FOR_QUIRKS + /* Windows' CMD compatibility: use the wrongly evaluated number of tokens */ + fc->varcount = NumTokens; + /* Allocate a large enough variables array if needed */ + if (NumTokens <= ARRAYSIZE(Variables)) + { + fc->values = Variables; + } + else + { + fc->values = cmd_alloc(fc->varcount * sizeof(*fc->values)); + if (!fc->values) + { + error_out_of_memory(); + return 1; + } + } +#else /* Count how many variables will be set: one for each token, - * plus maybe one for the remainder */ - fc->varcount = RemainderVar; - for (i = 1; i < 32; i++) - fc->varcount += (Tokens >> i & 1); + * plus maybe one for the remainder. */ + fc->varcount = NumTokens; + for (NumTokens = 1; NumTokens < 32; ++NumTokens) + fc->varcount += (TokensMask >> NumTokens) & 1; fc->values = Variables; +#endif if (*List == StringQuote || *List == CommandQuote) { @@ -267,7 +336,7 @@ static INT ForF(PARSED_COMMAND *Cmd, LPTSTR List, TCHAR *Buffer) End = List; while (!ExitingOrGoto(Cmd) && GetNextElement(&Start, &End)) { - FILE *InputFile; + FILE* InputFile; LPTSTR FullInput, In, NextLine; INT Skip; single_element: @@ -280,13 +349,18 @@ static INT ForF(PARSED_COMMAND *Cmd, LPTSTR List, TCHAR *Buffer) } else if (*Start == CommandQuote && End[-1] == CommandQuote) { - /* Read input from a command */ + /* + * Read input from a command. We let the CRT do the ANSI/UNICODE conversion. + * NOTE: Should we do that, or instead read in binary mode and + * do the conversion by ourselves, using *OUR* current codepage?? + */ End[-1] = _T('\0'); InputFile = _tpopen(Start + 1, _T("r")); if (!InputFile) { error_bad_command(Start + 1); - return 1; + Ret = 1; + goto Quit; } FullInput = ReadFileContents(InputFile, Buffer); _pclose(InputFile); @@ -302,7 +376,8 @@ static INT ForF(PARSED_COMMAND *Cmd, LPTSTR List, TCHAR *Buffer) if (!InputFile) { error_sfile_not_found(Start); - return 1; + Ret = 1; + goto Quit; } FullInput = ReadFileContents(InputFile, Buffer); fclose(InputFile); @@ -311,7 +386,8 @@ static INT ForF(PARSED_COMMAND *Cmd, LPTSTR List, TCHAR *Buffer) if (!FullInput) { error_out_of_memory(); - return 1; + Ret = 1; + goto Quit; } /* Patch the delimiters string */ @@ -326,8 +402,13 @@ static INT ForF(PARSED_COMMAND *Cmd, LPTSTR List, TCHAR *Buffer) !ExitingOrGoto(Cmd) && (In != NULL); In = NextLine) { - DWORD RemainingTokens = Tokens; - LPTSTR *CurVar = Variables; + DWORD RemainingTokens = TokensMask; + LPTSTR* CurVar = fc->values; + + ZeroMemory(fc->values, fc->varcount * sizeof(*fc->values)); +#ifdef MSCMD_FOR_QUIRKS + NumTokens = fc->varcount; +#endif NextLine = _tcschr(In, _T('\n')); if (NextLine) @@ -341,11 +422,19 @@ static INT ForF(PARSED_COMMAND *Cmd, LPTSTR List, TCHAR *Buffer) if (*In == Eol) continue; - while ((RemainingTokens >>= 1) != 0) + /* Loop as long as we have not reached the end of + * the line, and that we have tokens available. + * A maximum of 31 tokens will be enumerated. */ + while (*In && ((RemainingTokens >>= 1) != 0)) { /* Save pointer to this token in a variable if requested */ if (RemainingTokens & 1) + { +#ifdef MSCMD_FOR_QUIRKS + --NumTokens; +#endif *CurVar++ = In; + } /* Find end of token */ In += _tcscspn(In, Delims); /* NULL-terminate it and advance to next token */ @@ -355,11 +444,21 @@ static INT ForF(PARSED_COMMAND *Cmd, LPTSTR List, TCHAR *Buffer) In += _tcsspn(In, Delims); } } - /* Save pointer to remainder of line */ - *CurVar = In; - /* Don't run unless the line had enough tokens to fill at least one variable */ - if (*Variables[0]) + /* Save pointer to remainder of the line if we need to do so */ + if (*In) +#ifdef MSCMD_FOR_QUIRKS + if (RemainderVar && (fc->varcount - NumTokens + 1 == RemainderVar)) +#endif + { + /* NOTE: This sets fc->values[0] at least, if no tokens + * were initialized so far, since CurVar is initialized + * originally to point to fc->values. */ + *CurVar = In; + } + + /* Don't run unless we have at least one variable filled */ + if (fc->values[0]) Ret = RunInstance(Cmd); } @@ -370,6 +469,12 @@ static INT ForF(PARSED_COMMAND *Cmd, LPTSTR List, TCHAR *Buffer) cmd_free(FullInput); } +Quit: +#ifdef MSCMD_FOR_QUIRKS + if (fc->values && (fc->values != Variables)) + cmd_free(fc->values); +#endif + return Ret; }

3 years, 12 months

[reactos] 01/02: [CMD] IF: Fix x64 warning C4267.

by Hermès Bélusca-Maïto

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=e904471023214afbf66a0… commit e904471023214afbf66a0177700d95a670145c75 Author: Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org> AuthorDate: Sat Sep 19 20:57:35 2020 +0200 Commit: Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org> CommitDate: Mon Sep 21 03:31:01 2020 +0200 [CMD] IF: Fix x64 warning C4267. --- base/shell/cmd/if.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/base/shell/cmd/if.c b/base/shell/cmd/if.c index e219a3db225..a8426e1367a 100644 --- a/base/shell/cmd/if.c +++ b/base/shell/cmd/if.c @@ -113,7 +113,7 @@ INT ExecuteIf(PARSED_COMMAND *Cmd) else if (Cmd->If.Operator == IF_EXIST) { BOOL IsDir; - INT Size; + SIZE_T Size; WIN32_FIND_DATA f; HANDLE hFind; DWORD attrs;

3 years, 12 months

[reactos] 15/15: [NTOS:PS] On x64 don't fail in NtSetInformationProcess with ProcessUserModeIOPL information class, instead just don't do anything.

by Timo Kreuzer

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=cb22d5f697187d013ce85… commit cb22d5f697187d013ce85f3126ef723809aef56a Author: Timo Kreuzer <timo.kreuzer(a)reactos.org> AuthorDate: Sun Feb 11 11:26:51 2018 +0100 Commit: Timo Kreuzer <timo.kreuzer(a)reactos.org> CommitDate: Sun Sep 20 23:08:17 2020 +0200 [NTOS:PS] On x64 don't fail in NtSetInformationProcess with ProcessUserModeIOPL information class, instead just don't do anything. For NT6+ appcompat setting return STATUS_NOT_IMPLEMENTED --- ntoskrnl/include/internal/rtl.h | 5 +++++ ntoskrnl/ps/query.c | 9 +++++++++ sdk/lib/rtl/process.c | 17 +++++++++++++++++ 3 files changed, 31 insertions(+) diff --git a/ntoskrnl/include/internal/rtl.h b/ntoskrnl/include/internal/rtl.h index c38886c7cab..80e363c7acd 100644 --- a/ntoskrnl/include/internal/rtl.h +++ b/ntoskrnl/include/internal/rtl.h @@ -34,4 +34,9 @@ RtlFindCharInUnicodeString( _Out_ PUSHORT Position ); +_IRQL_requires_max_(APC_LEVEL) +ULONG +NTAPI +RtlRosGetAppcompatVersion(VOID); + /* EOF */ diff --git a/ntoskrnl/ps/query.c b/ntoskrnl/ps/query.c index 31275a5247f..5e340c7ccdf 100644 --- a/ntoskrnl/ps/query.c +++ b/ntoskrnl/ps/query.c @@ -1902,6 +1902,15 @@ NtSetInformationProcess(IN HANDLE ProcessHandle, /* Only supported on x86 */ #if defined (_X86_) Ke386SetIOPL(); +#elif defined(_M_AMD64) + /* On x64 this function isn't implemented. + On Windows 2003 it returns success. + On Vista+ it returns STATUS_NOT_IMPLEMENTED. */ + if ((ExGetPreviousMode() != KernelMode) && + (RtlRosGetAppcompatVersion() > _WIN32_WINNT_WS03)) + { + Status = STATUS_NOT_IMPLEMENTED; + } #else Status = STATUS_NOT_IMPLEMENTED; #endif diff --git a/sdk/lib/rtl/process.c b/sdk/lib/rtl/process.c index 444c6cc2018..637046ba8a9 100644 --- a/sdk/lib/rtl/process.c +++ b/sdk/lib/rtl/process.c @@ -493,3 +493,20 @@ RtlGetCurrentProcessorNumber(VOID) /* Forward to kernel */ return NtGetCurrentProcessorNumber(); } + +_IRQL_requires_max_(APC_LEVEL) +ULONG +NTAPI +RtlRosGetAppcompatVersion(VOID) +{ + /* Get the current PEB */ + PPEB Peb = RtlGetCurrentPeb(); + if (Peb == NULL) + { + /* Default to Server 2003 */ + return _WIN32_WINNT_WS03; + } + + /* Calculate OS version from PEB fields */ + return (Peb->OSMajorVersion << 8) | Peb->OSMinorVersion; +}

3 years, 12 months

[reactos] 14/15: [NTOS:MM] Fix MiSubsectionPteToSubsection

by Timo Kreuzer

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=26484eea9fcc0a56a2c00… commit 26484eea9fcc0a56a2c004090f8b28aa4a5db96a Author: Timo Kreuzer <timo.kreuzer(a)reactos.org> AuthorDate: Fri Sep 11 17:52:24 2020 +0200 Commit: Timo Kreuzer <timo.kreuzer(a)reactos.org> CommitDate: Sun Sep 20 23:08:17 2020 +0200 [NTOS:MM] Fix MiSubsectionPteToSubsection --- ntoskrnl/include/internal/amd64/mm.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ntoskrnl/include/internal/amd64/mm.h b/ntoskrnl/include/internal/amd64/mm.h index 0131817d4cf..bfc4a4b68d1 100644 --- a/ntoskrnl/include/internal/amd64/mm.h +++ b/ntoskrnl/include/internal/amd64/mm.h @@ -252,9 +252,10 @@ MiPxeToAddress(PMMPTE PointerPxe) // // Decodes a Prototype PTE into the underlying PTE +// The 48 bit signed value gets sign-extended to 64 bits. // #define MiSubsectionPteToSubsection(x) \ - (PMMPTE)((x)->u.Subsect.SubsectionAddress >> 16) + (PMMPTE)((LONG64)(x)->u.Subsect.SubsectionAddress) FORCEINLINE VOID

3 years, 12 months

[reactos] 13/15: [NTOS:MM] Call MiSessionAddProcess() from MmCreateProcess() like on x86

by Timo Kreuzer

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=896d090ee6537872faa0e… commit 896d090ee6537872faa0e173a4d9436773f84f0c Author: Timo Kreuzer <timo.kreuzer(a)reactos.org> AuthorDate: Mon Feb 12 19:25:08 2018 +0100 Commit: Timo Kreuzer <timo.kreuzer(a)reactos.org> CommitDate: Sun Sep 20 23:08:17 2020 +0200 [NTOS:MM] Call MiSessionAddProcess() from MmCreateProcess() like on x86 --- ntoskrnl/mm/amd64/page.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/ntoskrnl/mm/amd64/page.c b/ntoskrnl/mm/amd64/page.c index fb00e41bb96..afae9827191 100644 --- a/ntoskrnl/mm/amd64/page.c +++ b/ntoskrnl/mm/amd64/page.c @@ -713,6 +713,8 @@ MmCreateProcessAddressSpace(IN ULONG MinWs, ASSERT(Process->AddressSpaceInitialized == 0); Process->AddressSpaceInitialized = 1; + /* Add the process to the session */ + MiSessionAddProcess(Process); return TRUE; }

3 years, 12 months

[reactos] 12/15: [NTOS:MM] In the x64 version of MmCreateProcessAddressSpace() zero out all page table PFNs

by Timo Kreuzer

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=bebcda0b0b57ab1c7fe09… commit bebcda0b0b57ab1c7fe092c5157c0f627e2b009b Author: Timo Kreuzer <timo.kreuzer(a)reactos.org> AuthorDate: Mon Jan 29 12:34:45 2018 +0100 Commit: Timo Kreuzer <timo.kreuzer(a)reactos.org> CommitDate: Sun Sep 20 23:08:17 2020 +0200 [NTOS:MM] In the x64 version of MmCreateProcessAddressSpace() zero out all page table PFNs --- ntoskrnl/mm/amd64/page.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/ntoskrnl/mm/amd64/page.c b/ntoskrnl/mm/amd64/page.c index c5f6158d813..fb00e41bb96 100644 --- a/ntoskrnl/mm/amd64/page.c +++ b/ntoskrnl/mm/amd64/page.c @@ -626,8 +626,11 @@ MmCreateProcessAddressSpace(IN ULONG MinWs, /* Release PFN lock */ MiReleasePfnLock(OldIrql); - /* Zero pages */ /// FIXME: + /* Zero pages */ + MiZeroPhysicalPage(TableBasePfn); MiZeroPhysicalPage(HyperPfn); + MiZeroPhysicalPage(HyperPdPfn); + MiZeroPhysicalPage(HyperPtPfn); MiZeroPhysicalPage(WorkingSetPfn); /* Set the base directory pointers */

3 years, 12 months

← Newer
1
2
3
4
5
6
7
8
9
...
39
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs September 2020