Ros-diffs February 2021

ros-diffs@reactos.org

30 participants
434 discussions

[reactos] 01/01: [NTOS:MM] Properly handle the 1-offset of paging files

by Jérôme Gardou

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=857dd4ae36a55f8dcf122… commit 857dd4ae36a55f8dcf122d904ee6993199909d8a Author: Jérôme Gardou <jerome.gardou(a)reactos.org> AuthorDate: Mon Dec 7 10:22:28 2020 +0100 Commit: Jérôme Gardou <jerome.gardou(a)reactos.org> CommitDate: Tue Feb 2 10:17:28 2021 +0100 [NTOS:MM] Properly handle the 1-offset of paging files --- ntoskrnl/mm/pagefile.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/ntoskrnl/mm/pagefile.c b/ntoskrnl/mm/pagefile.c index b7d8c83e54e..37870520998 100644 --- a/ntoskrnl/mm/pagefile.c +++ b/ntoskrnl/mm/pagefile.c @@ -189,7 +189,7 @@ NTSTATUS NTAPI MmReadFromSwapPage(SWAPENTRY SwapEntry, PFN_NUMBER Page) { - return MiReadPageFile(Page, FILE_FROM_ENTRY(SwapEntry), OFFSET_FROM_ENTRY(SwapEntry) - 1); + return MiReadPageFile(Page, FILE_FROM_ENTRY(SwapEntry), OFFSET_FROM_ENTRY(SwapEntry)); } NTSTATUS @@ -215,6 +215,9 @@ MiReadPageFile( return(STATUS_UNSUCCESSFUL); } + /* Normalize offset. */ + PageFileOffset--; + ASSERT(PageFileIndex < MAX_PAGING_FILES); PagingFile = MmPagingFile[PageFileIndex];

3 years, 7 months

[reactos] 01/01: [KMTEST:NTOS_CC] Fix buffer size calculation

by Jérôme Gardou

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=a46ee7dafe39defcecdf8… commit a46ee7dafe39defcecdf812aed8d09cfab6f5e4e Author: Jérôme Gardou <jerome.gardou(a)reactos.org> AuthorDate: Mon Feb 1 10:42:37 2021 +0100 Commit: Jérôme Gardou <jerome.gardou(a)reactos.org> CommitDate: Tue Feb 2 10:15:19 2021 +0100 [KMTEST:NTOS_CC] Fix buffer size calculation --- modules/rostests/kmtests/ntos_cc/CcSetFileSizes_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/rostests/kmtests/ntos_cc/CcSetFileSizes_drv.c b/modules/rostests/kmtests/ntos_cc/CcSetFileSizes_drv.c index 241312c12c5..89bc3973cfb 100644 --- a/modules/rostests/kmtests/ntos_cc/CcSetFileSizes_drv.c +++ b/modules/rostests/kmtests/ntos_cc/CcSetFileSizes_drv.c @@ -467,7 +467,7 @@ TestIrpHandler( if (Length > (Fcb->Header.FileSize.QuadPart - Offset.QuadPart)) { - RtlFillMemory(Buffer, Length - Fcb->Header.FileSize.QuadPart, 0xBD); + RtlFillMemory(Buffer, Length - (Fcb->Header.FileSize.QuadPart - Offset.QuadPart), 0xBD); } } else

3 years, 7 months

[reactos] 02/02: [CMIPCI][DOC] Fix 4 DriverVer values

by Serge Gautherie

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=fa47d6f85278a72184fee… commit fa47d6f85278a72184feea91a5ca2ab0f8271466 Author: Serge Gautherie <reactos-git_serge_171003(a)gautherie.fr> AuthorDate: Thu Nov 26 06:59:36 2020 +0100 Commit: Stanislav Motylkov <x86corez(a)gmail.com> CommitDate: Tue Feb 2 01:56:50 2021 +0300 [CMIPCI][DOC] Fix 4 DriverVer values And add entry to '3rd Party Files.txt'. Addendum to 4b4d95d (r39827) and ee4368d (r58644). --- drivers/wdm/audio/drivers/CMIDriver/CM8738-x32-WaveRT.inf | 2 +- drivers/wdm/audio/drivers/CMIDriver/CM8738-x32.inf | 2 +- drivers/wdm/audio/drivers/CMIDriver/CM8738-x64-WaveRT.inf | 2 +- drivers/wdm/audio/drivers/CMIDriver/CM8738-x64.inf | 2 +- media/doc/3rd Party Files.txt | 6 ++++++ 5 files changed, 10 insertions(+), 4 deletions(-) diff --git a/drivers/wdm/audio/drivers/CMIDriver/CM8738-x32-WaveRT.inf b/drivers/wdm/audio/drivers/CMIDriver/CM8738-x32-WaveRT.inf index f8935e6300f..17464efc482 100644 --- a/drivers/wdm/audio/drivers/CMIDriver/CM8738-x32-WaveRT.inf +++ b/drivers/wdm/audio/drivers/CMIDriver/CM8738-x32-WaveRT.inf @@ -4,7 +4,7 @@ Class=MEDIA ClassGUID={4d36e96c-e325-11ce-bfc1-08002be10318} provider=%CMMfgName% LayoutFile=layout.inf, layout1.inf, layout2.inf -DriverVer=CMIReleaseDate,CMIVersion.1111 +DriverVer=07/13/2009,1.2.6.1111 [SourceDisksNames] 200="C-Media 8738/8768 WDM Drivers","",0 diff --git a/drivers/wdm/audio/drivers/CMIDriver/CM8738-x32.inf b/drivers/wdm/audio/drivers/CMIDriver/CM8738-x32.inf index 57742972901..4d274189d93 100644 --- a/drivers/wdm/audio/drivers/CMIDriver/CM8738-x32.inf +++ b/drivers/wdm/audio/drivers/CMIDriver/CM8738-x32.inf @@ -4,7 +4,7 @@ Class=MEDIA ClassGUID={4d36e96c-e325-11ce-bfc1-08002be10318} provider=%CMMfgName% LayoutFile=layout.inf, layout1.inf, layout2.inf -DriverVer=CMIReleaseDate,CMIVersion +DriverVer=07/13/2009,1.2.6 [SourceDisksNames] 200="C-Media 8738/8768 WDM Drivers","",0 diff --git a/drivers/wdm/audio/drivers/CMIDriver/CM8738-x64-WaveRT.inf b/drivers/wdm/audio/drivers/CMIDriver/CM8738-x64-WaveRT.inf index 51e83c67179..cec22acf682 100644 --- a/drivers/wdm/audio/drivers/CMIDriver/CM8738-x64-WaveRT.inf +++ b/drivers/wdm/audio/drivers/CMIDriver/CM8738-x64-WaveRT.inf @@ -4,7 +4,7 @@ Class=MEDIA ClassGUID={4d36e96c-e325-11ce-bfc1-08002be10318} provider=%CMMfgName% LayoutFile=layout.inf, layout1.inf, layout2.inf -DriverVer=CMIReleaseDate,CMIVersion.1111 +DriverVer=07/13/2009,1.2.6.1111 [SourceDisksNames] 200="C-Media 8738/8768 WDM Drivers","",0 diff --git a/drivers/wdm/audio/drivers/CMIDriver/CM8738-x64.inf b/drivers/wdm/audio/drivers/CMIDriver/CM8738-x64.inf index 921c0d4324a..09fc9faf6e8 100644 --- a/drivers/wdm/audio/drivers/CMIDriver/CM8738-x64.inf +++ b/drivers/wdm/audio/drivers/CMIDriver/CM8738-x64.inf @@ -4,7 +4,7 @@ Class=MEDIA ClassGUID={4d36e96c-e325-11ce-bfc1-08002be10318} provider=%CMMfgName% LayoutFile=layout.inf, layout1.inf, layout2.inf -DriverVer=CMIReleaseDate,CMIVersion.64 +DriverVer=07/13/2009,1.2.6.64 [SourceDisksNames] 200="C-Media 8738/8768 WDM Drivers","",0 diff --git a/media/doc/3rd Party Files.txt b/media/doc/3rd Party Files.txt index 946ae6a5c6e..a2d2c1b5392 100644 --- a/media/doc/3rd Party Files.txt +++ b/media/doc/3rd Party Files.txt @@ -163,6 +163,12 @@ Used Version: ??? License: GPL-2.0-or-later (https://spdx.org/licenses/GPL-2.0-or-later.html) URL: http://www.vmware.com/download/open_sources.html +Title: Open Source WDM Drivers for C-Media 8738/8768 based soundcards +Path: drivers/wdm/audio/drivers/CMIDriver +Used Version: 1.2.6 +License: BSD-3-Clause (https://opensource.org/licenses/BSD-3-Clause) +URL: https://code.google.com/archive/p/cmediadrivers/ + Title: PCI hardware IDs database Path: hal/halx86/legacy/bus/pci_classes.ids Path: hal/halx86/legacy/bus/pci_vendors.ids

3 years, 7 months

[reactos] 01/02: [GREEN][INF] Fix format of 3 DriverVer date values

by Serge Gautherie

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=c2a83d56a0e57df4726d3… commit c2a83d56a0e57df4726d3ce91f9ececd4c363a98 Author: Serge Gautherie <reactos-git_serge_171003(a)gautherie.fr> AuthorDate: Thu Nov 26 06:59:36 2020 +0100 Commit: Stanislav Motylkov <x86corez(a)gmail.com> CommitDate: Tue Feb 2 01:56:50 2021 +0300 [GREEN][INF] Fix format of 3 DriverVer date values GetVersionInformationFromInfFile() expects a 10-character date. --- media/inf/legcydrv.inf | 2 +- media/inf/scsi.inf | 2 +- modules/rosapps/drivers/green/green.inf | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/media/inf/legcydrv.inf b/media/inf/legcydrv.inf index 66277cb5bec..51b64551778 100644 --- a/media/inf/legcydrv.inf +++ b/media/inf/legcydrv.inf @@ -5,7 +5,7 @@ LayoutFile = layout.inf Class = LegacyDriver ClassGUID = {8ECC055D-047F-11D1-A537-0000F8753ED1} Provider = %ReactOS% -DriverVer = 3/20/2012,1.01.0.0 +DriverVer = 03/20/2012,1.01.0.0 [ClassInstall32.NT] AddReg = LegacyDriverClass.NT.AddReg diff --git a/media/inf/scsi.inf b/media/inf/scsi.inf index e8aedc59160..73863434119 100644 --- a/media/inf/scsi.inf +++ b/media/inf/scsi.inf @@ -9,7 +9,7 @@ LayoutFile = layout.inf Class = SCSIAdapter ClassGUID = {4D36E97B-E325-11CE-BFC1-08002BE10318} Provider = %ReactOS% -DriverVer = 11/2/2007,1.1 +DriverVer = 11/02/2007,1.1 [ClassInstall32.NT] AddReg = SCSIClass.NT.AddReg diff --git a/modules/rosapps/drivers/green/green.inf b/modules/rosapps/drivers/green/green.inf index 274833e011a..2b0b4d63998 100644 --- a/modules/rosapps/drivers/green/green.inf +++ b/modules/rosapps/drivers/green/green.inf @@ -9,7 +9,7 @@ LayoutFile = layout.inf Class = System ClassGUID = {4D36E97D-E325-11CE-BFC1-08002BE10318} Provider = %ReactOS% -DriverVer = 12/7/2005,1.00 +DriverVer = 12/07/2005,1.00 [DestinationDirs] DefaultDestDir = 12

3 years, 7 months

[reactos] 01/01: [NTOS:SE] Implement SECURITY_TOKEN_PROXY_DATA, SECURITY_TOKEN_AUDIT_D… (#3432)

by George Bișoc

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=1903b568b6d670856393c… commit 1903b568b6d670856393c6ad9f63337fcd0e124c Author: George Bișoc <george.bisoc(a)reactos.org> AuthorDate: Mon Feb 1 23:55:42 2021 +0100 Commit: GitHub <noreply(a)github.com> CommitDate: Tue Feb 2 01:55:42 2021 +0300 [NTOS:SE] Implement SECURITY_TOKEN_PROXY_DATA, SECURITY_TOKEN_AUDIT_D… (#3432) ProxyData and AuditData are pointers to an arbitrary data, which instead, they should point to their respective data structures. This serves as preparation for SepFreeProxyData and SepCopyProxyData functions implementations in the future (regarding the proxy data stuff specifically). For further details: https://www.vergiliusproject.com/kernels/x86/Windows%202003/SP2/_TOKEN https://www.nirsoft.net/kernel_struct/vista/SECURITY_TOKEN_AUDIT_DATA.html https://www.nirsoft.net/kernel_struct/vista/SECURITY_TOKEN_PROXY_DATA.html https://www.nirsoft.net/kernel_struct/vista/PROXY_CLASS.html --- ntoskrnl/include/internal/tag.h | 1 + sdk/include/ndk/setypes.h | 37 +++++++++++++++++++++++++++++++++++-- 2 files changed, 36 insertions(+), 2 deletions(-) diff --git a/ntoskrnl/include/internal/tag.h b/ntoskrnl/include/internal/tag.h index 9f86c7cb623..3e838c81abe 100644 --- a/ntoskrnl/include/internal/tag.h +++ b/ntoskrnl/include/internal/tag.h @@ -180,6 +180,7 @@ #define TAG_TOKEN_DYNAMIC 'dTeS' #define TAG_SE_HANDLES_TAB 'aHeS' #define TAG_SE_DIR_BUFFER 'bDeS' +#define TAG_SE_PROXY_DATA 'dPoT' /* LPC Tags */ #define TAG_LPC_MESSAGE 'McpL' diff --git a/sdk/include/ndk/setypes.h b/sdk/include/ndk/setypes.h index 10a500ce041..55e0d8fdab6 100644 --- a/sdk/include/ndk/setypes.h +++ b/sdk/include/ndk/setypes.h @@ -108,6 +108,17 @@ typedef struct _TOKEN_ACCESS_INFORMATION SE_GROUP_INTEGRITY | \ SE_GROUP_INTEGRITY_ENABLED) +// +// Proxy Class enumeration +// +typedef enum _PROXY_CLASS +{ + ProxyFull = 0, + ProxyService, + ProxyTree, + ProxyDirectory +} PROXY_CLASS; + // // Audit and Policy Structures // @@ -145,6 +156,28 @@ typedef struct _SE_AUDIT_PROCESS_CREATION_INFO POBJECT_NAME_INFORMATION ImageFileName; } SE_AUDIT_PROCESS_CREATION_INFO, *PSE_AUDIT_PROCESS_CREATION_INFO; +// +// Token Audit Data +// +typedef struct _SECURITY_TOKEN_AUDIT_DATA +{ + ULONG Length; + ULONG GrantMask; + ULONG DenyMask; +} SECURITY_TOKEN_AUDIT_DATA, *PSECURITY_TOKEN_AUDIT_DATA; + +// +// Token Proxy Data +// +typedef struct _SECURITY_TOKEN_PROXY_DATA +{ + ULONG Length; + PROXY_CLASS ProxyClass; + UNICODE_STRING PathInfo; + ULONG ContainerMask; + ULONG ObjectMask; +} SECURITY_TOKEN_PROXY_DATA, *PSECURITY_TOKEN_PROXY_DATA; + // // Token and auxiliary data // @@ -176,8 +209,8 @@ typedef struct _TOKEN SECURITY_IMPERSONATION_LEVEL ImpersonationLevel; /* 0x84 */ ULONG TokenFlags; /* 0x88 */ BOOLEAN TokenInUse; /* 0x8C */ - PVOID ProxyData; /* 0x90 */ - PVOID AuditData; /* 0x94 */ + PSECURITY_TOKEN_PROXY_DATA ProxyData; /* 0x90 */ + PSECURITY_TOKEN_AUDIT_DATA AuditData; /* 0x94 */ LUID OriginatingLogonSession; /* 0x98 */ ULONG VariablePart; /* 0xA0 */ } TOKEN, *PTOKEN;

3 years, 7 months

[reactos] 01/01: [INF] Fix the date in DriverVer directive for HAL

by Stanislav Motylkov

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=34914ca220b36440dd90d… commit 34914ca220b36440dd90d1387517e03d3cc88fdf Author: Stanislav Motylkov <x86corez(a)gmail.com> AuthorDate: Tue Feb 2 01:54:06 2021 +0300 Commit: Stanislav Motylkov <x86corez(a)gmail.com> CommitDate: Tue Feb 2 01:54:06 2021 +0300 [INF] Fix the date in DriverVer directive for HAL CORE-17212 --- media/inf/hal.inf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/media/inf/hal.inf b/media/inf/hal.inf index 2d27ea92785..78d7587fc1a 100644 --- a/media/inf/hal.inf +++ b/media/inf/hal.inf @@ -9,7 +9,7 @@ LayoutFile = layout.inf Class = Computer ClassGUID = {4D36E966-E325-11CE-BFC1-08002BE10318} Provider = %ReactOS% -DriverVer = 8/15/2011,1.00.0.0 +DriverVer = 08/15/2011,1.00.0.0 [DestinationDirs] DefaultDestDir = 12

3 years, 7 months

[reactos] 01/01: [SCSIPORT] Append GEN_SCSIADAPTER compatible ID for legacy adapters (#3441)

by Stanislav Motylkov

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=df0261e799ebdebbc91b4… commit df0261e799ebdebbc91b4d02149eea6713371ad1 Author: Stanislav Motylkov <x86corez(a)gmail.com> AuthorDate: Tue Feb 2 01:38:06 2021 +0300 Commit: GitHub <noreply(a)github.com> CommitDate: Tue Feb 2 01:38:06 2021 +0300 [SCSIPORT] Append GEN_SCSIADAPTER compatible ID for legacy adapters (#3441) Fixes UniATA root SCSI devices detection in the Device Manager. Based on the description of GEN_SCSIADAPTER from Windows pnpscsi.inf: - https://community.osr.com/discussion/41967/installing-isa-scsi-miniport-dri… - https://chat.reactos.org/reactos/pl/qii1w36wu7yrxyukh9b5dzwnje - https://chat.reactos.org/reactos/pl/f5tanc9nfjdb5m17nhrq33994a CORE-17398 --- drivers/storage/port/scsiport/fdo.c | 56 +++++++++++++++++++++++++++++++++++++ media/inf/scsi.inf | 10 +++++++ 2 files changed, 66 insertions(+) diff --git a/drivers/storage/port/scsiport/fdo.c b/drivers/storage/port/scsiport/fdo.c index 052d5f62fa5..bdb6bf32b38 100644 --- a/drivers/storage/port/scsiport/fdo.c +++ b/drivers/storage/port/scsiport/fdo.c @@ -705,6 +705,51 @@ FdoHandleDeviceRelations( return IoCallDriver(PortExtension->Common.LowerDevice, Irp); } +static +NTSTATUS +FdoHandleQueryCompatibleId( + _Inout_ PZZWSTR* PwIds) +{ + static WCHAR GenScsiAdapterId[] = L"GEN_SCSIADAPTER"; + PWCHAR Ids = *PwIds, NewIds; + ULONG Length = 0; + + if (Ids) + { + /* Calculate the length of existing MULTI_SZ value line by line */ + while (*Ids) + { + Ids += wcslen(Ids) + 1; + } + Length = Ids - *PwIds; + Ids = *PwIds; + } + + /* New MULTI_SZ with added identifier and finalizing zeros */ + NewIds = ExAllocatePoolZero(PagedPool, + Length * sizeof(WCHAR) + sizeof(GenScsiAdapterId) + sizeof(UNICODE_NULL), + TAG_SCSIPORT); + if (!NewIds) + { + return STATUS_INSUFFICIENT_RESOURCES; + } + + if (Length) + { + RtlCopyMemory(NewIds, Ids, Length * sizeof(WCHAR)); + } + RtlCopyMemory(&NewIds[Length], GenScsiAdapterId, sizeof(GenScsiAdapterId)); + + /* Finally replace identifiers */ + if (Ids) + { + ExFreePool(Ids); + } + *PwIds = NewIds; + + return STATUS_SUCCESS; +} + NTSTATUS FdoDispatchPnp( _In_ PDEVICE_OBJECT DeviceObject, @@ -732,6 +777,17 @@ FdoDispatchPnp( { return FdoHandleDeviceRelations(portExt, Irp); } + case IRP_MN_QUERY_ID: + { + if (ioStack->Parameters.QueryId.IdType == BusQueryCompatibleIDs) + { + Irp->IoStatus.Information = 0; + IoForwardIrpSynchronously(portExt->Common.LowerDevice, Irp); + status = FdoHandleQueryCompatibleId((PZZWSTR*)&Irp->IoStatus.Information); + break; + } + // otherwise fall through the default case + } default: { // forward irp to next device object diff --git a/media/inf/scsi.inf b/media/inf/scsi.inf index 315fe4a34da..e8aedc59160 100644 --- a/media/inf/scsi.inf +++ b/media/inf/scsi.inf @@ -26,6 +26,7 @@ DefaultDestDir = 12 %GenericMfg% = GenericMfg [GenericMfg] +%GEN_SCSIADAPTER.DeviceDesc% = NO_DRV,,GEN_SCSIADAPTER %PCI\VEN_104B&CC_0100.DeviceDesc% = BusLogic_Inst,PCI\VEN_104B&CC_0100 ;----------------------------- ScsiPort Driver ---------------------------- @@ -40,6 +41,13 @@ ErrorControl = 0 ServiceBinary = %12%\scsiport.sys LoadOrderGroup = SCSI Port +;---------------------------- NO DRIVER REQ ----------------------------- + +[NO_DRV] + +[NO_DRV.Services] +AddService = , 0x00000002 + ;----------------------------- BusLogic Driver ---------------------------- [BusLogic_Inst.NT] @@ -66,6 +74,7 @@ ReactOS = "ReactOS Team" SCSIClassName = "SCSI and RAID Controllers" GenericMfg = "(Standard SCSI and RAID controllers)" +GEN_SCSIADAPTER.DeviceDesc = "SCSI/RAID Host Controller" PCI\VEN_104B&CC_0100.DeviceDesc = "BusLogic SCSI Controller" [Strings.0405] @@ -120,6 +129,7 @@ ReactOS = "Команда ReactOS" SCSIClassName = "SCSI и RAID контроллеры" GenericMfg = "(Стандартные SCSI и RAID контроллеры)" +GEN_SCSIADAPTER.DeviceDesc = "SCSI/RAID хост-контроллер" PCI\VEN_104B&CC_0100.DeviceDesc = "Контроллер BusLogic SCSI" [Strings.041B]

3 years, 7 months

[reactos] 01/01: [BOOTDATA] Link the Accessibility Utility Manager for LiveCD builds (#3443)

by George Bișoc

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=e4dd39f1a9e75fa6aa281… commit e4dd39f1a9e75fa6aa281850884d567d2af6b7cd Author: George Bișoc <george.bisoc(a)reactos.org> AuthorDate: Mon Feb 1 23:37:37 2021 +0100 Commit: GitHub <noreply(a)github.com> CommitDate: Tue Feb 2 01:37:37 2021 +0300 [BOOTDATA] Link the Accessibility Utility Manager for LiveCD builds (#3443) --- boot/bootdata/CMakeLists.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/boot/bootdata/CMakeLists.txt b/boot/bootdata/CMakeLists.txt index f1e6153f8a7..30ebc713b4c 100644 --- a/boot/bootdata/CMakeLists.txt +++ b/boot/bootdata/CMakeLists.txt @@ -83,6 +83,7 @@ add_livecd_shortcut("Device Manager" devmgmt.exe "Profiles/All Users/Start Menu/ add_livecd_shortcut("Event Viewer" eventvwr.exe "Profiles/All Users/Start Menu/Programs/Administrative Tools") add_livecd_shortcut("Service Manager" servman.exe "Profiles/All Users/Start Menu/Programs/Administrative Tools") add_livecd_shortcut("System Configuration" msconfig.exe "Profiles/All Users/Start Menu/Programs/Administrative Tools") +add_livecd_shortcut("Accessibility Utility Manager" utilman.exe "Profiles/All Users/Start Menu/Programs/Accessories/Accessibility") add_livecd_shortcut("Magnify" magnify.exe "Profiles/All Users/Start Menu/Programs/Accessories/Accessibility") add_livecd_shortcut("On-Screen Keyboard" osk.exe "Profiles/All Users/Start Menu/Programs/Accessories/Accessibility") add_livecd_shortcut("Remote Desktop Connection" mstsc.exe "Profiles/All Users/Start Menu/Programs/Accessories/Communications")

3 years, 7 months

[reactos] 01/01: [SYSDM] Fix sunrise regression CORE-17451

by Joachim Henze

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=d0c237a6ab7bb700c54a9… commit d0c237a6ab7bb700c54a93c56c7fffda5a97d8e4 Author: Joachim Henze <Joachim.Henze(a)reactos.org> AuthorDate: Mon Feb 1 21:12:59 2021 +0100 Commit: Joachim Henze <Joachim.Henze(a)reactos.org> CommitDate: Mon Feb 1 21:13:59 2021 +0100 [SYSDM] Fix sunrise regression CORE-17451 This fixes a regression with the AlphaBlending on single left-click on the ros logo in general tab. That regression was introduced by 0.4.15-dev-178-g d635ce0cc0336a9b77d243ddce946876f48ec4f6 So it can be seen as an addendum to (#2707). We luckily did not have any affected releases yet. --- dll/cpl/sysdm/general.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/dll/cpl/sysdm/general.c b/dll/cpl/sysdm/general.c index 938cb820e8c..e8f38e5a6b3 100644 --- a/dll/cpl/sysdm/general.c +++ b/dll/cpl/sysdm/general.c @@ -234,11 +234,10 @@ Cleanup: if (hCreditsBitmap != NULL) DeleteObject(hCreditsBitmap); + InvalidateRect(hwnd, NULL, FALSE); top = 0; timerid = 0; } - - InvalidateRect(hwnd, NULL, FALSE); break; case WM_TIMER: top += ANIM_STEP;

3 years, 7 months

[reactos] 03/03: [FREELDR] Disable SSE instructions for GCC x64

by Hervé Poussineau

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=bfedf9760cb464aaa1a55… commit bfedf9760cb464aaa1a55b19bc6899c02edba96d Author: Hervé Poussineau <hpoussin(a)reactos.org> AuthorDate: Sat Jan 30 18:51:07 2021 +0100 Commit: Hervé Poussineau <hpoussin(a)reactos.org> CommitDate: Mon Feb 1 19:57:12 2021 +0100 [FREELDR] Disable SSE instructions for GCC x64 Even if all x64 CPUs can handle SSE instructions, prevent GCC x64 to generate them, as FreeLoader is not ready to handle them. --- boot/freeldr/freeldr/CMakeLists.txt | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/boot/freeldr/freeldr/CMakeLists.txt b/boot/freeldr/freeldr/CMakeLists.txt index 95dc2e31224..f4610d4c12f 100644 --- a/boot/freeldr/freeldr/CMakeLists.txt +++ b/boot/freeldr/freeldr/CMakeLists.txt @@ -225,6 +225,10 @@ if(NOT MSVC AND ARCH STREQUAL "i386" AND SARCH STREQUAL "xbox") # Prevent a warning when doing a memcmp with address 0 set_source_files_properties(arch/i386/xbox/xboxmem.c PROPERTIES COMPILE_FLAGS "-Wno-nonnull") endif() +if(ARCH STREQUAL "amd64" AND NOT MSVC) + # Prevent using SSE (not support in freeldr) + target_compile_options(freeldr_common PUBLIC -mno-sse) +endif() set(PCH_SOURCE ${FREELDR_BOOTLIB_SOURCE}

3 years, 7 months

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs February 2021