ReactOS.org
Sign In
Sign Up
Sign In
Sign Up
Manage this list
×
Keyboard Shortcuts
Thread View
j
: Next unread message
k
: Previous unread message
j a
: Jump to all threads
j l
: Jump to MailingList overview
2024
December
November
October
September
August
July
June
May
April
March
February
January
2023
December
November
October
September
August
July
June
May
April
March
February
January
2022
December
November
October
September
August
July
June
May
April
March
February
January
2021
December
November
October
September
August
July
June
May
April
March
February
January
2020
December
November
October
September
August
July
June
May
April
March
February
January
2019
December
November
October
September
August
July
June
May
April
March
February
January
2018
December
November
October
September
August
July
June
May
April
March
February
January
2017
December
November
October
September
August
July
June
May
April
March
February
January
2016
December
November
October
September
August
July
June
May
April
March
February
January
2015
December
November
October
September
August
July
June
May
April
March
February
January
2014
December
November
October
September
August
July
June
May
April
March
February
January
2013
December
November
October
September
August
July
June
May
April
March
February
January
2012
December
November
October
September
August
July
June
May
April
March
February
January
2011
December
November
October
September
August
July
June
May
April
March
February
January
2010
December
November
October
September
August
July
June
May
April
March
February
January
2009
December
November
October
September
August
July
June
May
April
March
February
January
2008
December
November
October
September
August
July
June
May
April
March
February
January
2007
December
November
October
September
August
July
June
May
April
March
February
January
2006
December
November
October
September
August
July
June
May
April
March
February
January
2005
December
November
October
September
August
July
June
May
April
March
February
January
2004
December
November
October
September
August
July
June
May
April
March
February
List overview
Download
Ros-diffs
February 2021
----- 2024 -----
December 2024
November 2024
October 2024
September 2024
August 2024
July 2024
June 2024
May 2024
April 2024
March 2024
February 2024
January 2024
----- 2023 -----
December 2023
November 2023
October 2023
September 2023
August 2023
July 2023
June 2023
May 2023
April 2023
March 2023
February 2023
January 2023
----- 2022 -----
December 2022
November 2022
October 2022
September 2022
August 2022
July 2022
June 2022
May 2022
April 2022
March 2022
February 2022
January 2022
----- 2021 -----
December 2021
November 2021
October 2021
September 2021
August 2021
July 2021
June 2021
May 2021
April 2021
March 2021
February 2021
January 2021
----- 2020 -----
December 2020
November 2020
October 2020
September 2020
August 2020
July 2020
June 2020
May 2020
April 2020
March 2020
February 2020
January 2020
----- 2019 -----
December 2019
November 2019
October 2019
September 2019
August 2019
July 2019
June 2019
May 2019
April 2019
March 2019
February 2019
January 2019
----- 2018 -----
December 2018
November 2018
October 2018
September 2018
August 2018
July 2018
June 2018
May 2018
April 2018
March 2018
February 2018
January 2018
----- 2017 -----
December 2017
November 2017
October 2017
September 2017
August 2017
July 2017
June 2017
May 2017
April 2017
March 2017
February 2017
January 2017
----- 2016 -----
December 2016
November 2016
October 2016
September 2016
August 2016
July 2016
June 2016
May 2016
April 2016
March 2016
February 2016
January 2016
----- 2015 -----
December 2015
November 2015
October 2015
September 2015
August 2015
July 2015
June 2015
May 2015
April 2015
March 2015
February 2015
January 2015
----- 2014 -----
December 2014
November 2014
October 2014
September 2014
August 2014
July 2014
June 2014
May 2014
April 2014
March 2014
February 2014
January 2014
----- 2013 -----
December 2013
November 2013
October 2013
September 2013
August 2013
July 2013
June 2013
May 2013
April 2013
March 2013
February 2013
January 2013
----- 2012 -----
December 2012
November 2012
October 2012
September 2012
August 2012
July 2012
June 2012
May 2012
April 2012
March 2012
February 2012
January 2012
----- 2011 -----
December 2011
November 2011
October 2011
September 2011
August 2011
July 2011
June 2011
May 2011
April 2011
March 2011
February 2011
January 2011
----- 2010 -----
December 2010
November 2010
October 2010
September 2010
August 2010
July 2010
June 2010
May 2010
April 2010
March 2010
February 2010
January 2010
----- 2009 -----
December 2009
November 2009
October 2009
September 2009
August 2009
July 2009
June 2009
May 2009
April 2009
March 2009
February 2009
January 2009
----- 2008 -----
December 2008
November 2008
October 2008
September 2008
August 2008
July 2008
June 2008
May 2008
April 2008
March 2008
February 2008
January 2008
----- 2007 -----
December 2007
November 2007
October 2007
September 2007
August 2007
July 2007
June 2007
May 2007
April 2007
March 2007
February 2007
January 2007
----- 2006 -----
December 2006
November 2006
October 2006
September 2006
August 2006
July 2006
June 2006
May 2006
April 2006
March 2006
February 2006
January 2006
----- 2005 -----
December 2005
November 2005
October 2005
September 2005
August 2005
July 2005
June 2005
May 2005
April 2005
March 2005
February 2005
January 2005
----- 2004 -----
December 2004
November 2004
October 2004
September 2004
August 2004
July 2004
June 2004
May 2004
April 2004
March 2004
February 2004
ros-diffs@reactos.org
30 participants
434 discussions
Start a n
N
ew thread
[reactos] 01/01: [NTOS:MM] Handle demand zero PTEs with MM_EXECUTE_READWRITE and MM_READWRITE
by Timo Kreuzer
https://git.reactos.org/?p=reactos.git;a=commitdiff;h=4b4bff0642fd06fde2945…
commit 4b4bff0642fd06fde2945e711e70b366abbaa4a2 Author: Timo Kreuzer <timo.kreuzer(a)reactos.org> AuthorDate: Sun Nov 1 15:13:36 2020 +0100 Commit: Jérôme Gardou <zefklop(a)users.noreply.github.com> CommitDate: Tue Feb 16 18:02:57 2021 +0100 [NTOS:MM] Handle demand zero PTEs with MM_EXECUTE_READWRITE and MM_READWRITE --- ntoskrnl/mm/ARM3/pagfault.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/ntoskrnl/mm/ARM3/pagfault.c b/ntoskrnl/mm/ARM3/pagfault.c index eefee2b340b..6d60645debd 100644 --- a/ntoskrnl/mm/ARM3/pagfault.c +++ b/ntoskrnl/mm/ARM3/pagfault.c @@ -2262,12 +2262,13 @@ UserFault: } /* Quick check for demand-zero */ - if (TempPte.u.Long == (MM_READWRITE << MM_PTE_SOFTWARE_PROTECTION_BITS)) + if ((TempPte.u.Long == (MM_READWRITE << MM_PTE_SOFTWARE_PROTECTION_BITS)) || + (TempPte.u.Long == (MM_EXECUTE_READWRITE << MM_PTE_SOFTWARE_PROTECTION_BITS))) { /* Resolve the fault */ MiResolveDemandZeroFault(Address, PointerPte, - MM_READWRITE, + TempPte.u.Soft.Protection, CurrentProcess, MM_NOIRQL);
3 years, 10 months
1
0
0
0
[reactos] 01/01: [PSDK] winbase.h: Update LoadLibraryEx() dwFlags value defines (#3456)
by Serge Gautherie
https://git.reactos.org/?p=reactos.git;a=commitdiff;h=7ca16bf6969b1281095ad…
commit 7ca16bf6969b1281095adcc919ae7fe9d679055f Author: Serge Gautherie <32623169+SergeGautherie(a)users.noreply.github.com> AuthorDate: Tue Feb 16 16:37:48 2021 +0100 Commit: GitHub <noreply(a)github.com> CommitDate: Wed Feb 17 00:37:48 2021 +0900 [PSDK] winbase.h: Update LoadLibraryEx() dwFlags value defines (#3456) Add another Vista check. Addendum to 986cc5e. --- sdk/include/psdk/winbase.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sdk/include/psdk/winbase.h b/sdk/include/psdk/winbase.h index 445c255b0ea..b6bda981368 100644 --- a/sdk/include/psdk/winbase.h +++ b/sdk/include/psdk/winbase.h @@ -354,7 +354,9 @@ extern "C" { #define LOAD_LIBRARY_SAFE_CURRENT_DIRS 0x00002000 #define LOAD_LIBRARY_SEARCH_SYSTEM32_NO_FORWARDER 0x00004000 #else // NTDDI_WIN10_RS1 +#if (_WIN32_WINNT >= _WIN32_WINNT_VISTA) #define LOAD_LIBRARY_SEARCH_SYSTEM32_NO_FORWARDER LOAD_LIBRARY_SEARCH_SYSTEM32 +#endif // _WIN32_WINNT_VISTA #endif // NTDDI_WIN10_RS1 #if (NTDDI_VERSION >= NTDDI_WIN10_RS2) #define LOAD_LIBRARY_OS_INTEGRITY_CONTINUITY 0x00008000
3 years, 10 months
1
0
0
0
[reactos] 01/01: [SHIMGVW] Update Czech (cs-CZ) translation
by Václav Zouzalík
https://git.reactos.org/?p=reactos.git;a=commitdiff;h=0f8224e98522518922893…
commit 0f8224e985225189228936b7560ea7d7ea6ae9cc Author: Václav Zouzalík <Vaclav.Zouzalik(a)seznam.cz> AuthorDate: Mon Feb 15 22:07:41 2021 +0100 Commit: Robert Naumann <gonzomdx(a)gmail.com> CommitDate: Tue Feb 16 15:11:50 2021 +0100 [SHIMGVW] Update Czech (cs-CZ) translation --- dll/win32/shimgvw/lang/cs-CZ.rc | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/dll/win32/shimgvw/lang/cs-CZ.rc b/dll/win32/shimgvw/lang/cs-CZ.rc index 21c61dd7690..4a4c67ab0e7 100644 --- a/dll/win32/shimgvw/lang/cs-CZ.rc +++ b/dll/win32/shimgvw/lang/cs-CZ.rc @@ -1,6 +1,6 @@ /* Translators: * 2008-06-24, Radek Liska aka Black_Fox (radekliska at gmail dot com) - * 2020-12-30, Václav Zouzalík aka Venca24 (vaclav.zouzalik at seznam dot cz) + * 2021-02-15, Václav Zouzalík aka Venca24 (vaclav.zouzalik at seznam dot cz) */ LANGUAGE LANG_CZECH, SUBLANG_DEFAULT @@ -14,18 +14,18 @@ BEGIN /* Tooltips */ IDS_TOOLTIP_NEXT_PIC "Další obrázek" IDS_TOOLTIP_PREV_PIC "Předchozí obrázek" - IDS_TOOLTIP_BEST_FIT "Best fit to window (Ctrl+B)" - IDS_TOOLTIP_REAL_SIZE "Actual size (Ctrl+A)" - IDS_TOOLTIP_SLIDE_SHOW "Start slideshow (F11)" + IDS_TOOLTIP_BEST_FIT "Přizpůsobit velikosti okna (Ctrl+B)" + IDS_TOOLTIP_REAL_SIZE "Původní velikost (Ctrl+A)" + IDS_TOOLTIP_SLIDE_SHOW "Spustit prezentaci (F11)" IDS_TOOLTIP_ZOOM_IN "Přiblížit (+)" IDS_TOOLTIP_ZOOM_OUT "Oddálit (-)" IDS_TOOLTIP_ROT_CLOCKW "Otočit po směru hodinových ručiček (Ctrl+K)" IDS_TOOLTIP_ROT_COUNCW "Otočit proti směru hodinových ručiček (Ctrl+L)" - IDS_TOOLTIP_DELETE "Delete (DEL)" + IDS_TOOLTIP_DELETE "Odstranit (DEL)" IDS_TOOLTIP_PRINT "Tisk (Ctrl+P)" IDS_TOOLTIP_SAVEAS "Uložit jako... (Ctrl+S)" - IDS_TOOLTIP_MODIFY "Modify (Ctrl+E)" - IDS_TOOLTIP_HELP_TOC "Help topics (F1)" + IDS_TOOLTIP_MODIFY "Upravit (Ctrl+E)" + IDS_TOOLTIP_HELP_TOC "Nápověda (F1)" END STRINGTABLE
3 years, 10 months
1
0
0
0
[reactos] 01/01: Revert "Disable some C++ code, which doesn't compile for me"
by Hervé Poussineau
https://git.reactos.org/?p=reactos.git;a=commitdiff;h=796a536a22305ea3158c9…
commit 796a536a22305ea3158c905c7e2d1d43157f3fc9 Author: Hervé Poussineau <hpoussin(a)reactos.org> AuthorDate: Tue Feb 16 00:13:18 2021 +0100 Commit: Hervé Poussineau <hpoussin(a)reactos.org> CommitDate: Tue Feb 16 00:13:18 2021 +0100 Revert "Disable some C++ code, which doesn't compile for me" This reverts commit 83d9920cb9a1ff0fb7dca07402b2aaba2f9cc644. --- base/applications/CMakeLists.txt | 2 +- base/applications/network/CMakeLists.txt | 2 +- dll/shellext/CMakeLists.txt | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/base/applications/CMakeLists.txt b/base/applications/CMakeLists.txt index 5d88d1ed543..082b2121b35 100644 --- a/base/applications/CMakeLists.txt +++ b/base/applications/CMakeLists.txt @@ -6,7 +6,7 @@ add_subdirectory(charmap) add_subdirectory(clipbrd) add_subdirectory(cmdutils) add_subdirectory(control) -#add_subdirectory(drwtsn32) +add_subdirectory(drwtsn32) add_subdirectory(dxdiag) add_subdirectory(extrac32) add_subdirectory(findstr) diff --git a/base/applications/network/CMakeLists.txt b/base/applications/network/CMakeLists.txt index eca45a3e316..46246108408 100644 --- a/base/applications/network/CMakeLists.txt +++ b/base/applications/network/CMakeLists.txt @@ -11,7 +11,7 @@ add_subdirectory(nslookup) add_subdirectory(ping) add_subdirectory(route) if(NOT USE_CLANG_CL) - #add_subdirectory(telnet) + add_subdirectory(telnet) endif() add_subdirectory(tracert) add_subdirectory(whois) diff --git a/dll/shellext/CMakeLists.txt b/dll/shellext/CMakeLists.txt index 6eb0717474d..8d005319c4c 100644 --- a/dll/shellext/CMakeLists.txt +++ b/dll/shellext/CMakeLists.txt @@ -10,6 +10,6 @@ add_subdirectory(netplwiz) add_subdirectory(netshell) add_subdirectory(ntobjshex) add_subdirectory(sendmail) -#add_subdirectory(shellbtrfs) +add_subdirectory(shellbtrfs) add_subdirectory(stobject) add_subdirectory(zipfldr)
3 years, 10 months
1
0
0
0
[reactos] 02/02: Disable some C++ code, which doesn't compile for me
by Hervé Poussineau
https://git.reactos.org/?p=reactos.git;a=commitdiff;h=83d9920cb9a1ff0fb7dca…
commit 83d9920cb9a1ff0fb7dca07402b2aaba2f9cc644 Author: Hervé Poussineau <hpoussin(a)reactos.org> AuthorDate: Wed Jun 3 21:46:52 2020 +0200 Commit: Hervé Poussineau <hpoussin(a)reactos.org> CommitDate: Tue Feb 16 00:12:25 2021 +0100 Disable some C++ code, which doesn't compile for me --- base/applications/CMakeLists.txt | 2 +- base/applications/network/CMakeLists.txt | 2 +- dll/shellext/CMakeLists.txt | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/base/applications/CMakeLists.txt b/base/applications/CMakeLists.txt index 082b2121b35..5d88d1ed543 100644 --- a/base/applications/CMakeLists.txt +++ b/base/applications/CMakeLists.txt @@ -6,7 +6,7 @@ add_subdirectory(charmap) add_subdirectory(clipbrd) add_subdirectory(cmdutils) add_subdirectory(control) -add_subdirectory(drwtsn32) +#add_subdirectory(drwtsn32) add_subdirectory(dxdiag) add_subdirectory(extrac32) add_subdirectory(findstr) diff --git a/base/applications/network/CMakeLists.txt b/base/applications/network/CMakeLists.txt index 46246108408..eca45a3e316 100644 --- a/base/applications/network/CMakeLists.txt +++ b/base/applications/network/CMakeLists.txt @@ -11,7 +11,7 @@ add_subdirectory(nslookup) add_subdirectory(ping) add_subdirectory(route) if(NOT USE_CLANG_CL) - add_subdirectory(telnet) + #add_subdirectory(telnet) endif() add_subdirectory(tracert) add_subdirectory(whois) diff --git a/dll/shellext/CMakeLists.txt b/dll/shellext/CMakeLists.txt index 8d005319c4c..6eb0717474d 100644 --- a/dll/shellext/CMakeLists.txt +++ b/dll/shellext/CMakeLists.txt @@ -10,6 +10,6 @@ add_subdirectory(netplwiz) add_subdirectory(netshell) add_subdirectory(ntobjshex) add_subdirectory(sendmail) -add_subdirectory(shellbtrfs) +#add_subdirectory(shellbtrfs) add_subdirectory(stobject) add_subdirectory(zipfldr)
3 years, 10 months
1
0
0
0
[reactos] 01/02: [NTOS:KD] Merge initialization phases 1 and 2, and fix log file debugging
by Hervé Poussineau
https://git.reactos.org/?p=reactos.git;a=commitdiff;h=58332b076c7ae20fd3286…
commit 58332b076c7ae20fd328690dc7631b78786ba12b Author: Hervé Poussineau <hpoussin(a)reactos.org> AuthorDate: Mon Feb 15 23:20:15 2021 +0100 Commit: Hervé Poussineau <hpoussin(a)reactos.org> CommitDate: Tue Feb 16 00:12:25 2021 +0100 [NTOS:KD] Merge initialization phases 1 and 2, and fix log file debugging Phase 2 and 3 were not done anymore since 777a2d94da285f9ab612680ebb9f5d412b74fb68. Fix that, by merging phases 1 and 2, and by calling phase 3 later for log file debugging, when ExpInitializationPhase = 3 CORE-17470 --- ntoskrnl/kd/kdio.c | 23 ++++++++++++++++------- 1 file changed, 16 insertions(+), 7 deletions(-) diff --git a/ntoskrnl/kd/kdio.c b/ntoskrnl/kd/kdio.c index c1b01dec20b..288977bebbc 100644 --- a/ntoskrnl/kd/kdio.c +++ b/ntoskrnl/kd/kdio.c @@ -19,6 +19,7 @@ #define KdpBufferSize (1024 * 512) static BOOLEAN KdpLoggingEnabled = FALSE; +static BOOLEAN KdpLoggingStarting = FALSE; static PCHAR KdpDebugBuffer = NULL; static volatile ULONG KdpCurrentPosition = 0; static volatile ULONG KdpFreeBytes = 0; @@ -26,6 +27,7 @@ static KSPIN_LOCK KdpDebugLogSpinLock; static KEVENT KdpLoggerThreadEvent; static HANDLE KdpLogFileHandle; ANSI_STRING KdpLogFileName = RTL_CONSTANT_STRING("\\SystemRoot\\debug.log"); +extern ULONG ExpInitializationPhase; static KSPIN_LOCK KdpSerialSpinLock; ULONG SerialPortNumber = DEFAULT_DEBUG_PORT; @@ -155,6 +157,7 @@ KdpPrintToLogFile(PCHAR String, { KIRQL OldIrql; ULONG beg, end, num; + BOOLEAN DoReinit = FALSE; if (KdpDebugBuffer == NULL) return; @@ -184,8 +187,18 @@ KdpPrintToLogFile(PCHAR String, } /* Release the spinlock */ + if (OldIrql == PASSIVE_LEVEL && !KdpLoggingStarting && !KdpLoggingEnabled && ExpInitializationPhase >= 2) + { + DoReinit = TRUE; + } KdpReleaseLock(&KdpDebugLogSpinLock, OldIrql); + if (DoReinit) + { + KdpLoggingStarting = TRUE; + KdpDebugLogInit(NULL, 3); + } + /* Signal the logger thread */ if (OldIrql <= DISPATCH_LEVEL && KdpLoggingEnabled) KeSetEvent(&KdpLoggerThreadEvent, IO_NO_INCREMENT, FALSE); @@ -224,9 +237,7 @@ KdpDebugLogInit(PKD_DISPATCH_TABLE DispatchTable, /* Initialize spinlock */ KeInitializeSpinLock(&KdpDebugLogSpinLock); - } - else if (BootPhase == 2) - { + HalDisplayString("\r\n File log debugging enabled\r\n\r\n"); } else if (BootPhase == 3) @@ -338,7 +349,7 @@ KdpSerialInit(PKD_DISPATCH_TABLE DispatchTable, /* Register as a Provider */ InsertTailList(&KdProviders, &DispatchTable->KdProvidersList); } - else if (BootPhase == 2) + else if (BootPhase == 1) { HalDisplayString("\r\n Serial debugging enabled\r\n\r\n"); } @@ -508,9 +519,7 @@ KdpScreenInit(PKD_DISPATCH_TABLE DispatchTable, /* Initialize spinlock */ KeInitializeSpinLock(&KdpDmesgLogSpinLock); - } - else if (BootPhase == 2) - { + HalDisplayString("\r\n Screen debugging enabled\r\n\r\n"); } }
3 years, 10 months
1
0
0
0
[reactos] 01/01: [SHIMGVW] Refactoring (#3461)
by Katayama Hirofumi MZ
https://git.reactos.org/?p=reactos.git;a=commitdiff;h=99a9e7e49384c586e9b04…
commit 99a9e7e49384c586e9b0408dc0d7816f2abf0cda Author: Katayama Hirofumi MZ <katayama.hirofumi.mz(a)gmail.com> AuthorDate: Mon Feb 15 19:21:55 2021 +0900 Commit: GitHub <noreply(a)github.com> CommitDate: Mon Feb 15 19:21:55 2021 +0900 [SHIMGVW] Refactoring (#3461) - Make the calls of CallWindowProc and DefWindowProc Wide (Unicode). - Delete needless type casts. - Add const to function arguments. - Improve ImageView_LoadSettings function. - Insert OFN_EXPLORER flag. --- dll/win32/shimgvw/shimgvw.c | 47 ++++++++++++++++++++------------------------- 1 file changed, 21 insertions(+), 26 deletions(-) diff --git a/dll/win32/shimgvw/shimgvw.c b/dll/win32/shimgvw/shimgvw.c index 40723c2883f..a70ef51cc41 100644 --- a/dll/win32/shimgvw/shimgvw.c +++ b/dll/win32/shimgvw/shimgvw.c @@ -337,7 +337,7 @@ static void ResetZoom(void) } } -static void pLoadImage(LPWSTR szOpenFileName) +static void pLoadImage(LPCWSTR szOpenFileName) { /* check file presence */ if (GetFileAttributesW(szOpenFileName) == 0xFFFFFFFF) @@ -420,7 +420,7 @@ static void pSaveImageAs(HWND hwnd) sfn.lpstrFile = szSaveFileName; sfn.lpstrFilter = szFilterMask; sfn.nMaxFile = MAX_PATH; - sfn.Flags = OFN_OVERWRITEPROMPT | OFN_HIDEREADONLY; + sfn.Flags = OFN_EXPLORER | OFN_OVERWRITEPROMPT | OFN_HIDEREADONLY; c = szFilterMask; @@ -798,24 +798,21 @@ ImageView_DrawImage(HWND hwnd) } static BOOL -ImageView_LoadSettings() +ImageView_LoadSettings(VOID) { HKEY hKey; DWORD dwSize; + LONG nError; - if (RegOpenKeyEx(HKEY_CURRENT_USER, _T("Software\\ReactOS\\shimgvw"), 0, KEY_READ, &hKey) == ERROR_SUCCESS) - { - dwSize = sizeof(SHIMGVW_SETTINGS); - if (RegQueryValueEx(hKey, _T("Settings"), NULL, NULL, (LPBYTE)&shiSettings, &dwSize) == ERROR_SUCCESS) - { - RegCloseKey(hKey); - return TRUE; - } + nError = RegOpenKeyExW(HKEY_CURRENT_USER, L"Software\\ReactOS\\shimgvw", 0, KEY_READ, &hKey); + if (nError) + return FALSE; - RegCloseKey(hKey); - } + dwSize = sizeof(shiSettings); + nError = RegQueryValueExW(hKey, L"Settings", NULL, NULL, (LPBYTE)&shiSettings, &dwSize); + RegCloseKey(hKey); - return FALSE; + return !nError; } static VOID @@ -845,13 +842,11 @@ ImageView_SaveSettings(HWND hwnd) static BOOL ImageView_CreateToolBar(HWND hwnd) { - int n; - hToolBar = CreateWindowEx(0, TOOLBARCLASSNAME, NULL, WS_CHILD | WS_VISIBLE | TBSTYLE_FLAT | CCS_BOTTOM | TBSTYLE_TOOLTIPS, 0, 0, 0, 0, hwnd, 0, hInstance, NULL); - if(hToolBar != NULL) + if (hToolBar != NULL) { HIMAGELIST hImageList; @@ -864,7 +859,7 @@ ImageView_CreateToolBar(HWND hwnd) hImageList = ImageList_Create(TB_IMAGE_WIDTH, TB_IMAGE_HEIGHT, ILC_MASK | ILC_COLOR24, 1, 1); if (hImageList == NULL) return FALSE; - for (n = 0; n < _countof(BtnConfig); n++) + for (INT n = 0; n < _countof(BtnConfig); n++) { ImageList_AddMasked(hImageList, LoadImageW(hInstance, MAKEINTRESOURCEW(BtnConfig[n].idb), IMAGE_BITMAP, TB_IMAGE_WIDTH, TB_IMAGE_HEIGHT, LR_DEFAULTCOLOR), RGB(255, 255, 255)); @@ -914,7 +909,7 @@ ImageView_DispWndProc(HWND hwnd, UINT Message, WPARAM wParam, LPARAM lParam) break; } } - return CallWindowProc(PrevProc, hwnd, Message, wParam, lParam); + return CallWindowProcW(PrevProc, hwnd, Message, wParam, lParam); } static VOID @@ -1085,11 +1080,11 @@ ImageView_WndProc(HWND hwnd, UINT Message, WPARAM wParam, LPARAM lParam) } } - return DefWindowProc(hwnd, Message, wParam, lParam); + return DefWindowProcW(hwnd, Message, wParam, lParam); } LONG WINAPI -ImageView_CreateWindow(HWND hwnd, LPWSTR szFileName) +ImageView_CreateWindow(HWND hwnd, LPCWSTR szFileName) { struct GdiplusStartupInput gdiplusStartupInput; ULONG_PTR gdiplusToken; @@ -1132,7 +1127,7 @@ ImageView_CreateWindow(HWND hwnd, LPWSTR szFileName) if (!RegisterClassW(&WndClass)) return -1; - LoadStringW(hInstance, IDS_APPTITLE, szBuf, sizeof(szBuf) / sizeof(TCHAR)); + LoadStringW(hInstance, IDS_APPTITLE, szBuf, ARRAYSIZE(szBuf)); hMainWnd = CreateWindowExW(0, L"shimgvw_window", szBuf, WS_OVERLAPPEDWINDOW | WS_VISIBLE | WS_CAPTION, CW_USEDEFAULT, CW_USEDEFAULT, @@ -1188,13 +1183,13 @@ ImageView_CreateWindow(HWND hwnd, LPWSTR szFileName) VOID WINAPI ImageView_FullscreenW(HWND hwnd, HINSTANCE hInst, LPCWSTR path, int nShow) { - ImageView_CreateWindow(hwnd, (LPWSTR)path); + ImageView_CreateWindow(hwnd, path); } VOID WINAPI ImageView_Fullscreen(HWND hwnd, HINSTANCE hInst, LPCWSTR path, int nShow) { - ImageView_CreateWindow(hwnd, (LPWSTR)path); + ImageView_CreateWindow(hwnd, path); } VOID WINAPI @@ -1202,9 +1197,9 @@ ImageView_FullscreenA(HWND hwnd, HINSTANCE hInst, LPCSTR path, int nShow) { WCHAR szFile[MAX_PATH]; - if (MultiByteToWideChar(CP_ACP, 0, (char*)path, strlen((char*)path)+1, szFile, MAX_PATH)) + if (MultiByteToWideChar(CP_ACP, 0, path, -1, szFile, ARRAYSIZE(szFile))) { - ImageView_CreateWindow(hwnd, (LPWSTR)szFile); + ImageView_CreateWindow(hwnd, szFile); } }
3 years, 10 months
1
0
0
0
[reactos] 01/01: [MMSYS] Add the OFN_EXPLORER flag to the Browse for sound dialog. (#3460)
by Jared Smudde
https://git.reactos.org/?p=reactos.git;a=commitdiff;h=8b6e5e87c3a94192f0915…
commit 8b6e5e87c3a94192f09156cf7d82936e41f7e31c Author: Jared Smudde <computerwhiz02(a)hotmail.com> AuthorDate: Sun Feb 14 14:40:30 2021 -0600 Commit: GitHub <noreply(a)github.com> CommitDate: Sun Feb 14 21:40:30 2021 +0100 [MMSYS] Add the OFN_EXPLORER flag to the Browse for sound dialog. (#3460) --- dll/cpl/mmsys/sounds.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dll/cpl/mmsys/sounds.c b/dll/cpl/mmsys/sounds.c index 8b6b7d296a9..89df8727728 100644 --- a/dll/cpl/mmsys/sounds.c +++ b/dll/cpl/mmsys/sounds.c @@ -1151,7 +1151,7 @@ SoundsDlgProc(HWND hwndDlg, LoadStringW(hApplet, IDS_BROWSE_FOR_SOUND, szTitle, _countof(szTitle)); ofn.lpstrTitle = szTitle; ofn.lpstrInitialDir = L"%SystemRoot%\\Media"; - ofn.Flags = OFN_FILEMUSTEXIST | OFN_HIDEREADONLY; + ofn.Flags = OFN_EXPLORER | OFN_FILEMUSTEXIST | OFN_HIDEREADONLY; if (GetOpenFileNameW(&ofn) != FALSE) {
3 years, 10 months
1
0
0
0
[reactos] 01/01: [SHIMGVW] Fix wrong text into the title bar. (#3459)
by Carlo Bramini
https://git.reactos.org/?p=reactos.git;a=commitdiff;h=ac4b506eaba6f6cc81b87…
commit ac4b506eaba6f6cc81b87fb6b12bdc824a601f87 Author: Carlo Bramini <30959007+carlo-bramini(a)users.noreply.github.com> AuthorDate: Sun Feb 14 18:38:36 2021 +0100 Commit: GitHub <noreply(a)github.com> CommitDate: Mon Feb 15 02:38:36 2021 +0900 [SHIMGVW] Fix wrong text into the title bar. (#3459) Unicode/ANSI conversion problem happened by some wrong ANSI function calls. This PR fixes them by modifying CMakeLists.txt. --- dll/win32/shimgvw/CMakeLists.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dll/win32/shimgvw/CMakeLists.txt b/dll/win32/shimgvw/CMakeLists.txt index fefd3d1ca02..43e9f10c839 100644 --- a/dll/win32/shimgvw/CMakeLists.txt +++ b/dll/win32/shimgvw/CMakeLists.txt @@ -9,7 +9,7 @@ list(APPEND SOURCE ${CMAKE_CURRENT_BINARY_DIR}/shimgvw.def) add_library(shimgvw MODULE ${SOURCE}) -set_module_type(shimgvw win32dll) +set_module_type(shimgvw win32dll UNICODE) target_link_libraries(shimgvw wine) add_importlibs(shimgvw advapi32 comctl32 user32 gdi32 shell32 gdiplus comdlg32 shlwapi msvcrt kernel32 ntdll) add_cd_file(TARGET shimgvw DESTINATION reactos/system32 FOR all)
3 years, 10 months
1
0
0
0
[reactos] 01/01: [NETAPI32] Use our implementation of NetWkstaUserEnum instead of the Wine stub
by Eric Kohl
https://git.reactos.org/?p=reactos.git;a=commitdiff;h=2a3c94e3016a4689d0376…
commit 2a3c94e3016a4689d0376899cbfb9ed4b0c97a77 Author: Eric Kohl <eric.kohl(a)reactos.org> AuthorDate: Sun Feb 14 11:26:54 2021 +0100 Commit: Eric Kohl <eric.kohl(a)reactos.org> CommitDate: Sun Feb 14 11:26:54 2021 +0100 [NETAPI32] Use our implementation of NetWkstaUserEnum instead of the Wine stub --- dll/win32/netapi32/wksta.c | 13 ------------- dll/win32/netapi32/wksta_new.c | 2 ++ 2 files changed, 2 insertions(+), 13 deletions(-) diff --git a/dll/win32/netapi32/wksta.c b/dll/win32/netapi32/wksta.c index af835f20f3a..8890d7ce7e5 100644 --- a/dll/win32/netapi32/wksta.c +++ b/dll/win32/netapi32/wksta.c @@ -419,19 +419,6 @@ NET_API_STATUS WINAPI NetWkstaUserGetInfo(LMSTR reserved, DWORD level, return NERR_Success; } -/************************************************************ - * NetWkstaUserEnum (NETAPI32.@) - */ -NET_API_STATUS WINAPI -NetWkstaUserEnum(LMSTR servername, DWORD level, LPBYTE* bufptr, - DWORD prefmaxlen, LPDWORD entriesread, - LPDWORD totalentries, LPDWORD resumehandle) -{ - FIXME("(%s, %d, %p, %d, %p, %p, %p): stub!\n", debugstr_w(servername), - level, bufptr, prefmaxlen, entriesread, totalentries, resumehandle); - return ERROR_INVALID_PARAMETER; -} - /************************************************************ * NetpGetComputerName (NETAPI32.@) */ diff --git a/dll/win32/netapi32/wksta_new.c b/dll/win32/netapi32/wksta_new.c index 0c84a23f20f..29441bb52bc 100644 --- a/dll/win32/netapi32/wksta_new.c +++ b/dll/win32/netapi32/wksta_new.c @@ -1035,6 +1035,7 @@ NetWkstaTransportEnum( return status; } +#endif NET_API_STATUS @@ -1108,6 +1109,7 @@ NetWkstaUserEnum( } +#if 0 NET_API_STATUS WINAPI NetWkstaUserGetInfo(
3 years, 10 months
1
0
0
0
← Newer
1
2
3
4
5
6
7
8
...
44
Older →
Jump to page:
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
Results per page:
10
25
50
100
200