Ros-diffs June 2021

ros-diffs@reactos.org

19 participants
228 discussions

[reactos] 01/01: [CRT][ARM] Fix uninitialized variables caught by RTC

by Stanislav Motylkov

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=11687e9e437ae63f1e2a0… commit 11687e9e437ae63f1e2a03f2bbcd59fa7b5b5594 Author: Stanislav Motylkov <x86corez(a)gmail.com> AuthorDate: Wed Jun 2 13:18:40 2021 +0300 Commit: Stanislav Motylkov <x86corez(a)gmail.com> CommitDate: Wed Jun 2 13:18:40 2021 +0300 [CRT][ARM] Fix uninitialized variables caught by RTC CORE-17613 --- sdk/lib/crt/math/arm/__rt_div_worker.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sdk/lib/crt/math/arm/__rt_div_worker.h b/sdk/lib/crt/math/arm/__rt_div_worker.h index 63ea6349328..2aef926d0d9 100644 --- a/sdk/lib/crt/math/arm/__rt_div_worker.h +++ b/sdk/lib/crt/math/arm/__rt_div_worker.h @@ -44,8 +44,8 @@ __rt_div_worker( UINT3264 mask; UINT3264 quotient; #ifdef _SIGNED_DIV_ - int dividend_sign; - int divisor_sign; + int dividend_sign = 0; + int divisor_sign = 0; #endif // _SIGNED_DIV_ if (divisor == 0)

3 years, 4 months

[reactos] 01/01: [EXPLORER] Polish translation update (#3704)

by Piotr Hetnarowicz

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=0175e8f8dd8acd3be0a90… commit 0175e8f8dd8acd3be0a904e000c803d8c0b796e2 Author: Piotr Hetnarowicz <40692062+pithwz(a)users.noreply.github.com> AuthorDate: Wed Jun 2 11:54:12 2021 +0200 Commit: GitHub <noreply(a)github.com> CommitDate: Wed Jun 2 11:54:12 2021 +0200 [EXPLORER] Polish translation update (#3704) --- base/shell/explorer/lang/pl-PL.rc | 30 +++++++++++++++--------------- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/base/shell/explorer/lang/pl-PL.rc b/base/shell/explorer/lang/pl-PL.rc index a9f688f2e45..abdd0ab5cf4 100644 --- a/base/shell/explorer/lang/pl-PL.rc +++ b/base/shell/explorer/lang/pl-PL.rc @@ -39,15 +39,15 @@ BEGIN MENUITEM "", -1, MFT_SEPARATOR POPUP "&Programy", IDM_PROGRAMS BEGIN - MENUITEM "(Pusty)", -1, MFT_STRING, MFS_GRAYED + MENUITEM "(Puste)", -1, MFT_STRING, MFS_GRAYED END POPUP "&Ulubione", IDM_FAVORITES BEGIN - MENUITEM "(Pusty)", -1, MFT_STRING, MFS_GRAYED + MENUITEM "(Puste)", -1, MFT_STRING, MFS_GRAYED END POPUP "&Dokumenty", IDM_DOCUMENTS BEGIN - MENUITEM "(Pusty)", -1, MFT_STRING, MFS_GRAYED + MENUITEM "(Puste)", -1, MFT_STRING, MFS_GRAYED END POPUP "Us&tawienia", IDM_SETTINGS BEGIN @@ -58,15 +58,15 @@ BEGIN MENUITEM "&Drukarki i faksy", IDM_PRINTERSANDFAXES, MFT_STRING, MFS_ENABLED MENUITEM "P&asek zadań i menu Start", IDM_TASKBARANDSTARTMENU, MFT_STRING, MFS_ENABLED END - MENUITEM "&Szukaj", IDM_SEARCH, MFT_STRING, MFS_ENABLED - MENUITEM "Po&moc", IDM_HELPANDSUPPORT, MFT_STRING, MFS_ENABLED + MENUITEM "Wy&szukaj", IDM_SEARCH, MFT_STRING, MFS_ENABLED + MENUITEM "Po&moc i obsługa techniczna", IDM_HELPANDSUPPORT, MFT_STRING, MFS_ENABLED MENUITEM "&Uruchom...", IDM_RUN, MFT_STRING, MFS_ENABLED MENUITEM "", 450, MFT_SEPARATOR, MFS_ENABLED MENUITEM "S&ynchronizuj", IDM_SYNCHRONIZE, MFT_STRING, MFS_ENABLED MENUITEM "&Wyloguj %s...", IDM_LOGOFF, MFT_STRING, MFS_ENABLED MENUITEM "&Rozłącz...", IDM_DISCONNECT, MFT_STRING, MFS_ENABLED MENUITEM "Oddokuj &komputer", IDM_UNDOCKCOMPUTER, MFT_STRING, MFS_ENABLED - MENUITEM "&Zamknij system...", IDM_SHUTDOWN, MFT_STRING, MFS_ENABLED + MENUITEM "&Zamknij...", IDM_SHUTDOWN, MFT_STRING, MFS_ENABLED END END @@ -84,8 +84,8 @@ BEGIN AUTOCHECKBOX "Pokaż pasek &Szybkiego uruchamiania", IDC_TASKBARPROP_SHOWQL, 13, 97, 200, 10 GROUPBOX "Pasek powiadomień", IDC_STATIC, 6, 114, 240, 96 CONTROL "", IDC_TASKBARPROP_NOTIFICATIONBITMAP, "Static", SS_BITMAP | SS_SUNKEN | SS_CENTERIMAGE, 12, 126, 229, 24 - AUTOCHECKBOX "&Zegar", IDC_TASKBARPROP_CLOCK, 13, 153, 80, 10 - AUTOCHECKBOX "Pokazuj sekundy", IDC_TASKBARPROP_SECONDS, 120, 153, 80, 10, WS_DISABLED + AUTOCHECKBOX "Pokaż &zegar", IDC_TASKBARPROP_CLOCK, 13, 153, 80, 10 + AUTOCHECKBOX "Pokaż sekundy", IDC_TASKBARPROP_SECONDS, 120, 153, 80, 10, WS_DISABLED LTEXT "Możesz uporządkować obszar powiadomień poprzez ukrycie rzadko używanych ikon.", IDC_STATIC, 13, 169, 223, 16 AUTOCHECKBOX "&Ukryj nieaktywne ikony", IDC_TASKBARPROP_HIDEICONS, 13, 191, 125, 10 PUSHBUTTON "&Dostosuj...", IDC_TASKBARPROP_ICONCUST, 188, 191, 50, 14 @@ -111,7 +111,7 @@ EXSTYLE WS_EX_CONTEXTHELP CAPTION "Dostosuj powiadomienia" FONT 8, "MS Shell Dlg" BEGIN - LTEXT "Domyślnie ReactOS wyświetla ikony aktywnych i ważnych powiadomień, ukrywając te nieaktywne. Możesz zmienić to zachowanie lub wybrać elementy korzystając z poniższej listy.", IDC_STATIC, 6, 6, 220, 30 + LTEXT "System ReactOS wyświetla ikony dla powiadomień aktywnych i ważnych oraz ukrywa ikony powiadomień nieaktywnych. Możesz zmienić to zachowanie dla elementów wyświetlonych na poniższej liście.", IDC_STATIC, 6, 6, 220, 32 LTEXT "Zaznacz element, a następnie wybierz zachowanie powiadomienia:", IDC_STATIC, 6, 40, 220, 10 CONTROL "", IDC_NOTIFICATION_LIST, "SysListView32", WS_CLIPSIBLINGS | WS_BORDER | 0x00008005, 6, 50, 220, 128 COMBOBOX IDC_NOTIFICATION_BEHAVIOUR, 103, 178, 78, 200, CBS_DROPDOWNLIST | NOT WS_VISIBLE | WS_CLIPSIBLINGS @@ -151,7 +151,7 @@ BEGIN LTEXT "", IDC_STATIC, 7, 51, 258, 1, NOT WS_GROUP AUTOCHECKBOX "&Nie sprawdzaj tego przy starcie systemu", IDC_NOTCHECK, 7, 62, 139, 10 ICON 32515, IDC_STATIC, 7, 7, 21, 20 - LTEXT "Na Twoim komputerze znajduje się plik folderu o nazwie %s , który może spowodować nieprawidłowe działanie niektórych aplikacji. Zmienienie nazwy na %s rozwiązało by ten problem. Czy chcesz teraz zmienić nazwę tego pliku?", IDC_STATIC, 34, 7, 224, 37 + LTEXT "Na tym komputerze znajduje się plik folderu o nazwie %s, który może powodować nieprawidłowe działanie niektórych aplikacji. Zmiana jego nazwy na %s może rozwiązać ten problem. Czy chcesz teraz zmienić jego nazwę?", IDC_STATIC, 34, 7, 224, 37 END IDD_MODERNSTART_ADVANCED DIALOGEX 0, 0, 251, 198, 0 @@ -162,11 +162,11 @@ BEGIN GROUPBOX "Ustawienia menu Start ", IDC_STATIC, 7, 7, 238, 42 AUTOCHECKBOX "&Otwieraj podmenu po zatrzymaniu na nich wskaźnika myszy", IDC_AUTOOPEN, 14, 21, 224, 10 AUTOCHECKBOX "Wyróżnij &nowo zainstalowane programy", IDC_HIGHLIGHT, 14, 35, 224, 10 - LTEXT "Elementy %menu Start:", IDC_STATIC, 7, 53, 238, 8 + LTEXT "Elementy menu Start:", IDC_STATIC, 7, 53, 238, 8 CONTROL "StartMenuSe&ttings", IDC_ITEMS, "SysTreeView32", WS_BORDER | 0x00000001, 7, 63, 238, 67, WS_EX_CLIENTEDGE GROUPBOX "Niedawno używane dokumenty ", IDC_STATIC, 7, 133, 238, 56 LTEXT "Zaznacz tę opcję, aby zapewnić szybki dostęp do niedawno otwieranych dokumentów. Wyczyszczenie tej listy nie powoduje usunięcia dokumentów.", IDC_STATIC, 14, 144, 224, 21 - AUTOCHECKBOX "Wyczyść &moje ostatnio otwierane dokumenty", IDC_RECENTLY, 14, 168, 147, 10 + AUTOCHECKBOX "Wyświetl moje ostatnio otwierane dokumenty", IDC_RECENTLY, 14, 171, 162, 10 PUSHBUTTON "Wy&czyść listę", IDC_CLEAR, 182, 168, 55, 14 END @@ -181,7 +181,7 @@ BEGIN AUTORADIOBUTTON "&Duże ikony", IDC_CHOOSELARGE, 43, 25, 53, 10 AUTORADIOBUTTON "&Małe ikony", IDC_CHOOSESMALL, 177, 25, 51, 10, NOT WS_TABSTOP GROUPBOX "Programy ", IDC_STATIC, 7, 49, 238, 70 - LTEXT "Menu Start zawiera skróty do najczęściej używanych programów. Wyczyszczenie tej listy nie spowoduje usunięcia programów.", IDC_STATIC, 14, 63, 224, 20 + LTEXT "Menu Start zawiera skróty do najczęściej używanych programów. Wyczyszczenie tej listy nie spowoduje usunięcia programów.", IDC_STATIC, 14, 63, 224, 24 LTEXT "Liczba programów w me&nu Start:", IDC_STATIC, 14, 86, 112, 8 EDITTEXT IDC_NUMBEROFPROGRAMS, 133, 84, 27, 12, ES_LEFT | ES_RIGHT | ES_NUMBER CONTROL "", IDC_NUMBERUPDOWN, "msctls_updown32", WS_BORDER | 0x000000B6, 160, 84, 11, 12 @@ -197,8 +197,8 @@ STRINGTABLE BEGIN IDS_START "Start" IDS_PROPERTIES "Właś&ciwości" - IDS_OPEN_ALL_USERS "&Otwórz - wszyscy użytkownicy" - IDS_EXPLORE_ALL_USERS "&Eksploruj - wszyscy użytkownicy" + IDS_OPEN_ALL_USERS "&Otwórz - wszystkich użytkowników" + IDS_EXPLORE_ALL_USERS "&Eksploruj - wszystkich użytkowników" IDS_STARTUP_ERROR "System nie może uruchomić eksploratora, ponieważ rejestr jest niedostępny lub uszkodzony." END

3 years, 4 months

[reactos] 01/01: [BROWSEUI] Polish translation update (#3703)

by Piotr Hetnarowicz

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=4771551c740e8681db3f3… commit 4771551c740e8681db3f3b9246b90ab851b706eb Author: Piotr Hetnarowicz <40692062+pithwz(a)users.noreply.github.com> AuthorDate: Wed Jun 2 11:53:07 2021 +0200 Commit: GitHub <noreply(a)github.com> CommitDate: Wed Jun 2 11:53:07 2021 +0200 [BROWSEUI] Polish translation update (#3703) --- dll/win32/browseui/lang/pl-PL.rc | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/dll/win32/browseui/lang/pl-PL.rc b/dll/win32/browseui/lang/pl-PL.rc index 1c72f9ac48b..ff6127a9598 100644 --- a/dll/win32/browseui/lang/pl-PL.rc +++ b/dll/win32/browseui/lang/pl-PL.rc @@ -4,7 +4,7 @@ * http://www.reactos.org * IRC: irc.freenode.net #reactos-pl; * UTF-8 conversion by Caemyr (May, 2011) - * Polish translation updated by pithwz - Piotr Hetnarowicz (piotrhwz(a)gmail.com) (August, 2020) + * Polish translation updated by pithwz - Piotr Hetnarowicz (piotrhwz(a)gmail.com) (May, 2021) */ LANGUAGE LANG_POLISH, SUBLANG_DEFAULT @@ -33,7 +33,7 @@ BEGIN MENUITEM "", -1, MFT_SEPARATOR MENUITEM "&Zamknij", IDM_FILE_CLOSE END - POPUP "&Edytuj", FCIDM_MENU_EDIT + POPUP "&Edycja", FCIDM_MENU_EDIT BEGIN MENUITEM "", -1, MFT_SEPARATOR END @@ -50,7 +50,7 @@ BEGIN MENUITEM "&Ulubione\tCtrl+I", IDM_EXPLORERBAR_FAVORITES MENUITEM "&Multimedia", IDM_EXPLORERBAR_MEDIA MENUITEM "&Historia\tCtrl+H", IDM_EXPLORERBAR_HISTORY - MENUITEM "&Katalogi", IDM_EXPLORERBAR_FOLDERS + MENUITEM "&Foldery", IDM_EXPLORERBAR_FOLDERS MENUITEM "", IDM_EXPLORERBAR_SEPARATOR END MENUITEM "", FCIDM_MENU_VIEW_SEP_OPTIONS, MFT_SEPARATOR @@ -271,7 +271,7 @@ BEGIN 9553 "Pokazuje pasek Wyszukiwania." 9554 "Pokazuje pasek Ulubionych." 9555 "Pokazuje pasek Historii." - 9557 "Pokazuje pasek Katalogów." + 9557 "Pokazuje pasek folderów." 9559 "Pokazuje pasek Multimediów." END

3 years, 4 months

[reactos] 01/01: [WINLOGON] Polish translation update (#3702)

by Piotr Hetnarowicz

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=0e18985e5608fc5bd4c63… commit 0e18985e5608fc5bd4c63c1aa1298490da3d6a87 Author: Piotr Hetnarowicz <40692062+pithwz(a)users.noreply.github.com> AuthorDate: Wed Jun 2 11:52:10 2021 +0200 Commit: GitHub <noreply(a)github.com> CommitDate: Wed Jun 2 11:52:10 2021 +0200 [WINLOGON] Polish translation update (#3702) --- base/system/winlogon/lang/pl-PL.rc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/base/system/winlogon/lang/pl-PL.rc b/base/system/winlogon/lang/pl-PL.rc index 85674ec2d1d..2283c9a5c98 100644 --- a/base/system/winlogon/lang/pl-PL.rc +++ b/base/system/winlogon/lang/pl-PL.rc @@ -3,7 +3,7 @@ * https://sourceforge.net/projects/reactospl * UTF-8 conversion by Caemyr (May, 2011) * Updated by Marcin Mikołajczak <me(a)m4sk.in> (September, 2017) - * Updated by Piotr Hetnarowicz <piotrhwz(a)gmail.com> (February, 2020) + * Updated by Piotr Hetnarowicz <piotrhwz(a)gmail.com> (May, 2021) */ LANGUAGE LANG_POLISH, SUBLANG_DEFAULT @@ -52,8 +52,8 @@ BEGIN IDS_RUNNINGLOGONSCRIPTS "Trwa uruchamianie skryptów logowania..." IDS_LOADINGYOURPERSONALSETTINGS "Trwa ładowanie ustawień osobistych..." IDS_CLOSINGNETWORKCONNECTIONS "Trwa zamykanie połączeń sieciowych..." - IDS_REACTOSISRESTARTING "Restarting..." - IDS_REACTOSISSHUTTINGDOWN "Shutting down..." + IDS_REACTOSISRESTARTING "Trwa ponowne uruchamianie..." + IDS_REACTOSISSHUTTINGDOWN "Trwa zamykanie..." IDS_PREPARETOSTANDBY "Trwa przygotowywanie do przejścia w stan wstrzymania..." IDS_PREPARETOHIBERNATE "Trwa przygotowywanie do hibernacji..." IDS_SAVEYOURSETTINGS "Trwa zapisywanie ustawień..."

3 years, 4 months

[reactos] 01/01: [SHELL32] Polish translation update (#3701)

by Piotr Hetnarowicz

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=d05a20e7b330db5058276… commit d05a20e7b330db5058276306e00e42da529f095a Author: Piotr Hetnarowicz <40692062+pithwz(a)users.noreply.github.com> AuthorDate: Wed Jun 2 11:50:54 2021 +0200 Commit: GitHub <noreply(a)github.com> CommitDate: Wed Jun 2 11:50:54 2021 +0200 [SHELL32] Polish translation update (#3701) --- dll/win32/shell32/lang/pl-PL.rc | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/dll/win32/shell32/lang/pl-PL.rc b/dll/win32/shell32/lang/pl-PL.rc index 9e5e0f4c080..be54e6e9282 100644 --- a/dll/win32/shell32/lang/pl-PL.rc +++ b/dll/win32/shell32/lang/pl-PL.rc @@ -1,15 +1,15 @@ /* * Updated by Saibamen (July, 2015) * Updated by BlackDragonDv (January, 2018) - * Updated by Piotr Hetnarowicz <piotrhwz(a)gmail.com> (February, 2021) + * Updated by Piotr Hetnarowicz <piotrhwz(a)gmail.com> (May, 2021) */ LANGUAGE LANG_POLISH, SUBLANG_DEFAULT MENU_001 MENUEX BEGIN - MENUITEM "&Duże Ikony", FCIDM_SHVIEW_BIGICON - MENUITEM "&Małe Ikony", FCIDM_SHVIEW_SMALLICON + MENUITEM "&Duże ikony", FCIDM_SHVIEW_BIGICON + MENUITEM "&Małe ikony", FCIDM_SHVIEW_SMALLICON MENUITEM "&Lista", FCIDM_SHVIEW_LISTVIEW MENUITEM "&Szczegóły", FCIDM_SHVIEW_REPORTVIEW MENUITEM "", -1, MFT_SEPARATOR @@ -28,8 +28,8 @@ BEGIN BEGIN POPUP "&Widok", FCIDM_SHVIEW_VIEW BEGIN - MENUITEM "&Duże Ikony", FCIDM_SHVIEW_BIGICON - MENUITEM "&Małe Ikony", FCIDM_SHVIEW_SMALLICON + MENUITEM "&Duże ikony", FCIDM_SHVIEW_BIGICON + MENUITEM "&Małe ikony", FCIDM_SHVIEW_SMALLICON MENUITEM "&Lista", FCIDM_SHVIEW_LISTVIEW MENUITEM "&Szczegóły", FCIDM_SHVIEW_REPORTVIEW END @@ -784,8 +784,8 @@ BEGIN IDS_ABOUT_VERSION_STRING "Wersja %S (%S)" /* context menus */ - IDS_VIEW_LARGE "&Duże Ikony" - IDS_VIEW_SMALL "&Małe Ikony" + IDS_VIEW_LARGE "&Duże ikony" + IDS_VIEW_SMALL "&Małe ikony" IDS_VIEW_LIST "&Lista" IDS_VIEW_DETAILS "&Szczegóły" IDS_SELECT "Zaznacz" @@ -846,8 +846,8 @@ BEGIN IDS_FORMAT_COMPLETE "Formatowanie zakończone." /* Warning format system drive dialog strings */ - IDS_NO_FORMAT_TITLE "Cannot format this volume" - IDS_NO_FORMAT "This volume cannot be formatted! It contains important system files in order for ReactOS to run." + IDS_NO_FORMAT_TITLE "Nie można sformatować tego dysku" + IDS_NO_FORMAT "Nie można sformatować tego dysku! Zawiera ważne pliki systemowe wymagane do uruchamiania i pracy systemu ReactOS." /* Run File dialog */ IDS_RUNDLG_ERROR "Nie można wyświetlić okna Uruchom (błąd wewnętrzny)" @@ -981,8 +981,8 @@ BEGIN IDS_EXE_DESCRIPTION "Opis:" IDS_MENU_EMPTY "(Puste)" - IDS_OBJECTS "%d Obiektów" - IDS_OBJECTS_SELECTED "%d Zaznaczonych obiektów" + IDS_OBJECTS "Elementów: %d" + IDS_OBJECTS_SELECTED "Zaznaczonych elementów: %d" IDS_ADVANCED_FOLDER "Pliki i Foldery" IDS_ADVANCED_NET_CRAWLER "Automatycznie wyszukuj foldery sieciowe i drukarki" @@ -1036,5 +1036,5 @@ BEGIN IDS_LOG_OFF_DESC "Zamyka programy i kończy sesję systemu ReactOS." IDS_SWITCH_USER_DESC "Umożliwia innemu użytkownikowi zalogowanie się, podczas gdy Twoje programy i pliki są otwarte.\r\n\r\n(Możesz także przełączać użytkowników naciskając klawisze logo + L.)" IDS_LOG_OFF_TITLE "Wyloguj" - IDS_SWITCH_USER_TITLE "Switch User" + IDS_SWITCH_USER_TITLE "Przełącz użytkownika" END

3 years, 4 months

[reactos] 01/01: [NTOS:SE] Implement logon session deletion

by George Bișoc

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=06b0d2e380183c3c76f49… commit 06b0d2e380183c3c76f49fd166efdf91ab5b79c2 Author: George Bișoc <george.bisoc(a)reactos.org> AuthorDate: Sun May 23 12:21:47 2021 +0200 Commit: George Bișoc <george.bisoc(a)reactos.org> CommitDate: Wed Jun 2 11:09:01 2021 +0200 [NTOS:SE] Implement logon session deletion And declare a prototype for SepCleanupLUIDDeviceMapDirectory and annotate it with SAL. --- ntoskrnl/se/srm.c | 113 +++++++++++++++++++++++++++++++++++++++++++++++++++--- 1 file changed, 107 insertions(+), 6 deletions(-) diff --git a/ntoskrnl/se/srm.c b/ntoskrnl/se/srm.c index ffd5547fa32..6033e07d631 100644 --- a/ntoskrnl/se/srm.c +++ b/ntoskrnl/se/srm.c @@ -33,6 +33,11 @@ NTAPI SepRmCommandServerThread( PVOID StartContext); +static +NTSTATUS +SepCleanupLUIDDeviceMapDirectory( + _In_ PLUID LogonLuid); + static NTSTATUS SepRmCreateLogonSession( @@ -376,17 +381,113 @@ Leave: return Status; } +/** + * @brief + * Deletes a logon session from the logon sessions database. + * + * @param[in] LogonLuid + * A logon ID represented as a LUID. This LUID is used to point + * the exact logon session saved within the database. + * + * @return + * STATUS_SUCCESS is returned if the logon session has been deleted successfully. + * STATUS_NO_SUCH_LOGON_SESSION is returned if the logon session with the submitted + * LUID doesn't exist. STATUS_BAD_LOGON_SESSION_STATE is returned if the logon session + * is still in use and we're not allowed to delete it, or if a system or anonymous session + * is submitted and we're not allowed to delete them as they're internal parts of the system. + * Otherwise a failure NTSTATUS code is returned. + */ static NTSTATUS SepRmDeleteLogonSession( - PLUID LogonLuid) + _In_ PLUID LogonLuid) { + PSEP_LOGON_SESSION_REFERENCES SessionToDelete; + NTSTATUS Status; + PAGED_CODE(); + DPRINT("SepRmDeleteLogonSession(%08lx:%08lx)\n", LogonLuid->HighPart, LogonLuid->LowPart); - UNIMPLEMENTED; - NT_ASSERT(FALSE); - return STATUS_NOT_IMPLEMENTED; + /* Acquire the database lock */ + KeAcquireGuardedMutex(&SepRmDbLock); + + /* Loop over the existing logon sessions */ + for (SessionToDelete = SepLogonSessions; + SessionToDelete != NULL; + SessionToDelete = SessionToDelete->Next) + { + /* + * Does the actual logon session exist in the + * saved logon sessions database with the LUID + * provided? + */ + if (RtlEqualLuid(&SessionToDelete->LogonId, LogonLuid)) + { + /* Did the caller supply one of these internal sessions? */ + if (RtlEqualLuid(&SessionToDelete->LogonId, &SeSystemAuthenticationId) || + RtlEqualLuid(&SessionToDelete->LogonId, &SeAnonymousAuthenticationId)) + { + /* These logons are critical stuff, we can't delete them */ + DPRINT1("SepRmDeleteLogonSession(): We're not allowed to delete anonymous/system sessions!\n"); + Status = STATUS_BAD_LOGON_SESSION_STATE; + goto Leave; + } + else + { + /* We found the logon as exactly as we wanted, break the loop */ + break; + } + } + } + + /* + * If we reach this then that means we've exhausted all the logon + * sessions and couldn't find one with the desired LUID. + */ + if (SessionToDelete == NULL) + { + DPRINT1("SepRmDeleteLogonSession(): The logon session with this LUID doesn't exist!\n"); + Status = STATUS_NO_SUCH_LOGON_SESSION; + goto Leave; + } + + /* Is somebody still using this logon session? */ + if (SessionToDelete->ReferenceCount != 0) + { + /* The logon session is still in use, we cannot delete it... */ + DPRINT1("SepRmDeleteLogonSession(): The logon session is still in use!\n"); + Status = STATUS_BAD_LOGON_SESSION_STATE; + goto Leave; + } + + /* If we have a LUID device map, clean it */ + if (SessionToDelete->pDeviceMap != NULL) + { + Status = SepCleanupLUIDDeviceMapDirectory(LogonLuid); + if (!NT_SUCCESS(Status)) + { + /* + * We had one job on cleaning the device map directory + * of the logon session but we failed, quit... + */ + DPRINT1("SepRmDeleteLogonSession(): Failed to clean the LUID device map directory of the logon (Status: 0x%lx)\n", Status); + goto Leave; + } + + /* And dereference the device map of the logon */ + ObfDereferenceDeviceMap(SessionToDelete->pDeviceMap); + } + + /* If we're here then we've deleted the logon session successfully */ + DPRINT("SepRmDeleteLogonSession(): Logon session deleted with success!\n"); + Status = STATUS_SUCCESS; + ExFreePoolWithTag(SessionToDelete, SEP_LOGON_SESSION_TAG); + +Leave: + /* Release the database lock */ + KeReleaseGuardedMutex(&SepRmDbLock); + return Status; } @@ -429,10 +530,10 @@ SepRmReferenceLogonSession( return STATUS_NO_SUCH_LOGON_SESSION; } - +static NTSTATUS SepCleanupLUIDDeviceMapDirectory( - PLUID LogonLuid) + _In_ PLUID LogonLuid) { BOOLEAN UseCurrentProc; KAPC_STATE ApcState;

3 years, 4 months

[reactos] 01/01: [CMAKE] CMakeLists.txt: Remove NO_UNDERSCORE_PREFIX leftovers

by Serge Gautherie

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=2dcc40fb3ed0f87f1dc6c… commit 2dcc40fb3ed0f87f1dc6c588fcbee9db7e9d1764 Author: Serge Gautherie <reactos-git_serge_171003(a)gautherie.fr> AuthorDate: Mon May 24 08:56:17 2021 +0200 Commit: Jérôme Gardou <zefklop(a)users.noreply.github.com> CommitDate: Wed Jun 2 10:04:21 2021 +0200 [CMAKE] CMakeLists.txt: Remove NO_UNDERSCORE_PREFIX leftovers And switch to add_compile_definitions(). Addendum to 9efafd6. --- CMakeLists.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index b460c642887..0a63925f8ce 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -274,9 +274,9 @@ Enable this if the module uses typeid or dynamic_cast. You will probably need to if(ARCH STREQUAL "i386") add_definitions(-DUSE_COMPILER_EXCEPTIONS -D_USE_32BIT_TIME_T) elseif(ARCH STREQUAL "amd64") - add_definitions(-DUSE_COMPILER_EXCEPTIONS -DNO_UNDERSCORE_PREFIX) + add_compile_definitions(USE_COMPILER_EXCEPTIONS) elseif(ARCH STREQUAL "arm") - add_definitions(-DUSE_COMPILER_EXCEPTIONS -DNO_UNDERSCORE_PREFIX) + add_compile_definitions(USE_COMPILER_EXCEPTIONS) endif() # Activate support for assembly source files

3 years, 4 months

[reactos] 01/01: [WIN32SS][NTUSER] ShowWindow.SW_MINIMIZE should show window (#3700)

by Katayama Hirofumi MZ

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=59d4c1120310b7c08641c… commit 59d4c1120310b7c08641cc3aab82072251900d98 Author: Katayama Hirofumi MZ <katayama.hirofumi.mz(a)gmail.com> AuthorDate: Tue Jun 1 11:11:23 2021 +0900 Commit: GitHub <noreply(a)github.com> CommitDate: Tue Jun 1 11:11:23 2021 +0900 [WIN32SS][NTUSER] ShowWindow.SW_MINIMIZE should show window (#3700) - user32!ShowWindow.SW_MINIMIZE should show the window. - Fix the return value of ShowWindow function on invalid parameter. CORE-15669 --- win32ss/user/ntuser/winpos.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/win32ss/user/ntuser/winpos.c b/win32ss/user/ntuser/winpos.c index 71cf8a1cf8d..550a074c6c1 100644 --- a/win32ss/user/ntuser/winpos.c +++ b/win32ss/user/ntuser/winpos.c @@ -2560,9 +2560,8 @@ co_WinPosShowWindow(PWND Wnd, INT Cmd) Swp |= SWP_NOACTIVATE | SWP_NOZORDER; /* Fall through. */ case SW_SHOWMINIMIZED: + case SW_MINIMIZE: /* CORE-15669: SW_MINIMIZE also shows */ Swp |= SWP_SHOWWINDOW; - /* Fall through. */ - case SW_MINIMIZE: { Swp |= SWP_NOACTIVATE; if (!(style & WS_MINIMIZE)) @@ -2657,7 +2656,7 @@ co_WinPosShowWindow(PWND Wnd, INT Cmd) default: //ERR("co_WinPosShowWindow Exit Good 4\n"); - return WasVisible; + return FALSE; } ShowFlag = (Cmd != SW_HIDE);

3 years, 4 months

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs June 2021