Ros-diffs February 2022

ros-diffs@reactos.org

17 participants
108 discussions

[reactos] 01/10: [FREELDR] Improve progress bar support, adapted from Inbv.

by Hermès Bélusca-Maïto

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=c322610f6e1a407f3bf2c… commit c322610f6e1a407f3bf2c2a915ab2526b6b9f91d Author: Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org> AuthorDate: Mon Feb 14 02:28:53 2022 +0100 Commit: Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org> CommitDate: Mon Feb 21 02:53:54 2022 +0100 [FREELDR] Improve progress bar support, adapted from Inbv. - Improve accuracy/progression smoothness when loading drivers. - Allow changing text and percentage independently. --- boot/freeldr/freeldr/disk/ramdisk.c | 18 +-- boot/freeldr/freeldr/include/ui.h | 95 +++++++++++++-- boot/freeldr/freeldr/include/ui/minitui.h | 16 ++- boot/freeldr/freeldr/include/ui/noui.h | 19 ++- boot/freeldr/freeldr/include/ui/tui.h | 22 +--- boot/freeldr/freeldr/linuxboot.c | 6 +- boot/freeldr/freeldr/ntldr/setupldr.c | 4 +- boot/freeldr/freeldr/ntldr/winldr.c | 27 +++-- boot/freeldr/freeldr/ntldr/winldr.h | 2 + boot/freeldr/freeldr/ui/directui.c | 31 ----- boot/freeldr/freeldr/ui/minitui.c | 133 ++++++++++++-------- boot/freeldr/freeldr/ui/noui.c | 23 +++- boot/freeldr/freeldr/ui/tui.c | 135 +++++++++++++++------ boot/freeldr/freeldr/ui/ui.c | 195 ++++++++++++++++++++++++------ 14 files changed, 500 insertions(+), 226 deletions(-) diff --git a/boot/freeldr/freeldr/disk/ramdisk.c b/boot/freeldr/freeldr/disk/ramdisk.c index 58f8a37d528..6306cad88be 100644 --- a/boot/freeldr/freeldr/disk/ramdisk.c +++ b/boot/freeldr/freeldr/disk/ramdisk.c @@ -111,13 +111,12 @@ RamDiskLoadVirtualFile( ULONG RamFileId; ULONG ChunkSize, Count; ULONGLONG TotalRead; - PCHAR MsgBuffer = "Loading RamDisk..."; ULONG PercentPerChunk, Percent; FILEINFORMATION Information; LARGE_INTEGER Position; /* Display progress */ - UiDrawProgressBarCenter(1, 100, MsgBuffer); + UiDrawProgressBarCenter("Loading RamDisk..."); /* Try opening the Ramdisk file */ Status = FsOpenFile(FileName, DefaultPath, OpenReadOnly, &RamFileId); @@ -135,8 +134,8 @@ RamDiskLoadVirtualFile( /* FIXME: For now, limit RAM disks to 4GB */ if (Information.EndingAddress.HighPart != 0) { - UiMessageBox("RAM disk too big."); ArcClose(RamFileId); + UiMessageBox("RAM disk too big."); return ENOMEM; } RamDiskFileSize = Information.EndingAddress.QuadPart; @@ -145,20 +144,22 @@ RamDiskLoadVirtualFile( /* Allocate memory for it */ ChunkSize = 8 * 1024 * 1024; if (RamDiskFileSize < ChunkSize) - Percent = PercentPerChunk = 0; + PercentPerChunk = 0; else - Percent = PercentPerChunk = 100 / (RamDiskFileSize / ChunkSize); + PercentPerChunk = 100 * ChunkSize / RamDiskFileSize; RamDiskBase = MmAllocateMemoryWithType(RamDiskFileSize, LoaderXIPRom); if (!RamDiskBase) { - UiMessageBox("Failed to allocate memory for RAM disk."); + RamDiskFileSize = 0; ArcClose(RamFileId); + UiMessageBox("Failed to allocate memory for RAM disk."); return ENOMEM; } /* * Read it in chunks */ + Percent = 0; for (TotalRead = 0; TotalRead < RamDiskFileSize; TotalRead += ChunkSize) { /* Check if we're at the last chunk */ @@ -168,8 +169,8 @@ RamDiskLoadVirtualFile( ChunkSize = (ULONG)(RamDiskFileSize - TotalRead); } - /* Draw progress */ - UiDrawProgressBarCenter(Percent, 100, MsgBuffer); + /* Update progress */ + UiUpdateProgressBar(Percent, NULL); Percent += PercentPerChunk; /* Copy the contents */ @@ -194,6 +195,7 @@ RamDiskLoadVirtualFile( return ((Status != ESUCCESS) ? Status : EIO); } } + UiUpdateProgressBar(100, NULL); ArcClose(RamFileId); diff --git a/boot/freeldr/freeldr/include/ui.h b/boot/freeldr/freeldr/include/ui.h index 4308b95c0f4..938192e19b8 100644 --- a/boot/freeldr/freeldr/include/ui.h +++ b/boot/freeldr/freeldr/include/ui.h @@ -95,12 +95,74 @@ VOID UiInfoBox(PCSTR MessageText); // Displays a i VOID UiMessageBox(PCSTR Format, ...); // Displays a message box on the screen with an ok button VOID UiMessageBoxCritical(PCSTR MessageText); // Displays a message box on the screen with an ok button using no system resources + +/* Loading Progress-Bar Functions ********************************************/ + +/* + * Loading progress bar, based on the one from NTOS Inbv. + * Supports progress within sub-ranges, used when loading + * with an unknown number of steps. + */ +typedef struct _UI_PROGRESS_BAR +{ + // UI_PROGRESS_STATE + struct + { + ULONG Floor; + // ULONG Ceiling; + ULONG Bias; + } State; + + // BT_PROGRESS_INDICATOR + struct + { + ULONG Count; + ULONG Expected; + ULONG Percentage; + } Indicator; + + ULONG Left; + ULONG Top; + ULONG Right; + ULONG Bottom; + // ULONG Width; // == Right - Left + 1; + BOOLEAN Show; +} UI_PROGRESS_BAR, *PUI_PROGRESS_BAR; + +extern UI_PROGRESS_BAR UiProgressBar; + +VOID +UiInitProgressBar( + _In_ ULONG Left, + _In_ ULONG Top, + _In_ ULONG Right, + _In_ ULONG Bottom, + _In_ PCSTR ProgressText); + +/* Indicate loading progress without any specific number of steps */ +VOID +UiIndicateProgress(VOID); + +/* Set a progress loading percentage range */ +VOID +UiSetProgressBarSubset( + _In_ ULONG Floor, + _In_ ULONG Ceiling); + +/* Update the loading progress percentage within a selected range */ +VOID +UiUpdateProgressBar( + _In_ ULONG Percentage, + _In_opt_ PCSTR ProgressText); + +VOID +UiSetProgressBarText( + _In_ PCSTR ProgressText); + /* Draws the progress bar showing nPos percent filled */ VOID UiDrawProgressBarCenter( - _In_ ULONG Position, - _In_ ULONG Range, - _Inout_z_ PSTR ProgressText); + _In_ PCSTR ProgressText); /* Draws the progress bar showing nPos percent filled */ VOID @@ -109,9 +171,8 @@ UiDrawProgressBar( _In_ ULONG Top, _In_ ULONG Right, _In_ ULONG Bottom, - _In_ ULONG Position, - _In_ ULONG Range, - _Inout_z_ PSTR ProgressText); + _In_ PCSTR ProgressText); + // Displays all the message boxes in a given section. VOID @@ -123,14 +184,11 @@ UiShowMessageBoxesInArgv( IN ULONG Argc, IN PCHAR Argv[]); -VOID UiEscapeString(PCHAR String); // Processes a string and changes all occurrences of "\n" to '\n' BOOLEAN UiEditBox(PCSTR MessageText, PCHAR EditTextBuffer, ULONG Length); UCHAR UiTextToColor(PCSTR ColorText); // Converts the text color into it's equivalent color value UCHAR UiTextToFillStyle(PCSTR FillStyleText); // Converts the text fill into it's equivalent fill value -VOID UiTruncateStringEllipsis(PCHAR StringText, ULONG MaxChars); // Truncates a string to MaxChars by adding an ellipsis on the end '...' - VOID UiFadeInBackdrop(VOID); // Draws the backdrop and fades the screen in VOID UiFadeOut(VOID); // Fades the screen out @@ -200,8 +258,23 @@ typedef struct tagUIVTBL VOID (*UpdateDateTime)(VOID); VOID (*MessageBox)(PCSTR MessageText); VOID (*MessageBoxCritical)(PCSTR MessageText); - VOID (*DrawProgressBarCenter)(ULONG Position, ULONG Range, PCHAR ProgressText); - VOID (*DrawProgressBar)(ULONG Left, ULONG Top, ULONG Right, ULONG Bottom, ULONG Position, ULONG Range, PCHAR ProgressText); + + VOID (*DrawProgressBarCenter)( + _In_ PCSTR ProgressText); + + VOID (*DrawProgressBar)( + _In_ ULONG Left, + _In_ ULONG Top, + _In_ ULONG Right, + _In_ ULONG Bottom, + _In_ PCSTR ProgressText); + + VOID (*SetProgressBarText)( + _In_ PCSTR ProgressText); + + VOID (*TickProgressBar)( + _In_ ULONG SubPercentTimes100); + BOOLEAN (*EditBox)(PCSTR MessageText, PCHAR EditTextBuffer, ULONG Length); UCHAR (*TextToColor)(PCSTR ColorText); UCHAR (*TextToFillStyle)(PCSTR FillStyleText); diff --git a/boot/freeldr/freeldr/include/ui/minitui.h b/boot/freeldr/freeldr/include/ui/minitui.h index 4a710cd8b6f..6db89b41cc0 100644 --- a/boot/freeldr/freeldr/include/ui/minitui.h +++ b/boot/freeldr/freeldr/include/ui/minitui.h @@ -13,12 +13,18 @@ VOID MiniTuiDrawBackdrop(VOID); VOID MiniTuiDrawStatusText(PCSTR StatusText); +VOID +MiniTuiSetProgressBarText( + _In_ PCSTR ProgressText); + +VOID +MiniTuiTickProgressBar( + _In_ ULONG SubPercentTimes100); + /* Draws the progress bar showing nPos percent filled */ VOID MiniTuiDrawProgressBarCenter( - _In_ ULONG Position, - _In_ ULONG Range, - _Inout_z_ PSTR ProgressText); + _In_ PCSTR ProgressText); /* Draws the progress bar showing nPos percent filled */ VOID @@ -27,9 +33,7 @@ MiniTuiDrawProgressBar( _In_ ULONG Top, _In_ ULONG Right, _In_ ULONG Bottom, - _In_ ULONG Position, - _In_ ULONG Range, - _Inout_z_ PSTR ProgressText); + _In_ PCSTR ProgressText); /* Menu Functions ************************************************************/ diff --git a/boot/freeldr/freeldr/include/ui/noui.h b/boot/freeldr/freeldr/include/ui/noui.h index dca5db172e0..72eca1a9298 100644 --- a/boot/freeldr/freeldr/include/ui/noui.h +++ b/boot/freeldr/freeldr/include/ui/noui.h @@ -50,12 +50,20 @@ VOID NoUiUpdateDateTime(VOID); VOID NoUiMessageBox(PCSTR MessageText); VOID NoUiMessageBoxCritical(PCSTR MessageText); +/* Loading Progress-Bar Functions ********************************************/ + +VOID +NoUiSetProgressBarText( + _In_ PCSTR ProgressText); + +VOID +NoUiTickProgressBar( + _In_ ULONG SubPercentTimes100); + /* Draws the progress bar showing nPos percent filled */ VOID NoUiDrawProgressBarCenter( - _In_ ULONG Position, - _In_ ULONG Range, - _Inout_z_ PSTR ProgressText); + _In_ PCSTR ProgressText); /* Draws the progress bar showing nPos percent filled */ VOID @@ -64,9 +72,8 @@ NoUiDrawProgressBar( _In_ ULONG Top, _In_ ULONG Right, _In_ ULONG Bottom, - _In_ ULONG Position, - _In_ ULONG Range, - _Inout_z_ PSTR ProgressText); + _In_ PCSTR ProgressText); + BOOLEAN NoUiEditBox(PCSTR MessageText, PCHAR EditTextBuffer, ULONG Length); UCHAR NoUiTextToColor(PCSTR ColorText); diff --git a/boot/freeldr/freeldr/include/ui/tui.h b/boot/freeldr/freeldr/include/ui/tui.h index 27918f47bd7..b952a06822d 100644 --- a/boot/freeldr/freeldr/include/ui/tui.h +++ b/boot/freeldr/freeldr/include/ui/tui.h @@ -25,6 +25,10 @@ INT TuiPrintf( _In_ PCSTR Format, ...); +VOID +TuiTruncateStringEllipsis( + _Inout_z_ PSTR StringText, + _In_ ULONG MaxChars); #define TUI_TITLE_BOX_CHAR_HEIGHT 5 @@ -72,24 +76,6 @@ VOID TuiRestoreScreen(PUCHAR Buffer); // Restores the VOID TuiMessageBox(PCSTR MessageText); // Displays a message box on the screen with an ok button VOID TuiMessageBoxCritical(PCSTR MessageText); // Displays a message box on the screen with an ok button using no system resources -/* Draws the progress bar showing nPos percent filled */ -VOID -TuiDrawProgressBarCenter( - _In_ ULONG Position, - _In_ ULONG Range, - _Inout_z_ PSTR ProgressText); - -/* Draws the progress bar showing nPos percent filled */ -VOID -TuiDrawProgressBar( - _In_ ULONG Left, - _In_ ULONG Top, - _In_ ULONG Right, - _In_ ULONG Bottom, - _In_ ULONG Position, - _In_ ULONG Range, - _Inout_z_ PSTR ProgressText); - BOOLEAN TuiEditBox(PCSTR MessageText, PCHAR EditTextBuffer, ULONG Length); UCHAR TuiTextToColor(PCSTR ColorText); // Converts the text color into it's equivalent color value UCHAR TuiTextToFillStyle(PCSTR FillStyleText); // Converts the text fill into it's equivalent fill value diff --git a/boot/freeldr/freeldr/linuxboot.c b/boot/freeldr/freeldr/linuxboot.c index fae1f8da6a2..5375aafe796 100644 --- a/boot/freeldr/freeldr/linuxboot.c +++ b/boot/freeldr/freeldr/linuxboot.c @@ -107,7 +107,7 @@ LoadAndBootLinux( UiDrawBackdrop(); UiDrawStatusText(LinuxBootDescription); - UiDrawProgressBarCenter(0, 100, LinuxBootDescription); + UiDrawProgressBarCenter(LinuxBootDescription); /* Find all the message box settings and run them */ UiShowMessageBoxesInArgv(Argc, Argv); @@ -445,7 +445,7 @@ static BOOLEAN LinuxReadKernel(ULONG LinuxKernelFile) BytesLoaded += LINUX_READ_CHUNK_SIZE; LoadAddress = (PVOID)((ULONG_PTR)LoadAddress + LINUX_READ_CHUNK_SIZE); - UiDrawProgressBarCenter(BytesLoaded, LinuxKernelSize + LinuxInitrdSize, LinuxBootDescription); + UiUpdateProgressBar(BytesLoaded * 100 / (LinuxKernelSize + LinuxInitrdSize), NULL); } return TRUE; @@ -540,7 +540,7 @@ static BOOLEAN LinuxReadInitrd(ULONG LinuxInitrdFile) BytesLoaded += LINUX_READ_CHUNK_SIZE; LinuxInitrdLoadAddress = (PVOID)((ULONG_PTR)LinuxInitrdLoadAddress + LINUX_READ_CHUNK_SIZE); - UiDrawProgressBarCenter(BytesLoaded + LinuxKernelSize, LinuxInitrdSize + LinuxKernelSize, LinuxBootDescription); + UiUpdateProgressBar((BytesLoaded + LinuxKernelSize) * 100 / (LinuxInitrdSize + LinuxKernelSize), NULL); } return TRUE; diff --git a/boot/freeldr/freeldr/ntldr/setupldr.c b/boot/freeldr/freeldr/ntldr/setupldr.c index 2deaf6ce5ba..f7a330be2fd 100644 --- a/boot/freeldr/freeldr/ntldr/setupldr.c +++ b/boot/freeldr/freeldr/ntldr/setupldr.c @@ -493,7 +493,7 @@ LoadReactOSSetup( /* Let the user know we started loading */ UiDrawBackdrop(); UiDrawStatusText("Setup is loading..."); - UiDrawProgressBarCenter(1, 100, "Loading ReactOS Setup..."); + UiDrawProgressBarCenter("Loading ReactOS Setup..."); /* Retrieve the system path */ *BootPath = ANSI_NULL; @@ -743,7 +743,7 @@ LoadReactOSSetup( SetupBlock->Flags = SETUPLDR_TEXT_MODE; /* Load the "setupreg.hiv" setup system hive */ - if (!SosEnabled) UiDrawProgressBarCenter(15, 100, "Loading setup system hive..."); + UiUpdateProgressBar(15, "Loading setup system hive..."); Success = WinLdrInitSystemHive(LoaderBlock, BootPath, TRUE); TRACE("Setup SYSTEM hive %s\n", (Success ? "loaded" : "not loaded")); /* Bail out if failure */ diff --git a/boot/freeldr/freeldr/ntldr/winldr.c b/boot/freeldr/freeldr/ntldr/winldr.c index 317d59a35bd..5b06bef6e0f 100644 --- a/boot/freeldr/freeldr/ntldr/winldr.c +++ b/boot/freeldr/freeldr/ntldr/winldr.c @@ -66,7 +66,8 @@ NtLdrOutputLoadMsg( RtlStringCbPrintfA(ProgressString, sizeof(ProgressString), "Loading %s...", (Description ? Description : FileName)); - // UiDrawProgressBarCenter(1, 100, ProgressString); + // UiSetProgressBarText(ProgressString); + // UiIndicateProgress(); UiDrawStatusText(ProgressString); } } @@ -379,12 +380,12 @@ WinLdrLoadBootDrivers(PLOADER_PARAMETER_BLOCK LoaderBlock, // Paths are relative (FIXME: Are they always relative?) // Load it + UiIndicateProgress(); Success = WinLdrLoadDeviceDriver(&LoaderBlock->LoadOrderListHead, BootPath, &BootDriver->FilePath, 0, &BootDriver->LdrEntry); - if (Success) { // Convert the RegistryPath and DTE addresses to VA since we are not going to use it anymore @@ -503,7 +504,7 @@ LoadModule( PVOID BaseAddress; RtlStringCbPrintfA(ProgressString, sizeof(ProgressString), "Loading %s...", File); - if (!SosEnabled) UiDrawProgressBarCenter(Percentage, 100, ProgressString); + UiUpdateProgressBar(Percentage, ProgressString); RtlStringCbCopyA(FullFileName, sizeof(FullFileName), Path); RtlStringCbCatA(FullFileName, sizeof(FullFileName), File); @@ -609,7 +610,7 @@ LoadWindowsCore(IN USHORT OperatingSystemVersion, /* Load the HAL */ HalBase = LoadModule(LoaderBlock, DirPath, HalFileName, - "hal.dll", LoaderHalCode, &HalDTE, 45); + "hal.dll", LoaderHalCode, &HalDTE, 35); if (!HalBase) { ERR("LoadModule('%s') failed\n", HalFileName); @@ -684,7 +685,7 @@ LoadWindowsCore(IN USHORT OperatingSystemVersion, /* Load the KD DLL. Override its base DLL name to the default "KDCOM.DLL". */ KdDllBase = LoadModule(LoaderBlock, DirPath, KdDllName, - "kdcom.dll", LoaderSystemCode, &KdDllDTE, 60); + "kdcom.dll", LoaderSystemCode, &KdDllDTE, 40); if (!KdDllBase) { /* If we failed to load a custom KD DLL, fall back to the standard one */ @@ -697,7 +698,7 @@ LoadWindowsCore(IN USHORT OperatingSystemVersion, RtlStringCbCopyA(KdDllName, sizeof(KdDllName), "kdcom.dll"); KdDllBase = LoadModule(LoaderBlock, DirPath, KdDllName, - "kdcom.dll", LoaderSystemCode, &KdDllDTE, 60); + "kdcom.dll", LoaderSystemCode, &KdDllDTE, 40); } if (!KdDllBase) @@ -939,7 +940,7 @@ LoadAndBootWindows( /* Let the user know we started loading */ UiDrawBackdrop(); UiDrawStatusText("Loading..."); - UiDrawProgressBarCenter(1, 100, "Loading NT..."); + UiDrawProgressBarCenter("Loading NT..."); /* Retrieve the system path */ *BootPath = ANSI_NULL; @@ -1043,7 +1044,7 @@ LoadAndBootWindows( AllocateAndInitLPB(OperatingSystemVersion, &LoaderBlock); /* Load the system hive */ - if (!SosEnabled) UiDrawProgressBarCenter(15, 100, "Loading system hive..."); + UiUpdateProgressBar(15, "Loading system hive..."); Success = WinLdrInitSystemHive(LoaderBlock, BootPath, FALSE); TRACE("SYSTEM hive %s\n", (Success ? "loaded" : "not loaded")); /* Bail out if failure */ @@ -1101,7 +1102,7 @@ LoadAndBootWindowsCommon( SystemRoot = strstr(BootPath, "\\"); /* Detect hardware */ - if (!SosEnabled) UiDrawProgressBarCenter(20, 100, "Detecting hardware..."); + UiUpdateProgressBar(20, "Detecting hardware..."); LoaderBlock->ConfigurationRoot = MachHwDetect(); /* Initialize the PE loader import-DLL callback, so that we can obtain @@ -1130,11 +1131,15 @@ LoadAndBootWindowsCommon( **** WE HAVE NOW REACHED THE POINT OF NO RETURN !! ****/ + UiSetProgressBarSubset(40, 90); // NTOS goes from 25 to 75% + /* Load boot drivers */ - if (!SosEnabled) UiDrawProgressBarCenter(100, 100, "Loading boot drivers..."); + UiSetProgressBarText("Loading boot drivers..."); Success = WinLdrLoadBootDrivers(LoaderBlock, BootPath); TRACE("Boot drivers loading %s\n", Success ? "successful" : "failed"); + UiSetProgressBarSubset(0, 100); + /* Reset the PE loader import-DLL callback */ PeLdrImportDllLoadCallback = NULL; @@ -1145,6 +1150,8 @@ LoadAndBootWindowsCommon( BootPath, OperatingSystemVersion); + UiUpdateProgressBar(100, NULL); + /* Save entry-point pointer and Loader block VAs */ KiSystemStartup = (KERNEL_ENTRY_POINT)KernelDTE->EntryPoint; LoaderBlockVA = PaToVa(LoaderBlock); diff --git a/boot/freeldr/freeldr/ntldr/winldr.h b/boot/freeldr/freeldr/ntldr/winldr.h index 03cc68f88c7..38598e29f85 100644 --- a/boot/freeldr/freeldr/ntldr/winldr.h +++ b/boot/freeldr/freeldr/ntldr/winldr.h @@ -88,6 +88,8 @@ UiResetForSOS(VOID) UiVtbl = MiniTuiVtbl; UiVtbl.Initialize(); #endif + /* Disable the progress bar */ + UiProgressBar.Show = FALSE; } VOID diff --git a/boot/freeldr/freeldr/ui/directui.c b/boot/freeldr/freeldr/ui/directui.c index dbd2ed41902..68d67777190 100644 --- a/boot/freeldr/freeldr/ui/directui.c +++ b/boot/freeldr/freeldr/ui/directui.c @@ -111,28 +111,6 @@ UiMessageBoxCritical(IN PCSTR MessageText) TuiPrintf(MessageText); } -VOID -UiDrawProgressBarCenter( - _In_ ULONG Position, - _In_ ULONG Range, - _Inout_z_ PSTR ProgressText) -{ - MiniTuiDrawProgressBarCenter(Position, Range, ProgressText); -} - -VOID -UiDrawProgressBar( - _In_ ULONG Left, - _In_ ULONG Top, - _In_ ULONG Right, - _In_ ULONG Bottom, - _In_ ULONG Position, - _In_ ULONG Range, - _Inout_z_ PSTR ProgressText) -{ - MiniTuiDrawProgressBar(Left, Top, Right, Bottom, Position, Range, ProgressText); -} - VOID UiShowMessageBoxesInSection( IN ULONG_PTR SectionId) @@ -148,15 +126,6 @@ UiShowMessageBoxesInArgv( return; } -VOID -UiTruncateStringEllipsis(IN PCHAR StringText, - IN ULONG MaxChars) -{ - /* If it's too large, just add some ellipsis past the maximum */ - if (strlen(StringText) > MaxChars) - strcpy(&StringText[MaxChars - 3], "..."); -} - VOID UiDrawMenu( _In_ PUI_MENU_INFO MenuInfo) diff --git a/boot/freeldr/freeldr/ui/minitui.c b/boot/freeldr/freeldr/ui/minitui.c index 373605a8b1b..ae2ae004fa3 100644 --- a/boot/freeldr/freeldr/ui/minitui.c +++ b/boot/freeldr/freeldr/ui/minitui.c @@ -31,11 +31,85 @@ VOID MiniTuiDrawStatusText(PCSTR StatusText) #endif // _M_ARM +/*static*/ VOID +MiniTuiSetProgressBarText( + _In_ PCSTR ProgressText) +{ + ULONG ProgressBarWidth; + CHAR ProgressString[256]; + + /* Make sure the progress bar is enabled */ + ASSERT(UiProgressBar.Show); + + /* Calculate the width of the bar proper */ + ProgressBarWidth = UiProgressBar.Right - UiProgressBar.Left + 1; + + /* First make sure the progress bar text fits */ + RtlStringCbCopyA(ProgressString, sizeof(ProgressString), ProgressText); + TuiTruncateStringEllipsis(ProgressString, ProgressBarWidth); + + /* Clear the text area */ + TuiFillArea(UiProgressBar.Left, UiProgressBar.Top, + UiProgressBar.Right, +#ifdef NTLDR_PROGRESSBAR + UiProgressBar.Bottom - 1, +#else // BTMGR_PROGRESSBAR + UiProgressBar.Bottom - 2, // One empty line between text and bar. +#endif + ' ', ATTR(UiTextColor, UiMenuBgColor)); + + /* Draw the "Loading..." text */ + TuiDrawCenteredText(UiProgressBar.Left, UiProgressBar.Top, + UiProgressBar.Right, +#ifdef NTLDR_PROGRESSBAR + UiProgressBar.Bottom - 1, +#else // BTMGR_PROGRESSBAR + UiProgressBar.Bottom - 2, // One empty line between text and bar. +#endif + ProgressString, ATTR(UiTextColor, UiMenuBgColor)); +} + +/*static*/ VOID +MiniTuiTickProgressBar( + _In_ ULONG SubPercentTimes100) +{ + ULONG ProgressBarWidth; + ULONG FillCount; + + /* Make sure the progress bar is enabled */ + ASSERT(UiProgressBar.Show); + + ASSERT(SubPercentTimes100 <= (100 * 100)); + + /* Calculate the width of the bar proper */ + ProgressBarWidth = UiProgressBar.Right - UiProgressBar.Left + 1; + + /* Compute fill count */ + // FillCount = (ProgressBarWidth * Position) / Range; + FillCount = ProgressBarWidth * SubPercentTimes100 / (100 * 100); + + /* Fill the progress bar */ + /* Draw the percent complete -- Use the fill character */ + if (FillCount > 0) + { + TuiFillArea(UiProgressBar.Left, UiProgressBar.Bottom, + UiProgressBar.Left + FillCount - 1, UiProgressBar.Bottom, + '\xDB', ATTR(UiTextColor, UiMenuBgColor)); + } + /* Fill the remaining with blanks */ + TuiFillArea(UiProgressBar.Left + FillCount, UiProgressBar.Bottom, + UiProgressBar.Right, UiProgressBar.Bottom, + ' ', ATTR(UiTextColor, UiMenuBgColor)); + +#ifndef _M_ARM + TuiUpdateDateTime(); + VideoCopyOffScreenBufferToVRAM(); +#endif +} + VOID MiniTuiDrawProgressBarCenter( - _In_ ULONG Position, - _In_ ULONG Range, - _Inout_z_ PSTR ProgressText) + _In_ PCSTR ProgressText) { ULONG Left, Top, Right, Bottom, Width, Height; @@ -55,7 +129,7 @@ MiniTuiDrawProgressBarCenter( Bottom = Top + Height - 1; /* Draw the progress bar */ - MiniTuiDrawProgressBar(Left, Top, Right, Bottom, Position, Range, ProgressText); + MiniTuiDrawProgressBar(Left, Top, Right, Bottom, ProgressText); } VOID @@ -64,54 +138,9 @@ MiniTuiDrawProgressBar( _In_ ULONG Top, _In_ ULONG Right, _In_ ULONG Bottom, - _In_ ULONG Position, - _In_ ULONG Range, - _Inout_z_ PSTR ProgressText) + _In_ PCSTR ProgressText) { - ULONG ProgressBarWidth, i; - - /* Calculate the width of the bar proper */ - ProgressBarWidth = Right - Left + 1; - - /* Clip the position */ - if (Position > Range) - Position = Range; - - /* First make sure the progress bar text fits */ - UiTruncateStringEllipsis(ProgressText, ProgressBarWidth); - - /* Clear the text area */ - TuiFillArea(Left, Top, Right, -#ifdef NTLDR_PROGRESSBAR - Bottom - 1, -#else // BTMGR_PROGRESSBAR - Bottom - 2, // One empty line between text and bar. -#endif - ' ', ATTR(UiTextColor, UiMenuBgColor)); - - /* Draw the "Loading..." text */ - TuiDrawCenteredText(Left, Top, Right, -#ifdef NTLDR_PROGRESSBAR - Bottom - 1, -#else // BTMGR_PROGRESSBAR - Bottom - 2, // One empty line between text and bar. -#endif - ProgressText, ATTR(UiTextColor, UiMenuBgColor)); - - /* Draw the percent complete -- Use the fill character */ - for (i = 0; i < (Position * ProgressBarWidth) / Range; i++) - { - TuiDrawText(Left + i, Bottom, - "\xDB", ATTR(UiTextColor, UiMenuBgColor)); - } - /* Fill the remaining with blanks */ - TuiFillArea(Left + i, Bottom, Right, Bottom, - ' ', ATTR(UiTextColor, UiMenuBgColor)); - -#ifndef _M_ARM - TuiUpdateDateTime(); - VideoCopyOffScreenBufferToVRAM(); -#endif + UiInitProgressBar(Left, Top, Right, Bottom, ProgressText); } VOID @@ -192,6 +221,8 @@ const UIVTBL MiniTuiVtbl = TuiMessageBoxCritical, MiniTuiDrawProgressBarCenter, MiniTuiDrawProgressBar, + MiniTuiSetProgressBarText, + MiniTuiTickProgressBar, TuiEditBox, TuiTextToColor, TuiTextToFillStyle, diff --git a/boot/freeldr/freeldr/ui/noui.c b/boot/freeldr/freeldr/ui/noui.c index 5e083dd8be0..5bc33d70e69 100644 --- a/boot/freeldr/freeldr/ui/noui.c +++ b/boot/freeldr/freeldr/ui/noui.c @@ -100,11 +100,23 @@ VOID NoUiMessageBoxCritical(PCSTR MessageText) MachConsGetCh(); } +/* Loading Progress-Bar Functions ********************************************/ + +VOID +NoUiSetProgressBarText( + _In_ PCSTR ProgressText) +{ +} + +VOID +NoUiTickProgressBar( + _In_ ULONG SubPercentTimes100) +{ +} + VOID NoUiDrawProgressBarCenter( - _In_ ULONG Position, - _In_ ULONG Range, - _Inout_z_ PSTR ProgressText) + _In_ PCSTR ProgressText) { } @@ -114,12 +126,11 @@ NoUiDrawProgressBar( _In_ ULONG Top, _In_ ULONG Right, _In_ ULONG Bottom, - _In_ ULONG Position, - _In_ ULONG Range, - _Inout_z_ PSTR ProgressText) + _In_ PCSTR ProgressText) { } + BOOLEAN NoUiEditBox(PCSTR MessageText, PCHAR EditTextBuffer, ULONG Length) { return FALSE; diff --git a/boot/freeldr/freeldr/ui/tui.c b/boot/freeldr/freeldr/ui/tui.c index bcf510ed7c8..3950f93df2d 100644 --- a/boot/freeldr/freeldr/ui/tui.c +++ b/boot/freeldr/freeldr/ui/tui.c @@ -53,6 +53,16 @@ TuiPrintf( return Length; } +VOID +TuiTruncateStringEllipsis( + _Inout_z_ PSTR StringText, + _In_ ULONG MaxChars) +{ + /* If it's too large, just add some ellipsis past the maximum */ + if (strlen(StringText) > MaxChars) + strcpy(&StringText[MaxChars - 3], "..."); +} + /* * DrawText() * Displays a string on a single screen line. @@ -690,11 +700,83 @@ VOID TuiMessageBoxCritical(PCSTR MessageText) } } -VOID +static VOID +TuiSetProgressBarText( + _In_ PCSTR ProgressText) +{ + ULONG ProgressBarWidth; + CHAR ProgressString[256]; + + /* Make sure the progress bar is enabled */ + ASSERT(UiProgressBar.Show); + + /* Calculate the width of the bar proper */ + ProgressBarWidth = UiProgressBar.Right - UiProgressBar.Left + 1; + + /* First make sure the progress bar text fits */ + RtlStringCbCopyA(ProgressString, sizeof(ProgressString), ProgressText); + TuiTruncateStringEllipsis(ProgressString, ProgressBarWidth); + + /* Clear the text area */ + TuiFillArea(UiProgressBar.Left, UiProgressBar.Top, + UiProgressBar.Right, UiProgressBar.Bottom - 1, + ' ', ATTR(UiTextColor, UiMenuBgColor)); + + /* Draw the "Loading..." text */ + TuiDrawCenteredText(UiProgressBar.Left, UiProgressBar.Top, + UiProgressBar.Right, UiProgressBar.Bottom - 1, + ProgressString, ATTR(UiTextColor, UiMenuBgColor)); +} + +static VOID +TuiTickProgressBar( + _In_ ULONG SubPercentTimes100) +{ + ULONG ProgressBarWidth; + ULONG FillCount; + + /* Make sure the progress bar is enabled */ + ASSERT(UiProgressBar.Show); + + ASSERT(SubPercentTimes100 <= (100 * 100)); + + /* Calculate the width of the bar proper */ + ProgressBarWidth = UiProgressBar.Right - UiProgressBar.Left + 1; + + /* Compute fill count */ + // FillCount = (ProgressBarWidth * Position) / Range; + FillCount = ProgressBarWidth * SubPercentTimes100 / (100 * 100); + + /* Fill the progress bar */ + /* Draw the percent complete -- Use the fill character */ + if (FillCount > 0) + { + TuiFillArea(UiProgressBar.Left, UiProgressBar.Bottom, + UiProgressBar.Left + FillCount - 1, UiProgressBar.Bottom, + '\xDB', ATTR(UiTextColor, UiMenuBgColor)); + } + /* Fill the remaining with shadow blanks */ + TuiFillArea(UiProgressBar.Left + FillCount, UiProgressBar.Bottom, + UiProgressBar.Right, UiProgressBar.Bottom, + '\xB2', ATTR(UiTextColor, UiMenuBgColor)); + +#ifndef _M_ARM + TuiUpdateDateTime(); + VideoCopyOffScreenBufferToVRAM(); +#endif +} + +static VOID +TuiDrawProgressBar( + _In_ ULONG Left, + _In_ ULONG Top, + _In_ ULONG Right, + _In_ ULONG Bottom, + _In_ PCSTR ProgressText); + +static VOID TuiDrawProgressBarCenter( - _In_ ULONG Position, - _In_ ULONG Range, - _Inout_z_ PSTR ProgressText) + _In_ PCSTR ProgressText) { ULONG Left, Top, Right, Bottom, Width, Height; @@ -713,23 +795,21 @@ TuiDrawProgressBarCenter( Bottom += 1; /* Draw the progress bar */ - TuiDrawProgressBar(Left, Top, Right, Bottom, Position, Range, ProgressText); + TuiDrawProgressBar(Left, Top, Right, Bottom, ProgressText); } -VOID +static VOID TuiDrawProgressBar( _In_ ULONG Left, _In_ ULONG Top, _In_ ULONG Right, _In_ ULONG Bottom, - _In_ ULONG Position, - _In_ ULONG Range, - _Inout_z_ PSTR ProgressText) + _In_ PCSTR ProgressText) { - ULONG ProgressBarWidth, i; - /* Draw the box */ - TuiDrawBox(Left, Top, Right, Bottom, VERT, HORZ, TRUE, TRUE, ATTR(UiMenuFgColor, UiMenuBgColor)); + TuiDrawBox(Left, Top, Right, Bottom, + VERT, HORZ, TRUE, TRUE, + ATTR(UiMenuFgColor, UiMenuBgColor)); /* Exclude the box margins */ Left += 2; @@ -737,34 +817,7 @@ TuiDrawProgressBar( Top += 1; Bottom -= 1; - /* Calculate the width of the bar proper */ - ProgressBarWidth = Right - Left + 1; - - /* Clip the position */ - if (Position > Range) - Position = Range; - - /* First make sure the progress bar text fits */ - UiTruncateStringEllipsis(ProgressText, ProgressBarWidth); - - /* Draw the "Loading..." text */ - TuiDrawCenteredText(Left, Top, Right, Bottom - 1, - ProgressText, ATTR(UiTextColor, UiMenuBgColor)); - - /* Draw the percent complete -- Use the fill character */ - for (i = 0; i < (Position * ProgressBarWidth) / Range; i++) - { - TuiDrawText(Left + i, Bottom, - "\xDB", ATTR(UiTextColor, UiMenuBgColor)); - } - /* Fill the remaining with shadow blanks */ - TuiFillArea(Left + i, Bottom, Right, Bottom, - '\xB2', ATTR(UiTextColor, UiMenuBgColor)); - -#ifndef _M_ARM - TuiUpdateDateTime(); - VideoCopyOffScreenBufferToVRAM(); -#endif + UiInitProgressBar(Left, Top, Right, Bottom, ProgressText); } UCHAR TuiTextToColor(PCSTR ColorText) @@ -1135,6 +1188,8 @@ const UIVTBL TuiVtbl = TuiMessageBoxCritical, TuiDrawProgressBarCenter, TuiDrawProgressBar, + TuiSetProgressBarText, + TuiTickProgressBar, TuiEditBox, TuiTextToColor, TuiTextToFillStyle, diff --git a/boot/freeldr/freeldr/ui/ui.c b/boot/freeldr/freeldr/ui/ui.c index b2a08f27c9f..7d13d81ef16 100644 --- a/boot/freeldr/freeldr/ui/ui.c +++ b/boot/freeldr/freeldr/ui/ui.c @@ -16,13 +16,14 @@ * with this program; if not, write to the Free Software Foundation, Inc., * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ -#ifndef _M_ARM #include <freeldr.h> #include <debug.h> DBG_DEFAULT_CHANNEL(UI); +#ifndef _M_ARM + #define TAG_UI_TEXT 'xTiU' ULONG UiScreenWidth; // Screen Width @@ -55,6 +56,17 @@ CHAR UiTimeText[260] = "[Time Remaining: ] "; const CHAR UiMonthNames[12][15] = { "January ", "February ", "March ", "April ", "May ", "June ", "July ", "August ", "September ", "October ", "November ", "December " }; +#endif // _M_ARM + +/* + * Loading progress bar, based on the NTOS Inbv one. + * Supports progress within sub-ranges, used when loading + * with an unknown number of steps. + */ +UI_PROGRESS_BAR UiProgressBar = {{0}}; + +#ifndef _M_ARM + UIVTBL UiVtbl = { NoUiInitialize, @@ -72,6 +84,8 @@ UIVTBL UiVtbl = NoUiMessageBoxCritical, NoUiDrawProgressBarCenter, NoUiDrawProgressBar, + NoUiSetProgressBarText, + NoUiTickProgressBar, NoUiEditBox, NoUiTextToColor, NoUiTextToFillStyle, @@ -369,13 +383,128 @@ UCHAR UiTextToFillStyle(PCSTR FillStyleText) return UiVtbl.TextToFillStyle(FillStyleText); } +#endif // _M_ARM + +VOID +UiInitProgressBar( + _In_ ULONG Left, + _In_ ULONG Top, + _In_ ULONG Right, + _In_ ULONG Bottom, + _In_ PCSTR ProgressText) +{ + /* Progress bar area */ + UiProgressBar.Left = Left; + UiProgressBar.Top = Top; + UiProgressBar.Right = Right; + UiProgressBar.Bottom = Bottom; + // UiProgressBar.Width = Right - Left + 1; + + /* Set the progress bar ranges */ + UiSetProgressBarSubset(0, 100); + UiProgressBar.Indicator.Count = 0; + UiProgressBar.Indicator.Expected = 25; + UiProgressBar.Indicator.Percentage = 0; + + /* Enable the progress bar */ + UiProgressBar.Show = TRUE; + + /* Initial drawing: set the "Loading..." text and the original position */ +#ifndef _M_ARM + UiVtbl.SetProgressBarText(ProgressText); + UiVtbl.TickProgressBar(0); +#else + MiniTuiSetProgressBarText(ProgressText); + MiniTuiTickProgressBar(0); +#endif +} + +VOID +UiIndicateProgress(VOID) +{ + ULONG Percentage; + + /* Increase progress */ + UiProgressBar.Indicator.Count++; + + /* Compute the new percentage - Don't go over 100% */ + Percentage = 100 * UiProgressBar.Indicator.Count / + UiProgressBar.Indicator.Expected; + Percentage = min(Percentage, 99); + + if (Percentage != UiProgressBar.Indicator.Percentage) + { + /* Percentage has changed, update the progress bar */ + UiProgressBar.Indicator.Percentage = Percentage; + UiUpdateProgressBar(Percentage, NULL); + } +} + +VOID +UiSetProgressBarSubset( + _In_ ULONG Floor, + _In_ ULONG Ceiling) +{ + /* Sanity checks */ + ASSERT(Floor < Ceiling); + ASSERT(Ceiling <= 100); + + /* Update the progress bar state */ + UiProgressBar.State.Floor = Floor * 100; + // UiProgressBar.State.Ceiling = Ceiling * 100; + UiProgressBar.State.Bias = Ceiling - Floor; +} + +VOID +UiUpdateProgressBar( + _In_ ULONG Percentage, + _In_opt_ PCSTR ProgressText) +{ + ULONG TotalProgress; + + /* Make sure the progress bar is enabled */ + if (!UiProgressBar.Show) + return; + + /* Set the progress text if specified */ + if (ProgressText) + UiSetProgressBarText(ProgressText); + + /* Compute the total progress and tick the progress bar */ + TotalProgress = UiProgressBar.State.Floor + (Percentage * UiProgressBar.State.Bias); + // TotalProgress /= (100 * 100); + +#ifndef _M_ARM + UiVtbl.TickProgressBar(TotalProgress); +#else + MiniTuiTickProgressBar(TotalProgress); +#endif +} + +VOID +UiSetProgressBarText( + _In_ PCSTR ProgressText) +{ + /* Make sure the progress bar is enabled */ + if (!UiProgressBar.Show) + return; + +#ifndef _M_ARM + UiVtbl.SetProgressBarText(ProgressText); +#else + MiniTuiSetProgressBarText(ProgressText); +#endif +} + VOID UiDrawProgressBarCenter( - _In_ ULONG Position, - _In_ ULONG Range, - _Inout_z_ PSTR ProgressText) + _In_ PCSTR ProgressText) { - UiVtbl.DrawProgressBarCenter(Position, Range, ProgressText); +#ifndef _M_ARM + UiVtbl.DrawProgressBarCenter(ProgressText); +#else + MiniTuiDrawProgressBarCenter(ProgressText); +#endif } VOID @@ -384,11 +513,34 @@ UiDrawProgressBar( _In_ ULONG Top, _In_ ULONG Right, _In_ ULONG Bottom, - _In_ ULONG Position, - _In_ ULONG Range, - _Inout_z_ PSTR ProgressText) + _In_ PCSTR ProgressText) { - UiVtbl.DrawProgressBar(Left, Top, Right, Bottom, Position, Range, ProgressText); +#ifndef _M_ARM + UiVtbl.DrawProgressBar(Left, Top, Right, Bottom, ProgressText); +#else + MiniTuiDrawProgressBar(Left, Top, Right, Bottom, ProgressText); +#endif +} + +#ifndef _M_ARM + +static VOID +UiEscapeString(PCHAR String) +{ + ULONG Idx; + + for (Idx=0; Idx<strlen(String); Idx++) + { + // Escape the new line characters + if (String[Idx] == '\\' && String[Idx+1] == 'n') + { + // Escape the character + String[Idx] = '\n'; + + // Move the rest of the string up + strcpy(&String[Idx+1], &String[Idx+2]); + } + } } VOID @@ -472,31 +624,6 @@ UiShowMessageBoxesInArgv( } } -VOID UiEscapeString(PCHAR String) -{ - ULONG Idx; - - for (Idx=0; Idx<strlen(String); Idx++) - { - // Escape the new line characters - if (String[Idx] == '\\' && String[Idx+1] == 'n') - { - // Escape the character - String[Idx] = '\n'; - - // Move the rest of the string up - strcpy(&String[Idx+1], &String[Idx+2]); - } - } -} - -VOID UiTruncateStringEllipsis(PCHAR StringText, ULONG MaxChars) -{ - /* If it's too large, just add some ellipsis past the maximum */ - if (strlen(StringText) > MaxChars) - strcpy(&StringText[MaxChars - 3], "..."); -} - BOOLEAN UiDisplayMenu( IN PCSTR MenuHeader,

2 years, 10 months

[reactos] 01/01: [RUNAS] Add password input and improve help text

by Eric Kohl

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=c14440ee5789445f38e0c… commit c14440ee5789445f38e0c7cf327b0200947c8965 Author: Eric Kohl <eric.kohl(a)reactos.org> AuthorDate: Sat Feb 19 19:50:46 2022 +0100 Commit: Eric Kohl <eric.kohl(a)reactos.org> CommitDate: Sat Feb 19 19:50:46 2022 +0100 [RUNAS] Add password input and improve help text Now it works on windows xp and 10. --- base/applications/runas/lang/de-DE.rc | 15 ++++++- base/applications/runas/lang/en-US.rc | 15 ++++++- base/applications/runas/resource.h | 25 ++++++++---- base/applications/runas/runas.c | 73 +++++++++++++++++++++++++++++------ 4 files changed, 106 insertions(+), 22 deletions(-) diff --git a/base/applications/runas/lang/de-DE.rc b/base/applications/runas/lang/de-DE.rc index 53f50974495..c9e3e159030 100644 --- a/base/applications/runas/lang/de-DE.rc +++ b/base/applications/runas/lang/de-DE.rc @@ -7,6 +7,17 @@ BEGIN IDS_USAGE03 " /user:<Benutzername> Programm\n\n" IDS_USAGE04 "RUNAS [ [/noprofile | /profile] [/env] [/savecred | /netonly] ]\n" IDS_USAGE05 " /smartcard [/user:<Benutzername>] Programm\n\n" - IDS_USAGE06 "/noprofile" - IDS_USAGE07 "/profile" + IDS_USAGE06 " /noprofile Legt fest, dass das Benutzerprofil nicht geladen werden\n" + IDS_USAGE07 " soll. Führt dazu, dass die Anwendung schneller geladen\n" + IDS_USAGE08 " wird. Dies kann bei einigen Anwendungen zu Fehlern führen.\n" + IDS_USAGE09 " /profile Legt fest, dass das Benutzerprofil geladen werden soll.\n" + IDS_USAGE10 " Dies ist die Standardeinstellung.\n" + IDS_USAGE11 " /env Verwendet die aktuelle Umgebung statt der des Benutzers.\n" + IDS_USAGE12 " /user <Benutzername> muss in der Form Benutzer@Domäne oder\n Domäne\\Benutzer angegeben werden\n" + IDS_USAGE13 " Programm Befehlszeile einer ausführbaren Datei. Siehe unten\n aufgeführte Beispiele.\n\n" + + IDS_START "Es wird versucht, %s als Benutzer ""%s\\%s"" zu starten...\n" + IDS_RUN_ERROR "RUNAS-FEHLER: %s kann nicht ausgeführt werden\n" + + IDS_PASSWORD "Geben Sie das Kennwort für ""%s\\%s"" ein: " END diff --git a/base/applications/runas/lang/en-US.rc b/base/applications/runas/lang/en-US.rc index 815319ea936..f3f478b67f6 100644 --- a/base/applications/runas/lang/en-US.rc +++ b/base/applications/runas/lang/en-US.rc @@ -7,6 +7,17 @@ BEGIN IDS_USAGE03 " /user:<UserName> program\n\n" IDS_USAGE04 "RUNAS [ [/noprofile | /profile] [/env] [/savecred | /netonly] ]\n" IDS_USAGE05 " /smartcard [/user:<UserName>] program\n\n" - IDS_USAGE06 "/noprofile" - IDS_USAGE07 "/profile" + IDS_USAGE06 " /noprofile specifies that the user's profile should not be loaded.\n" + IDS_USAGE07 " This causes the application to load more quickly, but\n" + IDS_USAGE08 " can cause some applications to malfunction.\n" + IDS_USAGE09 " /profile specifies that the user's profile should be loaded.\n" + IDS_USAGE10 " This is the default.\n" + IDS_USAGE11 " /env to use current environment instead of user's.\n" + IDS_USAGE12 " /user <UserName> should be in form USER@DOMAIN or DOMAIN\\USER\n" + IDS_USAGE13 " program command line for EXE. See below for examples\n\n" + + IDS_START "Attempting to start %s as user ""%s\\%s""...\n" + IDS_RUN_ERROR "RUNAS ERROR: Unable to run %s\n" + + IDS_PASSWORD "Enter the password for ""%s\\%s"": " END diff --git a/base/applications/runas/resource.h b/base/applications/runas/resource.h index 11ad5ad8fa3..a2288467f14 100644 --- a/base/applications/runas/resource.h +++ b/base/applications/runas/resource.h @@ -1,7 +1,18 @@ -#define IDS_USAGE01 7000 -#define IDS_USAGE02 7001 -#define IDS_USAGE03 7002 -#define IDS_USAGE04 7003 -#define IDS_USAGE05 7004 -#define IDS_USAGE06 7005 -#define IDS_USAGE07 7006 +#define IDS_USAGE01 7000 +#define IDS_USAGE02 7001 +#define IDS_USAGE03 7002 +#define IDS_USAGE04 7003 +#define IDS_USAGE05 7004 +#define IDS_USAGE06 7005 +#define IDS_USAGE07 7006 +#define IDS_USAGE08 7007 +#define IDS_USAGE09 7008 +#define IDS_USAGE10 7009 +#define IDS_USAGE11 7010 +#define IDS_USAGE12 7011 +#define IDS_USAGE13 7012 +#define IDS_USAGE_MAX IDS_USAGE13 + +#define IDS_START 7100 +#define IDS_RUN_ERROR 7101 +#define IDS_PASSWORD 7500 diff --git a/base/applications/runas/runas.c b/base/applications/runas/runas.c index 581f24e2d00..8adbe8d2894 100644 --- a/base/applications/runas/runas.c +++ b/base/applications/runas/runas.c @@ -23,17 +23,52 @@ #define NDEBUG #include <debug.h> +#define MAX_PASSWORD_LENGTH 64 + static -void -Usage(void) +VOID +Usage(VOID) { - ConResPuts(StdOut, IDS_USAGE01); - ConResPuts(StdOut, IDS_USAGE02); - ConResPuts(StdOut, IDS_USAGE03); - ConResPuts(StdOut, IDS_USAGE04); - ConResPuts(StdOut, IDS_USAGE05); - ConResPuts(StdOut, IDS_USAGE06); - ConResPuts(StdOut, IDS_USAGE07); + int i; + for (i = IDS_USAGE01; i <= IDS_USAGE_MAX; i++) + ConResPuts(StdOut, i); +} + + +static +VOID +ConInString( + _In_ PWSTR pInput, + _In_ DWORD dwLength) +{ + DWORD dwOldMode; + DWORD dwRead = 0; + HANDLE hFile; + PWSTR p; + PCHAR pBuf; + + pBuf = (PCHAR)HeapAlloc(GetProcessHeap(), 0, dwLength - 1); + ZeroMemory(pInput, dwLength * sizeof(WCHAR)); + hFile = GetStdHandle(STD_INPUT_HANDLE); + GetConsoleMode(hFile, &dwOldMode); + + SetConsoleMode(hFile, ENABLE_LINE_INPUT /*| ENABLE_ECHO_INPUT*/); + + ReadFile(hFile, (PVOID)pBuf, dwLength - 1, &dwRead, NULL); + + MultiByteToWideChar(GetConsoleCP(), 0, pBuf, dwRead, pInput, dwLength - 1); + HeapFree(GetProcessHeap(), 0, pBuf); + + for (p = pInput; *p; p++) + { + if (*p == L'\x0d') + { + *p = UNICODE_NULL; + break; + } + } + + SetConsoleMode(hFile, dwOldMode); } @@ -169,7 +204,22 @@ wmain( DPRINT("Domain: %S\n", pszDomain); DPRINT("CommandLine: %S\n", pszCommandLine); - /* FIXME: Query the password: */ + if (pszDomain == NULL) + { + DWORD dwLength = MAX_COMPUTERNAME_LENGTH + 1; + pszDomain = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, dwLength * sizeof(WCHAR)); + if (pszDomain) + GetComputerNameW(pszDomain, &dwLength); + } + + pszPassword = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, (MAX_PASSWORD_LENGTH + 1) * sizeof(WCHAR)); + + /* Query the password */ + ConResPrintf(StdOut, IDS_PASSWORD, pszDomain, pszUserName); + ConInString(pszPassword, MAX_PASSWORD_LENGTH + 1); + ConPuts(StdOut, L"\n"); + + ConResPrintf(StdOut, IDS_START, pszCommandLine, pszDomain, pszUserName); rc = CreateProcessWithLogonW(pszUserName, pszDomain, @@ -184,7 +234,8 @@ wmain( &ProcessInfo); if (rc == FALSE) { - DPRINT("Error: %lu\n", GetLastError()); + ConResPrintf(StdOut, IDS_RUN_ERROR, pszCommandLine); + ConPrintf(StdOut, L"Error: %lu\n", GetLastError()); } done:

2 years, 10 months

[reactos] 01/01: [WIN32SS][NTGDI] Remove useless assert (#4370) CORE-17561

by Oleg Dubinskiy

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=9ab5d3afb2007337b0a29… commit 9ab5d3afb2007337b0a298635729ccd82b3efe18 Author: Oleg Dubinskiy <oleg.dubinskij2013(a)yandex.ua> AuthorDate: Fri Feb 18 23:00:57 2022 +0200 Commit: GitHub <noreply(a)github.com> CommitDate: Fri Feb 18 22:00:57 2022 +0100 [WIN32SS][NTGDI] Remove useless assert (#4370) CORE-17561 Remove useless ASSERT(FALSE); in IntGdiCreateDisplayDC, because it actually does not check anything useful. It only asserts each time when the function is called from DxEngCreateMemoryDC by MS DirectDraw stack (ddraw.dll & dxg.sys). UNIMPLEMENTED debug print is enough a lot to see that this function is not implemented properly. CORE-17561 --- win32ss/gdi/ntgdi/dclife.c | 1 - 1 file changed, 1 deletion(-) diff --git a/win32ss/gdi/ntgdi/dclife.c b/win32ss/gdi/ntgdi/dclife.c index 4671c16d4a7..d94f69b9661 100644 --- a/win32ss/gdi/ntgdi/dclife.c +++ b/win32ss/gdi/ntgdi/dclife.c @@ -1064,7 +1064,6 @@ IntGdiCreateDisplayDC(HDEV hDev, ULONG DcType, BOOL EmptyDC) { HDC hDC; UNIMPLEMENTED; - ASSERT(FALSE); if (DcType == DC_TYPE_MEMORY) hDC = NtGdiCreateCompatibleDC(NULL); // OH~ Yuck! I think I taste vomit in my mouth!

2 years, 10 months

[reactos] 04/04: [FREELDR:NTLDR] Slightly rework how KD transport DLLs are loaded.

by Hermès Bélusca-Maïto

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=81943afb7b3603de981fa… commit 81943afb7b3603de981fae80e994c8d8f29041df Author: Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org> AuthorDate: Fri Feb 18 04:38:52 2022 +0100 Commit: Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org> CommitDate: Fri Feb 18 20:24:51 2022 +0100 [FREELDR:NTLDR] Slightly rework how KD transport DLLs are loaded. A Kernel Debugger Transport DLL is always loaded for Windows XP+ : either the standard KDCOM.DLL (by default), or an alternative user-provided one via the /DEBUGPORT= option. If this alternative does not exist or fails to be loaded, fall back to the standard KDCOM.DLL. If no KD dll is loaded, kernel loading would fail because of the resulting unsatisfied KDCOM dll import (tested on Windows and ReactOS). + Normalize kernel, HAL and KD dll file names to lowercase (needed for case-sensitive installations). --- boot/freeldr/freeldr/ntldr/winldr.c | 78 +++++++++++++++++++++++++------------ 1 file changed, 53 insertions(+), 25 deletions(-) diff --git a/boot/freeldr/freeldr/ntldr/winldr.c b/boot/freeldr/freeldr/ntldr/winldr.c index 3e7abaa51f4..317d59a35bd 100644 --- a/boot/freeldr/freeldr/ntldr/winldr.c +++ b/boot/freeldr/freeldr/ntldr/winldr.c @@ -575,7 +575,7 @@ LoadWindowsCore(IN USHORT OperatingSystemVersion, /* Retrieve the HAL file name */ Option += 4; OptionLength -= 4; RtlStringCbCopyNA(HalFileName, sizeof(HalFileName), Option, OptionLength); - _strupr(HalFileName); + _strlwr(HalFileName); } Option = NtLdrGetOptionEx(BootOptions, "KERNEL=", &OptionLength); @@ -584,7 +584,7 @@ LoadWindowsCore(IN USHORT OperatingSystemVersion, /* Retrieve the KERNEL file name */ Option += 7; OptionLength -= 7; RtlStringCbCopyNA(KernelFileName, sizeof(KernelFileName), Option, OptionLength); - _strupr(KernelFileName); + _strlwr(KernelFileName); } TRACE("HAL file = '%s' ; Kernel file = '%s'\n", HalFileName, KernelFileName); @@ -633,50 +633,78 @@ LoadWindowsCore(IN USHORT OperatingSystemVersion, * the name "kdcom.dll". [...]" */ + /* + * A Kernel Debugger Transport DLL is always loaded for Windows XP+ : + * either the standard KDCOM.DLL (by default): IsCustomKdDll == FALSE + * or an alternative user-provided one via the /DEBUGPORT= option: + * IsCustomKdDll == TRUE if it does not specify the default KDCOM. + */ + BOOLEAN IsCustomKdDll = FALSE; + /* Check whether there is a DEBUGPORT option */ Option = NtLdrGetOptionEx(BootOptions, "DEBUGPORT=", &OptionLength); if (Option && (OptionLength > 10)) { /* Move to the debug port name */ Option += 10; OptionLength -= 10; - ASSERT(OptionLength > 0); /* * Parse the port name. - * Format: /DEBUGPORT=COM[1-9] + * Format: /DEBUGPORT=COM[0-9] * or: /DEBUGPORT=FILE:\Device\HarddiskX\PartitionY\debug.log * or: /DEBUGPORT=FOO * If we only have /DEBUGPORT= (i.e. without any port name), - * defaults it to "COM". + * default to "COM". */ - RtlStringCbCopyA(KdDllName, sizeof(KdDllName), "KD"); - if (_strnicmp(Option, "COM", 3) == 0 && '0' <= Option[3] && Option[3] <= '9') + + /* Get the actual length of the debug port + * until the next whitespace or colon. */ + OptionLength = (ULONG)strcspn(Option, " \t:"); + + if ((OptionLength == 0) || + ( (OptionLength >= 3) && (_strnicmp(Option, "COM", 3) == 0) && + ((OptionLength == 3) || ('0' <= Option[3] && Option[3] <= '9')) )) { - RtlStringCbCatNA(KdDllName, sizeof(KdDllName), Option, 3); + /* The standard KDCOM.DLL is used */ } else { - /* Get the actual length of the debug port - * until the next whitespace or colon. */ - OptionLength = (ULONG)strcspn(Option, " \t:"); - if (OptionLength == 0) - RtlStringCbCatA(KdDllName, sizeof(KdDllName), "COM"); - else - RtlStringCbCatNA(KdDllName, sizeof(KdDllName), Option, OptionLength); + /* A custom KD DLL is used */ + IsCustomKdDll = TRUE; } - RtlStringCbCatA(KdDllName, sizeof(KdDllName), ".DLL"); - _strupr(KdDllName); + } + if (!IsCustomKdDll) + { + Option = "COM"; OptionLength = 3; + } - /* - * Load the transport DLL. Override the base DLL name of the - * loaded transport DLL to the default "KDCOM.DLL" name. - */ - KdDllBase = LoadModule(LoaderBlock, DirPath, KdDllName, - "kdcom.dll", LoaderSystemCode, &KdDllDTE, 60); - if (!KdDllBase) + RtlStringCbPrintfA(KdDllName, sizeof(KdDllName), "kd%.*s.dll", + OptionLength, Option); + _strlwr(KdDllName); + + /* Load the KD DLL. Override its base DLL name to the default "KDCOM.DLL". */ + KdDllBase = LoadModule(LoaderBlock, DirPath, KdDllName, + "kdcom.dll", LoaderSystemCode, &KdDllDTE, 60); + if (!KdDllBase) + { + /* If we failed to load a custom KD DLL, fall back to the standard one */ + if (IsCustomKdDll) { - /* The transport DLL being optional, just ignore the failure */ + /* The custom KD DLL being optional, just ignore the failure */ WARN("LoadModule('%s') failed\n", KdDllName); + + IsCustomKdDll = FALSE; + RtlStringCbCopyA(KdDllName, sizeof(KdDllName), "kdcom.dll"); + + KdDllBase = LoadModule(LoaderBlock, DirPath, KdDllName, + "kdcom.dll", LoaderSystemCode, &KdDllDTE, 60); + } + + if (!KdDllBase) + { + /* Ignore the failure; we will fail later when scanning the + * kernel import tables, if it really needs the KD DLL. */ + ERR("LoadModule('%s') failed\n", KdDllName); } } }

2 years, 10 months

[reactos] 03/04: [FREELDR] Add cleanup in PE-image-handling-related failure code paths.

by Hermès Bélusca-Maïto

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=2221df213f40ec1b6d62a… commit 2221df213f40ec1b6d62a0747863c9e0c891a97c Author: Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org> AuthorDate: Fri Feb 18 03:20:24 2022 +0100 Commit: Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org> CommitDate: Fri Feb 18 20:24:49 2022 +0100 [FREELDR] Add cleanup in PE-image-handling-related failure code paths. --- boot/freeldr/freeldr/disk/scsiport.c | 25 ++++++--- boot/freeldr/freeldr/include/peloader.h | 5 ++ boot/freeldr/freeldr/lib/peloader.c | 82 ++++++++++++++++++----------- boot/freeldr/freeldr/ntldr/winldr.c | 93 ++++++++++++++++++++++++++------- 4 files changed, 148 insertions(+), 57 deletions(-) diff --git a/boot/freeldr/freeldr/disk/scsiport.c b/boot/freeldr/freeldr/disk/scsiport.c index d23fe58a76e..0699f69f6a6 100644 --- a/boot/freeldr/freeldr/disk/scsiport.c +++ b/boot/freeldr/freeldr/disk/scsiport.c @@ -1653,7 +1653,7 @@ LoadBootDeviceDriver(VOID) Success = PeLdrLoadImage(NtBootDdPath, LoaderBootDriver, &ImageBase); if (!Success) { - /* That's OK. File simply doesn't exist */ + /* That's OK, file simply doesn't exist */ return ESUCCESS; } @@ -1661,7 +1661,11 @@ LoadBootDeviceDriver(VOID) Success = PeLdrAllocateDataTableEntry(&ModuleListHead, "ntbootdd.sys", "NTBOOTDD.SYS", ImageBase, &BootDdDTE); if (!Success) + { + /* Cleanup and bail out */ + MmFreeMemory(ImageBase); return EIO; + } /* Add the PE part of freeldr.sys to the list of loaded executables, it contains ScsiPort* exports, imported by ntbootdd.sys */ @@ -1669,20 +1673,27 @@ LoadBootDeviceDriver(VOID) "FREELDR.SYS", &__ImageBase, &FreeldrDTE); if (!Success) { - RemoveEntryList(&BootDdDTE->InLoadOrderLinks); + /* Cleanup and bail out */ + PeLdrFreeDataTableEntry(BootDdDTE); + MmFreeMemory(ImageBase); return EIO; } /* Fix imports */ Success = PeLdrScanImportDescriptorTable(&ModuleListHead, "", BootDdDTE); + if (!Success) + { + /* Cleanup and bail out */ + PeLdrFreeDataTableEntry(FreeldrDTE); + PeLdrFreeDataTableEntry(BootDdDTE); + MmFreeMemory(ImageBase); + return EIO; + } - /* Now unlinkt the DTEs, they won't be valid later */ + /* Now unlink the DTEs, they won't be valid later */ RemoveEntryList(&BootDdDTE->InLoadOrderLinks); RemoveEntryList(&FreeldrDTE->InLoadOrderLinks); - if (!Success) - return EIO; - /* Change imports to PA */ ImportTable = (PIMAGE_IMPORT_DESCRIPTOR)RtlImageDirectoryEntryToData(VaToPa(BootDdDTE->DllBase), TRUE, IMAGE_DIRECTORY_ENTRY_IMPORT, &ImportTableSize); @@ -1705,7 +1716,7 @@ LoadBootDeviceDriver(VOID) NtHeaders->OptionalHeader.ImageBase - (ULONG_PTR)BootDdDTE->DllBase, "FreeLdr", TRUE, - TRUE, /* in case of conflict still return success */ + TRUE, /* In case of conflict still return success */ FALSE); if (!Success) return EIO; diff --git a/boot/freeldr/freeldr/include/peloader.h b/boot/freeldr/freeldr/include/peloader.h index 63ffa80471a..1f67ed3bbac 100644 --- a/boot/freeldr/freeldr/include/peloader.h +++ b/boot/freeldr/freeldr/include/peloader.h @@ -40,6 +40,11 @@ PeLdrAllocateDataTableEntry( IN PVOID BasePA, OUT PLDR_DATA_TABLE_ENTRY *NewEntry); +VOID +PeLdrFreeDataTableEntry( + // _In_ PLIST_ENTRY ModuleListHead, + _In_ PLDR_DATA_TABLE_ENTRY Entry); + BOOLEAN PeLdrScanImportDescriptorTable( IN OUT PLIST_ENTRY ModuleListHead, diff --git a/boot/freeldr/freeldr/lib/peloader.c b/boot/freeldr/freeldr/lib/peloader.c index b768aa9dea8..f97639e4cec 100644 --- a/boot/freeldr/freeldr/lib/peloader.c +++ b/boot/freeldr/freeldr/lib/peloader.c @@ -115,7 +115,7 @@ PeLdrpBindImportName( // DllBase, ImageBase, ThunkData, ExportDirectory, ExportSize, ProcessForwards); /* Check passed DllBase param */ - if(DllBase == NULL) + if (DllBase == NULL) { WARN("DllBase == NULL!\n"); return FALSE; @@ -368,7 +368,7 @@ PeLdrpLoadAndScanReferencedDll( Success = PeLdrLoadImage(FullDllName, LoaderBootDriver, &BasePA); if (!Success) { - ERR("PeLdrLoadImage() failed\n"); + ERR("PeLdrLoadImage('%s') failed\n", FullDllName); return Success; } @@ -380,7 +380,9 @@ PeLdrpLoadAndScanReferencedDll( DataTableEntry); if (!Success) { - ERR("PeLdrAllocateDataTableEntry() failed\n"); + /* Cleanup and bail out */ + ERR("PeLdrAllocateDataTableEntry('%s') failed\n", FullDllName); + MmFreeMemory(BasePA); return Success; } @@ -392,7 +394,10 @@ PeLdrpLoadAndScanReferencedDll( Success = PeLdrScanImportDescriptorTable(ModuleListHead, DirectoryPath, *DataTableEntry); if (!Success) { + /* Cleanup and bail out */ ERR("PeLdrScanImportDescriptorTable() failed\n"); + PeLdrFreeDataTableEntry(*DataTableEntry); + MmFreeMemory(BasePA); return Success; } @@ -603,7 +608,7 @@ PeLdrAllocateDataTableEntry( PIMAGE_NT_HEADERS NtHeaders; USHORT Length; - TRACE("PeLdrAllocateDataTableEntry(, '%s', '%s', %p)\n", + TRACE("PeLdrAllocateDataTableEntry('%s', '%s', %p)\n", BaseDllName, FullDllName, BasePA); /* Allocate memory for a data table entry, zero-initialize it */ @@ -706,6 +711,20 @@ PeLdrAllocateDataTableEntry( return TRUE; } +VOID +PeLdrFreeDataTableEntry( + // _In_ PLIST_ENTRY ModuleListHead, + _In_ PLDR_DATA_TABLE_ENTRY Entry) +{ + // ASSERT(ModuleListHead); + ASSERT(Entry); + + RemoveEntryList(&Entry->InLoadOrderLinks); + FrLdrHeapFree(VaToPa(Entry->FullDllName.Buffer), TAG_WLDR_NAME); + FrLdrHeapFree(VaToPa(Entry->BaseDllName.Buffer), TAG_WLDR_NAME); + FrLdrHeapFree(Entry, TAG_WLDR_DTE); +} + /* * PeLdrLoadImage loads the specified image from the file (it doesn't * perform any additional operations on the filename, just directly @@ -730,13 +749,13 @@ PeLdrLoadImage( LARGE_INTEGER Position; ULONG i, BytesRead; - TRACE("PeLdrLoadImage(%s, %ld)\n", FileName, MemoryType); + TRACE("PeLdrLoadImage('%s', %ld)\n", FileName, MemoryType); /* Open the image file */ Status = ArcOpen((PSTR)FileName, OpenReadOnly, &FileId); if (Status != ESUCCESS) { - WARN("ArcOpen(FileName: '%s') failed. Status: %u\n", FileName, Status); + WARN("ArcOpen('%s') failed. Status: %u\n", FileName, Status); return FALSE; } @@ -744,8 +763,7 @@ PeLdrLoadImage( Status = ArcRead(FileId, HeadersBuffer, SECTOR_SIZE * 2, &BytesRead); if (Status != ESUCCESS) { - ERR("ArcRead(File: '%s') failed. Status: %u\n", FileName, Status); - UiMessageBox("Error reading from file."); + ERR("ArcRead('%s') failed. Status: %u\n", FileName, Status); ArcClose(FileId); return FALSE; } @@ -755,7 +773,6 @@ PeLdrLoadImage( if (!NtHeaders) { ERR("No NT header found in \"%s\"\n", FileName); - UiMessageBox("Error: No NT header found."); ArcClose(FileId); return FALSE; } @@ -764,7 +781,6 @@ PeLdrLoadImage( if (((NtHeaders->FileHeader.Characteristics & IMAGE_FILE_EXECUTABLE_IMAGE) == 0)) { ERR("Not an executable image \"%s\"\n", FileName); - UiMessageBox("Not an executable image."); ArcClose(FileId); return FALSE; } @@ -773,26 +789,25 @@ PeLdrLoadImage( NumberOfSections = NtHeaders->FileHeader.NumberOfSections; SectionHeader = IMAGE_FIRST_SECTION(NtHeaders); - /* Try to allocate this memory, if fails - allocate somewhere else */ + /* Try to allocate this memory; if it fails, allocate somewhere else */ PhysicalBase = MmAllocateMemoryAtAddress(NtHeaders->OptionalHeader.SizeOfImage, (PVOID)((ULONG)NtHeaders->OptionalHeader.ImageBase & (KSEG0_BASE - 1)), MemoryType); if (PhysicalBase == NULL) { - /* It's ok, we don't panic - let's allocate again at any other "low" place */ + /* Don't fail, allocate again at any other "low" place */ PhysicalBase = MmAllocateMemoryWithType(NtHeaders->OptionalHeader.SizeOfImage, MemoryType); if (PhysicalBase == NULL) { ERR("Failed to alloc %lu bytes for image %s\n", NtHeaders->OptionalHeader.SizeOfImage, FileName); - UiMessageBox("Failed to alloc pages for image."); ArcClose(FileId); return FALSE; } } - /* This is the real image base - in form of a virtual address */ + /* This is the real image base, in form of a virtual address */ VirtualBase = PaToVa(PhysicalBase); TRACE("Base PA: 0x%X, VA: 0x%X\n", PhysicalBase, VirtualBase); @@ -805,10 +820,10 @@ PeLdrLoadImage( Status = ArcRead(FileId, (PUCHAR)PhysicalBase + sizeof(HeadersBuffer), NtHeaders->OptionalHeader.SizeOfHeaders - sizeof(HeadersBuffer), &BytesRead); if (Status != ESUCCESS) { - ERR("ArcRead(File: '%s') failed. Status: %u\n", FileName, Status); - UiMessageBox("Error reading headers."); + ERR("ArcRead('%s') failed. Status: %u\n", FileName, Status); + // UiMessageBox("Error reading headers."); ArcClose(FileId); - return FALSE; + goto Failure; } } @@ -824,9 +839,6 @@ PeLdrLoadImage( /* Load the first section */ SectionHeader = IMAGE_FIRST_SECTION(NtHeaders); - /* Fill output parameters */ - *ImageBasePA = PhysicalBase; - /* Walk through each section and read it (check/fix any possible bad situations, if they arise) */ for (i = 0; i < NumberOfSections; i++) @@ -868,7 +880,7 @@ PeLdrLoadImage( } } - /* Size of data is less than the virtual size - fill up the remainder with zeroes */ + /* Size of data is less than the virtual size: fill up the remainder with zeroes */ if (SizeOfRawData < VirtualSize) { TRACE("PeLdrLoadImage(): SORD %d < VS %d\n", SizeOfRawData, VirtualSize); @@ -878,25 +890,35 @@ PeLdrLoadImage( SectionHeader++; } - /* We are done with the file - close it */ + /* We are done with the file, close it */ ArcClose(FileId); - /* If loading failed - return right now */ + /* If loading failed, return right now */ if (Status != ESUCCESS) - return FALSE; + goto Failure; /* Relocate the image, if it needs it */ if (NtHeaders->OptionalHeader.ImageBase != (ULONG_PTR)VirtualBase) { WARN("Relocating %p -> %p\n", NtHeaders->OptionalHeader.ImageBase, VirtualBase); - return (BOOLEAN)LdrRelocateImageWithBias(PhysicalBase, - (ULONG_PTR)VirtualBase - (ULONG_PTR)PhysicalBase, - "FreeLdr", - TRUE, - TRUE, /* in case of conflict still return success */ - FALSE); + Status = LdrRelocateImageWithBias(PhysicalBase, + (ULONG_PTR)VirtualBase - (ULONG_PTR)PhysicalBase, + "FreeLdr", + ESUCCESS, + ESUCCESS, /* In case of conflict still return success */ + ENOEXEC); + if (Status != ESUCCESS) + goto Failure; } + /* Fill output parameters */ + *ImageBasePA = PhysicalBase; + TRACE("PeLdrLoadImage() done, PA = %p\n", *ImageBasePA); return TRUE; + +Failure: + /* Cleanup and bail out */ + MmFreeMemory(PhysicalBase); + return FALSE; } diff --git a/boot/freeldr/freeldr/ntldr/winldr.c b/boot/freeldr/freeldr/ntldr/winldr.c index 2721ce4f0ed..3e7abaa51f4 100644 --- a/boot/freeldr/freeldr/ntldr/winldr.c +++ b/boot/freeldr/freeldr/ntldr/winldr.c @@ -333,7 +333,9 @@ WinLdrLoadDeviceDriver(PLIST_ENTRY LoadOrderListHead, Success = PeLdrAllocateDataTableEntry(LoadOrderListHead, DllName, DllName, DriverBase, DriverDTE); if (!Success) { + /* Cleanup and bail out */ ERR("PeLdrAllocateDataTableEntry('%s') failed\n", DllName); + MmFreeMemory(DriverBase); return FALSE; } @@ -345,7 +347,10 @@ WinLdrLoadDeviceDriver(PLIST_ENTRY LoadOrderListHead, Success = PeLdrScanImportDescriptorTable(LoadOrderListHead, FullPath, *DriverDTE); if (!Success) { + /* Cleanup and bail out */ ERR("PeLdrScanImportDescriptorTable('%s') failed\n", FullPath); + PeLdrFreeDataTableEntry(*DriverDTE); + MmFreeMemory(DriverBase); return FALSE; } @@ -482,7 +487,7 @@ WinLdrDetectVersion(VOID) } static -BOOLEAN +PVOID LoadModule( IN OUT PLOADER_PARAMETER_BLOCK LoaderBlock, IN PCCH Path, @@ -495,7 +500,7 @@ LoadModule( BOOLEAN Success; CHAR FullFileName[MAX_PATH]; CHAR ProgressString[256]; - PVOID BaseAddress = NULL; + PVOID BaseAddress; RtlStringCbPrintfA(ProgressString, sizeof(ProgressString), "Loading %s...", File); if (!SosEnabled) UiDrawProgressBarCenter(Percentage, 100, ProgressString); @@ -508,15 +513,10 @@ LoadModule( if (!Success) { ERR("PeLdrLoadImage('%s') failed\n", File); - return FALSE; + return NULL; } TRACE("%s loaded successfully at %p\n", File, BaseAddress); - /* - * Cheat about the base DLL name if we are loading - * the Kernel Debugger Transport DLL, to make the - * PE loader happy. - */ Success = PeLdrAllocateDataTableEntry(&LoaderBlock->LoadOrderListHead, ImportName, FullFileName, @@ -524,10 +524,13 @@ LoadModule( Dte); if (!Success) { + /* Cleanup and bail out */ ERR("PeLdrAllocateDataTableEntry('%s') failed\n", FullFileName); + MmFreeMemory(BaseAddress); + BaseAddress = NULL; } - return Success; + return BaseAddress; } static @@ -541,7 +544,8 @@ LoadWindowsCore(IN USHORT OperatingSystemVersion, BOOLEAN Success; PCSTR Option; ULONG OptionLength; - PLDR_DATA_TABLE_ENTRY HalDTE, KdComDTE = NULL; + PVOID KernelBase, HalBase, KdDllBase = NULL; + PLDR_DATA_TABLE_ENTRY HalDTE, KdDllDTE = NULL; CHAR DirPath[MAX_PATH]; CHAR HalFileName[MAX_PATH]; CHAR KernelFileName[MAX_PATH]; @@ -585,17 +589,33 @@ LoadWindowsCore(IN USHORT OperatingSystemVersion, TRACE("HAL file = '%s' ; Kernel file = '%s'\n", HalFileName, KernelFileName); + /* + * Load the core NT files: Kernel, HAL and KD transport DLL. + * Cheat about their base DLL name so as to satisfy the imports/exports, + * even if the corresponding underlying files do not have the same names + * -- this happens e.g. with UP vs. MP kernel, standard vs. ACPI hal, or + * different KD transport DLLs. + */ + /* Load the Kernel */ - if (!LoadModule(LoaderBlock, DirPath, KernelFileName, "ntoskrnl.exe", LoaderSystemCode, KernelDTE, 30)) + KernelBase = LoadModule(LoaderBlock, DirPath, KernelFileName, + "ntoskrnl.exe", LoaderSystemCode, KernelDTE, 30); + if (!KernelBase) { - ERR("LoadModule() failed for %s\n", KernelFileName); + ERR("LoadModule('%s') failed\n", KernelFileName); + UiMessageBox("Could not load %s", KernelFileName); return FALSE; } /* Load the HAL */ - if (!LoadModule(LoaderBlock, DirPath, HalFileName, "hal.dll", LoaderHalCode, &HalDTE, 45)) + HalBase = LoadModule(LoaderBlock, DirPath, HalFileName, + "hal.dll", LoaderHalCode, &HalDTE, 45); + if (!HalBase) { - ERR("LoadModule() failed for %s\n", HalFileName); + ERR("LoadModule('%s') failed\n", HalFileName); + UiMessageBox("Could not load %s", HalFileName); + PeLdrFreeDataTableEntry(*KernelDTE); + MmFreeMemory(KernelBase); return FALSE; } @@ -651,10 +671,12 @@ LoadWindowsCore(IN USHORT OperatingSystemVersion, * Load the transport DLL. Override the base DLL name of the * loaded transport DLL to the default "KDCOM.DLL" name. */ - if (!LoadModule(LoaderBlock, DirPath, KdDllName, "kdcom.dll", LoaderSystemCode, &KdComDTE, 60)) + KdDllBase = LoadModule(LoaderBlock, DirPath, KdDllName, + "kdcom.dll", LoaderSystemCode, &KdDllDTE, 60); + if (!KdDllBase) { /* The transport DLL being optional, just ignore the failure */ - WARN("LoadModule() failed for %s\n", KdDllName); + WARN("LoadModule('%s') failed\n", KdDllName); } } } @@ -730,11 +752,42 @@ LoadWindowsCore(IN USHORT OperatingSystemVersion, } /* Load all referenced DLLs for Kernel, HAL and Kernel Debugger Transport DLL */ - Success = PeLdrScanImportDescriptorTable(&LoaderBlock->LoadOrderListHead, DirPath, *KernelDTE); - Success &= PeLdrScanImportDescriptorTable(&LoaderBlock->LoadOrderListHead, DirPath, HalDTE); - if (KdComDTE) + Success = PeLdrScanImportDescriptorTable(&LoaderBlock->LoadOrderListHead, DirPath, *KernelDTE); + if (!Success) + { + UiMessageBox("Could not load %s", KernelFileName); + goto Quit; + } + Success = PeLdrScanImportDescriptorTable(&LoaderBlock->LoadOrderListHead, DirPath, HalDTE); + if (!Success) + { + UiMessageBox("Could not load %s", HalFileName); + goto Quit; + } + if (KdDllDTE) + { + Success = PeLdrScanImportDescriptorTable(&LoaderBlock->LoadOrderListHead, DirPath, KdDllDTE); + if (!Success) + { + UiMessageBox("Could not load %s", KdDllName); + goto Quit; + } + } + +Quit: + if (!Success) { - Success &= PeLdrScanImportDescriptorTable(&LoaderBlock->LoadOrderListHead, DirPath, KdComDTE); + /* Cleanup and bail out */ + if (KdDllDTE) + PeLdrFreeDataTableEntry(KdDllDTE); + if (KdDllBase) // Optional + MmFreeMemory(KdDllBase); + + PeLdrFreeDataTableEntry(HalDTE); + MmFreeMemory(HalBase); + + PeLdrFreeDataTableEntry(*KernelDTE); + MmFreeMemory(KernelBase); } return Success;

2 years, 10 months

[reactos] 02/04: [FREELDR:NTLDR] Add some error handling for LoadModule(). Based on PR #4294 by Serge Gautherie.

by Hermès Bélusca-Maïto

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=15e1489c7f4986d93d72b… commit 15e1489c7f4986d93d72b61a4a3da7e61f219f24 Author: Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org> AuthorDate: Fri Feb 11 02:55:13 2022 +0100 Commit: Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org> CommitDate: Fri Feb 18 20:24:48 2022 +0100 [FREELDR:NTLDR] Add some error handling for LoadModule(). Based on PR #4294 by Serge Gautherie. Co-authored-by: Serge Gautherie <reactos-git_serge_171003(a)gautherie.fr> --- boot/freeldr/freeldr/ntldr/winldr.c | 31 +++++++++++++++++++++++++------ 1 file changed, 25 insertions(+), 6 deletions(-) diff --git a/boot/freeldr/freeldr/ntldr/winldr.c b/boot/freeldr/freeldr/ntldr/winldr.c index 66954e27d5e..2721ce4f0ed 100644 --- a/boot/freeldr/freeldr/ntldr/winldr.c +++ b/boot/freeldr/freeldr/ntldr/winldr.c @@ -324,13 +324,16 @@ WinLdrLoadDeviceDriver(PLIST_ENTRY LoadOrderListHead, NtLdrOutputLoadMsg(FullPath, NULL); Success = PeLdrLoadImage(FullPath, LoaderBootDriver, &DriverBase); if (!Success) + { + ERR("PeLdrLoadImage('%s') failed\n", DllName); return FALSE; + } // Allocate a DTE for it Success = PeLdrAllocateDataTableEntry(LoadOrderListHead, DllName, DllName, DriverBase, DriverDTE); if (!Success) { - ERR("PeLdrAllocateDataTableEntry() failed\n"); + ERR("PeLdrAllocateDataTableEntry('%s') failed\n", DllName); return FALSE; } @@ -342,7 +345,7 @@ WinLdrLoadDeviceDriver(PLIST_ENTRY LoadOrderListHead, Success = PeLdrScanImportDescriptorTable(LoadOrderListHead, FullPath, *DriverDTE); if (!Success) { - ERR("PeLdrScanImportDescriptorTable() failed for %s\n", FullPath); + ERR("PeLdrScanImportDescriptorTable('%s') failed\n", FullPath); return FALSE; } @@ -504,7 +507,7 @@ LoadModule( Success = PeLdrLoadImage(FullFileName, MemoryType, &BaseAddress); if (!Success) { - TRACE("Loading %s failed\n", File); + ERR("PeLdrLoadImage('%s') failed\n", File); return FALSE; } TRACE("%s loaded successfully at %p\n", File, BaseAddress); @@ -519,6 +522,10 @@ LoadModule( FullFileName, BaseAddress, Dte); + if (!Success) + { + ERR("PeLdrAllocateDataTableEntry('%s') failed\n", FullFileName); + } return Success; } @@ -579,10 +586,18 @@ LoadWindowsCore(IN USHORT OperatingSystemVersion, TRACE("HAL file = '%s' ; Kernel file = '%s'\n", HalFileName, KernelFileName); /* Load the Kernel */ - LoadModule(LoaderBlock, DirPath, KernelFileName, "ntoskrnl.exe", LoaderSystemCode, KernelDTE, 30); + if (!LoadModule(LoaderBlock, DirPath, KernelFileName, "ntoskrnl.exe", LoaderSystemCode, KernelDTE, 30)) + { + ERR("LoadModule() failed for %s\n", KernelFileName); + return FALSE; + } /* Load the HAL */ - LoadModule(LoaderBlock, DirPath, HalFileName, "hal.dll", LoaderHalCode, &HalDTE, 45); + if (!LoadModule(LoaderBlock, DirPath, HalFileName, "hal.dll", LoaderHalCode, &HalDTE, 45)) + { + ERR("LoadModule() failed for %s\n", HalFileName); + return FALSE; + } /* Load the Kernel Debugger Transport DLL */ if (OperatingSystemVersion > _WIN32_WINNT_WIN2K) @@ -636,7 +651,11 @@ LoadWindowsCore(IN USHORT OperatingSystemVersion, * Load the transport DLL. Override the base DLL name of the * loaded transport DLL to the default "KDCOM.DLL" name. */ - LoadModule(LoaderBlock, DirPath, KdDllName, "kdcom.dll", LoaderSystemCode, &KdComDTE, 60); + if (!LoadModule(LoaderBlock, DirPath, KdDllName, "kdcom.dll", LoaderSystemCode, &KdComDTE, 60)) + { + /* The transport DLL being optional, just ignore the failure */ + WARN("LoadModule() failed for %s\n", KdDllName); + } } }

2 years, 10 months

[reactos] 01/04: [FREELDR:NTLDR] Shorten KdTransportDllName --> KdDllName.

by Hermès Bélusca-Maïto

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=1a920d9a7e48fbf9e92ab… commit 1a920d9a7e48fbf9e92aba6a1391be6591452010 Author: Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org> AuthorDate: Fri Feb 18 03:58:47 2022 +0100 Commit: Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org> CommitDate: Fri Feb 18 20:24:47 2022 +0100 [FREELDR:NTLDR] Shorten KdTransportDllName --> KdDllName. --- boot/freeldr/freeldr/ntldr/winldr.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/boot/freeldr/freeldr/ntldr/winldr.c b/boot/freeldr/freeldr/ntldr/winldr.c index 3a21d2fe01a..66954e27d5e 100644 --- a/boot/freeldr/freeldr/ntldr/winldr.c +++ b/boot/freeldr/freeldr/ntldr/winldr.c @@ -538,7 +538,7 @@ LoadWindowsCore(IN USHORT OperatingSystemVersion, CHAR DirPath[MAX_PATH]; CHAR HalFileName[MAX_PATH]; CHAR KernelFileName[MAX_PATH]; - CHAR KdTransportDllName[MAX_PATH]; + CHAR KdDllName[MAX_PATH]; if (!KernelDTE) return FALSE; @@ -614,10 +614,10 @@ LoadWindowsCore(IN USHORT OperatingSystemVersion, * If we only have /DEBUGPORT= (i.e. without any port name), * defaults it to "COM". */ - RtlStringCbCopyA(KdTransportDllName, sizeof(KdTransportDllName), "KD"); + RtlStringCbCopyA(KdDllName, sizeof(KdDllName), "KD"); if (_strnicmp(Option, "COM", 3) == 0 && '0' <= Option[3] && Option[3] <= '9') { - RtlStringCbCatNA(KdTransportDllName, sizeof(KdTransportDllName), Option, 3); + RtlStringCbCatNA(KdDllName, sizeof(KdDllName), Option, 3); } else { @@ -625,18 +625,18 @@ LoadWindowsCore(IN USHORT OperatingSystemVersion, * until the next whitespace or colon. */ OptionLength = (ULONG)strcspn(Option, " \t:"); if (OptionLength == 0) - RtlStringCbCatA(KdTransportDllName, sizeof(KdTransportDllName), "COM"); + RtlStringCbCatA(KdDllName, sizeof(KdDllName), "COM"); else - RtlStringCbCatNA(KdTransportDllName, sizeof(KdTransportDllName), Option, OptionLength); + RtlStringCbCatNA(KdDllName, sizeof(KdDllName), Option, OptionLength); } - RtlStringCbCatA(KdTransportDllName, sizeof(KdTransportDllName), ".DLL"); - _strupr(KdTransportDllName); + RtlStringCbCatA(KdDllName, sizeof(KdDllName), ".DLL"); + _strupr(KdDllName); /* * Load the transport DLL. Override the base DLL name of the * loaded transport DLL to the default "KDCOM.DLL" name. */ - LoadModule(LoaderBlock, DirPath, KdTransportDllName, "kdcom.dll", LoaderSystemCode, &KdComDTE, 60); + LoadModule(LoaderBlock, DirPath, KdDllName, "kdcom.dll", LoaderSystemCode, &KdComDTE, 60); } }

2 years, 10 months

[reactos] 02/02: [CRT] Fix some inconsistent annotations in CRT headers.

by Thomas Faber

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=b72efb6ca85b43097713a… commit b72efb6ca85b43097713a45f7fb72e5937fb2cd2 Author: Thomas Faber <thomas.faber(a)reactos.org> AuthorDate: Thu Nov 25 11:13:11 2021 -0500 Commit: Thomas Faber <thomas.faber(a)reactos.org> CommitDate: Thu Feb 17 22:01:37 2022 -0500 [CRT] Fix some inconsistent annotations in CRT headers. This fixes about 5000 VS analysis warnings. --- sdk/include/crt/io.h | 2 ++ sdk/include/crt/stdlib.h | 2 +- sdk/include/crt/string.h | 2 +- 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/sdk/include/crt/io.h b/sdk/include/crt/io.h index 404407d7dba..e6a452cc0ac 100644 --- a/sdk/include/crt/io.h +++ b/sdk/include/crt/io.h @@ -474,6 +474,7 @@ _getcwd( #include <string.h> #endif + _Check_return_ __CRT_INLINE intptr_t __cdecl @@ -492,6 +493,7 @@ _getcwd( return ret; } + _Check_return_ __CRT_INLINE int __cdecl diff --git a/sdk/include/crt/stdlib.h b/sdk/include/crt/stdlib.h index 3985a547536..e3548a84a71 100644 --- a/sdk/include/crt/stdlib.h +++ b/sdk/include/crt/stdlib.h @@ -1432,7 +1432,7 @@ extern "C" { _Check_return_ long long __cdecl llabs(_In_ long long _j); #pragma function(llabs) #endif - __MINGW_EXTENSION __CRT_INLINE long long __cdecl llabs(_In_ long long _j) { return (_j >= 0 ? _j : -_j); } + __MINGW_EXTENSION _Check_return_ __CRT_INLINE long long __cdecl llabs(_In_ long long _j) { return (_j >= 0 ? _j : -_j); } __MINGW_EXTENSION long long __cdecl strtoll(const char* __restrict__, char** __restrict, int); __MINGW_EXTENSION unsigned long long __cdecl strtoull(const char* __restrict__, char** __restrict__, int); diff --git a/sdk/include/crt/string.h b/sdk/include/crt/string.h index 23cf26a9ce1..1dd1fe0aba1 100644 --- a/sdk/include/crt/string.h +++ b/sdk/include/crt/string.h @@ -508,7 +508,7 @@ extern "C" { _strupr_s_l( _Inout_updates_z_(_Size) char *_Str, _In_ size_t _Size, - _locale_t _Locale); + _In_opt_ _locale_t _Locale); _Check_return_wat_ _CRTIMP

2 years, 10 months

[reactos] 01/02: [USBPORT] Fix incorrect use of bitfields.

by Thomas Faber

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=f5c5426924c25df4c1601… commit f5c5426924c25df4c16018cfca752963e982f485 Author: Thomas Faber <thomas.faber(a)reactos.org> AuthorDate: Thu Nov 25 09:30:03 2021 -0500 Commit: Thomas Faber <thomas.faber(a)reactos.org> CommitDate: Thu Feb 17 22:01:34 2022 -0500 [USBPORT] Fix incorrect use of bitfields. EndpointMoved == TRUE could never be true, because BOOL is a signed type, and the only two values in a signed one-bit type are 0 and -1. Courtesy of VS analysis warning C6299: Explicitly comparing a bit field to a Boolean type will yield unexpected results. --- drivers/usb/usbport/usb2.c | 4 ++-- drivers/usb/usbport/usbport.h | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/usb/usbport/usb2.c b/drivers/usb/usbport/usb2.c index 1d609addaa7..9d7a6548bc1 100644 --- a/drivers/usb/usbport/usb2.c +++ b/drivers/usb/usbport/usb2.c @@ -644,7 +644,7 @@ USB2_MoveTtEndpoint(IN PUSB2_TT_ENDPOINT TtEndpoint, TransferType = TtEndpoint->TtEndpointParams.TransferType; if (Rebalance->RebalanceEndpoint[Num] && - TtEndpoint->TtEndpointParams.EndpointMoved == TRUE && + TtEndpoint->TtEndpointParams.EndpointMoved && ((TransferType != USBPORT_TRANSFER_TYPE_INTERRUPT) || BusTime >= 0)) { DPRINT("USB2_MoveTtEndpoint: result - FALSE\n"); @@ -668,7 +668,7 @@ USB2_MoveTtEndpoint(IN PUSB2_TT_ENDPOINT TtEndpoint, *OutResult = FALSE; } - TtEndpoint->TtEndpointParams.EndpointMoved = TRUE; + TtEndpoint->TtEndpointParams.EndpointMoved = 1; if (Rebalance->RebalanceEndpoint[Num] == NULL) { diff --git a/drivers/usb/usbport/usbport.h b/drivers/usb/usbport/usbport.h index 04936bfe304..02726fea48c 100644 --- a/drivers/usb/usbport/usbport.h +++ b/drivers/usb/usbport/usbport.h @@ -486,8 +486,8 @@ typedef union _USB2_TT_ENDPOINT_PARAMS { struct { ULONG TransferType : 4; ULONG Direction : 1; - USB_DEVICE_SPEED DeviceSpeed : 2; - BOOL EndpointMoved : 1; + ULONG DeviceSpeed : 2; + ULONG EndpointMoved : 1; ULONG Reserved : 24; }; ULONG AsULONG;

2 years, 10 months

[reactos] 01/01: [WIN32SS] Store the scrollbar theming enabled flag in the scrollbar

by Mark Jansen

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=fd28a69de63f1a801384e… commit fd28a69de63f1a801384e3d6c5675189aa82455e Author: Mark Jansen <mark.jansen(a)reactos.org> AuthorDate: Wed Feb 16 18:41:43 2022 +0100 Commit: Mark Jansen <mark.jansen(a)reactos.org> CommitDate: Wed Feb 16 18:43:32 2022 +0100 [WIN32SS] Store the scrollbar theming enabled flag in the scrollbar This ensure we do not rely on usermode for always passing this flag in, which is a ReactOS specific flag. Thanks to Doug Lyons for finding the source of the problem. CORE-17780 --- win32ss/user/ntuser/scrollbar.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/win32ss/user/ntuser/scrollbar.c b/win32ss/user/ntuser/scrollbar.c index e4e0ba436af..9d5e4005dcb 100644 --- a/win32ss/user/ntuser/scrollbar.c +++ b/win32ss/user/ntuser/scrollbar.c @@ -528,6 +528,11 @@ co_IntSetScrollInfo(PWND Window, INT nBar, LPCSCROLLINFO lpsi, BOOL bRedraw) Info = IntGetScrollInfoFromWindow(Window, nBar); pSBData = IntGetSBData(Window, nBar); + if (lpsi->fMask & SIF_THEMED && !(Info->fMask & SIF_THEMED)) + { + Info->fMask |= SIF_THEMED; + } + /* Set the page size */ if (lpsi->fMask & SIF_PAGE) { @@ -660,7 +665,7 @@ co_IntSetScrollInfo(PWND Window, INT nBar, LPCSCROLLINFO lpsi, BOOL bRedraw) return lpsi->fMask & SIF_PREVIOUSPOS ? OldPos : pSBData->pos; /* SetWindowPos() already did the painting */ if (bRedraw) { - if (!(lpsi->fMask & SIF_THEMED)) /* Not Using Themes */ + if (!(Info->fMask & SIF_THEMED)) /* Not Using Themes */ { TRACE("Not using themes.\n"); if (action & SA_SSI_REPAINT_ARROWS)

2 years, 10 months

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs February 2022