Ros-diffs March 2022

ros-diffs@reactos.org

20 participants
436 discussions

[reactos] 01/01: [HALX64] Do not claim to handle display reset if you don't. Fix bootvid display initialization in x64 as a result.

by Hermès Bélusca-Maïto

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=215148267e7bad7587f5e… commit 215148267e7bad7587f5e09757013e221d4cf122 Author: Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org> AuthorDate: Mon Mar 28 00:28:35 2022 +0200 Commit: Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org> CommitDate: Mon Mar 28 00:32:25 2022 +0200 [HALX64] Do not claim to handle display reset if you don't. Fix bootvid display initialization in x64 as a result. The HalpBiosDisplayReset() function is currently stub-plemented. Returning FALSE will make bootvid take the route of fully re-initializing the VGA display all by itself. --- hal/halx86/amd64/x86bios.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/hal/halx86/amd64/x86bios.c b/hal/halx86/amd64/x86bios.c index cbcc75de6cc..3baef39f69c 100644 --- a/hal/halx86/amd64/x86bios.c +++ b/hal/halx86/amd64/x86bios.c @@ -510,7 +510,9 @@ HalpBiosDisplayReset(VOID) /* Restore previous flags */ __writeeflags(OldEflags); -#endif return TRUE; +#else + /* This x64 HAL does NOT currently handle display reset (TODO) */ + return FALSE; +#endif } -

2 years, 5 months

[reactos] 01/01: [DISKPART] Implement the detail command

by Eric Kohl

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=38b38bbf0c74dadb3843d… commit 38b38bbf0c74dadb3843d30100ca7461b80cf801 Author: Eric Kohl <eric.kohl(a)reactos.org> AuthorDate: Mon Mar 28 00:25:34 2022 +0200 Commit: Eric Kohl <eric.kohl(a)reactos.org> CommitDate: Mon Mar 28 00:25:34 2022 +0200 [DISKPART] Implement the detail command Display disk and partition details. --- base/system/diskpart/detail.c | 125 ++++++++++++++++++++++++++++++++++++- base/system/diskpart/lang/en-US.rc | 13 ++-- base/system/diskpart/lang/pl-PL.rc | 13 ++-- base/system/diskpart/lang/pt-PT.rc | 13 ++-- base/system/diskpart/lang/ro-RO.rc | 13 ++-- base/system/diskpart/lang/ru-RU.rc | 13 ++-- base/system/diskpart/lang/sq-AL.rc | 13 ++-- base/system/diskpart/lang/tr-TR.rc | 13 ++-- base/system/diskpart/lang/zh-CN.rc | 13 ++-- base/system/diskpart/lang/zh-TW.rc | 13 ++-- base/system/diskpart/resource.h | 7 +++ 11 files changed, 212 insertions(+), 37 deletions(-) diff --git a/base/system/diskpart/detail.c b/base/system/diskpart/detail.c index 062c60216b4..464085149fc 100644 --- a/base/system/diskpart/detail.c +++ b/base/system/diskpart/detail.c @@ -8,7 +8,130 @@ #include "diskpart.h" -BOOL detail_main(INT argc, LPWSTR *argv) +#define NDEBUG +#include <debug.h> + +/* FUNCTIONS ******************************************************************/ + +static +VOID +DetailDisk( + INT argc, + LPWSTR *argv) { + DPRINT("DetailDisk()\n"); + + if (argc > 2) + { + ConResPuts(StdErr, IDS_ERROR_INVALID_ARGS); + return; + } + + if (CurrentDisk == NULL) + { + ConResPuts(StdOut, IDS_SELECT_NO_DISK); + return; + } + + /* TODO: Print more disk details */ + ConPuts(StdOut, L"\n"); + ConResPrintf(StdOut, IDS_DETAIL_INFO_DISK_ID, CurrentDisk->LayoutBuffer->Signature); + ConResPrintf(StdOut, IDS_DETAIL_INFO_PATH, CurrentDisk->PathId); + ConResPrintf(StdOut, IDS_DETAIL_INFO_TARGET, CurrentDisk->TargetId); + ConResPrintf(StdOut, IDS_DETAIL_INFO_LUN_ID, CurrentDisk->Lun); + ConPuts(StdOut, L"\n"); +} + + +static +VOID +DetailPartition( + INT argc, + LPWSTR *argv) +{ + PPARTENTRY PartEntry; + ULONGLONG PartOffset; + + DPRINT("DetailPartition()\n"); + + if (argc > 2) + { + ConResPuts(StdErr, IDS_ERROR_INVALID_ARGS); + return; + } + + if (CurrentDisk == NULL) + { + ConResPuts(StdOut, IDS_SELECT_PARTITION_NO_DISK); + return; + } + + if (CurrentPartition == NULL) + { + ConResPuts(StdOut, IDS_SELECT_NO_PARTITION); + return; + } + + PartEntry = CurrentPartition; + PartOffset = PartEntry->StartSector.QuadPart * CurrentDisk->BytesPerSector; + + /* TODO: Print more partition details */ + ConPuts(StdOut, L"\n"); + ConResPrintf(StdOut, IDS_DETAIL_PARTITION_NUMBER, PartEntry->PartitionNumber); + ConResPrintf(StdOut, IDS_DETAIL_PARTITION_TYPE, PartEntry->PartitionType); + ConResPrintf(StdOut, IDS_DETAIL_PARTITION_HIDDEN, ""); + ConResPrintf(StdOut, IDS_DETAIL_PARTITION_ACTIVE, PartEntry->BootIndicator ? L"Yes" : L"No"); + ConResPrintf(StdOut, IDS_DETAIL_PARTITION_OFFSET, PartOffset); + ConPuts(StdOut, L"\n"); +} + + +static +VOID +DetailVolume( + INT argc, + LPWSTR *argv) +{ + DPRINT("DetailVolume()\n"); + + if (argc > 2) + { + ConResPuts(StdErr, IDS_ERROR_INVALID_ARGS); + return; + } + + if (CurrentVolume == NULL) + { + ConResPuts(StdOut, IDS_SELECT_NO_VOLUME); + return; + } + + /* TODO: Print volume details */ + +} + + +BOOL +detail_main( + INT argc, + LPWSTR *argv) +{ + /* gets the first word from the string */ + if (argc == 1) + { + ConResPuts(StdOut, IDS_HELP_CMD_DETAIL); + return TRUE; + } + + /* determines which details to print (disk, partition, etc.) */ + if (!wcsicmp(argv[1], L"disk")) + DetailDisk(argc, argv); + else if (!wcsicmp(argv[1], L"partition")) + DetailPartition(argc, argv); + else if (!wcsicmp(argv[1], L"volume")) + DetailVolume(argc, argv); + else + ConResPuts(StdOut, IDS_HELP_CMD_DETAIL); + return TRUE; } diff --git a/base/system/diskpart/lang/en-US.rc b/base/system/diskpart/lang/en-US.rc index f23a5cc13e0..50a6c13fcdd 100644 --- a/base/system/diskpart/lang/en-US.rc +++ b/base/system/diskpart/lang/en-US.rc @@ -18,12 +18,12 @@ END /* Disk Information Labels */ STRINGTABLE BEGIN - IDS_DETAIL_INFO_DISK_ID "Disk" + IDS_DETAIL_INFO_DISK_ID "Disk ID: %08lx\n" IDS_DETAIL_INFO_TYPE "Type" IDS_DETAIL_INFO_STATUS "Status" - IDS_DETAIL_INFO_PATH "Path" - IDS_DETAIL_INFO_TARGET "Target" - IDS_DETAIL_INFO_LUN_ID "LUN ID" + IDS_DETAIL_INFO_PATH "Path : %hu\n" + IDS_DETAIL_INFO_TARGET "Target : %hu\n" + IDS_DETAIL_INFO_LUN_ID "Lun ID : %hu\n" IDS_DETAIL_INFO_LOC_PATH "Location Path" IDS_DETAIL_INFO_CURR_RO_STATE "Current Read-only State" IDS_DETAIL_INFO_RO "Read-only" @@ -32,6 +32,11 @@ BEGIN IDS_DETAIL_INFO_HIBER_FILE_DSK "Hibernation File Disk" IDS_DETAIL_INFO_CRASH_DSK "Crashdump Disk" IDS_DETAIL_INFO_CLST_DSK "Clustered Disk" + IDS_DETAIL_PARTITION_NUMBER "Partition %lu\n" + IDS_DETAIL_PARTITION_TYPE "Type : %02x\n" + IDS_DETAIL_PARTITION_HIDDEN "Hidden : %s\n" + IDS_DETAIL_PARTITION_ACTIVE "Active : %s\n" + IDS_DETAIL_PARTITION_OFFSET "Offset in Byte: %I64u\n" END /* Detail header titles */ diff --git a/base/system/diskpart/lang/pl-PL.rc b/base/system/diskpart/lang/pl-PL.rc index 2656950d8b7..5d5efe940f4 100644 --- a/base/system/diskpart/lang/pl-PL.rc +++ b/base/system/diskpart/lang/pl-PL.rc @@ -18,12 +18,12 @@ END /* Disk Information Labels */ STRINGTABLE BEGIN - IDS_DETAIL_INFO_DISK_ID "Dysk" + IDS_DETAIL_INFO_DISK_ID "Dysk ID: %08lx\n" IDS_DETAIL_INFO_TYPE "Typ" IDS_DETAIL_INFO_STATUS "Stan" - IDS_DETAIL_INFO_PATH "Ścieżka" - IDS_DETAIL_INFO_TARGET "Docelowy" - IDS_DETAIL_INFO_LUN_ID "Identyfikator LUN" + IDS_DETAIL_INFO_PATH "Ścieżka : %hu\n" + IDS_DETAIL_INFO_TARGET "Docelowy : %hu\n" + IDS_DETAIL_INFO_LUN_ID "Identyfikator LUN : %hu\n" IDS_DETAIL_INFO_LOC_PATH "Ścieżka lokalizacji" IDS_DETAIL_INFO_CURR_RO_STATE "Aktualny stan Read-only" IDS_DETAIL_INFO_RO "Tylko do odczytu" @@ -32,6 +32,11 @@ BEGIN IDS_DETAIL_INFO_HIBER_FILE_DSK "Dysk pliku hibernacji" IDS_DETAIL_INFO_CRASH_DSK "Dysk zrzutu awarii systemu" IDS_DETAIL_INFO_CLST_DSK "Dysk klastrowany" + IDS_DETAIL_PARTITION_NUMBER "Partition %lu\n" + IDS_DETAIL_PARTITION_TYPE "Type : %02x\n" + IDS_DETAIL_PARTITION_HIDDEN "Hidden : %s\n" + IDS_DETAIL_PARTITION_ACTIVE "Active : %s\n" + IDS_DETAIL_PARTITION_OFFSET "Offset in Byte: %I64u\n" END /* Detail header titles */ diff --git a/base/system/diskpart/lang/pt-PT.rc b/base/system/diskpart/lang/pt-PT.rc index f3321412c72..ddbeba2fc2f 100644 --- a/base/system/diskpart/lang/pt-PT.rc +++ b/base/system/diskpart/lang/pt-PT.rc @@ -20,12 +20,12 @@ END /* Disk Information Labels */ STRINGTABLE BEGIN - IDS_DETAIL_INFO_DISK_ID "Disco" + IDS_DETAIL_INFO_DISK_ID "Disco ID: %08lx\n" IDS_DETAIL_INFO_TYPE "Tipo" IDS_DETAIL_INFO_STATUS "Estado" - IDS_DETAIL_INFO_PATH "Caminho" - IDS_DETAIL_INFO_TARGET "Alvo" - IDS_DETAIL_INFO_LUN_ID "LUN ID" + IDS_DETAIL_INFO_PATH "Caminho : %hu\n" + IDS_DETAIL_INFO_TARGET "Alvo : %hu\n" + IDS_DETAIL_INFO_LUN_ID "LUN ID : %hu\n" IDS_DETAIL_INFO_LOC_PATH "Caminho de localização" IDS_DETAIL_INFO_CURR_RO_STATE "Estado actual somente de leitura" IDS_DETAIL_INFO_RO "Apenas leitura" @@ -34,6 +34,11 @@ BEGIN IDS_DETAIL_INFO_HIBER_FILE_DSK "Ficheiro de hibernação de disco" IDS_DETAIL_INFO_CRASH_DSK "Despejo de memória de disco" IDS_DETAIL_INFO_CLST_DSK "Disco em cluster" + IDS_DETAIL_PARTITION_NUMBER "Partition %lu\n" + IDS_DETAIL_PARTITION_TYPE "Type : %02x\n" + IDS_DETAIL_PARTITION_HIDDEN "Hidden : %s\n" + IDS_DETAIL_PARTITION_ACTIVE "Active : %s\n" + IDS_DETAIL_PARTITION_OFFSET "Offset in Byte: %I64u\n" END /* Detail header titles */ diff --git a/base/system/diskpart/lang/ro-RO.rc b/base/system/diskpart/lang/ro-RO.rc index 99c311a7800..6e82e7c8b9e 100644 --- a/base/system/diskpart/lang/ro-RO.rc +++ b/base/system/diskpart/lang/ro-RO.rc @@ -20,12 +20,12 @@ END /* Disk Information Labels */ STRINGTABLE BEGIN - IDS_DETAIL_INFO_DISK_ID "Disc" + IDS_DETAIL_INFO_DISK_ID "Disc ID: %08lx\n" IDS_DETAIL_INFO_TYPE "Tip" IDS_DETAIL_INFO_STATUS "Stare" - IDS_DETAIL_INFO_PATH "Cale" - IDS_DETAIL_INFO_TARGET "Țintă" - IDS_DETAIL_INFO_LUN_ID "LUN ID" + IDS_DETAIL_INFO_PATH "Cale : %hu\n" + IDS_DETAIL_INFO_TARGET "Țintă : %hu\n" + IDS_DETAIL_INFO_LUN_ID "LUN ID : %hu\n" IDS_DETAIL_INFO_LOC_PATH "Localizat în" IDS_DETAIL_INFO_CURR_RO_STATE "Stare curentă nemodificabilă" IDS_DETAIL_INFO_RO "Nemodificabil" @@ -34,6 +34,11 @@ BEGIN IDS_DETAIL_INFO_HIBER_FILE_DSK "Disc cu fișier de hibernare" IDS_DETAIL_INFO_CRASH_DSK "Disc cu fișier «crashdump»" IDS_DETAIL_INFO_CLST_DSK "Disc în «cluster»" + IDS_DETAIL_PARTITION_NUMBER "Partition %lu\n" + IDS_DETAIL_PARTITION_TYPE "Type : %02x\n" + IDS_DETAIL_PARTITION_HIDDEN "Hidden : %s\n" + IDS_DETAIL_PARTITION_ACTIVE "Active : %s\n" + IDS_DETAIL_PARTITION_OFFSET "Offset in Byte: %I64u\n" END /* Detail header titles */ diff --git a/base/system/diskpart/lang/ru-RU.rc b/base/system/diskpart/lang/ru-RU.rc index ad20e840a0c..6e9a8cb5b48 100644 --- a/base/system/diskpart/lang/ru-RU.rc +++ b/base/system/diskpart/lang/ru-RU.rc @@ -20,12 +20,12 @@ END /* Disk Information Labels */ STRINGTABLE BEGIN - IDS_DETAIL_INFO_DISK_ID "Диск" + IDS_DETAIL_INFO_DISK_ID "Disk ID: %08lx\n" IDS_DETAIL_INFO_TYPE "Тип" IDS_DETAIL_INFO_STATUS "Состояние" - IDS_DETAIL_INFO_PATH "Путь" - IDS_DETAIL_INFO_TARGET "Цель" - IDS_DETAIL_INFO_LUN_ID "LUN ID" + IDS_DETAIL_INFO_PATH "Path : %hu\n" + IDS_DETAIL_INFO_TARGET "Target : %hu\n" + IDS_DETAIL_INFO_LUN_ID "Lun ID : %hu\n" IDS_DETAIL_INFO_LOC_PATH "Путь к диску" IDS_DETAIL_INFO_CURR_RO_STATE "Текущее состояние ""Только для чтения""" IDS_DETAIL_INFO_RO "Только для чтения" @@ -34,6 +34,11 @@ BEGIN IDS_DETAIL_INFO_HIBER_FILE_DSK "Hibernation File диск" IDS_DETAIL_INFO_CRASH_DSK "Crashdump диск" IDS_DETAIL_INFO_CLST_DSK "Кластерный диск" + IDS_DETAIL_PARTITION_NUMBER "Partition %lu\n" + IDS_DETAIL_PARTITION_TYPE "Type : %02x\n" + IDS_DETAIL_PARTITION_HIDDEN "Hidden : %s\n" + IDS_DETAIL_PARTITION_ACTIVE "Active : %s\n" + IDS_DETAIL_PARTITION_OFFSET "Offset in Byte: %I64u\n" END /* Detail header titles */ diff --git a/base/system/diskpart/lang/sq-AL.rc b/base/system/diskpart/lang/sq-AL.rc index 2238218d669..3f1222bcb8a 100644 --- a/base/system/diskpart/lang/sq-AL.rc +++ b/base/system/diskpart/lang/sq-AL.rc @@ -22,12 +22,12 @@ END /* Disk Information Labels */ STRINGTABLE BEGIN - IDS_DETAIL_INFO_DISK_ID "Disk" + IDS_DETAIL_INFO_DISK_ID "Disk ID: %08lx\n" IDS_DETAIL_INFO_TYPE "Tipi" IDS_DETAIL_INFO_STATUS "Gjendja" - IDS_DETAIL_INFO_PATH "Rrugë" - IDS_DETAIL_INFO_TARGET "Objektivi" - IDS_DETAIL_INFO_LUN_ID "LUN ID" + IDS_DETAIL_INFO_PATH "Path : %hu\n" + IDS_DETAIL_INFO_TARGET "Target : %hu\n" + IDS_DETAIL_INFO_LUN_ID "Lun ID : %hu\n" IDS_DETAIL_INFO_LOC_PATH "Rruga e vendndodhjes" IDS_DETAIL_INFO_CURR_RO_STATE "Read-only Gjendja aktuale" IDS_DETAIL_INFO_RO "Read-only" @@ -36,6 +36,11 @@ BEGIN IDS_DETAIL_INFO_HIBER_FILE_DSK "Hibernimi i dokumeteve Disk" IDS_DETAIL_INFO_CRASH_DSK "Hedhja e te dhenave Disk" IDS_DETAIL_INFO_CLST_DSK "Grupimet ne Disk" + IDS_DETAIL_PARTITION_NUMBER "Partition %lu\n" + IDS_DETAIL_PARTITION_TYPE "Type : %02x\n" + IDS_DETAIL_PARTITION_HIDDEN "Hidden : %s\n" + IDS_DETAIL_PARTITION_ACTIVE "Active : %s\n" + IDS_DETAIL_PARTITION_OFFSET "Offset in Byte: %I64u\n" END /* Detail header titles */ diff --git a/base/system/diskpart/lang/tr-TR.rc b/base/system/diskpart/lang/tr-TR.rc index 193502965c6..bb77084dd56 100644 --- a/base/system/diskpart/lang/tr-TR.rc +++ b/base/system/diskpart/lang/tr-TR.rc @@ -20,12 +20,12 @@ END /* Disk Information Labels */ STRINGTABLE BEGIN - IDS_DETAIL_INFO_DISK_ID "Disk" + IDS_DETAIL_INFO_DISK_ID "Disk ID: %08lx\n" IDS_DETAIL_INFO_TYPE "Tür" IDS_DETAIL_INFO_STATUS "Durum" - IDS_DETAIL_INFO_PATH "Yol" - IDS_DETAIL_INFO_TARGET "Varış" - IDS_DETAIL_INFO_LUN_ID "LUN ID" + IDS_DETAIL_INFO_PATH "Path : %hu\n" + IDS_DETAIL_INFO_TARGET "Target : %hu\n" + IDS_DETAIL_INFO_LUN_ID "Lun ID : %hu\n" IDS_DETAIL_INFO_LOC_PATH "Konum Yolu" IDS_DETAIL_INFO_CURR_RO_STATE "Şimdiki Yalnızca Okunur Durumu" IDS_DETAIL_INFO_RO "Yalnızca Okunur" @@ -34,6 +34,11 @@ BEGIN IDS_DETAIL_INFO_HIBER_FILE_DSK "Hazırda Bekletme Dosyası Diski" IDS_DETAIL_INFO_CRASH_DSK "Çöküş Dökümü Diski" IDS_DETAIL_INFO_CLST_DSK "Kümelenmiş Disk" + IDS_DETAIL_PARTITION_NUMBER "Partition %lu\n" + IDS_DETAIL_PARTITION_TYPE "Type : %02x\n" + IDS_DETAIL_PARTITION_HIDDEN "Hidden : %s\n" + IDS_DETAIL_PARTITION_ACTIVE "Active : %s\n" + IDS_DETAIL_PARTITION_OFFSET "Offset in Byte: %I64u\n" END /* Detail header titles */ diff --git a/base/system/diskpart/lang/zh-CN.rc b/base/system/diskpart/lang/zh-CN.rc index e04d919004c..06ee3182e2f 100644 --- a/base/system/diskpart/lang/zh-CN.rc +++ b/base/system/diskpart/lang/zh-CN.rc @@ -21,12 +21,12 @@ END /* Disk Information Labels */ STRINGTABLE BEGIN - IDS_DETAIL_INFO_DISK_ID "磁盘" + IDS_DETAIL_INFO_DISK_ID "Disk ID: %08lx\n" IDS_DETAIL_INFO_TYPE "类型" IDS_DETAIL_INFO_STATUS "状态" - IDS_DETAIL_INFO_PATH "路径" - IDS_DETAIL_INFO_TARGET "目标" - IDS_DETAIL_INFO_LUN_ID "LUN ID" + IDS_DETAIL_INFO_PATH "Path : %hu\n" + IDS_DETAIL_INFO_TARGET "Target : %hu\n" + IDS_DETAIL_INFO_LUN_ID "Lun ID : %hu\n" IDS_DETAIL_INFO_LOC_PATH "位置路径" IDS_DETAIL_INFO_CURR_RO_STATE "当前的只读状态" IDS_DETAIL_INFO_RO "只读模式" @@ -35,6 +35,11 @@ BEGIN IDS_DETAIL_INFO_HIBER_FILE_DSK "休眠文件磁盘" IDS_DETAIL_INFO_CRASH_DSK "故障转储磁盘" IDS_DETAIL_INFO_CLST_DSK "群集的磁盘" + IDS_DETAIL_PARTITION_NUMBER "Partition %lu\n" + IDS_DETAIL_PARTITION_TYPE "Type : %02x\n" + IDS_DETAIL_PARTITION_HIDDEN "Hidden : %s\n" + IDS_DETAIL_PARTITION_ACTIVE "Active : %s\n" + IDS_DETAIL_PARTITION_OFFSET "Offset in Byte: %I64u\n" END /* Detail header titles */ diff --git a/base/system/diskpart/lang/zh-TW.rc b/base/system/diskpart/lang/zh-TW.rc index 15a26899024..1674d6585fb 100644 --- a/base/system/diskpart/lang/zh-TW.rc +++ b/base/system/diskpart/lang/zh-TW.rc @@ -21,12 +21,12 @@ END /* Disk Information Labels */ STRINGTABLE BEGIN - IDS_DETAIL_INFO_DISK_ID "磁碟" + IDS_DETAIL_INFO_DISK_ID "Disk ID: %08lx\n" IDS_DETAIL_INFO_TYPE "類型" IDS_DETAIL_INFO_STATUS "狀態" - IDS_DETAIL_INFO_PATH "路徑" - IDS_DETAIL_INFO_TARGET "目標" - IDS_DETAIL_INFO_LUN_ID "LUN ID" + IDS_DETAIL_INFO_PATH "Path : %hu\n" + IDS_DETAIL_INFO_TARGET "Target : %hu\n" + IDS_DETAIL_INFO_LUN_ID "Lun ID : %hu\n" IDS_DETAIL_INFO_LOC_PATH "位置路徑" IDS_DETAIL_INFO_CURR_RO_STATE "當前的唯讀狀態" IDS_DETAIL_INFO_RO "唯讀模式" @@ -35,6 +35,11 @@ BEGIN IDS_DETAIL_INFO_HIBER_FILE_DSK "休眠檔案磁碟" IDS_DETAIL_INFO_CRASH_DSK "損毀傾印磁碟" IDS_DETAIL_INFO_CLST_DSK "叢集磁碟" + IDS_DETAIL_PARTITION_NUMBER "Partition %lu\n" + IDS_DETAIL_PARTITION_TYPE "Type : %02x\n" + IDS_DETAIL_PARTITION_HIDDEN "Hidden : %s\n" + IDS_DETAIL_PARTITION_ACTIVE "Active : %s\n" + IDS_DETAIL_PARTITION_OFFSET "Offset in Byte: %I64u\n" END /* Detail header titles */ diff --git a/base/system/diskpart/resource.h b/base/system/diskpart/resource.h index 34924947a98..ab5989de4d3 100644 --- a/base/system/diskpart/resource.h +++ b/base/system/diskpart/resource.h @@ -32,6 +32,12 @@ #define IDS_DETAIL_INFO_CRASH_DSK 19 #define IDS_DETAIL_INFO_CLST_DSK 20 +#define IDS_DETAIL_PARTITION_NUMBER 30 +#define IDS_DETAIL_PARTITION_TYPE 31 +#define IDS_DETAIL_PARTITION_HIDDEN 32 +#define IDS_DETAIL_PARTITION_ACTIVE 33 +#define IDS_DETAIL_PARTITION_OFFSET 34 + #define IDS_LIST_DISK_HEAD 3300 #define IDS_LIST_DISK_LINE 3301 #define IDS_LIST_DISK_FORMAT 3302 @@ -121,6 +127,7 @@ #define IDS_HELP_CMD_COMPACT 113 #define IDS_HELP_CMD_CONVERT 114 #define IDS_HELP_CMD_CREATE 115 +#define IDS_HELP_CMD_CREATE_PARTITION 180 #define IDS_HELP_CMD_DELETE 116 #define IDS_HELP_CMD_DETACH 117 #define IDS_HELP_CMD_DETAIL 118

2 years, 5 months

[reactos] 01/01: [DISKPART] Improve the conversion of numeric command parameters

by Eric Kohl

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=8476ae6ed511b694ca85b… commit 8476ae6ed511b694ca85bcebdc70fff007cc1911 Author: Eric Kohl <eric.kohl(a)reactos.org> AuthorDate: Mon Mar 28 00:04:24 2022 +0200 Commit: Eric Kohl <eric.kohl(a)reactos.org> CommitDate: Mon Mar 28 00:04:24 2022 +0200 [DISKPART] Improve the conversion of numeric command parameters --- base/system/diskpart/diskpart.h | 4 ++++ base/system/diskpart/misc.c | 22 ++++++++++++++++++ base/system/diskpart/select.c | 50 +++++++++++++++++++++++++---------------- base/system/diskpart/uniqueid.c | 17 ++++++-------- 4 files changed, 64 insertions(+), 29 deletions(-) diff --git a/base/system/diskpart/diskpart.h b/base/system/diskpart/diskpart.h index 39aae2f8a94..877f0063351 100644 --- a/base/system/diskpart/diskpart.h +++ b/base/system/diskpart/diskpart.h @@ -286,6 +286,10 @@ BOOL list_main(INT argc, LPWSTR *argv); BOOL merge_main(INT argc, LPWSTR *argv); /* misc.c */ +BOOL +IsDecString( + _In_ PWSTR pszDecString); + BOOL IsHexString( _In_ PWSTR pszHexString); diff --git a/base/system/diskpart/misc.c b/base/system/diskpart/misc.c index 2487530d405..65ba3a0ddb0 100644 --- a/base/system/diskpart/misc.c +++ b/base/system/diskpart/misc.c @@ -10,6 +10,28 @@ /* FUNCTIONS ******************************************************************/ +BOOL +IsDecString( + _In_ PWSTR pszDecString) +{ + PWSTR ptr; + + if ((pszDecString == NULL) || (*pszDecString == UNICODE_NULL)) + return FALSE; + + ptr = pszDecString; + while (*ptr != UNICODE_NULL) + { + if (!iswdigit(*ptr)) + return FALSE; + + ptr++; + } + + return TRUE; +} + + BOOL IsHexString( _In_ PWSTR pszHexString) diff --git a/base/system/diskpart/select.c b/base/system/diskpart/select.c index 4a1804ebbfd..aa2432484ae 100644 --- a/base/system/diskpart/select.c +++ b/base/system/diskpart/select.c @@ -21,8 +21,7 @@ SelectDisk( { PLIST_ENTRY Entry; PDISKENTRY DiskEntry; - LONG lValue; - LPWSTR endptr = NULL; + ULONG ulValue; DPRINT("Select Disk()\n"); @@ -41,9 +40,14 @@ SelectDisk( return; } - lValue = wcstol(argv[2], &endptr, 10); - if (((lValue == 0) && (endptr == argv[2])) || - (lValue < 0)) + if (!IsDecString(argv[2])) + { + ConResPuts(StdErr, IDS_ERROR_INVALID_ARGS); + return; + } + + ulValue = wcstoul(argv[2], NULL, 10); + if ((ulValue == 0) && (errno == ERANGE)) { ConResPuts(StdErr, IDS_ERROR_INVALID_ARGS); return; @@ -56,7 +60,7 @@ SelectDisk( { DiskEntry = CONTAINING_RECORD(Entry, DISKENTRY, ListEntry); - if (DiskEntry->DiskNumber == (ULONG)lValue) + if (DiskEntry->DiskNumber == ulValue) { CurrentDisk = DiskEntry; CurrentPartition = NULL; @@ -79,8 +83,7 @@ SelectPartition( { PLIST_ENTRY Entry; PPARTENTRY PartEntry; - LONG lValue; - LPWSTR endptr = NULL; + ULONG ulValue; ULONG PartNumber = 1; DPRINT("Select Partition()\n"); @@ -106,9 +109,14 @@ SelectPartition( return; } - lValue = wcstol(argv[2], &endptr, 10); - if (((lValue == 0) && (endptr == argv[2])) || - (lValue < 0)) + if (!IsDecString(argv[2])) + { + ConResPuts(StdErr, IDS_ERROR_INVALID_ARGS); + return; + } + + ulValue = wcstoul(argv[2], NULL, 10); + if ((ulValue == 0) && (errno == ERANGE)) { ConResPuts(StdErr, IDS_ERROR_INVALID_ARGS); return; @@ -121,7 +129,7 @@ SelectPartition( if (PartEntry->PartitionType != 0) { - if (PartNumber == (ULONG)lValue) + if (PartNumber == ulValue) { CurrentPartition = PartEntry; ConResPrintf(StdOut, IDS_SELECT_PARTITION, PartNumber); @@ -141,7 +149,7 @@ SelectPartition( if (PartEntry->PartitionType != 0) { - if (PartNumber == (ULONG)lValue) + if (PartNumber == ulValue) { CurrentPartition = PartEntry; ConResPrintf(StdOut, IDS_SELECT_PARTITION, PartNumber); @@ -165,8 +173,7 @@ SelectVolume( { PLIST_ENTRY Entry; PVOLENTRY VolumeEntry; - LONG lValue; - LPWSTR endptr = NULL; + ULONG ulValue; DPRINT("SelectVolume()\n"); @@ -185,9 +192,14 @@ SelectVolume( return; } - lValue = wcstol(argv[2], &endptr, 10); - if (((lValue == 0) && (endptr == argv[2])) || - (lValue < 0)) + if (!IsDecString(argv[2])) + { + ConResPuts(StdErr, IDS_ERROR_INVALID_ARGS); + return; + } + + ulValue = wcstoul(argv[2], NULL, 10); + if ((ulValue == 0) && (errno == ERANGE)) { ConResPuts(StdErr, IDS_ERROR_INVALID_ARGS); return; @@ -200,7 +212,7 @@ SelectVolume( { VolumeEntry = CONTAINING_RECORD(Entry, VOLENTRY, ListEntry); - if (VolumeEntry->VolumeNumber == (ULONG)lValue) + if (VolumeEntry->VolumeNumber == ulValue) { CurrentVolume = VolumeEntry; ConResPrintf(StdOut, IDS_SELECT_VOLUME, CurrentVolume->VolumeNumber); diff --git a/base/system/diskpart/uniqueid.c b/base/system/diskpart/uniqueid.c index df7d3bf6696..28c206ec65d 100644 --- a/base/system/diskpart/uniqueid.c +++ b/base/system/diskpart/uniqueid.c @@ -19,9 +19,7 @@ UniqueIdDisk( _In_ INT argc, _In_ LPWSTR *argv) { - ULONG ulLength; - ULONG ulValue; - PWSTR startptr = NULL, endptr = NULL; + ULONG ulLength, ulValue; if (CurrentDisk == NULL) { @@ -39,31 +37,30 @@ UniqueIdDisk( if (argc != 3) { - ConResPuts(StdOut, IDS_ERROR_INVALID_ARGS); + ConResPuts(StdErr, IDS_ERROR_INVALID_ARGS); return; } ulLength = wcslen(argv[2]); if ((ulLength <= 3) || (ulLength > 11)) { - ConResPuts(StdOut, IDS_ERROR_INVALID_ARGS); + ConResPuts(StdErr, IDS_ERROR_INVALID_ARGS); return; } if (!HasPrefix(argv[2], L"ID=")) { - ConResPuts(StdOut, IDS_ERROR_INVALID_ARGS); + ConResPuts(StdErr, IDS_ERROR_INVALID_ARGS); return; } - startptr = &argv[2][3]; - if (!IsHexString(startptr)) + if (!IsHexString(&argv[2][3])) { - ConResPuts(StdOut, IDS_ERROR_INVALID_ARGS); + ConResPuts(StdErr, IDS_ERROR_INVALID_ARGS); return; } - ulValue = wcstoul(startptr, &endptr, 16); + ulValue = wcstoul(&argv[2][3], NULL, 16); if ((ulValue == 0) && (errno == ERANGE)) { ConResPuts(StdErr, IDS_ERROR_INVALID_ARGS);

2 years, 5 months

[reactos] 01/01: [DISKPART] Move helper functions to a separate file

by Eric Kohl

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=72087c1e3aac64ee94618… commit 72087c1e3aac64ee94618ad845b5e751759d8b9b Author: Eric Kohl <eric.kohl(a)reactos.org> AuthorDate: Sun Mar 27 20:09:34 2022 +0200 Commit: Eric Kohl <eric.kohl(a)reactos.org> CommitDate: Sun Mar 27 20:09:34 2022 +0200 [DISKPART] Move helper functions to a separate file --- base/system/diskpart/CMakeLists.txt | 1 + base/system/diskpart/diskpart.h | 19 +++++++++++--- base/system/diskpart/list.c | 9 ------- base/system/diskpart/misc.c | 50 +++++++++++++++++++++++++++++++++++++ base/system/diskpart/uniqueid.c | 34 ++----------------------- 5 files changed, 68 insertions(+), 45 deletions(-) diff --git a/base/system/diskpart/CMakeLists.txt b/base/system/diskpart/CMakeLists.txt index f9b5bdd5a3f..0c0c9977947 100644 --- a/base/system/diskpart/CMakeLists.txt +++ b/base/system/diskpart/CMakeLists.txt @@ -29,6 +29,7 @@ list(APPEND SOURCE interpreter.c list.c merge.c + misc.c offline.c online.c partlist.c diff --git a/base/system/diskpart/diskpart.h b/base/system/diskpart/diskpart.h index b961e1e7f37..39aae2f8a94 100644 --- a/base/system/diskpart/diskpart.h +++ b/base/system/diskpart/diskpart.h @@ -282,13 +282,24 @@ VOID InterpretMain(VOID); /* list.c */ BOOL list_main(INT argc, LPWSTR *argv); +/* merge.c */ +BOOL merge_main(INT argc, LPWSTR *argv); + +/* misc.c */ +BOOL +IsHexString( + _In_ PWSTR pszHexString); + +BOOL +HasPrefix( + _In_ PWSTR pszString, + _In_ PWSTR pszPrefix); + ULONGLONG RoundingDivide( - _In_ ULONGLONG Dividend, - _In_ ULONGLONG Divisor); + _In_ ULONGLONG Dividend, + _In_ ULONGLONG Divisor); -/* merge.c */ -BOOL merge_main(INT argc, LPWSTR *argv); /* offline.c */ BOOL offline_main(INT argc, LPWSTR *argv); diff --git a/base/system/diskpart/list.c b/base/system/diskpart/list.c index 714f5e3c257..a6a2ebfde89 100644 --- a/base/system/diskpart/list.c +++ b/base/system/diskpart/list.c @@ -13,15 +13,6 @@ /* FUNCTIONS ******************************************************************/ -ULONGLONG -RoundingDivide( - IN ULONGLONG Dividend, - IN ULONGLONG Divisor) -{ - return (Dividend + Divisor / 2) / Divisor; -} - - static VOID ListDisk(VOID) diff --git a/base/system/diskpart/misc.c b/base/system/diskpart/misc.c new file mode 100644 index 00000000000..2487530d405 --- /dev/null +++ b/base/system/diskpart/misc.c @@ -0,0 +1,50 @@ +/* + * PROJECT: ReactOS DiskPart + * LICENSE: GPL - See COPYING in the top level directory + * FILE: base/system/diskpart/misc.c + * PURPOSE: Manages all the partitions of the OS in an interactive way. + * PROGRAMMERS: Eric Kohl + */ + +#include "diskpart.h" + +/* FUNCTIONS ******************************************************************/ + +BOOL +IsHexString( + _In_ PWSTR pszHexString) +{ + PWSTR ptr; + + if ((pszHexString == NULL) || (*pszHexString == UNICODE_NULL)) + return FALSE; + + ptr = pszHexString; + while (*ptr != UNICODE_NULL) + { + if (!iswxdigit(*ptr)) + return FALSE; + + ptr++; + } + + return TRUE; +} + + +BOOL +HasPrefix( + _In_ PWSTR pszString, + _In_ PWSTR pszPrefix) +{ + return (_wcsnicmp(pszString, pszPrefix, wcslen(pszPrefix)) == 0); +} + + +ULONGLONG +RoundingDivide( + _In_ ULONGLONG Dividend, + _In_ ULONGLONG Divisor) +{ + return (Dividend + Divisor / 2) / Divisor; +} diff --git a/base/system/diskpart/uniqueid.c b/base/system/diskpart/uniqueid.c index af2c5e4fc64..df7d3bf6696 100644 --- a/base/system/diskpart/uniqueid.c +++ b/base/system/diskpart/uniqueid.c @@ -13,36 +13,6 @@ /* FUNCTIONS ******************************************************************/ -static -BOOL -isHexString( - _In_ PWSTR pszHexString) -{ - PWSTR ptr; - - ptr = pszHexString; - while (*ptr != UNICODE_NULL) - { - if (!iswxdigit(*ptr)) - return FALSE; - - ptr++; - } - - return TRUE; -} - - -static -BOOL -hasPrefix( - _In_ PWSTR pszString, - _In_ PWSTR pszPrefix) -{ - return (_wcsnicmp(pszString, pszPrefix, wcslen(pszPrefix)) == 0); -} - - static VOID UniqueIdDisk( @@ -80,14 +50,14 @@ UniqueIdDisk( return; } - if (!hasPrefix(argv[2], L"ID=")) + if (!HasPrefix(argv[2], L"ID=")) { ConResPuts(StdOut, IDS_ERROR_INVALID_ARGS); return; } startptr = &argv[2][3]; - if (isHexString(startptr) == FALSE) + if (!IsHexString(startptr)) { ConResPuts(StdOut, IDS_ERROR_INVALID_ARGS); return;

2 years, 5 months

[reactos] 03/03: [SDK:CMLIB] Const-ify the unicode strings that are only used as input and not modified.

by Hermès Bélusca-Maïto

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=d873865971163e045bd2a… commit d873865971163e045bd2a2924638dd44150a97a0 Author: Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org> AuthorDate: Sun Mar 27 00:53:03 2022 +0100 Commit: Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org> CommitDate: Sun Mar 27 19:38:54 2022 +0200 [SDK:CMLIB] Const-ify the unicode strings that are only used as input and not modified. --- sdk/lib/cmlib/cmindex.c | 4 ++-- sdk/lib/cmlib/cmlib.h | 8 ++++---- sdk/lib/cmlib/cmname.c | 6 +++--- sdk/lib/cmlib/cmvalue.c | 2 +- 4 files changed, 10 insertions(+), 10 deletions(-) diff --git a/sdk/lib/cmlib/cmindex.c b/sdk/lib/cmlib/cmindex.c index 599900124d5..0e6ccf04c2a 100644 --- a/sdk/lib/cmlib/cmindex.c +++ b/sdk/lib/cmlib/cmindex.c @@ -923,7 +923,7 @@ NTAPI CmpAddToLeaf(IN PHHIVE Hive, IN HCELL_INDEX LeafCell, IN HCELL_INDEX NewKey, - IN PUNICODE_STRING Name) + IN PCUNICODE_STRING Name) { PCM_KEY_INDEX Leaf; PCM_KEY_FAST_INDEX FastLeaf; @@ -1265,7 +1265,7 @@ HCELL_INDEX NTAPI CmpSelectLeaf(IN PHHIVE Hive, IN PCM_KEY_NODE KeyNode, - IN PUNICODE_STRING Name, + IN PCUNICODE_STRING Name, IN HSTORAGE_TYPE Type, IN PHCELL_INDEX *RootCell) { diff --git a/sdk/lib/cmlib/cmlib.h b/sdk/lib/cmlib/cmlib.h index 6b65b73dc17..e4ae010702e 100644 --- a/sdk/lib/cmlib/cmlib.h +++ b/sdk/lib/cmlib/cmlib.h @@ -567,7 +567,7 @@ USHORT NTAPI CmpNameSize( IN PHHIVE Hive, - IN PUNICODE_STRING Name + IN PCUNICODE_STRING Name ); USHORT @@ -582,7 +582,7 @@ NTAPI CmpCopyName( IN PHHIVE Hive, OUT PWCHAR Destination, - IN PUNICODE_STRING Source + IN PCUNICODE_STRING Source ); VOID @@ -599,7 +599,7 @@ NTAPI CmpFindNameInList( IN PHHIVE Hive, IN PCHILD_LIST ChildList, - IN PUNICODE_STRING Name, + IN PCUNICODE_STRING Name, OUT PULONG ChildIndex OPTIONAL, OUT PHCELL_INDEX CellIndex ); @@ -613,7 +613,7 @@ NTAPI CmpFindValueByName( IN PHHIVE Hive, IN PCM_KEY_NODE KeyNode, - IN PUNICODE_STRING Name + IN PCUNICODE_STRING Name ); PCELL_DATA diff --git a/sdk/lib/cmlib/cmname.c b/sdk/lib/cmlib/cmname.c index b12374023c8..265a86a9216 100644 --- a/sdk/lib/cmlib/cmname.c +++ b/sdk/lib/cmlib/cmname.c @@ -20,7 +20,7 @@ USHORT NTAPI CmpCopyName(IN PHHIVE Hive, OUT PWCHAR Destination, - IN PUNICODE_STRING Source) + IN PCUNICODE_STRING Source) { ULONG i; @@ -72,7 +72,7 @@ CmpCopyCompressedName(OUT PWCHAR Destination, USHORT NTAPI CmpNameSize(IN PHHIVE Hive, - IN PUNICODE_STRING Name) + IN PCUNICODE_STRING Name) { ULONG i; @@ -148,7 +148,7 @@ BOOLEAN NTAPI CmpFindNameInList(IN PHHIVE Hive, IN PCHILD_LIST ChildList, - IN PUNICODE_STRING Name, + IN PCUNICODE_STRING Name, OUT PULONG ChildIndex OPTIONAL, OUT PHCELL_INDEX CellIndex) { diff --git a/sdk/lib/cmlib/cmvalue.c b/sdk/lib/cmlib/cmvalue.c index 86344a77079..a9c46a9fcdf 100644 --- a/sdk/lib/cmlib/cmvalue.c +++ b/sdk/lib/cmlib/cmvalue.c @@ -98,7 +98,7 @@ HCELL_INDEX NTAPI CmpFindValueByName(IN PHHIVE Hive, IN PCM_KEY_NODE KeyNode, - IN PUNICODE_STRING Name) + IN PCUNICODE_STRING Name) { HCELL_INDEX CellIndex;

2 years, 5 months

[reactos] 02/03: [BOOTDATA] Properly capitalize 'Boot File System'.

by Hermès Bélusca-Maïto

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=a6da36ed1b6155a73f452… commit a6da36ed1b6155a73f452010ec0f7a7cc72557a3 Author: Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org> AuthorDate: Sat Mar 26 01:53:41 2022 +0100 Commit: Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org> CommitDate: Sun Mar 27 19:38:53 2022 +0200 [BOOTDATA] Properly capitalize 'Boot File System'. --- boot/bootdata/hivesys.inf | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/boot/bootdata/hivesys.inf b/boot/bootdata/hivesys.inf index d0b05adb09d..48c51e04636 100644 --- a/boot/bootdata/hivesys.inf +++ b/boot/bootdata/hivesys.inf @@ -129,7 +129,7 @@ HKLM,"SYSTEM\CurrentControlSet\Control\SafeBoot","AlternateShell",2,"cmd.exe" HKLM,"SYSTEM\CurrentControlSet\Control\SafeBoot\Minimal\AppMgmt","",0x00000000,"Service" HKLM,"SYSTEM\CurrentControlSet\Control\SafeBoot\Minimal\Base","",0x00000000,"Driver Group" HKLM,"SYSTEM\CurrentControlSet\Control\SafeBoot\Minimal\Boot Bus Extender","",0x00000000,"Driver Group" -HKLM,"SYSTEM\CurrentControlSet\Control\SafeBoot\Minimal\Boot file system","",0x00000000,"Driver Group" +HKLM,"SYSTEM\CurrentControlSet\Control\SafeBoot\Minimal\Boot File System","",0x00000000,"Driver Group" HKLM,"SYSTEM\CurrentControlSet\Control\SafeBoot\Minimal\CryptSvc","",0x00000000,"Service" HKLM,"SYSTEM\CurrentControlSet\Control\SafeBoot\Minimal\DcomLaunch","",0x00000000,"Service" HKLM,"SYSTEM\CurrentControlSet\Control\SafeBoot\Minimal\dmadmin","",0x00000000,"Service" @@ -173,7 +173,7 @@ HKLM,"SYSTEM\CurrentControlSet\Control\SafeBoot\Network\AFD","",0x00000000,"Serv HKLM,"SYSTEM\CurrentControlSet\Control\SafeBoot\Network\AppMgmt","",0x00000000,"Service" HKLM,"SYSTEM\CurrentControlSet\Control\SafeBoot\Network\Base","",0x00000000,"Driver Group" HKLM,"SYSTEM\CurrentControlSet\Control\SafeBoot\Network\Boot Bus Extender","",0x00000000,"Driver Group" -HKLM,"SYSTEM\CurrentControlSet\Control\SafeBoot\Network\Boot file system","",0x00000000,"Driver Group" +HKLM,"SYSTEM\CurrentControlSet\Control\SafeBoot\Network\Boot File System","",0x00000000,"Driver Group" HKLM,"SYSTEM\CurrentControlSet\Control\SafeBoot\Network\Browser","",0x00000000,"Service" HKLM,"SYSTEM\CurrentControlSet\Control\SafeBoot\Network\CryptSvc","",0x00000000,"Service" HKLM,"SYSTEM\CurrentControlSet\Control\SafeBoot\Network\DcomLaunch","",0x00000000,"Service" @@ -1655,7 +1655,7 @@ HKLM,"SYSTEM\CurrentControlSet\Services\EventLog\System\Service Control Manager" ; Filesystem recognizer driver HKLM,"SYSTEM\CurrentControlSet\Services\Fs_Rec","ErrorControl",0x00010001,0x00000000 -HKLM,"SYSTEM\CurrentControlSet\Services\Fs_Rec","Group",0x00000000,"Boot file system" +HKLM,"SYSTEM\CurrentControlSet\Services\Fs_Rec","Group",0x00000000,"Boot File System" HKLM,"SYSTEM\CurrentControlSet\Services\Fs_Rec","ImagePath",0x00020000,"system32\drivers\fs_rec.sys" HKLM,"SYSTEM\CurrentControlSet\Services\Fs_Rec","Start",0x00010001,0x00000001 HKLM,"SYSTEM\CurrentControlSet\Services\Fs_Rec","Type",0x00010001,0x00000008

2 years, 5 months

[reactos] 01/03: [NTOS:CONFIG] Add missing HvGetCell casts. Addendum to a4cad7be6.

by Hermès Bélusca-Maïto

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=ce641de1e08a8d6db03ff… commit ce641de1e08a8d6db03ff7fed7ebd09f91795ae7 Author: Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org> AuthorDate: Sun Mar 27 19:09:34 2022 +0200 Commit: Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org> CommitDate: Sun Mar 27 19:38:53 2022 +0200 [NTOS:CONFIG] Add missing HvGetCell casts. Addendum to a4cad7be6. --- ntoskrnl/config/cmboot.c | 44 ++++++++++++++++++++++---------------------- 1 file changed, 22 insertions(+), 22 deletions(-) diff --git a/ntoskrnl/config/cmboot.c b/ntoskrnl/config/cmboot.c index 2a2a74a534e..98dd2a053ef 100644 --- a/ntoskrnl/config/cmboot.c +++ b/ntoskrnl/config/cmboot.c @@ -146,19 +146,19 @@ CmpFindTagIndex(IN PHHIVE Hive, ASSERT(Hive->ReleaseCellRoutine == NULL); /* Get the tag */ - Value = HvGetCell(Hive, TagCell); + Value = (PCM_KEY_VALUE)HvGetCell(Hive, TagCell); ASSERT(Value); DriverTag = (PULONG)CmpValueToData(Hive, Value, &Length); ASSERT(DriverTag); /* Get the order array */ - Node = HvGetCell(Hive, GroupOrderCell); + Node = (PCM_KEY_NODE)HvGetCell(Hive, GroupOrderCell); ASSERT(Node); OrderCell = CmpFindValueByName(Hive, Node, GroupName); if (OrderCell == HCELL_NIL) return -2; /* And read it */ - TagValue = HvGetCell(Hive, OrderCell); + TagValue = (PCM_KEY_VALUE)HvGetCell(Hive, OrderCell); CmpGetValueData(Hive, TagValue, &Length, (PVOID*)&TagOrder, &BufferAllocated, &OrderCell); ASSERT(TagOrder); @@ -208,7 +208,7 @@ CmpAddDriverToList(IN PHHIVE Hive, DriverEntry->FilePath.Buffer = NULL; /* Get the driver cell */ - Node = HvGetCell(Hive, DriverCell); + Node = (PCM_KEY_NODE)HvGetCell(Hive, DriverCell); ASSERT(Node); /* Get the name from the cell */ @@ -258,7 +258,7 @@ CmpAddDriverToList(IN PHHIVE Hive, else { /* Path name exists, so grab it */ - Value = HvGetCell(Hive, ValueCell); + Value = (PCM_KEY_VALUE)HvGetCell(Hive, ValueCell); ASSERT(Value); /* Allocate and setup the path name */ @@ -297,7 +297,7 @@ CmpAddDriverToList(IN PHHIVE Hive, else { /* Otherwise, read whatever the data says */ - Value = HvGetCell(Hive, ValueCell); + Value = (PCM_KEY_VALUE)HvGetCell(Hive, ValueCell); ASSERT(Value); ErrorControl = (PULONG)CmpValueToData(Hive, Value, &Length); ASSERT(ErrorControl); @@ -315,7 +315,7 @@ CmpAddDriverToList(IN PHHIVE Hive, else { /* Found it, read the group value */ - Value = HvGetCell(Hive, ValueCell); + Value = (PCM_KEY_VALUE)HvGetCell(Hive, ValueCell); ASSERT(Value); /* Copy it into the node */ @@ -362,13 +362,13 @@ CmpIsLoadType(IN PHHIVE Hive, ASSERT(Hive->ReleaseCellRoutine == NULL); /* Open the start cell */ - Node = HvGetCell(Hive, Cell); + Node = (PCM_KEY_NODE)HvGetCell(Hive, Cell); ASSERT(Node); ValueCell = CmpFindValueByName(Hive, Node, &ValueString); if (ValueCell == HCELL_NIL) return FALSE; /* Read the start value */ - Value = HvGetCell(Hive, ValueCell); + Value = (PCM_KEY_VALUE)HvGetCell(Hive, ValueCell); ASSERT(Value); Data = (PLONG)CmpValueToData(Hive, Value, &Length); ASSERT(Data); @@ -397,7 +397,7 @@ CmpFindDrivers(IN PHHIVE Hive, ASSERT(Hive->ReleaseCellRoutine == NULL); /* Open the control set key */ - ControlNode = HvGetCell(Hive, ControlSet); + ControlNode = (PCM_KEY_NODE)HvGetCell(Hive, ControlSet); ASSERT(ControlNode); /* Get services cell */ @@ -406,7 +406,7 @@ CmpFindDrivers(IN PHHIVE Hive, if (ServicesCell == HCELL_NIL) return FALSE; /* Open services key */ - ServicesNode = HvGetCell(Hive, ServicesCell); + ServicesNode = (PCM_KEY_NODE)HvGetCell(Hive, ServicesCell); ASSERT(ServicesNode); /* Get control cell */ @@ -416,7 +416,7 @@ CmpFindDrivers(IN PHHIVE Hive, /* Get the group order cell and read it */ RtlInitUnicodeString(&Name, L"GroupOrderList"); - Node = HvGetCell(Hive, ControlCell); + Node = (PCM_KEY_NODE)HvGetCell(Hive, ControlCell); ASSERT(Node); GroupOrderCell = CmpFindSubKeyByName(Hive, Node, &Name); if (GroupOrderCell == HCELL_NIL) return FALSE; @@ -426,13 +426,13 @@ CmpFindDrivers(IN PHHIVE Hive, { /* Open the Safe Boot key */ RtlInitUnicodeString(&Name, L"SafeBoot"); - Node = HvGetCell(Hive, ControlCell); + Node = (PCM_KEY_NODE)HvGetCell(Hive, ControlCell); ASSERT(Node); SafeBootCell = CmpFindSubKeyByName(Hive, Node, &Name); if (SafeBootCell == HCELL_NIL) return FALSE; /* Open the correct start key (depending on the mode) */ - Node = HvGetCell(Hive, SafeBootCell); + Node = (PCM_KEY_NODE)HvGetCell(Hive, SafeBootCell); ASSERT(Node); switch(InitSafeBootMode) { @@ -571,28 +571,28 @@ CmpSortDriverList(IN PHHIVE Hive, ASSERT(Hive->ReleaseCellRoutine == NULL); /* Open the control key */ - Node = HvGetCell(Hive, ControlSet); + Node = (PCM_KEY_NODE)HvGetCell(Hive, ControlSet); ASSERT(Node); RtlInitUnicodeString(&Name, L"Control"); Controls = CmpFindSubKeyByName(Hive, Node, &Name); if (Controls == HCELL_NIL) return FALSE; /* Open the service group order */ - Node = HvGetCell(Hive, Controls); + Node = (PCM_KEY_NODE)HvGetCell(Hive, Controls); ASSERT(Node); RtlInitUnicodeString(&Name, L"ServiceGroupOrder"); GroupOrder = CmpFindSubKeyByName(Hive, Node, &Name); if (GroupOrder == HCELL_NIL) return FALSE; /* Open the list key */ - Node = HvGetCell(Hive, GroupOrder); + Node = (PCM_KEY_NODE)HvGetCell(Hive, GroupOrder); ASSERT(Node); RtlInitUnicodeString(&Name, L"list"); ListCell = CmpFindValueByName(Hive, Node, &Name); if (ListCell == HCELL_NIL) return FALSE; /* Now read the actual list */ - ListNode = HvGetCell(Hive, ListCell); + ListNode = (PCM_KEY_VALUE)HvGetCell(Hive, ListCell); ASSERT(ListNode); if (ListNode->Type != REG_MULTI_SZ) return FALSE; @@ -736,12 +736,12 @@ CmpIsSafe(IN PHHIVE Hive, /* Driver key node (mandatory) */ ASSERT(DriverCell != HCELL_NIL); - DriverNode = HvGetCell(Hive, DriverCell); + DriverNode = (PCM_KEY_NODE)HvGetCell(Hive, DriverCell); ASSERT(DriverNode); /* Safe boot key node (optional but return TRUE if not present) */ if(SafeBootCell == HCELL_NIL) return TRUE; - SafeBootNode = HvGetCell(Hive, SafeBootCell); + SafeBootNode = (PCM_KEY_NODE)HvGetCell(Hive, SafeBootCell); if(!SafeBootNode) return FALSE; /* Search by the name from the group */ @@ -749,7 +749,7 @@ CmpIsSafe(IN PHHIVE Hive, CellIndex = CmpFindValueByName(Hive, DriverNode, &Name); if(CellIndex != HCELL_NIL) { - KeyValue = HvGetCell(Hive, CellIndex); + KeyValue = (PCM_KEY_VALUE)HvGetCell(Hive, CellIndex); ASSERT(KeyValue); if (KeyValue->Type == REG_SZ || KeyValue->Type == REG_EXPAND_SZ) { @@ -795,7 +795,7 @@ CmpIsSafe(IN PHHIVE Hive, CellIndex = CmpFindValueByName(Hive, DriverNode, &Name); if(CellIndex != HCELL_NIL) { - KeyValue = HvGetCell(Hive, CellIndex); + KeyValue = (PCM_KEY_VALUE)HvGetCell(Hive, CellIndex); ASSERT(KeyValue); if (KeyValue->Type == REG_SZ || KeyValue->Type == REG_EXPAND_SZ) {

2 years, 5 months

[reactos] 02/02: [SDK:CMLIB] HvGetCell is a macro calling the hive's GetCellRoutine callback.

by Hermès Bélusca-Maïto

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=8ccd435eb0b3237c98d39… commit 8ccd435eb0b3237c98d39f4a55f9bff669ff29a9 Author: Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org> AuthorDate: Sun Mar 27 17:30:52 2022 +0200 Commit: Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org> CommitDate: Sun Mar 27 18:37:16 2022 +0200 [SDK:CMLIB] HvGetCell is a macro calling the hive's GetCellRoutine callback. In principle there should be different get-cell routines, depending on the type of the hive (given by the OperationType parameter of HvInitialize): for flat hives, memory-mapped hives, etc. For now in ReactOS we only support a restricted subset of these, therefore we are still happy with a single get-cell callback... This may change in the future. --- sdk/lib/cmlib/cmlib.h | 19 +++++++++++-------- sdk/lib/cmlib/hivecell.c | 17 ++++++++--------- sdk/lib/cmlib/hiveinit.c | 5 +++++ 3 files changed, 24 insertions(+), 17 deletions(-) diff --git a/sdk/lib/cmlib/cmlib.h b/sdk/lib/cmlib/cmlib.h index 1946ec5437b..6b65b73dc17 100644 --- a/sdk/lib/cmlib/cmlib.h +++ b/sdk/lib/cmlib/cmlib.h @@ -384,15 +384,13 @@ VOID CMAPI HvFree( PHHIVE RegistryHive); -PVOID CMAPI -HvGetCell( - PHHIVE RegistryHive, - HCELL_INDEX CellOffset); +#define HvGetCell(Hive, Cell) \ + (Hive)->GetCellRoutine(Hive, Cell) -#define HvReleaseCell(h, c) \ -do { \ - if ((h)->ReleaseCellRoutine) \ - (h)->ReleaseCellRoutine(h, c); \ +#define HvReleaseCell(Hive, Cell) \ +do { \ + if ((Hive)->ReleaseCellRoutine) \ + (Hive)->ReleaseCellRoutine(Hive, Cell); \ } while(0) LONG CMAPI @@ -468,6 +466,11 @@ HvReleaseFreeCellRefArray( * Private functions. */ +PCELL_DATA CMAPI +HvpGetCellData( + _In_ PHHIVE Hive, + _In_ HCELL_INDEX CellIndex); + PHBIN CMAPI HvpAddBin( PHHIVE RegistryHive, diff --git a/sdk/lib/cmlib/hivecell.c b/sdk/lib/cmlib/hivecell.c index a267130e494..9820ab8de22 100644 --- a/sdk/lib/cmlib/hivecell.c +++ b/sdk/lib/cmlib/hivecell.c @@ -29,13 +29,13 @@ HvpGetCellHeader( ASSERT(CellBlock < RegistryHive->Storage[CellType].Length); Block = (PVOID)RegistryHive->Storage[CellType].BlockList[CellBlock].BlockAddress; ASSERT(Block != NULL); - return (PVOID)((ULONG_PTR)Block + CellOffset); + return (PHCELL)((ULONG_PTR)Block + CellOffset); } else { ASSERT(HvGetCellType(CellIndex) == Stable); - return (PVOID)((ULONG_PTR)RegistryHive->BaseBlock + HBLOCK_SIZE + - CellIndex); + return (PHCELL)((ULONG_PTR)RegistryHive->BaseBlock + HBLOCK_SIZE + + CellIndex); } } @@ -63,13 +63,12 @@ HvIsCellAllocated(IN PHHIVE RegistryHive, return FALSE; } -PVOID CMAPI -HvGetCell( - PHHIVE RegistryHive, - HCELL_INDEX CellIndex) +PCELL_DATA CMAPI +HvpGetCellData( + _In_ PHHIVE Hive, + _In_ HCELL_INDEX CellIndex) { - ASSERT(CellIndex != HCELL_NIL); - return (PVOID)(HvpGetCellHeader(RegistryHive, CellIndex) + 1); + return (PCELL_DATA)(HvpGetCellHeader(Hive, CellIndex) + 1); } static __inline LONG CMAPI diff --git a/sdk/lib/cmlib/hiveinit.c b/sdk/lib/cmlib/hiveinit.c index fcbbe08961c..2b070fb4f7e 100644 --- a/sdk/lib/cmlib/hiveinit.c +++ b/sdk/lib/cmlib/hiveinit.c @@ -562,6 +562,11 @@ HvInitialize( #endif Hive->HiveFlags = HiveFlags & ~HIVE_NOLAZYFLUSH; + // TODO: The CellRoutines point to different callbacks + // depending on the OperationType. + Hive->GetCellRoutine = HvpGetCellData; + Hive->ReleaseCellRoutine = NULL; + switch (OperationType) { case HINIT_CREATE:

2 years, 5 months

[reactos] 01/02: [SDK:CMLIB][MKHIVE][BOOT:ENVIRON][NTOS:CONFIG] Add missing HvGetCell casts. Replace some ASSERT(FALSE).

by Hermès Bélusca-Maïto

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=a4cad7be6bc8251ae65ec… commit a4cad7be6bc8251ae65ec46be2b36d8083e11205 Author: Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org> AuthorDate: Sun Mar 27 17:41:16 2022 +0200 Commit: Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org> CommitDate: Sun Mar 27 18:37:16 2022 +0200 [SDK:CMLIB][MKHIVE][BOOT:ENVIRON][NTOS:CONFIG] Add missing HvGetCell casts. Replace some ASSERT(FALSE). --- boot/environ/lib/misc/bootreg.c | 2 +- ntoskrnl/config/cmapi.c | 12 ++++++------ ntoskrnl/config/cmkcbncb.c | 3 +-- ntoskrnl/config/cmparse.c | 8 ++++---- sdk/lib/cmlib/cminit.c | 8 ++++---- sdk/lib/cmlib/cmkeydel.c | 25 +++++++++++++------------ sdk/lib/cmlib/cmse.c | 10 +++++----- sdk/tools/mkhive/registry.c | 4 ++-- 8 files changed, 36 insertions(+), 36 deletions(-) diff --git a/boot/environ/lib/misc/bootreg.c b/boot/environ/lib/misc/bootreg.c index 957bb122f5f..0551e4c7884 100644 --- a/boot/environ/lib/misc/bootreg.c +++ b/boot/environ/lib/misc/bootreg.c @@ -826,7 +826,7 @@ BiEnumerateSubKeys ( } /* Get the cell data for it */ - Node = HvGetCell(Hive, CellIndex); + Node = (PCM_KEY_NODE)HvGetCell(Hive, CellIndex); if (!Node) { Status = STATUS_REGISTRY_CORRUPT; diff --git a/ntoskrnl/config/cmapi.c b/ntoskrnl/config/cmapi.c index 25daeb46c57..6555658435f 100644 --- a/ntoskrnl/config/cmapi.c +++ b/ntoskrnl/config/cmapi.c @@ -180,7 +180,7 @@ CmpSetValueKeyNew(IN PHHIVE Hive, /* Get the actual data for it */ CellData = HvGetCell(Hive, ValueCell); - if (!CellData) ASSERT(FALSE); + ASSERT(CellData); /* Now we can release it, make sure it's also dirty */ HvReleaseCell(Hive, ValueCell); @@ -355,7 +355,7 @@ CmpSetValueKeyExisting(IN PHHIVE Hive, /* Now get the actual data for our data cell */ CellData = HvGetCell(Hive, NewCell); - if (!CellData) ASSERT(FALSE); + ASSERT(CellData); /* Release it immediately */ HvReleaseCell(Hive, NewCell); @@ -1378,7 +1378,7 @@ CmpQueryKeyDataFromCache( #if DBG /* Get the cell node */ - Node = HvGetCell(KeyHive, KeyCell); + Node = (PCM_KEY_NODE)HvGetCell(KeyHive, KeyCell); if (Node != NULL) { ULONG SubKeyCount; @@ -1457,7 +1457,7 @@ CmpQueryKeyDataFromCache( DPRINT1("Kcb cache incoherency detected, kcb = %p\n", Kcb); /* Get the cell node */ - Node = HvGetCell(KeyHive, KeyCell); + Node = (PCM_KEY_NODE)HvGetCell(KeyHive, KeyCell); if (Node == NULL) { return STATUS_INSUFFICIENT_RESOURCES; @@ -2468,7 +2468,7 @@ CmpDeepCopyKeyInternal(IN PHHIVE SourceHive, DestKeyCell); /* Get the source cell node */ - SrcNode = HvGetCell(SourceHive, SrcKeyCell); + SrcNode = (PCM_KEY_NODE)HvGetCell(SourceHive, SrcKeyCell); ASSERT(SrcNode); /* Sanity check */ @@ -2487,7 +2487,7 @@ CmpDeepCopyKeyInternal(IN PHHIVE SourceHive, } /* Get the destination cell node */ - DestNode = HvGetCell(DestinationHive, NewKeyCell); + DestNode = (PCM_KEY_NODE)HvGetCell(DestinationHive, NewKeyCell); ASSERT(DestNode); /* Set the parent and copy the flags */ diff --git a/ntoskrnl/config/cmkcbncb.c b/ntoskrnl/config/cmkcbncb.c index cb4035f75cc..2241d530ae8 100644 --- a/ntoskrnl/config/cmkcbncb.c +++ b/ntoskrnl/config/cmkcbncb.c @@ -961,8 +961,7 @@ CmpConstructName(IN PCM_KEY_CONTROL_BLOCK Kcb) if the key is not deleted */ if (!DeletedKey && !MyKcb->Delete) { - KeyNode = HvGetCell(MyKcb->KeyHive, MyKcb->KeyCell); - + KeyNode = (PCM_KEY_NODE)HvGetCell(MyKcb->KeyHive, MyKcb->KeyCell); if (!KeyNode) { /* Failure */ diff --git a/ntoskrnl/config/cmparse.c b/ntoskrnl/config/cmparse.c index 2fb6a997f71..52a3219babb 100644 --- a/ntoskrnl/config/cmparse.c +++ b/ntoskrnl/config/cmparse.c @@ -845,7 +845,7 @@ CmpCreateLinkNode(IN PHHIVE Hive, HvMarkCellDirty(Context->ChildHive.KeyHive, ChildCell, FALSE); /* Get the key node */ - KeyNode = HvGetCell(Context->ChildHive.KeyHive, ChildCell); + KeyNode = (PCM_KEY_NODE)HvGetCell(Context->ChildHive.KeyHive, ChildCell); if (!KeyNode) { /* Fail */ @@ -862,7 +862,7 @@ CmpCreateLinkNode(IN PHHIVE Hive, KeyNode->Flags |= KEY_HIVE_ENTRY | KEY_NO_DELETE; /* Get the link node */ - KeyNode = HvGetCell(Hive, LinkCell); + KeyNode = (PCM_KEY_NODE)HvGetCell(Hive, LinkCell); if (!KeyNode) { /* Fail */ @@ -895,7 +895,7 @@ CmpCreateLinkNode(IN PHHIVE Hive, HvReleaseCell(Hive, LinkCell); /* Get the parent node */ - KeyNode = HvGetCell(Hive, Cell); + KeyNode = (PCM_KEY_NODE)HvGetCell(Hive, Cell); if (!KeyNode) { /* Fail */ @@ -1183,7 +1183,7 @@ CmpParseKey(IN PVOID ParseObject, /* Get the new node */ Cell = NextCell; Node = (PCM_KEY_NODE)HvGetCell(Hive, Cell); - if (!Node) ASSERT(FALSE); + ASSERT(Node); /* Check if this was the last key */ if (Last) diff --git a/sdk/lib/cmlib/cminit.c b/sdk/lib/cmlib/cminit.c index 699376e75d9..d7c7d208797 100644 --- a/sdk/lib/cmlib/cminit.c +++ b/sdk/lib/cmlib/cminit.c @@ -87,7 +87,7 @@ CmpPrepareIndexOfKeys( { for (i = 0; i < IndexCell->Count; i++) { - PCM_KEY_INDEX SubIndexCell = HvGetCell(RegistryHive, IndexCell->List[i]); + PCM_KEY_INDEX SubIndexCell = (PCM_KEY_INDEX)HvGetCell(RegistryHive, IndexCell->List[i]); if (SubIndexCell->Signature == CM_KEY_NODE_SIGNATURE) CmpPrepareKey(RegistryHive, (PCM_KEY_NODE)SubIndexCell); else @@ -100,7 +100,7 @@ CmpPrepareIndexOfKeys( PCM_KEY_FAST_INDEX HashCell = (PCM_KEY_FAST_INDEX)IndexCell; for (i = 0; i < HashCell->Count; i++) { - PCM_KEY_NODE SubKeyCell = HvGetCell(RegistryHive, HashCell->List[i].Cell); + PCM_KEY_NODE SubKeyCell = (PCM_KEY_NODE)HvGetCell(RegistryHive, HashCell->List[i].Cell); CmpPrepareKey(RegistryHive, SubKeyCell); } } @@ -126,7 +126,7 @@ CmpPrepareKey( /* Enumerate and add subkeys */ if (KeyCell->SubKeyCounts[Stable] > 0) { - IndexCell = HvGetCell(RegistryHive, KeyCell->SubKeyLists[Stable]); + IndexCell = (PCM_KEY_INDEX)HvGetCell(RegistryHive, KeyCell->SubKeyLists[Stable]); CmpPrepareIndexOfKeys(RegistryHive, IndexCell); } } @@ -137,6 +137,6 @@ CmPrepareHive( { PCM_KEY_NODE RootCell; - RootCell = HvGetCell(RegistryHive, RegistryHive->BaseBlock->RootCell); + RootCell = (PCM_KEY_NODE)HvGetCell(RegistryHive, RegistryHive->BaseBlock->RootCell); CmpPrepareKey(RegistryHive, RootCell); } diff --git a/sdk/lib/cmlib/cmkeydel.c b/sdk/lib/cmlib/cmkeydel.c index 9baeaa886a7..6a2f9d52214 100644 --- a/sdk/lib/cmlib/cmkeydel.c +++ b/sdk/lib/cmlib/cmkeydel.c @@ -26,7 +26,7 @@ CmpMarkKeyDirty(IN PHHIVE Hive, ULONG i; /* Get the cell data for our target */ - CellData = HvGetCell(Hive, Cell); + CellData = (PCM_KEY_NODE)HvGetCell(Hive, Cell); if (!CellData) return FALSE; /* Check if sanity checks requested */ @@ -63,8 +63,8 @@ CmpMarkKeyDirty(IN PHHIVE Hive, HvMarkCellDirty(Hive, CellData->Security, FALSE); /* Get the security data and release it */ - SecurityData = HvGetCell(Hive, CellData->Security); - if (!SecurityData) ASSERT(FALSE); + SecurityData = (PCM_KEY_SECURITY)HvGetCell(Hive, CellData->Security); + ASSERT(SecurityData); HvReleaseCell(Hive, CellData->Security); /* Mark the security links dirty too */ @@ -81,7 +81,7 @@ CmpMarkKeyDirty(IN PHHIVE Hive, /* Get the list data itself, and release it */ ListData = HvGetCell(Hive, CellData->ValueList.List); - if (!ListData) ASSERT(FALSE); + ASSERT(ListData); HvReleaseCell(Hive, CellData->ValueList.List); /* Loop all values */ @@ -127,8 +127,8 @@ CmpFreeKeyBody(IN PHHIVE Hive, PCM_KEY_NODE CellData; /* Get the key node */ - CellData = HvGetCell(Hive, Cell); - if (!CellData) ASSERT(FALSE); + CellData = (PCM_KEY_NODE)HvGetCell(Hive, Cell); + ASSERT(CellData); /* Check if we can delete the child cells */ if (!(CellData->Flags & KEY_HIVE_EXIT)) @@ -169,8 +169,8 @@ CmpFreeKeyByCell(IN PHHIVE Hive, CmpMarkKeyDirty(Hive, Cell, TRUE); /* Get the target node and release it */ - CellData = HvGetCell(Hive, Cell); - if (!CellData) ASSERT(FALSE); + CellData = (PCM_KEY_NODE)HvGetCell(Hive, Cell); + ASSERT(CellData); HvReleaseCell(Hive, Cell); /* Make sure we don't have subkeys */ @@ -184,8 +184,8 @@ CmpFreeKeyByCell(IN PHHIVE Hive, if (!Result) return STATUS_INSUFFICIENT_RESOURCES; /* Get the parent node and release it */ - ParentData = HvGetCell(Hive, CellData->Parent); - if (!ParentData) ASSERT(FALSE); + ParentData = (PCM_KEY_NODE)HvGetCell(Hive, CellData->Parent); + ASSERT(ParentData); HvReleaseCell(Hive, CellData->Parent); /* Check if the parent node has no more subkeys */ @@ -206,14 +206,15 @@ CmpFreeKeyByCell(IN PHHIVE Hive, { /* Get the value list and release it */ ListData = HvGetCell(Hive, CellData->ValueList.List); - if (!ListData) ASSERT(FALSE); + ASSERT(ListData); HvReleaseCell(Hive, CellData->ValueList.List); /* Loop every value */ for (i = 0; i < CellData->ValueList.Count; i++) { /* Free it */ - if (!CmpFreeValue(Hive, ListData->u.KeyList[i])) ASSERT(FALSE); + Result = CmpFreeValue(Hive, ListData->u.KeyList[i]); + ASSERT(Result); } /* Free the value list */ diff --git a/sdk/lib/cmlib/cmse.c b/sdk/lib/cmlib/cmse.c index 6b3a8c18b65..98a1e035936 100644 --- a/sdk/lib/cmlib/cmse.c +++ b/sdk/lib/cmlib/cmse.c @@ -25,17 +25,17 @@ CmpRemoveSecurityCellList(IN PHHIVE Hive, // ASSERT( (((PCMHIVE)Hive)->HiveSecurityLockOwner == KeGetCurrentThread()) || (CmpTestRegistryLockExclusive() == TRUE) ); - SecurityData = HvGetCell(Hive, SecurityCell); + SecurityData = (PCM_KEY_SECURITY)HvGetCell(Hive, SecurityCell); if (!SecurityData) return; - FlinkCell = HvGetCell(Hive, SecurityData->Flink); + FlinkCell = (PCM_KEY_SECURITY)HvGetCell(Hive, SecurityData->Flink); if (!FlinkCell) { HvReleaseCell(Hive, SecurityCell); return; } - BlinkCell = HvGetCell(Hive, SecurityData->Blink); + BlinkCell = (PCM_KEY_SECURITY)HvGetCell(Hive, SecurityData->Blink); if (!BlinkCell) { HvReleaseCell(Hive, SecurityData->Flink); @@ -72,7 +72,7 @@ CmpFreeSecurityDescriptor(IN PHHIVE Hive, // ASSERT( (((PCMHIVE)Hive)->HiveSecurityLockOwner == KeGetCurrentThread()) || (CmpTestRegistryLockExclusive() == TRUE) ); - CellData = HvGetCell(Hive, Cell); + CellData = (PCM_KEY_NODE)HvGetCell(Hive, Cell); if (!CellData) return; ASSERT(CellData->Signature == CM_KEY_NODE_SIGNATURE); @@ -89,7 +89,7 @@ CmpFreeSecurityDescriptor(IN PHHIVE Hive, return; } - SecurityData = HvGetCell(Hive, CellData->Security); + SecurityData = (PCM_KEY_SECURITY)HvGetCell(Hive, CellData->Security); if (!SecurityData) { HvReleaseCell(Hive, Cell); diff --git a/sdk/tools/mkhive/registry.c b/sdk/tools/mkhive/registry.c index 9628f67573a..99823e33839 100644 --- a/sdk/tools/mkhive/registry.c +++ b/sdk/tools/mkhive/registry.c @@ -733,7 +733,7 @@ RegSetValueExW( else { /* The value already exists, use it. Get the value cell. */ - ValueCell = HvGetCell(&Key->RegistryHive->Hive, CellIndex); + ValueCell = (PCM_KEY_VALUE)HvGetCell(&Key->RegistryHive->Hive, CellIndex); ASSERT(ValueCell != NULL); Status = STATUS_SUCCESS; } @@ -887,7 +887,7 @@ RegQueryValueExW( return ERROR_FILE_NOT_FOUND; // STATUS_OBJECT_NAME_NOT_FOUND; /* Get the value cell */ - ValueCell = HvGetCell(Hive, CellIndex); + ValueCell = (PCM_KEY_VALUE)HvGetCell(Hive, CellIndex); ASSERT(ValueCell != NULL); RepGetValueData(Hive, ValueCell, lpType, lpData, lpcbData);

2 years, 5 months

[reactos] 01/01: [DISKPART] Store full scsi address in the diskentry

by Eric Kohl

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=641fdb342ef0d4717ef26… commit 641fdb342ef0d4717ef26837b499ede893189114 Author: Eric Kohl <eric.kohl(a)reactos.org> AuthorDate: Sun Mar 27 18:05:04 2022 +0200 Commit: Eric Kohl <eric.kohl(a)reactos.org> CommitDate: Sun Mar 27 18:05:04 2022 +0200 [DISKPART] Store full scsi address in the diskentry --- base/system/diskpart/diskpart.h | 5 +++-- base/system/diskpart/partlist.c | 5 +++-- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/base/system/diskpart/diskpart.h b/base/system/diskpart/diskpart.h index c7a453ed241..b961e1e7f37 100644 --- a/base/system/diskpart/diskpart.h +++ b/base/system/diskpart/diskpart.h @@ -152,8 +152,9 @@ typedef struct _DISKENTRY ULONG DiskNumber; USHORT Port; - USHORT Bus; - USHORT Id; + USHORT PathId; + USHORT TargetId; + USHORT Lun; /* Has the partition list been modified? */ BOOLEAN Dirty; diff --git a/base/system/diskpart/partlist.c b/base/system/diskpart/partlist.c index 2113373ce83..6d91e385571 100644 --- a/base/system/diskpart/partlist.c +++ b/base/system/diskpart/partlist.c @@ -936,8 +936,9 @@ AddDiskToList( DiskEntry->DiskNumber = DiskNumber; DiskEntry->Port = ScsiAddress.PortNumber; - DiskEntry->Bus = ScsiAddress.PathId; - DiskEntry->Id = ScsiAddress.TargetId; + DiskEntry->PathId = ScsiAddress.PathId; + DiskEntry->TargetId = ScsiAddress.TargetId; + DiskEntry->Lun = ScsiAddress.Lun; GetDriverName(DiskEntry);

2 years, 5 months

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs March 2022