https://git.reactos.org/?p=reactos.git;a=commitdiff;h=04eca8e2b21e6da084eea…
commit 04eca8e2b21e6da084eea163372a2cbbadb753de
Author: Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org>
AuthorDate: Sat Apr 9 17:51:08 2022 +0200
Commit: Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org>
CommitDate: Sat Apr 9 23:31:44 2022 +0200
[WIN32K] Remove incorrect packing specification around _TL, _WIN32THREAD and _THREADINFO structures.
CORE-18140
This was introduced historically in commit 583de66b3 (r7460) to
workaround some compiler problems (or replace already existing
GCC-specific __attribute__((packed)) annotations); however these
structures are in-memory-only, do not describe any on-disk data
format and don't describe hardware-specific data. So they should
have the "natural" alignment of the target platform.
They also have to match the documented layouts at:
https://reactos.org/wiki/Techwiki:Win32k/THREADINFOhttps://www.geoffchappell.com/studies/windows/km/win32k/structs/threadinfo/…
at least for the compatible parts that ReactOS shares.
---
win32ss/user/ntuser/win32.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/win32ss/user/ntuser/win32.h b/win32ss/user/ntuser/win32.h
index 585a7191589..dd30cf23fc8 100644
--- a/win32ss/user/ntuser/win32.h
+++ b/win32ss/user/ntuser/win32.h
@@ -53,7 +53,6 @@ extern HANDLE hModuleWin; // This Win32k Instance.
extern struct _CLS *SystemClassList;
extern BOOL RegisteredSysClasses;
-#include <pshpack1.h>
// FIXME: Move to ntuser.h
typedef struct _TL
{
@@ -164,8 +163,6 @@ typedef struct _THREADINFO
#endif // __cplusplus
} THREADINFO;
-#include <poppack.h>
-
#define IntReferenceThreadInfo(pti) \
InterlockedIncrement(&(pti)->RefCount)
https://git.reactos.org/?p=reactos.git;a=commitdiff;h=e5d17a0219f2a198e2923…
commit e5d17a0219f2a198e2923d0070bb43133d747191
Author: Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org>
AuthorDate: Sat Apr 9 20:18:03 2022 +0200
Commit: Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org>
CommitDate: Sat Apr 9 20:18:03 2022 +0200
[HALX86:ACPI] Use the correct PCH file for compilation.
This also removes the following warnings, that were present because,
as the ACPICA acpi.h header was used as PCH (instead of none, or the
hal's own main header), it was "included" before any other header
-- and in particular, before hal.h -- and as a result, colliding defines
were still defined even if the #undef tricks were used for them.
rosbuilds\sdk\include\reactos\mc\bugcodes.h(1417): warning C4005: 'ACPI_BIOS_ERROR': macro redefinition
reactos\drivers\bus\acpi\acpica\include\acoutput.h(243): note: see previous definition of 'ACPI_BIOS_ERROR'
reactos\hal\halx86\include\hal.h(41): warning C4109: unexpected identifier '_read'
reactos\hal\halx86\include\hal.h(42): warning C4109: unexpected identifier '_read'
---
hal/halx86/acpi.cmake | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/hal/halx86/acpi.cmake b/hal/halx86/acpi.cmake
index e35cab24e4a..600fac13ca3 100644
--- a/hal/halx86/acpi.cmake
+++ b/hal/halx86/acpi.cmake
@@ -14,7 +14,5 @@ if(ARCH STREQUAL "amd64")
endif()
add_library(lib_hal_acpi OBJECT ${HAL_ACPI_SOURCE})
-add_pch(lib_hal_acpi ${REACTOS_SOURCE_DIR}/drivers/bus/acpi/acpica/include/acpi.h ${HAL_ACPI_SOURCE})
+add_pch(lib_hal_acpi include/hal.h ${HAL_ACPI_SOURCE})
add_dependencies(lib_hal_acpi bugcodes xdk)
-#add_pch(lib_hal_acpi include/hal.h)
-
https://git.reactos.org/?p=reactos.git;a=commitdiff;h=cfe387a9b09751241060a…
commit cfe387a9b09751241060a6c0f24c94bc46df98b5
Author: Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org>
AuthorDate: Sat Apr 9 02:51:20 2022 +0200
Commit: Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org>
CommitDate: Sat Apr 9 03:15:57 2022 +0200
[BOOTDATA] Add two missing separating commas in the ServiceGroupOrder List multi-string.
Typos introduced in commit 4d1ea554c.
These had the effect of enumerating "NetworkProviderRemoteValidation"
and "Extended BasePCI Configuration" as groups, which were of course
invalid/non-existent.
The actual groups are: "NetworkProvider", "RemoteValidation",
"Extended Base", and "PCI Configuration".
Fixing this may correct the loading order of drivers that belong to
these groups (if we do have such drivers).
---
boot/bootdata/hivesys.inf | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/boot/bootdata/hivesys.inf b/boot/bootdata/hivesys.inf
index 48c51e04636..2486a3f551c 100644
--- a/boot/bootdata/hivesys.inf
+++ b/boot/bootdata/hivesys.inf
@@ -1466,11 +1466,11 @@ HKLM,"SYSTEM\CurrentControlSet\Control\ServiceGroupOrder","List",0x00010000, \
"SpoolerGroup", \
"AudioGroup", \
"SmartCardGroup", \
- "NetworkProvider" \
+ "NetworkProvider", \
"RemoteValidation", \
"NetDDEGroup", \
"Parallel arbitrator", \
- "Extended Base" \
+ "Extended Base", \
"PCI Configuration", \
"MS Transactions"