https://git.reactos.org/?p=reactos.git;a=commitdiff;h=5471363801a2faf160579…
commit 5471363801a2faf160579615e663e18a4e5c206d
Author: Stanislav Motylkov <x86corez(a)gmail.com>
AuthorDate: Thu May 26 02:48:39 2022 +0300
Commit: Stanislav Motylkov <x86corez(a)gmail.com>
CommitDate: Fri May 27 18:54:20 2022 +0300
[XBOXVMP] Fix video driver settings
- Store settings in non hardware-profile registry key.
- This makes Xbox video driver working again.
Addendum to f03750de. CORE-16216
---
win32ss/drivers/miniport/xboxvmp/xboxvmp_reg.inf | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/win32ss/drivers/miniport/xboxvmp/xboxvmp_reg.inf b/win32ss/drivers/miniport/xboxvmp/xboxvmp_reg.inf
index e7c2a3c5fdf..43d659323e8 100644
--- a/win32ss/drivers/miniport/xboxvmp/xboxvmp_reg.inf
+++ b/win32ss/drivers/miniport/xboxvmp/xboxvmp_reg.inf
@@ -7,7 +7,7 @@ HKLM,"SYSTEM\CurrentControlSet\Services\XboxVmp","Start",0x00010001,0x00000004
HKLM,"SYSTEM\CurrentControlSet\Services\XboxVmp","Type",0x00010001,0x00000001
HKLM,"SYSTEM\CurrentControlSet\Enum\PCI\VEN_10DE&DEV_02A0&SUBSYS_00000000&REV_A1\0000","Service",0x00000000,"XboxVmp"
-HKLM,"SYSTEM\CurrentControlSet\Hardware Profiles\Current\System\CurrentControlSet\Services\XboxVmp\Device0","InstalledDisplayDrivers",0x00010000,"framebuf"
+HKLM,"SYSTEM\CurrentControlSet\Services\XboxVmp\Device0","InstalledDisplayDrivers",0x00010000,"framebuf"
; This is not true but it allows to use 3rd party drivers while having the XboxVmp driver installed
-HKLM,"SYSTEM\CurrentControlSet\Hardware Profiles\Current\System\CurrentControlSet\Services\XboxVmp\Device0","VgaCompatible",0x00010001,1
+HKLM,"SYSTEM\CurrentControlSet\Services\XboxVmp\Device0","VgaCompatible",0x00010001,1
https://git.reactos.org/?p=reactos.git;a=commitdiff;h=a5a6101ca03514c292dc1…
commit a5a6101ca03514c292dc1d2c0cc8d9145c223627
Author: Victor Perevertkin <victor.perevertkin(a)reactos.org>
AuthorDate: Fri May 27 01:48:52 2022 +0300
Commit: Victor Perevertkin <victor.perevertkin(a)reactos.org>
CommitDate: Fri May 27 01:48:52 2022 +0300
[CMAKE] Fix buildbot builders
---
CMakeLists.txt | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/CMakeLists.txt b/CMakeLists.txt
index 2b05726a694..63353f0c58b 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -76,7 +76,8 @@ add_definitions(
# There doesn't seem to be a standard for __FILE__ being relative or absolute, so detect it at runtime.
file(RELATIVE_PATH _PATH_PREFIX ${REACTOS_BINARY_DIR} ${REACTOS_SOURCE_DIR})
-if (NOT MSVC AND (CMAKE_C_COMPILER_ID STREQUAL "GNU" OR CMAKE_C_COMPILER_ID STREQUAL "Clang"))
+if (NOT MSVC AND ((CMAKE_C_COMPILER_ID STREQUAL "GNU") AND (CMAKE_C_COMPILER_VERSION VERSION_GREATER_EQUAL "8.0.0")
+ OR (CMAKE_C_COMPILER_ID STREQUAL "Clang") AND (CMAKE_C_COMPILER_VERSION VERSION_GREATER_EQUAL "10.0.0")))
# Thankfully, GCC has this
add_compile_options(-ffile-prefix-map=${REACTOS_SOURCE_DIR}=)
add_compile_options(-ffile-prefix-map=${_PATH_PREFIX}=)
https://git.reactos.org/?p=reactos.git;a=commitdiff;h=6f4be52a1c710ac062d35…
commit 6f4be52a1c710ac062d35a8c9083c0dcec69827e
Author: Dmitry Borisov <di.sean(a)protonmail.com>
AuthorDate: Thu May 26 19:40:17 2022 +0600
Commit: GitHub <noreply(a)github.com>
CommitDate: Thu May 26 16:40:17 2022 +0300
[HALX86] Print the correct size of the BAR in HalpDebugPciDumpBus()
Reference: https://wiki.osdev.org/PCI#Address_and_size_of_the_BAR
To determine the amount of address space needed by a PCI device,
you must save the original value of the BAR, write a value
of all 1's to the register, then read it back.
Note: 64-bit BARs are not supported yet.
---
hal/halx86/include/halp.h | 2 ++
hal/halx86/legacy/bussupp.c | 32 ++++++++++++++++++++++++++------
2 files changed, 28 insertions(+), 6 deletions(-)
diff --git a/hal/halx86/include/halp.h b/hal/halx86/include/halp.h
index 62d0254773e..5446482dfc8 100644
--- a/hal/halx86/include/halp.h
+++ b/hal/halx86/include/halp.h
@@ -516,6 +516,8 @@ CODE_SEG("INIT")
VOID
NTAPI
HalpDebugPciDumpBus(
+ IN PBUS_HANDLER BusHandler,
+ IN PCI_SLOT_NUMBER PciSlot,
IN ULONG i,
IN ULONG j,
IN ULONG k,
diff --git a/hal/halx86/legacy/bussupp.c b/hal/halx86/legacy/bussupp.c
index 97b535285d3..f967ece635c 100644
--- a/hal/halx86/legacy/bussupp.c
+++ b/hal/halx86/legacy/bussupp.c
@@ -787,7 +787,9 @@ ShowSize(ULONG x)
CODE_SEG("INIT")
VOID
NTAPI
-HalpDebugPciDumpBus(IN ULONG i,
+HalpDebugPciDumpBus(IN PBUS_HANDLER BusHandler,
+ IN PCI_SLOT_NUMBER PciSlot,
+ IN ULONG i,
IN ULONG j,
IN ULONG k,
IN PPCI_COMMON_CONFIG PciData)
@@ -963,12 +965,30 @@ HalpDebugPciDumpBus(IN ULONG i,
Mem = 0;
if (Mem)
{
+ ULONG PciBar = 0xFFFFFFFF;
+
+ HalpWritePCIConfig(BusHandler,
+ PciSlot,
+ &PciBar,
+ FIELD_OFFSET(PCI_COMMON_HEADER, u.type0.BaseAddresses[b]),
+ sizeof(ULONG));
+ HalpReadPCIConfig(BusHandler,
+ PciSlot,
+ &PciBar,
+ FIELD_OFFSET(PCI_COMMON_HEADER, u.type0.BaseAddresses[b]),
+ sizeof(ULONG));
+ HalpWritePCIConfig(BusHandler,
+ PciSlot,
+ &Mem,
+ FIELD_OFFSET(PCI_COMMON_HEADER, u.type0.BaseAddresses[b]),
+ sizeof(ULONG));
+
/* Decode the address type */
- if (Mem & PCI_ADDRESS_IO_SPACE)
+ if (PciBar & PCI_ADDRESS_IO_SPACE)
{
/* Guess the size */
Size = 1 << 2;
- while (!(Mem & Size) && (Size)) Size <<= 1;
+ while (!(PciBar & Size) && (Size)) Size <<= 1;
/* Print it out */
DbgPrint("\tI/O ports at %04lx", Mem & PCI_ADDRESS_IO_ADDRESS_MASK);
@@ -977,8 +997,8 @@ HalpDebugPciDumpBus(IN ULONG i,
else
{
/* Guess the size */
- Size = 1 << 8;
- while (!(Mem & Size) && (Size)) Size <<= 1;
+ Size = 1 << 4;
+ while (!(PciBar & Size) && (Size)) Size <<= 1;
/* Print it out */
DbgPrint("\tMemory at %08lx (%d-bit, %sprefetchable)",
@@ -1102,7 +1122,7 @@ HalpInitializePciBus(VOID)
if (PciData->VendorID == PCI_INVALID_VENDORID) continue;
/* Print out the entry */
- HalpDebugPciDumpBus(i, j, k, PciData);
+ HalpDebugPciDumpBus(BusHandler, PciSlot, i, j, k, PciData);
/* Check if this is a Cardbus bridge */
if (PCI_CONFIGURATION_TYPE(PciData) == PCI_CARDBUS_BRIDGE_TYPE)