Ros-diffs January 2023

ros-diffs@reactos.org

18 participants
79 discussions

[reactos] 11/13: [NTDLL_APITEST] Fix tests for StackOverflow

by Timo Kreuzer

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=e6c192b55622dcd6a4bcf… commit e6c192b55622dcd6a4bcf68ae98449c504b064c2 Author: Timo Kreuzer <timo.kreuzer(a)reactos.org> AuthorDate: Mon Jan 30 22:02:02 2023 +0200 Commit: Timo Kreuzer <timo.kreuzer(a)reactos.org> CommitDate: Tue Jan 31 18:39:21 2023 +0100 [NTDLL_APITEST] Fix tests for StackOverflow --- modules/rostests/apitests/ntdll/StackOverflow.c | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/modules/rostests/apitests/ntdll/StackOverflow.c b/modules/rostests/apitests/ntdll/StackOverflow.c index 1c3007079ee..975dc07a34f 100644 --- a/modules/rostests/apitests/ntdll/StackOverflow.c +++ b/modules/rostests/apitests/ntdll/StackOverflow.c @@ -79,7 +79,11 @@ START_TEST(StackOverflow) /* Check TEB attributes */ ok_ptr(NtCurrentTeb()->DeallocationStack, StackAllocationBase); ok_ptr(NtCurrentTeb()->NtTib.StackBase, (PVOID)((ULONG_PTR)MemoryBasicInfo.BaseAddress + MemoryBasicInfo.RegionSize)); +#ifdef _WIN64 + ok_ptr(NtCurrentTeb()->NtTib.StackLimit, (PVOID)((ULONG_PTR)MemoryBasicInfo.BaseAddress - 2 * PAGE_SIZE)); +#else ok_ptr(NtCurrentTeb()->NtTib.StackLimit, (PVOID)((ULONG_PTR)MemoryBasicInfo.BaseAddress - PAGE_SIZE)); +#endif trace("Guaranteed stack size is %lu.\n", NtCurrentTeb()->GuaranteedStackBytes); /* Get its size */ @@ -111,7 +115,11 @@ START_TEST(StackOverflow) ok_ptr(MemoryBasicInfo.BaseAddress, NtCurrentTeb()->NtTib.StackLimit); ok_ptr(MemoryBasicInfo.AllocationBase, StackAllocationBase); ok_long(MemoryBasicInfo.AllocationProtect, PAGE_READWRITE); +#ifdef _WIN64 + ok_long(MemoryBasicInfo.RegionSize, 3 * PAGE_SIZE); +#else ok_long(MemoryBasicInfo.RegionSize, 2 * PAGE_SIZE); +#endif ok_long(MemoryBasicInfo.State, MEM_COMMIT); ok_long(MemoryBasicInfo.Protect, PAGE_READWRITE); ok_long(MemoryBasicInfo.Type, MEM_PRIVATE); @@ -146,7 +154,11 @@ START_TEST(StackOverflow) /* Windows lets 2 pages between the reserved memory and the smallest possible stack address */ ok((ULONG_PTR)LastStackAllocation > (ULONG_PTR)StackAllocationBase, "\n"); - ok_long(PAGE_ROUND_DOWN(LastStackAllocation), (ULONG_PTR)StackAllocationBase + 2 * PAGE_SIZE); +#ifdef _WIN64 + ok_long(PAGE_ROUND_DOWN(LastStackAllocation), (ULONG_PTR)StackAllocationBase + 4 * PAGE_SIZE); +#else + ok_long(PAGE_ROUND_DOWN(LastStackAllocation), (ULONG_PTR)StackAllocationBase + 3 * PAGE_SIZE); +#endif /* And in fact, this is the true condition of the stack overflow */ ok_ptr(NtCurrentTeb()->NtTib.StackLimit, (PVOID)((ULONG_PTR)StackAllocationBase + PAGE_SIZE));

1 year, 7 months

[reactos] 10/13: [COMPILER_APITEST] Comment out some tests, when PSEH is used

by Timo Kreuzer

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=dda076a8b38a571618bcb… commit dda076a8b38a571618bcbeb510a768b4c12c50eb Author: Timo Kreuzer <timo.kreuzer(a)reactos.org> AuthorDate: Mon Jan 30 21:35:13 2023 +0200 Commit: Timo Kreuzer <timo.kreuzer(a)reactos.org> CommitDate: Tue Jan 31 18:39:21 2023 +0100 [COMPILER_APITEST] Comment out some tests, when PSEH is used --- modules/rostests/apitests/compiler/ms_seh.c | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/modules/rostests/apitests/compiler/ms_seh.c b/modules/rostests/apitests/compiler/ms_seh.c index b209e92ecab..6656bb7f585 100644 --- a/modules/rostests/apitests/compiler/ms_seh.c +++ b/modules/rostests/apitests/compiler/ms_seh.c @@ -89,11 +89,15 @@ START_TEST(ms_seh) run_test(seh0006); run_test(seh0007); run_test(seh0008); +#ifdef _USE_NATIVE_SEH run_test(seh0009); +#endif run_test(seh0010); run_test(seh0011); run_test(seh0012); +#ifdef _USE_NATIVE_SEH run_test(seh0013); +#endif run_test(seh0014); run_test(seh0015); run_test(seh0016); @@ -102,21 +106,29 @@ START_TEST(ms_seh) run_test(seh0019); run_test(seh0020); run_test(seh0021); +#ifdef _USE_NATIVE_SEH run_test(seh0022); +#endif run_test(seh0023); run_test(seh0024); run_test(seh0025); +#ifdef _USE_NATIVE_SEH run_test(seh0026); +#endif run_test(seh0027); run_test(seh0028); +#ifdef _USE_NATIVE_SEH run_test(seh0029); +#endif run_test(seh0030); run_test(seh0031); run_test(seh0032); run_test(seh0033); +#ifdef _USE_NATIVE_SEH run_test(seh0034); run_test(seh0035); run_test(seh0036); +#endif run_test(seh0037); run_test(seh0038); run_test(seh0039); @@ -135,7 +147,7 @@ START_TEST(ms_seh) run_test(seh0052); run_test(seh0053); run_test(seh0054); -#if !defined(_PSEH3_H_) +#ifdef _USE_NATIVE_SEH run_test(seh0055); #endif run_test(seh0056);

1 year, 7 months

[reactos] 09/13: [CRT_APITEST] Fix test for strlen

by Timo Kreuzer

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=a6faa1b82dd6fa68174cb… commit a6faa1b82dd6fa68174cb341084855eae2fd4df3 Author: Timo Kreuzer <timo.kreuzer(a)reactos.org> AuthorDate: Mon Jan 30 20:38:40 2023 +0200 Commit: Timo Kreuzer <timo.kreuzer(a)reactos.org> CommitDate: Tue Jan 31 18:39:21 2023 +0100 [CRT_APITEST] Fix test for strlen The direction flag in eflags is preserved on x64, but not on x86. --- modules/rostests/apitests/crt/strlen.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/modules/rostests/apitests/crt/strlen.c b/modules/rostests/apitests/crt/strlen.c index 7f0c9d7e6fe..c8103f5d891 100644 --- a/modules/rostests/apitests/crt/strlen.c +++ b/modules/rostests/apitests/crt/strlen.c @@ -48,7 +48,12 @@ Test_strlen(PFN_STRLEN pstrlen) eflags = __readeflags(); __writeeflags(eflags | EFLAGS_DF); len = pstrlen(teststr + 4); - ok((__readeflags() & EFLAGS_DF) != 0, "Direction flag in ELFAGS was changed."); + +#ifdef _M_AMD64 + ok((__readeflags() & EFLAGS_DF) != 0, "Direction flag in ELFAGS was changed.\n"); +#else + ok((__readeflags() & EFLAGS_DF) == 0, "Direction flag in ELFAGS was not changed.\n"); +#endif __writeeflags(eflags); /* Only test this for the exported versions, intrinsics might do it

1 year, 7 months

[reactos] 08/13: [COMPILER_APITEST] Fix pseh test that failed when compiled with GCC

by Timo Kreuzer

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=8233aa5667a736778ba5e… commit 8233aa5667a736778ba5e4a137a5d3179dbb5568 Author: Timo Kreuzer <timo.kreuzer(a)reactos.org> AuthorDate: Mon Jan 30 20:25:31 2023 +0200 Commit: Timo Kreuzer <timo.kreuzer(a)reactos.org> CommitDate: Tue Jan 31 18:39:21 2023 +0100 [COMPILER_APITEST] Fix pseh test that failed when compiled with GCC --- modules/rostests/apitests/compiler/pseh.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/modules/rostests/apitests/compiler/pseh.c b/modules/rostests/apitests/compiler/pseh.c index 1b3577fd90d..1e36c1c1bce 100644 --- a/modules/rostests/apitests/compiler/pseh.c +++ b/modules/rostests/apitests/compiler/pseh.c @@ -2425,7 +2425,12 @@ DEFINE_TEST(test_unvolatile) } _SEH2_END; + /* This works with a proper SEH implementation, but not with our hacked PSEH */ +#ifdef _USE_NATIVE_SEH return (val == 4); +#else + return (val == 4 || val == 3); +#endif } DEFINE_TEST(test_unvolatile_2)

1 year, 7 months

[reactos] 07/13: [WIN32KNT_APITEST] Fox tests for NtGdiCreateDIBSection

by Timo Kreuzer

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=6cad84a769ddc42ef4dc1… commit 6cad84a769ddc42ef4dc1807e5ffb161a87be0cd Author: Timo Kreuzer <timo.kreuzer(a)reactos.org> AuthorDate: Mon Jan 30 20:04:55 2023 +0200 Commit: Timo Kreuzer <timo.kreuzer(a)reactos.org> CommitDate: Tue Jan 31 18:39:21 2023 +0100 [WIN32KNT_APITEST] Fox tests for NtGdiCreateDIBSection --- .../apitests/win32nt/ntgdi/NtGdiCreateDIBSection.c | 24 +++++++++++----------- 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/modules/rostests/apitests/win32nt/ntgdi/NtGdiCreateDIBSection.c b/modules/rostests/apitests/win32nt/ntgdi/NtGdiCreateDIBSection.c index b6f90e18000..07fcad20a45 100644 --- a/modules/rostests/apitests/win32nt/ntgdi/NtGdiCreateDIBSection.c +++ b/modules/rostests/apitests/win32nt/ntgdi/NtGdiCreateDIBSection.c @@ -93,21 +93,21 @@ START_TEST(NtGdiCreateDIBSection) /* Test a 0 HDC */ - SetLastError(0); + SetLastError(0xdeadbeef); pvBits = 0; hbmp = NtGdiCreateDIBSection(0, NULL, 0, pbmi, 0, cjHeader, 0, 0, &pvBits); TEST(pvBits != NULL); TEST(hbmp != 0); - TEST(GetLastError() == ERROR_NOT_ENOUGH_MEMORY); + ok_hex(GetLastError(), 0xdeadbeef); if (hbmp) DeleteObject(hbmp); /* Test a wrong HDC */ - SetLastError(0); + SetLastError(0xdeadbeef); pvBits = 0; hbmp = NtGdiCreateDIBSection((HDC)(LONG_PTR)0xdeadbeef, NULL, 0, pbmi, 0, cjHeader, 0, 0, &pvBits); TEST(pvBits != 0); TEST(hbmp != 0); - TEST(GetLastError() == 8); + ok_hex(GetLastError(), 0xdeadbeef); if (hbmp) DeleteObject(hbmp); /* Test pbmi = NULL */ @@ -339,12 +339,12 @@ printf("dib with bitfileds: %p\n", hbmp); /* increased header size */ pbih->biSize = sizeof(BITMAPINFOHEADER) + 4; cjHeader = pbih->biSize + cEntries * 4 + 8; - SetLastError(0); + SetLastError(0xdeadbeef); pvBits = 0; hbmp = NtGdiCreateDIBSection(hDC, NULL, 0, pbmi, 0, cjHeader, 0, 0, &pvBits); TEST(pvBits != NULL); TEST(hbmp != 0); - TEST(GetLastError() == 8); + ok_hex(GetLastError(), 0xdeadbeef); if (hbmp) DeleteObject(hbmp); /* increased header size */ @@ -397,12 +397,12 @@ printf("dib with bitfileds: %p\n", hbmp); cjHeader = bmi.bmiHeader.biSize + cEntries * 4 + 8; /* Test something simple */ - SetLastError(0); + SetLastError(0xdeadbeef); pvBits = 0; hbmp = NtGdiCreateDIBSection(hDC, NULL, 0, pbmi, 0, cjHeader, 0, 0, &pvBits); TEST(pvBits != NULL); TEST(hbmp != 0); - TEST(GetLastError() == 8); + ok_hex(GetLastError(), 0xdeadbeef); if (hbmp) DeleteObject(hbmp); @@ -437,23 +437,23 @@ printf("dib with bitfileds: %p\n", hbmp); cjHeader = pbV5h->bV5Size + cEntries * 4 + 8; /* Test something simple */ - SetLastError(0); + SetLastError(0xdeadbeef); pvBits = 0; hbmp = NtGdiCreateDIBSection(hDC, NULL, 0, pbmi, 0, cjHeader, 0, 0, &pvBits); TEST(pvBits != NULL); TEST(hbmp != 0); - TEST(GetLastError() == 8); + ok_hex(GetLastError(), 0xdeadbeef); if (hbmp) DeleteObject(hbmp); /* increased header size */ pbV5h->bV5Size = sizeof(BITMAPV5HEADER) + 64; cjHeader = pbV5h->bV5Size + cEntries * 4 + 8; - SetLastError(0); + SetLastError(0xdeadbeef); pvBits = 0; hbmp = NtGdiCreateDIBSection(hDC, NULL, 0, pbmi, 0, cjHeader, 0, 0, &pvBits); TEST(pvBits != NULL); TEST(hbmp != 0); - TEST(GetLastError() == 8); + ok_hex(GetLastError(), 0xdeadbeef); if (hbmp) DeleteObject(hbmp); /* Test section */

1 year, 7 months

[reactos] 06/13: [WIN32KNT_APITEST] Fix test for NtUserEnumDisplaySettings

by Timo Kreuzer

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=180207c516c72e11896ea… commit 180207c516c72e11896eae0d4cd405b758adae69 Author: Timo Kreuzer <timo.kreuzer(a)reactos.org> AuthorDate: Mon Jan 30 19:44:48 2023 +0200 Commit: Timo Kreuzer <timo.kreuzer(a)reactos.org> CommitDate: Tue Jan 31 18:39:21 2023 +0100 [WIN32KNT_APITEST] Fix test for NtUserEnumDisplaySettings --- .../apitests/win32nt/ntuser/NtUserEnumDisplaySettings.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/modules/rostests/apitests/win32nt/ntuser/NtUserEnumDisplaySettings.c b/modules/rostests/apitests/win32nt/ntuser/NtUserEnumDisplaySettings.c index 0e8e0a4b7dc..5a954489145 100644 --- a/modules/rostests/apitests/win32nt/ntuser/NtUserEnumDisplaySettings.c +++ b/modules/rostests/apitests/win32nt/ntuser/NtUserEnumDisplaySettings.c @@ -76,19 +76,21 @@ START_TEST(NtUserEnumDisplaySettings) Status = NtUserEnumDisplaySettings(NULL, 8, (DEVMODEW*)&data, 0); TEST(Status == STATUS_SUCCESS); - Status = NtUserEnumDisplaySettings(NULL, 247, (DEVMODEW*)&data, 0); - TEST(Status == STATUS_SUCCESS); - Status = NtUserEnumDisplaySettings(NULL, 248, (DEVMODEW*)&data, 0); + /* iModeNum out of range */ + Status = NtUserEnumDisplaySettings(NULL, 5000, (DEVMODEW*)&data, 0); TEST(Status == STATUS_INVALID_PARAMETER_2); + /* Secret values? */ Status = NtUserEnumDisplaySettings(NULL, -1, (DEVMODEW*)&data, 0); TEST(Status == STATUS_SUCCESS); Status = NtUserEnumDisplaySettings(NULL, -2, (DEVMODEW*)&data, 0); TEST(Status == STATUS_SUCCESS); + + /* What's going on here? */ Status = NtUserEnumDisplaySettings(NULL, -3, (DEVMODEW*)&data, 0); - TEST(Status == STATUS_SUCCESS); + ok_ntstatus(Status, STATUS_INVALID_PARAMETER_3); Status = NtUserEnumDisplaySettings(NULL, -4, (DEVMODEW*)&data, 0); - TEST(Status == STATUS_INVALID_PARAMETER_2); + ok_ntstatus(Status, STATUS_INVALID_PARAMETER_2); Status = NtUserEnumDisplaySettings(&usDeviceName, ENUM_CURRENT_SETTINGS, (DEVMODEW*)&data, 0); TEST(Status == STATUS_INVALID_PARAMETER_1);

1 year, 7 months

[reactos] 05/13: [WIN32KNT_APITEST] Comment out broken test for NtUserSystemParametersInfo

by Timo Kreuzer

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=82b3cd36d047e22904e67… commit 82b3cd36d047e22904e67baba636ab2372ff53ce Author: Timo Kreuzer <timo.kreuzer(a)reactos.org> AuthorDate: Mon Jan 30 19:33:03 2023 +0200 Commit: Timo Kreuzer <timo.kreuzer(a)reactos.org> CommitDate: Tue Jan 31 18:39:21 2023 +0100 [WIN32KNT_APITEST] Comment out broken test for NtUserSystemParametersInfo --- modules/rostests/apitests/win32nt/ntuser/NtUserSystemParametersInfo.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/modules/rostests/apitests/win32nt/ntuser/NtUserSystemParametersInfo.c b/modules/rostests/apitests/win32nt/ntuser/NtUserSystemParametersInfo.c index 518ed8e0e07..491a67d0c92 100644 --- a/modules/rostests/apitests/win32nt/ntuser/NtUserSystemParametersInfo.c +++ b/modules/rostests/apitests/win32nt/ntuser/NtUserSystemParametersInfo.c @@ -599,10 +599,12 @@ Test_SPI_SETDESKWALLPAPER(void) TEST(wcscmp(szNew, szOld) == 0); /* Set new Wallpaper */ +#if 0 // This is broken RtlInitUnicodeString(&ustrNew, L"test.bmp"); TEST(NtUserSystemParametersInfo(SPI_SETDESKWALLPAPER, 0, &ustrNew, 0) == 1); TEST(NtUserSystemParametersInfo(SPI_GETDESKWALLPAPER, MAX_PATH, szNew, 0) == 1); TEST(wcscmp(szNew, L"test.bmp") == 0); +#endif /* Get Wallpaper, too small buffer */ szNew[0] = 0; szNew[1] = 0; szNew[2] = 0;

1 year, 7 months

[reactos] 04/13: [WIN32KNT_APITEST] Fix tests for NtGdiPolyPolyDraw

by Timo Kreuzer

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=e5da567d876d31ecbab3a… commit e5da567d876d31ecbab3a9061b731d32af092430 Author: Timo Kreuzer <timo.kreuzer(a)reactos.org> AuthorDate: Mon Jan 30 19:28:16 2023 +0200 Commit: Timo Kreuzer <timo.kreuzer(a)reactos.org> CommitDate: Tue Jan 31 18:39:21 2023 +0100 [WIN32KNT_APITEST] Fix tests for NtGdiPolyPolyDraw --- modules/rostests/apitests/win32nt/ntgdi/NtGdiPolyPolyDraw.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/modules/rostests/apitests/win32nt/ntgdi/NtGdiPolyPolyDraw.c b/modules/rostests/apitests/win32nt/ntgdi/NtGdiPolyPolyDraw.c index daf0840abbf..82b99fd0cff 100644 --- a/modules/rostests/apitests/win32nt/ntgdi/NtGdiPolyPolyDraw.c +++ b/modules/rostests/apitests/win32nt/ntgdi/NtGdiPolyPolyDraw.c @@ -82,20 +82,20 @@ Test_Params(void) TEST(ret == 0); TEST(GetLastError() == ERROR_INVALID_HANDLE); - SetLastError(0); + SetLastError(0xdeadbeef); ret = NtGdiPolyPolyDraw(hDC, Points, Count1, 2, 3); TEST(ret == 0); - TEST(GetLastError() == ERROR_INVALID_HANDLE); + ok_long(GetLastError(), 0xdeadbeef); - SetLastError(0); + SetLastError(0xdeadbeef); ret = NtGdiPolyPolyDraw(hDC, Points, Count1, 2, 4); TEST(ret == 0); - TEST(GetLastError() == ERROR_INVALID_HANDLE); + ok_long(GetLastError(), 0xdeadbeef); - SetLastError(0); + SetLastError(0xdeadbeef); ret = NtGdiPolyPolyDraw(hDC, Points, Count1, 2, 5); TEST(ret == 0); - TEST(GetLastError() == ERROR_INVALID_HANDLE); + ok_long(GetLastError(), 0xdeadbeef); SetLastError(0); ret = NtGdiPolyPolyDraw(hDC, Points, Count1, 2, 6);

1 year, 7 months

[reactos] 03/13: [WIN32KNT_APITEST] Comment out broken test for NtGdiGetFontResourceInfoInternalW

by Timo Kreuzer

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=be7a7f8c22ff8dc7c3036… commit be7a7f8c22ff8dc7c303647002deb4e69d232bc5 Author: Timo Kreuzer <timo.kreuzer(a)reactos.org> AuthorDate: Mon Jan 30 19:22:23 2023 +0200 Commit: Timo Kreuzer <timo.kreuzer(a)reactos.org> CommitDate: Tue Jan 31 18:39:21 2023 +0100 [WIN32KNT_APITEST] Comment out broken test for NtGdiGetFontResourceInfoInternalW --- modules/rostests/apitests/win32nt/CMakeLists.txt | 2 +- modules/rostests/apitests/win32nt/testlist.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/modules/rostests/apitests/win32nt/CMakeLists.txt b/modules/rostests/apitests/win32nt/CMakeLists.txt index a861830bbc0..9968d8a0c9d 100644 --- a/modules/rostests/apitests/win32nt/CMakeLists.txt +++ b/modules/rostests/apitests/win32nt/CMakeLists.txt @@ -24,7 +24,7 @@ list(APPEND SOURCE #ntgdi/NtGdiFlushUserBatch.c ntgdi/NtGdiGetBitmapBits.c ntgdi/NtGdiGetDIBits.c - ntgdi/NtGdiGetFontResourceInfoInternalW.c + #ntgdi/NtGdiGetFontResourceInfoInternalW.c ntgdi/NtGdiGetRandomRgn.c ntgdi/NtGdiGetStockObject.c ntgdi/NtGdiIntersectClipRect.c diff --git a/modules/rostests/apitests/win32nt/testlist.c b/modules/rostests/apitests/win32nt/testlist.c index c63cc42c101..839d87480fc 100644 --- a/modules/rostests/apitests/win32nt/testlist.c +++ b/modules/rostests/apitests/win32nt/testlist.c @@ -92,7 +92,7 @@ const struct test winetest_testlist[] = //{ "NtGdiFlushUserBatch", func_NtGdiFlushUserBatch }, { "NtGdiGetBitmapBits", func_NtGdiGetBitmapBits }, { "NtGdiGetDIBitsInternal", func_NtGdiGetDIBitsInternal }, - { "NtGdiGetFontResourceInfoInternalW", func_NtGdiGetFontResourceInfoInternalW }, + //{ "NtGdiGetFontResourceInfoInternalW", func_NtGdiGetFontResourceInfoInternalW }, { "NtGdiGetRandomRgn", func_NtGdiGetRandomRgn }, { "NtGdiGetStockObject", func_NtGdiGetStockObject }, { "NtGdiIntersectClipRect", func_NtGdiIntersectClipRect },

1 year, 7 months

[reactos] 02/13: [WIN32KNT_APITEST] Fix a test for NtGdiExtTextOutW

by Timo Kreuzer

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=329e065dbb280a2959d13… commit 329e065dbb280a2959d13328cfe7b8894eebfdf3 Author: Timo Kreuzer <timo.kreuzer(a)reactos.org> AuthorDate: Mon Jan 30 19:17:54 2023 +0200 Commit: Timo Kreuzer <timo.kreuzer(a)reactos.org> CommitDate: Tue Jan 31 18:39:21 2023 +0100 [WIN32KNT_APITEST] Fix a test for NtGdiExtTextOutW --- modules/rostests/apitests/win32nt/ntgdi/NtGdiExtTextOutW.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/rostests/apitests/win32nt/ntgdi/NtGdiExtTextOutW.c b/modules/rostests/apitests/win32nt/ntgdi/NtGdiExtTextOutW.c index 044a0cde567..3a75f9f0b9f 100644 --- a/modules/rostests/apitests/win32nt/ntgdi/NtGdiExtTextOutW.c +++ b/modules/rostests/apitests/win32nt/ntgdi/NtGdiExtTextOutW.c @@ -54,5 +54,5 @@ START_TEST(NtGdiExtTextOutW) /* Test alignment requirement for lpDx */ ret = NtGdiExtTextOutW(hDC, 0, 0, 0, 0, lpstr, len, (INT*)((ULONG_PTR)Dx + 1), 0); - ok_int(ret, 1); + ok_int(ret, 0); }

1 year, 7 months

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs January 2023