Ros-diffs October 2024

ros-diffs@reactos.org

20 participants
117 discussions

[reactos] 05/08: [NTOS:PNP] IoReportTargetDeviceChange: Correct the check for system PnP notifications

by Adam Słaboń

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=77af26531558a8f4e00a7… commit 77af26531558a8f4e00a73cea1c0cb744b6c89d5 Author: Adam Słaboń <asaillen(a)protonmail.com> AuthorDate: Sun Mar 3 00:10:30 2024 +0100 Commit: Hermès BÉLUSCA - MAÏTO <hermes.belusca-maito(a)reactos.org> CommitDate: Mon Oct 7 11:16:03 2024 +0200 [NTOS:PNP] IoReportTargetDeviceChange: Correct the check for system PnP notifications Now IoReportTargetDeviceChange will process the custom notifications (rather than processing only those that it shouldn't). --- ntoskrnl/io/pnpmgr/pnpreport.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/ntoskrnl/io/pnpmgr/pnpreport.c b/ntoskrnl/io/pnpmgr/pnpreport.c index 735760f8c4f..ea23aa13304 100644 --- a/ntoskrnl/io/pnpmgr/pnpreport.c +++ b/ntoskrnl/io/pnpmgr/pnpreport.c @@ -464,9 +464,9 @@ IoReportTargetDeviceChange(IN PDEVICE_OBJECT PhysicalDeviceObject, ASSERT(notifyStruct->FileObject == NULL); /* Do not handle system PnP events */ - if ((RtlCompareMemory(&(notifyStruct->Event), &(GUID_TARGET_DEVICE_QUERY_REMOVE), sizeof(GUID)) != sizeof(GUID)) || - (RtlCompareMemory(&(notifyStruct->Event), &(GUID_TARGET_DEVICE_REMOVE_CANCELLED), sizeof(GUID)) != sizeof(GUID)) || - (RtlCompareMemory(&(notifyStruct->Event), &(GUID_TARGET_DEVICE_REMOVE_COMPLETE), sizeof(GUID)) != sizeof(GUID))) + if (IsEqualGUID(&(notifyStruct->Event), &GUID_TARGET_DEVICE_QUERY_REMOVE) || + IsEqualGUID(&(notifyStruct->Event), &GUID_TARGET_DEVICE_REMOVE_CANCELLED) || + IsEqualGUID(&(notifyStruct->Event), &GUID_TARGET_DEVICE_REMOVE_COMPLETE)) { return STATUS_INVALID_DEVICE_REQUEST; } @@ -515,9 +515,9 @@ IoReportTargetDeviceChangeAsynchronous(IN PDEVICE_OBJECT PhysicalDeviceObject, ASSERT(notifyStruct->FileObject == NULL); /* Do not handle system PnP events */ - if ((RtlCompareMemory(&(notifyStruct->Event), &(GUID_TARGET_DEVICE_QUERY_REMOVE), sizeof(GUID)) != sizeof(GUID)) || - (RtlCompareMemory(&(notifyStruct->Event), &(GUID_TARGET_DEVICE_REMOVE_CANCELLED), sizeof(GUID)) != sizeof(GUID)) || - (RtlCompareMemory(&(notifyStruct->Event), &(GUID_TARGET_DEVICE_REMOVE_COMPLETE), sizeof(GUID)) != sizeof(GUID))) + if (IsEqualGUID(&(notifyStruct->Event), &GUID_TARGET_DEVICE_QUERY_REMOVE) || + IsEqualGUID(&(notifyStruct->Event), &GUID_TARGET_DEVICE_REMOVE_CANCELLED) || + IsEqualGUID(&(notifyStruct->Event), &GUID_TARGET_DEVICE_REMOVE_COMPLETE)) { return STATUS_INVALID_DEVICE_REQUEST; }

2 months, 2 weeks

[reactos] 04/08: [KERNEL32] GetVolumeNameForRoot: Use towupper for uppercasing the drive letter

by Adam Słaboń

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=56f6734fa5eb03f9355a6… commit 56f6734fa5eb03f9355a62261240997659bd5c63 Author: Adam Słaboń <asaillen(a)protonmail.com> AuthorDate: Sun Mar 3 00:04:43 2024 +0100 Commit: Hermès BÉLUSCA - MAÏTO <hermes.belusca-maito(a)reactos.org> CommitDate: Mon Oct 7 11:16:03 2024 +0200 [KERNEL32] GetVolumeNameForRoot: Use towupper for uppercasing the drive letter Drive letter is a wide character, using the non-Unicode aware toupper could corrupt it. --- dll/win32/kernel32/client/file/mntpoint.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dll/win32/kernel32/client/file/mntpoint.c b/dll/win32/kernel32/client/file/mntpoint.c index 362ed15be82..8fab74c9a8d 100644 --- a/dll/win32/kernel32/client/file/mntpoint.c +++ b/dll/win32/kernel32/client/file/mntpoint.c @@ -61,7 +61,7 @@ GetVolumeNameForRoot(IN LPCWSTR lpszRootPath, { if (NtPathName.Buffer[(NtPathName.Length / sizeof(WCHAR)) - 1] == L':') { - NtPathName.Buffer[(NtPathName.Length / sizeof(WCHAR)) - 2] = _toupper(NtPathName.Buffer[(NtPathName.Length / sizeof(WCHAR)) - 2]); + NtPathName.Buffer[(NtPathName.Length / sizeof(WCHAR)) - 2] = towupper(NtPathName.Buffer[(NtPathName.Length / sizeof(WCHAR)) - 2]); } }

2 months, 2 weeks

[reactos] 03/08: [FORMAT] Handle unformatted volumes

by Adam Słaboń

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=358fecdcf00d8f91cfeb1… commit 358fecdcf00d8f91cfeb1735b79f0aaef9d0c118 Author: Adam Słaboń <asaillen(a)protonmail.com> AuthorDate: Sun Mar 3 10:53:24 2024 +0100 Commit: Hermès BÉLUSCA - MAÏTO <hermes.belusca-maito(a)reactos.org> CommitDate: Mon Oct 7 11:16:03 2024 +0200 [FORMAT] Handle unformatted volumes --- base/system/format/format.c | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/base/system/format/format.c b/base/system/format/format.c index c8805af5e69..29b22f9a27d 100644 --- a/base/system/format/format.c +++ b/base/system/format/format.c @@ -364,7 +364,7 @@ int wmain(int argc, WCHAR *argv[]) FMIFS_MEDIA_FLAG media = FMIFS_HARDDISK; DWORD driveType; WCHAR fileSystem[1024]; - WCHAR volumeName[1024]; + WCHAR volumeName[1024] = {0}; WCHAR input[1024]; DWORD serialNumber; DWORD flags, maxComponent; @@ -475,9 +475,16 @@ int wmain(int argc, WCHAR *argv[]) &serialNumber, &maxComponent, &flags, fileSystem, ARRAYSIZE(fileSystem))) { - K32LoadStringW(GetModuleHandle(NULL), STRING_NO_VOLUME, szMsg, ARRAYSIZE(szMsg)); - PrintWin32Error(szMsg, GetLastError()); - return -1; + if (GetLastError() == ERROR_UNRECOGNIZED_VOLUME) + { + wcscpy(fileSystem, L"RAW"); + } + else + { + K32LoadStringW(GetModuleHandle(NULL), STRING_NO_VOLUME, szMsg, ARRAYSIZE(szMsg)); + PrintWin32Error(szMsg, GetLastError()); + return -1; + } } if (QueryDeviceInformation(RootDirectory,

2 months, 2 weeks

[reactos] 02/08: [FORMAT] Use QueryDeviceInformation for retrieving the volume size before formatting it

by Adam Słaboń

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=c5a9f22d4eab1b36a240e… commit c5a9f22d4eab1b36a240ef306ec927784219d111 Author: Adam Słaboń <asaillen(a)protonmail.com> AuthorDate: Sat Mar 2 23:56:51 2024 +0100 Commit: Hermès BÉLUSCA - MAÏTO <hermes.belusca-maito(a)reactos.org> CommitDate: Mon Oct 7 11:16:03 2024 +0200 [FORMAT] Use QueryDeviceInformation for retrieving the volume size before formatting it QueryDeviceInformation returns more reliable volume length and works with unformatted volumes. It will return volume length only on ROS and Vista+ however, so also keep the GetFreeDiskSpaceExW as a fallback for XP/2003. --- base/system/format/format.c | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/base/system/format/format.c b/base/system/format/format.c index 0d7e642c598..c8805af5e69 100644 --- a/base/system/format/format.c +++ b/base/system/format/format.c @@ -360,6 +360,7 @@ static VOID Usage(LPWSTR ProgramName) int wmain(int argc, WCHAR *argv[]) { int badArg; + DEVICE_INFORMATION DeviceInformation = {0}; FMIFS_MEDIA_FLAG media = FMIFS_HARDDISK; DWORD driveType; WCHAR fileSystem[1024]; @@ -479,7 +480,19 @@ int wmain(int argc, WCHAR *argv[]) return -1; } - if (!GetDiskFreeSpaceExW(RootDirectory, + if (QueryDeviceInformation(RootDirectory, + &DeviceInformation, + sizeof(DeviceInformation))) + { + totalNumberOfBytes.QuadPart = DeviceInformation.SectorSize * + DeviceInformation.SectorCount.QuadPart; + } + + /* QueryDeviceInformation returns more accurate volume length and works with + * unformatted volumes, however it will NOT return volume length on XP/2003. + * Fallback to GetFreeDiskSpaceExW if we did not get any volume length. */ + if (totalNumberOfBytes.QuadPart == 0 && + !GetDiskFreeSpaceExW(RootDirectory, &freeBytesAvailableToCaller, &totalNumberOfBytes, &totalNumberOfFreeBytes))

2 months, 2 weeks

[reactos] 01/08: [SDK][FMIFS] Partially implement QueryDeviceInformation

by Adam Słaboń

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=4838d7bd56f3fa241d8ab… commit 4838d7bd56f3fa241d8ab9a0daa20f81c7045ca1 Author: Adam Słaboń <asaillen(a)protonmail.com> AuthorDate: Sat Mar 2 23:48:33 2024 +0100 Commit: Hermès BÉLUSCA - MAÏTO <hermes.belusca-maito(a)reactos.org> CommitDate: Mon Oct 7 11:16:03 2024 +0200 [SDK][FMIFS] Partially implement QueryDeviceInformation On Windows, QueryDeviceInformation leverages the ifsutil.dll's API. This is a standalone implementation that mimics Vista behaviour. --- dll/win32/fmifs/fmifs.spec | 2 +- dll/win32/fmifs/query.c | 158 +++++++++++++++++++++++++++++++++ sdk/include/reactos/libs/fmifs/fmifs.h | 23 ++++- 3 files changed, 178 insertions(+), 5 deletions(-) diff --git a/dll/win32/fmifs/fmifs.spec b/dll/win32/fmifs/fmifs.spec index 6969e36d8c4..2e038e7b209 100644 --- a/dll/win32/fmifs/fmifs.spec +++ b/dll/win32/fmifs/fmifs.spec @@ -8,7 +8,7 @@ @ stdcall FormatEx(wstr ptr wstr wstr long long ptr) @ stub FormatEx2 @ stdcall QueryAvailableFileSystemFormat(long wstr str str ptr) -@ stub QueryDeviceInformation +@ stdcall QueryDeviceInformation(wstr ptr long) @ stub QueryDeviceInformationByHandle @ stub QueryFileSystemName @ stub QueryLatestFileSystemVersion diff --git a/dll/win32/fmifs/query.c b/dll/win32/fmifs/query.c index 9903275fcac..c05e3fc65f7 100644 --- a/dll/win32/fmifs/query.c +++ b/dll/win32/fmifs/query.c @@ -8,6 +8,12 @@ */ #include "precomp.h" +#include <ntddstor.h> +#include <ntstrsafe.h> + +#define NTOS_MODE_USER +#include <ndk/iofuncs.h> +#include <ndk/obfuncs.h> BOOLEAN NTAPI @@ -43,3 +49,155 @@ QueryAvailableFileSystemFormat( return TRUE; } + +/** + * @brief + * Retrieves disk device information. + * + * @param[in] DriveRoot + * String which contains a DOS device name, + * + * @param[in,out] DeviceInformation + * Pointer to buffer with DEVICE_INFORMATION structure which will receive data. + * + * @param[in] BufferSize + * Size of buffer in bytes. + * + * @return + * TRUE if the buffer was large enough and was filled with + * the requested information, FALSE otherwise. + * + * @remarks + * The returned information is mostly related to Sony Memory Stick devices. + * On Vista+ the returned information is disk sector size and volume length in sectors, + * regardless of the type of disk. + * ReactOS implementation returns DEVICE_HOTPLUG flag if inspected device is a hotplug device + * as well as sector size and volume length of disk device. + */ +BOOL +NTAPI +QueryDeviceInformation( + _In_ PWCHAR DriveRoot, + _Out_ PVOID DeviceInformation, + _In_ ULONG BufferSize) +{ + PDEVICE_INFORMATION DeviceInfo = DeviceInformation; + IO_STATUS_BLOCK Iosb; + DISK_GEOMETRY DiskGeometry; + STORAGE_HOTPLUG_INFO HotplugInfo; + GET_LENGTH_INFORMATION LengthInformation; + OBJECT_ATTRIBUTES ObjectAttributes; + UNICODE_STRING DeviceName; + HANDLE FileHandle; + NTSTATUS Status; + WCHAR DiskDevice[MAX_PATH]; + WCHAR DriveName[MAX_PATH]; + + /* Buffer should be able to at least hold DeviceFlags */ + if (BufferSize < sizeof(ULONG) || + !NT_SUCCESS(RtlStringCchCopyW(DriveName, ARRAYSIZE(DriveName), DriveRoot))) + { + return FALSE; + } + + if (DriveName[wcslen(DriveName) - 1] != L'\\') + { + /* Append the trailing backslash for GetVolumeNameForVolumeMountPointW */ + if (!NT_SUCCESS(RtlStringCchCatW(DriveName, ARRAYSIZE(DriveName), L"\\"))) + return FALSE; + } + + if (!GetVolumeNameForVolumeMountPointW(DriveName, DiskDevice, ARRAYSIZE(DiskDevice)) || + !RtlDosPathNameToNtPathName_U(DiskDevice, &DeviceName, NULL, NULL)) + { + /* Disk has no volume GUID, fallback to QueryDosDevice */ + DriveName[wcslen(DriveName) - 1] = UNICODE_NULL; + if (!QueryDosDeviceW(DriveName, DiskDevice, ARRAYSIZE(DiskDevice))) + return FALSE; + RtlInitUnicodeString(&DeviceName, DiskDevice); + } + else + { + /* Trim the trailing backslash since we will work with a device object */ + DeviceName.Length -= sizeof(WCHAR); + } + + InitializeObjectAttributes(&ObjectAttributes, + &DeviceName, + OBJ_CASE_INSENSITIVE, + NULL, + NULL); + + Status = NtOpenFile(&FileHandle, + FILE_READ_DATA | FILE_READ_ATTRIBUTES | SYNCHRONIZE, + &ObjectAttributes, + &Iosb, + FILE_SHARE_READ | FILE_SHARE_WRITE, + FILE_SYNCHRONOUS_IO_NONALERT); + if (!NT_SUCCESS(Status)) + return FALSE; + + Status = NtDeviceIoControlFile(FileHandle, + NULL, + NULL, + NULL, + &Iosb, + IOCTL_STORAGE_GET_HOTPLUG_INFO, + NULL, + 0, + &HotplugInfo, + sizeof(HotplugInfo)); + if (!NT_SUCCESS(Status)) + goto Quit; + + DeviceInfo->DeviceFlags = 0; + if (HotplugInfo.MediaHotplug || HotplugInfo.DeviceHotplug) + { + /* This is a hotplug device */ + DeviceInfo->DeviceFlags |= DEVICE_HOTPLUG; + } + + /* Other flags that would be set here are related to Sony "Memory Stick" + * type of devices which we do not have any special support for */ + + if (BufferSize >= sizeof(DEVICE_INFORMATION)) + { + /* This is the Vista+ version of the structure. + * We need to also provide disk sector size and volume length in sectors. */ + Status = NtDeviceIoControlFile(FileHandle, + NULL, + NULL, + NULL, + &Iosb, + IOCTL_DISK_GET_DRIVE_GEOMETRY, + NULL, + 0, + &DiskGeometry, + sizeof(DiskGeometry)); + if (!NT_SUCCESS(Status)) + goto Quit; + + Status = NtDeviceIoControlFile(FileHandle, + NULL, + NULL, + NULL, + &Iosb, + IOCTL_DISK_GET_LENGTH_INFO, + NULL, + 0, + &LengthInformation, + sizeof(LengthInformation)); + if (!NT_SUCCESS(Status)) + goto Quit; + + LengthInformation.Length.QuadPart /= DiskGeometry.BytesPerSector; + DeviceInfo->SectorSize = DiskGeometry.BytesPerSector; + DeviceInfo->SectorCount = LengthInformation.Length; + } + + Status = STATUS_SUCCESS; + +Quit: + NtClose(FileHandle); + return NT_SUCCESS(Status); +} diff --git a/sdk/include/reactos/libs/fmifs/fmifs.h b/sdk/include/reactos/libs/fmifs/fmifs.h index 482b3b02457..27e3950239e 100644 --- a/sdk/include/reactos/libs/fmifs/fmifs.h +++ b/sdk/include/reactos/libs/fmifs/fmifs.h @@ -33,6 +33,20 @@ typedef struct PCHAR Output; } TEXTOUTPUT, *PTEXTOUTPUT; +/* Device information */ +typedef struct _DEVICE_INFORMATION +{ + ULONG DeviceFlags; + ULONG SectorSize; + LARGE_INTEGER SectorCount; +} DEVICE_INFORMATION, *PDEVICE_INFORMATION; + +/* Device information flags */ +#define MEMORYSTICK_FORMAT_CAPABLE 0x10 +#define MEMORYSTICK_SUPPORTS_PROGRESS_BAR 0x20 +#define DEVICE_HOTPLUG 0x40 +#define DEVICE_MEMORYSTICK 0x41 + /* media flags */ typedef enum { @@ -163,11 +177,12 @@ QueryAvailableFileSystemFormat( OUT UCHAR* Minor, OUT BOOLEAN* LatestVersion); -BOOL NTAPI +BOOL +NTAPI QueryDeviceInformation( - IN PWCHAR DriveRoot, - OUT ULONG* Buffer, /* That is probably some 4-bytes structure */ - IN ULONG BufferSize); /* 4 */ + _In_ PWCHAR DriveRoot, + _Out_ PVOID DeviceInformation, + _In_ ULONG BufferSize); BOOL NTAPI QueryFileSystemName(

2 months, 2 weeks

[reactos] 01/01: [NTOS:KDBG] Add missing \n to DPRINT() calls (#6018)

by Serge Gautherie

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=8de4d4d2ea171e9739948… commit 8de4d4d2ea171e97399486e4f0215ec4d8bef51e Author: Serge Gautherie <32623169+SergeGautherie(a)users.noreply.github.com> AuthorDate: Mon Oct 7 11:07:47 2024 +0200 Commit: GitHub <noreply(a)github.com> CommitDate: Mon Oct 7 11:07:47 2024 +0200 [NTOS:KDBG] Add missing \n to DPRINT() calls (#6018) And demote/promote some DPRINT()/DPRINT1(). --- ntoskrnl/kdbg/kdb_cli.c | 25 ++++++++++++------------- 1 file changed, 12 insertions(+), 13 deletions(-) diff --git a/ntoskrnl/kdbg/kdb_cli.c b/ntoskrnl/kdbg/kdb_cli.c index 50d484accd1..a8ce312f918 100644 --- a/ntoskrnl/kdbg/kdb_cli.c +++ b/ntoskrnl/kdbg/kdb_cli.c @@ -29,6 +29,7 @@ /* INCLUDES ******************************************************************/ #include <ntoskrnl.h> + #include "kdb.h" #include "../kd/kdterminal.h" @@ -619,7 +620,7 @@ KdbpCmdPrintStruct( { ULONG i; ULONGLONG Result = 0; - PVOID BaseAddress = 0; + PVOID BaseAddress = NULL; ROSSYM_AGGREGATE Aggregate = {0}; UNICODE_STRING ModName = {0}; ANSI_STRING AnsiName = {0}; @@ -641,7 +642,7 @@ KdbpCmdPrintStruct( if (Argc > 3) { ULONG len; PCHAR ArgStart = Argv[3]; - DPRINT1("Trying to get expression\n"); + DPRINT("Trying to get expression\n"); for (i = 3; i < Argc - 1; i++) { len = strlen(Argv[i]); @@ -649,20 +650,18 @@ KdbpCmdPrintStruct( } /* Evaluate the expression */ - DPRINT1("Arg: %s\n", ArgStart); - if (KdbpEvaluateExpression(ArgStart, strlen(ArgStart), &Result)) { + DPRINT("Arg: %s\n", ArgStart); + if (KdbpEvaluateExpression(ArgStart, strlen(ArgStart), &Result)) BaseAddress = (PVOID)(ULONG_PTR)Result; - DPRINT1("BaseAddress: %p\n", BaseAddress); - } } - DPRINT1("BaseAddress: %p\n", BaseAddress); + DPRINT("BaseAddress: %p\n", BaseAddress); KdbpPrintStructInternal(Info, Indent, !!BaseAddress, BaseAddress, &Aggregate); end: RosSymFreeAggregate(&Aggregate); RtlFreeUnicodeString(&ModName); return TRUE; } -#endif +#endif // __ROS_DWARF__ /*!\brief Retrieves the component ID corresponding to a given component name. * @@ -1140,7 +1139,7 @@ KdbpContextFromPrevTss( #endif return TRUE; } -#endif +#endif // _M_IX86 #ifdef _M_AMD64 @@ -3421,7 +3420,7 @@ KdbpCliInit(VOID) FILE_NO_INTERMEDIATE_BUFFERING); if (!NT_SUCCESS(Status)) { - DPRINT("Could not open \\SystemRoot\\System32\\drivers\\etc\\KDBinit (Status 0x%x)", Status); + DPRINT1("Could not open \\SystemRoot\\System32\\drivers\\etc\\KDBinit (Status 0x%lx)\n", Status); return Status; } @@ -3432,7 +3431,7 @@ KdbpCliInit(VOID) if (!NT_SUCCESS(Status)) { ZwClose(hFile); - DPRINT("Could not query size of \\SystemRoot\\System32\\drivers\\etc\\KDBinit (Status 0x%x)", Status); + DPRINT1("Could not query size of \\SystemRoot\\System32\\drivers\\etc\\KDBinit (Status 0x%lx)\n", Status); return Status; } FileSize = FileStdInfo.EndOfFile.u.LowPart; @@ -3442,7 +3441,7 @@ KdbpCliInit(VOID) if (!FileBuffer) { ZwClose(hFile); - DPRINT("Could not allocate %d bytes for KDBinit file\n", FileSize); + DPRINT1("Could not allocate %d bytes for KDBinit file\n", FileSize); return Status; } @@ -3453,7 +3452,7 @@ KdbpCliInit(VOID) if (!NT_SUCCESS(Status) && (Status != STATUS_END_OF_FILE)) { ExFreePool(FileBuffer); - DPRINT("Could not read KDBinit file into memory (Status 0x%lx)\n", Status); + DPRINT1("Could not read KDBinit file into memory (Status 0x%lx)\n", Status); return Status; }

2 months, 2 weeks

[reactos] 01/01: [NTOS:MM] MmFlushSegment: Simplify return (#7422)

by Thamatip Chitpong

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=259180a568d688e4e0758… commit 259180a568d688e4e07585ff07502ed98562edb8 Author: Thamatip Chitpong <thamatip.chitpong(a)reactos.org> AuthorDate: Mon Oct 7 15:56:29 2024 +0700 Commit: GitHub <noreply(a)github.com> CommitDate: Mon Oct 7 15:56:29 2024 +0700 [NTOS:MM] MmFlushSegment: Simplify return (#7422) --- ntoskrnl/mm/section.c | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/ntoskrnl/mm/section.c b/ntoskrnl/mm/section.c index 0e4c0e1bcc7..1949d026149 100644 --- a/ntoskrnl/mm/section.c +++ b/ntoskrnl/mm/section.c @@ -4961,9 +4961,7 @@ MmFlushSegment( if (!Segment) { /* Nothing to flush */ - if (Iosb) - Iosb->Status = STATUS_SUCCESS; - return STATUS_SUCCESS; + goto Quit; } ASSERT(*Segment->Flags & MM_DATAFILE_SEGMENT); @@ -4976,17 +4974,12 @@ MmFlushSegment( /* FIXME: All of this is suboptimal */ ULONG ElemCount = RtlNumberGenericTableElements(&Segment->PageTable); - /* No page. Nothing to flush */ if (!ElemCount) { + /* No page. Nothing to flush */ MmUnlockSectionSegment(Segment); MmDereferenceSegment(Segment); - if (Iosb) - { - Iosb->Status = STATUS_SUCCESS; - Iosb->Information = 0; - } - return STATUS_SUCCESS; + goto Quit; } PCACHE_SECTION_PAGE_TABLE PageTable = RtlGetElementGenericTable(&Segment->PageTable, ElemCount - 1); @@ -5014,6 +5007,8 @@ MmFlushSegment( MmUnlockSectionSegment(Segment); MmDereferenceSegment(Segment); +Quit: + /* FIXME: Handle failures */ if (Iosb) Iosb->Status = STATUS_SUCCESS;

2 months, 2 weeks

[reactos] 01/01: [REACTOS] Add missing line breaks at end of file

by Timo Kreuzer

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=0c2cdcae83e248a425f2f… commit 0c2cdcae83e248a425f2f199a439a0ac433ecbf4 Author: Timo Kreuzer <timo.kreuzer(a)reactos.org> AuthorDate: Sat May 18 13:30:54 2024 +0300 Commit: Timo Kreuzer <timo.kreuzer(a)reactos.org> CommitDate: Sun Oct 6 10:47:11 2024 +0300 [REACTOS] Add missing line breaks at end of file --- base/applications/atactl/helper.h | 2 +- base/applications/charmap_new/Cell.cpp | 2 +- base/applications/charmap_new/GridView.cpp | 2 +- base/applications/charmap_new/MainWindow.h | 2 +- base/applications/charmap_new/precomp.h | 2 +- base/applications/mscutils/servman/stop_dependencies.c | 2 +- base/applications/network/net/cmdConfig.c | 2 +- base/applications/network/net/cmdStatistics.c | 2 +- base/applications/sndvol32/mixer.c | 2 +- base/services/nfsd/acl.c | 2 +- base/services/nfsd/pnfs_io.c | 2 +- base/services/umpnpmgr/precomp.h | 2 +- base/shell/explorer/notifyiconscust.cpp | 2 +- base/system/diskpart/attach.c | 2 +- boot/armllb/inc/machtype.h | 2 +- boot/environ/include/efi/UefiMultiPhase.h | 2 +- boot/environ/include/efi/UefiSpec.h | 2 +- boot/environ/lib/misc/bootreg.c | 2 +- boot/environ/lib/mm/stub/mm.c | 2 +- boot/freeldr/install/linux/finstext2.c | 2 +- boot/freeldr/install/linux/finstext2.h | 2 +- dll/3rdparty/libtirpc/src/bindresvport.c | 2 +- dll/3rdparty/libtirpc/src/clnt_generic.c | 2 +- dll/3rdparty/libtirpc/src/epoll_sub.c | 2 +- dll/3rdparty/libtirpc/src/getpublickey.c | 2 +- dll/3rdparty/libtirpc/src/key_prot_xdr.c | 2 +- dll/3rdparty/libtirpc/src/netname.c | 2 +- dll/3rdparty/libtirpc/src/netnamer.c | 2 +- dll/3rdparty/libtirpc/src/pmap_getmaps.c | 2 +- dll/3rdparty/libtirpc/src/pmap_getport.c | 2 +- dll/3rdparty/libtirpc/src/pmap_prot.c | 2 +- dll/3rdparty/libtirpc/src/winstubs.c | 2 +- dll/3rdparty/mbedtls/_reactos_strsafe_wrapper.c | 2 +- dll/cpl/appwiz/removestartmenuitems.c | 2 +- dll/directx/bdaplgin/frequencyfilter.cpp | 2 +- dll/directx/bdaplgin/lnbinfo.cpp | 2 +- dll/directx/d3d9/d3d9_basetexture.h | 2 +- dll/directx/ksproxy/enumpins.cpp | 2 +- dll/directx/msdvbnp/enumpins.cpp | 2 +- dll/directx/msdvbnp/pin.cpp | 2 +- dll/directx/msdvbnp/scanningtuner.cpp | 2 +- dll/directx/msvidctl/tuningspace_container.cpp | 2 +- dll/nls/normaliz/normalize.c | 2 +- dll/opengl/opengl32/wgl_font.c | 2 +- dll/shellext/shellbtrfs/contextmenu.cpp | 2 +- dll/shellext/shellbtrfs/send.cpp | 2 +- dll/win32/devmgr/api.cpp | 2 +- dll/win32/devmgr/devmgmt/DeviceView.cpp | 2 +- dll/win32/devmgr/devmgmt/Node.cpp | 2 +- dll/win32/devmgr/devmgmt/RootNode.cpp | 2 +- dll/win32/devmgr/properties/stubs.cpp | 2 +- dll/win32/dnsapi/rpc.c | 2 +- dll/win32/fltlib/fltlib.c | 2 +- dll/win32/msports/serial.c | 2 +- dll/win32/schannel/schannel_mbedtls.c | 2 +- dll/win32/schannel/schannel_mbedtls_lazyload.h | 2 +- dll/win32/shell32/CQueryAssociations.cpp | 2 +- dll/win32/shell32/CQueryAssociations.h | 2 +- dll/win32/shell32/dialogs/filedefext.h | 2 +- dll/win32/shell32/shellmenu/CMenuFocusManager.cpp | 2 +- dll/win32/shimgvw/comsup.h | 2 +- dll/win32/streamci/streamci.c | 2 +- drivers/bluetooth/fbtusb/include/fbtHciCmdStructs.h | 2 +- drivers/bluetooth/fbtusb/include/fbtHciDefs.h | 2 +- drivers/bluetooth/fbtusb/include/fbtHciErrors.h | 2 +- drivers/bluetooth/fbtusb/include/fbtHciEventStructs.h | 2 +- drivers/bluetooth/fbtusb/include/fbtHciEvents.h | 2 +- drivers/bluetooth/fbtusb/include/fbtHciOpCodes.h | 2 +- drivers/bluetooth/fbtusb/include/fbtHciParms.h | 2 +- drivers/bluetooth/fbtusb/include/fbtHciSizes.h | 2 +- drivers/bluetooth/fbtusb/include/fbtSeXcpt.h | 2 +- drivers/bluetooth/fbtusb/include/fbtreg.h | 2 +- drivers/bluetooth/fbtusb/include/fbtutil.h | 2 +- drivers/filesystems/cdfs/cdprocssrc.c | 2 +- drivers/filesystems/fastfat/fatprocssrc.c | 2 +- drivers/filesystems/udfs/Include/CrossNt/CrossNt.h | 2 +- drivers/filesystems/udfs/Include/regtools.h | 2 +- drivers/filesystems/udfs/Include/string_lib.cpp | 2 +- drivers/filesystems/udfs/Include/udf_reg.h | 2 +- drivers/filesystems/udfs/namesup.h | 2 +- drivers/filters/fltmgr/Registry.h | 2 +- drivers/network/tcpip/include/lwip/arch/perf.h | 2 +- drivers/network/tcpip/include/lwip/lwipopts.h | 2 +- drivers/network/tcpip/ip/lwip_glue/ip.c | 2 +- drivers/network/tcpip/ip/lwip_glue/memory.c | 2 +- drivers/storage/ide/uniata/badblock.h | 2 +- drivers/storage/ide/uniata/id_queue.h | 2 +- drivers/storage/ide/uniata/inc/CrossNt.h | 2 +- drivers/storage/ide/uniata/inc/PostDbgMesg.h | 2 +- drivers/usb/usbport/device.c | 2 +- drivers/usb/usbport/queue.c | 2 +- drivers/wdm/audio/drivers/CMIDriver/cmicontrol/main.h | 2 +- drivers/wdm/audio/drivers/CMIDriver/interfaces.hpp | 2 +- drivers/wdm/audio/drivers/CMIDriver/property.h | 2 +- modules/rosapps/applications/screensavers/starfield/screensaver.c | 2 +- modules/rosapps/applications/sysutils/utils/sdkparse/binary2cstr.cpp | 2 +- modules/rosapps/applications/sysutils/utils/sdkparse/tokenize.cpp | 2 +- modules/rosapps/templates/mdi/ros2win.c | 2 +- modules/rostests/apitests/comctl32/toolbar.c | 2 +- modules/rostests/apitests/crt/dll_startup.cpp | 2 +- modules/rostests/apitests/include/apitest_iathook.h | 2 +- modules/rostests/apitests/include/msgtrace.h | 2 +- modules/rostests/apitests/kernel32/FindActCtxSectionStringW.c | 2 +- modules/rostests/apitests/kernel32/LoadLibraryExW.c | 2 +- modules/rostests/apitests/localspl/localspl_apitest.h | 2 +- modules/rostests/apitests/ntdll/NtFreeVirtualMemory.c | 2 +- modules/rostests/apitests/ntdll/RtlQueryTimeZoneInfo.c | 2 +- modules/rostests/apitests/shell32/CFSFolder.cpp | 2 +- modules/rostests/apitests/shell32/Control_RunDLLW.cpp | 2 +- modules/rostests/apitests/uxtheme/CloseThemeData.c | 2 +- modules/rostests/apitests/uxtheme/DrawThemeParentBackground.c | 2 +- modules/rostests/apitests/uxtheme/SetWindowTheme.c | 2 +- modules/rostests/kmtests/fltmgr/fltmgr_create/fltmgr_create.c | 2 +- modules/rostests/kmtests/hidparse/HidPDescription.c | 2 +- modules/rostests/kmtests/ntos_io/IoDeviceInterface.c | 2 +- modules/rostests/kmtests/ntos_ke/KeProcessor.c | 2 +- modules/rostests/win32/DriverLoading/Driver/driver.c | 2 +- modules/rostests/winetests/setupapi/dialog.c | 2 +- ntoskrnl/tests/TestTimer.c | 2 +- sdk/include/crt/mingw_math.h | 2 +- sdk/include/dxsdk/d3dx9effect.h | 2 +- sdk/include/reactos/srmp.h | 2 +- sdk/lib/atl/atlstr.h | 2 +- sdk/lib/crt/misc/isblank.c | 2 +- sdk/lib/crt/misc/iswblank.c | 2 +- sdk/lib/drivers/virtio/virtio_pci_common.h | 2 +- sdk/lib/drivers/wdf/reactos_special.cpp | 2 +- sdk/lib/rtl/heapdbg.c | 2 +- 128 files changed, 128 insertions(+), 128 deletions(-) diff --git a/base/applications/atactl/helper.h b/base/applications/atactl/helper.h index 700bc7c6bf8..fd379deca6d 100644 --- a/base/applications/atactl/helper.h +++ b/base/applications/atactl/helper.h @@ -35,4 +35,4 @@ typedef struct _SENDCMDINPARAMS { ULONG dwReserved[4]; UCHAR bBuffer[1]; } SENDCMDINPARAMS, *PSENDCMDINPARAMS, *LPSENDCMDINPARAMS; -#include <poppack.h> \ No newline at end of file +#include <poppack.h> diff --git a/base/applications/charmap_new/Cell.cpp b/base/applications/charmap_new/Cell.cpp index fba4bcdb642..671da41a2fb 100644 --- a/base/applications/charmap_new/Cell.cpp +++ b/base/applications/charmap_new/Cell.cpp @@ -91,4 +91,4 @@ CCell::SetCellCoordinates( ) { m_CellCoordinates = Coordinates; -} \ No newline at end of file +} diff --git a/base/applications/charmap_new/GridView.cpp b/base/applications/charmap_new/GridView.cpp index f7005d2170d..4aefe8b4b69 100644 --- a/base/applications/charmap_new/GridView.cpp +++ b/base/applications/charmap_new/GridView.cpp @@ -519,4 +519,4 @@ CGridView::SetCellFocus( // Set the new active cell and give it focus m_ActiveCell = NewActiveCell; m_ActiveCell->SetFocus(true); -} \ No newline at end of file +} diff --git a/base/applications/charmap_new/MainWindow.h b/base/applications/charmap_new/MainWindow.h index 63127d74fe9..08d67afa776 100644 --- a/base/applications/charmap_new/MainWindow.h +++ b/base/applications/charmap_new/MainWindow.h @@ -81,4 +81,4 @@ private: bool ChangeMapFont( ); -}; \ No newline at end of file +}; diff --git a/base/applications/charmap_new/precomp.h b/base/applications/charmap_new/precomp.h index 2a1d322c107..d8f95617576 100644 --- a/base/applications/charmap_new/precomp.h +++ b/base/applications/charmap_new/precomp.h @@ -51,4 +51,4 @@ //WINE_DEFAULT_DEBUG_CHANNEL(charmap); -#endif \ No newline at end of file +#endif diff --git a/base/applications/mscutils/servman/stop_dependencies.c b/base/applications/mscutils/servman/stop_dependencies.c index da94ebbf414..c535bfcf1f4 100644 --- a/base/applications/mscutils/servman/stop_dependencies.c +++ b/base/applications/mscutils/servman/stop_dependencies.c @@ -311,4 +311,4 @@ CreateStopDependsDialog(HWND hParent, return TRUE; return FALSE; -} \ No newline at end of file +} diff --git a/base/applications/network/net/cmdConfig.c b/base/applications/network/net/cmdConfig.c index 59245279b3f..ce816ea2c7e 100644 --- a/base/applications/network/net/cmdConfig.c +++ b/base/applications/network/net/cmdConfig.c @@ -322,4 +322,4 @@ done: PrintErrorMessage(ERROR_SUCCESS); return result; -} \ No newline at end of file +} diff --git a/base/applications/network/net/cmdStatistics.c b/base/applications/network/net/cmdStatistics.c index db51641c6c1..d8e88a46977 100644 --- a/base/applications/network/net/cmdStatistics.c +++ b/base/applications/network/net/cmdStatistics.c @@ -310,4 +310,4 @@ cmdStatistics( PrintErrorMessage(ERROR_SUCCESS); return result; -} \ No newline at end of file +} diff --git a/base/applications/sndvol32/mixer.c b/base/applications/sndvol32/mixer.c index cd1dcc1bf32..1dd4400e905 100644 --- a/base/applications/sndvol32/mixer.c +++ b/base/applications/sndvol32/mixer.c @@ -647,4 +647,4 @@ SndMixerGetLineByName(PSND_MIXER Mixer, } return NULL; -} \ No newline at end of file +} diff --git a/base/services/nfsd/acl.c b/base/services/nfsd/acl.c index 1d3774a9264..f2769991546 100644 --- a/base/services/nfsd/acl.c +++ b/base/services/nfsd/acl.c @@ -798,4 +798,4 @@ const nfs41_upcall_op nfs41_op_setacl = { parse_setacl, handle_setacl, marshall_setacl -}; \ No newline at end of file +}; diff --git a/base/services/nfsd/pnfs_io.c b/base/services/nfsd/pnfs_io.c index 8ca7df666bc..35f60368e0b 100644 --- a/base/services/nfsd/pnfs_io.c +++ b/base/services/nfsd/pnfs_io.c @@ -868,4 +868,4 @@ out: dprintf(IOLVL, "<-- pnfs_write() returning %s\n", pnfs_error_string(status)); return status; -} \ No newline at end of file +} diff --git a/base/services/umpnpmgr/precomp.h b/base/services/umpnpmgr/precomp.h index 0720b177c87..a9dabcc25c8 100644 --- a/base/services/umpnpmgr/precomp.h +++ b/base/services/umpnpmgr/precomp.h @@ -92,4 +92,4 @@ extern BOOL g_IsUISuppressed; BOOL GetSuppressNewUIValue(VOID); -#endif /* _UMPNPMGR_PCH_ */ \ No newline at end of file +#endif /* _UMPNPMGR_PCH_ */ diff --git a/base/shell/explorer/notifyiconscust.cpp b/base/shell/explorer/notifyiconscust.cpp index 18e2d665da0..2fe473c1021 100644 --- a/base/shell/explorer/notifyiconscust.cpp +++ b/base/shell/explorer/notifyiconscust.cpp @@ -47,4 +47,4 @@ INT_PTR CALLBACK CustomizeNotifyIconsProc(HWND hwnd, UINT Message, WPARAM wParam VOID ShowCustomizeNotifyIcons(HINSTANCE hInst, HWND hExplorer) { DialogBoxW(hInst, MAKEINTRESOURCEW(IDD_NOTIFICATIONS_CUSTOMIZE), hExplorer, CustomizeNotifyIconsProc); -} \ No newline at end of file +} diff --git a/base/system/diskpart/attach.c b/base/system/diskpart/attach.c index be02ff58e08..bc06be74a2d 100644 --- a/base/system/diskpart/attach.c +++ b/base/system/diskpart/attach.c @@ -11,4 +11,4 @@ BOOL attach_main(INT argc, LPWSTR *argv) { return TRUE; -} \ No newline at end of file +} diff --git a/boot/armllb/inc/machtype.h b/boot/armllb/inc/machtype.h index 9c76f4c1282..fcf35130189 100644 --- a/boot/armllb/inc/machtype.h +++ b/boot/armllb/inc/machtype.h @@ -29,4 +29,4 @@ // #define MACH_TYPE_OMAP_ZOOM2 1967 -/* EOF */ \ No newline at end of file +/* EOF */ diff --git a/boot/environ/include/efi/UefiMultiPhase.h b/boot/environ/include/efi/UefiMultiPhase.h index 65355b0ca34..397bdb0d90a 100644 --- a/boot/environ/include/efi/UefiMultiPhase.h +++ b/boot/environ/include/efi/UefiMultiPhase.h @@ -190,4 +190,4 @@ typedef struct { WIN_CERTIFICATE_UEFI_GUID AuthInfo; } EFI_VARIABLE_AUTHENTICATION_2; -#endif \ No newline at end of file +#endif diff --git a/boot/environ/include/efi/UefiSpec.h b/boot/environ/include/efi/UefiSpec.h index f7cbb8ba6bd..0b065431f02 100644 --- a/boot/environ/include/efi/UefiSpec.h +++ b/boot/environ/include/efi/UefiSpec.h @@ -2097,4 +2097,4 @@ typedef struct { //#include <Uefi/UefiGpt.h> //#include <Uefi/UefiInternalFormRepresentation.h> -#endif \ No newline at end of file +#endif diff --git a/boot/environ/lib/misc/bootreg.c b/boot/environ/lib/misc/bootreg.c index 0a32a73f955..fa709678e11 100644 --- a/boot/environ/lib/misc/bootreg.c +++ b/boot/environ/lib/misc/bootreg.c @@ -950,4 +950,4 @@ BiDeleteKey ( /* All done */ return Status; -} \ No newline at end of file +} diff --git a/boot/environ/lib/mm/stub/mm.c b/boot/environ/lib/mm/stub/mm.c index 84036d351e9..ad8a3b38dd9 100644 --- a/boot/environ/lib/mm/stub/mm.c +++ b/boot/environ/lib/mm/stub/mm.c @@ -49,4 +49,4 @@ MmArchTranslateVirtualAddress ( { EfiPrintf(L" MmMapPhysicalAddress NOT IMPLEMENTED for this platform\r\n"); return FALSE; -} \ No newline at end of file +} diff --git a/boot/freeldr/install/linux/finstext2.c b/boot/freeldr/install/linux/finstext2.c index a90275b003a..968bcf9d941 100644 --- a/boot/freeldr/install/linux/finstext2.c +++ b/boot/freeldr/install/linux/finstext2.c @@ -144,4 +144,4 @@ int main(int argc, char *argv[]) } return 0; -} \ No newline at end of file +} diff --git a/boot/freeldr/install/linux/finstext2.h b/boot/freeldr/install/linux/finstext2.h index 32e87e4aece..9ba59293d00 100644 --- a/boot/freeldr/install/linux/finstext2.h +++ b/boot/freeldr/install/linux/finstext2.h @@ -26,4 +26,4 @@ typedef struct unsigned char BootPartition; unsigned short BootSignature; -} PACKED EXT2_BOOTCODE, *PEXT2_BOOTCODE; \ No newline at end of file +} PACKED EXT2_BOOTCODE, *PEXT2_BOOTCODE; diff --git a/dll/3rdparty/libtirpc/src/bindresvport.c b/dll/3rdparty/libtirpc/src/bindresvport.c index d4a0e2f0b22..3b74f51922b 100644 --- a/dll/3rdparty/libtirpc/src/bindresvport.c +++ b/dll/3rdparty/libtirpc/src/bindresvport.c @@ -275,4 +275,4 @@ bindresvport_sa(sd, sa) /* #endif */ -#endif \ No newline at end of file +#endif diff --git a/dll/3rdparty/libtirpc/src/clnt_generic.c b/dll/3rdparty/libtirpc/src/clnt_generic.c index 409f4ecc49f..fa8fdb72079 100644 --- a/dll/3rdparty/libtirpc/src/clnt_generic.c +++ b/dll/3rdparty/libtirpc/src/clnt_generic.c @@ -472,4 +472,4 @@ __rpc_raise_fd(int fd) return (nfd); } -#endif \ No newline at end of file +#endif diff --git a/dll/3rdparty/libtirpc/src/epoll_sub.c b/dll/3rdparty/libtirpc/src/epoll_sub.c index 734509884ba..4f3789995c9 100644 --- a/dll/3rdparty/libtirpc/src/epoll_sub.c +++ b/dll/3rdparty/libtirpc/src/epoll_sub.c @@ -59,4 +59,4 @@ epoll_wait(int epfd, struct epoll_event *events, int maxevents, int timeout) return (syscall(__NR_epoll_wait, epfd, events, maxevents, timeout)); } -#endif \ No newline at end of file +#endif diff --git a/dll/3rdparty/libtirpc/src/getpublickey.c b/dll/3rdparty/libtirpc/src/getpublickey.c index 0dee0637c5b..9cc95d403af 100644 --- a/dll/3rdparty/libtirpc/src/getpublickey.c +++ b/dll/3rdparty/libtirpc/src/getpublickey.c @@ -172,4 +172,4 @@ int getpublickey(netname, publickey) else return(__getpublickey_real(netname, publickey)); } -#endif /* ! _WIN32 */ \ No newline at end of file +#endif /* ! _WIN32 */ diff --git a/dll/3rdparty/libtirpc/src/key_prot_xdr.c b/dll/3rdparty/libtirpc/src/key_prot_xdr.c index 985f55b2366..d24ee2777f6 100644 --- a/dll/3rdparty/libtirpc/src/key_prot_xdr.c +++ b/dll/3rdparty/libtirpc/src/key_prot_xdr.c @@ -170,4 +170,4 @@ xdr_key_netstres(register XDR *xdrs, key_netstres *objp) } return (TRUE); } -#endif \ No newline at end of file +#endif diff --git a/dll/3rdparty/libtirpc/src/netname.c b/dll/3rdparty/libtirpc/src/netname.c index d0588abadf0..96afb367576 100644 --- a/dll/3rdparty/libtirpc/src/netname.c +++ b/dll/3rdparty/libtirpc/src/netname.c @@ -147,4 +147,4 @@ host2netname(netname, host, domain) (void) sprintf(netname, "%s.%s@%s", OPSYS, host, domain); return (1); } -#endif \ No newline at end of file +#endif diff --git a/dll/3rdparty/libtirpc/src/netnamer.c b/dll/3rdparty/libtirpc/src/netnamer.c index b43f63462d8..b9cc15bfed7 100644 --- a/dll/3rdparty/libtirpc/src/netnamer.c +++ b/dll/3rdparty/libtirpc/src/netnamer.c @@ -324,4 +324,4 @@ getnetid(key, ret) } } } -#endif /* !_WIN32 */ \ No newline at end of file +#endif /* !_WIN32 */ diff --git a/dll/3rdparty/libtirpc/src/pmap_getmaps.c b/dll/3rdparty/libtirpc/src/pmap_getmaps.c index c6ad2bb8481..261ff1ebc6a 100644 --- a/dll/3rdparty/libtirpc/src/pmap_getmaps.c +++ b/dll/3rdparty/libtirpc/src/pmap_getmaps.c @@ -88,4 +88,4 @@ pmap_getmaps(address) } address->sin_port = 0; return (head); -} \ No newline at end of file +} diff --git a/dll/3rdparty/libtirpc/src/pmap_getport.c b/dll/3rdparty/libtirpc/src/pmap_getport.c index 45c8b1c02b7..7a01573df9d 100644 --- a/dll/3rdparty/libtirpc/src/pmap_getport.c +++ b/dll/3rdparty/libtirpc/src/pmap_getport.c @@ -106,4 +106,4 @@ pmap_getport(address, program, version, protocol) address->sin_port = 0; return (port); } -#endif /* ! _WIN32 */ \ No newline at end of file +#endif /* ! _WIN32 */ diff --git a/dll/3rdparty/libtirpc/src/pmap_prot.c b/dll/3rdparty/libtirpc/src/pmap_prot.c index 2f5644dd751..f9c03421276 100644 --- a/dll/3rdparty/libtirpc/src/pmap_prot.c +++ b/dll/3rdparty/libtirpc/src/pmap_prot.c @@ -55,4 +55,4 @@ xdr_pmap(xdrs, regs) xdr_u_long(xdrs, &regs->pm_prot)) return (xdr_u_long(xdrs, &regs->pm_port)); return (FALSE); -} \ No newline at end of file +} diff --git a/dll/3rdparty/libtirpc/src/winstubs.c b/dll/3rdparty/libtirpc/src/winstubs.c index 13bf356cd98..a6016c363dc 100644 --- a/dll/3rdparty/libtirpc/src/winstubs.c +++ b/dll/3rdparty/libtirpc/src/winstubs.c @@ -9,4 +9,4 @@ DWORD getpid(void) fprintf(stderr, "STUB: getpid() returning zero!\n"); return 0; } -*/ \ No newline at end of file +*/ diff --git a/dll/3rdparty/mbedtls/_reactos_strsafe_wrapper.c b/dll/3rdparty/mbedtls/_reactos_strsafe_wrapper.c index 3c5d9cb3c99..4d68a978026 100644 --- a/dll/3rdparty/mbedtls/_reactos_strsafe_wrapper.c +++ b/dll/3rdparty/mbedtls/_reactos_strsafe_wrapper.c @@ -47,4 +47,4 @@ int _vsnprintf_s(char *buffer, size_t sizeOfBuffer, size_t count, const char *fo default: return -1; } -} \ No newline at end of file +} diff --git a/dll/cpl/appwiz/removestartmenuitems.c b/dll/cpl/appwiz/removestartmenuitems.c index 6c6d783c85c..ee761083eb6 100644 --- a/dll/cpl/appwiz/removestartmenuitems.c +++ b/dll/cpl/appwiz/removestartmenuitems.c @@ -43,4 +43,4 @@ CALLBACK ConfigStartMenu(HWND hwndCPl, UINT uMsg, LPARAM lParam1, LPARAM lParam2) { return ShowRemoveStartMenuItems(hwndCPl, (LPWSTR) lParam1); -} \ No newline at end of file +} diff --git a/dll/directx/bdaplgin/frequencyfilter.cpp b/dll/directx/bdaplgin/frequencyfilter.cpp index 047fc8d7b20..9b8f3707ac2 100644 --- a/dll/directx/bdaplgin/frequencyfilter.cpp +++ b/dll/directx/bdaplgin/frequencyfilter.cpp @@ -281,4 +281,4 @@ CBDAFrequencyFilter_fnConstructor( } return NOERROR; -} \ No newline at end of file +} diff --git a/dll/directx/bdaplgin/lnbinfo.cpp b/dll/directx/bdaplgin/lnbinfo.cpp index 76895546b64..811a5eede59 100644 --- a/dll/directx/bdaplgin/lnbinfo.cpp +++ b/dll/directx/bdaplgin/lnbinfo.cpp @@ -202,4 +202,4 @@ CBDALNBInfo_fnConstructor( } return NOERROR; -} \ No newline at end of file +} diff --git a/dll/directx/d3d9/d3d9_basetexture.h b/dll/directx/d3d9/d3d9_basetexture.h index 2c08c4cbd8c..eaa674875f8 100644 --- a/dll/directx/d3d9/d3d9_basetexture.h +++ b/dll/directx/d3d9/d3d9_basetexture.h @@ -43,4 +43,4 @@ typedef struct _Direct3DBaseTexture9_INT } Direct3DBaseTexture9_INT; #pragma pack(pop) -#endif \ No newline at end of file +#endif diff --git a/dll/directx/ksproxy/enumpins.cpp b/dll/directx/ksproxy/enumpins.cpp index 38df14f7726..147ce1d3b76 100644 --- a/dll/directx/ksproxy/enumpins.cpp +++ b/dll/directx/ksproxy/enumpins.cpp @@ -166,4 +166,4 @@ CEnumPins_fnConstructor( } return NOERROR; -} \ No newline at end of file +} diff --git a/dll/directx/msdvbnp/enumpins.cpp b/dll/directx/msdvbnp/enumpins.cpp index c9450aacd4f..17a74723e4f 100644 --- a/dll/directx/msdvbnp/enumpins.cpp +++ b/dll/directx/msdvbnp/enumpins.cpp @@ -166,4 +166,4 @@ CEnumPins_fnConstructor( } return NOERROR; -} \ No newline at end of file +} diff --git a/dll/directx/msdvbnp/pin.cpp b/dll/directx/msdvbnp/pin.cpp index 51d913e772c..e5a71f6ba0d 100644 --- a/dll/directx/msdvbnp/pin.cpp +++ b/dll/directx/msdvbnp/pin.cpp @@ -342,4 +342,4 @@ CPin_fnConstructor( } return NOERROR; -} \ No newline at end of file +} diff --git a/dll/directx/msdvbnp/scanningtuner.cpp b/dll/directx/msdvbnp/scanningtuner.cpp index 3b86a664f23..ffa1ebaa135 100644 --- a/dll/directx/msdvbnp/scanningtuner.cpp +++ b/dll/directx/msdvbnp/scanningtuner.cpp @@ -719,4 +719,4 @@ CScanningTunner_fnConstructor( } return NOERROR; -} \ No newline at end of file +} diff --git a/dll/directx/msvidctl/tuningspace_container.cpp b/dll/directx/msvidctl/tuningspace_container.cpp index 1733e2fc8f7..94fcf978dde 100644 --- a/dll/directx/msvidctl/tuningspace_container.cpp +++ b/dll/directx/msvidctl/tuningspace_container.cpp @@ -269,4 +269,4 @@ CTuningSpaceContainer_fnConstructor( } return NOERROR; -} \ No newline at end of file +} diff --git a/dll/nls/normaliz/normalize.c b/dll/nls/normaliz/normalize.c index e6f78b852a1..74585ea536e 100644 --- a/dll/nls/normaliz/normalize.c +++ b/dll/nls/normaliz/normalize.c @@ -48,4 +48,4 @@ BOOL WINAPI IsNormalizedString(NORM_FORM NormForm, LPCWSTR lpString, INT cwLengt DPRINT1("%x %p %d\n", NormForm, lpString, cwLength); SetLastError(ERROR_CALL_NOT_IMPLEMENTED); return FALSE; -} \ No newline at end of file +} diff --git a/dll/opengl/opengl32/wgl_font.c b/dll/opengl/opengl32/wgl_font.c index 9640d41f411..1a8e1bc7d4d 100644 --- a/dll/opengl/opengl32/wgl_font.c +++ b/dll/opengl/opengl32/wgl_font.c @@ -567,4 +567,4 @@ BOOL WINAPI wglUseFontOutlinesW(HDC hdc, LPGLYPHMETRICSFLOAT lpgmf) { return wglUseFontOutlines_common(hdc, first, count, listBase, deviation, extrusion, format, lpgmf, TRUE); -} \ No newline at end of file +} diff --git a/dll/shellext/shellbtrfs/contextmenu.cpp b/dll/shellext/shellbtrfs/contextmenu.cpp index 004ac00057c..02fd041955e 100644 --- a/dll/shellext/shellbtrfs/contextmenu.cpp +++ b/dll/shellext/shellbtrfs/contextmenu.cpp @@ -1715,4 +1715,4 @@ extern "C" void CALLBACK ReflinkCopyW(HWND hwnd, HINSTANCE hinst, LPWSTR lpszCmd } } } -} \ No newline at end of file +} diff --git a/dll/shellext/shellbtrfs/send.cpp b/dll/shellext/shellbtrfs/send.cpp index b4f242f73c1..fab7677f57a 100644 --- a/dll/shellext/shellbtrfs/send.cpp +++ b/dll/shellext/shellbtrfs/send.cpp @@ -729,4 +729,4 @@ extern "C" void CALLBACK SendSubvolW(HWND hwnd, HINSTANCE hinst, LPWSTR lpszCmdL } } } -} \ No newline at end of file +} diff --git a/dll/win32/devmgr/api.cpp b/dll/win32/devmgr/api.cpp index fa331474ae0..c128d1055a8 100644 --- a/dll/win32/devmgr/api.cpp +++ b/dll/win32/devmgr/api.cpp @@ -828,4 +828,4 @@ DllMain(_In_ HINSTANCE hinstDLL, return TRUE; } -} \ No newline at end of file +} diff --git a/dll/win32/devmgr/devmgmt/DeviceView.cpp b/dll/win32/devmgr/devmgmt/DeviceView.cpp index 3b38bf208e2..5ee1fb81d54 100644 --- a/dll/win32/devmgr/devmgmt/DeviceView.cpp +++ b/dll/win32/devmgr/devmgmt/DeviceView.cpp @@ -1208,4 +1208,4 @@ CDeviceView::RefreshDeviceList() SetupDiDestroyDeviceInfoList(hDevInfo); return TRUE; -} \ No newline at end of file +} diff --git a/dll/win32/devmgr/devmgmt/Node.cpp b/dll/win32/devmgr/devmgmt/Node.cpp index 0d5e3e1eb29..46db2a2a61a 100644 --- a/dll/win32/devmgr/devmgmt/Node.cpp +++ b/dll/win32/devmgr/devmgmt/Node.cpp @@ -38,4 +38,4 @@ CNode::CNode(const CNode &Node) CNode::~CNode() { -} \ No newline at end of file +} diff --git a/dll/win32/devmgr/devmgmt/RootNode.cpp b/dll/win32/devmgr/devmgmt/RootNode.cpp index 0b9f6a51839..7ae640ad9e8 100644 --- a/dll/win32/devmgr/devmgmt/RootNode.cpp +++ b/dll/win32/devmgr/devmgmt/RootNode.cpp @@ -56,4 +56,4 @@ CRootNode::SetupNode() GetComputerNameW(m_DisplayName, &Size); return true; -} \ No newline at end of file +} diff --git a/dll/win32/devmgr/properties/stubs.cpp b/dll/win32/devmgr/properties/stubs.cpp index cb542635bad..37142269cd7 100644 --- a/dll/win32/devmgr/properties/stubs.cpp +++ b/dll/win32/devmgr/properties/stubs.cpp @@ -33,4 +33,4 @@ OUT LPDWORD lpReboot) unsigned long __stdcall pSetupGuidFromString(wchar_t const *, struct _GUID *) { return 1; -} \ No newline at end of file +} diff --git a/dll/win32/dnsapi/rpc.c b/dll/win32/dnsapi/rpc.c index cf4c8d50fe6..aa6e84c650c 100644 --- a/dll/win32/dnsapi/rpc.c +++ b/dll/win32/dnsapi/rpc.c @@ -72,4 +72,4 @@ void __RPC_USER midl_user_free(void __RPC_FAR * ptr) { HeapFree(GetProcessHeap(), 0, ptr); -} \ No newline at end of file +} diff --git a/dll/win32/fltlib/fltlib.c b/dll/win32/fltlib/fltlib.c index 2111d32fbeb..cbec289889b 100644 --- a/dll/win32/fltlib/fltlib.c +++ b/dll/win32/fltlib/fltlib.c @@ -167,4 +167,4 @@ DllMain(_In_ HINSTANCE hinstDLL, } return TRUE; -} \ No newline at end of file +} diff --git a/dll/win32/msports/serial.c b/dll/win32/msports/serial.c index 515e7eace33..0ce500389b8 100644 --- a/dll/win32/msports/serial.c +++ b/dll/win32/msports/serial.c @@ -667,4 +667,4 @@ SerialPortPropPageProvider( return TRUE; } -/* EOF */ \ No newline at end of file +/* EOF */ diff --git a/dll/win32/schannel/schannel_mbedtls.c b/dll/win32/schannel/schannel_mbedtls.c index e23bf89fa07..b0a8b53bd29 100644 --- a/dll/win32/schannel/schannel_mbedtls.c +++ b/dll/win32/schannel/schannel_mbedtls.c @@ -722,4 +722,4 @@ void schan_imp_deinit(void) WARN("Schannel MBEDTLS schan_imp_deinit\n"); } -#endif /* SONAME_LIBMBEDTLS && !HAVE_SECURITY_SECURITY_H && !SONAME_LIBGNUTLS */ \ No newline at end of file +#endif /* SONAME_LIBMBEDTLS && !HAVE_SECURITY_SECURITY_H && !SONAME_LIBGNUTLS */ diff --git a/dll/win32/schannel/schannel_mbedtls_lazyload.h b/dll/win32/schannel/schannel_mbedtls_lazyload.h index 833c24d5d82..22c27f92b0d 100644 --- a/dll/win32/schannel/schannel_mbedtls_lazyload.h +++ b/dll/win32/schannel/schannel_mbedtls_lazyload.h @@ -171,4 +171,4 @@ void schan_imp_deinit(void) #define mbedtls_cipher_info_from_type pmbedtls_cipher_info_from_type #define mbedtls_md_info_from_type pmbedtls_md_info_from_type #define mbedtls_pk_get_bitlen pmbedtls_pk_get_bitlen -#define mbedtls_ctr_drbg_seed pmbedtls_ctr_drbg_seed \ No newline at end of file +#define mbedtls_ctr_drbg_seed pmbedtls_ctr_drbg_seed diff --git a/dll/win32/shell32/CQueryAssociations.cpp b/dll/win32/shell32/CQueryAssociations.cpp index f115a3d5a3d..a21e49625f8 100644 --- a/dll/win32/shell32/CQueryAssociations.cpp +++ b/dll/win32/shell32/CQueryAssociations.cpp @@ -781,4 +781,4 @@ HRESULT CQueryAssociations::ReturnString(ASSOCF flags, LPWSTR out, DWORD *outlen } return hr; -} \ No newline at end of file +} diff --git a/dll/win32/shell32/CQueryAssociations.h b/dll/win32/shell32/CQueryAssociations.h index a9a09a302eb..90903a7e91c 100644 --- a/dll/win32/shell32/CQueryAssociations.h +++ b/dll/win32/shell32/CQueryAssociations.h @@ -33,4 +33,4 @@ DECLARE_PROTECT_FINAL_CONSTRUCT() BEGIN_COM_MAP(CQueryAssociations) COM_INTERFACE_ENTRY_IID(IID_IQueryAssociations, IQueryAssociations) END_COM_MAP() -}; \ No newline at end of file +}; diff --git a/dll/win32/shell32/dialogs/filedefext.h b/dll/win32/shell32/dialogs/filedefext.h index 73bf81b466a..6ac57d35eb0 100644 --- a/dll/win32/shell32/dialogs/filedefext.h +++ b/dll/win32/shell32/dialogs/filedefext.h @@ -139,4 +139,4 @@ struct _CountFolderAndFilesData { LPWSTR pwszBuf; }; -#endif /* _FILE_DEF_EXT_H_ */ \ No newline at end of file +#endif /* _FILE_DEF_EXT_H_ */ diff --git a/dll/win32/shell32/shellmenu/CMenuFocusManager.cpp b/dll/win32/shell32/shellmenu/CMenuFocusManager.cpp index 77b7b8edfaa..0e5631d9935 100644 --- a/dll/win32/shell32/shellmenu/CMenuFocusManager.cpp +++ b/dll/win32/shell32/shellmenu/CMenuFocusManager.cpp @@ -1040,4 +1040,4 @@ HRESULT CMenuFocusManager::PopTrackedPopup(HMENU popup) return hr; return S_OK; -} \ No newline at end of file +} diff --git a/dll/win32/shimgvw/comsup.h b/dll/win32/shimgvw/comsup.h index 9ac6d856c5c..55df460ce68 100644 --- a/dll/win32/shimgvw/comsup.h +++ b/dll/win32/shimgvw/comsup.h @@ -1,4 +1,4 @@ extern LONG LockCount; extern LONG ObjectCount; -VOID DllInitServer(VOID); \ No newline at end of file +VOID DllInitServer(VOID); diff --git a/dll/win32/streamci/streamci.c b/dll/win32/streamci/streamci.c index eb39aeff201..43e6537b228 100644 --- a/dll/win32/streamci/streamci.c +++ b/dll/win32/streamci/streamci.c @@ -249,4 +249,4 @@ StreamingDeviceSetupW(IN HWND hwnd, } } } -} \ No newline at end of file +} diff --git a/drivers/bluetooth/fbtusb/include/fbtHciCmdStructs.h b/drivers/bluetooth/fbtusb/include/fbtHciCmdStructs.h index 1e91486a2e1..b37c63b646f 100644 --- a/drivers/bluetooth/fbtusb/include/fbtHciCmdStructs.h +++ b/drivers/bluetooth/fbtusb/include/fbtHciCmdStructs.h @@ -718,4 +718,4 @@ typedef struct #pragma pack(pop) -#endif // _FBT_HCI_CMD_STRUCTS_H \ No newline at end of file +#endif // _FBT_HCI_CMD_STRUCTS_H diff --git a/drivers/bluetooth/fbtusb/include/fbtHciDefs.h b/drivers/bluetooth/fbtusb/include/fbtHciDefs.h index f8894fe385c..4d079d613c5 100644 --- a/drivers/bluetooth/fbtusb/include/fbtHciDefs.h +++ b/drivers/bluetooth/fbtusb/include/fbtHciDefs.h @@ -5,4 +5,4 @@ #include "fbtHciEvents.h" #include "fbtHciErrors.h" -#endif // _FBT_HCI_DEFS_H \ No newline at end of file +#endif // _FBT_HCI_DEFS_H diff --git a/drivers/bluetooth/fbtusb/include/fbtHciErrors.h b/drivers/bluetooth/fbtusb/include/fbtHciErrors.h index 98851627a65..a63276def04 100644 --- a/drivers/bluetooth/fbtusb/include/fbtHciErrors.h +++ b/drivers/bluetooth/fbtusb/include/fbtHciErrors.h @@ -55,4 +55,4 @@ #define FBT_HCI_SUCCESS(x) (x==FBT_HCI_ERROR_SUCCESS) -#endif // _FBT_HCI_ERROR_H \ No newline at end of file +#endif // _FBT_HCI_ERROR_H diff --git a/drivers/bluetooth/fbtusb/include/fbtHciEventStructs.h b/drivers/bluetooth/fbtusb/include/fbtHciEventStructs.h index 0610b751822..d538264c7da 100644 --- a/drivers/bluetooth/fbtusb/include/fbtHciEventStructs.h +++ b/drivers/bluetooth/fbtusb/include/fbtHciEventStructs.h @@ -316,4 +316,4 @@ typedef struct #pragma pack(pop) -#endif // _FBT_HCI_EVENT_STRUCTS_H \ No newline at end of file +#endif // _FBT_HCI_EVENT_STRUCTS_H diff --git a/drivers/bluetooth/fbtusb/include/fbtHciEvents.h b/drivers/bluetooth/fbtusb/include/fbtHciEvents.h index a65c9f21872..dde2abbc9a0 100644 --- a/drivers/bluetooth/fbtusb/include/fbtHciEvents.h +++ b/drivers/bluetooth/fbtusb/include/fbtHciEvents.h @@ -42,4 +42,4 @@ #define FBT_HCI_EVENT_SYNCHRONOUS_CONNECTION_COMPLETE 0x24 #define FBT_HCI_EVENT_SYNCHRONOUS_CONNECTION_CHANGED 0x25 -#endif // _FBT_HCI_EVENTS_H \ No newline at end of file +#endif // _FBT_HCI_EVENTS_H diff --git a/drivers/bluetooth/fbtusb/include/fbtHciOpCodes.h b/drivers/bluetooth/fbtusb/include/fbtHciOpCodes.h index c891b442ddd..0c0ef0f3ca6 100644 --- a/drivers/bluetooth/fbtusb/include/fbtHciOpCodes.h +++ b/drivers/bluetooth/fbtusb/include/fbtHciOpCodes.h @@ -122,4 +122,4 @@ #define FBT_HCI_OGF_FROM_COMMAND(cmd) (cmd>>10) #define FBT_HCI_OCF_FROM_COMMAND(cmd) (cmd&0x3FF) -#endif // _FBT_HCI_OPCODES_H \ No newline at end of file +#endif // _FBT_HCI_OPCODES_H diff --git a/drivers/bluetooth/fbtusb/include/fbtHciParms.h b/drivers/bluetooth/fbtusb/include/fbtHciParms.h index d178b721b4f..7a1839f35fa 100644 --- a/drivers/bluetooth/fbtusb/include/fbtHciParms.h +++ b/drivers/bluetooth/fbtusb/include/fbtHciParms.h @@ -48,4 +48,4 @@ #define FBT_HCI_BROADCAST_ACTIVE_SLAVE 0x01 #define FBT_HCI_BROADCAST_PARKED_SLAVE 0x02 -#endif // _FBT_HCI_PARAMETERS_H \ No newline at end of file +#endif // _FBT_HCI_PARAMETERS_H diff --git a/drivers/bluetooth/fbtusb/include/fbtHciSizes.h b/drivers/bluetooth/fbtusb/include/fbtHciSizes.h index d18ffc23999..7b4128877af 100644 --- a/drivers/bluetooth/fbtusb/include/fbtHciSizes.h +++ b/drivers/bluetooth/fbtusb/include/fbtHciSizes.h @@ -24,4 +24,4 @@ #define FBT_HCI_VARIABLE_SIZE 1 -#endif // _FBT_HCI_SIZES_H \ No newline at end of file +#endif // _FBT_HCI_SIZES_H diff --git a/drivers/bluetooth/fbtusb/include/fbtSeXcpt.h b/drivers/bluetooth/fbtusb/include/fbtSeXcpt.h index 0f211b45611..1603421b422 100644 --- a/drivers/bluetooth/fbtusb/include/fbtSeXcpt.h +++ b/drivers/bluetooth/fbtusb/include/fbtSeXcpt.h @@ -19,4 +19,4 @@ class fbtSeException void fbtXcptEnableSEHandling(); -#endif //__SEEXCEPTION_H__ \ No newline at end of file +#endif //__SEEXCEPTION_H__ diff --git a/drivers/bluetooth/fbtusb/include/fbtreg.h b/drivers/bluetooth/fbtusb/include/fbtreg.h index c116b26a793..8f80ac73446 100644 --- a/drivers/bluetooth/fbtusb/include/fbtreg.h +++ b/drivers/bluetooth/fbtusb/include/fbtreg.h @@ -55,4 +55,4 @@ class CReg }; -#endif \ No newline at end of file +#endif diff --git a/drivers/bluetooth/fbtusb/include/fbtutil.h b/drivers/bluetooth/fbtusb/include/fbtutil.h index 05e494bdc05..428e0d55e3a 100644 --- a/drivers/bluetooth/fbtusb/include/fbtutil.h +++ b/drivers/bluetooth/fbtusb/include/fbtutil.h @@ -1,3 +1,3 @@ #include "fbtXcpt.h" #include "fbtLog.h" -#include "fbtReg.h" \ No newline at end of file +#include "fbtReg.h" diff --git a/drivers/filesystems/cdfs/cdprocssrc.c b/drivers/filesystems/cdfs/cdprocssrc.c index a370cab1227..4a47290c788 100644 --- a/drivers/filesystems/cdfs/cdprocssrc.c +++ b/drivers/filesystems/cdfs/cdprocssrc.c @@ -1 +1 @@ -#include "cdprocs.h" \ No newline at end of file +#include "cdprocs.h" diff --git a/drivers/filesystems/fastfat/fatprocssrc.c b/drivers/filesystems/fastfat/fatprocssrc.c index b181cd1c076..1b412491b41 100644 --- a/drivers/filesystems/fastfat/fatprocssrc.c +++ b/drivers/filesystems/fastfat/fatprocssrc.c @@ -1 +1 @@ -#include "fatprocs.h" \ No newline at end of file +#include "fatprocs.h" diff --git a/drivers/filesystems/udfs/Include/CrossNt/CrossNt.h b/drivers/filesystems/udfs/Include/CrossNt/CrossNt.h index 661accc8b6e..f5701099d6d 100644 --- a/drivers/filesystems/udfs/Include/CrossNt/CrossNt.h +++ b/drivers/filesystems/udfs/Include/CrossNt/CrossNt.h @@ -144,4 +144,4 @@ int __cdecl CrNtstrcmp ( }; // end extern "C" -#endif //__CROSS_VERSION_LIB_NT__H__ \ No newline at end of file +#endif //__CROSS_VERSION_LIB_NT__H__ diff --git a/drivers/filesystems/udfs/Include/regtools.h b/drivers/filesystems/udfs/Include/regtools.h index 00d41d37a9c..af10ee59193 100644 --- a/drivers/filesystems/udfs/Include/regtools.h +++ b/drivers/filesystems/udfs/Include/regtools.h @@ -42,4 +42,4 @@ RegTGetStringValue( IN ULONG MaxLen ); -#endif //__MULTIENV_REG_TOOLS__H__ \ No newline at end of file +#endif //__MULTIENV_REG_TOOLS__H__ diff --git a/drivers/filesystems/udfs/Include/string_lib.cpp b/drivers/filesystems/udfs/Include/string_lib.cpp index 51c99ca1044..358598ba6bf 100644 --- a/drivers/filesystems/udfs/Include/string_lib.cpp +++ b/drivers/filesystems/udfs/Include/string_lib.cpp @@ -163,4 +163,4 @@ EO_Scan: return STATUS_SUCCESS; } // end MyInitUnicodeString() -#endif //CDRW_W32 \ No newline at end of file +#endif //CDRW_W32 diff --git a/drivers/filesystems/udfs/Include/udf_reg.h b/drivers/filesystems/udfs/Include/udf_reg.h index 6faf65944bf..9dc1dc8abe0 100644 --- a/drivers/filesystems/udfs/Include/udf_reg.h +++ b/drivers/filesystems/udfs/Include/udf_reg.h @@ -255,4 +255,4 @@ #define REGISTER_APP TEXT("DwRegister.exe") -#endif //__DWUDF_REGISTRY__H__ \ No newline at end of file +#endif //__DWUDF_REGISTRY__H__ diff --git a/drivers/filesystems/udfs/namesup.h b/drivers/filesystems/udfs/namesup.h index 275286d2c76..4c57c0fcd7c 100644 --- a/drivers/filesystems/udfs/namesup.h +++ b/drivers/filesystems/udfs/namesup.h @@ -30,4 +30,4 @@ extern BOOLEAN __fastcall UDFIsMatchAllMask(IN PUNICODE_STRING Name, extern BOOLEAN __fastcall UDFCanNameBeA8dot3(IN PUNICODE_STRING Name); -#endif //__UDF_NAME_SUP__H__ \ No newline at end of file +#endif //__UDF_NAME_SUP__H__ diff --git a/drivers/filters/fltmgr/Registry.h b/drivers/filters/fltmgr/Registry.h index b295daefacf..b004964c848 100644 --- a/drivers/filters/fltmgr/Registry.h +++ b/drivers/filters/fltmgr/Registry.h @@ -17,4 +17,4 @@ FltpReadRegistryValue( _Out_writes_bytes_(BufferSize) PVOID Buffer, _In_ ULONG BufferSize, _Out_opt_ PULONG BytesRequired -); \ No newline at end of file +); diff --git a/drivers/network/tcpip/include/lwip/arch/perf.h b/drivers/network/tcpip/include/lwip/arch/perf.h index 3e00e34ec03..c4348110016 100644 --- a/drivers/network/tcpip/include/lwip/arch/perf.h +++ b/drivers/network/tcpip/include/lwip/arch/perf.h @@ -1,4 +1,4 @@ /* ReactOS-Specific lwIP binding header - by Cameron Gutman */ #define PERF_START -#define PERF_STOP \ No newline at end of file +#define PERF_STOP diff --git a/drivers/network/tcpip/include/lwip/lwipopts.h b/drivers/network/tcpip/include/lwip/lwipopts.h index 5b8bd15dc96..a0310a31b04 100644 --- a/drivers/network/tcpip/include/lwip/lwipopts.h +++ b/drivers/network/tcpip/include/lwip/lwipopts.h @@ -203,4 +203,4 @@ /** * TCPIP_DEBUG: Enable debugging in tcpip.c. */ -#define TCPIP_DEBUG LWIP_DBG_OFF \ No newline at end of file +#define TCPIP_DEBUG LWIP_DBG_OFF diff --git a/drivers/network/tcpip/ip/lwip_glue/ip.c b/drivers/network/tcpip/ip/lwip_glue/ip.c index b6c5ae11129..58da6cda3f0 100644 --- a/drivers/network/tcpip/ip/lwip_glue/ip.c +++ b/drivers/network/tcpip/ip/lwip_glue/ip.c @@ -41,4 +41,4 @@ LibIPShutdown(void) { /* This is synchronous */ sys_shutdown(); -} \ No newline at end of file +} diff --git a/drivers/network/tcpip/ip/lwip_glue/memory.c b/drivers/network/tcpip/ip/lwip_glue/memory.c index 32675c58462..5a33321fe0a 100644 --- a/drivers/network/tcpip/ip/lwip_glue/memory.c +++ b/drivers/network/tcpip/ip/lwip_glue/memory.c @@ -60,4 +60,4 @@ realloc(void *mem, size_t size) /* Return the newly allocated block */ return new_mem; -} \ No newline at end of file +} diff --git a/drivers/storage/ide/uniata/badblock.h b/drivers/storage/ide/uniata/badblock.h index 4e7183cb452..5fa4bbb3b60 100644 --- a/drivers/storage/ide/uniata/badblock.h +++ b/drivers/storage/ide/uniata/badblock.h @@ -78,4 +78,4 @@ CheckIfBadBlock( IN ULONG count ); -#endif // _BADBLOCK_H_INCLUDED_ \ No newline at end of file +#endif // _BADBLOCK_H_INCLUDED_ diff --git a/drivers/storage/ide/uniata/id_queue.h b/drivers/storage/ide/uniata/id_queue.h index f292349456e..a697dec0a43 100644 --- a/drivers/storage/ide/uniata/id_queue.h +++ b/drivers/storage/ide/uniata/id_queue.h @@ -42,4 +42,4 @@ UniataGetNextChannel( IN PHW_CHANNEL chan ); -#endif //__UNIATA_COMMAND_QUEUE_SUPPORT__H__ \ No newline at end of file +#endif //__UNIATA_COMMAND_QUEUE_SUPPORT__H__ diff --git a/drivers/storage/ide/uniata/inc/CrossNt.h b/drivers/storage/ide/uniata/inc/CrossNt.h index 1946be81c58..eebc810cd92 100644 --- a/drivers/storage/ide/uniata/inc/CrossNt.h +++ b/drivers/storage/ide/uniata/inc/CrossNt.h @@ -147,4 +147,4 @@ int __cdecl CrNtstrcmp ( }; // end extern "C" -#endif //__CROSS_VERSION_LIB_NT__H__ \ No newline at end of file +#endif //__CROSS_VERSION_LIB_NT__H__ diff --git a/drivers/storage/ide/uniata/inc/PostDbgMesg.h b/drivers/storage/ide/uniata/inc/PostDbgMesg.h index 1b020610827..5c30d729c0e 100644 --- a/drivers/storage/ide/uniata/inc/PostDbgMesg.h +++ b/drivers/storage/ide/uniata/inc/PostDbgMesg.h @@ -43,4 +43,4 @@ DbgDump_SetAutoReconnect( }; #endif //__cplusplus -#endif //__DBG_DUMP_TOOLS__H__ \ No newline at end of file +#endif //__DBG_DUMP_TOOLS__H__ diff --git a/drivers/usb/usbport/device.c b/drivers/usb/usbport/device.c index 8ecd23cfc27..1003298cc15 100644 --- a/drivers/usb/usbport/device.c +++ b/drivers/usb/usbport/device.c @@ -2045,4 +2045,4 @@ USBPORT_Initialize20Hub(IN PDEVICE_OBJECT FdoDevice, HubDeviceHandle->TtCount = TtCount; return Status; -} \ No newline at end of file +} diff --git a/drivers/usb/usbport/queue.c b/drivers/usb/usbport/queue.c index df70e5f0286..a74f05a11a9 100644 --- a/drivers/usb/usbport/queue.c +++ b/drivers/usb/usbport/queue.c @@ -1414,4 +1414,4 @@ USBPORT_AbortEndpoint(IN PDEVICE_OBJECT FdoDevice, USBPORT_FlushPendingTransfers(Endpoint); USBPORT_FlushCancelList(Endpoint); -} \ No newline at end of file +} diff --git a/drivers/wdm/audio/drivers/CMIDriver/cmicontrol/main.h b/drivers/wdm/audio/drivers/CMIDriver/cmicontrol/main.h index a7f071fd894..8a284a4b206 100644 --- a/drivers/wdm/audio/drivers/CMIDriver/cmicontrol/main.h +++ b/drivers/wdm/audio/drivers/CMIDriver/cmicontrol/main.h @@ -80,4 +80,4 @@ WAVEHDR pwh; int currentChannelCount; HFONT hURLFont; -#endif //_MAIN_H_ \ No newline at end of file +#endif //_MAIN_H_ diff --git a/drivers/wdm/audio/drivers/CMIDriver/interfaces.hpp b/drivers/wdm/audio/drivers/CMIDriver/interfaces.hpp index 387818f141d..275d2461b90 100644 --- a/drivers/wdm/audio/drivers/CMIDriver/interfaces.hpp +++ b/drivers/wdm/audio/drivers/CMIDriver/interfaces.hpp @@ -467,4 +467,4 @@ enum KSNODE_WAVE_INVALID }; -#endif //_INTERFACES_HPP_ \ No newline at end of file +#endif //_INTERFACES_HPP_ diff --git a/drivers/wdm/audio/drivers/CMIDriver/property.h b/drivers/wdm/audio/drivers/CMIDriver/property.h index e0fa2b4d332..e0ed5521f7e 100644 --- a/drivers/wdm/audio/drivers/CMIDriver/property.h +++ b/drivers/wdm/audio/drivers/CMIDriver/property.h @@ -83,4 +83,4 @@ typedef struct UInt32 enableSPDI; } CMIDATA; -#endif //_PROPERTY_H_ \ No newline at end of file +#endif //_PROPERTY_H_ diff --git a/modules/rosapps/applications/screensavers/starfield/screensaver.c b/modules/rosapps/applications/screensavers/starfield/screensaver.c index 24302e1588c..16d131ac97f 100644 --- a/modules/rosapps/applications/screensavers/starfield/screensaver.c +++ b/modules/rosapps/applications/screensavers/starfield/screensaver.c @@ -224,4 +224,4 @@ BOOL WINAPI RegisterDialogClasses(HANDLE hmodule) szTitle, MB_OK | MB_ICONWARNING); return FALSE; -} \ No newline at end of file +} diff --git a/modules/rosapps/applications/sysutils/utils/sdkparse/binary2cstr.cpp b/modules/rosapps/applications/sysutils/utils/sdkparse/binary2cstr.cpp index 83c0aeb6855..335cec8c3a9 100644 --- a/modules/rosapps/applications/sysutils/utils/sdkparse/binary2cstr.cpp +++ b/modules/rosapps/applications/sysutils/utils/sdkparse/binary2cstr.cpp @@ -46,4 +46,4 @@ string binary2cstr ( const string& src ) } } return dst; -} \ No newline at end of file +} diff --git a/modules/rosapps/applications/sysutils/utils/sdkparse/tokenize.cpp b/modules/rosapps/applications/sysutils/utils/sdkparse/tokenize.cpp index 94f9c9a2d48..b6ccdb2e620 100644 --- a/modules/rosapps/applications/sysutils/utils/sdkparse/tokenize.cpp +++ b/modules/rosapps/applications/sysutils/utils/sdkparse/tokenize.cpp @@ -309,4 +309,4 @@ void tokenize ( const string& text, vector<string>& tokens ) break; } } -} \ No newline at end of file +} diff --git a/modules/rosapps/templates/mdi/ros2win.c b/modules/rosapps/templates/mdi/ros2win.c index 2c5bba16ee2..1398a5706bb 100644 --- a/modules/rosapps/templates/mdi/ros2win.c +++ b/modules/rosapps/templates/mdi/ros2win.c @@ -79,4 +79,4 @@ LRESULT CALLBACK RosMDIChildProc(HWND hWnd, UINT message, WPARAM wParam, LPARAM /* -*/ \ No newline at end of file +*/ diff --git a/modules/rostests/apitests/comctl32/toolbar.c b/modules/rostests/apitests/comctl32/toolbar.c index c4b49725b40..1b8f623d709 100644 --- a/modules/rostests/apitests/comctl32/toolbar.c +++ b/modules/rostests/apitests/comctl32/toolbar.c @@ -258,4 +258,4 @@ START_TEST(toolbar) DeactivateActCtx(0, cookie); } } -} \ No newline at end of file +} diff --git a/modules/rostests/apitests/crt/dll_startup.cpp b/modules/rostests/apitests/crt/dll_startup.cpp index 506b6599d74..815c503c93f 100644 --- a/modules/rostests/apitests/crt/dll_startup.cpp +++ b/modules/rostests/apitests/crt/dll_startup.cpp @@ -70,4 +70,4 @@ DllMain( return TRUE; } -} \ No newline at end of file +} diff --git a/modules/rostests/apitests/include/apitest_iathook.h b/modules/rostests/apitests/include/apitest_iathook.h index 9a0ae77e034..21f9d2550b8 100644 --- a/modules/rostests/apitests/include/apitest_iathook.h +++ b/modules/rostests/apitests/include/apitest_iathook.h @@ -61,4 +61,4 @@ static BOOL RestoreIat(HMODULE TargetDll, PCSTR DllName, PCSTR FunctionName, ULO } #endif // _APITEST_IATHOOK_H - \ No newline at end of file + diff --git a/modules/rostests/apitests/include/msgtrace.h b/modules/rostests/apitests/include/msgtrace.h index e7ae51da8a0..57b7b5fff1a 100644 --- a/modules/rostests/apitests/include/msgtrace.h +++ b/modules/rostests/apitests/include/msgtrace.h @@ -71,4 +71,4 @@ static inline BOOL IseKeyMsg(UINT msg) ok((status & (notexpected))!=(notexpected), "wrong queue status. got non expected %li\n", (DWORD)(notexpected)); \ } -#endif \ No newline at end of file +#endif diff --git a/modules/rostests/apitests/kernel32/FindActCtxSectionStringW.c b/modules/rostests/apitests/kernel32/FindActCtxSectionStringW.c index 75080535def..7cdd661a964 100644 --- a/modules/rostests/apitests/kernel32/FindActCtxSectionStringW.c +++ b/modules/rostests/apitests/kernel32/FindActCtxSectionStringW.c @@ -332,4 +332,4 @@ START_TEST(FindActCtxSectionStringW) { skip("Failed to create context for comctl32dep.manifest\n"); } -} \ No newline at end of file +} diff --git a/modules/rostests/apitests/kernel32/LoadLibraryExW.c b/modules/rostests/apitests/kernel32/LoadLibraryExW.c index 7e32f18468c..e7d38c98508 100644 --- a/modules/rostests/apitests/kernel32/LoadLibraryExW.c +++ b/modules/rostests/apitests/kernel32/LoadLibraryExW.c @@ -85,4 +85,4 @@ VOID TestDllRedirection() START_TEST(LoadLibraryExW) { TestDllRedirection(); -} \ No newline at end of file +} diff --git a/modules/rostests/apitests/localspl/localspl_apitest.h b/modules/rostests/apitests/localspl/localspl_apitest.h index c9108d6995f..910e31e7dd8 100644 --- a/modules/rostests/apitests/localspl/localspl_apitest.h +++ b/modules/rostests/apitests/localspl/localspl_apitest.h @@ -14,4 +14,4 @@ typedef BOOL (WINAPI *PInitializePrintProvidor)(LPPRINTPROVIDOR, DWORD, LPWSTR); -#endif \ No newline at end of file +#endif diff --git a/modules/rostests/apitests/ntdll/NtFreeVirtualMemory.c b/modules/rostests/apitests/ntdll/NtFreeVirtualMemory.c index 37fa2480580..afc8f65894a 100644 --- a/modules/rostests/apitests/ntdll/NtFreeVirtualMemory.c +++ b/modules/rostests/apitests/ntdll/NtFreeVirtualMemory.c @@ -214,4 +214,4 @@ START_TEST(NtFreeVirtualMemory) { Test_NtFreeVirtualMemory(); Test_NtFreeVirtualMemory_Parameters(); -} \ No newline at end of file +} diff --git a/modules/rostests/apitests/ntdll/RtlQueryTimeZoneInfo.c b/modules/rostests/apitests/ntdll/RtlQueryTimeZoneInfo.c index ed965e602c9..cd645a4c5a7 100644 --- a/modules/rostests/apitests/ntdll/RtlQueryTimeZoneInfo.c +++ b/modules/rostests/apitests/ntdll/RtlQueryTimeZoneInfo.c @@ -152,4 +152,4 @@ START_TEST(RtlQueryTimeZoneInformation) pRtlQueryTimeZoneInformation = (void *)GetProcAddress(mod, "RtlQueryTimeZoneInformation"); test_RtlQueryTimeZoneInformation(); -} \ No newline at end of file +} diff --git a/modules/rostests/apitests/shell32/CFSFolder.cpp b/modules/rostests/apitests/shell32/CFSFolder.cpp index 7aefe72c050..111f692cbaf 100644 --- a/modules/rostests/apitests/shell32/CFSFolder.cpp +++ b/modules/rostests/apitests/shell32/CFSFolder.cpp @@ -185,4 +185,4 @@ START_TEST(CFSFolder) TestUninitialized(); TestInitialize(); TestGetUIObjectOf(); -} \ No newline at end of file +} diff --git a/modules/rostests/apitests/shell32/Control_RunDLLW.cpp b/modules/rostests/apitests/shell32/Control_RunDLLW.cpp index 59bcbd24d99..8f9e7c9edb9 100644 --- a/modules/rostests/apitests/shell32/Control_RunDLLW.cpp +++ b/modules/rostests/apitests/shell32/Control_RunDLLW.cpp @@ -160,4 +160,4 @@ START_TEST(Control_RunDLLW) ok (tests[i].iStartParams == g_iParams, "%d, CPL_STARTWPARMSW: expected %d got %d\n", tests[i].srcLine, tests[i].iStartParams, g_iParams); ok (wcscmp(tests[i].params, g_wstrParams) == 0, "%d, CPL_STARTWPARMSW: expected %S got %S\n", tests[i].srcLine, tests[i].params, g_wstrParams); } -} \ No newline at end of file +} diff --git a/modules/rostests/apitests/uxtheme/CloseThemeData.c b/modules/rostests/apitests/uxtheme/CloseThemeData.c index 4811cd6801b..60c3d575a40 100644 --- a/modules/rostests/apitests/uxtheme/CloseThemeData.c +++ b/modules/rostests/apitests/uxtheme/CloseThemeData.c @@ -27,4 +27,4 @@ START_TEST(CloseThemeData) ok( hr == E_HANDLE, "Expected E_HANDLE, got 0x%lx\n", hr); RemoveVectoredExceptionHandler(pVEH); -} \ No newline at end of file +} diff --git a/modules/rostests/apitests/uxtheme/DrawThemeParentBackground.c b/modules/rostests/apitests/uxtheme/DrawThemeParentBackground.c index 8e4480c3b42..d18831dd492 100644 --- a/modules/rostests/apitests/uxtheme/DrawThemeParentBackground.c +++ b/modules/rostests/apitests/uxtheme/DrawThemeParentBackground.c @@ -212,4 +212,4 @@ START_TEST(DrawThemeParentBackground) { Test_Messages(); Test_Params(); -} \ No newline at end of file +} diff --git a/modules/rostests/apitests/uxtheme/SetWindowTheme.c b/modules/rostests/apitests/uxtheme/SetWindowTheme.c index 874f4c3c85a..7fe7be22959 100644 --- a/modules/rostests/apitests/uxtheme/SetWindowTheme.c +++ b/modules/rostests/apitests/uxtheme/SetWindowTheme.c @@ -88,4 +88,4 @@ START_TEST(SetWindowTheme) TestTheme(hwnd); DestroyWindow(hwnd); -} \ No newline at end of file +} diff --git a/modules/rostests/kmtests/fltmgr/fltmgr_create/fltmgr_create.c b/modules/rostests/kmtests/fltmgr/fltmgr_create/fltmgr_create.c index 6c28f3ef184..ee35d1fdbd1 100644 --- a/modules/rostests/kmtests/fltmgr/fltmgr_create/fltmgr_create.c +++ b/modules/rostests/kmtests/fltmgr/fltmgr_create/fltmgr_create.c @@ -144,4 +144,4 @@ TestFilterPostOperation( ok_eq_hex(Iopb->MajorFunction, IRP_MJ_CREATE); return FLT_POSTOP_FINISHED_PROCESSING; -} \ No newline at end of file +} diff --git a/modules/rostests/kmtests/hidparse/HidPDescription.c b/modules/rostests/kmtests/hidparse/HidPDescription.c index 242af384bb3..51102042747 100644 --- a/modules/rostests/kmtests/hidparse/HidPDescription.c +++ b/modules/rostests/kmtests/hidparse/HidPDescription.c @@ -255,4 +255,4 @@ TestHidPDescription( TestGetCollectionDescription(); return STATUS_SUCCESS; -} \ No newline at end of file +} diff --git a/modules/rostests/kmtests/ntos_io/IoDeviceInterface.c b/modules/rostests/kmtests/ntos_io/IoDeviceInterface.c index fd4f1f5ee4a..58f15cb6c75 100644 --- a/modules/rostests/kmtests/ntos_io/IoDeviceInterface.c +++ b/modules/rostests/kmtests/ntos_io/IoDeviceInterface.c @@ -289,4 +289,4 @@ START_TEST(IoDeviceInterface) (void)Test_IoRegisterDeviceInterface; Test_IoRegisterPlugPlayNotification(); Test_IoSetDeviceInterface(); -} \ No newline at end of file +} diff --git a/modules/rostests/kmtests/ntos_ke/KeProcessor.c b/modules/rostests/kmtests/ntos_ke/KeProcessor.c index fdf7e3bb555..8bee382aacc 100644 --- a/modules/rostests/kmtests/ntos_ke/KeProcessor.c +++ b/modules/rostests/kmtests/ntos_ke/KeProcessor.c @@ -54,4 +54,4 @@ static VOID KeStallExecutionProcessorTest(VOID) START_TEST(KeProcessor) { KeStallExecutionProcessorTest(); -} \ No newline at end of file +} diff --git a/modules/rostests/win32/DriverLoading/Driver/driver.c b/modules/rostests/win32/DriverLoading/Driver/driver.c index 8d2e56182a8..a8d3ca1fda1 100644 --- a/modules/rostests/win32/DriverLoading/Driver/driver.c +++ b/modules/rostests/win32/DriverLoading/Driver/driver.c @@ -15,4 +15,4 @@ DriverEntry(PDRIVER_OBJECT DriverObject, DbgPrint("Test driver loaded sucessfully\n"); return STATUS_SUCCESS; -} \ No newline at end of file +} diff --git a/modules/rostests/winetests/setupapi/dialog.c b/modules/rostests/winetests/setupapi/dialog.c index 8b47350542d..ff1b0dc9cb9 100644 --- a/modules/rostests/winetests/setupapi/dialog.c +++ b/modules/rostests/winetests/setupapi/dialog.c @@ -108,4 +108,4 @@ START_TEST(dialog) { test_SetupPromptForDiskA(); test_SetupPromptForDiskW(); -} \ No newline at end of file +} diff --git a/ntoskrnl/tests/TestTimer.c b/ntoskrnl/tests/TestTimer.c index 933fc9eb669..1439f7812be 100644 --- a/ntoskrnl/tests/TestTimer.c +++ b/ntoskrnl/tests/TestTimer.c @@ -34,4 +34,4 @@ void main ( int argc, char** argv, char** environ ) } -} \ No newline at end of file +} diff --git a/sdk/include/crt/mingw_math.h b/sdk/include/crt/mingw_math.h index 6713a4fc7e4..2ba58545b71 100644 --- a/sdk/include/crt/mingw_math.h +++ b/sdk/include/crt/mingw_math.h @@ -544,4 +544,4 @@ __MINGW_EXTENSION long long __cdecl llrintl (long double); #endif #endif /* C99 or non strict ANSI or C++ */ -#endif /* __NO_ISOCEXT */ \ No newline at end of file +#endif /* __NO_ISOCEXT */ diff --git a/sdk/include/dxsdk/d3dx9effect.h b/sdk/include/dxsdk/d3dx9effect.h index 4d3689f0f5a..5dd1e7542a5 100644 --- a/sdk/include/dxsdk/d3dx9effect.h +++ b/sdk/include/dxsdk/d3dx9effect.h @@ -442,4 +442,4 @@ HRESULT WINAPI D3DXDisassembleEffect(ID3DXEffect *effect, BOOL enable_color_code } #endif -#endif /* __D3DX9EFFECT_H__ */ \ No newline at end of file +#endif /* __D3DX9EFFECT_H__ */ diff --git a/sdk/include/reactos/srmp.h b/sdk/include/reactos/srmp.h index dbc36da0209..96e964814ba 100644 --- a/sdk/include/reactos/srmp.h +++ b/sdk/include/reactos/srmp.h @@ -48,4 +48,4 @@ typedef struct _LSAP_RM_API_MESSAGE } u; } LSAP_RM_API_MESSAGE, *PLSAP_RM_API_MESSAGE; -#endif /* _SRMP_ */ \ No newline at end of file +#endif /* _SRMP_ */ diff --git a/sdk/lib/atl/atlstr.h b/sdk/lib/atl/atlstr.h index 30c4f940bce..f22efb17eee 100644 --- a/sdk/lib/atl/atlstr.h +++ b/sdk/lib/atl/atlstr.h @@ -142,4 +142,4 @@ typedef CStringA CString; } -#endif \ No newline at end of file +#endif diff --git a/sdk/lib/crt/misc/isblank.c b/sdk/lib/crt/misc/isblank.c index 0963ad52c84..e934d851652 100644 --- a/sdk/lib/crt/misc/isblank.c +++ b/sdk/lib/crt/misc/isblank.c @@ -4,4 +4,4 @@ int __cdecl isblank (int _C) { return (_isctype(_C, _BLANK) || _C == '\t'); -} \ No newline at end of file +} diff --git a/sdk/lib/crt/misc/iswblank.c b/sdk/lib/crt/misc/iswblank.c index bb08ca14523..982a47d4b8e 100644 --- a/sdk/lib/crt/misc/iswblank.c +++ b/sdk/lib/crt/misc/iswblank.c @@ -4,4 +4,4 @@ int __cdecl iswblank (wint_t _C) { return (iswctype(_C, _BLANK) || _C == '\t'); -} \ No newline at end of file +} diff --git a/sdk/lib/drivers/virtio/virtio_pci_common.h b/sdk/lib/drivers/virtio/virtio_pci_common.h index 16720835ed2..cbed1c61dcf 100644 --- a/sdk/lib/drivers/virtio/virtio_pci_common.h +++ b/sdk/lib/drivers/virtio/virtio_pci_common.h @@ -85,4 +85,4 @@ void vp_notify(struct virtqueue *vq); NTSTATUS vio_legacy_initialize(VirtIODevice *vdev); NTSTATUS vio_modern_initialize(VirtIODevice *vdev); -#endif \ No newline at end of file +#endif diff --git a/sdk/lib/drivers/wdf/reactos_special.cpp b/sdk/lib/drivers/wdf/reactos_special.cpp index 2d04b3dc0ed..94ff2f21d87 100644 --- a/sdk/lib/drivers/wdf/reactos_special.cpp +++ b/sdk/lib/drivers/wdf/reactos_special.cpp @@ -72,4 +72,4 @@ __cxa_pure_virtual() __debugbreak(); } -} // extern "C" \ No newline at end of file +} // extern "C" diff --git a/sdk/lib/rtl/heapdbg.c b/sdk/lib/rtl/heapdbg.c index d8beaa36969..261dcdad78a 100644 --- a/sdk/lib/rtl/heapdbg.c +++ b/sdk/lib/rtl/heapdbg.c @@ -542,4 +542,4 @@ RtlDebugSizeHeap(HANDLE HeapPtr, return Result; } -/* EOF */ \ No newline at end of file +/* EOF */

2 months, 2 weeks

[reactos] 01/01: [FREELDR] Remove the "setupldr" build target (#7419)

by Hermès Bélusca-Maïto

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=764881a94b4129538d62f… commit 764881a94b4129538d62fda2c99cfcd1ad518ce5 Author: Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org> AuthorDate: Thu Oct 3 11:16:20 2024 +0200 Commit: Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org> CommitDate: Thu Oct 3 12:32:45 2024 +0200 [FREELDR] Remove the "setupldr" build target (#7419) The setupldr and freeldr binaries are the same since commit 948e82af1 (r65832), because both their functionality have been shared. --- boot/freeldr/bootsect/isoboot.S | 50 ++++++++++++++++++++--------------------- boot/freeldr/freeldr/pcat.cmake | 16 +------------ 2 files changed, 26 insertions(+), 40 deletions(-) diff --git a/boot/freeldr/bootsect/isoboot.S b/boot/freeldr/bootsect/isoboot.S index da52eba9bfe..845bc34059b 100644 --- a/boot/freeldr/bootsect/isoboot.S +++ b/boot/freeldr/bootsect/isoboot.S @@ -115,28 +115,28 @@ relocated: call pollchar_and_empty // If we're booting in hybrid mode and our boot drive is the first HDD (drive 80h), - // we have no other option than booting into SETUPLDR. + // we have no other option than booting into FREELDR. cmp word ptr ds:[GetlinsecPtr], offset getlinsec_ebios jne .read_mbr cmp byte ptr ds:[DriveNumber], HEX(80) - je .boot_setupldr + je .boot_freeldr .read_mbr: // Read the first sector (MBR) from the first hard disk (drive 80h) to 7C00h. // If we then decide to boot from HDD, we already have it at the right place. - // In case of an error (indicated by the Carry Flag), just boot SETUPLDR from our ReactOS medium. + // In case of an error (indicated by the Carry Flag), just boot FREELDR from our ReactOS medium. mov ax, HEX(0201) mov dx, HEX(0080) mov cx, HEX(0001) mov bx, HEX(7C00) call int13 - jc .boot_setupldr + jc .boot_freeldr // Verify the signature of the read MBR. - // If it's invalid, there is probably no OS installed and we just boot SETUPLDR from our ReactOS medium. + // If it's invalid, there is probably no OS installed and we just boot FREELDR from our ReactOS medium. mov ax, word ptr ds:[HEX(7C00)+510] cmp ax, HEX(AA55) - jne .boot_setupldr + jne .boot_freeldr #ifdef WAIT_FOR_KEY // We could either boot from the ReactOS medium or from hard disk. Let the user decide! @@ -155,9 +155,9 @@ relocated: add eax, 19 .poll_again: - // Check for a keypress, boot SETUPLDR from our ReactOS medium if a key was pressed. + // Check for a keypress, boot FREELDR from our ReactOS medium if a key was pressed. call pollchar_and_empty - jnz .boot_setupldr + jnz .boot_freeldr // Check if another second has passed (in BIOS Timer ticks). mov ebx, ds:[BIOS_timer] @@ -185,7 +185,7 @@ relocated: ljmp16 0, HEX(7C00) -.boot_setupldr: +.boot_freeldr: #ifdef WAIT_FOR_KEY call crlf_early call crlf_early @@ -266,26 +266,26 @@ found_drive: xchg eax, dword ptr ds:[si+file_sector] mov dword ptr ds:[CurrentDir+dir_lba], eax - // Look for the "SETUPLDR.SYS" file. - mov di, offset setupldr_sys + // Look for the "FREELDR.SYS" file. + mov di, offset freeldr_sys call searchdir - jnz .setupldr_found + jnz .freeldr_found - // The SETUPLDR file was not found, so bail out with an error message. - mov si, offset no_setupldr_msg + // The FREELDR file was not found, so bail out with an error message. + mov si, offset no_freeldr_msg call writemsg jmp kaboom -.setupldr_found: +.freeldr_found: // Calculate the rounded up number of 2K sectors that need to be read. mov ecx, eax shr ecx, SECTOR_SHIFT test eax, HEX(7FF) - jz .load_setupldr + jz .load_freeldr inc ecx -.load_setupldr: - // Load the entire SETUPLDR.SYS (parameter CX = FFFFh) to its designated base address FREELDR_BASE. +.load_freeldr: + // Load the entire FREELDR.SYS (parameter CX = FFFFh) to its designated base address FREELDR_BASE. // Using a high segment address with offset 0 instead of segment 0 with offset FREELDR_BASE apparently increases compatibility with some BIOSes. mov bx, FREELDR_BASE / 16 mov es, bx @@ -293,15 +293,15 @@ found_drive: mov cx, HEX(FFFF) call getfssec - // Pass two parameters to SETUPLDR: + // Pass two parameters to FREELDR: // DL = BIOS Drive Number // DH = Boot Partition (0 for HDD booting in hybrid mode, FFh for CD booting) movzx dx, byte ptr ds:[DriveNumber] cmp word ptr ds:[GetlinsecPtr], offset getlinsec_ebios - je .jump_to_setupldr + je .jump_to_freeldr mov dh, HEX(FF) -.jump_to_setupldr: +.jump_to_freeldr: // Transfer execution to the bootloader. ljmp16 0, FREELDR_BASE @@ -1086,10 +1086,10 @@ loader_dir: .ascii "/LOADER", NUL no_dir_msg: .ascii "LOADER dir not found.", CR, LF, NUL -setupldr_sys: - .ascii "SETUPLDR.SYS", NUL -no_setupldr_msg: - .ascii "SETUPLDR.SYS not found.", CR, LF, NUL +freeldr_sys: + .ascii "FREELDR.SYS", NUL +no_freeldr_msg: + .ascii "FREELDR.SYS not found.", CR, LF, NUL .align 4 BufSafe: diff --git a/boot/freeldr/freeldr/pcat.cmake b/boot/freeldr/freeldr/pcat.cmake index 0a9c96cdee5..ac18b0e00ec 100644 --- a/boot/freeldr/freeldr/pcat.cmake +++ b/boot/freeldr/freeldr/pcat.cmake @@ -250,18 +250,4 @@ else() add_custom_target(freeldr ALL DEPENDS freeldr_pe) endif() -# Rename freeldr on livecd to setupldr.sys because isoboot.bin looks for setupldr.sys -add_cd_file(TARGET freeldr FILE ${CMAKE_CURRENT_BINARY_DIR}/freeldr.sys DESTINATION loader NO_CAB FOR bootcd regtest) -add_cd_file(TARGET freeldr FILE ${CMAKE_CURRENT_BINARY_DIR}/freeldr.sys DESTINATION loader NO_CAB NOT_IN_HYBRIDCD FOR livecd hybridcd NAME_ON_CD setupldr.sys) - -if(NOT ARCH STREQUAL "arm") - concatenate_files( - ${CMAKE_CURRENT_BINARY_DIR}/setupldr.sys - ${CMAKE_CURRENT_BINARY_DIR}/frldr16.bin - ${CMAKE_CURRENT_BINARY_DIR}/$<TARGET_FILE_NAME:freeldr_pe>) - add_custom_target(setupldr ALL DEPENDS ${CMAKE_CURRENT_BINARY_DIR}/setupldr.sys) -else() - add_custom_target(setupldr ALL DEPENDS freeldr_pe) -endif() - -add_cd_file(TARGET setupldr FILE ${CMAKE_CURRENT_BINARY_DIR}/setupldr.sys DESTINATION loader NO_CAB FOR bootcd regtest) +add_cd_file(TARGET freeldr FILE ${CMAKE_CURRENT_BINARY_DIR}/freeldr.sys DESTINATION loader NO_CAB NOT_IN_HYBRIDCD FOR bootcd livecd hybridcd regtest)

2 months, 3 weeks

[reactos] 01/01: [FREELDR] Simplify some control branches in loops (#7417)

by Hermès Bélusca-Maïto

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=3b928898ef09ece59ba63… commit 3b928898ef09ece59ba63ece3efdd4467195d74a Author: Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org> AuthorDate: Wed Oct 2 19:24:42 2024 +0200 Commit: Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org> CommitDate: Thu Oct 3 11:47:31 2024 +0200 [FREELDR] Simplify some control branches in loops (#7417) Collapse some tests; remove redundant `continue;` Pointed out by Serge Gautherie. --- boot/freeldr/freeldr/arch/i386/pc/pcdisk.c | 42 ++++++++------------------ boot/freeldr/freeldr/arch/i386/pc98/pc98disk.c | 21 ++++--------- boot/freeldr/freeldr/lib/fs/fat.c | 4 +-- 3 files changed, 20 insertions(+), 47 deletions(-) diff --git a/boot/freeldr/freeldr/arch/i386/pc/pcdisk.c b/boot/freeldr/freeldr/arch/i386/pc/pcdisk.c index 1bd498e6730..cf13ed663dc 100644 --- a/boot/freeldr/freeldr/arch/i386/pc/pcdisk.c +++ b/boot/freeldr/freeldr/arch/i386/pc/pcdisk.c @@ -605,22 +605,13 @@ PcDiskReadLogicalSectorsLBA( Int386(0x13, &RegsIn, &RegsOut); - /* If it worked return TRUE */ - if (INT386_SUCCESS(RegsOut)) - { - return TRUE; - } - /* If it was a corrected ECC error then the data is still good */ - else if (RegsOut.b.ah == 0x11) - { + /* If it worked, or if it was a corrected ECC error + * and the data is still good, return success */ + if (INT386_SUCCESS(RegsOut) || (RegsOut.b.ah == 0x11)) return TRUE; - } - /* If it failed then do the next retry */ - else - { - DiskResetController(DriveNumber); - continue; - } + + /* It failed, do the next retry */ + DiskResetController(DriveNumber); } /* If we get here then the read failed */ @@ -715,22 +706,13 @@ PcDiskReadLogicalSectorsCHS( { Int386(0x13, &RegsIn, &RegsOut); - /* If it worked break out */ - if (INT386_SUCCESS(RegsOut)) - { + /* If it worked, or if it was a corrected ECC error + * and the data is still good, break out */ + if (INT386_SUCCESS(RegsOut) || (RegsOut.b.ah == 0x11)) break; - } - /* If it was a corrected ECC error then the data is still good */ - else if (RegsOut.b.ah == 0x11) - { - break; - } - /* If it failed then do the next retry */ - else - { - DiskResetController(DriveNumber); - continue; - } + + /* It failed, do the next retry */ + DiskResetController(DriveNumber); } /* If we retried 3 times then fail */ diff --git a/boot/freeldr/freeldr/arch/i386/pc98/pc98disk.c b/boot/freeldr/freeldr/arch/i386/pc98/pc98disk.c index 9eef9d45f71..e6f98d136f7 100644 --- a/boot/freeldr/freeldr/arch/i386/pc98/pc98disk.c +++ b/boot/freeldr/freeldr/arch/i386/pc98/pc98disk.c @@ -219,22 +219,13 @@ Pc98DiskReadLogicalSectorsLBA( { Int386(0x1B, &RegsIn, &RegsOut); - /* If it worked return TRUE */ - if (INT386_SUCCESS(RegsOut)) - { - return TRUE; - } - /* If it was a corrected ECC error then the data is still good */ - else if (RegsOut.b.ah == 0x08) - { + /* If it worked, or if it was a corrected ECC error + * and the data is still good, return success */ + if (INT386_SUCCESS(RegsOut) || (RegsOut.b.ah == 0x08)) return TRUE; - } - /* If it failed the do the next retry */ - else - { - DiskResetController(DiskDrive); - continue; - } + + /* It failed, do the next retry */ + DiskResetController(DiskDrive); } } diff --git a/boot/freeldr/freeldr/lib/fs/fat.c b/boot/freeldr/freeldr/lib/fs/fat.c index 556f8086430..257f1e43c63 100644 --- a/boot/freeldr/freeldr/lib/fs/fat.c +++ b/boot/freeldr/freeldr/lib/fs/fat.c @@ -668,7 +668,8 @@ BOOLEAN FatSearchDirectoryBufferForFile(PFAT_VOLUME_INFO Volume, PVOID Directory // See if the file name matches either the short or long name // if (((strlen(FileName) == strlen(LfnNameBuffer)) && (_stricmp(FileName, LfnNameBuffer) == 0)) || - ((strlen(FileName) == strlen(ShortNameBuffer)) && (_stricmp(FileName, ShortNameBuffer) == 0))) { + ((strlen(FileName) == strlen(ShortNameBuffer)) && (_stricmp(FileName, ShortNameBuffer) == 0))) + { // // We found the entry, now fill in the FAT_FILE_INFO struct // @@ -702,7 +703,6 @@ BOOLEAN FatSearchDirectoryBufferForFile(PFAT_VOLUME_INFO Volume, PVOID Directory // RtlZeroMemory(ShortNameBuffer, 13 * sizeof(UCHAR)); RtlZeroMemory(LfnNameBuffer, 261 * sizeof(UCHAR)); - continue; } return FALSE;

2 months, 3 weeks

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs October 2024