Ros-diffs January 2025

ros-diffs@reactos.org

23 participants
278 discussions

[reactos] 01/01: [SHELL32][SHELL32_APITEST][SDK] Implement SHEnumerateUnreadMailAccountsW (#7619)

by Katayama Hirofumi MZ

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=aa52c3f5ebb588adbf710… commit aa52c3f5ebb588adbf710310dcb9dd5bfb3a3ba6 Author: Katayama Hirofumi MZ <katayama.hirofumi.mz(a)gmail.com> AuthorDate: Mon Jan 20 08:32:07 2025 +0900 Commit: GitHub <noreply(a)github.com> CommitDate: Mon Jan 20 08:32:07 2025 +0900 [SHELL32][SHELL32_APITEST][SDK] Implement SHEnumerateUnreadMailAccountsW (#7619) Implementing missing features... JIRA issue: CORE-19278 - Move function definition from stubs.cpp into utils.cpp. - Add prototype to <shellapi.h>. --- dll/win32/shell32/stubs.cpp | 15 ---------- dll/win32/shell32/utils.cpp | 33 ++++++++++++++++++++++ modules/rostests/apitests/shell32/CMakeLists.txt | 1 + .../shell32/SHEnumerateUnreadMailAccountsW.cpp | 33 ++++++++++++++++++++++ modules/rostests/apitests/shell32/testlist.c | 2 ++ sdk/include/psdk/shellapi.h | 7 +++++ 6 files changed, 76 insertions(+), 15 deletions(-) diff --git a/dll/win32/shell32/stubs.cpp b/dll/win32/shell32/stubs.cpp index 70918f6f18a..8967dd49ab8 100644 --- a/dll/win32/shell32/stubs.cpp +++ b/dll/win32/shell32/stubs.cpp @@ -30,21 +30,6 @@ SHGetUnreadMailCountW(HKEY hKeyUser, return E_FAIL; } -/* - * Unimplemented - */ -EXTERN_C HRESULT -WINAPI -SHEnumerateUnreadMailAccountsW(HKEY user, - DWORD idx, - LPWSTR mailaddress, - INT mailaddresslen) -{ - FIXME("SHEnumerateUnreadMailAccountsW(%p %d %p %d) stub\n", - user, idx, mailaddress, mailaddresslen); - return E_NOTIMPL; -} - /* * Unimplemented */ diff --git a/dll/win32/shell32/utils.cpp b/dll/win32/shell32/utils.cpp index 391acbd8461..1f4ff07a88e 100644 --- a/dll/win32/shell32/utils.cpp +++ b/dll/win32/shell32/utils.cpp @@ -901,6 +901,39 @@ SheRemoveQuotesW(LPWSTR psz) return psz; } +/************************************************************************* + * SHEnumerateUnreadMailAccountsW [SHELL32.287] + * + * @see https://learn.microsoft.com/en-us/windows/win32/api/shellapi/nf-shellapi-sh… + */ +EXTERN_C +HRESULT WINAPI +SHEnumerateUnreadMailAccountsW( + _In_opt_ HKEY hKeyUser, + _In_ DWORD dwIndex, + _Out_writes_(cchMailAddress) PWSTR pszMailAddress, + _In_ INT cchMailAddress) +{ + if (!hKeyUser) + hKeyUser = HKEY_CURRENT_USER; + + HKEY hKey; + LSTATUS error = RegOpenKeyExW(hKeyUser, + L"Software\\Microsoft\\Windows\\CurrentVersion\\UnreadMail", + 0, KEY_ENUMERATE_SUB_KEYS, &hKey); + if (error) + return HRESULT_FROM_WIN32(error); + + FILETIME FileTime; + error = RegEnumKeyExW(hKey, dwIndex, pszMailAddress, (PDWORD)&cchMailAddress, NULL, NULL, + NULL, &FileTime); + if (error) + *pszMailAddress = UNICODE_NULL; + + RegCloseKey(hKey); + return error ? HRESULT_FROM_WIN32(error) : S_OK; +} + /************************************************************************* * SHFindComputer [SHELL32.91] * diff --git a/modules/rostests/apitests/shell32/CMakeLists.txt b/modules/rostests/apitests/shell32/CMakeLists.txt index 7a7b523a68d..aff71a65c90 100644 --- a/modules/rostests/apitests/shell32/CMakeLists.txt +++ b/modules/rostests/apitests/shell32/CMakeLists.txt @@ -34,6 +34,7 @@ list(APPEND SOURCE SHParseDisplayName.cpp SHRestricted.cpp SHShouldShowWizards.cpp + SHEnumerateUnreadMailAccountsW.cpp She.cpp ShellExec_RunDLL.cpp ShellExecCmdLine.cpp diff --git a/modules/rostests/apitests/shell32/SHEnumerateUnreadMailAccountsW.cpp b/modules/rostests/apitests/shell32/SHEnumerateUnreadMailAccountsW.cpp new file mode 100644 index 00000000000..5abc2df9a44 --- /dev/null +++ b/modules/rostests/apitests/shell32/SHEnumerateUnreadMailAccountsW.cpp @@ -0,0 +1,33 @@ +/* + * PROJECT: ReactOS API tests + * LICENSE: GPL-2.0+ (https://spdx.org/licenses/GPL-2.0+) + * PURPOSE: Test for SHEnumerateUnreadMailAccountsW + * COPYRIGHT: Copyright 2025 Katayama Hirofumi MZ (katayama.hirofumi.mz(a)gmail.com) + */ + +#include "shelltest.h" + +START_TEST(SHEnumerateUnreadMailAccountsW) +{ + HRESULT hr; + WCHAR szMailAddress[MAX_PATH]; + HKEY hKey; + LSTATUS error; + DWORD dwDisposition; + + error = RegCreateKeyExW(HKEY_CURRENT_USER, + L"Software\\Microsoft\\Windows\\CurrentVersion\\UnreadMail\\example.com", + 0, NULL, 0, KEY_WRITE, NULL, &hKey, &dwDisposition); + ok_long(error, ERROR_SUCCESS); + + szMailAddress[0] = UNICODE_NULL; + hr = SHEnumerateUnreadMailAccountsW(NULL, 0, szMailAddress, _countof(szMailAddress)); + ok_hex(hr, S_OK); + ok(szMailAddress[0] != UNICODE_NULL, "szMailAddress was empty\n"); + + if (dwDisposition == REG_CREATED_NEW_KEY) + { + RegDeleteKeyW(HKEY_CURRENT_USER, + L"Software\\Microsoft\\Windows\\CurrentVersion\\UnreadMail\\example.com"); + } +} diff --git a/modules/rostests/apitests/shell32/testlist.c b/modules/rostests/apitests/shell32/testlist.c index d98d529c6fb..daa699a8e32 100644 --- a/modules/rostests/apitests/shell32/testlist.c +++ b/modules/rostests/apitests/shell32/testlist.c @@ -34,6 +34,7 @@ extern void func_SHChangeNotify(void); extern void func_SHCreateDataObject(void); extern void func_SHCreateFileDataObject(void); extern void func_SHCreateFileExtractIconW(void); +extern void func_SHEnumerateUnreadMailAccountsW(void); extern void func_She(void); extern void func_ShellExec_RunDLL(void); extern void func_ShellExecCmdLine(void); @@ -84,6 +85,7 @@ const struct test winetest_testlist[] = { "SHCreateDataObject", func_SHCreateDataObject }, { "SHCreateFileDataObject", func_SHCreateFileDataObject }, { "SHCreateFileExtractIconW", func_SHCreateFileExtractIconW }, + { "SHEnumerateUnreadMailAccountsW", func_SHEnumerateUnreadMailAccountsW }, { "She", func_She }, { "ShellExec_RunDLL", func_ShellExec_RunDLL }, { "ShellExecCmdLine", func_ShellExecCmdLine }, diff --git a/sdk/include/psdk/shellapi.h b/sdk/include/psdk/shellapi.h index eeda59cfcfb..b707d6d41df 100644 --- a/sdk/include/psdk/shellapi.h +++ b/sdk/include/psdk/shellapi.h @@ -652,6 +652,13 @@ SHTestTokenMembership( _In_ ULONG ulRID); #endif +HRESULT WINAPI +SHEnumerateUnreadMailAccountsW( + _In_opt_ HKEY hKeyUser, + _In_ DWORD dwIndex, + _Out_writes_(cchMailAddress) PWSTR pszMailAddress, + _In_ INT cchMailAddress); + #ifdef UNICODE #define NOTIFYICONDATA_V1_SIZE NOTIFYICONDATAW_V1_SIZE #define NOTIFYICONDATA_V2_SIZE NOTIFYICONDATAW_V2_SIZE

2 weeks, 3 days

[reactos] 01/01: [SHELL32] Follow-up of #7620: Simplify string handling

by Katayama Hirofumi MZ

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=0bb8b46ba8e5c25c95a42… commit 0bb8b46ba8e5c25c95a4250edbac8863523b8608 Author: Katayama Hirofumi MZ <katayama.hirofumi.mz(a)gmail.com> AuthorDate: Mon Jan 20 08:27:26 2025 +0900 Commit: Katayama Hirofumi MZ <katayama.hirofumi.mz(a)gmail.com> CommitDate: Mon Jan 20 08:28:58 2025 +0900 [SHELL32] Follow-up of #7620: Simplify string handling CORE-19278 --- dll/win32/shell32/utils.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/dll/win32/shell32/utils.cpp b/dll/win32/shell32/utils.cpp index 575dadaa338..391acbd8461 100644 --- a/dll/win32/shell32/utils.cpp +++ b/dll/win32/shell32/utils.cpp @@ -808,8 +808,7 @@ SHSetUnreadMailCountW( _In_ DWORD dwCount, _In_ PCWSTR pszShellExecuteCommand) { - CString strKey = L"Software\\Microsoft\\Windows\\CurrentVersion\\UnreadMail"; - strKey += L'\\'; + CString strKey = L"Software\\Microsoft\\Windows\\CurrentVersion\\UnreadMail\\"; strKey += pszMailAddress; HKEY hKey;

2 weeks, 3 days

[reactos] 01/01: [SHELL32] Temporarily disable LVS_EX_DOUBLEBUFFER in DefView (#7642)

by Whindmar Saksit

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=b87c6b879907980aee4fd… commit b87c6b879907980aee4fd957b8cecbd1b2ded407 Author: Whindmar Saksit <whindsaks(a)proton.me> AuthorDate: Sun Jan 19 23:20:34 2025 +0100 Commit: GitHub <noreply(a)github.com> CommitDate: Sun Jan 19 23:20:34 2025 +0100 [SHELL32] Temporarily disable LVS_EX_DOUBLEBUFFER in DefView (#7642) Hackfix for CORE-19624 and CORE-19818 until ListView is fixed --- dll/win32/shell32/CDefView.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/dll/win32/shell32/CDefView.cpp b/dll/win32/shell32/CDefView.cpp index 21e7c1bcc4f..55c99e6f7ad 100644 --- a/dll/win32/shell32/CDefView.cpp +++ b/dll/win32/shell32/CDefView.cpp @@ -828,7 +828,9 @@ BOOL CDefView::CreateList() { dwStyle |= LVS_SHOWSELALWAYS; // MSDN says FWF_SHOWSELALWAYS is deprecated, always turn on for folders dwStyle |= (m_FolderSettings.fFlags & FWF_ALIGNLEFT) ? LVS_ALIGNLEFT : LVS_ALIGNTOP; +#if 0 // FIXME: Temporarily disabled until ListView is fixed (CORE-19624, CORE-19818) ListExStyle |= LVS_EX_DOUBLEBUFFER; +#endif } ViewMode = m_FolderSettings.ViewMode;

2 weeks, 3 days

[reactos] 01/01: [SHELL32] Allow DnD to create shortcuts across different drives (#7607)

by Whindmar Saksit

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=aebaa14eba88056e15f46… commit aebaa14eba88056e15f46adbb30767a3889f2d1d Author: Whindmar Saksit <whindsaks(a)proton.me> AuthorDate: Sun Jan 19 21:00:55 2025 +0100 Commit: GitHub <noreply(a)github.com> CommitDate: Sun Jan 19 21:00:55 2025 +0100 [SHELL32] Allow DnD to create shortcuts across different drives (#7607) CORE-17871 CORE-18271 --- dll/win32/shell32/droptargets/CFSDropTarget.cpp | 61 +++++++++++++++++-------- dll/win32/shell32/droptargets/CFSDropTarget.h | 1 + dll/win32/shell32/folders/CDrivesFolder.cpp | 9 ++-- dll/win32/shell32/shldataobject.cpp | 5 +- 4 files changed, 49 insertions(+), 27 deletions(-) diff --git a/dll/win32/shell32/droptargets/CFSDropTarget.cpp b/dll/win32/shell32/droptargets/CFSDropTarget.cpp index fce1a88d5b8..e7b5927500e 100644 --- a/dll/win32/shell32/droptargets/CFSDropTarget.cpp +++ b/dll/win32/shell32/droptargets/CFSDropTarget.cpp @@ -24,6 +24,11 @@ WINE_DEFAULT_DEBUG_CHANNEL (shell); +#define D_NONE DROPEFFECT_NONE +#define D_COPY DROPEFFECT_COPY +#define D_MOVE DROPEFFECT_MOVE +#define D_LINK DROPEFFECT_LINK + static void SHELL_StripIllegalFsNameCharacters(_Inout_ LPWSTR Buf) { for (LPWSTR src = Buf, dst = src;;) @@ -38,6 +43,17 @@ static void SHELL_StripIllegalFsNameCharacters(_Inout_ LPWSTR Buf) } } +static bool PathIsSameDrive(LPCWSTR Path1, LPCWSTR Path2) +{ + int d1 = PathGetDriveNumberW(Path1), d2 = PathGetDriveNumberW(Path2); + return d1 == d2 && d2 >= 0; +} + +static bool PathIsDriveRoot(LPCWSTR Path) +{ + return PathIsRootW(Path) && PathGetDriveNumberW(Path) >= 0; +} + static HRESULT SHELL_LimitDropEffectToItemAttributes(_In_ IDataObject *pDataObject, _Inout_ PDWORD pdwEffect) { @@ -134,7 +150,8 @@ CFSDropTarget::CFSDropTarget(): m_fAcceptFmt(FALSE), m_sPathTarget(NULL), m_hwndSite(NULL), - m_grfKeyState(0) + m_grfKeyState(0), + m_AllowedEffects(0) { } @@ -147,13 +164,7 @@ HRESULT CFSDropTarget::Initialize(LPWSTR PathTarget) if (!m_cfShellIDList) return E_FAIL; - m_sPathTarget = (WCHAR *)SHAlloc((wcslen(PathTarget) + 1) * sizeof(WCHAR)); - if (!m_sPathTarget) - return E_OUTOFMEMORY; - - wcscpy(m_sPathTarget, PathTarget); - - return S_OK; + return SHStrDupW(PathTarget, &m_sPathTarget); } CFSDropTarget::~CFSDropTarget() @@ -202,7 +213,13 @@ BOOL CFSDropTarget::_QueryDrop(DWORD dwKeyState, LPDWORD pdwEffect) *pdwEffect = DROPEFFECT_NONE; if (m_fAcceptFmt) { /* Does our interpretation of the keystate ... */ - *pdwEffect = KeyStateToDropEffect (dwKeyState); + *pdwEffect = KeyStateToDropEffect(dwKeyState); + + // Transform disallowed move to a copy + if ((*pdwEffect & D_MOVE) && (m_AllowedEffects & (D_MOVE | D_COPY)) == D_COPY) + *pdwEffect = D_COPY; + + *pdwEffect &= m_AllowedEffects; if (*pdwEffect == DROPEFFECT_NONE) *pdwEffect = dwEffect; @@ -320,6 +337,9 @@ HRESULT WINAPI CFSDropTarget::DragEnter(IDataObject *pDataObject, { TRACE("(%p)->(DataObject=%p)\n", this, pDataObject); + const BOOL bAnyKeyMod = dwKeyState & (MK_SHIFT | MK_CONTROL); + m_AllowedEffects = *pdwEffect; + if (*pdwEffect == DROPEFFECT_NONE) return S_OK; @@ -337,11 +357,9 @@ HRESULT WINAPI CFSDropTarget::DragEnter(IDataObject *pDataObject, m_grfKeyState = dwKeyState; -#define D_NONE DROPEFFECT_NONE -#define D_COPY DROPEFFECT_COPY -#define D_MOVE DROPEFFECT_MOVE -#define D_LINK DROPEFFECT_LINK - m_dwDefaultEffect = *pdwEffect; + SHELL_LimitDropEffectToItemAttributes(pDataObject, pdwEffect); + m_AllowedEffects = *pdwEffect; + m_dwDefaultEffect = m_AllowedEffects; switch (*pdwEffect & (D_COPY | D_MOVE | D_LINK)) { case D_COPY | D_MOVE: @@ -378,19 +396,24 @@ HRESULT WINAPI CFSDropTarget::DragEnter(IDataObject *pDataObject, WCHAR wstrFirstFile[MAX_PATH]; if (DragQueryFileW((HDROP)medium.hGlobal, 0, wstrFirstFile, _countof(wstrFirstFile))) { - /* Check if the drive letter is different */ - if (wstrFirstFile[0] != m_sPathTarget[0]) + if (!PathIsSameDrive(wstrFirstFile, m_sPathTarget) && m_dwDefaultEffect != D_LINK) { m_dwDefaultEffect = DROPEFFECT_COPY; } + + if (!bAnyKeyMod && PathIsDriveRoot(wstrFirstFile) && (m_AllowedEffects & DROPEFFECT_LINK)) + { + m_dwDefaultEffect = DROPEFFECT_LINK; // Don't copy a drive by default + } } ReleaseStgMedium(&medium); } if (!m_fAcceptFmt) - *pdwEffect = DROPEFFECT_NONE; + m_AllowedEffects = DROPEFFECT_NONE; else *pdwEffect = m_dwDefaultEffect; + *pdwEffect &= m_AllowedEffects; return S_OK; } @@ -471,7 +494,7 @@ HRESULT WINAPI CFSDropTarget::Drop(IDataObject *pDataObject, data->pt = pt; // Need to dereference as pdweffect gets freed. data->pdwEffect = *pdwEffect; - SHCreateThread(CFSDropTarget::_DoDropThreadProc, data, NULL, NULL); + SHCreateThread(CFSDropTarget::_DoDropThreadProc, data, CTF_COINIT | CTF_PROCESS_REF, NULL); return S_OK; } } @@ -726,7 +749,6 @@ HRESULT CFSDropTarget::_DoDrop(IDataObject *pDataObject, DWORD WINAPI CFSDropTarget::_DoDropThreadProc(LPVOID lpParameter) { - CoInitialize(NULL); _DoDropData *data = static_cast<_DoDropData*>(lpParameter); CComPtr<IDataObject> pDataObject; HRESULT hr = CoGetInterfaceAndReleaseStream (data->pStream, IID_PPV_ARG(IDataObject, &pDataObject)); @@ -744,7 +766,6 @@ DWORD WINAPI CFSDropTarget::_DoDropThreadProc(LPVOID lpParameter) data->This->Release(); //Release the parameter from the heap. HeapFree(GetProcessHeap(), 0, data); - CoUninitialize(); return 0; } diff --git a/dll/win32/shell32/droptargets/CFSDropTarget.h b/dll/win32/shell32/droptargets/CFSDropTarget.h index 706164d8f6d..bde59979c24 100644 --- a/dll/win32/shell32/droptargets/CFSDropTarget.h +++ b/dll/win32/shell32/droptargets/CFSDropTarget.h @@ -35,6 +35,7 @@ class CFSDropTarget : HWND m_hwndSite; DWORD m_grfKeyState; DWORD m_dwDefaultEffect; + DWORD m_AllowedEffects; CComPtr<IUnknown> m_site; BOOL _QueryDrop (DWORD dwKeyState, LPDWORD pdwEffect); diff --git a/dll/win32/shell32/folders/CDrivesFolder.cpp b/dll/win32/shell32/folders/CDrivesFolder.cpp index 040511f03e9..df2f591b8bc 100644 --- a/dll/win32/shell32/folders/CDrivesFolder.cpp +++ b/dll/win32/shell32/folders/CDrivesFolder.cpp @@ -557,7 +557,7 @@ static const DWORD dwControlPanelAttributes = SFGAO_HASSUBFOLDER | SFGAO_FOLDER | SFGAO_CANLINK; static const DWORD dwDriveAttributes = SFGAO_HASSUBFOLDER | SFGAO_FILESYSTEM | SFGAO_FOLDER | SFGAO_FILESYSANCESTOR | - SFGAO_DROPTARGET | SFGAO_HASPROPSHEET | SFGAO_CANRENAME | SFGAO_CANLINK; + SFGAO_DROPTARGET | SFGAO_HASPROPSHEET | SFGAO_CANRENAME | SFGAO_CANLINK | SFGAO_CANCOPY; CDrivesFolder::CDrivesFolder() { @@ -611,10 +611,9 @@ HRESULT WINAPI CDrivesFolder::ParseDisplayName(HWND hwndOwner, LPBC pbc, LPOLEST pdwAttributes); } - if (lpszDisplayName[0] && - ((L'A' <= lpszDisplayName[0] && lpszDisplayName[0] <= L'Z') || + if (((L'A' <= lpszDisplayName[0] && lpszDisplayName[0] <= L'Z') || (L'a' <= lpszDisplayName[0] && lpszDisplayName[0] <= L'z')) && - lpszDisplayName[1] == L':' && lpszDisplayName[2] == L'\\') + lpszDisplayName[1] == L':' && (lpszDisplayName[2] == L'\\' || !lpszDisplayName[2])) { // "C:\..." WCHAR szRoot[8]; @@ -630,7 +629,7 @@ HRESULT WINAPI CDrivesFolder::ParseDisplayName(HWND hwndOwner, LPBC pbc, LPOLEST if (!pidlTemp) return E_OUTOFMEMORY; - if (lpszDisplayName[3]) + if (lpszDisplayName[2] && lpszDisplayName[3]) { CComPtr<IShellFolder> pChildFolder; hr = BindToObject(pidlTemp, pbc, IID_PPV_ARG(IShellFolder, &pChildFolder)); diff --git a/dll/win32/shell32/shldataobject.cpp b/dll/win32/shell32/shldataobject.cpp index 728cca0dbf3..04126e930b9 100644 --- a/dll/win32/shell32/shldataobject.cpp +++ b/dll/win32/shell32/shldataobject.cpp @@ -77,8 +77,9 @@ HRESULT WINAPI SHGetAttributesFromDataObject(IDataObject* pDataObject, DWORD dwA data.dwAttributes = rgfInOut & dwQueryAttributes; data.cItems = apidl.GetSize(); - hr = DataObject_SetData(pDataObject, g_DataObjectAttributes, &data, sizeof(data)); - FAILED_UNEXPECTEDLY(hr); + HRESULT hr2; + hr2 = DataObject_SetData(pDataObject, g_DataObjectAttributes, &data, sizeof(data)); + FAILED_UNEXPECTEDLY(hr2); // Report cache failure but don't fail the function } } }

2 weeks, 3 days

[reactos] 01/01: [REGEDIT] Add ES_AUTOHSCROLL to address bar window (#7638)

by Katayama Hirofumi MZ

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=17eff53f35e72e661532a… commit 17eff53f35e72e661532a66da0879d71e2ff4be8 Author: Katayama Hirofumi MZ <katayama.hirofumi.mz(a)gmail.com> AuthorDate: Mon Jan 20 01:01:30 2025 +0900 Commit: GitHub <noreply(a)github.com> CommitDate: Mon Jan 20 01:01:30 2025 +0900 [REGEDIT] Add ES_AUTOHSCROLL to address bar window (#7638) Enable horizontal scroll on address bar. JIRA issue: CORE-19743 - Add ES_AUTOHSCROLL style to the address bar window on its creation. --- base/applications/regedit/childwnd.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/base/applications/regedit/childwnd.c b/base/applications/regedit/childwnd.c index b08736e5322..1cd0dc787ed 100644 --- a/base/applications/regedit/childwnd.c +++ b/base/applications/regedit/childwnd.c @@ -388,7 +388,8 @@ LRESULT CALLBACK ChildWndProc(HWND hWnd, UINT message, WPARAM wParam, LPARAM lPa g_pChildWnd->nSplitPos = 190; g_pChildWnd->hWnd = hWnd; - style = WS_CHILD | WS_VISIBLE | WS_TABSTOP; + /* ES_AUTOHSCROLL style enables horizontal scrolling and shrinking */ + style = WS_CHILD | WS_VISIBLE | WS_TABSTOP | ES_AUTOHSCROLL; g_pChildWnd->hAddressBarWnd = CreateWindowExW(WS_EX_CLIENTEDGE, L"Edit", NULL, style, CW_USEDEFAULT, CW_USEDEFAULT, CW_USEDEFAULT, CW_USEDEFAULT, hWnd, (HMENU)0, hInst, 0);

2 weeks, 3 days

[reactos] 01/01: [SHELL32][SHELL32_APITEST][SDK] Implement SHSetUnreadMailCountW (#7620)

by Katayama Hirofumi MZ

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=2da2fba042f013e5a21b9… commit 2da2fba042f013e5a21b9abe39d5709e95db81f6 Author: Katayama Hirofumi MZ <katayama.hirofumi.mz(a)gmail.com> AuthorDate: Sun Jan 19 21:26:19 2025 +0900 Commit: GitHub <noreply(a)github.com> CommitDate: Sun Jan 19 21:26:19 2025 +0900 [SHELL32][SHELL32_APITEST][SDK] Implement SHSetUnreadMailCountW (#7620) Implementing missing features... JIRA issue: CORE-19278 - Move function definition from stubs.cpp into utils.cpp. - Add prototype to <shellapi.h>. --- dll/win32/shell32/stubs.cpp | 13 ----- dll/win32/shell32/utils.cpp | 58 ++++++++++++++++++++++ modules/rostests/apitests/shell32/CMakeLists.txt | 1 + .../apitests/shell32/SHSetUnreadMailCountW.cpp | 58 ++++++++++++++++++++++ modules/rostests/apitests/shell32/testlist.c | 2 + sdk/include/psdk/shellapi.h | 6 +++ 6 files changed, 125 insertions(+), 13 deletions(-) diff --git a/dll/win32/shell32/stubs.cpp b/dll/win32/shell32/stubs.cpp index 5fec3d1e342..70918f6f18a 100644 --- a/dll/win32/shell32/stubs.cpp +++ b/dll/win32/shell32/stubs.cpp @@ -30,19 +30,6 @@ SHGetUnreadMailCountW(HKEY hKeyUser, return E_FAIL; } -/* - * Unimplemented - */ -EXTERN_C HRESULT -WINAPI -SHSetUnreadMailCountW(LPCWSTR pszMailAddress, - DWORD dwCount, - LPCWSTR pszShellExecuteCommand) -{ - FIXME("SHSetUnreadMailCountW() stub\n"); - return E_FAIL; -} - /* * Unimplemented */ diff --git a/dll/win32/shell32/utils.cpp b/dll/win32/shell32/utils.cpp index c1761021e18..575dadaa338 100644 --- a/dll/win32/shell32/utils.cpp +++ b/dll/win32/shell32/utils.cpp @@ -796,6 +796,64 @@ SHCreatePropertyBag(_In_ REFIID riid, _Out_ void **ppvObj) return SHCreatePropertyBagOnMemory(STGM_READWRITE, riid, ppvObj); } +/************************************************************************* + * SHSetUnreadMailCountW [SHELL32.336] + * + * @see https://learn.microsoft.com/en-us/windows/win32/api/shellapi/nf-shellapi-sh… + */ +EXTERN_C +HRESULT WINAPI +SHSetUnreadMailCountW( + _In_ PCWSTR pszMailAddress, + _In_ DWORD dwCount, + _In_ PCWSTR pszShellExecuteCommand) +{ + CString strKey = L"Software\\Microsoft\\Windows\\CurrentVersion\\UnreadMail"; + strKey += L'\\'; + strKey += pszMailAddress; + + HKEY hKey; + DWORD dwDisposition; + LSTATUS error = RegCreateKeyExW(HKEY_CURRENT_USER, strKey, 0, NULL, 0, KEY_SET_VALUE, NULL, + &hKey, &dwDisposition); + if (error) + return HRESULT_FROM_WIN32(error); + + error = RegSetValueExW(hKey, L"MessageCount", 0, REG_DWORD, (PBYTE)&dwCount, sizeof(dwCount)); + if (error) + { + RegCloseKey(hKey); + return HRESULT_FROM_WIN32(error); + } + + FILETIME FileTime; + GetSystemTimeAsFileTime(&FileTime); + + error = RegSetValueExW(hKey, L"TimeStamp", 0, REG_BINARY, (PBYTE)&FileTime, sizeof(FileTime)); + if (error) + { + RegCloseKey(hKey); + return HRESULT_FROM_WIN32(error); + } + + WCHAR szBuff[2 * MAX_PATH]; + if (!PathUnExpandEnvStringsW(pszShellExecuteCommand, szBuff, _countof(szBuff))) + { + HRESULT hr = StringCchCopyW(szBuff, _countof(szBuff), pszShellExecuteCommand); + if (FAILED_UNEXPECTEDLY(hr)) + { + RegCloseKey(hKey); + return hr; + } + } + + DWORD cbValue = (lstrlenW(szBuff) + 1) * sizeof(WCHAR); + error = RegSetValueExW(hKey, L"Application", 0, REG_SZ, (PBYTE)szBuff, cbValue); + + RegCloseKey(hKey); + return (error ? HRESULT_FROM_WIN32(error) : S_OK); +} + /************************************************************************* * SheRemoveQuotesA (SHELL32.@) */ diff --git a/modules/rostests/apitests/shell32/CMakeLists.txt b/modules/rostests/apitests/shell32/CMakeLists.txt index 39f1092027e..7a7b523a68d 100644 --- a/modules/rostests/apitests/shell32/CMakeLists.txt +++ b/modules/rostests/apitests/shell32/CMakeLists.txt @@ -45,6 +45,7 @@ list(APPEND SOURCE SHGetAttributesFromDataObject.cpp SHGetUserDisplayName.cpp SHLimitInputEdit.cpp + SHSetUnreadMailCountW.cpp menu.cpp shelltest.cpp) diff --git a/modules/rostests/apitests/shell32/SHSetUnreadMailCountW.cpp b/modules/rostests/apitests/shell32/SHSetUnreadMailCountW.cpp new file mode 100644 index 00000000000..413ecb34335 --- /dev/null +++ b/modules/rostests/apitests/shell32/SHSetUnreadMailCountW.cpp @@ -0,0 +1,58 @@ +/* + * PROJECT: ReactOS API tests + * LICENSE: GPL-2.0+ (https://spdx.org/licenses/GPL-2.0+) + * PURPOSE: Test for SHSetUnreadMailCountW + * COPYRIGHT: Copyright 2025 Katayama Hirofumi MZ (katayama.hirofumi.mz(a)gmail.com) + */ + +#include "shelltest.h" + +START_TEST(SHSetUnreadMailCountW) +{ + HKEY hKey; + LSTATUS error; + DWORD dwDisposition; + error = RegCreateKeyExW(HKEY_CURRENT_USER, + L"Software\\Microsoft\\Windows\\CurrentVersion\\UnreadMail\\example.com", + 0, NULL, 0, KEY_WRITE, NULL, &hKey, &dwDisposition); + ok_long(error, ERROR_SUCCESS); + RegCloseKey(hKey); + + HRESULT hr = SHSetUnreadMailCountW(L"example.com", 1, L"MyMailerApp"); + ok_hex(hr, S_OK); + + error = RegOpenKeyExW(HKEY_CURRENT_USER, + L"Software\\Microsoft\\Windows\\CurrentVersion\\UnreadMail\\example.com", + 0, + KEY_READ, + &hKey); + ok_long(error, ERROR_SUCCESS); + + DWORD dwValue, cbValue = sizeof(dwValue); + error = RegQueryValueExW(hKey, L"MessageCount", NULL, NULL, (PBYTE)&dwValue, &cbValue); + ok_long(error, ERROR_SUCCESS); + ok_long(dwValue, 1); + + FILETIME FileTime; + cbValue = sizeof(FileTime); + error = RegQueryValueExW(hKey, L"TimeStamp", NULL, NULL, (PBYTE)&FileTime, &cbValue); + ok_long(error, ERROR_SUCCESS); + ok(FileTime.dwHighDateTime != 0, "FileTime.dwHighDateTime was zero\n"); + + WCHAR szValue[MAX_PATH]; + cbValue = sizeof(szValue); + error = RegQueryValueExW(hKey, L"Application", NULL, NULL, (PBYTE)szValue, &cbValue); + ok_long(error, ERROR_SUCCESS); + ok_wstr(szValue, L"MyMailerApp"); + + RegCloseKey(hKey); + + hr = SHSetUnreadMailCountW(L"example.com", 0, L"MyMailerApp"); + ok_hex(hr, S_OK); + + if (dwDisposition == REG_CREATED_NEW_KEY) + { + RegDeleteKeyW(HKEY_CURRENT_USER, + L"Software\\Microsoft\\Windows\\CurrentVersion\\UnreadMail\\example.com"); + } +} diff --git a/modules/rostests/apitests/shell32/testlist.c b/modules/rostests/apitests/shell32/testlist.c index 134f01a7838..d98d529c6fb 100644 --- a/modules/rostests/apitests/shell32/testlist.c +++ b/modules/rostests/apitests/shell32/testlist.c @@ -49,6 +49,7 @@ extern void func_SHParseDisplayName(void); extern void func_SHShouldShowWizards(void); extern void func_SHSimpleIDListFromPath(void); extern void func_SHRestricted(void); +extern void func_SHSetUnreadMailCountW(void); const struct test winetest_testlist[] = { @@ -98,6 +99,7 @@ const struct test winetest_testlist[] = { "SHShouldShowWizards", func_SHShouldShowWizards }, { "SHSimpleIDListFromPath", func_SHSimpleIDListFromPath }, { "SHRestricted", func_SHRestricted }, + { "SHSetUnreadMailCountW", func_SHSetUnreadMailCountW }, { 0, 0 } }; diff --git a/sdk/include/psdk/shellapi.h b/sdk/include/psdk/shellapi.h index 479d27d228d..eeda59cfcfb 100644 --- a/sdk/include/psdk/shellapi.h +++ b/sdk/include/psdk/shellapi.h @@ -638,6 +638,12 @@ DoEnvironmentSubstW( _Inout_updates_(cchSrc) LPWSTR pszSrc, UINT cchSrc); +HRESULT WINAPI +SHSetUnreadMailCountW( + _In_ PCWSTR pszMailAddress, + _In_ DWORD dwCount, + _In_ PCWSTR pszShellExecuteCommand); + #if (_WIN32_IE >= 0x0601) BOOL WINAPI

2 weeks, 3 days

[reactos] 08/08: [SPEC2DEF] Implement support for debug-only exports

by Timo Kreuzer

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=dc25409cbf4f90176b773… commit dc25409cbf4f90176b773af10849e94084130217 Author: Timo Kreuzer <timo.kreuzer(a)reactos.org> AuthorDate: Sat Nov 16 11:49:51 2024 +0200 Commit: Timo Kreuzer <timo.kreuzer(a)reactos.org> CommitDate: Sun Jan 19 09:02:58 2025 +0200 [SPEC2DEF] Implement support for debug-only exports --- sdk/cmake/gcc.cmake | 9 +++++++-- sdk/cmake/msvc.cmake | 9 +++++++-- sdk/tools/spec2def/spec2def.c | 13 +++++++++++++ 3 files changed, 27 insertions(+), 4 deletions(-) diff --git a/sdk/cmake/gcc.cmake b/sdk/cmake/gcc.cmake index 1c994e2c51d..1a233c22d47 100644 --- a/sdk/cmake/gcc.cmake +++ b/sdk/cmake/gcc.cmake @@ -373,11 +373,16 @@ function(fixup_load_config _target) DEPENDS native-pefixup) endfunction() +if(CMAKE_BUILD_TYPE STREQUAL "Debug" OR + CMAKE_BUILD_TYPE STREQUAL "RelWithDebInfo") + set(__spec2def_dbg_arg "--dbg") +endif() + function(generate_import_lib _libname _dllname _spec_file __version_arg) # Generate the def for the import lib add_custom_command( OUTPUT ${CMAKE_CURRENT_BINARY_DIR}/${_libname}_implib.def - COMMAND native-spec2def ${__version_arg} -n=${_dllname} -a=${ARCH2} ${ARGN} --implib -d=${CMAKE_CURRENT_BINARY_DIR}/${_libname}_implib.def ${CMAKE_CURRENT_SOURCE_DIR}/${_spec_file} + COMMAND native-spec2def ${__version_arg} ${__spec2def_dbg_arg} -n=${_dllname} -a=${ARCH2} ${ARGN} --implib -d=${CMAKE_CURRENT_BINARY_DIR}/${_libname}_implib.def ${CMAKE_CURRENT_SOURCE_DIR}/${_spec_file} DEPENDS ${CMAKE_CURRENT_SOURCE_DIR}/${_spec_file} native-spec2def) # With this, we let DLLTOOL create an import library @@ -450,7 +455,7 @@ function(spec2def _dllname _spec_file) # Generate exports def and C stubs file for the DLL add_custom_command( OUTPUT ${CMAKE_CURRENT_BINARY_DIR}/${_file}.def ${CMAKE_CURRENT_BINARY_DIR}/${_file}_stubs.c - COMMAND native-spec2def -n=${_dllname} -a=${ARCH2} -d=${CMAKE_CURRENT_BINARY_DIR}/${_file}.def -s=${CMAKE_CURRENT_BINARY_DIR}/${_file}_stubs.c ${__with_relay_arg} ${__version_arg} ${CMAKE_CURRENT_SOURCE_DIR}/${_spec_file} + COMMAND native-spec2def -n=${_dllname} -a=${ARCH2} -d=${CMAKE_CURRENT_BINARY_DIR}/${_file}.def -s=${CMAKE_CURRENT_BINARY_DIR}/${_file}_stubs.c ${__with_relay_arg} ${__version_arg} ${__spec2def_dbg_arg} ${CMAKE_CURRENT_SOURCE_DIR}/${_spec_file} DEPENDS ${CMAKE_CURRENT_SOURCE_DIR}/${_spec_file} native-spec2def) # Do not use precompiled headers for the stub file diff --git a/sdk/cmake/msvc.cmake b/sdk/cmake/msvc.cmake index 16f3d3ea159..f9e768bfa0f 100644 --- a/sdk/cmake/msvc.cmake +++ b/sdk/cmake/msvc.cmake @@ -332,6 +332,11 @@ function(fixup_load_config _target) # msvc knows how to generate a load_config so no hacks here endfunction() +if(CMAKE_BUILD_TYPE STREQUAL "Debug" OR + CMAKE_BUILD_TYPE STREQUAL "RelWithDebInfo") + set(__spec2def_dbg_arg "--dbg") +endif() + function(generate_import_lib _libname _dllname _spec_file __version_arg) set(_def_file ${CMAKE_CURRENT_BINARY_DIR}/${_libname}_implib.def) @@ -341,7 +346,7 @@ function(generate_import_lib _libname _dllname _spec_file __version_arg) # Generate the def, asm stub and alias files add_custom_command( OUTPUT ${_asm_stubs_file} ${_def_file} ${_asm_impalias_file} - COMMAND native-spec2def --ms ${__version_arg} -a=${SPEC2DEF_ARCH} --implib -n=${_dllname} -d=${_def_file} -l=${_asm_stubs_file} -i=${_asm_impalias_file} ${CMAKE_CURRENT_SOURCE_DIR}/${_spec_file} + COMMAND native-spec2def --ms ${__version_arg} ${__spec2def_dbg_arg} -a=${SPEC2DEF_ARCH} --implib -n=${_dllname} -d=${_def_file} -l=${_asm_stubs_file} -i=${_asm_impalias_file} ${CMAKE_CURRENT_SOURCE_DIR}/${_spec_file} DEPENDS ${CMAKE_CURRENT_SOURCE_DIR}/${_spec_file} native-spec2def) # Compile the generated asm stub file @@ -414,7 +419,7 @@ function(spec2def _dllname _spec_file) # Generate exports def and C stubs file for the DLL add_custom_command( OUTPUT ${CMAKE_CURRENT_BINARY_DIR}/${_file}.def ${CMAKE_CURRENT_BINARY_DIR}/${_file}_stubs.c - COMMAND native-spec2def --ms -a=${SPEC2DEF_ARCH} -n=${_dllname} -d=${CMAKE_CURRENT_BINARY_DIR}/${_file}.def -s=${CMAKE_CURRENT_BINARY_DIR}/${_file}_stubs.c ${__with_relay_arg} ${__version_arg} ${CMAKE_CURRENT_SOURCE_DIR}/${_spec_file} + COMMAND native-spec2def --ms -a=${SPEC2DEF_ARCH} -n=${_dllname} -d=${CMAKE_CURRENT_BINARY_DIR}/${_file}.def -s=${CMAKE_CURRENT_BINARY_DIR}/${_file}_stubs.c ${__with_relay_arg} ${__version_arg} ${__spec2def_dbg_arg} ${CMAKE_CURRENT_SOURCE_DIR}/${_spec_file} DEPENDS ${CMAKE_CURRENT_SOURCE_DIR}/${_spec_file} native-spec2def) # Do not use precompiled headers for the stub file diff --git a/sdk/tools/spec2def/spec2def.c b/sdk/tools/spec2def/spec2def.c index cd80dffafcc..df844ba9d55 100644 --- a/sdk/tools/spec2def/spec2def.c +++ b/sdk/tools/spec2def/spec2def.c @@ -67,6 +67,7 @@ int gbImportLib = 0; int gbNotPrivateNoWarn = 0; int gbTracing = 0; int giArch = ARCH_X86; +int gbDbgExports = 0; char *pszArchString = "i386"; char *pszArchString2; char *pszSourceFileName = NULL; @@ -1162,6 +1163,13 @@ ParseFile(char* pcStart, FILE *fileDest, unsigned *cExports) } while (*pc == ','); } + else if (CompareToken(pc, "-dbg")) + { + if (!gbDbgExports) + { + included = 0; + } + } else if (CompareToken(pc, "-private")) { exp.uFlags |= FL_PRIVATE; @@ -1505,6 +1513,7 @@ void usage(void) " -s=<file> generate a stub file\n" " -i=<file> generate an import alias file\n" " --ms MSVC compatibility\n" + " --dbg Enable debug exports\n" " -n=<name> name of the dll\n" " --version=<version> Sets the version to create exports for\n" " --implib generate a def file for an import library\n" @@ -1571,6 +1580,10 @@ int main(int argc, char *argv[]) { gbMSComp = 1; } + else if (strcasecmp(argv[i], "--dbg") == 0) + { + gbDbgExports = 1; + } else if (strcasecmp(argv[i], "--no-private-warnings") == 0) { gbNotPrivateNoWarn = 1;

2 weeks, 4 days

[reactos] 07/08: [NTDLL] Make _alloca_probe(_16) private

by Timo Kreuzer

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=93ba586ec3b345f252b65… commit 93ba586ec3b345f252b6578adf72810b966abf72 Author: Timo Kreuzer <timo.kreuzer(a)reactos.org> AuthorDate: Sat Dec 7 10:15:29 2024 +0200 Commit: Timo Kreuzer <timo.kreuzer(a)reactos.org> CommitDate: Sun Jan 19 09:02:58 2025 +0200 [NTDLL] Make _alloca_probe(_16) private This avoids a linker error due to a duplicated symbol in ntdll and the statically linked chkstk library. This happens when the linker first resolves _chkstk from the CRT or the chkstk library (which also pulls in _alloca_probe(_16)) and then tries to resolve _alloca_probe(_16) from ntdll. --- dll/ntdll/def/ntdll.spec | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dll/ntdll/def/ntdll.spec b/dll/ntdll/def/ntdll.spec index 62f374c05fb..de23297ea55 100644 --- a/dll/ntdll/def/ntdll.spec +++ b/dll/ntdll/def/ntdll.spec @@ -1767,8 +1767,8 @@ @ cdecl -arch=i386 -ret64 _alldiv(double double) @ cdecl -arch=i386 _alldvrm() @ cdecl -arch=i386 -ret64 _allmul(double double) -@ cdecl -arch=i386 -norelay _alloca_probe() -@ cdecl -version=0x600+ -arch=i386 _alloca_probe_16() +@ cdecl -arch=i386 -norelay -private _alloca_probe() +@ cdecl -version=0x600+ -arch=i386 -private _alloca_probe_16() @ stub -version=0x600+ -arch=i386 _alloca_probe_8 @ cdecl -arch=i386 -ret64 _allrem(double double) @ cdecl -arch=i386 _allshl()

2 weeks, 4 days

[reactos] 06/08: [EXPLORER-OLD] Fix build when _DEBUG is defined

by Timo Kreuzer

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=c2c4d853c2bd31a6abf7b… commit c2c4d853c2bd31a6abf7b5dc7b54814bae12a712 Author: Timo Kreuzer <timo.kreuzer(a)reactos.org> AuthorDate: Wed Dec 4 08:12:43 2024 +0200 Commit: Timo Kreuzer <timo.kreuzer(a)reactos.org> CommitDate: Sun Jan 19 09:02:58 2025 +0200 [EXPLORER-OLD] Fix build when _DEBUG is defined --- modules/rosapps/applications/explorer-old/shell/fatfs.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/modules/rosapps/applications/explorer-old/shell/fatfs.cpp b/modules/rosapps/applications/explorer-old/shell/fatfs.cpp index 5cd237280bf..fbfb3e832be 100644 --- a/modules/rosapps/applications/explorer-old/shell/fatfs.cpp +++ b/modules/rosapps/applications/explorer-old/shell/fatfs.cpp @@ -141,7 +141,7 @@ void FATDirectory::read_directory(int scan_flags) s = (const char*)p->Ent->B; // no change of the pointer, just to avoid overung warnings in code checkers // read long file name - TCHAR lname[] = {s[1], s[3], s[5], s[7], s[9], s[14], s[16], s[18], s[20], s[22], s[24], s[28], s[30]}; + char lname[] = {s[1], s[3], s[5], s[7], s[9], s[14], s[16], s[18], s[20], s[22], s[24], s[28], s[30]}; long_name = String(lname, 13) + long_name; } @@ -397,7 +397,7 @@ bool FATDirectory::read_dir() } } - buf->dat[0] = 0; // Endekennzeichen f�r Rekurs setzen + buf->dat[0] = 0; // Endekennzeichen für Rekurs setzen } return true;

2 weeks, 4 days

[reactos] 05/08: [BROWSEUI] Check if ATL windows are valid, before destroying them

by Timo Kreuzer

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=888540c2d3df1ee65adaa… commit 888540c2d3df1ee65adaa20dc5a8c04f12444689 Author: Timo Kreuzer <timo.kreuzer(a)reactos.org> AuthorDate: Wed Jan 15 17:02:41 2025 +0200 Commit: Timo Kreuzer <timo.kreuzer(a)reactos.org> CommitDate: Sun Jan 19 09:02:58 2025 +0200 [BROWSEUI] Check if ATL windows are valid, before destroying them Prevents ATL assertion failure. --- dll/win32/browseui/CAutoComplete.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/dll/win32/browseui/CAutoComplete.cpp b/dll/win32/browseui/CAutoComplete.cpp index e05c31b8b76..075654109b8 100644 --- a/dll/win32/browseui/CAutoComplete.cpp +++ b/dll/win32/browseui/CAutoComplete.cpp @@ -1584,9 +1584,9 @@ LRESULT CAutoComplete::OnNCDestroy(UINT uMsg, WPARAM wParam, LPARAM lParam, BOOL m_hwndSizeBox.m_pDropDown = NULL; // destroy controls - m_hwndList.DestroyWindow(); - m_hwndScrollBar.DestroyWindow(); - m_hwndSizeBox.DestroyWindow(); + if (m_hwndList) m_hwndList.DestroyWindow(); + if (m_hwndScrollBar) m_hwndScrollBar.DestroyWindow(); + if (m_hwndSizeBox) m_hwndSizeBox.DestroyWindow(); // clean up m_hwndCombo = NULL;

2 weeks, 4 days

← Newer
1
...
12
13
14
15
16
17
18
...
28
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs January 2025