Ros-diffs

ros-diffs@reactos.org

81390 discussions

[akhaldi] 71112: [DBGHELP] Stub dbghelp. CORE-2990
by akhaldi＠svn.reactos.org 07 Apr '16

07 Apr '16

Author: akhaldi Date: Thu Apr 7 13:58:19 2016 New Revision: 71112 URL: http://svn.reactos.org/svn/reactos?rev=71112&view=rev Log: [DBGHELP] Stub dbghelp. CORE-2990 Modified: trunk/reactos/dll/win32/dbghelp/dbghelp.spec Modified: trunk/reactos/dll/win32/dbghelp/dbghelp.spec URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/dbghelp/dbghelp.… ============================================================================== --- trunk/reactos/dll/win32/dbghelp/dbghelp.spec [iso-8859-1] (original) +++ trunk/reactos/dll/win32/dbghelp/dbghelp.spec [iso-8859-1] Thu Apr 7 13:58:19 2016 @@ -192,7 +192,7 @@ @ stdcall WinDbgExtensionDllInit(ptr long long) #@ stdcall block #@ stdcall chksym -#@ stdcall dbghelp +@ stdcall -stub dbghelp(ptr ptr) #@ stdcall dh #@ stdcall fptr #@ stdcall homedir

1 0

[tfaber] 71111: [NTOS:IO] - Do not leak ServiceName in IopInitializeBuiltinDriver CORE-11084 #resolve
by tfaber＠svn.reactos.org 06 Apr '16

06 Apr '16

Author: tfaber Date: Wed Apr 6 20:10:09 2016 New Revision: 71111 URL: http://svn.reactos.org/svn/reactos?rev=71111&view=rev Log: [NTOS:IO] - Do not leak ServiceName in IopInitializeBuiltinDriver CORE-11084 #resolve Modified: trunk/reactos/ntoskrnl/io/iomgr/driver.c Modified: trunk/reactos/ntoskrnl/io/iomgr/driver.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/io/iomgr/driver.c… ============================================================================== --- trunk/reactos/ntoskrnl/io/iomgr/driver.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/io/iomgr/driver.c [iso-8859-1] Wed Apr 6 20:10:09 2016 @@ -919,6 +919,7 @@ NULL, &ServiceName, &DeviceNode); + RtlFreeUnicodeString(&ServiceName); if (!NT_SUCCESS(Status)) { DPRINT1("Driver '%wZ' load failed, status (%x)\n", ModuleName, Status);

1 0

[tfaber] 71110: [NTOS:IO] - Get rid of some magic numbers
by tfaber＠svn.reactos.org 06 Apr '16

06 Apr '16

Author: tfaber Date: Wed Apr 6 20:02:38 2016 New Revision: 71110 URL: http://svn.reactos.org/svn/reactos?rev=71110&view=rev Log: [NTOS:IO] - Get rid of some magic numbers Modified: trunk/reactos/ntoskrnl/io/iomgr/driver.c Modified: trunk/reactos/ntoskrnl/io/iomgr/driver.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/io/iomgr/driver.c… ============================================================================== --- trunk/reactos/ntoskrnl/io/iomgr/driver.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/io/iomgr/driver.c [iso-8859-1] Wed Apr 6 20:02:38 2016 @@ -2001,8 +2001,8 @@ */ Status = IopGetDriverObject(DriverObject, &ServiceName, - (Type == 2 /* SERVICE_FILE_SYSTEM_DRIVER */ || - Type == 8 /* SERVICE_RECOGNIZER_DRIVER */)); + (Type == SERVICE_FILE_SYSTEM_DRIVER || + Type == SERVICE_RECOGNIZER_DRIVER)); if (!NT_SUCCESS(Status)) { @@ -2037,8 +2037,8 @@ Status = IopInitializeDriverModule(DeviceNode, ModuleObject, &DeviceNode->ServiceName, - (Type == 2 /* SERVICE_FILE_SYSTEM_DRIVER */ || - Type == 8 /* SERVICE_RECOGNIZER_DRIVER */), + (Type == SERVICE_FILE_SYSTEM_DRIVER || + Type == SERVICE_RECOGNIZER_DRIVER), DriverObject); if (!NT_SUCCESS(Status)) {

1 0

[tfaber] 71109: [NTOS:IO] - Handle RtlCreateUnicodeString failure in IopInitializeBuiltinDriver. Patch by Víctor Martínez Calvo. CID 1341416 CORE-11029 #resolve
by tfaber＠svn.reactos.org 06 Apr '16

06 Apr '16

Author: tfaber Date: Wed Apr 6 20:00:34 2016 New Revision: 71109 URL: http://svn.reactos.org/svn/reactos?rev=71109&view=rev Log: [NTOS:IO] - Handle RtlCreateUnicodeString failure in IopInitializeBuiltinDriver. Patch by Víctor Martínez Calvo. CID 1341416 CORE-11029 #resolve Modified: trunk/reactos/ntoskrnl/io/iomgr/driver.c Modified: trunk/reactos/ntoskrnl/io/iomgr/driver.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/io/iomgr/driver.c… ============================================================================== --- trunk/reactos/ntoskrnl/io/iomgr/driver.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/io/iomgr/driver.c [iso-8859-1] Wed Apr 6 20:00:34 2016 @@ -874,6 +874,7 @@ PLDR_DATA_TABLE_ENTRY LdrEntry; PLIST_ENTRY NextEntry; UNICODE_STRING ServiceName; + BOOLEAN Success; /* * Display 'Loading XXX...' message @@ -897,7 +898,12 @@ /* * Strip the file extension from ServiceName */ - RtlCreateUnicodeString(&ServiceName, FileNameWithoutPath); + Success = RtlCreateUnicodeString(&ServiceName, FileNameWithoutPath); + if (!Success) + { + return STATUS_INSUFFICIENT_RESOURCES; + } + FileExtension = wcsrchr(ServiceName.Buffer, '.'); if (FileExtension != NULL) {

1 0

[tfaber] 71108: [NTDLL_APITEST] - Add missing va_end. Patch by Víctor Martínez Calvo. ROSTESTS-202 #resolve
by tfaber＠svn.reactos.org 06 Apr '16

06 Apr '16

Author: tfaber Date: Wed Apr 6 19:31:20 2016 New Revision: 71108 URL: http://svn.reactos.org/svn/reactos?rev=71108&view=rev Log: [NTDLL_APITEST] - Add missing va_end. Patch by Víctor Martínez Calvo. ROSTESTS-202 #resolve Modified: trunk/rostests/apitests/ntdll/sprintf.c Modified: trunk/rostests/apitests/ntdll/sprintf.c URL: http://svn.reactos.org/svn/reactos/trunk/rostests/apitests/ntdll/sprintf.c?… ============================================================================== --- trunk/rostests/apitests/ntdll/sprintf.c [iso-8859-1] (original) +++ trunk/rostests/apitests/ntdll/sprintf.c [iso-8859-1] Wed Apr 6 19:31:20 2016 @@ -29,9 +29,13 @@ { const TCHAR * fmt = format; va_list argptr; + int ret; va_start(argptr, format); - return p_vsprintf(buf, fmt, argptr); + ret = p_vsprintf(buf, fmt, argptr); + va_end(argptr); + + return ret; } int @@ -39,9 +43,13 @@ { const wchar_t * fmt = format; va_list argptr; + int ret; va_start(argptr, format); - return _vsnwprintf(buf, MAXLONG, fmt, argptr); + ret = _vsnwprintf(buf, MAXLONG, fmt, argptr); + va_end(argptr); + + return ret; } #define sprintf(buf, format, ...) my_sprintf(buf, format, __VA_ARGS__);

1 0

[tfaber] 71107: [CRT_APITEST] - Add missing va_end. Patch by Víctor Martínez Calvo. ROSTESTS-221 #resolve
by tfaber＠svn.reactos.org 06 Apr '16

06 Apr '16

Author: tfaber Date: Wed Apr 6 12:34:26 2016 New Revision: 71107 URL: http://svn.reactos.org/svn/reactos?rev=71107&view=rev Log: [CRT_APITEST] - Add missing va_end. Patch by Víctor Martínez Calvo. ROSTESTS-221 #resolve Modified: trunk/rostests/apitests/crt/_vscprintf.c trunk/rostests/apitests/crt/_vscwprintf.c trunk/rostests/apitests/crt/_vsnprintf.c trunk/rostests/apitests/crt/_vsnwprintf.c Modified: trunk/rostests/apitests/crt/_vscprintf.c URL: http://svn.reactos.org/svn/reactos/trunk/rostests/apitests/crt/_vscprintf.c… ============================================================================== --- trunk/rostests/apitests/crt/_vscprintf.c [iso-8859-1] (original) +++ trunk/rostests/apitests/crt/_vscprintf.c [iso-8859-1] Wed Apr 6 12:34:26 2016 @@ -17,6 +17,7 @@ /* Test the basic functionality */ va_start(args, formatString); ret = _vscprintf(formatString, args); + va_end(args); ok(expected_ret == ret, "Test failed: expected %i, got %i.\n", expected_ret, ret); } Modified: trunk/rostests/apitests/crt/_vscwprintf.c URL: http://svn.reactos.org/svn/reactos/trunk/rostests/apitests/crt/_vscwprintf.… ============================================================================== --- trunk/rostests/apitests/crt/_vscwprintf.c [iso-8859-1] (original) +++ trunk/rostests/apitests/crt/_vscwprintf.c [iso-8859-1] Wed Apr 6 12:34:26 2016 @@ -17,6 +17,7 @@ /* Test the basic functionality */ va_start(args, formatString); ret = _vscwprintf(formatString, args); + va_end(args); ok(expected_ret == ret, "expected %i, got %i.\n", expected_ret, ret); } Modified: trunk/rostests/apitests/crt/_vsnprintf.c URL: http://svn.reactos.org/svn/reactos/trunk/rostests/apitests/crt/_vsnprintf.c… ============================================================================== --- trunk/rostests/apitests/crt/_vsnprintf.c [iso-8859-1] (original) +++ trunk/rostests/apitests/crt/_vsnprintf.c [iso-8859-1] Wed Apr 6 12:34:26 2016 @@ -20,6 +20,7 @@ /* Test the basic functionality */ va_start(args, formatString); ret = _vsnprintf(buf, buf_size, formatString, args); + va_end(args); ok(expected_ret == ret, "Test failed: expected %i, got %i.\n", expected_ret, ret); } Modified: trunk/rostests/apitests/crt/_vsnwprintf.c URL: http://svn.reactos.org/svn/reactos/trunk/rostests/apitests/crt/_vsnwprintf.… ============================================================================== --- trunk/rostests/apitests/crt/_vsnwprintf.c [iso-8859-1] (original) +++ trunk/rostests/apitests/crt/_vsnwprintf.c [iso-8859-1] Wed Apr 6 12:34:26 2016 @@ -20,6 +20,7 @@ /* Test the basic functionality */ va_start(args, formatString); ret = _vsnwprintf(buf, buf_size, formatString, args); + va_end(args); ok(expected_ret == ret, "Test failed: expected %i, got %i.\n", expected_ret, ret); }

1 0

[tfaber] 71106: [BOOTLIB] - Fix uninitialized variable in MmFwGetMemoryMap. Patch by Víctor Martínez Calvo. CID 1341421 CORE-11026 #resolve
by tfaber＠svn.reactos.org 06 Apr '16

06 Apr '16

Author: tfaber Date: Wed Apr 6 12:30:06 2016 New Revision: 71106 URL: http://svn.reactos.org/svn/reactos?rev=71106&view=rev Log: [BOOTLIB] - Fix uninitialized variable in MmFwGetMemoryMap. Patch by Víctor Martínez Calvo. CID 1341421 CORE-11026 #resolve Modified: trunk/reactos/boot/environ/lib/firmware/efi/firmware.c Modified: trunk/reactos/boot/environ/lib/firmware/efi/firmware.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/environ/lib/firmware/… ============================================================================== --- trunk/reactos/boot/environ/lib/firmware/efi/firmware.c [iso-8859-1] (original) +++ trunk/reactos/boot/environ/lib/firmware/efi/firmware.c [iso-8859-1] Wed Apr 6 12:30:06 2016 @@ -1365,7 +1365,7 @@ NTSTATUS Status; ULONGLONG Pages, StartPage, EndPage; UINTN EfiMemoryMapSize, MapKey, DescriptorSize, DescriptorVersion; - EFI_PHYSICAL_ADDRESS EfiBuffer; + EFI_PHYSICAL_ADDRESS EfiBuffer = 0; EFI_MEMORY_DESCRIPTOR* EfiMemoryMap; EFI_STATUS EfiStatus; BL_ARCH_MODE OldMode;

1 0

[tfaber] 71105: [NDIS] - Print status code in case MiniportInitialize fails CORE-11073
by tfaber＠svn.reactos.org 06 Apr '16

06 Apr '16

Author: tfaber Date: Wed Apr 6 12:14:28 2016 New Revision: 71105 URL: http://svn.reactos.org/svn/reactos?rev=71105&view=rev Log: [NDIS] - Print status code in case MiniportInitialize fails CORE-11073 Modified: trunk/reactos/drivers/network/ndis/ndis/miniport.c Modified: trunk/reactos/drivers/network/ndis/ndis/miniport.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/network/ndis/ndis/… ============================================================================== --- trunk/reactos/drivers/network/ndis/ndis/miniport.c [iso-8859-1] (original) +++ trunk/reactos/drivers/network/ndis/ndis/miniport.c [iso-8859-1] Wed Apr 6 12:14:28 2016 @@ -2100,7 +2100,7 @@ if (NdisStatus != NDIS_STATUS_SUCCESS) { - NDIS_DbgPrint(MIN_TRACE, ("MiniportInitialize() failed for an adapter.\n")); + NDIS_DbgPrint(MIN_TRACE, ("MiniportInitialize() failed for an adapter (%lx).\n", NdisStatus)); ExInterlockedRemoveEntryList( &Adapter->ListEntry, &AdapterListLock ); if (Adapter->NdisMiniportBlock.Interrupt) {

1 0

[ekohl] 71104: [CHARMAP] Statusbar character descriptions. Patch by Baruch Rutman. CORE-7386 #resolve #comment Thanks a lot!
by ekohl＠svn.reactos.org 05 Apr '16

05 Apr '16

Author: ekohl Date: Tue Apr 5 20:29:48 2016 New Revision: 71104 URL: http://svn.reactos.org/svn/reactos?rev=71104&view=rev Log: [CHARMAP] Statusbar character descriptions. Patch by Baruch Rutman. CORE-7386 #resolve #comment Thanks a lot! Modified: trunk/reactos/base/applications/charmap/charmap.c trunk/reactos/base/applications/charmap/lrgcell.c trunk/reactos/base/applications/charmap/precomp.h Modified: trunk/reactos/base/applications/charmap/charmap.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/charmap/… ============================================================================== --- trunk/reactos/base/applications/charmap/charmap.c [iso-8859-1] (original) +++ trunk/reactos/base/applications/charmap/charmap.c [iso-8859-1] Tue Apr 5 20:29:48 2016 @@ -24,6 +24,10 @@ HICON hBgIcon; SETTINGS Settings; +/* GetUName prototype */ +typedef int (WINAPI * GETUNAME)(WORD wCharCode, LPWSTR lpbuf); +GETUNAME GetUName; + /* Font-enumeration callback */ static int @@ -256,6 +260,20 @@ } } #endif + +VOID +UpdateStatusBar(WCHAR wch) +{ + WCHAR buff[MAX_PATH]; + WCHAR szDesc[MAX_PATH]; + + if (GetUName) + { + GetUName(wch, szDesc); + wsprintfW(buff, L"U+%04X: %s", wch, szDesc); + SendMessageW(hStatusWnd, SB_SETTEXT, 0, (LPARAM)buff); + } +} static void @@ -571,12 +589,25 @@ INT Ret = 1; HMODULE hRichEd20; MSG Msg; + HINSTANCE hGetUName = NULL; hInstance = hInst; iccx.dwSize = sizeof(INITCOMMONCONTROLSEX); iccx.dwICC = ICC_TAB_CLASSES; InitCommonControlsEx(&iccx); + + /* Loading the GetUName function */ + hGetUName = LoadLibraryW(L"getuname.dll"); + if (hGetUName != NULL) + { + GetUName = (GETUNAME) GetProcAddress(hGetUName, "GetUName"); + if (GetUName == NULL) + { + FreeLibrary(hGetUName); + hGetUName = NULL; + } + } if (RegisterMapClasses(hInstance)) { @@ -603,5 +634,8 @@ UnregisterMapClasses(hInstance); } + if (hGetUName != NULL) + FreeLibrary(hGetUName); + return Ret; } Modified: trunk/reactos/base/applications/charmap/lrgcell.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/charmap/… ============================================================================== --- trunk/reactos/base/applications/charmap/lrgcell.c [iso-8859-1] (original) +++ trunk/reactos/base/applications/charmap/lrgcell.c [iso-8859-1] Tue Apr 5 20:29:48 2016 @@ -140,6 +140,7 @@ EndPaint(hwnd, &ps); + UpdateStatusBar(infoPtr->pActiveCell->ch); break; } Modified: trunk/reactos/base/applications/charmap/precomp.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/charmap/… ============================================================================== --- trunk/reactos/base/applications/charmap/precomp.h [iso-8859-1] (original) +++ trunk/reactos/base/applications/charmap/precomp.h [iso-8859-1] Tue Apr 5 20:29:48 2016 @@ -74,6 +74,7 @@ VOID UnregisterMapClasses(HINSTANCE hInstance); /* charmap.c */ +VOID UpdateStatusBar(WCHAR wch); extern VOID ChangeMapFont(HWND hDlg); /* settings.c */

1 0

[rnaumann] 71103: [WELCOME] Fix the blurry header bitmap. By Henry Tang Ih. CORE-10712
by rnaumann＠svn.reactos.org 05 Apr '16

05 Apr '16

Author: rnaumann Date: Tue Apr 5 19:29:56 2016 New Revision: 71103 URL: http://svn.reactos.org/svn/reactos?rev=71103&view=rev Log: [WELCOME] Fix the blurry header bitmap. By Henry Tang Ih. CORE-10712 Modified: trunk/reactos/base/setup/welcome/res/title.bmp Modified: trunk/reactos/base/setup/welcome/res/title.bmp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/setup/welcome/res/tit… ============================================================================== Binary files - no diff available.

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs