Ros-diffs

ros-diffs@reactos.org

81390 discussions

[pschweitzer] 69661: [MSVCRT] Add a test that shows that _splitpath() null-terminates drive
by pschweitzer＠svn.reactos.org 24 Oct '15

24 Oct '15

Author: pschweitzer Date: Sat Oct 24 08:20:05 2015 New Revision: 69661 URL: http://svn.reactos.org/svn/reactos?rev=69661&view=rev Log: [MSVCRT] Add a test that shows that _splitpath() null-terminates drive Modified: trunk/rostests/apitests/msvcrt/splitpath.c Modified: trunk/rostests/apitests/msvcrt/splitpath.c URL: http://svn.reactos.org/svn/reactos/trunk/rostests/apitests/msvcrt/splitpath… ============================================================================== --- trunk/rostests/apitests/msvcrt/splitpath.c [iso-8859-1] (original) +++ trunk/rostests/apitests/msvcrt/splitpath.c [iso-8859-1] Sat Oct 24 08:20:05 2015 @@ -22,11 +22,13 @@ Major = (DWORD)(LOBYTE(LOWORD(GetVersion()))); + drive[2] = 0xFF; _splitpath("c:\\dir1\\dir2\\file.ext", drive, dir, fname, ext); ok_str(drive, "c:"); ok_str(dir, "\\dir1\\dir2\\"); ok_str(fname, "file"); ok_str(ext, ".ext"); + ok_int(drive[2], 0); *_errno() = 0; _splitpath("c:\\dir1\\dir2\\file.ext", 0, 0, 0, 0);

1 0

[pschweitzer] 69660: [CONSOLE] Don't overrun two buffers CID 1322100, 1237057
by pschweitzer＠svn.reactos.org 24 Oct '15

24 Oct '15

Author: pschweitzer Date: Sat Oct 24 07:59:52 2015 New Revision: 69660 URL: http://svn.reactos.org/svn/reactos?rev=69660&view=rev Log: [CONSOLE] Don't overrun two buffers CID 1322100, 1237057 Modified: trunk/reactos/dll/cpl/console/font.c Modified: trunk/reactos/dll/cpl/console/font.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/cpl/console/font.c?rev… ============================================================================== --- trunk/reactos/dll/cpl/console/font.c [iso-8859-1] (original) +++ trunk/reactos/dll/cpl/console/font.c [iso-8859-1] Sat Oct 24 07:59:52 2015 @@ -305,7 +305,7 @@ LB_GETTEXT, nSel, (LPARAM)FaceName); FaceName[Length] = '\0'; - Length = min(Length/*wcslen(FaceName) + 1*/, LF_FACESIZE); // wcsnlen + Length = min(Length/*wcslen(FaceName) + 1*/, LF_FACESIZE - 1); // wcsnlen wcsncpy(pConInfo->FaceName, FaceName, LF_FACESIZE); pConInfo->FaceName[Length] = L'\0'; DPRINT1("pConInfo->FaceName = '%S'\n", pConInfo->FaceName);

1 0

[gedmurphy] 69659: [DEVMGR] - Force all refreshes to go through the CDeviceManager method instead of calling CDeviceView directly. - Fixes missing checked radio item in the view menu on startup
by gedmurphy＠svn.reactos.org 23 Oct '15

23 Oct '15

Author: gedmurphy Date: Fri Oct 23 13:16:25 2015 New Revision: 69659 URL: http://svn.reactos.org/svn/reactos?rev=69659&view=rev Log: [DEVMGR] - Force all refreshes to go through the CDeviceManager method instead of calling CDeviceView directly. - Fixes missing checked radio item in the view menu on startup Modified: trunk/reactos/dll/win32/devmgr/devmgmt/DeviceView.cpp trunk/reactos/dll/win32/devmgr/devmgmt/DeviceView.h trunk/reactos/dll/win32/devmgr/devmgmt/MainWindow.cpp trunk/reactos/dll/win32/devmgr/devmgmt/MainWindow.h Modified: trunk/reactos/dll/win32/devmgr/devmgmt/DeviceView.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/devmgr/devmgmt/D… ============================================================================== --- trunk/reactos/dll/win32/devmgr/devmgmt/DeviceView.cpp [iso-8859-1] (original) +++ trunk/reactos/dll/win32/devmgr/devmgmt/DeviceView.cpp [iso-8859-1] Fri Oct 23 13:16:25 2015 @@ -188,8 +188,7 @@ CDeviceView::Refresh( _In_ ViewType Type, _In_ bool ScanForChanges, - _In_ bool UpdateView, - _In_opt_ LPWSTR DeviceId + _In_ bool UpdateView ) { // Enum devices on a seperate thread to keep the gui responsive @@ -230,8 +229,7 @@ { Refresh(GetCurrentView(), true, - true, - NULL); + true); break; } Modified: trunk/reactos/dll/win32/devmgr/devmgmt/DeviceView.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/devmgr/devmgmt/D… ============================================================================== --- trunk/reactos/dll/win32/devmgr/devmgmt/DeviceView.h [iso-8859-1] (original) +++ trunk/reactos/dll/win32/devmgr/devmgmt/DeviceView.h [iso-8859-1] Fri Oct 23 13:16:25 2015 @@ -60,8 +60,7 @@ VOID Refresh( _In_ ViewType Type, _In_ bool ScanForChanges, - _In_ bool UpdateView, - _In_opt_ LPWSTR DeviceId + _In_ bool UpdateView ); VOID DisplayPropertySheet(); Modified: trunk/reactos/dll/win32/devmgr/devmgmt/MainWindow.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/devmgr/devmgmt/M… ============================================================================== --- trunk/reactos/dll/win32/devmgr/devmgmt/MainWindow.cpp [iso-8859-1] (original) +++ trunk/reactos/dll/win32/devmgr/devmgmt/MainWindow.cpp [iso-8859-1] Fri Oct 23 13:16:25 2015 @@ -245,12 +245,13 @@ } bool -CDeviceManager::RefreshView(_In_ ViewType Type) +CDeviceManager::RefreshView(_In_ ViewType Type, + _In_ bool ScanForChanges) { UINT CheckId = 0; // Refreshed the cached view - m_DeviceView->Refresh(Type, FALSE, TRUE, NULL); + m_DeviceView->Refresh(Type, ScanForChanges, true); // Get the menu item id switch (Type) @@ -437,10 +438,7 @@ if (m_DeviceView->Initialize()) { // Do the initial scan - m_DeviceView->Refresh(m_DeviceView->GetCurrentView(), - true, - true, - NULL); + RefreshView(m_DeviceView->GetCurrentView(), true); // Display the window according to the user request ShowWindow(hwnd, m_CmdShow); @@ -608,13 +606,13 @@ case IDC_DEVBYTYPE: { - RefreshView(DevicesByType); + RefreshView(DevicesByType, false); break; } case IDC_DEVBYCONN: { - RefreshView(DevicesByConnection); + RefreshView(DevicesByConnection, false); break; } @@ -633,10 +631,7 @@ CheckMenuItem(m_hMenu, IDC_SHOWHIDDEN, MF_BYCOMMAND | MF_CHECKED); } // Refresh the device view - m_DeviceView->Refresh(m_DeviceView->GetCurrentView(), - false, - true, - NULL); + RefreshView(m_DeviceView->GetCurrentView(), false); break; } @@ -798,10 +793,7 @@ if (wParam == REFRESH_TIMER) { // Schedule a refresh (this just creates a thread and returns) - This->m_DeviceView->Refresh(This->m_DeviceView->GetCurrentView(), - true, - true, - NULL); + This->RefreshView(This->m_DeviceView->GetCurrentView(), true); // Cleanup the timer KillTimer(hwnd, REFRESH_TIMER); Modified: trunk/reactos/dll/win32/devmgr/devmgmt/MainWindow.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/devmgr/devmgmt/M… ============================================================================== --- trunk/reactos/dll/win32/devmgr/devmgmt/MainWindow.h [iso-8859-1] (original) +++ trunk/reactos/dll/win32/devmgr/devmgmt/MainWindow.h [iso-8859-1] Fri Oct 23 13:16:25 2015 @@ -90,7 +90,8 @@ ); bool RefreshView( - _In_ ViewType Type + _In_ ViewType Type, + _In_ bool ScanForChanges ); };

1 0

[gedmurphy] 69658: [DEVMGR] - When refreshing the view, reselect and expand the previously selected node in the tree. This allows to switch from 'by type' to 'by connection' and see where the selec...
by gedmurphy＠svn.reactos.org 23 Oct '15

23 Oct '15

Author: gedmurphy Date: Fri Oct 23 12:45:41 2015 New Revision: 69658 URL: http://svn.reactos.org/svn/reactos?rev=69658&view=rev Log: [DEVMGR] - When refreshing the view, reselect and expand the previously selected node in the tree. This allows to switch from 'by type' to 'by connection' and see where the selected device sits in the tree hierarchy (and vice versa) Modified: trunk/reactos/dll/win32/devmgr/devmgmt/DeviceNode.cpp trunk/reactos/dll/win32/devmgr/devmgmt/DeviceNode.h trunk/reactos/dll/win32/devmgr/devmgmt/DeviceView.cpp trunk/reactos/dll/win32/devmgr/devmgmt/DeviceView.h trunk/reactos/dll/win32/devmgr/devmgmt/Node.cpp trunk/reactos/dll/win32/devmgr/devmgmt/Node.h Modified: trunk/reactos/dll/win32/devmgr/devmgmt/DeviceNode.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/devmgr/devmgmt/D… ============================================================================== --- trunk/reactos/dll/win32/devmgr/devmgmt/DeviceNode.cpp [iso-8859-1] (original) +++ trunk/reactos/dll/win32/devmgr/devmgmt/DeviceNode.cpp [iso-8859-1] Fri Oct 23 12:45:41 2015 @@ -26,6 +26,24 @@ ZeroMemory(&m_DevinfoData, sizeof(SP_DEVINFO_DATA)); } +CDeviceNode::CDeviceNode( + _In_ const CDeviceNode &Node + ) : + CNode(Node) +{ + m_DevInst = Node.m_DevInst; + m_hDevInfo = Node.m_hDevInfo; + m_Status = Node.m_Status; + m_ProblemNumber = Node.m_ProblemNumber; + m_OverlayImage = Node.m_OverlayImage; + CopyMemory(&m_DevinfoData, &Node.m_DevinfoData, sizeof(SP_DEVINFO_DATA)); + + size_t size = wcslen(Node.m_DeviceId) + 1; + m_DeviceId = new WCHAR[size]; + StringCbCopyW(m_DeviceId, size * sizeof(WCHAR), Node.m_DeviceId); + +} + CDeviceNode::~CDeviceNode() { Cleanup(); @@ -290,7 +308,7 @@ for (int i = 0; i < 2; i++) { // Check globally first, then check config specific - pcp.Scope = (i == 0) ? DICS_FLAG_GLOBAL : DICS_FLAG_CONFIGSPECIFIC; + pcp.Scope = (i == 0) ? DICS_FLAG_CONFIGGENERAL : DICS_FLAG_CONFIGSPECIFIC; if (SetupDiSetClassInstallParamsW(m_hDevInfo, &m_DevinfoData, @@ -319,6 +337,7 @@ { SetupDiChangeState(m_hDevInfo, &m_DevinfoData); } + if (Enable) { Modified: trunk/reactos/dll/win32/devmgr/devmgmt/DeviceNode.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/devmgr/devmgmt/D… ============================================================================== --- trunk/reactos/dll/win32/devmgr/devmgmt/DeviceNode.h [iso-8859-1] (original) +++ trunk/reactos/dll/win32/devmgr/devmgmt/DeviceNode.h [iso-8859-1] Fri Oct 23 12:45:41 2015 @@ -19,6 +19,10 @@ ); ~CDeviceNode(); + + CDeviceNode( + _In_ const CDeviceNode &Node + ); virtual bool SetupNode(); Modified: trunk/reactos/dll/win32/devmgr/devmgmt/DeviceView.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/devmgr/devmgmt/D… ============================================================================== --- trunk/reactos/dll/win32/devmgr/devmgmt/DeviceView.cpp [iso-8859-1] (original) +++ trunk/reactos/dll/win32/devmgr/devmgmt/DeviceView.cpp [iso-8859-1] Fri Oct 23 12:45:41 2015 @@ -27,7 +27,6 @@ CDeviceView *This; BOOL ScanForChanges; BOOL UpdateView; - LPWSTR DeviceId; }; @@ -79,6 +78,10 @@ // Give the treeview arrows instead of +/- boxes (on Win7) SetWindowTheme(m_hTreeView, L"explorer", NULL); + + // Create the root node + m_RootNode = new CRootNode(&m_ImageListData); + m_RootNode->SetupNode(); } @@ -198,15 +201,6 @@ ThreadData->This = this; ThreadData->ScanForChanges = ScanForChanges; ThreadData->UpdateView = UpdateView; - ThreadData->DeviceId = NULL; - - if (DeviceId) - { - // Node gets deleted on refresh so we copy it to another block - size_t Length = wcslen(DeviceId) + 1; - ThreadData->DeviceId = new WCHAR[Length]; - StringCbCopyW(ThreadData->DeviceId, Length, DeviceId); - } HANDLE hThread; @@ -377,13 +371,29 @@ RefreshThreadData *ThreadData = (RefreshThreadData *)Param; CDeviceView *This = ThreadData->This; + // Get a copy of the currently selected node + CNode *LastSelectedNode = This->GetSelectedNode(); + if (LastSelectedNode == nullptr || (LastSelectedNode->GetNodeType() == RootNode)) + { + LastSelectedNode = new CRootNode(*This->m_RootNode); + } + else if (LastSelectedNode->GetNodeType() == ClassNode) + { + LastSelectedNode = new CClassNode(*dynamic_cast<CClassNode *>(LastSelectedNode)); + } + else if (LastSelectedNode->GetNodeType() == DeviceNode) + { + LastSelectedNode = new CDeviceNode(*dynamic_cast<CDeviceNode *>(LastSelectedNode)); + } // Empty the treeview This->EmptyDeviceView(); - This->m_hTreeRoot = NULL; - - // Refresh the devices only if requested. This means - // switching views uses the cache and remains fast + + // Re-add the root node to the tree + if (This->AddRootDevice() == false) + return 0; + + // Refresh the devices only if requested if (ThreadData->ScanForChanges) { This->RefreshDeviceList(); @@ -408,10 +418,8 @@ } - This->SelectNode(ThreadData->DeviceId); - - if (ThreadData->DeviceId) - delete[] ThreadData->DeviceId; + This->SelectNode(LastSelectedNode); + delete ThreadData; return 0; @@ -428,10 +436,6 @@ GUID ClassGuid; INT ClassIndex; BOOL bClassSuccess, bSuccess; - - // Start by adding the root node to the tree - bSuccess = AddRootDevice(); - if (bSuccess == false) return false; ClassIndex = 0; do @@ -564,12 +568,6 @@ bool CDeviceView::ListDevicesByConnection() { - bool bSuccess; - - // Start by adding the root node to the tree - bSuccess = AddRootDevice(); - if (bSuccess == false) return false; - // Walk the device tree and add all the devices (void)RecurseChildDevices(m_RootNode->GetDeviceInst(), m_hTreeRoot); @@ -928,13 +926,13 @@ HTREEITEM CDeviceView::RecurseFindDevice( _In_ HTREEITEM hParentItem, - _In_ LPWSTR DeviceId + _In_ CNode *Node ) { HTREEITEM FoundItem; HTREEITEM hItem; TVITEMW tvItem; - CNode *Node; + CNode *FoundNode; // Check if this node has any children hItem = TreeView_GetChild(m_hTreeView, hParentItem); @@ -946,17 +944,22 @@ if (TreeView_GetItem(m_hTreeView, &tvItem) && tvItem.lParam != NULL) { - // check for a matching deviceid - Node = reinterpret_cast<CNode *>(tvItem.lParam); - if (Node->GetDeviceId() && - (wcscmp(Node->GetDeviceId(), DeviceId) == 0)) - { - return hItem; + // check for a matching node + FoundNode = reinterpret_cast<CNode *>(tvItem.lParam); + if ((FoundNode->GetNodeType() == Node->GetNodeType()) && + (IsEqualGUID(*FoundNode->GetClassGuid(), *Node->GetClassGuid()))) + { + // check if this is a class node, or a device with matching ID's + if ((FoundNode->GetNodeType() == ClassNode) || + (wcscmp(FoundNode->GetDeviceId(), Node->GetDeviceId()) == 0)) + { + return hItem; + } } } // This node may have its own children - FoundItem = RecurseFindDevice(hItem, DeviceId); + FoundItem = RecurseFindDevice(hItem, Node); if (FoundItem) return FoundItem; // Loop all the siblings @@ -971,17 +974,22 @@ tvItem.mask = TVIF_PARAM; if (TreeView_GetItem(m_hTreeView, &tvItem)) { - // check for a matching deviceid - Node = reinterpret_cast<CNode *>(tvItem.lParam); - if (Node->GetDeviceId() && - wcscmp(Node->GetDeviceId(), DeviceId) == 0) + // check for a matching class + FoundNode = reinterpret_cast<CNode *>(tvItem.lParam); + if ((FoundNode->GetNodeType() == Node->GetNodeType()) && + (IsEqualGUID(*FoundNode->GetClassGuid(), *Node->GetClassGuid()))) { - return hItem; + // check if this is a class node, or a device with matching ID's + if ((FoundNode->GetNodeType() == ClassNode) || + (wcscmp(FoundNode->GetDeviceId(), Node->GetDeviceId()) == 0)) + { + return hItem; + } } } // This node may have its own children - FoundItem = RecurseFindDevice(hItem, DeviceId); + FoundItem = RecurseFindDevice(hItem, Node); if (FoundItem) return FoundItem; } @@ -990,7 +998,7 @@ void CDeviceView::SelectNode( - _In_ LPWSTR DeviceId + _In_ CNode *Node ) { HTREEITEM hRoot, hItem; @@ -1000,18 +1008,17 @@ if (hRoot == NULL) return; // If we don't want to set select a node, just select root - if (DeviceId == NULL) + if (Node == nullptr || Node->GetNodeType() == RootNode) { TreeView_SelectItem(m_hTreeView, hRoot); return; } // Scan the tree looking for the node we want - hItem = RecurseFindDevice(hRoot, DeviceId); + hItem = RecurseFindDevice(hRoot, Node); if (hItem) { TreeView_SelectItem(m_hTreeView, hItem); - TreeView_Expand(m_hTreeView, hItem, TVM_EXPAND); } else { @@ -1033,7 +1040,7 @@ ) { POSITION Pos; - CClassNode *Node; + CClassNode *Node = nullptr; Pos = m_ClassNodeList.GetHeadPosition(); if (Pos == NULL) return nullptr; @@ -1047,7 +1054,7 @@ break; } - Node = NULL; + Node = nullptr; } while (Pos != NULL); @@ -1060,7 +1067,7 @@ ) { POSITION Pos; - CDeviceNode *Node; + CDeviceNode *Node = nullptr; Pos = m_DeviceNodeList.GetHeadPosition(); if (Pos == NULL) return nullptr; @@ -1074,7 +1081,7 @@ break; } - Node = NULL; + Node = nullptr; } while (Pos != NULL); @@ -1090,7 +1097,7 @@ { return (CNode *)TvItem->lParam; } - return NULL; + return nullptr; } void Modified: trunk/reactos/dll/win32/devmgr/devmgmt/DeviceView.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/devmgr/devmgmt/D… ============================================================================== --- trunk/reactos/dll/win32/devmgr/devmgmt/DeviceView.h [iso-8859-1] (original) +++ trunk/reactos/dll/win32/devmgr/devmgmt/DeviceView.h [iso-8859-1] Fri Oct 23 12:45:41 2015 @@ -148,11 +148,11 @@ HTREEITEM RecurseFindDevice( _In_ HTREEITEM hParentItem, - _In_ LPWSTR DeviceId + _In_ CNode *Node ); void SelectNode( - _In_ LPWSTR DeviceId + _In_ CNode *Node ); void EmptyDeviceView( Modified: trunk/reactos/dll/win32/devmgr/devmgmt/Node.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/devmgr/devmgmt/N… ============================================================================== --- trunk/reactos/dll/win32/devmgr/devmgmt/Node.cpp [iso-8859-1] (original) +++ trunk/reactos/dll/win32/devmgr/devmgmt/Node.cpp [iso-8859-1] Fri Oct 23 12:45:41 2015 @@ -25,6 +25,17 @@ m_ClassGuid = GUID_NULL; } +CNode::CNode(const CNode &Node) +{ + m_NodeType = Node.m_NodeType; + m_ImageListData = Node.m_ImageListData; + m_DeviceId = Node.m_DeviceId; + m_ClassImage = Node.m_ClassImage; + + StringCbCopyW(m_DisplayName, DISPLAY_NAME_LEN, Node.m_DisplayName); + CopyMemory(&m_ClassGuid, &Node.m_ClassGuid, sizeof(GUID)); +} + CNode::~CNode() { -} +} Modified: trunk/reactos/dll/win32/devmgr/devmgmt/Node.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/devmgr/devmgmt/N… ============================================================================== --- trunk/reactos/dll/win32/devmgr/devmgmt/Node.h [iso-8859-1] (original) +++ trunk/reactos/dll/win32/devmgr/devmgmt/Node.h [iso-8859-1] Fri Oct 23 12:45:41 2015 @@ -25,6 +25,10 @@ _In_ PSP_CLASSIMAGELIST_DATA ImageListData ); + CNode( + _In_ const CNode& Node + ); + virtual ~CNode(); virtual bool SetupNode() = 0;

1 0

[tfaber] 69657: [NTOS:SE] - Fail if the provided default DACL is invalid in NtCreateToken. CID 1237131
by tfaber＠svn.reactos.org 23 Oct '15

23 Oct '15

Author: tfaber Date: Fri Oct 23 12:40:29 2015 New Revision: 69657 URL: http://svn.reactos.org/svn/reactos?rev=69657&view=rev Log: [NTOS:SE] - Fail if the provided default DACL is invalid in NtCreateToken. CID 1237131 Modified: trunk/reactos/ntoskrnl/se/token.c Modified: trunk/reactos/ntoskrnl/se/token.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/se/token.c?rev=69… ============================================================================== --- trunk/reactos/ntoskrnl/se/token.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/se/token.c [iso-8859-1] Fri Oct 23 12:40:29 2015 @@ -2852,6 +2852,10 @@ NonPagedPool, FALSE, &CapturedDefaultDacl); + if (!NT_SUCCESS(Status)) + { + goto Cleanup; + } } /* Call the internal function */

1 0

[rnaumann] 69656: revert r69654
by rnaumann＠svn.reactos.org 23 Oct '15

23 Oct '15

Author: rnaumann Date: Fri Oct 23 12:23:37 2015 New Revision: 69656 URL: http://svn.reactos.org/svn/reactos?rev=69656&view=rev Log: revert r69654 Modified: trunk/reactos/dll/win32/devmgr/resources/toolbar.bmp Modified: trunk/reactos/dll/win32/devmgr/resources/toolbar.bmp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/devmgr/resources… ============================================================================== Binary files - no diff available.

1 0

[rnaumann] 69655: [CPL] Fix some blurry resources. By Henry Tang Ih. CORE-10385
by rnaumann＠svn.reactos.org 23 Oct '15

23 Oct '15

Author: rnaumann Date: Fri Oct 23 11:42:02 2015 New Revision: 69655 URL: http://svn.reactos.org/svn/reactos?rev=69655&view=rev Log: [CPL] Fix some blurry resources. By Henry Tang Ih. CORE-10385 Modified: trunk/reactos/dll/cpl/inetcpl/resources/inetcpl.ico trunk/reactos/dll/cpl/main/resources/admintools_folder.ico trunk/reactos/dll/cpl/main/resources/fonts_folder.ico trunk/reactos/dll/cpl/main/resources/keyboard.ico trunk/reactos/dll/cpl/mmsys/resources/4393.ico trunk/reactos/dll/cpl/timedate/resources/world.bmp Modified: trunk/reactos/dll/cpl/inetcpl/resources/inetcpl.ico URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/cpl/inetcpl/resources/… ============================================================================== Binary files - no diff available. Modified: trunk/reactos/dll/cpl/main/resources/admintools_folder.ico URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/cpl/main/resources/adm… ============================================================================== Binary files - no diff available. Modified: trunk/reactos/dll/cpl/main/resources/fonts_folder.ico URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/cpl/main/resources/fon… ============================================================================== Binary files - no diff available. Modified: trunk/reactos/dll/cpl/main/resources/keyboard.ico URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/cpl/main/resources/key… ============================================================================== Binary files - no diff available. Modified: trunk/reactos/dll/cpl/mmsys/resources/4393.ico URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/cpl/mmsys/resources/43… ============================================================================== Binary files - no diff available. Modified: trunk/reactos/dll/cpl/timedate/resources/world.bmp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/cpl/timedate/resources… ============================================================================== Binary files - no diff available.

1 0

[rnaumann] 69654: [DEVMGR] Improve the toolbar bitmap. By Jared Smudde. CORE-10342
by rnaumann＠svn.reactos.org 23 Oct '15

23 Oct '15

Author: rnaumann Date: Fri Oct 23 11:27:52 2015 New Revision: 69654 URL: http://svn.reactos.org/svn/reactos?rev=69654&view=rev Log: [DEVMGR] Improve the toolbar bitmap. By Jared Smudde. CORE-10342 Modified: trunk/reactos/dll/win32/devmgr/resources/toolbar.bmp Modified: trunk/reactos/dll/win32/devmgr/resources/toolbar.bmp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/devmgr/resources… ============================================================================== Binary files - no diff available.

1 0

[tfaber] 69653: [WIN32K:NTUSER] - Don't open-code IoGetRemainingStackSize
by tfaber＠svn.reactos.org 23 Oct '15

23 Oct '15

Author: tfaber Date: Fri Oct 23 10:34:44 2015 New Revision: 69653 URL: http://svn.reactos.org/svn/reactos?rev=69653&view=rev Log: [WIN32K:NTUSER] - Don't open-code IoGetRemainingStackSize Modified: trunk/reactos/win32ss/user/ntuser/message.c Modified: trunk/reactos/win32ss/user/ntuser/message.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/ntuser/messag… ============================================================================== --- trunk/reactos/win32ss/user/ntuser/message.c [iso-8859-1] (original) +++ trunk/reactos/win32ss/user/ntuser/message.c [iso-8859-1] Fri Oct 23 10:34:44 2015 @@ -1300,7 +1300,7 @@ INT lParamBufferSize; LPARAM lParamPacked; PTHREADINFO Win32Thread, ptiSendTo = NULL; - ULONG_PTR Hi, Lo, Result = 0; + ULONG_PTR Result = 0; DECLARE_RETURN(LRESULT); USER_REFERENCE_ENTRY Ref; BOOL DoCallBack = TRUE; @@ -1348,9 +1348,8 @@ if ( Window->state & WNDS_SERVERSIDEWINDOWPROC ) { TRACE("SMT: Server Side Window Procedure\n"); - IoGetStackLimits(&Lo, &Hi); // Handle it here. Safeguard against excessive recursions. - if (((ULONG_PTR)&uResult - Lo) < 4096 ) + if (IoGetRemainingStackSize() < PAGE_SIZE) { ERR("Server Callback Exceeded Stack!\n"); RETURN( FALSE);

1 0

[tfaber] 69652: [NETWORKING][CABMAN] - Attempt to silence some 200 benign "Operands don't affect result" Coverity defects
by tfaber＠svn.reactos.org 23 Oct '15

23 Oct '15

Author: tfaber Date: Fri Oct 23 07:26:42 2015 New Revision: 69652 URL: http://svn.reactos.org/svn/reactos?rev=69652&view=rev Log: [NETWORKING][CABMAN] - Attempt to silence some 200 benign "Operands don't affect result" Coverity defects Modified: trunk/reactos/dll/win32/ws2_32/include/debug.h trunk/reactos/dll/win32/wshirda/debug.h trunk/reactos/drivers/network/afd/include/debug.h trunk/reactos/drivers/network/dd/ne2000/include/debug.h trunk/reactos/drivers/network/dd/rtl8139/debug.h trunk/reactos/drivers/network/lan/include/debug.h trunk/reactos/drivers/network/ndis/include/debug.h trunk/reactos/tools/cabman/cabinet.h trunk/rosapps/applications/net/tditest/include/debug.h Modified: trunk/reactos/dll/win32/ws2_32/include/debug.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/ws2_32/include/d… ============================================================================== --- trunk/reactos/dll/win32/ws2_32/include/debug.h [iso-8859-1] (original) +++ trunk/reactos/dll/win32/ws2_32/include/debug.h [iso-8859-1] Fri Oct 23 07:26:42 2015 @@ -28,8 +28,9 @@ extern DWORD DebugTraceLevel; #define WS_DbgPrint(_t_, _x_) \ - if (((DebugTraceLevel & NORMAL_MASK) >= _t_) || \ - ((DebugTraceLevel & _t_) > NORMAL_MASK)) { \ + if ((_t_ > NORMAL_MASK) \ + ? (DebugTraceLevel & _t_) > NORMAL_MASK \ + : (DebugTraceLevel & NORMAL_MASK) >= _t_) { \ DbgPrint("(%hS:%d)(%hS) ", __FILE__, __LINE__, __FUNCTION__); \ DbgPrint _x_; \ } Modified: trunk/reactos/dll/win32/wshirda/debug.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/wshirda/debug.h?… ============================================================================== --- trunk/reactos/dll/win32/wshirda/debug.h [iso-8859-1] (original) +++ trunk/reactos/dll/win32/wshirda/debug.h [iso-8859-1] Fri Oct 23 07:26:42 2015 @@ -22,8 +22,9 @@ extern DWORD DebugTraceLevel; #define WSH_DbgPrint(_t_, _x_) \ - if (((DebugTraceLevel & NORMAL_MASK) >= _t_) || \ - ((DebugTraceLevel & _t_) > NORMAL_MASK)) { \ + if ((_t_ > NORMAL_MASK) \ + ? (DebugTraceLevel & _t_) > NORMAL_MASK \ + : (DebugTraceLevel & NORMAL_MASK) >= _t_) { \ DbgPrint("(%hS:%d)(%hS) ", __FILE__, __LINE__, __FUNCTION__); \ DbgPrint _x_; \ } Modified: trunk/reactos/drivers/network/afd/include/debug.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/network/afd/includ… ============================================================================== --- trunk/reactos/drivers/network/afd/include/debug.h [iso-8859-1] (original) +++ trunk/reactos/drivers/network/afd/include/debug.h [iso-8859-1] Fri Oct 23 07:26:42 2015 @@ -26,8 +26,9 @@ #ifdef _MSC_VER #define AFD_DbgPrint(_t_, _x_) \ - if (((DebugTraceLevel & NORMAL_MASK) >= _t_) || \ - ((DebugTraceLevel & _t_) > NORMAL_MASK)) { \ + if ((_t_ > NORMAL_MASK) \ + ? (DebugTraceLevel & _t_) > NORMAL_MASK \ + : (DebugTraceLevel & NORMAL_MASK) >= _t_) { \ DbgPrint("(%s:%d) ", __FILE__, __LINE__); \ DbgPrint _x_ ; \ } @@ -35,8 +36,9 @@ #else /* _MSC_VER */ #define AFD_DbgPrint(_t_, _x_) \ - if (((DebugTraceLevel & NORMAL_MASK) >= _t_) || \ - ((DebugTraceLevel & _t_) > NORMAL_MASK)) { \ + if ((_t_ > NORMAL_MASK) \ + ? (DebugTraceLevel & _t_) > NORMAL_MASK \ + : (DebugTraceLevel & NORMAL_MASK) >= _t_) { \ DbgPrint("(%s:%d)(%s) ", __FILE__, __LINE__, __FUNCTION__); \ DbgPrint _x_ ; \ } Modified: trunk/reactos/drivers/network/dd/ne2000/include/debug.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/network/dd/ne2000/… ============================================================================== --- trunk/reactos/drivers/network/dd/ne2000/include/debug.h [iso-8859-1] (original) +++ trunk/reactos/drivers/network/dd/ne2000/include/debug.h [iso-8859-1] Fri Oct 23 07:26:42 2015 @@ -25,8 +25,9 @@ #ifdef _MSC_VER #define NDIS_DbgPrint(_t_, _x_) \ - if (((DebugTraceLevel & NORMAL_MASK) >= _t_) || \ - ((DebugTraceLevel & _t_) > NORMAL_MASK)) { \ + if ((_t_ > NORMAL_MASK) \ + ? (DebugTraceLevel & _t_) > NORMAL_MASK \ + : (DebugTraceLevel & NORMAL_MASK) >= _t_) { \ DbgPrint("(%s:%d) ", __FILE__, __LINE__); \ DbgPrint _x_ ; \ } @@ -34,8 +35,9 @@ #else /* _MSC_VER */ #define NDIS_DbgPrint(_t_, _x_) \ - if (((DebugTraceLevel & NORMAL_MASK) >= _t_) || \ - ((DebugTraceLevel & _t_) > NORMAL_MASK)) { \ + if ((_t_ > NORMAL_MASK) \ + ? (DebugTraceLevel & _t_) > NORMAL_MASK \ + : (DebugTraceLevel & NORMAL_MASK) >= _t_) { \ DbgPrint("(%s:%d)(%s) ", __FILE__, __LINE__, __FUNCTION__); \ DbgPrint _x_ ; \ } Modified: trunk/reactos/drivers/network/dd/rtl8139/debug.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/network/dd/rtl8139… ============================================================================== --- trunk/reactos/drivers/network/dd/rtl8139/debug.h [iso-8859-1] (original) +++ trunk/reactos/drivers/network/dd/rtl8139/debug.h [iso-8859-1] Fri Oct 23 07:26:42 2015 @@ -25,8 +25,9 @@ #ifdef _MSC_VER #define NDIS_DbgPrint(_t_, _x_) \ - if (((DebugTraceLevel & NORMAL_MASK) >= _t_) || \ - ((DebugTraceLevel & _t_) > NORMAL_MASK)) { \ + if ((_t_ > NORMAL_MASK) \ + ? (DebugTraceLevel & _t_) > NORMAL_MASK \ + : (DebugTraceLevel & NORMAL_MASK) >= _t_) { \ DbgPrint("(%s:%d) ", __FILE__, __LINE__); \ DbgPrint _x_ ; \ } @@ -34,8 +35,9 @@ #else /* _MSC_VER */ #define NDIS_DbgPrint(_t_, _x_) \ - if (((DebugTraceLevel & NORMAL_MASK) >= _t_) || \ - ((DebugTraceLevel & _t_) > NORMAL_MASK)) { \ + if ((_t_ > NORMAL_MASK) \ + ? (DebugTraceLevel & _t_) > NORMAL_MASK \ + : (DebugTraceLevel & NORMAL_MASK) >= _t_) { \ DbgPrint("(%s:%d)(%s) ", __FILE__, __LINE__, __FUNCTION__); \ DbgPrint _x_ ; \ } Modified: trunk/reactos/drivers/network/lan/include/debug.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/network/lan/includ… ============================================================================== --- trunk/reactos/drivers/network/lan/include/debug.h [iso-8859-1] (original) +++ trunk/reactos/drivers/network/lan/include/debug.h [iso-8859-1] Fri Oct 23 07:26:42 2015 @@ -40,8 +40,9 @@ #ifdef _MSC_VER #define LA_DbgPrint(_t_, _x_) \ - if (((DebugTraceLevel & NORMAL_MASK) >= _t_) || \ - ((DebugTraceLevel & _t_) > NORMAL_MASK)) { \ + if ((_t_ > NORMAL_MASK) \ + ? (DebugTraceLevel & _t_) > NORMAL_MASK \ + : (DebugTraceLevel & NORMAL_MASK) >= _t_) { \ DbgPrint("(%s:%d) ", __FILE__, __LINE__); \ DbgPrint _x_ ; \ } @@ -49,8 +50,9 @@ #else /* _MSC_VER */ #define LA_DbgPrint(_t_, _x_) \ - if (((DebugTraceLevel & NORMAL_MASK) >= _t_) || \ - ((DebugTraceLevel & _t_) > NORMAL_MASK)) { \ + if ((_t_ > NORMAL_MASK) \ + ? (DebugTraceLevel & _t_) > NORMAL_MASK \ + : (DebugTraceLevel & NORMAL_MASK) >= _t_) { \ DbgPrint("(%s:%d)(%s) ", __FILE__, __LINE__, __FUNCTION__); \ DbgPrint _x_ ; \ } Modified: trunk/reactos/drivers/network/ndis/include/debug.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/network/ndis/inclu… ============================================================================== --- trunk/reactos/drivers/network/ndis/include/debug.h [iso-8859-1] (original) +++ trunk/reactos/drivers/network/ndis/include/debug.h [iso-8859-1] Fri Oct 23 07:26:42 2015 @@ -26,8 +26,9 @@ #ifdef _MSC_VER #define NDIS_DbgPrint(_t_, _x_) \ - if (((DebugTraceLevel & NORMAL_MASK) >= _t_) || \ - ((DebugTraceLevel & _t_) > NORMAL_MASK)) { \ + if ((_t_ > NORMAL_MASK) \ + ? (DebugTraceLevel & _t_) > NORMAL_MASK \ + : (DebugTraceLevel & NORMAL_MASK) >= _t_) { \ DbgPrint("(%s:%d) ", __FILE__, __LINE__); \ DbgPrint _x_ ; \ } @@ -35,8 +36,9 @@ #else /* _MSC_VER */ #define NDIS_DbgPrint(_t_, _x_) \ - if (((DebugTraceLevel & NORMAL_MASK) >= _t_) || \ - ((DebugTraceLevel & _t_) > NORMAL_MASK)) { \ + if ((_t_ > NORMAL_MASK) \ + ? (DebugTraceLevel & _t_) > NORMAL_MASK \ + : (DebugTraceLevel & NORMAL_MASK) >= _t_) { \ DbgPrint("(%s:%d)(%s) ", __FILE__, __LINE__, __FUNCTION__); \ DbgPrint _x_ ; \ } Modified: trunk/reactos/tools/cabman/cabinet.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/tools/cabman/cabinet.h?rev… ============================================================================== --- trunk/reactos/tools/cabman/cabinet.h [iso-8859-1] (original) +++ trunk/reactos/tools/cabman/cabinet.h [iso-8859-1] Fri Oct 23 07:26:42 2015 @@ -65,8 +65,9 @@ #undef DPRINT #define DPRINT(_t_, _x_) \ - if (((DebugTraceLevel & NORMAL_MASK) >= _t_) || \ - ((DebugTraceLevel & _t_) > NORMAL_MASK)) { \ + if ((_t_ > NORMAL_MASK) \ + ? (DebugTraceLevel & _t_) > NORMAL_MASK \ + : (DebugTraceLevel & NORMAL_MASK) >= _t_) { \ printf("(%s:%d)(%s) ", __FILE__, __LINE__, __FUNCTION__); \ printf _x_ ; \ } Modified: trunk/rosapps/applications/net/tditest/include/debug.h URL: http://svn.reactos.org/svn/reactos/trunk/rosapps/applications/net/tditest/i… ============================================================================== --- trunk/rosapps/applications/net/tditest/include/debug.h [iso-8859-1] (original) +++ trunk/rosapps/applications/net/tditest/include/debug.h [iso-8859-1] Fri Oct 23 07:26:42 2015 @@ -28,8 +28,9 @@ #ifdef _MSC_VER #define TDI_DbgPrint(_t_, _x_) \ - if (((DebugTraceLevel & NORMAL_MASK) >= _t_) || \ - ((DebugTraceLevel & _t_) > NORMAL_MASK)) { \ + if ((_t_ > NORMAL_MASK) \ + ? (DebugTraceLevel & _t_) > NORMAL_MASK \ + : (DebugTraceLevel & NORMAL_MASK) >= _t_) { \ DbgPrint("(%s:%d) ", __FILE__, __LINE__); \ DbgPrint _x_ ; \ } @@ -37,8 +38,9 @@ #else /* _MSC_VER */ #define TDI_DbgPrint(_t_, _x_) \ - if (((DebugTraceLevel & NORMAL_MASK) >= _t_) || \ - ((DebugTraceLevel & _t_) > NORMAL_MASK)) { \ + if ((_t_ > NORMAL_MASK) \ + ? (DebugTraceLevel & _t_) > NORMAL_MASK \ + : (DebugTraceLevel & NORMAL_MASK) >= _t_) { \ DbgPrint("(%s:%d)(%s) ", __FILE__, __LINE__, __FUNCTION__); \ DbgPrint _x_ ; \ }

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs