Ros-diffs

ros-diffs@reactos.org

81390 discussions

[tfaber] 69591: [WINDOWSCODECS] - Fix some MSVC warnings
by tfaber＠svn.reactos.org 18 Oct '15

18 Oct '15

Author: tfaber Date: Sun Oct 18 09:45:12 2015 New Revision: 69591 URL: http://svn.reactos.org/svn/reactos?rev=69591&view=rev Log: [WINDOWSCODECS] - Fix some MSVC warnings Modified: trunk/reactos/dll/win32/windowscodecs/typeof.h Modified: trunk/reactos/dll/win32/windowscodecs/typeof.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/windowscodecs/ty… ============================================================================== --- trunk/reactos/dll/win32/windowscodecs/typeof.h [iso-8859-1] (original) +++ trunk/reactos/dll/win32/windowscodecs/typeof.h [iso-8859-1] Sun Oct 18 09:45:12 2015 @@ -78,7 +78,7 @@ typedef void (__cdecl typeof(png_set_crc_action))(struct png_struct_def *, int, int); typedef void *thandle_t_1; -typedef int (*TIFFReadWriteProc_1)(thandle_t_1, void *, int); +typedef int (*TIFFReadWriteProc_1)(thandle_t_1, void *, long); typedef unsigned int (*TIFFSeekProc_1)(void *, unsigned int, int); typedef int (*TIFFCloseProc_1)(thandle_t_1); typedef unsigned int (*TIFFSizeProc_1)(thandle_t_1);

1 0

[tfaber] 69590: [RTL] - Add missing OBJ_KERNEL_HANDLE in RtlOpenCurrentUser CORE-10207
by tfaber＠svn.reactos.org 18 Oct '15

18 Oct '15

Author: tfaber Date: Sun Oct 18 09:32:52 2015 New Revision: 69590 URL: http://svn.reactos.org/svn/reactos?rev=69590&view=rev Log: [RTL] - Add missing OBJ_KERNEL_HANDLE in RtlOpenCurrentUser CORE-10207 Modified: trunk/reactos/lib/rtl/registry.c Modified: trunk/reactos/lib/rtl/registry.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/rtl/registry.c?rev=695… ============================================================================== --- trunk/reactos/lib/rtl/registry.c [iso-8859-1] (original) +++ trunk/reactos/lib/rtl/registry.c [iso-8859-1] Sun Oct 18 09:32:52 2015 @@ -703,7 +703,7 @@ /* Initialize the attributes and open it */ InitializeObjectAttributes(&ObjectAttributes, &KeyPath, - OBJ_CASE_INSENSITIVE, + OBJ_CASE_INSENSITIVE | OBJ_KERNEL_HANDLE, NULL, NULL); Status = ZwOpenKey(KeyHandle, DesiredAccess, &ObjectAttributes); @@ -717,7 +717,7 @@ RtlInitUnicodeString(&KeyPath, RtlpRegPaths[RTL_REGISTRY_USER]); InitializeObjectAttributes(&ObjectAttributes, &KeyPath, - OBJ_CASE_INSENSITIVE, + OBJ_CASE_INSENSITIVE | OBJ_KERNEL_HANDLE, NULL, NULL); Status = ZwOpenKey(KeyHandle, DesiredAccess, &ObjectAttributes);

1 0

[tfaber] 69589: [LIBXML] - Fix VS2013 build
by tfaber＠svn.reactos.org 18 Oct '15

18 Oct '15

Author: tfaber Date: Sun Oct 18 08:39:56 2015 New Revision: 69589 URL: http://svn.reactos.org/svn/reactos?rev=69589&view=rev Log: [LIBXML] - Fix VS2013 build Modified: trunk/reactos/lib/3rdparty/libxml2/CMakeLists.txt Modified: trunk/reactos/lib/3rdparty/libxml2/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/3rdparty/libxml2/CMake… ============================================================================== --- trunk/reactos/lib/3rdparty/libxml2/CMakeLists.txt [iso-8859-1] (original) +++ trunk/reactos/lib/3rdparty/libxml2/CMakeLists.txt [iso-8859-1] Sun Oct 18 08:39:56 2015 @@ -70,6 +70,8 @@ if(MSVC) # Formal parameter different from declaration add_target_compile_flags(libxml2 "/wd4101") + # Local variable initialized but not referenced + replace_compile_flags("/we4189" " ") else() add_target_compile_flags(libxml2 "-w") endif()

1 0

[tfaber] 69588: [LIBXML] - Fix MSVC incompatible declaration warning - Silence MSVC unused variable warnings - Get config.h slightly more in sync with upstream
by tfaber＠svn.reactos.org 18 Oct '15

18 Oct '15

Author: tfaber Date: Sun Oct 18 08:32:42 2015 New Revision: 69588 URL: http://svn.reactos.org/svn/reactos?rev=69588&view=rev Log: [LIBXML] - Fix MSVC incompatible declaration warning - Silence MSVC unused variable warnings - Get config.h slightly more in sync with upstream Modified: trunk/reactos/lib/3rdparty/libxml2/CMakeLists.txt trunk/reactos/lib/3rdparty/libxml2/config.h Modified: trunk/reactos/lib/3rdparty/libxml2/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/3rdparty/libxml2/CMake… ============================================================================== --- trunk/reactos/lib/3rdparty/libxml2/CMakeLists.txt [iso-8859-1] (original) +++ trunk/reactos/lib/3rdparty/libxml2/CMakeLists.txt [iso-8859-1] Sun Oct 18 08:32:42 2015 @@ -68,7 +68,8 @@ add_dependencies(libxml2 psdk) if(MSVC) - replace_compile_flags("/we4189" " ") + # Formal parameter different from declaration + add_target_compile_flags(libxml2 "/wd4101") else() add_target_compile_flags(libxml2 "-w") endif() Modified: trunk/reactos/lib/3rdparty/libxml2/config.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/3rdparty/libxml2/confi… ============================================================================== --- trunk/reactos/lib/3rdparty/libxml2/config.h [iso-8859-1] (original) +++ trunk/reactos/lib/3rdparty/libxml2/config.h [iso-8859-1] Sun Oct 18 08:32:42 2015 @@ -1,5 +1,8 @@ /* config.h. Generated from config.h.in by configure. */ /* config.h.in. Generated from configure.in by autoheader. */ + +/* Type cast for the gethostbyname() argument */ +#define GETHOSTBYNAME_ARG_CAST /* Define to 1 if you have the <ansidecl.h> header file. */ /* #undef HAVE_ANSIDECL_H */ @@ -297,11 +300,17 @@ /* Define to the version of this package. */ #define PACKAGE_VERSION "" +/* Type cast for the send() function 2nd arg */ +#define SEND_ARG2_CAST + /* Define to 1 if you have the ANSI C header files. */ #define STDC_HEADERS 1 /* Support for IPv6 */ /* #undef SUPPORT_IP6 */ + +/* Define if va_list is an array type */ +/* #undef VA_LIST_IS_ARRAY */ /* Version number of package */ #define VERSION "2.9.2" @@ -317,7 +326,6 @@ /* Using the Win32 Socket implementation */ //#define _WINSOCKAPI_ 1 - /* ss_family is not defined here, use __ss_family instead */ /* #undef ss_family */ @@ -325,21 +333,15 @@ such a type exists and the standard includes do not define it. */ /* #undef uint32_t */ -#if defined(_MSC_VER) -#define GetModuleHandleA GetModuleHandleA_ -#endif +#ifdef __REACTOS__ #if defined(__MINGW32__) //#include <windows.h> #define WIN32_NO_STATUS +#define _WINDOWS_ #define _INC_WINDOWS #define COM_NO_WINDOWS_H #include <stdarg.h> #include <windef.h> #include <winbase.h> #endif -#if defined(_MSC_VER) -#undef GetModuleHandleA #endif - -#define SEND_ARG2_CAST -#define GETHOSTBYNAME_ARG_CAST

1 0

[tfaber] 69587: [CMAKE] - Reserve some more space for ntdll so that we're compatible with Windows's version (base 0x7c910000). Should fix VMware Hybrid builder
by tfaber＠svn.reactos.org 18 Oct '15

18 Oct '15

Author: tfaber Date: Sun Oct 18 07:56:27 2015 New Revision: 69587 URL: http://svn.reactos.org/svn/reactos?rev=69587&view=rev Log: [CMAKE] - Reserve some more space for ntdll so that we're compatible with Windows's version (base 0x7c910000). Should fix VMware Hybrid builder Modified: trunk/reactos/cmake/baseaddress.cmake Modified: trunk/reactos/cmake/baseaddress.cmake URL: http://svn.reactos.org/svn/reactos/trunk/reactos/cmake/baseaddress.cmake?re… ============================================================================== --- trunk/reactos/cmake/baseaddress.cmake [iso-8859-1] (original) +++ trunk/reactos/cmake/baseaddress.cmake [iso-8859-1] Sun Oct 18 07:56:27 2015 @@ -1,6 +1,6 @@ set(baseaddress_ntdll 0x7c920000) # should be above 0x7c920000 -set(baseaddress_kernel32 0x7c770000) -set(baseaddress_msvcrt 0x7c6c0000) +set(baseaddress_kernel32 0x7c750000) +set(baseaddress_msvcrt 0x7c6b0000) set(baseaddress_advapi32 0x7c610000) set(baseaddress_gdi32 0x7c570000) set(baseaddress_user32 0x7c3d0000)

1 0

[tfaber] 69586: [EXT2FS] - Fix warnings
by tfaber＠svn.reactos.org 18 Oct '15

18 Oct '15

Author: tfaber Date: Sun Oct 18 07:32:09 2015 New Revision: 69586 URL: http://svn.reactos.org/svn/reactos?rev=69586&view=rev Log: [EXT2FS] - Fix warnings Modified: trunk/reactos/drivers/filesystems/ext2/CMakeLists.txt trunk/reactos/drivers/filesystems/ext2/inc/ext2fs.h trunk/reactos/drivers/filesystems/ext2/src/fastio.c trunk/reactos/drivers/filesystems/ext2/src/memory.c Modified: trunk/reactos/drivers/filesystems/ext2/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/ext2/C… ============================================================================== --- trunk/reactos/drivers/filesystems/ext2/CMakeLists.txt [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/ext2/CMakeLists.txt [iso-8859-1] Sun Oct 18 07:32:09 2015 @@ -88,7 +88,6 @@ if(NOT MSVC) add_target_compile_flags(ext2fs "-Wno-pointer-sign -Wno-unused-function") if(NOT CMAKE_C_COMPILER_ID STREQUAL "Clang") - replace_compile_flags("-Werror" " ") add_target_compile_flags(ext2fs "-Wno-unused-but-set-variable -Wno-unused-variable -Wno-missing-braces") endif() else() Modified: trunk/reactos/drivers/filesystems/ext2/inc/ext2fs.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/ext2/i… ============================================================================== --- trunk/reactos/drivers/filesystems/ext2/inc/ext2fs.h [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/ext2/inc/ext2fs.h [iso-8859-1] Sun Oct 18 07:32:09 2015 @@ -2030,7 +2030,11 @@ BOOLEAN NTAPI Ext2FastIoUnlockAllByKey ( IN PFILE_OBJECT FileObject, +#ifdef __REACTOS__ + IN PVOID Process, +#else IN PEPROCESS Process, +#endif IN ULONG Key, OUT PIO_STATUS_BLOCK IoStatus, IN PDEVICE_OBJECT DeviceObject Modified: trunk/reactos/drivers/filesystems/ext2/src/fastio.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/ext2/s… ============================================================================== --- trunk/reactos/drivers/filesystems/ext2/src/fastio.c [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/ext2/src/fastio.c [iso-8859-1] Sun Oct 18 07:32:09 2015 @@ -779,7 +779,11 @@ BOOLEAN NTAPI Ext2FastIoUnlockAllByKey ( IN PFILE_OBJECT FileObject, +#ifdef __REACTOS__ + IN PVOID Process, +#else IN PEPROCESS Process, +#endif IN ULONG Key, OUT PIO_STATUS_BLOCK IoStatus, IN PDEVICE_OBJECT DeviceObject Modified: trunk/reactos/drivers/filesystems/ext2/src/memory.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/ext2/s… ============================================================================== --- trunk/reactos/drivers/filesystems/ext2/src/memory.c [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/ext2/src/memory.c [iso-8859-1] Sun Oct 18 07:32:09 2015 @@ -2077,7 +2077,12 @@ k < ParamPattern[i].Length && Params->Buffer[j+k] != L';' && Params->Buffer[j+k] != L',' ) { +#ifdef __REACTOS__ + ParamPattern[i].uValue[k] = Params->Buffer[j + k]; + k++; +#else ParamPattern[i].uValue[k] = Params->Buffer[j + k++]; +#endif } if (k) { NTSTATUS status;

1 0

[tfaber] 69585: [NTSTATUS] - Add some more status codes CORE-8373
by tfaber＠svn.reactos.org 18 Oct '15

18 Oct '15

Author: tfaber Date: Sun Oct 18 07:05:14 2015 New Revision: 69585 URL: http://svn.reactos.org/svn/reactos?rev=69585&view=rev Log: [NTSTATUS] - Add some more status codes CORE-8373 Modified: trunk/reactos/include/reactos/mc/ntstatus.mc Modified: trunk/reactos/include/reactos/mc/ntstatus.mc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/reactos/mc/ntstatu… ============================================================================== --- trunk/reactos/include/reactos/mc/ntstatus.mc [iso-8859-1] (original) +++ trunk/reactos/include/reactos/mc/ntstatus.mc [iso-8859-1] Sun Oct 18 07:05:14 2015 @@ -1585,12 +1585,52 @@ Indicates two revision levels are incompatible. . +MessageId=0x5a +Severity=Error +Facility=System +SymbolicName=STATUS_INVALID_OWNER +Language=English +The specified owner is not valid for this object. + +. +MessageId=0x5b +Severity=Error +Facility=System +SymbolicName=STATUS_INVALID_PRIMARY_GROUP +Language=English +The specified primary group is not valid for this object. + +. MessageId=0x5c Severity=Error Facility=System SymbolicName=STATUS_NO_IMPERSONATION_TOKEN Language=English An attempt has been made to operate on an impersonation token by a thread that is not currently impersonating a client. + +. +MessageId=0x5d +Severity=Error +Facility=System +SymbolicName=STATUS_CANT_DISABLE_MANDATORY +Language=English +The specified group cannot be disabled because it is marked as mandatory. + +. +MessageId=0x5e +Severity=Error +Facility=System +SymbolicName=STATUS_NO_LOGON_SERVERS +Language=English +The logon failed because no valid logon servers were found. + +. +MessageId=0x5f +Severity=Error +Facility=System +SymbolicName=STATUS_NO_SUCH_LOGON_SESSION +Language=English +The specified logon session does not exist. . MessageId=0x60 @@ -1675,12 +1715,52 @@ This is not allowed to prevent creating a situation in which the system cannot be administrated. . +MessageId=0x6a +Severity=Error +Facility=System +SymbolicName=STATUS_WRONG_PASSWORD +Language=English +The specified current password is not correct. + +. +MessageId=0x6b +Severity=Error +Facility=System +SymbolicName=STATUS_ILL_FORMED_PASSWORD +Language=English +The new password contains invalid characters. + +. MessageId=0x6c Severity=Error Facility=System SymbolicName=STATUS_PASSWORD_RESTRICTION Language=English When trying to update a password, this status indicates that some password update rule has been violated. For example, the password may not meet length criteria. + +. +MessageId=0x6d +Severity=Error +Facility=System +SymbolicName=STATUS_LOGON_FAILURE +Language=English +Logon failed because the specified user name or password is incorrect. + +. +MessageId=0x6e +Severity=Error +Facility=System +SymbolicName=STATUS_ACCOUNT_RESTRICTION +Language=English +The specified information is valid but an account restriction prevented logon. + +. +MessageId=0x6f +Severity=Error +Facility=System +SymbolicName=STATUS_INVALID_LOGON_HOURS +Language=English +The attempted logon is not allowed at this time. . MessageId=0x70 @@ -1790,6 +1870,30 @@ This is typically done by referencing the token associated with a thread when the thread is not impersonating a client. . +MessageId=0x7d +Severity=Error +Facility=System +SymbolicName=STATUS_BAD_INHERITANCE_ACL +Language=English +The inherited access control list could not be created. + +. +MessageId=0x7e +Severity=Error +Facility=System +SymbolicName=STATUS_RANGE_NOT_LOCKED +Language=English +Attempt to unlock a file range that is not locked. + +. +MessageId=0x7f +Severity=Error +Facility=System +SymbolicName=STATUS_DISK_FULL +Language=English +The disk is full. Delete files and free up disk space to continue the operation. + +. MessageId=0x80 Severity=Error Facility=System @@ -1868,6 +1972,22 @@ SymbolicName=STATUS_RESOURCE_DATA_NOT_FOUND Language=English Indicates the specified image file did not contain a resource section. + +. +MessageId=0x8a +Severity=Error +Facility=System +SymbolicName=STATUS_RESOURCE_TYPE_NOT_FOUND +Language=English +A resource of the specified type could not be found in the image file. + +. +MessageId=0x8b +Severity=Error +Facility=System +SymbolicName=STATUS_RESOURCE_NAME_NOT_FOUND +Language=English +A resource with the specified name could not be found in the image file. . MessageId=0x8c @@ -1877,6 +1997,33 @@ Language=English {EXCEPTION} Array bounds exceeded. + +. +MessageId=0x8d +Severity=Error +Facility=System +SymbolicName=STATUS_FLOAT_DENORMAL_OPERAND +Language=English +{EXCEPTION} +Floating-point denormal operand. + +. +MessageId=0x8e +Severity=Error +Facility=System +SymbolicName=STATUS_FLOAT_DIVIDE_BY_ZERO +Language=English +{EXCEPTION} +Floating-point division by zero. + +. +MessageId=0x8f +Severity=Error +Facility=System +SymbolicName=STATUS_FLOAT_INEXACT_RESULT +Language=English +{EXCEPTION} +Floating-point inexact result. . MessageId=0x90 @@ -1976,12 +2123,70 @@ Insufficient system resources exist to complete this API. . +MessageId=0x9b +Severity=Error +Facility=System +SymbolicName=STATUS_DFS_EXIT_PATH_FOUND +Language=English +The specified file cannot be opened because it is a DFS exit path file. + +. MessageId=0x9c Severity=Error Facility=System SymbolicName=STATUS_DEVICE_DATA_ERROR Language=English STATUS_DEVICE_DATA_ERROR + +. +MessageId=0x9d +Severity=Error +Facility=System +SymbolicName=STATUS_DEVICE_NOT_CONNECTED +Language=English +The specified device is not connected. + +. +MessageId=0x9f +Severity=Error +Facility=System +SymbolicName=STATUS_FREE_VM_NOT_AT_BASE +Language=English +The specified memory could not be freed because it is not at the start of the allocation. + +. +MessageId=0xa0 +Severity=Error +Facility=System +SymbolicName=STATUS_MEMORY_NOT_ALLOCATED +Language=English +The specified memory could not be freed because it was not allocated. + +. +MessageId=0xa1 +Severity=Error +Facility=System +SymbolicName=STATUS_WORKING_SET_QUOTA +Language=English +The process working set quota was exceeded + +. +MessageId=0xa2 +Severity=Error +Facility=System +SymbolicName=STATUS_MEDIA_WRITE_PROTECTED +Language=English +{Write Protect Error} +The media in volume %hs cannot be written to because it is write-protected. + +. +MessageId=0xa3 +Severity=Error +Facility=System +SymbolicName=STATUS_DEVICE_NOT_READY +Language=English +{Device Not Ready} +The device %hs is not ready. . MessageId=0xc0

1 0

[tfaber] 69584: [BUGCODES] - Correct broken bug check code entry aka fix build
by tfaber＠svn.reactos.org 18 Oct '15

18 Oct '15

Author: tfaber Date: Sun Oct 18 06:31:20 2015 New Revision: 69584 URL: http://svn.reactos.org/svn/reactos?rev=69584&view=rev Log: [BUGCODES] - Correct broken bug check code entry aka fix build Modified: trunk/reactos/include/reactos/mc/bugcodes.mc Modified: trunk/reactos/include/reactos/mc/bugcodes.mc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/reactos/mc/bugcode… ============================================================================== --- trunk/reactos/include/reactos/mc/bugcodes.mc [iso-8859-1] (original) +++ trunk/reactos/include/reactos/mc/bugcodes.mc [iso-8859-1] Sun Oct 18 06:31:20 2015 @@ -1515,7 +1515,8 @@ Facility=System SymbolicName=IMPERSONATING_WORKER_THREAD Language=English -A work queue item terminated without properly restoring its impersonation level. +A worker thread is impersonating another process. The work item forgot to +disable impersonation before it returned. . MessageId=0xE0 @@ -1662,10 +1663,9 @@ MessageId=0xFA Severity=Success Facility=System -SymbolicName=IMPERSONATING_WORKER_THREAD -Language=English -A worker thread is impersonating another process. The work item forgot to -disable impersonation before it returned. +SymbolicName=HTTP_DRIVER_CORRUPTED +Language=English +Corruption was detected in the HTTP kernel driver. . MessageId=0xFC

1 0

[tfaber] 69583: [BUGCODES] - Add some more bug check codes
by tfaber＠svn.reactos.org 18 Oct '15

18 Oct '15

Author: tfaber Date: Sun Oct 18 06:26:51 2015 New Revision: 69583 URL: http://svn.reactos.org/svn/reactos?rev=69583&view=rev Log: [BUGCODES] - Add some more bug check codes Modified: trunk/reactos/include/reactos/mc/bugcodes.mc Modified: trunk/reactos/include/reactos/mc/bugcodes.mc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/reactos/mc/bugcode… ============================================================================== --- trunk/reactos/include/reactos/mc/bugcodes.mc [iso-8859-1] (original) +++ trunk/reactos/include/reactos/mc/bugcodes.mc [iso-8859-1] Sun Oct 18 06:26:51 2015 @@ -1316,6 +1316,14 @@ so that your operating system will continue to function properly. . +MessageId=0xC4 +Severity=Success +Facility=System +SymbolicName=DRIVER_VERIFIER_DETECTED_VIOLATION +Language=English +Driver Verifier has detected a fatal error condition. +. + MessageId=0xC5 Severity=Success Facility=System @@ -1422,6 +1430,14 @@ The driver mistakenly marked a part of its image pageable instead of non-pageable. . +MessageId=0xD4 +Severity=Success +Facility=System +SymbolicName=SYSTEM_SCAN_AT_RAISED_IRQL_CAUGHT_IMPROPER_DRIVER_UNLOAD +Language=English +The driver unloaded without cancelling pending operations. +. + MessageId=0xD5 Severity=Success Facility=System @@ -1454,12 +1470,52 @@ The driver has used an excessive number of system PTEs. . -MessageId=0xD4 -Severity=Success -Facility=System -SymbolicName=SYSTEM_SCAN_AT_RAISED_IRQL_CAUGHT_IMPROPER_DRIVER_UNLOAD -Language=English -The driver unloaded without cancelling pending operations. +MessageId=0xD9 +Severity=Success +Facility=System +SymbolicName=LOCKED_PAGES_TRACKER_CORRUPTION +Language=English +The system's structures tracking locked pages have been corrupted. +. + +MessageId=0xDA +Severity=Success +Facility=System +SymbolicName=SYSTEM_PTE_MISUSE +Language=English +The driver has called a system PTE routine in an improper way. +. + +MessageId=0xDB +Severity=Success +Facility=System +SymbolicName=DRIVER_CORRUPTED_SYSPTES +Language=English +The driver has corrupted system PTEs. +. + +MessageId=0xDC +Severity=Success +Facility=System +SymbolicName=DRIVER_INVALID_STACK_ACCESS +Language=English +The driver has accessed an invalid stack address. +. + +MessageId=0xDE +Severity=Success +Facility=System +SymbolicName=POOL_CORRUPTION_IN_FILE_AREA +Language=English +Kernel pool corruption has been detected in an area marked to be written to disk. +. + +MessageId=0xDF +Severity=Success +Facility=System +SymbolicName=IMPERSONATING_WORKER_THREAD +Language=English +A work queue item terminated without properly restoring its impersonation level. . MessageId=0xE0

1 0

[hbelusca] 69582: [COMSUPP]: Fix string length computations.
by hbelusca＠svn.reactos.org 18 Oct '15

18 Oct '15

Author: hbelusca Date: Sun Oct 18 02:14:21 2015 New Revision: 69582 URL: http://svn.reactos.org/svn/reactos?rev=69582&view=rev Log: [COMSUPP]: Fix string length computations. Modified: trunk/reactos/lib/sdk/comsupp/comsupp.cpp Modified: trunk/reactos/lib/sdk/comsupp/comsupp.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/sdk/comsupp/comsupp.cp… ============================================================================== --- trunk/reactos/lib/sdk/comsupp/comsupp.cpp [iso-8859-1] (original) +++ trunk/reactos/lib/sdk/comsupp/comsupp.cpp [iso-8859-1] Sun Oct 18 02:14:21 2015 @@ -62,13 +62,12 @@ if (!pSrc) return NULL; - /* Compute the needed size without the NULL terminator */ + /* Compute the needed size with the NULL terminator */ cwch = ::MultiByteToWideChar(CP_ACP /* CP_UTF8 */, 0, pSrc, -1, NULL, 0); if (cwch == 0) return NULL; - cwch--; - /* Allocate the BSTR */ - wsOut = ::SysAllocStringLen(NULL, cwch); + /* Allocate the BSTR (without the NULL terminator) */ + wsOut = ::SysAllocStringLen(NULL, cwch - 1); if (!wsOut) { ::_com_issue_error(HRESULT_FROM_WIN32(ERROR_OUTOFMEMORY)); @@ -97,11 +96,11 @@ if (!pSrc) return NULL; - /* Retrieve the size of the BSTR without the NULL terminator */ - cwch = ::SysStringLen(pSrc); + /* Retrieve the size of the BSTR with the NULL terminator */ + cwch = ::SysStringLen(pSrc) + 1; /* Compute the needed size with the NULL terminator */ - cb = ::WideCharToMultiByte(CP_ACP /* CP_UTF8 */, 0, pSrc, cwch + 1, NULL, 0, NULL, NULL); + cb = ::WideCharToMultiByte(CP_ACP /* CP_UTF8 */, 0, pSrc, cwch, NULL, 0, NULL, NULL); if (cb == 0) { cwch = ::GetLastError(); @@ -118,8 +117,8 @@ } /* Convert the string and NULL-terminate */ - szOut[cb - 1] = '\0'; - if (::WideCharToMultiByte(CP_ACP /* CP_UTF8 */, 0, pSrc, cwch + 1, szOut, cb, NULL, NULL) == 0) + szOut[cb - 1] = '\0'; + if (::WideCharToMultiByte(CP_ACP /* CP_UTF8 */, 0, pSrc, cwch, szOut, cb, NULL, NULL) == 0) { /* We failed, clean everything up */ cwch = ::GetLastError();

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs