Ros-diffs

ros-diffs@reactos.org

81390 discussions

[akhaldi] 69471: [PSDK] Correct setStartMode() uri default value. CORE-10320
by akhaldi＠svn.reactos.org 09 Oct '15

09 Oct '15

Author: akhaldi Date: Fri Oct 9 09:12:57 2015 New Revision: 69471 URL: http://svn.reactos.org/svn/reactos?rev=69471&view=rev Log: [PSDK] Correct setStartMode() uri default value. CORE-10320 Modified: trunk/reactos/include/psdk/msxml2.idl Modified: trunk/reactos/include/psdk/msxml2.idl URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/psdk/msxml2.idl?re… ============================================================================== --- trunk/reactos/include/psdk/msxml2.idl [iso-8859-1] (original) +++ trunk/reactos/include/psdk/msxml2.idl [iso-8859-1] Fri Oct 9 09:12:57 2015 @@ -1258,7 +1258,7 @@ [id(DISPID_XMLDOM_PROCESSOR_SETSTARTMODE)] HRESULT setStartMode( [in] BSTR p, - [in, defaultvalue("")] BSTR uri); + [in, defaultvalue(L"")] BSTR uri); [propget, id(DISPID_XMLDOM_PROCESSOR_STARTMODE)] HRESULT startMode([retval, out] BSTR *p);

1 0

[rnaumann] 69470: [SHELL32] Update German translation
by rnaumann＠svn.reactos.org 09 Oct '15

09 Oct '15

Author: rnaumann Date: Fri Oct 9 06:26:34 2015 New Revision: 69470 URL: http://svn.reactos.org/svn/reactos?rev=69470&view=rev Log: [SHELL32] Update German translation Modified: trunk/reactos/dll/win32/shell32/lang/de-DE.rc Modified: trunk/reactos/dll/win32/shell32/lang/de-DE.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/lang/de-… ============================================================================== --- trunk/reactos/dll/win32/shell32/lang/de-DE.rc [iso-8859-1] (original) +++ trunk/reactos/dll/win32/shell32/lang/de-DE.rc [iso-8859-1] Fri Oct 9 06:26:34 2015 @@ -819,6 +819,6 @@ IDS_EXE_DESCRIPTION "Beschreibung:" IDS_MENU_EMPTY "(Leer)" - IDS_OBJECTS "%d Objects" - IDS_OBJECTS_SELECTED "%d Objects Selected" -END + IDS_OBJECTS "%d Objekte" + IDS_OBJECTS_SELECTED "%d Objekte ausgewÃ¤hlt" +END

1 0

[gadamopoulos] 69469: [SHELL32] - "Fix" SHChangeNotifyRegister to report file system changes. I am not really sure if these changes are correct but really make it work now. CORE-1171
by gadamopoulos＠svn.reactos.org 09 Oct '15

09 Oct '15

Author: gadamopoulos Date: Fri Oct 9 00:31:47 2015 New Revision: 69469 URL: http://svn.reactos.org/svn/reactos?rev=69469&view=rev Log: [SHELL32] - "Fix" SHChangeNotifyRegister to report file system changes. I am not really sure if these changes are correct but really make it work now. CORE-1171 Modified: trunk/reactos/dll/win32/shell32/CDefView.cpp trunk/reactos/dll/win32/shell32/wine/changenotify.c Modified: trunk/reactos/dll/win32/shell32/CDefView.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/CDefView… ============================================================================== --- trunk/reactos/dll/win32/shell32/CDefView.cpp [iso-8859-1] (original) +++ trunk/reactos/dll/win32/shell32/CDefView.cpp [iso-8859-1] Fri Oct 9 00:31:47 2015 @@ -1979,7 +1979,7 @@ TRACE("(%p)(%p,%p,0x%08x)\n", this, Pidls[0], Pidls[1], lParam); - switch (lParam) + switch (lParam &~ SHCNE_INTERRUPT) { case SHCNE_MKDIR: case SHCNE_CREATE: Modified: trunk/reactos/dll/win32/shell32/wine/changenotify.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/wine/cha… ============================================================================== --- trunk/reactos/dll/win32/shell32/wine/changenotify.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/shell32/wine/changenotify.c [iso-8859-1] Fri Oct 9 00:31:47 2015 @@ -378,11 +378,11 @@ } if( ( ( wEventId & SHCNE_NOITEMEVENTS ) && - ( wEventId & ~SHCNE_NOITEMEVENTS ) ) || + ( wEventId & ~(SHCNE_NOITEMEVENTS | SHCNE_INTERRUPT) ) ) || ( ( wEventId & SHCNE_ONEITEMEVENTS ) && - ( wEventId & ~SHCNE_ONEITEMEVENTS ) ) || + ( wEventId & ~(SHCNE_ONEITEMEVENTS | SHCNE_INTERRUPT) ) ) || ( ( wEventId & SHCNE_TWOITEMEVENTS ) && - ( wEventId & ~SHCNE_TWOITEMEVENTS ) ) ) + ( wEventId & ~(SHCNE_TWOITEMEVENTS | SHCNE_INTERRUPT) ) ) ) { WARN("mutually incompatible events listed\n"); return; @@ -692,12 +692,14 @@ LPNOTIFYREGISTER item = (LPNOTIFYREGISTER) lpOverlapped->hEvent; TRACE("_NotificationCompletion\n"); +#if 0 if (dwErrorCode == ERROR_OPERATION_ABORTED) { /* Command was induced by CancelIo in the shutdown procedure. */ TRACE("_NotificationCompletion ended.\n"); return; } +#endif /* This likely means overflow, so force whole directory refresh. */ if (!dwNumberOfBytesTransfered)

1 0

[gadamopoulos] 69468: [SHELL32] - CDefView: Implement updating the status bar . Based on patch by Barrett Karish CORE-10300
by gadamopoulos＠svn.reactos.org 09 Oct '15

09 Oct '15

Author: gadamopoulos Date: Fri Oct 9 00:27:34 2015 New Revision: 69468 URL: http://svn.reactos.org/svn/reactos?rev=69468&view=rev Log: [SHELL32] - CDefView: Implement updating the status bar . Based on patch by Barrett Karish CORE-10300 Modified: trunk/reactos/dll/win32/shell32/CDefView.cpp trunk/reactos/dll/win32/shell32/lang/bg-BG.rc trunk/reactos/dll/win32/shell32/lang/ca-ES.rc trunk/reactos/dll/win32/shell32/lang/cs-CZ.rc trunk/reactos/dll/win32/shell32/lang/da-DK.rc trunk/reactos/dll/win32/shell32/lang/de-DE.rc trunk/reactos/dll/win32/shell32/lang/el-GR.rc trunk/reactos/dll/win32/shell32/lang/en-GB.rc trunk/reactos/dll/win32/shell32/lang/en-US.rc trunk/reactos/dll/win32/shell32/lang/es-ES.rc trunk/reactos/dll/win32/shell32/lang/fi-FI.rc trunk/reactos/dll/win32/shell32/lang/fr-FR.rc trunk/reactos/dll/win32/shell32/lang/he-IL.rc trunk/reactos/dll/win32/shell32/lang/hu-HU.rc trunk/reactos/dll/win32/shell32/lang/it-IT.rc trunk/reactos/dll/win32/shell32/lang/ja-JP.rc trunk/reactos/dll/win32/shell32/lang/ko-KR.rc trunk/reactos/dll/win32/shell32/lang/nl-NL.rc trunk/reactos/dll/win32/shell32/lang/no-NO.rc trunk/reactos/dll/win32/shell32/lang/pl-PL.rc trunk/reactos/dll/win32/shell32/lang/pt-BR.rc trunk/reactos/dll/win32/shell32/lang/pt-PT.rc trunk/reactos/dll/win32/shell32/lang/ro-RO.rc trunk/reactos/dll/win32/shell32/lang/ru-RU.rc trunk/reactos/dll/win32/shell32/lang/sk-SK.rc trunk/reactos/dll/win32/shell32/lang/sl-SI.rc trunk/reactos/dll/win32/shell32/lang/sq-AL.rc trunk/reactos/dll/win32/shell32/lang/sv-SE.rc trunk/reactos/dll/win32/shell32/lang/tr-TR.rc trunk/reactos/dll/win32/shell32/lang/uk-UA.rc trunk/reactos/dll/win32/shell32/lang/zh-CN.rc trunk/reactos/dll/win32/shell32/lang/zh-TW.rc trunk/reactos/dll/win32/shell32/shresdef.h Modified: trunk/reactos/dll/win32/shell32/CDefView.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/CDefView… ============================================================================== --- trunk/reactos/dll/win32/shell32/CDefView.cpp [iso-8859-1] (original) +++ trunk/reactos/dll/win32/shell32/CDefView.cpp [iso-8859-1] Fri Oct 9 00:27:34 2015 @@ -125,6 +125,7 @@ HRESULT IncludeObject(PCUITEMID_CHILD pidl); HRESULT OnDefaultCommand(); HRESULT OnStateChange(UINT uFlags); + void UpdateStatusbar(); void CheckToolbar(); void SetStyle(DWORD dwAdd, DWORD dwRemove); BOOL CreateList(); @@ -467,6 +468,26 @@ m_pShellBrowser->SendControlMsg(FCW_TOOLBAR, TB_ENABLEBUTTON, FCIDM_TB_REPORTVIEW, TRUE, &result); } +} + +void CDefView::UpdateStatusbar() +{ + WCHAR szFormat[MAX_PATH] = {0}; + WCHAR szObjects[MAX_PATH] = {0}; + UINT cSelectedItems; + + cSelectedItems = m_ListView.GetSelectedCount(); + if (cSelectedItems) + { + LoadStringW(shell32_hInstance, IDS_OBJECTS_SELECTED, szFormat, _countof(szFormat)); + StringCchPrintfW(szObjects, MAX_PATH, szFormat, cSelectedItems); + } + else + { + LoadStringW(shell32_hInstance, IDS_OBJECTS, szFormat, _countof(szFormat)); + StringCchPrintfW(szObjects, MAX_PATH, szFormat, m_ListView.GetItemCount()); + } + m_pShellBrowser->SetStatusTextSB(szObjects); } /********************************************************** @@ -1071,6 +1092,8 @@ m_hAccel = LoadAcceleratorsW(shell32_hInstance, MAKEINTRESOURCEW(IDA_SHELLVIEW)); + UpdateStatusbar(); + return S_OK; } @@ -1822,6 +1845,7 @@ case LVN_ITEMCHANGED: TRACE("-- LVN_ITEMCHANGED %p\n", this); OnStateChange(CDBOSC_SELCHANGE); /* the browser will get the IDataObject now */ + UpdateStatusbar(); break; case LVN_BEGINDRAG: Modified: trunk/reactos/dll/win32/shell32/lang/bg-BG.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/lang/bg-… ============================================================================== --- trunk/reactos/dll/win32/shell32/lang/bg-BG.rc [iso-8859-1] (original) +++ trunk/reactos/dll/win32/shell32/lang/bg-BG.rc [iso-8859-1] Fri Oct 9 00:27:34 2015 @@ -818,4 +818,6 @@ IDS_EXE_DESCRIPTION "Description:" IDS_MENU_EMPTY "(Empty)" -END + IDS_OBJECTS "%d Objects" + IDS_OBJECTS_SELECTED "%d Objects Selected" +END Modified: trunk/reactos/dll/win32/shell32/lang/ca-ES.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/lang/ca-… ============================================================================== --- trunk/reactos/dll/win32/shell32/lang/ca-ES.rc [iso-8859-1] (original) +++ trunk/reactos/dll/win32/shell32/lang/ca-ES.rc [iso-8859-1] Fri Oct 9 00:27:34 2015 @@ -818,4 +818,6 @@ IDS_EXE_DESCRIPTION "Description:" IDS_MENU_EMPTY "(Empty)" -END + IDS_OBJECTS "%d Objects" + IDS_OBJECTS_SELECTED "%d Objects Selected" +END Modified: trunk/reactos/dll/win32/shell32/lang/cs-CZ.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/lang/cs-… ============================================================================== --- trunk/reactos/dll/win32/shell32/lang/cs-CZ.rc [iso-8859-1] (original) +++ trunk/reactos/dll/win32/shell32/lang/cs-CZ.rc [iso-8859-1] Fri Oct 9 00:27:34 2015 @@ -824,4 +824,6 @@ IDS_EXE_DESCRIPTION "Popis:" IDS_MENU_EMPTY "(PrÃ¡zdnÃ©)" -END + IDS_OBJECTS "%d Objects" + IDS_OBJECTS_SELECTED "%d Objects Selected" +END Modified: trunk/reactos/dll/win32/shell32/lang/da-DK.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/lang/da-… ============================================================================== --- trunk/reactos/dll/win32/shell32/lang/da-DK.rc [iso-8859-1] (original) +++ trunk/reactos/dll/win32/shell32/lang/da-DK.rc [iso-8859-1] Fri Oct 9 00:27:34 2015 @@ -824,4 +824,6 @@ IDS_EXE_DESCRIPTION "Description:" IDS_MENU_EMPTY "(Empty)" -END + IDS_OBJECTS "%d Objects" + IDS_OBJECTS_SELECTED "%d Objects Selected" +END Modified: trunk/reactos/dll/win32/shell32/lang/de-DE.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/lang/de-… ============================================================================== --- trunk/reactos/dll/win32/shell32/lang/de-DE.rc [iso-8859-1] (original) +++ trunk/reactos/dll/win32/shell32/lang/de-DE.rc [iso-8859-1] Fri Oct 9 00:27:34 2015 @@ -819,4 +819,6 @@ IDS_EXE_DESCRIPTION "Beschreibung:" IDS_MENU_EMPTY "(Leer)" -END + IDS_OBJECTS "%d Objects" + IDS_OBJECTS_SELECTED "%d Objects Selected" +END Modified: trunk/reactos/dll/win32/shell32/lang/el-GR.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/lang/el-… ============================================================================== --- trunk/reactos/dll/win32/shell32/lang/el-GR.rc [iso-8859-1] (original) +++ trunk/reactos/dll/win32/shell32/lang/el-GR.rc [iso-8859-1] Fri Oct 9 00:27:34 2015 @@ -818,4 +818,6 @@ IDS_EXE_DESCRIPTION "Description:" IDS_MENU_EMPTY "(Empty)" -END + IDS_OBJECTS "%d Objects" + IDS_OBJECTS_SELECTED "%d Objects Selected" +END Modified: trunk/reactos/dll/win32/shell32/lang/en-GB.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/lang/en-… ============================================================================== --- trunk/reactos/dll/win32/shell32/lang/en-GB.rc [iso-8859-1] (original) +++ trunk/reactos/dll/win32/shell32/lang/en-GB.rc [iso-8859-1] Fri Oct 9 00:27:34 2015 @@ -818,4 +818,6 @@ IDS_EXE_DESCRIPTION "Description:" IDS_MENU_EMPTY "(Empty)" -END + IDS_OBJECTS "%d Objects" + IDS_OBJECTS_SELECTED "%d Objects Selected" +END Modified: trunk/reactos/dll/win32/shell32/lang/en-US.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/lang/en-… ============================================================================== --- trunk/reactos/dll/win32/shell32/lang/en-US.rc [iso-8859-1] (original) +++ trunk/reactos/dll/win32/shell32/lang/en-US.rc [iso-8859-1] Fri Oct 9 00:27:34 2015 @@ -818,4 +818,6 @@ IDS_EXE_DESCRIPTION "Description:" IDS_MENU_EMPTY "(Empty)" -END + IDS_OBJECTS "%d Objects" + IDS_OBJECTS_SELECTED "%d Objects Selected" +END Modified: trunk/reactos/dll/win32/shell32/lang/es-ES.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/lang/es-… ============================================================================== --- trunk/reactos/dll/win32/shell32/lang/es-ES.rc [iso-8859-1] (original) +++ trunk/reactos/dll/win32/shell32/lang/es-ES.rc [iso-8859-1] Fri Oct 9 00:27:34 2015 @@ -819,4 +819,6 @@ IDS_EXE_DESCRIPTION "DescripciÃ³n:" IDS_MENU_EMPTY "(VacÃo)" -END + IDS_OBJECTS "%d Objects" + IDS_OBJECTS_SELECTED "%d Objects Selected" +END Modified: trunk/reactos/dll/win32/shell32/lang/fi-FI.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/lang/fi-… ============================================================================== --- trunk/reactos/dll/win32/shell32/lang/fi-FI.rc [iso-8859-1] (original) +++ trunk/reactos/dll/win32/shell32/lang/fi-FI.rc [iso-8859-1] Fri Oct 9 00:27:34 2015 @@ -818,4 +818,6 @@ IDS_EXE_DESCRIPTION "Description:" IDS_MENU_EMPTY "(Empty)" -END + IDS_OBJECTS "%d Objects" + IDS_OBJECTS_SELECTED "%d Objects Selected" +END Modified: trunk/reactos/dll/win32/shell32/lang/fr-FR.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/lang/fr-… ============================================================================== --- trunk/reactos/dll/win32/shell32/lang/fr-FR.rc [iso-8859-1] (original) +++ trunk/reactos/dll/win32/shell32/lang/fr-FR.rc [iso-8859-1] Fri Oct 9 00:27:34 2015 @@ -818,4 +818,6 @@ IDS_EXE_DESCRIPTION "Description :" IDS_MENU_EMPTY "(Vide)" -END + IDS_OBJECTS "%d Objects" + IDS_OBJECTS_SELECTED "%d Objects Selected" +END Modified: trunk/reactos/dll/win32/shell32/lang/he-IL.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/lang/he-… ============================================================================== --- trunk/reactos/dll/win32/shell32/lang/he-IL.rc [iso-8859-1] (original) +++ trunk/reactos/dll/win32/shell32/lang/he-IL.rc [iso-8859-1] Fri Oct 9 00:27:34 2015 @@ -818,4 +818,6 @@ IDS_EXE_DESCRIPTION "Description:" IDS_MENU_EMPTY "(Empty)" -END + IDS_OBJECTS "%d Objects" + IDS_OBJECTS_SELECTED "%d Objects Selected" +END Modified: trunk/reactos/dll/win32/shell32/lang/hu-HU.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/lang/hu-… ============================================================================== --- trunk/reactos/dll/win32/shell32/lang/hu-HU.rc [iso-8859-1] (original) +++ trunk/reactos/dll/win32/shell32/lang/hu-HU.rc [iso-8859-1] Fri Oct 9 00:27:34 2015 @@ -818,4 +818,6 @@ IDS_EXE_DESCRIPTION "Description:" IDS_MENU_EMPTY "(Empty)" -END + IDS_OBJECTS "%d Objects" + IDS_OBJECTS_SELECTED "%d Objects Selected" +END Modified: trunk/reactos/dll/win32/shell32/lang/it-IT.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/lang/it-… ============================================================================== --- trunk/reactos/dll/win32/shell32/lang/it-IT.rc [iso-8859-1] (original) +++ trunk/reactos/dll/win32/shell32/lang/it-IT.rc [iso-8859-1] Fri Oct 9 00:27:34 2015 @@ -818,4 +818,6 @@ IDS_EXE_DESCRIPTION "Descrizione:" IDS_MENU_EMPTY "(Vuoto)" -END + IDS_OBJECTS "%d Objects" + IDS_OBJECTS_SELECTED "%d Objects Selected" +END Modified: trunk/reactos/dll/win32/shell32/lang/ja-JP.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/lang/ja-… ============================================================================== --- trunk/reactos/dll/win32/shell32/lang/ja-JP.rc [iso-8859-1] (original) +++ trunk/reactos/dll/win32/shell32/lang/ja-JP.rc [iso-8859-1] Fri Oct 9 00:27:34 2015 @@ -818,4 +818,6 @@ IDS_EXE_DESCRIPTION "Description:" IDS_MENU_EMPTY "(Empty)" -END + IDS_OBJECTS "%d Objects" + IDS_OBJECTS_SELECTED "%d Objects Selected" +END Modified: trunk/reactos/dll/win32/shell32/lang/ko-KR.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/lang/ko-… ============================================================================== --- trunk/reactos/dll/win32/shell32/lang/ko-KR.rc [iso-8859-1] (original) +++ trunk/reactos/dll/win32/shell32/lang/ko-KR.rc [iso-8859-1] Fri Oct 9 00:27:34 2015 @@ -818,4 +818,6 @@ IDS_EXE_DESCRIPTION "Description:" IDS_MENU_EMPTY "(Empty)" -END + IDS_OBJECTS "%d Objects" + IDS_OBJECTS_SELECTED "%d Objects Selected" +END Modified: trunk/reactos/dll/win32/shell32/lang/nl-NL.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/lang/nl-… ============================================================================== --- trunk/reactos/dll/win32/shell32/lang/nl-NL.rc [iso-8859-1] (original) +++ trunk/reactos/dll/win32/shell32/lang/nl-NL.rc [iso-8859-1] Fri Oct 9 00:27:34 2015 @@ -818,4 +818,6 @@ IDS_EXE_DESCRIPTION "Description:" IDS_MENU_EMPTY "(Empty)" -END + IDS_OBJECTS "%d Objects" + IDS_OBJECTS_SELECTED "%d Objects Selected" +END Modified: trunk/reactos/dll/win32/shell32/lang/no-NO.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/lang/no-… ============================================================================== --- trunk/reactos/dll/win32/shell32/lang/no-NO.rc [iso-8859-1] (original) +++ trunk/reactos/dll/win32/shell32/lang/no-NO.rc [iso-8859-1] Fri Oct 9 00:27:34 2015 @@ -818,4 +818,6 @@ IDS_EXE_DESCRIPTION "Description:" IDS_MENU_EMPTY "(Empty)" -END + IDS_OBJECTS "%d Objects" + IDS_OBJECTS_SELECTED "%d Objects Selected" +END Modified: trunk/reactos/dll/win32/shell32/lang/pl-PL.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/lang/pl-… ============================================================================== --- trunk/reactos/dll/win32/shell32/lang/pl-PL.rc [iso-8859-1] (original) +++ trunk/reactos/dll/win32/shell32/lang/pl-PL.rc [iso-8859-1] Fri Oct 9 00:27:34 2015 @@ -822,4 +822,6 @@ IDS_EXE_DESCRIPTION "Opis:" IDS_MENU_EMPTY "(Puste)" -END + IDS_OBJECTS "%d Objects" + IDS_OBJECTS_SELECTED "%d Objects Selected" +END Modified: trunk/reactos/dll/win32/shell32/lang/pt-BR.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/lang/pt-… ============================================================================== --- trunk/reactos/dll/win32/shell32/lang/pt-BR.rc [iso-8859-1] (original) +++ trunk/reactos/dll/win32/shell32/lang/pt-BR.rc [iso-8859-1] Fri Oct 9 00:27:34 2015 @@ -818,4 +818,6 @@ IDS_EXE_DESCRIPTION "DescriÃ§Ã£o:" IDS_MENU_EMPTY "(Empty)" -END + IDS_OBJECTS "%d Objects" + IDS_OBJECTS_SELECTED "%d Objects Selected" +END Modified: trunk/reactos/dll/win32/shell32/lang/pt-PT.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/lang/pt-… ============================================================================== --- trunk/reactos/dll/win32/shell32/lang/pt-PT.rc [iso-8859-1] (original) +++ trunk/reactos/dll/win32/shell32/lang/pt-PT.rc [iso-8859-1] Fri Oct 9 00:27:34 2015 @@ -818,4 +818,6 @@ IDS_EXE_DESCRIPTION "Description:" IDS_MENU_EMPTY "(Empty)" -END + IDS_OBJECTS "%d Objects" + IDS_OBJECTS_SELECTED "%d Objects Selected" +END Modified: trunk/reactos/dll/win32/shell32/lang/ro-RO.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/lang/ro-… ============================================================================== --- trunk/reactos/dll/win32/shell32/lang/ro-RO.rc [iso-8859-1] (original) +++ trunk/reactos/dll/win32/shell32/lang/ro-RO.rc [iso-8859-1] Fri Oct 9 00:27:34 2015 @@ -820,4 +820,6 @@ IDS_EXE_DESCRIPTION "Descriere:" IDS_MENU_EMPTY "(Gol)" -END + IDS_OBJECTS "%d Objects" + IDS_OBJECTS_SELECTED "%d Objects Selected" +END Modified: trunk/reactos/dll/win32/shell32/lang/ru-RU.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/lang/ru-… ============================================================================== --- trunk/reactos/dll/win32/shell32/lang/ru-RU.rc [iso-8859-1] (original) +++ trunk/reactos/dll/win32/shell32/lang/ru-RU.rc [iso-8859-1] Fri Oct 9 00:27:34 2015 @@ -820,4 +820,6 @@ IDS_EXE_DESCRIPTION "ÐÐ¿Ð¸ÑÐ°Ð½Ð¸Ðµ:" IDS_MENU_EMPTY "(Ð¿ÑÑÑÐ¾)" -END + IDS_OBJECTS "%d Objects" + IDS_OBJECTS_SELECTED "%d Objects Selected" +END Modified: trunk/reactos/dll/win32/shell32/lang/sk-SK.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/lang/sk-… ============================================================================== --- trunk/reactos/dll/win32/shell32/lang/sk-SK.rc [iso-8859-1] (original) +++ trunk/reactos/dll/win32/shell32/lang/sk-SK.rc [iso-8859-1] Fri Oct 9 00:27:34 2015 @@ -818,4 +818,6 @@ IDS_EXE_DESCRIPTION "Description:" IDS_MENU_EMPTY "(Empty)" -END + IDS_OBJECTS "%d Objects" + IDS_OBJECTS_SELECTED "%d Objects Selected" +END Modified: trunk/reactos/dll/win32/shell32/lang/sl-SI.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/lang/sl-… ============================================================================== --- trunk/reactos/dll/win32/shell32/lang/sl-SI.rc [iso-8859-1] (original) +++ trunk/reactos/dll/win32/shell32/lang/sl-SI.rc [iso-8859-1] Fri Oct 9 00:27:34 2015 @@ -818,4 +818,6 @@ IDS_EXE_DESCRIPTION "Description:" IDS_MENU_EMPTY "(Empty)" -END + IDS_OBJECTS "%d Objects" + IDS_OBJECTS_SELECTED "%d Objects Selected" +END Modified: trunk/reactos/dll/win32/shell32/lang/sq-AL.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/lang/sq-… ============================================================================== --- trunk/reactos/dll/win32/shell32/lang/sq-AL.rc [iso-8859-1] (original) +++ trunk/reactos/dll/win32/shell32/lang/sq-AL.rc [iso-8859-1] Fri Oct 9 00:27:34 2015 @@ -822,4 +822,6 @@ IDS_EXE_DESCRIPTION "PÃ«rshkrimi:" IDS_MENU_EMPTY "(Empty)" -END + IDS_OBJECTS "%d Objects" + IDS_OBJECTS_SELECTED "%d Objects Selected" +END Modified: trunk/reactos/dll/win32/shell32/lang/sv-SE.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/lang/sv-… ============================================================================== --- trunk/reactos/dll/win32/shell32/lang/sv-SE.rc [iso-8859-1] (original) +++ trunk/reactos/dll/win32/shell32/lang/sv-SE.rc [iso-8859-1] Fri Oct 9 00:27:34 2015 @@ -818,4 +818,6 @@ IDS_EXE_DESCRIPTION "Description:" IDS_MENU_EMPTY "(Empty)" -END + IDS_OBJECTS "%d Objects" + IDS_OBJECTS_SELECTED "%d Objects Selected" +END Modified: trunk/reactos/dll/win32/shell32/lang/tr-TR.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/lang/tr-… ============================================================================== --- trunk/reactos/dll/win32/shell32/lang/tr-TR.rc [iso-8859-1] (original) +++ trunk/reactos/dll/win32/shell32/lang/tr-TR.rc [iso-8859-1] Fri Oct 9 00:27:34 2015 @@ -818,4 +818,6 @@ IDS_EXE_DESCRIPTION "AÃ§Ä±klama:" IDS_MENU_EMPTY "(Empty)" -END + IDS_OBJECTS "%d Objects" + IDS_OBJECTS_SELECTED "%d Objects Selected" +END Modified: trunk/reactos/dll/win32/shell32/lang/uk-UA.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/lang/uk-… ============================================================================== --- trunk/reactos/dll/win32/shell32/lang/uk-UA.rc [iso-8859-1] (original) +++ trunk/reactos/dll/win32/shell32/lang/uk-UA.rc [iso-8859-1] Fri Oct 9 00:27:34 2015 @@ -818,4 +818,6 @@ IDS_EXE_DESCRIPTION "Description:" IDS_MENU_EMPTY "(Empty)" -END + IDS_OBJECTS "%d Objects" + IDS_OBJECTS_SELECTED "%d Objects Selected" +END Modified: trunk/reactos/dll/win32/shell32/lang/zh-CN.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/lang/zh-… ============================================================================== --- trunk/reactos/dll/win32/shell32/lang/zh-CN.rc [iso-8859-1] (original) +++ trunk/reactos/dll/win32/shell32/lang/zh-CN.rc [iso-8859-1] Fri Oct 9 00:27:34 2015 @@ -825,4 +825,6 @@ IDS_EXE_DESCRIPTION "æè¿°ï¼" IDS_MENU_EMPTY "(ç©º)" -END + IDS_OBJECTS "%d Objects" + IDS_OBJECTS_SELECTED "%d Objects Selected" +END Modified: trunk/reactos/dll/win32/shell32/lang/zh-TW.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/lang/zh-… ============================================================================== --- trunk/reactos/dll/win32/shell32/lang/zh-TW.rc [iso-8859-1] (original) +++ trunk/reactos/dll/win32/shell32/lang/zh-TW.rc [iso-8859-1] Fri Oct 9 00:27:34 2015 @@ -826,4 +826,6 @@ IDS_EXE_DESCRIPTION "Description:" IDS_MENU_EMPTY "(Empty)" -END + IDS_OBJECTS "%d Objects" + IDS_OBJECTS_SELECTED "%d Objects Selected" +END Modified: trunk/reactos/dll/win32/shell32/shresdef.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/shresdef… ============================================================================== --- trunk/reactos/dll/win32/shell32/shresdef.h [iso-8859-1] (original) +++ trunk/reactos/dll/win32/shell32/shresdef.h [iso-8859-1] Fri Oct 9 00:27:34 2015 @@ -225,6 +225,8 @@ #define IDS_MYCOMPUTER 9216 #define IDS_PERSONAL 9227 #define IDS_NETWORKPLACE 9217 +#define IDS_OBJECTS 6466 +#define IDS_OBJECTS_SELECTED 6477 /* Dialogs */

1 0

[sginsberg] 69467: Fix the fix
by sginsberg＠svn.reactos.org 08 Oct '15

08 Oct '15

Author: sginsberg Date: Thu Oct 8 17:19:40 2015 New Revision: 69467 URL: http://svn.reactos.org/svn/reactos?rev=69467&view=rev Log: Fix the fix Modified: trunk/reactos/dll/win32/kernel32/client/i386/fiber.S Modified: trunk/reactos/dll/win32/kernel32/client/i386/fiber.S URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/client/… ============================================================================== --- trunk/reactos/dll/win32/kernel32/client/i386/fiber.S [iso-8859-1] (original) +++ trunk/reactos/dll/win32/kernel32/client/i386/fiber.S [iso-8859-1] Thu Oct 8 17:19:40 2015 @@ -26,6 +26,7 @@ /* Start the thread with our parameters */ push dword ptr [eax+FIBER_CONTEXT_EBX] push dword ptr [eax+FIBER_CONTEXT_EAX] + push 0 jmp _BaseThreadStartup@8 ENDFUNC

1 0

[sginsberg] 69466: [KERNEL32] Fix bug in CreateFiberEx that made it replace the CONTEXT_FULL bits rather than ORing in CONTEXT_FLOATING_POINT when caller wanted FPU state saved. SwitchToFiber check...
by sginsberg＠svn.reactos.org 08 Oct '15

08 Oct '15

Author: sginsberg Date: Thu Oct 8 16:26:29 2015 New Revision: 69466 URL: http://svn.reactos.org/svn/reactos?rev=69466&view=rev Log: [KERNEL32] Fix bug in CreateFiberEx that made it replace the CONTEXT_FULL bits rather than ORing in CONTEXT_FLOATING_POINT when caller wanted FPU state saved. SwitchToFiber checks for CONTEXT_FULL OR CONTEXT_FLOATING_POINT so the save/restore would fail. Moreover, fix BaseInitializeContext that was not checking CONTEXT_FLOATING_POINT correctly for some fibers and, as a result, not initializing FPU context correctly for callers of ConvertThreadToFiberEx. Finally, because trying to access address 0x6 is generally a bad idea, fix SwitchToFiber to use the correct shared user data offsets. Misc cleanup all around. Bonus: Sort TEB/PEB asm offsets and add GDI Batch Count offset, needed soon. Modified: trunk/reactos/dll/win32/kernel32/client/fiber.c trunk/reactos/dll/win32/kernel32/client/i386/fiber.S trunk/reactos/dll/win32/kernel32/client/utils.c trunk/reactos/include/asm/ks386.template.h trunk/reactos/include/ndk/i386/asm.h Modified: trunk/reactos/dll/win32/kernel32/client/fiber.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/client/… ============================================================================== --- trunk/reactos/dll/win32/kernel32/client/fiber.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/kernel32/client/fiber.c [iso-8859-1] Thu Oct 8 16:26:29 2015 @@ -27,10 +27,9 @@ VOID WINAPI -BaseRundownFls(IN PVOID FlsData) +BaseRundownFls(_In_ PVOID FlsData) { /* No FLS support yet */ - } /* PUBLIC FUNCTIONS ***********************************************************/ @@ -55,16 +54,18 @@ return FALSE; } - /* this thread won't run a fiber anymore */ + /* This thread won't run a fiber anymore */ Teb->HasFiberData = FALSE; FiberData = Teb->NtTib.FiberData; Teb->NtTib.FiberData = NULL; /* Free the fiber */ ASSERT(FiberData != NULL); - RtlFreeHeap(GetProcessHeap(), 0, FiberData); - - /* success */ + RtlFreeHeap(GetProcessHeap(), + 0, + FiberData); + + /* Success */ return TRUE; } @@ -73,15 +74,15 @@ */ LPVOID WINAPI -ConvertThreadToFiberEx(LPVOID lpParameter, - DWORD dwFlags) +ConvertThreadToFiberEx(_In_opt_ LPVOID lpParameter, + _In_ DWORD dwFlags) { PTEB Teb; PFIBER Fiber; DPRINT1("Converting Thread to Fiber\n"); /* Check for invalid flags */ - if (dwFlags &~ FIBER_FLAG_FLOAT_SWITCH) + if (dwFlags & ~FIBER_FLAG_FLOAT_SWITCH) { /* Fail */ SetLastError(ERROR_INVALID_PARAMETER); @@ -98,9 +99,12 @@ } /* Allocate the fiber */ - Fiber = RtlAllocateHeap(RtlGetProcessHeap(), 0, sizeof(FIBER)); + Fiber = RtlAllocateHeap(RtlGetProcessHeap(), + 0, + sizeof(FIBER)); if (!Fiber) { + /* Fail */ SetLastError(ERROR_NOT_ENOUGH_MEMORY); return NULL; } @@ -114,13 +118,11 @@ Fiber->FlsData = Teb->FlsData; Fiber->GuaranteedStackBytes = Teb->GuaranteedStackBytes; Fiber->ActivationContextStackPointer = Teb->ActivationContextStackPointer; - Fiber->FiberContext.ContextFlags = CONTEXT_FULL; - - /* Save FPU State if requested */ - if (dwFlags & FIBER_FLAG_FLOAT_SWITCH) - { - Fiber->FiberContext.ContextFlags |= CONTEXT_FLOATING_POINT; - } + + /* Save FPU State if requested, otherwise just the basic registers */ + Fiber->FiberContext.ContextFlags = (dwFlags & FIBER_FLAG_FLOAT_SWITCH) ? + (CONTEXT_FULL | CONTEXT_FLOATING_POINT) : + CONTEXT_FULL; /* Associate the fiber to the current thread */ Teb->NtTib.FiberData = Fiber; @@ -135,10 +137,11 @@ */ LPVOID WINAPI -ConvertThreadToFiber(LPVOID lpParameter) +ConvertThreadToFiber(_In_opt_ LPVOID lpParameter) { /* Call the newer function */ - return ConvertThreadToFiberEx(lpParameter, 0); + return ConvertThreadToFiberEx(lpParameter, + 0); } /* @@ -146,12 +149,16 @@ */ LPVOID WINAPI -CreateFiber(SIZE_T dwStackSize, - LPFIBER_START_ROUTINE lpStartAddress, - LPVOID lpParameter) +CreateFiber(_In_ SIZE_T dwStackSize, + _In_ LPFIBER_START_ROUTINE lpStartAddress, + _In_opt_ LPVOID lpParameter) { /* Call the Newer Function */ - return CreateFiberEx(dwStackSize, 0, 0, lpStartAddress, lpParameter); + return CreateFiberEx(dwStackSize, + 0, + 0, + lpStartAddress, + lpParameter); } /* @@ -159,20 +166,20 @@ */ LPVOID WINAPI -CreateFiberEx(SIZE_T dwStackCommitSize, - SIZE_T dwStackReserveSize, - DWORD dwFlags, - LPFIBER_START_ROUTINE lpStartAddress, - LPVOID lpParameter) +CreateFiberEx(_In_ SIZE_T dwStackCommitSize, + _In_ SIZE_T dwStackReserveSize, + _In_ DWORD dwFlags, + _In_ LPFIBER_START_ROUTINE lpStartAddress, + _In_opt_ LPVOID lpParameter) { PFIBER Fiber; NTSTATUS Status; INITIAL_TEB InitialTeb; - PACTIVATION_CONTEXT_STACK ActivationContextStackPointer = NULL; + PACTIVATION_CONTEXT_STACK ActivationContextStackPointer; DPRINT("Creating Fiber\n"); /* Check for invalid flags */ - if (dwFlags &~ FIBER_FLAG_FLOAT_SWITCH) + if (dwFlags & ~FIBER_FLAG_FLOAT_SWITCH) { /* Fail */ SetLastError(ERROR_INVALID_PARAMETER); @@ -180,6 +187,7 @@ } /* Allocate the Activation Context Stack */ + ActivationContextStackPointer = NULL; Status = RtlAllocateActivationContextStack(&ActivationContextStackPointer); if (!NT_SUCCESS(Status)) { @@ -189,7 +197,9 @@ } /* Allocate the fiber */ - Fiber = RtlAllocateHeap(RtlGetProcessHeap(), 0, sizeof(FIBER)); + Fiber = RtlAllocateHeap(RtlGetProcessHeap(), + 0, + sizeof(FIBER)); if (!Fiber) { /* Free the activation context stack */ @@ -208,7 +218,9 @@ if (!NT_SUCCESS(Status)) { /* Free the fiber */ - RtlFreeHeap(GetProcessHeap(), 0, Fiber); + RtlFreeHeap(GetProcessHeap(), + 0, + Fiber); /* Free the activation context stack */ RtlFreeActivationContextStack(ActivationContextStackPointer); @@ -219,7 +231,8 @@ } /* Clear the context */ - RtlZeroMemory(&Fiber->FiberContext, sizeof(CONTEXT)); + RtlZeroMemory(&Fiber->FiberContext, + sizeof(CONTEXT)); /* Copy the data into the fiber */ Fiber->StackBase = InitialTeb.StackBase; @@ -230,12 +243,13 @@ Fiber->GuaranteedStackBytes = 0; Fiber->FlsData = NULL; Fiber->ActivationContextStackPointer = ActivationContextStackPointer; - Fiber->FiberContext.ContextFlags = CONTEXT_FULL; - - /* Save FPU State if requested */ - Fiber->FiberContext.ContextFlags = (dwFlags & FIBER_FLAG_FLOAT_SWITCH) ? CONTEXT_FLOATING_POINT : 0; - - /* initialize the context for the fiber */ + + /* Save FPU State if requested, otherwise just the basic registers */ + Fiber->FiberContext.ContextFlags = (dwFlags & FIBER_FLAG_FLOAT_SWITCH) ? + (CONTEXT_FULL | CONTEXT_FLOATING_POINT) : + CONTEXT_FULL; + + /* Initialize the context for the fiber */ BaseInitializeContext(&Fiber->FiberContext, lpParameter, lpStartAddress, @@ -251,17 +265,24 @@ */ VOID WINAPI -DeleteFiber(LPVOID lpFiber) -{ - SIZE_T Size = 0; - PFIBER Fiber = (PFIBER)lpFiber; +DeleteFiber(_In_ LPVOID lpFiber) +{ + SIZE_T Size; + PFIBER Fiber; PTEB Teb; - /* First, exit the thread */ + /* Are we deleting ourselves? */ Teb = NtCurrentTeb(); - if ((Teb->HasFiberData) && (Teb->NtTib.FiberData == Fiber)) ExitThread(1); - - /* Now de-allocate the stack */ + Fiber = (PFIBER)lpFiber; + if ((Teb->HasFiberData) && + (Teb->NtTib.FiberData == Fiber)) + { + /* Just exit */ + ExitThread(1); + } + + /* Not ourselves, de-allocate the stack */ + Size = 0 ; NtFreeVirtualMemory(NtCurrentProcess(), &Fiber->DeallocationStack, &Size, @@ -274,7 +295,9 @@ RtlFreeActivationContextStack(Fiber->ActivationContextStackPointer); /* Free the fiber data */ - RtlFreeHeap(GetProcessHeap(), 0, lpFiber); + RtlFreeHeap(GetProcessHeap(), + 0, + lpFiber); } /* @@ -284,6 +307,7 @@ WINAPI IsThreadAFiber(VOID) { + /* Return flag in the TEB */ return NtCurrentTeb()->HasFiberData; } @@ -349,7 +373,8 @@ */ BOOL WINAPI -FlsSetValue(DWORD dwFlsIndex, PVOID lpFlsData) +FlsSetValue(DWORD dwFlsIndex, + PVOID lpFlsData) { PVOID *ppFlsSlots; TEB *pTeb = NtCurrentTeb(); Modified: trunk/reactos/dll/win32/kernel32/client/i386/fiber.S URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/client/… ============================================================================== --- trunk/reactos/dll/win32/kernel32/client/i386/fiber.S [iso-8859-1] (original) +++ trunk/reactos/dll/win32/kernel32/client/i386/fiber.S [iso-8859-1] Thu Oct 8 16:26:29 2015 @@ -15,21 +15,26 @@ .code PUBLIC _BaseFiberStartup@0 -.PROC _BaseFiberStartup@0 - /* Frame pointer is zeroed */ +FUNC _BaseFiberStartup@0 FPO 0, 0, 0, 0, 0, FRAME_FPO + + /* Note that EBP is already zeroed for us during fiber creation */ /* Get the fiber data */ mov eax, fs:[TEB_FIBER_DATA] - push dword ptr [eax+FIBER_CONTEXT_EBX] /* Parameter */ - push dword ptr [eax+FIBER_CONTEXT_EAX] /* Start Address */ - call _BaseThreadStartup@8 -.ENDP + /* Start the thread with our parameters */ + push dword ptr [eax+FIBER_CONTEXT_EBX] + push dword ptr [eax+FIBER_CONTEXT_EAX] + jmp _BaseThreadStartup@8 + +ENDFUNC PUBLIC _SwitchToFiber@4 -_SwitchToFiber@4: +FUNC _SwitchToFiber@4 + FPO 0, 0, 0, 0, 0, FRAME_FPO + /* Get the TEB */ mov edx, fs:[TEB_SELF] @@ -51,7 +56,7 @@ fnstcw [eax+FIBER_CONTEXT_FLOAT_SAVE_CONTROL_WORD] /* Check if the CPU supports SIMD MXCSR State Save */ - cmp byte ptr ds:[PF_XMMI_INSTRUCTIONS_AVAILABLE], 1 + cmp byte ptr ds:[USER_SHARED_DATA + USER_SHARED_DATA_PROCESSOR_FEATURES + PF_XMMI_INSTRUCTIONS_AVAILABLE], 1 jnz NoFpuStateSave stmxcsr [eax+FIBER_CONTEXT_DR6] @@ -109,13 +114,13 @@ StatusWordChanged: /* Load the new one */ - mov word ptr [ecx+FIBER_CONTEXT_FLOAT_SAVE_TAG_WORD], HEX(0FFFF) + mov word ptr [ecx+FIBER_CONTEXT_FLOAT_SAVE_TAG_WORD], HEX(FFFF) fldenv [ecx+FIBER_CONTEXT_FLOAT_SAVE_CONTROL_WORD] ControlWordEqual: /* Load the new one */ - cmp byte ptr ds:[PF_XMMI_INSTRUCTIONS_AVAILABLE], 1 + cmp byte ptr ds:[USER_SHARED_DATA + USER_SHARED_DATA_PROCESSOR_FEATURES + PF_XMMI_INSTRUCTIONS_AVAILABLE], 1 jnz NoFpuStateRestore ldmxcsr [ecx+FIBER_CONTEXT_DR6] @@ -136,6 +141,7 @@ mov esp, [ecx+FIBER_CONTEXT_ESP] ret 4 +ENDFUNC END /* EOF */ Modified: trunk/reactos/dll/win32/kernel32/client/utils.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/client/… ============================================================================== --- trunk/reactos/dll/win32/kernel32/client/utils.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/kernel32/client/utils.c [iso-8859-1] Thu Oct 8 16:26:29 2015 @@ -548,7 +548,7 @@ /* Is FPU state required? */ Context->ContextFlags |= ContextFlags; - if (ContextFlags == CONTEXT_FLOATING_POINT) + if ((ContextFlags & CONTEXT_FLOATING_POINT) == CONTEXT_FLOATING_POINT) { /* Set an initial state */ Context->FloatSave.ControlWord = 0x27F; Modified: trunk/reactos/include/asm/ks386.template.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/asm/ks386.template… ============================================================================== --- trunk/reactos/include/asm/ks386.template.h [iso-8859-1] (original) +++ trunk/reactos/include/asm/ks386.template.h [iso-8859-1] Thu Oct 8 16:26:29 2015 @@ -724,17 +724,20 @@ HEADER("TEB"), OFFSET(TEB_EXCEPTION_LIST, TEB, NtTib.ExceptionList), +OFFSET(TEB_STACK_BASE, TEB, NtTib.StackBase), OFFSET(TEB_STACK_LIMIT, TEB, NtTib.StackLimit), -OFFSET(TEB_STACK_BASE, TEB, NtTib.StackBase), +OFFSET(TEB_FIBER_DATA, TEB, NtTib.FiberData), OFFSET(TEB_SELF, TEB, NtTib.Self), -OFFSET(TEB_FIBER_DATA, TEB, NtTib.FiberData), OFFSET(TEB_PEB, TEB, ProcessEnvironmentBlock), OFFSET(TEB_EXCEPTION_CODE, TEB, ExceptionCode), +OFFSET(TEB_ACTIVATION_CONTEXT_STACK_POINTER, TEB, ActivationContextStackPointer), +OFFSET(TEB_DEALLOCATION_STACK, TEB, DeallocationStack), +OFFSET(TEB_GDI_BATCH_COUNT, TEB, GdiBatchCount), +OFFSET(TEB_GUARANTEED_STACK_BYTES, TEB, GuaranteedStackBytes), +OFFSET(TEB_FLS_DATA, TEB, FlsData), + +HEADER("PEB"), OFFSET(PEB_KERNEL_CALLBACK_TABLE, PEB, KernelCallbackTable), -OFFSET(TEB_FLS_DATA, TEB, FlsData), -OFFSET(TEB_ACTIVATION_CONTEXT_STACK_POINTER, TEB, ActivationContextStackPointer), -OFFSET(TEB_GUARANTEED_STACK_BYTES, TEB, GuaranteedStackBytes), -OFFSET(TEB_DEALLOCATION_STACK, TEB, DeallocationStack), HEADER("Misc"), CONSTANT(NPX_FRAME_LENGTH), @@ -754,4 +757,6 @@ CONSTANT(CONTEXT_ALIGNED_SIZE), CONSTANT(PROCESSOR_FEATURE_FXSR), CONSTANT(KUSER_SHARED_SYSCALL_RET), - +CONSTANT(USER_SHARED_DATA), +CONSTANT(USER_SHARED_DATA_PROCESSOR_FEATURES), + Modified: trunk/reactos/include/ndk/i386/asm.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/ndk/i386/asm.h?rev… ============================================================================== --- trunk/reactos/include/ndk/i386/asm.h [iso-8859-1] (original) +++ trunk/reactos/include/ndk/i386/asm.h [iso-8859-1] Thu Oct 8 16:26:29 2015 @@ -315,13 +315,14 @@ #define FRAME_EDITED 0xFFF8 // -// KUSER_SHARED_DATA Offsets +// USER_SHARED_DATA Offsets // #ifdef __ASM__ #define USER_SHARED_DATA 0xFFDF0000 #endif #define USER_SHARED_DATA_INTERRUPT_TIME 0x8 #define USER_SHARED_DATA_SYSTEM_TIME 0x14 +#define USER_SHARED_DATA_PROCESSOR_FEATURES 0x274 #define USER_SHARED_DATA_TICK_COUNT 0x320 //

1 0

[cfinck] 69465: [DOCUMENTATION] This is my written Bachelor Thesis called "Analysis, Design and Implementation of a Printing Stack for the Open-Source ReactOS Operating System". It's being uploaded...
by cfinck＠svn.reactos.org 08 Oct '15

08 Oct '15

Author: cfinck Date: Thu Oct 8 12:42:43 2015 New Revision: 69465 URL: http://svn.reactos.org/svn/reactos?rev=69465&view=rev Log: [DOCUMENTATION] This is my written Bachelor Thesis called "Analysis, Design and Implementation of a Printing Stack for the Open-Source ReactOS Operating System". It's being uploaded in PDF and in the TeX source files. This can serve as an introduction into the Windows Printing Stack and also detail some specifics of my implementation. Additionally, the tools presented should be useful for newbies into Reverse Engineering. Thanks to all the people who are keeping up ReactOS and thereby giving me the opportunity to make it part of my Bachelor Thesis! Added: trunk/documentation/articles/Printing Stack Thesis/ (with props) trunk/documentation/articles/Printing Stack Thesis/src/ (with props) trunk/documentation/articles/Printing Stack Thesis/src/abstract/ (with props) trunk/documentation/articles/Printing Stack Thesis/src/abstract.tex (with props) trunk/documentation/articles/Printing Stack Thesis/src/abstract/english.tex (with props) trunk/documentation/articles/Printing Stack Thesis/src/abstract/german.tex (with props) trunk/documentation/articles/Printing Stack Thesis/src/appendices/ (with props) trunk/documentation/articles/Printing Stack Thesis/src/appendices.tex (with props) trunk/documentation/articles/Printing Stack Thesis/src/appendices/listings.tex (with props) trunk/documentation/articles/Printing Stack Thesis/src/bibliography.bib (with props) trunk/documentation/articles/Printing Stack Thesis/src/chapters/ (with props) trunk/documentation/articles/Printing Stack Thesis/src/chapters.tex (with props) trunk/documentation/articles/Printing Stack Thesis/src/chapters/basics.tex (with props) trunk/documentation/articles/Printing Stack Thesis/src/chapters/conclusion.tex (with props) trunk/documentation/articles/Printing Stack Thesis/src/chapters/evaluation.tex (with props) trunk/documentation/articles/Printing Stack Thesis/src/chapters/implementation.tex (with props) trunk/documentation/articles/Printing Stack Thesis/src/chapters/introduction.tex (with props) trunk/documentation/articles/Printing Stack Thesis/src/glossary.tex (with props) trunk/documentation/articles/Printing Stack Thesis/src/images/ (with props) trunk/documentation/articles/Printing Stack Thesis/src/images/apimon.png (with props) trunk/documentation/articles/Printing Stack Thesis/src/images/depends.png (with props) trunk/documentation/articles/Printing Stack Thesis/src/images/skiplist_test.png (with props) trunk/documentation/articles/Printing Stack Thesis/src/images/windbg.png (with props) trunk/documentation/articles/Printing Stack Thesis/src/plots/ (with props) trunk/documentation/articles/Printing Stack Thesis/src/plots/16_levels_1000_elements.csv (with props) trunk/documentation/articles/Printing Stack Thesis/src/plots/16_levels_65536_elements.csv (with props) trunk/documentation/articles/Printing Stack Thesis/src/template/ (with props) trunk/documentation/articles/Printing Stack Thesis/src/template/acsthesis.cls (with props) trunk/documentation/articles/Printing Stack Thesis/src/template/config.tex (with props) trunk/documentation/articles/Printing Stack Thesis/src/template/includes.tex (with props) trunk/documentation/articles/Printing Stack Thesis/src/thesis.tcp (with props) trunk/documentation/articles/Printing Stack Thesis/src/thesis.tex (with props) trunk/documentation/articles/Printing Stack Thesis/thesis.pdf (with props) [This mail would be too long, it was shortened to contain the URLs only.] Added: trunk/documentation/articles/Printing Stack Thesis/src/abstract.tex URL: http://svn.reactos.org/svn/reactos/trunk/documentation/articles/Printing%20… Added: trunk/documentation/articles/Printing Stack Thesis/src/abstract/english.tex URL: http://svn.reactos.org/svn/reactos/trunk/documentation/articles/Printing%20… Added: trunk/documentation/articles/Printing Stack Thesis/src/abstract/german.tex URL: http://svn.reactos.org/svn/reactos/trunk/documentation/articles/Printing%20… Added: trunk/documentation/articles/Printing Stack Thesis/src/appendices.tex URL: http://svn.reactos.org/svn/reactos/trunk/documentation/articles/Printing%20… Added: trunk/documentation/articles/Printing Stack Thesis/src/appendices/listings.tex URL: http://svn.reactos.org/svn/reactos/trunk/documentation/articles/Printing%20… Added: trunk/documentation/articles/Printing Stack Thesis/src/bibliography.bib URL: http://svn.reactos.org/svn/reactos/trunk/documentation/articles/Printing%20… Added: trunk/documentation/articles/Printing Stack Thesis/src/chapters.tex URL: http://svn.reactos.org/svn/reactos/trunk/documentation/articles/Printing%20… Added: trunk/documentation/articles/Printing Stack Thesis/src/chapters/basics.tex URL: http://svn.reactos.org/svn/reactos/trunk/documentation/articles/Printing%20… Added: trunk/documentation/articles/Printing Stack Thesis/src/chapters/conclusion.tex URL: http://svn.reactos.org/svn/reactos/trunk/documentation/articles/Printing%20… Added: trunk/documentation/articles/Printing Stack Thesis/src/chapters/evaluation.tex URL: http://svn.reactos.org/svn/reactos/trunk/documentation/articles/Printing%20… Added: trunk/documentation/articles/Printing Stack Thesis/src/chapters/implementation.tex URL: http://svn.reactos.org/svn/reactos/trunk/documentation/articles/Printing%20… Added: trunk/documentation/articles/Printing Stack Thesis/src/chapters/introduction.tex URL: http://svn.reactos.org/svn/reactos/trunk/documentation/articles/Printing%20… Added: trunk/documentation/articles/Printing Stack Thesis/src/glossary.tex URL: http://svn.reactos.org/svn/reactos/trunk/documentation/articles/Printing%20… Added: trunk/documentation/articles/Printing Stack Thesis/src/images/apimon.png URL: http://svn.reactos.org/svn/reactos/trunk/documentation/articles/Printing%20… Added: trunk/documentation/articles/Printing Stack Thesis/src/images/depends.png URL: http://svn.reactos.org/svn/reactos/trunk/documentation/articles/Printing%20… Added: trunk/documentation/articles/Printing Stack Thesis/src/images/skiplist_test.png URL: http://svn.reactos.org/svn/reactos/trunk/documentation/articles/Printing%20… Added: trunk/documentation/articles/Printing Stack Thesis/src/images/windbg.png URL: http://svn.reactos.org/svn/reactos/trunk/documentation/articles/Printing%20… Added: trunk/documentation/articles/Printing Stack Thesis/src/plots/16_levels_1000_elements.csv URL: http://svn.reactos.org/svn/reactos/trunk/documentation/articles/Printing%20… Added: trunk/documentation/articles/Printing Stack Thesis/src/plots/16_levels_65536_elements.csv URL: http://svn.reactos.org/svn/reactos/trunk/documentation/articles/Printing%20… Added: trunk/documentation/articles/Printing Stack Thesis/src/template/acsthesis.cls URL: http://svn.reactos.org/svn/reactos/trunk/documentation/articles/Printing%20… Added: trunk/documentation/articles/Printing Stack Thesis/src/template/config.tex URL: http://svn.reactos.org/svn/reactos/trunk/documentation/articles/Printing%20… Added: trunk/documentation/articles/Printing Stack Thesis/src/template/includes.tex URL: http://svn.reactos.org/svn/reactos/trunk/documentation/articles/Printing%20… Added: trunk/documentation/articles/Printing Stack Thesis/src/thesis.tcp URL: http://svn.reactos.org/svn/reactos/trunk/documentation/articles/Printing%20… Added: trunk/documentation/articles/Printing Stack Thesis/src/thesis.tex URL: http://svn.reactos.org/svn/reactos/trunk/documentation/articles/Printing%20… Added: trunk/documentation/articles/Printing Stack Thesis/thesis.pdf URL: http://svn.reactos.org/svn/reactos/trunk/documentation/articles/Printing%20…

1 0

[sginsberg] 69464: [NTDLL] Expose the last of the system call exports so that we finally, once and for all, have the whole NTOS API properly exposed to user mode. Only real change is some NtLoadKey...
by sginsberg＠svn.reactos.org 08 Oct '15

08 Oct '15

Author: sginsberg Date: Thu Oct 8 12:22:33 2015 New Revision: 69464 URL: http://svn.reactos.org/svn/reactos?rev=69464&view=rev Log: [NTDLL] Expose the last of the system call exports so that we finally, once and for all, have the whole NTOS API properly exposed to user mode. Only real change is some NtLoadKey* functionality, rest is a bunch of EFI stubs. Modified: trunk/reactos/dll/ntdll/def/ntdll.spec Modified: trunk/reactos/dll/ntdll/def/ntdll.spec URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/ntdll/def/ntdll.spec?r… ============================================================================== --- trunk/reactos/dll/ntdll/def/ntdll.spec [iso-8859-1] (original) +++ trunk/reactos/dll/ntdll/def/ntdll.spec [iso-8859-1] Thu Oct 8 12:22:33 2015 @@ -190,7 +190,7 @@ 190 stdcall NtDelayExecution(long ptr) 191 stdcall NtDeleteAtom(long) 192 stdcall NtDeleteBootEntry(long) -# NtDeleteDriverEntry +193 stdcall NtDeleteDriverEntry(long) 194 stdcall NtDeleteFile(ptr) 195 stdcall NtDeleteKey(long) 196 stdcall NtDeleteObjectAuditAlarm(ptr ptr long) @@ -200,7 +200,7 @@ 200 stdcall NtDuplicateObject(long long long ptr long long long) 201 stdcall NtDuplicateToken(long long long long long long) 202 stdcall NtEnumerateBootEntries(ptr ptr) -# stdcall NtEnumerateDriverEntries(ptr ptr) +203 stdcall NtEnumerateDriverEntries(ptr ptr) 204 stdcall NtEnumerateKey (long long long long long long) 205 stdcall NtEnumerateSystemEnvironmentValuesEx(long ptr long) 206 stdcall NtEnumerateValueKey(long long long long long long) @@ -232,7 +232,7 @@ 232 stdcall NtLoadDriver(ptr) 233 stdcall NtLoadKey2(ptr ptr long) 234 stdcall NtLoadKey(ptr ptr) -# stdcall NtLoadKeyEx(ptr ptr long ptr) +235 stdcall NtLoadKeyEx(ptr ptr long ptr) 236 stdcall NtLockFile(long long ptr ptr ptr ptr ptr ptr long long) 237 stdcall NtLockProductActivationKeys(ptr ptr) 238 stdcall NtLockRegistryKey(ptr) @@ -243,7 +243,7 @@ 243 stdcall NtMapUserPhysicalPagesScatter(ptr ptr ptr) 244 stdcall NtMapViewOfSection(long long ptr long long ptr ptr long long long) 245 stdcall NtModifyBootEntry(ptr) -# NtModifyDriverEntry +246 stdcall NtModifyDriverEntry(ptr) 247 stdcall NtNotifyChangeDirectoryFile(long long ptr ptr ptr ptr long long long) 248 stdcall NtNotifyChangeKey(long long ptr ptr ptr long long ptr long long) 249 stdcall NtNotifyChangeMultipleKeys(ptr long ptr ptr ptr ptr ptr long long ptr long long) @@ -282,7 +282,7 @@ 282 stdcall NtQueryDefaultUILanguage(ptr) 283 stdcall NtQueryDirectoryFile(long long ptr ptr ptr ptr long long long ptr long) 284 stdcall NtQueryDirectoryObject(long ptr long long long ptr ptr) -# stdcall NtQueryDriverEntryOrder(ptr ptr) +285 stdcall NtQueryDriverEntryOrder(ptr ptr) 286 stdcall NtQueryEaFile(long ptr ptr long long ptr long ptr long) 287 stdcall NtQueryEvent(long long ptr long ptr) 288 stdcall NtQueryFullAttributesFile(ptr ptr) @@ -301,7 +301,7 @@ 301 stdcall NtQueryMutant(long long ptr long ptr) 302 stdcall NtQueryObject(long long long long long) 303 stdcall NtQueryOpenSubKeys(ptr ptr) -# stdcall NtQueryOpenSubKeysEx(ptr long ptr ptr) +304 stdcall NtQueryOpenSubKeysEx(ptr long ptr ptr) 305 stdcall NtQueryPerformanceCounter(ptr ptr) 306 stdcall NtQueryPortInformationProcess() 307 stdcall NtQueryQuotaInformationFile(ptr ptr ptr long long ptr long ptr long) @@ -357,7 +357,7 @@ 357 stdcall NtSetDefaultHardErrorPort(ptr) 358 stdcall NtSetDefaultLocale(long long) 359 stdcall NtSetDefaultUILanguage(long) -# stdcall NtSetDriverEntryOrder(ptr ptr) +360 stdcall NtSetDriverEntryOrder(ptr ptr) 361 stdcall NtSetEaFile(long ptr ptr long) 362 stdcall NtSetEvent(long long) 363 stdcall NtSetEventBoostPriority(ptr) @@ -403,7 +403,7 @@ 403 stdcall NtTraceEvent(long long long ptr) 404 stdcall NtTranslateFilePath(ptr long ptr long) 405 stdcall NtUnloadDriver(ptr) -# stdcall NtUnloadKey2(ptr long) +406 stdcall NtUnloadKey2(ptr long) 407 stdcall NtUnloadKey(long) 408 stdcall NtUnloadKeyEx(ptr ptr) 409 stdcall NtUnlockFile(long ptr ptr ptr ptr) @@ -412,7 +412,7 @@ 412 stdcall NtVdmControl(long ptr) 413 stdcall NtWaitForDebugEvent(ptr long ptr ptr) 414 stdcall NtWaitForKeyedEvent(ptr ptr long ptr) -# stdcall NtWaitForMultipleObjects32(long ptr long long ptr) +415 stdcall NtWaitForMultipleObjects32(long ptr long long ptr) 416 stdcall NtWaitForMultipleObjects(long ptr long long ptr) 417 stdcall NtWaitForSingleObject(long long long) 418 stdcall NtWaitHighEventPair(ptr) @@ -981,7 +981,7 @@ 973 stdcall ZwAccessCheckByTypeResultListAndAuditAlarmByHandle(ptr ptr ptr ptr ptr ptr ptr long long long ptr long ptr long ptr ptr ptr) NtAccessCheckByTypeResultListAndAuditAlarmByHandle 974 stdcall ZwAddAtom(ptr long ptr) NtAddAtom 975 stdcall ZwAddBootEntry(ptr long) -# ZwAddDriverEntry +976 stdcall ZwAddDriverEntry(ptr long) 977 stdcall ZwAdjustGroupsToken(long long long long long long) NtAdjustGroupsToken 978 stdcall ZwAdjustPrivilegesToken(long long long long long long) NtAdjustPrivilegesToken 979 stdcall ZwAlertResumeThread(long ptr) NtAlertResumeThread @@ -990,7 +990,7 @@ 982 stdcall ZwAllocateUserPhysicalPages(ptr ptr ptr) 983 stdcall ZwAllocateUuids(ptr ptr ptr ptr) NtAllocateUuids 984 stdcall ZwAllocateVirtualMemory(long ptr ptr ptr long long) NtAllocateVirtualMemory -# ZwApphelpCacheControl +985 stdcall ZwApphelpCacheControl(long ptr) 986 stdcall ZwAreMappedFilesTheSame(ptr ptr) NtAreMappedFilesTheSame 987 stdcall ZwAssignProcessToJobObject(long long) NtAssignProcessToJobObject 988 stdcall ZwCallbackReturn(ptr long long) @@ -1036,7 +1036,7 @@ 1028 stdcall ZwDelayExecution(long ptr) NtDelayExecution 1029 stdcall ZwDeleteAtom(long) NtDeleteAtom 1030 stdcall ZwDeleteBootEntry(long) NtDeleteBootEntry -# ZwDeleteDriverEntry +1031 stdcall ZwDeleteDriverEntry(long) 1032 stdcall ZwDeleteFile(ptr) NtDeleteFile 1033 stdcall ZwDeleteKey(long) NtDeleteKey 1034 stdcall ZwDeleteObjectAuditAlarm(ptr ptr long) @@ -1046,7 +1046,7 @@ 1038 stdcall ZwDuplicateObject(long long long ptr long long long) NtDuplicateObject 1039 stdcall ZwDuplicateToken(long long long long long long) NtDuplicateToken 1040 stdcall ZwEnumerateBootEntries(ptr ptr) -# ZwEnumerateDriverEntries +1041 stdcall ZwEnumerateDriverEntries(ptr ptr) 1042 stdcall ZwEnumerateKey(long long long ptr long ptr) NtEnumerateKey 1043 stdcall ZwEnumerateSystemEnvironmentValuesEx(long ptr long) NtEnumerateSystemEnvironmentValuesEx 1044 stdcall ZwEnumerateValueKey(long long long ptr long ptr) NtEnumerateValueKey @@ -1077,7 +1077,7 @@ 1069 stdcall ZwLoadDriver(ptr) NtLoadDriver 1070 stdcall ZwLoadKey2(ptr ptr long) NtLoadKey2 1071 stdcall ZwLoadKey(ptr ptr) NtLoadKey -# ZwLoadKeyEx +1072 stdcall ZwLoadKeyEx(ptr ptr long ptr) 1073 stdcall ZwLockFile(long long ptr ptr ptr ptr ptr ptr long long) NtLockFile 1074 stdcall ZwLockProductActivationKeys(ptr ptr) NtLockProductActivationKeys 1075 stdcall ZwLockRegistryKey(ptr) NtLockRegistryKey @@ -1088,7 +1088,7 @@ 1080 stdcall ZwMapUserPhysicalPagesScatter(ptr ptr ptr) 1081 stdcall ZwMapViewOfSection(long long ptr long long ptr ptr long long long) NtMapViewOfSection 1082 stdcall ZwModifyBootEntry(ptr) NtModifyBootEntry -# ZwModifyDriverEntry +1083 stdcall ZwModifyDriverEntry(ptr) 1084 stdcall ZwNotifyChangeDirectoryFile(long long ptr ptr ptr ptr long long long) NtNotifyChangeDirectoryFile 1085 stdcall ZwNotifyChangeKey(long long ptr ptr ptr long long ptr long long) NtNotifyChangeKey 1086 stdcall ZwNotifyChangeMultipleKeys(ptr long ptr ptr ptr ptr ptr long long ptr long long) NtNotifyChangeMultipleKeys @@ -1127,7 +1127,7 @@ 1119 stdcall ZwQueryDefaultUILanguage(ptr) NtQueryDefaultUILanguage 1120 stdcall ZwQueryDirectoryFile(long long ptr ptr ptr ptr long long long ptr long) NtQueryDirectoryFile 1121 stdcall ZwQueryDirectoryObject(long ptr long long long ptr ptr) NtQueryDirectoryObject -# ZwQueryDriverEntryOrder +1122 stdcall ZwQueryDriverEntryOrder(ptr ptr) 1123 stdcall ZwQueryEaFile(long ptr ptr long long ptr long ptr long) NtQueryEaFile 1124 stdcall ZwQueryEvent(long long ptr long ptr) NtQueryEvent 1125 stdcall ZwQueryFullAttributesFile(ptr ptr) NtQueryFullAttributesFile @@ -1146,7 +1146,7 @@ 1138 stdcall ZwQueryMutant(long long ptr long ptr) NtQueryMutant 1139 stdcall ZwQueryObject(long long long long long) NtQueryObject 1140 stdcall ZwQueryOpenSubKeys(ptr ptr) NtQueryOpenSubKeys -# ZwQueryOpenSubKeysEx +1141 stdcall ZwQueryOpenSubKeysEx(ptr long ptr ptr) 1142 stdcall ZwQueryPerformanceCounter (long long) NtQueryPerformanceCounter 1143 stdcall ZwQueryPortInformationProcess() NtQueryPortInformationProcess 1144 stdcall ZwQueryQuotaInformationFile(ptr ptr ptr long long ptr long ptr long) NtQueryQuotaInformationFile @@ -1202,7 +1202,7 @@ 1194 stdcall ZwSetDefaultHardErrorPort(ptr) 1195 stdcall ZwSetDefaultLocale(long long) 1196 stdcall ZwSetDefaultUILanguage(long) -# ZwSetDriverEntryOrder +1197 stdcall ZwSetDriverEntryOrder(ptr ptr) 1198 stdcall ZwSetEaFile(long ptr ptr long) 1199 stdcall ZwSetEvent(long long) 1200 stdcall ZwSetEventBoostPriority(ptr) @@ -1248,7 +1248,7 @@ 1240 stdcall ZwTraceEvent(long long long ptr) 1241 stdcall ZwTranslateFilePath(ptr long ptr long) 1242 stdcall ZwUnloadDriver(ptr) -# ZwUnloadKey2 +1243 stdcall ZwUnloadKey2(ptr long) 1244 stdcall ZwUnloadKey(long) 1245 stdcall ZwUnloadKeyEx(ptr ptr) 1246 stdcall ZwUnlockFile(long ptr ptr ptr ptr) @@ -1257,7 +1257,7 @@ 1249 stdcall ZwVdmControl(long ptr) 1250 stdcall ZwWaitForDebugEvent(ptr long ptr ptr) 1251 stdcall ZwWaitForKeyedEvent(ptr ptr long ptr) -# ZwWaitForMultipleObjects32 +1252 stdcall ZwWaitForMultipleObjects32(long ptr long long ptr) 1253 stdcall ZwWaitForMultipleObjects(long ptr long long ptr) 1254 stdcall ZwWaitForSingleObject(long long long) 1255 stdcall ZwWaitHighEventPair(ptr)

1 0

[rnaumann] 69463: [SYSDM] Change the applet icon to a new, better looking one. By Ismael Ferreras Morezuelas CORE-10107
by rnaumann＠svn.reactos.org 07 Oct '15

07 Oct '15

Author: rnaumann Date: Wed Oct 7 12:33:47 2015 New Revision: 69463 URL: http://svn.reactos.org/svn/reactos?rev=69463&view=rev Log: [SYSDM] Change the applet icon to a new, better looking one. By Ismael Ferreras Morezuelas CORE-10107 Modified: trunk/reactos/dll/cpl/sysdm/resources/applet.ico Modified: trunk/reactos/dll/cpl/sysdm/resources/applet.ico URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/cpl/sysdm/resources/ap… ============================================================================== Binary files - no diff available.

1 0

[tfaber] 69462: [NTOBJSHEX] - Correctly handle NULL ppidl in EnumerateNext as required by Skip() callers - Don't reenumerate NT directories every time EnumerateNext is called from Skip() CORE-10311...
by tfaber＠svn.reactos.org 07 Oct '15

07 Oct '15

Author: tfaber Date: Wed Oct 7 10:23:06 2015 New Revision: 69462 URL: http://svn.reactos.org/svn/reactos?rev=69462&view=rev Log: [NTOBJSHEX] - Correctly handle NULL ppidl in EnumerateNext as required by Skip() callers - Don't reenumerate NT directories every time EnumerateNext is called from Skip() CORE-10311 #resolve Modified: trunk/reactos/dll/shellext/ntobjshex/ntobjenum.cpp Modified: trunk/reactos/dll/shellext/ntobjshex/ntobjenum.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/shellext/ntobjshex/nto… ============================================================================== --- trunk/reactos/dll/shellext/ntobjshex/ntobjenum.cpp [iso-8859-1] (original) +++ trunk/reactos/dll/shellext/ntobjshex/ntobjenum.cpp [iso-8859-1] Wed Oct 7 10:23:06 2015 @@ -250,7 +250,8 @@ entry->cb += sizeof(WCHAR); } - *ppidl = (LPITEMIDLIST) entry; + if (ppidl) + *ppidl = (LPITEMIDLIST) entry; return S_OK; } @@ -409,7 +410,8 @@ entry->cb += entry->contentsLength + sizeof(WCHAR); } - *ppidl = (LPITEMIDLIST) entry; + if (ppidl) + *ppidl = (LPITEMIDLIST) entry; return S_OK; } @@ -480,7 +482,8 @@ } - *ppidl = (LPITEMIDLIST) entry; + if (ppidl) + *ppidl = (LPITEMIDLIST) entry; return S_OK; } @@ -596,12 +599,13 @@ if (!NT_SUCCESS(NtQueryDirectoryObject(m_directory, dirbuffer, 2048, TRUE, m_first, &m_enumContext, NULL))) return S_FALSE; + m_first = FALSE; + // if ppidl is NULL, assume the caller was Skip(), // so we don't care about the info if (!ppidl) return S_OK; - m_first = FALSE; POBJECT_DIRECTORY_INFORMATION info = (POBJECT_DIRECTORY_INFORMATION) dirbuffer; if (info->Name.Buffer)

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs