Ros-diffs

ros-diffs@reactos.org

81390 discussions

[cwittich] 68981: [CRT] fix resource leak in error case CID 716561
by cwittich＠svn.reactos.org 04 Sep '15

04 Sep '15

Author: cwittich Date: Fri Sep 4 08:02:53 2015 New Revision: 68981 URL: http://svn.reactos.org/svn/reactos?rev=68981&view=rev Log: [CRT] fix resource leak in error case CID 716561 Modified: trunk/reactos/lib/sdk/crt/math/rand.c Modified: trunk/reactos/lib/sdk/crt/math/rand.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/sdk/crt/math/rand.c?re… ============================================================================== --- trunk/reactos/lib/sdk/crt/math/rand.c [iso-8859-1] (original) +++ trunk/reactos/lib/sdk/crt/math/rand.c [iso-8859-1] Fri Sep 4 08:02:53 2015 @@ -34,15 +34,16 @@ { BOOLEAN (WINAPI *pSystemFunction036)(PVOID, ULONG); // RtlGenRandom HINSTANCE hadvapi32 = LoadLibraryA("advapi32.dll"); + int ret = 0; pSystemFunction036 = (void*)GetProcAddress(hadvapi32, "SystemFunction036"); #if 1 if (!pval || (pSystemFunction036 && !pSystemFunction036(pval, sizeof(*pval)))) { _invalid_parameter(NULL,_CRT_WIDE("rand_s"),_CRT_WIDE(__FILE__),__LINE__, 0); *_errno() = EINVAL; - return EINVAL; + ret = EINVAL; } #endif if(hadvapi32) FreeLibrary(hadvapi32); - return 0; + return ret; }

1 0

[tfaber] 68980: [RSYM] - Sort symbol entries with line number information before those without. Fixes backtraces showing ":0" as file/line for the first line of a function
by tfaber＠svn.reactos.org 04 Sep '15

04 Sep '15

Author: tfaber Date: Fri Sep 4 08:02:35 2015 New Revision: 68980 URL: http://svn.reactos.org/svn/reactos?rev=68980&view=rev Log: [RSYM] - Sort symbol entries with line number information before those without. Fixes backtraces showing ":0" as file/line for the first line of a function Modified: trunk/reactos/tools/rsym/rsym.c Modified: trunk/reactos/tools/rsym/rsym.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/tools/rsym/rsym.c?rev=6898… ============================================================================== --- trunk/reactos/tools/rsym/rsym.c [iso-8859-1] (original) +++ trunk/reactos/tools/rsym/rsym.c [iso-8859-1] Fri Sep 4 08:02:35 2015 @@ -119,6 +119,16 @@ } if (SymEntry2->Address < SymEntry1->Address) + { + return +1; + } + + if (SymEntry2->SourceLine == 0) + { + return +1; + } + + if (SymEntry1->SourceLine == 0) { return +1; }

1 0

[cwittich] 68979: [PORTCLS] fix memory leak in error case CID 716555
by cwittich＠svn.reactos.org 04 Sep '15

04 Sep '15

Author: cwittich Date: Fri Sep 4 07:59:51 2015 New Revision: 68979 URL: http://svn.reactos.org/svn/reactos?rev=68979&view=rev Log: [PORTCLS] fix memory leak in error case CID 716555 Modified: trunk/reactos/drivers/wdm/audio/backpln/portcls/undoc.cpp Modified: trunk/reactos/drivers/wdm/audio/backpln/portcls/undoc.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/wdm/audio/backpln/… ============================================================================== --- trunk/reactos/drivers/wdm/audio/backpln/portcls/undoc.cpp [iso-8859-1] (original) +++ trunk/reactos/drivers/wdm/audio/backpln/portcls/undoc.cpp [iso-8859-1] Fri Sep 4 07:59:51 2015 @@ -207,6 +207,7 @@ else { // invalid buffer size + FreeItem(PropertyRequest, TAG_PORTCLASS); return STATUS_INVALID_BUFFER_SIZE; }

1 0

[cwittich] 68978: [WDMAUD.DRV] fix memory leak in error case CID 716484
by cwittich＠svn.reactos.org 04 Sep '15

04 Sep '15

Author: cwittich Date: Fri Sep 4 07:55:30 2015 New Revision: 68978 URL: http://svn.reactos.org/svn/reactos?rev=68978&view=rev Log: [WDMAUD.DRV] fix memory leak in error case CID 716484 Modified: trunk/reactos/dll/win32/wdmaud.drv/legacy.c Modified: trunk/reactos/dll/win32/wdmaud.drv/legacy.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/wdmaud.drv/legac… ============================================================================== --- trunk/reactos/dll/win32/wdmaud.drv/legacy.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/wdmaud.drv/legacy.c [iso-8859-1] Fri Sep 4 07:55:30 2015 @@ -668,6 +668,7 @@ if (Overlap->Standard.hEvent == NULL) { // no memory + HeapFree(GetProcessHeap(), 0, DeviceInfo); return MMSYSERR_NOMEM; }

1 0

[cwittich] 68977: [NSLOOKUP] fix resource leaks CID 701325
by cwittich＠svn.reactos.org 04 Sep '15

04 Sep '15

Author: cwittich Date: Fri Sep 4 07:48:18 2015 New Revision: 68977 URL: http://svn.reactos.org/svn/reactos?rev=68977&view=rev Log: [NSLOOKUP] fix resource leaks CID 701325 Modified: trunk/reactos/base/applications/network/nslookup/utility.c Modified: trunk/reactos/base/applications/network/nslookup/utility.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/network/… ============================================================================== --- trunk/reactos/base/applications/network/nslookup/utility.c [iso-8859-1] (original) +++ trunk/reactos/base/applications/network/nslookup/utility.c [iso-8859-1] Fri Sep 4 07:48:18 2015 @@ -32,6 +32,9 @@ /* Create the sockets for both send and receive. */ s = socket( AF_INET, SOCK_DGRAM, IPPROTO_UDP ); + + if (s == INVALID_SOCKET) + return FALSE; /* Set up the structure to tell it where we are going. */ RecAddr.sin_family = AF_INET; @@ -130,6 +133,7 @@ _tprintf( _T("sendto() failed with unknown error\n") ); } + closesocket( s ); return FALSE; } @@ -221,6 +225,7 @@ _tprintf( _T("recvfrom() failed with unknown error\n") ); } + closesocket( s ); return FALSE; }

1 0

[tfaber] 68976: [NTKRNLMP] - Apply link flags to the right module
by tfaber＠svn.reactos.org 04 Sep '15

04 Sep '15

Author: tfaber Date: Fri Sep 4 06:37:05 2015 New Revision: 68976 URL: http://svn.reactos.org/svn/reactos?rev=68976&view=rev Log: [NTKRNLMP] - Apply link flags to the right module Modified: trunk/reactos/ntoskrnl/ntkrnlmp/CMakeLists.txt Modified: trunk/reactos/ntoskrnl/ntkrnlmp/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ntkrnlmp/CMakeLis… ============================================================================== --- trunk/reactos/ntoskrnl/ntkrnlmp/CMakeLists.txt [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/ntkrnlmp/CMakeLists.txt [iso-8859-1] Fri Sep 4 06:37:05 2015 @@ -28,7 +28,7 @@ if(MSVC) set_image_base(ntkrnlmp 0x00400000) - add_target_link_flags(ntoskrnl "/SECTION:.rsrc,!DP") #Accessed from bugcheck code + add_target_link_flags(ntkrnlmp "/SECTION:.rsrc,!DP") #Accessed from bugcheck code else() set_image_base(ntkrnlmp 0x80800000) endif()

1 0

[hbelusca] 68975: [VSSAPI] Compile the THISCALL calling convention support only for x86. On x64, we are automatically in THISCALL. Also I suggest we turn this file (and maybe also /lib/sdk/crt/exce...
by hbelusca＠svn.reactos.org 04 Sep '15

04 Sep '15

Author: hbelusca Date: Fri Sep 4 01:14:51 2015 New Revision: 68975 URL: http://svn.reactos.org/svn/reactos?rev=68975&view=rev Log: [VSSAPI] Compile the THISCALL calling convention support only for x86. On x64, we are automatically in THISCALL. Also I suggest we turn this file (and maybe also /lib/sdk/crt/except/i386/cpp.s) into a "msvc-thiscall.c" as it is already done in some other DLLs (like in ole32, riched20). Fixes build in x64. Modified: trunk/reactos/dll/win32/vssapi/CMakeLists.txt Modified: trunk/reactos/dll/win32/vssapi/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/vssapi/CMakeList… ============================================================================== --- trunk/reactos/dll/win32/vssapi/CMakeLists.txt [iso-8859-1] (original) +++ trunk/reactos/dll/win32/vssapi/CMakeLists.txt [iso-8859-1] Fri Sep 4 01:14:51 2015 @@ -8,7 +8,7 @@ ${CMAKE_CURRENT_BINARY_DIR}/vssapi_stubs.c ${CMAKE_CURRENT_BINARY_DIR}/vssapi.def) -if(MSVC) +if(MSVC AND ARCH STREQUAL "i386") add_asm_files(vssapi_asm msvc.s) endif()

1 0

[hbelusca] 68974: [few apps][LOGONUI][FREELDR][MSGINA][BLUE] VOIDify function paramater lists when they indeed don't take any arguments.
by hbelusca＠svn.reactos.org 04 Sep '15

04 Sep '15

Author: hbelusca Date: Fri Sep 4 00:21:03 2015 New Revision: 68974 URL: http://svn.reactos.org/svn/reactos?rev=68974&view=rev Log: [few apps][LOGONUI][FREELDR][MSGINA][BLUE] VOIDify function paramater lists when they indeed don't take any arguments. Modified: trunk/reactos/base/applications/kbswitch/kbswitch.c trunk/reactos/base/setup/usetup/cabinet.c trunk/reactos/base/system/logonui/logonui.c trunk/reactos/boot/freeldr/freeldr/arch/amd64/winldr.c trunk/reactos/boot/freeldr/freeldr/arch/i386/winldr.c trunk/reactos/boot/freeldr/freeldr/arch/i386/xboxvideo.c trunk/reactos/boot/freeldr/freeldr/machine.c trunk/reactos/boot/freeldr/freeldr/mm/meminit.c trunk/reactos/boot/freeldr/freeldr/windows/winldr.c trunk/reactos/dll/win32/msgina/msgina.c trunk/reactos/drivers/setup/blue/font.c Modified: trunk/reactos/base/applications/kbswitch/kbswitch.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/kbswitch… ============================================================================== --- trunk/reactos/base/applications/kbswitch/kbswitch.c [iso-8859-1] (original) +++ trunk/reactos/base/applications/kbswitch/kbswitch.c [iso-8859-1] Fri Sep 4 00:21:03 2015 @@ -300,7 +300,7 @@ } static HMENU -BuildLeftPopupMenu() +BuildLeftPopupMenu(VOID) { HMENU hMenu; HKEY hKey; @@ -334,7 +334,7 @@ } BOOL -SetHooks() +SetHooks(VOID) { hDllLib = LoadLibrary(_T("kbsdll.dll")); if (!hDllLib) return FALSE; @@ -349,14 +349,14 @@ } VOID -DeleteHooks() +DeleteHooks(VOID) { if (KbSwitchDeleteHooks) KbSwitchDeleteHooks(); if (hDllLib) FreeLibrary(hDllLib); } ULONG -GetNextLayout() +GetNextLayout(VOID) { TCHAR szLayoutNum[3 + 1], szLayoutID[CCH_LAYOUT_ID + 1]; ULONG Ret = ulCurrentLayoutNum; Modified: trunk/reactos/base/setup/usetup/cabinet.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/setup/usetup/cabinet.… ============================================================================== --- trunk/reactos/base/setup/usetup/cabinet.c [iso-8859-1] (original) +++ trunk/reactos/base/setup/usetup/cabinet.c [iso-8859-1] Fri Sep 4 00:21:03 2015 @@ -804,7 +804,7 @@ #if 0 int -Validate() +Validate(VOID) { return (int)RtlValidateHeap(ProcessHeap, 0, 0); } Modified: trunk/reactos/base/system/logonui/logonui.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/system/logonui/logonu… ============================================================================== --- trunk/reactos/base/system/logonui/logonui.c [iso-8859-1] (original) +++ trunk/reactos/base/system/logonui/logonui.c [iso-8859-1] Fri Sep 4 00:21:03 2015 @@ -89,7 +89,7 @@ } static VOID -Run() +Run(VOID) { HWND hDesktopWnd; HDC hdcDesktop, hdcMem; Modified: trunk/reactos/boot/freeldr/freeldr/arch/amd64/winldr.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/arch/… ============================================================================== --- trunk/reactos/boot/freeldr/freeldr/arch/amd64/winldr.c [iso-8859-1] (original) +++ trunk/reactos/boot/freeldr/freeldr/arch/amd64/winldr.c [iso-8859-1] Fri Sep 4 00:21:03 2015 @@ -29,7 +29,7 @@ /* FUNCTIONS **************************************************************/ BOOLEAN -MempAllocatePageTables() +MempAllocatePageTables(VOID) { TRACE(">>> MempAllocatePageTables\n"); @@ -203,7 +203,7 @@ } VOID -WinLdrpMapApic() +WinLdrpMapApic(VOID) { BOOLEAN LocalAPIC; LARGE_INTEGER MsrValue; @@ -235,7 +235,7 @@ } BOOLEAN -WinLdrMapSpecialPages() +WinLdrMapSpecialPages(VOID) { PHARDWARE_PTE PpeBase, PdeBase; @@ -418,7 +418,7 @@ VOID -MempDump() -{ -} - +MempDump(VOID) +{ +} + Modified: trunk/reactos/boot/freeldr/freeldr/arch/i386/winldr.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/arch/… ============================================================================== --- trunk/reactos/boot/freeldr/freeldr/arch/i386/winldr.c [iso-8859-1] (original) +++ trunk/reactos/boot/freeldr/freeldr/arch/i386/winldr.c [iso-8859-1] Fri Sep 4 00:21:03 2015 @@ -47,7 +47,7 @@ /* FUNCTIONS **************************************************************/ BOOLEAN -MempAllocatePageTables() +MempAllocatePageTables(VOID) { ULONG NumPageTables, TotalSize; PUCHAR Buffer; @@ -222,7 +222,7 @@ } VOID -WinLdrpMapApic() +WinLdrpMapApic(VOID) { BOOLEAN LocalAPIC; LARGE_INTEGER MsrValue; @@ -297,7 +297,7 @@ UltraVision_8x10Font = 0x12, }; -void WinLdrSetupSpecialDataPointers() +void WinLdrSetupSpecialDataPointers(VOID) { REGS BiosRegs; @@ -670,7 +670,7 @@ #if DBG VOID -MempDump() +MempDump(VOID) { ULONG *PDE_Addr=(ULONG *)PDE;//0xC0300000; int i, j; Modified: trunk/reactos/boot/freeldr/freeldr/arch/i386/xboxvideo.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/arch/… ============================================================================== --- trunk/reactos/boot/freeldr/freeldr/arch/i386/xboxvideo.c [iso-8859-1] (original) +++ trunk/reactos/boot/freeldr/freeldr/arch/i386/xboxvideo.c [iso-8859-1] Fri Sep 4 00:21:03 2015 @@ -227,13 +227,13 @@ } VOID -XboxVideoSync() +XboxVideoSync(VOID) { /* Not supported */ } VOID -XboxBeep() +XboxBeep(VOID) { /* Call PC version */ PcBeep(); Modified: trunk/reactos/boot/freeldr/freeldr/machine.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/machi… ============================================================================== --- trunk/reactos/boot/freeldr/freeldr/machine.c [iso-8859-1] (original) +++ trunk/reactos/boot/freeldr/freeldr/machine.c [iso-8859-1] Fri Sep 4 00:21:03 2015 @@ -49,13 +49,13 @@ } BOOLEAN -MachConsKbHit() +MachConsKbHit(VOID) { return MachVtbl.ConsKbHit(); } int -MachConsGetCh() +MachConsGetCh(VOID) { return MachVtbl.ConsGetCh(); } Modified: trunk/reactos/boot/freeldr/freeldr/mm/meminit.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/mm/me… ============================================================================== --- trunk/reactos/boot/freeldr/freeldr/mm/meminit.c [iso-8859-1] (original) +++ trunk/reactos/boot/freeldr/freeldr/mm/meminit.c [iso-8859-1] Fri Sep 4 00:21:03 2015 @@ -236,7 +236,7 @@ static VOID -MmCheckFreeldrImageFile() +MmCheckFreeldrImageFile(VOID) { PIMAGE_NT_HEADERS NtHeaders; PIMAGE_FILE_HEADER FileHeader; Modified: trunk/reactos/boot/freeldr/freeldr/windows/winldr.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/windo… ============================================================================== --- trunk/reactos/boot/freeldr/freeldr/windows/winldr.c [iso-8859-1] (original) +++ trunk/reactos/boot/freeldr/freeldr/windows/winldr.c [iso-8859-1] Fri Sep 4 00:21:03 2015 @@ -408,7 +408,7 @@ } USHORT -WinLdrDetectVersion() +WinLdrDetectVersion(VOID) { LONG rc; FRLDRHKEY hKey; Modified: trunk/reactos/dll/win32/msgina/msgina.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/msgina/msgina.c?… ============================================================================== --- trunk/reactos/dll/win32/msgina/msgina.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/msgina/msgina.c [iso-8859-1] Fri Sep 4 00:21:03 2015 @@ -263,7 +263,7 @@ typedef BOOL (WINAPI *pThemeWatch)(void); static void -InitThemeSupport() +InitThemeSupport(VOID) { HMODULE hDll = LoadLibraryW(L"shsvcs.dll"); pThemeWait themeWait; Modified: trunk/reactos/drivers/setup/blue/font.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/setup/blue/font.c?… ============================================================================== --- trunk/reactos/drivers/setup/blue/font.c [iso-8859-1] (original) +++ trunk/reactos/drivers/setup/blue/font.c [iso-8859-1] Fri Sep 4 00:21:03 2015 @@ -195,7 +195,7 @@ /* Font-load specific funcs */ VOID -OpenBitPlane() +OpenBitPlane(VOID) { /* disable interrupts */ _disable(); @@ -216,7 +216,7 @@ } VOID -CloseBitPlane() +CloseBitPlane(VOID) { /* disable interrupts */ _disable();

1 0

[hbelusca] 68973: [WIN32SS] VOIDify function paramater lists when they indeed don't take any arguments.
by hbelusca＠svn.reactos.org 04 Sep '15

04 Sep '15

Author: hbelusca Date: Fri Sep 4 00:11:49 2015 New Revision: 68973 URL: http://svn.reactos.org/svn/reactos?rev=68973&view=rev Log: [WIN32SS] VOIDify function paramater lists when they indeed don't take any arguments. Modified: trunk/reactos/win32ss/drivers/miniport/vga/initvga.c trunk/reactos/win32ss/gdi/eng/pdevobj.c trunk/reactos/win32ss/gdi/eng/stubs.c trunk/reactos/win32ss/gdi/gdi32/misc/gdientry.c trunk/reactos/win32ss/gdi/gdi32/misc/misc.c trunk/reactos/win32ss/gdi/ntgdi/dclife.c trunk/reactos/win32ss/gdi/ntgdi/gdidbg.c trunk/reactos/win32ss/gdi/ntgdi/palette.c trunk/reactos/win32ss/reactx/dxapi/main.c trunk/reactos/win32ss/reactx/ntddraw/dxeng.c trunk/reactos/win32ss/user/ntuser/callback.c trunk/reactos/win32ss/user/ntuser/cursoricon.c trunk/reactos/win32ss/user/ntuser/desktop.c trunk/reactos/win32ss/user/ntuser/display.c trunk/reactos/win32ss/user/ntuser/input.c trunk/reactos/win32ss/user/ntuser/message.c trunk/reactos/win32ss/user/ntuser/monitor.c trunk/reactos/win32ss/user/ntuser/object.c trunk/reactos/win32ss/user/ntuser/sysparams.c trunk/reactos/win32ss/user/ntuser/winsta.c trunk/reactos/win32ss/user/user32/controls/appswitch.c trunk/reactos/win32ss/user/user32/misc/dllmain.c Modified: trunk/reactos/win32ss/drivers/miniport/vga/initvga.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/drivers/miniport/v… ============================================================================== --- trunk/reactos/win32ss/drivers/miniport/vga/initvga.c [iso-8859-1] (original) +++ trunk/reactos/win32ss/drivers/miniport/vga/initvga.c [iso-8859-1] Fri Sep 4 00:11:49 2015 @@ -107,7 +107,7 @@ } VOID -InitVGAMode() +InitVGAMode(VOID) { vgaSaveRegisters(&TextModeRegs); vgaSetRegisters(&Mode12Regs); Modified: trunk/reactos/win32ss/gdi/eng/pdevobj.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/gdi/eng/pdevobj.c?… ============================================================================== --- trunk/reactos/win32ss/gdi/eng/pdevobj.c [iso-8859-1] (original) +++ trunk/reactos/win32ss/gdi/eng/pdevobj.c [iso-8859-1] Fri Sep 4 00:11:49 2015 @@ -18,7 +18,7 @@ INIT_FUNCTION NTSTATUS NTAPI -InitPDEVImpl() +InitPDEVImpl(VOID) { ghsemPDEV = EngCreateSemaphore(); if (!ghsemPDEV) return STATUS_INSUFFICIENT_RESOURCES; @@ -50,7 +50,7 @@ #endif PPDEVOBJ -PDEVOBJ_AllocPDEV() +PDEVOBJ_AllocPDEV(VOID) { PPDEVOBJ ppdev; Modified: trunk/reactos/win32ss/gdi/eng/stubs.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/gdi/eng/stubs.c?re… ============================================================================== --- trunk/reactos/win32ss/gdi/eng/stubs.c [iso-8859-1] (original) +++ trunk/reactos/win32ss/gdi/eng/stubs.c [iso-8859-1] Fri Sep 4 00:11:49 2015 @@ -669,7 +669,7 @@ */ BOOL APIENTRY -EngLpkInstalled() +EngLpkInstalled(VOID) { UNIMPLEMENTED; return FALSE; @@ -803,7 +803,7 @@ */ BOOL APIENTRY -NtGdiAnyLinkedFonts() +NtGdiAnyLinkedFonts(VOID) { UNIMPLEMENTED; return FALSE; Modified: trunk/reactos/win32ss/gdi/gdi32/misc/gdientry.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/gdi/gdi32/misc/gdi… ============================================================================== --- trunk/reactos/win32ss/gdi/gdi32/misc/gdientry.c [iso-8859-1] (original) +++ trunk/reactos/win32ss/gdi/gdi32/misc/gdientry.c [iso-8859-1] Fri Sep 4 00:11:49 2015 @@ -2028,7 +2028,7 @@ */ ULONG WINAPI -DdQueryDisplaySettingsUniqueness() +DdQueryDisplaySettingsUniqueness(VOID) { return GdiSharedHandleTable->flDeviceUniq; } Modified: trunk/reactos/win32ss/gdi/gdi32/misc/misc.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/gdi/gdi32/misc/mis… ============================================================================== --- trunk/reactos/win32ss/gdi/gdi32/misc/misc.c [iso-8859-1] (original) +++ trunk/reactos/win32ss/gdi/gdi32/misc/misc.c [iso-8859-1] Fri Sep 4 00:11:49 2015 @@ -41,7 +41,7 @@ */ BOOL WINAPI -GdiFlush() +GdiFlush(VOID) { NtGdiFlush(); return TRUE; @@ -459,7 +459,7 @@ */ DWORD WINAPI -GdiGetBatchLimit() +GdiGetBatchLimit(VOID) { return GDI_BatchLimit; } Modified: trunk/reactos/win32ss/gdi/ntgdi/dclife.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/gdi/ntgdi/dclife.c… ============================================================================== --- trunk/reactos/win32ss/gdi/ntgdi/dclife.c [iso-8859-1] (original) +++ trunk/reactos/win32ss/gdi/ntgdi/dclife.c [iso-8859-1] Fri Sep 4 00:11:49 2015 @@ -50,7 +50,7 @@ INIT_FUNCTION NTSTATUS NTAPI -InitDcImpl() +InitDcImpl(VOID) { psurfDefaultBitmap = SURFACE_ShareLockSurface(StockObjects[DEFAULT_BITMAP]); if (!psurfDefaultBitmap) Modified: trunk/reactos/win32ss/gdi/ntgdi/gdidbg.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/gdi/ntgdi/gdidbg.c… ============================================================================== --- trunk/reactos/win32ss/gdi/ntgdi/gdidbg.c [iso-8859-1] (original) +++ trunk/reactos/win32ss/gdi/ntgdi/gdidbg.c [iso-8859-1] Fri Sep 4 00:11:49 2015 @@ -20,7 +20,7 @@ ULONG gulLogUnique = 0; /* Note: the following values need to be sorted */ -DBG_CHANNEL DbgChannels[DbgChCount]={ +DBG_CHANNEL DbgChannels[DbgChCount] = { {L"EngBlt", DbgChEngBlt}, {L"EngBrush", DbgChEngBrush}, {L"EngClip", DbgChEngClip}, @@ -281,7 +281,7 @@ BOOL NTAPI -DbgGdiHTIntegrityCheck() +DbgGdiHTIntegrityCheck(VOID) { ULONG i, nDeleted = 0, nFree = 0, nUsed = 0; PGDI_TABLE_ENTRY pEntry; @@ -516,7 +516,7 @@ VOID NTAPI -DbgDumpLockedGdiHandles() +DbgDumpLockedGdiHandles(VOID) { ULONG i; @@ -733,7 +733,7 @@ return TRUE; } -BOOL DbgInitDebugChannels() +BOOL DbgInitDebugChannels(VOID) { WCHAR valBuffer[100]; UNICODE_STRING Value; Modified: trunk/reactos/win32ss/gdi/ntgdi/palette.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/gdi/ntgdi/palette.… ============================================================================== --- trunk/reactos/win32ss/gdi/ntgdi/palette.c [iso-8859-1] (original) +++ trunk/reactos/win32ss/gdi/ntgdi/palette.c [iso-8859-1] Fri Sep 4 00:11:49 2015 @@ -60,7 +60,7 @@ INIT_FUNCTION NTSTATUS NTAPI -InitPaletteImpl() +InitPaletteImpl(VOID) { // Create default palette (20 system colors) gppalDefault = PALETTE_AllocPalWithHandle(PAL_INDEXED, Modified: trunk/reactos/win32ss/reactx/dxapi/main.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/reactx/dxapi/main.… ============================================================================== --- trunk/reactos/win32ss/reactx/dxapi/main.c [iso-8859-1] (original) +++ trunk/reactos/win32ss/reactx/dxapi/main.c [iso-8859-1] Fri Sep 4 00:11:49 2015 @@ -41,7 +41,7 @@ *--*/ ULONG NTAPI -DxApiGetVersion() +DxApiGetVersion(VOID) { /* MSDN say this always return Direct Sound version 4.02 */ return 0x402; Modified: trunk/reactos/win32ss/reactx/ntddraw/dxeng.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/reactx/ntddraw/dxe… ============================================================================== --- trunk/reactos/win32ss/reactx/ntddraw/dxeng.c [iso-8859-1] (original) +++ trunk/reactos/win32ss/reactx/ntddraw/dxeng.c [iso-8859-1] Fri Sep 4 00:11:49 2015 @@ -12,7 +12,7 @@ HSEMAPHORE ghsemShareDevLock = NULL; ULONG gcEngFuncs = DXENG_INDEX_DxEngLoadImage + 1; -DRVFN gaEngFuncs [] = +DRVFN gaEngFuncs[] = { {0, (PFN) NULL}, {DXENG_INDEX_DxEngNUIsTermSrv, (PFN)DxEngNUIsTermSrv}, @@ -75,7 +75,7 @@ *--*/ ULONG APIENTRY -DxEngDispUniq() +DxEngDispUniq(VOID) { DPRINT1("ReactX Calling : DxEngDispUniq\n"); return GdiHandleTable->flDeviceUniq; @@ -176,7 +176,7 @@ *--*/ BOOLEAN APIENTRY -DxEngLockShareSem() +DxEngLockShareSem(VOID) { DPRINT1("ReactX Calling : DxEngLockShareSem\n"); if(!ghsemShareDevLock) ghsemShareDevLock = EngCreateSemaphore(); // Hax, should be in dllmain.c @@ -199,7 +199,7 @@ *--*/ BOOLEAN APIENTRY -DxEngUnlockShareSem() +DxEngUnlockShareSem(VOID) { DPRINT1("ReactX Calling : DxEngUnlockShareSem\n"); EngReleaseSemaphore(ghsemShareDevLock); @@ -498,7 +498,7 @@ *--*/ BOOLEAN APIENTRY -DxEngIncDispUniq() +DxEngIncDispUniq(VOID) { DPRINT1("ReactX Calling : DxEngIncDispUniq \n"); @@ -596,7 +596,7 @@ /* Notes: Check if terminal server got connections or not */ BOOLEAN APIENTRY -DxEngNUIsTermSrv() +DxEngNUIsTermSrv(VOID) { /* FIXME: ReactOS does not suport terminal server yet, we can not check if we got connections or not */ UNIMPLEMENTED; @@ -611,7 +611,7 @@ (redraws current desktop) */ BOOLEAN APIENTRY -DxEngRedrawDesktop() +DxEngRedrawDesktop(VOID) { UserRedrawDesktop(); return TRUE; @@ -626,7 +626,7 @@ /* Notes: returns the VisRgnUniq counter for win32k */ ULONG APIENTRY -DxEngVisRgnUniq() +DxEngVisRgnUniq(VOID) { DPRINT1("ReactX Calling : DxEngVisRgnUniq \n"); @@ -659,7 +659,7 @@ /************************************************************************/ /* DxEngScreenAccessCheck */ /************************************************************************/ -DWORD APIENTRY DxEngScreenAccessCheck() +DWORD APIENTRY DxEngScreenAccessCheck(VOID) { UNIMPLEMENTED; Modified: trunk/reactos/win32ss/user/ntuser/callback.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/ntuser/callba… ============================================================================== --- trunk/reactos/win32ss/user/ntuser/callback.c [iso-8859-1] (original) +++ trunk/reactos/win32ss/user/ntuser/callback.c [iso-8859-1] Fri Sep 4 00:11:49 2015 @@ -424,7 +424,7 @@ } HMENU APIENTRY -co_IntLoadSysMenuTemplate() +co_IntLoadSysMenuTemplate(VOID) { LRESULT Result = 0; NTSTATUS Status; Modified: trunk/reactos/win32ss/user/ntuser/cursoricon.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/ntuser/cursor… ============================================================================== --- trunk/reactos/win32ss/user/ntuser/cursoricon.c [iso-8859-1] (original) +++ trunk/reactos/win32ss/user/ntuser/cursoricon.c [iso-8859-1] Fri Sep 4 00:11:49 2015 @@ -184,7 +184,7 @@ } PSYSTEM_CURSORINFO -IntGetSysCursorInfo() +IntGetSysCursorInfo(VOID) { return &gSysCursorInfo; } Modified: trunk/reactos/win32ss/user/ntuser/desktop.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/ntuser/deskto… ============================================================================== --- trunk/reactos/win32ss/user/ntuser/desktop.c [iso-8859-1] (original) +++ trunk/reactos/win32ss/user/ntuser/desktop.c [iso-8859-1] Fri Sep 4 00:11:49 2015 @@ -723,7 +723,7 @@ return TRUE; /* We are done. Do not do any callbacks to user mode */ } -VOID NTAPI DesktopThreadMain() +VOID NTAPI DesktopThreadMain(VOID) { BOOL Ret; MSG Msg; @@ -769,7 +769,7 @@ } VOID APIENTRY -UserRedrawDesktop() +UserRedrawDesktop(VOID) { PWND Window = NULL; PREGION Rgn; Modified: trunk/reactos/win32ss/user/ntuser/display.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/ntuser/displa… ============================================================================== --- trunk/reactos/win32ss/user/ntuser/display.c [iso-8859-1] (original) +++ trunk/reactos/win32ss/user/ntuser/display.c [iso-8859-1] Fri Sep 4 00:11:49 2015 @@ -152,7 +152,7 @@ NTSTATUS NTAPI -InitVideo() +InitVideo(VOID) { ULONG iDevNum, iVGACompatible = -1, ulMaxObjectNumber = 0; WCHAR awcDeviceName[20]; Modified: trunk/reactos/win32ss/user/ntuser/input.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/ntuser/input.… ============================================================================== --- trunk/reactos/win32ss/user/ntuser/input.c [iso-8859-1] (original) +++ trunk/reactos/win32ss/user/ntuser/input.c [iso-8859-1] Fri Sep 4 00:11:49 2015 @@ -125,7 +125,7 @@ * Reads data from input devices and supports win32 timers */ VOID NTAPI -RawInputThreadMain() +RawInputThreadMain(VOID) { NTSTATUS MouStatus = STATUS_UNSUCCESSFUL, KbdStatus = STATUS_UNSUCCESSFUL, Status; IO_STATUS_BLOCK MouIosb, KbdIosb; Modified: trunk/reactos/win32ss/user/ntuser/message.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/ntuser/messag… ============================================================================== --- trunk/reactos/win32ss/user/ntuser/message.c [iso-8859-1] (original) +++ trunk/reactos/win32ss/user/ntuser/message.c [iso-8859-1] Fri Sep 4 00:11:49 2015 @@ -1937,7 +1937,7 @@ } BOOL APIENTRY -IntInitMessagePumpHook() +IntInitMessagePumpHook(VOID) { PTHREADINFO pti = PsGetCurrentThreadWin32Thread(); @@ -1950,7 +1950,7 @@ } BOOL APIENTRY -IntUninitMessagePumpHook() +IntUninitMessagePumpHook(VOID) { PTHREADINFO pti = PsGetCurrentThreadWin32Thread(); Modified: trunk/reactos/win32ss/user/ntuser/monitor.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/ntuser/monito… ============================================================================== --- trunk/reactos/win32ss/user/ntuser/monitor.c [iso-8859-1] (original) +++ trunk/reactos/win32ss/user/ntuser/monitor.c [iso-8859-1] Fri Sep 4 00:11:49 2015 @@ -30,7 +30,7 @@ */ static PMONITOR -IntCreateMonitorObject() +IntCreateMonitorObject(VOID) { return UserCreateObject(gHandleTable, NULL, NULL, NULL, TYPE_MONITOR, sizeof(MONITOR)); } @@ -99,7 +99,7 @@ * PMONITOR */ PMONITOR NTAPI -UserGetPrimaryMonitor() +UserGetPrimaryMonitor(VOID) { PMONITOR pMonitor; Modified: trunk/reactos/win32ss/user/ntuser/object.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/ntuser/object… ============================================================================== --- trunk/reactos/win32ss/user/ntuser/object.c [iso-8859-1] (original) +++ trunk/reactos/win32ss/user/ntuser/object.c [iso-8859-1] Fri Sep 4 00:11:49 2015 @@ -246,7 +246,7 @@ #if DBG -void DbgUserDumpHandleTable() +void DbgUserDumpHandleTable(VOID) { int HandleCounts[TYPE_CTYPES]; PPROCESSINFO ppiList; Modified: trunk/reactos/win32ss/user/ntuser/sysparams.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/ntuser/syspar… ============================================================================== --- trunk/reactos/win32ss/user/ntuser/sysparams.c [iso-8859-1] (original) +++ trunk/reactos/win32ss/user/ntuser/sysparams.c [iso-8859-1] Fri Sep 4 00:11:49 2015 @@ -186,7 +186,7 @@ static VOID -SpiFixupValues() +SpiFixupValues(VOID) { /* Fixup values */ gspv.ncm.iCaptionWidth = max(gspv.ncm.iCaptionWidth, 8); @@ -210,7 +210,7 @@ static VOID -SpiUpdatePerUserSystemParameters() +SpiUpdatePerUserSystemParameters(VOID) { static LOGFONTW lf1 = {-11, 0, 0, 0, FW_NORMAL, FALSE, FALSE, FALSE, ANSI_CHARSET, 0, 0, DEFAULT_QUALITY, @@ -320,7 +320,7 @@ } BOOL -InitSysParams() +InitSysParams(VOID) { SpiUpdatePerUserSystemParameters(); gbSpiInitialized = TRUE; @@ -724,7 +724,7 @@ } static BOOL -SpiNotifyNCMetricsChanged() +SpiNotifyNCMetricsChanged(VOID) { PWND pwndDesktop, pwndCurrent; HWND *ahwnd; Modified: trunk/reactos/win32ss/user/ntuser/winsta.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/ntuser/winsta… ============================================================================== --- trunk/reactos/win32ss/user/ntuser/winsta.c [iso-8859-1] (original) +++ trunk/reactos/win32ss/user/ntuser/winsta.c [iso-8859-1] Fri Sep 4 00:11:49 2015 @@ -45,7 +45,7 @@ NTSTATUS NTAPI -UserCreateWinstaDirectory() +UserCreateWinstaDirectory(VOID) { PPEB Peb; NTSTATUS Status; Modified: trunk/reactos/win32ss/user/user32/controls/appswitch.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/user32/contro… ============================================================================== --- trunk/reactos/win32ss/user/user32/controls/appswitch.c [iso-8859-1] (original) +++ trunk/reactos/win32ss/user/user32/controls/appswitch.c [iso-8859-1] Fri Sep 4 00:11:49 2015 @@ -54,7 +54,7 @@ wpl.length = sizeof(WINDOWPLACEMENT); GetWindowPlacement(hwnd, &wpl); - + TRACE("GetWindowPlacement wpl.showCmd %d\n",wpl.showCmd); if (wpl.showCmd == SW_SHOWMINIMIZED) ShowWindowAsync(hwnd, SW_RESTORE); @@ -82,7 +82,7 @@ //if(selectedWindow != 0) { HWND hwnd = windowList[selectedWindow]; - + GetWindowTextW(hwnd, windowText, _countof(windowText)); TRACE("[ATbot] CompleteSwitch Switching to 0x%08x (%ls)\n", hwnd, windowText); @@ -107,7 +107,7 @@ if ((wcscmp(L"Shell_TrayWnd", windowText)==0) || (wcscmp(L"Progman", windowText)==0) ) return TRUE; - + // First try to get the big icon assigned to the window hIcon = (HICON)SendMessageW(window, WM_GETICON, ICON_BIG, 0); if (!hIcon) @@ -161,8 +161,8 @@ void ProcessMouseMessage(UINT message, LPARAM lParam) { - int xPos = LOWORD(lParam); - int yPos = HIWORD(lParam); + int xPos = LOWORD(lParam); + int yPos = HIWORD(lParam); int xIndex = (xPos - xOffset)/40; int xOff = (xPos - xOffset)%40; @@ -209,7 +209,7 @@ for(i=0; i< windowCount; i++) { HICON hIcon = iconList[i]; - + int xpos = xOffset + 40 * (i % nCols); int ypos = yOffset + 40 * (i / nCols); @@ -266,12 +266,12 @@ TRACE("[ATbot] Task Switcher Window failed to create.\n"); return 0; } - + isOpen = FALSE; return 1; } - -DWORD GetDialogFont() + +DWORD GetDialogFont(VOID) { HDC tDC; TEXTMETRIC tm; @@ -286,11 +286,11 @@ return 1; } -void PrepareWindow() +void PrepareWindow(VOID) { cxBorder = GetSystemMetrics(SM_CXBORDER); cyBorder = GetSystemMetrics(SM_CYBORDER); - + nItems = windowCount; nCols = min(max(nItems,8),12); nRows = (nItems+nCols-1)/nCols; @@ -312,7 +312,7 @@ ResizeAndCenter(switchdialog, totalW, totalH); } -void ProcessHotKey() +void ProcessHotKey(VOID) { if (!isOpen) { @@ -492,7 +492,7 @@ } VOID -DestroyAppWindows() +DestroyAppWindows(VOID) { INT i; for (i=0; i< windowCount; i++) @@ -516,7 +516,7 @@ { NtUserSetWindowFNID(hWnd, FNID_SWITCH); } - } + } switch (uMsg) { Modified: trunk/reactos/win32ss/user/user32/misc/dllmain.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/user32/misc/d… ============================================================================== --- trunk/reactos/win32ss/user/user32/misc/dllmain.c [iso-8859-1] (original) +++ trunk/reactos/win32ss/user/user32/misc/dllmain.c [iso-8859-1] Fri Sep 4 00:11:49 2015 @@ -24,7 +24,7 @@ WCHAR szAppInit[KEY_LENGTH]; BOOL -GetDllList() +GetDllList(VOID) { NTSTATUS Status; OBJECT_ATTRIBUTES Attributes; @@ -123,7 +123,7 @@ VOID -LoadAppInitDlls() +LoadAppInitDlls(VOID) { szAppInit[0] = UNICODE_NULL; @@ -156,7 +156,7 @@ } VOID -UnloadAppInitDlls() +UnloadAppInitDlls(VOID) { if (szAppInit[0] != UNICODE_NULL) {

1 0

[hbelusca] 68972: Forgot those three ones.
by hbelusca＠svn.reactos.org 04 Sep '15

04 Sep '15

Author: hbelusca Date: Thu Sep 3 23:59:27 2015 New Revision: 68972 URL: http://svn.reactos.org/svn/reactos?rev=68972&view=rev Log: Forgot those three ones. Modified: trunk/reactos/ntoskrnl/mm/amd64/init.c Modified: trunk/reactos/ntoskrnl/mm/amd64/init.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/amd64/init.c?r… ============================================================================== --- trunk/reactos/ntoskrnl/mm/amd64/init.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/mm/amd64/init.c [iso-8859-1] Thu Sep 3 23:59:27 2015 @@ -62,7 +62,7 @@ VOID NTAPI INIT_FUNCTION -MiInitializeSessionSpaceLayout() +MiInitializeSessionSpaceLayout(VOID) { MmSessionSize = MI_SESSION_SIZE; MmSessionViewSize = MI_SESSION_VIEW_SIZE; @@ -185,7 +185,7 @@ VOID NTAPI INIT_FUNCTION -MiInitializePageTable() +MiInitializePageTable(VOID) { ULONG64 PxePhysicalAddress; MMPTE TmplPte, *PointerPxe; @@ -367,7 +367,7 @@ VOID NTAPI INIT_FUNCTION -MiBuildSystemPteSpace() +MiBuildSystemPteSpace(VOID) { PMMPTE PointerPte;

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs