Ros-diffs

ros-diffs@reactos.org

81390 discussions

[hbelusca] 68971: [NTDLL][HAL][INFLIB][RTL][NTOS] VOIDify function paramater lists when they indeed don't take any arguments.
by hbelusca＠svn.reactos.org 04 Sep '15

04 Sep '15

Author: hbelusca Date: Thu Sep 3 23:57:39 2015 New Revision: 68971 URL: http://svn.reactos.org/svn/reactos?rev=68971&view=rev Log: [NTDLL][HAL][INFLIB][RTL][NTOS] VOIDify function paramater lists when they indeed don't take any arguments. Modified: trunk/reactos/dll/ntdll/dispatch/amd64/stubs.c trunk/reactos/dll/ntdll/ldr/ldrinit.c trunk/reactos/dll/ntdll/rtl/libsupp.c trunk/reactos/hal/halx86/apic/tsc.c trunk/reactos/hal/halx86/generic/bios.c trunk/reactos/include/asm/asm.inc trunk/reactos/lib/inflib/infrosgen.c trunk/reactos/lib/rtl/heappage.c trunk/reactos/ntoskrnl/ex/lookas.c trunk/reactos/ntoskrnl/fsrtl/tunnel.c trunk/reactos/ntoskrnl/include/internal/amd64/ke.h trunk/reactos/ntoskrnl/include/internal/i386/intrin_i.h trunk/reactos/ntoskrnl/io/iomgr/iomgr.c trunk/reactos/ntoskrnl/kd/wrappers/gdbstub.c trunk/reactos/ntoskrnl/kd/wrappers/gdbstub_powerpc.c trunk/reactos/ntoskrnl/kdbg/kdb.c trunk/reactos/ntoskrnl/kdbg/kdb_cli.c trunk/reactos/ntoskrnl/ke/powerpc/kiinit.c trunk/reactos/ntoskrnl/ke/powerpc/stubs.c trunk/reactos/ntoskrnl/mm/ARM3/i386/init.c trunk/reactos/ntoskrnl/mm/ARM3/session.c trunk/reactos/ntoskrnl/mm/ARM3/special.c trunk/reactos/ntoskrnl/mm/mminit.c trunk/reactos/ntoskrnl/ps/kill.c trunk/reactos/ntoskrnl/ps/psmgr.c trunk/reactos/ntoskrnl/rtl/libsupp.c Modified: trunk/reactos/dll/ntdll/dispatch/amd64/stubs.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/ntdll/dispatch/amd64/s… ============================================================================== --- trunk/reactos/dll/ntdll/dispatch/amd64/stubs.c [iso-8859-1] (original) +++ trunk/reactos/dll/ntdll/dispatch/amd64/stubs.c [iso-8859-1] Thu Sep 3 23:57:39 2015 @@ -44,7 +44,7 @@ VOID NTAPI -KiRaiseUserExceptionDispatcher() +KiRaiseUserExceptionDispatcher(VOID) { UNIMPLEMENTED; return; @@ -52,7 +52,7 @@ VOID NTAPI -KiUserCallbackDispatcher() +KiUserCallbackDispatcher(VOID) { UNIMPLEMENTED; return; @@ -60,7 +60,7 @@ VOID NTAPI -KiUserExceptionDispatcher() +KiUserExceptionDispatcher(VOID) { UNIMPLEMENTED; return; Modified: trunk/reactos/dll/ntdll/ldr/ldrinit.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/ntdll/ldr/ldrinit.c?re… ============================================================================== --- trunk/reactos/dll/ntdll/ldr/ldrinit.c [iso-8859-1] (original) +++ trunk/reactos/dll/ntdll/ldr/ldrinit.c [iso-8859-1] Thu Sep 3 23:57:39 2015 @@ -395,7 +395,7 @@ VOID NTAPI -LdrpEnsureLoaderLockIsHeld() +LdrpEnsureLoaderLockIsHeld(VOID) { // Ignored atm } Modified: trunk/reactos/dll/ntdll/rtl/libsupp.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/ntdll/rtl/libsupp.c?re… ============================================================================== --- trunk/reactos/dll/ntdll/rtl/libsupp.c [iso-8859-1] (original) +++ trunk/reactos/dll/ntdll/rtl/libsupp.c [iso-8859-1] Thu Sep 3 23:57:39 2015 @@ -66,7 +66,7 @@ KPROCESSOR_MODE NTAPI -RtlpGetMode() +RtlpGetMode(VOID) { return UserMode; } @@ -298,8 +298,8 @@ RtlpCreateAtomHandleTable(PRTL_ATOM_TABLE AtomTable) { RtlInitializeHandleTable(0xCFFF, - sizeof(RTL_ATOM_HANDLE), - &AtomTable->RtlHandleTable); + sizeof(RTL_ATOM_HANDLE), + &AtomTable->RtlHandleTable); return TRUE; } Modified: trunk/reactos/hal/halx86/apic/tsc.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/hal/halx86/apic/tsc.c?rev=… ============================================================================== --- trunk/reactos/hal/halx86/apic/tsc.c [iso-8859-1] (original) +++ trunk/reactos/hal/halx86/apic/tsc.c [iso-8859-1] Thu Sep 3 23:57:39 2015 @@ -53,7 +53,7 @@ VOID NTAPI -HalpInitializeTsc() +HalpInitializeTsc(VOID) { ULONG_PTR Flags; KIDTENTRY OldIdtEntry, *IdtPointer; Modified: trunk/reactos/hal/halx86/generic/bios.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/hal/halx86/generic/bios.c?… ============================================================================== --- trunk/reactos/hal/halx86/generic/bios.c [iso-8859-1] (original) +++ trunk/reactos/hal/halx86/generic/bios.c [iso-8859-1] Thu Sep 3 23:57:39 2015 @@ -228,7 +228,7 @@ VOID DECLSPEC_NORETURN -HalpTrap06() +HalpTrap06(VOID) { /* Restore ES/DS to known good values first */ Ke386SetEs(KGDT_R3_DATA | RPL_MASK); @@ -247,7 +247,7 @@ VOID NTAPI -HalpBiosCall() +HalpBiosCall(VOID) { /* Must be volatile so it doesn't get optimized away! */ volatile KTRAP_FRAME V86TrapFrame; Modified: trunk/reactos/include/asm/asm.inc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/asm/asm.inc?rev=68… ============================================================================== --- trunk/reactos/include/asm/asm.inc [iso-8859-1] (original) +++ trunk/reactos/include/asm/asm.inc [iso-8859-1] Thu Sep 3 23:57:39 2015 @@ -2,7 +2,7 @@ * COPYRIGHT: See COPYING in the top level directory * PROJECT: ReactOS Kernel * FILE: ntoskrnl/include/amd64/asmmacro.S - * PURPOSE: ASM macros for for GAS and MASM/ML64 + * PURPOSE: ASM macros for GAS and MASM/ML64 * PROGRAMMERS: Timo Kreuzer (timo.kreuzer(a)reactos.org) */ Modified: trunk/reactos/lib/inflib/infrosgen.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/inflib/infrosgen.c?rev… ============================================================================== --- trunk/reactos/lib/inflib/infrosgen.c [iso-8859-1] (original) +++ trunk/reactos/lib/inflib/infrosgen.c [iso-8859-1] Thu Sep 3 23:57:39 2015 @@ -19,7 +19,7 @@ static int InfpHeapRefCount; static VOID -CheckHeap() +CheckHeap(VOID) { if (NULL == InfpHeap) { Modified: trunk/reactos/lib/rtl/heappage.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/rtl/heappage.c?rev=689… ============================================================================== --- trunk/reactos/lib/rtl/heappage.c [iso-8859-1] (original) +++ trunk/reactos/lib/rtl/heappage.c [iso-8859-1] Thu Sep 3 23:57:39 2015 @@ -1201,7 +1201,7 @@ } NTSTATUS NTAPI -RtlpDphInitializeDelayedFreeQueue() +RtlpDphInitializeDelayedFreeQueue(VOID) { NTSTATUS Status; @@ -1278,7 +1278,7 @@ } NTSTATUS NTAPI -RtlpDphTargetDllsLogicInitialize() +RtlpDphTargetDllsLogicInitialize(VOID) { UNIMPLEMENTED; return STATUS_SUCCESS; @@ -1428,7 +1428,7 @@ } NTSTATUS NTAPI -RtlpDphProcessStartupInitialization() +RtlpDphProcessStartupInitialization(VOID) { NTSTATUS Status; PTEB Teb = NtCurrentTeb(); Modified: trunk/reactos/ntoskrnl/ex/lookas.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ex/lookas.c?rev=6… ============================================================================== --- trunk/reactos/ntoskrnl/ex/lookas.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/ex/lookas.c [iso-8859-1] Thu Sep 3 23:57:39 2015 @@ -90,7 +90,7 @@ VOID NTAPI INIT_FUNCTION -ExpInitLookasideLists() +ExpInitLookasideLists(VOID) { ULONG i; Modified: trunk/reactos/ntoskrnl/fsrtl/tunnel.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/fsrtl/tunnel.c?re… ============================================================================== --- trunk/reactos/ntoskrnl/fsrtl/tunnel.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/fsrtl/tunnel.c [iso-8859-1] Thu Sep 3 23:57:39 2015 @@ -196,7 +196,7 @@ INIT_FUNCTION VOID NTAPI -FsRtlInitializeTunnels() +FsRtlInitializeTunnels(VOID) { ULONG TunnelEntries; UNICODE_STRING MaximumTunnelEntryAgeInSeconds = RTL_CONSTANT_STRING(L"MaximumTunnelEntryAgeInSeconds"); Modified: trunk/reactos/ntoskrnl/include/internal/amd64/ke.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/include/internal/… ============================================================================== --- trunk/reactos/ntoskrnl/include/internal/amd64/ke.h [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/include/internal/amd64/ke.h [iso-8859-1] Thu Sep 3 23:57:39 2015 @@ -260,7 +260,7 @@ VOID FORCEINLINE -KiSendEOI() +KiSendEOI(VOID) { /* Write 0 to the apic EOI register */ *((volatile ULONG*)APIC_EOI_REGISTER) = 0; Modified: trunk/reactos/ntoskrnl/include/internal/i386/intrin_i.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/include/internal/… ============================================================================== --- trunk/reactos/ntoskrnl/include/internal/i386/intrin_i.h [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/include/internal/i386/intrin_i.h [iso-8859-1] Thu Sep 3 23:57:39 2015 @@ -52,7 +52,7 @@ FORCEINLINE USHORT -Ke386GetLocalDescriptorTable() +Ke386GetLocalDescriptorTable(VOID) { USHORT Ldt; __asm__("sldt %0\n\t" Modified: trunk/reactos/ntoskrnl/io/iomgr/iomgr.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/io/iomgr/iomgr.c?… ============================================================================== --- trunk/reactos/ntoskrnl/io/iomgr/iomgr.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/io/iomgr/iomgr.c [iso-8859-1] Thu Sep 3 23:57:39 2015 @@ -332,7 +332,7 @@ BOOLEAN INIT_FUNCTION NTAPI -IopCreateRootDirectories() +IopCreateRootDirectories(VOID) { OBJECT_ATTRIBUTES ObjectAttributes; UNICODE_STRING DirName; Modified: trunk/reactos/ntoskrnl/kd/wrappers/gdbstub.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/kd/wrappers/gdbst… ============================================================================== --- trunk/reactos/ntoskrnl/kd/wrappers/gdbstub.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/kd/wrappers/gdbstub.c [iso-8859-1] Thu Sep 3 23:57:39 2015 @@ -133,7 +133,7 @@ /* scan for the sequence $<data>#<Checksum> */ PCHAR -GspGetPacket() +GspGetPacket(VOID) { PCHAR Buffer = &GspInBuffer[0]; CHAR Checksum; Modified: trunk/reactos/ntoskrnl/kd/wrappers/gdbstub_powerpc.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/kd/wrappers/gdbst… ============================================================================== --- trunk/reactos/ntoskrnl/kd/wrappers/gdbstub_powerpc.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/kd/wrappers/gdbstub_powerpc.c [iso-8859-1] Thu Sep 3 23:57:39 2015 @@ -181,7 +181,7 @@ /* scan for the sequence $<data>#<Checksum> */ PCHAR -GspGetPacket() +GspGetPacket(VOID) { PCHAR Buffer = &GspInBuffer[0]; CHAR Checksum; Modified: trunk/reactos/ntoskrnl/kdbg/kdb.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/kdbg/kdb.c?rev=68… ============================================================================== --- trunk/reactos/ntoskrnl/kdbg/kdb.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/kdbg/kdb.c [iso-8859-1] Thu Sep 3 23:57:39 2015 @@ -1236,7 +1236,7 @@ * Disables interrupts, releases display ownership, ... */ static VOID -KdbpInternalEnter() +KdbpInternalEnter(VOID) { PETHREAD Thread; PVOID SavedInitialStack, SavedStackBase, SavedKernelStack; Modified: trunk/reactos/ntoskrnl/kdbg/kdb_cli.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/kdbg/kdb_cli.c?re… ============================================================================== --- trunk/reactos/ntoskrnl/kdbg/kdb_cli.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/kdbg/kdb_cli.c [iso-8859-1] Thu Sep 3 23:57:39 2015 @@ -3512,7 +3512,7 @@ * call this function if KdbInitFileBuffer is not NULL. */ VOID -KdbpCliInterpretInitFile() +KdbpCliInterpretInitFile(VOID) { PCHAR p1, p2; INT i; @@ -3561,7 +3561,7 @@ * Reads the KDBinit file from the SystemRoot\System32\drivers\etc directory and executes it. */ VOID -KdbpCliInit() +KdbpCliInit(VOID) { NTSTATUS Status; OBJECT_ATTRIBUTES ObjectAttributes; Modified: trunk/reactos/ntoskrnl/ke/powerpc/kiinit.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ke/powerpc/kiinit… ============================================================================== --- trunk/reactos/ntoskrnl/ke/powerpc/kiinit.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/ke/powerpc/kiinit.c [iso-8859-1] Thu Sep 3 23:57:39 2015 @@ -41,19 +41,21 @@ VOID NTAPI -KiSetupSyscallHandler() +KiSetupSyscallHandler(VOID) { paddr_t handler_target; int *source; for(source = syscall_start, handler_target = 0xc00; - source < &syscall_end; - source++, handler_target += sizeof(int)) - SetPhys(handler_target, *source); -} - -VOID -NTAPI -KiSetupDecrementerTrap() + source < &syscall_end; + source++, handler_target += sizeof(int)) + { + SetPhys(handler_target, *source); + } +} + +VOID +NTAPI +KiSetupDecrementerTrap(VOID) { paddr_t handler_target; int *source; @@ -165,7 +167,7 @@ 0, 0xFFFFFFFF, &PageDirectory, - TRUE); + TRUE); InitProcess->QuantumReset = MAXCHAR; } else @@ -270,26 +272,26 @@ Cpu = KeNumberProcessors; if (!Cpu) { - /* We'll allocate a page from the end of the kernel area for KPCR. This code will probably - * change when we get SMP support. - */ - info[0].phys = 0; - info[0].proc = 2; - info[0].addr = (vaddr_t)Pcr; - info[0].flags = MMU_KRW_UR; - info[1].phys = 0; - info[1].proc = 2; - info[1].addr = ((vaddr_t)Pcr) + (1 << PAGE_SHIFT); - info[1].flags = MMU_KRW_UR; - info[2].phys = 0; - info[2].proc = 2; - info[2].addr = (vaddr_t)KI_USER_SHARED_DATA; - info[2].flags = MMU_KRW_UR; + /* We'll allocate a page from the end of the kernel area for KPCR. This code will probably + * change when we get SMP support. + */ + info[0].phys = 0; + info[0].proc = 2; + info[0].addr = (vaddr_t)Pcr; + info[0].flags = MMU_KRW_UR; + info[1].phys = 0; + info[1].proc = 2; + info[1].addr = ((vaddr_t)Pcr) + (1 << PAGE_SHIFT); + info[1].flags = MMU_KRW_UR; + info[2].phys = 0; + info[2].proc = 2; + info[2].addr = (vaddr_t)KI_USER_SHARED_DATA; + info[2].flags = MMU_KRW_UR; info[3].phys = 0; info[3].proc = 2; info[3].addr = (vaddr_t)KIP0PCRADDRESS; info[3].flags = MMU_KRW_UR; - MmuMapPage(info, 4); + MmuMapPage(info, 4); } /* Skip initial setup if this isn't the Boot CPU */ @@ -326,7 +328,7 @@ /* Check for break-in */ if (KdPollBreakIn()) { - DbgBreakPointWithStatus(DBG_STATUS_CONTROL_C); + DbgBreakPointWithStatus(DBG_STATUS_CONTROL_C); } /* Raise to HIGH_LEVEL */ @@ -347,7 +349,7 @@ { } -void abort() +void abort(VOID) { KeBugCheck(KMODE_EXCEPTION_NOT_HANDLED); while(1); Modified: trunk/reactos/ntoskrnl/ke/powerpc/stubs.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ke/powerpc/stubs.… ============================================================================== --- trunk/reactos/ntoskrnl/ke/powerpc/stubs.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/ke/powerpc/stubs.c [iso-8859-1] Thu Sep 3 23:57:39 2015 @@ -31,7 +31,7 @@ VOID NTAPI -KiUnexpectedInterrupt() +KiUnexpectedInterrupt(VOID) { } Modified: trunk/reactos/ntoskrnl/mm/ARM3/i386/init.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/ARM3/i386/init… ============================================================================== --- trunk/reactos/ntoskrnl/mm/ARM3/i386/init.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/mm/ARM3/i386/init.c [iso-8859-1] Thu Sep 3 23:57:39 2015 @@ -42,7 +42,7 @@ VOID NTAPI INIT_FUNCTION -MiInitializeSessionSpaceLayout() +MiInitializeSessionSpaceLayout(VOID) { // // Set the size of session view, pool, and image Modified: trunk/reactos/ntoskrnl/mm/ARM3/session.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/ARM3/session.c… ============================================================================== --- trunk/reactos/ntoskrnl/mm/ARM3/session.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/mm/ARM3/session.c [iso-8859-1] Thu Sep 3 23:57:39 2015 @@ -37,7 +37,7 @@ FORCEINLINE KIRQL -MiAcquireExpansionLock() +MiAcquireExpansionLock(VOID) { KIRQL OldIrql; Modified: trunk/reactos/ntoskrnl/mm/ARM3/special.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/ARM3/special.c… ============================================================================== --- trunk/reactos/ntoskrnl/mm/ARM3/special.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/mm/ARM3/special.c [iso-8859-1] Thu Sep 3 23:57:39 2015 @@ -588,7 +588,7 @@ VOID NTAPI -MiTestSpecialPool() +MiTestSpecialPool(VOID) { ULONG i; PVOID p1, p2[100]; Modified: trunk/reactos/ntoskrnl/mm/mminit.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/mminit.c?rev=6… ============================================================================== --- trunk/reactos/ntoskrnl/mm/mminit.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/mm/mminit.c [iso-8859-1] Thu Sep 3 23:57:39 2015 @@ -67,7 +67,7 @@ VOID INIT_FUNCTION NTAPI -MiInitSystemMemoryAreas() +MiInitSystemMemoryAreas(VOID) { // // Create all the static memory areas. Modified: trunk/reactos/ntoskrnl/ps/kill.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ps/kill.c?rev=689… ============================================================================== --- trunk/reactos/ntoskrnl/ps/kill.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/ps/kill.c [iso-8859-1] Thu Sep 3 23:57:39 2015 @@ -208,7 +208,7 @@ #if DBG VOID NTAPI -PspCheckProcessList() +PspCheckProcessList(VOID) { PLIST_ENTRY Entry; @@ -1066,7 +1066,7 @@ NTAPI PspIsProcessExiting(IN PEPROCESS Process) { - return Process->Flags & PSF_PROCESS_EXITING_BIT; + return Process->Flags & PSF_PROCESS_EXITING_BIT; } VOID Modified: trunk/reactos/ntoskrnl/ps/psmgr.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ps/psmgr.c?rev=68… ============================================================================== --- trunk/reactos/ntoskrnl/ps/psmgr.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/ps/psmgr.c [iso-8859-1] Thu Sep 3 23:57:39 2015 @@ -395,7 +395,7 @@ BOOLEAN NTAPI INIT_FUNCTION -PspInitPhase1() +PspInitPhase1(VOID) { /* Initialize the System DLL and return status of operation */ if (!NT_SUCCESS(PspInitializeSystemDll())) return FALSE; Modified: trunk/reactos/ntoskrnl/rtl/libsupp.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/rtl/libsupp.c?rev… ============================================================================== --- trunk/reactos/ntoskrnl/rtl/libsupp.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/rtl/libsupp.c [iso-8859-1] Thu Sep 3 23:57:39 2015 @@ -92,7 +92,7 @@ KPROCESSOR_MODE NTAPI -RtlpGetMode() +RtlpGetMode(VOID) { return KernelMode; }

1 0

[pschweitzer] 68970: [NTOSKRNL] Mark more functions as INIT
by pschweitzer＠svn.reactos.org 04 Sep '15

04 Sep '15

Author: pschweitzer Date: Thu Sep 3 22:19:16 2015 New Revision: 68970 URL: http://svn.reactos.org/svn/reactos?rev=68970&view=rev Log: [NTOSKRNL] Mark more functions as INIT Modified: trunk/reactos/ntoskrnl/fsrtl/largemcb.c trunk/reactos/ntoskrnl/fsrtl/tunnel.c Modified: trunk/reactos/ntoskrnl/fsrtl/largemcb.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/fsrtl/largemcb.c?… ============================================================================== --- trunk/reactos/ntoskrnl/fsrtl/largemcb.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/fsrtl/largemcb.c [iso-8859-1] Thu Sep 3 22:19:16 2015 @@ -474,6 +474,7 @@ /* * @implemented */ +INIT_FUNCTION VOID NTAPI FsRtlInitializeLargeMcbs(VOID) Modified: trunk/reactos/ntoskrnl/fsrtl/tunnel.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/fsrtl/tunnel.c?re… ============================================================================== --- trunk/reactos/ntoskrnl/fsrtl/tunnel.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/fsrtl/tunnel.c [iso-8859-1] Thu Sep 3 22:19:16 2015 @@ -129,6 +129,7 @@ } } +INIT_FUNCTION VOID FsRtlGetTunnelParameterValue( IN PUNICODE_STRING ParameterName, @@ -192,6 +193,7 @@ ZwClose(hKey); } +INIT_FUNCTION VOID NTAPI FsRtlInitializeTunnels()

1 0

[aandrejevic] 68969: [SHELL32] Make the RLE-compressed AVIs even smaller. CORE-10093 #resolve #comment Fixed in revision r68969.
by aandrejevic＠svn.reactos.org 04 Sep '15

04 Sep '15

Author: aandrejevic Date: Thu Sep 3 22:16:28 2015 New Revision: 68969 URL: http://svn.reactos.org/svn/reactos?rev=68969&view=rev Log: [SHELL32] Make the RLE-compressed AVIs even smaller. CORE-10093 #resolve #comment Fixed in revision r68969. Modified: trunk/reactos/dll/win32/shell32/res/avis/160+161+167+168.avi trunk/reactos/dll/win32/shell32/res/avis/162.avi trunk/reactos/dll/win32/shell32/res/avis/163.avi trunk/reactos/dll/win32/shell32/res/avis/164+169.avi trunk/reactos/dll/win32/shell32/res/avis/170.avi Modified: trunk/reactos/dll/win32/shell32/res/avis/160+161+167+168.avi URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/res/avis… ============================================================================== Binary files - no diff available. Modified: trunk/reactos/dll/win32/shell32/res/avis/162.avi URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/res/avis… ============================================================================== Binary files - no diff available. Modified: trunk/reactos/dll/win32/shell32/res/avis/163.avi URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/res/avis… ============================================================================== Binary files - no diff available. Modified: trunk/reactos/dll/win32/shell32/res/avis/164+169.avi URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/res/avis… ============================================================================== Binary files - no diff available. Modified: trunk/reactos/dll/win32/shell32/res/avis/170.avi URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/res/avis… ============================================================================== Binary files - no diff available.

1 0

[pschweitzer] 68968: [ADVAPI32] Fix memory leaks in case of failure CID 1322129 CID 1322130
by pschweitzer＠svn.reactos.org 03 Sep '15

03 Sep '15

Author: pschweitzer Date: Thu Sep 3 21:27:51 2015 New Revision: 68968 URL: http://svn.reactos.org/svn/reactos?rev=68968&view=rev Log: [ADVAPI32] Fix memory leaks in case of failure CID 1322129 CID 1322130 Modified: trunk/reactos/dll/win32/advapi32/service/sctrl.c Modified: trunk/reactos/dll/win32/advapi32/service/sctrl.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/advapi32/service… ============================================================================== --- trunk/reactos/dll/win32/advapi32/service/sctrl.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/advapi32/service/sctrl.c [iso-8859-1] Thu Sep 3 21:27:51 2015 @@ -472,7 +472,10 @@ &ThreadParamsW->dwArgCount, &ThreadParamsW->lpArgVector); if (dwError != ERROR_SUCCESS) + { + HeapFree(GetProcessHeap(), 0, ThreadParamsW); return dwError; + } ThreadParamsW->lpServiceMain = lpService->ServiceMain.W; ThreadHandle = CreateThread(NULL, 0, @@ -500,7 +503,10 @@ &ThreadParamsA->dwArgCount, &ThreadParamsA->lpArgVector); if (dwError != ERROR_SUCCESS) + { + HeapFree(GetProcessHeap(), 0, ThreadParamsA); return dwError; + } ThreadParamsA->lpServiceMain = lpService->ServiceMain.A; ThreadHandle = CreateThread(NULL, 0,

1 0

[pschweitzer] 68967: [MUP] Fix an hypthetic uninit var usage in MupCreate(). Dedicated to Chris. CID 1322239
by pschweitzer＠svn.reactos.org 03 Sep '15

03 Sep '15

Author: pschweitzer Date: Thu Sep 3 21:19:05 2015 New Revision: 68967 URL: http://svn.reactos.org/svn/reactos?rev=68967&view=rev Log: [MUP] Fix an hypthetic uninit var usage in MupCreate(). Dedicated to Chris. CID 1322239 Modified: trunk/reactos/drivers/filesystems/mup/mup.c Modified: trunk/reactos/drivers/filesystems/mup/mup.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/mup/mu… ============================================================================== --- trunk/reactos/drivers/filesystems/mup/mup.c [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/mup/mup.c [iso-8859-1] Thu Sep 3 21:19:05 2015 @@ -2214,12 +2214,9 @@ _SEH2_TRY { /* If DFS is enabled, check if that's for DFS and is so relay */ - if (MupEnableDfs) - { - if (DeviceObject->DeviceType == FILE_DEVICE_DFS || DeviceObject->DeviceType == FILE_DEVICE_DFS_FILE_SYSTEM) - { - Status = DfsFsdCreate(DeviceObject, Irp); - } + if (MupEnableDfs && (DeviceObject->DeviceType == FILE_DEVICE_DFS || DeviceObject->DeviceType == FILE_DEVICE_DFS_FILE_SYSTEM)) + { + Status = DfsFsdCreate(DeviceObject, Irp); } else {

1 0

[ekohl] 68966: [INTL] - Update all values in "HKCU\Control Panel\International" when a new language is selected. - Update the language examples after a language change. - Disable all settings that ...
by ekohl＠svn.reactos.org 03 Sep '15

03 Sep '15

Author: ekohl Date: Thu Sep 3 20:37:17 2015 New Revision: 68966 URL: http://svn.reactos.org/svn/reactos?rev=68966&view=rev Log: [INTL] - Update all values in "HKCU\Control Panel\International" when a new language is selected. - Update the language examples after a language change. - Disable all settings that should not be affected by a language change. Missing: - Top-level windows do not get notification yet. - Language settings customization should not work yet. CORE-10074 Modified: trunk/reactos/dll/cpl/intl/generalp.c trunk/reactos/dll/cpl/intl/intl.h Modified: trunk/reactos/dll/cpl/intl/generalp.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/cpl/intl/generalp.c?re… ============================================================================== --- trunk/reactos/dll/cpl/intl/generalp.c [iso-8859-1] (original) +++ trunk/reactos/dll/cpl/intl/generalp.c [iso-8859-1] Thu Sep 3 20:37:17 2015 @@ -135,12 +135,40 @@ /* or should it be System and not user? */ GetLocaleInfo(GetUserDefaultLCID(), LOCALE_SLANGUAGE, langSel, sizeof(langSel)/sizeof(TCHAR)); + DPRINT("LCID: %08lx\n", GetUserDefaultLCID()); + DPRINT("Language: %S\n", langSel); + SendMessage(hList, CB_SELECTSTRING, -1, (LPARAM)langSel); } + +static +VOID +SetLocaleString(HKEY hKey, + LCID lcId, + LCTYPE lcType, + PWSTR pszValueName) +{ + WCHAR szBuffer[256]; + + if (GetLocaleInfo(lcId, + lcType | LOCALE_NOUSEROVERRIDE, + szBuffer, + 256)) + { + RegSetValueExW(hKey, + pszValueName, + 0, + REG_SZ, + (PBYTE)szBuffer, + (wcslen(szBuffer) + 1) * sizeof(WCHAR)); + } +} + + /* Sets new locale */ VOID SetNewLocale(LCID lcid) @@ -151,13 +179,14 @@ // Set locale HKEY localeKey; - HKEY langKey; +// HKEY langKey; DWORD ret; - TCHAR value[9]; + WCHAR value[9]; DWORD valuesize; - TCHAR ACPPage[9]; - TCHAR OEMPage[9]; - +// TCHAR ACPPage[9]; +// TCHAR OEMPage[9]; + +#if 0 ret = GetLocaleInfo(MAKELCID(lcid, SORT_DEFAULT), LOCALE_IDEFAULTCODEPAGE, OEMPage, sizeof(OEMPage)/sizeof(TCHAR)); if (ret == 0) { @@ -171,20 +200,72 @@ PrintErrorMsgBox(IDS_ERROR_ANSI_CODE_PAGE); return; } - - ret = RegOpenKey(HKEY_CURRENT_USER, _T("Control Panel\\International"), &localeKey); +#endif + + ret = RegOpenKeyExW(HKEY_CURRENT_USER, L"Control Panel\\International", + 0, KEY_READ | KEY_WRITE, &localeKey); if (ret != ERROR_SUCCESS) { PrintErrorMsgBox(IDS_ERROR_INT_KEY_REG); return; } - wsprintf(value, _T("%04X"), (DWORD)lcid); - valuesize = (_tcslen(value) + 1) * sizeof(TCHAR); - - RegSetValueEx(localeKey, _T("Locale"), 0, REG_SZ, (LPBYTE)value, valuesize); + wsprintf(value, L"%08x", (DWORD)lcid); + valuesize = (wcslen(value) + 1) * sizeof(WCHAR); + + ret = RegSetValueExW(localeKey, L"Locale", 0, REG_SZ, (PBYTE)value, valuesize); + if (ret != ERROR_SUCCESS) + { + RegCloseKey(localeKey); + PrintErrorMsgBox(IDS_ERROR_INT_KEY_REG); + return; + } + + SetLocaleString(localeKey, lcid, LOCALE_ICALENDARTYPE, L"iCalendarType"); + SetLocaleString(localeKey, lcid, LOCALE_ICOUNTRY, L"iCountry"); + SetLocaleString(localeKey, lcid, LOCALE_ICURRDIGITS, L"iCurrDigits"); + SetLocaleString(localeKey, lcid, LOCALE_ICURRENCY, L"iCurrency"); + SetLocaleString(localeKey, lcid, LOCALE_IDATE, L"iDate"); + SetLocaleString(localeKey, lcid, LOCALE_IDIGITS, L"iDigits"); + SetLocaleString(localeKey, lcid, LOCALE_IFIRSTDAYOFWEEK, L"iFirstDayOfWeek"); + SetLocaleString(localeKey, lcid, LOCALE_IFIRSTWEEKOFYEAR, L"iFirstWeekOfYear"); + SetLocaleString(localeKey, lcid, LOCALE_ILZERO, L"iLZero"); + SetLocaleString(localeKey, lcid, LOCALE_IMEASURE, L"iMeasure"); + SetLocaleString(localeKey, lcid, LOCALE_INEGCURR, L"iNegCurr"); + SetLocaleString(localeKey, lcid, LOCALE_INEGNUMBER, L"iNegNumber"); + SetLocaleString(localeKey, lcid, LOCALE_ITIME, L"iTime"); + SetLocaleString(localeKey, lcid, LOCALE_ITIMEMARKPOSN, L"iTimePrefix"); + SetLocaleString(localeKey, lcid, LOCALE_ITLZERO, L"iTLZero"); + SetLocaleString(localeKey, lcid, LOCALE_IDIGITSUBSTITUTION, L"NumShape"); + SetLocaleString(localeKey, lcid, LOCALE_S1159, L"s1159"); + SetLocaleString(localeKey, lcid, LOCALE_S2359, L"s2359"); + SetLocaleString(localeKey, lcid, LOCALE_SCOUNTRY, L"sCountry"); + SetLocaleString(localeKey, lcid, LOCALE_SCURRENCY, L"sCurrency"); + SetLocaleString(localeKey, lcid, LOCALE_SDATE, L"sDate"); + SetLocaleString(localeKey, lcid, LOCALE_SDECIMAL, L"sDecimal"); + SetLocaleString(localeKey, lcid, LOCALE_SGROUPING, L"sGrouping"); + SetLocaleString(localeKey, lcid, LOCALE_SABBREVLANGNAME, L"sLanguage"); + SetLocaleString(localeKey, lcid, LOCALE_SLIST, L"sList"); + SetLocaleString(localeKey, lcid, LOCALE_SLONGDATE, L"sLongDate"); + SetLocaleString(localeKey, lcid, LOCALE_SMONDECIMALSEP, L"sMonDecimalSep"); + SetLocaleString(localeKey, lcid, LOCALE_SMONGROUPING, L"sMonGrouping"); + SetLocaleString(localeKey, lcid, LOCALE_SMONTHOUSANDSEP, L"sMonThousandSep"); + SetLocaleString(localeKey, lcid, LOCALE_SNATIVEDIGITS, L"sNativeDigits"); + SetLocaleString(localeKey, lcid, LOCALE_SNEGATIVESIGN, L"sNegativeSign"); + SetLocaleString(localeKey, lcid, LOCALE_SPOSITIVESIGN, L"sPositiveSign"); + SetLocaleString(localeKey, lcid, LOCALE_SSHORTDATE, L"sShortDate"); + SetLocaleString(localeKey, lcid, LOCALE_STHOUSAND, L"sThousand"); + SetLocaleString(localeKey, lcid, LOCALE_STIME, L"sTime"); + SetLocaleString(localeKey, lcid, LOCALE_STIMEFORMAT, L"sTimeFormat"); + + /* Flush and close the locale key */ + RegFlushKey(localeKey); RegCloseKey(localeKey); + /* Set the new locale for the current process */ + NtSetDefaultLocale(TRUE, lcid); + +#if 0 ret = RegOpenKey(HKEY_USERS, _T(".DEFAULT\\Control Panel\\International"), &localeKey); if (ret != ERROR_SUCCESS) { @@ -192,7 +273,7 @@ return; } - wsprintf(value, _T("%04X"), (DWORD)lcid); + wsprintf(value, _T("%08X"), (DWORD)lcid); valuesize = (_tcslen(value) + 1) * sizeof(TCHAR); RegSetValueEx(localeKey, _T("Locale"), 0, REG_SZ, (BYTE *)value, valuesize); @@ -224,6 +305,7 @@ RegSetValueExW(langKey, _T("ACP"), 0, REG_SZ, (BYTE *)ACPPage, (_tcslen(ACPPage) +1 ) * sizeof(TCHAR)); RegCloseKey(langKey); +#endif } /* Location enumerate procedure */ @@ -318,7 +400,7 @@ { case WM_INITDIALOG: CreateLanguagesList(GetDlgItem(hwndDlg, IDC_LANGUAGELIST)); - UpdateLocaleSample(hwndDlg, LOCALE_USER_DEFAULT); + UpdateLocaleSample(hwndDlg, GetUserDefaultLCID()); CreateLocationsList(GetDlgItem(hwndDlg, IDC_LOCATION_COMBO)); if (IsUnattendedSetupEnabled) { Modified: trunk/reactos/dll/cpl/intl/intl.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/cpl/intl/intl.h?rev=68… ============================================================================== --- trunk/reactos/dll/cpl/intl/intl.h [iso-8859-1] (original) +++ trunk/reactos/dll/cpl/intl/intl.h [iso-8859-1] Thu Sep 3 20:37:17 2015 @@ -13,6 +13,7 @@ #include <setupapi.h> #include <tchar.h> #include <malloc.h> +#include <ndk/exfuncs.h> #include "resource.h"

1 0

[pschweitzer] 68965: [CDFS] [FASTFAT] [MUP] [NTFS] Mark DriverEntry() and associated functions as INIT
by pschweitzer＠svn.reactos.org 03 Sep '15

03 Sep '15

Author: pschweitzer Date: Thu Sep 3 20:34:47 2015 New Revision: 68965 URL: http://svn.reactos.org/svn/reactos?rev=68965&view=rev Log: [CDFS] [FASTFAT] [MUP] [NTFS] Mark DriverEntry() and associated functions as INIT Modified: trunk/reactos/drivers/filesystems/cdfs/cdfs.c trunk/reactos/drivers/filesystems/cdfs/cdfs.h trunk/reactos/drivers/filesystems/fastfat/iface.c trunk/reactos/drivers/filesystems/fastfat/vfat.h trunk/reactos/drivers/filesystems/mup/mup.c trunk/reactos/drivers/filesystems/mup/mup.h trunk/reactos/drivers/filesystems/ntfs/ntfs.c trunk/reactos/drivers/filesystems/ntfs/ntfs.h Modified: trunk/reactos/drivers/filesystems/cdfs/cdfs.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/cdfs/c… ============================================================================== --- trunk/reactos/drivers/filesystems/cdfs/cdfs.c [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/cdfs/cdfs.c [iso-8859-1] Thu Sep 3 20:34:47 2015 @@ -39,6 +39,7 @@ /* FUNCTIONS ****************************************************************/ +INIT_FUNCTION NTSTATUS NTAPI DriverEntry(PDRIVER_OBJECT DriverObject, PUNICODE_STRING RegistryPath) Modified: trunk/reactos/drivers/filesystems/cdfs/cdfs.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/cdfs/c… ============================================================================== --- trunk/reactos/drivers/filesystems/cdfs/cdfs.h [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/cdfs/cdfs.h [iso-8859-1] Thu Sep 3 20:34:47 2015 @@ -4,6 +4,14 @@ #include <ntifs.h> #include <ntddcdrm.h> #include <pseh/pseh2.h> + +#ifdef __GNUC__ +#define INIT_SECTION __attribute__((section ("INIT"))) +#define INIT_FUNCTION INIT_SECTION +#else +#define INIT_SECTION /* Done via alloc_text for MSC */ +#define INIT_FUNCTION INIT_SECTION +#endif #define CDFS_BASIC_SECTOR 2048 #define CDFS_PRIMARY_DESCRIPTOR_LOCATION 16 Modified: trunk/reactos/drivers/filesystems/fastfat/iface.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/fastfa… ============================================================================== --- trunk/reactos/drivers/filesystems/fastfat/iface.c [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/fastfat/iface.c [iso-8859-1] Thu Sep 3 20:34:47 2015 @@ -43,6 +43,7 @@ * RegistryPath = path to our configuration entries * RETURNS: Success or failure */ +INIT_FUNCTION NTSTATUS NTAPI DriverEntry( Modified: trunk/reactos/drivers/filesystems/fastfat/vfat.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/fastfa… ============================================================================== --- trunk/reactos/drivers/filesystems/fastfat/vfat.h [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/fastfat/vfat.h [iso-8859-1] Thu Sep 3 20:34:47 2015 @@ -5,6 +5,14 @@ #include <ntdddisk.h> #include <dos.h> #include <pseh/pseh2.h> + +#ifdef __GNUC__ +#define INIT_SECTION __attribute__((section ("INIT"))) +#define INIT_FUNCTION INIT_SECTION +#else +#define INIT_SECTION /* Done via alloc_text for MSC */ +#define INIT_FUNCTION INIT_SECTION +#endif #define USE_ROS_CC_AND_FS #if 0 Modified: trunk/reactos/drivers/filesystems/mup/mup.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/mup/mu… ============================================================================== --- trunk/reactos/drivers/filesystems/mup/mup.c [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/mup/mup.c [iso-8859-1] Thu Sep 3 20:34:47 2015 @@ -53,6 +53,7 @@ /* FUNCTIONS ****************************************************************/ +INIT_FUNCTION VOID MupInitializeData() { @@ -78,6 +79,7 @@ ExDeleteResourceLite(&MupVcbLock); } +INIT_FUNCTION VOID MupInitializeVcb(PMUP_VCB Vcb) { @@ -2512,6 +2514,7 @@ MupUninitializeData(); } +INIT_FUNCTION NTSTATUS DfsDriverEntry(PDRIVER_OBJECT DriverObject, PUNICODE_STRING RegistryPath) @@ -2530,6 +2533,7 @@ * RegistryPath = path to our configuration entries * RETURNS: Success or failure */ +INIT_FUNCTION NTSTATUS NTAPI DriverEntry(PDRIVER_OBJECT DriverObject, Modified: trunk/reactos/drivers/filesystems/mup/mup.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/mup/mu… ============================================================================== --- trunk/reactos/drivers/filesystems/mup/mup.h [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/mup/mup.h [iso-8859-1] Thu Sep 3 20:34:47 2015 @@ -5,6 +5,14 @@ #include <ntifs.h> #include <pseh/pseh2.h> #include <ndk/muptypes.h> + +#ifdef __GNUC__ +#define INIT_SECTION __attribute__((section ("INIT"))) +#define INIT_FUNCTION INIT_SECTION +#else +#define INIT_SECTION /* Done via alloc_text for MSC */ +#define INIT_FUNCTION INIT_SECTION +#endif #define ROUND_UP(N, S) ((((N) + (S) - 1) / (S)) * (S)) #define IO_METHOD_FROM_CTL_CODE(C) (C & 0x00000003) Modified: trunk/reactos/drivers/filesystems/ntfs/ntfs.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/ntfs/n… ============================================================================== --- trunk/reactos/drivers/filesystems/ntfs/ntfs.c [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/ntfs/ntfs.c [iso-8859-1] Thu Sep 3 20:34:47 2015 @@ -44,6 +44,7 @@ * RegistryPath = path to our configuration entries * RETURNS: Success or failure */ +INIT_FUNCTION NTSTATUS NTAPI DriverEntry(PDRIVER_OBJECT DriverObject, @@ -122,6 +123,7 @@ * DriverObject = object describing this driver * RETURNS: Nothing */ +INIT_FUNCTION VOID NTAPI NtfsInitializeFunctionPointers(PDRIVER_OBJECT DriverObject) Modified: trunk/reactos/drivers/filesystems/ntfs/ntfs.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/ntfs/n… ============================================================================== --- trunk/reactos/drivers/filesystems/ntfs/ntfs.h [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/ntfs/ntfs.h [iso-8859-1] Thu Sep 3 20:34:47 2015 @@ -3,6 +3,14 @@ #include <ntifs.h> #include <pseh/pseh2.h> + +#ifdef __GNUC__ +#define INIT_SECTION __attribute__((section ("INIT"))) +#define INIT_FUNCTION INIT_SECTION +#else +#define INIT_SECTION /* Done via alloc_text for MSC */ +#define INIT_FUNCTION INIT_SECTION +#endif #define CACHEPAGESIZE(pDeviceExt) \ ((pDeviceExt)->NtfsInfo.UCHARsPerCluster > PAGE_SIZE ? \

1 0

[sginsberg] 68964: - Now that we actually take the trouble to set up MmLargeStackSize properly, use it! Also make it possible to set via the registry by adding it to the control vector table.
by sginsberg＠svn.reactos.org 03 Sep '15

03 Sep '15

Author: sginsberg Date: Thu Sep 3 20:04:28 2015 New Revision: 68964 URL: http://svn.reactos.org/svn/reactos?rev=68964&view=rev Log: - Now that we actually take the trouble to set up MmLargeStackSize properly, use it! Also make it possible to set via the registry by adding it to the control vector table. Modified: trunk/reactos/ntoskrnl/config/cmdata.c trunk/reactos/ntoskrnl/mm/ARM3/procsup.c Modified: trunk/reactos/ntoskrnl/config/cmdata.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/config/cmdata.c?r… ============================================================================== --- trunk/reactos/ntoskrnl/config/cmdata.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/config/cmdata.c [iso-8859-1] Thu Sep 3 20:04:28 2015 @@ -341,7 +341,7 @@ { L"Session Manager\\Memory Management", L"LargeStackSize", - &DummyData, + &MmLargeStackSize, NULL, NULL }, Modified: trunk/reactos/ntoskrnl/mm/ARM3/procsup.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/ARM3/procsup.c… ============================================================================== --- trunk/reactos/ntoskrnl/mm/ARM3/procsup.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/mm/ARM3/procsup.c [iso-8859-1] Thu Sep 3 20:04:28 2015 @@ -200,7 +200,7 @@ // Calculate pages used // StackPages = BYTES_TO_PAGES(GuiStack ? - KERNEL_LARGE_STACK_SIZE : KERNEL_STACK_SIZE); + MmLargeStackSize : KERNEL_STACK_SIZE); /* Acquire the PFN lock */ OldIrql = KeAcquireQueuedSpinLock(LockQueuePfnLock); @@ -275,7 +275,7 @@ // // We'll allocate 64KB stack, but only commit 12K // - StackPtes = BYTES_TO_PAGES(KERNEL_LARGE_STACK_SIZE); + StackPtes = BYTES_TO_PAGES(MmLargeStackSize); StackPages = BYTES_TO_PAGES(KERNEL_LARGE_STACK_COMMIT); } else @@ -317,7 +317,7 @@ // Select the right PTE address where we actually start committing pages // PointerPte = StackPte; - if (GuiStack) PointerPte += BYTES_TO_PAGES(KERNEL_LARGE_STACK_SIZE - + if (GuiStack) PointerPte += BYTES_TO_PAGES(MmLargeStackSize - KERNEL_LARGE_STACK_COMMIT); @@ -382,7 +382,7 @@ // Make sure the stack did not overflow // ASSERT(((ULONG_PTR)Thread->StackBase - (ULONG_PTR)Thread->StackLimit) <= - (KERNEL_LARGE_STACK_SIZE + PAGE_SIZE)); + (MmLargeStackSize + PAGE_SIZE)); // // Get the current stack limit @@ -400,7 +400,7 @@ // Now make sure you're not going past the reserved space // LastPte = MiAddressToPte((PVOID)((ULONG_PTR)Thread->StackBase - - KERNEL_LARGE_STACK_SIZE)); + MmLargeStackSize)); if (NewLimitPte < LastPte) { //

1 0

[aandrejevic] 68963: [SHELL32] RLE-compress the AVIs.
by aandrejevic＠svn.reactos.org 03 Sep '15

03 Sep '15

Author: aandrejevic Date: Thu Sep 3 19:42:46 2015 New Revision: 68963 URL: http://svn.reactos.org/svn/reactos?rev=68963&view=rev Log: [SHELL32] RLE-compress the AVIs. Modified: trunk/reactos/dll/win32/shell32/res/avis/160+161+167+168.avi trunk/reactos/dll/win32/shell32/res/avis/162.avi trunk/reactos/dll/win32/shell32/res/avis/163.avi trunk/reactos/dll/win32/shell32/res/avis/164+169.avi trunk/reactos/dll/win32/shell32/res/avis/170.avi Modified: trunk/reactos/dll/win32/shell32/res/avis/160+161+167+168.avi URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/res/avis… ============================================================================== Binary files - no diff available. Modified: trunk/reactos/dll/win32/shell32/res/avis/162.avi URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/res/avis… ============================================================================== Binary files - no diff available. Modified: trunk/reactos/dll/win32/shell32/res/avis/163.avi URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/res/avis… ============================================================================== Binary files - no diff available. Modified: trunk/reactos/dll/win32/shell32/res/avis/164+169.avi URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/res/avis… ============================================================================== Binary files - no diff available. Modified: trunk/reactos/dll/win32/shell32/res/avis/170.avi URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/res/avis… ============================================================================== Binary files - no diff available.

1 0

[sginsberg] 68962: - Enable INIT_FUNCTION for HAL while keeping FreeLdr happy and not putting anything into .INIT when compiling mini-HAL for it.
by sginsberg＠svn.reactos.org 03 Sep '15

03 Sep '15

Author: sginsberg Date: Thu Sep 3 17:52:13 2015 New Revision: 68962 URL: http://svn.reactos.org/svn/reactos?rev=68962&view=rev Log: - Enable INIT_FUNCTION for HAL while keeping FreeLdr happy and not putting anything into .INIT when compiling mini-HAL for it. Modified: trunk/reactos/hal/halx86/include/halp.h Modified: trunk/reactos/hal/halx86/include/halp.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/hal/halx86/include/halp.h?… ============================================================================== --- trunk/reactos/hal/halx86/include/halp.h [iso-8859-1] (original) +++ trunk/reactos/hal/halx86/include/halp.h [iso-8859-1] Thu Sep 3 17:52:13 2015 @@ -4,16 +4,12 @@ #pragma once -#define PLACE_IN_SECTION(s) __attribute__((section (s))) -#ifdef __GNUC__ -#define INIT_FUNCTION -#define PAGE_LOCKED_FUNCTION PLACE_IN_SECTION("pagelk") -#define PAGE_UNLOCKED_FUNCTION PLACE_IN_SECTION("pagepo") +#if defined(__GNUC__) && !defined(_MINIHAL_) +#define INIT_FUNCTION __attribute__((section ("INIT"))) #else -#define INIT_FUNCTION -#define PAGE_LOCKED_FUNCTION -#define PAGE_UNLOCKED_FUNCTION +#define INIT_FUNCTION /* Done via alloc_text for MSC */ #endif + #ifdef _MSC_VER #define REGISTERCALL FASTCALL

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs