Ros-diffs

ros-diffs@reactos.org

81390 discussions

[tfaber] 67711: [ADVAPI32] - Add parameter check to RegQueryInfoKeyA CORE-6976
by tfaber＠svn.reactos.org 14 May '15

14 May '15

Author: tfaber Date: Thu May 14 13:02:49 2015 New Revision: 67711 URL: http://svn.reactos.org/svn/reactos?rev=67711&view=rev Log: [ADVAPI32] - Add parameter check to RegQueryInfoKeyA CORE-6976 Modified: trunk/reactos/dll/win32/advapi32/reg/reg.c Modified: trunk/reactos/dll/win32/advapi32/reg/reg.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/advapi32/reg/reg… ============================================================================== --- trunk/reactos/dll/win32/advapi32/reg/reg.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/advapi32/reg/reg.c [iso-8859-1] Thu May 14 13:02:49 2015 @@ -3604,6 +3604,11 @@ NTSTATUS Status; DWORD cClass = 0; + if ((lpClass) && (!lpcClass)) + { + return ERROR_INVALID_PARAMETER; + } + RtlInitUnicodeString(&UnicodeString, NULL); if (lpClass != NULL)

1 0

[tkreuzer] 67710: [CRT] Add stubs for __stoi64 and __stou64
by tkreuzer＠svn.reactos.org 14 May '15

14 May '15

Author: tkreuzer Date: Thu May 14 10:20:08 2015 New Revision: 67710 URL: http://svn.reactos.org/svn/reactos?rev=67710&view=rev Log: [CRT] Add stubs for __stoi64 and __stou64 Added: trunk/reactos/lib/sdk/crt/math/arm/__stoi64.s (with props) trunk/reactos/lib/sdk/crt/math/arm/__stou64.s (with props) Added: trunk/reactos/lib/sdk/crt/math/arm/__stoi64.s URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/sdk/crt/math/arm/__sto… ============================================================================== --- trunk/reactos/lib/sdk/crt/math/arm/__stoi64.s (added) +++ trunk/reactos/lib/sdk/crt/math/arm/__stoi64.s [iso-8859-1] Thu May 14 10:20:08 2015 @@ -0,0 +1,24 @@ +/* + * COPYRIGHT: BSD - See COPYING.ARM in the top level directory + * PROJECT: ReactOS CRT library + * PURPOSE: Implementation of __stoi64 + * PROGRAMMER: Timo Kreuzer (timo.kreuzer(a)reactos.org) + */ + +/* INCLUDES ******************************************************************/ + +#include <kxarm.h> + +/* CODE **********************************************************************/ + + TEXTAREA + + LEAF_ENTRY __stoi64 + + __assertfail + bx lr + + LEAF_END __stoi64 + + END +/* EOF */ Propchange: trunk/reactos/lib/sdk/crt/math/arm/__stoi64.s ------------------------------------------------------------------------------ svn:eol-style = native Added: trunk/reactos/lib/sdk/crt/math/arm/__stou64.s URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/sdk/crt/math/arm/__sto… ============================================================================== --- trunk/reactos/lib/sdk/crt/math/arm/__stou64.s (added) +++ trunk/reactos/lib/sdk/crt/math/arm/__stou64.s [iso-8859-1] Thu May 14 10:20:08 2015 @@ -0,0 +1,24 @@ +/* + * COPYRIGHT: BSD - See COPYING.ARM in the top level directory + * PROJECT: ReactOS CRT library + * PURPOSE: Implementation of __stou64 + * PROGRAMMER: Timo Kreuzer (timo.kreuzer(a)reactos.org) + */ + +/* INCLUDES ******************************************************************/ + +#include <kxarm.h> + +/* CODE **********************************************************************/ + + TEXTAREA + + LEAF_ENTRY __stou64 + + __assertfail + bx lr + + LEAF_END __stou64 + + END +/* EOF */ Propchange: trunk/reactos/lib/sdk/crt/math/arm/__stou64.s ------------------------------------------------------------------------------ svn:eol-style = native

1 0

[tkreuzer] 67709: [D3DX9_36/WINED3D] - Remove useless copysignf invocation and the wrong defines for it - BrokenHacksOnTopOfBrokenCode--; - Should be sent upstream
by tkreuzer＠svn.reactos.org 14 May '15

14 May '15

Author: tkreuzer Date: Thu May 14 10:00:37 2015 New Revision: 67709 URL: http://svn.reactos.org/svn/reactos?rev=67709&view=rev Log: [D3DX9_36/WINED3D] - Remove useless copysignf invocation and the wrong defines for it - BrokenHacksOnTopOfBrokenCode--; - Should be sent upstream Modified: trunk/reactos/dll/directx/wine/d3dx9_36/math.c trunk/reactos/dll/directx/wine/wined3d/utils.c Modified: trunk/reactos/dll/directx/wine/d3dx9_36/math.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/directx/wine/d3dx9_36/… ============================================================================== --- trunk/reactos/dll/directx/wine/d3dx9_36/math.c [iso-8859-1] (original) +++ trunk/reactos/dll/directx/wine/d3dx9_36/math.c [iso-8859-1] Thu May 14 10:00:37 2015 @@ -24,10 +24,6 @@ #include "d3dx9_36_private.h" -#ifdef _MSC_VER -#define copysignf(x, y) ((x) < 0.0f ? -fabsf(y) : fabsf(y)) -#endif - struct ID3DXMatrixStackImpl { ID3DXMatrixStack ID3DXMatrixStack_iface; @@ -2122,7 +2118,7 @@ { int exp = 0, origexp; float tmp = fabsf(in); - int sign = (copysignf(1, in) < 0); + int sign = (in < 0); unsigned int mantissa; unsigned short ret; Modified: trunk/reactos/dll/directx/wine/wined3d/utils.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/directx/wine/wined3d/u… ============================================================================== --- trunk/reactos/dll/directx/wine/wined3d/utils.c [iso-8859-1] (original) +++ trunk/reactos/dll/directx/wine/wined3d/utils.c [iso-8859-1] Thu May 14 10:00:37 2015 @@ -25,10 +25,6 @@ */ #include "wined3d_private.h" - -#ifdef _MSC_VER -#define copysignf(x, y) ((x) < 0.0f ? -fabsf(y) : fabsf(y)) -#endif WINE_DEFAULT_DEBUG_CHANNEL(d3d); @@ -3991,7 +3987,7 @@ { int idx = 1; - if (copysignf(1.0f, value) < 0.0f) + if (value < 0.0f) ++idx; /* Be sure to allocate a buffer of at least 17 characters for the result

1 0

[aandrejevic] 67708: [FAST486] - Make Fast486ReadMemory and Fast486WriteMemory FASTCALL. - Fix build when FAST486_NO_FPU is defined.
by aandrejevic＠svn.reactos.org 13 May '15

13 May '15

Author: aandrejevic Date: Wed May 13 23:26:25 2015 New Revision: 67708 URL: http://svn.reactos.org/svn/reactos?rev=67708&view=rev Log: [FAST486] - Make Fast486ReadMemory and Fast486WriteMemory FASTCALL. - Fix build when FAST486_NO_FPU is defined. Modified: trunk/reactos/lib/fast486/common.c trunk/reactos/lib/fast486/common.h trunk/reactos/lib/fast486/fpu.c Modified: trunk/reactos/lib/fast486/common.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/fast486/common.c?rev=6… ============================================================================== --- trunk/reactos/lib/fast486/common.c [iso-8859-1] (original) +++ trunk/reactos/lib/fast486/common.c [iso-8859-1] Wed May 13 23:26:25 2015 @@ -32,6 +32,7 @@ /* PUBLIC FUNCTIONS ***********************************************************/ BOOLEAN +FASTCALL Fast486ReadMemory(PFAST486_STATE State, FAST486_SEG_REGS SegmentReg, ULONG Offset, @@ -156,6 +157,7 @@ } BOOLEAN +FASTCALL Fast486WriteMemory(PFAST486_STATE State, FAST486_SEG_REGS SegmentReg, ULONG Offset, Modified: trunk/reactos/lib/fast486/common.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/fast486/common.h?rev=6… ============================================================================== --- trunk/reactos/lib/fast486/common.h [iso-8859-1] (original) +++ trunk/reactos/lib/fast486/common.h [iso-8859-1] Wed May 13 23:26:25 2015 @@ -137,6 +137,7 @@ /* FUNCTIONS ******************************************************************/ BOOLEAN +FASTCALL Fast486ReadMemory ( PFAST486_STATE State, @@ -148,6 +149,7 @@ ); BOOLEAN +FASTCALL Fast486WriteMemory ( PFAST486_STATE State, Modified: trunk/reactos/lib/fast486/fpu.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/fast486/fpu.c?rev=6770… ============================================================================== --- trunk/reactos/lib/fast486/fpu.c [iso-8859-1] (original) +++ trunk/reactos/lib/fast486/fpu.c [iso-8859-1] Wed May 13 23:26:25 2015 @@ -1044,8 +1044,10 @@ { FAST486_MOD_REG_RM ModRegRm; BOOLEAN AddressSize = State->SegmentRegs[FAST486_REG_CS].Size; +#ifndef FAST486_NO_FPU PFAST486_FPU_DATA_REG SourceOperand, DestOperand; FAST486_FPU_DATA_REG MemoryData; +#endif TOGGLE_ADSIZE(AddressSize); @@ -1692,9 +1694,11 @@ { FAST486_MOD_REG_RM ModRegRm; BOOLEAN AddressSize = State->SegmentRegs[FAST486_REG_CS].Size; +#ifndef FAST486_NO_FPU PFAST486_FPU_DATA_REG SourceOperand, DestOperand; LONG Value; FAST486_FPU_DATA_REG MemoryData; +#endif TOGGLE_ADSIZE(AddressSize); @@ -2013,8 +2017,10 @@ { FAST486_MOD_REG_RM ModRegRm; BOOLEAN AddressSize = State->SegmentRegs[FAST486_REG_CS].Size; +#ifndef FAST486_NO_FPU PFAST486_FPU_DATA_REG SourceOperand, DestOperand; FAST486_FPU_DATA_REG MemoryData; +#endif TOGGLE_ADSIZE(AddressSize); @@ -2389,7 +2395,9 @@ { FAST486_MOD_REG_RM ModRegRm; BOOLEAN AddressSize = State->SegmentRegs[FAST486_REG_CS].Size; +#ifndef FAST486_NO_FPU PFAST486_FPU_DATA_REG SourceOperand, DestOperand; +#endif TOGGLE_ADSIZE(AddressSize);

1 0

[aandrejevic] 67707: [NTVDM] Fill the part of the buffer that was supposed to receive memory data above the MAX_ADDRESS with 0xFF.
by aandrejevic＠svn.reactos.org 13 May '15

13 May '15

Author: aandrejevic Date: Wed May 13 23:23:17 2015 New Revision: 67707 URL: http://svn.reactos.org/svn/reactos?rev=67707&view=rev Log: [NTVDM] Fill the part of the buffer that was supposed to receive memory data above the MAX_ADDRESS with 0xFF. Modified: trunk/reactos/subsystems/mvdm/ntvdm/emulator.c Modified: trunk/reactos/subsystems/mvdm/ntvdm/emulator.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/mvdm/ntvdm/emul… ============================================================================== --- trunk/reactos/subsystems/mvdm/ntvdm/emulator.c [iso-8859-1] (original) +++ trunk/reactos/subsystems/mvdm/ntvdm/emulator.c [iso-8859-1] Wed May 13 23:23:17 2015 @@ -73,8 +73,16 @@ /* If the A20 line is disabled, mask bit 20 */ if (!A20Line) Address &= ~(1 << 20); - if (Address >= MAX_ADDRESS) return; - Size = min(Size, MAX_ADDRESS - Address); + if ((Address + Size - 1) >= MAX_ADDRESS) + { + ULONG ExtraStart = (Address < MAX_ADDRESS) ? MAX_ADDRESS - Address : 0; + + /* Fill the memory that was above the limit with 0xFF */ + RtlFillMemory((PVOID)((ULONG_PTR)Buffer + ExtraStart), Size - ExtraStart, 0xFF); + + if (Address < MAX_ADDRESS) Size = MAX_ADDRESS - Address; + else return; + } /* Read while calling fast memory hooks */ MemRead(Address, Buffer, Size);

1 0

[akhaldi] 67706: [CMAKE] Add a minimum major/minor subsystem version number for ARM. Dedicated to Timo.
by akhaldi＠svn.reactos.org 13 May '15

13 May '15

Author: akhaldi Date: Wed May 13 12:12:20 2015 New Revision: 67706 URL: http://svn.reactos.org/svn/reactos?rev=67706&view=rev Log: [CMAKE] Add a minimum major/minor subsystem version number for ARM. Dedicated to Timo. Modified: trunk/reactos/cmake/msvc.cmake Modified: trunk/reactos/cmake/msvc.cmake URL: http://svn.reactos.org/svn/reactos/trunk/reactos/cmake/msvc.cmake?rev=67706… ============================================================================== --- trunk/reactos/cmake/msvc.cmake [iso-8859-1] (original) +++ trunk/reactos/cmake/msvc.cmake [iso-8859-1] Wed May 13 12:12:20 2015 @@ -213,6 +213,8 @@ string(TOUPPER ${SUBSYSTEM} _subsystem) if(ARCH STREQUAL "amd64") add_target_link_flags(${MODULE} "/SUBSYSTEM:${_subsystem},5.02") + elseif(ARCH STREQUAL "arm") + add_target_link_flags(${MODULE} "/SUBSYSTEM:${_subsystem},6.02") else() add_target_link_flags(${MODULE} "/SUBSYSTEM:${_subsystem},5.01") endif()

1 0

[cfinck] 67705: spec2def requires the DLL filename and not the module name in its parameters. Fixes delay-importing spoolss.dll.
by cfinck＠svn.reactos.org 13 May '15

13 May '15

Author: cfinck Date: Wed May 13 07:03:05 2015 New Revision: 67705 URL: http://svn.reactos.org/svn/reactos?rev=67705&view=rev Log: spec2def requires the DLL filename and not the module name in its parameters. Fixes delay-importing spoolss.dll. Modified: branches/colins-printing-for-freedom/reactos/win32ss/printing/base/spoolss/CMakeLists.txt Modified: branches/colins-printing-for-freedom/reactos/win32ss/printing/base/spoolss/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/branches/colins-printing-for-freedom/rea… ============================================================================== --- branches/colins-printing-for-freedom/reactos/win32ss/printing/base/spoolss/CMakeLists.txt [iso-8859-1] (original) +++ branches/colins-printing-for-freedom/reactos/win32ss/printing/base/spoolss/CMakeLists.txt [iso-8859-1] Wed May 13 07:03:05 2015 @@ -1,5 +1,5 @@ -spec2def(spoolss spoolss.spec ADD_IMPORTLIB) +spec2def(spoolss.dll spoolss.spec ADD_IMPORTLIB) list(APPEND SOURCE context.c

1 0

[aandrejevic] 67704: [FAST486] For regular protected mode interrupts, the TF and NT flags should be cleared.
by aandrejevic＠svn.reactos.org 13 May '15

13 May '15

Author: aandrejevic Date: Wed May 13 03:00:54 2015 New Revision: 67704 URL: http://svn.reactos.org/svn/reactos?rev=67704&view=rev Log: [FAST486] For regular protected mode interrupts, the TF and NT flags should be cleared. Modified: trunk/reactos/lib/fast486/common.c Modified: trunk/reactos/lib/fast486/common.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/fast486/common.c?rev=6… ============================================================================== --- trunk/reactos/lib/fast486/common.c [iso-8859-1] (original) +++ trunk/reactos/lib/fast486/common.c [iso-8859-1] Wed May 13 03:00:54 2015 @@ -428,6 +428,9 @@ State->InstPtr.LowWord = IdtEntry->Offset; } + /* Clear TF and NT */ + State->Flags.Tf = State->Flags.Nt = FALSE; + if (OldVm) { /* Push GS, FS, DS and ES */

1 0

[aandrejevic] 67703: [FAST486] Addendum to r67702.
by aandrejevic＠svn.reactos.org 12 May '15

12 May '15

Author: aandrejevic Date: Tue May 12 21:37:10 2015 New Revision: 67703 URL: http://svn.reactos.org/svn/reactos?rev=67703&view=rev Log: [FAST486] Addendum to r67702. Modified: trunk/reactos/lib/fast486/opcodes.c Modified: trunk/reactos/lib/fast486/opcodes.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/fast486/opcodes.c?rev=… ============================================================================== --- trunk/reactos/lib/fast486/opcodes.c [iso-8859-1] (original) +++ trunk/reactos/lib/fast486/opcodes.c [iso-8859-1] Tue May 12 21:37:10 2015 @@ -635,12 +635,7 @@ /* Make sure this is the right instruction */ ASSERT(Opcode == 0xF8); - /* No prefixes allowed */ - if (State->PrefixFlags) - { - Fast486Exception(State, FAST486_EXCEPTION_UD); - return; - } + NO_LOCK_PREFIX(); /* Clear CF and return success */ State->Flags.Cf = FALSE; @@ -651,12 +646,7 @@ /* Make sure this is the right instruction */ ASSERT(Opcode == 0xF9); - /* No prefixes allowed */ - if (State->PrefixFlags) - { - Fast486Exception(State, FAST486_EXCEPTION_UD); - return; - } + NO_LOCK_PREFIX(); /* Set CF and return success*/ State->Flags.Cf = TRUE; @@ -667,12 +657,7 @@ /* Make sure this is the right instruction */ ASSERT(Opcode == 0xF5); - /* No prefixes allowed */ - if (State->PrefixFlags) - { - Fast486Exception(State, FAST486_EXCEPTION_UD); - return; - } + NO_LOCK_PREFIX(); /* Toggle CF and return success */ State->Flags.Cf = !State->Flags.Cf; @@ -684,12 +669,7 @@ /* Make sure this is the right instruction */ ASSERT(Opcode == 0xFA); - /* No prefixes allowed */ - if (State->PrefixFlags) - { - Fast486Exception(State, FAST486_EXCEPTION_UD); - return; - } + NO_LOCK_PREFIX(); /* Check for protected mode */ if (State->ControlRegisters[FAST486_REG_CR0] & FAST486_CR0_PE) @@ -719,12 +699,7 @@ /* Make sure this is the right instruction */ ASSERT(Opcode == 0xFB); - /* No prefixes allowed */ - if (State->PrefixFlags) - { - Fast486Exception(State, FAST486_EXCEPTION_UD); - return; - } + NO_LOCK_PREFIX(); /* Check for protected mode */ if (State->ControlRegisters[FAST486_REG_CR0] & FAST486_CR0_PE) @@ -754,12 +729,7 @@ /* Make sure this is the right instruction */ ASSERT(Opcode == 0xFC); - /* No prefixes allowed */ - if (State->PrefixFlags) - { - Fast486Exception(State, FAST486_EXCEPTION_UD); - return; - } + NO_LOCK_PREFIX(); /* Clear DF */ State->Flags.Df = FALSE; @@ -770,12 +740,7 @@ /* Make sure this is the right instruction */ ASSERT(Opcode == 0xFD); - /* No prefixes allowed */ - if (State->PrefixFlags) - { - Fast486Exception(State, FAST486_EXCEPTION_UD); - return; - } + NO_LOCK_PREFIX(); /* Set DF */ State->Flags.Df = TRUE; @@ -786,12 +751,7 @@ /* Make sure this is the right instruction */ ASSERT(Opcode == 0xF4); - /* No prefixes allowed */ - if (State->PrefixFlags) - { - Fast486Exception(State, FAST486_EXCEPTION_UD); - return; - } + NO_LOCK_PREFIX(); /* Privileged instructions can only be executed under CPL = 0 */ if (Fast486GetCurrentPrivLevel(State) != 0)

1 0

[aandrejevic] 67702: [FAST486] Superfluous prefixes don't usually generate #UD, except for LOCK.
by aandrejevic＠svn.reactos.org 12 May '15

12 May '15

Author: aandrejevic Date: Tue May 12 20:08:39 2015 New Revision: 67702 URL: http://svn.reactos.org/svn/reactos?rev=67702&view=rev Log: [FAST486] Superfluous prefixes don't usually generate #UD, except for LOCK. Modified: trunk/reactos/lib/fast486/opcodes.c Modified: trunk/reactos/lib/fast486/opcodes.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/fast486/opcodes.c?rev=… ============================================================================== --- trunk/reactos/lib/fast486/opcodes.c [iso-8859-1] (original) +++ trunk/reactos/lib/fast486/opcodes.c [iso-8859-1] Tue May 12 20:08:39 2015 @@ -1046,12 +1046,7 @@ /* Make sure this is the right instruction */ ASSERT((Opcode & 0xF8) == 0xB0); - if (State->PrefixFlags != 0) - { - /* Invalid prefix */ - Fast486Exception(State, FAST486_EXCEPTION_UD); - return; - } + NO_LOCK_PREFIX(); /* Fetch the byte */ if (!Fast486FetchByte(State, &Value)) @@ -1211,12 +1206,7 @@ /* Make sure this is the right instruction */ ASSERT(Opcode == 0x04); - if (State->PrefixFlags) - { - /* This opcode doesn't take any prefixes */ - Fast486Exception(State, FAST486_EXCEPTION_UD); - return; - } + NO_LOCK_PREFIX(); if (!Fast486FetchByte(State, &SecondValue)) { @@ -1437,12 +1427,7 @@ /* Make sure this is the right instruction */ ASSERT(Opcode == 0x0C); - if (State->PrefixFlags) - { - /* This opcode doesn't take any prefixes */ - Fast486Exception(State, FAST486_EXCEPTION_UD); - return; - } + NO_LOCK_PREFIX(); if (!Fast486FetchByte(State, &SecondValue)) { @@ -1872,12 +1857,7 @@ /* Make sure this is the right instruction */ ASSERT(Opcode == 0x34); - if (State->PrefixFlags) - { - /* This opcode doesn't take any prefixes */ - Fast486Exception(State, FAST486_EXCEPTION_UD); - return; - } + NO_LOCK_PREFIX(); if (!Fast486FetchByte(State, &SecondValue)) { @@ -2073,12 +2053,7 @@ /* Make sure this is the right instruction */ ASSERT(Opcode == 0xA8); - if (State->PrefixFlags) - { - /* This opcode doesn't take any prefixes */ - Fast486Exception(State, FAST486_EXCEPTION_UD); - return; - } + NO_LOCK_PREFIX(); if (!Fast486FetchByte(State, &SecondValue)) { @@ -2454,12 +2429,7 @@ /* Make sure this is the right instruction */ ASSERT(Opcode == 0x14); - if (State->PrefixFlags) - { - /* This opcode doesn't take any prefixes */ - Fast486Exception(State, FAST486_EXCEPTION_UD); - return; - } + NO_LOCK_PREFIX(); if (!Fast486FetchByte(State, &SecondValue)) { @@ -2746,12 +2716,7 @@ /* Make sure this is the right instruction */ ASSERT(Opcode == 0x1C); - if (State->PrefixFlags) - { - /* This opcode doesn't take any prefixes */ - Fast486Exception(State, FAST486_EXCEPTION_UD); - return; - } + NO_LOCK_PREFIX(); if (!Fast486FetchByte(State, &SecondValue)) { @@ -3073,12 +3038,7 @@ /* Make sure this is the right instruction */ ASSERT((Opcode & 0xEF) == 0x2C); - if (State->PrefixFlags) - { - /* This opcode doesn't take any prefixes */ - Fast486Exception(State, FAST486_EXCEPTION_UD); - return; - } + NO_LOCK_PREFIX(); if (!Fast486FetchByte(State, &SecondValue)) {

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs