Ros-diffs

ros-diffs@reactos.org

81390 discussions

[tkreuzer] 65736: [USER32] Fix copy-paste-bug in SubtractRect
by tkreuzer＠svn.reactos.org 18 Dec '14

18 Dec '14

Author: tkreuzer Date: Thu Dec 18 08:13:01 2014 New Revision: 65736 URL: http://svn.reactos.org/svn/reactos?rev=65736&view=rev Log: [USER32] Fix copy-paste-bug in SubtractRect Modified: trunk/reactos/win32ss/user/user32/windows/rect.c Modified: trunk/reactos/win32ss/user/user32/windows/rect.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/user32/window… ============================================================================== --- trunk/reactos/win32ss/user/user32/windows/rect.c [iso-8859-1] (original) +++ trunk/reactos/win32ss/user/user32/windows/rect.c [iso-8859-1] Thu Dec 18 08:13:01 2014 @@ -218,8 +218,8 @@ { if(lprcDst->top == tempRect.top) lprcDst->top = tempRect.bottom; - else if(lprcDst->right == tempRect.right) - lprcDst->right = tempRect.left; + else if(lprcDst->bottom == tempRect.bottom) + lprcDst->bottom = tempRect.top; } return(TRUE);

1 0

[tkreuzer] 65735: [WIN32K] - Rename xmemcheck to REGION_bGrowBufferSize - Implement REGION_bEnsureBufferSize and REGION_vAddRect helper functions - Replace MERGERECT macro with REGION_bMergeRect in...
by tkreuzer＠svn.reactos.org 18 Dec '14

18 Dec '14

Author: tkreuzer Date: Thu Dec 18 08:12:55 2014 New Revision: 65735 URL: http://svn.reactos.org/svn/reactos?rev=65735&view=rev Log: [WIN32K] - Rename xmemcheck to REGION_bGrowBufferSize - Implement REGION_bEnsureBufferSize and REGION_vAddRect helper functions - Replace MERGERECT macro with REGION_bMergeRect inline function Modified: trunk/reactos/win32ss/gdi/ntgdi/region.c Modified: trunk/reactos/win32ss/gdi/ntgdi/region.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/gdi/ntgdi/region.c… ============================================================================== --- trunk/reactos/win32ss/gdi/ntgdi/region.c [iso-8859-1] (original) +++ trunk/reactos/win32ss/gdi/ntgdi/region.c [iso-8859-1] Thu Dec 18 08:12:55 2014 @@ -405,43 +405,109 @@ #define LARGE_COORDINATE 0x7fffffff /* FIXME */ #define SMALL_COORDINATE 0x80000000 -/* - * Check to see if there is enough memory in the present region. - */ -static __inline INT xmemcheck(PREGION reg, PRECTL *rect, PRECTL *firstrect) -{ - if ((reg->rdh.nCount+1) * sizeof(RECT) >= reg->rdh.nRgnSize) - { - PRECTL temp; - DWORD NewSize = 2 * reg->rdh.nRgnSize; - - if (NewSize < (reg->rdh.nCount + 1) * sizeof(RECT)) - { - NewSize = (reg->rdh.nCount + 1) * sizeof(RECT); - } - - temp = ExAllocatePoolWithTag(PagedPool, NewSize, TAG_REGION); - if (temp == NULL) - { - return 0; - } - - /* Copy the rectangles */ - COPY_RECTS(temp, *firstrect, reg->rdh.nCount); - - reg->rdh.nRgnSize = NewSize; - if (*firstrect != &reg->rdh.rcBound) - { - ExFreePoolWithTag(*firstrect, TAG_REGION); - } - - *firstrect = temp; - *rect = (*firstrect) + reg->rdh.nCount; - } - return 1; -} - -#define MEMCHECK(reg, rect, firstrect) xmemcheck(reg,&(rect),(PRECTL *)&(firstrect)) +static +BOOL +REGION_bGrowBufferSize( + _Inout_ PREGION prgn, + _In_ UINT cRects) +{ + ULONG cjNewSize; + PVOID pvBuffer; + NT_ASSERT(cRects > 0); + + /* Make sure we don't overflow */ + if (cRects > MAXULONG / sizeof(RECTL)) + { + return FALSE; + } + + /* Calculate new buffer size */ + cjNewSize = cRects * sizeof(RECTL); + + /* Avoid allocating too often, by duplicating the old buffer size + Note: we don't do an overflow check, since the old size will never + get that large before running out of memory. */ + if (2 * prgn->rdh.nRgnSize > cjNewSize) + { + cjNewSize = 2 * prgn->rdh.nRgnSize; + } + + /* Allocate the new buffer */ + pvBuffer = ExAllocatePoolWithTag(PagedPool, cjNewSize, TAG_REGION); + if (pvBuffer == NULL) + { + return FALSE; + } + + /* Copy the rects into the new buffer */ + COPY_RECTS(pvBuffer, prgn->Buffer, prgn->rdh.nCount); + + /* Free the old buffer */ + if (prgn->Buffer != &prgn->rdh.rcBound) + { + ExFreePoolWithTag(prgn->Buffer, TAG_REGION); + } + + /* Set the new buffer */ + prgn->Buffer = pvBuffer; + prgn->rdh.nRgnSize = cjNewSize; + + return TRUE; +} + +static __inline +BOOL +REGION_bEnsureBufferSize( + _Inout_ PREGION prgn, + _In_ UINT cRects) +{ + /* Check if the current region size is too small */ + if (cRects > prgn->rdh.nRgnSize / sizeof(RECTL)) + { + /* Allocate a new buffer */ + return REGION_bGrowBufferSize(prgn, cRects); + } + + return TRUE; +} + +FORCEINLINE +VOID +REGION_vAddRect( + _Inout_ PREGION prgn, + _In_ LONG left, + _In_ LONG top, + _In_ LONG right, + _In_ LONG bottom) +{ + PRECTL prcl; + NT_ASSERT((prgn->rdh.nCount + 1) * sizeof(RECT) <= prgn->rdh.nRgnSize); + + prcl = &prgn->Buffer[prgn->rdh.nCount]; + prcl->left = left; + prcl->top = top; + prcl->right = right; + prcl->bottom = bottom; + prgn->rdh.nCount++; +} + +static __inline +BOOL +REGION_bAddRect( + _Inout_ PREGION prgn, + _In_ LONG left, + _In_ LONG top, + _In_ LONG right, + _In_ LONG bottom) +{ + if (!REGION_bEnsureBufferSize(prgn, prgn->rdh.nCount + 1)) + { + return FALSE; + } + + REGION_vAddRect(prgn, left, top, right, bottom); + return TRUE; +} typedef VOID (FASTCALL *overlapProcp)(PREGION, PRECT, PRECT, PRECT, PRECT, INT, INT); typedef VOID (FASTCALL *nonOverlapProcp)(PREGION, PRECT, PRECT, INT, INT); @@ -1180,10 +1246,7 @@ INT top, INT bottom) { - INT left, right; - RECTL *pNextRect; - - pNextRect = pReg->Buffer + pReg->rdh.nCount; + INT left, right; while ((r1 != r1End) && (r2 != r2End)) { @@ -1197,13 +1260,10 @@ * right next to each other. Since that should never happen... */ if (left < right) { - MEMCHECK(pReg, pNextRect, pReg->Buffer); - pNextRect->left = left; - pNextRect->top = top; - pNextRect->right = right; - pNextRect->bottom = bottom; - pReg->rdh.nCount += 1; - pNextRect++; + if (!REGION_bAddRect(pReg, left, top, right, bottom)) + { + return; + } } /* Need to advance the pointers. Shift the one that extends @@ -1290,23 +1350,52 @@ INT top, INT bottom) { - RECTL *pNextRect; - - pNextRect = pReg->Buffer + pReg->rdh.nCount; - - while (r != rEnd) - { - MEMCHECK(pReg, pNextRect, pReg->Buffer); - pNextRect->left = r->left; - pNextRect->top = top; - pNextRect->right = r->right; - pNextRect->bottom = bottom; - pReg->rdh.nCount += 1; - pNextRect++; - r++; + if (r != rEnd) + { + if (!REGION_bEnsureBufferSize(pReg, pReg->rdh.nCount + (rEnd - r))) + { + return; + } + + do + { + REGION_vAddRect(pReg, r->left, top, r->right, bottom); + r++; + } + while (r != rEnd); } return; +} + +static __inline +BOOL +REGION_bMergeRect( + _Inout_ PREGION prgn, + _In_ LONG left, + _In_ LONG top, + _In_ LONG right, + _In_ LONG bottom) +{ + if ((prgn->rdh.nCount != 0) && + (prgn->Buffer[prgn->rdh.nCount - 1].top == top) && + (prgn->Buffer[prgn->rdh.nCount - 1].bottom == bottom) && + (prgn->Buffer[prgn->rdh.nCount - 1].right >= left)) + { + if (prgn->Buffer[prgn->rdh.nCount - 1].right < right) + { + prgn->Buffer[prgn->rdh.nCount - 1].right = right; + } + } + else + { + if (!REGION_bAddRect(prgn, left, top, right, bottom)) + { + return FALSE; + } + } + + return TRUE; } /*! @@ -1333,42 +1422,17 @@ INT top, INT bottom) { - RECTL *pNextRect; - - pNextRect = pReg->Buffer + pReg->rdh.nCount; - -#define MERGERECT(r) \ - if ((pReg->rdh.nCount != 0) && \ - ((pNextRect-1)->top == top) && \ - ((pNextRect-1)->bottom == bottom) && \ - ((pNextRect-1)->right >= r->left)) \ - { \ - if ((pNextRect-1)->right < r->right) \ - { \ - (pNextRect-1)->right = r->right; \ - } \ - } \ - else \ - { \ - MEMCHECK(pReg, pNextRect, pReg->Buffer); \ - pNextRect->top = top; \ - pNextRect->bottom = bottom; \ - pNextRect->left = r->left; \ - pNextRect->right = r->right; \ - pReg->rdh.nCount += 1; \ - pNextRect += 1; \ - } \ - r++; - while ((r1 != r1End) && (r2 != r2End)) { if (r1->left < r2->left) { - MERGERECT(r1); + REGION_bMergeRect(pReg, r1->left, top, r1->right, bottom); + r1++; } else { - MERGERECT(r2); + REGION_bMergeRect(pReg, r2->left, top, r2->right, bottom); + r2++; } } @@ -1376,7 +1440,8 @@ { do { - MERGERECT(r1); + REGION_bMergeRect(pReg, r1->left, top, r1->right, bottom); + r1++; } while (r1 != r1End); } @@ -1384,7 +1449,8 @@ { while (r2 != r2End) { - MERGERECT(r2); + REGION_bMergeRect(pReg, r2->left, top, r2->right, bottom); + r2++; } } @@ -1497,20 +1563,19 @@ INT top, INT bottom) { - RECTL *pNextRect; - - pNextRect = pReg->Buffer + pReg->rdh.nCount; - - while (r != rEnd) - { - MEMCHECK(pReg, pNextRect, pReg->Buffer); - pNextRect->left = r->left; - pNextRect->top = top; - pNextRect->right = r->right; - pNextRect->bottom = bottom; - pReg->rdh.nCount += 1; - pNextRect++; - r++; + if (r != rEnd) + { + if (!REGION_bEnsureBufferSize(pReg, pReg->rdh.nCount + (rEnd - r))) + { + return; + } + + do + { + REGION_vAddRect(pReg, r->left, top, r->right, bottom); + r++; + } + while (r != rEnd); } return; @@ -1540,11 +1605,9 @@ INT top, INT bottom) { - RECTL *pNextRect; INT left; left = r1->left; - pNextRect = pReg->Buffer + pReg->rdh.nCount; while ((r1 != r1End) && (r2 != r2End)) { @@ -1576,13 +1639,11 @@ { /* Left part of subtrahend covers part of minuend: add uncovered * part of minuend to region and skip to next subtrahend. */ - MEMCHECK(pReg, pNextRect, pReg->Buffer); - pNextRect->left = left; - pNextRect->top = top; - pNextRect->right = r2->left; - pNextRect->bottom = bottom; - pReg->rdh.nCount += 1; - pNextRect++; + if (!REGION_bAddRect(pReg, left, top, r2->left, bottom)) + { + return; + } + left = r2->right; if (left >= r1->right) { @@ -1602,13 +1663,10 @@ /* Minuend used up: add any remaining piece before advancing. */ if (r1->right > left) { - MEMCHECK(pReg, pNextRect, pReg->Buffer); - pNextRect->left = left; - pNextRect->top = top; - pNextRect->right = r1->right; - pNextRect->bottom = bottom; - pReg->rdh.nCount += 1; - pNextRect++; + if (!REGION_bAddRect(pReg, left, top, r1->right, bottom)) + { + return; + } } r1++; @@ -1617,21 +1675,25 @@ } } - /* Add remaining minuend rectangles to region. */ - while (r1 != r1End) - { - MEMCHECK(pReg, pNextRect, pReg->Buffer); - pNextRect->left = left; - pNextRect->top = top; - pNextRect->right = r1->right; - pNextRect->bottom = bottom; - pReg->rdh.nCount += 1; - pNextRect++; - r1++; - if (r1 != r1End) - { - left = r1->left; - } + /* Make sure the buffer is large enough for all remaining operations */ + if (r1 != r1End) + { + if (!REGION_bEnsureBufferSize(pReg, pReg->rdh.nCount + (r1End - r1))) + { + return; + } + + /* Add remaining minuend rectangles to region. */ + do + { + REGION_vAddRect(pReg, left, top, r1->right, bottom); + r1++; + if (r1 != r1End) + { + left = r1->left; + } + } + while (r1 != r1End); } return;

1 0

[tkreuzer] 65734: [WIN32K] Improve REGION_bMakeFrameRegion and REGION_bMakeSimpleFrameRgn
by tkreuzer＠svn.reactos.org 18 Dec '14

18 Dec '14

Author: tkreuzer Date: Thu Dec 18 08:12:51 2014 New Revision: 65734 URL: http://svn.reactos.org/svn/reactos?rev=65734&view=rev Log: [WIN32K] Improve REGION_bMakeFrameRegion and REGION_bMakeSimpleFrameRgn Modified: trunk/reactos/win32ss/gdi/ntgdi/region.c Modified: trunk/reactos/win32ss/gdi/ntgdi/region.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/gdi/ntgdi/region.c… ============================================================================== --- trunk/reactos/win32ss/gdi/ntgdi/region.c [iso-8859-1] (original) +++ trunk/reactos/win32ss/gdi/ntgdi/region.c [iso-8859-1] Thu Dec 18 08:12:51 2014 @@ -1759,80 +1759,92 @@ return REGION_Complexity(prgnDest); } +static BOOL -FASTCALL -REGION_CreateSimpleFrameRgn( - PREGION rgn, - INT x, - INT y) -{ - RECTL rc[4]; - PRECTL prc; - - if ((x != 0) || (y != 0)) - { - prc = rc; - - if ((rgn->rdh.rcBound.bottom - rgn->rdh.rcBound.top > y * 2) && - (rgn->rdh.rcBound.right - rgn->rdh.rcBound.left > x * 2)) - { - if (y != 0) - { - /* Top rectangle */ - prc->left = rgn->rdh.rcBound.left; - prc->top = rgn->rdh.rcBound.top; - prc->right = rgn->rdh.rcBound.right; - prc->bottom = prc->top + y; - prc++; - } - - if (x != 0) - { - /* Left rectangle */ - prc->left = rgn->rdh.rcBound.left; - prc->top = rgn->rdh.rcBound.top + y; - prc->right = prc->left + x; - prc->bottom = rgn->rdh.rcBound.bottom - y; - prc++; - - /* Right rectangle */ - prc->left = rgn->rdh.rcBound.right - x; - prc->top = rgn->rdh.rcBound.top + y; - prc->right = rgn->rdh.rcBound.right; - prc->bottom = rgn->rdh.rcBound.bottom - y; - prc++; - } - - if (y != 0) - { - /* Bottom rectangle */ - prc->left = rgn->rdh.rcBound.left; - prc->top = rgn->rdh.rcBound.bottom - y; - prc->right = rgn->rdh.rcBound.right; - prc->bottom = rgn->rdh.rcBound.bottom; - prc++; - } - } - - if (prc != rc) - { - /* The frame results in a complex region. rcBounds remains - the same, though. */ - rgn->rdh.nCount = (DWORD)(prc - rc); - ASSERT(rgn->rdh.nCount > 1); - rgn->rdh.nRgnSize = rgn->rdh.nCount * sizeof(RECT); - rgn->Buffer = ExAllocatePoolWithTag(PagedPool, - rgn->rdh.nRgnSize, - TAG_REGION); - if (rgn->Buffer == NULL) - { - rgn->rdh.nRgnSize = 0; - return FALSE; - } - - _PRAGMA_WARNING_SUPPRESS(__WARNING_MAYBE_UNINIT_VAR) // rc is initialized - COPY_RECTS(rgn->Buffer, rc, rgn->rdh.nCount); - } +REGION_bMakeSimpleFrameRgn( + _Inout_ PREGION prgn, + _In_ PRECTL prclSrc, + _In_ INT cx, + _In_ INT cy) +{ + RECTL arcl[4]; + UINT i; + + NT_ASSERT((cx >= 0) && (cy >= 0)); + NT_ASSERT((prclSrc->bottom > prclSrc->top) && + (prclSrc->right > prclSrc->left)); + + /* Start with an empty region */ + EMPTY_REGION(prgn); + + /* Check for the case where the frame covers the whole rect */ + if (((prclSrc->bottom - prclSrc->top) <= cy * 2) || + ((prclSrc->right - prclSrc->left) <= cx * 2)) + { + prgn->rdh.rcBound = *prclSrc; + prgn->Buffer[0] = *prclSrc; + prgn->rdh.nCount = 1; + return TRUE; + } + + i = 0; + + if (cy != 0) + { + /* Top rectangle */ + arcl[i].left = prclSrc->left; + arcl[i].top = prclSrc->top; + arcl[i].right = prclSrc->right; + arcl[i].bottom = prclSrc->top + cy; + i++; + } + + if (cx != 0) + { + /* Left rectangle */ + arcl[i].left = prclSrc->left; + arcl[i].top = prclSrc->top + cy; + arcl[i].right = prclSrc->left + cx; + arcl[i].bottom = prclSrc->bottom - cy; + i++; + + /* Right rectangle */ + arcl[i].left = prclSrc->right - cx; + arcl[i].top = prclSrc->top + cy; + arcl[i].right = prclSrc->right; + arcl[i].bottom = prclSrc->bottom - cy; + i++; + } + + if (cy != 0) + { + /* Bottom rectangle */ + arcl[i].left = prclSrc->left; + arcl[i].top = prclSrc->bottom - cy; + arcl[i].right = prclSrc->right; + arcl[i].bottom = prclSrc->bottom; + i++; + } + + if (i != 0) + { + /* The frame results in a complex region. rcBounds remains + the same, though. */ + prgn->rdh.nCount = i; + NT_ASSERT(prgn->rdh.nCount > 1); + prgn->rdh.nRgnSize = prgn->rdh.nCount * sizeof(RECT); + NT_ASSERT(prgn->Buffer == &prgn->rdh.rcBound); + prgn->Buffer = ExAllocatePoolWithTag(PagedPool, + prgn->rdh.nRgnSize, + TAG_REGION); + if (prgn->Buffer == NULL) + { + prgn->rdh.nRgnSize = 0; + return FALSE; + } + + _PRAGMA_WARNING_SUPPRESS(__WARNING_MAYBE_UNINIT_VAR) // arcl is initialized + COPY_RECTS(prgn->Buffer, arcl, prgn->rdh.nCount); } return TRUE; @@ -1842,60 +1854,83 @@ BOOL REGION_bMakeFrameRegion( _Inout_ PREGION prgnDest, - _In_ PREGION prgnSrc, + _Inout_ PREGION prgnSrc, _In_ INT cx, _In_ INT cy) { - + /* Handle negative cx / cy */ + cx = abs(cx); + cy = abs(cy); + + /* Check border size (the cast is necessary to catch cx/cy == INT_MIN!) */ + if (((UINT)cx > MAX_COORD) || ((UINT)cy > MAX_COORD)) + { + return FALSE; + } + + /* Fail on empty source region */ if (!REGION_NOT_EMPTY(prgnSrc)) { return FALSE; } + /* Handle trivial case */ + if ((cx == 0) && (cy == 0)) + { + EMPTY_REGION(prgnDest); + return TRUE; + } + + /* Handle simple source region */ + if (REGION_Complexity(prgnSrc) == SIMPLEREGION) + { + return REGION_bMakeSimpleFrameRgn(prgnDest, &prgnSrc->rdh.rcBound, cx, cy); + } + + /* Check if we can move the region to create the frame region */ + if ((prgnSrc->rdh.rcBound.left < (MIN_COORD + cx)) || + (prgnSrc->rdh.rcBound.top < (MIN_COORD + cy)) || + (prgnSrc->rdh.rcBound.right > (MAX_COORD - cx)) || + (prgnSrc->rdh.rcBound.bottom > (MAX_COORD - cy))) + { + return FALSE; + } + + /* Copy the source region */ if (!REGION_CopyRegion(prgnDest, prgnSrc)) { return FALSE; } - if (REGION_Complexity(prgnSrc) == SIMPLEREGION) - { - if (!REGION_CreateSimpleFrameRgn(prgnDest, cx, cy)) - { - return FALSE; - } - } - else - { - /* Move the source region to the bottom-right */ - REGION_bOffsetRgn(prgnSrc, cx, cy); - - /* Intersect with the source region (this crops the top-left frame) */ - REGION_IntersectRegion(prgnDest, prgnDest, prgnSrc); - - /* Move the source region to the bottom-left */ - REGION_bOffsetRgn(prgnSrc, -2 * cx, 0); - - /* Intersect with the source region (this crops the top-right frame) */ - REGION_IntersectRegion(prgnDest, prgnDest, prgnSrc); - - /* Move the source region to the top-left */ - REGION_bOffsetRgn(prgnSrc, 0, -2 * cy); - - /* Intersect with the source region (this crops the bottom-right frame) */ - REGION_IntersectRegion(prgnDest, prgnDest, prgnSrc); - - /* Move the source region to the top-right */ - REGION_bOffsetRgn(prgnSrc, 2 * cx, 0); - - /* Intersect with the source region (this crops the bottom-left frame) */ - REGION_IntersectRegion(prgnDest, prgnDest, prgnSrc); - - /* Move the source region back to the original position */ - REGION_bOffsetRgn(prgnSrc, -cx, cy); - - /* Finally subtract the cropped region from the source */ - REGION_SubtractRegion(prgnDest, prgnSrc, prgnDest); - } + /* Move the source region to the bottom-right */ + NT_VERIFY(REGION_bOffsetRgn(prgnSrc, cx, cy)); + + /* Intersect with the source region (this crops the top-left frame) */ + REGION_IntersectRegion(prgnDest, prgnDest, prgnSrc); + + /* Move the source region to the bottom-left */ + NT_VERIFY(REGION_bOffsetRgn(prgnSrc, -2 * cx, 0)); + + /* Intersect with the source region (this crops the top-right frame) */ + REGION_IntersectRegion(prgnDest, prgnDest, prgnSrc); + + /* Move the source region to the top-left */ + NT_VERIFY(REGION_bOffsetRgn(prgnSrc, 0, -2 * cy)); + + /* Intersect with the source region (this crops the bottom-right frame) */ + REGION_IntersectRegion(prgnDest, prgnDest, prgnSrc); + + /* Move the source region to the top-right */ + NT_VERIFY(REGION_bOffsetRgn(prgnSrc, 2 * cx, 0)); + + /* Intersect with the source region (this crops the bottom-left frame) */ + REGION_IntersectRegion(prgnDest, prgnDest, prgnSrc); + + /* Move the source region back to the original position */ + NT_VERIFY(REGION_bOffsetRgn(prgnSrc, -cx, cy)); + + /* Finally subtract the cropped region from the source */ + REGION_SubtractRegion(prgnDest, prgnSrc, prgnDest); return TRUE; }

1 0

[tkreuzer] 65733: [WIN32K] - Make REGION_iOffsetRgn check the region for coordinate space overflow and fail, if the region cannot be moved - Rename REGION_iOffsetRgn to REGION_bOffsetRgn and make i...
by tkreuzer＠svn.reactos.org 18 Dec '14

18 Dec '14

Author: tkreuzer Date: Thu Dec 18 08:12:41 2014 New Revision: 65733 URL: http://svn.reactos.org/svn/reactos?rev=65733&view=rev Log: [WIN32K] - Make REGION_iOffsetRgn check the region for coordinate space overflow and fail, if the region cannot be moved - Rename REGION_iOffsetRgn to REGION_bOffsetRgn and make it return BOOL instead of the complexity, since the majority of callers are not interested in the complexity. It's also more obvious that we need to check for an error. Modified: trunk/reactos/win32ss/gdi/ntgdi/bitblt.c trunk/reactos/win32ss/gdi/ntgdi/cliprgn.c trunk/reactos/win32ss/gdi/ntgdi/coord.h trunk/reactos/win32ss/gdi/ntgdi/dcobjs.c trunk/reactos/win32ss/gdi/ntgdi/region.c trunk/reactos/win32ss/gdi/ntgdi/region.h trunk/reactos/win32ss/user/ntuser/painting.c trunk/reactos/win32ss/user/ntuser/vis.c trunk/reactos/win32ss/user/ntuser/windc.c trunk/reactos/win32ss/user/ntuser/winpos.c Modified: trunk/reactos/win32ss/gdi/ntgdi/bitblt.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/gdi/ntgdi/bitblt.c… ============================================================================== --- trunk/reactos/win32ss/gdi/ntgdi/bitblt.c [iso-8859-1] (original) +++ trunk/reactos/win32ss/gdi/ntgdi/bitblt.c [iso-8859-1] Thu Dec 18 08:12:41 2014 @@ -1053,7 +1053,7 @@ /* Transform region into device coordinates */ if (!REGION_LPTODP(pdc, prgnClip, prgn) || - REGION_iOffsetRgn(prgnClip, pdc->ptlDCOrig.x, pdc->ptlDCOrig.y) == ERROR) + !REGION_bOffsetRgn(prgnClip, pdc->ptlDCOrig.x, pdc->ptlDCOrig.y)) { REGION_Delete(prgnClip); return FALSE; Modified: trunk/reactos/win32ss/gdi/ntgdi/cliprgn.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/gdi/ntgdi/cliprgn.… ============================================================================== --- trunk/reactos/win32ss/gdi/ntgdi/cliprgn.c [iso-8859-1] (original) +++ trunk/reactos/win32ss/gdi/ntgdi/cliprgn.c [iso-8859-1] Thu Dec 18 08:12:41 2014 @@ -57,7 +57,7 @@ ASSERT(prgn != NULL); IntGdiCombineRgn(dc->prgnVis, prgn, NULL, RGN_COPY); - REGION_iOffsetRgn(dc->prgnVis, -dc->ptlDCOrig.x, -dc->ptlDCOrig.y); + REGION_bOffsetRgn(dc->prgnVis, -dc->ptlDCOrig.x, -dc->ptlDCOrig.y); DC_UnlockDc(dc); } @@ -365,9 +365,17 @@ if(dc->dclevel.prgnClip != NULL) { - Result = REGION_iOffsetRgn(dc->dclevel.prgnClip, - XOffset, - YOffset); + if (!REGION_bOffsetRgn(dc->dclevel.prgnClip, + XOffset, + YOffset)) + { + Result = ERROR; + } + else + { + Result = REGION_Complexity(dc->dclevel.prgnClip); + } + dc->fs |= DC_FLAG_DIRTY_RAO; } else @@ -572,7 +580,7 @@ } - REGION_iOffsetRgn(pDC->prgnRao, pDC->ptlDCOrig.x, pDC->ptlDCOrig.y); + REGION_bOffsetRgn(pDC->prgnRao, pDC->ptlDCOrig.x, pDC->ptlDCOrig.y); RtlCopyMemory(&pDC->erclClip, &pDC->prgnRao->rdh.rcBound, @@ -590,7 +598,7 @@ pDC->prgnRao->Buffer, &pDC->erclClip); - REGION_iOffsetRgn(pDC->prgnRao, -pDC->ptlDCOrig.x, -pDC->ptlDCOrig.y); + REGION_bOffsetRgn(pDC->prgnRao, -pDC->ptlDCOrig.x, -pDC->ptlDCOrig.y); } /* EOF */ Modified: trunk/reactos/win32ss/gdi/ntgdi/coord.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/gdi/ntgdi/coord.h?… ============================================================================== --- trunk/reactos/win32ss/gdi/ntgdi/coord.h [iso-8859-1] (original) +++ trunk/reactos/win32ss/gdi/ntgdi/coord.h [iso-8859-1] Thu Dec 18 08:12:41 2014 @@ -1,4 +1,8 @@ #pragma once + +/* Maximum extend of coordinate space */ +#define MIN_COORD (INT_MIN / 16) +#define MAX_COORD (INT_MAX / 16) #define IntLPtoDP(pdc, ppt, count) DC_vXformWorldToDevice(pdc, count, (PPOINTL)(ppt), (PPOINTL)(ppt)); #define CoordLPtoDP(pdc, ppt) DC_vXformWorldToDevice(pdc, 1, (PPOINTL)(ppt), (PPOINTL)(ppt)); Modified: trunk/reactos/win32ss/gdi/ntgdi/dcobjs.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/gdi/ntgdi/dcobjs.c… ============================================================================== --- trunk/reactos/win32ss/gdi/ntgdi/dcobjs.c [iso-8859-1] (original) +++ trunk/reactos/win32ss/gdi/ntgdi/dcobjs.c [iso-8859-1] Thu Dec 18 08:12:41 2014 @@ -779,7 +779,10 @@ { ret = IntGdiCombineRgn(prgnDest, prgnSrc, 0, RGN_COPY) == ERROR ? -1 : 1; if ((ret == 1) && (iCode == SYSRGN)) - REGION_iOffsetRgn(prgnDest, pdc->ptlDCOrig.x, pdc->ptlDCOrig.y); + { + /// \todo FIXME This is not really correct, since we already modified the region + ret = REGION_bOffsetRgn(prgnDest, pdc->ptlDCOrig.x, pdc->ptlDCOrig.y); + } REGION_UnlockRgn(prgnDest); } else Modified: trunk/reactos/win32ss/gdi/ntgdi/region.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/gdi/ntgdi/region.c… ============================================================================== --- trunk/reactos/win32ss/gdi/ntgdi/region.c [iso-8859-1] (original) +++ trunk/reactos/win32ss/gdi/ntgdi/region.c [iso-8859-1] Thu Dec 18 08:12:41 2014 @@ -514,7 +514,7 @@ PREGION dst, PREGION src) { - /* Only copy if source and dest are equal */ + /* Only copy if source and dest are not equal */ if (dst != src) { /* Check if we need to increase our buffer */ @@ -1867,31 +1867,31 @@ else { /* Move the source region to the bottom-right */ - REGION_iOffsetRgn(prgnSrc, cx, cy); + REGION_bOffsetRgn(prgnSrc, cx, cy); /* Intersect with the source region (this crops the top-left frame) */ REGION_IntersectRegion(prgnDest, prgnDest, prgnSrc); /* Move the source region to the bottom-left */ - REGION_iOffsetRgn(prgnSrc, -2 * cx, 0); + REGION_bOffsetRgn(prgnSrc, -2 * cx, 0); /* Intersect with the source region (this crops the top-right frame) */ REGION_IntersectRegion(prgnDest, prgnDest, prgnSrc); /* Move the source region to the top-left */ - REGION_iOffsetRgn(prgnSrc, 0, -2 * cy); + REGION_bOffsetRgn(prgnSrc, 0, -2 * cy); /* Intersect with the source region (this crops the bottom-right frame) */ REGION_IntersectRegion(prgnDest, prgnDest, prgnSrc); /* Move the source region to the top-right */ - REGION_iOffsetRgn(prgnSrc, 2 * cx, 0); + REGION_bOffsetRgn(prgnSrc, 2 * cx, 0); /* Intersect with the source region (this crops the bottom-left frame) */ REGION_IntersectRegion(prgnDest, prgnDest, prgnSrc); /* Move the source region back to the original position */ - REGION_iOffsetRgn(prgnSrc, -cx, cy); + REGION_bOffsetRgn(prgnSrc, -cx, cy); /* Finally subtract the cropped region from the source */ REGION_SubtractRegion(prgnDest, prgnSrc, prgnDest); @@ -1961,7 +1961,7 @@ if (pmx->flAccel & XFORM_UNITY) { /* Just offset the region */ - return REGION_iOffsetRgn(prgn, (pmx->fxDx + 8) / 16, (pmx->fxDy + 8) / 16) != ERROR; + return REGION_bOffsetRgn(prgn, (pmx->fxDx + 8) / 16, (pmx->fxDy + 8) / 16); } else { @@ -2584,40 +2584,93 @@ } } -INT -FASTCALL -REGION_iOffsetRgn( - PREGION rgn, - INT XOffset, - INT YOffset) -{ - if (XOffset || YOffset) - { - int nbox = rgn->rdh.nCount; - PRECTL pbox = rgn->Buffer; - - if (nbox && pbox) - { - while (nbox--) - { - pbox->left += XOffset; - pbox->right += XOffset; - pbox->top += YOffset; - pbox->bottom += YOffset; - pbox++; - } - - if (rgn->Buffer != &rgn->rdh.rcBound) - { - rgn->rdh.rcBound.left += XOffset; - rgn->rdh.rcBound.right += XOffset; - rgn->rdh.rcBound.top += YOffset; - rgn->rdh.rcBound.bottom += YOffset; - } - } - } - - return REGION_Complexity(rgn); +BOOL +FASTCALL +REGION_bOffsetRgn( + _Inout_ PREGION prgn, + _In_ INT cx, + _In_ INT cy) +{ + PRECTL prcl; + UINT i; + + NT_ASSERT(prgn != NULL); + + /* Check for trivial case */ + if ((cx == 0) && (cy == 0)) + { + return TRUE; + } + + /* Check for empty regions, we ignore the offset values here */ + if (prgn->rdh.nCount == 0) + { + return TRUE; + } + + /* Make sure the offset is within the legal range */ + if ((cx > MAX_COORD) || (cx < MIN_COORD) || + (cy > MAX_COORD) || (cy < MIN_COORD)) + { + return FALSE; + } + + /* Are we moving right? */ + if (cx > 0) + { + /* Check if we stay inside the bounds on the right side */ + if (prgn->rdh.rcBound.right > (MAX_COORD - cx)) + { + return FALSE; + } + } + else + { + /* Check if we stay inside the bounds on the left side */ + if (prgn->rdh.rcBound.left < (MIN_COORD - cx)) + { + return FALSE; + } + } + + /* Are we moving down? */ + if (cy > 0) + { + /* Check if we stay inside the bounds on the right side */ + if (prgn->rdh.rcBound.bottom > (MAX_COORD - cy)) + { + return FALSE; + } + } + else + { + /* Check if we stay inside the bounds on the left side */ + if (prgn->rdh.rcBound.top < (MIN_COORD - cy)) + { + return FALSE; + } + } + + /* Loop to move the rects */ + prcl = prgn->Buffer; + for (i = 0; i < prgn->rdh.nCount; i++) + { + prcl[i].left += cx; + prcl[i].right += cx; + prcl[i].top += cy; + prcl[i].bottom += cy; + } + + /* Finally update the bounds rect */ + if (prgn->Buffer != &prgn->rdh.rcBound) + { + prgn->rdh.rcBound.left += cx; + prgn->rdh.rcBound.right += cx; + prgn->rdh.rcBound.top += cy; + prgn->rdh.rcBound.bottom += cy; + } + + return TRUE; } /*********************************************************************** @@ -3786,7 +3839,14 @@ return ERROR; } - ret = REGION_iOffsetRgn(rgn, XOffset, YOffset); + if (!REGION_bOffsetRgn(rgn, XOffset, YOffset)) + { + ret = ERROR; + } + else + { + ret = REGION_Complexity(rgn); + } RGNOBJAPI_Unlock(rgn); return ret; Modified: trunk/reactos/win32ss/gdi/ntgdi/region.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/gdi/ntgdi/region.h… ============================================================================== --- trunk/reactos/win32ss/gdi/ntgdi/region.h [iso-8859-1] (original) +++ trunk/reactos/win32ss/gdi/ntgdi/region.h [iso-8859-1] Thu Dec 18 08:12:41 2014 @@ -62,7 +62,13 @@ _In_ ULONG cPolygons, _In_ INT iMode); -INT FASTCALL REGION_iOffsetRgn(PREGION,INT,INT); +BOOL +FASTCALL +REGION_bOffsetRgn( + _Inout_ PREGION prgn, + _In_ INT cx, + _In_ INT cy); + BOOL FASTCALL IntRectInRegion(HRGN,LPRECTL); INT FASTCALL IntGdiCombineRgn(PREGION, PREGION, PREGION, INT); Modified: trunk/reactos/win32ss/user/ntuser/painting.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/ntuser/painti… ============================================================================== --- trunk/reactos/win32ss/user/ntuser/painting.c [iso-8859-1] (original) +++ trunk/reactos/win32ss/user/ntuser/painting.c [iso-8859-1] Thu Dec 18 08:12:41 2014 @@ -460,11 +460,11 @@ PREGION RgnClip = RGNOBJAPI_Lock(Wnd->hrgnClip, NULL); if (RgnClip) { - REGION_iOffsetRgn(Rgn, + REGION_bOffsetRgn(Rgn, -Wnd->rcWindow.left, -Wnd->rcWindow.top); RgnType = IntGdiCombineRgn(Rgn, Rgn, RgnClip, RGN_AND); - REGION_iOffsetRgn(Rgn, + REGION_bOffsetRgn(Rgn, Wnd->rcWindow.left, Wnd->rcWindow.top); RGNOBJAPI_Unlock(RgnClip); @@ -682,7 +682,7 @@ } else { - REGION_iOffsetRgn(TmpRgn, Window->rcClient.left, Window->rcClient.top); + REGION_bOffsetRgn(TmpRgn, Window->rcClient.left, Window->rcClient.top); } } else if (UpdateRect != NULL) @@ -690,7 +690,7 @@ if (!RECTL_bIsEmptyRect(UpdateRect)) { TmpRgn = IntSysCreateRectpRgnIndirect(UpdateRect); - REGION_iOffsetRgn(TmpRgn, Window->rcClient.left, Window->rcClient.top); + REGION_bOffsetRgn(TmpRgn, Window->rcClient.left, Window->rcClient.top); } } else if ((Flags & (RDW_INVALIDATE | RDW_FRAME)) == (RDW_INVALIDATE | RDW_FRAME) || @@ -1229,7 +1229,7 @@ IntIntersectWithParents(Window, &Rect); REGION_SetRectRgn(Rgn, Rect.left, Rect.top, Rect.right, Rect.bottom); RegionType = IntGdiCombineRgn(Rgn, Rgn, UpdateRgn, RGN_AND); - REGION_iOffsetRgn(Rgn, -Window->rcClient.left, -Window->rcClient.top); + REGION_bOffsetRgn(Rgn, -Window->rcClient.left, -Window->rcClient.top); RGNOBJAPI_Unlock(UpdateRgn); if (bErase && RegionType != NULLREGION && RegionType != ERROR) @@ -1565,7 +1565,7 @@ /* Substract the part of the dest that was visible in source */ IntGdiCombineRgn(RgnTmp, RgnTmp, pDC->prgnVis, RGN_AND); - REGION_iOffsetRgn(RgnTmp, dx, dy); + REGION_bOffsetRgn(RgnTmp, dx, dy); Result = IntGdiCombineRgn(RgnOwn, RgnOwn, RgnTmp, RGN_DIFF); /* DO NOT Unlock DC while messing with prgnVis! */ @@ -1851,7 +1851,7 @@ RgnWinupd = IntSysCreateRectpRgn( 0, 0, 0, 0); IntGdiCombineRgn( RgnWinupd, RgnTemp, 0, RGN_COPY); } - REGION_iOffsetRgn(RgnTemp, dx, dy); + REGION_bOffsetRgn(RgnTemp, dx, dy); IntGdiCombineRgn(RgnTemp, RgnTemp, RgnClip, RGN_AND); if (hrgnUpdate) IntGdiCombineRgn( RgnWinupd, RgnWinupd, RgnTemp, RGN_OR ); Modified: trunk/reactos/win32ss/user/ntuser/vis.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/ntuser/vis.c?… ============================================================================== --- trunk/reactos/win32ss/user/ntuser/vis.c [iso-8859-1] (original) +++ trunk/reactos/win32ss/user/ntuser/vis.c [iso-8859-1] Thu Dec 18 08:12:41 2014 @@ -81,9 +81,9 @@ PREGION SiblingClipRgn = RGNOBJAPI_Lock(CurrentSibling->hrgnClip, NULL); if (SiblingClipRgn) { - REGION_iOffsetRgn(ClipRgn, -CurrentSibling->rcWindow.left, -CurrentSibling->rcWindow.top); + REGION_bOffsetRgn(ClipRgn, -CurrentSibling->rcWindow.left, -CurrentSibling->rcWindow.top); IntGdiCombineRgn(ClipRgn, ClipRgn, SiblingClipRgn, RGN_AND); - REGION_iOffsetRgn(ClipRgn, CurrentSibling->rcWindow.left, CurrentSibling->rcWindow.top); + REGION_bOffsetRgn(ClipRgn, CurrentSibling->rcWindow.left, CurrentSibling->rcWindow.top); RGNOBJAPI_Unlock(SiblingClipRgn); } } @@ -113,9 +113,9 @@ PREGION CurrentRgnClip = RGNOBJAPI_Lock(CurrentWindow->hrgnClip, NULL); if (CurrentRgnClip) { - REGION_iOffsetRgn(ClipRgn, -CurrentWindow->rcWindow.left, -CurrentWindow->rcWindow.top); + REGION_bOffsetRgn(ClipRgn, -CurrentWindow->rcWindow.left, -CurrentWindow->rcWindow.top); IntGdiCombineRgn(ClipRgn, ClipRgn, CurrentRgnClip, RGN_AND); - REGION_iOffsetRgn(ClipRgn, CurrentWindow->rcWindow.left, CurrentWindow->rcWindow.top); + REGION_bOffsetRgn(ClipRgn, CurrentWindow->rcWindow.left, CurrentWindow->rcWindow.top); RGNOBJAPI_Unlock(CurrentRgnClip); } } @@ -131,9 +131,9 @@ PREGION WndRgnClip = RGNOBJAPI_Lock(Wnd->hrgnClip, NULL); if (WndRgnClip) { - REGION_iOffsetRgn(VisRgn, -Wnd->rcWindow.left, -Wnd->rcWindow.top); + REGION_bOffsetRgn(VisRgn, -Wnd->rcWindow.left, -Wnd->rcWindow.top); IntGdiCombineRgn(VisRgn, VisRgn, WndRgnClip, RGN_AND); - REGION_iOffsetRgn(VisRgn, Wnd->rcWindow.left, Wnd->rcWindow.top); + REGION_bOffsetRgn(VisRgn, Wnd->rcWindow.left, Wnd->rcWindow.top); RGNOBJAPI_Unlock(WndRgnClip); } } @@ -160,7 +160,7 @@ return; IntGdiCombineRgn(TempRgn, NewlyExposed, NULL, RGN_COPY); - REGION_iOffsetRgn(TempRgn, + REGION_bOffsetRgn(TempRgn, Wnd->rcWindow.left - Parent->rcClient.left, Wnd->rcWindow.top - Parent->rcClient.top); Modified: trunk/reactos/win32ss/user/ntuser/windc.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/ntuser/windc.… ============================================================================== --- trunk/reactos/win32ss/user/ntuser/windc.c [iso-8859-1] (original) +++ trunk/reactos/win32ss/user/ntuser/windc.c [iso-8859-1] Thu Dec 18 08:12:41 2014 @@ -873,7 +873,7 @@ if (NULL != dc->dclevel.prgnClip) { - REGION_iOffsetRgn(dc->dclevel.prgnClip, DeltaX, DeltaY); + REGION_bOffsetRgn(dc->dclevel.prgnClip, DeltaX, DeltaY); dc->fs |= DC_FLAG_DIRTY_RAO; } if (NULL != pDCE->hrgnClip) Modified: trunk/reactos/win32ss/user/ntuser/winpos.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/ntuser/winpos… ============================================================================== --- trunk/reactos/win32ss/user/ntuser/winpos.c [iso-8859-1] (original) +++ trunk/reactos/win32ss/user/ntuser/winpos.c [iso-8859-1] Thu Dec 18 08:12:41 2014 @@ -1762,7 +1762,7 @@ } else if(VisBefore) { - REGION_iOffsetRgn(VisBefore, -Window->rcWindow.left, -Window->rcWindow.top); + REGION_bOffsetRgn(VisBefore, -Window->rcWindow.left, -Window->rcWindow.top); } /* Calculate the non client area for resizes, as this is used in the copy region */ @@ -1779,7 +1779,7 @@ } else if(VisBeforeJustClient) { - REGION_iOffsetRgn(VisBeforeJustClient, -Window->rcWindow.left, -Window->rcWindow.top); + REGION_bOffsetRgn(VisBeforeJustClient, -Window->rcWindow.left, -Window->rcWindow.top); } } } @@ -1864,7 +1864,7 @@ } else if(VisAfter) { - REGION_iOffsetRgn(VisAfter, -Window->rcWindow.left, -Window->rcWindow.top); + REGION_bOffsetRgn(VisAfter, -Window->rcWindow.left, -Window->rcWindow.top); } /* @@ -1905,9 +1905,9 @@ PREGION RgnUpdate = RGNOBJAPI_Lock(Window->hrgnUpdate, NULL); if (RgnUpdate) { - REGION_iOffsetRgn(CopyRgn, NewWindowRect.left, NewWindowRect.top); + REGION_bOffsetRgn(CopyRgn, NewWindowRect.left, NewWindowRect.top); IntGdiCombineRgn(CopyRgn, CopyRgn, RgnUpdate, RGN_DIFF); - REGION_iOffsetRgn(CopyRgn, -NewWindowRect.left, -NewWindowRect.top); + REGION_bOffsetRgn(CopyRgn, -NewWindowRect.left, -NewWindowRect.top); RGNOBJAPI_Unlock(RgnUpdate); } } @@ -1939,7 +1939,7 @@ * to create a copy of CopyRgn and pass that. We need CopyRgn later */ IntGdiCombineRgn(DcRgnObj, CopyRgn, NULL, RGN_COPY); - REGION_iOffsetRgn(DcRgnObj, NewWindowRect.left, NewWindowRect.top); + REGION_bOffsetRgn(DcRgnObj, NewWindowRect.left, NewWindowRect.top); RGNOBJAPI_Unlock(DcRgnObj); Dc = UserGetDCEx( Window, DcRgn, @@ -1992,7 +1992,7 @@ PWND Parent = Window->spwndParent; - REGION_iOffsetRgn( DirtyRgn, + REGION_bOffsetRgn( DirtyRgn, Window->rcWindow.left, Window->rcWindow.top); if ( (Window->style & WS_CHILD) && @@ -2027,7 +2027,7 @@ if (ExposedRgn) { RgnType = IntGdiCombineRgn(ExposedRgn, VisBefore, NULL, RGN_COPY); - REGION_iOffsetRgn(ExposedRgn, + REGION_bOffsetRgn(ExposedRgn, OldWindowRect.left - NewWindowRect.left, OldWindowRect.top - NewWindowRect.top);

1 0

[tkreuzer] 65732: [WIN32K] - Rename IntGdiOffsetRgn to REGION_iOffsetRgn
by tkreuzer＠svn.reactos.org 18 Dec '14

18 Dec '14

Author: tkreuzer Date: Thu Dec 18 08:12:34 2014 New Revision: 65732 URL: http://svn.reactos.org/svn/reactos?rev=65732&view=rev Log: [WIN32K] - Rename IntGdiOffsetRgn to REGION_iOffsetRgn Modified: trunk/reactos/win32ss/gdi/ntgdi/bitblt.c trunk/reactos/win32ss/gdi/ntgdi/cliprgn.c trunk/reactos/win32ss/gdi/ntgdi/dcobjs.c trunk/reactos/win32ss/gdi/ntgdi/region.c trunk/reactos/win32ss/gdi/ntgdi/region.h trunk/reactos/win32ss/user/ntuser/painting.c trunk/reactos/win32ss/user/ntuser/vis.c trunk/reactos/win32ss/user/ntuser/windc.c trunk/reactos/win32ss/user/ntuser/winpos.c Modified: trunk/reactos/win32ss/gdi/ntgdi/bitblt.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/gdi/ntgdi/bitblt.c… ============================================================================== --- trunk/reactos/win32ss/gdi/ntgdi/bitblt.c [iso-8859-1] (original) +++ trunk/reactos/win32ss/gdi/ntgdi/bitblt.c [iso-8859-1] Thu Dec 18 08:12:34 2014 @@ -1053,7 +1053,7 @@ /* Transform region into device coordinates */ if (!REGION_LPTODP(pdc, prgnClip, prgn) || - IntGdiOffsetRgn(prgnClip, pdc->ptlDCOrig.x, pdc->ptlDCOrig.y) == ERROR) + REGION_iOffsetRgn(prgnClip, pdc->ptlDCOrig.x, pdc->ptlDCOrig.y) == ERROR) { REGION_Delete(prgnClip); return FALSE; Modified: trunk/reactos/win32ss/gdi/ntgdi/cliprgn.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/gdi/ntgdi/cliprgn.… ============================================================================== --- trunk/reactos/win32ss/gdi/ntgdi/cliprgn.c [iso-8859-1] (original) +++ trunk/reactos/win32ss/gdi/ntgdi/cliprgn.c [iso-8859-1] Thu Dec 18 08:12:34 2014 @@ -57,7 +57,7 @@ ASSERT(prgn != NULL); IntGdiCombineRgn(dc->prgnVis, prgn, NULL, RGN_COPY); - IntGdiOffsetRgn(dc->prgnVis, -dc->ptlDCOrig.x, -dc->ptlDCOrig.y); + REGION_iOffsetRgn(dc->prgnVis, -dc->ptlDCOrig.x, -dc->ptlDCOrig.y); DC_UnlockDc(dc); } @@ -365,9 +365,9 @@ if(dc->dclevel.prgnClip != NULL) { - Result = IntGdiOffsetRgn(dc->dclevel.prgnClip, - XOffset, - YOffset); + Result = REGION_iOffsetRgn(dc->dclevel.prgnClip, + XOffset, + YOffset); dc->fs |= DC_FLAG_DIRTY_RAO; } else @@ -572,7 +572,7 @@ } - IntGdiOffsetRgn(pDC->prgnRao, pDC->ptlDCOrig.x, pDC->ptlDCOrig.y); + REGION_iOffsetRgn(pDC->prgnRao, pDC->ptlDCOrig.x, pDC->ptlDCOrig.y); RtlCopyMemory(&pDC->erclClip, &pDC->prgnRao->rdh.rcBound, @@ -590,7 +590,7 @@ pDC->prgnRao->Buffer, &pDC->erclClip); - IntGdiOffsetRgn(pDC->prgnRao, -pDC->ptlDCOrig.x, -pDC->ptlDCOrig.y); + REGION_iOffsetRgn(pDC->prgnRao, -pDC->ptlDCOrig.x, -pDC->ptlDCOrig.y); } /* EOF */ Modified: trunk/reactos/win32ss/gdi/ntgdi/dcobjs.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/gdi/ntgdi/dcobjs.c… ============================================================================== --- trunk/reactos/win32ss/gdi/ntgdi/dcobjs.c [iso-8859-1] (original) +++ trunk/reactos/win32ss/gdi/ntgdi/dcobjs.c [iso-8859-1] Thu Dec 18 08:12:34 2014 @@ -779,7 +779,7 @@ { ret = IntGdiCombineRgn(prgnDest, prgnSrc, 0, RGN_COPY) == ERROR ? -1 : 1; if ((ret == 1) && (iCode == SYSRGN)) - IntGdiOffsetRgn(prgnDest, pdc->ptlDCOrig.x, pdc->ptlDCOrig.y); + REGION_iOffsetRgn(prgnDest, pdc->ptlDCOrig.x, pdc->ptlDCOrig.y); REGION_UnlockRgn(prgnDest); } else Modified: trunk/reactos/win32ss/gdi/ntgdi/region.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/gdi/ntgdi/region.c… ============================================================================== --- trunk/reactos/win32ss/gdi/ntgdi/region.c [iso-8859-1] (original) +++ trunk/reactos/win32ss/gdi/ntgdi/region.c [iso-8859-1] Thu Dec 18 08:12:34 2014 @@ -1867,31 +1867,31 @@ else { /* Move the source region to the bottom-right */ - IntGdiOffsetRgn(prgnSrc, cx, cy); + REGION_iOffsetRgn(prgnSrc, cx, cy); /* Intersect with the source region (this crops the top-left frame) */ REGION_IntersectRegion(prgnDest, prgnDest, prgnSrc); /* Move the source region to the bottom-left */ - IntGdiOffsetRgn(prgnSrc, -2 * cx, 0); + REGION_iOffsetRgn(prgnSrc, -2 * cx, 0); /* Intersect with the source region (this crops the top-right frame) */ REGION_IntersectRegion(prgnDest, prgnDest, prgnSrc); /* Move the source region to the top-left */ - IntGdiOffsetRgn(prgnSrc, 0, -2 * cy); + REGION_iOffsetRgn(prgnSrc, 0, -2 * cy); /* Intersect with the source region (this crops the bottom-right frame) */ REGION_IntersectRegion(prgnDest, prgnDest, prgnSrc); /* Move the source region to the top-right */ - IntGdiOffsetRgn(prgnSrc, 2 * cx, 0); + REGION_iOffsetRgn(prgnSrc, 2 * cx, 0); /* Intersect with the source region (this crops the bottom-left frame) */ REGION_IntersectRegion(prgnDest, prgnDest, prgnSrc); /* Move the source region back to the original position */ - IntGdiOffsetRgn(prgnSrc, -cx, cy); + REGION_iOffsetRgn(prgnSrc, -cx, cy); /* Finally subtract the cropped region from the source */ REGION_SubtractRegion(prgnDest, prgnSrc, prgnDest); @@ -1961,7 +1961,7 @@ if (pmx->flAccel & XFORM_UNITY) { /* Just offset the region */ - return IntGdiOffsetRgn(prgn, (pmx->fxDx + 8) / 16, (pmx->fxDy + 8) / 16) != ERROR; + return REGION_iOffsetRgn(prgn, (pmx->fxDx + 8) / 16, (pmx->fxDy + 8) / 16) != ERROR; } else { @@ -2586,7 +2586,7 @@ INT FASTCALL -IntGdiOffsetRgn( +REGION_iOffsetRgn( PREGION rgn, INT XOffset, INT YOffset) @@ -3786,7 +3786,7 @@ return ERROR; } - ret = IntGdiOffsetRgn(rgn, XOffset, YOffset); + ret = REGION_iOffsetRgn(rgn, XOffset, YOffset); RGNOBJAPI_Unlock(rgn); return ret; Modified: trunk/reactos/win32ss/gdi/ntgdi/region.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/gdi/ntgdi/region.h… ============================================================================== --- trunk/reactos/win32ss/gdi/ntgdi/region.h [iso-8859-1] (original) +++ trunk/reactos/win32ss/gdi/ntgdi/region.h [iso-8859-1] Thu Dec 18 08:12:34 2014 @@ -62,7 +62,7 @@ _In_ ULONG cPolygons, _In_ INT iMode); -INT FASTCALL IntGdiOffsetRgn(PREGION,INT,INT); +INT FASTCALL REGION_iOffsetRgn(PREGION,INT,INT); BOOL FASTCALL IntRectInRegion(HRGN,LPRECTL); INT FASTCALL IntGdiCombineRgn(PREGION, PREGION, PREGION, INT); Modified: trunk/reactos/win32ss/user/ntuser/painting.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/ntuser/painti… ============================================================================== --- trunk/reactos/win32ss/user/ntuser/painting.c [iso-8859-1] (original) +++ trunk/reactos/win32ss/user/ntuser/painting.c [iso-8859-1] Thu Dec 18 08:12:34 2014 @@ -460,13 +460,13 @@ PREGION RgnClip = RGNOBJAPI_Lock(Wnd->hrgnClip, NULL); if (RgnClip) { - IntGdiOffsetRgn( Rgn, - -Wnd->rcWindow.left, - -Wnd->rcWindow.top); + REGION_iOffsetRgn(Rgn, + -Wnd->rcWindow.left, + -Wnd->rcWindow.top); RgnType = IntGdiCombineRgn(Rgn, Rgn, RgnClip, RGN_AND); - IntGdiOffsetRgn( Rgn, - Wnd->rcWindow.left, - Wnd->rcWindow.top); + REGION_iOffsetRgn(Rgn, + Wnd->rcWindow.left, + Wnd->rcWindow.top); RGNOBJAPI_Unlock(RgnClip); } } @@ -682,7 +682,7 @@ } else { - IntGdiOffsetRgn(TmpRgn, Window->rcClient.left, Window->rcClient.top); + REGION_iOffsetRgn(TmpRgn, Window->rcClient.left, Window->rcClient.top); } } else if (UpdateRect != NULL) @@ -690,7 +690,7 @@ if (!RECTL_bIsEmptyRect(UpdateRect)) { TmpRgn = IntSysCreateRectpRgnIndirect(UpdateRect); - IntGdiOffsetRgn(TmpRgn, Window->rcClient.left, Window->rcClient.top); + REGION_iOffsetRgn(TmpRgn, Window->rcClient.left, Window->rcClient.top); } } else if ((Flags & (RDW_INVALIDATE | RDW_FRAME)) == (RDW_INVALIDATE | RDW_FRAME) || @@ -1229,7 +1229,7 @@ IntIntersectWithParents(Window, &Rect); REGION_SetRectRgn(Rgn, Rect.left, Rect.top, Rect.right, Rect.bottom); RegionType = IntGdiCombineRgn(Rgn, Rgn, UpdateRgn, RGN_AND); - IntGdiOffsetRgn(Rgn, -Window->rcClient.left, -Window->rcClient.top); + REGION_iOffsetRgn(Rgn, -Window->rcClient.left, -Window->rcClient.top); RGNOBJAPI_Unlock(UpdateRgn); if (bErase && RegionType != NULLREGION && RegionType != ERROR) @@ -1565,7 +1565,7 @@ /* Substract the part of the dest that was visible in source */ IntGdiCombineRgn(RgnTmp, RgnTmp, pDC->prgnVis, RGN_AND); - IntGdiOffsetRgn(RgnTmp, dx, dy); + REGION_iOffsetRgn(RgnTmp, dx, dy); Result = IntGdiCombineRgn(RgnOwn, RgnOwn, RgnTmp, RGN_DIFF); /* DO NOT Unlock DC while messing with prgnVis! */ @@ -1851,7 +1851,7 @@ RgnWinupd = IntSysCreateRectpRgn( 0, 0, 0, 0); IntGdiCombineRgn( RgnWinupd, RgnTemp, 0, RGN_COPY); } - IntGdiOffsetRgn(RgnTemp, dx, dy); + REGION_iOffsetRgn(RgnTemp, dx, dy); IntGdiCombineRgn(RgnTemp, RgnTemp, RgnClip, RGN_AND); if (hrgnUpdate) IntGdiCombineRgn( RgnWinupd, RgnWinupd, RgnTemp, RGN_OR ); Modified: trunk/reactos/win32ss/user/ntuser/vis.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/ntuser/vis.c?… ============================================================================== --- trunk/reactos/win32ss/user/ntuser/vis.c [iso-8859-1] (original) +++ trunk/reactos/win32ss/user/ntuser/vis.c [iso-8859-1] Thu Dec 18 08:12:34 2014 @@ -81,9 +81,9 @@ PREGION SiblingClipRgn = RGNOBJAPI_Lock(CurrentSibling->hrgnClip, NULL); if (SiblingClipRgn) { - IntGdiOffsetRgn(ClipRgn, -CurrentSibling->rcWindow.left, -CurrentSibling->rcWindow.top); + REGION_iOffsetRgn(ClipRgn, -CurrentSibling->rcWindow.left, -CurrentSibling->rcWindow.top); IntGdiCombineRgn(ClipRgn, ClipRgn, SiblingClipRgn, RGN_AND); - IntGdiOffsetRgn(ClipRgn, CurrentSibling->rcWindow.left, CurrentSibling->rcWindow.top); + REGION_iOffsetRgn(ClipRgn, CurrentSibling->rcWindow.left, CurrentSibling->rcWindow.top); RGNOBJAPI_Unlock(SiblingClipRgn); } } @@ -113,9 +113,9 @@ PREGION CurrentRgnClip = RGNOBJAPI_Lock(CurrentWindow->hrgnClip, NULL); if (CurrentRgnClip) { - IntGdiOffsetRgn(ClipRgn, -CurrentWindow->rcWindow.left, -CurrentWindow->rcWindow.top); + REGION_iOffsetRgn(ClipRgn, -CurrentWindow->rcWindow.left, -CurrentWindow->rcWindow.top); IntGdiCombineRgn(ClipRgn, ClipRgn, CurrentRgnClip, RGN_AND); - IntGdiOffsetRgn(ClipRgn, CurrentWindow->rcWindow.left, CurrentWindow->rcWindow.top); + REGION_iOffsetRgn(ClipRgn, CurrentWindow->rcWindow.left, CurrentWindow->rcWindow.top); RGNOBJAPI_Unlock(CurrentRgnClip); } } @@ -131,9 +131,9 @@ PREGION WndRgnClip = RGNOBJAPI_Lock(Wnd->hrgnClip, NULL); if (WndRgnClip) { - IntGdiOffsetRgn(VisRgn, -Wnd->rcWindow.left, -Wnd->rcWindow.top); + REGION_iOffsetRgn(VisRgn, -Wnd->rcWindow.left, -Wnd->rcWindow.top); IntGdiCombineRgn(VisRgn, VisRgn, WndRgnClip, RGN_AND); - IntGdiOffsetRgn(VisRgn, Wnd->rcWindow.left, Wnd->rcWindow.top); + REGION_iOffsetRgn(VisRgn, Wnd->rcWindow.left, Wnd->rcWindow.top); RGNOBJAPI_Unlock(WndRgnClip); } } @@ -160,9 +160,9 @@ return; IntGdiCombineRgn(TempRgn, NewlyExposed, NULL, RGN_COPY); - IntGdiOffsetRgn(TempRgn, - Wnd->rcWindow.left - Parent->rcClient.left, - Wnd->rcWindow.top - Parent->rcClient.top); + REGION_iOffsetRgn(TempRgn, + Wnd->rcWindow.left - Parent->rcClient.left, + Wnd->rcWindow.top - Parent->rcClient.top); UserRefObjectCo(Parent, &Ref); co_UserRedrawWindow(Parent, NULL, TempRgn, Modified: trunk/reactos/win32ss/user/ntuser/windc.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/ntuser/windc.… ============================================================================== --- trunk/reactos/win32ss/user/ntuser/windc.c [iso-8859-1] (original) +++ trunk/reactos/win32ss/user/ntuser/windc.c [iso-8859-1] Thu Dec 18 08:12:34 2014 @@ -873,7 +873,7 @@ if (NULL != dc->dclevel.prgnClip) { - IntGdiOffsetRgn(dc->dclevel.prgnClip, DeltaX, DeltaY); + REGION_iOffsetRgn(dc->dclevel.prgnClip, DeltaX, DeltaY); dc->fs |= DC_FLAG_DIRTY_RAO; } if (NULL != pDCE->hrgnClip) Modified: trunk/reactos/win32ss/user/ntuser/winpos.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/ntuser/winpos… ============================================================================== --- trunk/reactos/win32ss/user/ntuser/winpos.c [iso-8859-1] (original) +++ trunk/reactos/win32ss/user/ntuser/winpos.c [iso-8859-1] Thu Dec 18 08:12:34 2014 @@ -1440,7 +1440,7 @@ TRACE("skip all the topmost windows\n"); /* skip all the topmost windows */ while (List[i] && - (ChildObject = ValidateHwndNoErr(List[i])) && + (ChildObject = ValidateHwndNoErr(List[i])) && (ChildObject->ExStyle & WS_EX_TOPMOST)) i++; } } @@ -1532,9 +1532,9 @@ POINT pt; /* Finally make sure that all coordinates are valid */ - if (WinPos->x < -32768) WinPos->x = -32768; + if (WinPos->x < -32768) WinPos->x = -32768; else if (WinPos->x > 32767) WinPos->x = 32767; - if (WinPos->y < -32768) WinPos->y = -32768; + if (WinPos->y < -32768) WinPos->y = -32768; else if (WinPos->y > 32767) WinPos->y = 32767; WinPos->cx = max(WinPos->cx, 0); @@ -1762,10 +1762,10 @@ } else if(VisBefore) { - IntGdiOffsetRgn(VisBefore, -Window->rcWindow.left, -Window->rcWindow.top); + REGION_iOffsetRgn(VisBefore, -Window->rcWindow.left, -Window->rcWindow.top); } - /* Calculate the non client area for resizes, as this is used in the copy region */ + /* Calculate the non client area for resizes, as this is used in the copy region */ if (!(WinPos.flags & SWP_NOSIZE)) { VisBeforeJustClient = VIS_ComputeVisibleRegion(Window, TRUE, FALSE, @@ -1779,7 +1779,7 @@ } else if(VisBeforeJustClient) { - IntGdiOffsetRgn(VisBeforeJustClient, -Window->rcWindow.left, -Window->rcWindow.top); + REGION_iOffsetRgn(VisBeforeJustClient, -Window->rcWindow.left, -Window->rcWindow.top); } } } @@ -1864,7 +1864,7 @@ } else if(VisAfter) { - IntGdiOffsetRgn(VisAfter, -Window->rcWindow.left, -Window->rcWindow.top); + REGION_iOffsetRgn(VisAfter, -Window->rcWindow.left, -Window->rcWindow.top); } /* @@ -1905,9 +1905,9 @@ PREGION RgnUpdate = RGNOBJAPI_Lock(Window->hrgnUpdate, NULL); if (RgnUpdate) { - IntGdiOffsetRgn(CopyRgn, NewWindowRect.left, NewWindowRect.top); + REGION_iOffsetRgn(CopyRgn, NewWindowRect.left, NewWindowRect.top); IntGdiCombineRgn(CopyRgn, CopyRgn, RgnUpdate, RGN_DIFF); - IntGdiOffsetRgn(CopyRgn, -NewWindowRect.left, -NewWindowRect.top); + REGION_iOffsetRgn(CopyRgn, -NewWindowRect.left, -NewWindowRect.top); RGNOBJAPI_Unlock(RgnUpdate); } } @@ -1939,7 +1939,7 @@ * to create a copy of CopyRgn and pass that. We need CopyRgn later */ IntGdiCombineRgn(DcRgnObj, CopyRgn, NULL, RGN_COPY); - IntGdiOffsetRgn(DcRgnObj, NewWindowRect.left, NewWindowRect.top); + REGION_iOffsetRgn(DcRgnObj, NewWindowRect.left, NewWindowRect.top); RGNOBJAPI_Unlock(DcRgnObj); Dc = UserGetDCEx( Window, DcRgn, @@ -1992,7 +1992,7 @@ PWND Parent = Window->spwndParent; - IntGdiOffsetRgn( DirtyRgn, + REGION_iOffsetRgn( DirtyRgn, Window->rcWindow.left, Window->rcWindow.top); if ( (Window->style & WS_CHILD) && @@ -2027,9 +2027,9 @@ if (ExposedRgn) { RgnType = IntGdiCombineRgn(ExposedRgn, VisBefore, NULL, RGN_COPY); - IntGdiOffsetRgn( ExposedRgn, - OldWindowRect.left - NewWindowRect.left, - OldWindowRect.top - NewWindowRect.top); + REGION_iOffsetRgn(ExposedRgn, + OldWindowRect.left - NewWindowRect.left, + OldWindowRect.top - NewWindowRect.top); if (VisAfter != NULL) RgnType = IntGdiCombineRgn(ExposedRgn, ExposedRgn, VisAfter, RGN_DIFF);

1 0

[tkreuzer] 65731: [WIN32K] Implement exclusive lock order checks for GDI objects in debug builds
by tkreuzer＠svn.reactos.org 18 Dec '14

18 Dec '14

Author: tkreuzer Date: Thu Dec 18 08:12:28 2014 New Revision: 65731 URL: http://svn.reactos.org/svn/reactos?rev=65731&view=rev Log: [WIN32K] Implement exclusive lock order checks for GDI objects in debug builds Modified: trunk/reactos/win32ss/gdi/ntgdi/gdiobj.c Modified: trunk/reactos/win32ss/gdi/ntgdi/gdiobj.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/gdi/ntgdi/gdiobj.c… ============================================================================== --- trunk/reactos/win32ss/gdi/ntgdi/gdiobj.c [iso-8859-1] (original) +++ trunk/reactos/win32ss/gdi/ntgdi/gdiobj.c [iso-8859-1] Thu Dec 18 08:12:28 2014 @@ -71,6 +71,22 @@ } #if DBG +VOID +ASSERT_LOCK_ORDER( + _In_ UCHAR objt) +{ + PTHREADINFO pti = PsGetCurrentThreadWin32Thread(); + ULONG i; + + if (pti) + { + /* Ensure correct locking order! */ + for (i = objt + 1; i < GDIObjTypeTotal; i++) + { + NT_ASSERT(pti->acExclusiveLockCount[i] == 0); + } + } +} #define ASSERT_SHARED_OBJECT_TYPE(objt) \ ASSERT((objt) == GDIObjType_SURF_TYPE || \ (objt) == GDIObjType_PAL_TYPE || \ @@ -83,6 +99,7 @@ #define ASSERT_TRYLOCK_OBJECT_TYPE(objt) \ ASSERT((objt) == GDIObjType_DRVOBJ_TYPE) #else +#define ASSERT_LOCK_ORDER(hobj) #define ASSERT_SHARED_OBJECT_TYPE(objt) #define ASSERT_EXCLUSIVE_OBJECT_TYPE(objt) #define ASSERT_TRYLOCK_OBJECT_TYPE(objt) @@ -669,6 +686,9 @@ return NULL; } + /* Make sure lock order is correct */ + ASSERT_LOCK_ORDER(objt); + /* Reference the handle entry */ pentry = ENTRY_ReferenceEntryByHandle(hobj, 0); if (!pentry) @@ -734,6 +754,9 @@ DPRINT("Wrong object type: hobj=0x%p, objt=0x%x\n", hobj, objt); return NULL; } + + /* Make sure lock order is correct */ + ASSERT_LOCK_ORDER(objt); /* Reference the handle entry */ pentry = ENTRY_ReferenceEntryByHandle(hobj, 0);

1 0

[tkreuzer] 65730: [WIN32K] - Rewrite NtGdiFillRgn and IntGdiPaintRgn We now properly support painting regions on DCs with arbitrary world transforms, with pattern brushes and we respect the foregro...
by tkreuzer＠svn.reactos.org 18 Dec '14

18 Dec '14

Author: tkreuzer Date: Thu Dec 18 08:12:23 2014 New Revision: 65730 URL: http://svn.reactos.org/svn/reactos?rev=65730&view=rev Log: [WIN32K] - Rewrite NtGdiFillRgn and IntGdiPaintRgn We now properly support painting regions on DCs with arbitrary world transforms, with pattern brushes and we respect the foreground ROP and mode of the DC. And we don't run into deadlocks due to having an exclusive region lock while trying to lock a DC. LOCKING MUST BE DONE IN PROPER ORDER! Modified: trunk/reactos/win32ss/gdi/ntgdi/bitblt.c Modified: trunk/reactos/win32ss/gdi/ntgdi/bitblt.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/gdi/ntgdi/bitblt.c… ============================================================================== --- trunk/reactos/win32ss/gdi/ntgdi/bitblt.c [iso-8859-1] (original) +++ trunk/reactos/win32ss/gdi/ntgdi/bitblt.c [iso-8859-1] Thu Dec 18 08:12:23 2014 @@ -1021,103 +1021,146 @@ if (IntGdiCombineRgn(prgnDest, prgnSrc, NULL, RGN_COPY) == ERROR) return FALSE; - return REGION_bXformRgn(prgnDest, &pdc->dclevel.mxWorldToDevice); + return REGION_bXformRgn(prgnDest, DC_pmxWorldToDevice(pdc)); +} + +BOOL +IntGdiFillRgn( + _In_ PDC pdc, + _In_ PREGION prgn, + _In_ BRUSHOBJ *pbo) +{ + PREGION prgnClip; + XCLIPOBJ xcoClip; + BOOL bRet; + PSURFACE psurf; + DWORD rop2Fg; + MIX mix; + + NT_ASSERT((pdc != NULL) && (prgn != NULL)); + + psurf = pdc->dclevel.pSurface; + if (psurf == NULL) + { + return TRUE; + } + + prgnClip = IntSysCreateRectpRgn(0, 0, 0, 0); + if (prgnClip == NULL) + { + return FALSE; + } + + /* Transform region into device coordinates */ + if (!REGION_LPTODP(pdc, prgnClip, prgn) || + IntGdiOffsetRgn(prgnClip, pdc->ptlDCOrig.x, pdc->ptlDCOrig.y) == ERROR) + { + REGION_Delete(prgnClip); + return FALSE; + } + + /* Intersect with the system or RAO region */ + if (pdc->prgnRao) + IntGdiCombineRgn(prgnClip, prgnClip, pdc->prgnRao, RGN_AND); + else + IntGdiCombineRgn(prgnClip, prgnClip, pdc->prgnVis, RGN_AND); + + IntEngInitClipObj(&xcoClip); + IntEngUpdateClipRegion(&xcoClip, + prgnClip->rdh.nCount, + prgnClip->Buffer, + &prgnClip->rdh.rcBound ); + + /* Get the FG rop and create a MIX based on the BK mode */ + rop2Fg = pdc->pdcattr->jROP2; + mix = rop2Fg | (pdc->pdcattr->jBkMode == OPAQUE ? rop2Fg : R2_NOP) << 8; + + /* Call the internal function */ + bRet = IntEngPaint(&psurf->SurfObj, + &xcoClip.ClipObj, + pbo, + &pdc->pdcattr->ptlBrushOrigin, + mix); + + REGION_Delete(prgnClip); + IntEngFreeClipResources(&xcoClip); + + // Fill the region + return bRet; } BOOL FASTCALL IntGdiPaintRgn( - PDC dc, - PREGION Rgn) -{ - PREGION VisRgn; - XCLIPOBJ ClipRegion; - BOOL bRet = FALSE; - POINTL BrushOrigin; - SURFACE *psurf; - PDC_ATTR pdcattr; - - if ((dc == NULL) || (Rgn == NULL)) - return FALSE; - - pdcattr = dc->pdcattr; - - ASSERT(!(pdcattr->ulDirty_ & (DIRTY_FILL | DC_BRUSH_DIRTY))); - - VisRgn = IntSysCreateRectpRgn(0, 0, 0, 0); - if (VisRgn == NULL) - { - return FALSE; - } - - // Transform region into device co-ords - if (!REGION_LPTODP(dc, VisRgn, Rgn) || - IntGdiOffsetRgn(VisRgn, dc->ptlDCOrig.x, dc->ptlDCOrig.y) == ERROR) - { - REGION_Delete(VisRgn); - return FALSE; - } - - if (dc->prgnRao) - IntGdiCombineRgn(VisRgn, VisRgn, dc->prgnRao, RGN_AND); - - IntEngInitClipObj(&ClipRegion); - IntEngUpdateClipRegion(&ClipRegion, - VisRgn->rdh.nCount, - VisRgn->Buffer, - &VisRgn->rdh.rcBound ); - - BrushOrigin.x = pdcattr->ptlBrushOrigin.x; - BrushOrigin.y = pdcattr->ptlBrushOrigin.y; - psurf = dc->dclevel.pSurface; - /* FIXME: Handle psurf == NULL !!!! */ - - bRet = IntEngPaint(&psurf->SurfObj, - &ClipRegion.ClipObj, - &dc->eboFill.BrushObject, - &BrushOrigin, - 0xFFFF); // FIXME: Don't know what to put here - - REGION_Delete(VisRgn); - IntEngFreeClipResources(&ClipRegion); - - // Fill the region - return bRet; + _In_ PDC pdc, + _In_ PREGION prgn) +{ + if (pdc->pdcattr->ulDirty_ & (DIRTY_FILL | DC_BRUSH_DIRTY)) + DC_vUpdateFillBrush(pdc); + + return IntGdiFillRgn(pdc, prgn, &pdc->eboFill.BrushObject); } BOOL APIENTRY NtGdiFillRgn( - HDC hDC, - HRGN hRgn, - HBRUSH hBrush) -{ - HBRUSH oldhBrush; - PREGION rgn; - PRECTL r; - - rgn = RGNOBJAPI_Lock(hRgn, NULL); - if (rgn == NULL) - { - return FALSE; - } - - oldhBrush = NtGdiSelectBrush(hDC, hBrush); - if (oldhBrush == NULL) - { - RGNOBJAPI_Unlock(rgn); - return FALSE; - } - - for (r = rgn->Buffer; r < rgn->Buffer + rgn->rdh.nCount; r++) - { - NtGdiPatBlt(hDC, r->left, r->top, r->right - r->left, r->bottom - r->top, PATCOPY); - } - - RGNOBJAPI_Unlock(rgn); - NtGdiSelectBrush(hDC, oldhBrush); - - return TRUE; + _In_ HDC hdc, + _In_ HRGN hrgn, + _In_ HBRUSH hbrush) +{ + PDC pdc; + PREGION prgn; + PBRUSH pbrFill; + EBRUSHOBJ eboFill; + BOOL bResult; + + /* Lock the DC */ + pdc = DC_LockDc(hdc); + if (pdc == NULL) + { + ERR("Failed to lock hdc %p\n", hdc); + return FALSE; + } + + /* Check if the DC has no surface (empty mem or info DC) */ + if (pdc->dclevel.pSurface == NULL) + { + DC_UnlockDc(pdc); + return TRUE; + } + + /* Lock the region */ + prgn = RGNOBJAPI_Lock(hrgn, NULL); + if (prgn == NULL) + { + ERR("Failed to lock hrgn %p\n", hrgn); + DC_UnlockDc(pdc); + return FALSE; + } + + /* Lock the brush */ + pbrFill = BRUSH_ShareLockBrush(hbrush); + if (pbrFill == NULL) + { + ERR("Failed to lock hbrush %p\n", hbrush); + RGNOBJAPI_Unlock(prgn); + DC_UnlockDc(pdc); + return FALSE; + } + + /* Initialize the brush object */ + /// \todo Check parameters + EBRUSHOBJ_vInit(&eboFill, pbrFill, pdc->dclevel.pSurface, 0x00FFFFFF, 0, NULL); + + /* Call the internal function */ + bResult = IntGdiFillRgn(pdc, prgn, &eboFill.BrushObject); + + /* Cleanup locks */ + BRUSH_ShareUnlockBrush(pbrFill); + RGNOBJAPI_Unlock(prgn); + DC_UnlockDc(pdc); + + return bResult; } BOOL

1 0

[tkreuzer] 65729: [WIN32K] Properly implement EngPaint, calling IntEngBitBlt, instead of doing a manual single color fill.
by tkreuzer＠svn.reactos.org 18 Dec '14

18 Dec '14

Author: tkreuzer Date: Thu Dec 18 08:12:19 2014 New Revision: 65729 URL: http://svn.reactos.org/svn/reactos?rev=65729&view=rev Log: [WIN32K] Properly implement EngPaint, calling IntEngBitBlt, instead of doing a manual single color fill. Modified: trunk/reactos/win32ss/gdi/eng/eng.h trunk/reactos/win32ss/gdi/eng/paint.c Modified: trunk/reactos/win32ss/gdi/eng/eng.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/gdi/eng/eng.h?rev=… ============================================================================== --- trunk/reactos/win32ss/gdi/eng/eng.h [iso-8859-1] (original) +++ trunk/reactos/win32ss/gdi/eng/eng.h [iso-8859-1] Thu Dec 18 08:12:19 2014 @@ -1,4 +1,10 @@ #pragma once + +extern const BYTE gajRop2ToRop3[16]; + +#define MIX_TO_ROP4(mix) \ + (((ULONG)gajRop2ToRop3[((mix) - 1) & 0xF]) | \ + ((ULONG)gajRop2ToRop3[(((mix) >> 8) - 1) & 0xF] << 8)) VOID NTAPI Modified: trunk/reactos/win32ss/gdi/eng/paint.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/gdi/eng/paint.c?re… ============================================================================== --- trunk/reactos/win32ss/gdi/eng/paint.c [iso-8859-1] (original) +++ trunk/reactos/win32ss/gdi/eng/paint.c [iso-8859-1] Thu Dec 18 08:12:19 2014 @@ -3,13 +3,34 @@ * PROJECT: ReactOS kernel * PURPOSE: GDI Driver Paint Functions * FILE: subsys/win32k/eng/paint.c - * PROGRAMER: Jason Filby + * PROGRAMERS: Timo Kreuzer (timo.kreuzer(a)reactos.org) + * Jason Filby */ #include <win32k.h> #define NDEBUG #include <debug.h> + +const BYTE gajRop2ToRop3[16] = +{ + 0x00, // 1: R2_BLACK 0 + 0x05, // 2: R2_NOTMERGEPEN DPon + 0x0A, // 3: R2_MASKNOTPEN DPna + 0x0F, // 4: R2_NOTCOPYPEN Pn + 0x50, // 5: R2_MASKPENNOT PDna + 0x55, // 6: R2_NOT Dn + 0x5A, // 7: R2_XORPEN DPx + 0x5F, // 8: R2_NOTMASKPEN DPan + 0xA0, // 9: R2_MASKPEN DPa + 0xA5, // 10: R2_NOTXORPEN PDxn + 0xAA, // 11: R2_NOP D + 0xAF, // 12: R2_MERGENOTPEN DPno + 0xF0, // 13: R2_COPYPEN P + 0xF5, // 14: R2_MERGEPENNOT PDno + 0xFA, // 15: R2_MERGEPEN DPo + 0xFF, // 16: R2_WHITE 1 +}; BOOL APIENTRY FillSolid(SURFOBJ *pso, PRECTL pRect, ULONG iColor) { @@ -28,87 +49,57 @@ return TRUE; } -BOOL APIENTRY -EngPaintRgn(SURFOBJ *pso, CLIPOBJ *ClipRegion, ULONG iColor, MIX Mix, - BRUSHOBJ *BrushObj, POINTL *BrushPoint) +BOOL +APIENTRY +EngPaint( + _In_ SURFOBJ *pso, + _In_ CLIPOBJ *pco, + _In_ BRUSHOBJ *pbo, + _In_ POINTL *pptlBrushOrg, + _In_ __in_data_source(USER_MODE) MIX mix) { - RECT_ENUM RectEnum; - BOOL EnumMore; - ULONG i; + ROP4 rop4; - ASSERT(pso); - ASSERT(ClipRegion); + /* Convert the MIX, consisting of 2 ROP2 codes into a ROP4 */ + rop4 = MIX_TO_ROP4(mix); - DPRINT("ClipRegion->iMode:%u, ClipRegion->iDComplexity: %u\n Color: %lu", ClipRegion->iMode, ClipRegion->iDComplexity, iColor); - switch(ClipRegion->iMode) { + /* Sanity checks */ + NT_ASSERT(!ROP4_USES_SOURCE(rop4)); + NT_ASSERT(!ROP4_USES_MASK(rop4)); - case TC_RECTANGLES: + /* Forward the call to Eng/DrvBitBlt */ + return IntEngBitBlt(pso, + NULL, + NULL, + pco, + NULL, + &pco->rclBounds, + NULL, + NULL, + pbo, + pptlBrushOrg, + rop4); +} - /* Rectangular clipping can be handled without enumeration. - Note that trivial clipping is not possible, since the clipping - region defines the area to fill */ +BOOL +APIENTRY +IntEngPaint( + _In_ SURFOBJ *pso, + _In_ CLIPOBJ *pco, + _In_ BRUSHOBJ *pbo, + _In_ POINTL *pptlBrushOrg, + _In_ __in_data_source(USER_MODE) MIX mix) +{ + SURFACE *psurf = CONTAINING_RECORD(pso, SURFACE, SurfObj); - if (ClipRegion->iDComplexity == DC_RECT) + /* Is the surface's Paint function hooked? */ + if ((pso->iType != STYPE_BITMAP) && (psurf->flags & HOOK_PAINT)) { - FillSolid(pso, &(ClipRegion->rclBounds), iColor); - } else { - - /* Enumerate all the rectangles and draw them */ - CLIPOBJ_cEnumStart(ClipRegion, FALSE, CT_RECTANGLES, CD_ANY, 0); - - do { - EnumMore = CLIPOBJ_bEnum(ClipRegion, sizeof(RectEnum), (PVOID) &RectEnum); - for (i = 0; i < RectEnum.c; i++) { - FillSolid(pso, RectEnum.arcl + i, iColor); - } - } while (EnumMore); + /* Call the driver's DrvPaint */ + return GDIDEVFUNCS(pso).Paint(pso, pco, pbo, pptlBrushOrg, mix); } - return(TRUE); - - default: - return(FALSE); - } + return EngPaint(pso, pco, pbo, pptlBrushOrg, mix); } -/* - * @unimplemented - */ -BOOL APIENTRY -EngPaint(IN SURFOBJ *pso, - IN CLIPOBJ *ClipRegion, - IN BRUSHOBJ *Brush, - IN POINTL *BrushOrigin, - IN MIX Mix) -{ - BOOLEAN ret; - - // FIXME: We only support a brush's solid color attribute - ret = EngPaintRgn(pso, ClipRegion, Brush->iSolidColor, Mix, Brush, BrushOrigin); - - return ret; -} - -BOOL APIENTRY -IntEngPaint(IN SURFOBJ *pso, - IN CLIPOBJ *ClipRegion, - IN BRUSHOBJ *Brush, - IN POINTL *BrushOrigin, - IN MIX Mix) -{ - SURFACE *psurf = CONTAINING_RECORD(pso, SURFACE, SurfObj); - BOOL ret; - - DPRINT("pso->iType == %u\n", pso->iType); - /* Is the surface's Paint function hooked? */ - if((pso->iType!=STYPE_BITMAP) && (psurf->flags & HOOK_PAINT)) - { - // Call the driver's DrvPaint - ret = GDIDEVFUNCS(pso).Paint( - pso, ClipRegion, Brush, BrushOrigin, Mix); - return ret; - } - return EngPaint(pso, ClipRegion, Brush, BrushOrigin, Mix ); - -} /* EOF */

1 0

[tkreuzer] 65728: [WIN32K] - Implement REGION_bXformRgn - Move IntGdiPaintRgn ro bitblt.c
by tkreuzer＠svn.reactos.org 18 Dec '14

18 Dec '14

Author: tkreuzer Date: Thu Dec 18 08:12:06 2014 New Revision: 65728 URL: http://svn.reactos.org/svn/reactos?rev=65728&view=rev Log: [WIN32K] - Implement REGION_bXformRgn - Move IntGdiPaintRgn ro bitblt.c Modified: trunk/reactos/win32ss/gdi/ntgdi/bitblt.c trunk/reactos/win32ss/gdi/ntgdi/region.c trunk/reactos/win32ss/gdi/ntgdi/region.h Modified: trunk/reactos/win32ss/gdi/ntgdi/bitblt.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/gdi/ntgdi/bitblt.c… ============================================================================== --- trunk/reactos/win32ss/gdi/ntgdi/bitblt.c [iso-8859-1] (original) +++ trunk/reactos/win32ss/gdi/ntgdi/bitblt.c [iso-8859-1] Thu Dec 18 08:12:06 2014 @@ -1010,6 +1010,81 @@ return Ret; } +static +BOOL +FASTCALL +REGION_LPTODP( + _In_ PDC pdc, + _Inout_ PREGION prgnDest, + _In_ PREGION prgnSrc) +{ + if (IntGdiCombineRgn(prgnDest, prgnSrc, NULL, RGN_COPY) == ERROR) + return FALSE; + + return REGION_bXformRgn(prgnDest, &pdc->dclevel.mxWorldToDevice); +} + +BOOL +FASTCALL +IntGdiPaintRgn( + PDC dc, + PREGION Rgn) +{ + PREGION VisRgn; + XCLIPOBJ ClipRegion; + BOOL bRet = FALSE; + POINTL BrushOrigin; + SURFACE *psurf; + PDC_ATTR pdcattr; + + if ((dc == NULL) || (Rgn == NULL)) + return FALSE; + + pdcattr = dc->pdcattr; + + ASSERT(!(pdcattr->ulDirty_ & (DIRTY_FILL | DC_BRUSH_DIRTY))); + + VisRgn = IntSysCreateRectpRgn(0, 0, 0, 0); + if (VisRgn == NULL) + { + return FALSE; + } + + // Transform region into device co-ords + if (!REGION_LPTODP(dc, VisRgn, Rgn) || + IntGdiOffsetRgn(VisRgn, dc->ptlDCOrig.x, dc->ptlDCOrig.y) == ERROR) + { + REGION_Delete(VisRgn); + return FALSE; + } + + if (dc->prgnRao) + IntGdiCombineRgn(VisRgn, VisRgn, dc->prgnRao, RGN_AND); + + IntEngInitClipObj(&ClipRegion); + IntEngUpdateClipRegion(&ClipRegion, + VisRgn->rdh.nCount, + VisRgn->Buffer, + &VisRgn->rdh.rcBound ); + + BrushOrigin.x = pdcattr->ptlBrushOrigin.x; + BrushOrigin.y = pdcattr->ptlBrushOrigin.y; + psurf = dc->dclevel.pSurface; + /* FIXME: Handle psurf == NULL !!!! */ + + bRet = IntEngPaint(&psurf->SurfObj, + &ClipRegion.ClipObj, + &dc->eboFill.BrushObject, + &BrushOrigin, + 0xFFFF); // FIXME: Don't know what to put here + + REGION_Delete(VisRgn); + IntEngFreeClipResources(&ClipRegion); + + // Fill the region + return bRet; +} + BOOL APIENTRY NtGdiFillRgn( Modified: trunk/reactos/win32ss/gdi/ntgdi/region.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/gdi/ntgdi/region.c… ============================================================================== --- trunk/reactos/win32ss/gdi/ntgdi/region.c [iso-8859-1] (original) +++ trunk/reactos/win32ss/gdi/ntgdi/region.c [iso-8859-1] Thu Dec 18 08:12:06 2014 @@ -1941,64 +1941,137 @@ return hrgnFrame; } - -static BOOL FASTCALL -REGION_LPTODP( - _In_ PDC dc, - _Inout_ PREGION RgnDest, - _In_ PREGION RgnSrc) -{ - RECTL *pCurRect, *pEndRect; - RECTL tmpRect; - PDC_ATTR pdcattr; - - if (dc == NULL) - return FALSE; - pdcattr = dc->pdcattr; - - if (pdcattr->iMapMode == MM_TEXT) // Requires only a translation - { - if (IntGdiCombineRgn(RgnDest, RgnSrc, 0, RGN_COPY) == ERROR) +REGION_bXformRgn( + _Inout_ PREGION prgn, + _In_ PMATRIX pmx) +{ + XFORMOBJ xo; + ULONG i, j, cjSize; + PPOINT ppt; + PULONG pcPoints; + RECT rect; + BOOL bResult; + + /* Check if this is a scaling only matrix (off-diagonal elements are 0 */ + if (pmx->flAccel & XFORM_SCALE) + { + /* Check if this is a translation only matrix */ + if (pmx->flAccel & XFORM_UNITY) + { + /* Just offset the region */ + return IntGdiOffsetRgn(prgn, (pmx->fxDx + 8) / 16, (pmx->fxDy + 8) / 16) != ERROR; + } + else + { + /* Initialize the xform object */ + XFORMOBJ_vInit(&xo, pmx); + + /* Scaling can move the rects out of the coordinate space, so + * we first need to check whether we can apply the transformation + * on the bounds rect without modifying the region */ + if (!XFORMOBJ_bApplyXform(&xo, XF_LTOL, 2, &prgn->rdh.rcBound, &rect)) + { + return FALSE; + } + + /* Apply the xform to the rects in the region */ + if (!XFORMOBJ_bApplyXform(&xo, + XF_LTOL, + prgn->rdh.nCount * 2, + prgn->Buffer, + prgn->Buffer)) + { + /* This can not happen, since we already checked the bounds! */ + NT_ASSERT(FALSE); + } + + /* Reset bounds */ + RECTL_vSetEmptyRect(&prgn->rdh.rcBound); + + /* Loop all rects in the region */ + for (i = 0; i < prgn->rdh.nCount; i++) + { + /* Make sure the rect is well-ordered after the xform */ + RECTL_vMakeWellOrdered(&prgn->Buffer[i]); + + /* Update bounds */ + RECTL_bUnionRect(&prgn->rdh.rcBound, + &prgn->rdh.rcBound, + &prgn->Buffer[i]); + } + + /* Loop all rects in the region */ + for (i = 0; i < prgn->rdh.nCount - 1; i++) + { + for (j = i; i < prgn->rdh.nCount; i++) + { + NT_ASSERT(prgn->Buffer[i].top < prgn->Buffer[i].bottom); + NT_ASSERT(prgn->Buffer[j].top >= prgn->Buffer[i].top); + } + } + + return TRUE; + } + } + else + { + /* Allocate a buffer for the polygons */ + cjSize = prgn->rdh.nCount * (4 * sizeof(POINT) + sizeof(ULONG)); + ppt = ExAllocatePoolWithTag(PagedPool, cjSize, GDITAG_REGION); + if (ppt == NULL) + { return FALSE; - - IntGdiOffsetRgn(RgnDest, - pdcattr->ptlViewportOrg.x - pdcattr->ptlWindowOrg.x, - pdcattr->ptlViewportOrg.y - pdcattr->ptlWindowOrg.y); - return TRUE; - } - - EMPTY_REGION(RgnDest); - - pEndRect = RgnSrc->Buffer + RgnSrc->rdh.nCount; - for (pCurRect = RgnSrc->Buffer; pCurRect < pEndRect; pCurRect++) - { - tmpRect = *pCurRect; - tmpRect.left = XLPTODP(pdcattr, tmpRect.left); - tmpRect.top = YLPTODP(pdcattr, tmpRect.top); - tmpRect.right = XLPTODP(pdcattr, tmpRect.right); - tmpRect.bottom = YLPTODP(pdcattr, tmpRect.bottom); - - if (tmpRect.left > tmpRect.right) - { - INT tmp = tmpRect.left; - tmpRect.left = tmpRect.right; - tmpRect.right = tmp; - } - - if (tmpRect.top > tmpRect.bottom) - { - INT tmp = tmpRect.top; - tmpRect.top = tmpRect.bottom; - tmpRect.bottom = tmp; - } - - REGION_UnionRectWithRgn(RgnDest, &tmpRect); - } - - return TRUE; -} + } + + /* Fill the buffer with the rects */ + pcPoints = (PULONG)&ppt[4 * prgn->rdh.nCount]; + for (i = 0; i < prgn->rdh.nCount; i++) + { + /* Make sure the rect is within the legal range */ + pcPoints[i] = 4; + ppt[4 * i + 0].x = prgn->Buffer[i].left; + ppt[4 * i + 0].y = prgn->Buffer[i].top; + ppt[4 * i + 1].x = prgn->Buffer[i].right; + ppt[4 * i + 1].y = prgn->Buffer[i].top; + ppt[4 * i + 2].x = prgn->Buffer[i].right; + ppt[4 * i + 2].y = prgn->Buffer[i].bottom; + ppt[4 * i + 3].x = prgn->Buffer[i].left; + ppt[4 * i + 3].y = prgn->Buffer[i].bottom; + } + + /* Initialize the xform object */ + XFORMOBJ_vInit(&xo, pmx); + + /* Apply the xform to the rects in the buffer */ + if (!XFORMOBJ_bApplyXform(&xo, + XF_LTOL, + prgn->rdh.nCount * 2, + ppt, + ppt)) + { + /* This means, there were coordinates that would go outside of + the coordinate space after the transformation */ + ExFreePoolWithTag(ppt, GDITAG_REGION); + return FALSE; + } + + /* Now use the polygons to create a polygon region */ + bResult = REGION_SetPolyPolygonRgn(prgn, + ppt, + pcPoints, + prgn->rdh.nCount, + WINDING); + + /* Free the polygon buffer */ + ExFreePoolWithTag(ppt, GDITAG_REGION); + + return bResult; + } + +} + PREGION FASTCALL @@ -2385,66 +2458,6 @@ return ret; } -BOOL -FASTCALL -IntGdiPaintRgn( - PDC dc, - PREGION Rgn) -{ - PREGION VisRgn; - XCLIPOBJ ClipRegion; - BOOL bRet = FALSE; - POINTL BrushOrigin; - SURFACE *psurf; - PDC_ATTR pdcattr; - - if ((dc == NULL) || (Rgn == NULL)) - return FALSE; - - pdcattr = dc->pdcattr; - - ASSERT(!(pdcattr->ulDirty_ & (DIRTY_FILL | DC_BRUSH_DIRTY))); - - VisRgn = IntSysCreateRectpRgn(0, 0, 0, 0); - if (VisRgn == NULL) - { - return FALSE; - } - - // Transform region into device co-ords - if (!REGION_LPTODP(dc, VisRgn, Rgn) || - IntGdiOffsetRgn(VisRgn, dc->ptlDCOrig.x, dc->ptlDCOrig.y) == ERROR) - { - REGION_Delete(VisRgn); - return FALSE; - } - - if (dc->prgnRao) - IntGdiCombineRgn(VisRgn, VisRgn, dc->prgnRao, RGN_AND); - - IntEngInitClipObj(&ClipRegion); - IntEngUpdateClipRegion(&ClipRegion, - VisRgn->rdh.nCount, - VisRgn->Buffer, - &VisRgn->rdh.rcBound ); - - BrushOrigin.x = pdcattr->ptlBrushOrigin.x; - BrushOrigin.y = pdcattr->ptlBrushOrigin.y; - psurf = dc->dclevel.pSurface; - /* FIXME: Handle psurf == NULL !!!! */ - - bRet = IntEngPaint(&psurf->SurfObj, - &ClipRegion.ClipObj, - &dc->eboFill.BrushObject, - &BrushOrigin, - 0xFFFF); // FIXME: Don't know what to put here - - REGION_Delete(VisRgn); - IntEngFreeClipResources(&ClipRegion); - - // Fill the region - return bRet; -} BOOL FASTCALL @@ -3204,8 +3217,10 @@ * are in the Winding active edge table. */ if (pWETE == pAET) { - pts->x = pAET->bres.minor_axis, pts->y = y; - pts++, iPts++; + pts->x = pAET->bres.minor_axis; + pts->y = y; + pts++; + iPts++; /* Send out the buffer */ if (iPts == NUMPTSTOBUFFER) @@ -3245,7 +3260,7 @@ REGION_FreeStorage(SLLBlock.next); REGION_PtsToRegion(numFullPtBlocks, iPts, &FirstPtBlock, prgn); - for (curPtBlock = FirstPtBlock.next; --numFullPtBlocks >= 0;) + for (curPtBlock = FirstPtBlock.next; numFullPtBlocks-- > 0;) { tmpPtBlock = curPtBlock->next; ExFreePoolWithTag(curPtBlock, TAG_REGION); Modified: trunk/reactos/win32ss/gdi/ntgdi/region.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/gdi/ntgdi/region.h… ============================================================================== --- trunk/reactos/win32ss/gdi/ntgdi/region.h [iso-8859-1] (original) +++ trunk/reactos/win32ss/gdi/ntgdi/region.h [iso-8859-1] Thu Dec 18 08:12:06 2014 @@ -38,6 +38,12 @@ VOID NTAPI REGION_vCleanup(PVOID ObjectBody); VOID FASTCALL REGION_Delete(PREGION); INT APIENTRY IntGdiGetRgnBox(HRGN, RECTL*); + +BOOL +FASTCALL +REGION_bXformRgn( + _Inout_ PREGION prgn, + _In_ PMATRIX pmx); BOOL FASTCALL

1 0

[tkreuzer] 65727: [WIN32K] - Move IntGdiReleaseRaoRgn and IntGdiReleaseVisRgn to cliprgn.c - Remove unused IntUpdateVisRectRgn
by tkreuzer＠svn.reactos.org 18 Dec '14

18 Dec '14

Author: tkreuzer Date: Thu Dec 18 08:12:01 2014 New Revision: 65727 URL: http://svn.reactos.org/svn/reactos?rev=65727&view=rev Log: [WIN32K] - Move IntGdiReleaseRaoRgn and IntGdiReleaseVisRgn to cliprgn.c - Remove unused IntUpdateVisRectRgn Modified: trunk/reactos/win32ss/gdi/ntgdi/cliprgn.c trunk/reactos/win32ss/gdi/ntgdi/cliprgn.h trunk/reactos/win32ss/gdi/ntgdi/region.c trunk/reactos/win32ss/gdi/ntgdi/region.h Modified: trunk/reactos/win32ss/gdi/ntgdi/cliprgn.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/gdi/ntgdi/cliprgn.… ============================================================================== --- trunk/reactos/win32ss/gdi/ntgdi/cliprgn.c [iso-8859-1] (original) +++ trunk/reactos/win32ss/gdi/ntgdi/cliprgn.c [iso-8859-1] Thu Dec 18 08:12:01 2014 @@ -10,6 +10,32 @@ #define NDEBUG #include <debug.h> + +VOID +FASTCALL +IntGdiReleaseRaoRgn(PDC pDC) +{ + INT Index = GDI_HANDLE_GET_INDEX(pDC->BaseObject.hHmgr); + PGDI_TABLE_ENTRY Entry = &GdiHandleTable->Entries[Index]; + pDC->fs |= DC_FLAG_DIRTY_RAO; + Entry->Flags |= GDI_ENTRY_VALIDATE_VIS; + RECTL_vSetEmptyRect(&pDC->erclClip); + REGION_Delete(pDC->prgnRao); + pDC->prgnRao = NULL; +} + +VOID +FASTCALL +IntGdiReleaseVisRgn(PDC pDC) +{ + INT Index = GDI_HANDLE_GET_INDEX(pDC->BaseObject.hHmgr); + PGDI_TABLE_ENTRY Entry = &GdiHandleTable->Entries[Index]; + pDC->fs |= DC_FLAG_DIRTY_RAO; + Entry->Flags |= GDI_ENTRY_VALIDATE_VIS; + RECTL_vSetEmptyRect(&pDC->erclClip); + REGION_Delete(pDC->prgnVis); + pDC->prgnVis = prgnDefault; +} VOID FASTCALL Modified: trunk/reactos/win32ss/gdi/ntgdi/cliprgn.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/gdi/ntgdi/cliprgn.… ============================================================================== --- trunk/reactos/win32ss/gdi/ntgdi/cliprgn.h [iso-8859-1] (original) +++ trunk/reactos/win32ss/gdi/ntgdi/cliprgn.h [iso-8859-1] Thu Dec 18 08:12:01 2014 @@ -9,3 +9,5 @@ VOID FASTCALL GdiSelectVisRgn(HDC hdc, PREGION prgn); INT FASTCALL IntGdiExtSelectClipRgn (PDC dc, PREGION prgn, int fnMode); VOID FASTCALL CLIPPING_UpdateGCRegion(DC* Dc); +VOID FASTCALL IntGdiReleaseRaoRgn(PDC); +VOID FASTCALL IntGdiReleaseVisRgn(PDC); Modified: trunk/reactos/win32ss/gdi/ntgdi/region.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/gdi/ntgdi/region.c… ============================================================================== --- trunk/reactos/win32ss/gdi/ntgdi/region.c [iso-8859-1] (original) +++ trunk/reactos/win32ss/gdi/ntgdi/region.c [iso-8859-1] Thu Dec 18 08:12:01 2014 @@ -2264,70 +2264,6 @@ GDIOBJ_vDeleteObject(&pRgn->BaseObject); } -VOID -FASTCALL -IntGdiReleaseRaoRgn(PDC pDC) -{ - INT Index = GDI_HANDLE_GET_INDEX(pDC->BaseObject.hHmgr); - PGDI_TABLE_ENTRY Entry = &GdiHandleTable->Entries[Index]; - pDC->fs |= DC_FLAG_DIRTY_RAO; - Entry->Flags |= GDI_ENTRY_VALIDATE_VIS; - RECTL_vSetEmptyRect(&pDC->erclClip); - REGION_Delete(pDC->prgnRao); - pDC->prgnRao = NULL; -} - -VOID -FASTCALL -IntGdiReleaseVisRgn(PDC pDC) -{ - INT Index = GDI_HANDLE_GET_INDEX(pDC->BaseObject.hHmgr); - PGDI_TABLE_ENTRY Entry = &GdiHandleTable->Entries[Index]; - pDC->fs |= DC_FLAG_DIRTY_RAO; - Entry->Flags |= GDI_ENTRY_VALIDATE_VIS; - RECTL_vSetEmptyRect(&pDC->erclClip); - REGION_Delete(pDC->prgnVis); - pDC->prgnVis = prgnDefault; -} - -VOID -FASTCALL -IntUpdateVisRectRgn(PDC pDC, PREGION pRgn) -{ - INT Index = GDI_HANDLE_GET_INDEX(pDC->BaseObject.hHmgr); - PGDI_TABLE_ENTRY Entry = &GdiHandleTable->Entries[Index]; - PDC_ATTR pdcattr; - RECTL rcl; - - if (Entry->Flags & GDI_ENTRY_VALIDATE_VIS) - { - pdcattr = pDC->pdcattr; - - pdcattr->VisRectRegion.iComplexity = REGION_Complexity(pRgn); - - if (pRgn && pdcattr->VisRectRegion.iComplexity != NULLREGION) - { - rcl.left = pRgn->rdh.rcBound.left; - rcl.top = pRgn->rdh.rcBound.top; - rcl.right = pRgn->rdh.rcBound.right; - rcl.bottom = pRgn->rdh.rcBound.bottom; - - rcl.left -= pDC->erclWindow.left; - rcl.top -= pDC->erclWindow.top; - rcl.right -= pDC->erclWindow.left; - rcl.bottom -= pDC->erclWindow.top; - } - else - { - RECTL_vSetEmptyRect(&rcl); - } - - pdcattr->VisRectRegion.Rect = rcl; - - Entry->Flags &= ~GDI_ENTRY_VALIDATE_VIS; - } -} - BOOL FASTCALL IntGdiSetRegionOwner(HRGN hRgn, DWORD OwnerMask) @@ -3617,6 +3553,8 @@ ULONG i; BOOL bRet = FALSE; + /// FIXME: need to use GDIOBJ_LockMultipleObjects + rgn1 = RGNOBJAPI_Lock(hSrcRgn1, NULL); if (rgn1 == NULL) return ERROR; Modified: trunk/reactos/win32ss/gdi/ntgdi/region.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/gdi/ntgdi/region.h… ============================================================================== --- trunk/reactos/win32ss/gdi/ntgdi/region.h [iso-8859-1] (original) +++ trunk/reactos/win32ss/gdi/ntgdi/region.h [iso-8859-1] Thu Dec 18 08:12:01 2014 @@ -8,14 +8,18 @@ { /* Header for all gdi objects in the handle table. Do not (re)move this. */ - BASEOBJECT BaseObject; + BASEOBJECT BaseObject; PRGN_ATTR prgnattr; RGN_ATTR rgnattr; RGNDATAHEADER rdh; - RECTL *Buffer; + RECTL *Buffer; } REGION, *PREGION; +/* Globals ********************************************************************/ + +extern PREGION prgnDefault; +extern HRGN hrgnDefault; /* Functions ******************************************************************/ @@ -32,16 +36,8 @@ INT FASTCALL REGION_CropRegion(PREGION rgnDst, PREGION rgnSrc, const RECTL *rect); VOID FASTCALL REGION_SetRectRgn(PREGION pRgn, INT LeftRect, INT TopRect, INT RightRect, INT BottomRect); VOID NTAPI REGION_vCleanup(PVOID ObjectBody); - -extern PREGION prgnDefault; -extern HRGN hrgnDefault; - VOID FASTCALL REGION_Delete(PREGION); -VOID FASTCALL IntGdiReleaseRaoRgn(PDC); -VOID FASTCALL IntGdiReleaseVisRgn(PDC); - INT APIENTRY IntGdiGetRgnBox(HRGN, RECTL*); -BOOL FASTCALL IntGdiPaintRgn(PDC, PREGION ); BOOL FASTCALL @@ -97,3 +93,6 @@ { GDIOBJ_vUnlockObject(&prgn->BaseObject); } + +// FIXME: move this +BOOL FASTCALL IntGdiPaintRgn(PDC, PREGION );

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs