Ros-diffs

ros-diffs@reactos.org

81390 discussions

[akhaldi] 64203: [DBGHELP] * Work around a Clang bug w.r.t. dwarf emission. Brought to you by the mighty Arty. CORE-8516 #comment Now ReactOS can compile a bootcd with Clang, and it boots to shell....
by akhaldi＠svn.reactos.org 20 Sep '14

20 Sep '14

Author: akhaldi Date: Sat Sep 20 18:06:09 2014 New Revision: 64203 URL: http://svn.reactos.org/svn/reactos?rev=64203&view=rev Log: [DBGHELP] * Work around a Clang bug w.r.t. dwarf emission. Brought to you by the mighty Arty. CORE-8516 #comment Now ReactOS can compile a bootcd with Clang, and it boots to shell. Only some PSEH bug(s) remain for it to be fully functional and ready for testman (I'm looking at you, Timo ;) ) Modified: trunk/reactos/dll/win32/dbghelp/dwarf.c Modified: trunk/reactos/dll/win32/dbghelp/dwarf.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/dbghelp/dwarf.c?… ============================================================================== --- trunk/reactos/dll/win32/dbghelp/dwarf.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/dbghelp/dwarf.c [iso-8859-1] Sat Sep 20 18:06:09 2014 @@ -2381,7 +2381,17 @@ } if (dwarf2_find_attribute(&ctx, di, DW_AT_stmt_list, &stmt_list)) { +#ifdef __REACTOS__ + unsigned long stmt_list_val = stmt_list.u.uvalue; + if (stmt_list_val > module->module.BaseOfImage) + { + /* FIXME: Clang is recording this as an address, not an offset */ + stmt_list_val -= module->module.BaseOfImage + sections[section_line].rva; + } + if (dwarf2_parse_line_numbers(sections, &ctx, comp_dir.u.string, stmt_list_val)) +#else if (dwarf2_parse_line_numbers(sections, &ctx, comp_dir.u.string, stmt_list.u.uvalue)) +#endif module->module.LineNumbers = TRUE; } ret = TRUE;

1 0

[akhaldi] 64202: [CMAKE/CLANG] * Properly initialize compiler flags. CORE-8516
by akhaldi＠svn.reactos.org 20 Sep '14

20 Sep '14

Author: akhaldi Date: Sat Sep 20 17:36:37 2014 New Revision: 64202 URL: http://svn.reactos.org/svn/reactos?rev=64202&view=rev Log: [CMAKE/CLANG] * Properly initialize compiler flags. CORE-8516 Modified: trunk/reactos/cmake/gcc.cmake Modified: trunk/reactos/cmake/gcc.cmake URL: http://svn.reactos.org/svn/reactos/trunk/reactos/cmake/gcc.cmake?rev=64202&… ============================================================================== --- trunk/reactos/cmake/gcc.cmake [iso-8859-1] (original) +++ trunk/reactos/cmake/gcc.cmake [iso-8859-1] Sat Sep 20 17:36:37 2014 @@ -43,6 +43,9 @@ set(CMAKE_CXX_COMPILE_OPTIONS_PIE "") set(CMAKE_SHARED_LIBRARY_C_FLAGS "") set(CMAKE_SHARED_LIBRARY_CXX_FLAGS "") + set(CMAKE_ASM_FLAGS_DEBUG "") + set(CMAKE_C_FLAGS_DEBUG "") + set(CMAKE_CXX_FLAGS_DEBUG "") endif() if(DBG)

1 0

[ekohl] 64201: [SAMSRV] Fix some really stupid typos.
by ekohl＠svn.reactos.org 20 Sep '14

20 Sep '14

Author: ekohl Date: Sat Sep 20 13:45:12 2014 New Revision: 64201 URL: http://svn.reactos.org/svn/reactos?rev=64201&view=rev Log: [SAMSRV] Fix some really stupid typos. Modified: trunk/reactos/dll/win32/samsrv/samrpc.c Modified: trunk/reactos/dll/win32/samsrv/samrpc.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/samsrv/samrpc.c?… ============================================================================== --- trunk/reactos/dll/win32/samsrv/samrpc.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/samsrv/samrpc.c [iso-8859-1] Sat Sep 20 13:45:12 2014 @@ -2179,7 +2179,7 @@ EnumBuffer->Buffer[i].RelativeId = Rid; EnumBuffer->Buffer[i].Name.Length = (USHORT)NameLength; - EnumBuffer->Buffer[i].Name.MaximumLength = (USHORT)(DataLength + sizeof(UNICODE_NULL)); + EnumBuffer->Buffer[i].Name.MaximumLength = (USHORT)(NameLength + sizeof(UNICODE_NULL)); /* FIXME: Disabled because of bugs in widl and rpcrt4 */ #if 0 @@ -2790,7 +2790,7 @@ EnumBuffer->Buffer[i].RelativeId = Rid; EnumBuffer->Buffer[i].Name.Length = (USHORT)NameLength; - EnumBuffer->Buffer[i].Name.MaximumLength = (USHORT)(DataLength + sizeof(UNICODE_NULL)); + EnumBuffer->Buffer[i].Name.MaximumLength = (USHORT)(NameLength + sizeof(UNICODE_NULL)); /* FIXME: Disabled because of bugs in widl and rpcrt4 */ #if 0 @@ -3171,7 +3171,7 @@ EnumBuffer->Buffer[i].RelativeId = Rid; EnumBuffer->Buffer[i].Name.Length = (USHORT)NameLength; - EnumBuffer->Buffer[i].Name.MaximumLength = (USHORT)(DataLength + sizeof(UNICODE_NULL)); + EnumBuffer->Buffer[i].Name.MaximumLength = (USHORT)(NameLength + sizeof(UNICODE_NULL)); /* FIXME: Disabled because of bugs in widl and rpcrt4 */ #if 0

1 0

[jgardou] 64200: [WIN32K] - revert r64197 and r64198
by jgardou＠svn.reactos.org 19 Sep '14

19 Sep '14

Author: jgardou Date: Fri Sep 19 21:10:56 2014 New Revision: 64200 URL: http://svn.reactos.org/svn/reactos?rev=64200&view=rev Log: [WIN32K] - revert r64197 and r64198 Modified: trunk/reactos/win32ss/user/ntuser/main.c Modified: trunk/reactos/win32ss/user/ntuser/main.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/ntuser/main.c… ============================================================================== --- trunk/reactos/win32ss/user/ntuser/main.c [iso-8859-1] (original) +++ trunk/reactos/win32ss/user/ntuser/main.c [iso-8859-1] Fri Sep 19 21:10:56 2014 @@ -266,7 +266,6 @@ NTSTATUS Status = STATUS_SUCCESS; PTEB pTeb; LARGE_INTEGER LargeTickCount; - OBJECT_ATTRIBUTES EventQueueObjAttr; Process = Thread->ThreadsProcess; @@ -314,9 +313,8 @@ ptiCurrent->ppi->cThreads++; ptiCurrent->hEventQueueClient = NULL; - InitializeObjectAttributes(&EventQueueObjAttr, NULL, OBJ_KERNEL_HANDLE, NULL, NULL); Status = ZwCreateEvent(&ptiCurrent->hEventQueueClient, EVENT_ALL_ACCESS, - &EventQueueObjAttr, SynchronizationEvent, FALSE); + NULL, SynchronizationEvent, FALSE); if (!NT_SUCCESS(Status)) { goto error;

1 0

[ekohl] 64199: [RPCRT4] Addendum to r64053. Fix EmbeddedPointerFree too. Patch by Alexandre Julliard.
by ekohl＠svn.reactos.org 19 Sep '14

19 Sep '14

Author: ekohl Date: Fri Sep 19 20:30:17 2014 New Revision: 64199 URL: http://svn.reactos.org/svn/reactos?rev=64199&view=rev Log: [RPCRT4] Addendum to r64053. Fix EmbeddedPointerFree too. Patch by Alexandre Julliard. Modified: trunk/reactos/dll/win32/rpcrt4/ndr_marshall.c Modified: trunk/reactos/dll/win32/rpcrt4/ndr_marshall.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/rpcrt4/ndr_marsh… ============================================================================== --- trunk/reactos/dll/win32/rpcrt4/ndr_marshall.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/rpcrt4/ndr_marshall.c [iso-8859-1] Fri Sep 19 20:30:17 2014 @@ -1479,7 +1479,7 @@ unsigned char *memptr = membase + *(const SHORT*)&info[0]; unsigned char *saved_memory = pStubMsg->Memory; - pStubMsg->Memory = pMemory; + pStubMsg->Memory = membase; PointerFree(pStubMsg, *(unsigned char**)memptr, info+4); pStubMsg->Memory = saved_memory; }

1 0

[jgardou] 64198: [WIN32K] - Embarassing addendum to r64197
by jgardou＠svn.reactos.org 19 Sep '14

19 Sep '14

Author: jgardou Date: Fri Sep 19 18:55:22 2014 New Revision: 64198 URL: http://svn.reactos.org/svn/reactos?rev=64198&view=rev Log: [WIN32K] - Embarassing addendum to r64197 Modified: trunk/reactos/win32ss/user/ntuser/main.c Modified: trunk/reactos/win32ss/user/ntuser/main.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/ntuser/main.c… ============================================================================== --- trunk/reactos/win32ss/user/ntuser/main.c [iso-8859-1] (original) +++ trunk/reactos/win32ss/user/ntuser/main.c [iso-8859-1] Fri Sep 19 18:55:22 2014 @@ -316,7 +316,7 @@ ptiCurrent->hEventQueueClient = NULL; InitializeObjectAttributes(&EventQueueObjAttr, NULL, OBJ_KERNEL_HANDLE, NULL, NULL); Status = ZwCreateEvent(&ptiCurrent->hEventQueueClient, EVENT_ALL_ACCESS, - NULL, SynchronizationEvent, FALSE); + &EventQueueObjAttr, SynchronizationEvent, FALSE); if (!NT_SUCCESS(Status)) { goto error;

1 0

[jgardou] 64197: [WIN32K] - Allocate the the queue client event as a KERNEL_HANDLE CORE-8539
by jgardou＠svn.reactos.org 19 Sep '14

19 Sep '14

Author: jgardou Date: Fri Sep 19 18:21:06 2014 New Revision: 64197 URL: http://svn.reactos.org/svn/reactos?rev=64197&view=rev Log: [WIN32K] - Allocate the the queue client event as a KERNEL_HANDLE CORE-8539 Modified: trunk/reactos/win32ss/user/ntuser/main.c Modified: trunk/reactos/win32ss/user/ntuser/main.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/ntuser/main.c… ============================================================================== --- trunk/reactos/win32ss/user/ntuser/main.c [iso-8859-1] (original) +++ trunk/reactos/win32ss/user/ntuser/main.c [iso-8859-1] Fri Sep 19 18:21:06 2014 @@ -266,6 +266,7 @@ NTSTATUS Status = STATUS_SUCCESS; PTEB pTeb; LARGE_INTEGER LargeTickCount; + OBJECT_ATTRIBUTES EventQueueObjAttr; Process = Thread->ThreadsProcess; @@ -313,6 +314,7 @@ ptiCurrent->ppi->cThreads++; ptiCurrent->hEventQueueClient = NULL; + InitializeObjectAttributes(&EventQueueObjAttr, NULL, OBJ_KERNEL_HANDLE, NULL, NULL); Status = ZwCreateEvent(&ptiCurrent->hEventQueueClient, EVENT_ALL_ACCESS, NULL, SynchronizationEvent, FALSE); if (!NT_SUCCESS(Status))

1 0

[tfaber] 64196: [GDI32] - Fix MSVC build
by tfaber＠svn.reactos.org 19 Sep '14

19 Sep '14

Author: tfaber Date: Fri Sep 19 17:51:04 2014 New Revision: 64196 URL: http://svn.reactos.org/svn/reactos?rev=64196&view=rev Log: [GDI32] - Fix MSVC build Modified: trunk/reactos/win32ss/gdi/gdi32/CMakeLists.txt Modified: trunk/reactos/win32ss/gdi/gdi32/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/gdi/gdi32/CMakeLis… ============================================================================== --- trunk/reactos/win32ss/gdi/gdi32/CMakeLists.txt [iso-8859-1] (original) +++ trunk/reactos/win32ss/gdi/gdi32/CMakeLists.txt [iso-8859-1] Fri Sep 19 17:51:04 2014 @@ -58,6 +58,7 @@ target_link_libraries(gdi32 win32ksys dxguid + msvcrtex ${PSEH_LIB}) add_importlibs(gdi32 user32 advapi32 kernel32 ntdll)

1 0

[tfaber] 64195: [OLEAUT32] - Sync MSVC version of call_method with GCC version. Patch by Timo Kreuzer.
by tfaber＠svn.reactos.org 19 Sep '14

19 Sep '14

Author: tfaber Date: Fri Sep 19 14:35:56 2014 New Revision: 64195 URL: http://svn.reactos.org/svn/reactos?rev=64195&view=rev Log: [OLEAUT32] - Sync MSVC version of call_method with GCC version. Patch by Timo Kreuzer. Modified: trunk/reactos/dll/win32/oleaut32/msvc.S Modified: trunk/reactos/dll/win32/oleaut32/msvc.S URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/oleaut32/msvc.S?… ============================================================================== --- trunk/reactos/dll/win32/oleaut32/msvc.S [iso-8859-1] (original) +++ trunk/reactos/dll/win32/oleaut32/msvc.S [iso-8859-1] Fri Sep 19 14:35:56 2014 @@ -19,17 +19,21 @@ push esi push edi mov edx, dword ptr ds:[ebp + 12] + mov edi, esp shl edx, 2 jz cm1 - sub esp, edx - and esp, HEX(0FFFFFFF0) + sub edi, edx + and edi, HEX(0FFFFFFF0) + mov esp, edi mov ecx, dword ptr ds:[ebp + 12] mov esi, dword ptr ds:[ebp + 16] - mov edi, esp cld rep movsd cm1: call dword ptr ds:[ebp + 8] + sub edi, esp + mov ecx,[ebp + 20] + mov [ecx], edi lea esp, [ebp - 8] pop edi pop esi

1 0

[tfaber] 64194: [PSEH3] - Don't clobber ebx in __SEH3$_RegisterTryLevelWithNonVolatiles (addendum to r64132)
by tfaber＠svn.reactos.org 19 Sep '14

19 Sep '14

Author: tfaber Date: Fri Sep 19 13:59:13 2014 New Revision: 64194 URL: http://svn.reactos.org/svn/reactos?rev=64194&view=rev Log: [PSEH3] - Don't clobber ebx in __SEH3$_RegisterTryLevelWithNonVolatiles (addendum to r64132) Modified: trunk/reactos/lib/pseh/i386/pseh3.c trunk/reactos/lib/pseh/i386/pseh3_i386.S Modified: trunk/reactos/lib/pseh/i386/pseh3.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/pseh/i386/pseh3.c?rev=… ============================================================================== --- trunk/reactos/lib/pseh/i386/pseh3.c [iso-8859-1] (original) +++ trunk/reactos/lib/pseh/i386/pseh3.c [iso-8859-1] Fri Sep 19 13:59:13 2014 @@ -153,7 +153,7 @@ /* Check for __finally frames */ if (Frame->ScopeTable->Target == NULL) { - _SEH3$_InvokeFilter(Frame, Frame->ScopeTable->Filter); + _SEH3$_InvokeFilter(Frame, Frame->ScopeTable->Filter); } } Modified: trunk/reactos/lib/pseh/i386/pseh3_i386.S URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/pseh/i386/pseh3_i386.S… ============================================================================== --- trunk/reactos/lib/pseh/i386/pseh3_i386.S [iso-8859-1] (original) +++ trunk/reactos/lib/pseh/i386/pseh3_i386.S [iso-8859-1] Fri Sep 19 13:59:13 2014 @@ -87,6 +87,7 @@ /* Safe the return address */ mov ebx, [esp] mov [eax + SEH3_REGISTRATION_FRAME_ReturnAddress], ebx + mov ebx, [eax + SEH3_REGISTRATION_FRAME_Ebx] .global __SEH3$_RegisterTryLevelWithStackLayout __SEH3$_RegisterTryLevelWithStackLayout:

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs