Ros-diffs

ros-diffs@reactos.org

81390 discussions

[akhaldi] 64063: [SAL] * Add some missing _Check_return_ annotations.
by akhaldi＠svn.reactos.org 07 Sep '14

07 Sep '14

Author: akhaldi Date: Sun Sep 7 17:10:44 2014 New Revision: 64063 URL: http://svn.reactos.org/svn/reactos?rev=64063&view=rev Log: [SAL] * Add some missing _Check_return_ annotations. Modified: trunk/reactos/include/crt/stdlib.h Modified: trunk/reactos/include/crt/stdlib.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/crt/stdlib.h?rev=6… ============================================================================== --- trunk/reactos/include/crt/stdlib.h [iso-8859-1] (original) +++ trunk/reactos/include/crt/stdlib.h [iso-8859-1] Sun Sep 7 17:10:44 2014 @@ -1202,6 +1202,7 @@ _In_ int _Shift); #if _INTEGRAL_MAX_BITS >= 64 + _Check_return_ __MINGW_EXTENSION unsigned __int64 __cdecl @@ -1217,6 +1218,7 @@ _In_ int _Shift); #if _INTEGRAL_MAX_BITS >= 64 + _Check_return_ __MINGW_EXTENSION unsigned __int64 __cdecl

1 0

[akhaldi] 64062: [CRT/INTRIN_X86] * Skip some intrinsics when compiling with Clang.
by akhaldi＠svn.reactos.org 07 Sep '14

07 Sep '14

Author: akhaldi Date: Sun Sep 7 17:09:34 2014 New Revision: 64062 URL: http://svn.reactos.org/svn/reactos?rev=64062&view=rev Log: [CRT/INTRIN_X86] * Skip some intrinsics when compiling with Clang. Modified: trunk/reactos/include/crt/mingw32/intrin_x86.h Modified: trunk/reactos/include/crt/mingw32/intrin_x86.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/crt/mingw32/intrin… ============================================================================== --- trunk/reactos/include/crt/mingw32/intrin_x86.h [iso-8859-1] (original) +++ trunk/reactos/include/crt/mingw32/intrin_x86.h [iso-8859-1] Sun Sep 7 17:09:34 2014 @@ -190,16 +190,18 @@ } #ifndef __clang__ + __INTRIN_INLINE long _InterlockedCompareExchange(volatile long * const Destination, const long Exchange, const long Comperand) { return __sync_val_compare_and_swap(Destination, Comperand, Exchange); } -#endif __INTRIN_INLINE void * _InterlockedCompareExchangePointer(void * volatile * const Destination, void * const Exchange, void * const Comperand) { return (void *)__sync_val_compare_and_swap(Destination, Comperand, Exchange); } + +#endif __INTRIN_INLINE char _InterlockedExchange8(volatile char * const Target, const char Value) { @@ -215,6 +217,8 @@ return __sync_lock_test_and_set(Target, Value); } +#ifndef __clang__ + __INTRIN_INLINE long _InterlockedExchange(volatile long * const Target, const long Value) { /* NOTE: __sync_lock_test_and_set would be an acquire barrier, so we force a full barrier */ @@ -222,6 +226,15 @@ return __sync_lock_test_and_set(Target, Value); } +__INTRIN_INLINE void * _InterlockedExchangePointer(void * volatile * const Target, void * const Value) +{ + /* NOTE: __sync_lock_test_and_set would be an acquire barrier, so we force a full barrier */ + __sync_synchronize(); + return (void *)__sync_lock_test_and_set(Target, Value); +} + +#endif + #if defined(_M_AMD64) __INTRIN_INLINE long long _InterlockedExchange64(volatile long long * const Target, const long long Value) { @@ -230,13 +243,6 @@ return __sync_lock_test_and_set(Target, Value); } #endif - -__INTRIN_INLINE void * _InterlockedExchangePointer(void * volatile * const Target, void * const Value) -{ - /* NOTE: __sync_lock_test_and_set would be an acquire barrier, so we force a full barrier */ - __sync_synchronize(); - return (void *)__sync_lock_test_and_set(Target, Value); -} __INTRIN_INLINE long _InterlockedExchangeAdd16(volatile short * const Addend, const short Value) {

1 0

[cwittich] 64061: [crt] revert changes to streamout_char
by cwittich＠svn.reactos.org 07 Sep '14

07 Sep '14

Author: cwittich Date: Sun Sep 7 13:55:36 2014 New Revision: 64061 URL: http://svn.reactos.org/svn/reactos?rev=64061&view=rev Log: [crt] revert changes to streamout_char Modified: trunk/reactos/lib/sdk/crt/printf/streamout.c Modified: trunk/reactos/lib/sdk/crt/printf/streamout.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/sdk/crt/printf/streamo… ============================================================================== --- trunk/reactos/lib/sdk/crt/printf/streamout.c [iso-8859-1] (original) +++ trunk/reactos/lib/sdk/crt/printf/streamout.c [iso-8859-1] Sun Sep 7 13:55:36 2014 @@ -227,9 +227,6 @@ int streamout_char(FILE *stream, int chr) { - if ((stream->_flag & _IOSTRG) && (!stream->_ptr)) - return 1; - #if defined(_USER32_WSPRINTF) || defined(_LIBCNT_) /* Check if the buffer is full */ if (stream->_cnt < sizeof(TCHAR))

1 0

[akhaldi] 64060: [CMAKE/CLANG] * Fix Clang def file handling. * Clang doesn't have -Wold-style-declaration (yet?).
by akhaldi＠svn.reactos.org 07 Sep '14

07 Sep '14

Author: akhaldi Date: Sun Sep 7 12:36:26 2014 New Revision: 64060 URL: http://svn.reactos.org/svn/reactos?rev=64060&view=rev Log: [CMAKE/CLANG] * Fix Clang def file handling. * Clang doesn't have -Wold-style-declaration (yet?). Modified: trunk/reactos/cmake/gcc.cmake Modified: trunk/reactos/cmake/gcc.cmake URL: http://svn.reactos.org/svn/reactos/trunk/reactos/cmake/gcc.cmake?rev=64060&… ============================================================================== --- trunk/reactos/cmake/gcc.cmake [iso-8859-1] (original) +++ trunk/reactos/cmake/gcc.cmake [iso-8859-1] Sun Sep 7 12:36:26 2014 @@ -34,11 +34,16 @@ if(CMAKE_C_COMPILER_ID STREQUAL "Clang") add_compile_flags_language("-std=gnu89" "C") add_compile_flags("-Wno-microsoft") + set(CMAKE_LINK_DEF_FILE_FLAG "") endif() if(DBG) - add_compile_flags_language("-Wold-style-declaration -Wdeclaration-after-statement" "C") -endif() + if(NOT CMAKE_C_COMPILER_ID STREQUAL "Clang") + add_compile_flags_language("-Wold-style-declaration" "C") + endif() + add_compile_flags_language("-Wdeclaration-after-statement" "C") +endif() + add_compile_flags_language("-fno-rtti -fno-exceptions" "CXX") #bug

1 0

[akhaldi] 64059: [CMAKE] * Fix Clang toolchain file with regards to static libs creation.
by akhaldi＠svn.reactos.org 07 Sep '14

07 Sep '14

Author: akhaldi Date: Sun Sep 7 12:33:13 2014 New Revision: 64059 URL: http://svn.reactos.org/svn/reactos?rev=64059&view=rev Log: [CMAKE] * Fix Clang toolchain file with regards to static libs creation. Modified: trunk/reactos/toolchain-clang.cmake Modified: trunk/reactos/toolchain-clang.cmake URL: http://svn.reactos.org/svn/reactos/trunk/reactos/toolchain-clang.cmake?rev=… ============================================================================== --- trunk/reactos/toolchain-clang.cmake [iso-8859-1] (original) +++ trunk/reactos/toolchain-clang.cmake [iso-8859-1] Sun Sep 7 12:33:13 2014 @@ -47,11 +47,11 @@ set(CMAKE_RC_COMPILER ${MINGW_TOOLCHAIN_PREFIX}windres) set(CMAKE_DLLTOOL ${MINGW_TOOLCHAIN_PREFIX}dlltool) -if(NOT LTCG) - set(CMAKE_C_CREATE_STATIC_LIBRARY "<CMAKE_AR> crT <TARGET> <LINK_FLAGS> <OBJECTS>") -else() - set(CMAKE_C_CREATE_STATIC_LIBRARY "<CMAKE_AR> cr <TARGET> <LINK_FLAGS> <OBJECTS>") +if(CMAKE_HOST_WIN32) + set(CMAKE_AR ar) endif() + +set(CMAKE_C_CREATE_STATIC_LIBRARY "${CMAKE_AR} crT <TARGET> <LINK_FLAGS> <OBJECTS>") set(CMAKE_CXX_CREATE_STATIC_LIBRARY ${CMAKE_C_CREATE_STATIC_LIBRARY}) set(CMAKE_ASM_CREATE_STATIC_LIBRARY ${CMAKE_C_CREATE_STATIC_LIBRARY})

1 0

[akhaldi] 64058: [OPENGL32/MESA] * Zap extra_EXT_secondary_color_flush_current and EXT_secondary_color. CORE-7499
by akhaldi＠svn.reactos.org 07 Sep '14

07 Sep '14

Author: akhaldi Date: Sun Sep 7 12:30:40 2014 New Revision: 64058 URL: http://svn.reactos.org/svn/reactos?rev=64058&view=rev Log: [OPENGL32/MESA] * Zap extra_EXT_secondary_color_flush_current and EXT_secondary_color. CORE-7499 Modified: trunk/reactos/dll/opengl/mesa/main/get.c Modified: trunk/reactos/dll/opengl/mesa/main/get.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/opengl/mesa/main/get.c… ============================================================================== --- trunk/reactos/dll/opengl/mesa/main/get.c [iso-8859-1] (original) +++ trunk/reactos/dll/opengl/mesa/main/get.c [iso-8859-1] Sun Sep 7 12:30:40 2014 @@ -235,12 +235,6 @@ EXTRA_END }; -static const int extra_EXT_secondary_color_flush_current[] = { - EXT(EXT_secondary_color), - EXTRA_FLUSH_CURRENT, - EXTRA_END -}; - static const int extra_EXT_fog_coord_flush_current[] = { EXT(EXT_fog_coord), EXTRA_FLUSH_CURRENT, @@ -254,7 +248,6 @@ EXTRA_EXT(ARB_texture_cube_map); -EXTRA_EXT(EXT_secondary_color); EXTRA_EXT(EXT_fog_coord); EXTRA_EXT(NV_fog_distance); EXTRA_EXT(EXT_texture_filter_anisotropic);

1 0

[akhaldi] 64057: [OPENGL32/MESA] * Zap unused nonlinear_to_linear(). CORE-7499
by akhaldi＠svn.reactos.org 07 Sep '14

07 Sep '14

Author: akhaldi Date: Sun Sep 7 11:52:18 2014 New Revision: 64057 URL: http://svn.reactos.org/svn/reactos?rev=64057&view=rev Log: [OPENGL32/MESA] * Zap unused nonlinear_to_linear(). CORE-7499 Modified: trunk/reactos/dll/opengl/mesa/main/format_unpack.c Modified: trunk/reactos/dll/opengl/mesa/main/format_unpack.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/opengl/mesa/main/forma… ============================================================================== --- trunk/reactos/dll/opengl/mesa/main/format_unpack.c [iso-8859-1] (original) +++ trunk/reactos/dll/opengl/mesa/main/format_unpack.c [iso-8859-1] Sun Sep 7 11:52:18 2014 @@ -36,35 +36,6 @@ #define EXPAND_5_8(X) ( ((X) << 3) | ((X) >> 2) ) #define EXPAND_6_8(X) ( ((X) << 2) | ((X) >> 4) ) - - -/** - * Convert an 8-bit sRGB value from non-linear space to a - * linear RGB value in [0, 1]. - * Implemented with a 256-entry lookup table. - */ -static inline GLfloat -nonlinear_to_linear(GLubyte cs8) -{ - static GLfloat table[256]; - static GLboolean tableReady = GL_FALSE; - if (!tableReady) { - /* compute lookup table now */ - GLuint i; - for (i = 0; i < 256; i++) { - const GLfloat cs = UBYTE_TO_FLOAT(i); - if (cs <= 0.04045) { - table[i] = cs / 12.92f; - } - else { - table[i] = (GLfloat) pow((cs + 0.055) / 1.055, 2.4); - } - } - tableReady = GL_TRUE; - } - return table[cs8]; -} - /**********************************************************************/ /* Unpack, returning GLfloat colors */

1 0

[cwittich] 64056: [crt] fix behavior of _sxprintf when a NULL buffer is supplied fixes ntdll:string winetest
by cwittich＠svn.reactos.org 07 Sep '14

07 Sep '14

Author: cwittich Date: Sun Sep 7 10:34:17 2014 New Revision: 64056 URL: http://svn.reactos.org/svn/reactos?rev=64056&view=rev Log: [crt] fix behavior of _sxprintf when a NULL buffer is supplied fixes ntdll:string winetest Modified: trunk/reactos/lib/sdk/crt/printf/_sxprintf.c trunk/reactos/lib/sdk/crt/printf/streamout.c Modified: trunk/reactos/lib/sdk/crt/printf/_sxprintf.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/sdk/crt/printf/_sxprin… ============================================================================== --- trunk/reactos/lib/sdk/crt/printf/_sxprintf.c [iso-8859-1] (original) +++ trunk/reactos/lib/sdk/crt/printf/_sxprintf.c [iso-8859-1] Sun Sep 7 10:34:17 2014 @@ -57,12 +57,6 @@ int result; FILE stream; - /* Check trivial case */ - if ((buffer == NULL) && (count == 0) && (sizeOfBuffer == 0)) - { - return 0; - } - #if IS_SECAPI /* Validate parameters */ if (MSVCRT_CHECK_PMT(((buffer == NULL) || (format == NULL) || (sizeOfBuffer <= 0)))) @@ -118,7 +112,8 @@ buffer[result] = _T('\0'); #else /* Only zero terminate if there is enough space left */ - if (stream._cnt >= sizeof(TCHAR)) *(TCHAR*)stream._ptr = _T('\0'); + if ((stream._cnt >= sizeof(TCHAR)) && (stream._ptr)) + *(TCHAR*)stream._ptr = _T('\0'); #endif return result; Modified: trunk/reactos/lib/sdk/crt/printf/streamout.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/sdk/crt/printf/streamo… ============================================================================== --- trunk/reactos/lib/sdk/crt/printf/streamout.c [iso-8859-1] (original) +++ trunk/reactos/lib/sdk/crt/printf/streamout.c [iso-8859-1] Sun Sep 7 10:34:17 2014 @@ -227,6 +227,9 @@ int streamout_char(FILE *stream, int chr) { + if ((stream->_flag & _IOSTRG) && (!stream->_ptr)) + return 1; + #if defined(_USER32_WSPRINTF) || defined(_LIBCNT_) /* Check if the buffer is full */ if (stream->_cnt < sizeof(TCHAR))

1 0

[hbelusca] 64055: [ROSAUTOTEST] Initialize hStdInput to the standard input handle, and hStdError to the output pipe, instead of keeping these handles NULL. See the details why this is important in ...
by hbelusca＠svn.reactos.org 07 Sep '14

07 Sep '14

Author: hbelusca Date: Sun Sep 7 00:34:26 2014 New Revision: 64055 URL: http://svn.reactos.org/svn/reactos?rev=64055&view=rev Log: [ROSAUTOTEST] Initialize hStdInput to the standard input handle, and hStdError to the output pipe, instead of keeping these handles NULL. See the details why this is important in the Jira report ROSTESTS-140. ROSTESTS-140 #resolve #comment Fixed. Modified: trunk/rostests/rosautotest/CWineTest.cpp Modified: trunk/rostests/rosautotest/CWineTest.cpp URL: http://svn.reactos.org/svn/reactos/trunk/rostests/rosautotest/CWineTest.cpp… ============================================================================== --- trunk/rostests/rosautotest/CWineTest.cpp [iso-8859-1] (original) +++ trunk/rostests/rosautotest/CWineTest.cpp [iso-8859-1] Sun Sep 7 00:34:26 2014 @@ -342,7 +342,9 @@ m_StartupInfo.cb = sizeof(m_StartupInfo); m_StartupInfo.dwFlags = STARTF_USESTDHANDLES; + m_StartupInfo.hStdInput = GetStdHandle(STD_INPUT_HANDLE); m_StartupInfo.hStdOutput = m_hWritePipe; + m_StartupInfo.hStdError = m_hWritePipe; /* The virtual test list is of course faster, so it should be preferred over the journaled one.

1 0

[jimtabor] 64054: [Win32k] - Apply band-aid patch from CORE-8506. Problem still persists, how did a bad region get plugged into the DCE structure?
by jimtabor＠svn.reactos.org 06 Sep '14

06 Sep '14

Author: jimtabor Date: Sat Sep 6 17:47:45 2014 New Revision: 64054 URL: http://svn.reactos.org/svn/reactos?rev=64054&view=rev Log: [Win32k] - Apply band-aid patch from CORE-8506. Problem still persists, how did a bad region get plugged into the DCE structure? Modified: trunk/reactos/win32ss/user/ntuser/windc.c Modified: trunk/reactos/win32ss/user/ntuser/windc.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/ntuser/windc.… ============================================================================== --- trunk/reactos/win32ss/user/ntuser/windc.c [iso-8859-1] (original) +++ trunk/reactos/win32ss/user/ntuser/windc.c [iso-8859-1] Sat Sep 6 17:47:45 2014 @@ -215,7 +215,7 @@ PWND Parent; Parent = Window->spwndParent; - if(!Parent) + if (!Parent) { RgnVisible = NULL; goto noparent; @@ -252,15 +252,19 @@ noparent: if (Flags & DCX_INTERSECTRGN) { - if(Dce->hrgnClip != NULL) - { - PREGION RgnClip = REGION_LockRgn(Dce->hrgnClip); + PREGION RgnClip = NULL; + + if (Dce->hrgnClip != NULL) + RgnClip = REGION_LockRgn(Dce->hrgnClip); + + if (RgnClip) + { IntGdiCombineRgn(RgnVisible, RgnVisible, RgnClip, RGN_AND); REGION_UnlockRgn(RgnClip); } else { - if(RgnVisible != NULL) + if (RgnVisible != NULL) { REGION_Delete(RgnVisible); }

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs