Ros-diffs

ros-diffs@reactos.org

81390 discussions

[tfaber] 63953: [FASTFAT] - Do not use direct I/O since it limits read/write operations to 64 MB CORE-8410 #resolve
by tfaber＠svn.reactos.org 26 Aug '14

26 Aug '14

Author: tfaber Date: Tue Aug 26 13:41:57 2014 New Revision: 63953 URL: http://svn.reactos.org/svn/reactos?rev=63953&view=rev Log: [FASTFAT] - Do not use direct I/O since it limits read/write operations to 64 MB CORE-8410 #resolve Modified: trunk/reactos/drivers/filesystems/fastfat/fsctl.c Modified: trunk/reactos/drivers/filesystems/fastfat/fsctl.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/fastfa… ============================================================================== --- trunk/reactos/drivers/filesystems/fastfat/fsctl.c [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/fastfat/fsctl.c [iso-8859-1] Tue Aug 26 13:41:57 2014 @@ -442,8 +442,7 @@ goto ByeBye; } - DeviceObject->Flags = DeviceObject->Flags | DO_DIRECT_IO; - DeviceExt = (PVOID) DeviceObject->DeviceExtension; + DeviceExt = DeviceObject->DeviceExtension; RtlZeroMemory(DeviceExt, ROUND_UP(sizeof(DEVICE_EXTENSION), sizeof(ULONG)) + sizeof(HASHENTRY*) * HashTableSize); DeviceExt->FcbHashTable = (HASHENTRY**)((ULONG_PTR)DeviceExt + ROUND_UP(sizeof(DEVICE_EXTENSION), sizeof(ULONG))); DeviceExt->HashTableSize = HashTableSize;

1 0

[tfaber] 63952: [NTOS:MM] - Assert correct pool entry alignment in ExFreePoolWithTag
by tfaber＠svn.reactos.org 26 Aug '14

26 Aug '14

Author: tfaber Date: Tue Aug 26 12:47:02 2014 New Revision: 63952 URL: http://svn.reactos.org/svn/reactos?rev=63952&view=rev Log: [NTOS:MM] - Assert correct pool entry alignment in ExFreePoolWithTag Modified: trunk/reactos/ntoskrnl/mm/ARM3/expool.c Modified: trunk/reactos/ntoskrnl/mm/ARM3/expool.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/ARM3/expool.c?… ============================================================================== --- trunk/reactos/ntoskrnl/mm/ARM3/expool.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/mm/ARM3/expool.c [iso-8859-1] Tue Aug 26 12:47:02 2014 @@ -2220,6 +2220,7 @@ // Entry = P; Entry--; + ASSERT((ULONG_PTR)Entry % POOL_BLOCK_SIZE == 0); // // Get the size of the entry, and it's pool type, then load the descriptor

1 0

[tfaber] 63951: [CMLIB] - Fix format specifiers to work in host-tools
by tfaber＠svn.reactos.org 26 Aug '14

26 Aug '14

Author: tfaber Date: Tue Aug 26 11:29:15 2014 New Revision: 63951 URL: http://svn.reactos.org/svn/reactos?rev=63951&view=rev Log: [CMLIB] - Fix format specifiers to work in host-tools Modified: trunk/reactos/lib/cmlib/hiveinit.c Modified: trunk/reactos/lib/cmlib/hiveinit.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/cmlib/hiveinit.c?rev=6… ============================================================================== --- trunk/reactos/lib/cmlib/hiveinit.c [iso-8859-1] (original) +++ trunk/reactos/lib/cmlib/hiveinit.c [iso-8859-1] Tue Aug 26 11:29:15 2014 @@ -210,8 +210,8 @@ if (Bin->Signature != HV_BIN_SIGNATURE || (Bin->Size % HV_BLOCK_SIZE) != 0) { - DPRINT1("Invalid bin at BlockIndex %Iu, Signature 0x%lx, Size 0x%lx\n", - BlockIndex, Bin->Signature, Bin->Size); + DPRINT1("Invalid bin at BlockIndex %lu, Signature 0x%x, Size 0x%x\n", + (unsigned long)BlockIndex, (unsigned)Bin->Signature, (unsigned)Bin->Size); Hive->Free(Hive->BaseBlock, 0); Hive->Free(Hive->Storage[Stable].BlockList, 0); return STATUS_REGISTRY_CORRUPT;

1 0

[tfaber] 63950: [CMLIB] - Print a debug message if bin validation fails in HvpInitializeMemoryHive.
by tfaber＠svn.reactos.org 26 Aug '14

26 Aug '14

Author: tfaber Date: Tue Aug 26 10:53:21 2014 New Revision: 63950 URL: http://svn.reactos.org/svn/reactos?rev=63950&view=rev Log: [CMLIB] - Print a debug message if bin validation fails in HvpInitializeMemoryHive. Modified: trunk/reactos/lib/cmlib/hiveinit.c Modified: trunk/reactos/lib/cmlib/hiveinit.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/cmlib/hiveinit.c?rev=6… ============================================================================== --- trunk/reactos/lib/cmlib/hiveinit.c [iso-8859-1] (original) +++ trunk/reactos/lib/cmlib/hiveinit.c [iso-8859-1] Tue Aug 26 10:53:21 2014 @@ -210,6 +210,8 @@ if (Bin->Signature != HV_BIN_SIGNATURE || (Bin->Size % HV_BLOCK_SIZE) != 0) { + DPRINT1("Invalid bin at BlockIndex %Iu, Signature 0x%lx, Size 0x%lx\n", + BlockIndex, Bin->Signature, Bin->Size); Hive->Free(Hive->BaseBlock, 0); Hive->Free(Hive->Storage[Stable].BlockList, 0); return STATUS_REGISTRY_CORRUPT; @@ -506,7 +508,7 @@ } /* Check for previous damage */ - if (Status == STATUS_REGISTRY_RECOVERED) ASSERT(FALSE); + ASSERT(Status != STATUS_REGISTRY_RECOVERED); break; }

1 0

[tfaber] 63949: [NTOS:CM] - Correctly delete resource in failure cases of CmpInitializeHive. Fixes pool corruption when trying to load an invalid hive file.
by tfaber＠svn.reactos.org 26 Aug '14

26 Aug '14

Author: tfaber Date: Tue Aug 26 10:49:38 2014 New Revision: 63949 URL: http://svn.reactos.org/svn/reactos?rev=63949&view=rev Log: [NTOS:CM] - Correctly delete resource in failure cases of CmpInitializeHive. Fixes pool corruption when trying to load an invalid hive file. Modified: trunk/reactos/ntoskrnl/config/cminit.c Modified: trunk/reactos/ntoskrnl/config/cminit.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/config/cminit.c?r… ============================================================================== --- trunk/reactos/ntoskrnl/config/cminit.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/config/cminit.c [iso-8859-1] Tue Aug 26 10:49:38 2014 @@ -201,6 +201,7 @@ if (!NT_SUCCESS(Status)) { /* Cleanup allocations and fail */ + ExDeleteResourceLite(Hive->FlusherLock); ExFreePoolWithTag(Hive->FlusherLock, TAG_CM); ExFreePoolWithTag(Hive->ViewLock, TAG_CM); ExFreePoolWithTag(Hive, TAG_CM); @@ -218,6 +219,7 @@ if (CheckStatus != 0) { /* Cleanup allocations and fail */ + ExDeleteResourceLite(Hive->FlusherLock); ExFreePoolWithTag(Hive->FlusherLock, TAG_CM); ExFreePoolWithTag(Hive->ViewLock, TAG_CM); ExFreePoolWithTag(Hive, TAG_CM);

1 0

[tfaber] 63948: [NTOS:MM] - Fix broken assert mistakenly added. By Jérôme, delayed at my request. Thanks.
by tfaber＠svn.reactos.org 26 Aug '14

26 Aug '14

Author: tfaber Date: Tue Aug 26 09:22:29 2014 New Revision: 63948 URL: http://svn.reactos.org/svn/reactos?rev=63948&view=rev Log: [NTOS:MM] - Fix broken assert mistakenly added. By Jérôme, delayed at my request. Thanks. Modified: trunk/reactos/ntoskrnl/mm/ARM3/virtual.c Modified: trunk/reactos/ntoskrnl/mm/ARM3/virtual.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/ARM3/virtual.c… ============================================================================== --- trunk/reactos/ntoskrnl/mm/ARM3/virtual.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/mm/ARM3/virtual.c [iso-8859-1] Tue Aug 26 09:22:29 2014 @@ -409,7 +409,7 @@ { /* Prototype and paged out PTEs not supported yet */ ASSERT(TempPte.u.Soft.Prototype == 0); - ASSERT(TempPte.u.Soft.PageFileHigh == 0); + ASSERT((TempPte.u.Soft.PageFileHigh == 0) || (TempPte.u.Soft.Transition == 1)); if (TempPte.u.Soft.Transition) {

1 0

[jgardou] 63947: [NTOS/MM] - Bring back PTE frame refcounting when serving a prototype PTE page fault. - Fix a bug in MiDeletePte where the said PTE frame was not unshared. - Improve transitional P...
by jgardou＠svn.reactos.org 25 Aug '14

25 Aug '14

Author: jgardou Date: Mon Aug 25 12:33:49 2014 New Revision: 63947 URL: http://svn.reactos.org/svn/reactos?rev=63947&view=rev Log: [NTOS/MM] - Bring back PTE frame refcounting when serving a prototype PTE page fault. - Fix a bug in MiDeletePte where the said PTE frame was not unshared. - Improve transitional PTEs deletion (will be needed for future work). Do not always trust the comments stating that "strange RosMm code broke everything" Modified: trunk/reactos/ntoskrnl/mm/ARM3/pagfault.c trunk/reactos/ntoskrnl/mm/ARM3/virtual.c Modified: trunk/reactos/ntoskrnl/mm/ARM3/pagfault.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/ARM3/pagfault.… ============================================================================== --- trunk/reactos/ntoskrnl/mm/ARM3/pagfault.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/mm/ARM3/pagfault.c [iso-8859-1] Mon Aug 25 12:33:49 2014 @@ -709,12 +709,9 @@ Pfn1->u3.e1.PrototypePte = 1; /* Increment the share count for the page table */ - // FIXME: This doesn't work because we seem to bump the sharecount to two, and MiDeletePte gets annoyed and ASSERTs. - // This could be beause MiDeletePte is now being called from strange code in Rosmm PageTablePte = MiAddressToPte(PointerPte); Pfn2 = MiGetPfnEntry(PageTablePte->u.Hard.PageFrameNumber); - //Pfn2->u2.ShareCount++; - DBG_UNREFERENCED_LOCAL_VARIABLE(Pfn2); + Pfn2->u2.ShareCount++; /* Check where we should be getting the protection information from */ if (PointerPte->u.Soft.PageFileHigh == MI_PTE_LOOKUP_NEEDED) Modified: trunk/reactos/ntoskrnl/mm/ARM3/virtual.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/ARM3/virtual.c… ============================================================================== --- trunk/reactos/ntoskrnl/mm/ARM3/virtual.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/mm/ARM3/virtual.c [iso-8859-1] Mon Aug 25 12:33:49 2014 @@ -407,15 +407,17 @@ /* See if the PTE is valid */ if (TempPte.u.Hard.Valid == 0) { - /* Prototype PTEs not supported yet */ + /* Prototype and paged out PTEs not supported yet */ ASSERT(TempPte.u.Soft.Prototype == 0); + ASSERT(TempPte.u.Soft.PageFileHigh == 0); + if (TempPte.u.Soft.Transition) { /* Get the PFN entry */ PageFrameIndex = PFN_FROM_PTE(&TempPte); Pfn1 = MiGetPfnEntry(PageFrameIndex); - DPRINT1("Pte %p is transitional!\n", PointerPte); + DPRINT("Pte %p is transitional!\n", PointerPte); /* Destroy the PTE */ MI_ERASE_PTE(PointerPte); @@ -433,12 +435,14 @@ /* And it should be in standby or modified list */ ASSERT((Pfn1->u3.e1.PageLocation == ModifiedPageList) || (Pfn1->u3.e1.PageLocation == StandbyPageList)); - /* Unlink it and put it back in free list */ + /* Unlink it and temporarily mark it as active */ MiUnlinkPageFromList(Pfn1); + Pfn1->u3.e2.ReferenceCount++; Pfn1->u3.e1.PageLocation = ActiveAndValid; - /* Bring it back into the free list */ - MiInsertPageInFreeList(PageFrameIndex); + /* This will put it back in free list and clean properly up */ + MI_SET_PFN_DELETED(Pfn1); + MiDecrementReferenceCount(Pfn1, PageFrameIndex); } return; } @@ -470,6 +474,11 @@ #if (_MI_PAGING_LEVELS == 2) } #endif + /* Drop the share count on the page table */ + PointerPde = MiPteToPde(PointerPte); + MiDecrementShareCount(MiGetPfnEntry(PointerPde->u.Hard.PageFrameNumber), + PointerPde->u.Hard.PageFrameNumber); + /* Drop the share count */ MiDecrementShareCount(Pfn1, PageFrameIndex);

1 0

[jgardou] 63946: [WIN32K] - Addendum to r63933: Pass absolute value of the font width to freetype. CORE-4657 Somehow got lost in the number of attached files. Spotted by Thomas Faber
by jgardou＠svn.reactos.org 25 Aug '14

25 Aug '14

Author: jgardou Date: Mon Aug 25 09:57:27 2014 New Revision: 63946 URL: http://svn.reactos.org/svn/reactos?rev=63946&view=rev Log: [WIN32K] - Addendum to r63933: Pass absolute value of the font width to freetype. CORE-4657 Somehow got lost in the number of attached files. Spotted by Thomas Faber Modified: trunk/reactos/win32ss/gdi/ntgdi/freetype.c Modified: trunk/reactos/win32ss/gdi/ntgdi/freetype.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/gdi/ntgdi/freetype… ============================================================================== --- trunk/reactos/win32ss/gdi/ntgdi/freetype.c [iso-8859-1] (original) +++ trunk/reactos/win32ss/gdi/ntgdi/freetype.c [iso-8859-1] Mon Aug 25 09:57:27 2014 @@ -1601,7 +1601,7 @@ } FT_Set_Pixel_Sizes(ft_face, - TextObj->logfont.elfEnumLogfontEx.elfLogFont.lfWidth, + abs(TextObj->logfont.elfEnumLogfontEx.elfLogFont.lfWidth), /* FIXME: Should set character height if neg */ (TextObj->logfont.elfEnumLogfontEx.elfLogFont.lfHeight == 0 ? dc->ppdev->devinfo.lfDefaultFont.lfHeight : abs(TextObj->logfont.elfEnumLogfontEx.elfLogFont.lfHeight)));

1 0

[jgardou] 63945: [SCSIPORT] - Use kernel handles instead of process handles
by jgardou＠svn.reactos.org 24 Aug '14

24 Aug '14

Author: jgardou Date: Sun Aug 24 19:49:42 2014 New Revision: 63945 URL: http://svn.reactos.org/svn/reactos?rev=63945&view=rev Log: [SCSIPORT] - Use kernel handles instead of process handles Modified: trunk/reactos/drivers/storage/scsiport/scsiport.c Modified: trunk/reactos/drivers/storage/scsiport/scsiport.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/storage/scsiport/s… ============================================================================== --- trunk/reactos/drivers/storage/scsiport/scsiport.c [iso-8859-1] (original) +++ trunk/reactos/drivers/storage/scsiport/scsiport.c [iso-8859-1] Sun Aug 24 19:49:42 2014 @@ -5296,7 +5296,7 @@ L"\\Registry\\Machine\\Hardware\\DeviceMap\\Scsi"); InitializeObjectAttributes(&ObjectAttributes, &KeyName, - OBJ_CASE_INSENSITIVE | OBJ_OPENIF, + OBJ_CASE_INSENSITIVE | OBJ_OPENIF | OBJ_KERNEL_HANDLE, 0, NULL); Status = ZwCreateKey(&ScsiKey, @@ -5323,7 +5323,7 @@ NameBuffer); InitializeObjectAttributes(&ObjectAttributes, &KeyName, - 0, + OBJ_KERNEL_HANDLE, ScsiKey, NULL); Status = ZwCreateKey(&ScsiPortKey,

1 0

[hbelusca] 63944: Fix the fix of revision 63943. Noticed by Thomas Faber. CORE-8150 #comment Indeed, do not confuse 'l' (lowercase L) with 'I' (uppercase i)!
by hbelusca＠svn.reactos.org 24 Aug '14

24 Aug '14

Author: hbelusca Date: Sun Aug 24 19:32:54 2014 New Revision: 63944 URL: http://svn.reactos.org/svn/reactos?rev=63944&view=rev Log: Fix the fix of revision 63943. Noticed by Thomas Faber. CORE-8150 #comment Indeed, do not confuse 'l' (lowercase L) with 'I' (uppercase i)! Modified: trunk/reactos/dll/cpl/desk/screensaver.c Modified: trunk/reactos/dll/cpl/desk/screensaver.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/cpl/desk/screensaver.c… ============================================================================== --- trunk/reactos/dll/cpl/desk/screensaver.c [iso-8859-1] (original) +++ trunk/reactos/dll/cpl/desk/screensaver.c [iso-8859-1] Sun Aug 24 19:32:54 2014 @@ -123,7 +123,7 @@ if (pData->Selection > 0) { _stprintf(szCmdline, - _T("%s /p %lu"), + _T("%s /p %Iu"), pData->ScreenSaverItems[pData->Selection].szFilename, (ULONG_PTR)hPreview); @@ -199,7 +199,7 @@ return; _stprintf(szCmdline, - _T("%s /c:%lu"), + _T("%s /c:%Iu"), pData->ScreenSaverItems[pData->Selection].szFilename, (ULONG_PTR)hwndDlg);

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs