Ros-diffs

ros-diffs@reactos.org

81390 discussions

[tfaber] 63833: [NTOS:OB] - Mark object types as not having ObjectCreateInfo on creation. Otherwise ObpObjectType's TypeList gets corrupted when a handle to an object type is created (as kmtest:ObT...
by tfaber＠svn.reactos.org 07 Aug '14

07 Aug '14

Author: tfaber Date: Thu Aug 7 13:02:59 2014 New Revision: 63833 URL: http://svn.reactos.org/svn/reactos?rev=63833&view=rev Log: [NTOS:OB] - Mark object types as not having ObjectCreateInfo on creation. Otherwise ObpObjectType's TypeList gets corrupted when a handle to an object type is created (as kmtest:ObTypes does) and ObpIncrementHandleCount tries to insert the list entry a second time. CORE-8423 #resolve Modified: trunk/reactos/ntoskrnl/ob/oblife.c Modified: trunk/reactos/ntoskrnl/ob/oblife.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ob/oblife.c?rev=6… ============================================================================== --- trunk/reactos/ntoskrnl/ob/oblife.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/ob/oblife.c [iso-8859-1] Thu Aug 7 13:02:59 2014 @@ -1231,8 +1231,15 @@ /* Get creator info and insert it into the type list */ CreatorInfo = OBJECT_HEADER_TO_CREATOR_INFO(Header); - if (CreatorInfo) InsertTailList(&ObpTypeObjectType->TypeList, - &CreatorInfo->TypeList); + if (CreatorInfo) + { + InsertTailList(&ObpTypeObjectType->TypeList, + &CreatorInfo->TypeList); + + /* CORE-8423: Avoid inserting this a second time if someone creates a + * handle to the object type (bug in Windows 2003) */ + Header->Flags &= ~OB_FLAG_CREATE_INFO; + } /* Set the index and the entry into the object type array */ LocalObjectType->Index = ObpTypeObjectType->TotalNumberOfObjects;

1 0

[hbelusca] 63832: Sync with trunk r63831.
by hbelusca＠svn.reactos.org 07 Aug '14

07 Aug '14

Author: hbelusca Date: Thu Aug 7 12:54:03 2014 New Revision: 63832 URL: http://svn.reactos.org/svn/reactos?rev=63832&view=rev Log: Sync with trunk r63831. Added: branches/condrv_restructure/dll/win32/cards/COPYING - copied unchanged from r63831, trunk/reactos/dll/win32/cards/COPYING Modified: branches/condrv_restructure/ (props changed) branches/condrv_restructure/CMakeLists.txt branches/condrv_restructure/base/applications/calc/lang/tr-TR.rc branches/condrv_restructure/base/applications/games/spider/spider.cpp branches/condrv_restructure/base/applications/games/spider/spider.h branches/condrv_restructure/base/applications/games/spider/spigame.cpp branches/condrv_restructure/base/applications/mplay32/lang/tr-TR.rc branches/condrv_restructure/base/applications/mscutils/servman/lang/tr-TR.rc branches/condrv_restructure/base/applications/mspaint/lang/tr-TR.rc branches/condrv_restructure/base/applications/notepad/lang/tr-TR.rc branches/condrv_restructure/base/applications/rapps/lang/tr-TR.rc branches/condrv_restructure/base/applications/rapps/rapps/ghostscript.txt branches/condrv_restructure/base/applications/rapps/rapps/ghostview.txt branches/condrv_restructure/base/applications/rapps/rapps/miktex.txt branches/condrv_restructure/base/applications/rapps/rapps/net20.txt branches/condrv_restructure/base/applications/rapps/rapps/nirlauncher.txt branches/condrv_restructure/base/applications/rapps/rapps/qmmp.txt branches/condrv_restructure/base/applications/rapps/rapps/smplayer.txt branches/condrv_restructure/base/applications/regedit/lang/tr-TR.rc branches/condrv_restructure/base/applications/screensavers/logon/lang/tr-TR.rc branches/condrv_restructure/base/applications/sndrec32/lang/tr-TR.rc branches/condrv_restructure/base/applications/taskmgr/lang/tr-TR.rc branches/condrv_restructure/base/applications/winhlp32/lang/Tr.rc branches/condrv_restructure/base/applications/wordpad/lang/Tr.rc branches/condrv_restructure/base/setup/usetup/lang/tr-TR.h branches/condrv_restructure/base/shell/explorer/CMakeLists.txt branches/condrv_restructure/dll/cpl/access/lang/tr-TR.rc branches/condrv_restructure/dll/cpl/desk/lang/tr-TR.rc branches/condrv_restructure/dll/cpl/input/lang/tr-TR.rc branches/condrv_restructure/dll/cpl/main/lang/tr-TR.rc branches/condrv_restructure/dll/cpl/mmsys/lang/tr-TR.rc branches/condrv_restructure/dll/cpl/powercfg/lang/tr-TR.rc branches/condrv_restructure/dll/cpl/sysdm/lang/tr-TR.rc branches/condrv_restructure/dll/cpl/wined3dcfg/lang/cs-CZ.rc branches/condrv_restructure/dll/cpl/wined3dcfg/lang/de-DE.rc branches/condrv_restructure/dll/cpl/wined3dcfg/lang/en-US.rc branches/condrv_restructure/dll/cpl/wined3dcfg/lang/he-IL.rc branches/condrv_restructure/dll/cpl/wined3dcfg/lang/pl-PL.rc branches/condrv_restructure/dll/cpl/wined3dcfg/lang/ro-RO.rc branches/condrv_restructure/dll/cpl/wined3dcfg/lang/sq-AL.rc branches/condrv_restructure/dll/cpl/wined3dcfg/lang/tr-TR.rc branches/condrv_restructure/dll/win32/avifil32/lang/avifile_Tr.rc branches/condrv_restructure/dll/win32/browseui/CMakeLists.txt branches/condrv_restructure/dll/win32/cards/res/bavarian/Ruecken1.bmp branches/condrv_restructure/dll/win32/cards/res/bavarian/Ruecken11.bmp branches/condrv_restructure/dll/win32/cards/res/bavarian/Ruecken12.bmp branches/condrv_restructure/dll/win32/cards/res/bavarian/Ruecken3.bmp branches/condrv_restructure/dll/win32/cards/res/bavarian/Ruecken4.bmp branches/condrv_restructure/dll/win32/cards/res/bavarian/Ruecken6.bmp branches/condrv_restructure/dll/win32/cards/res/bavarian/Ruecken8.bmp branches/condrv_restructure/dll/win32/cards/res/default/Background_6.bmp branches/condrv_restructure/dll/win32/cards/res/default/Clubs_Ace.bmp branches/condrv_restructure/dll/win32/cards/res/default/Clubs_Eight.bmp branches/condrv_restructure/dll/win32/cards/res/default/Clubs_Five.bmp branches/condrv_restructure/dll/win32/cards/res/default/Clubs_Four.bmp branches/condrv_restructure/dll/win32/cards/res/default/Clubs_Jack.bmp branches/condrv_restructure/dll/win32/cards/res/default/Clubs_King.bmp branches/condrv_restructure/dll/win32/cards/res/default/Clubs_Nine.bmp branches/condrv_restructure/dll/win32/cards/res/default/Clubs_Queen.bmp branches/condrv_restructure/dll/win32/cards/res/default/Clubs_Seven.bmp branches/condrv_restructure/dll/win32/cards/res/default/Clubs_Six.bmp branches/condrv_restructure/dll/win32/cards/res/default/Clubs_Ten.bmp branches/condrv_restructure/dll/win32/cards/res/default/Clubs_Three.bmp branches/condrv_restructure/dll/win32/cards/res/default/Clubs_Two.bmp branches/condrv_restructure/dll/win32/cards/res/default/Diamonds_Ace.bmp branches/condrv_restructure/dll/win32/cards/res/default/Diamonds_Eight.bmp branches/condrv_restructure/dll/win32/cards/res/default/Diamonds_Five.bmp branches/condrv_restructure/dll/win32/cards/res/default/Diamonds_Four.bmp branches/condrv_restructure/dll/win32/cards/res/default/Diamonds_Jack.bmp branches/condrv_restructure/dll/win32/cards/res/default/Diamonds_King.bmp branches/condrv_restructure/dll/win32/cards/res/default/Diamonds_Nine.bmp branches/condrv_restructure/dll/win32/cards/res/default/Diamonds_Queen.bmp branches/condrv_restructure/dll/win32/cards/res/default/Diamonds_Seven.bmp branches/condrv_restructure/dll/win32/cards/res/default/Diamonds_Six.bmp branches/condrv_restructure/dll/win32/cards/res/default/Diamonds_Ten.bmp branches/condrv_restructure/dll/win32/cards/res/default/Diamonds_Three.bmp branches/condrv_restructure/dll/win32/cards/res/default/Diamonds_Two.bmp branches/condrv_restructure/dll/win32/cards/res/default/Hearts_Ace.bmp branches/condrv_restructure/dll/win32/cards/res/default/Hearts_Eight.bmp branches/condrv_restructure/dll/win32/cards/res/default/Hearts_Five.bmp branches/condrv_restructure/dll/win32/cards/res/default/Hearts_Four.bmp branches/condrv_restructure/dll/win32/cards/res/default/Hearts_Jack.bmp branches/condrv_restructure/dll/win32/cards/res/default/Hearts_King.bmp branches/condrv_restructure/dll/win32/cards/res/default/Hearts_Nine.bmp branches/condrv_restructure/dll/win32/cards/res/default/Hearts_Queen.bmp branches/condrv_restructure/dll/win32/cards/res/default/Hearts_Seven.bmp branches/condrv_restructure/dll/win32/cards/res/default/Hearts_Six.bmp branches/condrv_restructure/dll/win32/cards/res/default/Hearts_Ten.bmp branches/condrv_restructure/dll/win32/cards/res/default/Hearts_Three.bmp branches/condrv_restructure/dll/win32/cards/res/default/Hearts_Two.bmp branches/condrv_restructure/dll/win32/cards/res/default/Spades_Ace.bmp branches/condrv_restructure/dll/win32/cards/res/default/Spades_Eight.bmp branches/condrv_restructure/dll/win32/cards/res/default/Spades_Five.bmp branches/condrv_restructure/dll/win32/cards/res/default/Spades_Four.bmp branches/condrv_restructure/dll/win32/cards/res/default/Spades_Jack.bmp branches/condrv_restructure/dll/win32/cards/res/default/Spades_King.bmp branches/condrv_restructure/dll/win32/cards/res/default/Spades_Nine.bmp branches/condrv_restructure/dll/win32/cards/res/default/Spades_Queen.bmp branches/condrv_restructure/dll/win32/cards/res/default/Spades_Seven.bmp branches/condrv_restructure/dll/win32/cards/res/default/Spades_Six.bmp branches/condrv_restructure/dll/win32/cards/res/default/Spades_Ten.bmp branches/condrv_restructure/dll/win32/cards/res/default/Spades_Three.bmp branches/condrv_restructure/dll/win32/cards/res/default/Spades_Two.bmp branches/condrv_restructure/dll/win32/comctl32/lang/comctl_Tr.rc branches/condrv_restructure/dll/win32/comctl32/rsrc.rc branches/condrv_restructure/dll/win32/comdlg32/lang/cdlg_Tr.rc branches/condrv_restructure/dll/win32/comdlg32/rsrc.rc branches/condrv_restructure/dll/win32/credui/lang/credui_Tr.rc branches/condrv_restructure/dll/win32/crypt32/lang/crypt32_Tr.rc branches/condrv_restructure/dll/win32/cryptdlg/lang/cryptdlg_Tr.rc branches/condrv_restructure/dll/win32/cryptui/lang/cryptui_Tr.rc branches/condrv_restructure/dll/win32/devmgr/lang/tr-TR.rc branches/condrv_restructure/dll/win32/getuname/getuname.rc branches/condrv_restructure/dll/win32/jscript/lang/jscript_Tr.rc branches/condrv_restructure/dll/win32/kernel32/winnls/lang/tr-TR.rc branches/condrv_restructure/dll/win32/localui/lang/ui_Tr.rc branches/condrv_restructure/dll/win32/msgina/lang/tr-TR.rc branches/condrv_restructure/dll/win32/msvfw32/lang/msvfw32_Tr.rc branches/condrv_restructure/dll/win32/oledlg/lang/oledlg_Tr.rc branches/condrv_restructure/drivers/filesystems/npfs/datasup.c branches/condrv_restructure/drivers/filesystems/npfs/readsup.c branches/condrv_restructure/drivers/filesystems/npfs/waitsup.c branches/condrv_restructure/include/ndk/mmtypes.h branches/condrv_restructure/include/reactos/libs/pseh/pseh3.h branches/condrv_restructure/lib/pseh/i386/pseh3.c branches/condrv_restructure/ntoskrnl/CMakeLists.txt branches/condrv_restructure/ntoskrnl/config/i386/cmhardwr.c branches/condrv_restructure/ntoskrnl/include/internal/i386/ke.h branches/condrv_restructure/ntoskrnl/include/internal/mm.h branches/condrv_restructure/ntoskrnl/io/iomgr/iofunc.c branches/condrv_restructure/ntoskrnl/mm/ARM3/miarm.h branches/condrv_restructure/ntoskrnl/mm/ARM3/pagfault.c branches/condrv_restructure/ntoskrnl/mm/ARM3/pfnlist.c branches/condrv_restructure/ntoskrnl/mm/ARM3/section.c branches/condrv_restructure/ntoskrnl/mm/ARM3/virtual.c branches/condrv_restructure/ntoskrnl/mm/balance.c branches/condrv_restructure/ntoskrnl/mm/pagefile.c branches/condrv_restructure/ntoskrnl/mm/section.c branches/condrv_restructure/ntoskrnl/ntkrnlmp/CMakeLists.txt branches/condrv_restructure/ntoskrnl/ob/oblife.c branches/condrv_restructure/win32ss/gdi/ntgdi/cliprgn.c branches/condrv_restructure/win32ss/user/ntuser/menu.c branches/condrv_restructure/win32ss/user/user32/misc/stubs.c [This mail would be too long, it was shortened to contain the URLs only.] Modified: branches/condrv_restructure/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/CMakeLists.t… Modified: branches/condrv_restructure/base/applications/calc/lang/tr-TR.rc URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/base/applica… Modified: branches/condrv_restructure/base/applications/games/spider/spider.cpp URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/base/applica… Modified: branches/condrv_restructure/base/applications/games/spider/spider.h URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/base/applica… Modified: branches/condrv_restructure/base/applications/games/spider/spigame.cpp URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/base/applica… Modified: branches/condrv_restructure/base/applications/mplay32/lang/tr-TR.rc URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/base/applica… Modified: branches/condrv_restructure/base/applications/mscutils/servman/lang/tr-TR.rc URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/base/applica… Modified: branches/condrv_restructure/base/applications/mspaint/lang/tr-TR.rc URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/base/applica… Modified: branches/condrv_restructure/base/applications/notepad/lang/tr-TR.rc URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/base/applica… Modified: branches/condrv_restructure/base/applications/rapps/lang/tr-TR.rc URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/base/applica… Modified: branches/condrv_restructure/base/applications/rapps/rapps/ghostscript.txt URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/base/applica… Modified: branches/condrv_restructure/base/applications/rapps/rapps/ghostview.txt URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/base/applica… Modified: branches/condrv_restructure/base/applications/rapps/rapps/miktex.txt URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/base/applica… Modified: branches/condrv_restructure/base/applications/rapps/rapps/net20.txt URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/base/applica… Modified: branches/condrv_restructure/base/applications/rapps/rapps/nirlauncher.txt URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/base/applica… Modified: branches/condrv_restructure/base/applications/rapps/rapps/qmmp.txt URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/base/applica… Modified: branches/condrv_restructure/base/applications/rapps/rapps/smplayer.txt URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/base/applica… Modified: branches/condrv_restructure/base/applications/regedit/lang/tr-TR.rc URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/base/applica… Modified: branches/condrv_restructure/base/applications/screensavers/logon/lang/tr-TR.rc URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/base/applica… Modified: branches/condrv_restructure/base/applications/sndrec32/lang/tr-TR.rc URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/base/applica… Modified: branches/condrv_restructure/base/applications/taskmgr/lang/tr-TR.rc URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/base/applica… Modified: branches/condrv_restructure/base/applications/winhlp32/lang/Tr.rc URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/base/applica… Modified: branches/condrv_restructure/base/applications/wordpad/lang/Tr.rc URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/base/applica… Modified: branches/condrv_restructure/base/setup/usetup/lang/tr-TR.h URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/base/setup/u… Modified: branches/condrv_restructure/base/shell/explorer/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/base/shell/e… Modified: branches/condrv_restructure/dll/cpl/access/lang/tr-TR.rc URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/dll/cpl/acce… Modified: branches/condrv_restructure/dll/cpl/desk/lang/tr-TR.rc URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/dll/cpl/desk… Modified: branches/condrv_restructure/dll/cpl/input/lang/tr-TR.rc URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/dll/cpl/inpu… Modified: branches/condrv_restructure/dll/cpl/main/lang/tr-TR.rc URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/dll/cpl/main… Modified: branches/condrv_restructure/dll/cpl/mmsys/lang/tr-TR.rc URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/dll/cpl/mmsy… Modified: branches/condrv_restructure/dll/cpl/powercfg/lang/tr-TR.rc URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/dll/cpl/powe… Modified: branches/condrv_restructure/dll/cpl/sysdm/lang/tr-TR.rc URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/dll/cpl/sysd… Modified: branches/condrv_restructure/dll/cpl/wined3dcfg/lang/cs-CZ.rc URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/dll/cpl/wine… Modified: branches/condrv_restructure/dll/cpl/wined3dcfg/lang/de-DE.rc URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/dll/cpl/wine… Modified: branches/condrv_restructure/dll/cpl/wined3dcfg/lang/en-US.rc URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/dll/cpl/wine… Modified: branches/condrv_restructure/dll/cpl/wined3dcfg/lang/he-IL.rc URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/dll/cpl/wine… Modified: branches/condrv_restructure/dll/cpl/wined3dcfg/lang/pl-PL.rc URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/dll/cpl/wine… Modified: branches/condrv_restructure/dll/cpl/wined3dcfg/lang/ro-RO.rc URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/dll/cpl/wine… Modified: branches/condrv_restructure/dll/cpl/wined3dcfg/lang/sq-AL.rc URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/dll/cpl/wine… Modified: branches/condrv_restructure/dll/cpl/wined3dcfg/lang/tr-TR.rc URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/dll/cpl/wine… Modified: branches/condrv_restructure/dll/win32/avifil32/lang/avifile_Tr.rc URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/dll/win32/av… Modified: branches/condrv_restructure/dll/win32/browseui/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/dll/win32/br… Modified: branches/condrv_restructure/dll/win32/cards/res/bavarian/Ruecken1.bmp URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/dll/win32/ca… Modified: branches/condrv_restructure/dll/win32/cards/res/bavarian/Ruecken11.bmp URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/dll/win32/ca… Modified: branches/condrv_restructure/dll/win32/cards/res/bavarian/Ruecken12.bmp URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/dll/win32/ca… Modified: branches/condrv_restructure/dll/win32/cards/res/bavarian/Ruecken3.bmp URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/dll/win32/ca… Modified: branches/condrv_restructure/dll/win32/cards/res/bavarian/Ruecken4.bmp URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/dll/win32/ca… Modified: branches/condrv_restructure/dll/win32/cards/res/bavarian/Ruecken6.bmp URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/dll/win32/ca… Modified: branches/condrv_restructure/dll/win32/cards/res/bavarian/Ruecken8.bmp URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/dll/win32/ca… Modified: branches/condrv_restructure/dll/win32/cards/res/default/Background_6.bmp URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/dll/win32/ca… Modified: branches/condrv_restructure/dll/win32/cards/res/default/Clubs_Ace.bmp URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/dll/win32/ca… Modified: branches/condrv_restructure/dll/win32/cards/res/default/Clubs_Eight.bmp URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/dll/win32/ca… Modified: branches/condrv_restructure/dll/win32/cards/res/default/Clubs_Five.bmp URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/dll/win32/ca… Modified: branches/condrv_restructure/dll/win32/cards/res/default/Clubs_Four.bmp URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/dll/win32/ca… Modified: branches/condrv_restructure/dll/win32/cards/res/default/Clubs_Jack.bmp URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/dll/win32/ca… Modified: branches/condrv_restructure/dll/win32/cards/res/default/Clubs_King.bmp URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/dll/win32/ca… Modified: branches/condrv_restructure/dll/win32/cards/res/default/Clubs_Nine.bmp URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/dll/win32/ca… Modified: branches/condrv_restructure/dll/win32/cards/res/default/Clubs_Queen.bmp URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/dll/win32/ca… Modified: branches/condrv_restructure/dll/win32/cards/res/default/Clubs_Seven.bmp URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/dll/win32/ca… Modified: branches/condrv_restructure/dll/win32/cards/res/default/Clubs_Six.bmp URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/dll/win32/ca… Modified: branches/condrv_restructure/dll/win32/cards/res/default/Clubs_Ten.bmp URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/dll/win32/ca… Modified: branches/condrv_restructure/dll/win32/cards/res/default/Clubs_Three.bmp URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/dll/win32/ca… Modified: branches/condrv_restructure/dll/win32/cards/res/default/Clubs_Two.bmp URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/dll/win32/ca… Modified: branches/condrv_restructure/dll/win32/cards/res/default/Diamonds_Ace.bmp URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/dll/win32/ca… Modified: branches/condrv_restructure/dll/win32/cards/res/default/Diamonds_Eight.bmp URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/dll/win32/ca… Modified: branches/condrv_restructure/dll/win32/cards/res/default/Diamonds_Five.bmp URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/dll/win32/ca… Modified: branches/condrv_restructure/dll/win32/cards/res/default/Diamonds_Four.bmp URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/dll/win32/ca… Modified: branches/condrv_restructure/dll/win32/cards/res/default/Diamonds_Jack.bmp URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/dll/win32/ca… Modified: branches/condrv_restructure/dll/win32/cards/res/default/Diamonds_King.bmp URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/dll/win32/ca… Modified: branches/condrv_restructure/dll/win32/cards/res/default/Diamonds_Nine.bmp URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/dll/win32/ca… Modified: branches/condrv_restructure/dll/win32/cards/res/default/Diamonds_Queen.bmp URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/dll/win32/ca… Modified: branches/condrv_restructure/dll/win32/cards/res/default/Diamonds_Seven.bmp URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/dll/win32/ca… Modified: branches/condrv_restructure/dll/win32/cards/res/default/Diamonds_Six.bmp URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/dll/win32/ca… Modified: branches/condrv_restructure/dll/win32/cards/res/default/Diamonds_Ten.bmp URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/dll/win32/ca… Modified: branches/condrv_restructure/dll/win32/cards/res/default/Diamonds_Three.bmp URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/dll/win32/ca… Modified: branches/condrv_restructure/dll/win32/cards/res/default/Diamonds_Two.bmp URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/dll/win32/ca… Modified: branches/condrv_restructure/dll/win32/cards/res/default/Hearts_Ace.bmp URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/dll/win32/ca… Modified: branches/condrv_restructure/dll/win32/cards/res/default/Hearts_Eight.bmp URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/dll/win32/ca… Modified: branches/condrv_restructure/dll/win32/cards/res/default/Hearts_Five.bmp URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/dll/win32/ca… Modified: branches/condrv_restructure/dll/win32/cards/res/default/Hearts_Four.bmp URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/dll/win32/ca… Modified: branches/condrv_restructure/dll/win32/cards/res/default/Hearts_Jack.bmp URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/dll/win32/ca… Modified: branches/condrv_restructure/dll/win32/cards/res/default/Hearts_King.bmp URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/dll/win32/ca… Modified: branches/condrv_restructure/dll/win32/cards/res/default/Hearts_Nine.bmp URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/dll/win32/ca… Modified: branches/condrv_restructure/dll/win32/cards/res/default/Hearts_Queen.bmp URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/dll/win32/ca… Modified: branches/condrv_restructure/dll/win32/cards/res/default/Hearts_Seven.bmp URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/dll/win32/ca… Modified: branches/condrv_restructure/dll/win32/cards/res/default/Hearts_Six.bmp URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/dll/win32/ca… Modified: branches/condrv_restructure/dll/win32/cards/res/default/Hearts_Ten.bmp URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/dll/win32/ca… Modified: branches/condrv_restructure/dll/win32/cards/res/default/Hearts_Three.bmp URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/dll/win32/ca… Modified: branches/condrv_restructure/dll/win32/cards/res/default/Hearts_Two.bmp URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/dll/win32/ca… Modified: branches/condrv_restructure/dll/win32/cards/res/default/Spades_Ace.bmp URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/dll/win32/ca… Modified: branches/condrv_restructure/dll/win32/cards/res/default/Spades_Eight.bmp URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/dll/win32/ca… Modified: branches/condrv_restructure/dll/win32/cards/res/default/Spades_Five.bmp URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/dll/win32/ca… Modified: branches/condrv_restructure/dll/win32/cards/res/default/Spades_Four.bmp URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/dll/win32/ca… Modified: branches/condrv_restructure/dll/win32/cards/res/default/Spades_Jack.bmp URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/dll/win32/ca… Modified: branches/condrv_restructure/dll/win32/cards/res/default/Spades_King.bmp URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/dll/win32/ca… Modified: branches/condrv_restructure/dll/win32/cards/res/default/Spades_Nine.bmp URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/dll/win32/ca… Modified: branches/condrv_restructure/dll/win32/cards/res/default/Spades_Queen.bmp URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/dll/win32/ca… Modified: branches/condrv_restructure/dll/win32/cards/res/default/Spades_Seven.bmp URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/dll/win32/ca… Modified: branches/condrv_restructure/dll/win32/cards/res/default/Spades_Six.bmp URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/dll/win32/ca… Modified: branches/condrv_restructure/dll/win32/cards/res/default/Spades_Ten.bmp URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/dll/win32/ca… Modified: branches/condrv_restructure/dll/win32/cards/res/default/Spades_Three.bmp URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/dll/win32/ca… Modified: branches/condrv_restructure/dll/win32/cards/res/default/Spades_Two.bmp URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/dll/win32/ca… Modified: branches/condrv_restructure/dll/win32/comctl32/lang/comctl_Tr.rc URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/dll/win32/co… Modified: branches/condrv_restructure/dll/win32/comctl32/rsrc.rc URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/dll/win32/co… Modified: branches/condrv_restructure/dll/win32/comdlg32/lang/cdlg_Tr.rc URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/dll/win32/co… Modified: branches/condrv_restructure/dll/win32/comdlg32/rsrc.rc URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/dll/win32/co… Modified: branches/condrv_restructure/dll/win32/credui/lang/credui_Tr.rc URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/dll/win32/cr… Modified: branches/condrv_restructure/dll/win32/crypt32/lang/crypt32_Tr.rc URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/dll/win32/cr… Modified: branches/condrv_restructure/dll/win32/cryptdlg/lang/cryptdlg_Tr.rc URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/dll/win32/cr… Modified: branches/condrv_restructure/dll/win32/cryptui/lang/cryptui_Tr.rc URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/dll/win32/cr… Modified: branches/condrv_restructure/dll/win32/devmgr/lang/tr-TR.rc URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/dll/win32/de… Modified: branches/condrv_restructure/dll/win32/getuname/getuname.rc URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/dll/win32/ge… Modified: branches/condrv_restructure/dll/win32/jscript/lang/jscript_Tr.rc URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/dll/win32/js… Modified: branches/condrv_restructure/dll/win32/kernel32/winnls/lang/tr-TR.rc URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/dll/win32/ke… Modified: branches/condrv_restructure/dll/win32/localui/lang/ui_Tr.rc URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/dll/win32/lo… Modified: branches/condrv_restructure/dll/win32/msgina/lang/tr-TR.rc URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/dll/win32/ms… Modified: branches/condrv_restructure/dll/win32/msvfw32/lang/msvfw32_Tr.rc URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/dll/win32/ms… Modified: branches/condrv_restructure/dll/win32/oledlg/lang/oledlg_Tr.rc URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/dll/win32/ol… Modified: branches/condrv_restructure/drivers/filesystems/npfs/datasup.c URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/drivers/file… Modified: branches/condrv_restructure/drivers/filesystems/npfs/readsup.c URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/drivers/file… Modified: branches/condrv_restructure/drivers/filesystems/npfs/waitsup.c URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/drivers/file… Modified: branches/condrv_restructure/include/ndk/mmtypes.h URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/include/ndk/… Modified: branches/condrv_restructure/include/reactos/libs/pseh/pseh3.h URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/include/reac… Modified: branches/condrv_restructure/lib/pseh/i386/pseh3.c URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/lib/pseh/i38… Modified: branches/condrv_restructure/ntoskrnl/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/ntoskrnl/CMa… Modified: branches/condrv_restructure/ntoskrnl/config/i386/cmhardwr.c URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/ntoskrnl/con… Modified: branches/condrv_restructure/ntoskrnl/include/internal/i386/ke.h URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/ntoskrnl/inc… Modified: branches/condrv_restructure/ntoskrnl/include/internal/mm.h URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/ntoskrnl/inc… Modified: branches/condrv_restructure/ntoskrnl/io/iomgr/iofunc.c URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/ntoskrnl/io/… Modified: branches/condrv_restructure/ntoskrnl/mm/ARM3/miarm.h URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/ntoskrnl/mm/… Modified: branches/condrv_restructure/ntoskrnl/mm/ARM3/pagfault.c URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/ntoskrnl/mm/… Modified: branches/condrv_restructure/ntoskrnl/mm/ARM3/pfnlist.c URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/ntoskrnl/mm/… Modified: branches/condrv_restructure/ntoskrnl/mm/ARM3/section.c URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/ntoskrnl/mm/… Modified: branches/condrv_restructure/ntoskrnl/mm/ARM3/virtual.c URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/ntoskrnl/mm/… Modified: branches/condrv_restructure/ntoskrnl/mm/balance.c URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/ntoskrnl/mm/… Modified: branches/condrv_restructure/ntoskrnl/mm/pagefile.c URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/ntoskrnl/mm/… Modified: branches/condrv_restructure/ntoskrnl/mm/section.c URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/ntoskrnl/mm/… Modified: branches/condrv_restructure/ntoskrnl/ntkrnlmp/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/ntoskrnl/ntk… Modified: branches/condrv_restructure/ntoskrnl/ob/oblife.c URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/ntoskrnl/ob/… Modified: branches/condrv_restructure/win32ss/gdi/ntgdi/cliprgn.c URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/win32ss/gdi/… Modified: branches/condrv_restructure/win32ss/user/ntuser/menu.c URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/win32ss/user… Modified: branches/condrv_restructure/win32ss/user/user32/misc/stubs.c URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/win32ss/user…

1 0

[hbelusca] 63831: [CONSRV]: Add a DPRINT for diagnostics purposes...
by hbelusca＠svn.reactos.org 07 Aug '14

07 Aug '14

Author: hbelusca Date: Thu Aug 7 12:36:40 2014 New Revision: 63831 URL: http://svn.reactos.org/svn/reactos?rev=63831&view=rev Log: [CONSRV]: Add a DPRINT for diagnostics purposes... Modified: branches/condrv_restructure/win32ss/user/winsrv/consrv/frontends/gui/conwnd.c Modified: branches/condrv_restructure/win32ss/user/winsrv/consrv/frontends/gui/conwnd.c URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/win32ss/user… ============================================================================== --- branches/condrv_restructure/win32ss/user/winsrv/consrv/frontends/gui/conwnd.c [iso-8859-1] (original) +++ branches/condrv_restructure/win32ss/user/winsrv/consrv/frontends/gui/conwnd.c [iso-8859-1] Thu Aug 7 12:36:40 2014 @@ -2329,6 +2329,7 @@ */ case WM_SETCONSOLEINFO: { + DPRINT1("WM_SETCONSOLEINFO message\n"); GuiApplyWindowsConsoleSettings(GuiData, (HANDLE)wParam); break; }

1 0

[jgardou] 63830: [WIN32K] - Among a thousand ways to screw a commit, choose dysxelia
by jgardou＠svn.reactos.org 07 Aug '14

07 Aug '14

Author: jgardou Date: Thu Aug 7 11:08:06 2014 New Revision: 63830 URL: http://svn.reactos.org/svn/reactos?rev=63830&view=rev Log: [WIN32K] - Among a thousand ways to screw a commit, choose dysxelia Modified: trunk/reactos/win32ss/user/ntuser/menu.c Modified: trunk/reactos/win32ss/user/ntuser/menu.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/ntuser/menu.c… ============================================================================== --- trunk/reactos/win32ss/user/ntuser/menu.c [iso-8859-1] (original) +++ trunk/reactos/win32ss/user/ntuser/menu.c [iso-8859-1] Thu Aug 7 11:08:06 2014 @@ -1151,7 +1151,7 @@ KeAttachProcess(&Process->Pcb); } - while (!IsEmptyList(&Win32Process->MenuListHead)) + while (!IsListEmpty(&Win32Process->MenuListHead)) { MenuObject = CONTAINING_RECORD(Win32Process->MenuListHead.Flink, MENU, ListEntry); TRACE("Menus are stuck on the process list!\n");

1 0

[jgardou] 63829: [WIN32K] - Among a thousand ways to loop over a list, choose the simple one.
by jgardou＠svn.reactos.org 07 Aug '14

07 Aug '14

Author: jgardou Date: Thu Aug 7 10:59:54 2014 New Revision: 63829 URL: http://svn.reactos.org/svn/reactos?rev=63829&view=rev Log: [WIN32K] - Among a thousand ways to loop over a list, choose the simple one. Modified: trunk/reactos/win32ss/user/ntuser/menu.c Modified: trunk/reactos/win32ss/user/ntuser/menu.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/ntuser/menu.c… ============================================================================== --- trunk/reactos/win32ss/user/ntuser/menu.c [iso-8859-1] (original) +++ trunk/reactos/win32ss/user/ntuser/menu.c [iso-8859-1] Thu Aug 7 10:59:54 2014 @@ -1143,7 +1143,6 @@ IntCleanupMenus(struct _EPROCESS *Process, PPROCESSINFO Win32Process) { PEPROCESS CurrentProcess; - PLIST_ENTRY LastHead = NULL; PMENU MenuObject; CurrentProcess = PsGetCurrentProcess(); @@ -1152,10 +1151,8 @@ KeAttachProcess(&Process->Pcb); } - while (Win32Process->MenuListHead.Flink != &(Win32Process->MenuListHead) && - Win32Process->MenuListHead.Flink != LastHead) - { - LastHead = Win32Process->MenuListHead.Flink; + while (!IsEmptyList(&Win32Process->MenuListHead)) + { MenuObject = CONTAINING_RECORD(Win32Process->MenuListHead.Flink, MENU, ListEntry); TRACE("Menus are stuck on the process list!\n"); IntDestroyMenuObject(MenuObject, FALSE, TRUE);

1 0

[jgardou] 63828: [NDK] - Correct definition of SECTION_OBJECT
by jgardou＠svn.reactos.org 07 Aug '14

07 Aug '14

Author: jgardou Date: Thu Aug 7 10:59:48 2014 New Revision: 63828 URL: http://svn.reactos.org/svn/reactos?rev=63828&view=rev Log: [NDK] - Correct definition of SECTION_OBJECT Modified: trunk/reactos/include/ndk/mmtypes.h Modified: trunk/reactos/include/ndk/mmtypes.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/ndk/mmtypes.h?rev=… ============================================================================== --- trunk/reactos/include/ndk/mmtypes.h [iso-8859-1] (original) +++ trunk/reactos/include/ndk/mmtypes.h [iso-8859-1] Thu Aug 7 10:59:48 2014 @@ -639,6 +639,7 @@ { PVOID StartingVa; PVOID EndingVa; + PVOID Parent; PVOID LeftChild; PVOID RightChild; PSEGMENT_OBJECT Segment;

1 0

[tfaber] 63827: [NPFS] - Avoid magic values, remove a few casts and don't name an IO_STATUS_BLOCK Status. No code changes.
by tfaber＠svn.reactos.org 07 Aug '14

07 Aug '14

Author: tfaber Date: Thu Aug 7 10:24:07 2014 New Revision: 63827 URL: http://svn.reactos.org/svn/reactos?rev=63827&view=rev Log: [NPFS] - Avoid magic values, remove a few casts and don't name an IO_STATUS_BLOCK Status. No code changes. Modified: trunk/reactos/drivers/filesystems/npfs/datasup.c trunk/reactos/drivers/filesystems/npfs/readsup.c trunk/reactos/drivers/filesystems/npfs/waitsup.c Modified: trunk/reactos/drivers/filesystems/npfs/datasup.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/npfs/d… ============================================================================== --- trunk/reactos/drivers/filesystems/npfs/datasup.c [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/npfs/datasup.c [iso-8859-1] Thu Aug 7 10:24:07 2014 @@ -68,7 +68,7 @@ Irp = DataQueueEntry->Irp; - if ((DataQueueEntry->DataEntryType == 0) && (Irp)) + if ((DataQueueEntry->DataEntryType == Buffered) && (Irp)) { DataLeft = DataQueueEntry->DataSize - ByteOffset; @@ -127,12 +127,12 @@ DataQueue->BytesInQueue -= QueueEntry->DataSize; --DataQueue->EntriesInQueue; - HasWrites = 1; + HasWrites = TRUE; if (DataQueue->QueueState != WriteEntries || DataQueue->QuotaUsed < DataQueue->Quota || !QueueEntry->QuotaInEntry) { - HasWrites = 0; + HasWrites = FALSE; } DataQueue->QuotaUsed -= QueueEntry->QuotaInEntry; @@ -140,7 +140,7 @@ if (IsListEmpty(&DataQueue->Queue)) { DataQueue->QueueState = Empty; - HasWrites = 0; + HasWrites = FALSE; } Irp = QueueEntry->Irp; @@ -183,7 +183,9 @@ NextEntry != &DataQueue->Queue; NextEntry = DataQueue->Queue.Flink) { - DataEntry = CONTAINING_RECORD(NextEntry, NP_DATA_QUEUE_ENTRY, QueueEntry); + DataEntry = CONTAINING_RECORD(NextEntry, + NP_DATA_QUEUE_ENTRY, + QueueEntry); Type = DataEntry->DataEntryType; if (Type == Buffered || Type == Unbuffered) break; @@ -223,29 +225,29 @@ NpAcquireExclusiveVcb(); } - DataEntry = (PNP_DATA_QUEUE_ENTRY)Irp->Tail.Overlay.DriverContext[3]; + DataEntry = Irp->Tail.Overlay.DriverContext[3]; if (DataEntry) { if (DataEntry->QueueEntry.Blink == &DataQueue->Queue) { DataQueue->ByteOffset = 0; - FirstEntry = 1; + FirstEntry = TRUE; } else { - FirstEntry = 0; + FirstEntry = FALSE; } RemoveEntryList(&DataEntry->QueueEntry); ClientSecurityContext = DataEntry->ClientSecurityContext; - CompleteWrites = 1; + CompleteWrites = TRUE; if (DataQueue->QueueState != WriteEntries || DataQueue->QuotaUsed < DataQueue->Quota || !DataEntry->QuotaInEntry) { - CompleteWrites = 0; + CompleteWrites = FALSE; } DataQueue->BytesInQueue -= DataEntry->DataSize; Modified: trunk/reactos/drivers/filesystems/npfs/readsup.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/npfs/r… ============================================================================== --- trunk/reactos/drivers/filesystems/npfs/readsup.c [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/npfs/readsup.c [iso-8859-1] Thu Aug 7 10:24:07 2014 @@ -17,12 +17,12 @@ IO_STATUS_BLOCK NTAPI -NpReadDataQueue(IN PNP_DATA_QUEUE DataQueue, +NpReadDataQueue(IN PNP_DATA_QUEUE DataQueue, IN BOOLEAN Peek, IN BOOLEAN ReadOverflowOperation, IN PVOID Buffer, - IN ULONG BufferSize, - IN ULONG Mode, + IN ULONG BufferSize, + IN ULONG Mode, IN PNP_CCB Ccb, IN PLIST_ENTRY List) { @@ -30,14 +30,14 @@ PVOID DataBuffer; ULONG DataSize, DataLength, TotalBytesCopied, RemainingSize, Offset; PIRP Irp; - IO_STATUS_BLOCK Status; + IO_STATUS_BLOCK IoStatus; BOOLEAN CompleteWrites = FALSE; PAGED_CODE(); if (ReadOverflowOperation) Peek = TRUE; RemainingSize = BufferSize; - Status.Status = STATUS_SUCCESS; + IoStatus.Status = STATUS_SUCCESS; TotalBytesCopied = 0; if (Peek) @@ -110,7 +110,7 @@ { if (Mode == FILE_PIPE_MESSAGE_MODE) { - Status.Status = STATUS_BUFFER_OVERFLOW; + IoStatus.Status = STATUS_BUFFER_OVERFLOW; break; } } @@ -137,7 +137,7 @@ if (Mode == FILE_PIPE_MESSAGE_MODE) { - Status.Status = STATUS_SUCCESS; + IoStatus.Status = STATUS_SUCCESS; break; } @@ -159,9 +159,9 @@ } } - Status.Information = TotalBytesCopied; + IoStatus.Information = TotalBytesCopied; if (CompleteWrites) NpCompleteStalledWrites(DataQueue, List); - return Status; + return IoStatus; } /* EOF */ Modified: trunk/reactos/drivers/filesystems/npfs/waitsup.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/npfs/w… ============================================================================== --- trunk/reactos/drivers/filesystems/npfs/waitsup.c [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/npfs/waitsup.c [iso-8859-1] Thu Aug 7 10:24:07 2014 @@ -17,7 +17,7 @@ VOID NTAPI -NpCancelWaitQueueIrp(IN PDEVICE_OBJECT DeviceObject, +NpCancelWaitQueueIrp(IN PDEVICE_OBJECT DeviceObject, IN PIRP Irp) { KIRQL OldIrql; @@ -53,7 +53,7 @@ Irp->IoStatus.Status = STATUS_CANCELLED; IoCompleteRequest(Irp, IO_NAMED_PIPE_INCREMENT); } - + VOID NTAPI NpTimerDispatch(IN PKDPC Dpc, @@ -243,7 +243,7 @@ WaitEntry->WaitQueue = WaitQueue; WaitEntry->Irp = Irp; - WaitBuffer = (PFILE_PIPE_WAIT_FOR_BUFFER)Irp->AssociatedIrp.SystemBuffer; + WaitBuffer = Irp->AssociatedIrp.SystemBuffer; if (WaitBuffer->TimeoutSpecified) { DueTime = WaitBuffer->Timeout; @@ -281,7 +281,6 @@ KeSetTimer(&WaitEntry->Timer, DueTime, &WaitEntry->Dpc); WaitEntry = NULL; - } KeReleaseSpinLock(&WaitQueue->WaitLock, OldIrql);

1 0

[tfaber] 63826: [NPFS] - Base data queue entry on the right struct member in NpCompleteStalledWrites. Fixes list entry corruption found in CORE-8419.
by tfaber＠svn.reactos.org 07 Aug '14

07 Aug '14

Author: tfaber Date: Thu Aug 7 10:10:02 2014 New Revision: 63826 URL: http://svn.reactos.org/svn/reactos?rev=63826&view=rev Log: [NPFS] - Base data queue entry on the right struct member in NpCompleteStalledWrites. Fixes list entry corruption found in CORE-8419. Modified: trunk/reactos/drivers/filesystems/npfs/datasup.c Modified: trunk/reactos/drivers/filesystems/npfs/datasup.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/npfs/d… ============================================================================== --- trunk/reactos/drivers/filesystems/npfs/datasup.c [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/npfs/datasup.c [iso-8859-1] Thu Aug 7 10:10:02 2014 @@ -62,7 +62,9 @@ { if (!QuotaLeft) break; - DataQueueEntry = CONTAINING_RECORD(NextEntry, NP_DATA_QUEUE_ENTRY, Irp); + DataQueueEntry = CONTAINING_RECORD(NextEntry, + NP_DATA_QUEUE_ENTRY, + QueueEntry); Irp = DataQueueEntry->Irp;

1 0

[tfaber] 63825: [NTOS:OB] - Use ObpTypeObjectType's lock when modifying object type global properties, not the new object type's - Correctly free string returned by RtlUnicodeStringToAnsiString
by tfaber＠svn.reactos.org 07 Aug '14

07 Aug '14

Author: tfaber Date: Thu Aug 7 00:16:21 2014 New Revision: 63825 URL: http://svn.reactos.org/svn/reactos?rev=63825&view=rev Log: [NTOS:OB] - Use ObpTypeObjectType's lock when modifying object type global properties, not the new object type's - Correctly free string returned by RtlUnicodeStringToAnsiString Modified: trunk/reactos/ntoskrnl/ob/oblife.c Modified: trunk/reactos/ntoskrnl/ob/oblife.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ob/oblife.c?rev=6… ============================================================================== --- trunk/reactos/ntoskrnl/ob/oblife.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/ob/oblife.c [iso-8859-1] Thu Aug 7 00:16:21 2014 @@ -1145,7 +1145,7 @@ /* Set the key and free the converted name */ LocalObjectType->Key = *(PULONG)AnsiName.Buffer; - ExFreePool(AnsiName.Buffer); + RtlFreeAnsiString(&AnsiName); } else { @@ -1227,7 +1227,7 @@ InitializeListHead(&LocalObjectType->TypeList); /* Lock the object type */ - ObpEnterObjectTypeMutex(LocalObjectType); + ObpEnterObjectTypeMutex(ObpTypeObjectType); /* Get creator info and insert it into the type list */ CreatorInfo = OBJECT_HEADER_TO_CREATOR_INFO(Header); @@ -1246,7 +1246,7 @@ } /* Release the object type */ - ObpLeaveObjectTypeMutex(LocalObjectType); + ObpLeaveObjectTypeMutex(ObpTypeObjectType); /* Check if we're actually creating the directory object itself */ if (!(ObpTypeDirectoryObject) ||

1 0

[dgorbachev] 63824: [EXPLORER] Use -Wno-error option when building with link-time optimization. [BROWSEUI] "Fix" multiple definition of (non-virtual thunk to) QueryInterface errors. Binutils linker...
by dgorbachev＠svn.reactos.org 06 Aug '14

06 Aug '14

Author: dgorbachev Date: Wed Aug 6 23:10:17 2014 New Revision: 63824 URL: http://svn.reactos.org/svn/reactos?rev=63824&view=rev Log: [EXPLORER] Use -Wno-error option when building with link-time optimization. [BROWSEUI] "Fix" multiple definition of (non-virtual thunk to) QueryInterface errors. Binutils linker bug. Modified: trunk/reactos/base/shell/explorer/CMakeLists.txt trunk/reactos/dll/win32/browseui/CMakeLists.txt Modified: trunk/reactos/base/shell/explorer/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/shell/explorer/CMakeL… ============================================================================== --- trunk/reactos/base/shell/explorer/CMakeLists.txt [iso-8859-1] (original) +++ trunk/reactos/base/shell/explorer/CMakeLists.txt [iso-8859-1] Wed Aug 6 23:10:17 2014 @@ -63,4 +63,9 @@ if(NOT MSVC) add_compile_flags("-Wno-error=narrowing") + + # GCC bug #59472 + if(LTCG) + add_target_link_flags(explorer "-Wno-error") + endif() endif() Modified: trunk/reactos/dll/win32/browseui/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/browseui/CMakeLi… ============================================================================== --- trunk/reactos/dll/win32/browseui/CMakeLists.txt [iso-8859-1] (original) +++ trunk/reactos/dll/win32/browseui/CMakeLists.txt [iso-8859-1] Wed Aug 6 23:10:17 2014 @@ -61,4 +61,9 @@ if(NOT MSVC) add_target_compile_flags(browseui "-Wno-unused-but-set-variable") + + # Binutils linker bug + if(LTCG) + add_target_link_flags(browseui "-Wl,--allow-multiple-definition") + endif() endif()

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs