Ros-diffs

ros-diffs@reactos.org

81390 discussions

[pschweitzer] 63022: [PSAPI] Fix pointer arithmetic CID #1206924
by pschweitzer＠svn.reactos.org 27 Apr '14

27 Apr '14

Author: pschweitzer Date: Sun Apr 27 18:35:46 2014 New Revision: 63022 URL: http://svn.reactos.org/svn/reactos?rev=63022&view=rev Log: [PSAPI] Fix pointer arithmetic CID #1206924 Modified: trunk/reactos/dll/win32/psapi/psapi.c Modified: trunk/reactos/dll/win32/psapi/psapi.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/psapi/psapi.c?re… ============================================================================== --- trunk/reactos/dll/win32/psapi/psapi.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/psapi/psapi.c [iso-8859-1] Sun Apr 27 18:35:46 2014 @@ -1381,7 +1381,7 @@ if (Colon != 0 && Colon != PageFileInfo->PageFileName.Buffer) { /* We can call the user callback routine with the colon */ - Colon -= sizeof(WCHAR); + --Colon; pCallbackRoutine(lpContext, &Information, Colon); }

1 0

[pschweitzer] 63021: [RAPPS] - Fix memory leaks - Fix null-pointer dereference - Fix user-after-free CID #1206908 CID #1206915 CID #1206921 CID #1207022
by pschweitzer＠svn.reactos.org 27 Apr '14

27 Apr '14

Author: pschweitzer Date: Sun Apr 27 18:29:06 2014 New Revision: 63021 URL: http://svn.reactos.org/svn/reactos?rev=63021&view=rev Log: [RAPPS] - Fix memory leaks - Fix null-pointer dereference - Fix user-after-free CID #1206908 CID #1206915 CID #1206921 CID #1207022 Modified: trunk/reactos/base/applications/rapps/available.c trunk/reactos/base/applications/rapps/loaddlg.c Modified: trunk/reactos/base/applications/rapps/available.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/rapps/av… ============================================================================== --- trunk/reactos/base/applications/rapps/available.c [iso-8859-1] (original) +++ trunk/reactos/base/applications/rapps/available.c [iso-8859-1] Sun Apr 27 18:29:06 2014 @@ -179,12 +179,16 @@ if (!GetLocaleInfoW(GetUserDefaultLCID(), LOCALE_ILANGUAGE, szLocale, sizeof(szLocale) / sizeof(WCHAR))) { + FindClose(hFind); return FALSE; } hr = StringCbCatW(szSectionLocale, sizeof(szSectionLocale), szLocale); if (FAILED(hr)) - return FALSE; + { + FindClose(hFind); + return FALSE; + } #define GET_STRING1(a, b) \ if (!ParserGetString(szSectionLocale, a, b, MAX_PATH, FindFileData.cFileName)) \ Modified: trunk/reactos/base/applications/rapps/loaddlg.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/rapps/lo… ============================================================================== --- trunk/reactos/base/applications/rapps/loaddlg.c [iso-8859-1] (original) +++ trunk/reactos/base/applications/rapps/loaddlg.c [iso-8859-1] Sun Apr 27 18:29:06 2014 @@ -205,7 +205,7 @@ DWORD WINAPI ThreadFunc(LPVOID Context) { - IBindStatusCallback *dl; + IBindStatusCallback *dl = NULL; WCHAR path[MAX_PATH]; LPWSTR p; HWND Dlg = (HWND) Context; @@ -262,6 +262,7 @@ /* download it */ bTempfile = TRUE; dl = CreateDl(Context, &bCancelled); + if (dl == NULL) goto end; hOpen = InternetOpenW(lpszAgent, INTERNET_OPEN_TYPE_PRECONFIG, NULL, NULL, 0); if (!hOpen) goto end; @@ -282,9 +283,7 @@ IBindStatusCallback_OnProgress(dl, dwCurrentBytesRead, dwContentLen, 0, AppInfo->szUrlDownload); } while (dwBytesRead); - - CloseHandle(hOut); - if (dl) IBindStatusCallback_Release(dl); + if (bCancelled) goto end; ShowWindow(Dlg, SW_HIDE); @@ -298,6 +297,8 @@ CloseHandle(hOut); InternetCloseHandle(hFile); InternetCloseHandle(hOpen); + + if (dl) IBindStatusCallback_Release(dl); if (bTempfile) {

1 0

[pschweitzer] 63020: [NTOSKRNL] Init event before passing it to the IRP. Fixes issues on IRP completion
by pschweitzer＠svn.reactos.org 27 Apr '14

27 Apr '14

Author: pschweitzer Date: Sun Apr 27 13:46:21 2014 New Revision: 63020 URL: http://svn.reactos.org/svn/reactos?rev=63020&view=rev Log: [NTOSKRNL] Init event before passing it to the IRP. Fixes issues on IRP completion Modified: trunk/reactos/ntoskrnl/io/iomgr/iofunc.c Modified: trunk/reactos/ntoskrnl/io/iomgr/iofunc.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/io/iomgr/iofunc.c… ============================================================================== --- trunk/reactos/ntoskrnl/io/iomgr/iofunc.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/io/iomgr/iofunc.c [iso-8859-1] Sun Apr 27 13:46:21 2014 @@ -661,6 +661,9 @@ ObDereferenceObject(FileObject); return STATUS_INSUFFICIENT_RESOURCES; } + + /* Init event */ + KeInitializeEvent(&Event, SynchronizationEvent, FALSE); /* Setup the IRP */ Irp->UserIosb = &IoStatusBlock;

1 0

[tfaber] 63019: [I8042PRT] - Fix WDK warnings and remove some unnecessary casts
by tfaber＠svn.reactos.org 27 Apr '14

27 Apr '14

Author: tfaber Date: Sun Apr 27 13:33:42 2014 New Revision: 63019 URL: http://svn.reactos.org/svn/reactos?rev=63019&view=rev Log: [I8042PRT] - Fix WDK warnings and remove some unnecessary casts Modified: trunk/reactos/drivers/input/i8042prt/i8042prt.c trunk/reactos/drivers/input/i8042prt/i8042prt.h trunk/reactos/drivers/input/i8042prt/keyboard.c trunk/reactos/drivers/input/i8042prt/misc.c trunk/reactos/drivers/input/i8042prt/mouse.c trunk/reactos/drivers/input/i8042prt/pnp.c Modified: trunk/reactos/drivers/input/i8042prt/i8042prt.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/input/i8042prt/i80… ============================================================================== --- trunk/reactos/drivers/input/i8042prt/i8042prt.c [iso-8859-1] (original) +++ trunk/reactos/drivers/input/i8042prt/i8042prt.c [iso-8859-1] Sun Apr 27 13:33:42 2014 @@ -19,7 +19,9 @@ static DRIVER_STARTIO i8042StartIo; static DRIVER_DISPATCH IrpStub; +_Dispatch_type_(IRP_MJ_DEVICE_CONTROL) static DRIVER_DISPATCH i8042DeviceControl; +_Dispatch_type_(IRP_MJ_INTERNAL_DEVICE_CONTROL) static DRIVER_DISPATCH i8042InternalDeviceControl; DRIVER_INITIALIZE DriverEntry; Modified: trunk/reactos/drivers/input/i8042prt/i8042prt.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/input/i8042prt/i80… ============================================================================== --- trunk/reactos/drivers/input/i8042prt/i8042prt.h [iso-8859-1] (original) +++ trunk/reactos/drivers/input/i8042prt/i8042prt.h [iso-8859-1] Sun Apr 27 13:33:42 2014 @@ -292,10 +292,13 @@ IO_WORKITEM_ROUTINE i8042SendHookWorkItem; +_Dispatch_type_(IRP_MJ_CREATE) DRIVER_DISPATCH i8042Create; +_Dispatch_type_(IRP_MJ_CLEANUP) DRIVER_DISPATCH i8042Cleanup; +_Dispatch_type_(IRP_MJ_CLOSE) DRIVER_DISPATCH i8042Close; /* keyboard.c */ @@ -371,6 +374,7 @@ IN UCHAR FlagsToDisable, IN UCHAR FlagsToEnable); +_Dispatch_type_(IRP_MJ_PNP) DRIVER_DISPATCH i8042Pnp; /* ps2pp.c */ Modified: trunk/reactos/drivers/input/i8042prt/keyboard.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/input/i8042prt/key… ============================================================================== --- trunk/reactos/drivers/input/i8042prt/keyboard.c [iso-8859-1] (original) +++ trunk/reactos/drivers/input/i8042prt/keyboard.c [iso-8859-1] Sun Apr 27 13:33:42 2014 @@ -21,6 +21,7 @@ /* GLOBALS *******************************************************************/ static IO_WORKITEM_ROUTINE i8042PowerWorkItem; +static KDEFERRED_ROUTINE i8042KbdDpcRoutine; /* This structure starts with the same layout as KEYBOARD_INDICATOR_TRANSLATION */ typedef struct _LOCAL_KEYBOARD_INDICATOR_TRANSLATION { @@ -196,9 +197,10 @@ PIRP WaitingIrp; NTSTATUS Status; - DeviceExtension = (PI8042_KEYBOARD_EXTENSION)Context; - UNREFERENCED_PARAMETER(DeviceObject); + + __analysis_assume(Context != NULL); + DeviceExtension = Context; /* See http://blogs.msdn.com/doronh/archive/2006/09/08/746961.aspx */ @@ -331,7 +333,8 @@ UNREFERENCED_PARAMETER(SystemArgument1); UNREFERENCED_PARAMETER(SystemArgument2); - DeviceExtension = (PI8042_KEYBOARD_EXTENSION)DeferredContext; + __analysis_assume(DeferredContext != NULL); + DeviceExtension = DeferredContext; PortDeviceExtension = DeviceExtension->Common.PortDeviceExtension; if (HandlePowerKeys(DeviceExtension)) @@ -652,9 +655,6 @@ Irp->IoStatus.Information = sizeof(KEYBOARD_ATTRIBUTES); Status = STATUS_SUCCESS; break; - - Status = STATUS_NOT_IMPLEMENTED; - break; } case IOCTL_KEYBOARD_QUERY_TYPEMATIC: { @@ -745,9 +745,9 @@ } /* - * Call the customization hook. The ToReturn parameter is about wether + * Call the customization hook. The ToReturn parameter is about whether * we should go on with the interrupt. The return value is what - * we should return (indicating to the system wether someone else + * we should return (indicating to the system whether someone else * should try to handle the interrupt) */ static BOOLEAN @@ -796,7 +796,8 @@ UNREFERENCED_PARAMETER(Interrupt); - DeviceExtension = (PI8042_KEYBOARD_EXTENSION)Context; + __analysis_assume(Context != NULL); + DeviceExtension = Context; PortDeviceExtension = DeviceExtension->Common.PortDeviceExtension; InputData = DeviceExtension->KeyboardBuffer + DeviceExtension->KeysInBuffer; Counter = PortDeviceExtension->Settings.PollStatusIterations; Modified: trunk/reactos/drivers/input/i8042prt/misc.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/input/i8042prt/mis… ============================================================================== --- trunk/reactos/drivers/input/i8042prt/misc.c [iso-8859-1] (original) +++ trunk/reactos/drivers/input/i8042prt/misc.c [iso-8859-1] Sun Apr 27 13:33:42 2014 @@ -23,8 +23,9 @@ IN PVOID Context) { UNREFERENCED_PARAMETER(DeviceObject); + __analysis_assume(Context != NULL); if (Irp->PendingReturned) - KeSetEvent((PKEVENT)Context, IO_NO_INCREMENT, FALSE); + KeSetEvent(Context, IO_NO_INCREMENT, FALSE); return STATUS_MORE_PROCESSING_REQUIRED; } Modified: trunk/reactos/drivers/input/i8042prt/mouse.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/input/i8042prt/mou… ============================================================================== --- trunk/reactos/drivers/input/i8042prt/mouse.c [iso-8859-1] (original) +++ trunk/reactos/drivers/input/i8042prt/mouse.c [iso-8859-1] Sun Apr 27 13:33:42 2014 @@ -18,6 +18,8 @@ /* FUNCTIONS *****************************************************************/ +static KDEFERRED_ROUTINE i8042MouDpcRoutine; + /* * These functions are callbacks for filter driver custom interrupt * service routines. @@ -269,7 +271,8 @@ UNREFERENCED_PARAMETER(SystemArgument1); UNREFERENCED_PARAMETER(SystemArgument2); - DeviceExtension = (PI8042_MOUSE_EXTENSION)DeferredContext; + __analysis_assume(DeferredContext != NULL); + DeviceExtension = DeferredContext; PortDeviceExtension = DeviceExtension->Common.PortDeviceExtension; switch (DeviceExtension->MouseTimeoutState) @@ -343,6 +346,7 @@ * I'll just send the 'disable mouse port' command to the controller * and say the mouse doesn't exist. */ +static KDEFERRED_ROUTINE i8042DpcRoutineMouseTimeout; static VOID NTAPI i8042DpcRoutineMouseTimeout( IN PKDPC Dpc, @@ -358,7 +362,8 @@ UNREFERENCED_PARAMETER(SystemArgument1); UNREFERENCED_PARAMETER(SystemArgument2); - DeviceExtension = (PI8042_MOUSE_EXTENSION)DeferredContext; + __analysis_assume(DeferredContext != NULL); + DeviceExtension = DeferredContext; PortDeviceExtension = DeviceExtension->Common.PortDeviceExtension; Irql = KeAcquireInterruptSpinLock(PortDeviceExtension->HighestDIRQLInterrupt); @@ -906,7 +911,8 @@ UNREFERENCED_PARAMETER(Interrupt); - DeviceExtension = (PI8042_MOUSE_EXTENSION)Context; + __analysis_assume(Context != NULL); + DeviceExtension = Context; PortDeviceExtension = DeviceExtension->Common.PortDeviceExtension; Counter = PortDeviceExtension->Settings.PollStatusIterations; Modified: trunk/reactos/drivers/input/i8042prt/pnp.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/input/i8042prt/pnp… ============================================================================== --- trunk/reactos/drivers/input/i8042prt/pnp.c [iso-8859-1] (original) +++ trunk/reactos/drivers/input/i8042prt/pnp.c [iso-8859-1] Sun Apr 27 13:33:42 2014 @@ -112,7 +112,7 @@ } else if (Value == KBD_RESEND) { - TRACE_(I8042PRT, "Resending...\n", Value); + TRACE_(I8042PRT, "Resending...\n"); KeStallExecutionProcessor(50); } else @@ -390,7 +390,7 @@ StartProcedure( IN PPORT_DEVICE_EXTENSION DeviceExtension) { - NTSTATUS Status; + NTSTATUS Status = STATUS_UNSUCCESSFUL; UCHAR FlagsToDisable = 0; UCHAR FlagsToEnable = 0; KIRQL Irql; @@ -495,7 +495,7 @@ PFDO_DEVICE_EXTENSION DeviceExtension; PPORT_DEVICE_EXTENSION PortDeviceExtension; PCM_PARTIAL_RESOURCE_DESCRIPTOR ResourceDescriptor, ResourceDescriptorTranslated; - INTERRUPT_DATA InterruptData; + INTERRUPT_DATA InterruptData = { NULL }; BOOLEAN FoundDataPort = FALSE; BOOLEAN FoundControlPort = FALSE; BOOLEAN FoundIrq = FALSE; @@ -685,7 +685,9 @@ PDEVICE_RELATIONS DeviceRelations; TRACE_(I8042PRT, "IRP_MJ_PNP / IRP_MN_QUERY_DEVICE_RELATIONS / BusRelations\n"); - DeviceRelations = ExAllocatePool(PagedPool, sizeof(DEVICE_RELATIONS)); + DeviceRelations = ExAllocatePoolWithTag(PagedPool, + sizeof(DEVICE_RELATIONS), + I8042PRT_TAG); if (DeviceRelations) { DeviceRelations->Count = 0;

1 0

[pschweitzer] 63018: [PSDK] Properly declare with __inline
by pschweitzer＠svn.reactos.org 27 Apr '14

27 Apr '14

Author: pschweitzer Date: Sun Apr 27 13:11:19 2014 New Revision: 63018 URL: http://svn.reactos.org/svn/reactos?rev=63018&view=rev Log: [PSDK] Properly declare with __inline Modified: trunk/reactos/include/psdk/ks.h Modified: trunk/reactos/include/psdk/ks.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/psdk/ks.h?rev=6301… ============================================================================== --- trunk/reactos/include/psdk/ks.h [iso-8859-1] (original) +++ trunk/reactos/include/psdk/ks.h [iso-8859-1] Sun Apr 27 13:11:19 2014 @@ -2792,8 +2792,8 @@ _IRQL_requires_max_(HIGH_LEVEL) static +__inline void -__inline KsGateTurnInputOn( _In_opt_ PKSGATE Gate) { @@ -2805,8 +2805,8 @@ _IRQL_requires_max_(HIGH_LEVEL) static +__inline void -__inline KsGateTurnInputOff( _In_opt_ PKSGATE Gate) { @@ -2818,8 +2818,8 @@ _IRQL_requires_max_(HIGH_LEVEL) static +__inline BOOLEAN -__inline KsGateGetStateUnsafe( _In_ PKSGATE Gate) { @@ -2829,8 +2829,8 @@ _IRQL_requires_max_(HIGH_LEVEL) static +__inline BOOLEAN -__inline KsGateCaptureThreshold( _In_ PKSGATE Gate) { @@ -2850,8 +2850,8 @@ _IRQL_requires_max_(HIGH_LEVEL) static +__inline void -__inline KsGateInitialize( _In_ PKSGATE Gate, _In_ LONG InitialCount, @@ -2883,8 +2883,8 @@ _IRQL_requires_max_(HIGH_LEVEL) static +__inline void -__inline KsGateInitializeAnd( _In_ PKSGATE AndGate, _In_opt_ PKSGATE NextOrGate) @@ -2894,8 +2894,8 @@ _IRQL_requires_max_(HIGH_LEVEL) static +__inline void -__inline KsGateInitializeOr( _In_ PKSGATE OrGate, _In_opt_ PKSGATE NextAndGate) @@ -2905,8 +2905,8 @@ _IRQL_requires_max_(HIGH_LEVEL) static +__inline void -__inline KsGateAddOnInputToAnd( _In_ PKSGATE AndGate) { @@ -2915,8 +2915,8 @@ _IRQL_requires_max_(HIGH_LEVEL) static +__inline void -__inline KsGateAddOffInputToAnd( _In_ PKSGATE AndGate) { @@ -2925,8 +2925,8 @@ _IRQL_requires_max_(HIGH_LEVEL) static +__inline void -__inline KsGateRemoveOnInputFromAnd( _In_ PKSGATE AndGate) { @@ -2935,8 +2935,8 @@ _IRQL_requires_max_(HIGH_LEVEL) static +__inline void -__inline KsGateRemoveOffInputFromAnd( _In_ PKSGATE AndGate) { @@ -2945,8 +2945,8 @@ _IRQL_requires_max_(HIGH_LEVEL) static +__inline void -__inline KsGateAddOnInputToOr( _In_ PKSGATE OrGate) { @@ -2955,8 +2955,8 @@ _IRQL_requires_max_(HIGH_LEVEL) static +__inline void -__inline KsGateAddOffInputToOr( _In_ PKSGATE OrGate) { @@ -2965,8 +2965,8 @@ _IRQL_requires_max_(HIGH_LEVEL) static +__inline void -__inline KsGateRemoveOnInputFromOr( _In_ PKSGATE OrGate) { @@ -2975,8 +2975,8 @@ _IRQL_requires_max_(HIGH_LEVEL) static +__inline void -__inline KsGateRemoveOffInputFromOr( _In_ PKSGATE OrGate) { @@ -2985,8 +2985,8 @@ _IRQL_requires_max_(HIGH_LEVEL) static +__inline void -__inline KsGateTerminateAnd( _In_ PKSGATE AndGate) { @@ -3003,8 +3003,8 @@ _IRQL_requires_max_(HIGH_LEVEL) static +__inline void -__inline KsGateTerminateOr( _In_ PKSGATE OrGate) { @@ -4705,8 +4705,8 @@ _IRQL_requires_max_(PASSIVE_LEVEL) static +__inline PKSFILTERFACTORY -__inline KsFilterGetParentFilterFactory( _In_ PKSFILTER Filter) { @@ -4715,8 +4715,8 @@ _IRQL_requires_max_(PASSIVE_LEVEL) static +__inline PKSDEVICE -__inline KsFilterFactoryGetParentDevice( _In_ PKSFILTERFACTORY FilterFactory) { @@ -4939,8 +4939,8 @@ _IRQL_requires_max_(PASSIVE_LEVEL) KSDDKAPI +__inline PKSDEVICE -__inline KsFilterFactoryGetDevice( _In_ PKSFILTERFACTORY FilterFactory);

1 0

[pschweitzer] 63017: [FREELDR] Properly declare with FORCEINLINE
by pschweitzer＠svn.reactos.org 27 Apr '14

27 Apr '14

Author: pschweitzer Date: Sun Apr 27 12:59:37 2014 New Revision: 63017 URL: http://svn.reactos.org/svn/reactos?rev=63017&view=rev Log: [FREELDR] Properly declare with FORCEINLINE Modified: trunk/reactos/boot/freeldr/freeldr/include/mm.h Modified: trunk/reactos/boot/freeldr/freeldr/include/mm.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/inclu… ============================================================================== --- trunk/reactos/boot/freeldr/freeldr/include/mm.h [iso-8859-1] (original) +++ trunk/reactos/boot/freeldr/freeldr/include/mm.h [iso-8859-1] Sun Apr 27 12:59:37 2014 @@ -170,16 +170,16 @@ FrLdrHeapFreeEx(FrLdrDefaultHeap, MemoryPointer, Tag); } +FORCEINLINE PVOID -FORCEINLINE FrLdrTempAlloc( ULONG Size, ULONG Tag) { return FrLdrHeapAllocateEx(FrLdrTempHeap, Size, Tag); } +FORCEINLINE VOID -FORCEINLINE FrLdrTempFree( PVOID Allocation, ULONG Tag) {

1 0

[pschweitzer] 63016: [RTL] Properly declare with FORCEINLINE
by pschweitzer＠svn.reactos.org 27 Apr '14

27 Apr '14

Author: pschweitzer Date: Sun Apr 27 12:45:51 2014 New Revision: 63016 URL: http://svn.reactos.org/svn/reactos?rev=63016&view=rev Log: [RTL] Properly declare with FORCEINLINE Modified: trunk/reactos/lib/rtl/heap.c trunk/reactos/lib/rtl/image.c Modified: trunk/reactos/lib/rtl/heap.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/rtl/heap.c?rev=63016&r… ============================================================================== --- trunk/reactos/lib/rtl/heap.c [iso-8859-1] (original) +++ trunk/reactos/lib/rtl/heap.c [iso-8859-1] Sun Apr 27 12:45:51 2014 @@ -46,7 +46,8 @@ 4,0,1,0,2,0,1,0,3,0,1,0,2,0,1,0 }; -UCHAR FORCEINLINE +FORCEINLINE +UCHAR RtlpFindLeastSetBit(ULONG Bits) { if (Bits & 0xFFFF) @@ -203,7 +204,8 @@ return STATUS_SUCCESS; } -VOID FORCEINLINE +FORCEINLINE +VOID RtlpSetFreeListsBit(PHEAP Heap, PHEAP_FREE_ENTRY FreeEntry) { @@ -222,7 +224,8 @@ Heap->u.FreeListsInUseBytes[Index] |= Bit; } -VOID FORCEINLINE +FORCEINLINE +VOID RtlpClearFreeListsBit(PHEAP Heap, PHEAP_FREE_ENTRY FreeEntry) { Modified: trunk/reactos/lib/rtl/image.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/rtl/image.c?rev=63016&… ============================================================================== --- trunk/reactos/lib/rtl/image.c [iso-8859-1] (original) +++ trunk/reactos/lib/rtl/image.c [iso-8859-1] Sun Apr 27 12:45:51 2014 @@ -20,8 +20,8 @@ /* FUNCTIONS *****************************************************************/ +FORCEINLINE USHORT -FORCEINLINE ChkSum(ULONG Sum, PUSHORT Src, ULONG Len) { ULONG i;

1 0

[pschweitzer] 63015: [RTL] Properly declare with FORCEINLINE
by pschweitzer＠svn.reactos.org 27 Apr '14

27 Apr '14

Author: pschweitzer Date: Sun Apr 27 12:34:39 2014 New Revision: 63015 URL: http://svn.reactos.org/svn/reactos?rev=63015&view=rev Log: [RTL] Properly declare with FORCEINLINE Modified: trunk/reactos/lib/rtl/rtlavl.h Modified: trunk/reactos/lib/rtl/rtlavl.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/rtl/rtlavl.h?rev=63015… ============================================================================== --- trunk/reactos/lib/rtl/rtlavl.h [iso-8859-1] (original) +++ trunk/reactos/lib/rtl/rtlavl.h [iso-8859-1] Sun Apr 27 12:34:39 2014 @@ -24,16 +24,16 @@ #define RtlInsertAsLeftChildAvl RtlInsertAsLeftChild #define RtlIsLeftChildAvl RtlIsLeftChild +FORCEINLINE VOID -FORCEINLINE RtlpCopyAvlNodeData(IN PRTL_BALANCED_LINKS Node1, IN PRTL_BALANCED_LINKS Node2) { *Node1 = *Node2; } +FORCEINLINE RTL_GENERIC_COMPARE_RESULTS -FORCEINLINE RtlpAvlCompareRoutine(IN PRTL_AVL_TABLE Table, IN PVOID Buffer, IN PVOID UserData) @@ -44,24 +44,24 @@ UserData); } +FORCEINLINE VOID -FORCEINLINE RtlSetParent(IN PRTL_BALANCED_LINKS Node, IN PRTL_BALANCED_LINKS Parent) { Node->Parent = Parent; } +FORCEINLINE VOID -FORCEINLINE RtlSetBalance(IN PRTL_BALANCED_LINKS Node, IN CHAR Balance) { Node->Balance = Balance; } +FORCEINLINE CHAR -FORCEINLINE RtlBalance(IN PRTL_BALANCED_LINKS Node) { return Node->Balance;

1 0

[pschweitzer] 63014: [NTOSKRNL] Few fixes to IopGetBasicInformationFile() and NtSetInformationFile(). Spotted by Thomas
by pschweitzer＠svn.reactos.org 27 Apr '14

27 Apr '14

Author: pschweitzer Date: Sun Apr 27 11:14:16 2014 New Revision: 63014 URL: http://svn.reactos.org/svn/reactos?rev=63014&view=rev Log: [NTOSKRNL] Few fixes to IopGetBasicInformationFile() and NtSetInformationFile(). Spotted by Thomas Modified: trunk/reactos/ntoskrnl/io/iomgr/iofunc.c Modified: trunk/reactos/ntoskrnl/io/iomgr/iofunc.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/io/iomgr/iofunc.c… ============================================================================== --- trunk/reactos/ntoskrnl/io/iomgr/iofunc.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/io/iomgr/iofunc.c [iso-8859-1] Sun Apr 27 11:14:16 2014 @@ -710,7 +710,7 @@ if (DeviceObject->DriverObject->FastIoDispatch != NULL && DeviceObject->DriverObject->FastIoDispatch->FastIoQueryBasicInfo != NULL && DeviceObject->DriverObject->FastIoDispatch->FastIoQueryBasicInfo(FileObject, - (FileObject->Flags & FO_SYNCHRONOUS_IO), + ((FileObject->Flags & FO_SYNCHRONOUS_IO) != 0), BasicInfo, &IoStatusBlock, DeviceObject)) @@ -2446,7 +2446,7 @@ PFILE_COMPLETION_INFORMATION CompletionInfo = FileInformation; PIO_COMPLETION_CONTEXT Context; PFILE_RENAME_INFORMATION RenameInfo; - HANDLE TargetHandle = INVALID_HANDLE_VALUE; + HANDLE TargetHandle = NULL; PAGED_CODE(); IOTRACE(IO_API_DEBUG, "FileHandle: %p\n", FileHandle); @@ -2744,6 +2744,11 @@ Status = IoCallDriver(DeviceObject, Irp); } } + else + { + Status = STATUS_INVALID_PARAMETER; + Irp->IoStatus.Status = Status; + } } else { @@ -2836,7 +2841,7 @@ if (!LocalEvent) IopUnlockFileObject(FileObject); } - if (TargetHandle != INVALID_HANDLE_VALUE) + if (TargetHandle != NULL) { ObCloseHandle(TargetHandle, KernelMode); }

1 0

[cwittich] 63013: [devmgmt] improve keyboard navigation
by cwittich＠svn.reactos.org 27 Apr '14

27 Apr '14

Author: cwittich Date: Sun Apr 27 08:15:59 2014 New Revision: 63013 URL: http://svn.reactos.org/svn/reactos?rev=63013&view=rev Log: [devmgmt] improve keyboard navigation Modified: trunk/reactos/base/applications/mscutils/devmgmt/mainwnd.c Modified: trunk/reactos/base/applications/mscutils/devmgmt/mainwnd.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… ============================================================================== --- trunk/reactos/base/applications/mscutils/devmgmt/mainwnd.c [iso-8859-1] (original) +++ trunk/reactos/base/applications/mscutils/devmgmt/mainwnd.c [iso-8859-1] Sun Apr 27 08:15:59 2014 @@ -304,7 +304,7 @@ 0); SetMenuDefaultItem(Info->hShortcutMenu, IDC_PROP, FALSE); - /* create seperate thread to emum devices */ + /* create separate thread to emum devices */ DevEnumThread = CreateThread(NULL, 0, DeviceEnumThread, @@ -418,6 +418,23 @@ } break; + case NM_RETURN: + { + HTREEITEM hSelected = TreeView_GetSelection(Info->hTreeView); + if (Info->Display == DevicesByType) + { + OpenPropSheet(Info->hTreeView, hSelected); + } + else if (Info->Display == DevicesByConnection) + { + if (hSelected != TreeView_GetRoot(Info->hTreeView)) + { + OpenPropSheet(Info->hTreeView, hSelected); + } + } + } + break; + case NM_DBLCLK: { HTREEITEM hSelected = TreeView_GetSelection(Info->hTreeView);

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs