Ros-diffs

ros-diffs@reactos.org

81390 discussions

[pschweitzer] 62664: [MOUNTMGR] - Fix broken logic in OnlineMountedVolumes() - Add missing return in MountMgrNotifyNameChange() CID #515247 CID #716002
by pschweitzer＠svn.reactos.org 06 Apr '14

06 Apr '14

Author: pschweitzer Date: Sun Apr 6 16:30:29 2014 New Revision: 62664 URL: http://svn.reactos.org/svn/reactos?rev=62664&view=rev Log: [MOUNTMGR] - Fix broken logic in OnlineMountedVolumes() - Add missing return in MountMgrNotifyNameChange() CID #515247 CID #716002 Modified: trunk/reactos/drivers/filters/mountmgr/database.c trunk/reactos/drivers/filters/mountmgr/notify.c Modified: trunk/reactos/drivers/filters/mountmgr/database.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filters/mountmgr/d… ============================================================================== --- trunk/reactos/drivers/filters/mountmgr/database.c [iso-8859-1] (original) +++ trunk/reactos/drivers/filters/mountmgr/database.c [iso-8859-1] Sun Apr 6 16:30:29 2014 @@ -746,10 +746,11 @@ return; } + RestartScan = TRUE; + /* Query mount points */ while (TRUE) { - RestartScan = TRUE; SymbolicName.Length = 0; SymbolicName.MaximumLength = sizeof(SymbolicNameBuffer); SymbolicName.Buffer = SymbolicNameBuffer; @@ -771,8 +772,7 @@ if (ReparsePointInformation.FileReference == SavedReparsePointInformation.FileReference && ReparsePointInformation.Tag == SavedReparsePointInformation.Tag) { - ZwClose(Handle); - return; + break; } } else @@ -782,8 +782,7 @@ if (!NT_SUCCESS(Status) || ReparsePointInformation.Tag != IO_REPARSE_TAG_MOUNT_POINT) { - ZwClose(Handle); - return; + break; } /* Get the volume name associated to the mount point */ @@ -813,6 +812,8 @@ PostOnlineNotification(DeviceExtension, &VolumeDeviceInformation->SymbolicName); } } + + ZwClose(Handle); } /* Modified: trunk/reactos/drivers/filters/mountmgr/notify.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filters/mountmgr/n… ============================================================================== --- trunk/reactos/drivers/filters/mountmgr/notify.c [iso-8859-1] (original) +++ trunk/reactos/drivers/filters/mountmgr/notify.c [iso-8859-1] Sun Apr 6 16:30:29 2014 @@ -414,6 +414,7 @@ { ObDereferenceObject(DeviceObject); ObDereferenceObject(FileObject); + return; } Stack = IoGetNextIrpStackLocation(Irp);

1 0

[pschweitzer] 62663: [NPFS] - Also call NpQueryNameInfo() in FileAllInformation and return its status. This prevents from returning uninit status - By default, return STATUS_ILLEGAL_FUNCTION in NpI...
by pschweitzer＠svn.reactos.org 06 Apr '14

06 Apr '14

Author: pschweitzer Date: Sun Apr 6 16:15:06 2014 New Revision: 62663 URL: http://svn.reactos.org/svn/reactos?rev=62663&view=rev Log: [NPFS] - Also call NpQueryNameInfo() in FileAllInformation and return its status. This prevents from returning uninit status - By default, return STATUS_ILLEGAL_FUNCTION in NpImpersonate(). This prevents from returning uninit status - Fix comparison in NpQueryFsVolumeInfo() (remaining len is to be used) - Properly set the string without space. This allows setting the complete string with 18 bytes. CID #1102019 CID #1102505 CID #1102506 Modified: trunk/reactos/drivers/filesystems/npfs/fileinfo.c trunk/reactos/drivers/filesystems/npfs/fsctrl.c trunk/reactos/drivers/filesystems/npfs/volinfo.c Modified: trunk/reactos/drivers/filesystems/npfs/fileinfo.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/npfs/f… ============================================================================== --- trunk/reactos/drivers/filesystems/npfs/fileinfo.c [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/npfs/fileinfo.c [iso-8859-1] Sun Apr 6 16:15:06 2014 @@ -440,6 +440,7 @@ NpQueryInternalInfo(Ccb, &AllInfo->InternalInformation, &Length); NpQueryEaInfo(Ccb, &AllInfo->EaInformation, &Length); NpQueryPositionInfo(Ccb, &AllInfo->PositionInformation, &Length, NamedPipeEnd); + Status = NpQueryNameInfo(Ccb, &AllInfo->NameInformation, &Length); Length += 96; break; Modified: trunk/reactos/drivers/filesystems/npfs/fsctrl.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/npfs/f… ============================================================================== --- trunk/reactos/drivers/filesystems/npfs/fsctrl.c [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/npfs/fsctrl.c [iso-8859-1] Sun Apr 6 16:15:06 2014 @@ -241,16 +241,13 @@ IoStack = IoGetCurrentIrpStackLocation(Irp); NodeTypeCode = NpDecodeFileObject(IoStack->FileObject, NULL, &Ccb, &NamedPipeEnd); - if (NodeTypeCode == NPFS_NTC_CCB) - { - if (NamedPipeEnd == FILE_PIPE_SERVER_END) - { - Status = NpImpersonateClientContext(Ccb); - } - else - { - Status = STATUS_ILLEGAL_FUNCTION; - } + if (NodeTypeCode == NPFS_NTC_CCB && NamedPipeEnd == FILE_PIPE_SERVER_END) + { + Status = NpImpersonateClientContext(Ccb); + } + else + { + Status = STATUS_ILLEGAL_FUNCTION; } return Status; Modified: trunk/reactos/drivers/filesystems/npfs/volinfo.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/npfs/v… ============================================================================== --- trunk/reactos/drivers/filesystems/npfs/volinfo.c [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/npfs/volinfo.c [iso-8859-1] Sun Apr 6 16:15:06 2014 @@ -35,7 +35,7 @@ NameLength = 18; InfoBuffer->VolumeLabelLength = 18; - if (NameLength < 18) + if (*Length < 18) { NameLength = (USHORT)*Length; Status = STATUS_BUFFER_OVERFLOW; @@ -45,7 +45,7 @@ Status = STATUS_SUCCESS; } - RtlCopyMemory(InfoBuffer->VolumeLabel, L"Named Pipe", NameLength); + RtlCopyMemory(InfoBuffer->VolumeLabel, L"NamedPipe", NameLength); *Length -= NameLength; TRACE("Leaving, Status = %lx\n", Status);

1 0

[hbelusca] 62662: [NTDLL_APITEST]: Add braces and remove an unneeded trace.
by hbelusca＠svn.reactos.org 06 Apr '14

06 Apr '14

Author: hbelusca Date: Sun Apr 6 15:51:38 2014 New Revision: 62662 URL: http://svn.reactos.org/svn/reactos?rev=62662&view=rev Log: [NTDLL_APITEST]: Add braces and remove an unneeded trace. Modified: trunk/rostests/apitests/ntdll/RtlGetFullPathName_UstrEx.c Modified: trunk/rostests/apitests/ntdll/RtlGetFullPathName_UstrEx.c URL: http://svn.reactos.org/svn/reactos/trunk/rostests/apitests/ntdll/RtlGetFull… ============================================================================== --- trunk/rostests/apitests/ntdll/RtlGetFullPathName_UstrEx.c [iso-8859-1] (original) +++ trunk/rostests/apitests/ntdll/RtlGetFullPathName_UstrEx.c [iso-8859-1] Sun Apr 6 15:51:38 2014 @@ -102,11 +102,13 @@ SIZE_T i; for (i = 0; i < Size; i++) + { if (Array[i] != Value) { trace("Expected %x, found %x at offset %lu\n", Value, Array[i], (ULONG)i); return FALSE; } + } return TRUE; } @@ -188,7 +190,6 @@ for (i = 0; i < TestCount; i++) { - trace("i = %d\n", i); switch (TestCases[i].PrefixType) { case PrefixNone:

1 0

[pschweitzer] 62661: [FASTFAT] Remove dead code CID #502185
by pschweitzer＠svn.reactos.org 06 Apr '14

06 Apr '14

Author: pschweitzer Date: Sun Apr 6 15:49:38 2014 New Revision: 62661 URL: http://svn.reactos.org/svn/reactos?rev=62661&view=rev Log: [FASTFAT] Remove dead code CID #502185 Modified: trunk/reactos/drivers/filesystems/fastfat/fsctl.c Modified: trunk/reactos/drivers/filesystems/fastfat/fsctl.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/fastfa… ============================================================================== --- trunk/reactos/drivers/filesystems/fastfat/fsctl.c [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/fastfat/fsctl.c [iso-8859-1] Sun Apr 6 15:49:38 2014 @@ -617,8 +617,6 @@ vfatDestroyCCB(Ccb); if (DeviceObject) IoDeleteDevice(DeviceObject); - if (VolumeFcb) - vfatDestroyFCB(VolumeFcb); } return Status;

1 0

[pschweitzer] 62660: [CDFS] - Fix broken if statement - Remove deadcode CID #502181 CID #502438 CID #716663
by pschweitzer＠svn.reactos.org 06 Apr '14

06 Apr '14

Author: pschweitzer Date: Sun Apr 6 15:43:06 2014 New Revision: 62660 URL: http://svn.reactos.org/svn/reactos?rev=62660&view=rev Log: [CDFS] - Fix broken if statement - Remove deadcode CID #502181 CID #502438 CID #716663 Modified: trunk/reactos/drivers/filesystems/cdfs/dirctl.c trunk/reactos/drivers/filesystems/cdfs/fsctl.c Modified: trunk/reactos/drivers/filesystems/cdfs/dirctl.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/cdfs/d… ============================================================================== --- trunk/reactos/drivers/filesystems/cdfs/dirctl.c [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/cdfs/dirctl.c [iso-8859-1] Sun Apr 6 15:43:06 2014 @@ -303,7 +303,7 @@ if (FsRtlIsNameInExpression(&FileToFindUpcase, &LongName, TRUE, NULL) || FsRtlIsNameInExpression(&FileToFindUpcase, &ShortName, TRUE, NULL)) { - if (Parent && Parent->PathName) + if (Parent->PathName[0]) { len = wcslen(Parent->PathName); memcpy(Fcb->PathName, Parent->PathName, len*sizeof(WCHAR)); Modified: trunk/reactos/drivers/filesystems/cdfs/fsctl.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/cdfs/f… ============================================================================== --- trunk/reactos/drivers/filesystems/cdfs/fsctl.c [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/cdfs/fsctl.c [iso-8859-1] Sun Apr 6 15:43:06 2014 @@ -439,8 +439,6 @@ ObDereferenceObject(DeviceExt->StreamFileObject); if (Fcb) ExFreePool(Fcb); - if (Ccb) - ExFreePool(Ccb); if (NewDeviceObject) IoDeleteDevice(NewDeviceObject); }

1 0

[pschweitzer] 62659: [SYSSETUP] Fix buffer overrun CID #716146
by pschweitzer＠svn.reactos.org 06 Apr '14

06 Apr '14

Author: pschweitzer Date: Sun Apr 6 15:31:06 2014 New Revision: 62659 URL: http://svn.reactos.org/svn/reactos?rev=62659&view=rev Log: [SYSSETUP] Fix buffer overrun CID #716146 Modified: trunk/reactos/dll/win32/syssetup/logfile.c Modified: trunk/reactos/dll/win32/syssetup/logfile.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/syssetup/logfile… ============================================================================== --- trunk/reactos/dll/win32/syssetup/logfile.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/syssetup/logfile.c [iso-8859-1] Sun Apr 6 15:31:06 2014 @@ -45,11 +45,11 @@ { wcsncat(szFileName, L"\\", - MAX_PATH); + (sizeof(szFileName) / sizeof(szFileName[0])) - wcslen(szFileName)); } wcsncat(szFileName, L"setuplog.txt", - MAX_PATH); + (sizeof(szFileName) / sizeof(szFileName[0])) - wcslen(szFileName)); if (bDeleteOldLogFile) {

1 0

[pschweitzer] 62658: [LSASRV] Fix broken if statements CID #513328 CID #1102024
by pschweitzer＠svn.reactos.org 06 Apr '14

06 Apr '14

Author: pschweitzer Date: Sun Apr 6 15:11:09 2014 New Revision: 62658 URL: http://svn.reactos.org/svn/reactos?rev=62658&view=rev Log: [LSASRV] Fix broken if statements CID #513328 CID #1102024 Modified: trunk/reactos/dll/win32/lsasrv/privileges.c Modified: trunk/reactos/dll/win32/lsasrv/privileges.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/lsasrv/privilege… ============================================================================== --- trunk/reactos/dll/win32/lsasrv/privileges.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/lsasrv/privileges.c [iso-8859-1] Sun Apr 6 15:11:09 2014 @@ -101,7 +101,7 @@ NameBuffer->MaximumLength = NameBuffer->Length + sizeof(WCHAR); NameBuffer->Buffer = MIDL_user_allocate(NameBuffer->MaximumLength); - if (NameBuffer == NULL) + if (NameBuffer->Buffer == NULL) { MIDL_user_free(NameBuffer); return STATUS_NO_MEMORY; @@ -257,7 +257,7 @@ NameBuffer->MaximumLength = NameBuffer->Length + sizeof(WCHAR); NameBuffer->Buffer = MIDL_user_allocate(NameBuffer->MaximumLength); - if (NameBuffer == NULL) + if (NameBuffer->Buffer == NULL) { MIDL_user_free(NameBuffer); return STATUS_INSUFFICIENT_RESOURCES;

1 0

[pschweitzer] 62657: [KERNEL32] - Fix buffer overrun - Fix incorrect return check CID #514675 CID #716130 CID #731615
by pschweitzer＠svn.reactos.org 06 Apr '14

06 Apr '14

Author: pschweitzer Date: Sun Apr 6 14:24:00 2014 New Revision: 62657 URL: http://svn.reactos.org/svn/reactos?rev=62657&view=rev Log: [KERNEL32] - Fix buffer overrun - Fix incorrect return check CID #514675 CID #716130 CID #731615 Modified: trunk/reactos/dll/win32/kernel32/client/compname.c trunk/reactos/dll/win32/kernel32/client/file/copy.c trunk/reactos/dll/win32/kernel32/client/vdm.c Modified: trunk/reactos/dll/win32/kernel32/client/compname.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/client/… ============================================================================== --- trunk/reactos/dll/win32/kernel32/client/compname.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/kernel32/client/compname.c [iso-8859-1] Sun Apr 6 14:24:00 2014 @@ -301,10 +301,12 @@ GetComputerNameA(LPSTR lpBuffer, LPDWORD lpnSize) { BOOL ret; + ret = GetComputerNameExA(ComputerNameNetBIOS, lpBuffer, lpnSize); - if(!ret && GetLastError() == ERROR_MORE_DATA) - SetLastError(ERROR_BUFFER_OVERFLOW); - return ret; + if (!ret && GetLastError() == ERROR_MORE_DATA) + SetLastError(ERROR_BUFFER_OVERFLOW); + + return ret; } Modified: trunk/reactos/dll/win32/kernel32/client/file/copy.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/client/… ============================================================================== --- trunk/reactos/dll/win32/kernel32/client/file/copy.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/kernel32/client/file/copy.c [iso-8859-1] Sun Apr 6 14:24:00 2014 @@ -325,7 +325,7 @@ PUNICODE_STRING lpExistingFileNameW; lpExistingFileNameW = Basep8BitStringToStaticUnicodeString(lpExistingFileName); - if (!lpExistingFileName) + if (!lpExistingFileNameW) { return FALSE; } Modified: trunk/reactos/dll/win32/kernel32/client/vdm.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/client/… ============================================================================== --- trunk/reactos/dll/win32/kernel32/client/vdm.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/kernel32/client/vdm.c [iso-8859-1] Sun Apr 6 14:24:00 2014 @@ -232,7 +232,7 @@ * %s%c : Nothing if DOS VDM, -w if WoW VDM, -ws if separate WoW VDM. */ _snwprintf(CommandLine, - sizeof(CommandLine), + sizeof(CommandLine) / sizeof(CommandLine[0]), L"\"%s\\ntvdm.exe\" -i%lx %s%c", Buffer, DosSeqId, @@ -246,7 +246,7 @@ * %s%c : Nothing if DOS VDM, -w if WoW VDM, -ws if separate WoW VDM. */ _snwprintf(CommandLine, - sizeof(CommandLine), + sizeof(CommandLine) / sizeof(CommandLine[0]), L"\"%s\\ntvdm.exe\" %s%c", Buffer, (BinaryType == BINARY_TYPE_DOS) ? L" " : L"-w",

1 0

[pschweitzer] 62656: [SYSDM] Fix memory leaks CID #716341 CID #716342
by pschweitzer＠svn.reactos.org 06 Apr '14

06 Apr '14

Author: pschweitzer Date: Sun Apr 6 13:50:53 2014 New Revision: 62656 URL: http://svn.reactos.org/svn/reactos?rev=62656&view=rev Log: [SYSDM] Fix memory leaks CID #716341 CID #716342 Modified: trunk/reactos/dll/cpl/sysdm/environment.c Modified: trunk/reactos/dll/cpl/sysdm/environment.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/cpl/sysdm/environment.… ============================================================================== --- trunk/reactos/dll/cpl/sysdm/environment.c [iso-8859-1] (original) +++ trunk/reactos/dll/cpl/sysdm/environment.c [iso-8859-1] Sun Apr 6 13:50:53 2014 @@ -199,7 +199,7 @@ lpData = GlobalAlloc(GPTR, (dwMaxValueDataLength + 1) * sizeof(TCHAR)); if (lpData == NULL) { - GlobalFree(lpData); + GlobalFree(lpName); RegCloseKey(hKey); return; } @@ -227,6 +227,7 @@ (LPBYTE)lpData, &dwDataLength)) { + GlobalFree(lpExpandData); GlobalFree(lpName); GlobalFree(lpData); RegCloseKey(hKey);

1 0

[pschweitzer] 62655: [INPUT] Fix buffer overrun CID #716118
by pschweitzer＠svn.reactos.org 06 Apr '14

06 Apr '14

Author: pschweitzer Date: Sun Apr 6 13:42:27 2014 New Revision: 62655 URL: http://svn.reactos.org/svn/reactos?rev=62655&view=rev Log: [INPUT] Fix buffer overrun CID #716118 Modified: trunk/reactos/dll/cpl/input/add.c Modified: trunk/reactos/dll/cpl/input/add.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/cpl/input/add.c?rev=62… ============================================================================== --- trunk/reactos/dll/cpl/input/add.c [iso-8859-1] (original) +++ trunk/reactos/dll/cpl/input/add.c [iso-8859-1] Sun Apr 6 13:42:27 2014 @@ -221,7 +221,7 @@ Lcid = _tcstoul(lpLanguage, NULL, 16); - GetLocaleInfo(Lcid, LOCALE_SLANGUAGE, Lang, sizeof(Lang)); + GetLocaleInfo(Lcid, LOCALE_SLANGUAGE, Lang, sizeof(Lang) / sizeof(Lang[0])); Index = (INT)SendMessage(hLangList, CB_ADDSTRING, 0, (LPARAM)Lang);

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs