Ros-diffs

ros-diffs@reactos.org

81390 discussions

[pschweitzer] 62654: [DESK] Fix leaks CID #716336 CID #716337
by pschweitzer＠svn.reactos.org 06 Apr '14

06 Apr '14

Author: pschweitzer Date: Sun Apr 6 13:38:06 2014 New Revision: 62654 URL: http://svn.reactos.org/svn/reactos?rev=62654&view=rev Log: [DESK] Fix leaks CID #716336 CID #716337 Modified: trunk/reactos/dll/cpl/desk/background.c trunk/reactos/dll/cpl/desk/screensaver.c Modified: trunk/reactos/dll/cpl/desk/background.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/cpl/desk/background.c?… ============================================================================== --- trunk/reactos/dll/cpl/desk/background.c [iso-8859-1] (original) +++ trunk/reactos/dll/cpl/desk/background.c [iso-8859-1] Sun Apr 6 13:38:06 2014 @@ -288,7 +288,7 @@ } if(!FindNextFile(hFind, &fd)) - hFind = INVALID_HANDLE_VALUE; + break; } token = _tcstok(NULL, separators); Modified: trunk/reactos/dll/cpl/desk/screensaver.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/cpl/desk/screensaver.c… ============================================================================== --- trunk/reactos/dll/cpl/desk/screensaver.c [iso-8859-1] (original) +++ trunk/reactos/dll/cpl/desk/screensaver.c [iso-8859-1] Sun Apr 6 13:38:06 2014 @@ -65,7 +65,10 @@ (LPBYTE)lpBuf, &BufSize); if (Ret != ERROR_SUCCESS) + { + HeapFree(GetProcessHeap(), 0, lpBuf); lpBuf = NULL; + } } }

1 0

[pschweitzer] 62653: [ACCESS] Don't leak memory CID #716335
by pschweitzer＠svn.reactos.org 06 Apr '14

06 Apr '14

Author: pschweitzer Date: Sun Apr 6 13:25:28 2014 New Revision: 62653 URL: http://svn.reactos.org/svn/reactos?rev=62653&view=rev Log: [ACCESS] Don't leak memory CID #716335 Modified: trunk/reactos/dll/cpl/access/access.c Modified: trunk/reactos/dll/cpl/access/access.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/cpl/access/access.c?re… ============================================================================== --- trunk/reactos/dll/cpl/access/access.c [iso-8859-1] (original) +++ trunk/reactos/dll/cpl/access/access.c [iso-8859-1] Sun Apr 6 13:25:28 2014 @@ -184,7 +184,10 @@ return 0; if (!ReadSettings(pGlobalData)) + { + HeapFree(GetProcessHeap(), 0, pGlobalData); return 0; + } ZeroMemory(&psh, sizeof(PROPSHEETHEADER)); psh.dwSize = sizeof(PROPSHEETHEADER);

1 0

[pschweitzer] 62652: [FREELDR] Don't call strlen to get max len of an uninit string CID #731721 CID #731722
by pschweitzer＠svn.reactos.org 06 Apr '14

06 Apr '14

Author: pschweitzer Date: Sun Apr 6 13:22:21 2014 New Revision: 62652 URL: http://svn.reactos.org/svn/reactos?rev=62652&view=rev Log: [FREELDR] Don't call strlen to get max len of an uninit string CID #731721 CID #731722 Modified: trunk/reactos/boot/freeldr/freeldr/disk/disk.c Modified: trunk/reactos/boot/freeldr/freeldr/disk/disk.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/disk/… ============================================================================== --- trunk/reactos/boot/freeldr/freeldr/disk/disk.c [iso-8859-1] (original) +++ trunk/reactos/boot/freeldr/freeldr/disk/disk.c [iso-8859-1] Sun Apr 6 13:22:21 2014 @@ -114,7 +114,7 @@ { /* This is a floppy */ - if (Size <= sizeof(Path) + 7 + strlen(Device)) + if (Size <= sizeof(Path) + 7 + sizeof(Device)) { return FALSE; } @@ -142,7 +142,7 @@ FrldrBootPartition = BootPartition; - if (Size <= sizeof(Path) + 18 + strlen(Device) + strlen(Partition)) + if (Size <= sizeof(Path) + 18 + sizeof(Device) + sizeof(Partition)) { return FALSE; } @@ -165,7 +165,7 @@ { /* This is a CD-ROM drive */ - if (Size <= sizeof(Path) + 7 + strlen(Device)) + if (Size <= sizeof(Path) + 7 + sizeof(Device)) { return FALSE; }

1 0

[khornicek] 62651: [WIN32K] - Fix a possible out of bounds read. CID 731665
by khornicek＠svn.reactos.org 06 Apr '14

06 Apr '14

Author: khornicek Date: Sun Apr 6 13:09:04 2014 New Revision: 62651 URL: http://svn.reactos.org/svn/reactos?rev=62651&view=rev Log: [WIN32K] - Fix a possible out of bounds read. CID 731665 Modified: trunk/reactos/win32ss/gdi/ntgdi/freetype.c Modified: trunk/reactos/win32ss/gdi/ntgdi/freetype.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/gdi/ntgdi/freetype… ============================================================================== --- trunk/reactos/win32ss/gdi/ntgdi/freetype.c [iso-8859-1] (original) +++ trunk/reactos/win32ss/gdi/ntgdi/freetype.c [iso-8859-1] Sun Apr 6 13:09:04 2014 @@ -533,19 +533,19 @@ switch (Flags) { case TCI_SRCFONTSIG: - while (0 == (*Src >> Index & 0x0001) && Index < MAXTCIINDEX) + while (Index < MAXTCIINDEX && 0 == (*Src >> Index & 0x0001)) { Index++; } break; case TCI_SRCCODEPAGE: - while ( *Src != FontTci[Index].ciACP && Index < MAXTCIINDEX) + while (Index < MAXTCIINDEX && *Src != FontTci[Index].ciACP) { Index++; } break; case TCI_SRCCHARSET: - while ( *Src != FontTci[Index].ciCharset && Index < MAXTCIINDEX) + while (Index < MAXTCIINDEX && *Src != FontTci[Index].ciCharset) { Index++; }

1 0

[pschweitzer] 62650: [RUNDLL32] Fix resource leak CID #716331
by pschweitzer＠svn.reactos.org 06 Apr '14

06 Apr '14

Author: pschweitzer Date: Sun Apr 6 13:01:41 2014 New Revision: 62650 URL: http://svn.reactos.org/svn/reactos?rev=62650&view=rev Log: [RUNDLL32] Fix resource leak CID #716331 Modified: trunk/reactos/base/system/rundll32/rundll32.c Modified: trunk/reactos/base/system/rundll32/rundll32.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/system/rundll32/rundl… ============================================================================== --- trunk/reactos/base/system/rundll32/rundll32.c [iso-8859-1] (original) +++ trunk/reactos/base/system/rundll32/rundll32.c [iso-8859-1] Sun Apr 6 13:01:41 2014 @@ -428,6 +428,7 @@ if (!RegisterBlankClass(hInstance, hPrevInstance)) { + FreeLibrary(hDll); return 0; } // Create a window so we can pass a window handle to

1 0

[pschweitzer] 62649: [FORMAT] - Check LoadLibrary() return - In case it doesn't match, free library CID #716330
by pschweitzer＠svn.reactos.org 06 Apr '14

06 Apr '14

Author: pschweitzer Date: Sun Apr 6 12:59:01 2014 New Revision: 62649 URL: http://svn.reactos.org/svn/reactos?rev=62649&view=rev Log: [FORMAT] - Check LoadLibrary() return - In case it doesn't match, free library CID #716330 Modified: trunk/reactos/base/system/format/format.c Modified: trunk/reactos/base/system/format/format.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/system/format/format.… ============================================================================== --- trunk/reactos/base/system/format/format.c [iso-8859-1] (original) +++ trunk/reactos/base/system/format/format.c [iso-8859-1] Sun Apr 6 12:59:01 2014 @@ -238,20 +238,24 @@ BOOLEAN LoadFMIFSEntryPoints() { HMODULE hFmifs = LoadLibrary( _T("fmifs.dll") ); + if (hFmifs == NULL) { + return FALSE; + } + if( !(void*) GetProcAddress( hFmifs, "FormatEx" ) ) { - + FreeLibrary(hFmifs); return FALSE; } if( !((void *) GetProcAddress( hFmifs, "EnableVolumeCompression" )) ) { - + FreeLibrary(hFmifs); return FALSE; } if( !((void *) GetProcAddress( hFmifs, "QueryAvailableFileSystemFormat" )) ) { - + FreeLibrary(hFmifs); return FALSE; }

1 0

[pschweitzer] 62648: [TCPSVCS] - Fix buffer overrun - Fix memory leak - Properly init memory CID #511073 CID #1102322 CID #1102405
by pschweitzer＠svn.reactos.org 06 Apr '14

06 Apr '14

Author: pschweitzer Date: Sun Apr 6 12:44:10 2014 New Revision: 62648 URL: http://svn.reactos.org/svn/reactos?rev=62648&view=rev Log: [TCPSVCS] - Fix buffer overrun - Fix memory leak - Properly init memory CID #511073 CID #1102322 CID #1102405 Modified: trunk/reactos/base/services/tcpsvcs/qotd.c trunk/reactos/base/services/tcpsvcs/skelserver.c Modified: trunk/reactos/base/services/tcpsvcs/qotd.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/services/tcpsvcs/qotd… ============================================================================== --- trunk/reactos/base/services/tcpsvcs/qotd.c [iso-8859-1] (original) +++ trunk/reactos/base/services/tcpsvcs/qotd.c [iso-8859-1] Sun Apr 6 12:44:10 2014 @@ -58,7 +58,7 @@ else { DWORD dwSize = GetFileSize(hFile, NULL); - lpQuotes = (LPSTR)HeapAlloc(GetProcessHeap(), 0, dwSize); + lpQuotes = (LPSTR)HeapAlloc(GetProcessHeap(), 0, dwSize + 1); if (!lpQuotes) { CloseHandle(hFile); @@ -75,7 +75,10 @@ lpQuotes[dwSize] = 0; if (dwBytesRead != dwSize) + { + HeapFree(GetProcessHeap(), 0, lpQuotes); return FALSE; + } lpStr = lpQuotes; while (*lpStr) @@ -120,6 +123,7 @@ } } + HeapFree(GetProcessHeap(), 0, lpQuotes); return TRUE; } Modified: trunk/reactos/base/services/tcpsvcs/skelserver.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/services/tcpsvcs/skel… ============================================================================== --- trunk/reactos/base/services/tcpsvcs/skelserver.c [iso-8859-1] (original) +++ trunk/reactos/base/services/tcpsvcs/skelserver.c [iso-8859-1] Sun Apr 6 12:44:10 2014 @@ -21,6 +21,7 @@ sock = socket(AF_INET, SOCK_STREAM, 0); if (sock != INVALID_SOCKET) { + ZeroMemory(&server, sizeof(SOCKADDR_IN)); server.sin_family = AF_INET; server.sin_addr.s_addr = htonl(INADDR_ANY); server.sin_port = Port;

1 0

[pschweitzer] 62647: [EVENTLOG] - Fix memory leak - Fix null pointer dereference CID #515253 CID #716316
by pschweitzer＠svn.reactos.org 06 Apr '14

06 Apr '14

Author: pschweitzer Date: Sun Apr 6 12:35:54 2014 New Revision: 62647 URL: http://svn.reactos.org/svn/reactos?rev=62647&view=rev Log: [EVENTLOG] - Fix memory leak - Fix null pointer dereference CID #515253 CID #716316 Modified: trunk/reactos/base/services/eventlog/file.c trunk/reactos/base/services/eventlog/rpc.c Modified: trunk/reactos/base/services/eventlog/file.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/services/eventlog/fil… ============================================================================== --- trunk/reactos/base/services/eventlog/file.c [iso-8859-1] (original) +++ trunk/reactos/base/services/eventlog/file.c [iso-8859-1] Sun Apr 6 12:35:54 2014 @@ -979,6 +979,7 @@ if (RecBuf->Reserved != LOGFILE_SIGNATURE) { DPRINT1("LogFile corrupt!\n"); + HeapFree(GetProcessHeap(), 0, RecBuf); RtlReleaseResource(&LogFile->Lock); return FALSE; } Modified: trunk/reactos/base/services/eventlog/rpc.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/services/eventlog/rpc… ============================================================================== --- trunk/reactos/base/services/eventlog/rpc.c [iso-8859-1] (original) +++ trunk/reactos/base/services/eventlog/rpc.c [iso-8859-1] Sun Apr 6 12:35:54 2014 @@ -921,20 +921,22 @@ } Done: - for (i = 0; i < NumStrings; i++) - { - if (StringsArrayW[i] != NULL) + if (StringsArrayW != NULL) + { + for (i = 0; i < NumStrings; i++) { - if (StringsArrayW[i]->Buffer) + if (StringsArrayW[i] != NULL) { - RtlFreeUnicodeString(StringsArrayW[i]); - HeapFree(MyHeap, 0, StringsArrayW[i]); + if (StringsArrayW[i]->Buffer) + { + RtlFreeUnicodeString(StringsArrayW[i]); + HeapFree(MyHeap, 0, StringsArrayW[i]); + } } } - } - - if (StringsArrayW != NULL) + HeapFree(MyHeap, 0, StringsArrayW); + } RtlFreeUnicodeString(&ComputerNameW);

1 0

[pschweitzer] 62646: [TASKMGR] Don't leak handle CID #716315
by pschweitzer＠svn.reactos.org 06 Apr '14

06 Apr '14

Author: pschweitzer Date: Sun Apr 6 12:28:25 2014 New Revision: 62646 URL: http://svn.reactos.org/svn/reactos?rev=62646&view=rev Log: [TASKMGR] Don't leak handle CID #716315 Modified: trunk/reactos/base/applications/taskmgr/taskmgr.c Modified: trunk/reactos/base/applications/taskmgr/taskmgr.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/taskmgr/… ============================================================================== --- trunk/reactos/base/applications/taskmgr/taskmgr.c [iso-8859-1] (original) +++ trunk/reactos/base/applications/taskmgr/taskmgr.c [iso-8859-1] Sun Apr 6 12:28:25 2014 @@ -130,6 +130,8 @@ SendMessage(hTaskMgr, WM_SYSCOMMAND, SC_RESTORE, 0); SetForegroundWindow(hTaskMgr); } + + CloseHandle(hMutex); return 0; } else if (!hMutex) @@ -175,6 +177,7 @@ /* Save our settings to the registry */ SaveSettings(); PerfDataUninitialize(); + CloseHandle(hMutex); return 0; }

1 0

[pschweitzer] 62645: [SC] - Remove dead code - Fix check for memory deallocation - Don't leak resource CID #500056 CID #500057 CID #501497 CID #716313
by pschweitzer＠svn.reactos.org 06 Apr '14

06 Apr '14

Author: pschweitzer Date: Sun Apr 6 12:18:05 2014 New Revision: 62645 URL: http://svn.reactos.org/svn/reactos?rev=62645&view=rev Log: [SC] - Remove dead code - Fix check for memory deallocation - Don't leak resource CID #500056 CID #500057 CID #501497 CID #716313 Modified: trunk/reactos/base/applications/sc/query.c trunk/reactos/base/applications/sc/start.c Modified: trunk/reactos/base/applications/sc/query.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/sc/query… ============================================================================== --- trunk/reactos/base/applications/sc/query.c [iso-8859-1] (original) +++ trunk/reactos/base/applications/sc/query.c [iso-8859-1] Sun Apr 6 12:18:05 2014 @@ -135,14 +135,17 @@ &ResumeHandle, 0)) { + CloseServiceHandle(hSCManager); return NumServices; } } } ReportLastError(); - if (pServiceStatus) + if (*pServiceStatus) HeapFree(GetProcessHeap(), 0, *pServiceStatus); + + CloseServiceHandle(hSCManager); return NumServices; } @@ -237,8 +240,5 @@ } } - if (pServiceStatus) - HeapFree(GetProcessHeap(), 0, pServiceStatus); - return TRUE; } Modified: trunk/reactos/base/applications/sc/start.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/sc/start… ============================================================================== --- trunk/reactos/base/applications/sc/start.c [iso-8859-1] (original) +++ trunk/reactos/base/applications/sc/start.c [iso-8859-1] Sun Apr 6 12:18:05 2014 @@ -74,7 +74,6 @@ fail: ReportLastError(); - if (pServiceInfo) HeapFree(GetProcessHeap(), 0, pServiceInfo); if (hSc) CloseServiceHandle(hSc); if (hSCManager) CloseServiceHandle(hSCManager); return FALSE;

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs