Ros-diffs

ros-diffs@reactos.org

81390 discussions

[gadamopoulos] 62143: [shell32] - Implement showing the target type in shortcut properties dialog - Patch by Edijs Kolesnikovics - See CORE-7366
by gadamopoulos＠svn.reactos.org 13 Feb '14

13 Feb '14

Author: gadamopoulos Date: Thu Feb 13 11:10:47 2014 New Revision: 62143 URL: http://svn.reactos.org/svn/reactos?rev=62143&view=rev Log: [shell32] - Implement showing the target type in shortcut properties dialog - Patch by Edijs Kolesnikovics - See CORE-7366 Modified: trunk/reactos/dll/win32/shell32/shelllink.cpp Modified: trunk/reactos/dll/win32/shell32/shelllink.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/shelllin… ============================================================================== --- trunk/reactos/dll/win32/shell32/shelllink.cpp [iso-8859-1] (original) +++ trunk/reactos/dll/win32/shell32/shelllink.cpp [iso-8859-1] Thu Feb 13 11:10:47 2014 @@ -76,6 +76,43 @@ #include "poppack.h" +/************************************************************************** +* SH_GetTargetTypeByPath +* +* Function to get target type by passing full path to it +*/ +LPWSTR SH_GetTargetTypeByPath(LPCWSTR lpcwFullPath) +{ + LPCWSTR pwszExt; + static WCHAR wszBuf[MAX_PATH]; + + /* Get file information */ + SHFILEINFO fi; + if (!SHGetFileInfoW(lpcwFullPath, 0, &fi, sizeof(fi), SHGFI_TYPENAME | SHGFI_USEFILEATTRIBUTES )) + { + ERR("SHGetFileInfoW failed for %ls (%lu)\n", lpcwFullPath, GetLastError()); + fi.szTypeName[0] = L'\0'; + fi.hIcon = NULL; + } + + pwszExt = PathFindExtensionW(lpcwFullPath); + if (pwszExt[0]) + { + if (!fi.szTypeName[0]) + { + /* The file type is unknown, so default to string "FileExtension File" */ + size_t cchRemaining = 0; + LPWSTR pwszEnd = NULL; + + StringCchPrintfExW(wszBuf, _countof(wszBuf), &pwszEnd, &cchRemaining, 0, L"%s ", pwszExt + 1); + } + else + StringCbPrintfW(wszBuf, sizeof(wszBuf), L"%s (%s)", fi.szTypeName, pwszExt); /* Update file type */ + } + + return wszBuf; +} + /* IShellLink Implementation */ static HRESULT ShellLink_UpdatePath(LPCWSTR sPathRel, LPCWSTR path, LPCWSTR sWorkDir, LPWSTR* psPath); @@ -1949,6 +1986,10 @@ else ERR("ExtractIconW failed %ls %u\n", pThis->sIcoPath, pThis->iIcoNdx); + /* target type */ + if (pThis->sPath) + SetDlgItemTextW(hwndDlg, 14005, SH_GetTargetTypeByPath(pThis->sPath)); + /* target location */ if (pThis->sWorkDir) SetDlgItemTextW(hwndDlg, 14007, PathFindFileName(pThis->sWorkDir));

1 0

[hbelusca] 62142: [REACTOS] Revert r62140 per Alex request. Alex, why did we choose Win2k3 SP1 at first, and not SP2 directly? CORE-6611 #comment Reverted in r62142.
by hbelusca＠svn.reactos.org 12 Feb '14

12 Feb '14

Author: hbelusca Date: Wed Feb 12 22:58:13 2014 New Revision: 62142 URL: http://svn.reactos.org/svn/reactos?rev=62142&view=rev Log: [REACTOS] Revert r62140 per Alex request. Alex, why did we choose Win2k3 SP1 at first, and not SP2 directly? CORE-6611 #comment Reverted in r62142. Modified: trunk/reactos/boot/bootdata/hivesys.inf trunk/reactos/include/psdk/ntverp.h trunk/reactos/ntoskrnl/ex/init.c Modified: trunk/reactos/boot/bootdata/hivesys.inf URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/bootdata/hivesys.inf?… ============================================================================== --- trunk/reactos/boot/bootdata/hivesys.inf [iso-8859-1] (original) +++ trunk/reactos/boot/bootdata/hivesys.inf [iso-8859-1] Wed Feb 12 22:58:13 2014 @@ -1143,8 +1143,8 @@ ; ReactOS specific - by default we report ourselves as Server for the user, ; but we can also report as Workstation if some application needs it. HKLM,"SYSTEM\CurrentControlSet\Control\ReactOS\Settings\Version","ReportAsWorkstation",0x00010001,0x00000000 -; Some installers check for SP2 -HKLM,"SYSTEM\CurrentControlSet\Control\Windows","CSDVersion",0x00010001,0x00000200 +; Some installers check for SP1 +HKLM,"SYSTEM\CurrentControlSet\Control\Windows","CSDVersion",0x00010001,0x00000100 HKLM,"SYSTEM\CurrentControlSet\Control\SecurityProviders","SecurityProviders",2,"schannel.dll" HKLM,"SYSTEM\CurrentControlSet\Control\SecurityProviders\SaslProfiles",,0x00000012 Modified: trunk/reactos/include/psdk/ntverp.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/psdk/ntverp.h?rev=… ============================================================================== --- trunk/reactos/include/psdk/ntverp.h [iso-8859-1] (original) +++ trunk/reactos/include/psdk/ntverp.h [iso-8859-1] Wed Feb 12 22:58:13 2014 @@ -14,10 +14,10 @@ */ // -// Windows NT Build 3790.3959 +// Windows NT Build 3790.1830 // #define VER_PRODUCTBUILD 3790 -#define VER_PRODUCTBUILD_QFE 3959 +#define VER_PRODUCTBUILD_QFE 1830 // // Windows NT Version 5.2 Modified: trunk/reactos/ntoskrnl/ex/init.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ex/init.c?rev=621… ============================================================================== --- trunk/reactos/ntoskrnl/ex/init.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/ex/init.c [iso-8859-1] Wed Feb 12 22:58:13 2014 @@ -1072,12 +1072,12 @@ /* Setup initial system settings */ CmGetSystemControlValues(LoaderBlock->RegistryBase, CmControlVector); - /* Load static defaults for Service Pack 2 and add our SVN revision */ + /* Load static defaults for Service Pack 1 and add our SVN revision */ /* Format of CSD : SPMajor - SPMinor */ - CmNtCSDVersion = 0x200 | (KERNEL_VERSION_BUILD_HEX << 16); + CmNtCSDVersion = 0x100 | (KERNEL_VERSION_BUILD_HEX << 16); CmNtCSDReleaseType = 0; - /* Set Service Pack data for Service Pack 2 */ + /* Set Service Pack data for Service Pack 1 */ CmNtSpBuildNumber = VER_PRODUCTBUILD_QFE; if (!(CmNtCSDVersion & 0xFFFF0000)) {

1 0

[akhaldi] 62141: [CMAKE] * Improve the dummy definitions.
by akhaldi＠svn.reactos.org 12 Feb '14

12 Feb '14

Author: akhaldi Date: Wed Feb 12 22:12:52 2014 New Revision: 62141 URL: http://svn.reactos.org/svn/reactos?rev=62141&view=rev Log: [CMAKE] * Improve the dummy definitions. Modified: trunk/reactos/cmake/gcc.cmake trunk/reactos/cmake/msvc.cmake Modified: trunk/reactos/cmake/gcc.cmake URL: http://svn.reactos.org/svn/reactos/trunk/reactos/cmake/gcc.cmake?rev=62141&… ============================================================================== --- trunk/reactos/cmake/gcc.cmake [iso-8859-1] (original) +++ trunk/reactos/cmake/gcc.cmake [iso-8859-1] Wed Feb 12 22:12:52 2014 @@ -329,7 +329,7 @@ endforeach() endmacro() else() - macro(add_pch _target_name _FILE) + macro(add_pch _target _pch _sources) endmacro() endif() Modified: trunk/reactos/cmake/msvc.cmake URL: http://svn.reactos.org/svn/reactos/trunk/reactos/cmake/msvc.cmake?rev=62141… ============================================================================== --- trunk/reactos/cmake/msvc.cmake [iso-8859-1] (original) +++ trunk/reactos/cmake/msvc.cmake [iso-8859-1] Wed Feb 12 22:12:52 2014 @@ -157,7 +157,7 @@ endforeach() endmacro() else() - macro(add_pch _target_name _FILE) + macro(add_pch _target _pch _sources) endmacro() endif()

1 0

[hbelusca] 62140: [REACTOS] Go fully to Win2k3 SP2 version reporting. CORE-6611 #resolve #comment Fixed in r62140.
by hbelusca＠svn.reactos.org 12 Feb '14

12 Feb '14

Author: hbelusca Date: Wed Feb 12 20:03:57 2014 New Revision: 62140 URL: http://svn.reactos.org/svn/reactos?rev=62140&view=rev Log: [REACTOS] Go fully to Win2k3 SP2 version reporting. CORE-6611 #resolve #comment Fixed in r62140. Modified: trunk/reactos/boot/bootdata/hivesys.inf trunk/reactos/include/psdk/ntverp.h trunk/reactos/ntoskrnl/ex/init.c Modified: trunk/reactos/boot/bootdata/hivesys.inf URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/bootdata/hivesys.inf?… ============================================================================== --- trunk/reactos/boot/bootdata/hivesys.inf [iso-8859-1] (original) +++ trunk/reactos/boot/bootdata/hivesys.inf [iso-8859-1] Wed Feb 12 20:03:57 2014 @@ -1143,8 +1143,8 @@ ; ReactOS specific - by default we report ourselves as Server for the user, ; but we can also report as Workstation if some application needs it. HKLM,"SYSTEM\CurrentControlSet\Control\ReactOS\Settings\Version","ReportAsWorkstation",0x00010001,0x00000000 -; Some installers check for SP1 -HKLM,"SYSTEM\CurrentControlSet\Control\Windows","CSDVersion",0x00010001,0x00000100 +; Some installers check for SP2 +HKLM,"SYSTEM\CurrentControlSet\Control\Windows","CSDVersion",0x00010001,0x00000200 HKLM,"SYSTEM\CurrentControlSet\Control\SecurityProviders","SecurityProviders",2,"schannel.dll" HKLM,"SYSTEM\CurrentControlSet\Control\SecurityProviders\SaslProfiles",,0x00000012 Modified: trunk/reactos/include/psdk/ntverp.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/psdk/ntverp.h?rev=… ============================================================================== --- trunk/reactos/include/psdk/ntverp.h [iso-8859-1] (original) +++ trunk/reactos/include/psdk/ntverp.h [iso-8859-1] Wed Feb 12 20:03:57 2014 @@ -14,10 +14,10 @@ */ // -// Windows NT Build 3790.1830 +// Windows NT Build 3790.3959 // #define VER_PRODUCTBUILD 3790 -#define VER_PRODUCTBUILD_QFE 1830 +#define VER_PRODUCTBUILD_QFE 3959 // // Windows NT Version 5.2 Modified: trunk/reactos/ntoskrnl/ex/init.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ex/init.c?rev=621… ============================================================================== --- trunk/reactos/ntoskrnl/ex/init.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/ex/init.c [iso-8859-1] Wed Feb 12 20:03:57 2014 @@ -1072,12 +1072,12 @@ /* Setup initial system settings */ CmGetSystemControlValues(LoaderBlock->RegistryBase, CmControlVector); - /* Load static defaults for Service Pack 1 and add our SVN revision */ + /* Load static defaults for Service Pack 2 and add our SVN revision */ /* Format of CSD : SPMajor - SPMinor */ - CmNtCSDVersion = 0x100 | (KERNEL_VERSION_BUILD_HEX << 16); + CmNtCSDVersion = 0x200 | (KERNEL_VERSION_BUILD_HEX << 16); CmNtCSDReleaseType = 0; - /* Set Service Pack data for Service Pack 1 */ + /* Set Service Pack data for Service Pack 2 */ CmNtSpBuildNumber = VER_PRODUCTBUILD_QFE; if (!(CmNtCSDVersion & 0xFFFF0000)) {

1 0

[akhaldi] 62139: [CMAKE] * *Significantly* speedup our GCC and MSVC builds by bringing-in precompiled headers support. * Grab RosBE 2.1.1, set PCH to 1 and enjoy ; ) CORE-7716
by akhaldi＠svn.reactos.org 12 Feb '14

12 Feb '14

Author: akhaldi Date: Wed Feb 12 19:55:12 2014 New Revision: 62139 URL: http://svn.reactos.org/svn/reactos?rev=62139&view=rev Log: [CMAKE] * *Significantly* speedup our GCC and MSVC builds by bringing-in precompiled headers support. * Grab RosBE 2.1.1, set PCH to 1 and enjoy ;) CORE-7716 Modified: trunk/reactos/cmake/gcc.cmake trunk/reactos/cmake/msvc.cmake Modified: trunk/reactos/cmake/gcc.cmake URL: http://svn.reactos.org/svn/reactos/trunk/reactos/cmake/gcc.cmake?rev=62139&… ============================================================================== --- trunk/reactos/cmake/gcc.cmake [iso-8859-1] (original) +++ trunk/reactos/cmake/gcc.cmake [iso-8859-1] Wed Feb 12 19:55:12 2014 @@ -297,67 +297,36 @@ # Macros if(PCH) - macro(_PCH_GET_COMPILE_FLAGS _target_name _out_compile_flags _header_filename) - # Add the precompiled header to the build - get_filename_component(_FILE ${_header_filename} NAME) - set(_gch_filename "${_FILE}.gch") - list(APPEND ${_out_compile_flags} -c ${_header_filename} -o ${_gch_filename}) - - # This gets us our includes - get_directory_property(DIRINC INCLUDE_DIRECTORIES) - foreach(item ${DIRINC}) - list(APPEND ${_out_compile_flags} -I${item}) + macro(add_pch _target _pch _sources) + # When including x.h GCC looks for x.h.gch first + set(_pch_final_name "${_target}_pch.h") + set(_gch ${CMAKE_CURRENT_BINARY_DIR}/${_pch_final_name}.gch) + + if(IS_CPP) + set(_pch_language CXX) + else() + set(_pch_language C) + endif() + + # Build the precompiled header + # HEADER_FILE_ONLY FALSE: force compiling the header + # EXTERNAL_SOURCE TRUE: don't use the .gch file when linking + set_source_files_properties(${_pch} PROPERTIES + HEADER_FILE_ONLY FALSE + LANGUAGE ${_pch_language} + EXTERNAL_SOURCE TRUE + OBJECT_LOCATION ${_gch}) + + if(ENABLE_CCACHE) + set(_ccache_flag "-fpch-preprocess") + endif() + + # Include the gch in the specified source files, skipping the pch file itself + list(REMOVE_ITEM ${_sources} ${_pch}) + foreach(_src ${${_sources}}) + set_property(SOURCE ${_src} APPEND_STRING PROPERTY COMPILE_FLAGS " ${_ccache_flag} -Winvalid-pch -Werror=invalid-pch -include ${_pch_final_name}") + set_property(SOURCE ${_src} APPEND PROPERTY OBJECT_DEPENDS ${_gch}) endforeach() - - # This our definitions - get_directory_property(_compiler_flags DEFINITIONS) - list(APPEND ${_out_compile_flags} ${_compiler_flags}) - - # This gets any specific definitions that were added with set-target-property - get_target_property(_target_defs ${_target_name} COMPILE_DEFINITIONS) - if(_target_defs) - foreach(item ${_target_defs}) - list(APPEND ${_out_compile_flags} -D${item}) - endforeach() - endif() - - if(IS_CPP) - list(APPEND ${_out_compile_flags} ${CMAKE_CXX_FLAGS}) - else() - list(APPEND ${_out_compile_flags} ${CMAKE_C_FLAGS}) - endif() - - separate_arguments(${_out_compile_flags}) - endmacro() - - macro(add_pch _target_name _FILE) - set(_header_filename ${CMAKE_CURRENT_SOURCE_DIR}/${_FILE}) - get_filename_component(_basename ${_FILE} NAME) - set(_gch_filename ${_basename}.gch) - _PCH_GET_COMPILE_FLAGS(${_target_name} _args ${_header_filename}) - - if(IS_CPP) - set(__lang CXX) - set(__compiler ${CCACHE} ${CMAKE_CXX_COMPILER} ${CMAKE_CXX_COMPILER_ARG1}) - else() - set(__lang C) - set(__compiler ${CCACHE} ${CMAKE_C_COMPILER} ${CMAKE_C_COMPILER_ARG1}) - endif() - - add_custom_command(OUTPUT ${_gch_filename} - COMMAND ${__compiler} ${_args} - IMPLICIT_DEPENDS ${__lang} ${_header_filename} - DEPENDS ${_header_filename} ${ARGN}) - get_target_property(_src_files ${_target_name} SOURCES) - add_target_compile_flags(${_target_name} "-fpch-preprocess -Winvalid-pch -Wno-error=invalid-pch") - foreach(_item in ${_src_files}) - get_source_file_property(__src_lang ${_item} LANGUAGE) - if(__src_lang STREQUAL __lang) - set_source_files_properties(${_item} PROPERTIES OBJECT_DEPENDS ${CMAKE_CURRENT_BINARY_DIR}/${_gch_filename}) - endif() - endforeach() - #set dependency checking : depends on precompiled header only which already depends on deeper header - set_target_properties(${_target_name} PROPERTIES IMPLICIT_DEPENDS_INCLUDE_TRANSFORM "\"${_basename}\"=;<${_basename}>=") endmacro() else() macro(add_pch _target_name _FILE) Modified: trunk/reactos/cmake/msvc.cmake URL: http://svn.reactos.org/svn/reactos/trunk/reactos/cmake/msvc.cmake?rev=62139… ============================================================================== --- trunk/reactos/cmake/msvc.cmake [iso-8859-1] (original) +++ trunk/reactos/cmake/msvc.cmake [iso-8859-1] Wed Feb 12 19:55:12 2014 @@ -54,7 +54,8 @@ # - TODO: C4133: incompatible types # - C4229: modifiers on data are ignored # - C4700: uninitialized variable usage -add_compile_flags("/we4013 /we4022 /we4047 /we4098 /we4113 /we4129 /we4229 /we4700") +# - C4603: macro is not defined or definition is different after precompiled header use +add_compile_flags("/we4013 /we4022 /we4047 /we4098 /we4113 /we4129 /we4229 /we4700 /we4603") # Enable warnings above the default level, but don't treat them as errors: # - C4115: named type definition in parentheses @@ -118,8 +119,47 @@ set(CMAKE_ASM_CREATE_SHARED_LIBRARY ${CMAKE_C_CREATE_SHARED_LIBRARY}) set(CMAKE_ASM_CREATE_STATIC_LIBRARY ${CMAKE_C_CREATE_STATIC_LIBRARY}) -macro(add_pch _target_name _FILE) -endmacro() +if(PCH) + macro(add_pch _target _pch _sources) + set(_gch ${CMAKE_CURRENT_BINARY_DIR}/${_target}.pch) + + if(IS_CPP) + set(_pch_language CXX) + set(_cl_lang_flag "/TP") + else() + set(_pch_language C) + set(_cl_lang_flag "/TC") + endif() + + if(MSVC_IDE) + set(_pch_path_name_flag "/Fp${_gch}") + endif() + + # Build the precompiled header + # HEADER_FILE_ONLY FALSE: force compiling the header + set_source_files_properties(${_pch} PROPERTIES + HEADER_FILE_ONLY FALSE + LANGUAGE ${_pch_language} + COMPILE_FLAGS "${_cl_lang_flag} /Yc /Fp${_gch}" + OBJECT_OUTPUTS ${_gch}) + + # Prevent a race condition related to writing to the PDB files between the PCH and the excluded list of source files + get_target_property(_target_sources ${_target} SOURCES) + list(REMOVE_ITEM _target_sources ${_pch}) + foreach(_target_src ${_target_sources}) + set_property(SOURCE ${_target_src} APPEND PROPERTY OBJECT_DEPENDS ${_gch}) + endforeach() + + # Use the precompiled header with the specified source files, skipping the pch itself + list(REMOVE_ITEM ${_sources} ${_pch}) + foreach(_src ${${_sources}}) + set_property(SOURCE ${_src} APPEND_STRING PROPERTY COMPILE_FLAGS " /FI${_gch} /Yu${_gch} ${_pch_path_name_flag}") + endforeach() + endmacro() +else() + macro(add_pch _target_name _FILE) + endmacro() +endif() function(set_entrypoint _module _entrypoint) if(${_entrypoint} STREQUAL "0")

1 0

[dquintana] 62138: [RSHELL] * Port the implementation of CMenuDeskBar to rshell (still disabled by default). * Begin implementing missing features: - Notify the band of the icon size change from Se...
by dquintana＠svn.reactos.org 12 Feb '14

12 Feb '14

Author: dquintana Date: Wed Feb 12 19:46:24 2014 New Revision: 62138 URL: http://svn.reactos.org/svn/reactos?rev=62138&view=rev Log: [RSHELL] * Port the implementation of CMenuDeskBar to rshell (still disabled by default). * Begin implementing missing features: - Notify the band of the icon size change from SetIconSize. Modified: branches/shell-experiments/base/shell/rshell/CMakeLists.txt branches/shell-experiments/base/shell/rshell/CMenuDeskBar.cpp branches/shell-experiments/dll/win32/shell32/folders/desktop.cpp Modified: branches/shell-experiments/base/shell/rshell/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/branches/shell-experiments/base/shell/rs… ============================================================================== --- branches/shell-experiments/base/shell/rshell/CMakeLists.txt [iso-8859-1] (original) +++ branches/shell-experiments/base/shell/rshell/CMakeLists.txt [iso-8859-1] Wed Feb 12 19:46:24 2014 @@ -28,6 +28,7 @@ add_importlibs(rshell shlwapi shell32 + gdi32 ole32 user32 msvcrt Modified: branches/shell-experiments/base/shell/rshell/CMenuDeskBar.cpp URL: http://svn.reactos.org/svn/reactos/branches/shell-experiments/base/shell/rs… ============================================================================== --- branches/shell-experiments/base/shell/rshell/CMenuDeskBar.cpp [iso-8859-1] (original) +++ branches/shell-experiments/base/shell/rshell/CMenuDeskBar.cpp [iso-8859-1] Wed Feb 12 19:46:24 2014 @@ -19,12 +19,21 @@ */ #include "precomp.h" #include "wraplog.h" +#include <atlwin.h> WINE_DEFAULT_DEBUG_CHANNEL(CMenuDeskBar); #define WRAP_LOG 1 +typedef CWinTraits< + WS_POPUP | WS_DLGFRAME | WS_CLIPCHILDREN | WS_CLIPSIBLINGS, + WS_EX_LEFT | WS_EX_LTRREADING | WS_EX_RIGHTSCROLLBAR | WS_EX_PALETTEWINDOW +> CMenuWinTraits; + class CMenuDeskBar : +#if !WRAP_LOG + public CWindowImpl<CMenuDeskBar, CWindow, CMenuWinTraits>, +#endif public CComCoClass<CMenuDeskBar>, public CComObjectRootEx<CComMultiThreadModelNoCS>, public IOleCommandTarget, @@ -54,6 +63,20 @@ IBanneredBar * m_IBanneredBar; IInitializeObject * m_IInitializeObject; #else + + CComPtr<IUnknown> m_Site; + CComPtr<IUnknown> m_Client; + HWND m_ClientWindow; + bool m_Vertical; + bool m_Visible; + int m_NeededSize; // width or height + + DWORD m_IconSize; + HBITMAP m_Banner; + + // used by resize tracking loop + bool m_Tracking; + POINT m_LastLocation; #endif public: @@ -99,9 +122,37 @@ virtual HRESULT STDMETHODCALLTYPE GetClient(IUnknown **ppunkClient); virtual HRESULT STDMETHODCALLTYPE OnPosRectChangeDB(LPRECT prc); + // message handlers + LRESULT OnSize(UINT uMsg, WPARAM wParam, LPARAM lParam, BOOL &bHandled); + LRESULT OnNotify(UINT uMsg, WPARAM wParam, LPARAM lParam, BOOL &bHandled); + LRESULT OnLButtonDown(UINT uMsg, WPARAM wParam, LPARAM lParam, BOOL &bHandled); + LRESULT OnLButtonUp(UINT uMsg, WPARAM wParam, LPARAM lParam, BOOL &bHandled); + LRESULT OnMouseMove(UINT uMsg, WPARAM wParam, LPARAM lParam, BOOL &bHandled); + LRESULT OnCancelMode(UINT uMsg, WPARAM wParam, LPARAM lParam, BOOL &bHandled); + LRESULT OnCaptureChanged(UINT uMsg, WPARAM wParam, LPARAM lParam, BOOL &bHandled); + LRESULT OnWindowPosChanged(UINT uMsg, WPARAM wParam, LPARAM lParam, BOOL &bHandled); + LRESULT OnActivate(UINT uMsg, WPARAM wParam, LPARAM lParam, BOOL &bHandled); + LRESULT OnPaint(UINT uMsg, WPARAM wParam, LPARAM lParam, BOOL &bHandled); DECLARE_NOT_AGGREGATABLE(CMenuDeskBar) DECLARE_PROTECT_FINAL_CONSTRUCT() + +#if !WRAP_LOG + DECLARE_WND_CLASS_EX(_T("BaseBar"), 0, COLOR_3DFACE) +#endif + + BEGIN_MSG_MAP(CMenuDeskBar) + MESSAGE_HANDLER(WM_SIZE, OnSize) + MESSAGE_HANDLER(WM_NOTIFY, OnNotify) + MESSAGE_HANDLER(WM_LBUTTONDOWN, OnLButtonDown) + MESSAGE_HANDLER(WM_LBUTTONUP, OnLButtonUp) + MESSAGE_HANDLER(WM_MOUSEMOVE, OnMouseMove) + MESSAGE_HANDLER(WM_CANCELMODE, OnCancelMode) + MESSAGE_HANDLER(WM_CAPTURECHANGED, OnCaptureChanged) + MESSAGE_HANDLER(WM_WINDOWPOSCHANGED, OnWindowPosChanged) + MESSAGE_HANDLER(WM_ACTIVATE, OnActivate) +/* MESSAGE_HANDLER(WM_PAINT, OnPaint) */ + END_MSG_MAP() BEGIN_COM_MAP(CMenuDeskBar) COM_INTERFACE_ENTRY_IID(IID_IMenuPopup, IMenuPopup) @@ -135,6 +186,7 @@ return hr; } +#if WRAP_LOG CMenuDeskBar::CMenuDeskBar() { HRESULT hr; @@ -392,3 +444,484 @@ WrapLogExit("CMenuDeskBar::OnPosRectChangeDB() = %08x\n", hr); return hr; } +#else + +CMenuDeskBar::CMenuDeskBar() : + m_ClientWindow(NULL), + m_Vertical(true), + m_Visible(false), + m_NeededSize(200), + m_Tracking(false) +{ +} + +CMenuDeskBar::~CMenuDeskBar() +{ +} + +HRESULT STDMETHODCALLTYPE CMenuDeskBar::GetWindow(HWND *lphwnd) +{ + if (lphwnd == NULL) + return E_POINTER; + *lphwnd = m_hWnd; + return S_OK; +} + +HRESULT STDMETHODCALLTYPE CMenuDeskBar::ContextSensitiveHelp(BOOL fEnterMode) +{ + return E_NOTIMPL; +} + +HRESULT STDMETHODCALLTYPE CMenuDeskBar::OnFocusChangeIS(IUnknown *punkObj, BOOL fSetFocus) +{ + // forward to owner + return E_NOTIMPL; +} + +HRESULT STDMETHODCALLTYPE CMenuDeskBar::QueryStatus(const GUID *pguidCmdGroup, ULONG cCmds, + OLECMD prgCmds[], OLECMDTEXT *pCmdText) +{ + return E_NOTIMPL; +} + +HRESULT STDMETHODCALLTYPE CMenuDeskBar::Exec(const GUID *pguidCmdGroup, DWORD nCmdID, + DWORD nCmdexecopt, VARIANT *pvaIn, VARIANT *pvaOut) +{ + if (IsEqualIID(*pguidCmdGroup, CGID_Explorer)) + { + } + else if (IsEqualIID(*pguidCmdGroup, IID_IDeskBarClient)) + { + switch (nCmdID) + { + case 0: + // hide current band + break; + case 2: + break; + case 3: + break; + } + } + return E_NOTIMPL; +} + +HRESULT STDMETHODCALLTYPE CMenuDeskBar::QueryService(REFGUID guidService, REFIID riid, void **ppvObject) +{ + CComPtr<IServiceProvider> serviceProvider; + HRESULT hResult; + + if (m_Site == NULL) + return E_FAIL; + hResult = m_Site->QueryInterface(IID_IServiceProvider, reinterpret_cast<void **>(&serviceProvider)); + if (FAILED(hResult)) + return hResult; + // called for SID_STopLevelBrowser, IID_IBrowserService to find top level browser + // called for SID_IWebBrowserApp, IID_IConnectionPointContainer + // connection point called for DIID_DWebBrowserEvents2 to establish connection + return serviceProvider->QueryService(guidService, riid, ppvObject); +} + +HRESULT STDMETHODCALLTYPE CMenuDeskBar::UIActivateIO(BOOL fActivate, LPMSG lpMsg) +{ + // forward to contained bar + return S_OK; +} + +HRESULT STDMETHODCALLTYPE CMenuDeskBar::HasFocusIO() +{ + // forward to contained bar + return S_OK; +} + +HRESULT STDMETHODCALLTYPE CMenuDeskBar::TranslateAcceleratorIO(LPMSG lpMsg) +{ + // forward to contained bar + return S_OK; +} + +HRESULT STDMETHODCALLTYPE CMenuDeskBar::SetClient(IUnknown *punkClient) +{ + CComPtr<IDeskBarClient> pDeskBandClient; + HRESULT hResult; + + if (m_hWnd == NULL) + { + HWND ownerWindow = NULL; + if (m_Site) + { + IOleWindow * oleWindow; + + hResult = m_Site->QueryInterface(IID_IOleWindow, reinterpret_cast<void **>(&oleWindow)); + if (SUCCEEDED(hResult)) + hResult = oleWindow->GetWindow(&ownerWindow); + + if (!::IsWindow(ownerWindow)) + return E_FAIL; + } + + Create(ownerWindow); + } + + if (punkClient == NULL) + m_Client.Release(); + else + { + hResult = punkClient->QueryInterface(IID_IUnknown, reinterpret_cast<void **>(&m_Client)); + if (FAILED(hResult)) + return hResult; + + hResult = m_Client->QueryInterface(IID_IDeskBarClient, (VOID**) &pDeskBandClient); + if (FAILED(hResult)) + return hResult; + + hResult = pDeskBandClient->SetDeskBarSite(static_cast<IDeskBar*>(this)); + if (FAILED(hResult)) + return hResult; + + } + + return S_OK; +} + +HRESULT STDMETHODCALLTYPE CMenuDeskBar::GetClient(IUnknown **ppunkClient) +{ + if (ppunkClient == NULL) + return E_POINTER; + *ppunkClient = m_Client; + if (m_Client.p != NULL) + m_Client.p->AddRef(); + return S_OK; +} + +HRESULT STDMETHODCALLTYPE CMenuDeskBar::OnPosRectChangeDB(LPRECT prc) +{ + if (prc == NULL) + return E_POINTER; + return S_OK; +} + +HRESULT STDMETHODCALLTYPE CMenuDeskBar::SetSite(IUnknown *pUnkSite) +{ + return S_OK; + CComPtr<IServiceProvider> serviceProvider; + CComPtr<IProfferService> profferService; + HRESULT hResult; + CComPtr<IOleWindow> oleWindow; + HWND ownerWindow; + + + m_Site.Release(); + if (pUnkSite == NULL) + { + return S_OK; + } + + if (m_hWnd == NULL) + { + // get window handle of parent + hResult = pUnkSite->QueryInterface(IID_ITrayPriv, reinterpret_cast<void **>(&m_Site)); + if (FAILED(hResult)) + return hResult; + + hResult = pUnkSite->QueryInterface(IID_IOleWindow, reinterpret_cast<void **>(&oleWindow)); + if (SUCCEEDED(hResult)) + hResult = oleWindow->GetWindow(&ownerWindow); + + if (!::IsWindow(ownerWindow)) + return E_FAIL; + + Create(ownerWindow); + } + else + { + //Set Owner ? + } + + return S_OK; +} + +HRESULT STDMETHODCALLTYPE CMenuDeskBar::GetSite(REFIID riid, void **ppvSite) +{ + if (ppvSite == NULL) + return E_POINTER; + *ppvSite = m_Site; + if (m_Site.p != NULL) + m_Site.p->AddRef(); + return S_OK; +} + +LRESULT CMenuDeskBar::OnSize(UINT uMsg, WPARAM wParam, LPARAM lParam, BOOL &bHandled) +{ + HRESULT hr; + + if (m_Client) + { + CComPtr<IOleWindow> pOw; + hr = m_Client->QueryInterface(IID_PPV_ARG(IOleWindow, &pOw)); + if (FAILED(hr)) + { + ERR("IUnknown_QueryInterface pBs failed: %x\n", hr); + return 0; + } + + HWND clientWnd; + pOw->GetWindow(&clientWnd); + + RECT rc; + + GetClientRect(&rc); + + if (m_Banner != NULL) + { + SIZE sz; + ::GetBitmapDimensionEx(m_Banner, &sz); + rc.left += sz.cx; + } + + ::SetWindowPos(clientWnd, NULL, rc.left, rc.top, rc.right - rc.left, rc.bottom - rc.top, 0); + } + + return 0; +} + +LRESULT CMenuDeskBar::OnNotify(UINT uMsg, WPARAM wParam, LPARAM lParam, BOOL &bHandled) +{ + CComPtr<IWinEventHandler> winEventHandler; + LRESULT result; + HRESULT hResult; + + result = 0; + if (m_Client.p != NULL) + { + hResult = m_Client->QueryInterface(IID_IWinEventHandler, reinterpret_cast<void **>(&winEventHandler)); + if (SUCCEEDED(hResult) && winEventHandler.p != NULL) + hResult = winEventHandler->OnWinEvent(NULL, uMsg, wParam, lParam, &result); + } + return result; +} + +LRESULT CMenuDeskBar::OnLButtonDown(UINT uMsg, WPARAM wParam, LPARAM lParam, BOOL &bHandled) +{ + SetCapture(); + m_Tracking = true; + m_LastLocation.x = LOWORD(lParam); + m_LastLocation.y = HIWORD(lParam); + return 0; +} + +LRESULT CMenuDeskBar::OnLButtonUp(UINT uMsg, WPARAM wParam, LPARAM lParam, BOOL &bHandled) +{ + ReleaseCapture(); + m_Tracking = false; + return 0; +} + +LRESULT CMenuDeskBar::OnMouseMove(UINT uMsg, WPARAM wParam, LPARAM lParam, BOOL &bHandled) +{ + POINT newLocation; + //int delta; + + if (m_Tracking) + { + newLocation.x = (short) LOWORD(lParam); + newLocation.y = (short) HIWORD(lParam); + m_LastLocation = newLocation; + } + return 0; +} + +LRESULT CMenuDeskBar::OnCancelMode(UINT uMsg, WPARAM wParam, LPARAM lParam, BOOL &bHandled) +{ + m_Tracking = false; + return 0; +} + +LRESULT CMenuDeskBar::OnCaptureChanged(UINT uMsg, WPARAM wParam, LPARAM lParam, BOOL &bHandled) +{ + m_Tracking = false; + return 0; +} + +LRESULT CMenuDeskBar::OnWindowPosChanged(UINT uMsg, WPARAM wParam, LPARAM lParam, BOOL &bHandled) +{ + return 0; +} + +LRESULT CMenuDeskBar::OnActivate(UINT uMsg, WPARAM wParam, LPARAM lParam, BOOL &bHandled) +{ + if (LOWORD(wParam) == WA_INACTIVE) + { + //DestroyWindow(); + //ShowWindow(SW_HIDE); + } + return 0; +} + +LRESULT CMenuDeskBar::OnPaint(UINT uMsg, WPARAM wParam, LPARAM lParam, BOOL &bHandled) +{ + TRACE("OnPaint\n"); + + if (m_Banner && !m_IconSize) + { + BITMAP bm; + PAINTSTRUCT ps; + HDC hdc = BeginPaint(&ps); + + HDC hdcMem = ::CreateCompatibleDC(hdc); + HGDIOBJ hbmOld = ::SelectObject(hdcMem, m_Banner); + + ::GetObject(m_Banner, sizeof(bm), &bm); + + TRACE("Painting banner: %d by %d\n", bm.bmWidth, bm.bmHeight); + + if (!::BitBlt(hdc, 0, 0, bm.bmWidth, bm.bmHeight, hdcMem, 0, 0, SRCCOPY)) + WARN("BitBlt failed\n"); + + ::SelectObject(hdcMem, hbmOld); + ::DeleteDC(hdcMem); + + EndPaint(&ps); + } + + return 0; +} + +HRESULT STDMETHODCALLTYPE CMenuDeskBar::Popup(POINTL *ppt, RECTL *prcExclude, MP_POPUPFLAGS dwFlags) +{ + //ENTER >> CMenuDeskBar<03901CC0>::Popup(POINTL *ppt=00B3F428, RECTL *prcExclude=00B3F418, MP_POPUPFLAGS dwFlags=80000000) + // ENTER >> CMenuBand<00D2CCF8>::QueryService + + // ENTER >> CMenuBand<00D2CCF8>::ShowDW(BOOL fShow=1) + // ENTER >> CMenuDeskBar<03901CC0>::GetSite(REFIID riid={4622AD10-FF23-11D0-8D34-00A0C90F2719}, PVOID *ppvSite=03901D4C) + // -- *ppvSite=00BDEA90 + // EXIT <<< CMenuDeskBar::GetSite() = 00000000 + // ENTER >> CMenuBand<00D2CCF8>::SetMenu(HMENU hmenu=593F0A07, HWND hwnd=00000000, DWORD dwFlags=20000000) + // EXIT <<< CMenuBand::SetMenu() = 00000000 + // EXIT <<< CMenuBand::ShowDW() = 00000000 + // ENTER >> CMenuBand<00D2CCF8>::GetBandInfo(DWORD dwBandID=0, DWORD dwViewMode=0, DESKBANDINFO *pdbi=00B3F0F0) + // EXIT <<< CMenuBand::GetBandInfo() = 00000000 + // ENTER >> CMenuBand<00D2CCF8>::QueryService(REFGUID guidService={ED9CC020-08B9-11D1-9823-00C04FD91972}, REFIID riid={B722BCCB-4E68-101B-A2BC-00AA00404770}, void **ppvObject=00B3F304) + // -- SID is SID_SMenuBandChild. Using QueryInterface of self instead of wrapped object. + // -- *ppvObject=00D2CD08 + // EXIT <<< CMenuBand::QueryService() = 00000000 + // ENTER >> CMenuBand<00D2CCF8>::Exec(const GUID *pguidCmdGroup=76BAE1FC, DWORD nCmdID=19, DWORD nCmdexecopt=0, VARIANT *pvaIn=00000000, VARIANT *pvaOut=00000000) + // -- *pguidCmdGroup={5B4DAE26-B807-11D0-9815-00C04FD91972} + // EXIT <<< CMenuBand::Exec() = 00000001 + // ENTER >> CMenuBand<00D2CCF8>::OnPosRectChangeDB(RECT *prc=00B3E630) + // -- *prc={L: 0, T: 0, R: 218, B: 305} + // EXIT <<< CMenuBand::OnPosRectChangeDB() = 00000000 + // ENTER >> CMenuBand<00D2CCF8>::UIActivateIO(BOOL fActivate=1, LPMSG lpMsg=00000000) + // EXIT <<< CMenuBand::UIActivateIO() = 00000001 + //EXIT <<< CMenuDeskBar::Popup() = 00000000 + HRESULT hr; + IServiceProvider * sp; + IOleCommandTarget * oct; + IInputObject * io; + + hr = m_Client->QueryInterface(IID_PPV_ARG(IServiceProvider, &sp)); + if (FAILED(hr)) + return hr; + + hr = m_Client->QueryInterface(IID_PPV_ARG(IInputObject, &io)); + if (FAILED(hr)) + return hr; + + hr = sp->QueryService(SID_SMenuBandChild, IID_PPV_ARG(IOleCommandTarget, &oct)); + if (FAILED(hr)) + { + sp->Release(); + return hr; + } + + // Unknown meaning + const int CMD = 19; + const int CMD_EXEC_OPT = 0; + + hr = oct->Exec(&CLSID_MenuBand, CMD, CMD_EXEC_OPT, NULL, NULL); + + oct->Release(); + sp->Release(); + return hr; + + // FIXME: everything! + const int hackWidth = 200; + const int hackHeight = 400; + RECT r = { ppt->x, ppt->y - hackHeight, ppt->x + hackWidth, ppt->y }; + if (this->m_hWnd == NULL) + { + this->Create(NULL, &r); + } + this->SetWindowPos(NULL, r.left, r.top, r.right - r.left, r.bottom - r.top, SWP_SHOWWINDOW); + return S_OK; +} + +HRESULT STDMETHODCALLTYPE CMenuDeskBar::SetIconSize(THIS_ DWORD iIcon) +{ + HRESULT hr; + IServiceProvider * sp; + IOleCommandTarget * oct; + + m_IconSize = iIcon; + + hr = m_Client->QueryInterface(IID_PPV_ARG(IServiceProvider, &sp)); + if (FAILED(hr)) + return hr; + + hr = sp->QueryService(SID_SMenuBandChild, IID_PPV_ARG(IOleCommandTarget, &oct)); + if (FAILED(hr)) + { + sp->Release(); + return hr; + } + + // Unknown meaning + const int CMD = 16; + const int CMD_EXEC_OPT = 2; + + hr = oct->Exec(&CLSID_MenuBand, CMD, CMD_EXEC_OPT, NULL, NULL); + + oct->Release(); + sp->Release(); + return hr; +} + +HRESULT STDMETHODCALLTYPE CMenuDeskBar::GetIconSize(THIS_ DWORD* piIcon) +{ + if (piIcon) + *piIcon = m_IconSize; + return S_OK; +} + +HRESULT STDMETHODCALLTYPE CMenuDeskBar::SetBitmap(THIS_ HBITMAP hBitmap) +{ + m_Banner = hBitmap; + return S_OK; +} + +HRESULT STDMETHODCALLTYPE CMenuDeskBar::GetBitmap(THIS_ HBITMAP* phBitmap) +{ + if (phBitmap) + *phBitmap = m_Banner; + return S_OK; +} + +HRESULT STDMETHODCALLTYPE CMenuDeskBar::OnSelect( + DWORD dwSelectType) +{ + return S_OK; +} + +HRESULT STDMETHODCALLTYPE CMenuDeskBar::SetSubMenu( + IMenuPopup *pmp, + BOOL fSet) +{ + return S_OK; +} + +HRESULT STDMETHODCALLTYPE CMenuDeskBar::Initialize(THIS) +{ + return S_OK; +} + +#endif Modified: branches/shell-experiments/dll/win32/shell32/folders/desktop.cpp URL: http://svn.reactos.org/svn/reactos/branches/shell-experiments/dll/win32/she… ============================================================================== --- branches/shell-experiments/dll/win32/shell32/folders/desktop.cpp [iso-8859-1] (original) +++ branches/shell-experiments/dll/win32/shell32/folders/desktop.cpp [iso-8859-1] Wed Feb 12 19:46:24 2014 @@ -1451,7 +1451,7 @@ else { InitFormatEtc (formatetc, CF_HDROP, TYMED_HGLOBAL); - if SUCCEEDED(pDataObject->QueryGetData(&formatetc)); + if (SUCCEEDED(pDataObject->QueryGetData(&formatetc))) { passthroughtofs = TRUE; }

1 0

[akhaldi] 62137: [CMAKE] * Speedup GCC and MSVC builds by making use of the new ninja deps mode. * It will be in effect once you update to RosBE 2.1.1. It's disabled now in the transition phase. CO...
by akhaldi＠svn.reactos.org 12 Feb '14

12 Feb '14

Author: akhaldi Date: Wed Feb 12 19:36:19 2014 New Revision: 62137 URL: http://svn.reactos.org/svn/reactos?rev=62137&view=rev Log: [CMAKE] * Speedup GCC and MSVC builds by making use of the new ninja deps mode. * It will be in effect once you update to RosBE 2.1.1. It's disabled now in the transition phase. CORE-7887 Modified: trunk/reactos/CMakeLists.txt trunk/reactos/cmake/msvc.cmake Modified: trunk/reactos/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/CMakeLists.txt?rev=62137&r… ============================================================================== --- trunk/reactos/CMakeLists.txt [iso-8859-1] (original) +++ trunk/reactos/CMakeLists.txt [iso-8859-1] Wed Feb 12 19:36:19 2014 @@ -26,6 +26,10 @@ set(CMAKE_COLOR_MAKEFILE OFF) #set_property(GLOBAL PROPERTY RULE_MESSAGES OFF) set(CMAKE_SKIP_INSTALL_RULES ON) + +if(NOT DEFINED CMAKE_DISABLE_NINJA_DEPSLOG) + set(CMAKE_DISABLE_NINJA_DEPSLOG TRUE) +endif() if(NOT ARCH) set(ARCH i386) Modified: trunk/reactos/cmake/msvc.cmake URL: http://svn.reactos.org/svn/reactos/trunk/reactos/cmake/msvc.cmake?rev=62137… ============================================================================== --- trunk/reactos/cmake/msvc.cmake [iso-8859-1] (original) +++ trunk/reactos/cmake/msvc.cmake [iso-8859-1] Wed Feb 12 19:36:19 2014 @@ -83,13 +83,19 @@ set(CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS} /MANIFEST:NO /INCREMENTAL:NO /SAFESEH:NO /NODEFAULTLIB /RELEASE") set(CMAKE_MODULE_LINKER_FLAGS "${CMAKE_MODULE_LINKER_FLAGS} /MANIFEST:NO /INCREMENTAL:NO /SAFESEH:NO /NODEFAULTLIB /RELEASE") +if(CMAKE_DISABLE_NINJA_DEPSLOG) + set(cl_includes_flag "") +else() + set(cl_includes_flag "/showIncludes") +endif() + if(MSVC_IDE AND (CMAKE_VERSION MATCHES "ReactOS")) # for VS builds we'll only have en-US in resource files add_definitions(/DLANGUAGE_EN_US) else() set(CMAKE_RC_COMPILE_OBJECT "<CMAKE_RC_COMPILER> /nologo <FLAGS> <DEFINES> ${I18N_DEFS} /fo<OBJECT> <SOURCE>") set(CMAKE_ASM_COMPILE_OBJECT - "cl /nologo /X /I${REACTOS_SOURCE_DIR}/include/asm /I${REACTOS_BINARY_DIR}/include/asm <FLAGS> <DEFINES> /D__ASM__ /D_USE_ML /EP /c <SOURCE> > <OBJECT>.tmp" + "cl ${cl_includes_flag} /nologo /X /I${REACTOS_SOURCE_DIR}/include/asm /I${REACTOS_BINARY_DIR}/include/asm <FLAGS> <DEFINES> /D__ASM__ /D_USE_ML /EP /c <SOURCE> > <OBJECT>.tmp" "<CMAKE_ASM_COMPILER> /nologo /Cp /Fo<OBJECT> /c /Ta <OBJECT>.tmp") endif()

1 0

[akhaldi] 62136: [CMAKE] * Disable the generation of unneeded installation rules. This speeds up build and reduces the build folder files count/overall size. * It will be in effect once you update ...
by akhaldi＠svn.reactos.org 12 Feb '14

12 Feb '14

Author: akhaldi Date: Wed Feb 12 19:25:45 2014 New Revision: 62136 URL: http://svn.reactos.org/svn/reactos?rev=62136&view=rev Log: [CMAKE] * Disable the generation of unneeded installation rules. This speeds up build and reduces the build folder files count/overall size. * It will be in effect once you update to RosBE 2.1.1. CORE-7888 #resolve Modified: trunk/reactos/CMakeLists.txt Modified: trunk/reactos/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/CMakeLists.txt?rev=62136&r… ============================================================================== --- trunk/reactos/CMakeLists.txt [iso-8859-1] (original) +++ trunk/reactos/CMakeLists.txt [iso-8859-1] Wed Feb 12 19:25:45 2014 @@ -25,6 +25,7 @@ set(CMAKE_SKIP_ASSEMBLY_SOURCE_RULES TRUE) set(CMAKE_COLOR_MAKEFILE OFF) #set_property(GLOBAL PROPERTY RULE_MESSAGES OFF) +set(CMAKE_SKIP_INSTALL_RULES ON) if(NOT ARCH) set(ARCH i386)

1 0

[akhaldi] 62135: [CMAKE/GCC] * Improve the ccache check.
by akhaldi＠svn.reactos.org 12 Feb '14

12 Feb '14

Author: akhaldi Date: Wed Feb 12 18:36:46 2014 New Revision: 62135 URL: http://svn.reactos.org/svn/reactos?rev=62135&view=rev Log: [CMAKE/GCC] * Improve the ccache check. Modified: trunk/reactos/cmake/gcc.cmake Modified: trunk/reactos/cmake/gcc.cmake URL: http://svn.reactos.org/svn/reactos/trunk/reactos/cmake/gcc.cmake?rev=62135&… ============================================================================== --- trunk/reactos/cmake/gcc.cmake [iso-8859-1] (original) +++ trunk/reactos/cmake/gcc.cmake [iso-8859-1] Wed Feb 12 18:36:46 2014 @@ -1,6 +1,6 @@ # Show a note about ccache build -if(CCACHE STREQUAL "ccache") +if(ENABLE_CCACHE) message("-- Enabling ccache build - done") endif()

1 0

[dquintana] 62134: [MPLAY32] * Remove from build while it hangs VS2013. [EXPLORER-NEW] * Hack it to work on Windows 7, even if an existing explorer is already running. * Move start menu popup to it...
by dquintana＠svn.reactos.org 12 Feb '14

12 Feb '14

Author: dquintana Date: Wed Feb 12 17:48:49 2014 New Revision: 62134 URL: http://svn.reactos.org/svn/reactos?rev=62134&view=rev Log: [MPLAY32] * Remove from build while it hangs VS2013. [EXPLORER-NEW] * Hack it to work on Windows 7, even if an existing explorer is already running. * Move start menu popup to its own function, for easier debugging. * Maybe-fix a drawing issue if no theme is selected. [RSHELL] * Added wrapper for CMenuBand * The cmake script should not use a hardcoded path * Better name for the log file. CORE-7886 Added: branches/shell-experiments/base/shell/rshell/CMenuDeskBar.cpp (with props) Modified: branches/shell-experiments/base/applications/CMakeLists.txt branches/shell-experiments/base/shell/explorer-new/explorer.c branches/shell-experiments/base/shell/explorer-new/trayntfy.c branches/shell-experiments/base/shell/explorer-new/traywnd.c branches/shell-experiments/base/shell/rshell/CMakeLists.txt branches/shell-experiments/base/shell/rshell/CMenuBand.cpp branches/shell-experiments/base/shell/rshell/CStartMenu.cpp branches/shell-experiments/base/shell/rshell/precomp.h branches/shell-experiments/base/shell/rshell/wraplog.cpp Modified: branches/shell-experiments/base/applications/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/branches/shell-experiments/base/applicat… ============================================================================== --- branches/shell-experiments/base/applications/CMakeLists.txt [iso-8859-1] (original) +++ branches/shell-experiments/base/applications/CMakeLists.txt [iso-8859-1] Wed Feb 12 17:48:49 2014 @@ -16,7 +16,6 @@ add_subdirectory(logoff) add_subdirectory(magnify) add_subdirectory(mmc) -add_subdirectory(mplay32) add_subdirectory(msconfig) add_subdirectory(mscutils) add_subdirectory(mstsc) Modified: branches/shell-experiments/base/shell/explorer-new/explorer.c URL: http://svn.reactos.org/svn/reactos/branches/shell-experiments/base/shell/ex… ============================================================================== --- branches/shell-experiments/base/shell/explorer-new/explorer.c [iso-8859-1] (original) +++ branches/shell-experiments/base/shell/explorer-new/explorer.c [iso-8859-1] Wed Feb 12 17:48:49 2014 @@ -407,7 +407,7 @@ ProcessStartupItems(); - if (GetShellWindow() == NULL) + //if (GetShellWindow() == NULL) CreateShellDesktop = TRUE; /* FIXME - initialize SSO Thread */ @@ -415,7 +415,7 @@ if (CreateShellDesktop) { /* Initialize shell dde support */ - ShellDDEInit(TRUE); + //ShellDDEInit(TRUE); /* Initialize shell icons */ FileIconInit(TRUE); @@ -430,15 +430,15 @@ left screen corner, but is also needed in order to receive HSHELL_* notification messages (which are required for taskbar buttons to work right) */ - HideMinimizedWindows(TRUE); + /*HideMinimizedWindows(TRUE); if (Tray != NULL) - hShellDesktop = DesktopCreateWindow(Tray); + hShellDesktop = DesktopCreateWindow(Tray);*/ } - /* WinXP: Notify msgina to hide the welcome screen */ - if (!SetShellReadyEvent(TEXT("msgina: ShellReadyEvent"))) - SetShellReadyEvent(TEXT("Global\\msgina: ShellReadyEvent")); + ///* WinXP: Notify msgina to hide the welcome screen */ + //if (!SetShellReadyEvent(TEXT("msgina: ShellReadyEvent"))) + // SetShellReadyEvent(TEXT("Global\\msgina: ShellReadyEvent")); } else { Modified: branches/shell-experiments/base/shell/explorer-new/trayntfy.c URL: http://svn.reactos.org/svn/reactos/branches/shell-experiments/base/shell/ex… ============================================================================== --- branches/shell-experiments/base/shell/explorer-new/trayntfy.c [iso-8859-1] (original) +++ branches/shell-experiments/base/shell/explorer-new/trayntfy.c [iso-8859-1] Wed Feb 12 17:48:49 2014 @@ -1717,6 +1717,8 @@ TrayNotifyWnd_UpdateTheme(This); return 0; case WM_ERASEBKGND: + if (!This->TrayTheme) + goto HandleDefaultMessage; return TrayNotifyWnd_DrawBackground(hwnd, uMsg, wParam, Modified: branches/shell-experiments/base/shell/explorer-new/traywnd.c URL: http://svn.reactos.org/svn/reactos/branches/shell-experiments/base/shell/ex… ============================================================================== --- branches/shell-experiments/base/shell/explorer-new/traywnd.c [iso-8859-1] (original) +++ branches/shell-experiments/base/shell/explorer-new/traywnd.c [iso-8859-1] Wed Feb 12 17:48:49 2014 @@ -2070,6 +2070,42 @@ } CloseHandle(CreateThread(NULL, 0, RunFileDlgThread, This, 0, NULL)); +} + +static void PopupStartMenu(IN ITrayWindowImpl *This) +{ + if (This->StartMenuPopup != NULL) + { + POINTL pt; + RECTL rcExclude; + DWORD dwFlags = 0; + + if (GetWindowRect(This->hwndStart, + (RECT*) &rcExclude)) + { + if (ITrayWindowImpl_IsPosHorizontal(This)) + { + pt.x = rcExclude.left; + pt.y = rcExclude.top; + dwFlags |= MPPF_BOTTOM; + } + else + { + if (This->Position == ABE_LEFT) + pt.x = rcExclude.left; + else + pt.x = rcExclude.right; + + pt.y = rcExclude.bottom; + dwFlags |= MPPF_BOTTOM; + } + + IMenuPopup_Popup(This->StartMenuPopup, + &pt, + &rcExclude, + dwFlags); + } + } } static LRESULT CALLBACK @@ -2566,38 +2602,7 @@ case WM_COMMAND: if ((HWND)lParam == This->hwndStart) { - if (This->StartMenuPopup != NULL) - { - POINTL pt; - RECTL rcExclude; - DWORD dwFlags = 0; - - if (GetWindowRect(This->hwndStart, - (RECT*)&rcExclude)) - { - if (ITrayWindowImpl_IsPosHorizontal(This)) - { - pt.x = rcExclude.left; - pt.y = rcExclude.top; - dwFlags |= MPPF_BOTTOM; - } - else - { - if (This->Position == ABE_LEFT) - pt.x = rcExclude.left; - else - pt.x = rcExclude.right; - - pt.y = rcExclude.bottom; - dwFlags |= MPPF_BOTTOM; - } - - IMenuPopup_Popup(This->StartMenuPopup, - &pt, - &rcExclude, - dwFlags); - } - } + PopupStartMenu(This); break; } Modified: branches/shell-experiments/base/shell/rshell/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/branches/shell-experiments/base/shell/rs… ============================================================================== --- branches/shell-experiments/base/shell/rshell/CMakeLists.txt [iso-8859-1] (original) +++ branches/shell-experiments/base/shell/rshell/CMakeLists.txt [iso-8859-1] Wed Feb 12 17:48:49 2014 @@ -9,6 +9,7 @@ list(APPEND SOURCE CDesktopBrowser.cpp CMenuBand.cpp + CMenuDeskBar.cpp CMenuSite.cpp CStartMenu.cpp misc.cpp @@ -36,5 +37,5 @@ add_custom_command(TARGET rshell POST_BUILD COMMAND "${CMAKE_COMMAND}" -E copy "$<TARGET_FILE:rshell>" - "G:/reactos/vs12/reactos/base/shell/explorer-new/$<CONFIGURATION>/$<TARGET_FILE_NAME:rshell>" + "$<TARGET_FILE_DIR:explorer_new>/$<TARGET_FILE_NAME:rshell>" COMMENT "Copying to output directory") Modified: branches/shell-experiments/base/shell/rshell/CMenuBand.cpp URL: http://svn.reactos.org/svn/reactos/branches/shell-experiments/base/shell/rs… ============================================================================== --- branches/shell-experiments/base/shell/rshell/CMenuBand.cpp [iso-8859-1] (original) +++ branches/shell-experiments/base/shell/rshell/CMenuBand.cpp [iso-8859-1] Wed Feb 12 17:48:49 2014 @@ -22,7 +22,7 @@ WINE_DEFAULT_DEBUG_CHANNEL(CMenuBand); -#define WRAP_LOG 0 +#define WRAP_LOG 1 extern "C" BOOL WINAPI Shell_GetImageLists(HIMAGELIST * lpBigList, HIMAGELIST * lpSmallList); Added: branches/shell-experiments/base/shell/rshell/CMenuDeskBar.cpp URL: http://svn.reactos.org/svn/reactos/branches/shell-experiments/base/shell/rs… ============================================================================== --- branches/shell-experiments/base/shell/rshell/CMenuDeskBar.cpp (added) +++ branches/shell-experiments/base/shell/rshell/CMenuDeskBar.cpp [iso-8859-1] Wed Feb 12 17:48:49 2014 @@ -0,0 +1,394 @@ +/* +* Shell Menu Desk Bar +* +* Copyright 2014 David Quintana +* +* This library is free software; you can redistribute it and/or +* modify it under the terms of the GNU Lesser General Public +* License as published by the Free Software Foundation; either +* version 2.1 of the License, or (at your option) any later version. +* +* This library is distributed in the hope that it will be useful, +* but WITHOUT ANY WARRANTY; without even the implied warranty of +* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU +* Lesser General Public License for more details. +* +* You should have received a copy of the GNU Lesser General Public +* License along with this library; if not, write to the Free Software +* Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA +*/ +#include "precomp.h" +#include "wraplog.h" + +WINE_DEFAULT_DEBUG_CHANNEL(CMenuDeskBar); + +#define WRAP_LOG 1 + +class CMenuDeskBar : + public CComCoClass<CMenuDeskBar>, + public CComObjectRootEx<CComMultiThreadModelNoCS>, + public IOleCommandTarget, + public IServiceProvider, + public IInputObjectSite, + public IInputObject, + public IMenuPopup, + public IObjectWithSite, + public IBanneredBar, + public IInitializeObject +{ +public: + CMenuDeskBar(); + ~CMenuDeskBar(); + +private: +#if WRAP_LOG + IUnknown * m_IUnknown; + IMenuPopup * m_IMenuPopup; + IOleCommandTarget * m_IOleCommandTarget; + IServiceProvider * m_IServiceProvider; + IDeskBar * m_IDeskBar; + IOleWindow * m_IOleWindow; + IInputObjectSite * m_IInputObjectSite; + IInputObject * m_IInputObject; + IObjectWithSite * m_IObjectWithSite; + IBanneredBar * m_IBanneredBar; + IInitializeObject * m_IInitializeObject; +#else +#endif + +public: + // *** IMenuPopup methods *** + virtual HRESULT STDMETHODCALLTYPE Popup(POINTL *ppt, RECTL *prcExclude, MP_POPUPFLAGS dwFlags); + virtual HRESULT STDMETHODCALLTYPE OnSelect(DWORD dwSelectType); + virtual HRESULT STDMETHODCALLTYPE SetSubMenu(IMenuPopup *pmp, BOOL fSet); + + // *** IOleWindow methods *** + virtual HRESULT STDMETHODCALLTYPE GetWindow(HWND *phwnd); + virtual HRESULT STDMETHODCALLTYPE ContextSensitiveHelp(BOOL fEnterMode); + + // *** IObjectWithSite methods *** + virtual HRESULT STDMETHODCALLTYPE SetSite(IUnknown *pUnkSite); + virtual HRESULT STDMETHODCALLTYPE GetSite(REFIID riid, PVOID *ppvSite); + + // *** IBanneredBar methods *** + virtual HRESULT STDMETHODCALLTYPE SetIconSize(DWORD iIcon); + virtual HRESULT STDMETHODCALLTYPE GetIconSize(DWORD* piIcon); + virtual HRESULT STDMETHODCALLTYPE SetBitmap(HBITMAP hBitmap); + virtual HRESULT STDMETHODCALLTYPE GetBitmap(HBITMAP* phBitmap); + + // *** IInitializeObject methods *** + virtual HRESULT STDMETHODCALLTYPE Initialize(THIS); + + // *** IOleCommandTarget methods *** + virtual HRESULT STDMETHODCALLTYPE QueryStatus(const GUID *pguidCmdGroup, ULONG cCmds, OLECMD prgCmds [], OLECMDTEXT *pCmdText); + virtual HRESULT STDMETHODCALLTYPE Exec(const GUID *pguidCmdGroup, DWORD nCmdID, DWORD nCmdexecopt, VARIANT *pvaIn, VARIANT *pvaOut); + + // *** IServiceProvider methods *** + virtual HRESULT STDMETHODCALLTYPE QueryService(REFGUID guidService, REFIID riid, void **ppvObject); + + // *** IInputObjectSite methods *** + virtual HRESULT STDMETHODCALLTYPE OnFocusChangeIS(LPUNKNOWN lpUnknown, BOOL bFocus); + + // *** IInputObject methods *** + virtual HRESULT STDMETHODCALLTYPE UIActivateIO(BOOL bActivating, LPMSG lpMsg); + virtual HRESULT STDMETHODCALLTYPE HasFocusIO(THIS); + virtual HRESULT STDMETHODCALLTYPE TranslateAcceleratorIO(LPMSG lpMsg); + + // *** IDeskBar methods *** + virtual HRESULT STDMETHODCALLTYPE SetClient(IUnknown *punkClient); + virtual HRESULT STDMETHODCALLTYPE GetClient(IUnknown **ppunkClient); + virtual HRESULT STDMETHODCALLTYPE OnPosRectChangeDB(LPRECT prc); + + + DECLARE_NOT_AGGREGATABLE(CMenuDeskBar) + DECLARE_PROTECT_FINAL_CONSTRUCT() + + BEGIN_COM_MAP(CMenuDeskBar) + COM_INTERFACE_ENTRY_IID(IID_IMenuPopup, IMenuPopup) + COM_INTERFACE_ENTRY_IID(IID_IOleCommandTarget, IOleCommandTarget) + COM_INTERFACE_ENTRY_IID(IID_IServiceProvider, IServiceProvider) + COM_INTERFACE_ENTRY_IID(IID_IInputObjectSite, IInputObjectSite) + COM_INTERFACE_ENTRY_IID(IID_IInputObject, IInputObject) + COM_INTERFACE_ENTRY_IID(IID_IDeskBar, IMenuPopup) + COM_INTERFACE_ENTRY_IID(IID_IOleWindow, IMenuPopup) + COM_INTERFACE_ENTRY_IID(IID_IObjectWithSite, IObjectWithSite) + COM_INTERFACE_ENTRY_IID(IID_IBanneredBar, IBanneredBar) + COM_INTERFACE_ENTRY_IID(IID_IInitializeObject, IInitializeObject) + END_COM_MAP() +}; + +extern "C" +HRESULT CMenuDeskBar_Constructor(REFIID riid, LPVOID *ppv) +{ + *ppv = NULL; + + CMenuDeskBar * deskbar = new CComObject<CMenuDeskBar>(); + + if (!deskbar) + return E_OUTOFMEMORY; + + HRESULT hr = deskbar->QueryInterface(riid, ppv); + + if (FAILED(hr)) + deskbar->Release(); + + return hr; +} + +CMenuDeskBar::CMenuDeskBar() +{ + HRESULT hr; + WrapLogOpen(); + + hr = CoCreateInstance(CLSID_MenuDeskBar, NULL, CLSCTX_INPROC_SERVER, IID_PPV_ARG(IMenuPopup, &m_IMenuPopup)); + hr = m_IMenuPopup->QueryInterface(IID_PPV_ARG(IUnknown, &m_IUnknown)); + + hr = m_IUnknown->QueryInterface(IID_PPV_ARG(IOleCommandTarget, &m_IOleCommandTarget)); + hr = m_IUnknown->QueryInterface(IID_PPV_ARG(IServiceProvider, &m_IServiceProvider)); + hr = m_IUnknown->QueryInterface(IID_PPV_ARG(IDeskBar, &m_IDeskBar)); + hr = m_IUnknown->QueryInterface(IID_PPV_ARG(IOleWindow, &m_IOleWindow)); + hr = m_IUnknown->QueryInterface(IID_PPV_ARG(IInputObjectSite, &m_IInputObjectSite)); + hr = m_IUnknown->QueryInterface(IID_PPV_ARG(IInputObject, &m_IInputObject)); + hr = m_IUnknown->QueryInterface(IID_PPV_ARG(IObjectWithSite, &m_IObjectWithSite)); + hr = m_IUnknown->QueryInterface(IID_PPV_ARG(IBanneredBar, &m_IBanneredBar)); + hr = m_IUnknown->QueryInterface(IID_PPV_ARG(IInitializeObject, &m_IInitializeObject)); +} + +CMenuDeskBar::~CMenuDeskBar() +{ + m_IUnknown->Release(); + m_IMenuPopup->Release(); + m_IOleCommandTarget->Release(); + m_IServiceProvider->Release(); + m_IDeskBar->Release(); + m_IOleWindow->Release(); + m_IInputObjectSite->Release(); + m_IInputObject->Release(); + m_IObjectWithSite->Release(); + m_IBanneredBar->Release(); + m_IInitializeObject->Release(); + + WrapLogClose(); +} + +// *** IMenuPopup methods *** +HRESULT STDMETHODCALLTYPE CMenuDeskBar::Popup(POINTL *ppt, RECTL *prcExclude, MP_POPUPFLAGS dwFlags) +{ + WrapLogEnter("CMenuDeskBar<%p>::Popup(POINTL *ppt=%p, RECTL *prcExclude=%p, MP_POPUPFLAGS dwFlags=%08x)\n", this, ppt, prcExclude, dwFlags); + HRESULT hr = m_IMenuPopup->Popup(ppt, prcExclude, dwFlags); + WrapLogExit("CMenuDeskBar::Popup() = %08x\n", hr); + return hr; +} + +HRESULT STDMETHODCALLTYPE CMenuDeskBar::OnSelect(DWORD dwSelectType) +{ + WrapLogEnter("CMenuDeskBar<%p>::OnSelect(DWORD dwSelectType=%08x)\n", this, dwSelectType); + HRESULT hr = m_IMenuPopup->OnSelect(dwSelectType); + WrapLogExit("CMenuDeskBar::OnSelect() = %08x\n", hr); + return hr; +} + +HRESULT STDMETHODCALLTYPE CMenuDeskBar::SetSubMenu(IMenuPopup *pmp, BOOL fSet) +{ + WrapLogEnter("CMenuDeskBar<%p>::SetSubMenu(IMenuPopup *pmp=%p, BOOL fSet=%d)\n", this, pmp, fSet); + HRESULT hr = m_IMenuPopup->SetSubMenu(pmp, fSet); + WrapLogExit("CMenuDeskBar::SetSubMenu() = %08x\n", hr); + return hr; +} + +// *** IOleWindow methods *** +HRESULT STDMETHODCALLTYPE CMenuDeskBar::GetWindow(HWND *phwnd) +{ + WrapLogEnter("CMenuDeskBar<%p>::GetWindow(HWND *phwnd=%p)\n", this, phwnd); + HRESULT hr = m_IOleWindow->GetWindow(phwnd); + if (phwnd) WrapLogMsg("*phwnd=%p\n", *phwnd); + WrapLogExit("CMenuDeskBar::GetWindow() = %08x\n", hr); + return hr; +} + +HRESULT STDMETHODCALLTYPE CMenuDeskBar::ContextSensitiveHelp(BOOL fEnterMode) +{ + WrapLogEnter("CMenuDeskBar<%p>::ContextSensitiveHelp(BOOL fEnterMode=%d)\n", this, fEnterMode); + HRESULT hr = m_IOleWindow->ContextSensitiveHelp(fEnterMode); + WrapLogExit("CMenuDeskBar::ContextSensitiveHelp() = %08x\n", hr); + return hr; +} + +// *** IObjectWithSite methods *** +HRESULT STDMETHODCALLTYPE CMenuDeskBar::SetSite(IUnknown *pUnkSite) +{ + WrapLogEnter("CMenuDeskBar<%p>::SetSite(IUnknown *pUnkSite=%p)\n", this, pUnkSite); + HRESULT hr = m_IObjectWithSite->SetSite(pUnkSite); + WrapLogExit("CMenuDeskBar::SetSite() = %08x\n", hr); + return hr; +} + +HRESULT STDMETHODCALLTYPE CMenuDeskBar::GetSite(REFIID riid, PVOID *ppvSite) +{ + WrapLogEnter("CMenuDeskBar<%p>::GetSite(REFIID riid=%s, PVOID *ppvSite=%p)\n", this, Wrap(riid), ppvSite); + HRESULT hr = m_IObjectWithSite->GetSite(riid, ppvSite); + if (ppvSite) WrapLogMsg("*ppvSite=%p\n", *ppvSite); + WrapLogExit("CMenuDeskBar::GetSite() = %08x\n", hr); + return hr; +} + +// *** IBanneredBar methods *** +HRESULT STDMETHODCALLTYPE CMenuDeskBar::SetIconSize(DWORD iIcon) +{ + WrapLogEnter("CMenuDeskBar<%p>::SetIconSize(DWORD iIcon=%d)\n", this, iIcon); + HRESULT hr = m_IBanneredBar->SetIconSize(iIcon); + WrapLogExit("CMenuDeskBar::SetIconSize() = %08x\n", hr); + return hr; +} + +HRESULT STDMETHODCALLTYPE CMenuDeskBar::GetIconSize(DWORD* piIcon) +{ + WrapLogEnter("CMenuDeskBar<%p>::GetIconSize(DWORD* piIcon=%p)\n", this, piIcon); + HRESULT hr = m_IBanneredBar->GetIconSize(piIcon); + if (piIcon) WrapLogMsg("*piIcon=%d\n", *piIcon); + WrapLogExit("CMenuDeskBar::GetIconSize() = %08x\n", hr); + return hr; +} + +HRESULT STDMETHODCALLTYPE CMenuDeskBar::SetBitmap(HBITMAP hBitmap) +{ + WrapLogEnter("CMenuDeskBar<%p>::SetBitmap(HBITMAP hBitmap=%p)\n", this, hBitmap); + HRESULT hr = m_IBanneredBar->SetBitmap(hBitmap); + WrapLogExit("CMenuDeskBar::SetBitmap() = %08x\n", hr); + return hr; +} + +HRESULT STDMETHODCALLTYPE CMenuDeskBar::GetBitmap(HBITMAP* phBitmap) +{ + WrapLogEnter("CMenuDeskBar<%p>::GetBitmap(HBITMAP* phBitmap=%p)\n", this, phBitmap); + HRESULT hr = m_IBanneredBar->GetBitmap(phBitmap); + if (phBitmap) WrapLogMsg("*phBitmap=%p\n", *phBitmap); + WrapLogExit("CMenuDeskBar::GetBitmap() = %08x\n", hr); + return hr; +} + + +// *** IInitializeObject methods *** +HRESULT STDMETHODCALLTYPE CMenuDeskBar::Initialize(THIS) +{ + WrapLogEnter("CMenuDeskBar<%p>::Initialize()\n", this); + HRESULT hr = m_IInitializeObject->Initialize(); + WrapLogExit("CMenuDeskBar::Initialize() = %08x\n", hr); + return hr; +} + +// *** IOleCommandTarget methods *** +HRESULT STDMETHODCALLTYPE CMenuDeskBar::QueryStatus(const GUID *pguidCmdGroup, ULONG cCmds, OLECMD prgCmds [], OLECMDTEXT *pCmdText) +{ + WrapLogEnter("CMenuDeskBar<%p>::QueryStatus(const GUID *pguidCmdGroup=%p, ULONG cCmds=%u, prgCmds=%p, pCmdText=%p)\n", this, pguidCmdGroup, cCmds, prgCmds, pCmdText); + HRESULT hr = m_IOleCommandTarget->QueryStatus(pguidCmdGroup, cCmds, prgCmds, pCmdText); + if (pguidCmdGroup) WrapLogMsg("*pguidCmdGroup=%s\n", Wrap(*pguidCmdGroup)); + WrapLogExit("CMenuDeskBar::QueryStatus() = %08x\n", hr); + return hr; +} + +HRESULT STDMETHODCALLTYPE CMenuDeskBar::Exec(const GUID *pguidCmdGroup, DWORD nCmdID, DWORD nCmdexecopt, VARIANT *pvaIn, VARIANT *pvaOut) +{ + //bool b; + + WrapLogEnter("CMenuDeskBar<%p>::Exec(const GUID *pguidCmdGroup=%p, DWORD nCmdID=%d, DWORD nCmdexecopt=%d, VARIANT *pvaIn=%p, VARIANT *pvaOut=%p)\n", this, pguidCmdGroup, nCmdID, nCmdexecopt, pvaIn, pvaOut); + + //if (pguidCmdGroup && IsEqualGUID(*pguidCmdGroup, CLSID_MenuBand)) + //{ + // if (nCmdID == 19) // popup + // { + // b = true; + // } + //} + + + if (pguidCmdGroup) WrapLogMsg("*pguidCmdGroup=%s\n", Wrap(*pguidCmdGroup)); + HRESULT hr = m_IOleCommandTarget->Exec(pguidCmdGroup, nCmdID, nCmdexecopt, pvaIn, pvaOut); + WrapLogExit("CMenuDeskBar::Exec() = %08x\n", hr); + return hr; +} + +// *** IServiceProvider methods *** +HRESULT STDMETHODCALLTYPE CMenuDeskBar::QueryService(REFGUID guidService, REFIID riid, void **ppvObject) +{ + WrapLogEnter("CMenuDeskBar<%p>::QueryService(REFGUID guidService=%s, REFIID riid=%s, void **ppvObject=%p)\n", this, Wrap(guidService), Wrap(riid), ppvObject); + + //if (IsEqualIID(guidService, SID_SMenuBandChild)) + //{ + // WrapLogMsg("SID is SID_SMenuBandChild. Using QueryInterface of self instead of wrapped object.\n"); + // HRESULT hr = this->QueryInterface(riid, ppvObject); + // if (ppvObject) WrapLogMsg("*ppvObject=%p\n", *ppvObject); + // WrapLogExit("CMenuDeskBar::QueryService() = %08x\n", hr); + // return hr; + //} + //else + { + WrapLogMsg("SID not identified.\n"); + } + HRESULT hr = m_IServiceProvider->QueryService(guidService, riid, ppvObject); + if (ppvObject) WrapLogMsg("*ppvObject=%p\n", *ppvObject); + WrapLogExit("CMenuDeskBar::QueryService() = %08x\n", hr); + return hr; +} + +// *** IInputObjectSite methods *** +HRESULT STDMETHODCALLTYPE CMenuDeskBar::OnFocusChangeIS(LPUNKNOWN lpUnknown, BOOL bFocus) +{ + WrapLogEnter("CMenuDeskBar<%p>::OnFocusChangeIS(LPUNKNOWN lpUnknown=%p, BOOL bFocus=%d)\n", this, lpUnknown, bFocus); + HRESULT hr = m_IInputObjectSite->OnFocusChangeIS(lpUnknown, bFocus); + WrapLogExit("CMenuDeskBar::OnFocusChangeIS() = %08x\n", hr); + return hr; +} + +// *** IInputObject methods *** +HRESULT STDMETHODCALLTYPE CMenuDeskBar::UIActivateIO(BOOL bActivating, LPMSG lpMsg) +{ + WrapLogEnter("CMenuDeskBar<%p>::UIActivateIO(BOOL bActivating=%d, LPMSG lpMsg=%p)\n", this, bActivating, lpMsg); + HRESULT hr = m_IInputObject->UIActivateIO(bActivating, lpMsg); + WrapLogExit("CMenuDeskBar::UIActivateIO() = %08x\n", hr); + return hr; +} + +HRESULT STDMETHODCALLTYPE CMenuDeskBar::HasFocusIO(THIS) +{ + WrapLogEnter("CMenuDeskBar<%p>::HasFocusIO()\n", this); + HRESULT hr = m_IInputObject->HasFocusIO(); + WrapLogExit("CMenuDeskBar::HasFocusIO() = %08x\n", hr); + return hr; +} + +HRESULT STDMETHODCALLTYPE CMenuDeskBar::TranslateAcceleratorIO(LPMSG lpMsg) +{ + WrapLogEnter("CMenuDeskBar<%p>::TranslateAcceleratorIO(LPMSG lpMsg=%p)\n", this, lpMsg); + if (lpMsg) WrapLogMsg("*lpMsg=%s\n", Wrap(*lpMsg)); + HRESULT hr = m_IInputObject->TranslateAcceleratorIO(lpMsg); + WrapLogExit("CMenuDeskBar::TranslateAcceleratorIO() = %08x\n", hr); + return hr; +} + +// *** IDeskBar methods *** +HRESULT STDMETHODCALLTYPE CMenuDeskBar::SetClient(IUnknown *punkClient) +{ + WrapLogEnter("CMenuDeskBar<%p>::SetClient(IUnknown *punkClient=%p)\n", this, punkClient); + HRESULT hr = m_IDeskBar->SetClient(punkClient); + WrapLogExit("CMenuDeskBar::SetClient() = %08x\n", hr); + return hr; +} + +HRESULT STDMETHODCALLTYPE CMenuDeskBar::GetClient(IUnknown **ppunkClient) +{ + WrapLogEnter("CMenuDeskBar<%p>::GetClient(IUnknown **ppunkClient=%p)\n", this, ppunkClient); + HRESULT hr = m_IDeskBar->GetClient(ppunkClient); + if (ppunkClient) WrapLogMsg("*ppunkClient=%p\n", *ppunkClient); + WrapLogExit("CMenuDeskBar::GetClient() = %08x\n", hr); + return hr; +} + +HRESULT STDMETHODCALLTYPE CMenuDeskBar::OnPosRectChangeDB(LPRECT prc) +{ + WrapLogEnter("CMenuDeskBar<%p>::OnPosRectChangeDB(RECT *prc=%p)\n", this, prc); + HRESULT hr = m_IDeskBar->OnPosRectChangeDB(prc); + if (prc) WrapLogMsg("*prc=%s\n", Wrap(*prc)); + WrapLogExit("CMenuDeskBar::OnPosRectChangeDB() = %08x\n", hr); + return hr; +} Propchange: branches/shell-experiments/base/shell/rshell/CMenuDeskBar.cpp ------------------------------------------------------------------------------ svn:eol-style = native Modified: branches/shell-experiments/base/shell/rshell/CStartMenu.cpp URL: http://svn.reactos.org/svn/reactos/branches/shell-experiments/base/shell/rs… ============================================================================== --- branches/shell-experiments/base/shell/rshell/CStartMenu.cpp [iso-8859-1] (original) +++ branches/shell-experiments/base/shell/rshell/CStartMenu.cpp [iso-8859-1] Wed Feb 12 17:48:49 2014 @@ -270,7 +270,7 @@ if (FAILED(hr)) return NULL; -#if 1 +#if 0 hr = CoCreateInstance(CLSID_MenuBandSite, NULL, CLSCTX_INPROC_SERVER, @@ -281,10 +281,14 @@ if (FAILED(hr)) return NULL; +#if 0 hr = CoCreateInstance(CLSID_MenuDeskBar, NULL, CLSCTX_INPROC_SERVER, IID_PPV_ARG(IDeskBar, &pDeskBar)); +#else + hr = CMenuDeskBar_Constructor(IID_PPV_ARG(IDeskBar, &pDeskBar)); +#endif if (FAILED(hr)) return NULL; Modified: branches/shell-experiments/base/shell/rshell/precomp.h URL: http://svn.reactos.org/svn/reactos/branches/shell-experiments/base/shell/rs… ============================================================================== --- branches/shell-experiments/base/shell/rshell/precomp.h [iso-8859-1] (original) +++ branches/shell-experiments/base/shell/rshell/precomp.h [iso-8859-1] Wed Feb 12 17:48:49 2014 @@ -30,5 +30,6 @@ #define SMC_EXEC 4 extern "C" INT WINAPI Shell_GetCachedImageIndex(LPCWSTR szPath, INT nIndex, UINT bSimulateDoc); +extern "C" HRESULT CMenuDeskBar_Constructor(REFIID riid, LPVOID *ppv); extern "C" HRESULT CMenuSite_Constructor(REFIID riid, LPVOID *ppv); extern "C" HRESULT CMenuBand_Constructor(REFIID riid, LPVOID *ppv); Modified: branches/shell-experiments/base/shell/rshell/wraplog.cpp URL: http://svn.reactos.org/svn/reactos/branches/shell-experiments/base/shell/rs… ============================================================================== --- branches/shell-experiments/base/shell/rshell/wraplog.cpp [iso-8859-1] (original) +++ branches/shell-experiments/base/shell/rshell/wraplog.cpp [iso-8859-1] Wed Feb 12 17:48:49 2014 @@ -13,7 +13,7 @@ { if (openCount == 0) { - log = fopen("G:\\CMenuBand.log", "w"); + log = fopen("G:\\RShellWrap.log", "w"); nTemps = 0; callLevel = 0; }

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs