Ros-diffs

ros-diffs@reactos.org

81390 discussions

[tkreuzer] 61571: [RTL/NTDLL] - Implement registry transaction API (RXACT) - Add RtlCheckForOrphanedCriticalSections stub
by tkreuzer＠svn.reactos.org 07 Jan '14

07 Jan '14

Author: tkreuzer Date: Tue Jan 7 21:26:06 2014 New Revision: 61571 URL: http://svn.reactos.org/svn/reactos?rev=61571&view=rev Log: [RTL/NTDLL] - Implement registry transaction API (RXACT) - Add RtlCheckForOrphanedCriticalSections stub Added: trunk/reactos/lib/rtl/rxact.c (with props) Modified: trunk/reactos/dll/ntdll/def/ntdll.spec trunk/reactos/lib/rtl/CMakeLists.txt trunk/reactos/lib/rtl/critical.c Modified: trunk/reactos/dll/ntdll/def/ntdll.spec URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/ntdll/def/ntdll.spec?r… ============================================================================== --- trunk/reactos/dll/ntdll/def/ntdll.spec [iso-8859-1] (original) +++ trunk/reactos/dll/ntdll/def/ntdll.spec [iso-8859-1] Tue Jan 7 21:26:06 2014 @@ -376,7 +376,7 @@ ;@ stdcall PfxInsertPrefix ;@ stdcall PfxRemovePrefix ;@ stdcall PropertyLengthAsVariant -;@ stdcall RtlAbortRXact +@ stdcall RtlAbortRXact(ptr) @ stdcall RtlAbsoluteToSelfRelativeSD(ptr ptr ptr) @ stdcall RtlAcquirePebLock() @ stdcall RtlAcquirePrivilege(ptr long long ptr) @@ -394,9 +394,9 @@ @ stdcall RtlAddAccessDeniedAceEx(ptr long long long ptr) @ stdcall RtlAddAccessDeniedObjectAce(ptr long long long ptr ptr ptr) @ stdcall RtlAddAce(ptr long long ptr long) -;@ stdcall RtlAddActionToRXact +@ stdcall RtlAddActionToRXact(ptr long ptr long ptr long) @ stdcall RtlAddAtomToAtomTable(ptr wstr ptr) -;@ stdcall RtlAddAttributeActionToRXact +@ stdcall RtlAddAttributeActionToRXact(ptr long ptr ptr ptr long ptr long) @ stdcall RtlAddAuditAccessAce(ptr long long ptr long long) @ stdcall RtlAddAuditAccessAceEx(ptr long long long ptr long long) @ stdcall RtlAddAuditAccessObjectAce(ptr long long long ptr ptr ptr long long) @@ -423,8 +423,8 @@ @ stdcall RtlAppendUnicodeStringToString(ptr ptr) @ stdcall RtlAppendUnicodeToString(ptr wstr) ;@ stdcall RtlApplicationVerifierStop -;@ stdcall RtlApplyRXact -;@ stdcall RtlApplyRXactNoFlush +@ stdcall RtlApplyRXact(ptr) +@ stdcall RtlApplyRXactNoFlush(ptr) @ stdcall RtlAreAllAccessesGranted(long long) @ stdcall RtlAreAnyAccessesGranted(long long) @ stdcall RtlAreBitsClear(ptr long long) @@ -435,7 +435,7 @@ @ stdcall RtlCaptureStackBackTrace(long long ptr ptr) ;@ stdcall RtlCaptureStackContext @ stdcall RtlCharToInteger(ptr long ptr) -;@ stdcall RtlCheckForOrphanedCriticalSections +@ stdcall RtlCheckForOrphanedCriticalSections(ptr) ;@ stdcall RtlCheckProcessParameters @ stdcall RtlCheckRegistryKey(long ptr) @ stdcall RtlClearAllBits(ptr) @@ -673,7 +673,7 @@ @ stdcall RtlInitializeGenericTable(ptr ptr ptr ptr ptr) @ stdcall RtlInitializeGenericTableAvl(ptr ptr ptr ptr ptr) @ stdcall RtlInitializeHandleTable(long long ptr) -;@ stdcall RtlInitializeRXact +@ stdcall RtlInitializeRXact(ptr long ptr) @ stdcall RtlInitializeRangeList(ptr) @ stdcall RtlInitializeResource(ptr) @ stdcall RtlInitializeSListHead(ptr) @@ -868,7 +868,7 @@ @ stdcall RtlSleepConditionVariableCS(ptr ptr ptr) @ stdcall RtlSleepConditionVariableSRW(ptr ptr ptr long) @ stdcall RtlSplay(ptr) -;@ stdcall RtlStartRXact +@ stdcall RtlStartRXact(ptr) @ stdcall RtlStatMemoryStream(ptr ptr long) @ stdcall RtlStringFromGUID(ptr ptr) @ stdcall RtlSubAuthorityCountSid(ptr) Modified: trunk/reactos/lib/rtl/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/rtl/CMakeLists.txt?rev… ============================================================================== --- trunk/reactos/lib/rtl/CMakeLists.txt [iso-8859-1] (original) +++ trunk/reactos/lib/rtl/CMakeLists.txt [iso-8859-1] Tue Jan 7 21:26:06 2014 @@ -49,6 +49,7 @@ registry.c res.c resource.c + rxact.c sd.c security.c slist.c Modified: trunk/reactos/lib/rtl/critical.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/rtl/critical.c?rev=615… ============================================================================== --- trunk/reactos/lib/rtl/critical.c [iso-8859-1] (original) +++ trunk/reactos/lib/rtl/critical.c [iso-8859-1] Tue Jan 7 21:26:06 2014 @@ -757,4 +757,12 @@ return FALSE; } +VOID +NTAPI +RtlCheckForOrphanedCriticalSections( + HANDLE ThreadHandle) +{ + UNIMPLEMENTED; +} + /* EOF */ Added: trunk/reactos/lib/rtl/rxact.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/rtl/rxact.c?rev=61571 ============================================================================== --- trunk/reactos/lib/rtl/rxact.c (added) +++ trunk/reactos/lib/rtl/rxact.c [iso-8859-1] Tue Jan 7 21:26:06 2014 @@ -0,0 +1,696 @@ +/* + * COPYRIGHT: See COPYING in the top level directory + * PROJECT: ReactOS system libraries + * FILE: lib/rtl/rxact.c + * PURPOSE: Registry Transaction API + * PROGRAMMERS: Timo Kreuzer (timo.kreuzer(a)reactos.org) + */ + +/* INCLUDES *****************************************************************/ + +#include <rtl.h> +#include <ndk/cmfuncs.h> + +#define NDEBUG +#include <debug.h> + +#define RXACT_DEFAULT_BUFFER_SIZE (4 * PAGE_SIZE) + +typedef struct _RXACT_INFO +{ + ULONG Revision; + ULONG Unknown1; + ULONG Unknown2; +} RXACT_INFO, *PRXACT_INFO; + +typedef struct _RXACT_DATA +{ + ULONG ActionCount; + ULONG BufferSize; + ULONG CurrentSize; +} RXACT_DATA, *PRXACT_DATA; + +typedef struct _RXACT_CONTEXT +{ + HANDLE RootDirectory; + HANDLE KeyHandle; + BOOLEAN CanUseHandles; + PRXACT_DATA Data; +} RXACT_CONTEXT, *PRXACT_CONTEXT; + +typedef struct _RXACT_ACTION +{ + ULONG Size; + ULONG Type; + UNICODE_STRING KeyName; + UNICODE_STRING ValueName; + HANDLE KeyHandle; + ULONG ValueType; + ULONG ValueDataSize; + PVOID ValueData; +} RXACT_ACTION, *PRXACT_ACTION; + +enum +{ + RXactDeleteKey = 1, + RXactSetValueKey = 2, +}; + +#define ALIGN_UP_BY ROUND_UP + +/* FUNCTIONS *****************************************************************/ + +static +VOID +NTAPI +RXactInitializeContext( + PRXACT_CONTEXT Context, + HANDLE RootDirectory, + HANDLE KeyHandle) +{ + Context->Data = NULL; + Context->RootDirectory = RootDirectory; + Context->CanUseHandles = TRUE; + Context->KeyHandle = KeyHandle; +} + +static +NTSTATUS +NTAPI +RXactpOpenTargetKey( + HANDLE RootDirectory, + ULONG ActionType, + PUNICODE_STRING KeyName, + PHANDLE KeyHandle) +{ + NTSTATUS Status; + ULONG Disposition; + OBJECT_ATTRIBUTES ObjectAttributes; + + /* Check what kind of action this is */ + if (ActionType == RXactDeleteKey) + { + /* This is a delete, so open the key for delete */ + InitializeObjectAttributes(&ObjectAttributes, + KeyName, + OBJ_CASE_INSENSITIVE, + RootDirectory, + NULL); + Status = ZwOpenKey(KeyHandle, DELETE, &ObjectAttributes); + } + else if (ActionType == RXactSetValueKey) + { + /* This is a create, so open or create with write access */ + InitializeObjectAttributes(&ObjectAttributes, + KeyName, + OBJ_CASE_INSENSITIVE | OBJ_OPENIF, + RootDirectory, + NULL); + Status = ZwCreateKey(KeyHandle, + KEY_WRITE, + &ObjectAttributes, + 0, + NULL, + 0, + &Disposition); + } + else + { + return STATUS_INVALID_PARAMETER; + } + + return Status; +} + +static +NTSTATUS +NTAPI +RXactpCommit( + PRXACT_CONTEXT Context) +{ + PRXACT_DATA Data; + PRXACT_ACTION Action; + NTSTATUS Status, TmpStatus; + HANDLE KeyHandle; + ULONG i; + + Data = Context->Data; + + /* The first action record starts after the data header */ + Action = (PRXACT_ACTION)(Data + 1); + + /* Loop all recorded actions */ + for (i = 0; i < Data->ActionCount; i++) + { + /* Translate relative offsets to actual pointers */ + Action->KeyName.Buffer = (PWSTR)((PUCHAR)Data + (ULONG_PTR)Action->KeyName.Buffer); + Action->ValueName.Buffer = (PWSTR)((PUCHAR)Data + (ULONG_PTR)Action->ValueName.Buffer); + Action->ValueData = (PUCHAR)Data + (ULONG_PTR)Action->ValueData; + + /* Check what kind of action this is */ + if (Action->Type == RXactDeleteKey) + { + /* This is a delete action. Check if we can use a handle */ + if ((Action->KeyHandle != INVALID_HANDLE_VALUE) && Context->CanUseHandles) + { + /* Delete the key by the given handle */ + Status = ZwDeleteKey(Action->KeyHandle); + if (!NT_SUCCESS(Status)) + { + return Status; + } + } + else + { + /* We cannot use a handle, open the key first by it's name */ + Status = RXactpOpenTargetKey(Context->RootDirectory, + RXactDeleteKey, + &Action->KeyName, + &KeyHandle); + if (NT_SUCCESS(Status)) + { + Status = ZwDeleteKey(KeyHandle); + TmpStatus = NtClose(KeyHandle); + ASSERT(NT_SUCCESS(TmpStatus)); + if (!NT_SUCCESS(Status)) + { + return Status; + } + } + else + { + /* Failed to open the key, it's ok, if it was not found */ + if (Status != STATUS_OBJECT_NAME_NOT_FOUND) + return Status; + } + } + } + else if (Action->Type == RXactSetValueKey) + { + /* This is a set action. Check if we can use a handle */ + if ((Action->KeyHandle != INVALID_HANDLE_VALUE) && Context->CanUseHandles) + { + /* Set the key value using the given key handle */ + Status = ZwSetValueKey(Action->KeyHandle, + &Action->ValueName, + 0, + Action->ValueType, + Action->ValueData, + Action->ValueDataSize); + if (!NT_SUCCESS(Status)) + { + return Status; + } + } + else + { + /* We cannot use a handle, open the key first by it's name */ + Status = RXactpOpenTargetKey(Context->RootDirectory, + RXactSetValueKey, + &Action->KeyName, + &KeyHandle); + if (!NT_SUCCESS(Status)) + { + return Status; + } + + /* Set the key value */ + Status = ZwSetValueKey(KeyHandle, + &Action->ValueName, + 0, + Action->ValueType, + Action->ValueData, + Action->ValueDataSize); + + TmpStatus = NtClose(KeyHandle); + ASSERT(NT_SUCCESS(TmpStatus)); + + if (!NT_SUCCESS(Status)) + { + return Status; + } + } + } + else + { + ASSERT(FALSE); + return STATUS_INVALID_PARAMETER; + } + + /* Go to the next action record */ + Action = (PRXACT_ACTION)((PUCHAR)Action + Action->Size); + } + + return STATUS_SUCCESS; +} + +NTSTATUS +NTAPI +RtlStartRXact( + PRXACT_CONTEXT Context) +{ + PRXACT_DATA Buffer; + + /* We must not have a buffer yet */ + if (Context->Data != NULL) + { + return STATUS_RXACT_INVALID_STATE; + } + + /* Allocate a buffer */ + Buffer = RtlAllocateHeap(RtlGetProcessHeap(), 0, RXACT_DEFAULT_BUFFER_SIZE); + if (Buffer == NULL) + { + return STATUS_NO_MEMORY; + } + + /* Initialize the buffer */ + Buffer->ActionCount = 0; + Buffer->BufferSize = RXACT_DEFAULT_BUFFER_SIZE; + Buffer->CurrentSize = sizeof(RXACT_DATA); + Context->Data = Buffer; + + return STATUS_SUCCESS; +} + +NTSTATUS +NTAPI +RtlAbortRXact( + PRXACT_CONTEXT Context) +{ + /* We must have a data buffer */ + if (Context->Data == NULL) + { + return STATUS_RXACT_INVALID_STATE; + } + + /* Free the buffer */ + RtlFreeHeap(RtlGetProcessHeap(), 0, Context->Data); + + /* Reinitialize the context */ + RXactInitializeContext(Context, Context->RootDirectory, Context->KeyHandle); + + return STATUS_SUCCESS; +} + +NTSTATUS +NTAPI +RtlInitializeRXact( + HANDLE RootDirectory, + BOOLEAN Commit, + PRXACT_CONTEXT *OutContext) +{ + NTSTATUS Status, TmpStatus; + PRXACT_CONTEXT Context; + PKEY_VALUE_FULL_INFORMATION KeyValueInformation; + KEY_VALUE_BASIC_INFORMATION KeyValueBasicInfo; + UNICODE_STRING ValueName; + UNICODE_STRING KeyName; + OBJECT_ATTRIBUTES ObjectAttributes; + RXACT_INFO TransactionInfo; + ULONG Disposition; + ULONG ValueType; + ULONG ValueDataLength; + ULONG Length; + HANDLE KeyHandle; + + /* Open or create the 'RXACT' key in the root directory */ + RtlInitUnicodeString(&KeyName, L"RXACT"); + InitializeObjectAttributes(&ObjectAttributes, + &KeyName, + OBJ_CASE_INSENSITIVE | OBJ_OPENIF, + RootDirectory, + NULL); + Status = ZwCreateKey(&KeyHandle, + KEY_READ | KEY_WRITE | DELETE, + &ObjectAttributes, + 0, + NULL, + 0, + &Disposition); + if (!NT_SUCCESS(Status)) + { + return Status; + } + + /* Allocate a new context */ + Context = RtlAllocateHeap(RtlGetProcessHeap(), 0, sizeof(*Context)); + *OutContext = Context; + if (Context == NULL) + { + TmpStatus = ZwDeleteKey(KeyHandle); + ASSERT(NT_SUCCESS(TmpStatus)); + + TmpStatus = NtClose(KeyHandle); + ASSERT(NT_SUCCESS(TmpStatus)); + + return STATUS_NO_MEMORY; + } + + /* Initialize the context */ + RXactInitializeContext(Context, RootDirectory, KeyHandle); + + /* Check if we created a new key */ + if (Disposition == REG_CREATED_NEW_KEY) + { + /* The key is new, set the default value */ + TransactionInfo.Revision = 1; + RtlInitUnicodeString(&ValueName, NULL); + Status = ZwSetValueKey(KeyHandle, + &ValueName, + 0, + REG_NONE, + &TransactionInfo, + sizeof(TransactionInfo)); + if (!NT_SUCCESS(Status)) + { + TmpStatus = ZwDeleteKey(KeyHandle); + ASSERT(NT_SUCCESS(TmpStatus)); + + TmpStatus = NtClose(KeyHandle); + ASSERT(NT_SUCCESS(TmpStatus)); + + RtlFreeHeap(RtlGetProcessHeap(), 0, *OutContext); + return Status; + } + + return STATUS_RXACT_STATE_CREATED; + } + else + { + /* The key exited, get the default key value */ + ValueDataLength = sizeof(TransactionInfo); + Status = RtlpNtQueryValueKey(KeyHandle, + &ValueType, + &TransactionInfo, + &ValueDataLength, + 0); + if (!NT_SUCCESS(Status)) + { + TmpStatus = NtClose(KeyHandle); + ASSERT(NT_SUCCESS(TmpStatus)); + RtlFreeHeap(RtlGetProcessHeap(), 0, Context); + return Status; + } + + /* Check if the value date is valid */ + if ((ValueDataLength != sizeof(TransactionInfo)) || + (TransactionInfo.Revision != 1)) + { + TmpStatus = NtClose(KeyHandle); + ASSERT(NT_SUCCESS(TmpStatus)); + RtlFreeHeap(RtlGetProcessHeap(), 0, Context); + return STATUS_UNKNOWN_REVISION; + } + + /* Query the 'Log' key value */ + RtlInitUnicodeString(&ValueName, L"Log"); + Status = ZwQueryValueKey(KeyHandle, + &ValueName, + KeyValueBasicInformation, + &KeyValueBasicInfo, + sizeof(KeyValueBasicInfo), + &Length); + if (!NT_SUCCESS(Status)) + { + /* There is no 'Log', so we are done */ + return STATUS_SUCCESS; + } + + /* Check if the caller asked to commit the current state */ + if (!Commit) + { + /* We have a log, that must be committed first! */ + return STATUS_RXACT_COMMIT_NECESSARY; + } + + /* Query the size of the 'Log' key value */ + Status = ZwQueryValueKey(KeyHandle, + &ValueName, + KeyValueFullInformation, + NULL, + 0, + &Length); + if (Status != STATUS_BUFFER_TOO_SMALL) + { + return Status; + } + + /* Allocate a buffer for the key value information */ + KeyValueInformation = RtlAllocateHeap(RtlGetProcessHeap(), 0, Length); + if (KeyValueInformation == NULL) + { + return STATUS_NO_MEMORY; + } + + /* Query the 'Log' key value */ + Status = ZwQueryValueKey(KeyHandle, + &ValueName, + KeyValueFullInformation, + KeyValueInformation, + Length, + &Length); + if (!NT_SUCCESS(Status)) + { + RtlFreeHeap(RtlGetProcessHeap(), 0, KeyValueInformation); + RtlFreeHeap(RtlGetProcessHeap(), 0, Context); + return Status; + } + + /* Set the Data pointer to the key value data */ + Context->Data = (PRXACT_DATA)((PUCHAR)KeyValueInformation + + KeyValueInformation->DataOffset); + + /* This is an old log, don't use handles when committing! */ + Context->CanUseHandles = FALSE; + + /* Commit the data */ + Status = RXactpCommit(Context); + if (!NT_SUCCESS(Status)) + { + RtlFreeHeap(RtlGetProcessHeap(), 0, KeyValueInformation); + RtlFreeHeap(RtlGetProcessHeap(), 0, Context); + return Status; + } + + /* Delete the old key */ + Status = NtDeleteValueKey(KeyHandle, &ValueName); + ASSERT(NT_SUCCESS(Status)); + + /* Set the data member to the allocated buffer, so it will get freed */ + Context->Data = (PRXACT_DATA)KeyValueInformation; + + /* Abort the old transaction */ + Status = RtlAbortRXact(Context); + ASSERT(NT_SUCCESS(Status)); + + return Status; + } +} + +NTSTATUS +NTAPI +RtlAddAttributeActionToRXact( + PRXACT_CONTEXT Context, + ULONG ActionType, + PUNICODE_STRING KeyName, + HANDLE KeyHandle, + PUNICODE_STRING ValueName, + ULONG ValueType, + PVOID ValueData, + ULONG ValueDataSize) +{ + ULONG ActionSize; + ULONG RequiredSize; + ULONG BufferSize; + ULONG CurrentOffset; + PRXACT_DATA NewData; + PRXACT_ACTION Action; + + /* Validate ActionType parameter */ + if ((ActionType != RXactDeleteKey) && (ActionType != RXactSetValueKey)) + { + return STATUS_INVALID_PARAMETER; + } + + /* Calculate the size of the new action record */ + ActionSize = ALIGN_UP_BY(ValueName->Length, sizeof(ULONG)) + + ALIGN_UP_BY(ValueDataSize, sizeof(ULONG)) + + ALIGN_UP_BY(KeyName->Length, sizeof(ULONG)) + + ALIGN_UP_BY(sizeof(RXACT_ACTION), sizeof(ULONG)); + + /* Calculate the new buffer size we need */ + RequiredSize = ActionSize + Context->Data->CurrentSize; + + /* Check for integer overflow */ + if (RequiredSize < ActionSize) + { + return STATUS_NO_MEMORY; + } + + /* Check if the buffer is large enough */ + BufferSize = Context->Data->BufferSize; + if (RequiredSize > BufferSize) + { + /* Increase by a factor of 2, until it is large enough */ + while (BufferSize < RequiredSize) + { + BufferSize *= 2; + } + + /* Allocate a new buffer from the heap */ + NewData = RtlAllocateHeap(RtlGetProcessHeap(), 0, BufferSize); + if (NewData == NULL) + { + return STATUS_NO_MEMORY; + } + + /* Copy the old buffer to the new one */ + RtlCopyMemory(NewData, Context->Data, Context->Data->CurrentSize); + + /* Free the old buffer and use the new one */ + RtlFreeHeap(RtlGetProcessHeap(), 0, Context->Data); + Context->Data = NewData; + NewData->BufferSize = BufferSize; + } + + /* Get the next action record */ + Action = (RXACT_ACTION *)((PUCHAR)Context->Data + Context->Data->CurrentSize); + + /* Fill in the fields */ + Action->Size = ActionSize; + Action->Type = ActionType; + Action->KeyName = *KeyName; + Action->ValueName = *ValueName; + Action->ValueType = ValueType; + Action->ValueDataSize = ValueDataSize; + Action->KeyHandle = KeyHandle; + + /* Copy the key name (and convert the pointer to a buffer offset) */ + CurrentOffset = Context->Data->CurrentSize + sizeof(RXACT_ACTION); + Action->KeyName.Buffer = UlongToPtr(CurrentOffset); + RtlCopyMemory((PUCHAR)Context->Data + CurrentOffset, + KeyName->Buffer, + KeyName->Length); + + /* Copy the value name (and convert the pointer to a buffer offset) */ + CurrentOffset += ALIGN_UP_BY(KeyName->Length, sizeof(ULONG)); + Action->ValueName.Buffer = UlongToPtr(CurrentOffset); + RtlCopyMemory((PUCHAR)Context->Data + CurrentOffset, + ValueName->Buffer, + ValueName->Length); + + /* Update the offset */ + CurrentOffset += ALIGN_UP_BY(ValueName->Length, sizeof(ULONG)); + + /* Is this a set action? */ + if (ActionType == RXactSetValueKey) + { + /* Copy the key value data as well */ + Action->ValueData = UlongToPtr(CurrentOffset); + RtlCopyMemory((PUCHAR)Context->Data + CurrentOffset, + ValueData, + ValueDataSize); + CurrentOffset += ALIGN_UP_BY(ValueDataSize, sizeof(ULONG)); + } + + /* Update data site and action count */ + Context->Data->CurrentSize = CurrentOffset; + Context->Data->ActionCount++; + + return STATUS_SUCCESS; +} + +NTSTATUS +NTAPI +RtlAddActionToRXact( + PRXACT_CONTEXT Context, + ULONG ActionType, + PUNICODE_STRING KeyName, + ULONG ValueType, + PVOID ValueData, + ULONG ValueDataSize) +{ + UNICODE_STRING ValueName; + + /* Create a key and set the default key value or delete a key. */ + RtlInitUnicodeString(&ValueName, NULL); + return RtlAddAttributeActionToRXact(Context, + ActionType, + KeyName, + INVALID_HANDLE_VALUE, + &ValueName, + ValueType, + ValueData, + ValueDataSize); +} + +NTSTATUS +NTAPI +RtlApplyRXactNoFlush( + PRXACT_CONTEXT Context) +{ + NTSTATUS Status; + + /* Commit the transaction */ + Status = RXactpCommit(Context); + if (!NT_SUCCESS(Status)) + { + return Status; + } + + /* Reset the transaction */ + Status = RtlAbortRXact(Context); + ASSERT(NT_SUCCESS(Status)); + + return Status; +} + +NTSTATUS +NTAPI +RtlApplyRXact( + PRXACT_CONTEXT Context) +{ + UNICODE_STRING ValueName; + NTSTATUS Status; + + /* Temporarily safe the current transaction in the 'Log' key value */ + RtlInitUnicodeString(&ValueName, L"Log"); + Status = ZwSetValueKey(Context->KeyHandle, + &ValueName, + 0, + REG_BINARY, + Context->Data, + Context->Data->CurrentSize); + if (!NT_SUCCESS(Status)) + { + return Status; + } + + /* Flush the key */ + Status = NtFlushKey(Context->KeyHandle); + if (!NT_SUCCESS(Status)) + { + NtDeleteValueKey(Context->KeyHandle, &ValueName); + return Status; + } + + /* Now commit the transaction */ + Status = RXactpCommit(Context); + if (!NT_SUCCESS(Status)) + { + NtDeleteValueKey(Context->KeyHandle, &ValueName); + return Status; + } + + /* Delete the 'Log' key value */ + Status = NtDeleteValueKey(Context->KeyHandle, &ValueName); + ASSERT(NT_SUCCESS(Status)); + + /* Reset the transaction */ + Status = RtlAbortRXact(Context); + ASSERT(NT_SUCCESS(Status)); + + return STATUS_SUCCESS; +} + Propchange: trunk/reactos/lib/rtl/rxact.c ------------------------------------------------------------------------------ svn:eol-style = native

1 0

[tkreuzer] 61570: [NETAPI32/SAMSRV] - Update/fix exports to match win 2k3
by tkreuzer＠svn.reactos.org 07 Jan '14

07 Jan '14

Author: tkreuzer Date: Tue Jan 7 21:15:57 2014 New Revision: 61570 URL: http://svn.reactos.org/svn/reactos?rev=61570&view=rev Log: [NETAPI32/SAMSRV] - Update/fix exports to match win 2k3 Modified: trunk/reactos/dll/win32/netapi32/netapi32.spec trunk/reactos/dll/win32/samsrv/samsrv.spec Modified: trunk/reactos/dll/win32/netapi32/netapi32.spec URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/netapi32/netapi3… ============================================================================== --- trunk/reactos/dll/win32/netapi32/netapi32.spec [iso-8859-1] (original) +++ trunk/reactos/dll/win32/netapi32/netapi32.spec [iso-8859-1] Tue Jan 7 21:15:57 2014 @@ -1,20 +1,43 @@ -@ stub DsAddressToSiteNames -@ stub DsAddressToSiteNamesEx -@ stub DsDeregisterDnsHostRecords -@ stub DsEnumerateDomainTrusts -@ stub DsGetDcClose +@ stub CredpValidateTargetName +@ stub DsAddressToSiteNamesA +@ stub DsAddressToSiteNamesExA +@ stub DsAddressToSiteNamesExW +@ stub DsAddressToSiteNamesW +@ stub DsDeregisterDnsHostRecordsA +@ stub DsDeregisterDnsHostRecordsW +@ stub DsEnumerateDomainTrustsA +@ stub DsEnumerateDomainTrustsW +@ stub DsGetDcCloseW @ stdcall DsGetDcNameA(str str ptr str long ptr) @ stdcall DsGetDcNameW(wstr wstr ptr wstr long ptr) -@ stub DsGetDcNext -@ stub DsGetDcOpen -@ stub DsGetDcSiteCoverage +@ stub DsGetDcNameWithAccountA +@ stub DsGetDcNameWithAccountW +@ stub DsGetDcNextA +@ stub DsGetDcNextW +@ stub DsGetDcOpenA +@ stub DsGetDcOpenW +@ stub DsGetDcSiteCoverageA +@ stub DsGetDcSiteCoverageW @ stub DsGetForestTrustInformationW -@ stub DsGetSiteNameA # (str str) +@ stub DsGetSiteNameA @ stdcall DsGetSiteNameW(wstr wstr) @ stub DsMergeForestTrustInformationW +@ stub DsRoleAbortDownlevelServerUpgrade +@ stub DsRoleCancel +@ stub DsRoleDcAsDc +@ stub DsRoleDcAsReplica +@ stub DsRoleDemoteDc +@ stub DsRoleDnsNameToFlatName @ stdcall DsRoleFreeMemory(ptr) +@ stub DsRoleGetDatabaseFacts +@ stub DsRoleGetDcOperationProgress +@ stub DsRoleGetDcOperationResults @ stdcall DsRoleGetPrimaryDomainInformation(wstr long ptr) -@ stub DsValidateSubnetName +@ stub DsRoleIfmHandleFree +@ stub DsRoleServerSaveStateForUpgrade +@ stub DsRoleUpgradeDownlevelServer +@ stub DsValidateSubnetNameA +@ stub DsValidateSubnetNameW @ stub I_BrowserDebugCall @ stub I_BrowserDebugTrace @ stdcall I_BrowserQueryEmulatedDomains(wstr ptr ptr) @@ -35,18 +58,25 @@ @ stub I_NetDfsDeleteExitPoint @ stub I_NetDfsDeleteLocalPartition @ stub I_NetDfsFixLocalVolume +@ stub I_NetDfsGetFtServers @ stub I_NetDfsGetVersion @ stub I_NetDfsIsThisADomainName +@ stub I_NetDfsManagerReportSiteInfo @ stub I_NetDfsModifyPrefix @ stub I_NetDfsSetLocalVolumeState @ stub I_NetDfsSetServerInfo @ stub I_NetGetDCList +@ stub I_NetGetForestTrustInformation @ stub I_NetListCanonicalize @ stub I_NetListTraverse @ stub I_NetLogonControl2 @ stub I_NetLogonControl +@ stub I_NetLogonGetDomainInfo @ stub I_NetLogonSamLogoff @ stub I_NetLogonSamLogon +@ stub I_NetLogonSamLogonEx +@ stub I_NetLogonSamLogonWithFlags +@ stub I_NetLogonSendToSam @ stub I_NetLogonUasLogoff @ stub I_NetLogonUasLogon @ stub I_NetNameCanonicalize @@ -56,11 +86,20 @@ @ stub I_NetPathCompare @ stub I_NetPathType @ stub I_NetServerAuthenticate2 +@ stub I_NetServerAuthenticate3 @ stub I_NetServerAuthenticate +@ stub I_NetServerGetTrustInfo +@ stub I_NetServerPasswordGet +@ stub I_NetServerPasswordSet2 @ stub I_NetServerPasswordSet @ stub I_NetServerReqChallenge @ stub I_NetServerSetServiceBits @ stub I_NetServerSetServiceBitsEx +@ stub I_NetServerTrustPasswordsGet +@ stub I_NetlogonComputeClientDigest +@ stub I_NetlogonComputeServerDigest +@ stub I_NetlogonGetTrustRid +@ stub NetAddAlternateComputerName @ stub NetAlertRaise @ stub NetAlertRaiseEx @ stdcall NetApiBufferAllocate(long ptr) @@ -76,13 +115,31 @@ @ stub NetConfigSet @ stub NetConnectionEnum @ stub NetDfsAdd +@ stub NetDfsAddFtRoot +@ stub NetDfsAddStdRoot +@ stub NetDfsAddStdRootForced @ stub NetDfsEnum +@ stub NetDfsGetClientInfo +@ stub NetDfsGetDcAddress +@ stub NetDfsGetFtContainerSecurity @ stub NetDfsGetInfo +@ stub NetDfsGetSecurity +@ stub NetDfsGetStdContainerSecurity @ stub NetDfsManagerGetConfigInfo +@ stub NetDfsManagerInitialize +@ stub NetDfsManagerSendSiteInfo @ stub NetDfsMove @ stub NetDfsRemove +@ stub NetDfsRemoveFtRoot +@ stub NetDfsRemoveFtRootForced +@ stub NetDfsRemoveStdRoot @ stub NetDfsRename +@ stub NetDfsSetClientInfo +@ stub NetDfsSetFtContainerSecurity @ stub NetDfsSetInfo +@ stub NetDfsSetSecurity +@ stub NetDfsSetStdContainerSecurity +@ stub NetEnumerateComputerNames @ stub NetEnumerateTrustedDomains @ stub NetErrorLogClear @ stub NetErrorLogRead @@ -94,6 +151,7 @@ @ stdcall NetGetDCName(wstr wstr ptr) @ stub NetGetDisplayInformationIndex @ stdcall NetGetJoinInformation(wstr ptr ptr) +@ stub NetGetJoinableOUs @ stdcall NetGroupAdd(wstr long ptr ptr) @ stdcall NetGroupAddUser(wstr wstr wstr) @ stdcall NetGroupDel(wstr wstr) @@ -103,6 +161,7 @@ @ stdcall NetGroupGetUsers(wstr wstr long ptr long ptr ptr ptr) @ stdcall NetGroupSetInfo(wstr wstr long ptr ptr) @ stdcall NetGroupSetUsers(wstr wstr long ptr long) +@ stub NetJoinDomain @ stdcall NetLocalGroupAdd(wstr long ptr ptr) @ stdcall NetLocalGroupAddMember(wstr wstr ptr) @ stdcall NetLocalGroupAddMembers(wstr wstr long ptr long) @@ -114,14 +173,19 @@ @ stdcall NetLocalGroupGetMembers(wstr wstr long ptr long ptr ptr ptr) @ stdcall NetLocalGroupSetInfo(wstr wstr long ptr ptr) @ stdcall NetLocalGroupSetMembers(wstr wstr long ptr long) +@ stub NetLogonGetTimeServiceParentDomain +@ stub NetLogonSetServiceBits @ stub NetMessageBufferSend @ stub NetMessageNameAdd @ stub NetMessageNameDel @ stub NetMessageNameEnum @ stub NetMessageNameGetInfo @ stdcall NetQueryDisplayInformation(wstr long long long long ptr ptr) +@ stub NetRegisterDomainNameChangeNotification @ stub NetRemoteComputerSupports @ stub NetRemoteTOD +@ stub NetRemoveAlternateComputerName +@ stub NetRenameMachineInDomain @ stub NetReplExportDirAdd @ stub NetReplExportDirDel @ stub NetReplExportDirEnum @@ -137,35 +201,6 @@ @ stub NetReplImportDirLock @ stub NetReplImportDirUnlock @ stub NetReplSetInfo -@ stub NetRplAdapterAdd -@ stub NetRplAdapterDel -@ stub NetRplAdapterEnum -@ stub NetRplBootAdd -@ stub NetRplBootDel -@ stub NetRplBootEnum -@ stub NetRplClose -@ stub NetRplConfigAdd -@ stub NetRplConfigDel -@ stub NetRplConfigEnum -@ stub NetRplGetInfo -@ stub NetRplOpen -@ stub NetRplProfileAdd -@ stub NetRplProfileClone -@ stub NetRplProfileDel -@ stub NetRplProfileEnum -@ stub NetRplProfileGetInfo -@ stub NetRplProfileSetInfo -@ stub NetRplSetInfo -@ stub NetRplSetSecurity -@ stub NetRplVendorAdd -@ stub NetRplVendorDel -@ stub NetRplVendorEnum -@ stub NetRplWkstaAdd -@ stub NetRplWkstaClone -@ stub NetRplWkstaDel -@ stub NetRplWkstaEnum -@ stub NetRplWkstaGetInfo -@ stub NetRplWkstaSetInfo @ stub NetScheduleJobAdd @ stub NetScheduleJobDel @ stub NetScheduleJobEnum @@ -188,6 +223,7 @@ @ stub NetSessionDel @ stdcall NetSessionEnum(wstr wstr wstr long ptr long ptr ptr ptr) @ stub NetSessionGetInfo +@ stub NetSetPrimaryComputerName @ stdcall NetShareAdd(wstr long ptr ptr) @ stub NetShareCheck @ stdcall NetShareDel(wstr wstr long) @@ -197,6 +233,8 @@ @ stdcall NetShareGetInfo(wstr wstr long ptr) @ stub NetShareSetInfo @ stdcall NetStatisticsGet(wstr wstr long long ptr) +@ stub NetUnjoinDomain +@ stub NetUnregisterDomainNameChangeNotification @ stdcall NetUseAdd(wstr long ptr ptr) @ stub NetUseDel @ stdcall NetUseEnum(wstr long ptr long ptr ptr ptr) @@ -212,6 +250,9 @@ @ stdcall NetUserModalsSet(wstr long ptr ptr) @ stdcall NetUserSetGroups(wstr wstr long ptr long) @ stdcall NetUserSetInfo(wstr wstr long ptr ptr) +@ stub NetValidateName +@ stub NetValidatePasswordPolicy +@ stub NetValidatePasswordPolicyFree @ stdcall NetWkstaGetInfo(wstr long ptr) @ stub NetWkstaSetInfo @ stub NetWkstaTransportAdd @@ -224,18 +265,19 @@ @ stdcall Netbios(ptr) @ stub NetpAccessCheck @ stub NetpAccessCheckAndAudit +@ stub NetpAddTlnFtinfoEntry @ stub NetpAllocConfigName -@ stub NetpAllocStrFromStr +@ stub NetpAllocFtinfoEntry @ stub NetpAllocStrFromWStr -@ stub NetpAllocTStrFromString @ stub NetpAllocWStrFromStr @ stub NetpAllocWStrFromWStr @ stub NetpApiStatusToNtStatus @ stub NetpAssertFailed +@ stub NetpCleanFtinfoContext @ stub NetpCloseConfigData +@ stub NetpCopyFtinfoContext @ stub NetpCopyStringToBuffer @ stub NetpCreateSecurityObject -@ stub NetpDbgDisplayServerInfo @ stub NetpDbgPrint @ stdcall NetpDeleteSecurityObject(long) ntdll.RtlDeleteSecurityObject @ stdcall NetpGetComputerName(ptr) @@ -247,11 +289,13 @@ @ stub NetpGetFileSecurity @ stub NetpGetPrivilege @ stub NetpHexDump +@ stub NetpInitFtinfoContext @ stdcall NetpInitOemString(ptr str) ntdll.RtlInitAnsiString @ stub NetpIsRemote @ stub NetpIsUncComputerNameValid @ stub NetpLocalTimeZoneOffset @ stub NetpLogonPutUnicodeString +@ stub NetpMergeFtinfo @ stub NetpNetBiosAddName @ stub NetpNetBiosCall @ stub NetpNetBiosDelName @@ -264,14 +308,18 @@ @ stdcall NetpNtStatusToApiStatus(long) @ stub NetpOpenConfigData @ stub NetpPackString +@ stub NetpParmsQueryUserProperty +@ stub NetpParmsQueryUserPropertyWithLength +@ stub NetpParmsSetUserProperty +@ stub NetpParmsSetUserPropertyWithLength +@ stub NetpParmsUserPropertyFree @ stub NetpReleasePrivilege -@ stub NetpSetConfigBool -@ stub NetpSetConfigDword -@ stub NetpSetConfigTStrArray @ stub NetpSetFileSecurity @ stub NetpSmbCheck +@ stub NetpStoreIntialDcRecord @ stub NetpStringToNetBiosName @ stub NetpTStrArrayEntryCount +@ stub NetpUpgradePreNT5JoinInfo @ stub NetpwNameCanonicalize @ stub NetpwNameCompare @ stub NetpwNameValidate Modified: trunk/reactos/dll/win32/samsrv/samsrv.spec URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/samsrv/samsrv.sp… ============================================================================== --- trunk/reactos/dll/win32/samsrv/samsrv.spec [iso-8859-1] (original) +++ trunk/reactos/dll/win32/samsrv/samsrv.spec [iso-8859-1] Tue Jan 7 21:15:57 2014 @@ -38,7 +38,7 @@ @ stub SamIGetFixedAttributes @ stub SamIGetInterdomainTrustAccountPasswordsForUpgrade @ stub SamIGetPrivateData -@ stub SamIGetResourceGroupmembershipsTransitive +@ stub SamIGetResourceGroupMembershipsTransitive @ stub SamIGetSerialNumberDomain @ stub SamIGetUserLogonInformation @ stub SamIGetUserLogonInformation2

1 0

[tkreuzer] 61569: [NTOSKRNL] - Fix return value of ObOpenObjectByName (in success case the return status of ObpLookupObjectName is returned.
by tkreuzer＠svn.reactos.org 07 Jan '14

07 Jan '14

Author: tkreuzer Date: Tue Jan 7 20:50:34 2014 New Revision: 61569 URL: http://svn.reactos.org/svn/reactos?rev=61569&view=rev Log: [NTOSKRNL] - Fix return value of ObOpenObjectByName (in success case the return status of ObpLookupObjectName is returned. Modified: trunk/reactos/ntoskrnl/ob/obhandle.c Modified: trunk/reactos/ntoskrnl/ob/obhandle.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ob/obhandle.c?rev… ============================================================================== --- trunk/reactos/ntoskrnl/ob/obhandle.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/ob/obhandle.c [iso-8859-1] Tue Jan 7 20:50:34 2014 @@ -2431,7 +2431,7 @@ { PVOID Object = NULL; UNICODE_STRING ObjectName; - NTSTATUS Status; + NTSTATUS Status, Status2; POBJECT_HEADER ObjectHeader; PGENERIC_MAPPING GenericMapping = NULL; OB_OPEN_REASON OpenReason; @@ -2557,17 +2557,21 @@ else { /* Create the actual handle now */ - Status = ObpCreateHandle(OpenReason, - Object, - ObjectType, - PassedAccessState, - 0, - TempBuffer->ObjectCreateInfo.Attributes, - &TempBuffer->LookupContext, - AccessMode, - NULL, - Handle); - if (!NT_SUCCESS(Status)) ObDereferenceObject(Object); + Status2 = ObpCreateHandle(OpenReason, + Object, + ObjectType, + PassedAccessState, + 0, + TempBuffer->ObjectCreateInfo.Attributes, + &TempBuffer->LookupContext, + AccessMode, + NULL, + Handle); + if (!NT_SUCCESS(Status)) + { + ObDereferenceObject(Object); + Status = Status2; + } } Cleanup:

1 0

[tkreuzer] 61568: [RTL/NDK/NTDLL] - Fix calling convention of RtlSetProcessIsCritical and RtlSetThreadIsCritical (they are __cdecl!) [NDK] - Add missing extern "C"
by tkreuzer＠svn.reactos.org 07 Jan '14

07 Jan '14

Author: tkreuzer Date: Tue Jan 7 20:23:44 2014 New Revision: 61568 URL: http://svn.reactos.org/svn/reactos?rev=61568&view=rev Log: [RTL/NDK/NTDLL] - Fix calling convention of RtlSetProcessIsCritical and RtlSetThreadIsCritical (they are __cdecl!) [NDK] - Add missing extern "C" Modified: trunk/reactos/dll/ntdll/def/ntdll.spec trunk/reactos/include/ndk/mmtypes.h trunk/reactos/include/ndk/rtlfuncs.h trunk/reactos/lib/rtl/process.c trunk/reactos/lib/rtl/thread.c Modified: trunk/reactos/dll/ntdll/def/ntdll.spec URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/ntdll/def/ntdll.spec?r… ============================================================================== --- trunk/reactos/dll/ntdll/def/ntdll.spec [iso-8859-1] (original) +++ trunk/reactos/dll/ntdll/def/ntdll.spec [iso-8859-1] Tue Jan 7 20:23:44 2014 @@ -846,7 +846,7 @@ @ stdcall RtlSetLastWin32ErrorAndNtStatusFromNtStatus(long) @ stdcall RtlSetMemoryStreamSize(ptr int64) @ stdcall RtlSetOwnerSecurityDescriptor(ptr ptr long) -@ stdcall RtlSetProcessIsCritical(long ptr long) +@ cdecl RtlSetProcessIsCritical(long ptr long) ;@ stdcall RtlSetProperties ; RtlSetProperties ;@ stdcall RtlSetPropertyClassId ; 4.0 only ;@ stdcall RtlSetPropertyNames ; 4.0 only @@ -856,7 +856,7 @@ @ stdcall RtlSetSecurityObject(long ptr ptr ptr ptr) @ stdcall RtlSetSecurityObjectEx(long ptr ptr long ptr ptr) @ stdcall RtlSetThreadErrorMode(long ptr) -@ stdcall RtlSetThreadIsCritical(long ptr long) +@ cdecl RtlSetThreadIsCritical(long ptr long) @ stdcall RtlSetThreadPoolStartFunc(ptr ptr) @ stdcall RtlSetTimeZoneInformation(ptr) ;@ stdcall RtlSetTimer Modified: trunk/reactos/include/ndk/mmtypes.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/ndk/mmtypes.h?rev=… ============================================================================== --- trunk/reactos/include/ndk/mmtypes.h [iso-8859-1] (original) +++ trunk/reactos/include/ndk/mmtypes.h [iso-8859-1] Tue Jan 7 20:23:44 2014 @@ -25,6 +25,10 @@ #include <umtypes.h> #include <arch/mmtypes.h> #include <extypes.h> + +#ifdef __cplusplus +extern "C" { +#endif // // Page-Rounding Macros @@ -1037,4 +1041,8 @@ #endif // !NTOS_MODE_USER +#ifdef __cplusplus +} // extern "C" +#endif + #endif // _MMTYPES_H Modified: trunk/reactos/include/ndk/rtlfuncs.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/ndk/rtlfuncs.h?rev… ============================================================================== --- trunk/reactos/include/ndk/rtlfuncs.h [iso-8859-1] (original) +++ trunk/reactos/include/ndk/rtlfuncs.h [iso-8859-1] Tue Jan 7 20:23:44 2014 @@ -2564,7 +2564,7 @@ NTSYSAPI NTSTATUS -NTAPI +__cdecl RtlSetProcessIsCritical( _In_ BOOLEAN NewValue, _Out_opt_ PBOOLEAN OldValue, @@ -2573,7 +2573,7 @@ NTSYSAPI NTSTATUS -NTAPI +__cdecl RtlSetThreadIsCritical( _In_ BOOLEAN NewValue, _Out_opt_ PBOOLEAN OldValue, @@ -4244,7 +4244,7 @@ NTSYSAPI HRESULT NTAPI -RtlQueryInterfaceMemoryStream( +RtlQueryInterfaceMemoryStream( _In_ struct IStream *This, _In_ REFIID RequestedIid, _Outptr_ PVOID *ResultObject @@ -4253,21 +4253,21 @@ NTSYSAPI ULONG NTAPI -RtlAddRefMemoryStream( +RtlAddRefMemoryStream( _In_ struct IStream *This ); NTSYSAPI ULONG NTAPI -RtlReleaseMemoryStream( +RtlReleaseMemoryStream( _In_ struct IStream *This ); NTSYSAPI HRESULT NTAPI -RtlReadMemoryStream( +RtlReadMemoryStream( _In_ struct IStream *This, _Out_writes_bytes_(Length) PVOID Buffer, _In_ ULONG Length, @@ -4277,7 +4277,7 @@ NTSYSAPI HRESULT NTAPI -RtlReadOutOfProcessMemoryStream( +RtlReadOutOfProcessMemoryStream( _In_ struct IStream *This, _Out_writes_bytes_(Length) PVOID Buffer, _In_ ULONG Length, @@ -4287,7 +4287,7 @@ NTSYSAPI HRESULT NTAPI -RtlSeekMemoryStream( +RtlSeekMemoryStream( _In_ struct IStream *This, _In_ LARGE_INTEGER RelativeOffset, _In_ ULONG Origin, @@ -4297,7 +4297,7 @@ NTSYSAPI HRESULT NTAPI -RtlCopyMemoryStreamTo( +RtlCopyMemoryStreamTo( _In_ struct IStream *This, _In_ struct IStream *Target, _In_ ULARGE_INTEGER Length, @@ -4308,7 +4308,7 @@ NTSYSAPI HRESULT NTAPI -RtlCopyOutOfProcessMemoryStreamTo( +RtlCopyOutOfProcessMemoryStreamTo( _In_ struct IStream *This, _In_ struct IStream *Target, _In_ ULARGE_INTEGER Length, @@ -4319,7 +4319,7 @@ NTSYSAPI HRESULT NTAPI -RtlStatMemoryStream( +RtlStatMemoryStream( _In_ struct IStream *This, _Out_ struct tagSTATSTG *Stats, _In_ ULONG Flags @@ -4329,7 +4329,7 @@ NTSYSAPI HRESULT NTAPI -RtlWriteMemoryStream( +RtlWriteMemoryStream( _In_ struct IStream *This, _In_reads_bytes_(Length) CONST VOID *Buffer, _In_ ULONG Length, @@ -4339,7 +4339,7 @@ NTSYSAPI HRESULT NTAPI -RtlSetMemoryStreamSize( +RtlSetMemoryStreamSize( _In_ struct IStream *This, _In_ ULARGE_INTEGER NewSize ); @@ -4347,7 +4347,7 @@ NTSYSAPI HRESULT NTAPI -RtlCommitMemoryStream( +RtlCommitMemoryStream( _In_ struct IStream *This, _In_ ULONG CommitFlags ); @@ -4355,14 +4355,14 @@ NTSYSAPI HRESULT NTAPI -RtlRevertMemoryStream( +RtlRevertMemoryStream( _In_ struct IStream *This ); NTSYSAPI HRESULT NTAPI -RtlLockMemoryStreamRegion( +RtlLockMemoryStreamRegion( _In_ struct IStream *This, _In_ ULARGE_INTEGER Offset, _In_ ULARGE_INTEGER Length, @@ -4372,7 +4372,7 @@ NTSYSAPI HRESULT NTAPI -RtlUnlockMemoryStreamRegion( +RtlUnlockMemoryStreamRegion( _In_ struct IStream *This, _In_ ULARGE_INTEGER Offset, _In_ ULARGE_INTEGER Length, @@ -4382,7 +4382,7 @@ NTSYSAPI HRESULT NTAPI -RtlCloneMemoryStream( +RtlCloneMemoryStream( _In_ struct IStream *This, _Outptr_ struct IStream **ResultStream ); Modified: trunk/reactos/lib/rtl/process.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/rtl/process.c?rev=6156… ============================================================================== --- trunk/reactos/lib/rtl/process.c [iso-8859-1] (original) +++ trunk/reactos/lib/rtl/process.c [iso-8859-1] Tue Jan 7 20:23:44 2014 @@ -357,7 +357,7 @@ * http://www.geoffchappell.com/studies/windows/win32/ntdll/api/rtl/peb/setpro… */ NTSTATUS -NTAPI +__cdecl RtlSetProcessIsCritical(IN BOOLEAN NewValue, OUT PBOOLEAN OldValue OPTIONAL, IN BOOLEAN NeedBreaks) Modified: trunk/reactos/lib/rtl/thread.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/rtl/thread.c?rev=61568… ============================================================================== --- trunk/reactos/lib/rtl/thread.c [iso-8859-1] (original) +++ trunk/reactos/lib/rtl/thread.c [iso-8859-1] Tue Jan 7 20:23:44 2014 @@ -158,7 +158,7 @@ * @implemented */ NTSTATUS -NTAPI +__cdecl RtlSetThreadIsCritical(IN BOOLEAN NewValue, OUT PBOOLEAN OldValue OPTIONAL, IN BOOLEAN NeedBreaks)

1 0

[tkreuzer] 61567: [DDK/XDK] - Add missing _KEY_USER_FLAGS_INFORMATION - Fix some FSCTL_* constants, add Win7/8 ones - Sync DDK/XDK (just a reminder, you are supposed to fix XDK headers and simply r...
by tkreuzer＠svn.reactos.org 07 Jan '14

07 Jan '14

Author: tkreuzer Date: Tue Jan 7 20:17:01 2014 New Revision: 61567 URL: http://svn.reactos.org/svn/reactos?rev=61567&view=rev Log: [DDK/XDK] - Add missing _KEY_USER_FLAGS_INFORMATION - Fix some FSCTL_* constants, add Win7/8 ones - Sync DDK/XDK (just a reminder, you are supposed to fix XDK headers and simply regenerate the DDK headers from them) Modified: trunk/reactos/include/ddk/ntifs.h trunk/reactos/include/ddk/wdm.h trunk/reactos/include/xdk/cmtypes.h trunk/reactos/include/xdk/iotypes.h trunk/reactos/include/xdk/rtlfuncs.h Modified: trunk/reactos/include/ddk/ntifs.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/ddk/ntifs.h?rev=61… ============================================================================== --- trunk/reactos/include/ddk/ntifs.h [iso-8859-1] (original) +++ trunk/reactos/include/ddk/ntifs.h [iso-8859-1] Tue Jan 7 20:17:01 2014 @@ -3558,7 +3558,7 @@ #define FSCTL_GET_NTFS_FILE_RECORD CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 26, METHOD_BUFFERED, FILE_ANY_ACCESS) #define FSCTL_GET_VOLUME_BITMAP CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 27, METHOD_NEITHER, FILE_ANY_ACCESS) #define FSCTL_GET_RETRIEVAL_POINTERS CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 28, METHOD_NEITHER, FILE_ANY_ACCESS) -#define FSCTL_MOVE_FILE CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 29, METHOD_BUFFERED, FILE_ANY_ACCESS) +#define FSCTL_MOVE_FILE CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 29, METHOD_BUFFERED, FILE_SPECIAL_ACCESS) #define FSCTL_IS_VOLUME_DIRTY CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 30, METHOD_BUFFERED, FILE_ANY_ACCESS) #define FSCTL_ALLOW_EXTENDED_DASD_IO CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 32, METHOD_NEITHER, FILE_ANY_ACCESS) @@ -3573,22 +3573,22 @@ #define FSCTL_SET_REPARSE_POINT CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 41, METHOD_BUFFERED, FILE_SPECIAL_ACCESS) #define FSCTL_GET_REPARSE_POINT CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 42, METHOD_BUFFERED, FILE_ANY_ACCESS) #define FSCTL_DELETE_REPARSE_POINT CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 43, METHOD_BUFFERED, FILE_SPECIAL_ACCESS) -#define FSCTL_ENUM_USN_DATA CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 44, METHOD_NEITHER, FILE_READ_DATA) +#define FSCTL_ENUM_USN_DATA CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 44, METHOD_NEITHER, FILE_ANY_ACCESS) #define FSCTL_SECURITY_ID_CHECK CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 45, METHOD_NEITHER, FILE_READ_DATA) -#define FSCTL_READ_USN_JOURNAL CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 46, METHOD_NEITHER, FILE_READ_DATA) +#define FSCTL_READ_USN_JOURNAL CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 46, METHOD_NEITHER, FILE_ANY_ACCESS) #define FSCTL_SET_OBJECT_ID_EXTENDED CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 47, METHOD_BUFFERED, FILE_SPECIAL_ACCESS) #define FSCTL_CREATE_OR_GET_OBJECT_ID CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 48, METHOD_BUFFERED, FILE_ANY_ACCESS) #define FSCTL_SET_SPARSE CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 49, METHOD_BUFFERED, FILE_SPECIAL_ACCESS) #define FSCTL_SET_ZERO_DATA CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 50, METHOD_BUFFERED, FILE_WRITE_DATA) #define FSCTL_QUERY_ALLOCATED_RANGES CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 51, METHOD_NEITHER, FILE_READ_DATA) #define FSCTL_ENABLE_UPGRADE CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 52, METHOD_BUFFERED, FILE_WRITE_DATA) -#define FSCTL_SET_ENCRYPTION CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 53, METHOD_BUFFERED, FILE_ANY_ACCESS) +#define FSCTL_SET_ENCRYPTION CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 53, METHOD_NEITHER, FILE_ANY_ACCESS) #define FSCTL_ENCRYPTION_FSCTL_IO CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 54, METHOD_NEITHER, FILE_ANY_ACCESS) #define FSCTL_WRITE_RAW_ENCRYPTED CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 55, METHOD_NEITHER, FILE_SPECIAL_ACCESS) #define FSCTL_READ_RAW_ENCRYPTED CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 56, METHOD_NEITHER, FILE_SPECIAL_ACCESS) -#define FSCTL_CREATE_USN_JOURNAL CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 57, METHOD_NEITHER, FILE_READ_DATA) -#define FSCTL_READ_FILE_USN_DATA CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 58, METHOD_NEITHER, FILE_READ_DATA) -#define FSCTL_WRITE_USN_CLOSE_RECORD CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 59, METHOD_NEITHER, FILE_READ_DATA) +#define FSCTL_CREATE_USN_JOURNAL CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 57, METHOD_NEITHER, FILE_ANY_ACCESS) +#define FSCTL_READ_FILE_USN_DATA CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 58, METHOD_NEITHER, FILE_ANY_ACCESS) +#define FSCTL_WRITE_USN_CLOSE_RECORD CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 59, METHOD_NEITHER, FILE_ANY_ACCESS) #define FSCTL_EXTEND_VOLUME CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 60, METHOD_BUFFERED, FILE_ANY_ACCESS) #define FSCTL_QUERY_USN_JOURNAL CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 61, METHOD_BUFFERED, FILE_ANY_ACCESS) #define FSCTL_DELETE_USN_JOURNAL CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 62, METHOD_BUFFERED, FILE_ANY_ACCESS) @@ -3631,7 +3631,6 @@ #define FSCTL_SHRINK_VOLUME CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 108, METHOD_BUFFERED, FILE_SPECIAL_ACCESS) #define FSCTL_SET_SHORT_NAME_BEHAVIOR CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 109, METHOD_BUFFERED, FILE_ANY_ACCESS) #define FSCTL_DFSR_SET_GHOST_HANDLE_STATE CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 110, METHOD_BUFFERED, FILE_ANY_ACCESS) - #define FSCTL_TXFS_LIST_TRANSACTION_LOCKED_FILES \ CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 120, METHOD_BUFFERED, FILE_READ_DATA) #define FSCTL_TXFS_LIST_TRANSACTIONS CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 121, METHOD_BUFFERED, FILE_READ_DATA) @@ -3652,17 +3651,15 @@ #define FSCTL_GET_RETRIEVAL_POINTER_BASE CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 141, METHOD_BUFFERED, FILE_ANY_ACCESS) #define FSCTL_SET_PERSISTENT_VOLUME_STATE CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 142, METHOD_BUFFERED, FILE_ANY_ACCESS) #define FSCTL_QUERY_PERSISTENT_VOLUME_STATE CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 143, METHOD_BUFFERED, FILE_ANY_ACCESS) - #define FSCTL_REQUEST_OPLOCK CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 144, METHOD_BUFFERED, FILE_ANY_ACCESS) - #define FSCTL_CSV_TUNNEL_REQUEST CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 145, METHOD_BUFFERED, FILE_ANY_ACCESS) #define FSCTL_IS_CSV_FILE CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 146, METHOD_BUFFERED, FILE_ANY_ACCESS) - #define FSCTL_QUERY_FILE_SYSTEM_RECOGNITION CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 147, METHOD_BUFFERED, FILE_ANY_ACCESS) #define FSCTL_CSV_GET_VOLUME_PATH_NAME CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 148, METHOD_BUFFERED, FILE_ANY_ACCESS) #define FSCTL_CSV_GET_VOLUME_NAME_FOR_VOLUME_MOUNT_POINT CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 149, METHOD_BUFFERED, FILE_ANY_ACCESS) #define FSCTL_CSV_GET_VOLUME_PATH_NAMES_FOR_VOLUME_NAME CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 150, METHOD_BUFFERED, FILE_ANY_ACCESS) #define FSCTL_IS_FILE_ON_CSV_VOLUME CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 151, METHOD_BUFFERED, FILE_ANY_ACCESS) +#define FSCTL_CSV_INTERNAL CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 155, METHOD_BUFFERED, FILE_ANY_ACCESS) typedef struct _CSV_NAMESPACE_INFO { ULONG Version; @@ -3673,6 +3670,36 @@ #define CSV_NAMESPACE_INFO_V1 (sizeof(CSV_NAMESPACE_INFO)) #define CSV_INVALID_DEVICE_NUMBER 0xFFFFFFFF + +#endif + +#if (_WIN32_WINNT >= 0x0602) + +#define FSCTL_FILE_LEVEL_TRIM CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 130, METHOD_BUFFERED, FILE_WRITE_DATA) +#define FSCTL_CORRUPTION_HANDLING CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 152, METHOD_BUFFERED, FILE_ANY_ACCESS) +#define FSCTL_OFFLOAD_READ CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 153, METHOD_BUFFERED, FILE_READ_ACCESS) +#define FSCTL_OFFLOAD_WRITE CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 154, METHOD_BUFFERED, FILE_WRITE_ACCESS) +#define FSCTL_SET_PURGE_FAILURE_MODE CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 156, METHOD_BUFFERED, FILE_ANY_ACCESS) +#define FSCTL_QUERY_FILE_LAYOUT CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 157, METHOD_NEITHER, FILE_ANY_ACCESS) +#define FSCTL_IS_VOLUME_OWNED_BYCSVFS CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 158, METHOD_BUFFERED, FILE_ANY_ACCESS) +#define FSCTL_GET_INTEGRITY_INFORMATION CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 159, METHOD_BUFFERED, FILE_ANY_ACCESS) +#define FSCTL_SET_INTEGRITY_INFORMATION CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 160, METHOD_BUFFERED, FILE_READ_DATA | FILE_WRITE_DATA) +#define FSCTL_QUERY_FILE_REGIONS CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 161, METHOD_BUFFERED, FILE_ANY_ACCESS) +#define FSCTL_DEDUP_FILE CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 165, METHOD_BUFFERED, FILE_ANY_ACCESS) +#define FSCTL_DEDUP_QUERY_FILE_HASHES CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 166, METHOD_NEITHER, FILE_READ_DATA) +#define FSCTL_RKF_INTERNAL CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 171, METHOD_NEITHER, FILE_ANY_ACCESS) +#define FSCTL_SCRUB_DATA CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 172, METHOD_BUFFERED, FILE_ANY_ACCESS) +#define FSCTL_REPAIR_COPIES CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 173, METHOD_BUFFERED, FILE_READ_DATA | FILE_WRITE_DATA) +#define FSCTL_DISABLE_LOCAL_BUFFERING CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 174, METHOD_BUFFERED, FILE_ANY_ACCESS) +#define FSCTL_CSV_MGMT_LOCK CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 175, METHOD_BUFFERED, FILE_ANY_ACCESS) +#define FSCTL_CSV_QUERY_DOWN_LEVEL_FILE_SYSTEM_CHARACTERISTICS \ + CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 176, METHOD_BUFFERED, FILE_ANY_ACCESS) +#define FSCTL_ADVANCE_FILE_ID CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 177, METHOD_BUFFERED, FILE_ANY_ACCESS) +#define FSCTL_CSV_SYNC_TUNNEL_REQUEST CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 178, METHOD_BUFFERED, FILE_ANY_ACCESS) +#define FSCTL_CSV_QUERY_VETO_FILE_DIRECT_IO CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 179, METHOD_BUFFERED, FILE_ANY_ACCESS) +#define FSCTL_WRITE_USN_REASON CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 180, METHOD_BUFFERED, FILE_ANY_ACCESS) +#define FSCTL_CSV_CONTROL CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 181, METHOD_BUFFERED, FILE_ANY_ACCESS) +#define FSCTL_GET_REFS_VOLUME_DATA CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 182, METHOD_BUFFERED, FILE_ANY_ACCESS) #endif Modified: trunk/reactos/include/ddk/wdm.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/ddk/wdm.h?rev=6156… ============================================================================== --- trunk/reactos/include/ddk/wdm.h [iso-8859-1] (original) +++ trunk/reactos/include/ddk/wdm.h [iso-8859-1] Tue Jan 7 20:17:01 2014 @@ -3440,6 +3440,12 @@ typedef struct _KEY_WRITE_TIME_INFORMATION { LARGE_INTEGER LastWriteTime; } KEY_WRITE_TIME_INFORMATION, *PKEY_WRITE_TIME_INFORMATION; + +#if (NTDDI_VERSION < NTDDI_VISTA) +typedef struct _KEY_USER_FLAGS_INFORMATION { + ULONG UserFlags; +} KEY_USER_FLAGS_INFORMATION, *PKEY_USER_FLAGS_INFORMATION; +#endif typedef enum _REG_NOTIFY_CLASS { RegNtDeleteKey, @@ -8333,7 +8339,7 @@ #define HIGH_LEVEL 15 #define KI_USER_SHARED_DATA ((ULONG_PTR)(KADDRESS_BASE + 0xFFFE0000)) -extern DECLSPEC_CACHEALIGN volatile LARGE_INTEGER KeTickCount; +extern volatile LARGE_INTEGER KeTickCount; #define PAUSE_PROCESSOR __yield(); Modified: trunk/reactos/include/xdk/cmtypes.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/xdk/cmtypes.h?rev=… ============================================================================== --- trunk/reactos/include/xdk/cmtypes.h [iso-8859-1] (original) +++ trunk/reactos/include/xdk/cmtypes.h [iso-8859-1] Tue Jan 7 20:17:01 2014 @@ -617,6 +617,12 @@ typedef struct _KEY_WRITE_TIME_INFORMATION { LARGE_INTEGER LastWriteTime; } KEY_WRITE_TIME_INFORMATION, *PKEY_WRITE_TIME_INFORMATION; + +#if (NTDDI_VERSION < NTDDI_VISTA) +typedef struct _KEY_USER_FLAGS_INFORMATION { + ULONG UserFlags; +} KEY_USER_FLAGS_INFORMATION, *PKEY_USER_FLAGS_INFORMATION; +#endif typedef enum _REG_NOTIFY_CLASS { RegNtDeleteKey, Modified: trunk/reactos/include/xdk/iotypes.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/xdk/iotypes.h?rev=… ============================================================================== --- trunk/reactos/include/xdk/iotypes.h [iso-8859-1] (original) +++ trunk/reactos/include/xdk/iotypes.h [iso-8859-1] Tue Jan 7 20:17:01 2014 @@ -5658,7 +5658,7 @@ #define FSCTL_GET_NTFS_FILE_RECORD CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 26, METHOD_BUFFERED, FILE_ANY_ACCESS) #define FSCTL_GET_VOLUME_BITMAP CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 27, METHOD_NEITHER, FILE_ANY_ACCESS) #define FSCTL_GET_RETRIEVAL_POINTERS CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 28, METHOD_NEITHER, FILE_ANY_ACCESS) -#define FSCTL_MOVE_FILE CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 29, METHOD_BUFFERED, FILE_ANY_ACCESS) +#define FSCTL_MOVE_FILE CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 29, METHOD_BUFFERED, FILE_SPECIAL_ACCESS) #define FSCTL_IS_VOLUME_DIRTY CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 30, METHOD_BUFFERED, FILE_ANY_ACCESS) #define FSCTL_ALLOW_EXTENDED_DASD_IO CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 32, METHOD_NEITHER, FILE_ANY_ACCESS) @@ -5667,28 +5667,28 @@ #if (_WIN32_WINNT >= 0x0500) #define FSCTL_FIND_FILES_BY_SID CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 35, METHOD_NEITHER, FILE_ANY_ACCESS) -#define FSCTL_SET_OBJECT_ID CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 38, METHOD_BUFFERED, FILE_WRITE_DATA) +#define FSCTL_SET_OBJECT_ID CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 38, METHOD_BUFFERED, FILE_SPECIAL_ACCESS) #define FSCTL_GET_OBJECT_ID CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 39, METHOD_BUFFERED, FILE_ANY_ACCESS) -#define FSCTL_DELETE_OBJECT_ID CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 40, METHOD_BUFFERED, FILE_WRITE_DATA) -#define FSCTL_SET_REPARSE_POINT CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 41, METHOD_BUFFERED, FILE_WRITE_DATA) +#define FSCTL_DELETE_OBJECT_ID CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 40, METHOD_BUFFERED, FILE_SPECIAL_ACCESS) +#define FSCTL_SET_REPARSE_POINT CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 41, METHOD_BUFFERED, FILE_SPECIAL_ACCESS) #define FSCTL_GET_REPARSE_POINT CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 42, METHOD_BUFFERED, FILE_ANY_ACCESS) -#define FSCTL_DELETE_REPARSE_POINT CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 43, METHOD_BUFFERED, FILE_WRITE_DATA) -#define FSCTL_ENUM_USN_DATA CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 44, METHOD_NEITHER, FILE_READ_DATA) +#define FSCTL_DELETE_REPARSE_POINT CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 43, METHOD_BUFFERED, FILE_SPECIAL_ACCESS) +#define FSCTL_ENUM_USN_DATA CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 44, METHOD_NEITHER, FILE_ANY_ACCESS) #define FSCTL_SECURITY_ID_CHECK CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 45, METHOD_NEITHER, FILE_READ_DATA) -#define FSCTL_READ_USN_JOURNAL CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 46, METHOD_NEITHER, FILE_READ_DATA) -#define FSCTL_SET_OBJECT_ID_EXTENDED CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 47, METHOD_BUFFERED, FILE_WRITE_DATA) +#define FSCTL_READ_USN_JOURNAL CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 46, METHOD_NEITHER, FILE_ANY_ACCESS) +#define FSCTL_SET_OBJECT_ID_EXTENDED CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 47, METHOD_BUFFERED, FILE_SPECIAL_ACCESS) #define FSCTL_CREATE_OR_GET_OBJECT_ID CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 48, METHOD_BUFFERED, FILE_ANY_ACCESS) -#define FSCTL_SET_SPARSE CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 49, METHOD_BUFFERED, FILE_WRITE_DATA) +#define FSCTL_SET_SPARSE CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 49, METHOD_BUFFERED, FILE_SPECIAL_ACCESS) #define FSCTL_SET_ZERO_DATA CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 50, METHOD_BUFFERED, FILE_WRITE_DATA) #define FSCTL_QUERY_ALLOCATED_RANGES CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 51, METHOD_NEITHER, FILE_READ_DATA) #define FSCTL_ENABLE_UPGRADE CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 52, METHOD_BUFFERED, FILE_WRITE_DATA) -#define FSCTL_SET_ENCRYPTION CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 53, METHOD_BUFFERED, FILE_ANY_ACCESS) +#define FSCTL_SET_ENCRYPTION CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 53, METHOD_NEITHER, FILE_ANY_ACCESS) #define FSCTL_ENCRYPTION_FSCTL_IO CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 54, METHOD_NEITHER, FILE_ANY_ACCESS) -#define FSCTL_WRITE_RAW_ENCRYPTED CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 55, METHOD_NEITHER, FILE_ANY_ACCESS) -#define FSCTL_READ_RAW_ENCRYPTED CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 56, METHOD_NEITHER, FILE_ANY_ACCESS) -#define FSCTL_CREATE_USN_JOURNAL CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 57, METHOD_NEITHER, FILE_READ_DATA) -#define FSCTL_READ_FILE_USN_DATA CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 58, METHOD_NEITHER, FILE_READ_DATA) -#define FSCTL_WRITE_USN_CLOSE_RECORD CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 59, METHOD_NEITHER, FILE_READ_DATA) +#define FSCTL_WRITE_RAW_ENCRYPTED CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 55, METHOD_NEITHER, FILE_SPECIAL_ACCESS) +#define FSCTL_READ_RAW_ENCRYPTED CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 56, METHOD_NEITHER, FILE_SPECIAL_ACCESS) +#define FSCTL_CREATE_USN_JOURNAL CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 57, METHOD_NEITHER, FILE_ANY_ACCESS) +#define FSCTL_READ_FILE_USN_DATA CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 58, METHOD_NEITHER, FILE_ANY_ACCESS) +#define FSCTL_WRITE_USN_CLOSE_RECORD CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 59, METHOD_NEITHER, FILE_ANY_ACCESS) #define FSCTL_EXTEND_VOLUME CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 60, METHOD_BUFFERED, FILE_ANY_ACCESS) #define FSCTL_QUERY_USN_JOURNAL CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 61, METHOD_BUFFERED, FILE_ANY_ACCESS) #define FSCTL_DELETE_USN_JOURNAL CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 62, METHOD_BUFFERED, FILE_ANY_ACCESS) @@ -5731,7 +5731,6 @@ #define FSCTL_SHRINK_VOLUME CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 108, METHOD_BUFFERED, FILE_SPECIAL_ACCESS) #define FSCTL_SET_SHORT_NAME_BEHAVIOR CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 109, METHOD_BUFFERED, FILE_ANY_ACCESS) #define FSCTL_DFSR_SET_GHOST_HANDLE_STATE CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 110, METHOD_BUFFERED, FILE_ANY_ACCESS) - #define FSCTL_TXFS_LIST_TRANSACTION_LOCKED_FILES \ CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 120, METHOD_BUFFERED, FILE_READ_DATA) #define FSCTL_TXFS_LIST_TRANSACTIONS CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 121, METHOD_BUFFERED, FILE_READ_DATA) @@ -5752,17 +5751,15 @@ #define FSCTL_GET_RETRIEVAL_POINTER_BASE CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 141, METHOD_BUFFERED, FILE_ANY_ACCESS) #define FSCTL_SET_PERSISTENT_VOLUME_STATE CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 142, METHOD_BUFFERED, FILE_ANY_ACCESS) #define FSCTL_QUERY_PERSISTENT_VOLUME_STATE CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 143, METHOD_BUFFERED, FILE_ANY_ACCESS) - #define FSCTL_REQUEST_OPLOCK CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 144, METHOD_BUFFERED, FILE_ANY_ACCESS) - #define FSCTL_CSV_TUNNEL_REQUEST CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 145, METHOD_BUFFERED, FILE_ANY_ACCESS) #define FSCTL_IS_CSV_FILE CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 146, METHOD_BUFFERED, FILE_ANY_ACCESS) - #define FSCTL_QUERY_FILE_SYSTEM_RECOGNITION CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 147, METHOD_BUFFERED, FILE_ANY_ACCESS) #define FSCTL_CSV_GET_VOLUME_PATH_NAME CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 148, METHOD_BUFFERED, FILE_ANY_ACCESS) #define FSCTL_CSV_GET_VOLUME_NAME_FOR_VOLUME_MOUNT_POINT CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 149, METHOD_BUFFERED, FILE_ANY_ACCESS) #define FSCTL_CSV_GET_VOLUME_PATH_NAMES_FOR_VOLUME_NAME CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 150, METHOD_BUFFERED, FILE_ANY_ACCESS) #define FSCTL_IS_FILE_ON_CSV_VOLUME CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 151, METHOD_BUFFERED, FILE_ANY_ACCESS) +#define FSCTL_CSV_INTERNAL CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 155, METHOD_BUFFERED, FILE_ANY_ACCESS) typedef struct _CSV_NAMESPACE_INFO { ULONG Version; @@ -5773,6 +5770,36 @@ #define CSV_NAMESPACE_INFO_V1 (sizeof(CSV_NAMESPACE_INFO)) #define CSV_INVALID_DEVICE_NUMBER 0xFFFFFFFF + +#endif + +#if (_WIN32_WINNT >= 0x0602) + +#define FSCTL_FILE_LEVEL_TRIM CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 130, METHOD_BUFFERED, FILE_WRITE_DATA) +#define FSCTL_CORRUPTION_HANDLING CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 152, METHOD_BUFFERED, FILE_ANY_ACCESS) +#define FSCTL_OFFLOAD_READ CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 153, METHOD_BUFFERED, FILE_READ_ACCESS) +#define FSCTL_OFFLOAD_WRITE CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 154, METHOD_BUFFERED, FILE_WRITE_ACCESS) +#define FSCTL_SET_PURGE_FAILURE_MODE CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 156, METHOD_BUFFERED, FILE_ANY_ACCESS) +#define FSCTL_QUERY_FILE_LAYOUT CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 157, METHOD_NEITHER, FILE_ANY_ACCESS) +#define FSCTL_IS_VOLUME_OWNED_BYCSVFS CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 158, METHOD_BUFFERED, FILE_ANY_ACCESS) +#define FSCTL_GET_INTEGRITY_INFORMATION CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 159, METHOD_BUFFERED, FILE_ANY_ACCESS) +#define FSCTL_SET_INTEGRITY_INFORMATION CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 160, METHOD_BUFFERED, FILE_READ_DATA | FILE_WRITE_DATA) +#define FSCTL_QUERY_FILE_REGIONS CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 161, METHOD_BUFFERED, FILE_ANY_ACCESS) +#define FSCTL_DEDUP_FILE CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 165, METHOD_BUFFERED, FILE_ANY_ACCESS) +#define FSCTL_DEDUP_QUERY_FILE_HASHES CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 166, METHOD_NEITHER, FILE_READ_DATA) +#define FSCTL_RKF_INTERNAL CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 171, METHOD_NEITHER, FILE_ANY_ACCESS) +#define FSCTL_SCRUB_DATA CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 172, METHOD_BUFFERED, FILE_ANY_ACCESS) +#define FSCTL_REPAIR_COPIES CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 173, METHOD_BUFFERED, FILE_READ_DATA | FILE_WRITE_DATA) +#define FSCTL_DISABLE_LOCAL_BUFFERING CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 174, METHOD_BUFFERED, FILE_ANY_ACCESS) +#define FSCTL_CSV_MGMT_LOCK CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 175, METHOD_BUFFERED, FILE_ANY_ACCESS) +#define FSCTL_CSV_QUERY_DOWN_LEVEL_FILE_SYSTEM_CHARACTERISTICS \ + CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 176, METHOD_BUFFERED, FILE_ANY_ACCESS) +#define FSCTL_ADVANCE_FILE_ID CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 177, METHOD_BUFFERED, FILE_ANY_ACCESS) +#define FSCTL_CSV_SYNC_TUNNEL_REQUEST CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 178, METHOD_BUFFERED, FILE_ANY_ACCESS) +#define FSCTL_CSV_QUERY_VETO_FILE_DIRECT_IO CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 179, METHOD_BUFFERED, FILE_ANY_ACCESS) +#define FSCTL_WRITE_USN_REASON CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 180, METHOD_BUFFERED, FILE_ANY_ACCESS) +#define FSCTL_CSV_CONTROL CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 181, METHOD_BUFFERED, FILE_ANY_ACCESS) +#define FSCTL_GET_REFS_VOLUME_DATA CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 182, METHOD_BUFFERED, FILE_ANY_ACCESS) #endif Modified: trunk/reactos/include/xdk/rtlfuncs.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/xdk/rtlfuncs.h?rev… ============================================================================== --- trunk/reactos/include/xdk/rtlfuncs.h [iso-8859-1] (original) +++ trunk/reactos/include/xdk/rtlfuncs.h [iso-8859-1] Tue Jan 7 20:17:01 2014 @@ -1104,7 +1104,7 @@ NTAPI RtlUpperString( _Inout_ PSTRING DestinationString, - _In_ const PSTRING SourceString); + _In_ const STRING *SourceString); _IRQL_requires_max_(PASSIVE_LEVEL) _When_(AllocateDestinationString, _Must_inspect_result_) @@ -1140,8 +1140,8 @@ LONG NTAPI RtlCompareString( - _In_ const PSTRING String1, - _In_ const PSTRING String2, + _In_ const STRING *String1, + _In_ const STRING *String2, _In_ BOOLEAN CaseInSensitive); NTSYSAPI @@ -1149,7 +1149,7 @@ NTAPI RtlCopyString( _Out_ PSTRING DestinationString, - _In_opt_ const PSTRING SourceString); + _In_opt_ const STRING *SourceString); _IRQL_requires_max_(PASSIVE_LEVEL) _Must_inspect_result_ @@ -1157,8 +1157,8 @@ BOOLEAN NTAPI RtlEqualString( - _In_ const PSTRING String1, - _In_ const PSTRING String2, + _In_ const STRING *String1, + _In_ const STRING *String2, _In_ BOOLEAN CaseInSensitive); _IRQL_requires_max_(PASSIVE_LEVEL) @@ -1232,6 +1232,16 @@ _Out_ _At_(DestinationString->Buffer, __drv_allocatesMem(Mem)) PUNICODE_STRING DestinationString, _In_z_ PCWSTR SourceString); + +_IRQL_requires_max_(PASSIVE_LEVEL) +_Must_inspect_result_ +NTSYSAPI +BOOLEAN +NTAPI +RtlPrefixString( + _In_ const STRING *String1, + _In_ const STRING *String2, + _In_ BOOLEAN CaseInsensitive); _IRQL_requires_max_(APC_LEVEL) NTSYSAPI

1 0

[akhaldi] 61566: [3DTEXT] * Remove one time inclusions from the main header and put them back where they belong. * Cleanup the main header. CORE-7716
by akhaldi＠svn.reactos.org 07 Jan '14

07 Jan '14

Author: akhaldi Date: Tue Jan 7 17:11:52 2014 New Revision: 61566 URL: http://svn.reactos.org/svn/reactos?rev=61566&view=rev Log: [3DTEXT] * Remove one time inclusions from the main header and put them back where they belong. * Cleanup the main header. CORE-7716 Modified: trunk/reactos/base/applications/screensavers/3dtext/3dtext.c trunk/reactos/base/applications/screensavers/3dtext/3dtext.h trunk/reactos/base/applications/screensavers/3dtext/settings.c Modified: trunk/reactos/base/applications/screensavers/3dtext/3dtext.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/screensa… ============================================================================== --- trunk/reactos/base/applications/screensavers/3dtext/3dtext.c [iso-8859-1] (original) +++ trunk/reactos/base/applications/screensavers/3dtext/3dtext.c [iso-8859-1] Tue Jan 7 17:11:52 2014 @@ -19,6 +19,15 @@ */ #include "3dtext.h" + +#include <winbase.h> +#include <wingdi.h> +#include <winuser.h> +#include <scrnsave.h> +#include <math.h> +#include <GL/glu.h> + +#include "resource.h" static HGLRC hRC; // Permanent Rendering Context static HDC hDC; // Private GDI Device Context Modified: trunk/reactos/base/applications/screensavers/3dtext/3dtext.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/screensa… ============================================================================== --- trunk/reactos/base/applications/screensavers/3dtext/3dtext.h [iso-8859-1] (original) +++ trunk/reactos/base/applications/screensavers/3dtext/3dtext.h [iso-8859-1] Tue Jan 7 17:11:52 2014 @@ -18,18 +18,8 @@ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA */ -#include <stdarg.h> +#include <tchar.h> #include <windef.h> -#include <winbase.h> -#include <winreg.h> -#include <wingdi.h> -#include <winuser.h> -#include <scrnsave.h> -#include <math.h> -#include <GL/glu.h> -#include <tchar.h> - -#include "resource.h" extern TCHAR m_Text[MAX_PATH]; Modified: trunk/reactos/base/applications/screensavers/3dtext/settings.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/screensa… ============================================================================== --- trunk/reactos/base/applications/screensavers/3dtext/settings.c [iso-8859-1] (original) +++ trunk/reactos/base/applications/screensavers/3dtext/settings.c [iso-8859-1] Tue Jan 7 17:11:52 2014 @@ -18,9 +18,9 @@ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA */ -////////////////////////////////////////////////////////////////// +#include "3dtext.h" -#include "3dtext.h" +#include <winreg.h> TCHAR m_Text[MAX_PATH] = _T("ReactOS Rocks!");

1 0

[akhaldi] 61565: [SC] * Move conio.h inclusion where it's used. CORE-7716
by akhaldi＠svn.reactos.org 07 Jan '14

07 Jan '14

Author: akhaldi Date: Tue Jan 7 17:10:31 2014 New Revision: 61565 URL: http://svn.reactos.org/svn/reactos?rev=61565&view=rev Log: [SC] * Move conio.h inclusion where it's used. CORE-7716 Modified: trunk/reactos/base/applications/sc/sc.h trunk/reactos/base/applications/sc/usage.c Modified: trunk/reactos/base/applications/sc/sc.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/sc/sc.h?… ============================================================================== --- trunk/reactos/base/applications/sc/sc.h [iso-8859-1] (original) +++ trunk/reactos/base/applications/sc/sc.h [iso-8859-1] Tue Jan 7 17:10:31 2014 @@ -1,8 +1,8 @@ #include <stdarg.h> + #include <windef.h> #include <winbase.h> #include <winsvc.h> -#include <conio.h> #include <tchar.h> #define SCDBG Modified: trunk/reactos/base/applications/sc/usage.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/sc/usage… ============================================================================== --- trunk/reactos/base/applications/sc/usage.c [iso-8859-1] (original) +++ trunk/reactos/base/applications/sc/usage.c [iso-8859-1] Tue Jan 7 17:10:31 2014 @@ -6,7 +6,10 @@ * COPYRIGHT: Copyright 2005 - 2006 Ged Murphy <gedmurphy(a)gmail.com> * */ + #include "sc.h" + +#include <conio.h> VOID MainUsage(VOID) {

1 0

[akhaldi] 61564: [REGEDIT] * Remove one time inclusions from the main header and put them back where they belong. * Cleanup the main header. CORE-7716
by akhaldi＠svn.reactos.org 07 Jan '14

07 Jan '14

Author: akhaldi Date: Tue Jan 7 17:08:52 2014 New Revision: 61564 URL: http://svn.reactos.org/svn/reactos?rev=61564&view=rev Log: [REGEDIT] * Remove one time inclusions from the main header and put them back where they belong. * Cleanup the main header. CORE-7716 Modified: trunk/reactos/base/applications/regedit/about.c trunk/reactos/base/applications/regedit/edit.c trunk/reactos/base/applications/regedit/framewnd.c trunk/reactos/base/applications/regedit/hexedit.c trunk/reactos/base/applications/regedit/listview.c trunk/reactos/base/applications/regedit/main.c trunk/reactos/base/applications/regedit/regedit.c trunk/reactos/base/applications/regedit/regedit.h trunk/reactos/base/applications/regedit/regproc.c trunk/reactos/base/applications/regedit/regproc.h Modified: trunk/reactos/base/applications/regedit/about.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/regedit/… ============================================================================== --- trunk/reactos/base/applications/regedit/about.c [iso-8859-1] (original) +++ trunk/reactos/base/applications/regedit/about.c [iso-8859-1] Tue Jan 7 17:08:52 2014 @@ -20,6 +20,8 @@ #include "regedit.h" +#include <shellapi.h> + void ShowAboutBox(HWND hWnd) { WCHAR AppStr[255]; Modified: trunk/reactos/base/applications/regedit/edit.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/regedit/… ============================================================================== --- trunk/reactos/base/applications/regedit/edit.c [iso-8859-1] (original) +++ trunk/reactos/base/applications/regedit/edit.c [iso-8859-1] Tue Jan 7 17:08:52 2014 @@ -19,6 +19,9 @@ */ #include "regedit.h" + +#define NTOS_MODE_USER +#include <ndk/cmtypes.h> typedef enum _EDIT_MODE { Modified: trunk/reactos/base/applications/regedit/framewnd.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/regedit/… ============================================================================== --- trunk/reactos/base/applications/regedit/framewnd.c [iso-8859-1] (original) +++ trunk/reactos/base/applications/regedit/framewnd.c [iso-8859-1] Tue Jan 7 17:08:52 2014 @@ -19,6 +19,10 @@ */ #include "regedit.h" + +#include <commdlg.h> +#include <cderr.h> +#include <objsel.h> /******************************************************************************** * Global and Local Variables: Modified: trunk/reactos/base/applications/regedit/hexedit.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/regedit/… ============================================================================== --- trunk/reactos/base/applications/regedit/hexedit.c [iso-8859-1] (original) +++ trunk/reactos/base/applications/regedit/hexedit.c [iso-8859-1] Tue Jan 7 17:08:52 2014 @@ -19,6 +19,7 @@ */ #include "regedit.h" + typedef struct { HWND hWndSelf; Modified: trunk/reactos/base/applications/regedit/listview.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/regedit/… ============================================================================== --- trunk/reactos/base/applications/regedit/listview.c [iso-8859-1] (original) +++ trunk/reactos/base/applications/regedit/listview.c [iso-8859-1] Tue Jan 7 17:08:52 2014 @@ -20,7 +20,6 @@ #include "regedit.h" - #define CX_ICON 16 #define CY_ICON 16 #define NUM_ICONS 2 Modified: trunk/reactos/base/applications/regedit/main.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/regedit/… ============================================================================== --- trunk/reactos/base/applications/regedit/main.c [iso-8859-1] (original) +++ trunk/reactos/base/applications/regedit/main.c [iso-8859-1] Tue Jan 7 17:08:52 2014 @@ -21,7 +21,6 @@ #include "regedit.h" BOOL ProcessCmdLine(LPWSTR lpCmdLine); - /******************************************************************************* * Global Variables: Modified: trunk/reactos/base/applications/regedit/regedit.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/regedit/… ============================================================================== --- trunk/reactos/base/applications/regedit/regedit.c [iso-8859-1] (original) +++ trunk/reactos/base/applications/regedit/regedit.c [iso-8859-1] Tue Jan 7 17:08:52 2014 @@ -19,7 +19,6 @@ */ #include "regedit.h" - static const LPCWSTR usage = L"Usage:\n" Modified: trunk/reactos/base/applications/regedit/regedit.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/regedit/… ============================================================================== --- trunk/reactos/base/applications/regedit/regedit.h [iso-8859-1] (original) +++ trunk/reactos/base/applications/regedit/regedit.h [iso-8859-1] Tue Jan 7 17:08:52 2014 @@ -4,25 +4,14 @@ #define WIN32_LEAN_AND_MEAN /* Exclude rarely-used stuff from Windows headers */ #define WIN32_NO_STATUS #include <windows.h> - -#define NTOS_MODE_USER -#include <ndk/cmtypes.h> - #include <commctrl.h> -#include <shellapi.h> #include <shlwapi.h> #include <stdio.h> #include <aclapi.h> -#include <commdlg.h> -#include <cderr.h> -#include <objsel.h> -#include <assert.h> #include "main.h" #include "regproc.h" #include "hexedit.h" #include "security.h" -#endif - -/* EOF */ +#endif /* _REGEDIT_H */ Modified: trunk/reactos/base/applications/regedit/regproc.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/regedit/… ============================================================================== --- trunk/reactos/base/applications/regedit/regproc.c [iso-8859-1] (original) +++ trunk/reactos/base/applications/regedit/regproc.c [iso-8859-1] Tue Jan 7 17:08:52 2014 @@ -23,6 +23,8 @@ #include "regedit.h" +#include <assert.h> + #define REG_VAL_BUF_SIZE 4096 /* maximal number of characters in hexadecimal data line, Modified: trunk/reactos/base/applications/regedit/regproc.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/regedit/… ============================================================================== --- trunk/reactos/base/applications/regedit/regproc.h [iso-8859-1] (original) +++ trunk/reactos/base/applications/regedit/regproc.h [iso-8859-1] Tue Jan 7 17:08:52 2014 @@ -17,6 +17,8 @@ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA */ +#pragma once + #define KEY_MAX_LEN 1024 #define REG_FORMAT_5 1

1 0

[akhaldi] 61563: [RAPPS] * Move some definitions to the main header. * Remove one time inclusions from the main header and put them back where they belong. CORE-7716
by akhaldi＠svn.reactos.org 07 Jan '14

07 Jan '14

Author: akhaldi Date: Tue Jan 7 17:07:36 2014 New Revision: 61563 URL: http://svn.reactos.org/svn/reactos?rev=61563&view=rev Log: [RAPPS] * Move some definitions to the main header. * Remove one time inclusions from the main header and put them back where they belong. CORE-7716 Modified: trunk/reactos/base/applications/rapps/installdlg.c trunk/reactos/base/applications/rapps/listview.c trunk/reactos/base/applications/rapps/loaddlg.c trunk/reactos/base/applications/rapps/misc.c trunk/reactos/base/applications/rapps/rapps.h trunk/reactos/base/applications/rapps/richedit.c trunk/reactos/base/applications/rapps/settingsdlg.c trunk/reactos/base/applications/rapps/treeview.c trunk/reactos/base/applications/rapps/winmain.c Modified: trunk/reactos/base/applications/rapps/installdlg.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/rapps/in… ============================================================================== --- trunk/reactos/base/applications/rapps/installdlg.c [iso-8859-1] (original) +++ trunk/reactos/base/applications/rapps/installdlg.c [iso-8859-1] Tue Jan 7 17:07:36 2014 @@ -9,7 +9,6 @@ #include "rapps.h" static PAPPLICATION_INFO AppInfo; - static INT_PTR CALLBACK Modified: trunk/reactos/base/applications/rapps/listview.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/rapps/li… ============================================================================== --- trunk/reactos/base/applications/rapps/listview.c [iso-8859-1] (original) +++ trunk/reactos/base/applications/rapps/listview.c [iso-8859-1] Tue Jan 7 17:07:36 2014 @@ -10,7 +10,6 @@ HWND hListView; BOOL bAscending = TRUE; - PVOID ListViewGetlParam(INT Index) Modified: trunk/reactos/base/applications/rapps/loaddlg.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/rapps/lo… ============================================================================== --- trunk/reactos/base/applications/rapps/loaddlg.c [iso-8859-1] (original) +++ trunk/reactos/base/applications/rapps/loaddlg.c [iso-8859-1] Tue Jan 7 17:07:36 2014 @@ -25,9 +25,6 @@ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA */ -#define COBJMACROS -#define WIN32_NO_STATUS - #include "rapps.h" static PAPPLICATION_INFO AppInfo; Modified: trunk/reactos/base/applications/rapps/misc.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/rapps/mi… ============================================================================== --- trunk/reactos/base/applications/rapps/misc.c [iso-8859-1] (original) +++ trunk/reactos/base/applications/rapps/misc.c [iso-8859-1] Tue Jan 7 17:07:36 2014 @@ -7,7 +7,6 @@ */ #include "rapps.h" - /* SESSION Operation */ #define EXTRACT_FILLFILELIST 0x00000001 Modified: trunk/reactos/base/applications/rapps/rapps.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/rapps/ra… ============================================================================== --- trunk/reactos/base/applications/rapps/rapps.h [iso-8859-1] (original) +++ trunk/reactos/base/applications/rapps/rapps.h [iso-8859-1] Tue Jan 7 17:07:36 2014 @@ -1,7 +1,10 @@ +#include <stdarg.h> + #define WIN32_NO_STATUS #define _INC_WINDOWS #define COM_NO_WINDOWS_H -#include <stdarg.h> +#define COBJMACROS + #include <windef.h> #include <winbase.h> #include <winreg.h> @@ -10,8 +13,6 @@ #include <winuser.h> #include <wincon.h> #include <richedit.h> -#include <shellapi.h> -#include <shlwapi.h> #include <shlobj.h> #include <stdio.h> Modified: trunk/reactos/base/applications/rapps/richedit.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/rapps/ri… ============================================================================== --- trunk/reactos/base/applications/rapps/richedit.c [iso-8859-1] (original) +++ trunk/reactos/base/applications/rapps/richedit.c [iso-8859-1] Tue Jan 7 17:07:36 2014 @@ -8,9 +8,10 @@ #include "rapps.h" +#include <shlwapi.h> + HWND hRichEdit; PWSTR pLink = NULL; - VOID RichEditOnLink(HWND hwnd, ENLINK *Link) Modified: trunk/reactos/base/applications/rapps/settingsdlg.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/rapps/se… ============================================================================== --- trunk/reactos/base/applications/rapps/settingsdlg.c [iso-8859-1] (original) +++ trunk/reactos/base/applications/rapps/settingsdlg.c [iso-8859-1] Tue Jan 7 17:07:36 2014 @@ -6,7 +6,6 @@ * PROGRAMMERS: Dmitry Chapyshev (dmitry(a)reactos.org) */ -#define _WIN32_DCOM // For CoInitializeEx, etc... #include "rapps.h" SETTINGS_INFO NewSettingsInfo; Modified: trunk/reactos/base/applications/rapps/treeview.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/rapps/tr… ============================================================================== --- trunk/reactos/base/applications/rapps/treeview.c [iso-8859-1] (original) +++ trunk/reactos/base/applications/rapps/treeview.c [iso-8859-1] Tue Jan 7 17:07:36 2014 @@ -9,7 +9,6 @@ #include "rapps.h" HWND hTreeView; - HTREEITEM TreeViewAddItem(HTREEITEM hParent, LPWSTR lpText, INT Image, INT SelectedImage, LPARAM lParam) Modified: trunk/reactos/base/applications/rapps/winmain.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/rapps/wi… ============================================================================== --- trunk/reactos/base/applications/rapps/winmain.c [iso-8859-1] (original) +++ trunk/reactos/base/applications/rapps/winmain.c [iso-8859-1] Tue Jan 7 17:07:36 2014 @@ -8,12 +8,13 @@ #include "rapps.h" +#include <shellapi.h> + HWND hMainWnd; HINSTANCE hInst; HIMAGELIST hImageTreeView = NULL; INT SelectedEnumType = ENUM_ALL_COMPONENTS; SETTINGS_INFO SettingsInfo; - VOID FillDefaultSettings(PSETTINGS_INFO pSettingsInfo)

1 0

[akhaldi] 61562: [NOTEPAD] * Remove one time inclusions from the main header and put them back where they belong. * Cleanup headers. CORE-7716
by akhaldi＠svn.reactos.org 07 Jan '14

07 Jan '14

Author: akhaldi Date: Tue Jan 7 17:05:34 2014 New Revision: 61562 URL: http://svn.reactos.org/svn/reactos?rev=61562&view=rev Log: [NOTEPAD] * Remove one time inclusions from the main header and put them back where they belong. * Cleanup headers. CORE-7716 Modified: trunk/reactos/base/applications/notepad/dialog.c trunk/reactos/base/applications/notepad/dialog.h trunk/reactos/base/applications/notepad/main.h trunk/reactos/base/applications/notepad/notepad.h trunk/reactos/base/applications/notepad/settings.c Modified: trunk/reactos/base/applications/notepad/dialog.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/notepad/… ============================================================================== --- trunk/reactos/base/applications/notepad/dialog.c [iso-8859-1] (original) +++ trunk/reactos/base/applications/notepad/dialog.c [iso-8859-1] Tue Jan 7 17:05:34 2014 @@ -21,6 +21,10 @@ */ #include "notepad.h" + +#include <assert.h> +#include <commctrl.h> +#include <strsafe.h> LRESULT CALLBACK EDIT_WndProc(HWND hWnd, UINT msg, WPARAM wParam, LPARAM lParam); Modified: trunk/reactos/base/applications/notepad/dialog.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/notepad/… ============================================================================== --- trunk/reactos/base/applications/notepad/dialog.h [iso-8859-1] (original) +++ trunk/reactos/base/applications/notepad/dialog.h [iso-8859-1] Tue Jan 7 17:05:34 2014 @@ -17,6 +17,8 @@ * License along with this library; if not, write to the Free Software * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA */ + +#pragma once VOID DIALOG_FileNew(VOID); VOID DIALOG_FileOpen(VOID); Modified: trunk/reactos/base/applications/notepad/main.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/notepad/… ============================================================================== --- trunk/reactos/base/applications/notepad/main.h [iso-8859-1] (original) +++ trunk/reactos/base/applications/notepad/main.h [iso-8859-1] Tue Jan 7 17:05:34 2014 @@ -18,6 +18,8 @@ * License along with this library; if not, write to the Free Software * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA */ + +#pragma once #define SIZEOF(a) (sizeof(a)/sizeof((a)[0])) Modified: trunk/reactos/base/applications/notepad/notepad.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/notepad/… ============================================================================== --- trunk/reactos/base/applications/notepad/notepad.h [iso-8859-1] (original) +++ trunk/reactos/base/applications/notepad/notepad.h [iso-8859-1] Tue Jan 7 17:05:34 2014 @@ -2,20 +2,17 @@ #define STRSAFE_NO_DEPRECATE #endif -#include <assert.h> -#include <stdio.h> +#include <stdarg.h> + #include <windef.h> #include <winbase.h> #include <winuser.h> #include <winnls.h> -#include <winreg.h> #include <wingdi.h> #include <shellapi.h> #include <commdlg.h> -#include <commctrl.h> #include <tchar.h> #include <malloc.h> -#include <strsafe.h> #include "main.h" #include "dialog.h" Modified: trunk/reactos/base/applications/notepad/settings.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/notepad/… ============================================================================== --- trunk/reactos/base/applications/notepad/settings.c [iso-8859-1] (original) +++ trunk/reactos/base/applications/notepad/settings.c [iso-8859-1] Tue Jan 7 17:05:34 2014 @@ -21,6 +21,8 @@ */ #include "notepad.h" + +#include <winreg.h> static LPCTSTR s_szRegistryKey = _T("Software\\Microsoft\\Notepad");

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs