Ros-diffs

ros-diffs@reactos.org

81390 discussions

[aandrejevic] 60049: [SOFT386] Implement PUSHA and POPA.
by aandrejevic＠svn.reactos.org 11 Sep '13

11 Sep '13

Author: aandrejevic Date: Wed Sep 11 23:31:35 2013 New Revision: 60049 URL: http://svn.reactos.org/svn/reactos?rev=60049&view=rev Log: [SOFT386] Implement PUSHA and POPA. Modified: branches/ntvdm/lib/soft386/opcodes.c Modified: branches/ntvdm/lib/soft386/opcodes.c URL: http://svn.reactos.org/svn/reactos/branches/ntvdm/lib/soft386/opcodes.c?rev… ============================================================================== --- branches/ntvdm/lib/soft386/opcodes.c [iso-8859-1] (original) +++ branches/ntvdm/lib/soft386/opcodes.c [iso-8859-1] Wed Sep 11 23:31:35 2013 @@ -3485,18 +3485,92 @@ SOFT386_OPCODE_HANDLER(Soft386OpcodePushAll) { - // TODO: NOT IMPLEMENTED - UNIMPLEMENTED; - - return FALSE; + INT i; + BOOLEAN Size = State->SegmentRegs[SOFT386_REG_CS].Size; + SOFT386_REG SavedEsp = State->GeneralRegs[SOFT386_REG_ESP]; + + /* Make sure this is the right instruction */ + ASSERT(Opcode == 0x60); + + if (State->PrefixFlags == SOFT386_PREFIX_OPSIZE) + { + /* The OPSIZE prefix toggles the size */ + Size = !Size; + } + else + { + /* Invalid prefix */ + Soft386Exception(State, SOFT386_EXCEPTION_UD); + return FALSE; + } + + /* Push all the registers in order */ + for (i = 0; i < SOFT386_NUM_GEN_REGS; i++) + { + if (i == SOFT386_REG_ESP) + { + /* Use the saved ESP instead */ + if (!Soft386StackPush(State, Size ? SavedEsp.Long : SavedEsp.LowWord)) + { + /* Exception occurred */ + return FALSE; + } + } + else + { + /* Push the register */ + if (!Soft386StackPush(State, Size ? State->GeneralRegs[i].Long + : State->GeneralRegs[i].LowWord)) + { + /* Exception occurred */ + return FALSE; + } + } + } + + return TRUE; } SOFT386_OPCODE_HANDLER(Soft386OpcodePopAll) { - // TODO: NOT IMPLEMENTED - UNIMPLEMENTED; - - return FALSE; + INT i; + BOOLEAN Size = State->SegmentRegs[SOFT386_REG_CS].Size; + ULONG Value; + + /* Make sure this is the right instruction */ + ASSERT(Opcode == 0x61); + + if (State->PrefixFlags == SOFT386_PREFIX_OPSIZE) + { + /* The OPSIZE prefix toggles the size */ + Size = !Size; + } + else + { + /* Invalid prefix */ + Soft386Exception(State, SOFT386_EXCEPTION_UD); + return FALSE; + } + + /* Pop all the registers in reverse order */ + for (i = SOFT386_NUM_GEN_REGS - 1; i >= 0; i--) + { + /* Pop the value */ + if (!Soft386StackPop(State, &Value)) + { + /* Exception occurred */ + return FALSE; + } + + /* Don't modify ESP */ + if (i != SOFT386_REG_ESP) + { + if (Size) State->GeneralRegs[i].Long = Value; + else State->GeneralRegs[i].LowWord = LOWORD(Value); + } + } + + return TRUE; } SOFT386_OPCODE_HANDLER(Soft386OpcodeBound)

1 0

[tfaber] 60048: [KERNEL32] - Fix access rights when using CreateFile with FILE_FLAG_DELETE_ON_CLOSE
by tfaber＠svn.reactos.org 11 Sep '13

11 Sep '13

Author: tfaber Date: Wed Sep 11 23:31:11 2013 New Revision: 60048 URL: http://svn.reactos.org/svn/reactos?rev=60048&view=rev Log: [KERNEL32] - Fix access rights when using CreateFile with FILE_FLAG_DELETE_ON_CLOSE Modified: trunk/reactos/dll/win32/kernel32/client/file/create.c Modified: trunk/reactos/dll/win32/kernel32/client/file/create.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/client/… ============================================================================== --- trunk/reactos/dll/win32/kernel32/client/file/create.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/kernel32/client/file/create.c [iso-8859-1] Wed Sep 11 23:31:11 2013 @@ -174,7 +174,10 @@ Flags |= FILE_SEQUENTIAL_ONLY; if(dwFlagsAndAttributes & FILE_FLAG_DELETE_ON_CLOSE) + { Flags |= FILE_DELETE_ON_CLOSE; + dwDesiredAccess |= DELETE; + } if(dwFlagsAndAttributes & FILE_FLAG_BACKUP_SEMANTICS) {

1 0

[hbelusca] 60047: [NPFS_NEW]: Add file header info.
by hbelusca＠svn.reactos.org 11 Sep '13

11 Sep '13

Author: hbelusca Date: Wed Sep 11 23:19:20 2013 New Revision: 60047 URL: http://svn.reactos.org/svn/reactos?rev=60047&view=rev Log: [NPFS_NEW]: Add file header info. Modified: trunk/reactos/drivers/filesystems/npfs_new/cleanup.c trunk/reactos/drivers/filesystems/npfs_new/close.c trunk/reactos/drivers/filesystems/npfs_new/create.c trunk/reactos/drivers/filesystems/npfs_new/datasup.c trunk/reactos/drivers/filesystems/npfs_new/fileinfo.c trunk/reactos/drivers/filesystems/npfs_new/fileobsup.c trunk/reactos/drivers/filesystems/npfs_new/flushbuf.c trunk/reactos/drivers/filesystems/npfs_new/fsctrl.c trunk/reactos/drivers/filesystems/npfs_new/main.c trunk/reactos/drivers/filesystems/npfs_new/prefxsup.c trunk/reactos/drivers/filesystems/npfs_new/read.c trunk/reactos/drivers/filesystems/npfs_new/readsup.c trunk/reactos/drivers/filesystems/npfs_new/secursup.c trunk/reactos/drivers/filesystems/npfs_new/seinfo.c trunk/reactos/drivers/filesystems/npfs_new/statesup.c trunk/reactos/drivers/filesystems/npfs_new/strucsup.c trunk/reactos/drivers/filesystems/npfs_new/volinfo.c trunk/reactos/drivers/filesystems/npfs_new/waitsup.c trunk/reactos/drivers/filesystems/npfs_new/write.c trunk/reactos/drivers/filesystems/npfs_new/writesup.c Modified: trunk/reactos/drivers/filesystems/npfs_new/cleanup.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/npfs_n… ============================================================================== --- trunk/reactos/drivers/filesystems/npfs_new/cleanup.c [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/npfs_new/cleanup.c [iso-8859-1] Wed Sep 11 23:19:20 2013 @@ -1,4 +1,16 @@ +/* + * PROJECT: ReactOS Named Pipe FileSystem + * LICENSE: BSD - See COPYING.ARM in the top level directory + * FILE: drivers/filesystems/npfs/cleanup.c + * PURPOSE: Pipes Cleanup + * PROGRAMMERS: ReactOS Portable Systems Group + */ + +/* INCLUDES *******************************************************************/ + #include "npfs.h" + +/* FUNCTIONS ******************************************************************/ NTSTATUS NTAPI @@ -61,3 +73,4 @@ return Status; } +/* EOF */ Modified: trunk/reactos/drivers/filesystems/npfs_new/close.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/npfs_n… ============================================================================== --- trunk/reactos/drivers/filesystems/npfs_new/close.c [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/npfs_new/close.c [iso-8859-1] Wed Sep 11 23:19:20 2013 @@ -1,4 +1,16 @@ +/* + * PROJECT: ReactOS Named Pipe FileSystem + * LICENSE: BSD - See COPYING.ARM in the top level directory + * FILE: drivers/filesystems/npfs/close.c + * PURPOSE: Pipes Closing + * PROGRAMMERS: ReactOS Portable Systems Group + */ + +/* INCLUDES *******************************************************************/ + #include "npfs.h" + +/* FUNCTIONS ******************************************************************/ NTSTATUS NTAPI @@ -56,3 +68,4 @@ return Status; } +/* EOF */ Modified: trunk/reactos/drivers/filesystems/npfs_new/create.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/npfs_n… ============================================================================== --- trunk/reactos/drivers/filesystems/npfs_new/create.c [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/npfs_new/create.c [iso-8859-1] Wed Sep 11 23:19:20 2013 @@ -1,4 +1,16 @@ +/* + * PROJECT: ReactOS Named Pipe FileSystem + * LICENSE: BSD - See COPYING.ARM in the top level directory + * FILE: drivers/filesystems/npfs/create.c + * PURPOSE: Pipes Creation + * PROGRAMMERS: ReactOS Portable Systems Group + */ + +/* INCLUDES *******************************************************************/ + #include "npfs.h" + +/* FUNCTIONS ******************************************************************/ VOID NTAPI @@ -728,3 +740,4 @@ return IoStatus.Status; } +/* EOF */ Modified: trunk/reactos/drivers/filesystems/npfs_new/datasup.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/npfs_n… ============================================================================== --- trunk/reactos/drivers/filesystems/npfs_new/datasup.c [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/npfs_new/datasup.c [iso-8859-1] Wed Sep 11 23:19:20 2013 @@ -1,4 +1,16 @@ +/* + * PROJECT: ReactOS Named Pipe FileSystem + * LICENSE: BSD - See COPYING.ARM in the top level directory + * FILE: drivers/filesystems/npfs/datasup.c + * PURPOSE: Data Queues Support + * PROGRAMMERS: ReactOS Portable Systems Group + */ + +/* INCLUDES *******************************************************************/ + #include "npfs.h" + +/* FUNCTIONS ******************************************************************/ NTSTATUS NTAPI @@ -457,3 +469,5 @@ return Status; } + +/* EOF */ Modified: trunk/reactos/drivers/filesystems/npfs_new/fileinfo.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/npfs_n… ============================================================================== --- trunk/reactos/drivers/filesystems/npfs_new/fileinfo.c [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/npfs_new/fileinfo.c [iso-8859-1] Wed Sep 11 23:19:20 2013 @@ -1,4 +1,16 @@ +/* + * PROJECT: ReactOS Named Pipe FileSystem + * LICENSE: BSD - See COPYING.ARM in the top level directory + * FILE: drivers/filesystems/npfs/fileinfo.c + * PURPOSE: Pipes Information + * PROGRAMMERS: ReactOS Portable Systems Group + */ + +/* INCLUDES *******************************************************************/ + #include "npfs.h" + +/* FUNCTIONS ******************************************************************/ NTSTATUS NTAPI @@ -466,6 +478,4 @@ return Status; } -// -// volinfo.c -// +/* EOF */ Modified: trunk/reactos/drivers/filesystems/npfs_new/fileobsup.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/npfs_n… ============================================================================== --- trunk/reactos/drivers/filesystems/npfs_new/fileobsup.c [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/npfs_new/fileobsup.c [iso-8859-1] Wed Sep 11 23:19:20 2013 @@ -1,4 +1,16 @@ +/* + * PROJECT: ReactOS Named Pipe FileSystem + * LICENSE: BSD - See COPYING.ARM in the top level directory + * FILE: drivers/filesystems/npfs/fileobsup.c + * PURPOSE: Pipes File Object Support + * PROGRAMMERS: ReactOS Portable Systems Group + */ + +/* INCLUDES *******************************************************************/ + #include "npfs.h" + +/* FUNCTIONS ******************************************************************/ NODE_TYPE_CODE NTAPI @@ -73,3 +85,4 @@ if (FileIsPipe) FileObject->Flags |= FO_NAMED_PIPE; } +/* EOF */ Modified: trunk/reactos/drivers/filesystems/npfs_new/flushbuf.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/npfs_n… ============================================================================== --- trunk/reactos/drivers/filesystems/npfs_new/flushbuf.c [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/npfs_new/flushbuf.c [iso-8859-1] Wed Sep 11 23:19:20 2013 @@ -1,4 +1,16 @@ +/* + * PROJECT: ReactOS Named Pipe FileSystem + * LICENSE: BSD - See COPYING.ARM in the top level directory + * FILE: drivers/filesystems/npfs/flushbuf.c + * PURPOSE: Buffers Flushing Support + * PROGRAMMERS: ReactOS Portable Systems Group + */ + +/* INCLUDES *******************************************************************/ + #include "npfs.h" + +/* FUNCTIONS ******************************************************************/ NTSTATUS NTAPI @@ -69,3 +81,4 @@ return Status; } +/* EOF */ Modified: trunk/reactos/drivers/filesystems/npfs_new/fsctrl.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/npfs_n… ============================================================================== --- trunk/reactos/drivers/filesystems/npfs_new/fsctrl.c [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/npfs_new/fsctrl.c [iso-8859-1] Wed Sep 11 23:19:20 2013 @@ -1,6 +1,20 @@ +/* + * PROJECT: ReactOS Named Pipe FileSystem + * LICENSE: BSD - See COPYING.ARM in the top level directory + * FILE: drivers/filesystems/npfs/fsctrl.c + * PURPOSE: Named Pipe FileSystem I/O Controls + * PROGRAMMERS: ReactOS Portable Systems Group + */ + +/* INCLUDES *******************************************************************/ + #include "npfs.h" +/* GLOBALS ********************************************************************/ + IO_STATUS_BLOCK NpUserIoStatusBlock; + +/* FUNCTIONS ******************************************************************/ NTSTATUS NTAPI @@ -687,4 +701,4 @@ return Status; } - +/* EOF */ Modified: trunk/reactos/drivers/filesystems/npfs_new/main.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/npfs_n… ============================================================================== --- trunk/reactos/drivers/filesystems/npfs_new/main.c [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/npfs_new/main.c [iso-8859-1] Wed Sep 11 23:19:20 2013 @@ -1,6 +1,20 @@ +/* + * PROJECT: ReactOS Named Pipe FileSystem + * LICENSE: BSD - See COPYING.ARM in the top level directory + * FILE: drivers/filesystems/npfs/main.c + * PURPOSE: Named Pipe FileSystem Driver Initialization + * PROGRAMMERS: ReactOS Portable Systems Group + */ + +/* INCLUDES *******************************************************************/ + #include "npfs.h" +/* GLOBALS ********************************************************************/ + PDEVICE_OBJECT NpfsDeviceObject; + +/* FUNCTIONS ******************************************************************/ NTSTATUS NTAPI @@ -70,3 +84,5 @@ ASSERT(Status == STATUS_SUCCESS); return STATUS_SUCCESS; } + +/* EOF */ Modified: trunk/reactos/drivers/filesystems/npfs_new/prefxsup.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/npfs_n… ============================================================================== --- trunk/reactos/drivers/filesystems/npfs_new/prefxsup.c [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/npfs_new/prefxsup.c [iso-8859-1] Wed Sep 11 23:19:20 2013 @@ -1,4 +1,16 @@ +/* + * PROJECT: ReactOS Named Pipe FileSystem + * LICENSE: BSD - See COPYING.ARM in the top level directory + * FILE: drivers/filesystems/npfs/prefxsup.c + * PURPOSE: Pipes Prefixes Support + * PROGRAMMERS: ReactOS Portable Systems Group + */ + +/* INCLUDES *******************************************************************/ + #include "npfs.h" + +/* FUNCTIONS ******************************************************************/ PNP_FCB NTAPI @@ -75,3 +87,4 @@ return STATUS_SUCCESS; } +/* EOF */ Modified: trunk/reactos/drivers/filesystems/npfs_new/read.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/npfs_n… ============================================================================== --- trunk/reactos/drivers/filesystems/npfs_new/read.c [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/npfs_new/read.c [iso-8859-1] Wed Sep 11 23:19:20 2013 @@ -1,6 +1,20 @@ +/* + * PROJECT: ReactOS Named Pipe FileSystem + * LICENSE: BSD - See COPYING.ARM in the top level directory + * FILE: drivers/filesystems/npfs/read.c + * PURPOSE: Pipes Reading + * PROGRAMMERS: ReactOS Portable Systems Group + */ + +/* INCLUDES *******************************************************************/ + #include "npfs.h" +/* GLOBALS ********************************************************************/ + LONG NpSlowReadCalls; + +/* FUNCTIONS ******************************************************************/ BOOLEAN NTAPI @@ -172,3 +186,5 @@ return IoStatus.Status; } + +/* EOF */ Modified: trunk/reactos/drivers/filesystems/npfs_new/readsup.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/npfs_n… ============================================================================== --- trunk/reactos/drivers/filesystems/npfs_new/readsup.c [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/npfs_new/readsup.c [iso-8859-1] Wed Sep 11 23:19:20 2013 @@ -1,4 +1,16 @@ +/* + * PROJECT: ReactOS Named Pipe FileSystem + * LICENSE: BSD - See COPYING.ARM in the top level directory + * FILE: drivers/filesystems/npfs/readsup.c + * PURPOSE: Pipes Reading Support + * PROGRAMMERS: ReactOS Portable Systems Group + */ + +/* INCLUDES *******************************************************************/ + #include "npfs.h" + +/* FUNCTIONS ******************************************************************/ IO_STATUS_BLOCK NTAPI @@ -140,3 +152,4 @@ return Status; } +/* EOF */ Modified: trunk/reactos/drivers/filesystems/npfs_new/secursup.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/npfs_n… ============================================================================== --- trunk/reactos/drivers/filesystems/npfs_new/secursup.c [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/npfs_new/secursup.c [iso-8859-1] Wed Sep 11 23:19:20 2013 @@ -1,4 +1,16 @@ +/* + * PROJECT: ReactOS Named Pipe FileSystem + * LICENSE: BSD - See COPYING.ARM in the top level directory + * FILE: drivers/filesystems/npfs/secursup.c + * PURPOSE: Pipes Security Support + * PROGRAMMERS: ReactOS Portable Systems Group + */ + +/* INCLUDES *******************************************************************/ + #include "npfs.h" + +/* FUNCTIONS ******************************************************************/ VOID NTAPI @@ -118,3 +130,4 @@ return Status; } +/* EOF */ Modified: trunk/reactos/drivers/filesystems/npfs_new/seinfo.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/npfs_n… ============================================================================== --- trunk/reactos/drivers/filesystems/npfs_new/seinfo.c [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/npfs_new/seinfo.c [iso-8859-1] Wed Sep 11 23:19:20 2013 @@ -1,4 +1,16 @@ +/* + * PROJECT: ReactOS Named Pipe FileSystem + * LICENSE: BSD - See COPYING.ARM in the top level directory + * FILE: drivers/filesystems/npfs/seinfo.c + * PURPOSE: Pipes Security Information + * PROGRAMMERS: ReactOS Portable Systems Group + */ + +/* INCLUDES *******************************************************************/ + #include "npfs.h" + +/* FUNCTIONS ******************************************************************/ NTSTATUS NTAPI @@ -126,3 +138,4 @@ return Status; } +/* EOF */ Modified: trunk/reactos/drivers/filesystems/npfs_new/statesup.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/npfs_n… ============================================================================== --- trunk/reactos/drivers/filesystems/npfs_new/statesup.c [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/npfs_new/statesup.c [iso-8859-1] Wed Sep 11 23:19:20 2013 @@ -1,4 +1,16 @@ +/* + * PROJECT: ReactOS Named Pipe FileSystem + * LICENSE: BSD - See COPYING.ARM in the top level directory + * FILE: drivers/filesystems/npfs/statesup.c + * PURPOSE: Pipes State Support + * PROGRAMMERS: ReactOS Portable Systems Group + */ + +/* INCLUDES *******************************************************************/ + #include "npfs.h" + +/* FUNCTIONS ******************************************************************/ VOID NTAPI @@ -371,3 +383,4 @@ return STATUS_SUCCESS; } +/* EOF */ Modified: trunk/reactos/drivers/filesystems/npfs_new/strucsup.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/npfs_n… ============================================================================== --- trunk/reactos/drivers/filesystems/npfs_new/strucsup.c [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/npfs_new/strucsup.c [iso-8859-1] Wed Sep 11 23:19:20 2013 @@ -1,9 +1,23 @@ +/* + * PROJECT: ReactOS Named Pipe FileSystem + * LICENSE: BSD - See COPYING.ARM in the top level directory + * FILE: drivers/filesystems/npfs/strucsup.c + * PURPOSE: + * PROGRAMMERS: ReactOS Portable Systems Group + */ + +/* INCLUDES *******************************************************************/ + #include "npfs.h" + +/* GLOBALS ********************************************************************/ #define UNIMPLEMENTED PWCHAR NpRootDCBName = L"\\"; PNP_VCB NpVcb; + +/* FUNCTIONS ******************************************************************/ RTL_GENERIC_COMPARE_RESULTS NTAPI @@ -344,3 +358,4 @@ return STATUS_SUCCESS; } +/* EOF */ Modified: trunk/reactos/drivers/filesystems/npfs_new/volinfo.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/npfs_n… ============================================================================== --- trunk/reactos/drivers/filesystems/npfs_new/volinfo.c [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/npfs_new/volinfo.c [iso-8859-1] Wed Sep 11 23:19:20 2013 @@ -1,4 +1,16 @@ +/* + * PROJECT: ReactOS Named Pipe FileSystem + * LICENSE: BSD - See COPYING.ARM in the top level directory + * FILE: drivers/filesystems/npfs/volinfo.c + * PURPOSE: Named Pipe FileSystem Volume Information + * PROGRAMMERS: ReactOS Portable Systems Group + */ + +/* INCLUDES *******************************************************************/ + #include "npfs.h" + +/* FUNCTIONS ******************************************************************/ NTSTATUS NTAPI @@ -186,3 +198,5 @@ return Status; } + +/* EOF */ Modified: trunk/reactos/drivers/filesystems/npfs_new/waitsup.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/npfs_n… ============================================================================== --- trunk/reactos/drivers/filesystems/npfs_new/waitsup.c [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/npfs_new/waitsup.c [iso-8859-1] Wed Sep 11 23:19:20 2013 @@ -1,4 +1,16 @@ +/* + * PROJECT: ReactOS Named Pipe FileSystem + * LICENSE: BSD - See COPYING.ARM in the top level directory + * FILE: drivers/filesystems/npfs/waitsup.c + * PURPOSE: Pipes Waiting Support + * PROGRAMMERS: ReactOS Portable Systems Group + */ + +/* INCLUDES *******************************************************************/ + #include "npfs.h" + +/* FUNCTIONS ******************************************************************/ VOID NTAPI @@ -189,3 +201,5 @@ } return Status; } + +/* EOF */ Modified: trunk/reactos/drivers/filesystems/npfs_new/write.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/npfs_n… ============================================================================== --- trunk/reactos/drivers/filesystems/npfs_new/write.c [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/npfs_new/write.c [iso-8859-1] Wed Sep 11 23:19:20 2013 @@ -1,6 +1,20 @@ +/* + * PROJECT: ReactOS Named Pipe FileSystem + * LICENSE: BSD - See COPYING.ARM in the top level directory + * FILE: drivers/filesystems/npfs/write.c + * PURPOSE: Pipes Writing + * PROGRAMMERS: ReactOS Portable Systems Group + */ + +/* INCLUDES *******************************************************************/ + #include "npfs.h" +/* GLOBALS ********************************************************************/ + LONG NpSlowWriteCalls; + +/* FUNCTIONS ******************************************************************/ BOOLEAN NTAPI @@ -188,3 +202,4 @@ return IoStatus.Status; } +/* EOF */ Modified: trunk/reactos/drivers/filesystems/npfs_new/writesup.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/npfs_n… ============================================================================== --- trunk/reactos/drivers/filesystems/npfs_new/writesup.c [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/npfs_new/writesup.c [iso-8859-1] Wed Sep 11 23:19:20 2013 @@ -1,4 +1,16 @@ +/* + * PROJECT: ReactOS Named Pipe FileSystem + * LICENSE: BSD - See COPYING.ARM in the top level directory + * FILE: drivers/filesystems/npfs/writesup.c + * PURPOSE: Pipes Writing Support + * PROGRAMMERS: ReactOS Portable Systems Group + */ + +/* INCLUDES *******************************************************************/ + #include "npfs.h" + +/* FUNCTIONS ******************************************************************/ NTSTATUS NTAPI @@ -153,3 +165,4 @@ return Status; } +/* EOF */

1 0

[akhaldi] 60046: [NTOSKRNL] * Fix a copy pasted typo.
by akhaldi＠svn.reactos.org 11 Sep '13

11 Sep '13

Author: akhaldi Date: Wed Sep 11 22:09:41 2013 New Revision: 60046 URL: http://svn.reactos.org/svn/reactos?rev=60046&view=rev Log: [NTOSKRNL] * Fix a copy pasted typo. Modified: trunk/reactos/ntoskrnl/io/iomgr/file.c Modified: trunk/reactos/ntoskrnl/io/iomgr/file.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/io/iomgr/file.c?r… ============================================================================== --- trunk/reactos/ntoskrnl/io/iomgr/file.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/io/iomgr/file.c [iso-8859-1] Wed Sep 11 22:09:41 2013 @@ -1763,7 +1763,7 @@ if (CreateOptions & ~FILE_VALID_OPTION_FLAGS) { - DPRINT1("File Create 'CreateOptions' Prameter contains invalid flags!\n"); + DPRINT1("File Create 'CreateOptions' parameter contains invalid flags!\n"); ExFreePool(OpenPacket); return STATUS_INVALID_PARAMETER; } @@ -1771,14 +1771,14 @@ if ((CreateOptions & (FILE_SYNCHRONOUS_IO_ALERT | FILE_SYNCHRONOUS_IO_NONALERT)) && (!(DesiredAccess & SYNCHRONIZE))) { - DPRINT1("File Create 'CreateOptions' Prameter FILE_SYNCHRONOUS_IO_* requested, but 'DesiredAccess' does not have SYNCHRONIZE!\n"); + DPRINT1("File Create 'CreateOptions' parameter FILE_SYNCHRONOUS_IO_* requested, but 'DesiredAccess' does not have SYNCHRONIZE!\n"); ExFreePool(OpenPacket); return STATUS_INVALID_PARAMETER; } if ((CreateOptions & FILE_DELETE_ON_CLOSE) && (!(DesiredAccess & DELETE))) { - DPRINT1("File Create 'CreateOptions' Prameter FILE_DELETE_ON_CLOSE requested, but 'DesiredAccess' does not have DELETE!\n"); + DPRINT1("File Create 'CreateOptions' parameter FILE_DELETE_ON_CLOSE requested, but 'DesiredAccess' does not have DELETE!\n"); ExFreePool(OpenPacket); return STATUS_INVALID_PARAMETER; } @@ -1786,7 +1786,7 @@ if ((CreateOptions & (FILE_SYNCHRONOUS_IO_NONALERT | FILE_SYNCHRONOUS_IO_ALERT)) == (FILE_SYNCHRONOUS_IO_NONALERT | FILE_SYNCHRONOUS_IO_ALERT)) { - DPRINT1("File Create 'FileAttributes' Prameter both FILE_SYNCHRONOUS_IO_NONALERT and FILE_SYNCHRONOUS_IO_ALERT specified!\n"); + DPRINT1("File Create 'FileAttributes' parameter both FILE_SYNCHRONOUS_IO_NONALERT and FILE_SYNCHRONOUS_IO_ALERT specified!\n"); ExFreePool(OpenPacket); return STATUS_INVALID_PARAMETER; } @@ -1826,7 +1826,7 @@ if ((CreateOptions & FILE_NO_INTERMEDIATE_BUFFERING) && (DesiredAccess & FILE_APPEND_DATA)) { - DPRINT1("File Create 'CreateOptions' Prameter FILE_NO_INTERMEDIATE_BUFFERING requested, but 'DesiredAccess' FILE_APPEND_DATA requires it!\n"); + DPRINT1("File Create 'CreateOptions' parameter FILE_NO_INTERMEDIATE_BUFFERING requested, but 'DesiredAccess' FILE_APPEND_DATA requires it!\n"); ExFreePool(OpenPacket); return STATUS_INVALID_PARAMETER; }

1 0

[akhaldi] 60045: [NTOSKRNL] * Break down the checks as suggested by Alex. Brought to you by David Quintana.
by akhaldi＠svn.reactos.org 11 Sep '13

11 Sep '13

Author: akhaldi Date: Wed Sep 11 21:50:15 2013 New Revision: 60045 URL: http://svn.reactos.org/svn/reactos?rev=60045&view=rev Log: [NTOSKRNL] * Break down the checks as suggested by Alex. Brought to you by David Quintana. Modified: trunk/reactos/ntoskrnl/io/iomgr/file.c Modified: trunk/reactos/ntoskrnl/io/iomgr/file.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/io/iomgr/file.c?r… ============================================================================== --- trunk/reactos/ntoskrnl/io/iomgr/file.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/io/iomgr/file.c [iso-8859-1] Wed Sep 11 21:50:15 2013 @@ -1740,45 +1740,93 @@ if ((AccessMode != KernelMode) || (Options & IO_CHECK_CREATE_PARAMETERS)) { /* Validate parameters */ - if ((FileAttributes & ~FILE_ATTRIBUTE_VALID_FLAGS) || - - (ShareAccess & ~FILE_SHARE_VALID_FLAGS) || - - (Disposition > FILE_MAXIMUM_DISPOSITION) || - - (CreateOptions & ~FILE_VALID_OPTION_FLAGS) || - - ((CreateOptions & (FILE_SYNCHRONOUS_IO_ALERT | FILE_SYNCHRONOUS_IO_NONALERT)) && - (!(DesiredAccess & SYNCHRONIZE))) || - - ((CreateOptions & FILE_DELETE_ON_CLOSE) && (!(DesiredAccess & DELETE))) || - - ((CreateOptions & (FILE_SYNCHRONOUS_IO_NONALERT | FILE_SYNCHRONOUS_IO_ALERT)) == - (FILE_SYNCHRONOUS_IO_NONALERT | FILE_SYNCHRONOUS_IO_ALERT)) || - - ((CreateOptions & FILE_DIRECTORY_FILE) && !(CreateOptions & FILE_NON_DIRECTORY_FILE) && - ((CreateOptions & ~(FILE_DIRECTORY_FILE | - FILE_SYNCHRONOUS_IO_ALERT | - FILE_SYNCHRONOUS_IO_NONALERT | - FILE_WRITE_THROUGH | - FILE_COMPLETE_IF_OPLOCKED | - FILE_OPEN_FOR_BACKUP_INTENT | - FILE_DELETE_ON_CLOSE | - FILE_OPEN_FOR_FREE_SPACE_QUERY | - FILE_OPEN_BY_FILE_ID | - FILE_NO_COMPRESSION | - FILE_OPEN_REPARSE_POINT)) || - ((Disposition != FILE_CREATE) && (Disposition != FILE_OPEN) && (Disposition != FILE_OPEN_IF)))) || - - ((CreateOptions & FILE_COMPLETE_IF_OPLOCKED) && (CreateOptions & FILE_RESERVE_OPFILTER)) || - - ((CreateOptions & FILE_NO_INTERMEDIATE_BUFFERING) && (DesiredAccess & FILE_APPEND_DATA))) - { - /* - * Parameter failure. We'll be as unspecific as NT as to - * why this happened though, to make debugging a pain! - */ - DPRINT1("File Create Parameter Failure!\n"); + if (FileAttributes & ~FILE_ATTRIBUTE_VALID_FLAGS) + { + DPRINT1("File Create 'FileAttributes' Parameter contains invalid flags!\n"); + ExFreePool(OpenPacket); + return STATUS_INVALID_PARAMETER; + } + + if (ShareAccess & ~FILE_SHARE_VALID_FLAGS) + { + DPRINT1("File Create 'ShareAccess' Parameter contains invalid flags!\n"); + ExFreePool(OpenPacket); + return STATUS_INVALID_PARAMETER; + } + + if (Disposition > FILE_MAXIMUM_DISPOSITION) + { + DPRINT1("File Create 'Disposition' Parameter is out of range!\n"); + ExFreePool(OpenPacket); + return STATUS_INVALID_PARAMETER; + } + + if (CreateOptions & ~FILE_VALID_OPTION_FLAGS) + { + DPRINT1("File Create 'CreateOptions' Prameter contains invalid flags!\n"); + ExFreePool(OpenPacket); + return STATUS_INVALID_PARAMETER; + } + + if ((CreateOptions & (FILE_SYNCHRONOUS_IO_ALERT | FILE_SYNCHRONOUS_IO_NONALERT)) && + (!(DesiredAccess & SYNCHRONIZE))) + { + DPRINT1("File Create 'CreateOptions' Prameter FILE_SYNCHRONOUS_IO_* requested, but 'DesiredAccess' does not have SYNCHRONIZE!\n"); + ExFreePool(OpenPacket); + return STATUS_INVALID_PARAMETER; + } + + if ((CreateOptions & FILE_DELETE_ON_CLOSE) && (!(DesiredAccess & DELETE))) + { + DPRINT1("File Create 'CreateOptions' Prameter FILE_DELETE_ON_CLOSE requested, but 'DesiredAccess' does not have DELETE!\n"); + ExFreePool(OpenPacket); + return STATUS_INVALID_PARAMETER; + } + + if ((CreateOptions & (FILE_SYNCHRONOUS_IO_NONALERT | FILE_SYNCHRONOUS_IO_ALERT)) == + (FILE_SYNCHRONOUS_IO_NONALERT | FILE_SYNCHRONOUS_IO_ALERT)) + { + DPRINT1("File Create 'FileAttributes' Prameter both FILE_SYNCHRONOUS_IO_NONALERT and FILE_SYNCHRONOUS_IO_ALERT specified!\n"); + ExFreePool(OpenPacket); + return STATUS_INVALID_PARAMETER; + } + + if ((CreateOptions & FILE_DIRECTORY_FILE) && !(CreateOptions & FILE_NON_DIRECTORY_FILE) && + (CreateOptions & ~(FILE_DIRECTORY_FILE | + FILE_SYNCHRONOUS_IO_ALERT | + FILE_SYNCHRONOUS_IO_NONALERT | + FILE_WRITE_THROUGH | + FILE_COMPLETE_IF_OPLOCKED | + FILE_OPEN_FOR_BACKUP_INTENT | + FILE_DELETE_ON_CLOSE | + FILE_OPEN_FOR_FREE_SPACE_QUERY | + FILE_OPEN_BY_FILE_ID | + FILE_NO_COMPRESSION | + FILE_OPEN_REPARSE_POINT))) + { + DPRINT1("File Create 'CreateOptions' Parameter has flags incompatible with FILE_DIRECTORY_FILE!\n"); + ExFreePool(OpenPacket); + return STATUS_INVALID_PARAMETER; + } + + if ((CreateOptions & FILE_DIRECTORY_FILE) && !(CreateOptions & FILE_NON_DIRECTORY_FILE) && + (Disposition != FILE_CREATE) && (Disposition != FILE_OPEN) && (Disposition != FILE_OPEN_IF)) + { + DPRINT1("File Create 'CreateOptions' Parameter FILE_DIRECTORY_FILE requested, but 'Disposition' is not FILE_CREATE/FILE_OPEN/FILE_OPEN_IF!\n"); + ExFreePool(OpenPacket); + return STATUS_INVALID_PARAMETER; + } + + if ((CreateOptions & FILE_COMPLETE_IF_OPLOCKED) && (CreateOptions & FILE_RESERVE_OPFILTER)) + { + DPRINT1("File Create 'CreateOptions' Parameter both FILE_COMPLETE_IF_OPLOCKED and FILE_RESERVE_OPFILTER specified!\n"); + ExFreePool(OpenPacket); + return STATUS_INVALID_PARAMETER; + } + + if ((CreateOptions & FILE_NO_INTERMEDIATE_BUFFERING) && (DesiredAccess & FILE_APPEND_DATA)) + { + DPRINT1("File Create 'CreateOptions' Prameter FILE_NO_INTERMEDIATE_BUFFERING requested, but 'DesiredAccess' FILE_APPEND_DATA requires it!\n"); ExFreePool(OpenPacket); return STATUS_INVALID_PARAMETER; }

1 0

[tfaber] 60044: [NTOS:IO] - Fix pool corruption resulting form a combination of r60038 and dubious SEH programming patterns
by tfaber＠svn.reactos.org 11 Sep '13

11 Sep '13

Author: tfaber Date: Wed Sep 11 21:23:23 2013 New Revision: 60044 URL: http://svn.reactos.org/svn/reactos?rev=60044&view=rev Log: [NTOS:IO] - Fix pool corruption resulting form a combination of r60038 and dubious SEH programming patterns Modified: trunk/reactos/ntoskrnl/io/iomgr/file.c Modified: trunk/reactos/ntoskrnl/io/iomgr/file.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/io/iomgr/file.c?r… ============================================================================== --- trunk/reactos/ntoskrnl/io/iomgr/file.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/io/iomgr/file.c [iso-8859-1] Wed Sep 11 21:23:23 2013 @@ -1890,7 +1890,7 @@ /* Return the exception code */ if (OpenPacket->EaBuffer != NULL) ExFreePool(OpenPacket->EaBuffer); ExFreePool(OpenPacket); - Status = _SEH2_GetExceptionCode(); + _SEH2_YIELD(return _SEH2_GetExceptionCode()); } _SEH2_END; }

1 0

[akhaldi] 60043: [NTOSKRNL] * Silence some debug prints.
by akhaldi＠svn.reactos.org 11 Sep '13

11 Sep '13

Author: akhaldi Date: Wed Sep 11 19:59:59 2013 New Revision: 60043 URL: http://svn.reactos.org/svn/reactos?rev=60043&view=rev Log: [NTOSKRNL] * Silence some debug prints. Modified: trunk/reactos/ntoskrnl/mm/ARM3/expool.c trunk/reactos/ntoskrnl/mm/ARM3/mminit.c trunk/reactos/ntoskrnl/mm/ARM3/pagfault.c trunk/reactos/ntoskrnl/mm/ARM3/pool.c trunk/reactos/ntoskrnl/po/events.c Modified: trunk/reactos/ntoskrnl/mm/ARM3/expool.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/ARM3/expool.c?… ============================================================================== --- trunk/reactos/ntoskrnl/mm/ARM3/expool.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/mm/ARM3/expool.c [iso-8859-1] Wed Sep 11 19:59:59 2013 @@ -1008,9 +1008,9 @@ // // During development, print this out so we can see what's happening // - DPRINT1("EXPOOL: Pool Tracker Table at: 0x%p with 0x%lx bytes\n", + DPRINT("EXPOOL: Pool Tracker Table at: 0x%p with 0x%lx bytes\n", PoolTrackTable, PoolTrackTableSize * sizeof(POOL_TRACKER_TABLE)); - DPRINT1("EXPOOL: Big Pool Tracker Table at: 0x%p with 0x%lx bytes\n", + DPRINT("EXPOOL: Big Pool Tracker Table at: 0x%p with 0x%lx bytes\n", PoolBigPageTable, PoolBigPageTableSize * sizeof(POOL_TRACKER_BIG_PAGES)); // Modified: trunk/reactos/ntoskrnl/mm/ARM3/mminit.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/ARM3/mminit.c?… ============================================================================== --- trunk/reactos/ntoskrnl/mm/ARM3/mminit.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/mm/ARM3/mminit.c [iso-8859-1] Wed Sep 11 19:59:59 2013 @@ -1180,7 +1180,7 @@ } /* Release the PFN lock and flush the TLB */ - DPRINT1("Loader pages freed: %lx\n", LoaderPages); + DPRINT("Loader pages freed: %lx\n", LoaderPages); KeReleaseQueuedSpinLock(LockQueuePfnLock, OldIrql); KeFlushCurrentTb(); Modified: trunk/reactos/ntoskrnl/mm/ARM3/pagfault.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/ARM3/pagfault.… ============================================================================== --- trunk/reactos/ntoskrnl/mm/ARM3/pagfault.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/mm/ARM3/pagfault.c [iso-8859-1] Wed Sep 11 19:59:59 2013 @@ -56,7 +56,7 @@ StackBase = Teb->NtTib.StackBase; DeallocationStack = Teb->DeallocationStack; GuranteedSize = Teb->GuaranteedStackBytes; - DPRINT1("Handling guard page fault with Stacks Addresses 0x%p and 0x%p, guarantee: %lx\n", + DPRINT("Handling guard page fault with Stacks Addresses 0x%p and 0x%p, guarantee: %lx\n", StackBase, DeallocationStack, GuranteedSize); /* Guarantees make this code harder, for now, assume there aren't any */ @@ -101,7 +101,7 @@ if ((NT_SUCCESS(Status) || (Status == STATUS_ALREADY_COMMITTED))) { /* We did it! */ - DPRINT1("Guard page handled successfully for %p\n", Address); + DPRINT("Guard page handled successfully for %p\n", Address); return STATUS_PAGE_FAULT_GUARD_PAGE; } Modified: trunk/reactos/ntoskrnl/mm/ARM3/pool.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/ARM3/pool.c?re… ============================================================================== --- trunk/reactos/ntoskrnl/mm/ARM3/pool.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/mm/ARM3/pool.c [iso-8859-1] Wed Sep 11 19:59:59 2013 @@ -482,7 +482,7 @@ // Get the page bit count // i = ((SizeInPages - 1) / PTE_COUNT) + 1; - DPRINT1("Paged pool expansion: %lu %x\n", i, SizeInPages); + DPRINT("Paged pool expansion: %lu %x\n", i, SizeInPages); // // Check if there is enougn paged pool expansion space left Modified: trunk/reactos/ntoskrnl/po/events.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/po/events.c?rev=6… ============================================================================== --- trunk/reactos/ntoskrnl/po/events.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/po/events.c [iso-8859-1] Wed Sep 11 19:59:59 2013 @@ -264,11 +264,11 @@ /* FIXME: What do do with the capabilities? */ { - DPRINT1("Device capabilities: 0x%x (", Caps); - if (Caps & SYS_BUTTON_POWER) DbgPrint(" POWER"); - if (Caps & SYS_BUTTON_SLEEP) DbgPrint(" SLEEP"); - if (Caps & SYS_BUTTON_LID) DbgPrint(" LID"); - DbgPrint(" )\n"); + DPRINT("Device capabilities: 0x%x (", Caps); + if (Caps & SYS_BUTTON_POWER) DPRINT(" POWER"); + if (Caps & SYS_BUTTON_SLEEP) DPRINT(" SLEEP"); + if (Caps & SYS_BUTTON_LID) DPRINT(" LID"); + DPRINT(" )\n"); } SysButtonContext = ExAllocatePool(NonPagedPool, sizeof(SYS_BUTTON_CONTEXT));

1 0

[ion] 60042: [NPFS-NEW]: ntdll_winetest pipe : 107 tests executed (0 marked as todo, 0 failures), 0 skipped.
by ion＠svn.reactos.org 11 Sep '13

11 Sep '13

Author: ion Date: Wed Sep 11 19:36:51 2013 New Revision: 60042 URL: http://svn.reactos.org/svn/reactos?rev=60042&view=rev Log: [NPFS-NEW]: ntdll_winetest pipe : 107 tests executed (0 marked as todo, 0 failures), 0 skipped. Modified: trunk/reactos/drivers/filesystems/npfs_new/create.c Modified: trunk/reactos/drivers/filesystems/npfs_new/create.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/npfs_n… ============================================================================== --- trunk/reactos/drivers/filesystems/npfs_new/create.c [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/npfs_new/create.c [iso-8859-1] Wed Sep 11 19:36:51 2013 @@ -148,8 +148,8 @@ SeUnlockSubjectContext(SubjectSecurityContext); if (!AccessGranted) return IoStatus; - if (((AccessGranted & FILE_READ_DATA) && (NamedPipeConfiguration == FILE_PIPE_INBOUND)) || - ((AccessGranted & FILE_WRITE_DATA) && (NamedPipeConfiguration == FILE_PIPE_OUTBOUND))) + if (((GrantedAccess & FILE_READ_DATA) && (NamedPipeConfiguration == FILE_PIPE_INBOUND)) || + ((GrantedAccess & FILE_WRITE_DATA) && (NamedPipeConfiguration == FILE_PIPE_OUTBOUND))) { IoStatus.Status = STATUS_ACCESS_DENIED; return IoStatus; @@ -391,7 +391,6 @@ AccessState->RemainingDesiredAccess &= ~(GrantedAccess | 0x2000000); } - ObjectTypeName.Buffer = L"NamedPipe"; ObjectTypeName.Length = 18; SeOpenObjectAuditAlarm(&ObjectTypeName,

1 0

[tfaber] 60041: [CMAKE] - Improve MSVC warning settings
by tfaber＠svn.reactos.org 11 Sep '13

11 Sep '13

Author: tfaber Date: Wed Sep 11 19:25:48 2013 New Revision: 60041 URL: http://svn.reactos.org/svn/reactos?rev=60041&view=rev Log: [CMAKE] - Improve MSVC warning settings Modified: trunk/reactos/cmake/msvc.cmake Modified: trunk/reactos/cmake/msvc.cmake URL: http://svn.reactos.org/svn/reactos/trunk/reactos/cmake/msvc.cmake?rev=60041… ============================================================================== --- trunk/reactos/cmake/msvc.cmake [iso-8859-1] (original) +++ trunk/reactos/cmake/msvc.cmake [iso-8859-1] Wed Sep 11 19:25:48 2013 @@ -23,13 +23,17 @@ add_compile_flags("/X /GR- /EHs-c- /GS- /Zl /W3") # HACK: for VS 11+ we need to explicitly disable SSE, which is off by -# default for older compilers. See bug #7174 +# default for older compilers. See CORE-6507 if (MSVC_VERSION GREATER 1699 AND ARCH STREQUAL "i386") add_compile_flags("/arch:IA32") endif () -# C4700 is almost always likely to result in broken code, so mark it as an error -add_compile_flags("/we4700") +# C++ exception specification ignored... yeah we don't care +add_compile_flags("/wd4290") + +# different level of indirection, void function returning a value and +# uninitialized variable usage should be errors. +add_compile_flags("/we4047 /we4098 /we4700") # Debugging #if(${CMAKE_BUILD_TYPE} STREQUAL "Debug")

1 0

[hbelusca] 60040: [SAC]: Don't return things from a VOID function (MSVC_warning--; )
by hbelusca＠svn.reactos.org 11 Sep '13

11 Sep '13

Author: hbelusca Date: Wed Sep 11 19:23:20 2013 New Revision: 60040 URL: http://svn.reactos.org/svn/reactos?rev=60040&view=rev Log: [SAC]: Don't return things from a VOID function (MSVC_warning--;) Modified: trunk/reactos/drivers/sac/driver/data.c Modified: trunk/reactos/drivers/sac/driver/data.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/sac/driver/data.c?… ============================================================================== --- trunk/reactos/drivers/sac/driver/data.c [iso-8859-1] (original) +++ trunk/reactos/drivers/sac/driver/data.c [iso-8859-1] Wed Sep 11 19:23:20 2013 @@ -28,7 +28,7 @@ WorkerProcessEvents(IN PSAC_DEVICE_EXTENSION DeviceExtension) { /* Call the worker function */ - return ConMgrWorkerProcessEvents(DeviceExtension); + ConMgrWorkerProcessEvents(DeviceExtension); } VOID

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs