Ros-diffs

ros-diffs@reactos.org

81390 discussions

[akhaldi] 58977: [USER32] * Fix some signed/unsigned mismatches. Brought to you by Victor Martinez. CORE-7150 #resolve
by akhaldi＠svn.reactos.org 09 May '13

09 May '13

Author: akhaldi Date: Thu May 9 20:09:31 2013 New Revision: 58977 URL: http://svn.reactos.org/svn/reactos?rev=58977&view=rev Log: [USER32] * Fix some signed/unsigned mismatches. Brought to you by Victor Martinez. CORE-7150 #resolve Modified: trunk/reactos/win32ss/user/user32/windows/menu.c Modified: trunk/reactos/win32ss/user/user32/windows/menu.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/user32/window… ============================================================================== --- trunk/reactos/win32ss/user/user32/windows/menu.c [iso-8859-1] (original) +++ trunk/reactos/win32ss/user/user32/windows/menu.c [iso-8859-1] Thu May 9 20:09:31 2013 @@ -2641,7 +2641,7 @@ static INT FASTCALL MenuButtonUp(MTRACKER *Mt, HMENU PtMenu, UINT Flags) { - UINT Id; + INT Id; ROSMENUINFO MenuInfo; ROSMENUITEMINFO ItemInfo; @@ -2754,7 +2754,7 @@ static BOOL FASTCALL MenuMouseMove(MTRACKER *Mt, HMENU PtMenu, UINT Flags) { - UINT Index; + INT Index; ROSMENUINFO MenuInfo; ROSMENUITEMINFO ItemInfo;

1 0

[ekohl] 58976: [FASTFAT] Allow only readonly, hidden, system and archive files attributes to be set for a new file. Other file attributes must be ignored. This fixes several tests.
by ekohl＠svn.reactos.org 09 May '13

09 May '13

Author: ekohl Date: Thu May 9 15:03:51 2013 New Revision: 58976 URL: http://svn.reactos.org/svn/reactos?rev=58976&view=rev Log: [FASTFAT] Allow only readonly, hidden, system and archive files attributes to be set for a new file. Other file attributes must be ignored. This fixes several tests. Modified: trunk/reactos/drivers/filesystems/fastfat/create.c Modified: trunk/reactos/drivers/filesystems/fastfat/create.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/fastfa… ============================================================================== --- trunk/reactos/drivers/filesystems/fastfat/create.c [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/fastfat/create.c [iso-8859-1] Thu May 9 15:03:51 2013 @@ -545,11 +545,12 @@ RequestedDisposition == FILE_SUPERSEDE) { ULONG Attributes; - Attributes = Stack->Parameters.Create.FileAttributes & ~FILE_ATTRIBUTE_NORMAL; + Attributes = Stack->Parameters.Create.FileAttributes; + Attributes &= (FILE_ATTRIBUTE_READONLY | FILE_ATTRIBUTE_HIDDEN | FILE_ATTRIBUTE_SYSTEM | FILE_ATTRIBUTE_ARCHIVE); vfatSplitPathName(&PathNameU, NULL, &FileNameU); Status = VfatAddEntry (DeviceExt, &FileNameU, &pFcb, ParentFcb, RequestedOptions, - (UCHAR)(Attributes & FILE_ATTRIBUTE_VALID_FLAGS)); + (UCHAR)(Attributes | FILE_ATTRIBUTE_ARCHIVE)); vfatReleaseFCB (DeviceExt, ParentFcb); if (NT_SUCCESS (Status)) {

1 0

[akhaldi] 58975: [ISAPNP] * Add some function annotations. * Fix several debug print specifiers. * Properly mark some unreferenced parameters as such.
by akhaldi＠svn.reactos.org 09 May '13

09 May '13

Author: akhaldi Date: Thu May 9 14:06:21 2013 New Revision: 58975 URL: http://svn.reactos.org/svn/reactos?rev=58975&view=rev Log: [ISAPNP] * Add some function annotations. * Fix several debug print specifiers. * Properly mark some unreferenced parameters as such. Modified: trunk/reactos/drivers/bus/isapnp/fdo.c trunk/reactos/drivers/bus/isapnp/hardware.c trunk/reactos/drivers/bus/isapnp/isapnp.c trunk/reactos/drivers/bus/isapnp/isapnp.h Modified: trunk/reactos/drivers/bus/isapnp/fdo.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/bus/isapnp/fdo.c?r… ============================================================================== --- trunk/reactos/drivers/bus/isapnp/fdo.c [iso-8859-1] (original) +++ trunk/reactos/drivers/bus/isapnp/fdo.c [iso-8859-1] Thu May 9 14:06:21 2013 @@ -18,6 +18,9 @@ { NTSTATUS Status; KIRQL OldIrql; + + UNREFERENCED_PARAMETER(Irp); + UNREFERENCED_PARAMETER(IrpSp); KeAcquireSpinLock(&FdoExt->Lock, &OldIrql); Modified: trunk/reactos/drivers/bus/isapnp/hardware.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/bus/isapnp/hardwar… ============================================================================== --- trunk/reactos/drivers/bus/isapnp/hardware.c [iso-8859-1] (original) +++ trunk/reactos/drivers/bus/isapnp/hardware.c [iso-8859-1] Thu May 9 14:06:21 2013 @@ -319,7 +319,7 @@ INT Csn = 0; USHORT Byte, Data; - DPRINT("Setting read data port: 0x%x\n", ReadDataPort); + DPRINT("Setting read data port: 0x%p\n", ReadDataPort); WaitForKey(); SendKey(); @@ -408,7 +408,7 @@ if (Csn > 0) { - DPRINT("Found %d cards at read port 0x%x\n", Csn, ReadDataPort); + DPRINT("Found %d cards at read port 0x%p\n", Csn, ReadDataPort); } return Csn; @@ -543,7 +543,7 @@ return STATUS_UNSUCCESSFUL; } - DPRINT1("Detected read data port at 0x%x\n", FdoExt->ReadDataPort); + DPRINT1("Detected read data port at 0x%p\n", FdoExt->ReadDataPort); return STATUS_SUCCESS; } Modified: trunk/reactos/drivers/bus/isapnp/isapnp.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/bus/isapnp/isapnp.… ============================================================================== --- trunk/reactos/drivers/bus/isapnp/isapnp.c [iso-8859-1] (original) +++ trunk/reactos/drivers/bus/isapnp/isapnp.c [iso-8859-1] Thu May 9 14:06:21 2013 @@ -9,6 +9,8 @@ #define NDEBUG #include <debug.h> +static IO_COMPLETION_ROUTINE ForwardIrpCompletion; + static NTSTATUS NTAPI @@ -17,6 +19,9 @@ IN PIRP Irp, IN PVOID Context) { + + UNREFERENCED_PARAMETER(DeviceObject); + if (Irp->PendingReturned) KeSetEvent((PKEVENT)Context, IO_NO_INCREMENT, FALSE); @@ -48,6 +53,7 @@ return Status; } +static DRIVER_DISPATCH IsaCreateClose; static NTSTATUS @@ -65,6 +71,8 @@ return STATUS_SUCCESS; } + +static DRIVER_DISPATCH IsaIoctl; static NTSTATUS @@ -91,6 +99,8 @@ return Status; } + +static DRIVER_DISPATCH IsaReadWrite; static NTSTATUS @@ -153,6 +163,8 @@ return STATUS_SUCCESS; } +static DRIVER_DISPATCH IsaPnp; + static NTSTATUS NTAPI Modified: trunk/reactos/drivers/bus/isapnp/isapnp.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/bus/isapnp/isapnp.… ============================================================================== --- trunk/reactos/drivers/bus/isapnp/isapnp.h [iso-8859-1] (original) +++ trunk/reactos/drivers/bus/isapnp/isapnp.h [iso-8859-1] Thu May 9 14:06:21 2013 @@ -40,6 +40,9 @@ } ISAPNP_LOGICAL_DEVICE, *PISAPNP_LOGICAL_DEVICE; /* isapnp.c */ + +DRIVER_INITIALIZE DriverEntry; + NTSTATUS NTAPI DriverEntry(

1 0

[hbelusca] 58974: Merge my current work done on the kd++ branch: - FreeLdr is able now to load personalized Kernel Debugger Transport DLLs by reading at the kernel command line and interpreting the...
by hbelusca＠svn.reactos.org 09 May '13

09 May '13

Author: hbelusca Date: Thu May 9 13:12:58 2013 New Revision: 58974 URL: http://svn.reactos.org/svn/reactos?rev=58974&view=rev Log: Merge my current work done on the kd++ branch: - FreeLdr is able now to load personalized Kernel Debugger Transport DLLs by reading at the kernel command line and interpreting the /DEBUGPORT=xxx entry (--> loads KDxxx.DLL dll in \SystemRoot\System32\). Therefore we can not only load the "default" kdcom.dll, but also 3rd-party ones such as kdbazis.dll from VirtualKD (from revision 58902). - The GCC-compiled-only version of kdcom, containing legacy COM code, was removed and put directly along KDBG. It remains only a stub / template for future kdcom-like dlls. The MSVC-version remains untouched. - Make those functions ^ use directly the CPORTLIB library. Added: trunk/reactos/drivers/base/kdcom/ (props changed) - copied from r58973, branches/kd++/drivers/base/kdcom/ trunk/reactos/drivers/base/kdrosdbg/ (props changed) - copied from r58973, branches/kd++/drivers/base/kdrosdbg/ trunk/reactos/ntoskrnl/kd/arm/ - copied from r58973, branches/kd++/ntoskrnl/kd/arm/ trunk/reactos/ntoskrnl/kd/i386/kdbg.c - copied unchanged from r58973, branches/kd++/ntoskrnl/kd/i386/kdbg.c Removed: trunk/reactos/drivers/base/kddll/ Modified: trunk/reactos/ (props changed) trunk/reactos/boot/freeldr/freeldr/disk/scsiport.c trunk/reactos/boot/freeldr/freeldr/windows/peloader.c trunk/reactos/boot/freeldr/freeldr/windows/winldr.c trunk/reactos/drivers/base/CMakeLists.txt trunk/reactos/include/reactos/windbgkd.h trunk/reactos/ntoskrnl/CMakeLists.txt trunk/reactos/ntoskrnl/include/internal/kd.h trunk/reactos/ntoskrnl/include/internal/tag.h trunk/reactos/ntoskrnl/kd/kdinit.c trunk/reactos/ntoskrnl/kd/kdio.c trunk/reactos/ntoskrnl/kd/wrappers/gdbstub.c trunk/reactos/ntoskrnl/kd/wrappers/gdbstub_powerpc.c trunk/reactos/ntoskrnl/kdbg/kdb.h Propchange: trunk/reactos/ ------------------------------------------------------------------------------ --- svn:mergeinfo (original) +++ svn:mergeinfo Thu May 9 13:12:58 2013 @@ -4,6 +4,7 @@ /branches/GSoC_Network:51545-51546 /branches/cmake-bringup:50484,50693,50719,51544-52564 /branches/header-work:45691-47721 +/branches/kd++:58883-58973 /branches/reactos-yarotows:45219-46371,46373-48025,48027-49273 /branches/reactx/reactos:49994-49995 /branches/ros-amd64-bringup:36852 Modified: trunk/reactos/boot/freeldr/freeldr/disk/scsiport.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/disk/… ============================================================================== --- trunk/reactos/boot/freeldr/freeldr/disk/scsiport.c [iso-8859-1] (original) +++ trunk/reactos/boot/freeldr/freeldr/disk/scsiport.c [iso-8859-1] Thu May 9 13:12:58 2013 @@ -1568,7 +1568,7 @@ ULONG ImportTableSize; PLDR_DATA_TABLE_ENTRY BootDdDTE, FreeldrDTE; CHAR NtBootDdPath[MAX_PATH]; - PVOID ImageBase; + PVOID ImageBase = NULL; ULONG (NTAPI *EntryPoint)(IN PVOID DriverObject, IN PVOID RegistryPath); BOOLEAN Status; Modified: trunk/reactos/boot/freeldr/freeldr/windows/peloader.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/windo… ============================================================================== --- trunk/reactos/boot/freeldr/freeldr/windows/peloader.c [iso-8859-1] (original) +++ trunk/reactos/boot/freeldr/freeldr/windows/peloader.c [iso-8859-1] Thu May 9 13:12:58 2013 @@ -255,11 +255,12 @@ return TRUE; } -/* WinLdrLoadImage loads the specified image from the file (it doesn't - perform any additional operations on the filename, just directly - calls the file I/O routines), and relocates it so that it's ready - to be used when paging is enabled. - Addressing mode: physical +/* + * WinLdrLoadImage loads the specified image from the file (it doesn't + * perform any additional operations on the filename, just directly + * calls the file I/O routines), and relocates it so that it's ready + * to be used when paging is enabled. + * Addressing mode: physical */ BOOLEAN WinLdrLoadImage(IN PCHAR FileName, @@ -429,7 +430,6 @@ /* If loading failed - return right now */ if (Status != ESUCCESS) return FALSE; - /* Relocate the image, if it needs it */ if (NtHeaders->OptionalHeader.ImageBase != (ULONG_PTR)VirtualBase) @@ -756,7 +756,7 @@ { CHAR FullDllName[256]; BOOLEAN Status; - PVOID BasePA; + PVOID BasePA = NULL; /* Prepare the full path to the file to be loaded */ strcpy(FullDllName, DirectoryPath); @@ -781,7 +781,7 @@ DataTableEntry); if (!Status) { - ERR("WinLdrAllocateDataTableEntry() failed with Status=0x%X\n", Status); + ERR("WinLdrAllocateDataTableEntry() failed\n"); return Status; } @@ -791,7 +791,7 @@ Status = WinLdrScanImportDescriptorTable(ModuleListHead, DirectoryPath, *DataTableEntry); if (!Status) { - ERR("WinLdrScanImportDescriptorTable() failed with Status=0x%X\n", Status); + ERR("WinLdrScanImportDescriptorTable() failed\n"); return Status; } Modified: trunk/reactos/boot/freeldr/freeldr/windows/winldr.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/windo… ============================================================================== --- trunk/reactos/boot/freeldr/freeldr/windows/winldr.c [iso-8859-1] (original) +++ trunk/reactos/boot/freeldr/freeldr/windows/winldr.c [iso-8859-1] Thu May 9 13:12:58 2013 @@ -227,7 +227,7 @@ static BOOLEAN WinLdrLoadDeviceDriver(PLIST_ENTRY LoadOrderListHead, - LPSTR BootPath, + LPCSTR BootPath, PUNICODE_STRING FilePath, ULONG Flags, PLDR_DATA_TABLE_ENTRY *DriverDTE) @@ -237,7 +237,7 @@ CHAR DllName[1024]; PCHAR DriverNamePos; BOOLEAN Status; - PVOID DriverBase; + PVOID DriverBase = NULL; // Separate the path to file name and directory path _snprintf(DriverPath, sizeof(DriverPath), "%wZ", FilePath); @@ -258,7 +258,6 @@ } TRACE("DriverPath: %s, DllName: %s, LPB\n", DriverPath, DllName); - // Check if driver is already loaded Status = WinLdrCheckForLoadedDll(LoadOrderListHead, DllName, DriverDTE); @@ -299,7 +298,7 @@ BOOLEAN WinLdrLoadBootDrivers(PLOADER_PARAMETER_BLOCK LoaderBlock, - LPSTR BootPath) + LPCSTR BootPath) { PLIST_ENTRY NextBd; PBOOT_DRIVER_LIST_ENTRY BootDriver; @@ -318,8 +317,11 @@ // Paths are relative (FIXME: Are they always relative?) // Load it - Status = WinLdrLoadDeviceDriver(&LoaderBlock->LoadOrderListHead, BootPath, &BootDriver->FilePath, - 0, &BootDriver->LdrEntry); + Status = WinLdrLoadDeviceDriver(&LoaderBlock->LoadOrderListHead, + BootPath, + &BootDriver->FilePath, + 0, + &BootDriver->LdrEntry); // If loading failed - cry loudly //FIXME: Maybe remove it from the list and try to continue? @@ -340,8 +342,10 @@ return TRUE; } -PVOID WinLdrLoadModule(PCSTR ModuleName, ULONG *Size, - TYPE_OF_MEMORY MemoryType) +PVOID +WinLdrLoadModule(PCSTR ModuleName, + ULONG *Size, + TYPE_OF_MEMORY MemoryType) { ULONG FileId; PVOID PhysicalBase; @@ -398,7 +402,6 @@ return PhysicalBase; } - USHORT WinLdrDetectVersion() { @@ -420,19 +423,20 @@ } static -PVOID +BOOLEAN LoadModule( PLOADER_PARAMETER_BLOCK LoaderBlock, PCCH Path, PCCH File, TYPE_OF_MEMORY MemoryType, PLDR_DATA_TABLE_ENTRY *Dte, + BOOLEAN IsKdTransportDll, ULONG Percentage) { + BOOLEAN Status; CHAR FullFileName[MAX_PATH]; CHAR ProgressString[256]; - NTSTATUS Status; - PVOID BaseAdress; + PVOID BaseAdress = NULL; UiDrawBackdrop(); sprintf(ProgressString, "Loading %s...", File); @@ -443,15 +447,146 @@ strcat(FullFileName, File); Status = WinLdrLoadImage(FullFileName, MemoryType, &BaseAdress); - TRACE("%s loaded with status %d at %p\n", - File, Status, BaseAdress); + if (!Status) + { + TRACE("Loading %s failed\n", File); + return FALSE; + } + TRACE("%s loaded successfully at %p\n", File, BaseAdress); strcpy(FullFileName, "WINDOWS\\SYSTEM32\\"); strcat(FullFileName, File); - WinLdrAllocateDataTableEntry(&LoaderBlock->LoadOrderListHead, File, - FullFileName, BaseAdress, Dte); - - return BaseAdress; + /* + * Cheat about the base DLL name if we are loading + * the Kernel Debugger Transport DLL, to make the + * PE loader happy. + */ + Status = WinLdrAllocateDataTableEntry(&LoaderBlock->LoadOrderListHead, + (IsKdTransportDll ? "KDCOM.DLL" : File), + FullFileName, + BaseAdress, + Dte); + + return Status; +} + +static +BOOLEAN +LoadWindowsCore(IN USHORT OperatingSystemVersion, + IN OUT PLOADER_PARAMETER_BLOCK LoaderBlock, + IN LPCSTR BootOptions, + IN LPCSTR BootPath, + IN OUT PLDR_DATA_TABLE_ENTRY* KernelDTE) +{ + BOOLEAN Status; + CHAR DirPath[MAX_PATH]; + CHAR KdTransportDllName[MAX_PATH]; + PLDR_DATA_TABLE_ENTRY HalDTE, KdComDTE = NULL; + + if (!KernelDTE) return FALSE; + + /* Load the Kernel */ + LoadModule(LoaderBlock, BootPath, "NTOSKRNL.EXE", LoaderSystemCode, KernelDTE, FALSE, 30); + + /* Load the HAL */ + LoadModule(LoaderBlock, BootPath, "HAL.DLL", LoaderHalCode, &HalDTE, FALSE, 45); + + /* Load the Kernel Debugger Transport DLL */ + if (OperatingSystemVersion > _WIN32_WINNT_WIN2K) + { + /* + * According to http://www.nynaeve.net/?p=173 : + * "[...] Another enhancement that could be done Microsoft-side would be + * a better interface for replacing KD transport modules. Right now, due + * to the fact that ntoskrnl is static linked to KDCOM.DLL, the OS loader + * has a hardcoded hack that interprets the KD type in the OS loader options, + * loads one of the (hardcoded filenames) "kdcom.dll", "kd1394.dll", or + * "kdusb2.dll" modules, and inserts them into the loaded module list under + * the name "kdcom.dll". [...]" + */ + + /* + * This loop replaces a dumb call to strstr(..., "DEBUGPORT="). + * Indeed I want it to be case-insensitive to allow "debugport=" + * or "DeBuGpOrT=" or... , and I don't want it to match malformed + * command-line options, such as: + * + * "...foo DEBUGPORT=xxx bar..." + * "...foo/DEBUGPORT=xxx bar..." + * "...foo/DEBUGPORT=bar..." + * + * i.e. the "DEBUGPORT=" switch must start with a slash and be separated + * from the rest by whitespace, unless it begins the command-line, e.g.: + * + * "/DEBUGPORT=COM1 foo...bar..." + * "...foo /DEBUGPORT=USB bar..." + * or: + * "...foo /DEBUGPORT= bar..." + * (in that case, we default the port to COM). + */ + while (BootOptions) + { + /* Skip possible initial whitespace */ + BootOptions += strspn(BootOptions, " \t"); + + /* Check whether a new commutator starts and it is the DEBUGPORT one */ + if (*BootOptions != '/' || _strnicmp(++BootOptions, "DEBUGPORT=", 10) != 0) + { + /* Search for another whitespace */ + BootOptions = strpbrk(BootOptions, " \t"); + continue; + } + else + { + /* We found the DEBUGPORT commutator. Move to the port name. */ + BootOptions += 10; + break; + } + } + + if (BootOptions) + { + /* + * We have found the DEBUGPORT commutator. Parse the port name. + * Format: /DEBUGPORT=COM1 or /DEBUGPORT=FILE:\Device\HarddiskX\PartitionY\debug.log or /DEBUGPORT=FOO + * If we only have /DEBUGPORT= (i.e. without any port name), defaults it to "COM". + */ + strcpy(KdTransportDllName, "KD"); + if (_strnicmp(BootOptions, "COM", 3) == 0 && '0' <= BootOptions[3] && BootOptions[3] <= '9') + { + strncat(KdTransportDllName, BootOptions, 3); + } + else + { + size_t i = strcspn(BootOptions, " \t:"); /* Skip valid separators: whitespace or colon */ + if (i == 0) + strcat(KdTransportDllName, "COM"); + else + strncat(KdTransportDllName, BootOptions, i); + } + strcat(KdTransportDllName, ".DLL"); + _strupr(KdTransportDllName); + + /* + * Load the transport DLL. Specify it to LoadModule so that it can + * change the base DLL name of the loaded transport DLL to the default + * "KDCOM.DLL" name, to make the PE loader happy. + */ + LoadModule(LoaderBlock, BootPath, KdTransportDllName, LoaderSystemCode, &KdComDTE, TRUE, 60); + } + } + + /* Load all referenced DLLs for Kernel, HAL and Kernel Debugger Transport DLL */ + strcpy(DirPath, BootPath); + strcat(DirPath, "system32\\"); + Status = WinLdrScanImportDescriptorTable(&LoaderBlock->LoadOrderListHead, DirPath, *KernelDTE); + Status &= WinLdrScanImportDescriptorTable(&LoaderBlock->LoadOrderListHead, DirPath, HalDTE); + if (KdComDTE) + { + Status &= WinLdrScanImportDescriptorTable(&LoaderBlock->LoadOrderListHead, DirPath, KdComDTE); + } + + return Status; } VOID @@ -496,7 +631,7 @@ strcat(BootPath, FileName); } - /* append a backslash */ + /* Append a backslash */ if ((strlen(BootPath)==0) || BootPath[strlen(BootPath)] != '\\') strcat(BootPath, "\\"); @@ -547,13 +682,13 @@ UiDrawBackdrop(); UiDrawProgressBarCenter(15, 100, "Loading system hive..."); Status = WinLdrInitSystemHive(LoaderBlock, BootPath); - TRACE("SYSTEM hive loaded with status %d\n", Status); + TRACE("SYSTEM hive %s\n", (Status ? "loaded" : "not loaded")); /* Load NLS data, OEM font, and prepare boot drivers list */ Status = WinLdrScanSystemHive(LoaderBlock, BootPath); - TRACE("SYSTEM hive scanned with status %d\n", Status); - - + TRACE("SYSTEM hive %s\n", (Status ? "scanned" : "not scanned")); + + /* Finish loading */ LoadAndBootWindowsCommon(OperatingSystemVersion, LoaderBlock, BootOptions, @@ -571,8 +706,7 @@ { PLOADER_PARAMETER_BLOCK LoaderBlockVA; BOOLEAN Status; - CHAR FileName[MAX_PATH]; - PLDR_DATA_TABLE_ENTRY KernelDTE, HalDTE, KdComDTE = NULL; + PLDR_DATA_TABLE_ENTRY KernelDTE; KERNEL_ENTRY_POINT KiSystemStartup; LPCSTR SystemRoot; TRACE("LoadAndBootWindowsCommon()\n"); @@ -586,40 +720,30 @@ if (OperatingSystemVersion == 0) OperatingSystemVersion = WinLdrDetectVersion(); - /* Load kernel */ - LoadModule(LoaderBlock, BootPath, "NTOSKRNL.EXE", LoaderSystemCode, &KernelDTE, 30); - - /* Load HAL */ - LoadModule(LoaderBlock, BootPath, "HAL.DLL", LoaderHalCode, &HalDTE, 45); - - /* Load kernel-debugger support dll */ - if (OperatingSystemVersion > _WIN32_WINNT_WIN2K) - { - LoadModule(LoaderBlock, BootPath, "KDCOM.DLL", LoaderSystemCode, &KdComDTE, 60); - } - - /* Load all referenced DLLs for kernel, HAL and kdcom.dll */ - strcpy(FileName, BootPath); - strcat(FileName, "system32\\"); - Status = WinLdrScanImportDescriptorTable(&LoaderBlock->LoadOrderListHead, FileName, KernelDTE); - Status &= WinLdrScanImportDescriptorTable(&LoaderBlock->LoadOrderListHead, FileName, HalDTE); - if (KdComDTE) - Status &= WinLdrScanImportDescriptorTable(&LoaderBlock->LoadOrderListHead, FileName, KdComDTE); - + /* Load the operating system core: the Kernel, the HAL and the Kernel Debugger Transport DLL */ + Status = LoadWindowsCore(OperatingSystemVersion, + LoaderBlock, + BootOptions, + BootPath, + &KernelDTE); if (!Status) { - UiMessageBox("Error loading imported dll."); + UiMessageBox("Error loading NTOS core."); return; } /* Load boot drivers */ UiDrawBackdrop(); UiDrawProgressBarCenter(100, 100, "Loading boot drivers..."); - Status = WinLdrLoadBootDrivers(LoaderBlock, (PCHAR)BootPath); + Status = WinLdrLoadBootDrivers(LoaderBlock, BootPath); TRACE("Boot drivers loaded with status %d\n", Status); /* Initialize Phase 1 - no drivers loading anymore */ - WinLdrInitializePhase1(LoaderBlock, BootOptions, SystemRoot, BootPath, OperatingSystemVersion); + WinLdrInitializePhase1(LoaderBlock, + BootOptions, + SystemRoot, + BootPath, + OperatingSystemVersion); /* Save entry-point pointer and Loader block VAs */ KiSystemStartup = (KERNEL_ENTRY_POINT)KernelDTE->EntryPoint; @@ -644,7 +768,7 @@ LoaderBlock->Extension->LoaderPagesSpanned = LoaderPagesSpanned; TRACE("Hello from paged mode, KiSystemStartup %p, LoaderBlockVA %p!\n", - KiSystemStartup, LoaderBlockVA); + KiSystemStartup, LoaderBlockVA); // Zero KI_USER_SHARED_DATA page memset((PVOID)KI_USER_SHARED_DATA, 0, MM_PAGE_SIZE); @@ -722,5 +846,3 @@ NextBd = ArcDisk->ListEntry.Flink; } } - - Modified: trunk/reactos/drivers/base/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/base/CMakeLists.tx… ============================================================================== --- trunk/reactos/drivers/base/CMakeLists.txt [iso-8859-1] (original) +++ trunk/reactos/drivers/base/CMakeLists.txt [iso-8859-1] Thu May 9 13:12:58 2013 @@ -3,9 +3,10 @@ add_subdirectory(bootvid) if(_WINKD_) -add_subdirectory(kddll) +add_subdirectory(kdcom) else() -add_subdirectory(kdcom) +add_subdirectory(kdrosdbg) endif() + add_subdirectory(nmidebug) add_subdirectory(null) Propchange: trunk/reactos/drivers/base/kdcom/ ------------------------------------------------------------------------------ --- bugtraq:logregex (added) +++ bugtraq:logregex Thu May 9 13:12:58 2013 @@ -0,0 +1,2 @@ +([Ii]ssue|[Bb]ug)s? #?(\d+)(,? ?#?(\d+))*(,? ?(and |or )?#?(\d+))? +(\d+) Propchange: trunk/reactos/drivers/base/kdcom/ ------------------------------------------------------------------------------ bugtraq:message = See issue #%BUGID% for more details. Propchange: trunk/reactos/drivers/base/kdcom/ ------------------------------------------------------------------------------ bugtraq:url = http://www.reactos.org/bugzilla/show_bug.cgi?id=%BUGID% Propchange: trunk/reactos/drivers/base/kdcom/ ------------------------------------------------------------------------------ tsvn:logminsize = 10 Propchange: trunk/reactos/drivers/base/kdrosdbg/ ------------------------------------------------------------------------------ --- svn:ignore (added) +++ svn:ignore Thu May 9 13:12:58 2013 @@ -0,0 +1,7 @@ +GNUmakefile +*.vcproj +*.user +*.cbp +*.ncb +*.suo +*.sln Modified: trunk/reactos/include/reactos/windbgkd.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/reactos/windbgkd.h… ============================================================================== --- trunk/reactos/include/reactos/windbgkd.h [iso-8859-1] (original) +++ trunk/reactos/include/reactos/windbgkd.h [iso-8859-1] Thu May 9 13:12:58 2013 @@ -451,7 +451,7 @@ ULONG Thread; ULONG ProgramCounter; union - { + { DBGKM_EXCEPTION32 Exception; DBGKD_LOAD_SYMBOLS32 LoadSymbols; } u; @@ -481,13 +481,13 @@ ULONG64 Thread; ULONG64 ProgramCounter; union - { + { DBGKM_EXCEPTION64 Exception; DBGKD_LOAD_SYMBOLS64 LoadSymbols; DBGKD_COMMAND_STRING CommandString; } u; union - { + { DBGKD_CONTROL_REPORT ControlReport; DBGKD_ANY_CONTROL_REPORT AnyControlReport; }; @@ -814,7 +814,7 @@ ULONG ApiNumber; ULONG Status; union - { + { ULONG64 ReserveSpace[7]; DBGKD_CREATE_FILE CreateFile; DBGKD_READ_FILE ReadFile; @@ -843,7 +843,7 @@ { ULONG ApiNumber; union - { + { DBGKD_REQUEST_BREAKPOINT RequestBreakpoint; DBGKD_RELEASE_BREAKPOINT ReleaseBreakpoint; } u; Modified: trunk/reactos/ntoskrnl/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/CMakeLists.txt?re… ============================================================================== --- trunk/reactos/ntoskrnl/CMakeLists.txt [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/CMakeLists.txt [iso-8859-1] Thu May 9 13:12:58 2013 @@ -363,6 +363,7 @@ if(NOT _WINKD_) if(ARCH STREQUAL "i386") list(APPEND SOURCE + kd/i386/kdbg.c kd/i386/kdmemsup.c kd/wrappers/gdbstub.c) if(KDBG) @@ -372,6 +373,7 @@ elseif(ARCH STREQUAL "amd64") list(APPEND SOURCE kd/amd64/kd.c + kd/i386/kdbg.c # Use the x86 file kd/amd64/kdmemsup.c) if(KDBG) list(APPEND ASM_SOURCE kdbg/amd64/kdb_help.S) @@ -379,6 +381,8 @@ kdbg/amd64/i386-dis.c kdbg/amd64/kdb.c) endif() + elseif(ARCH STREQUAL "arm") + list(APPEND SOURCE kd/arm/kdbg.c) elseif(ARCH STREQUAL "powerpc") list(APPEND SOURCE kd/wrappers/gdbstub_powerpc.c) endif() Modified: trunk/reactos/ntoskrnl/include/internal/kd.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/include/internal/… ============================================================================== --- trunk/reactos/ntoskrnl/include/internal/kd.h [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/include/internal/kd.h [iso-8859-1] Thu May 9 13:12:58 2013 @@ -1,4 +1,6 @@ #pragma once + +#include <cportlib/cportlib.h> #ifdef _M_PPC #define KdDebuggerEnabled _KdDebuggerEnabled @@ -8,15 +10,8 @@ // // Kernel Debugger Port Definition // -typedef struct _KD_PORT_INFORMATION -{ - ULONG ComPort; - ULONG BaudRate; - ULONG BaseAddress; -} KD_PORT_INFORMATION, *PKD_PORT_INFORMATION; - struct _KD_DISPATCH_TABLE; -extern KD_PORT_INFORMATION GdbPortInfo; +extern CPPORT GdbPortInfo; extern BOOLEAN _KdDebuggerEnabled; extern BOOLEAN _KdDebuggerNotPresent; extern BOOLEAN KdBreakAfterSymbolLoad; @@ -25,41 +20,21 @@ BOOLEAN NTAPI -KdPortInitialize( - PKD_PORT_INFORMATION PortInformation, - ULONG Unknown1, - ULONG Unknown2 -); - -BOOLEAN -NTAPI KdPortInitializeEx( - PKD_PORT_INFORMATION PortInformation, - ULONG Unknown1, - ULONG Unknown2 -); - -BOOLEAN -NTAPI -KdPortGetByte( + PCPPORT PortInformation, + ULONG ComPortNumber +); + +BOOLEAN +NTAPI +KdPortGetByteEx( + PCPPORT PortInformation, PUCHAR ByteReceived); -BOOLEAN -NTAPI -KdPortGetByteEx( - PKD_PORT_INFORMATION PortInformation, - PUCHAR ByteReceived); - -VOID -NTAPI -KdPortPutByte( - UCHAR ByteToSend -); - VOID NTAPI KdPortPutByteEx( - PKD_PORT_INFORMATION PortInformation, + PCPPORT PortInformation, UCHAR ByteToSend ); @@ -359,7 +334,8 @@ extern ULONG KdpPort; /* Port Information for the Serial Native Mode */ -extern KD_PORT_INFORMATION SerialPortInfo; +extern ULONG SerialPortNumber; +extern CPPORT SerialPortInfo; /* Init Functions for Native Providers */ extern PKDP_INIT_ROUTINE InitRoutines[KdMax]; Modified: trunk/reactos/ntoskrnl/include/internal/tag.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/include/internal/… ============================================================================== --- trunk/reactos/ntoskrnl/include/internal/tag.h [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/include/internal/tag.h [iso-8859-1] Thu May 9 13:12:58 2013 @@ -95,10 +95,6 @@ #define TAG_VPB ' BPV' #define TAG_SYSB 'BSYS' -/* formerly located in kdbg/kdb_symbols.c */ -#define TAG_KDBS 'SBDK' -#define TAG_KDBG 'GBDK' - /* formerly located in ldr/loader.c */ #define TAG_DRIVER_MEM 'MVRD' /* drvm */ #define TAG_MODULE_OBJECT 'omlk' /* klmo - kernel ldr module object */ Modified: trunk/reactos/ntoskrnl/kd/kdinit.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/kd/kdinit.c?rev=5… ============================================================================== --- trunk/reactos/ntoskrnl/kd/kdinit.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/kd/kdinit.c [iso-8859-1] Thu May 9 13:12:58 2013 @@ -16,7 +16,8 @@ /* VARIABLES ***************************************************************/ -KD_PORT_INFORMATION PortInfo = {DEFAULT_DEBUG_PORT, DEFAULT_DEBUG_BAUD_RATE, 0}; +ULONG PortNumber = DEFAULT_DEBUG_PORT; +CPPORT PortInfo = {0, DEFAULT_DEBUG_BAUD_RATE, 0}; ULONG KdpPortIrq; #ifdef AUTO_ENABLE_BOCHS KDP_DEBUG_MODE KdpDebugMode = {{{.Bochs=TRUE}}}; @@ -68,7 +69,7 @@ KdpDebugMode.Serial = TRUE; /* Set the port to use */ - SerialPortInfo.ComPort = Value; + SerialPortNumber = Value; KdpPort = Value; } } @@ -78,8 +79,8 @@ if (Value) { KdpDebugMode.Serial = TRUE; - SerialPortInfo.BaseAddress = Value; - SerialPortInfo.ComPort = 0; + SerialPortInfo.Address = UlongToPtr(Value); + SerialPortNumber = 0; KdpPort = 0; } } Modified: trunk/reactos/ntoskrnl/kd/kdio.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/kd/kdio.c?rev=589… ============================================================================== --- trunk/reactos/ntoskrnl/kd/kdio.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/kd/kdio.c [iso-8859-1] Thu May 9 13:12:58 2013 @@ -26,7 +26,8 @@ ANSI_STRING KdpLogFileName = RTL_CONSTANT_STRING("\\SystemRoot\\debug.log"); KSPIN_LOCK KdpSerialSpinLock; -KD_PORT_INFORMATION SerialPortInfo = { DEFAULT_DEBUG_PORT, DEFAULT_DEBUG_BAUD_RATE, 0 }; +ULONG SerialPortNumber = DEFAULT_DEBUG_PORT; +CPPORT SerialPortInfo = {0, DEFAULT_DEBUG_BAUD_RATE, 0}; /* Current Port in use. FIXME: Do we support more then one? */ ULONG KdpPort; @@ -358,12 +359,12 @@ DispatchTable->KdpPrintRoutine = KdpSerialDebugPrint; /* Initialize the Port */ - if (!KdPortInitializeEx(&SerialPortInfo, 0, 0)) + if (!KdPortInitializeEx(&SerialPortInfo, SerialPortNumber)) { KdpDebugMode.Serial = FALSE; return; } - KdComPortInUse = (PUCHAR)(ULONG_PTR)SerialPortInfo.BaseAddress; + KdComPortInUse = SerialPortInfo.Address; /* Initialize spinlock */ KeInitializeSpinLock(&KdpSerialSpinLock); Modified: trunk/reactos/ntoskrnl/kd/wrappers/gdbstub.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/kd/wrappers/gdbst… ============================================================================== --- trunk/reactos/ntoskrnl/kd/wrappers/gdbstub.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/kd/wrappers/gdbstub.c [iso-8859-1] Thu May 9 13:12:58 2013 @@ -44,7 +44,8 @@ extern LIST_ENTRY PsActiveProcessHead; /* FIXME hardcoded for COM2, 115200 baud */ -KD_PORT_INFORMATION GdbPortInfo = { 2, 115200, 0 }; +ULONG GdbPortNumber = DEFAULT_DEBUG_PORT; +CPPORT GdbPortInfo = {0, DEFAULT_DEBUG_BAUD_RATE, 0}; static CHAR GspInBuffer[1000]; static CHAR GspOutBuffer[1000]; @@ -126,9 +127,7 @@ { UCHAR Value; - while (!KdPortGetByteEx(&GdbPortInfo, &Value)) - ; - + while (!KdPortGetByteEx(&GdbPortInfo, &Value)) ; return Value; } @@ -145,8 +144,7 @@ while (TRUE) { /* wait around for the start character, ignore all other characters */ - while ((ch = GdbGetChar()) != '$') - ; + while ((ch = GdbGetChar()) != '$') ; retry: Checksum = 0; @@ -784,7 +782,6 @@ } else if (strncmp(Request, "Rcmd,", 5) == 0) { - ; } } @@ -943,12 +940,14 @@ ULONG Index; for (Index = 0; Index < GspSwBreakpointCount; Index++) + { if (GspSwBreakpoints[Index].Address == Address) { if (PIndex) *PIndex = Index; return TRUE; } + } return FALSE; } @@ -1569,7 +1568,7 @@ WrapperTable->KdpExceptionRoutine = KdpGdbEnterDebuggerException; /* Initialize the Port */ - KdPortInitializeEx(&GdbPortInfo, 0, 0); + KdPortInitializeEx(&GdbPortInfo, GdbPortNumber); } else if (BootPhase == 1) { Modified: trunk/reactos/ntoskrnl/kd/wrappers/gdbstub_powerpc.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/kd/wrappers/gdbst… ============================================================================== --- trunk/reactos/ntoskrnl/kd/wrappers/gdbstub_powerpc.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/kd/wrappers/gdbstub_powerpc.c [iso-8859-1] Thu May 9 13:12:58 2013 @@ -88,44 +88,47 @@ #include <debug.h> /************************************************************************/ + +static BOOLEAN GspInitialized; +static BOOLEAN GspRemoteDebug; + +static CONST CHAR HexChars[]="0123456789abcdef"; + +static PETHREAD GspRunThread; /* NULL means run all threads */ +static PETHREAD GspDbgThread; +static PETHREAD GspEnumThread; + +static FAST_MUTEX GspLock; + +extern LIST_ENTRY PsActiveProcessHead; + +/* FIXME hardcoded for COM2, 115200 baud */ +ULONG GdbPortNumber = DEFAULT_DEBUG_PORT; +CPPORT GdbPortInfo = {0, DEFAULT_DEBUG_BAUD_RATE, 0}; + /* BUFMAX defines the maximum number of characters in inbound/outbound buffers*/ /* at least NUMREGBYTES*2 are needed for register packets */ #define BUFMAX 1000 - -static BOOLEAN GspInitialized; - -static BOOLEAN GspRemoteDebug; - -static CONST CHAR HexChars[]="0123456789abcdef"; - -static PETHREAD GspRunThread; /* NULL means run all threads */ -static PETHREAD GspDbgThread; -static PETHREAD GspEnumThread; - -static FAST_MUTEX GspLock; - -extern LIST_ENTRY PsActiveProcessHead; - -/* FIXME hardcoded for COM2, 115200 baud */ -KD_PORT_INFORMATION GdbPortInfo = { 2, 115200, 0 }; +static CHAR GspInBuffer[BUFMAX]; +static CHAR GspOutBuffer[BUFMAX]; /* Number of Registers. */ #define NUMREGS 16 enum REGISTER_NAMES { - EAX, ECX, EDX, EBX, ESP, EBP, ESI, EDI, - PC /* also known as eip */, - PS /* also known as eflags */, - CS, SS, DS, ES, FS, GS + EAX, ECX, EDX, EBX, ESP, EBP, ESI, EDI, + PC /* also known as eip */, + PS /* also known as eflags */, + CS, SS, DS, ES, FS, GS }; typedef struct _CPU_REGISTER { - ULONG Size; - ULONG OffsetInTF; - ULONG OffsetInContext; - BOOLEAN SetInContext; + ULONG Size; + ULONG OffsetInTF; + ULONG OffsetInContext; + BOOLEAN SetInContext; } CPU_REGISTER, *PCPU_REGISTER; static CPU_REGISTER GspRegisters[NUMREGS] = @@ -134,54 +137,45 @@ static PCHAR GspThreadStates[DeferredReady+1] = { - "Initialized", - "Ready", - "Running", - "Standby", - "Terminated", - "Waiting", - "Transition", - "DeferredReady" + "Initialized", + "Ready", + "Running", + "Standby", + "Terminated", + "Waiting", + "Transition", + "DeferredReady" }; LONG HexValue(CHAR ch) { - if ((ch >= '0') && (ch <= '9')) - { - return (ch - '0'); - } - if ((ch >= 'a') && (ch <= 'f')) - { - return (ch - 'a' + 10); - } - if ((ch >= 'A') && (ch <= 'F')) - { - return (ch - 'A' + 10); - } - - return -1; -} - -static CHAR GspInBuffer[BUFMAX]; -static CHAR GspOutBuffer[BUFMAX]; + if ((ch >= '0') && (ch <= '9')) + return (ch - '0'); + + if ((ch >= 'a') && (ch <= 'f')) + return (ch - 'a' + 10); + + if ((ch >= 'A') && (ch <= 'F')) + return (ch - 'A' + 10); + + return -1; +} VOID GdbPutChar(UCHAR Value) { - KdPortPutByteEx(&GdbPortInfo, Value); + KdPortPutByteEx(&GdbPortInfo, Value); } UCHAR GdbGetChar(VOID) { - UCHAR Value; - - while (!KdPortGetByteEx(&GdbPortInfo, &Value)) - ; - - return Value; + UCHAR Value; + + while (!KdPortGetByteEx(&GdbPortInfo, &Value)) ; + return Value; } /* scan for the sequence $<data>#<Checksum> */ @@ -189,57 +183,53 @@ PCHAR GspGetPacket() { - PCHAR Buffer = &GspInBuffer[0]; - CHAR Checksum; - CHAR XmitChecksum; - ULONG Count; - CHAR ch; - - while (TRUE) - { - /* wait around for the start character, ignore all other characters */ - while ((ch = GdbGetChar ()) != '$') - ; - - retry: - Checksum = 0; - XmitChecksum = -1; - Count = 0; - - /* now, read until a # or end of Buffer is found */ - while (Count < BUFMAX) - { - ch = GdbGetChar(); - if (ch == '$') - { - goto retry; - } - if (ch == '#') - { - break; - } - Checksum = Checksum + ch; - Buffer[Count] = ch; - Count = Count + 1; - } - Buffer[Count] = 0; - - if (ch == '#') - { - ch = GdbGetChar(); - XmitChecksum = (CHAR)(HexValue(ch) << 4); - ch = GdbGetChar(); - XmitChecksum += (CHAR)(HexValue(ch)); - - if (Checksum != XmitChecksum) - { - GdbPutChar('-'); /* failed checksum */ - } - else - { - GdbPutChar('+'); /* successful transfer */ - - return &Buffer[0]; + PCHAR Buffer = &GspInBuffer[0]; + CHAR Checksum; + CHAR XmitChecksum; + ULONG Count; + CHAR ch; + + while (TRUE) + { + /* wait around for the start character, ignore all other characters */ + while ((ch = GdbGetChar ()) != '$') ; + +retry: + Checksum = 0; + XmitChecksum = -1; + Count = 0; + + /* now, read until a # or end of Buffer is found */ + while (Count < BUFMAX) + { + ch = GdbGetChar(); + if (ch == '$') + goto retry; + + if (ch == '#') + break; + + Checksum = Checksum + ch; + Buffer[Count] = ch; + Count = Count + 1; + } + Buffer[Count] = 0; + + if (ch == '#') + { + ch = GdbGetChar(); + XmitChecksum = (CHAR)(HexValue(ch) << 4); + ch = GdbGetChar(); + XmitChecksum += (CHAR)(HexValue(ch)); + + if (Checksum != XmitChecksum) + { + GdbPutChar('-'); /* failed checksum */ + } + else + { + GdbPutChar('+'); /* successful transfer */ + return &Buffer[0]; } } } @@ -250,54 +240,54 @@ VOID GspPutPacket(PCHAR Buffer) { - CHAR Checksum; - LONG Count; - CHAR ch; - - /* $<packet info>#<Checksum>. */ - do - { - GdbPutChar('$'); - Checksum = 0; - Count = 0; - - while ((ch = Buffer[Count])) - { - GdbPutChar(ch); - Checksum += ch; - Count += 1; - } - - GdbPutChar('#'); - GdbPutChar(HexChars[(Checksum >> 4) & 0xf]); - GdbPutChar(HexChars[Checksum & 0xf]); - } - while (GdbGetChar() != '+'); + CHAR Checksum; + LONG Count; + CHAR ch; + + /* $<packet info>#<Checksum>. */ + do + { + GdbPutChar('$'); + Checksum = 0; + Count = 0; + + while ((ch = Buffer[Count])) + { + GdbPutChar(ch); + Checksum += ch; + Count += 1; + } + + GdbPutChar('#'); + GdbPutChar(HexChars[(Checksum >> 4) & 0xf]); + GdbPutChar(HexChars[Checksum & 0xf]); + } + while (GdbGetChar() != '+'); } VOID GspPutPacketNoWait(PCHAR Buffer) { - CHAR Checksum; - LONG Count; - CHAR ch; - - /* $<packet info>#<Checksum>. */ - GdbPutChar('$'); - Checksum = 0; - Count = 0; - - while ((ch = Buffer[Count])) - { - GdbPutChar(ch); - Checksum += ch; - Count += 1; - } - - GdbPutChar('#'); - GdbPutChar(HexChars[(Checksum >> 4) & 0xf]); - GdbPutChar(HexChars[Checksum & 0xf]); + CHAR Checksum; + LONG Count; + CHAR ch; + + /* $<packet info>#<Checksum>. */ + GdbPutChar('$'); + Checksum = 0; + Count = 0; + + while ((ch = Buffer[Count])) + { + GdbPutChar(ch); + Checksum += ch; + Count += 1; + } + + GdbPutChar('#'); + GdbPutChar(HexChars[(Checksum >> 4) & 0xf]); + GdbPutChar(HexChars[Checksum & 0xf]); } /* Indicate to caller of GspMem2Hex or GspHex2Mem that there has been an @@ -308,19 +298,33 @@ static CHAR GspReadMemSafe(PCHAR Address) { - CHAR ch; - - if (NULL == Address) - { - GspMemoryError = TRUE; - return '\0'; - } - - GspAccessLocation = Address; - ch = *Address; - GspAccessLocation = NULL; - - return ch; + CHAR ch; + + if (NULL == Address) + { + GspMemoryError = TRUE; + return '\0'; + } + + GspAccessLocation = Address; + ch = *Address; + GspAccessLocation = NULL; + + return ch; +} + +static CHAR +GspWriteMemSafeGetContent(PVOID Context, ULONG Offset) +{ + ASSERT(0 == Offset); + return *((PCHAR) Context); +} + +static void +GspWriteMemSafe(PCHAR Address, + CHAR Ch) +{ + GspWriteMem(Address, 1, TRUE, GspWriteMemSafeGetContent, &Ch); } /* Convert the memory pointed to by Address into hex, placing result in Buffer */ @@ -329,131 +333,110 @@ a fault; if FALSE treat a fault like any other fault in the stub. */ static PCHAR GspMem2Hex(PCHAR Address, - PCHAR Buffer, - LONG Count, - BOOLEAN MayFault) -{ - ULONG i; - CHAR ch; - - for (i = 0; i < (ULONG) Count; i++) - { - if (MayFault) - { - ch = GspReadMemSafe(Address); - if (GspMemoryError) - { - return Buffer; - } - } - else - { - ch = *Address; - } - *Buffer++ = HexChars[(ch >> 4) & 0xf]; - *Buffer++ = HexChars[ch & 0xf]; - Address++; - } - - *Buffer = 0; - return Buffer; + PCHAR Buffer, + LONG Count, + BOOLEAN MayFault) +{ + ULONG i; + CHAR ch; + + for (i = 0; i < (ULONG) Count; i++) + { + if (MayFault) + { + ch = GspReadMemSafe(Address); + if (GspMemoryError) + return Buffer; + } + else + { + ch = *Address; + } + *Buffer++ = HexChars[(ch >> 4) & 0xf]; + *Buffer++ = HexChars[ch & 0xf]; + Address++; + } + + *Buffer = 0; + return Buffer; } static ULONG GspWriteMem(PCHAR Address, - ULONG Count, - BOOLEAN MayFault, - CHAR (*GetContent)(PVOID Context, ULONG Offset), - PVOID Context) -{ - PCHAR Current; - PCHAR Page; - ULONG CountInPage; - ULONG i; - CHAR ch; - ULONG OldProt = 0; - - Current = Address; - while (Current < Address + Count) - { - Page = (PCHAR)PAGE_ROUND_DOWN(Current); - if (Address + Count <= Page + PAGE_SIZE) - { - /* Fits in this page */ - CountInPage = Count; - } - else - { - /* Flows into next page, handle only current page in this iteration */ - CountInPage = PAGE_SIZE - (Address - Page); - } - if (MayFault) - { - OldProt = MmGetPageProtect(NULL, Address); - MmSetPageProtect(NULL, Address, PAGE_EXECUTE_READWRITE); - } - - for (i = 0; i < CountInPage && ! GspMemoryError; i++) - { - ch = (*GetContent)(Context, Current - Address); - - if (MayFault) - { - GspAccessLocation = Current; - } - *Current = ch; - if (MayFault) - { - GspAccessLocation = NULL; - } - Current++; - } - if (MayFault) - { - MmSetPageProtect(NULL, Page, OldProt); - if (GspMemoryError) - { - return Current - Address; - } - } - } - - return Current - Address; + ULONG Count, + BOOLEAN MayFault, + CHAR (*GetContent)(PVOID Context, ULONG Offset), + PVOID Context) +{ + PCHAR Current; + PCHAR Page; + ULONG CountInPage; + ULONG i; + CHAR ch; + ULONG OldProt = 0; + + Current = Address; + while (Current < Address + Count) + { + Page = (PCHAR)PAGE_ROUND_DOWN(Current); + if (Address + Count <= Page + PAGE_SIZE) + { + /* Fits in this page */ + CountInPage = Count; + } + else + { + /* Flows into next page, handle only current page in this iteration */ + CountInPage = PAGE_SIZE - (Address - Page); + } + if (MayFault) + { + OldProt = MmGetPageProtect(NULL, Address); + MmSetPageProtect(NULL, Address, PAGE_EXECUTE_READWRITE); + } + + for (i = 0; i < CountInPage && ! GspMemoryError; i++) + { + ch = (*GetContent)(Context, Current - Address); + + if (MayFault) + GspAccessLocation = Current; + + *Current = ch; + + if (MayFault) + GspAccessLocation = NULL; + + Current++; + } + if (MayFault) + { + MmSetPageProtect(NULL, Page, OldProt); + if (GspMemoryError) + return Current - Address; + } + } + + return Current - Address; } static CHAR GspHex2MemGetContent(PVOID Context, ULONG Offset) { - return (CHAR)((HexValue(*((PCHAR) Context + 2 * Offset)) << 4) + - HexValue(*((PCHAR) Context + 2 * Offset + 1))); + return (CHAR)((HexValue(*((PCHAR) Context + 2 * Offset)) << 4) + + HexValue(*((PCHAR) Context + 2 * Offset + 1))); } /* Convert the hex array pointed to by Buffer into binary to be placed at Address */ /* Return a pointer to the character AFTER the last byte read from Buffer */ static PCHAR GspHex2Mem(PCHAR Buffer, - PCHAR Address, - ULONG Count, - BOOLEAN MayFault) -{ - Count = GspWriteMem(Address, Count, MayFault, GspHex2MemGetContent, Buffer); - - return Buffer + 2 * Count; -} - -static CHAR -GspWriteMemSafeGetContent(PVOID Context, ULONG Offset) -{ - ASSERT(0 == Offset); - - return *((PCHAR) Context); -} - -static void -GspWriteMemSafe(PCHAR Address, - CHAR Ch) -{ - GspWriteMem(Address, 1, TRUE, GspWriteMemSafeGetContent, &Ch); + PCHAR Address, + ULONG Count, + BOOLEAN MayFault) +{ + Count = GspWriteMem(Address, Count, MayFault, GspHex2MemGetContent, Buffer); + return Buffer + 2 * Count; } @@ -462,33 +445,38 @@ ULONG GspComputeSignal(NTSTATUS ExceptionCode) { - ULONG SigVal; - - switch (ExceptionCode) - { - case STATUS_INTEGER_DIVIDE_BY_ZERO: - SigVal = 8; /* divide by zero */ - break; - case STATUS_SINGLE_STEP: - case STATUS_BREAKPOINT: - SigVal = 5; /* breakpoint */ - break; - case STATUS_INTEGER_OVERFLOW: - case STATUS_ARRAY_BOUNDS_EXCEEDED: - SigVal = 16; /* bound instruction */ - break; - case STATUS_ILLEGAL_INSTRUCTION: - SigVal = 4; /* Invalid opcode */ - break; - case STATUS_STACK_OVERFLOW: - case STATUS_DATATYPE_MISALIGNMENT: - case STATUS_ACCESS_VIOLATION: - SigVal = 11; /* access violation */ - break; - default: - SigVal = 7; /* "software generated" */ - } - return SigVal; + ULONG SigVal; + + switch (ExceptionCode) + { + case STATUS_INTEGER_DIVIDE_BY_ZERO: + SigVal = 8; /* divide by zero */ + break; + + case STATUS_SINGLE_STEP: + case STATUS_BREAKPOINT: + SigVal = 5; /* breakpoint */ + break; + + case STATUS_INTEGER_OVERFLOW: + case STATUS_ARRAY_BOUNDS_EXCEEDED: + SigVal = 16; /* bound instruction */ + break; + + case STATUS_ILLEGAL_INSTRUCTION: + SigVal = 4; /* Invalid opcode */ + break; + + case STATUS_STACK_OVERFLOW: + case STATUS_DATATYPE_MISALIGNMENT: + case STATUS_ACCESS_VIOLATION: + SigVal = 11; /* access violation */ + break; + + default: + SigVal = 7; /* "software generated" */ + } + return SigVal; } @@ -1626,43 +1614,39 @@ BOOLEAN NTAPI GspBreakIn(PKINTERRUPT Interrupt, - PVOID ServiceContext) -{ - PKTRAP_FRAME TrapFrame; - BOOLEAN DoBreakIn; - CONTEXT Context; - KIRQL OldIrql; - UCHAR Value; - - DPRINT("Break In\n"); - - DoBreakIn = FALSE; - while (KdPortGetByteEx(&GdbPortInfo, &Value)) - { - if (Value == 0x03) - { - DoBreakIn = TRUE; - } - } - - if (!DoBreakIn) - { - return TRUE; - } - - KeRaiseIrql(HIGH_LEVEL, &OldIrql); - - TrapFrame = PsGetCurrentThread()->Tcb.TrapFrame; - - KeTrapFrameToContext(TrapFrame, NULL, &Context); - - KdpGdbEnterDebuggerException(NULL, &Context, TrapFrame); - - KeContextToTrapFrame(&Context, NULL, TrapFrame, Context.ContextFlags, KernelMode); - - KeLowerIrql(OldIrql); - - return TRUE; + PVOID ServiceContext) +{ + PKTRAP_FRAME TrapFrame; + BOOLEAN DoBreakIn; + CONTEXT Context; + KIRQL OldIrql; + UCHAR Value; + + DPRINT("Break In\n"); + + DoBreakIn = FALSE; + while (KdPortGetByteEx(&GdbPortInfo, &Value)) + { + if (Value == 0x03) + DoBreakIn = TRUE; + } + + if (!DoBreakIn) + return TRUE; + + KeRaiseIrql(HIGH_LEVEL, &OldIrql); + + TrapFrame = PsGetCurrentThread()->Tcb.TrapFrame; + + KeTrapFrameToContext(TrapFrame, NULL, &Context); + + KdpGdbEnterDebuggerException(NULL, &Context, TrapFrame); + + KeContextToTrapFrame(&Context, NULL, TrapFrame, Context.ContextFlags, KernelMode); + + KeLowerIrql(OldIrql); + + return TRUE; } VOID @@ -1677,39 +1661,36 @@ KdpGdbStubInit(PKD_DISPATCH_TABLE WrapperTable, ULONG BootPhase) { - if (!KdDebuggerEnabled || !KdpDebugMode.Gdb) - { - return; - } - - if (BootPhase == 0) - { - ExInitializeFastMutex(&GspLock); - - /* Write out the functions that we support for now */ - WrapperTable->KdpInitRoutine = KdpGdbStubInit; - WrapperTable->KdpPrintRoutine = KdpGdbDebugPrint; - WrapperTable->KdpExceptionRoutine = KdpGdbEnterDebuggerException; - - /* Initialize the Port */ - KdPortInitializeEx(&GdbPortInfo, 0, 0); - - KdpPort = GdbPortInfo.ComPort; - } - else if (BootPhase == 1) - { - GspInitialized = TRUE; - - GspRunThread = NULL; - GspDbgThread = NULL; - GspEnumThread = NULL; - - HalDisplayString("Waiting for GDB to attach\n"); - DbgBreakPointWithStatus(DBG_STATUS_CONTROL_C); - } - else if (BootPhase == 2) - { - HalDisplayString("\n GDB debugging enabled\n\n"); + if (!KdDebuggerEnabled || !KdpDebugMode.Gdb) + return; + + if (BootPhase == 0) + { + ExInitializeFastMutex(&GspLock); + + /* Write out the functions that we support for now */ + WrapperTable->KdpInitRoutine = KdpGdbStubInit; + WrapperTable->KdpPrintRoutine = KdpGdbDebugPrint; + WrapperTable->KdpExceptionRoutine = KdpGdbEnterDebuggerException; + + /* Initialize the Port */ + KdPortInitializeEx(&GdbPortInfo, GdbPortNumber); + // KdpPort = GdbPortInfo.ComPort; + } + else if (BootPhase == 1) + { + GspInitialized = TRUE; + + GspRunThread = NULL; + GspDbgThread = NULL; + GspEnumThread = NULL; + + HalDisplayString("Waiting for GDB to attach\n"); + DbgBreakPointWithStatus(DBG_STATUS_CONTROL_C); + } + else if (BootPhase == 2) + { + HalDisplayString("\n GDB debugging enabled\n\n"); } } Modified: trunk/reactos/ntoskrnl/kdbg/kdb.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/kdbg/kdb.h?rev=58… ============================================================================== --- trunk/reactos/ntoskrnl/kdbg/kdb.h [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/kdbg/kdb.h [iso-8859-1] Thu May 9 13:12:58 2013 @@ -5,6 +5,10 @@ #ifndef RTL_NUMBER_OF # define RTL_NUMBER_OF(x) (sizeof(x) / sizeof((x)[0])) #endif + +/* formerly located in kdbg/kdb_symbols.c */ +#define TAG_KDBS 'SBDK' +#define TAG_KDBG 'GBDK' /* TYPES *********************************************************************/

1 0

[hbelusca] 58973: [NTOS] Remove the kdbg-specific tags from the tag header and put them into the kdbg-specific header.
by hbelusca＠svn.reactos.org 09 May '13

09 May '13

Author: hbelusca Date: Thu May 9 12:55:39 2013 New Revision: 58973 URL: http://svn.reactos.org/svn/reactos?rev=58973&view=rev Log: [NTOS] Remove the kdbg-specific tags from the tag header and put them into the kdbg-specific header. Modified: branches/kd++/ntoskrnl/include/internal/tag.h branches/kd++/ntoskrnl/kdbg/kdb.h Modified: branches/kd++/ntoskrnl/include/internal/tag.h URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/ntoskrnl/include/inter… ============================================================================== --- branches/kd++/ntoskrnl/include/internal/tag.h [iso-8859-1] (original) +++ branches/kd++/ntoskrnl/include/internal/tag.h [iso-8859-1] Thu May 9 12:55:39 2013 @@ -95,10 +95,6 @@ #define TAG_VPB ' BPV' #define TAG_SYSB 'BSYS' -/* formerly located in kdbg/kdb_symbols.c */ -#define TAG_KDBS 'SBDK' -#define TAG_KDBG 'GBDK' - /* formerly located in ldr/loader.c */ #define TAG_DRIVER_MEM 'MVRD' /* drvm */ #define TAG_MODULE_OBJECT 'omlk' /* klmo - kernel ldr module object */ Modified: branches/kd++/ntoskrnl/kdbg/kdb.h URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/ntoskrnl/kdbg/kdb.h?re… ============================================================================== --- branches/kd++/ntoskrnl/kdbg/kdb.h [iso-8859-1] (original) +++ branches/kd++/ntoskrnl/kdbg/kdb.h [iso-8859-1] Thu May 9 12:55:39 2013 @@ -5,6 +5,10 @@ #ifndef RTL_NUMBER_OF # define RTL_NUMBER_OF(x) (sizeof(x) / sizeof((x)[0])) #endif + +/* formerly located in kdbg/kdb_symbols.c */ +#define TAG_KDBS 'SBDK' +#define TAG_KDBG 'GBDK' /* TYPES *********************************************************************/

1 0

[hbelusca] 58972: Sunc with trunk revision 58971.
by hbelusca＠svn.reactos.org 09 May '13

09 May '13

Author: hbelusca Date: Thu May 9 12:36:15 2013 New Revision: 58972 URL: http://svn.reactos.org/svn/reactos?rev=58972&view=rev Log: Sunc with trunk revision 58971. Added: branches/kd++/base/applications/cmdutils/hostname/lang/ (props changed) - copied from r58971, trunk/reactos/base/applications/cmdutils/hostname/lang/ branches/kd++/base/applications/cmdutils/hostname/resource.h - copied unchanged from r58971, trunk/reactos/base/applications/cmdutils/hostname/resource.h branches/kd++/base/applications/cmdutils/hostname/rsrc.rc - copied unchanged from r58971, trunk/reactos/base/applications/cmdutils/hostname/rsrc.rc branches/kd++/base/applications/cmdutils/reg/lang/cs-CZ.rc - copied unchanged from r58971, trunk/reactos/base/applications/cmdutils/reg/lang/cs-CZ.rc branches/kd++/base/applications/kbswitch/lang/tr-TR.rc - copied unchanged from r58971, trunk/reactos/base/applications/kbswitch/lang/tr-TR.rc branches/kd++/base/applications/network/net/cmdContinue.c - copied unchanged from r58971, trunk/reactos/base/applications/network/net/cmdContinue.c branches/kd++/base/applications/network/net/cmdHelpMsg.c - copied unchanged from r58971, trunk/reactos/base/applications/network/net/cmdHelpMsg.c branches/kd++/base/applications/network/net/cmdPause.c - copied unchanged from r58971, trunk/reactos/base/applications/network/net/cmdPause.c branches/kd++/base/applications/network/wlanconf/lang/cs-CZ.rc - copied unchanged from r58971, trunk/reactos/base/applications/network/wlanconf/lang/cs-CZ.rc branches/kd++/lib/rtl/bitmap64.c - copied unchanged from r58971, trunk/reactos/lib/rtl/bitmap64.c Removed: branches/kd++/dll/win32/fusion/fusion_main.c branches/kd++/lib/drivers/lwip/src/netif/loopif.c branches/kd++/lib/drivers/lwip/src/netif/ppp/vjbsdhdr.h Modified: branches/kd++/ (props changed) branches/kd++/base/applications/cmdutils/hostname/CMakeLists.txt branches/kd++/base/applications/cmdutils/hostname/hostname.c branches/kd++/base/applications/cmdutils/hostname/hostname.rc branches/kd++/base/applications/cmdutils/reg/rsrc.rc branches/kd++/base/applications/dxdiag/lang/tr-TR.rc branches/kd++/base/applications/kbswitch/rsrc.rc branches/kd++/base/applications/mscutils/servman/precomp.h branches/kd++/base/applications/mstsc/precomp.h branches/kd++/base/applications/network/net/CMakeLists.txt branches/kd++/base/applications/network/net/help.c branches/kd++/base/applications/network/net/main.c branches/kd++/base/applications/network/net/net.h branches/kd++/base/applications/network/wlanconf/wlanconf.rc branches/kd++/base/applications/rapps/rapps.h branches/kd++/base/applications/regedit/lang/cs-CZ.rc branches/kd++/base/applications/regedit/regedit.rc branches/kd++/base/shell/explorer-new/precomp.h branches/kd++/base/shell/explorer/precomp.h branches/kd++/base/system/userinit/userinit.c branches/kd++/boot/bootdata/hivesft.inf branches/kd++/cmake/baseaddress.cmake branches/kd++/dll/cpl/desk/desk.h branches/kd++/dll/cpl/desk/lang/cs-CZ.rc branches/kd++/dll/cpl/main/main.h branches/kd++/dll/cpl/sysdm/precomp.h branches/kd++/dll/ntdll/csr/connect.c branches/kd++/dll/shellext/deskadp/precomp.h branches/kd++/dll/shellext/deskmon/precomp.h branches/kd++/dll/shellext/slayer/precomp.h branches/kd++/dll/win32/advapi32/reg/reg.c branches/kd++/dll/win32/browseui/precomp.h branches/kd++/dll/win32/comdlg32/cdlg.h branches/kd++/dll/win32/comdlg32/filedlgbrowser.h branches/kd++/dll/win32/fusion/CMakeLists.txt branches/kd++/dll/win32/fusion/asmcache.c branches/kd++/dll/win32/fusion/asmenum.c branches/kd++/dll/win32/fusion/asmname.c branches/kd++/dll/win32/fusion/assembly.c branches/kd++/dll/win32/fusion/fusion.c branches/kd++/dll/win32/fusion/fusion.spec branches/kd++/dll/win32/fusion/fusionpriv.h branches/kd++/dll/win32/ieframe/ieframe.h branches/kd++/dll/win32/ieframe/ieframe.rc branches/kd++/dll/win32/kernel32/client/job.c branches/kd++/dll/win32/kernel32/client/time.c branches/kd++/dll/win32/kernel32/client/utils.c branches/kd++/dll/win32/lsasrv/authpackage.c branches/kd++/dll/win32/lsasrv/lsasrv.h branches/kd++/dll/win32/msgina/gui.c branches/kd++/dll/win32/msgina/lang/cs-CZ.rc branches/kd++/dll/win32/msgina/msgina.c branches/kd++/dll/win32/msgina/msgina.h branches/kd++/dll/win32/msgina/stubs.c branches/kd++/dll/win32/msgina/tui.c branches/kd++/dll/win32/msi/package.c branches/kd++/dll/win32/msv1_0/msv1_0.c branches/kd++/dll/win32/msv1_0/msv1_0.h branches/kd++/dll/win32/newdev/newdev_private.h branches/kd++/dll/win32/setupapi/setupapi_private.h branches/kd++/dll/win32/shell32/precomp.h branches/kd++/dll/win32/shlwapi/ordinal.c branches/kd++/dll/win32/syssetup/precomp.h branches/kd++/dll/win32/syssetup/wizard.c branches/kd++/drivers/base/beep/beep.c branches/kd++/drivers/hid/hidclass/hidclass.c branches/kd++/drivers/network/afd/afd/bind.c branches/kd++/drivers/network/afd/afd/connect.c branches/kd++/drivers/network/afd/afd/context.c branches/kd++/drivers/network/afd/afd/info.c branches/kd++/drivers/network/afd/afd/listen.c branches/kd++/drivers/network/afd/afd/lock.c branches/kd++/drivers/network/afd/afd/main.c branches/kd++/drivers/network/afd/afd/read.c branches/kd++/drivers/network/afd/afd/select.c branches/kd++/drivers/network/afd/afd/tdi.c branches/kd++/drivers/network/afd/afd/write.c branches/kd++/drivers/network/afd/include/afd.h branches/kd++/drivers/network/ndis/include/miniport.h branches/kd++/drivers/network/ndis/ndis/miniport.c branches/kd++/drivers/network/ndis/ndis/protocol.c branches/kd++/include/crt/memory.h branches/kd++/include/crt/sys/utime.h branches/kd++/include/crt/tchar.h branches/kd++/include/ddk/ntddk.h branches/kd++/include/ddk/wdm.h branches/kd++/include/psdk/corerror.h branches/kd++/include/psdk/fusion.idl branches/kd++/include/psdk/ntsecpkg.h branches/kd++/include/psdk/shlobj.h branches/kd++/include/psdk/shlobj_undoc.h branches/kd++/include/psdk/winternl.h branches/kd++/include/xdk/iofuncs.h branches/kd++/lib/atl/atlcom.h branches/kd++/lib/atl/statreg.h branches/kd++/lib/drivers/libusb/hcd_controller.cpp (contents, props changed) branches/kd++/lib/drivers/libusb/hub_controller.cpp (contents, props changed) branches/kd++/lib/drivers/lwip/CHANGELOG branches/kd++/lib/drivers/lwip/doc/contrib.txt branches/kd++/lib/drivers/lwip/doc/rawapi.txt branches/kd++/lib/drivers/lwip/doc/savannah.txt branches/kd++/lib/drivers/lwip/doc/sys_arch.txt branches/kd++/lib/drivers/lwip/src/api/api_lib.c branches/kd++/lib/drivers/lwip/src/api/api_msg.c branches/kd++/lib/drivers/lwip/src/api/netdb.c branches/kd++/lib/drivers/lwip/src/api/sockets.c branches/kd++/lib/drivers/lwip/src/api/tcpip.c branches/kd++/lib/drivers/lwip/src/core/dhcp.c branches/kd++/lib/drivers/lwip/src/core/init.c branches/kd++/lib/drivers/lwip/src/core/ipv4/autoip.c branches/kd++/lib/drivers/lwip/src/core/ipv4/icmp.c branches/kd++/lib/drivers/lwip/src/core/ipv4/igmp.c branches/kd++/lib/drivers/lwip/src/core/ipv4/ip.c branches/kd++/lib/drivers/lwip/src/core/ipv6/ip6.c branches/kd++/lib/drivers/lwip/src/core/mem.c branches/kd++/lib/drivers/lwip/src/core/memp.c branches/kd++/lib/drivers/lwip/src/core/netif.c branches/kd++/lib/drivers/lwip/src/core/pbuf.c branches/kd++/lib/drivers/lwip/src/core/raw.c branches/kd++/lib/drivers/lwip/src/core/snmp/mib2.c branches/kd++/lib/drivers/lwip/src/core/snmp/msg_in.c branches/kd++/lib/drivers/lwip/src/core/snmp/msg_out.c branches/kd++/lib/drivers/lwip/src/core/stats.c branches/kd++/lib/drivers/lwip/src/core/sys.c branches/kd++/lib/drivers/lwip/src/core/tcp.c branches/kd++/lib/drivers/lwip/src/core/tcp_in.c branches/kd++/lib/drivers/lwip/src/core/tcp_out.c branches/kd++/lib/drivers/lwip/src/core/timers.c branches/kd++/lib/drivers/lwip/src/core/udp.c branches/kd++/lib/drivers/lwip/src/include/arch/cc.h branches/kd++/lib/drivers/lwip/src/include/ipv4/lwip/autoip.h branches/kd++/lib/drivers/lwip/src/include/ipv4/lwip/ip.h branches/kd++/lib/drivers/lwip/src/include/lwip/api.h branches/kd++/lib/drivers/lwip/src/include/lwip/api_msg.h branches/kd++/lib/drivers/lwip/src/include/lwip/arch.h branches/kd++/lib/drivers/lwip/src/include/lwip/debug.h branches/kd++/lib/drivers/lwip/src/include/lwip/def.h branches/kd++/lib/drivers/lwip/src/include/lwip/init.h branches/kd++/lib/drivers/lwip/src/include/lwip/mem.h branches/kd++/lib/drivers/lwip/src/include/lwip/memp_std.h branches/kd++/lib/drivers/lwip/src/include/lwip/netif.h branches/kd++/lib/drivers/lwip/src/include/lwip/opt.h branches/kd++/lib/drivers/lwip/src/include/lwip/pbuf.h branches/kd++/lib/drivers/lwip/src/include/lwip/sockets.h branches/kd++/lib/drivers/lwip/src/include/lwip/stats.h branches/kd++/lib/drivers/lwip/src/include/lwip/sys.h branches/kd++/lib/drivers/lwip/src/include/lwip/tcp.h branches/kd++/lib/drivers/lwip/src/include/lwip/tcp_impl.h branches/kd++/lib/drivers/lwip/src/include/lwip/tcpip.h branches/kd++/lib/drivers/lwip/src/include/lwip/timers.h branches/kd++/lib/drivers/lwip/src/include/lwip/udp.h branches/kd++/lib/drivers/lwip/src/include/netif/etharp.h branches/kd++/lib/drivers/lwip/src/include/netif/slipif.h branches/kd++/lib/drivers/lwip/src/netif/etharp.c branches/kd++/lib/drivers/lwip/src/netif/ethernetif.c branches/kd++/lib/drivers/lwip/src/netif/ppp/auth.c branches/kd++/lib/drivers/lwip/src/netif/ppp/chap.c branches/kd++/lib/drivers/lwip/src/netif/ppp/chpms.c branches/kd++/lib/drivers/lwip/src/netif/ppp/fsm.c branches/kd++/lib/drivers/lwip/src/netif/ppp/ipcp.c branches/kd++/lib/drivers/lwip/src/netif/ppp/lcp.c branches/kd++/lib/drivers/lwip/src/netif/ppp/magic.c branches/kd++/lib/drivers/lwip/src/netif/ppp/md5.c branches/kd++/lib/drivers/lwip/src/netif/ppp/pap.c branches/kd++/lib/drivers/lwip/src/netif/ppp/ppp.c branches/kd++/lib/drivers/lwip/src/netif/ppp/ppp.h branches/kd++/lib/drivers/lwip/src/netif/ppp/ppp_oe.c branches/kd++/lib/drivers/lwip/src/netif/ppp/randm.c branches/kd++/lib/drivers/lwip/src/netif/ppp/vj.c branches/kd++/lib/drivers/lwip/src/netif/slipif.c branches/kd++/lib/drivers/lwip/src/rosip.c branches/kd++/lib/drivers/lwip/src/rosmem.c branches/kd++/lib/drivers/lwip/src/rostcp.c branches/kd++/lib/drivers/lwip/test/unit/lwip_unittests.c branches/kd++/lib/drivers/lwip/test/unit/tcp/tcp_helper.c branches/kd++/lib/drivers/lwip/test/unit/tcp/tcp_helper.h branches/kd++/lib/drivers/lwip/test/unit/tcp/test_tcp.c branches/kd++/lib/drivers/lwip/test/unit/tcp/test_tcp_oos.c branches/kd++/lib/rtl/bitmap.c branches/kd++/lib/rtl/mem.c branches/kd++/lib/rtl/priv.c branches/kd++/media/doc/README.WINE branches/kd++/ntoskrnl/fsrtl/dbcsname.c branches/kd++/ntoskrnl/fsrtl/fsrtlpc.c branches/kd++/ntoskrnl/fsrtl/largemcb.c branches/kd++/ntoskrnl/fsrtl/stackovf.c branches/kd++/ntoskrnl/io/iomgr/error.c branches/kd++/ntoskrnl/ke/i386/v86vdm.c branches/kd++/subsystems/win/basesrv/dosdev.c branches/kd++/subsystems/win32/csrsrv/api.c branches/kd++/subsystems/win32/csrsrv/thredsup.c branches/kd++/tools/cdmake/cdmake.c branches/kd++/win32ss/gdi/ntgdi/device.c branches/kd++/win32ss/gdi/ntgdi/freetype.c branches/kd++/win32ss/user/consrv/console.c branches/kd++/win32ss/user/consrv/init.c branches/kd++/win32ss/user/ntuser/winsta.c [This mail would be too long, it was shortened to contain the URLs only.] Modified: branches/kd++/base/applications/cmdutils/hostname/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/base/applications/cmdu… Modified: branches/kd++/base/applications/cmdutils/hostname/hostname.c URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/base/applications/cmdu… Modified: branches/kd++/base/applications/cmdutils/hostname/hostname.rc URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/base/applications/cmdu… Modified: branches/kd++/base/applications/cmdutils/reg/rsrc.rc URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/base/applications/cmdu… Modified: branches/kd++/base/applications/dxdiag/lang/tr-TR.rc URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/base/applications/dxdi… Modified: branches/kd++/base/applications/kbswitch/rsrc.rc URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/base/applications/kbsw… Modified: branches/kd++/base/applications/mscutils/servman/precomp.h URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/base/applications/mscu… Modified: branches/kd++/base/applications/mstsc/precomp.h URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/base/applications/msts… Modified: branches/kd++/base/applications/network/net/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/base/applications/netw… Modified: branches/kd++/base/applications/network/net/help.c URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/base/applications/netw… Modified: branches/kd++/base/applications/network/net/main.c URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/base/applications/netw… Modified: branches/kd++/base/applications/network/net/net.h URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/base/applications/netw… Modified: branches/kd++/base/applications/network/wlanconf/wlanconf.rc URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/base/applications/netw… Modified: branches/kd++/base/applications/rapps/rapps.h URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/base/applications/rapp… Modified: branches/kd++/base/applications/regedit/lang/cs-CZ.rc URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/base/applications/rege… Modified: branches/kd++/base/applications/regedit/regedit.rc URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/base/applications/rege… Modified: branches/kd++/base/shell/explorer-new/precomp.h URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/base/shell/explorer-ne… Modified: branches/kd++/base/shell/explorer/precomp.h URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/base/shell/explorer/pr… Modified: branches/kd++/base/system/userinit/userinit.c URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/base/system/userinit/u… Modified: branches/kd++/boot/bootdata/hivesft.inf URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/boot/bootdata/hivesft.… Modified: branches/kd++/cmake/baseaddress.cmake URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/cmake/baseaddress.cmak… Modified: branches/kd++/dll/cpl/desk/desk.h URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/dll/cpl/desk/desk.h?re… Modified: branches/kd++/dll/cpl/desk/lang/cs-CZ.rc URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/dll/cpl/desk/lang/cs-C… Modified: branches/kd++/dll/cpl/main/main.h URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/dll/cpl/main/main.h?re… Modified: branches/kd++/dll/cpl/sysdm/precomp.h URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/dll/cpl/sysdm/precomp.… Modified: branches/kd++/dll/ntdll/csr/connect.c URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/dll/ntdll/csr/connect.… Modified: branches/kd++/dll/shellext/deskadp/precomp.h URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/dll/shellext/deskadp/p… Modified: branches/kd++/dll/shellext/deskmon/precomp.h URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/dll/shellext/deskmon/p… Modified: branches/kd++/dll/shellext/slayer/precomp.h URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/dll/shellext/slayer/pr… Modified: branches/kd++/dll/win32/advapi32/reg/reg.c URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/dll/win32/advapi32/reg… Modified: branches/kd++/dll/win32/browseui/precomp.h URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/dll/win32/browseui/pre… Modified: branches/kd++/dll/win32/comdlg32/cdlg.h URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/dll/win32/comdlg32/cdl… Modified: branches/kd++/dll/win32/comdlg32/filedlgbrowser.h URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/dll/win32/comdlg32/fil… Modified: branches/kd++/dll/win32/fusion/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/dll/win32/fusion/CMake… Modified: branches/kd++/dll/win32/fusion/asmcache.c URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/dll/win32/fusion/asmca… Modified: branches/kd++/dll/win32/fusion/asmenum.c URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/dll/win32/fusion/asmen… Modified: branches/kd++/dll/win32/fusion/asmname.c URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/dll/win32/fusion/asmna… Modified: branches/kd++/dll/win32/fusion/assembly.c URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/dll/win32/fusion/assem… Modified: branches/kd++/dll/win32/fusion/fusion.c URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/dll/win32/fusion/fusio… Modified: branches/kd++/dll/win32/fusion/fusion.spec URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/dll/win32/fusion/fusio… Removed: branches/kd++/dll/win32/fusion/fusion_main.c URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/dll/win32/fusion/fusio… Modified: branches/kd++/dll/win32/fusion/fusionpriv.h URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/dll/win32/fusion/fusio… Modified: branches/kd++/dll/win32/ieframe/ieframe.h URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/dll/win32/ieframe/iefr… Modified: branches/kd++/dll/win32/ieframe/ieframe.rc URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/dll/win32/ieframe/iefr… Modified: branches/kd++/dll/win32/kernel32/client/job.c URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/dll/win32/kernel32/cli… Modified: branches/kd++/dll/win32/kernel32/client/time.c URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/dll/win32/kernel32/cli… Modified: branches/kd++/dll/win32/kernel32/client/utils.c URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/dll/win32/kernel32/cli… Modified: branches/kd++/dll/win32/lsasrv/authpackage.c URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/dll/win32/lsasrv/authp… Modified: branches/kd++/dll/win32/lsasrv/lsasrv.h URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/dll/win32/lsasrv/lsasr… Modified: branches/kd++/dll/win32/msgina/gui.c URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/dll/win32/msgina/gui.c… Modified: branches/kd++/dll/win32/msgina/lang/cs-CZ.rc URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/dll/win32/msgina/lang/… Modified: branches/kd++/dll/win32/msgina/msgina.c URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/dll/win32/msgina/msgin… Modified: branches/kd++/dll/win32/msgina/msgina.h URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/dll/win32/msgina/msgin… Modified: branches/kd++/dll/win32/msgina/stubs.c URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/dll/win32/msgina/stubs… Modified: branches/kd++/dll/win32/msgina/tui.c URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/dll/win32/msgina/tui.c… Modified: branches/kd++/dll/win32/msi/package.c URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/dll/win32/msi/package.… Modified: branches/kd++/dll/win32/msv1_0/msv1_0.c URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/dll/win32/msv1_0/msv1_… Modified: branches/kd++/dll/win32/msv1_0/msv1_0.h URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/dll/win32/msv1_0/msv1_… Modified: branches/kd++/dll/win32/newdev/newdev_private.h URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/dll/win32/newdev/newde… Modified: branches/kd++/dll/win32/setupapi/setupapi_private.h URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/dll/win32/setupapi/set… Modified: branches/kd++/dll/win32/shell32/precomp.h URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/dll/win32/shell32/prec… Modified: branches/kd++/dll/win32/shlwapi/ordinal.c URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/dll/win32/shlwapi/ordi… Modified: branches/kd++/dll/win32/syssetup/precomp.h URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/dll/win32/syssetup/pre… Modified: branches/kd++/dll/win32/syssetup/wizard.c URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/dll/win32/syssetup/wiz… Modified: branches/kd++/drivers/base/beep/beep.c URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/drivers/base/beep/beep… Modified: branches/kd++/drivers/hid/hidclass/hidclass.c URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/drivers/hid/hidclass/h… Modified: branches/kd++/drivers/network/afd/afd/bind.c URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/drivers/network/afd/af… Modified: branches/kd++/drivers/network/afd/afd/connect.c URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/drivers/network/afd/af… Modified: branches/kd++/drivers/network/afd/afd/context.c URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/drivers/network/afd/af… Modified: branches/kd++/drivers/network/afd/afd/info.c URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/drivers/network/afd/af… Modified: branches/kd++/drivers/network/afd/afd/listen.c URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/drivers/network/afd/af… Modified: branches/kd++/drivers/network/afd/afd/lock.c URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/drivers/network/afd/af… Modified: branches/kd++/drivers/network/afd/afd/main.c URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/drivers/network/afd/af… Modified: branches/kd++/drivers/network/afd/afd/read.c URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/drivers/network/afd/af… Modified: branches/kd++/drivers/network/afd/afd/select.c URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/drivers/network/afd/af… Modified: branches/kd++/drivers/network/afd/afd/tdi.c URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/drivers/network/afd/af… Modified: branches/kd++/drivers/network/afd/afd/write.c URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/drivers/network/afd/af… Modified: branches/kd++/drivers/network/afd/include/afd.h URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/drivers/network/afd/in… Modified: branches/kd++/drivers/network/ndis/include/miniport.h URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/drivers/network/ndis/i… Modified: branches/kd++/drivers/network/ndis/ndis/miniport.c URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/drivers/network/ndis/n… Modified: branches/kd++/drivers/network/ndis/ndis/protocol.c URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/drivers/network/ndis/n… Modified: branches/kd++/include/crt/memory.h URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/include/crt/memory.h?r… Modified: branches/kd++/include/crt/sys/utime.h URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/include/crt/sys/utime.… Modified: branches/kd++/include/crt/tchar.h URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/include/crt/tchar.h?re… Modified: branches/kd++/include/ddk/ntddk.h URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/include/ddk/ntddk.h?re… Modified: branches/kd++/include/ddk/wdm.h URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/include/ddk/wdm.h?rev=… Modified: branches/kd++/include/psdk/corerror.h URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/include/psdk/corerror.… Modified: branches/kd++/include/psdk/fusion.idl URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/include/psdk/fusion.id… Modified: branches/kd++/include/psdk/ntsecpkg.h URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/include/psdk/ntsecpkg.… Modified: branches/kd++/include/psdk/shlobj.h URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/include/psdk/shlobj.h?… Modified: branches/kd++/include/psdk/shlobj_undoc.h URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/include/psdk/shlobj_un… Modified: branches/kd++/include/psdk/winternl.h URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/include/psdk/winternl.… Modified: branches/kd++/include/xdk/iofuncs.h URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/include/xdk/iofuncs.h?… Modified: branches/kd++/lib/atl/atlcom.h URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/lib/atl/atlcom.h?rev=5… Modified: branches/kd++/lib/atl/statreg.h URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/lib/atl/statreg.h?rev=… Modified: branches/kd++/lib/drivers/libusb/hcd_controller.cpp URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/lib/drivers/libusb/hcd… Modified: branches/kd++/lib/drivers/libusb/hub_controller.cpp URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/lib/drivers/libusb/hub… Modified: branches/kd++/lib/drivers/lwip/CHANGELOG URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/lib/drivers/lwip/CHANG… Modified: branches/kd++/lib/drivers/lwip/doc/contrib.txt URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/lib/drivers/lwip/doc/c… Modified: branches/kd++/lib/drivers/lwip/doc/rawapi.txt URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/lib/drivers/lwip/doc/r… Modified: branches/kd++/lib/drivers/lwip/doc/savannah.txt URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/lib/drivers/lwip/doc/s… Modified: branches/kd++/lib/drivers/lwip/doc/sys_arch.txt URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/lib/drivers/lwip/doc/s… Modified: branches/kd++/lib/drivers/lwip/src/api/api_lib.c URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/lib/drivers/lwip/src/a… Modified: branches/kd++/lib/drivers/lwip/src/api/api_msg.c URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/lib/drivers/lwip/src/a… Modified: branches/kd++/lib/drivers/lwip/src/api/netdb.c URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/lib/drivers/lwip/src/a… Modified: branches/kd++/lib/drivers/lwip/src/api/sockets.c URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/lib/drivers/lwip/src/a… Modified: branches/kd++/lib/drivers/lwip/src/api/tcpip.c URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/lib/drivers/lwip/src/a… Modified: branches/kd++/lib/drivers/lwip/src/core/dhcp.c URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/lib/drivers/lwip/src/c… Modified: branches/kd++/lib/drivers/lwip/src/core/init.c URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/lib/drivers/lwip/src/c… Modified: branches/kd++/lib/drivers/lwip/src/core/ipv4/autoip.c URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/lib/drivers/lwip/src/c… Modified: branches/kd++/lib/drivers/lwip/src/core/ipv4/icmp.c URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/lib/drivers/lwip/src/c… Modified: branches/kd++/lib/drivers/lwip/src/core/ipv4/igmp.c URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/lib/drivers/lwip/src/c… Modified: branches/kd++/lib/drivers/lwip/src/core/ipv4/ip.c URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/lib/drivers/lwip/src/c… Modified: branches/kd++/lib/drivers/lwip/src/core/ipv6/ip6.c URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/lib/drivers/lwip/src/c… Modified: branches/kd++/lib/drivers/lwip/src/core/mem.c URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/lib/drivers/lwip/src/c… Modified: branches/kd++/lib/drivers/lwip/src/core/memp.c URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/lib/drivers/lwip/src/c… Modified: branches/kd++/lib/drivers/lwip/src/core/netif.c URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/lib/drivers/lwip/src/c… Modified: branches/kd++/lib/drivers/lwip/src/core/pbuf.c URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/lib/drivers/lwip/src/c… Modified: branches/kd++/lib/drivers/lwip/src/core/raw.c URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/lib/drivers/lwip/src/c… Modified: branches/kd++/lib/drivers/lwip/src/core/snmp/mib2.c URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/lib/drivers/lwip/src/c… Modified: branches/kd++/lib/drivers/lwip/src/core/snmp/msg_in.c URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/lib/drivers/lwip/src/c… Modified: branches/kd++/lib/drivers/lwip/src/core/snmp/msg_out.c URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/lib/drivers/lwip/src/c… Modified: branches/kd++/lib/drivers/lwip/src/core/stats.c URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/lib/drivers/lwip/src/c… Modified: branches/kd++/lib/drivers/lwip/src/core/sys.c URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/lib/drivers/lwip/src/c… Modified: branches/kd++/lib/drivers/lwip/src/core/tcp.c URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/lib/drivers/lwip/src/c… Modified: branches/kd++/lib/drivers/lwip/src/core/tcp_in.c URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/lib/drivers/lwip/src/c… Modified: branches/kd++/lib/drivers/lwip/src/core/tcp_out.c URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/lib/drivers/lwip/src/c… Modified: branches/kd++/lib/drivers/lwip/src/core/timers.c URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/lib/drivers/lwip/src/c… Modified: branches/kd++/lib/drivers/lwip/src/core/udp.c URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/lib/drivers/lwip/src/c… Modified: branches/kd++/lib/drivers/lwip/src/include/arch/cc.h URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/lib/drivers/lwip/src/i… Modified: branches/kd++/lib/drivers/lwip/src/include/ipv4/lwip/autoip.h URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/lib/drivers/lwip/src/i… Modified: branches/kd++/lib/drivers/lwip/src/include/ipv4/lwip/ip.h URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/lib/drivers/lwip/src/i… Modified: branches/kd++/lib/drivers/lwip/src/include/lwip/api.h URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/lib/drivers/lwip/src/i… Modified: branches/kd++/lib/drivers/lwip/src/include/lwip/api_msg.h URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/lib/drivers/lwip/src/i… Modified: branches/kd++/lib/drivers/lwip/src/include/lwip/arch.h URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/lib/drivers/lwip/src/i… Modified: branches/kd++/lib/drivers/lwip/src/include/lwip/debug.h URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/lib/drivers/lwip/src/i… Modified: branches/kd++/lib/drivers/lwip/src/include/lwip/def.h URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/lib/drivers/lwip/src/i… Modified: branches/kd++/lib/drivers/lwip/src/include/lwip/init.h URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/lib/drivers/lwip/src/i… Modified: branches/kd++/lib/drivers/lwip/src/include/lwip/mem.h URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/lib/drivers/lwip/src/i… Modified: branches/kd++/lib/drivers/lwip/src/include/lwip/memp_std.h URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/lib/drivers/lwip/src/i… Modified: branches/kd++/lib/drivers/lwip/src/include/lwip/netif.h URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/lib/drivers/lwip/src/i… Modified: branches/kd++/lib/drivers/lwip/src/include/lwip/opt.h URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/lib/drivers/lwip/src/i… Modified: branches/kd++/lib/drivers/lwip/src/include/lwip/pbuf.h URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/lib/drivers/lwip/src/i… Modified: branches/kd++/lib/drivers/lwip/src/include/lwip/sockets.h URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/lib/drivers/lwip/src/i… Modified: branches/kd++/lib/drivers/lwip/src/include/lwip/stats.h URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/lib/drivers/lwip/src/i… Modified: branches/kd++/lib/drivers/lwip/src/include/lwip/sys.h URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/lib/drivers/lwip/src/i… Modified: branches/kd++/lib/drivers/lwip/src/include/lwip/tcp.h URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/lib/drivers/lwip/src/i… Modified: branches/kd++/lib/drivers/lwip/src/include/lwip/tcp_impl.h URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/lib/drivers/lwip/src/i… Modified: branches/kd++/lib/drivers/lwip/src/include/lwip/tcpip.h URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/lib/drivers/lwip/src/i… Modified: branches/kd++/lib/drivers/lwip/src/include/lwip/timers.h URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/lib/drivers/lwip/src/i… Modified: branches/kd++/lib/drivers/lwip/src/include/lwip/udp.h URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/lib/drivers/lwip/src/i… Modified: branches/kd++/lib/drivers/lwip/src/include/netif/etharp.h URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/lib/drivers/lwip/src/i… Modified: branches/kd++/lib/drivers/lwip/src/include/netif/slipif.h URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/lib/drivers/lwip/src/i… Modified: branches/kd++/lib/drivers/lwip/src/netif/etharp.c URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/lib/drivers/lwip/src/n… Modified: branches/kd++/lib/drivers/lwip/src/netif/ethernetif.c URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/lib/drivers/lwip/src/n… Removed: branches/kd++/lib/drivers/lwip/src/netif/loopif.c URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/lib/drivers/lwip/src/n… Modified: branches/kd++/lib/drivers/lwip/src/netif/ppp/auth.c URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/lib/drivers/lwip/src/n… Modified: branches/kd++/lib/drivers/lwip/src/netif/ppp/chap.c URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/lib/drivers/lwip/src/n… Modified: branches/kd++/lib/drivers/lwip/src/netif/ppp/chpms.c URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/lib/drivers/lwip/src/n… Modified: branches/kd++/lib/drivers/lwip/src/netif/ppp/fsm.c URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/lib/drivers/lwip/src/n… Modified: branches/kd++/lib/drivers/lwip/src/netif/ppp/ipcp.c URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/lib/drivers/lwip/src/n… Modified: branches/kd++/lib/drivers/lwip/src/netif/ppp/lcp.c URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/lib/drivers/lwip/src/n… Modified: branches/kd++/lib/drivers/lwip/src/netif/ppp/magic.c URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/lib/drivers/lwip/src/n… Modified: branches/kd++/lib/drivers/lwip/src/netif/ppp/md5.c URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/lib/drivers/lwip/src/n… Modified: branches/kd++/lib/drivers/lwip/src/netif/ppp/pap.c URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/lib/drivers/lwip/src/n… Modified: branches/kd++/lib/drivers/lwip/src/netif/ppp/ppp.c URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/lib/drivers/lwip/src/n… Modified: branches/kd++/lib/drivers/lwip/src/netif/ppp/ppp.h URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/lib/drivers/lwip/src/n… Modified: branches/kd++/lib/drivers/lwip/src/netif/ppp/ppp_oe.c URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/lib/drivers/lwip/src/n… Modified: branches/kd++/lib/drivers/lwip/src/netif/ppp/randm.c URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/lib/drivers/lwip/src/n… Modified: branches/kd++/lib/drivers/lwip/src/netif/ppp/vj.c URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/lib/drivers/lwip/src/n… Removed: branches/kd++/lib/drivers/lwip/src/netif/ppp/vjbsdhdr.h URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/lib/drivers/lwip/src/n… Modified: branches/kd++/lib/drivers/lwip/src/netif/slipif.c URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/lib/drivers/lwip/src/n… Modified: branches/kd++/lib/drivers/lwip/src/rosip.c URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/lib/drivers/lwip/src/r… Modified: branches/kd++/lib/drivers/lwip/src/rosmem.c URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/lib/drivers/lwip/src/r… Modified: branches/kd++/lib/drivers/lwip/src/rostcp.c URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/lib/drivers/lwip/src/r… Modified: branches/kd++/lib/drivers/lwip/test/unit/lwip_unittests.c URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/lib/drivers/lwip/test/… Modified: branches/kd++/lib/drivers/lwip/test/unit/tcp/tcp_helper.c URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/lib/drivers/lwip/test/… Modified: branches/kd++/lib/drivers/lwip/test/unit/tcp/tcp_helper.h URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/lib/drivers/lwip/test/… Modified: branches/kd++/lib/drivers/lwip/test/unit/tcp/test_tcp.c URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/lib/drivers/lwip/test/… Modified: branches/kd++/lib/drivers/lwip/test/unit/tcp/test_tcp_oos.c URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/lib/drivers/lwip/test/… Modified: branches/kd++/lib/rtl/bitmap.c URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/lib/rtl/bitmap.c?rev=5… Modified: branches/kd++/lib/rtl/mem.c URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/lib/rtl/mem.c?rev=5897… Modified: branches/kd++/lib/rtl/priv.c URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/lib/rtl/priv.c?rev=589… Modified: branches/kd++/media/doc/README.WINE URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/media/doc/README.WINE?… Modified: branches/kd++/ntoskrnl/fsrtl/dbcsname.c URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/ntoskrnl/fsrtl/dbcsnam… Modified: branches/kd++/ntoskrnl/fsrtl/fsrtlpc.c URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/ntoskrnl/fsrtl/fsrtlpc… Modified: branches/kd++/ntoskrnl/fsrtl/largemcb.c URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/ntoskrnl/fsrtl/largemc… Modified: branches/kd++/ntoskrnl/fsrtl/stackovf.c URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/ntoskrnl/fsrtl/stackov… Modified: branches/kd++/ntoskrnl/io/iomgr/error.c URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/ntoskrnl/io/iomgr/erro… Modified: branches/kd++/ntoskrnl/ke/i386/v86vdm.c URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/ntoskrnl/ke/i386/v86vd… Modified: branches/kd++/subsystems/win/basesrv/dosdev.c URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/subsystems/win/basesrv… Modified: branches/kd++/subsystems/win32/csrsrv/api.c URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/subsystems/win32/csrsr… Modified: branches/kd++/subsystems/win32/csrsrv/thredsup.c URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/subsystems/win32/csrsr… Modified: branches/kd++/tools/cdmake/cdmake.c URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/tools/cdmake/cdmake.c?… Modified: branches/kd++/win32ss/gdi/ntgdi/device.c URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/win32ss/gdi/ntgdi/devi… Modified: branches/kd++/win32ss/gdi/ntgdi/freetype.c URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/win32ss/gdi/ntgdi/free… Modified: branches/kd++/win32ss/user/consrv/console.c URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/win32ss/user/consrv/co… Modified: branches/kd++/win32ss/user/consrv/init.c URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/win32ss/user/consrv/in… Modified: branches/kd++/win32ss/user/ntuser/winsta.c URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/win32ss/user/ntuser/wi…

1 0

[hbelusca] 58971: [FREELDR] - Fix dprints (be careful when "Status" variables are booleans). - Don't fail when trying to load an non-existent KD transport dll.
by hbelusca＠svn.reactos.org 08 May '13

08 May '13

Author: hbelusca Date: Wed May 8 17:52:16 2013 New Revision: 58971 URL: http://svn.reactos.org/svn/reactos?rev=58971&view=rev Log: [FREELDR] - Fix dprints (be careful when "Status" variables are booleans). - Don't fail when trying to load an non-existent KD transport dll. Modified: branches/kd++/boot/freeldr/freeldr/disk/scsiport.c branches/kd++/boot/freeldr/freeldr/windows/peloader.c branches/kd++/boot/freeldr/freeldr/windows/winldr.c Modified: branches/kd++/boot/freeldr/freeldr/disk/scsiport.c URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/boot/freeldr/freeldr/d… ============================================================================== --- branches/kd++/boot/freeldr/freeldr/disk/scsiport.c [iso-8859-1] (original) +++ branches/kd++/boot/freeldr/freeldr/disk/scsiport.c [iso-8859-1] Wed May 8 17:52:16 2013 @@ -1568,7 +1568,7 @@ ULONG ImportTableSize; PLDR_DATA_TABLE_ENTRY BootDdDTE, FreeldrDTE; CHAR NtBootDdPath[MAX_PATH]; - PVOID ImageBase; + PVOID ImageBase = NULL; ULONG (NTAPI *EntryPoint)(IN PVOID DriverObject, IN PVOID RegistryPath); BOOLEAN Status; Modified: branches/kd++/boot/freeldr/freeldr/windows/peloader.c URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/boot/freeldr/freeldr/w… ============================================================================== --- branches/kd++/boot/freeldr/freeldr/windows/peloader.c [iso-8859-1] (original) +++ branches/kd++/boot/freeldr/freeldr/windows/peloader.c [iso-8859-1] Wed May 8 17:52:16 2013 @@ -255,11 +255,12 @@ return TRUE; } -/* WinLdrLoadImage loads the specified image from the file (it doesn't - perform any additional operations on the filename, just directly - calls the file I/O routines), and relocates it so that it's ready - to be used when paging is enabled. - Addressing mode: physical +/* + * WinLdrLoadImage loads the specified image from the file (it doesn't + * perform any additional operations on the filename, just directly + * calls the file I/O routines), and relocates it so that it's ready + * to be used when paging is enabled. + * Addressing mode: physical */ BOOLEAN WinLdrLoadImage(IN PCHAR FileName, @@ -429,7 +430,6 @@ /* If loading failed - return right now */ if (Status != ESUCCESS) return FALSE; - /* Relocate the image, if it needs it */ if (NtHeaders->OptionalHeader.ImageBase != (ULONG_PTR)VirtualBase) @@ -756,7 +756,7 @@ { CHAR FullDllName[256]; BOOLEAN Status; - PVOID BasePA; + PVOID BasePA = NULL; /* Prepare the full path to the file to be loaded */ strcpy(FullDllName, DirectoryPath); @@ -781,7 +781,7 @@ DataTableEntry); if (!Status) { - ERR("WinLdrAllocateDataTableEntry() failed with Status=0x%X\n", Status); + ERR("WinLdrAllocateDataTableEntry() failed\n"); return Status; } @@ -791,7 +791,7 @@ Status = WinLdrScanImportDescriptorTable(ModuleListHead, DirectoryPath, *DataTableEntry); if (!Status) { - ERR("WinLdrScanImportDescriptorTable() failed with Status=0x%X\n", Status); + ERR("WinLdrScanImportDescriptorTable() failed\n"); return Status; } Modified: branches/kd++/boot/freeldr/freeldr/windows/winldr.c URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/boot/freeldr/freeldr/w… ============================================================================== --- branches/kd++/boot/freeldr/freeldr/windows/winldr.c [iso-8859-1] (original) +++ branches/kd++/boot/freeldr/freeldr/windows/winldr.c [iso-8859-1] Wed May 8 17:52:16 2013 @@ -237,7 +237,7 @@ CHAR DllName[1024]; PCHAR DriverNamePos; BOOLEAN Status; - PVOID DriverBase; + PVOID DriverBase = NULL; // Separate the path to file name and directory path _snprintf(DriverPath, sizeof(DriverPath), "%wZ", FilePath); @@ -258,7 +258,6 @@ } TRACE("DriverPath: %s, DllName: %s, LPB\n", DriverPath, DllName); - // Check if driver is already loaded Status = WinLdrCheckForLoadedDll(LoadOrderListHead, DllName, DriverDTE); @@ -424,7 +423,7 @@ } static -PVOID +BOOLEAN LoadModule( PLOADER_PARAMETER_BLOCK LoaderBlock, PCCH Path, @@ -434,10 +433,10 @@ BOOLEAN IsKdTransportDll, ULONG Percentage) { + BOOLEAN Status; CHAR FullFileName[MAX_PATH]; CHAR ProgressString[256]; - NTSTATUS Status; - PVOID BaseAdress; + PVOID BaseAdress = NULL; UiDrawBackdrop(); sprintf(ProgressString, "Loading %s...", File); @@ -448,8 +447,12 @@ strcat(FullFileName, File); Status = WinLdrLoadImage(FullFileName, MemoryType, &BaseAdress); - TRACE("%s loaded with status %d at %p\n", - File, Status, BaseAdress); + if (!Status) + { + TRACE("Loading %s failed\n", File); + return FALSE; + } + TRACE("%s loaded successfully at %p\n", File, BaseAdress); strcpy(FullFileName, "WINDOWS\\SYSTEM32\\"); strcat(FullFileName, File); @@ -458,13 +461,13 @@ * the Kernel Debugger Transport DLL, to make the * PE loader happy. */ - WinLdrAllocateDataTableEntry(&LoaderBlock->LoadOrderListHead, - (IsKdTransportDll ? "KDCOM.DLL" : File), - FullFileName, - BaseAdress, - Dte); - - return BaseAdress; + Status = WinLdrAllocateDataTableEntry(&LoaderBlock->LoadOrderListHead, + (IsKdTransportDll ? "KDCOM.DLL" : File), + FullFileName, + BaseAdress, + Dte); + + return Status; } static @@ -679,11 +682,11 @@ UiDrawBackdrop(); UiDrawProgressBarCenter(15, 100, "Loading system hive..."); Status = WinLdrInitSystemHive(LoaderBlock, BootPath); - TRACE("SYSTEM hive loaded with status %d\n", Status); + TRACE("SYSTEM hive %s\n", (Status ? "loaded" : "not loaded")); /* Load NLS data, OEM font, and prepare boot drivers list */ Status = WinLdrScanSystemHive(LoaderBlock, BootPath); - TRACE("SYSTEM hive scanned with status %d\n", Status); + TRACE("SYSTEM hive %s\n", (Status ? "scanned" : "not scanned")); /* Finish loading */ LoadAndBootWindowsCommon(OperatingSystemVersion,

1 0

[hbelusca] 58970: [KDROSDBG-NTOS] Put the 3 helper COM functions into KDBG directly.
by hbelusca＠svn.reactos.org 08 May '13

08 May '13

Author: hbelusca Date: Wed May 8 15:36:38 2013 New Revision: 58970 URL: http://svn.reactos.org/svn/reactos?rev=58970&view=rev Log: [KDROSDBG-NTOS] Put the 3 helper COM functions into KDBG directly. Added: branches/kd++/ntoskrnl/kd/arm/ branches/kd++/ntoskrnl/kd/arm/kdbg.c - copied, changed from r58964, branches/kd++/drivers/base/kdrosdbg/arm/kdbg.c branches/kd++/ntoskrnl/kd/i386/kdbg.c - copied, changed from r58964, branches/kd++/drivers/base/kdrosdbg/i386/kdbg.c Removed: branches/kd++/drivers/base/kdrosdbg/arm/ branches/kd++/drivers/base/kdrosdbg/i386/ Modified: branches/kd++/drivers/base/kdrosdbg/CMakeLists.txt branches/kd++/drivers/base/kdrosdbg/kdrosdbg.spec branches/kd++/ntoskrnl/CMakeLists.txt Modified: branches/kd++/drivers/base/kdrosdbg/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/drivers/base/kdrosdbg/… ============================================================================== --- branches/kd++/drivers/base/kdrosdbg/CMakeLists.txt [iso-8859-1] (original) +++ branches/kd++/drivers/base/kdrosdbg/CMakeLists.txt [iso-8859-1] Wed May 8 15:36:38 2013 @@ -1,13 +1,6 @@ spec2def(kdcom.dll kdrosdbg.spec ADD_IMPORTLIB) -if(ARCH STREQUAL "i386") - list(APPEND SOURCE i386/kdbg.c) -elseif(ARCH STREQUAL "amd64") - list(APPEND SOURCE i386/kdbg.c) -elseif(ARCH STREQUAL "arm") - list(APPEND SOURCE arm/kdbg.c) -endif(ARCH STREQUAL "i386") list(APPEND SOURCE kdrosdbg.c kdrosdbg.rc Modified: branches/kd++/drivers/base/kdrosdbg/kdrosdbg.spec URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/drivers/base/kdrosdbg/… ============================================================================== --- branches/kd++/drivers/base/kdrosdbg/kdrosdbg.spec [iso-8859-1] (original) +++ branches/kd++/drivers/base/kdrosdbg/kdrosdbg.spec [iso-8859-1] Wed May 8 15:36:38 2013 @@ -1,13 +1,8 @@ -1 stdcall KdD0Transition() -2 stdcall KdD3Transition() -3 stdcall KdDebuggerInitialize0(ptr) -4 stdcall KdDebuggerInitialize1(ptr) -5 stdcall KdReceivePacket(long ptr ptr ptr ptr) -6 stdcall KdRestore(long) -7 stdcall KdSave(long) -8 stdcall KdSendPacket(long ptr ptr ptr) - -; Legacy KD -@ stdcall KdPortInitializeEx(ptr long) -@ stdcall KdPortGetByteEx(ptr ptr) -@ stdcall KdPortPutByteEx(ptr long) +@ stdcall KdD0Transition() +@ stdcall KdD3Transition() +@ stdcall KdDebuggerInitialize0(ptr) +@ stdcall KdDebuggerInitialize1(ptr) +@ stdcall KdReceivePacket(long ptr ptr ptr ptr) +@ stdcall KdRestore(long) +@ stdcall KdSave(long) +@ stdcall KdSendPacket(long ptr ptr ptr) Modified: branches/kd++/ntoskrnl/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/ntoskrnl/CMakeLists.tx… ============================================================================== --- branches/kd++/ntoskrnl/CMakeLists.txt [iso-8859-1] (original) +++ branches/kd++/ntoskrnl/CMakeLists.txt [iso-8859-1] Wed May 8 15:36:38 2013 @@ -363,6 +363,7 @@ if(NOT _WINKD_) if(ARCH STREQUAL "i386") list(APPEND SOURCE + kd/i386/kdbg.c kd/i386/kdmemsup.c kd/wrappers/gdbstub.c) if(KDBG) @@ -372,6 +373,7 @@ elseif(ARCH STREQUAL "amd64") list(APPEND SOURCE kd/amd64/kd.c + kd/i386/kdbg.c # Use the x86 file kd/amd64/kdmemsup.c) if(KDBG) list(APPEND ASM_SOURCE kdbg/amd64/kdb_help.S) @@ -379,6 +381,8 @@ kdbg/amd64/i386-dis.c kdbg/amd64/kdb.c) endif() + elseif(ARCH STREQUAL "arm") + list(APPEND SOURCE kd/arm/kdbg.c) elseif(ARCH STREQUAL "powerpc") list(APPEND SOURCE kd/wrappers/gdbstub_powerpc.c) endif() Copied: branches/kd++/ntoskrnl/kd/arm/kdbg.c (from r58964, branches/kd++/drivers/base/kdrosdbg/arm/kdbg.c) URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/ntoskrnl/kd/arm/kdbg.c… ============================================================================== --- branches/kd++/drivers/base/kdrosdbg/arm/kdbg.c [iso-8859-1] (original) +++ branches/kd++/ntoskrnl/kd/arm/kdbg.c [iso-8859-1] Wed May 8 15:36:38 2013 @@ -8,16 +8,8 @@ /* INCLUDES *******************************************************************/ -#define NOEXTAPI -#include <ntifs.h> -#include <arc/arc.h> -#include <halfuncs.h> -#include <windbgkd.h> -#include <ioaccess.h> /* port intrinsics */ -#include <cportlib/cportlib.h> +#include <ntoskrnl.h> #include <arm/peripherals/pl011.h> -#include <stdio.h> - #define NDEBUG #include <debug.h> @@ -32,6 +24,13 @@ #define HACK 24000000 /* REACTOS FUNCTIONS **********************************************************/ + +NTSTATUS +NTAPI +KdDebuggerInitialize1(IN PLOADER_PARAMETER_BLOCK LoaderBlock OPTIONAL) +{ + return STATUS_NOT_IMPLEMENTED; +} BOOLEAN NTAPI Copied: branches/kd++/ntoskrnl/kd/i386/kdbg.c (from r58964, branches/kd++/drivers/base/kdrosdbg/i386/kdbg.c) URL: http://svn.reactos.org/svn/reactos/branches/kd%2B%2B/ntoskrnl/kd/i386/kdbg.… ============================================================================== --- branches/kd++/drivers/base/kdrosdbg/i386/kdbg.c [iso-8859-1] (original) +++ branches/kd++/ntoskrnl/kd/i386/kdbg.c [iso-8859-1] Wed May 8 15:36:38 2013 @@ -9,15 +9,7 @@ /* INCLUDES *****************************************************************/ -#define NOEXTAPI -#include <ntifs.h> -#include <arc/arc.h> -#include <halfuncs.h> -#include <windbgkd.h> -#include <ioaccess.h> /* port intrinsics */ -#include <cportlib/cportlib.h> -#include <stdio.h> - +#include <ntoskrnl.h> #define NDEBUG #include <debug.h> @@ -45,6 +37,14 @@ /* REACTOS FUNCTIONS **********************************************************/ + +NTSTATUS +NTAPI +KdDebuggerInitialize1( + IN PLOADER_PARAMETER_BLOCK LoaderBlock OPTIONAL) +{ + return STATUS_NOT_IMPLEMENTED; +} BOOLEAN NTAPI

1 0

[akhaldi] 58969: [AFD] * Mark SelectTimeout as a KDEFERRED_ROUTINE and fix its calling convention. This fixes a potential stack corruption. * Brought to you by Nikolay Borisov and the MSVC static a...
by akhaldi＠svn.reactos.org 08 May '13

08 May '13

Author: akhaldi Date: Wed May 8 12:12:15 2013 New Revision: 58969 URL: http://svn.reactos.org/svn/reactos?rev=58969&view=rev Log: [AFD] * Mark SelectTimeout as a KDEFERRED_ROUTINE and fix its calling convention. This fixes a potential stack corruption. * Brought to you by Nikolay Borisov and the MSVC static analyzer ;) CORE-7171 #resolve Modified: trunk/reactos/drivers/network/afd/afd/select.c Modified: trunk/reactos/drivers/network/afd/afd/select.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/network/afd/afd/se… ============================================================================== --- trunk/reactos/drivers/network/afd/afd/select.c [iso-8859-1] (original) +++ trunk/reactos/drivers/network/afd/afd/select.c [iso-8859-1] Wed May 8 12:12:15 2013 @@ -91,7 +91,8 @@ AFD_DbgPrint(MID_TRACE,("Done\n")); } -static VOID SelectTimeout( PKDPC Dpc, +static KDEFERRED_ROUTINE SelectTimeout; +static VOID NTAPI SelectTimeout( PKDPC Dpc, PVOID DeferredContext, PVOID SystemArgument1, PVOID SystemArgument2 ) { @@ -235,9 +236,7 @@ KeInitializeTimerEx( &Poll->Timer, NotificationTimer ); - KeInitializeDpc( (PRKDPC)&Poll->TimeoutDpc, - (PKDEFERRED_ROUTINE)SelectTimeout, - Poll ); + KeInitializeDpc( (PRKDPC)&Poll->TimeoutDpc, SelectTimeout, Poll ); InsertTailList( &DeviceExt->Polls, &Poll->ListEntry );

1 0

[akhaldi] 58968: [BEEP] * Properly mark some unreferenced parameters as such. [AFD] * Properly fix a debug print specifier.
by akhaldi＠svn.reactos.org 08 May '13

08 May '13

Author: akhaldi Date: Wed May 8 11:55:37 2013 New Revision: 58968 URL: http://svn.reactos.org/svn/reactos?rev=58968&view=rev Log: [BEEP] * Properly mark some unreferenced parameters as such. [AFD] * Properly fix a debug print specifier. Modified: trunk/reactos/drivers/base/beep/beep.c trunk/reactos/drivers/network/afd/afd/info.c Modified: trunk/reactos/drivers/base/beep/beep.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/base/beep/beep.c?r… ============================================================================== --- trunk/reactos/drivers/base/beep/beep.c [iso-8859-1] (original) +++ trunk/reactos/drivers/base/beep/beep.c [iso-8859-1] Wed May 8 11:55:37 2013 @@ -38,6 +38,10 @@ { PDEVICE_EXTENSION DeviceExtension = DeviceObject->DeviceExtension; + UNREFERENCED_PARAMETER(Dpc); + UNREFERENCED_PARAMETER(SystemArgument1); + UNREFERENCED_PARAMETER(SystemArgument2); + /* Stop the beep */ HalMakeBeep(0); @@ -367,6 +371,8 @@ PDEVICE_OBJECT DeviceObject; UNICODE_STRING DeviceName = RTL_CONSTANT_STRING(L"\\Device\\Beep"); NTSTATUS Status; + + UNREFERENCED_PARAMETER(RegistryPath); /* Create the device */ Status = IoCreateDevice(DriverObject, Modified: trunk/reactos/drivers/network/afd/afd/info.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/network/afd/afd/in… ============================================================================== --- trunk/reactos/drivers/network/afd/afd/info.c [iso-8859-1] (original) +++ trunk/reactos/drivers/network/afd/afd/info.c [iso-8859-1] Wed May 8 11:55:37 2013 @@ -116,7 +116,7 @@ _SEH2_TRY { switch (InfoReq->InformationClass) { case AFD_INFO_BLOCKING_MODE: - AFD_DbgPrint(MID_TRACE,("Blocking mode set to %c\n", InfoReq->Information.Boolean)); + AFD_DbgPrint(MID_TRACE,("Blocking mode set to %u\n", InfoReq->Information.Boolean)); FCB->NonBlocking = InfoReq->Information.Boolean; break; case AFD_INFO_INLINING_MODE:

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs