Ros-diffs

ros-diffs@reactos.org

81390 discussions

[gadamopoulos] 55745: [win32k] - Peb->ProcessParameters->DesktopInfo must be probed and captured with SEH before used in win32k
by gadamopoulos＠svn.reactos.org 20 Feb '12

20 Feb '12

Author: gadamopoulos Date: Mon Feb 20 10:51:07 2012 New Revision: 55745 URL: http://svn.reactos.org/svn/reactos?rev=55745&view=rev Log: [win32k] - Peb->ProcessParameters->DesktopInfo must be probed and captured with SEH before used in win32k Modified: trunk/reactos/subsystems/win32/win32k/main/dllmain.c Modified: trunk/reactos/subsystems/win32/win32k/main/dllmain.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/ma… ============================================================================== --- trunk/reactos/subsystems/win32/win32k/main/dllmain.c [iso-8859-1] (original) +++ trunk/reactos/subsystems/win32/win32k/main/dllmain.c [iso-8859-1] Mon Feb 20 10:51:07 2012 @@ -238,7 +238,7 @@ HWINSTA hWinSta = NULL; PCLIENTINFO pci; HDESK hDesk = NULL; - PUNICODE_STRING DesktopPath; + UNICODE_STRING DesktopPath; PDESKTOP pdesk; PRTL_USER_PROCESS_PARAMETERS ProcessParams = Process->Peb->ProcessParameters; @@ -297,11 +297,24 @@ * inherit the thread desktop and process window station (if not yet inherited) from the process startup * info structure. See documentation of CreateProcess() */ - DesktopPath = (ProcessParams ? ((ProcessParams->DesktopInfo.Length > 0) ? &ProcessParams->DesktopInfo : NULL) : NULL); + Status = STATUS_UNSUCCESSFUL; + if(ProcessParams && ProcessParams->DesktopInfo.Length > 0) + { + Status = IntSafeCopyUnicodeStringTerminateNULL(&DesktopPath, &ProcessParams->DesktopInfo); + } + if(!NT_SUCCESS(Status)) + { + RtlInitUnicodeString(&DesktopPath, NULL); + } + Status = IntParseDesktopPath(Process, - DesktopPath, + &DesktopPath, &hWinSta, &hDesk); + + if (DesktopPath.Buffer) + ExFreePoolWithTag(DesktopPath.Buffer, TAG_STRING); + if(!NT_SUCCESS(Status)) { ERR_CH(UserThread, "Failed to assign default dekstop and winsta to process\n"); @@ -545,6 +558,7 @@ NT_ROF(InitKeyboardImpl()); NT_ROF(MsqInitializeImpl()); NT_ROF(InitTimerImpl()); + NT_ROF(InitDCEImpl()); /* Initialize FreeType library */ if (!InitFontSupport())

1 0

[gadamopoulos] 55744: [win32k] - Remove an unused function
by gadamopoulos＠svn.reactos.org 20 Feb '12

20 Feb '12

Author: gadamopoulos Date: Mon Feb 20 10:47:13 2012 New Revision: 55744 URL: http://svn.reactos.org/svn/reactos?rev=55744&view=rev Log: [win32k] - Remove an unused function Modified: trunk/reactos/subsystems/win32/win32k/ntuser/input.c Modified: trunk/reactos/subsystems/win32/win32k/ntuser/input.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/nt… ============================================================================== --- trunk/reactos/subsystems/win32/win32k/ntuser/input.c [iso-8859-1] (original) +++ trunk/reactos/subsystems/win32/win32k/ntuser/input.c [iso-8859-1] Mon Feb 20 10:47:13 2012 @@ -329,17 +329,6 @@ } KeInitializeTimer(MasterTimer); - return STATUS_SUCCESS; -} - -/* - * CleanupInputImp - * - * Cleans input implementation - */ -NTSTATUS FASTCALL -CleanupInputImp(VOID) -{ return STATUS_SUCCESS; }

1 0

[cgutman] 55743: [NTOSKRNL] - First check if a driver object exists before trying to load the service module to properly handle boot drivers
by cgutman＠svn.reactos.org 20 Feb '12

20 Feb '12

Author: cgutman Date: Mon Feb 20 10:24:14 2012 New Revision: 55743 URL: http://svn.reactos.org/svn/reactos?rev=55743&view=rev Log: [NTOSKRNL] - First check if a driver object exists before trying to load the service module to properly handle boot drivers Modified: trunk/reactos/ntoskrnl/io/iomgr/driver.c Modified: trunk/reactos/ntoskrnl/io/iomgr/driver.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/io/iomgr/driver.c… ============================================================================== --- trunk/reactos/ntoskrnl/io/iomgr/driver.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/io/iomgr/driver.c [iso-8859-1] Mon Feb 20 10:24:14 2012 @@ -560,35 +560,25 @@ ServiceName.MaximumLength = ServiceName.Length = (USHORT)wcslen(Filters) * sizeof(WCHAR); - /* Load and initialize the filter driver */ - Status = IopLoadServiceModule(&ServiceName, &ModuleObject); - if (Status != STATUS_IMAGE_ALREADY_LOADED) - { - if (!NT_SUCCESS(Status)) - continue; - - Status = IopInitializeDriverModule(DeviceNode, ModuleObject, &ServiceName, - FALSE, &DriverObject); - if (!NT_SUCCESS(Status)) - continue; - } - else - { - /* get existing DriverObject pointer */ - Status = IopGetDriverObject( - &DriverObject, - &ServiceName, - FALSE); - if (!NT_SUCCESS(Status)) - { - DPRINT1("IopGetDriverObject() returned status 0x%08x!\n", Status); - continue; - } - } - - Status = IopInitializeDevice(DeviceNode, DriverObject); - if (!NT_SUCCESS(Status)) - continue; + Status = IopGetDriverObject(&DriverObject, + &ServiceName, + FALSE); + if (!NT_SUCCESS(Status)) + { + /* Load and initialize the filter driver */ + Status = IopLoadServiceModule(&ServiceName, &ModuleObject); + if (!NT_SUCCESS(Status)) + continue; + + Status = IopInitializeDriverModule(DeviceNode, ModuleObject, &ServiceName, + FALSE, &DriverObject); + if (!NT_SUCCESS(Status)) + continue; + } + + Status = IopInitializeDevice(DeviceNode, DriverObject); + if (!NT_SUCCESS(Status)) + continue; } return STATUS_SUCCESS;

1 0

[cgutman] 55742: [USBEHCI] - When releasing a low or full speed device, set the EHCI_PRT_RELEASEOWNERSHIP bit with the current port status so that any change bits are acknowledged - Fixes detecting...
by cgutman＠svn.reactos.org 20 Feb '12

20 Feb '12

Author: cgutman Date: Mon Feb 20 09:23:33 2012 New Revision: 55742 URL: http://svn.reactos.org/svn/reactos?rev=55742&view=rev Log: [USBEHCI] - When releasing a low or full speed device, set the EHCI_PRT_RELEASEOWNERSHIP bit with the current port status so that any change bits are acknowledged - Fixes detecting new devices after a companion controller handoff Modified: trunk/reactos/drivers/usb/usbehci/hardware.cpp Modified: trunk/reactos/drivers/usb/usbehci/hardware.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/usb/usbehci/hardwa… ============================================================================== --- trunk/reactos/drivers/usb/usbehci/hardware.cpp [iso-8859-1] (original) +++ trunk/reactos/drivers/usb/usbehci/hardware.cpp [iso-8859-1] Mon Feb 20 09:23:33 2012 @@ -963,7 +963,7 @@ if (PortStatus & EHCI_PRT_SLOWSPEEDLINE) { DPRINT1("Non HighSpeed device. Releasing Ownership\n"); - EHCI_WRITE_REGISTER_ULONG(EHCI_PORTSC + (4 * PortIndex), EHCI_PRT_RELEASEOWNERSHIP); + EHCI_WRITE_REGISTER_ULONG(EHCI_PORTSC + (4 * PortIndex), PortStatus | EHCI_PRT_RELEASEOWNERSHIP); return STATUS_DEVICE_NOT_CONNECTED; } @@ -1132,7 +1132,7 @@ if (Value & EHCI_PRT_SLOWSPEEDLINE) { DPRINT1("Non HighSpeed device. Releasing Ownership\n"); - EHCI_WRITE_REGISTER_ULONG(EHCI_PORTSC + (4 * PortId), EHCI_PRT_RELEASEOWNERSHIP); + EHCI_WRITE_REGISTER_ULONG(EHCI_PORTSC + (4 * PortId), Value | EHCI_PRT_RELEASEOWNERSHIP); return STATUS_DEVICE_NOT_CONNECTED; } @@ -1478,9 +1478,6 @@ { DPRINT1("Device connected on port %d\n", i); - // - //FIXME: Determine device speed - // if (This->m_Capabilities.HCSParams.CHCCount) { if (PortStatus & EHCI_PRT_ENABLED) @@ -1491,7 +1488,7 @@ if (PortStatus & EHCI_PRT_SLOWSPEEDLINE) { DPRINT1("Non HighSpeed device connected. Release ownership\n"); - This->EHCI_WRITE_REGISTER_ULONG(EHCI_PORTSC + (4 * i), EHCI_PRT_RELEASEOWNERSHIP); + This->EHCI_WRITE_REGISTER_ULONG(EHCI_PORTSC + (4 * i), PortStatus | EHCI_PRT_RELEASEOWNERSHIP); continue; } }

1 0

[cgutman] 55741: [USBOHCI] - Finally fix the OHCI reset bug for real and remove hacks
by cgutman＠svn.reactos.org 20 Feb '12

20 Feb '12

Author: cgutman Date: Mon Feb 20 09:00:09 2012 New Revision: 55741 URL: http://svn.reactos.org/svn/reactos?rev=55741&view=rev Log: [USBOHCI] - Finally fix the OHCI reset bug for real and remove hacks Modified: trunk/reactos/drivers/usb/usbohci/hardware.cpp Modified: trunk/reactos/drivers/usb/usbohci/hardware.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/usb/usbohci/hardwa… ============================================================================== --- trunk/reactos/drivers/usb/usbohci/hardware.cpp [iso-8859-1] (original) +++ trunk/reactos/drivers/usb/usbohci/hardware.cpp [iso-8859-1] Mon Feb 20 09:00:09 2012 @@ -1353,35 +1353,9 @@ // WRITE_REGISTER_ULONG((PULONG)((PUCHAR)m_Base + OHCI_RH_PORT_STATUS(PortId)), OHCI_RH_PORTSTATUS_PRS); - do - { - // - // read port status - // - Value = READ_REGISTER_ULONG((PULONG)((PUCHAR)m_Base + OHCI_RH_PORT_STATUS(PortId))); - - if ((Value & OHCI_RH_PORTSTATUS_PRS) == 0 && - (Value & OHCI_RH_PORTSTATUS_PRSC) != 0) - { - // - // reset is complete - // - break; - } - - // - // wait a bit - // - KeStallExecutionProcessor(100); - } while(TRUE); - - if (m_SCECallBack != NULL) - { - // - // issue callback - // - m_SCECallBack(m_SCEContext); - } + // + // an interrupt signals the reset completion + // return STATUS_SUCCESS; } return STATUS_SUCCESS;

1 0

[cgutman] 55740: [USBOHCI] - Set the power switching configuration into a known state when initializing the controller
by cgutman＠svn.reactos.org 20 Feb '12

20 Feb '12

Author: cgutman Date: Mon Feb 20 08:41:19 2012 New Revision: 55740 URL: http://svn.reactos.org/svn/reactos?rev=55740&view=rev Log: [USBOHCI] - Set the power switching configuration into a known state when initializing the controller Modified: trunk/reactos/drivers/usb/usbohci/hardware.cpp Modified: trunk/reactos/drivers/usb/usbohci/hardware.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/usb/usbohci/hardwa… ============================================================================== --- trunk/reactos/drivers/usb/usbohci/hardware.cpp [iso-8859-1] (original) +++ trunk/reactos/drivers/usb/usbohci/hardware.cpp [iso-8859-1] Mon Feb 20 08:41:19 2012 @@ -595,7 +595,26 @@ // // no over current protection // - WRITE_REGISTER_ULONG((PULONG)((PUCHAR)m_Base + OHCI_RH_DESCRIPTOR_A_OFFSET), Descriptor | OHCI_RH_NO_OVER_CURRENT_PROTECTION); + Descriptor |= OHCI_RH_NO_OVER_CURRENT_PROTECTION; + + // + // power switching on + // + Descriptor &= ~OHCI_RH_NO_POWER_SWITCHING; + + // + // control each port power independently (disabled until it's supported correctly) + // +#if 0 + Descriptor |= OHCI_RH_POWER_SWITCHING_MODE; +#else + Descriptor &= ~OHCI_RH_POWER_SWITCHING_MODE; +#endif + + // + // write the configuration back + // + WRITE_REGISTER_ULONG((PULONG)((PUCHAR)m_Base + OHCI_RH_DESCRIPTOR_A_OFFSET), Descriptor); // // enable power on all ports

1 0

[cgutman] 55739: [USBOHCI] - Queue a work item to handle an enable status change condition
by cgutman＠svn.reactos.org 20 Feb '12

20 Feb '12

Author: cgutman Date: Mon Feb 20 08:25:38 2012 New Revision: 55739 URL: http://svn.reactos.org/svn/reactos?rev=55739&view=rev Log: [USBOHCI] - Queue a work item to handle an enable status change condition Modified: trunk/reactos/drivers/usb/usbohci/hardware.cpp Modified: trunk/reactos/drivers/usb/usbohci/hardware.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/usb/usbohci/hardwa… ============================================================================== --- trunk/reactos/drivers/usb/usbohci/hardware.cpp [iso-8859-1] (original) +++ trunk/reactos/drivers/usb/usbohci/hardware.cpp [iso-8859-1] Mon Feb 20 08:25:38 2012 @@ -1634,6 +1634,18 @@ // QueueSCEWorkItem = TRUE; } + else if (PortStatus & OHCI_RH_PORTSTATUS_PESC) + { + // + // device disconnected or some error condition + // + ASSERT(!(PortStatus & OHCI_RH_PORTSTATUS_PES)); + + // + // work to do + // + QueueSCEWorkItem = TRUE; + } else if (PortStatus & OHCI_RH_PORTSTATUS_PRSC) { //

1 0

[cgutman] 55738: [USBOHCI] - Don't clear extra change bits
by cgutman＠svn.reactos.org 20 Feb '12

20 Feb '12

Author: cgutman Date: Mon Feb 20 08:09:31 2012 New Revision: 55738 URL: http://svn.reactos.org/svn/reactos?rev=55738&view=rev Log: [USBOHCI] - Don't clear extra change bits Modified: trunk/reactos/drivers/usb/usbohci/hardware.cpp Modified: trunk/reactos/drivers/usb/usbohci/hardware.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/usb/usbohci/hardwa… ============================================================================== --- trunk/reactos/drivers/usb/usbohci/hardware.cpp [iso-8859-1] (original) +++ trunk/reactos/drivers/usb/usbohci/hardware.cpp [iso-8859-1] Mon Feb 20 08:09:31 2012 @@ -1217,7 +1217,7 @@ // // clear change bits // - WRITE_REGISTER_ULONG((PULONG)((PUCHAR)m_Base + OHCI_RH_PORT_STATUS(PortId)), OHCI_RH_PORTSTATUS_CSC | OHCI_RH_PORTSTATUS_PESC); + WRITE_REGISTER_ULONG((PULONG)((PUCHAR)m_Base + OHCI_RH_PORT_STATUS(PortId)), Value & (OHCI_RH_PORTSTATUS_CSC | OHCI_RH_PORTSTATUS_PESC)); // // wait for port to stabilize

1 0

[ion] 55737: [NTOSKRNL]: Fix the zombie fix. Should fix toolhelp tests. [NTOSKRNL]: If you're going to fake success when doing access checks, also grant the rights that would normally be refused, f...
by ion＠svn.reactos.org 20 Feb '12

20 Feb '12

Author: ion Date: Mon Feb 20 07:30:26 2012 New Revision: 55737 URL: http://svn.reactos.org/svn/reactos?rev=55737&view=rev Log: [NTOSKRNL]: Fix the zombie fix. Should fix toolhelp tests. [NTOSKRNL]: If you're going to fake success when doing access checks, also grant the rights that would normally be refused, for consistency's sake. Should fix a bunch of the kernel32:synch tests (which have nothing to do with synch...). Modified: trunk/reactos/ntoskrnl/ex/sysinfo.c trunk/reactos/ntoskrnl/se/semgr.c Modified: trunk/reactos/ntoskrnl/ex/sysinfo.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ex/sysinfo.c?rev=… ============================================================================== --- trunk/reactos/ntoskrnl/ex/sysinfo.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/ex/sysinfo.c [iso-8859-1] Mon Feb 20 07:30:26 2012 @@ -721,8 +721,6 @@ SystemProcess = PsIdleProcess; Process = SystemProcess; Current = (PUCHAR) Spi; - CurrentSize = 0; - ImageNameMaximumLength = 0; do { @@ -733,7 +731,10 @@ !(Process->ActiveThreads) && (IsListEmpty(&Process->Pcb.ThreadListHead))) { - DPRINT1("Skipping zombie\n"); + DPRINT1("Process %p (%s:%lx) is a zombie\n", + Process, Process->ImageFileName, Process->UniqueProcessId); + CurrentSize = 0; + ImageNameMaximumLength = 0; goto Skip; } Modified: trunk/reactos/ntoskrnl/se/semgr.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/se/semgr.c?rev=55… ============================================================================== --- trunk/reactos/ntoskrnl/se/semgr.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/se/semgr.c [iso-8859-1] Mon Feb 20 07:30:26 2012 @@ -705,6 +705,7 @@ *GrantedAccess, DesiredAccess, GenericMapping); //*AccessStatus = STATUS_ACCESS_DENIED; //return FALSE; + *GrantedAccess = DesiredAccess; *AccessStatus = STATUS_SUCCESS; return TRUE; }

1 0

[ion] 55736: [NDK]: Fix completely messed up SYSTEM_PROCESS_INFORMATION and SYSTEM_THREAD_INFORMATION classes, which were causing the kernel to return totally wrong data for NtQuerySystemInformatio...
by ion＠svn.reactos.org 20 Feb '12

20 Feb '12

Author: ion Date: Mon Feb 20 06:45:02 2012 New Revision: 55736 URL: http://svn.reactos.org/svn/reactos?rev=55736&view=rev Log: [NDK]: Fix completely messed up SYSTEM_PROCESS_INFORMATION and SYSTEM_THREAD_INFORMATION classes, which were causing the kernel to return totally wrong data for NtQuerySystemInformation(SystemProcessInformation). Fixes Winetests, I assume Taskmgr, and other similar system tools. Modified: trunk/reactos/include/ndk/extypes.h Modified: trunk/reactos/include/ndk/extypes.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/ndk/extypes.h?rev=… ============================================================================== --- trunk/reactos/include/ndk/extypes.h [iso-8859-1] (original) +++ trunk/reactos/include/ndk/extypes.h [iso-8859-1] Mon Feb 20 06:45:02 2012 @@ -843,7 +843,9 @@ ULONG ContextSwitches; ULONG ThreadState; ULONG WaitReason; + ULONG PadPadAlignment; } SYSTEM_THREAD_INFORMATION, *PSYSTEM_THREAD_INFORMATION; +C_ASSERT(sizeof(SYSTEM_THREAD_INFORMATION) == 0x40); // Must be 8-byte aligned typedef struct _SYSTEM_PROCESS_INFORMATION { @@ -890,10 +892,11 @@ LARGE_INTEGER ReadTransferCount; LARGE_INTEGER WriteTransferCount; LARGE_INTEGER OtherTransferCount; - - SYSTEM_THREAD_INFORMATION TH[1]; +// SYSTEM_THREAD_INFORMATION TH[1]; } SYSTEM_PROCESS_INFORMATION, *PSYSTEM_PROCESS_INFORMATION; - +C_ASSERT(sizeof(SYSTEM_PROCESS_INFORMATION) == 0xB8); // Must be 8-byte aligned + +// // Class 6 typedef struct _SYSTEM_CALL_COUNT_INFORMATION {

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs