Ros-diffs

ros-diffs@reactos.org

81390 discussions

[cgutman] 54732: [NTOSKRNL] - Don't wait to flush dirty pages during shutdown - This is a hack to fix KVM
by cgutman＠svn.reactos.org 21 Dec '11

21 Dec '11

Author: cgutman Date: Wed Dec 21 20:19:20 2011 New Revision: 54732 URL: http://svn.reactos.org/svn/reactos?rev=54732&view=rev Log: [NTOSKRNL] - Don't wait to flush dirty pages during shutdown - This is a hack to fix KVM Modified: trunk/reactos/ntoskrnl/po/power.c Modified: trunk/reactos/ntoskrnl/po/power.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/po/power.c?rev=54… ============================================================================== --- trunk/reactos/ntoskrnl/po/power.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/po/power.c [iso-8859-1] Wed Dec 21 20:19:20 2011 @@ -902,7 +902,7 @@ #ifndef NEWCC /* Flush dirty cache pages */ - CcRosFlushDirtyPages(-1, &Dummy, TRUE); + CcRosFlushDirtyPages(-1, &Dummy, FALSE); //HACK: We really should wait here! #else Dummy = 0; #endif

1 0

[cgutman] 54731: [FASTFAT] - Remove the old page file hack
by cgutman＠svn.reactos.org 21 Dec '11

21 Dec '11

Author: cgutman Date: Wed Dec 21 19:58:42 2011 New Revision: 54731 URL: http://svn.reactos.org/svn/reactos?rev=54731&view=rev Log: [FASTFAT] - Remove the old page file hack Modified: trunk/reactos/drivers/filesystems/fastfat/rw.c Modified: trunk/reactos/drivers/filesystems/fastfat/rw.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/fastfa… ============================================================================== --- trunk/reactos/drivers/filesystems/fastfat/rw.c [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/fastfat/rw.c [iso-8859-1] Wed Dec 21 19:58:42 2011 @@ -560,17 +560,6 @@ DPRINT("<%wZ>\n", &Fcb->PathNameU); - if (Fcb->Flags & FCB_IS_PAGE_FILE) - { - PFATINFO FatInfo = &IrpContext->DeviceExt->FatInfo; - IrpContext->Stack->Parameters.Read.ByteOffset.QuadPart += FatInfo->dataStart * FatInfo->BytesPerSector; - IoSkipCurrentIrpStackLocation(IrpContext->Irp); - DPRINT("Read from page file, disk offset %I64x\n", IrpContext->Stack->Parameters.Read.ByteOffset.QuadPart); - Status = IoCallDriver(IrpContext->DeviceExt->StorageDevice, IrpContext->Irp); - VfatFreeIrpContext(IrpContext); - return Status; - } - ByteOffset = IrpContext->Stack->Parameters.Read.ByteOffset; Length = IrpContext->Stack->Parameters.Read.Length; BytesPerSector = IrpContext->DeviceExt->FatInfo.BytesPerSector; @@ -772,17 +761,6 @@ ASSERT(Fcb); DPRINT("<%wZ>\n", &Fcb->PathNameU); - - if (Fcb->Flags & FCB_IS_PAGE_FILE) - { - PFATINFO FatInfo = &IrpContext->DeviceExt->FatInfo; - IrpContext->Stack->Parameters.Write.ByteOffset.QuadPart += FatInfo->dataStart * FatInfo->BytesPerSector; - IoSkipCurrentIrpStackLocation(IrpContext->Irp); - DPRINT("Write to page file, disk offset %I64x\n", IrpContext->Stack->Parameters.Write.ByteOffset.QuadPart); - Status = IoCallDriver(IrpContext->DeviceExt->StorageDevice, IrpContext->Irp); - VfatFreeIrpContext(IrpContext); - return Status; - } /* fail if file is a directory and no paged read */ if (*Fcb->Attributes & FILE_ATTRIBUTE_DIRECTORY && !(IrpContext->Irp->Flags & IRP_PAGING_IO))

1 0

[cgutman] 54730: [NTOSKRNL] - Add a wait parameter to CcRosFlushDirtyPages and only block on the segment locks of it is safe
by cgutman＠svn.reactos.org 21 Dec '11

21 Dec '11

Author: cgutman Date: Wed Dec 21 19:46:07 2011 New Revision: 54730 URL: http://svn.reactos.org/svn/reactos?rev=54730&view=rev Log: [NTOSKRNL] - Add a wait parameter to CcRosFlushDirtyPages and only block on the segment locks of it is safe Modified: trunk/reactos/ntoskrnl/cc/view.c trunk/reactos/ntoskrnl/include/internal/cc.h trunk/reactos/ntoskrnl/mm/mminit.c trunk/reactos/ntoskrnl/po/power.c Modified: trunk/reactos/ntoskrnl/cc/view.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/cc/view.c?rev=547… ============================================================================== --- trunk/reactos/ntoskrnl/cc/view.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/cc/view.c [iso-8859-1] Wed Dec 21 19:46:07 2011 @@ -175,43 +175,23 @@ NTSTATUS NTAPI -CcRosFlushDirtyPages(ULONG Target, PULONG Count) +CcRosFlushDirtyPages(ULONG Target, PULONG Count, BOOLEAN Wait) { PLIST_ENTRY current_entry; PCACHE_SEGMENT current; ULONG PagesPerSegment; BOOLEAN Locked; NTSTATUS Status; - static ULONG WriteCount[4] = {0, 0, 0, 0}; - ULONG NewTarget; + LARGE_INTEGER ZeroTimeout; DPRINT("CcRosFlushDirtyPages(Target %d)\n", Target); (*Count) = 0; + ZeroTimeout.QuadPart = 0; KeEnterCriticalRegion(); KeAcquireGuardedMutex(&ViewLock); - WriteCount[0] = WriteCount[1]; - WriteCount[1] = WriteCount[2]; - WriteCount[2] = WriteCount[3]; - WriteCount[3] = 0; - - NewTarget = WriteCount[0] + WriteCount[1] + WriteCount[2]; - - if (NewTarget < DirtyPageCount) - { - NewTarget = (DirtyPageCount - NewTarget + 3) / 4; - WriteCount[0] += NewTarget; - WriteCount[1] += NewTarget; - WriteCount[2] += NewTarget; - WriteCount[3] += NewTarget; - } - - NewTarget = WriteCount[0]; - - Target = max(NewTarget, Target); - current_entry = DirtySegmentListHead.Flink; if (current_entry == &DirtySegmentListHead) { @@ -225,17 +205,23 @@ current_entry = current_entry->Flink; Locked = current->Bcb->Callbacks->AcquireForLazyWrite( - current->Bcb->LazyWriteContext, TRUE); + current->Bcb->LazyWriteContext, Wait); if (!Locked) { continue; } - KeWaitForSingleObject(&current->Mutex, - Executive, - KernelMode, - FALSE, - NULL); + Status = KeWaitForSingleObject(&current->Mutex, + Executive, + KernelMode, + FALSE, + Wait ? NULL : &ZeroTimeout); + if (Status != STATUS_SUCCESS) + { + current->Bcb->Callbacks->ReleaseFromLazyWrite( + current->Bcb->LazyWriteContext); + continue; + } ASSERT(current->Dirty); if (current->ReferenceCount > 1) @@ -268,11 +254,6 @@ KeAcquireGuardedMutex(&ViewLock); current_entry = DirtySegmentListHead.Flink; - } - - if (*Count < NewTarget) - { - WriteCount[1] += (NewTarget - *Count); } KeReleaseGuardedMutex(&ViewLock); @@ -374,7 +355,7 @@ if (Target > 0 && !FlushedPages) { /* Flush dirty pages to disk */ - CcRosFlushDirtyPages(Target, &PagesFreed); + CcRosFlushDirtyPages(Target, &PagesFreed, FALSE); FlushedPages = TRUE; /* We can only swap as many pages as we flushed */ Modified: trunk/reactos/ntoskrnl/include/internal/cc.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/include/internal/… ============================================================================== --- trunk/reactos/ntoskrnl/include/internal/cc.h [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/include/internal/cc.h [iso-8859-1] Wed Dec 21 19:46:07 2011 @@ -261,7 +261,8 @@ NTAPI CcRosFlushDirtyPages( ULONG Target, - PULONG Count + PULONG Count, + BOOLEAN Wait ); VOID Modified: trunk/reactos/ntoskrnl/mm/mminit.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/mminit.c?rev=5… ============================================================================== --- trunk/reactos/ntoskrnl/mm/mminit.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/mm/mminit.c [iso-8859-1] Wed Dec 21 19:46:07 2011 @@ -306,7 +306,7 @@ #ifndef NEWCC // XXX arty -- we flush when evicting pages or destorying cache // sections. - CcRosFlushDirtyPages(128, &PagesWritten); + CcRosFlushDirtyPages(128, &PagesWritten, FALSE); #endif } } Modified: trunk/reactos/ntoskrnl/po/power.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/po/power.c?rev=54… ============================================================================== --- trunk/reactos/ntoskrnl/po/power.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/po/power.c [iso-8859-1] Wed Dec 21 19:46:07 2011 @@ -902,7 +902,7 @@ #ifndef NEWCC /* Flush dirty cache pages */ - CcRosFlushDirtyPages(-1, &Dummy); + CcRosFlushDirtyPages(-1, &Dummy, TRUE); #else Dummy = 0; #endif

1 0

[cgutman] 54729: [NTOSKRNL] - Change the method of segment locking from a push lock to a mutex - Fixes the 'OldValue.Locked' assertion failure
by cgutman＠svn.reactos.org 21 Dec '11

21 Dec '11

Author: cgutman Date: Wed Dec 21 19:08:59 2011 New Revision: 54729 URL: http://svn.reactos.org/svn/reactos?rev=54729&view=rev Log: [NTOSKRNL] - Change the method of segment locking from a push lock to a mutex - Fixes the 'OldValue.Locked' assertion failure Modified: trunk/reactos/ntoskrnl/cc/pin.c trunk/reactos/ntoskrnl/cc/view.c trunk/reactos/ntoskrnl/include/internal/cc.h Modified: trunk/reactos/ntoskrnl/cc/pin.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/cc/pin.c?rev=5472… ============================================================================== --- trunk/reactos/ntoskrnl/cc/pin.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/cc/pin.c [iso-8859-1] Wed Dec 21 19:08:59 2011 @@ -240,8 +240,11 @@ IoStatus->Information = 0; if (WriteThrough) { - KeEnterCriticalRegion(); - ExAcquirePushLockExclusive(&iBcb->CacheSegment->Lock); + KeWaitForSingleObject(&iBcb->CacheSegment->Mutex, + Executive, + KernelMode, + FALSE, + NULL); if (iBcb->CacheSegment->Dirty) { IoStatus->Status = CcRosFlushCacheSegment(iBcb->CacheSegment); @@ -250,8 +253,7 @@ { IoStatus->Status = STATUS_SUCCESS; } - ExReleasePushLockExclusive(&iBcb->CacheSegment->Lock); - KeLeaveCriticalRegion(); + KeReleaseMutex(&iBcb->CacheSegment->Mutex, 0); } else { Modified: trunk/reactos/ntoskrnl/cc/view.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/cc/view.c?rev=547… ============================================================================== --- trunk/reactos/ntoskrnl/cc/view.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/cc/view.c [iso-8859-1] Wed Dec 21 19:08:59 2011 @@ -230,25 +230,29 @@ { continue; } - - ExAcquirePushLockExclusive(&current->Lock); - + + KeWaitForSingleObject(&current->Mutex, + Executive, + KernelMode, + FALSE, + NULL); + ASSERT(current->Dirty); if (current->ReferenceCount > 1) { - ExReleasePushLock(&current->Lock); + KeReleaseMutex(&current->Mutex, 0); current->Bcb->Callbacks->ReleaseFromLazyWrite( current->Bcb->LazyWriteContext); continue; } - + PagesPerSegment = current->Bcb->CacheSegmentSize / PAGE_SIZE; KeReleaseGuardedMutex(&ViewLock); Status = CcRosFlushCacheSegment(current); - ExReleasePushLock(&current->Lock); + KeReleaseMutex(&current->Mutex, 0); current->Bcb->Callbacks->ReleaseFromLazyWrite( current->Bcb->LazyWriteContext); @@ -440,8 +444,7 @@ } KeReleaseSpinLock(&Bcb->BcbLock, oldIrql); KeReleaseGuardedMutex(&ViewLock); - ExReleasePushLock(&CacheSeg->Lock); - KeLeaveCriticalRegion(); + KeReleaseMutex(&CacheSeg->Mutex, 0); return(STATUS_SUCCESS); } @@ -470,8 +473,11 @@ { CcRosCacheSegmentIncRefCount(current); KeReleaseSpinLock(&Bcb->BcbLock, oldIrql); - KeEnterCriticalRegion(); - ExAcquirePushLockExclusive(&current->Lock); + KeWaitForSingleObject(&current->Mutex, + Executive, + KernelMode, + FALSE, + NULL); return(current); } current_entry = current_entry->Flink; @@ -519,8 +525,7 @@ KeReleaseGuardedMutex(&ViewLock); CacheSeg->Dirty = TRUE; - ExReleasePushLock(&CacheSeg->Lock); - KeLeaveCriticalRegion(); + KeReleaseMutex(&CacheSeg->Mutex, 0); return(STATUS_SUCCESS); } @@ -569,8 +574,7 @@ } KeReleaseSpinLock(&Bcb->BcbLock, oldIrql); - ExReleasePushLock(&CacheSeg->Lock); - KeLeaveCriticalRegion(); + KeReleaseMutex(&CacheSeg->Mutex, 0); return(STATUS_SUCCESS); } @@ -618,9 +622,12 @@ current->DirtySegmentListEntry.Flink = NULL; current->DirtySegmentListEntry.Blink = NULL; current->ReferenceCount = 1; - ExInitializePushLock(&current->Lock); - KeEnterCriticalRegion(); - ExAcquirePushLockExclusive(&current->Lock); + KeInitializeMutex(&current->Mutex, 0); + KeWaitForSingleObject(&current->Mutex, + Executive, + KernelMode, + FALSE, + NULL); KeAcquireGuardedMutex(&ViewLock); *CacheSeg = current; @@ -650,12 +657,15 @@ current ); } #endif - ExReleasePushLock(&(*CacheSeg)->Lock); + KeReleaseMutex(&(*CacheSeg)->Mutex, 0); KeReleaseGuardedMutex(&ViewLock); ExFreeToNPagedLookasideList(&CacheSegLookasideList, *CacheSeg); *CacheSeg = current; - /* We're still in the critical region from above */ - ExAcquirePushLockExclusive(&current->Lock); + KeWaitForSingleObject(&current->Mutex, + Executive, + KernelMode, + FALSE, + NULL); return STATUS_SUCCESS; } if (current->FileOffset < FileOffset) @@ -1040,8 +1050,7 @@ IoStatus->Status = Status; } } - ExReleasePushLock(&current->Lock); - KeLeaveCriticalRegion(); + KeReleaseMutex(&current->Mutex, 0); KeAcquireSpinLock(&Bcb->BcbLock, &oldIrql); CcRosCacheSegmentDecRefCount(current); KeReleaseSpinLock(&Bcb->BcbLock, oldIrql); Modified: trunk/reactos/ntoskrnl/include/internal/cc.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/include/internal/… ============================================================================== --- trunk/reactos/ntoskrnl/include/internal/cc.h [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/include/internal/cc.h [iso-8859-1] Wed Dec 21 19:08:59 2011 @@ -145,8 +145,8 @@ LIST_ENTRY CacheSegmentLRUListEntry; /* Offset in the file which this cache segment maps. */ ULONG FileOffset; - /* Lock. */ - EX_PUSH_LOCK Lock; + /* Mutex */ + KMUTEX Mutex; /* Number of references. */ ULONG ReferenceCount; /* Pointer to the BCB for the file which this cache segment maps data for. */

1 0

[rharabien] 54728: [SHELL32] - Try to fix MSVC build
by rharabien＠svn.reactos.org 21 Dec '11

21 Dec '11

Author: rharabien Date: Wed Dec 21 15:47:17 2011 New Revision: 54728 URL: http://svn.reactos.org/svn/reactos?rev=54728&view=rev Log: [SHELL32] - Try to fix MSVC build Modified: trunk/reactos/dll/win32/shell32/folders/desktop.cpp Modified: trunk/reactos/dll/win32/shell32/folders/desktop.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/folders/… ============================================================================== --- trunk/reactos/dll/win32/shell32/folders/desktop.cpp [iso-8859-1] (original) +++ trunk/reactos/dll/win32/shell32/folders/desktop.cpp [iso-8859-1] Wed Dec 21 15:47:17 2011 @@ -87,7 +87,7 @@ } static const WCHAR ClassicStartMenuW[] = L"SOFTWARE\\Microsoft\\Windows\\" - "CurrentVersion\\Explorer\\HideDesktopIcons\\ClassicStartMenu"; + L"CurrentVersion\\Explorer\\HideDesktopIcons\\ClassicStartMenu"; static INT IsNamespaceExtensionHidden(const WCHAR *iid)

1 0

[dgorbachev] 54727: [Translation] Romanian changes by Fulea Stefan (bug #6782).
by dgorbachev＠svn.reactos.org 21 Dec '11

21 Dec '11

Author: dgorbachev Date: Wed Dec 21 15:09:46 2011 New Revision: 54727 URL: http://svn.reactos.org/svn/reactos?rev=54727&view=rev Log: [Translation] Romanian changes by Fulea Stefan (bug #6782). Modified: trunk/reactos/base/applications/calc/lang/ro-RO.rc trunk/reactos/base/applications/charmap/lang/ro-RO.rc trunk/reactos/base/applications/dxdiag/lang/ro-RO.rc trunk/reactos/base/applications/games/solitaire/lang/ro-RO.rc trunk/reactos/base/applications/games/spider/lang/ro-RO.rc trunk/reactos/base/applications/games/winmine/lang/ro-RO.rc trunk/reactos/base/applications/magnify/lang/ro-RO.rc trunk/reactos/base/applications/mmc/lang/ro-RO.rc trunk/reactos/base/applications/mplay32/lang/ro-RO.rc trunk/reactos/base/applications/msconfig/lang/ro-RO.rc trunk/reactos/base/applications/mscutils/devmgmt/lang/ro-RO.rc trunk/reactos/base/applications/mscutils/devmgmt_new/lang/ro-RO.rc trunk/reactos/base/applications/mscutils/eventvwr/lang/ro-RO.rc trunk/reactos/base/applications/mscutils/servman/lang/ro-RO.rc trunk/reactos/base/applications/mspaint/lang/ro-RO.rc trunk/reactos/base/applications/mstsc/lang/ro-RO.rc trunk/reactos/base/applications/notepad/lang/ro-RO.rc trunk/reactos/base/applications/rapps/lang/ro-RO.rc trunk/reactos/base/applications/regedit/lang/ro-RO.rc trunk/reactos/base/applications/screensavers/3dtext/lang/ro-RO.rc trunk/reactos/base/applications/sndrec32/lang/ro-RO.rc trunk/reactos/base/applications/sndvol32/lang/ro-RO.rc trunk/reactos/base/applications/taskmgr/lang/ro-RO.rc trunk/reactos/base/setup/reactos/lang/ro-RO.rc trunk/reactos/base/setup/vmwinst/lang/ro-RO.rc trunk/reactos/base/shell/cmd/lang/ro-RO.rc trunk/reactos/base/shell/explorer-new/lang/ro-RO.rc trunk/reactos/base/shell/explorer/explorer-ro.rc trunk/reactos/base/system/runonce/lang/ro-RO.rc trunk/reactos/base/system/winlogon/lang/ro-RO.rc trunk/reactos/boot/freeldr/fdebug/lang/ro-RO.rc trunk/reactos/dll/cpl/access/lang/ro-RO.rc trunk/reactos/dll/cpl/appwiz/lang/ro-RO.rc trunk/reactos/dll/cpl/console/lang/ro-RO.rc trunk/reactos/dll/cpl/desk/lang/ro-RO.rc trunk/reactos/dll/cpl/hdwwiz/lang/ro-RO.rc trunk/reactos/dll/cpl/inetcpl/lang/ro-RO.rc trunk/reactos/dll/cpl/input/lang/ro-RO.rc trunk/reactos/dll/cpl/intl/lang/ro-RO.rc trunk/reactos/dll/cpl/joy/lang/ro-RO.rc trunk/reactos/dll/cpl/main/lang/ro-RO.rc trunk/reactos/dll/cpl/mmsys/lang/ro-RO.rc trunk/reactos/dll/cpl/powercfg/lang/ro-RO.rc trunk/reactos/dll/cpl/sysdm/lang/ro-RO.rc trunk/reactos/dll/cpl/timedate/lang/ro-RO.rc trunk/reactos/dll/shellext/deskadp/lang/ro-RO.rc trunk/reactos/dll/shellext/deskmon/lang/ro-RO.rc trunk/reactos/dll/win32/aclui/lang/ro-RO.rc trunk/reactos/dll/win32/browseui/lang/ro-RO.rc trunk/reactos/dll/win32/msports/lang/ro-RO.rc trunk/reactos/dll/win32/netcfgx/lang/ro-RO.rc trunk/reactos/dll/win32/netid/lang/ro-RO.rc trunk/reactos/dll/win32/netshell/netshell.rc trunk/reactos/dll/win32/newdev/lang/ro-RO.rc trunk/reactos/dll/win32/rasdlg/lang/ro-RO.rc trunk/reactos/dll/win32/setupapi/lang/ro-RO.rc trunk/reactos/dll/win32/shell32/lang/ro-RO.rc trunk/reactos/dll/win32/shimgvw/lang/ro-RO.rc trunk/reactos/dll/win32/syssetup/lang/ro-RO.rc trunk/reactos/dll/win32/tapiui/lang/ro-RO.rc trunk/reactos/dll/win32/user32/lang/ro-RO.rc trunk/reactos/dll/win32/userenv/lang/ro-RO.rc trunk/reactos/media/inf/hdc.inf trunk/reactos/media/inf/ks.inf trunk/reactos/subsystems/ntvdm/lang/ro-RO.rc trunk/reactos/subsystems/win32/csrss/win32csr/lang/ro-RO.rc [This mail would be too long, it was shortened to contain the URLs only.] Modified: trunk/reactos/base/applications/calc/lang/ro-RO.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/calc/lan… Modified: trunk/reactos/base/applications/charmap/lang/ro-RO.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/charmap/… Modified: trunk/reactos/base/applications/dxdiag/lang/ro-RO.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/dxdiag/l… Modified: trunk/reactos/base/applications/games/solitaire/lang/ro-RO.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/games/so… Modified: trunk/reactos/base/applications/games/spider/lang/ro-RO.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/games/sp… Modified: trunk/reactos/base/applications/games/winmine/lang/ro-RO.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/games/wi… Modified: trunk/reactos/base/applications/magnify/lang/ro-RO.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/magnify/… Modified: trunk/reactos/base/applications/mmc/lang/ro-RO.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mmc/lang… Modified: trunk/reactos/base/applications/mplay32/lang/ro-RO.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mplay32/… Modified: trunk/reactos/base/applications/msconfig/lang/ro-RO.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/msconfig… Modified: trunk/reactos/base/applications/mscutils/devmgmt/lang/ro-RO.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… Modified: trunk/reactos/base/applications/mscutils/devmgmt_new/lang/ro-RO.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… Modified: trunk/reactos/base/applications/mscutils/eventvwr/lang/ro-RO.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… Modified: trunk/reactos/base/applications/mscutils/servman/lang/ro-RO.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… Modified: trunk/reactos/base/applications/mspaint/lang/ro-RO.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mspaint/… Modified: trunk/reactos/base/applications/mstsc/lang/ro-RO.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mstsc/la… Modified: trunk/reactos/base/applications/notepad/lang/ro-RO.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/notepad/… Modified: trunk/reactos/base/applications/rapps/lang/ro-RO.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/rapps/la… Modified: trunk/reactos/base/applications/regedit/lang/ro-RO.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/regedit/… Modified: trunk/reactos/base/applications/screensavers/3dtext/lang/ro-RO.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/screensa… Modified: trunk/reactos/base/applications/sndrec32/lang/ro-RO.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/sndrec32… Modified: trunk/reactos/base/applications/sndvol32/lang/ro-RO.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/sndvol32… Modified: trunk/reactos/base/applications/taskmgr/lang/ro-RO.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/taskmgr/… Modified: trunk/reactos/base/setup/reactos/lang/ro-RO.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/setup/reactos/lang/ro… Modified: trunk/reactos/base/setup/vmwinst/lang/ro-RO.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/setup/vmwinst/lang/ro… Modified: trunk/reactos/base/shell/cmd/lang/ro-RO.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/shell/cmd/lang/ro-RO.… Modified: trunk/reactos/base/shell/explorer-new/lang/ro-RO.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/shell/explorer-new/la… Modified: trunk/reactos/base/shell/explorer/explorer-ro.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/shell/explorer/explor… Modified: trunk/reactos/base/system/runonce/lang/ro-RO.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/system/runonce/lang/r… Modified: trunk/reactos/base/system/winlogon/lang/ro-RO.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/system/winlogon/lang/… Modified: trunk/reactos/boot/freeldr/fdebug/lang/ro-RO.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/fdebug/lang/r… Modified: trunk/reactos/dll/cpl/access/lang/ro-RO.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/cpl/access/lang/ro-RO.… Modified: trunk/reactos/dll/cpl/appwiz/lang/ro-RO.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/cpl/appwiz/lang/ro-RO.… Modified: trunk/reactos/dll/cpl/console/lang/ro-RO.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/cpl/console/lang/ro-RO… Modified: trunk/reactos/dll/cpl/desk/lang/ro-RO.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/cpl/desk/lang/ro-RO.rc… Modified: trunk/reactos/dll/cpl/hdwwiz/lang/ro-RO.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/cpl/hdwwiz/lang/ro-RO.… Modified: trunk/reactos/dll/cpl/inetcpl/lang/ro-RO.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/cpl/inetcpl/lang/ro-RO… Modified: trunk/reactos/dll/cpl/input/lang/ro-RO.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/cpl/input/lang/ro-RO.r… Modified: trunk/reactos/dll/cpl/intl/lang/ro-RO.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/cpl/intl/lang/ro-RO.rc… Modified: trunk/reactos/dll/cpl/joy/lang/ro-RO.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/cpl/joy/lang/ro-RO.rc?… Modified: trunk/reactos/dll/cpl/main/lang/ro-RO.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/cpl/main/lang/ro-RO.rc… Modified: trunk/reactos/dll/cpl/mmsys/lang/ro-RO.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/cpl/mmsys/lang/ro-RO.r… Modified: trunk/reactos/dll/cpl/powercfg/lang/ro-RO.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/cpl/powercfg/lang/ro-R… Modified: trunk/reactos/dll/cpl/sysdm/lang/ro-RO.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/cpl/sysdm/lang/ro-RO.r… Modified: trunk/reactos/dll/cpl/timedate/lang/ro-RO.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/cpl/timedate/lang/ro-R… Modified: trunk/reactos/dll/shellext/deskadp/lang/ro-RO.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/shellext/deskadp/lang/… Modified: trunk/reactos/dll/shellext/deskmon/lang/ro-RO.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/shellext/deskmon/lang/… Modified: trunk/reactos/dll/win32/aclui/lang/ro-RO.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/aclui/lang/ro-RO… Modified: trunk/reactos/dll/win32/browseui/lang/ro-RO.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/browseui/lang/ro… Modified: trunk/reactos/dll/win32/msports/lang/ro-RO.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/msports/lang/ro-… Modified: trunk/reactos/dll/win32/netcfgx/lang/ro-RO.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/netcfgx/lang/ro-… Modified: trunk/reactos/dll/win32/netid/lang/ro-RO.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/netid/lang/ro-RO… Modified: trunk/reactos/dll/win32/netshell/netshell.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/netshell/netshel… Modified: trunk/reactos/dll/win32/newdev/lang/ro-RO.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/newdev/lang/ro-R… Modified: trunk/reactos/dll/win32/rasdlg/lang/ro-RO.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/rasdlg/lang/ro-R… Modified: trunk/reactos/dll/win32/setupapi/lang/ro-RO.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/setupapi/lang/ro… Modified: trunk/reactos/dll/win32/shell32/lang/ro-RO.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/lang/ro-… Modified: trunk/reactos/dll/win32/shimgvw/lang/ro-RO.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shimgvw/lang/ro-… Modified: trunk/reactos/dll/win32/syssetup/lang/ro-RO.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/syssetup/lang/ro… Modified: trunk/reactos/dll/win32/tapiui/lang/ro-RO.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/tapiui/lang/ro-R… Modified: trunk/reactos/dll/win32/user32/lang/ro-RO.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/lang/ro-R… Modified: trunk/reactos/dll/win32/userenv/lang/ro-RO.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/userenv/lang/ro-… Modified: trunk/reactos/media/inf/hdc.inf URL: http://svn.reactos.org/svn/reactos/trunk/reactos/media/inf/hdc.inf?rev=5472… Modified: trunk/reactos/media/inf/ks.inf URL: http://svn.reactos.org/svn/reactos/trunk/reactos/media/inf/ks.inf?rev=54727… Modified: trunk/reactos/subsystems/ntvdm/lang/ro-RO.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/ntvdm/lang/ro-R… Modified: trunk/reactos/subsystems/win32/csrss/win32csr/lang/ro-RO.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/csrss/win…

1 0

[rharabien] 54726: [SHELL32] - Fix opening properties in background context menu - Fix broken ASSERT in Open With menu
by rharabien＠svn.reactos.org 21 Dec '11

21 Dec '11

Author: rharabien Date: Wed Dec 21 13:53:49 2011 New Revision: 54726 URL: http://svn.reactos.org/svn/reactos?rev=54726&view=rev Log: [SHELL32] - Fix opening properties in background context menu - Fix broken ASSERT in Open With menu Modified: trunk/reactos/dll/win32/shell32/defcontextmenu.cpp trunk/reactos/dll/win32/shell32/fprop.cpp trunk/reactos/dll/win32/shell32/openwithmenu.cpp Modified: trunk/reactos/dll/win32/shell32/defcontextmenu.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/defconte… ============================================================================== --- trunk/reactos/dll/win32/shell32/defcontextmenu.cpp [iso-8859-1] (original) +++ trunk/reactos/dll/win32/shell32/defcontextmenu.cpp [iso-8859-1] Wed Dec 21 13:53:49 2011 @@ -738,6 +738,7 @@ DWORD dwSize; TRACE("BuildShellItemContextMenu entered\n"); + ASSERT(m_Dcm.cidl >= 1); hr = m_Dcm.psf->GetDisplayNameOf(m_Dcm.apidl[0], SHGDN_FORPARSING, &strFile); if (hr == S_OK) @@ -823,7 +824,7 @@ rfg = 0; } - if ((rfg & SFGAO_FOLDER) || _ILIsControlPanel(m_Dcm.apidl[m_Dcm.cidl])) + if ((rfg & SFGAO_FOLDER) || _ILIsControlPanel(m_Dcm.apidl[0])) { /* add the default verbs open / explore */ AddStaticEntryForFileClass(L"Folder"); @@ -926,13 +927,9 @@ UINT uFlags) { if (m_Dcm.cidl) - { idCmdFirst = BuildShellItemContextMenu(hmenu, idCmdFirst, idCmdLast, uFlags); - } else - { idCmdFirst = BuildBackgroundContextMenu(hmenu, idCmdFirst, idCmdLast, uFlags); - } return S_OK; } @@ -1396,56 +1393,91 @@ CDefaultContextMenu::DoProperties( LPCMINVOKECOMMANDINFO lpcmi) { - WCHAR szDrive[MAX_PATH]; + WCHAR wszBuf[MAX_PATH]; STRRET strFile; - - if (m_Dcm.cidl && _ILIsMyComputer(m_Dcm.apidl[0])) - { - ShellExecuteW(lpcmi->hwnd, L"open", L"rundll32.exe shell32.dll,Control_RunDLL sysdm.cpl", NULL, NULL, SW_SHOWNORMAL); - return S_OK; - } - else if (m_Dcm.cidl == 0 && m_Dcm.pidlFolder != NULL && _ILIsDesktop(m_Dcm.pidlFolder)) - { - ShellExecuteW(lpcmi->hwnd, L"open", L"rundll32.exe shell32.dll,Control_RunDLL desk.cpl", NULL, NULL, SW_SHOWNORMAL); - return S_OK; - } - else if (_ILIsDrive(m_Dcm.apidl[0])) - { - ILGetDisplayName(m_Dcm.apidl[0], szDrive); - SH_ShowDriveProperties(szDrive, m_Dcm.pidlFolder, m_Dcm.apidl); - return S_OK; - } - else if (_ILIsNetHood(m_Dcm.apidl[0])) - { - //FIXME path! - ShellExecuteW(NULL, L"open", L"explorer.exe", - L"::{7007ACC7-3202-11D1-AAD2-00805FC1270E}", - NULL, SW_SHOWDEFAULT); - return S_OK; - } - else if (_ILIsBitBucket(m_Dcm.apidl[0])) - { - /* FIXME - * detect the drive path of bitbucket if appropiate - */ - - SH_ShowRecycleBinProperties(L'C'); - return S_OK; - } - - if (m_Dcm.cidl > 1) - WARN("SHMultiFileProperties is not yet implemented\n"); - - if (m_Dcm.psf->GetDisplayNameOf(m_Dcm.apidl[0], SHGDN_FORPARSING, &strFile) != S_OK) - { - ERR("IShellFolder_GetDisplayNameOf failed for apidl\n"); - return E_FAIL; - } - - if (StrRetToBufW(&strFile, m_Dcm.apidl[0], szDrive, MAX_PATH) != S_OK) - return E_FAIL; - - return SH_ShowPropertiesDialog(szDrive, m_Dcm.pidlFolder, m_Dcm.apidl); + const ITEMIDLIST *pidlParent, *pidlChild; + HRESULT hr = S_OK; + + pidlParent = m_Dcm.pidlFolder; + if (!pidlParent) + { + IPersistFolder2 *pf; + + /* pidlFolder is optional */ + if (SUCCEEDED(m_Dcm.psf->QueryInterface(IID_IPersistFolder2, (PVOID*)&pf))) + { + pf->GetCurFolder((_ITEMIDLIST**)&pidlParent); + pf->Release(); + } + } + + if (m_Dcm.cidl > 0) + pidlChild = m_Dcm.apidl[0]; + else + { + /* Set pidlChild to last pidl of current folder */ + if (pidlParent == m_Dcm.pidlFolder) + pidlParent = (ITEMIDLIST*)ILClone(pidlParent); + + pidlChild = (ITEMIDLIST*)ILClone(ILFindLastID(pidlParent)); + ILRemoveLastID((ITEMIDLIST*)pidlParent); + } + + if (_ILIsMyComputer(pidlChild)) + { + if (32 >= (UINT)ShellExecuteW(lpcmi->hwnd, L"open", L"rundll32.exe shell32.dll,Control_RunDLL sysdm.cpl", NULL, NULL, SW_SHOWNORMAL)) + hr = E_FAIL; + } + else if (_ILIsDesktop(pidlChild)) + { + if (32 >= (UINT)ShellExecuteW(lpcmi->hwnd, L"open", L"rundll32.exe shell32.dll,Control_RunDLL desk.cpl", NULL, NULL, SW_SHOWNORMAL)) + hr = E_FAIL; + } + else if (_ILIsDrive(pidlChild)) + { + ILGetDisplayName(pidlChild, wszBuf); + if (!SH_ShowDriveProperties(wszBuf, pidlParent, &pidlChild)) + hr = E_FAIL; + } + else if (_ILIsNetHood(pidlChild)) + { + // FIXME path! + if (32 >= (UINT)ShellExecuteW(NULL, L"open", L"explorer.exe", + L"::{7007ACC7-3202-11D1-AAD2-00805FC1270E}", + NULL, SW_SHOWDEFAULT)) + hr = E_FAIL; + } + else if (_ILIsBitBucket(pidlChild)) + { + /* FIXME: detect the drive path of bitbucket if appropiate */ + if(!SH_ShowRecycleBinProperties(L'C')) + hr = E_FAIL; + } + else + { + if (m_Dcm.cidl > 1) + WARN("SHMultiFileProperties is not yet implemented\n"); + + hr = m_Dcm.psf->GetDisplayNameOf(pidlChild, SHGDN_FORPARSING, &strFile); + if (SUCCEEDED(hr)) + { + hr = StrRetToBufW(&strFile, pidlChild, wszBuf, _countof(wszBuf)); + if (SUCCEEDED(hr)) + hr = SH_ShowPropertiesDialog(wszBuf, pidlParent, &pidlChild); + else + ERR("StrRetToBufW failed\n"); + } + else + ERR("IShellFolder_GetDisplayNameOf failed for apidl\n"); + } + + /* Free allocated PIDLs */ + if (pidlParent != m_Dcm.pidlFolder) + ILFree((ITEMIDLIST*)pidlParent); + if (m_Dcm.cidl < 1 || pidlChild != m_Dcm.apidl[0]) + ILFree((ITEMIDLIST*)pidlChild); + + return hr; } HRESULT Modified: trunk/reactos/dll/win32/shell32/fprop.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/fprop.cp… ============================================================================== --- trunk/reactos/dll/win32/shell32/fprop.cpp [iso-8859-1] (original) +++ trunk/reactos/dll/win32/shell32/fprop.cpp [iso-8859-1] Wed Dec 21 13:53:49 2011 @@ -931,7 +931,7 @@ WCHAR *pFileName; HPSXA hpsxa[3]; INT_PTR res; - CComPtr<IDataObject> pDataObj; + CComPtr<IDataObject> pDataObj; HRESULT hResult; DWORD wLength; Modified: trunk/reactos/dll/win32/shell32/openwithmenu.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/openwith… ============================================================================== --- trunk/reactos/dll/win32/shell32/openwithmenu.cpp [iso-8859-1] (original) +++ trunk/reactos/dll/win32/shell32/openwithmenu.cpp [iso-8859-1] Wed Dec 21 13:53:49 2011 @@ -1035,7 +1035,7 @@ } pida = (LPIDA)GlobalLock(medium.hGlobal); - ASSERT(pida->cidl == 1); + ASSERT(pida->cidl >= 1); pidlFolder2 = (LPCITEMIDLIST) ((LPBYTE)pida + pida->aoffset[0]); pidlChild = (LPCITEMIDLIST) ((LPBYTE)pida + pida->aoffset[1]);

1 0

[cgutman] 54725: [NTOSKRNL] - Wait to acquire locks in CcRosFlushDirtyPages - This is needed because this path is used during critical times like shutdown and very low memory situations when flushe...
by cgutman＠svn.reactos.org 21 Dec '11

21 Dec '11

Author: cgutman Date: Wed Dec 21 05:30:16 2011 New Revision: 54725 URL: http://svn.reactos.org/svn/reactos?rev=54725&view=rev Log: [NTOSKRNL] - Wait to acquire locks in CcRosFlushDirtyPages - This is needed because this path is used during critical times like shutdown and very low memory situations when flushes cannot fail Modified: trunk/reactos/ntoskrnl/cc/view.c Modified: trunk/reactos/ntoskrnl/cc/view.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/cc/view.c?rev=547… ============================================================================== --- trunk/reactos/ntoskrnl/cc/view.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/cc/view.c [iso-8859-1] Wed Dec 21 05:30:16 2011 @@ -225,20 +225,13 @@ current_entry = current_entry->Flink; Locked = current->Bcb->Callbacks->AcquireForLazyWrite( - current->Bcb->LazyWriteContext, FALSE); + current->Bcb->LazyWriteContext, TRUE); if (!Locked) { continue; } - Locked = ExTryToAcquirePushLockExclusive(&current->Lock); - if (!Locked) - { - current->Bcb->Callbacks->ReleaseFromLazyWrite( - current->Bcb->LazyWriteContext); - - continue; - } + ExAcquirePushLockExclusive(&current->Lock); ASSERT(current->Dirty); if (current->ReferenceCount > 1)

1 0

[cgutman] 54724: [SHELL32] - Fix a typo in a registry path
by cgutman＠svn.reactos.org 21 Dec '11

21 Dec '11

Author: cgutman Date: Wed Dec 21 02:43:36 2011 New Revision: 54724 URL: http://svn.reactos.org/svn/reactos?rev=54724&view=rev Log: [SHELL32] - Fix a typo in a registry path Modified: trunk/reactos/dll/win32/shell32/folders/fs.cpp Modified: trunk/reactos/dll/win32/shell32/folders/fs.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/folders/… ============================================================================== --- trunk/reactos/dll/win32/shell32/folders/fs.cpp [iso-8859-1] (original) +++ trunk/reactos/dll/win32/shell32/folders/fs.cpp [iso-8859-1] Wed Dec 21 02:43:36 2011 @@ -514,7 +514,7 @@ return hr; } -static const WCHAR AdvancedW[] = L"SORFWARE\\Microsoft\\Windows\\CurrentVersion\\Explorer\\Advanced"; +static const WCHAR AdvancedW[] = L"SOFTWARE\\Microsoft\\Windows\\CurrentVersion\\Explorer\\Advanced"; static const WCHAR HideFileExtW[] = L"HideFileExt"; static const WCHAR NeverShowExtW[] = L"NeverShowExt";

1 0

[rharabien] 54723: [BOOTDATA] - Remove "Explore from here" from context menu. It's useless, does not exist in Windows and can't be translated in current form.
by rharabien＠svn.reactos.org 20 Dec '11

20 Dec '11

Author: rharabien Date: Tue Dec 20 22:55:42 2011 New Revision: 54723 URL: http://svn.reactos.org/svn/reactos?rev=54723&view=rev Log: [BOOTDATA] - Remove "Explore from here" from context menu. It's useless, does not exist in Windows and can't be translated in current form. Modified: trunk/reactos/boot/bootdata/hivecls_i386.inf Modified: trunk/reactos/boot/bootdata/hivecls_i386.inf URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/bootdata/hivecls_i386… ============================================================================== --- trunk/reactos/boot/bootdata/hivecls_i386.inf [iso-8859-1] (original) +++ trunk/reactos/boot/bootdata/hivecls_i386.inf [iso-8859-1] Tue Dec 20 22:55:42 2011 @@ -10,11 +10,9 @@ ; Folders HKCR,"Folder","",0x00000000,"Folder" -;HKCR,"Folder\Defaulticon","",0x00000000,"%SystemRoot%\system32\shell32.dll,-4" +;HKCR,"Folder\DefaultIcon","",0x00000000,"%SystemRoot%\system32\shell32.dll,-4" HKCR,"Folder\shell\open\command","",0x00000000,"explorer.exe ""%1""" HKCR,"Folder\shell\explore\command","",0x00000000,"explorer.exe /e,""%1""" -HKCR,"Folder\shell\rootexplore","",0x00000000,"Explore from here" -HKCR,"Folder\shell\rootexplore\command","",0x00000000,"explorer.exe /e,/root,""%1""" ; Drive property page HKCR,"CLSID\{5F5295E0-429F-1069-A2E2-08002B30309D}","",0x00000000,"Drive Property Page Extension"

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs