Ros-diffs

ros-diffs@reactos.org

81390 discussions

[tkreuzer] 53409: [HAL/VIDEOPRT/EVENTLOG] Really fix some of the sizeof issues
by tkreuzer＠svn.reactos.org 24 Aug '11

24 Aug '11

Author: tkreuzer Date: Wed Aug 24 09:41:16 2011 New Revision: 53409 URL: http://svn.reactos.org/svn/reactos?rev=53409&view=rev Log: [HAL/VIDEOPRT/EVENTLOG] Really fix some of the sizeof issues Modified: trunk/reactos/base/services/eventlog/rpc.c trunk/reactos/drivers/video/videoprt/services.c trunk/reactos/hal/halx86/generic/usage.c Modified: trunk/reactos/base/services/eventlog/rpc.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/services/eventlog/rpc… ============================================================================== --- trunk/reactos/base/services/eventlog/rpc.c [iso-8859-1] (original) +++ trunk/reactos/base/services/eventlog/rpc.c [iso-8859-1] Wed Aug 24 09:41:16 2011 @@ -462,7 +462,7 @@ EventID, lpLogHandle->szName, ComputerName->Buffer, - sizeof(PRPC_SID), + sizeof(RPC_SID), &UserSID, NumStrings, (WCHAR*)lpStrings, Modified: trunk/reactos/drivers/video/videoprt/services.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/video/videoprt/ser… ============================================================================== --- trunk/reactos/drivers/video/videoprt/services.c [iso-8859-1] (original) +++ trunk/reactos/drivers/video/videoprt/services.c [iso-8859-1] Wed Aug 24 09:41:16 2011 @@ -111,6 +111,6 @@ return FALSE; } - RtlCopyMemory(AgpServices, &Interface.AgpReservePhysical, sizeof(PVIDEO_PORT_AGP_SERVICES)); + RtlCopyMemory(AgpServices, &Interface.AgpReservePhysical, sizeof(VIDEO_PORT_AGP_SERVICES)); return TRUE; } Modified: trunk/reactos/hal/halx86/generic/usage.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/hal/halx86/generic/usage.c… ============================================================================== --- trunk/reactos/hal/halx86/generic/usage.c [iso-8859-1] (original) +++ trunk/reactos/hal/halx86/generic/usage.c [iso-8859-1] Wed Aug 24 09:41:16 2011 @@ -132,7 +132,7 @@ RawDescriptor->u.Interrupt.Affinity = HalpActiveProcessors; /* The translated copy is identical */ - RtlCopyMemory(TranslatedDescriptor, RawDescriptor, sizeof(PCM_PARTIAL_RESOURCE_DESCRIPTOR)); + RtlCopyMemory(TranslatedDescriptor, RawDescriptor, sizeof(CM_PARTIAL_RESOURCE_DESCRIPTOR)); /* But the vector and IRQL must be set correctly */ TranslatedDescriptor->u.Interrupt.Vector = Entry; @@ -180,7 +180,7 @@ } /* Make an identical copy to begin with */ - RtlCopyMemory(TranslatedDescriptor, RawDescriptor, sizeof(PCM_PARTIAL_RESOURCE_DESCRIPTOR)); + RtlCopyMemory(TranslatedDescriptor, RawDescriptor, sizeof(CM_PARTIAL_RESOURCE_DESCRIPTOR)); /* Check what this is */ if (RawDescriptor->Type == CmResourceTypePort)

1 0

[tkreuzer] 53408: [USER32_WINETEST] Better fix by Tomas Faber (increases the performance ; -))
by tkreuzer＠svn.reactos.org 24 Aug '11

24 Aug '11

Author: tkreuzer Date: Wed Aug 24 08:42:37 2011 New Revision: 53408 URL: http://svn.reactos.org/svn/reactos?rev=53408&view=rev Log: [USER32_WINETEST] Better fix by Tomas Faber (increases the performance ;-)) Modified: trunk/rostests/winetests/user32/cursoricon.c Modified: trunk/rostests/winetests/user32/cursoricon.c URL: http://svn.reactos.org/svn/reactos/trunk/rostests/winetests/user32/cursoric… ============================================================================== --- trunk/rostests/winetests/user32/cursoricon.c [iso-8859-1] (original) +++ trunk/rostests/winetests/user32/cursoricon.c [iso-8859-1] Wed Aug 24 08:42:37 2011 @@ -186,7 +186,7 @@ 0, /* biClrUsed */ \ 0 /* biClrImportant */ \ }, \ - { {0}/* DIB data: left uninitialized */ } \ + /* DIB data: left uninitialized */ \ } \ }

1 0

[tkreuzer] 53407: [USER32_WINETEST] Fix MSVC build
by tkreuzer＠svn.reactos.org 24 Aug '11

24 Aug '11

Author: tkreuzer Date: Wed Aug 24 08:36:18 2011 New Revision: 53407 URL: http://svn.reactos.org/svn/reactos?rev=53407&view=rev Log: [USER32_WINETEST] Fix MSVC build Modified: trunk/rostests/winetests/user32/cursoricon.c Modified: trunk/rostests/winetests/user32/cursoricon.c URL: http://svn.reactos.org/svn/reactos/trunk/rostests/winetests/user32/cursoric… ============================================================================== --- trunk/rostests/winetests/user32/cursoricon.c [iso-8859-1] (original) +++ trunk/rostests/winetests/user32/cursoricon.c [iso-8859-1] Wed Aug 24 08:36:18 2011 @@ -186,7 +186,7 @@ 0, /* biClrUsed */ \ 0 /* biClrImportant */ \ }, \ - { /* DIB data: left uninitialized */ } \ + { {0}/* DIB data: left uninitialized */ } \ } \ }

1 0

[akhaldi] 53406: [NTDLL/LDR] * Fix a thinko.
by akhaldi＠svn.reactos.org 24 Aug '11

24 Aug '11

Author: akhaldi Date: Wed Aug 24 03:02:03 2011 New Revision: 53406 URL: http://svn.reactos.org/svn/reactos?rev=53406&view=rev Log: [NTDLL/LDR] * Fix a thinko. Modified: trunk/reactos/dll/ntdll/ldr/ldrutils.c Modified: trunk/reactos/dll/ntdll/ldr/ldrutils.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/ntdll/ldr/ldrutils.c?r… ============================================================================== --- trunk/reactos/dll/ntdll/ldr/ldrutils.c [iso-8859-1] (original) +++ trunk/reactos/dll/ntdll/ldr/ldrutils.c [iso-8859-1] Wed Aug 24 03:02:03 2011 @@ -1660,7 +1660,7 @@ { /* Get character */ p = *ActualSearchPath; - if (!(p) && (p == ';')) + if (!(p) || (p == ';')) { /* FIXME: We don't have a character, or is a semicolon.*/

1 0

[akhaldi] 53405: [EVENTLOG] * Fix a bad sizeof().
by akhaldi＠svn.reactos.org 24 Aug '11

24 Aug '11

Author: akhaldi Date: Wed Aug 24 02:09:29 2011 New Revision: 53405 URL: http://svn.reactos.org/svn/reactos?rev=53405&view=rev Log: [EVENTLOG] * Fix a bad sizeof(). Modified: trunk/reactos/base/services/eventlog/rpc.c Modified: trunk/reactos/base/services/eventlog/rpc.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/services/eventlog/rpc… ============================================================================== --- trunk/reactos/base/services/eventlog/rpc.c [iso-8859-1] (original) +++ trunk/reactos/base/services/eventlog/rpc.c [iso-8859-1] Wed Aug 24 02:09:29 2011 @@ -462,7 +462,7 @@ EventID, lpLogHandle->szName, ComputerName->Buffer, - sizeof(UserSID), + sizeof(PRPC_SID), &UserSID, NumStrings, (WCHAR*)lpStrings,

1 0

[akhaldi] 53404: [VIDEOPRT] * Fix a bad sizeof() that's been with us since r12860 (more than 6 years ago).
by akhaldi＠svn.reactos.org 24 Aug '11

24 Aug '11

Author: akhaldi Date: Wed Aug 24 02:04:55 2011 New Revision: 53404 URL: http://svn.reactos.org/svn/reactos?rev=53404&view=rev Log: [VIDEOPRT] * Fix a bad sizeof() that's been with us since r12860 (more than 6 years ago). Modified: trunk/reactos/drivers/video/videoprt/services.c Modified: trunk/reactos/drivers/video/videoprt/services.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/video/videoprt/ser… ============================================================================== --- trunk/reactos/drivers/video/videoprt/services.c [iso-8859-1] (original) +++ trunk/reactos/drivers/video/videoprt/services.c [iso-8859-1] Wed Aug 24 02:04:55 2011 @@ -111,6 +111,6 @@ return FALSE; } - RtlCopyMemory(AgpServices, &Interface.AgpReservePhysical, sizeof(AgpServices)); + RtlCopyMemory(AgpServices, &Interface.AgpReservePhysical, sizeof(PVIDEO_PORT_AGP_SERVICES)); return TRUE; }

1 0

[akhaldi] 53403: [USER32] * Fix a bad sizeof().
by akhaldi＠svn.reactos.org 24 Aug '11

24 Aug '11

Author: akhaldi Date: Wed Aug 24 02:00:14 2011 New Revision: 53403 URL: http://svn.reactos.org/svn/reactos?rev=53403&view=rev Log: [USER32] * Fix a bad sizeof(). Modified: trunk/reactos/dll/win32/user32/windows/window.c Modified: trunk/reactos/dll/win32/user32/windows/window.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/w… ============================================================================== --- trunk/reactos/dll/win32/user32/windows/window.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/user32/windows/window.c [iso-8859-1] Wed Aug 24 02:00:14 2011 @@ -1792,7 +1792,7 @@ UpdateLayeredWindowIndirect(HWND hwnd, const UPDATELAYEREDWINDOWINFO *info) { - if (info && info->cbSize == sizeof(info)) + if (info && info->cbSize == sizeof(*info)) { return NtUserUpdateLayeredWindow( hwnd, info->hdcDst,

1 0

[akhaldi] 53402: [HAL] * Fix a couple bad sizeof().
by akhaldi＠svn.reactos.org 24 Aug '11

24 Aug '11

Author: akhaldi Date: Wed Aug 24 01:52:12 2011 New Revision: 53402 URL: http://svn.reactos.org/svn/reactos?rev=53402&view=rev Log: [HAL] * Fix a couple bad sizeof(). Modified: trunk/reactos/hal/halx86/generic/usage.c Modified: trunk/reactos/hal/halx86/generic/usage.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/hal/halx86/generic/usage.c… ============================================================================== --- trunk/reactos/hal/halx86/generic/usage.c [iso-8859-1] (original) +++ trunk/reactos/hal/halx86/generic/usage.c [iso-8859-1] Wed Aug 24 01:52:12 2011 @@ -132,7 +132,7 @@ RawDescriptor->u.Interrupt.Affinity = HalpActiveProcessors; /* The translated copy is identical */ - RtlCopyMemory(TranslatedDescriptor, RawDescriptor, sizeof(TranslatedDescriptor)); + RtlCopyMemory(TranslatedDescriptor, RawDescriptor, sizeof(PCM_PARTIAL_RESOURCE_DESCRIPTOR)); /* But the vector and IRQL must be set correctly */ TranslatedDescriptor->u.Interrupt.Vector = Entry; @@ -180,7 +180,7 @@ } /* Make an identical copy to begin with */ - RtlCopyMemory(TranslatedDescriptor, RawDescriptor, sizeof(TranslatedDescriptor)); + RtlCopyMemory(TranslatedDescriptor, RawDescriptor, sizeof(PCM_PARTIAL_RESOURCE_DESCRIPTOR)); /* Check what this is */ if (RawDescriptor->Type == CmResourceTypePort)

1 0

[tkreuzer] 53401: [XDK/DDK] Add KeSaveFloatingPointState as well
by tkreuzer＠svn.reactos.org 23 Aug '11

23 Aug '11

Author: tkreuzer Date: Tue Aug 23 22:59:23 2011 New Revision: 53401 URL: http://svn.reactos.org/svn/reactos?rev=53401&view=rev Log: [XDK/DDK] Add KeSaveFloatingPointState as well Modified: trunk/reactos/include/ddk/wdm.h trunk/reactos/include/reactos/arm/armddk.h trunk/reactos/include/xdk/amd64/ke.h Modified: trunk/reactos/include/ddk/wdm.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/ddk/wdm.h?rev=5340… ============================================================================== --- trunk/reactos/include/ddk/wdm.h [iso-8859-1] (original) +++ trunk/reactos/include/ddk/wdm.h [iso-8859-1] Tue Aug 23 22:59:23 2011 @@ -7946,6 +7946,14 @@ FORCEINLINE NTSTATUS +KeSaveFloatingPointState(PVOID FloatingState) +{ + UNREFERENCED_PARAMETER(FloatingState); + return STATUS_SUCCESS; +} + +FORCEINLINE +NTSTATUS KeRestoreFloatingPointState(PVOID FloatingState) { UNREFERENCED_PARAMETER(FloatingState); Modified: trunk/reactos/include/reactos/arm/armddk.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/reactos/arm/armddk… ============================================================================== --- trunk/reactos/include/reactos/arm/armddk.h [iso-8859-1] (original) +++ trunk/reactos/include/reactos/arm/armddk.h [iso-8859-1] Tue Aug 23 22:59:23 2011 @@ -197,6 +197,14 @@ FORCEINLINE NTSTATUS +KeSaveFloatingPointState(PVOID FloatingState) +{ + UNREFERENCED_PARAMETER(FloatingState); + return STATUS_SUCCESS; +} + +FORCEINLINE +NTSTATUS KeRestoreFloatingPointState(PVOID FloatingState) { UNREFERENCED_PARAMETER(FloatingState); Modified: trunk/reactos/include/xdk/amd64/ke.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/xdk/amd64/ke.h?rev… ============================================================================== --- trunk/reactos/include/xdk/amd64/ke.h [iso-8859-1] (original) +++ trunk/reactos/include/xdk/amd64/ke.h [iso-8859-1] Tue Aug 23 22:59:23 2011 @@ -109,6 +109,14 @@ KeGetCurrentThread(VOID) { return (struct _KTHREAD *)__readgsqword(0x188); +} + +FORCEINLINE +NTSTATUS +KeSaveFloatingPointState(PVOID FloatingState) +{ + UNREFERENCED_PARAMETER(FloatingState); + return STATUS_SUCCESS; } FORCEINLINE

1 0

[tkreuzer] 53400: [DDK(XDK] Add inline functionss Ke*FloatingPointState for amd64 and arm, doing nothing. Noticed by Thomas Faber.
by tkreuzer＠svn.reactos.org 23 Aug '11

23 Aug '11

Author: tkreuzer Date: Tue Aug 23 22:31:20 2011 New Revision: 53400 URL: http://svn.reactos.org/svn/reactos?rev=53400&view=rev Log: [DDK(XDK] Add inline functionss Ke*FloatingPointState for amd64 and arm, doing nothing. Noticed by Thomas Faber. Modified: trunk/reactos/include/ddk/ntddk.h trunk/reactos/include/ddk/ntifs.h trunk/reactos/include/ddk/wdm.h trunk/reactos/include/reactos/arm/armddk.h trunk/reactos/include/xdk/amd64/ke.h Modified: trunk/reactos/include/ddk/ntddk.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/ddk/ntddk.h?rev=53… ============================================================================== --- trunk/reactos/include/ddk/ntddk.h [iso-8859-1] (original) +++ trunk/reactos/include/ddk/ntddk.h [iso-8859-1] Tue Aug 23 22:31:20 2011 @@ -1919,7 +1919,7 @@ typedef enum _TIMER_SET_INFORMATION_CLASS { TimerSetCoalescableTimer, - MaxTimerInfoClass + MaxTimerInfoClass } TIMER_SET_INFORMATION_CLASS; #if (NTDDI_VERSION >= NTDDI_WIN7) @@ -5607,8 +5607,8 @@ NTAPI ZwDisplayString( IN PUNICODE_STRING String); - -NTSYSCALLAPI + +NTSYSAPI NTSTATUS NTAPI ZwPowerInformation( Modified: trunk/reactos/include/ddk/ntifs.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/ddk/ntifs.h?rev=53… ============================================================================== --- trunk/reactos/include/ddk/ntifs.h [iso-8859-1] (original) +++ trunk/reactos/include/ddk/ntifs.h [iso-8859-1] Tue Aug 23 22:31:20 2011 @@ -9615,7 +9615,7 @@ #if (VER_PRODUCTBUILD >= 2195) -NTSYSCALLAPI +NTSYSAPI NTSTATUS NTAPI ZwInitiatePowerAction ( Modified: trunk/reactos/include/ddk/wdm.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/ddk/wdm.h?rev=5340… ============================================================================== --- trunk/reactos/include/ddk/wdm.h [iso-8859-1] (original) +++ trunk/reactos/include/ddk/wdm.h [iso-8859-1] Tue Aug 23 22:31:20 2011 @@ -5457,6 +5457,7 @@ #define IRP_DEFER_IO_COMPLETION 0x00000800 #define IRP_OB_QUERY_NAME 0x00001000 #define IRP_HOLD_DEVICE_QUEUE 0x00002000 +/* The following 2 are missing in latest WDK */ #define IRP_RETRY_IO_COMPLETION 0x00004000 #define IRP_CLASS_CACHE_OPERATION 0x00008000 @@ -7943,6 +7944,14 @@ return (struct _KTHREAD *)__readgsqword(0x188); } +FORCEINLINE +NTSTATUS +KeRestoreFloatingPointState(PVOID FloatingState) +{ + UNREFERENCED_PARAMETER(FloatingState); + return STATUS_SUCCESS; +} + /* VOID * KeFlushIoBuffers( * IN PMDL Mdl, Modified: trunk/reactos/include/reactos/arm/armddk.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/reactos/arm/armddk… ============================================================================== --- trunk/reactos/include/reactos/arm/armddk.h [iso-8859-1] (original) +++ trunk/reactos/include/reactos/arm/armddk.h [iso-8859-1] Tue Aug 23 22:31:20 2011 @@ -195,6 +195,14 @@ NTAPI KeGetCurrentThread(VOID); +FORCEINLINE +NTSTATUS +KeRestoreFloatingPointState(PVOID FloatingState) +{ + UNREFERENCED_PARAMETER(FloatingState); + return STATUS_SUCCESS; +} + extern volatile struct _KSYSTEM_TIME KeTickCount; #ifndef YieldProcessor Modified: trunk/reactos/include/xdk/amd64/ke.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/xdk/amd64/ke.h?rev… ============================================================================== --- trunk/reactos/include/xdk/amd64/ke.h [iso-8859-1] (original) +++ trunk/reactos/include/xdk/amd64/ke.h [iso-8859-1] Tue Aug 23 22:31:20 2011 @@ -109,6 +109,14 @@ KeGetCurrentThread(VOID) { return (struct _KTHREAD *)__readgsqword(0x188); +} + +FORCEINLINE +NTSTATUS +KeRestoreFloatingPointState(PVOID FloatingState) +{ + UNREFERENCED_PARAMETER(FloatingState); + return STATUS_SUCCESS; } /* VOID

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs