Ros-diffs

ros-diffs@reactos.org

81390 discussions

[akhaldi] 52919: [EXT2FS] * Use ext2fsd.h as a PCH.
by akhaldi＠svn.reactos.org 27 Jul '11

27 Jul '11

Author: akhaldi Date: Wed Jul 27 10:11:21 2011 New Revision: 52919 URL: http://svn.reactos.org/svn/reactos?rev=52919&view=rev Log: [EXT2FS] * Use ext2fsd.h as a PCH. Modified: trunk/reactos/drivers/filesystems/ext2/CMakeLists.txt Modified: trunk/reactos/drivers/filesystems/ext2/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/ext2/C… ============================================================================== --- trunk/reactos/drivers/filesystems/ext2/CMakeLists.txt [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/ext2/CMakeLists.txt [iso-8859-1] Wed Jul 27 10:11:21 2011 @@ -24,7 +24,7 @@ add_library(ext2fs SHARED ${SOURCE}) target_link_libraries(ext2fs ${PSEH_LIB}) - +add_pch(ext2fs inc/ext2fsd.h) set_module_type(ext2fs kernelmodedriver) add_importlibs(ext2fs ntoskrnl hal)

1 0

[akhaldi] 52918: [CMAKE] Thomas Faber: - Properly Initialize OUTPUT_VARIABLE.
by akhaldi＠svn.reactos.org 27 Jul '11

27 Jul '11

Author: akhaldi Date: Wed Jul 27 09:18:46 2011 New Revision: 52918 URL: http://svn.reactos.org/svn/reactos?rev=52918&view=rev Log: [CMAKE] Thomas Faber: - Properly Initialize OUTPUT_VARIABLE. Modified: trunk/reactos/include/reactos/version.cmake Modified: trunk/reactos/include/reactos/version.cmake URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/reactos/version.cm… ============================================================================== --- trunk/reactos/include/reactos/version.cmake [iso-8859-1] (original) +++ trunk/reactos/include/reactos/version.cmake [iso-8859-1] Wed Jul 27 09:18:46 2011 @@ -17,6 +17,7 @@ endmacro() macro(converttohex INTVALUE OUTPUT_VARIABLE) + set(${OUTPUT_VARIABLE} "") set(REMAINING ${INTVALUE}) while(REMAINING) math(EXPR REMAINDER "${REMAINING}%16")

1 0

[dgorbachev] 52917: [NTOSKRNL] Fix a bug in KiConvertToGuiThread inline asm and get rid of 1 instruction.
by dgorbachev＠svn.reactos.org 27 Jul '11

27 Jul '11

Author: dgorbachev Date: Wed Jul 27 02:37:47 2011 New Revision: 52917 URL: http://svn.reactos.org/svn/reactos?rev=52917&view=rev Log: [NTOSKRNL] Fix a bug in KiConvertToGuiThread inline asm and get rid of 1 instruction. Modified: trunk/reactos/ntoskrnl/include/internal/i386/ke.h Modified: trunk/reactos/ntoskrnl/include/internal/i386/ke.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/include/internal/… ============================================================================== --- trunk/reactos/ntoskrnl/include/internal/i386/ke.h [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/include/internal/i386/ke.h [iso-8859-1] Wed Jul 27 02:37:47 2011 @@ -759,13 +759,12 @@ */ __asm__ __volatile__ ( - "movl %%ebp, %1\n" - "subl %%esp, %1\n" - "call _PsConvertToGuiThread@0\n" - "addl %%esp, %1\n" - "movl %1, %%ebp\n" - "movl %%eax, %0\n" - : "=r"(Result), "=r"(StackFrame) + "movl %%ebp, %1\n\t" + "subl %%esp, %1\n\t" + "call _PsConvertToGuiThread@0\n\t" + "addl %%esp, %1\n\t" + "movl %1, %%ebp" + : "=a"(Result), "=r"(StackFrame) : : "%esp", "%ecx", "%edx", "memory" );

1 0

[dgorbachev] 52916: [CDFS] Workaround for GCC 4.6 optimizer bug (ICE when compiling with -O3).
by dgorbachev＠svn.reactos.org 27 Jul '11

27 Jul '11

Author: dgorbachev Date: Wed Jul 27 02:37:40 2011 New Revision: 52916 URL: http://svn.reactos.org/svn/reactos?rev=52916&view=rev Log: [CDFS] Workaround for GCC 4.6 optimizer bug (ICE when compiling with -O3). Modified: trunk/reactos/drivers/filesystems/cdfs/fsctl.c Modified: trunk/reactos/drivers/filesystems/cdfs/fsctl.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/cdfs/f… ============================================================================== --- trunk/reactos/drivers/filesystems/cdfs/fsctl.c [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/cdfs/fsctl.c [iso-8859-1] Wed Jul 27 02:37:40 2011 @@ -63,10 +63,10 @@ for (i = 0; i < 2048; i += 4) { /* DON'T optimize this to ULONG!!! (breaks overflow) */ + Serial.Part[3] += Buffer[i+0]; + Serial.Part[2] += Buffer[i+1]; + Serial.Part[1] += Buffer[i+2]; Serial.Part[0] += Buffer[i+3]; - Serial.Part[1] += Buffer[i+2]; - Serial.Part[2] += Buffer[i+1]; - Serial.Part[3] += Buffer[i+0]; } CdInfo->SerialNumber = Serial.Value;

1 0

[dgorbachev] 52915: Add "-fno-omit-frame-pointer" compiler option. GCC 4.6 omits on -O2 and -O3 level.
by dgorbachev＠svn.reactos.org 27 Jul '11

27 Jul '11

Author: dgorbachev Date: Wed Jul 27 02:37:33 2011 New Revision: 52915 URL: http://svn.reactos.org/svn/reactos?rev=52915&view=rev Log: Add "-fno-omit-frame-pointer" compiler option. GCC 4.6 omits on -O2 and -O3 level. Modified: trunk/reactos/ReactOS-i386.rbuild trunk/reactos/cmake/gcc.cmake Modified: trunk/reactos/ReactOS-i386.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ReactOS-i386.rbuild?rev=52… ============================================================================== --- trunk/reactos/ReactOS-i386.rbuild [iso-8859-1] (original) +++ trunk/reactos/ReactOS-i386.rbuild [iso-8859-1] Wed Jul 27 02:37:33 2011 @@ -30,6 +30,7 @@ <compilerflag compiler="cc,cxx">-gstabs+</compilerflag> <compilerflag compiler="cc,cxx">-fno-set-stack-executable</compilerflag> <compilerflag compiler="cc,cxx">-fno-optimize-sibling-calls</compilerflag> + <compilerflag compiler="cc,cxx">-fno-omit-frame-pointer</compilerflag> <compilerflag compiler="as">-gstabs+</compilerflag> </group> Modified: trunk/reactos/cmake/gcc.cmake URL: http://svn.reactos.org/svn/reactos/trunk/reactos/cmake/gcc.cmake?rev=52915&… ============================================================================== --- trunk/reactos/cmake/gcc.cmake [iso-8859-1] (original) +++ trunk/reactos/cmake/gcc.cmake [iso-8859-1] Wed Jul 27 02:37:33 2011 @@ -37,7 +37,7 @@ add_compiler_flags(-fno-strict-aliasing) if(ARCH MATCHES i386) - add_compiler_flags(-mpreferred-stack-boundary=2 -fno-set-stack-executable -fno-optimize-sibling-calls) + add_compiler_flags(-mpreferred-stack-boundary=2 -fno-set-stack-executable -fno-optimize-sibling-calls -fno-omit-frame-pointer) if(OPTIMIZE STREQUAL "1") add_compiler_flags(-ftracer -momit-leaf-frame-pointer) endif()

1 0

[dgorbachev] 52914: [FASTFAT] Do not set attribute "normal" on files. Bug #6384.
by dgorbachev＠svn.reactos.org 27 Jul '11

27 Jul '11

Author: dgorbachev Date: Wed Jul 27 02:36:56 2011 New Revision: 52914 URL: http://svn.reactos.org/svn/reactos?rev=52914&view=rev Log: [FASTFAT] Do not set attribute "normal" on files. Bug #6384. Modified: trunk/reactos/drivers/filesystems/fastfat/create.c Modified: trunk/reactos/drivers/filesystems/fastfat/create.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/fastfa… ============================================================================== --- trunk/reactos/drivers/filesystems/fastfat/create.c [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/fastfat/create.c [iso-8859-1] Wed Jul 27 02:36:56 2011 @@ -545,7 +545,7 @@ RequestedDisposition == FILE_SUPERSEDE) { ULONG Attributes; - Attributes = Stack->Parameters.Create.FileAttributes; + Attributes = Stack->Parameters.Create.FileAttributes & ~FILE_ATTRIBUTE_NORMAL; vfatSplitPathName(&PathNameU, NULL, &FileNameU); Status = VfatAddEntry (DeviceExt, &FileNameU, &pFcb, ParentFcb, RequestedOptions,

1 0

[rharabien] 52913: [DESK] - Fix MS VC compilation. Spotted by Michael Martin - Remove unused definition
by rharabien＠svn.reactos.org 27 Jul '11

27 Jul '11

Author: rharabien Date: Wed Jul 27 01:00:47 2011 New Revision: 52913 URL: http://svn.reactos.org/svn/reactos?rev=52913&view=rev Log: [DESK] - Fix MS VC compilation. Spotted by Michael Martin - Remove unused definition Modified: trunk/reactos/dll/cpl/desk/theme.c trunk/reactos/dll/cpl/desk/theme.h Modified: trunk/reactos/dll/cpl/desk/theme.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/cpl/desk/theme.c?rev=5… ============================================================================== --- trunk/reactos/dll/cpl/desk/theme.c [iso-8859-1] (original) +++ trunk/reactos/dll/cpl/desk/theme.c [iso-8859-1] Wed Jul 27 01:00:47 2011 @@ -120,8 +120,8 @@ /* FIXME: XP seems to use grayed checkboxes to reflect differences between menu and tooltips settings * Just keep them in sync for now: */ - theme->Effects.bTooltipAnimation = theme->Effects.bMenuAnimation; - theme->Effects.bTooltipFade = theme->Effects.bMenuFade; + theme->Effects.bTooltipAnimation = theme->Effects.bMenuAnimation; + theme->Effects.bTooltipFade = theme->Effects.bMenuFade; /* show content of windows during dragging */ SystemParametersInfo(SPI_GETDRAGFULLWINDOWS, 0, &theme->Effects.bDragFullWindows, 0); @@ -138,6 +138,7 @@ TCHAR strValueName[10]; HKEY hkNewSchemes, hkScheme, hkSize; DWORD dwType, dwLength; + UINT64 iSize; BOOL Ret = FALSE; if (!g_PresetLoaded) @@ -190,7 +191,6 @@ for (i = 0; i < NUM_SIZES; i++) { wsprintf(strValueName, TEXT("Size #%d"), i); - UINT64 iSize; dwLength = sizeof(UINT64); if (RegQueryValueEx(hkSize, strValueName, NULL, &dwType, (LPBYTE)&iSize, &dwLength) != ERROR_SUCCESS || dwType != REG_QWORD || dwLength != sizeof(UINT64)) Modified: trunk/reactos/dll/cpl/desk/theme.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/cpl/desk/theme.h?rev=5… ============================================================================== --- trunk/reactos/dll/cpl/desk/theme.h [iso-8859-1] (original) +++ trunk/reactos/dll/cpl/desk/theme.h [iso-8859-1] Wed Jul 27 01:00:47 2011 @@ -33,7 +33,6 @@ #define NUM_SIZES 20 #define NUM_COLORS 31 #define MAX_TEMPLATES 50 -#define MAX_COLORNAMELENGTH 30 #define MAX_TEMPLATENAMELENTGH 80 /* Some typedefs for theme */

1 0

[ion] 52912: [KERNEL32]: Don't try to acquire any privileges for now, as the API is unimplemented (restore back to original/broken behavior).
by ion＠svn.reactos.org 27 Jul '11

27 Jul '11

Author: ion Date: Wed Jul 27 00:30:38 2011 New Revision: 52912 URL: http://svn.reactos.org/svn/reactos?rev=52912&view=rev Log: [KERNEL32]: Don't try to acquire any privileges for now, as the API is unimplemented (restore back to original/broken behavior). Modified: trunk/reactos/dll/win32/kernel32/client/time.c Modified: trunk/reactos/dll/win32/kernel32/client/time.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/client/… ============================================================================== --- trunk/reactos/dll/win32/kernel32/client/time.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/kernel32/client/time.c [iso-8859-1] Wed Jul 27 00:30:38 2011 @@ -380,6 +380,7 @@ NewSystemTime.QuadPart += TimeZoneBias.QuadPart; Status = RtlAcquirePrivilege(&Privilege, 1, 0, &State); + Status = STATUS_SUCCESS; if (NT_SUCCESS(Status)) { Status = NtSetSystemTime(&NewSystemTime, NULL); @@ -423,6 +424,7 @@ } Status = RtlAcquirePrivilege(&Privilege, 1, 0, &State); + Status = STATUS_SUCCESS; if (NT_SUCCESS(Status)) { Status = NtSetSystemTime(&NewSystemTime, NULL);

1 0

[akhaldi] 52911: [PCI/PCMCIA] * Use pci.h and as pcmcia.h as PCH's.
by akhaldi＠svn.reactos.org 26 Jul '11

26 Jul '11

Author: akhaldi Date: Tue Jul 26 22:19:36 2011 New Revision: 52911 URL: http://svn.reactos.org/svn/reactos?rev=52911&view=rev Log: [PCI/PCMCIA] * Use pci.h and as pcmcia.h as PCH's. Modified: trunk/reactos/drivers/bus/pci/CMakeLists.txt trunk/reactos/drivers/bus/pci/pci.h trunk/reactos/drivers/bus/pcmcia/CMakeLists.txt Modified: trunk/reactos/drivers/bus/pci/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/bus/pci/CMakeLists… ============================================================================== --- trunk/reactos/drivers/bus/pci/CMakeLists.txt [iso-8859-1] (original) +++ trunk/reactos/drivers/bus/pci/CMakeLists.txt [iso-8859-1] Tue Jul 26 22:19:36 2011 @@ -7,5 +7,5 @@ set_module_type(pci kernelmodedriver) add_importlibs(pci ntoskrnl hal) - +add_pch(pci pci.h) add_cd_file(TARGET pci DESTINATION reactos/system32/drivers NO_CAB FOR all) Modified: trunk/reactos/drivers/bus/pci/pci.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/bus/pci/pci.h?rev=… ============================================================================== --- trunk/reactos/drivers/bus/pci/pci.h [iso-8859-1] (original) +++ trunk/reactos/drivers/bus/pci/pci.h [iso-8859-1] Tue Jul 26 22:19:36 2011 @@ -1,5 +1,3 @@ -#pragma once - #include <ntifs.h> #include <wdmguid.h> #include <stdio.h> Modified: trunk/reactos/drivers/bus/pcmcia/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/bus/pcmcia/CMakeLi… ============================================================================== --- trunk/reactos/drivers/bus/pcmcia/CMakeLists.txt [iso-8859-1] (original) +++ trunk/reactos/drivers/bus/pcmcia/CMakeLists.txt [iso-8859-1] Tue Jul 26 22:19:36 2011 @@ -6,6 +6,6 @@ pcmcia.rc) set_module_type(pcmcia kernelmodedriver) +add_pch(pcmcia pcmcia.h) add_importlibs(pcmcia ntoskrnl hal) - add_cd_file(TARGET pcmcia DESTINATION reactos/system32/drivers NO_CAB FOR all)

1 0

[akhaldi] 52910: [ISAPNP] * Use isapnp.h as a PCH.
by akhaldi＠svn.reactos.org 26 Jul '11

26 Jul '11

Author: akhaldi Date: Tue Jul 26 22:16:41 2011 New Revision: 52910 URL: http://svn.reactos.org/svn/reactos?rev=52910&view=rev Log: [ISAPNP] * Use isapnp.h as a PCH. Modified: trunk/reactos/drivers/bus/isapnp/CMakeLists.txt trunk/reactos/drivers/bus/isapnp/isapnp.h Modified: trunk/reactos/drivers/bus/isapnp/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/bus/isapnp/CMakeLi… ============================================================================== --- trunk/reactos/drivers/bus/isapnp/CMakeLists.txt [iso-8859-1] (original) +++ trunk/reactos/drivers/bus/isapnp/CMakeLists.txt [iso-8859-1] Tue Jul 26 22:16:41 2011 @@ -8,5 +8,5 @@ set_module_type(isapnp kernelmodedriver) add_importlibs(isapnp ntoskrnl hal) - +add_pch(isapnp isapnp.h) add_cd_file(TARGET isapnp DESTINATION reactos/system32/drivers NO_CAB FOR all) Modified: trunk/reactos/drivers/bus/isapnp/isapnp.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/bus/isapnp/isapnp.… ============================================================================== --- trunk/reactos/drivers/bus/isapnp/isapnp.h [iso-8859-1] (original) +++ trunk/reactos/drivers/bus/isapnp/isapnp.h [iso-8859-1] Tue Jul 26 22:16:41 2011 @@ -1,4 +1,3 @@ -#pragma once #include <wdm.h>

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs