Ros-diffs

ros-diffs@reactos.org

81390 discussions

[spetreolle] 49339: [CMAKE] Enable auto import.
by spetreolle＠svn.reactos.org 29 Oct '10

29 Oct '10

Author: spetreolle Date: Fri Oct 29 12:27:26 2010 New Revision: 49339 URL: http://svn.reactos.org/svn/reactos?rev=49339&view=rev Log: [CMAKE] Enable auto import. Modified: branches/cmake-bringup/gcc.cmake branches/cmake-bringup/toolchain-mingw32.cmake Modified: branches/cmake-bringup/gcc.cmake URL: http://svn.reactos.org/svn/reactos/branches/cmake-bringup/gcc.cmake?rev=493… ============================================================================== --- branches/cmake-bringup/gcc.cmake [iso-8859-1] (original) +++ branches/cmake-bringup/gcc.cmake [iso-8859-1] Fri Oct 29 12:27:26 2010 @@ -11,7 +11,7 @@ link_directories("${REACTOS_SOURCE_DIR}/importlibs" ${REACTOS_BINARY_DIR}/lib/3rdparty/mingw) set(CMAKE_C_LINK_EXECUTABLE "<CMAKE_C_COMPILER> <FLAGS> <CMAKE_C_LINK_FLAGS> <LINK_FLAGS> <OBJECTS> -o <TARGET> <LINK_LIBRARIES>") set(CMAKE_CXX_LINK_EXECUTABLE "<CMAKE_CXX_COMPILER> <FLAGS> <CMAKE_CXX_LINK_FLAGS> <LINK_FLAGS> <OBJECTS> -o <TARGET> <LINK_LIBRARIES>") -set(CMAKE_EXE_LINKER_FLAGS "-nodefaultlibs -nostdlib -Wl,--enable-auto-image-base -Wl,--kill-at") +set(CMAKE_EXE_LINKER_FLAGS "-nodefaultlibs -nostdlib -Wl,--enable-auto-image-base -Wl,--kill-at -Wl,--enable-auto-import") # -Wl,-T,${REACTOS_SOURCE_DIR}/global.lds # Compiler Core Modified: branches/cmake-bringup/toolchain-mingw32.cmake URL: http://svn.reactos.org/svn/reactos/branches/cmake-bringup/toolchain-mingw32… ============================================================================== --- branches/cmake-bringup/toolchain-mingw32.cmake [iso-8859-1] (original) +++ branches/cmake-bringup/toolchain-mingw32.cmake [iso-8859-1] Fri Oct 29 12:27:26 2010 @@ -38,10 +38,10 @@ set(CMAKE_CXX_STANDARD_LIBRARIES "" CACHE STRING "Standard C++ Libraries") if(ARCH MATCHES i386) -set(CMAKE_SHARED_LINKER_FLAGS_INIT "-nodefaultlibs -nostdlib -Wl,--enable-auto-image-base -Wl,--enable-stdcall-fixup -Wl,--kill-at") +set(CMAKE_SHARED_LINKER_FLAGS_INIT "-nodefaultlibs -nostdlib -Wl,--enable-auto-image-base -Wl,--enable-stdcall-fixup -Wl,--kill-at -Wl,--enable-auto-import") #-Wl,-T,${REACTOS_SOURCE_DIR}/global.lds elseif(ARCH MATCHES amd64) -set(CMAKE_SHARED_LINKER_FLAGS_INIT "-nodefaultlibs -nostdlib -Wl,--enable-auto-image-base -Wl,--enable-stdcall-fixup -Wl,--kill-at") +set(CMAKE_SHARED_LINKER_FLAGS_INIT "-nodefaultlibs -nostdlib -Wl,--enable-auto-image-base -Wl,--enable-stdcall-fixup -Wl,--kill-at -Wl,--enable-auto-import") endif(ARCH MATCHES i386) # adjust the default behaviour of the FIND_XXX() commands:

1 0

[tkreuzer] 49338: [WIN32K] Fix possible use of uninitialized variable. Spotted by Amine.
by tkreuzer＠svn.reactos.org 29 Oct '10

29 Oct '10

Author: tkreuzer Date: Fri Oct 29 09:31:54 2010 New Revision: 49338 URL: http://svn.reactos.org/svn/reactos?rev=49338&view=rev Log: [WIN32K] Fix possible use of uninitialized variable. Spotted by Amine. Modified: trunk/reactos/subsystems/win32/win32k/eng/bitblt.c Modified: trunk/reactos/subsystems/win32/win32k/eng/bitblt.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/en… ============================================================================== --- trunk/reactos/subsystems/win32/win32k/eng/bitblt.c [iso-8859-1] (original) +++ trunk/reactos/subsystems/win32/win32k/eng/bitblt.c [iso-8859-1] Fri Oct 29 09:31:54 2010 @@ -370,6 +370,7 @@ } else { + InputPoint.x = InputPoint.y = 0; InputRect.left = 0; InputRect.right = DestRect->right - DestRect->left; InputRect.top = 0;

1 0

[janderwald] 49337: [PORTCLS] - Fix stupid bug which lead to access an invalid buffer. - dedicated to igorko
by janderwald＠svn.reactos.org 29 Oct '10

29 Oct '10

Author: janderwald Date: Fri Oct 29 01:09:13 2010 New Revision: 49337 URL: http://svn.reactos.org/svn/reactos?rev=49337&view=rev Log: [PORTCLS] - Fix stupid bug which lead to access an invalid buffer. - dedicated to igorko Modified: trunk/reactos/drivers/wdm/audio/backpln/portcls/pin_wavecyclic.cpp Modified: trunk/reactos/drivers/wdm/audio/backpln/portcls/pin_wavecyclic.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/wdm/audio/backpln/… ============================================================================== --- trunk/reactos/drivers/wdm/audio/backpln/portcls/pin_wavecyclic.cpp [iso-8859-1] (original) +++ trunk/reactos/drivers/wdm/audio/backpln/portcls/pin_wavecyclic.cpp [iso-8859-1] Fri Oct 29 01:09:13 2010 @@ -699,15 +699,15 @@ if (!NT_SUCCESS(Status)) { Gap = Position - m_CommonBufferOffset; - if (Gap > m_FrameSize) + if (Gap > BufferLength) { // insert silence samples DPRINT1("Inserting Silence Buffer Offset %lu GapLength %lu\n", m_CommonBufferOffset, BufferLength); m_Stream->Silence((PUCHAR)m_CommonBuffer + m_CommonBufferOffset, BufferLength); m_CommonBufferOffset += BufferLength; - break; } + break; } BytesToCopy = min(BufferLength, BufferSize); @@ -758,7 +758,7 @@ if (!NT_SUCCESS(Status)) { Gap = m_CommonBufferSize - m_CommonBufferOffset + Position; - if (Gap > m_FrameSize) + if (Gap > BufferLength) { // insert silence samples DPRINT1("Overlap Inserting Silence Buffer Size %lu Offset %lu Gap %lu Position %lu\n", m_CommonBufferSize, m_CommonBufferOffset, Gap, Position); @@ -771,7 +771,7 @@ BytesToCopy = min(BufferLength, BufferSize); - if (m_Capture) + if (m_Capture) { m_DmaChannel->CopyFrom(Buffer, (PUCHAR)m_CommonBuffer + m_CommonBufferOffset, @@ -1290,7 +1290,7 @@ PC_ASSERT(NT_SUCCESS(Status)); PC_ASSERT(m_FrameSize); - DPRINT1("Bits %u Samples %u Channels %u Tag %u FrameSize %u CommonBufferSize %lu\n", ((PKSDATAFORMAT_WAVEFORMATEX)(DataFormat))->WaveFormatEx.wBitsPerSample, ((PKSDATAFORMAT_WAVEFORMATEX)(DataFormat))->WaveFormatEx.nSamplesPerSec, ((PKSDATAFORMAT_WAVEFORMATEX)(DataFormat))->WaveFormatEx.nChannels, ((PKSDATAFORMAT_WAVEFORMATEX)(DataFormat))->WaveFormatEx.wFormatTag, m_FrameSize, m_CommonBufferSize); + DPRINT1("Bits %u Samples %u Channels %u Tag %u FrameSize %u CommonBufferSize %lu, CommonBuffer %p\n", ((PKSDATAFORMAT_WAVEFORMATEX)(DataFormat))->WaveFormatEx.wBitsPerSample, ((PKSDATAFORMAT_WAVEFORMATEX)(DataFormat))->WaveFormatEx.nSamplesPerSec, ((PKSDATAFORMAT_WAVEFORMATEX)(DataFormat))->WaveFormatEx.nChannels, ((PKSDATAFORMAT_WAVEFORMATEX)(DataFormat))->WaveFormatEx.wFormatTag, m_FrameSize, m_CommonBufferSize, m_DmaChannel->SystemAddress()); /* set up allocator framing */

1 0

[janderwald] 49336: - Fix mdl probe access rights
by janderwald＠svn.reactos.org 29 Oct '10

29 Oct '10

Author: janderwald Date: Fri Oct 29 00:41:06 2010 New Revision: 49336 URL: http://svn.reactos.org/svn/reactos?rev=49336&view=rev Log: - Fix mdl probe access rights Modified: trunk/reactos/drivers/ksfilter/ks/irp.c Modified: trunk/reactos/drivers/ksfilter/ks/irp.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/ksfilter/ks/irp.c?… ============================================================================== --- trunk/reactos/drivers/ksfilter/ks/irp.c [iso-8859-1] (original) +++ trunk/reactos/drivers/ksfilter/ks/irp.c [iso-8859-1] Fri Oct 29 00:41:06 2010 @@ -724,7 +724,16 @@ Mdl = Irp->MdlAddress; /* determine operation */ - Operation = (ProbeFlags & KSPROBE_STREAMWRITE) ? IoWriteAccess : IoReadAccess; + if (!(ProbeFlags & KSPROBE_STREAMWRITE) || (ProbeFlags & KSPROBE_MODIFY)) + { + /* operation is read / modify stream, need write access */ + Operation = IoWriteAccess; + } + else + { + /* operation is write to device, so we need read access */ + Operation = IoReadAccess; + } do { @@ -859,7 +868,8 @@ if (StreamHeader->FrameExtent) { /* allocate an mdl */ - Mdl = IoAllocateMdl(StreamHeader->Data, StreamHeader->FrameExtent, Irp->MdlAddress != NULL, TRUE, Irp); + ASSERT(Irp->MdlAddress == NULL); + Mdl = IoAllocateMdl(StreamHeader->Data, StreamHeader->FrameExtent, FALSE, TRUE, Irp); if (!Mdl) { /* not enough memory */ @@ -880,10 +890,10 @@ /* now probe the allocated mdl's */ if (!NT_SUCCESS(Status)) - { + { DPRINT("Status %x\n", Status); return Status; - } + } else goto ProbeMdl; }

1 0

[janderwald] 49335: - remove rtl dependency - thanks to mephisto!
by janderwald＠svn.reactos.org 28 Oct '10

28 Oct '10

Author: janderwald Date: Thu Oct 28 23:33:50 2010 New Revision: 49335 URL: http://svn.reactos.org/svn/reactos?rev=49335&view=rev Log: - remove rtl dependency - thanks to mephisto! Modified: trunk/reactos/drivers/wdm/audio/legacy/wdmaud/wdmaud.rbuild Modified: trunk/reactos/drivers/wdm/audio/legacy/wdmaud/wdmaud.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/wdm/audio/legacy/w… ============================================================================== --- trunk/reactos/drivers/wdm/audio/legacy/wdmaud/wdmaud.rbuild [iso-8859-1] (original) +++ trunk/reactos/drivers/wdm/audio/legacy/wdmaud/wdmaud.rbuild [iso-8859-1] Thu Oct 28 23:33:50 2010 @@ -7,7 +7,6 @@ <define name="_COMDDK_" /> <library>mmixer</library> <library>ntoskrnl</library> - <library>rtl</library> <library>libcntpr</library> <library>ks</library> <library>pseh</library>

1 0

[spetreolle] 49334: [CMAKE] Add remaining base/applications modules, except sndrec32. wordpad resources fixes will be submitted upstream.
by spetreolle＠svn.reactos.org 28 Oct '10

28 Oct '10

Author: spetreolle Date: Thu Oct 28 22:16:07 2010 New Revision: 49334 URL: http://svn.reactos.org/svn/reactos?rev=49334&view=rev Log: [CMAKE] Add remaining base/applications modules, except sndrec32. wordpad resources fixes will be submitted upstream. Added: branches/cmake-bringup/base/applications/notepad/CMakeLists.txt (with props) branches/cmake-bringup/base/applications/rapps/CMakeLists.txt (with props) branches/cmake-bringup/base/applications/regedit/clb/CMakeLists.txt (with props) branches/cmake-bringup/base/applications/screensavers/3dtext/CMakeLists.txt (with props) branches/cmake-bringup/base/applications/screensavers/CMakeLists.txt (with props) branches/cmake-bringup/base/applications/screensavers/logon/CMakeLists.txt (with props) branches/cmake-bringup/base/applications/wordpad/CMakeLists.txt (with props) Modified: branches/cmake-bringup/base/applications/CMakeLists.txt branches/cmake-bringup/base/applications/cmdutils/CMakeLists.txt branches/cmake-bringup/base/applications/notepad/lang/bg-BG.rc branches/cmake-bringup/base/applications/notepad/lang/cs-CZ.rc branches/cmake-bringup/base/applications/notepad/lang/da-DK.rc branches/cmake-bringup/base/applications/notepad/lang/de-DE.rc branches/cmake-bringup/base/applications/notepad/lang/el-GR.rc branches/cmake-bringup/base/applications/notepad/lang/es-ES.rc branches/cmake-bringup/base/applications/notepad/lang/eu-ES.rc branches/cmake-bringup/base/applications/notepad/lang/fi-FI.rc branches/cmake-bringup/base/applications/notepad/lang/fr-FR.rc branches/cmake-bringup/base/applications/notepad/lang/hu-HU.rc branches/cmake-bringup/base/applications/notepad/lang/hy-AM.rc branches/cmake-bringup/base/applications/notepad/lang/id-ID.rc branches/cmake-bringup/base/applications/notepad/lang/it-IT.rc branches/cmake-bringup/base/applications/notepad/lang/nl-NL.rc branches/cmake-bringup/base/applications/notepad/lang/no-NO.rc branches/cmake-bringup/base/applications/notepad/lang/pl-PL.rc branches/cmake-bringup/base/applications/notepad/lang/pt-PT.rc branches/cmake-bringup/base/applications/notepad/lang/ro-RO.rc branches/cmake-bringup/base/applications/notepad/lang/ru-RU.rc branches/cmake-bringup/base/applications/notepad/lang/sk-SK.rc branches/cmake-bringup/base/applications/notepad/lang/sl-SI.rc branches/cmake-bringup/base/applications/notepad/lang/sv-SE.rc branches/cmake-bringup/base/applications/notepad/lang/th-TH.rc branches/cmake-bringup/base/applications/notepad/lang/uk-UA.rc branches/cmake-bringup/base/applications/notepad/lang/zh-CN.rc branches/cmake-bringup/base/applications/shutdown/CMakeLists.txt branches/cmake-bringup/base/applications/wordpad/Da.rc branches/cmake-bringup/base/applications/wordpad/De.rc branches/cmake-bringup/base/applications/wordpad/En.rc branches/cmake-bringup/base/applications/wordpad/Fr.rc branches/cmake-bringup/base/applications/wordpad/Hu.rc branches/cmake-bringup/base/applications/wordpad/It.rc branches/cmake-bringup/base/applications/wordpad/Ja.rc branches/cmake-bringup/base/applications/wordpad/Ko.rc branches/cmake-bringup/base/applications/wordpad/Lt.rc branches/cmake-bringup/base/applications/wordpad/Nl.rc branches/cmake-bringup/base/applications/wordpad/No.rc branches/cmake-bringup/base/applications/wordpad/Pl.rc branches/cmake-bringup/base/applications/wordpad/Pt.rc branches/cmake-bringup/base/applications/wordpad/Ro.rc branches/cmake-bringup/base/applications/wordpad/Ru.rc branches/cmake-bringup/base/applications/wordpad/Si.rc branches/cmake-bringup/base/applications/wordpad/Sv.rc branches/cmake-bringup/base/applications/wordpad/Tr.rc branches/cmake-bringup/base/applications/wordpad/Uk.rc branches/cmake-bringup/base/applications/wordpad/Zh.rc branches/cmake-bringup/base/applications/wordpad/rsrc.rc [This mail would be too long, it was shortened to contain the URLs only.] Modified: branches/cmake-bringup/base/applications/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/branches/cmake-bringup/base/applications… Modified: branches/cmake-bringup/base/applications/cmdutils/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/branches/cmake-bringup/base/applications… Added: branches/cmake-bringup/base/applications/notepad/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/branches/cmake-bringup/base/applications… Modified: branches/cmake-bringup/base/applications/notepad/lang/bg-BG.rc URL: http://svn.reactos.org/svn/reactos/branches/cmake-bringup/base/applications… Modified: branches/cmake-bringup/base/applications/notepad/lang/cs-CZ.rc URL: http://svn.reactos.org/svn/reactos/branches/cmake-bringup/base/applications… Modified: branches/cmake-bringup/base/applications/notepad/lang/da-DK.rc URL: http://svn.reactos.org/svn/reactos/branches/cmake-bringup/base/applications… Modified: branches/cmake-bringup/base/applications/notepad/lang/de-DE.rc URL: http://svn.reactos.org/svn/reactos/branches/cmake-bringup/base/applications… Modified: branches/cmake-bringup/base/applications/notepad/lang/el-GR.rc URL: http://svn.reactos.org/svn/reactos/branches/cmake-bringup/base/applications… Modified: branches/cmake-bringup/base/applications/notepad/lang/es-ES.rc URL: http://svn.reactos.org/svn/reactos/branches/cmake-bringup/base/applications… Modified: branches/cmake-bringup/base/applications/notepad/lang/eu-ES.rc URL: http://svn.reactos.org/svn/reactos/branches/cmake-bringup/base/applications… Modified: branches/cmake-bringup/base/applications/notepad/lang/fi-FI.rc URL: http://svn.reactos.org/svn/reactos/branches/cmake-bringup/base/applications… Modified: branches/cmake-bringup/base/applications/notepad/lang/fr-FR.rc URL: http://svn.reactos.org/svn/reactos/branches/cmake-bringup/base/applications… Modified: branches/cmake-bringup/base/applications/notepad/lang/hu-HU.rc URL: http://svn.reactos.org/svn/reactos/branches/cmake-bringup/base/applications… Modified: branches/cmake-bringup/base/applications/notepad/lang/hy-AM.rc URL: http://svn.reactos.org/svn/reactos/branches/cmake-bringup/base/applications… Modified: branches/cmake-bringup/base/applications/notepad/lang/id-ID.rc URL: http://svn.reactos.org/svn/reactos/branches/cmake-bringup/base/applications… Modified: branches/cmake-bringup/base/applications/notepad/lang/it-IT.rc URL: http://svn.reactos.org/svn/reactos/branches/cmake-bringup/base/applications… Modified: branches/cmake-bringup/base/applications/notepad/lang/nl-NL.rc URL: http://svn.reactos.org/svn/reactos/branches/cmake-bringup/base/applications… Modified: branches/cmake-bringup/base/applications/notepad/lang/no-NO.rc URL: http://svn.reactos.org/svn/reactos/branches/cmake-bringup/base/applications… Modified: branches/cmake-bringup/base/applications/notepad/lang/pl-PL.rc URL: http://svn.reactos.org/svn/reactos/branches/cmake-bringup/base/applications… Modified: branches/cmake-bringup/base/applications/notepad/lang/pt-PT.rc URL: http://svn.reactos.org/svn/reactos/branches/cmake-bringup/base/applications… Modified: branches/cmake-bringup/base/applications/notepad/lang/ro-RO.rc URL: http://svn.reactos.org/svn/reactos/branches/cmake-bringup/base/applications… Modified: branches/cmake-bringup/base/applications/notepad/lang/ru-RU.rc URL: http://svn.reactos.org/svn/reactos/branches/cmake-bringup/base/applications… Modified: branches/cmake-bringup/base/applications/notepad/lang/sk-SK.rc URL: http://svn.reactos.org/svn/reactos/branches/cmake-bringup/base/applications… Modified: branches/cmake-bringup/base/applications/notepad/lang/sl-SI.rc URL: http://svn.reactos.org/svn/reactos/branches/cmake-bringup/base/applications… Modified: branches/cmake-bringup/base/applications/notepad/lang/sv-SE.rc URL: http://svn.reactos.org/svn/reactos/branches/cmake-bringup/base/applications… Modified: branches/cmake-bringup/base/applications/notepad/lang/th-TH.rc URL: http://svn.reactos.org/svn/reactos/branches/cmake-bringup/base/applications… Modified: branches/cmake-bringup/base/applications/notepad/lang/uk-UA.rc URL: http://svn.reactos.org/svn/reactos/branches/cmake-bringup/base/applications… Modified: branches/cmake-bringup/base/applications/notepad/lang/zh-CN.rc URL: http://svn.reactos.org/svn/reactos/branches/cmake-bringup/base/applications… Added: branches/cmake-bringup/base/applications/rapps/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/branches/cmake-bringup/base/applications… Added: branches/cmake-bringup/base/applications/regedit/clb/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/branches/cmake-bringup/base/applications… Added: branches/cmake-bringup/base/applications/screensavers/3dtext/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/branches/cmake-bringup/base/applications… Added: branches/cmake-bringup/base/applications/screensavers/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/branches/cmake-bringup/base/applications… Added: branches/cmake-bringup/base/applications/screensavers/logon/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/branches/cmake-bringup/base/applications… Modified: branches/cmake-bringup/base/applications/shutdown/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/branches/cmake-bringup/base/applications… Added: branches/cmake-bringup/base/applications/wordpad/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/branches/cmake-bringup/base/applications… Modified: branches/cmake-bringup/base/applications/wordpad/Da.rc URL: http://svn.reactos.org/svn/reactos/branches/cmake-bringup/base/applications… Modified: branches/cmake-bringup/base/applications/wordpad/De.rc URL: http://svn.reactos.org/svn/reactos/branches/cmake-bringup/base/applications… Modified: branches/cmake-bringup/base/applications/wordpad/En.rc URL: http://svn.reactos.org/svn/reactos/branches/cmake-bringup/base/applications… Modified: branches/cmake-bringup/base/applications/wordpad/Fr.rc URL: http://svn.reactos.org/svn/reactos/branches/cmake-bringup/base/applications… Modified: branches/cmake-bringup/base/applications/wordpad/Hu.rc URL: http://svn.reactos.org/svn/reactos/branches/cmake-bringup/base/applications… Modified: branches/cmake-bringup/base/applications/wordpad/It.rc URL: http://svn.reactos.org/svn/reactos/branches/cmake-bringup/base/applications… Modified: branches/cmake-bringup/base/applications/wordpad/Ja.rc URL: http://svn.reactos.org/svn/reactos/branches/cmake-bringup/base/applications… Modified: branches/cmake-bringup/base/applications/wordpad/Ko.rc URL: http://svn.reactos.org/svn/reactos/branches/cmake-bringup/base/applications… Modified: branches/cmake-bringup/base/applications/wordpad/Lt.rc URL: http://svn.reactos.org/svn/reactos/branches/cmake-bringup/base/applications… Modified: branches/cmake-bringup/base/applications/wordpad/Nl.rc URL: http://svn.reactos.org/svn/reactos/branches/cmake-bringup/base/applications… Modified: branches/cmake-bringup/base/applications/wordpad/No.rc URL: http://svn.reactos.org/svn/reactos/branches/cmake-bringup/base/applications… Modified: branches/cmake-bringup/base/applications/wordpad/Pl.rc URL: http://svn.reactos.org/svn/reactos/branches/cmake-bringup/base/applications… Modified: branches/cmake-bringup/base/applications/wordpad/Pt.rc URL: http://svn.reactos.org/svn/reactos/branches/cmake-bringup/base/applications… Modified: branches/cmake-bringup/base/applications/wordpad/Ro.rc URL: http://svn.reactos.org/svn/reactos/branches/cmake-bringup/base/applications… Modified: branches/cmake-bringup/base/applications/wordpad/Ru.rc URL: http://svn.reactos.org/svn/reactos/branches/cmake-bringup/base/applications… Modified: branches/cmake-bringup/base/applications/wordpad/Si.rc URL: http://svn.reactos.org/svn/reactos/branches/cmake-bringup/base/applications… Modified: branches/cmake-bringup/base/applications/wordpad/Sv.rc URL: http://svn.reactos.org/svn/reactos/branches/cmake-bringup/base/applications… Modified: branches/cmake-bringup/base/applications/wordpad/Tr.rc URL: http://svn.reactos.org/svn/reactos/branches/cmake-bringup/base/applications… Modified: branches/cmake-bringup/base/applications/wordpad/Uk.rc URL: http://svn.reactos.org/svn/reactos/branches/cmake-bringup/base/applications… Modified: branches/cmake-bringup/base/applications/wordpad/Zh.rc URL: http://svn.reactos.org/svn/reactos/branches/cmake-bringup/base/applications… Modified: branches/cmake-bringup/base/applications/wordpad/rsrc.rc URL: http://svn.reactos.org/svn/reactos/branches/cmake-bringup/base/applications…

1 0

[spetreolle] 49333: [CMAKE] Cant' have comments in mc files.
by spetreolle＠svn.reactos.org 28 Oct '10

28 Oct '10

Author: spetreolle Date: Thu Oct 28 22:10:10 2010 New Revision: 49333 URL: http://svn.reactos.org/svn/reactos?rev=49333&view=rev Log: [CMAKE] Cant' have comments in mc files. Modified: branches/cmake-bringup/base/applications/rapps/rappsmsg.mc Modified: branches/cmake-bringup/base/applications/rapps/rappsmsg.mc URL: http://svn.reactos.org/svn/reactos/branches/cmake-bringup/base/applications… ============================================================================== --- branches/cmake-bringup/base/applications/rapps/rappsmsg.mc [iso-8859-1] (original) +++ branches/cmake-bringup/base/applications/rapps/rappsmsg.mc [iso-8859-1] Thu Oct 28 22:10:10 2010 @@ -25,4 +25,3 @@ Removal of the program "%1" is called. . -; EOF

1 0

[fireball] 49332: Roel Messiant: - Heap corruption fixes.
by fireball＠svn.reactos.org 28 Oct '10

28 Oct '10

Author: fireball Date: Thu Oct 28 22:08:18 2010 New Revision: 49332 URL: http://svn.reactos.org/svn/reactos?rev=49332&view=rev Log: Roel Messiant: - Heap corruption fixes. Modified: trunk/reactos/base/applications/network/tracert/tracert.c trunk/reactos/dll/ntdll/ldr/utils.c trunk/reactos/dll/win32/netcfgx/tcpipconf_notify.c Modified: trunk/reactos/base/applications/network/tracert/tracert.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/network/… ============================================================================== --- trunk/reactos/base/applications/network/tracert/tracert.c [iso-8859-1] (original) +++ trunk/reactos/base/applications/network/tracert/tracert.c [iso-8859-1] Thu Oct 28 22:08:18 2010 @@ -422,7 +422,7 @@ pInfo->RecvPacket = (PIPv4_HEADER)HeapAlloc(GetProcessHeap(), 0, - sizeof(IPv4_HEADER) + PACKET_SIZE); + MAX_PING_PACKET_SIZE); if (!pInfo->RecvPacket) { HeapFree(GetProcessHeap(), Modified: trunk/reactos/dll/ntdll/ldr/utils.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/ntdll/ldr/utils.c?rev=… ============================================================================== --- trunk/reactos/dll/ntdll/ldr/utils.c [iso-8859-1] (original) +++ trunk/reactos/dll/ntdll/ldr/utils.c [iso-8859-1] Thu Oct 28 22:08:18 2010 @@ -256,7 +256,7 @@ /* Copy it to the heap allocd memory */ Path = RtlAllocateHeap(RtlGetProcessHeap(), 0, - wcslen(SearchPathBuffer) * sizeof(WCHAR)); + (wcslen(SearchPathBuffer) + 1) * sizeof(WCHAR)); if (!Path) { Modified: trunk/reactos/dll/win32/netcfgx/tcpipconf_notify.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/netcfgx/tcpipcon… ============================================================================== --- trunk/reactos/dll/win32/netcfgx/tcpipconf_notify.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/netcfgx/tcpipconf_notify.c [iso-8859-1] Thu Oct 28 22:08:18 2010 @@ -2860,7 +2860,7 @@ } pCurSettings->AutoconfigActive = pPerInfo->AutoconfigActive; } - CoTaskMemFree(pInfo); + CoTaskMemFree(pPerInfo); } }

1 0

[gadamopoulos] 49331: [win32k] message.c: - Don't use RETURN macro - Correctly use SEH. Use _SEH2_YIELD
by gadamopoulos＠svn.reactos.org 28 Oct '10

28 Oct '10

Author: gadamopoulos Date: Thu Oct 28 17:14:29 2010 New Revision: 49331 URL: http://svn.reactos.org/svn/reactos?rev=49331&view=rev Log: [win32k] message.c: - Don't use RETURN macro - Correctly use SEH. Use _SEH2_YIELD Modified: trunk/reactos/subsystems/win32/win32k/ntuser/message.c Modified: trunk/reactos/subsystems/win32/win32k/ntuser/message.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/nt… ============================================================================== --- trunk/reactos/subsystems/win32/win32k/ntuser/message.c [iso-8859-1] (original) +++ trunk/reactos/subsystems/win32/win32k/ntuser/message.c [iso-8859-1] Thu Oct 28 17:14:29 2010 @@ -1868,9 +1868,6 @@ PTHREADINFO pti; PUSER_MESSAGE_QUEUE Queue; DWORD Result; - DECLARE_RETURN(DWORD); - - DPRINT("Enter IntGetQueueStatus\n"); pti = PsGetCurrentThreadWin32Thread(); Queue = pti->MessageQueue; @@ -1881,19 +1878,17 @@ Queue->ChangedBits = 0; } - RETURN(Result); - -CLEANUP: - DPRINT("Leave IntGetQueueStatus, ret=%i\n",_ret_); - END_CLEANUP; + return Result; } BOOL APIENTRY IntInitMessagePumpHook() { - if (((PTHREADINFO)PsGetCurrentThread()->Tcb.Win32Thread)->pcti) - { - ((PTHREADINFO)PsGetCurrentThread()->Tcb.Win32Thread)->pcti->dwcPumpHook++; + PTHREADINFO pti = PsGetCurrentThreadWin32Thread(); + + if (pti->pcti) + { + pti->pcti->dwcPumpHook++; return TRUE; } return FALSE; @@ -1902,13 +1897,15 @@ BOOL APIENTRY IntUninitMessagePumpHook() { - if (((PTHREADINFO)PsGetCurrentThread()->Tcb.Win32Thread)->pcti) - { - if (((PTHREADINFO)PsGetCurrentThread()->Tcb.Win32Thread)->pcti->dwcPumpHook <= 0) + PTHREADINFO pti = PsGetCurrentThreadWin32Thread(); + + if (pti->pcti) + { + if (pti->pcti->dwcPumpHook <= 0) { return FALSE; } - ((PTHREADINFO)PsGetCurrentThread()->Tcb.Win32Thread)->pcti->dwcPumpHook--; + pti->pcti->dwcPumpHook--; return TRUE; } return FALSE; @@ -1922,17 +1919,15 @@ WPARAM wParam, LPARAM lParam) { - DECLARE_RETURN(BOOL); - - DPRINT("Enter NtUserPostMessage\n"); + BOOL ret; + UserEnterExclusive(); - RETURN( UserPostMessage(hWnd, Msg, wParam, lParam)); - -CLEANUP: - DPRINT("Leave NtUserPostMessage, ret=%i\n",_ret_); + ret = UserPostMessage(hWnd, Msg, wParam, lParam); + UserLeave(); - END_CLEANUP; + + return ret; } BOOL APIENTRY @@ -1941,20 +1936,15 @@ WPARAM wParam, LPARAM lParam) { - DECLARE_RETURN(BOOL); - - DPRINT("Enter NtUserPostThreadMessage\n"); + BOOL ret; + UserEnterExclusive(); - RETURN( UserPostThreadMessage( idThread, - Msg, - wParam, - lParam)); - -CLEANUP: - DPRINT("Leave NtUserPostThreadMessage, ret=%i\n",_ret_); + ret = UserPostThreadMessage( idThread, Msg, wParam, lParam); + UserLeave(); - END_CLEANUP; + + return ret; } DWORD APIENTRY @@ -1979,31 +1969,34 @@ { DOSENDMESSAGE dsm; LRESULT Result; - DECLARE_RETURN(BOOL); DPRINT("Enter NtUserSendMessageTimeout\n"); - UserEnterExclusive(); dsm.uFlags = uFlags; dsm.uTimeout = uTimeout; + + UserEnterExclusive(); + Result = co_IntDoSendMessage(hWnd, Msg, wParam, lParam, &dsm, UnsafeInfo); + + UserLeave(); + if(uResult != NULL && Result != 0) { - NTSTATUS Status; - - Status = MmCopyToCaller(uResult, &dsm.Result, sizeof(ULONG_PTR)); - if(!NT_SUCCESS(Status)) - { - SetLastWin32Error(ERROR_INVALID_PARAMETER); - RETURN( FALSE); - } - } - RETURN( Result); - -CLEANUP: - DPRINT("Leave NtUserSendMessageTimeout, ret=%i\n",_ret_); - UserLeave(); - END_CLEANUP; + _SEH2_TRY + { + ProbeForWrite(uResult, sizeof(ULONG_PTR), 1); + RtlCopyMemory(uResult, &dsm.Result, sizeof(ULONG_PTR)); + } + _SEH2_EXCEPT(EXCEPTION_EXECUTE_HANDLER) + { + SetLastWin32Error(ERROR_INVALID_PARAMETER);; + Result = FALSE; + } + _SEH2_END; + } + + return Result; } LRESULT APIENTRY @@ -2013,34 +2006,30 @@ LPARAM lParam, PNTUSERSENDMESSAGEINFO UnsafeInfo ) { - DECLARE_RETURN(BOOL); - - DPRINT("Enter NtUserSendMessage\n"); + BOOL ret; + UserEnterExclusive(); - RETURN(co_IntDoSendMessage(Wnd, Msg, wParam, lParam, NULL, UnsafeInfo)); - -CLEANUP: - DPRINT("Leave NtUserSendMessage, ret=%i\n",_ret_); + ret = co_IntDoSendMessage(Wnd, Msg, wParam, lParam, NULL, UnsafeInfo); + UserLeave(); - END_CLEANUP; + + return ret; } ////////// BOOL APIENTRY NtUserWaitMessage(VOID) { - DECLARE_RETURN(BOOL); - - DPRINT("EnterNtUserWaitMessage\n"); + BOOL ret; + UserEnterExclusive(); - RETURN(co_IntWaitMessage(NULL, 0, 0)); - -CLEANUP: - DPRINT("Leave NtUserWaitMessage, ret=%i\n",_ret_); + ret = co_IntWaitMessage(NULL, 0, 0); + UserLeave(); - END_CLEANUP; + + return ret; } @@ -2067,10 +2056,8 @@ PWND Window = NULL; PMSGMEMORY MsgMemoryEntry; PVOID UserMem; - UINT Size; + ULONG Size; USER_MESSAGE Msg; - DECLARE_RETURN(BOOL); - // USER_REFERENCE_ENTRY Ref; DPRINT("Enter NtUserGetMessage\n"); UserEnterExclusive(); @@ -2078,7 +2065,8 @@ /* Validate input */ if (hWnd && !(Window = UserGetWindowObject(hWnd))) { - RETURN(-1); + UserLeave(); + return -1; } // if (Window) UserRefObjectCo(Window, &Ref); @@ -2092,65 +2080,71 @@ do { GotMessage = co_IntPeekMessage(&Msg, Window, MsgFilterMin, MsgFilterMax, PM_REMOVE); - if (GotMessage) - { - Info.Msg = Msg.Msg; - /* See if this message type is present in the table */ - MsgMemoryEntry = FindMsgMemory(Info.Msg.message); - if (NULL == MsgMemoryEntry) - { - /* Not present, no copying needed */ - Info.LParamSize = 0; - } - else - { - /* Determine required size */ - Size = MsgMemorySize(MsgMemoryEntry, Info.Msg.wParam, - Info.Msg.lParam); - /* Allocate required amount of user-mode memory */ - Info.LParamSize = Size; - UserMem = NULL; - Status = ZwAllocateVirtualMemory(NtCurrentProcess(), &UserMem, 0, - &Info.LParamSize, MEM_COMMIT, PAGE_READWRITE); - - if (! NT_SUCCESS(Status)) - { - SetLastNtError(Status); - RETURN( (BOOL) -1); - } - /* Transfer lParam data to user-mode mem */ - Status = MmCopyToCaller(UserMem, (PVOID) Info.Msg.lParam, Size); - if (! NT_SUCCESS(Status)) - { - ZwFreeVirtualMemory(NtCurrentProcess(), (PVOID *) &UserMem, - &Info.LParamSize, MEM_DECOMMIT); - SetLastNtError(Status); - RETURN( (BOOL) -1); - } - Info.Msg.lParam = (LPARAM) UserMem; - } - Status = MmCopyToCaller(UnsafeInfo, &Info, sizeof(NTUSERGETMESSAGEINFO)); + + if (!GotMessage && !co_IntWaitMessage(Window, MsgFilterMin, MsgFilterMax)) + { + UserLeave(); + return -1; + } + } + while (! GotMessage); + + UserLeave(); + + Info.Msg = Msg.Msg; + /* See if this message type is present in the table */ + MsgMemoryEntry = FindMsgMemory(Info.Msg.message); + + _SEH2_TRY + { + ProbeForWrite(UnsafeInfo, sizeof(NTUSERGETMESSAGEINFO), 1); + RtlCopyMemory(UnsafeInfo, &Info, sizeof(NTUSERGETMESSAGEINFO)); + + if (NULL == MsgMemoryEntry) + { + /* Not present, no copying needed */ + Info.LParamSize = 0; + } + else + { + /* Determine required size */ + Size = MsgMemorySize(MsgMemoryEntry, Info.Msg.wParam, Info.Msg.lParam); + + /* Allocate required amount of user-mode memory */ + Status = ZwAllocateVirtualMemory(NtCurrentProcess(), + &UserMem, + 0, + &Size, + MEM_COMMIT, + PAGE_READWRITE); if (! NT_SUCCESS(Status)) { SetLastNtError(Status); - RETURN( (BOOL) -1); - } - } - else if (! co_IntWaitMessage(Window, MsgFilterMin, MsgFilterMax)) - { - RETURN( (BOOL) -1); - } - } - while (! GotMessage); - - RETURN( WM_QUIT != Info.Msg.message); - -CLEANUP: - // if (Window) UserDerefObjectCo(Window); - - DPRINT("Leave NtUserGetMessage\n"); - UserLeave(); - END_CLEANUP; + _SEH2_YIELD(return (BOOL) -1); + } + + /* Transfer lParam data to user-mode mem */ + ProbeForWrite(UserMem, Size, 1); + RtlCopyMemory(UserMem, (PVOID)Info.Msg.lParam, Size); + + Info.LParamSize = Size; + Info.Msg.lParam = (LPARAM) UserMem; + } + } + _SEH2_EXCEPT(EXCEPTION_EXECUTE_HANDLER) + { + SetLastNtError(_SEH2_GetExceptionCode()); + + if(UserMem != NULL) + { + ZwFreeVirtualMemory(NtCurrentProcess(), &UserMem, &Size, MEM_RELEASE); + } + + _SEH2_YIELD(return (BOOL) -1); + } + _SEH2_END; + + return (Info.Msg.message != WM_QUIT ); } @@ -2161,21 +2155,21 @@ UINT MsgFilterMax) { MSG Msg; - BOOL Ret = FALSE; - DECLARE_RETURN(BOOL); - - DPRINT("Enter NtUserGetMessage\n"); + BOOL Ret; + + if ( (MsgFilterMin|MsgFilterMax) & ~WM_MAXIMUM ) + { + SetLastWin32Error(ERROR_INVALID_PARAMETER); + return FALSE; + } + + RtlZeroMemory(&Msg, sizeof(MSG)); + UserEnterExclusive(); - if ( (MsgFilterMin|MsgFilterMax) & ~WM_MAXIMUM ) - { - SetLastWin32Error(ERROR_INVALID_PARAMETER); - RETURN( Ret); - } - - RtlZeroMemory(&Msg, sizeof(MSG)); - Ret = co_IntGetPeekMessage(&Msg, hWnd, MsgFilterMin, MsgFilterMax, PM_REMOVE, TRUE); + + UserLeave(); if (Ret) { @@ -2191,12 +2185,8 @@ } _SEH2_END; } - RETURN( Ret); - -CLEANUP: - DPRINT("Leave NtUserGetMessage\n"); - UserLeave(); - END_CLEANUP; + + return Ret; } BOOL APIENTRY @@ -2207,16 +2197,14 @@ UINT RemoveMsg) { NTSTATUS Status; - BOOL Present; + BOOL Ret; NTUSERGETMESSAGEINFO Info; PWND Window; PMSGMEMORY MsgMemoryEntry; - PVOID UserMem; - UINT Size; + PVOID UserMem = NULL; + ULONG Size; USER_MESSAGE Msg; - DECLARE_RETURN(BOOL); - - DPRINT("Enter NtUserPeekMessage\n"); + UserEnterExclusive(); if (hWnd == (HWND)-1 || hWnd == (HWND)0x0000FFFF || hWnd == (HWND)0xFFFFFFFF) @@ -2227,7 +2215,8 @@ { if (!(Window = UserGetWindowObject(hWnd))) { - RETURN(-1); + UserLeave(); + return -1; } } else @@ -2241,58 +2230,66 @@ MsgFilterMax = 0; } - Present = co_IntPeekMessage(&Msg, Window, MsgFilterMin, MsgFilterMax, RemoveMsg); - if (Present) - { - + Ret = co_IntPeekMessage(&Msg, Window, MsgFilterMin, MsgFilterMax, RemoveMsg); + + UserLeave(); + + if (Ret) + { Info.Msg = Msg.Msg; /* See if this message type is present in the table */ MsgMemoryEntry = FindMsgMemory(Info.Msg.message); - if (NULL == MsgMemoryEntry) - { - /* Not present, no copying needed */ - Info.LParamSize = 0; - } - else - { - /* Determine required size */ - Size = MsgMemorySize(MsgMemoryEntry, Info.Msg.wParam, - Info.Msg.lParam); - /* Allocate required amount of user-mode memory */ - Info.LParamSize = Size; - UserMem = NULL; - Status = ZwAllocateVirtualMemory(NtCurrentProcess(), &UserMem, 0, - &Info.LParamSize, MEM_COMMIT, PAGE_READWRITE); - if (! NT_SUCCESS(Status)) - { - SetLastNtError(Status); - RETURN( (BOOL) -1); - } - /* Transfer lParam data to user-mode mem */ - Status = MmCopyToCaller(UserMem, (PVOID) Info.Msg.lParam, Size); - if (! NT_SUCCESS(Status)) - { - ZwFreeVirtualMemory(NtCurrentProcess(), (PVOID *) &UserMem, - &Info.LParamSize, MEM_RELEASE); - SetLastNtError(Status); - RETURN( (BOOL) -1); - } - Info.Msg.lParam = (LPARAM) UserMem; - } - Status = MmCopyToCaller(UnsafeInfo, &Info, sizeof(NTUSERGETMESSAGEINFO)); - if (! NT_SUCCESS(Status)) - { - SetLastNtError(Status); - RETURN( (BOOL) -1); - } - } - - RETURN( Present); - -CLEANUP: - DPRINT("Leave NtUserPeekMessage, ret=%i\n",_ret_); - UserLeave(); - END_CLEANUP; + + _SEH2_TRY + { + ProbeForWrite(UnsafeInfo, sizeof(NTUSERGETMESSAGEINFO), 1); + RtlCopyMemory(UnsafeInfo, &Info, sizeof(NTUSERGETMESSAGEINFO)); + + if (NULL == MsgMemoryEntry) + { + /* Not present, no copying needed */ + Info.LParamSize = 0; + } + else + { + /* Determine required size */ + Size = MsgMemorySize(MsgMemoryEntry, Info.Msg.wParam, Info.Msg.lParam); + + /* Allocate required amount of user-mode memory */ + Status = ZwAllocateVirtualMemory(NtCurrentProcess(), + &UserMem, + 0, + &Size, + MEM_COMMIT, + PAGE_READWRITE); + if (! NT_SUCCESS(Status)) + { + SetLastNtError(Status); + _SEH2_YIELD(return (BOOL) -1); + } + + /* Transfer lParam data to user-mode mem */ + ProbeForWrite(UserMem, Size, 1); + RtlCopyMemory(UserMem, (PVOID)Info.Msg.lParam, Size); + + Info.LParamSize = Size; + Info.Msg.lParam = (LPARAM) UserMem; + } + } + _SEH2_EXCEPT(EXCEPTION_EXECUTE_HANDLER) + { + SetLastNtError(_SEH2_GetExceptionCode()); + Ret = (BOOL) -1; + + if(UserMem != NULL) + { + ZwFreeVirtualMemory(NtCurrentProcess(), &UserMem, &Size, MEM_RELEASE); + } + } + _SEH2_END; + } + + return Ret; } BOOL APIENTRY @@ -2303,21 +2300,21 @@ UINT RemoveMsg) { MSG Msg; - BOOL Ret = FALSE; - DECLARE_RETURN(BOOL); - - DPRINT("Enter NtUserPeekMessage\n"); + BOOL Ret; + + if ( RemoveMsg & PM_BADMSGFLAGS ) + { + SetLastWin32Error(ERROR_INVALID_FLAGS); + return FALSE; + } + + RtlZeroMemory(&Msg, sizeof(MSG)); + UserEnterExclusive(); - if ( RemoveMsg & PM_BADMSGFLAGS ) - { - SetLastWin32Error(ERROR_INVALID_FLAGS); - RETURN( Ret); - } - - RtlZeroMemory(&Msg, sizeof(MSG)); - Ret = co_IntGetPeekMessage(&Msg, hWnd, MsgFilterMin, MsgFilterMax, RemoveMsg, FALSE); + + UserLeave(); if (Ret) { @@ -2333,49 +2330,39 @@ } _SEH2_END; } - RETURN( Ret); - -CLEANUP: - DPRINT("Leave NtUserPeekMessage, ret=%i\n",_ret_); - UserLeave(); - END_CLEANUP; + + return Ret; } BOOL APIENTRY NtUserCallMsgFilter( LPMSG lpmsg, INT code) { - BOOL BadChk = FALSE, Ret = FALSE; + BOOL Ret = FALSE; MSG Msg; - DECLARE_RETURN(BOOL); - - DPRINT("Enter NtUserCallMsgFilter\n"); + + _SEH2_TRY + { + ProbeForRead(lpmsg, sizeof(MSG), 1); + RtlCopyMemory( &Msg, lpmsg, sizeof(MSG)); + } + _SEH2_EXCEPT(EXCEPTION_EXECUTE_HANDLER) + { + _SEH2_YIELD(return FALSE); + } + _SEH2_END; + UserEnterExclusive(); - if (lpmsg) - { - _SEH2_TRY - { - ProbeForRead(lpmsg, sizeof(MSG), 1); - RtlCopyMemory( &Msg, lpmsg, sizeof(MSG)); - } - _SEH2_EXCEPT(EXCEPTION_EXECUTE_HANDLER) - { - BadChk = TRUE; - } - _SEH2_END; + + if ( co_HOOK_CallHooks( WH_SYSMSGFILTER, code, 0, (LPARAM)&Msg)) + { + Ret = TRUE; } else - RETURN( FALSE); - - if (BadChk) RETURN( FALSE); - - if ( co_HOOK_CallHooks( WH_SYSMSGFILTER, code, 0, (LPARAM)&Msg)) - { - Ret = TRUE; - } - else { Ret = co_HOOK_CallHooks( WH_MSGFILTER, code, 0, (LPARAM)&Msg); } + + UserLeave(); _SEH2_TRY { @@ -2384,26 +2371,19 @@ } _SEH2_EXCEPT(EXCEPTION_EXECUTE_HANDLER) { - BadChk = TRUE; + Ret = FALSE; } _SEH2_END; - if (BadChk) RETURN( FALSE); - RETURN( Ret) - -CLEANUP: - DPRINT("Leave NtUserCallMsgFilter. ret=%i\n", _ret_); - UserLeave(); - END_CLEANUP; + + return Ret; } LRESULT APIENTRY NtUserDispatchMessage(PMSG UnsafeMsgInfo) { LRESULT Res = 0; - BOOL Hit = FALSE; MSG SafeMsg; - UserEnterExclusive(); _SEH2_TRY { ProbeForRead(UnsafeMsgInfo, sizeof(MSG), 1); @@ -2412,11 +2392,13 @@ _SEH2_EXCEPT(EXCEPTION_EXECUTE_HANDLER) { SetLastNtError(_SEH2_GetExceptionCode()); - Hit = TRUE; + _SEH2_YIELD(return FALSE); } _SEH2_END; - if (!Hit) Res = IntDispatchMessage(&SafeMsg); + UserEnterExclusive(); + + Res = IntDispatchMessage(&SafeMsg); UserLeave(); return Res; @@ -2426,26 +2408,28 @@ BOOL APIENTRY NtUserTranslateMessage(LPMSG lpMsg, UINT flags) { - NTSTATUS Status; MSG SafeMsg; - DECLARE_RETURN(BOOL); - - DPRINT("Enter NtUserTranslateMessage\n"); + BOOL Ret; + + _SEH2_TRY + { + ProbeForRead(lpMsg, sizeof(MSG), 1); + RtlCopyMemory(&SafeMsg, lpMsg, sizeof(MSG)); + } + _SEH2_EXCEPT(EXCEPTION_EXECUTE_HANDLER) + { + SetLastNtError(_SEH2_GetExceptionCode()); + _SEH2_YIELD(return FALSE); + } + _SEH2_END; + UserEnterExclusive(); - Status = MmCopyFromCaller(&SafeMsg, lpMsg, sizeof(MSG)); - if(!NT_SUCCESS(Status)) - { - SetLastNtError(Status); - RETURN( FALSE); - } - - RETURN( IntTranslateKbdMessage(&SafeMsg, flags)); - -CLEANUP: - DPRINT("Leave NtUserTranslateMessage: ret=%i\n",_ret_); + Ret = IntTranslateKbdMessage(&SafeMsg, flags); + UserLeave(); - END_CLEANUP; + + return Ret; } BOOL APIENTRY @@ -2459,7 +2443,6 @@ { LRESULT lResult = 0; BOOL Ret = FALSE; - BOOL BadChk = FALSE; PWND Window = NULL; USER_REFERENCE_ENTRY Ref; @@ -2501,10 +2484,10 @@ } _SEH2_EXCEPT(EXCEPTION_EXECUTE_HANDLER) { - BadChk = TRUE; + Ret = FALSE; + _SEH2_YIELD(break); } _SEH2_END; - if (BadChk) break; } else break; @@ -2531,7 +2514,7 @@ { co_IntSendMessageTimeout( HWND_BROADCAST, Msg, - wParam, + wParam, lParam, SMTO_NOTIMEOUTIFNOTHUNG, 2000, @@ -2657,7 +2640,7 @@ } _SEH2_EXCEPT(EXCEPTION_EXECUTE_HANDLER) { - BadChk = TRUE; + Ret = FALSE; } _SEH2_END; } @@ -2668,7 +2651,7 @@ UserLeave(); - return BadChk ? FALSE : Ret; + return Ret; } #define INFINITE 0xFFFFFFFF

1 0

[jgardou] 49330: [CMAKE] - add vgafonts cab file to build
by jgardou＠svn.reactos.org 28 Oct '10

28 Oct '10

Author: jgardou Date: Thu Oct 28 16:36:49 2010 New Revision: 49330 URL: http://svn.reactos.org/svn/reactos?rev=49330&view=rev Log: [CMAKE] - add vgafonts cab file to build Added: branches/cmake-bringup/media/vgafonts/CMakeLists.txt (with props) Modified: branches/cmake-bringup/media/CMakeLists.txt Modified: branches/cmake-bringup/media/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/branches/cmake-bringup/media/CMakeLists.… ============================================================================== --- branches/cmake-bringup/media/CMakeLists.txt [iso-8859-1] (original) +++ branches/cmake-bringup/media/CMakeLists.txt [iso-8859-1] Thu Oct 28 16:36:49 2010 @@ -1,3 +1,4 @@ add_subdirectory(fonts) add_subdirectory(inf) -add_subdirectory(nls) +add_subdirectory(nls) +add_subdirectory(vgafonts) Added: branches/cmake-bringup/media/vgafonts/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/branches/cmake-bringup/media/vgafonts/CM… ============================================================================== --- branches/cmake-bringup/media/vgafonts/CMakeLists.txt (added) +++ branches/cmake-bringup/media/vgafonts/CMakeLists.txt [iso-8859-1] Thu Oct 28 16:36:49 2010 @@ -1,0 +1,17 @@ + +list(APPEND SOURCE + ${CMAKE_CURRENT_SOURCE_DIR}/437-8x8.bin + ${CMAKE_CURRENT_SOURCE_DIR}/737-8x8.bin + ${CMAKE_CURRENT_SOURCE_DIR}/775-8x8.bin + ${CMAKE_CURRENT_SOURCE_DIR}/850-8x8.bin + ${CMAKE_CURRENT_SOURCE_DIR}/852-8x8.bin + ${CMAKE_CURRENT_SOURCE_DIR}/865-8x8.bin + ${CMAKE_CURRENT_SOURCE_DIR}/866-8x8.bin + ${CMAKE_CURRENT_SOURCE_DIR}/932-8x8.bin +) + +add_custom_command(OUTPUT ${CMAKE_CURRENT_BINARY_DIR}/vgafonts.cab + COMMAND native-cabman -M raw -S ${CMAKE_CURRENT_BINARY_DIR}/vgafonts.cab ${SOURCE} + DEPENDS ${SOURCE}) + +add_custom_target(vgafonts DEPENDS ${CMAKE_CURRENT_BINARY_DIR}/vgafonts.cab) Propchange: branches/cmake-bringup/media/vgafonts/CMakeLists.txt ------------------------------------------------------------------------------ svn:eol-style = native

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs