Ros-diffs

ros-diffs@reactos.org

81390 discussions

[cgutman] 47288: DHCPCSVC] - Move code from dhcp to dhcpcsvc - Export ServiceMain from dhcpcsvc - Now our DHCP service is compatible with the Windows architecture [DHCP] - Remove dhcp from build [IPHLPAPI] - Use dhcpcsvc APIs to control the DHCP service - Add a missing DhcpCApiInitialize - Fix include path in the rbuild file [BOOTDATA] - Add DHCP to the service list to be loaded by svchost in the netsvcs group - Add the correct registry keys in the DHCP service key for loading by svchost - Remov
by cgutman＠svn.reactos.org 21 May '10

21 May '10

Author: cgutman Date: Fri May 21 08:08:15 2010 New Revision: 47288 URL: http://svn.reactos.org/svn/reactos?rev=47288&view=rev Log: DHCPCSVC] - Move code from dhcp to dhcpcsvc - Export ServiceMain from dhcpcsvc - Now our DHCP service is compatible with the Windows architecture [DHCP] - Remove dhcp from build [IPHLPAPI] - Use dhcpcsvc APIs to control the DHCP service - Add a missing DhcpCApiInitialize - Fix include path in the rbuild file [BOOTDATA] - Add DHCP to the service list to be loaded by svchost in the netsvcs group - Add the correct registry keys in the DHCP service key for loading by svchost - Remove dhcp.exe from bootcd - Part 3 of 3 Added: trunk/reactos/dll/win32/dhcpcsvc/adapter.c (with props) trunk/reactos/dll/win32/dhcpcsvc/alloc.c (with props) trunk/reactos/dll/win32/dhcpcsvc/api.c (with props) trunk/reactos/dll/win32/dhcpcsvc/compat.c (with props) trunk/reactos/dll/win32/dhcpcsvc/dhclient.c (with props) trunk/reactos/dll/win32/dhcpcsvc/dispatch.c (with props) trunk/reactos/dll/win32/dhcpcsvc/hash.c (with props) trunk/reactos/dll/win32/dhcpcsvc/include/ trunk/reactos/dll/win32/dhcpcsvc/include/debug.h (with props) trunk/reactos/dll/win32/dhcpcsvc/include/dhcp.h (with props) trunk/reactos/dll/win32/dhcpcsvc/include/dhcpd.h (with props) trunk/reactos/dll/win32/dhcpcsvc/include/hash.h (with props) trunk/reactos/dll/win32/dhcpcsvc/include/rosdhcp.h (with props) trunk/reactos/dll/win32/dhcpcsvc/include/tree.h (with props) trunk/reactos/dll/win32/dhcpcsvc/options.c (with props) trunk/reactos/dll/win32/dhcpcsvc/pipe.c (with props) trunk/reactos/dll/win32/dhcpcsvc/socket.c (with props) trunk/reactos/dll/win32/dhcpcsvc/tables.c (with props) trunk/reactos/dll/win32/dhcpcsvc/tree.c (with props) trunk/reactos/dll/win32/dhcpcsvc/util.c (with props) Modified: trunk/reactos/base/services/services.rbuild trunk/reactos/boot/bootdata/hivesft_arm.inf trunk/reactos/boot/bootdata/hivesft_i386.inf trunk/reactos/boot/bootdata/hivesys_i386.inf trunk/reactos/boot/bootdata/packages/reactos.dff trunk/reactos/dll/win32/dhcpcsvc/dhcpcsvc.c trunk/reactos/dll/win32/dhcpcsvc/dhcpcsvc.rbuild trunk/reactos/dll/win32/dhcpcsvc/dhcpcsvc.spec trunk/reactos/dll/win32/iphlpapi/dhcp_reactos.c trunk/reactos/dll/win32/iphlpapi/iphlpapi.rbuild trunk/reactos/dll/win32/iphlpapi/iphlpapi_main.c trunk/reactos/include/psdk/dhcpcapi.h [This mail would be too long, it was shortened to contain the URLs only.] Modified: trunk/reactos/base/services/services.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/services/services.rbu… Modified: trunk/reactos/boot/bootdata/hivesft_arm.inf URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/bootdata/hivesft_arm.… Modified: trunk/reactos/boot/bootdata/hivesft_i386.inf URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/bootdata/hivesft_i386… Modified: trunk/reactos/boot/bootdata/hivesys_i386.inf URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/bootdata/hivesys_i386… Modified: trunk/reactos/boot/bootdata/packages/reactos.dff URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/bootdata/packages/rea… Added: trunk/reactos/dll/win32/dhcpcsvc/adapter.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/dhcpcsvc/adapter… Added: trunk/reactos/dll/win32/dhcpcsvc/alloc.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/dhcpcsvc/alloc.c… Added: trunk/reactos/dll/win32/dhcpcsvc/api.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/dhcpcsvc/api.c?r… Added: trunk/reactos/dll/win32/dhcpcsvc/compat.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/dhcpcsvc/compat.… Added: trunk/reactos/dll/win32/dhcpcsvc/dhclient.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/dhcpcsvc/dhclien… Modified: trunk/reactos/dll/win32/dhcpcsvc/dhcpcsvc.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/dhcpcsvc/dhcpcsv… Modified: trunk/reactos/dll/win32/dhcpcsvc/dhcpcsvc.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/dhcpcsvc/dhcpcsv… Modified: trunk/reactos/dll/win32/dhcpcsvc/dhcpcsvc.spec URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/dhcpcsvc/dhcpcsv… Added: trunk/reactos/dll/win32/dhcpcsvc/dispatch.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/dhcpcsvc/dispatc… Added: trunk/reactos/dll/win32/dhcpcsvc/hash.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/dhcpcsvc/hash.c?… Added: trunk/reactos/dll/win32/dhcpcsvc/include/debug.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/dhcpcsvc/include… Added: trunk/reactos/dll/win32/dhcpcsvc/include/dhcp.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/dhcpcsvc/include… Added: trunk/reactos/dll/win32/dhcpcsvc/include/dhcpd.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/dhcpcsvc/include… Added: trunk/reactos/dll/win32/dhcpcsvc/include/hash.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/dhcpcsvc/include… Added: trunk/reactos/dll/win32/dhcpcsvc/include/rosdhcp.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/dhcpcsvc/include… Added: trunk/reactos/dll/win32/dhcpcsvc/include/tree.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/dhcpcsvc/include… Added: trunk/reactos/dll/win32/dhcpcsvc/options.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/dhcpcsvc/options… Added: trunk/reactos/dll/win32/dhcpcsvc/pipe.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/dhcpcsvc/pipe.c?… Added: trunk/reactos/dll/win32/dhcpcsvc/socket.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/dhcpcsvc/socket.… Added: trunk/reactos/dll/win32/dhcpcsvc/tables.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/dhcpcsvc/tables.… Added: trunk/reactos/dll/win32/dhcpcsvc/tree.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/dhcpcsvc/tree.c?… Added: trunk/reactos/dll/win32/dhcpcsvc/util.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/dhcpcsvc/util.c?… Modified: trunk/reactos/dll/win32/iphlpapi/dhcp_reactos.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/iphlpapi/dhcp_re… Modified: trunk/reactos/dll/win32/iphlpapi/iphlpapi.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/iphlpapi/iphlpap… Modified: trunk/reactos/dll/win32/iphlpapi/iphlpapi_main.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/iphlpapi/iphlpap… Modified: trunk/reactos/include/psdk/dhcpcapi.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/psdk/dhcpcapi.h?re…

1 0

[cgutman] 47287: [DHCP] - Delete the old DHCP service - Part 2 of x
by cgutman＠svn.reactos.org 21 May '10

21 May '10

Author: cgutman Date: Fri May 21 07:57:05 2010 New Revision: 47287 URL: http://svn.reactos.org/svn/reactos?rev=47287&view=rev Log: [DHCP] - Delete the old DHCP service - Part 2 of x Removed: trunk/reactos/base/services/dhcp/

1 0

[cgutman] 47286: [DHCP] - Delete the old dhcp service - Part 1 of x
by cgutman＠svn.reactos.org 21 May '10

21 May '10

Author: cgutman Date: Fri May 21 07:44:35 2010 New Revision: 47286 URL: http://svn.reactos.org/svn/reactos?rev=47286&view=rev Log: [DHCP] - Delete the old dhcp service - Part 1 of x Removed: trunk/reactos/base/services/dhcp/adapter.c trunk/reactos/base/services/dhcp/alloc.c trunk/reactos/base/services/dhcp/api.c trunk/reactos/base/services/dhcp/compat.c trunk/reactos/base/services/dhcp/design.txt trunk/reactos/base/services/dhcp/dhclient.c trunk/reactos/base/services/dhcp/dhcp.rbuild trunk/reactos/base/services/dhcp/dhcp.rc trunk/reactos/base/services/dhcp/dhcpmain.c trunk/reactos/base/services/dhcp/dispatch.c trunk/reactos/base/services/dhcp/hash.c trunk/reactos/base/services/dhcp/include/cdefs.h trunk/reactos/base/services/dhcp/include/debug.h trunk/reactos/base/services/dhcp/include/dhcp.h trunk/reactos/base/services/dhcp/include/dhcpd.h trunk/reactos/base/services/dhcp/include/dhctoken.h trunk/reactos/base/services/dhcp/include/hash.h trunk/reactos/base/services/dhcp/include/inet.h trunk/reactos/base/services/dhcp/include/osdep.h trunk/reactos/base/services/dhcp/include/predec.h trunk/reactos/base/services/dhcp/include/privsep.h trunk/reactos/base/services/dhcp/include/rosdhcp.h trunk/reactos/base/services/dhcp/include/site.h trunk/reactos/base/services/dhcp/include/stdint.h trunk/reactos/base/services/dhcp/include/sysconf.h trunk/reactos/base/services/dhcp/include/tree.h trunk/reactos/base/services/dhcp/include/version.h trunk/reactos/base/services/dhcp/memory.c trunk/reactos/base/services/dhcp/options.c trunk/reactos/base/services/dhcp/pipe.c trunk/reactos/base/services/dhcp/privsep.c trunk/reactos/base/services/dhcp/socket.c trunk/reactos/base/services/dhcp/tables.c trunk/reactos/base/services/dhcp/timer.c trunk/reactos/base/services/dhcp/tree.c trunk/reactos/base/services/dhcp/util.c [This mail would be too long, it was shortened to contain the URLs only.] Removed: trunk/reactos/base/services/dhcp/adapter.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/services/dhcp/adapter… Removed: trunk/reactos/base/services/dhcp/alloc.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/services/dhcp/alloc.c… Removed: trunk/reactos/base/services/dhcp/api.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/services/dhcp/api.c?r… Removed: trunk/reactos/base/services/dhcp/compat.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/services/dhcp/compat.… Removed: trunk/reactos/base/services/dhcp/design.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/services/dhcp/design.… Removed: trunk/reactos/base/services/dhcp/dhclient.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/services/dhcp/dhclien… Removed: trunk/reactos/base/services/dhcp/dhcp.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/services/dhcp/dhcp.rb… Removed: trunk/reactos/base/services/dhcp/dhcp.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/services/dhcp/dhcp.rc… Removed: trunk/reactos/base/services/dhcp/dhcpmain.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/services/dhcp/dhcpmai… Removed: trunk/reactos/base/services/dhcp/dispatch.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/services/dhcp/dispatc… Removed: trunk/reactos/base/services/dhcp/hash.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/services/dhcp/hash.c?… Removed: trunk/reactos/base/services/dhcp/include/cdefs.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/services/dhcp/include… Removed: trunk/reactos/base/services/dhcp/include/debug.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/services/dhcp/include… Removed: trunk/reactos/base/services/dhcp/include/dhcp.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/services/dhcp/include… Removed: trunk/reactos/base/services/dhcp/include/dhcpd.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/services/dhcp/include… Removed: trunk/reactos/base/services/dhcp/include/dhctoken.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/services/dhcp/include… Removed: trunk/reactos/base/services/dhcp/include/hash.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/services/dhcp/include… Removed: trunk/reactos/base/services/dhcp/include/inet.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/services/dhcp/include… Removed: trunk/reactos/base/services/dhcp/include/osdep.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/services/dhcp/include… Removed: trunk/reactos/base/services/dhcp/include/predec.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/services/dhcp/include… Removed: trunk/reactos/base/services/dhcp/include/privsep.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/services/dhcp/include… Removed: trunk/reactos/base/services/dhcp/include/rosdhcp.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/services/dhcp/include… Removed: trunk/reactos/base/services/dhcp/include/site.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/services/dhcp/include… Removed: trunk/reactos/base/services/dhcp/include/stdint.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/services/dhcp/include… Removed: trunk/reactos/base/services/dhcp/include/sysconf.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/services/dhcp/include… Removed: trunk/reactos/base/services/dhcp/include/tree.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/services/dhcp/include… Removed: trunk/reactos/base/services/dhcp/include/version.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/services/dhcp/include… Removed: trunk/reactos/base/services/dhcp/memory.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/services/dhcp/memory.… Removed: trunk/reactos/base/services/dhcp/options.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/services/dhcp/options… Removed: trunk/reactos/base/services/dhcp/pipe.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/services/dhcp/pipe.c?… Removed: trunk/reactos/base/services/dhcp/privsep.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/services/dhcp/privsep… Removed: trunk/reactos/base/services/dhcp/socket.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/services/dhcp/socket.… Removed: trunk/reactos/base/services/dhcp/tables.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/services/dhcp/tables.… Removed: trunk/reactos/base/services/dhcp/timer.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/services/dhcp/timer.c… Removed: trunk/reactos/base/services/dhcp/tree.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/services/dhcp/tree.c?… Removed: trunk/reactos/base/services/dhcp/util.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/services/dhcp/util.c?…

1 0

[mjmartin] 47285: [win32k] - Move the initialization of MasterTimer into InitInputImp which is called from win32k DriverEntry routine instead of initializing it in the secondary thread RawInputThreadMain.
by mjmartin＠svn.reactos.org 20 May '10

20 May '10

Author: mjmartin Date: Thu May 20 23:45:15 2010 New Revision: 47285 URL: http://svn.reactos.org/svn/reactos?rev=47285&view=rev Log: [win32k] - Move the initialization of MasterTimer into InitInputImp which is called from win32k DriverEntry routine instead of initializing it in the secondary thread RawInputThreadMain. Modified: trunk/reactos/subsystems/win32/win32k/ntuser/input.c Modified: trunk/reactos/subsystems/win32/win32k/ntuser/input.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/nt… ============================================================================== --- trunk/reactos/subsystems/win32/win32k/ntuser/input.c [iso-8859-1] (original) +++ trunk/reactos/subsystems/win32/win32k/ntuser/input.c [iso-8859-1] Thu May 20 23:45:15 2010 @@ -868,14 +868,6 @@ NTSTATUS Status; LARGE_INTEGER DueTime; - MasterTimer = ExAllocatePoolWithTag(NonPagedPool, sizeof(KTIMER), TAG_INPUT); - if (!MasterTimer) - { - DPRINT1("Win32K: Failed making Raw Input thread a win32 thread.\n"); - return; - } - KeInitializeTimer(MasterTimer); - DueTime.QuadPart = (LONGLONG)(-10000000); do @@ -936,6 +928,15 @@ NTSTATUS Status; KeInitializeEvent(&InputThreadsStart, NotificationEvent, FALSE); + + MasterTimer = ExAllocatePoolWithTag(NonPagedPool, sizeof(KTIMER), TAG_INPUT); + if (!MasterTimer) + { + DPRINT1("Win32K: Failed making Raw Input thread a win32 thread.\n"); + ASSERT(FALSE); + return STATUS_UNSUCCESSFUL; + } + KeInitializeTimer(MasterTimer); /* Initialize the default keyboard layout */ if(!UserInitDefaultKeyboardLayout())

1 0

[mjmartin] 47284: [win32k] - Set MasterTimer initial value to NULL and Initialize MasterTimer at the beginning of RawInputThreadMain before doing anything else. - Add ASSERTs to catch if MasterTimer is NULL.
by mjmartin＠svn.reactos.org 20 May '10

20 May '10

Author: mjmartin Date: Thu May 20 23:07:53 2010 New Revision: 47284 URL: http://svn.reactos.org/svn/reactos?rev=47284&view=rev Log: [win32k] - Set MasterTimer initial value to NULL and Initialize MasterTimer at the beginning of RawInputThreadMain before doing anything else. - Add ASSERTs to catch if MasterTimer is NULL. Modified: trunk/reactos/subsystems/win32/win32k/ntuser/input.c trunk/reactos/subsystems/win32/win32k/ntuser/timer.c Modified: trunk/reactos/subsystems/win32/win32k/ntuser/input.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/nt… ============================================================================== --- trunk/reactos/subsystems/win32/win32k/ntuser/input.c [iso-8859-1] (original) +++ trunk/reactos/subsystems/win32/win32k/ntuser/input.c [iso-8859-1] Thu May 20 23:07:53 2010 @@ -22,7 +22,7 @@ /* GLOBALS *******************************************************************/ PTHREADINFO ptiRawInput; -PKTIMER MasterTimer; +PKTIMER MasterTimer = NULL; PATTACHINFO gpai = NULL; static HANDLE MouseDeviceHandle; @@ -868,18 +868,6 @@ NTSTATUS Status; LARGE_INTEGER DueTime; - DueTime.QuadPart = (LONGLONG)(-10000000); - - do - { - KEVENT Event; - KeInitializeEvent(&Event, NotificationEvent, FALSE); - Status = KeWaitForSingleObject(&Event, Executive, KernelMode, FALSE, &DueTime); - } while (!NT_SUCCESS(Status)); - - - Objects[0] = &InputThreadsStart; - MasterTimer = ExAllocatePoolWithTag(NonPagedPool, sizeof(KTIMER), TAG_INPUT); if (!MasterTimer) { @@ -887,6 +875,18 @@ return; } KeInitializeTimer(MasterTimer); + + DueTime.QuadPart = (LONGLONG)(-10000000); + + do + { + KEVENT Event; + KeInitializeEvent(&Event, NotificationEvent, FALSE); + Status = KeWaitForSingleObject(&Event, Executive, KernelMode, FALSE, &DueTime); + } while (!NT_SUCCESS(Status)); + + + Objects[0] = &InputThreadsStart; Objects[1] = MasterTimer; // This thread requires win32k! Modified: trunk/reactos/subsystems/win32/win32k/ntuser/timer.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/nt… ============================================================================== --- trunk/reactos/subsystems/win32/win32k/ntuser/timer.c [iso-8859-1] (original) +++ trunk/reactos/subsystems/win32/win32k/ntuser/timer.c [iso-8859-1] Thu May 20 23:07:53 2010 @@ -245,6 +245,7 @@ pTmr->flags &= ~TMRF_DELETEPENDING; } + ASSERT(MasterTimer != NULL); // Start the timer thread! if (pTmr == FirstpTmr) KeSetTimer(MasterTimer, DueTime, NULL); @@ -419,6 +420,7 @@ } while (pTmr != FirstpTmr); // Restart the timer thread! + ASSERT(MasterTimer != NULL); KeSetTimer(MasterTimer, DueTime, NULL); TimeLast = Time;

1 0

[gadamopoulos] 47283: [win32k] -Remove an incorrect debug message and silence one
by gadamopoulos＠svn.reactos.org 20 May '10

20 May '10

Author: gadamopoulos Date: Thu May 20 14:25:50 2010 New Revision: 47283 URL: http://svn.reactos.org/svn/reactos?rev=47283&view=rev Log: [win32k] -Remove an incorrect debug message and silence one Modified: trunk/reactos/subsystems/win32/win32k/ntuser/focus.c trunk/reactos/subsystems/win32/win32k/ntuser/input.c Modified: trunk/reactos/subsystems/win32/win32k/ntuser/focus.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/nt… ============================================================================== --- trunk/reactos/subsystems/win32/win32k/ntuser/focus.c [iso-8859-1] (original) +++ trunk/reactos/subsystems/win32/win32k/ntuser/focus.c [iso-8859-1] Thu May 20 14:25:50 2010 @@ -110,7 +110,7 @@ HANDLE OldTID = IntGetWndThreadId(WindowPrev); HANDLE NewTID = IntGetWndThreadId(Window); - DPRINT1("SendActiveMessage Old -> %x, New -> %x\n", OldTID, NewTID); + DPRINT("SendActiveMessage Old -> %x, New -> %x\n", OldTID, NewTID); if (Window->Wnd->style & WS_MINIMIZE) { DPRINT("Widow was minimized\n"); Modified: trunk/reactos/subsystems/win32/win32k/ntuser/input.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/nt… ============================================================================== --- trunk/reactos/subsystems/win32/win32k/ntuser/input.c [iso-8859-1] (original) +++ trunk/reactos/subsystems/win32/win32k/ntuser/input.c [iso-8859-1] Thu May 20 14:25:50 2010 @@ -1340,10 +1340,7 @@ /* All messages have to contain the cursor point. */ pti = PsGetCurrentThreadWin32Thread(); Msg.pt = gpsi->ptCursor; - - DPRINT1("Kbd Hook msg %d wParam %d lParam 0x%08x dropped by WH_KEYBOARD_LL hook\n", - Msg.message, vk_hook, Msg.lParam); - + KbdHookData.vkCode = vk_hook; KbdHookData.scanCode = ki->wScan; KbdHookData.flags = flags >> 8;

1 0

[tkreuzer] 47282: [WIN32CSR] Silence a debugprint
by tkreuzer＠svn.reactos.org 19 May '10

19 May '10

Author: tkreuzer Date: Thu May 20 00:15:49 2010 New Revision: 47282 URL: http://svn.reactos.org/svn/reactos?rev=47282&view=rev Log: [WIN32CSR] Silence a debugprint Modified: trunk/reactos/subsystems/win32/csrss/win32csr/guiconsole.c Modified: trunk/reactos/subsystems/win32/csrss/win32csr/guiconsole.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/csrss/win… ============================================================================== --- trunk/reactos/subsystems/win32/csrss/win32csr/guiconsole.c [iso-8859-1] (original) +++ trunk/reactos/subsystems/win32/csrss/win32csr/guiconsole.c [iso-8859-1] Thu May 20 00:15:49 2010 @@ -2321,7 +2321,7 @@ /* wait untill initialization has finished */ WaitForSingleObject(GuiData->hGuiInitEvent, INFINITE); - DPRINT1("received event Console %p GuiData %p X %d Y %d\n", Console, Console->PrivateData, Console->Size.X, Console->Size.Y); + DPRINT("received event Console %p GuiData %p X %d Y %d\n", Console, Console->PrivateData, Console->Size.X, Console->Size.Y); CloseHandle(GuiData->hGuiInitEvent); GuiData->hGuiInitEvent = NULL;

1 0

[gadamopoulos] 47281: [win32k] -Correctly adjust values returned from co_WinPosGetMinMaxInfo
by gadamopoulos＠svn.reactos.org 19 May '10

19 May '10

Author: gadamopoulos Date: Wed May 19 21:08:25 2010 New Revision: 47281 URL: http://svn.reactos.org/svn/reactos?rev=47281&view=rev Log: [win32k] -Correctly adjust values returned from co_WinPosGetMinMaxInfo Modified: trunk/reactos/subsystems/win32/win32k/ntuser/window.c Modified: trunk/reactos/subsystems/win32/win32k/ntuser/window.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/nt… ============================================================================== --- trunk/reactos/subsystems/win32/win32k/ntuser/window.c [iso-8859-1] (original) +++ trunk/reactos/subsystems/win32/win32k/ntuser/window.c [iso-8859-1] Wed May 19 21:08:25 2010 @@ -2219,21 +2219,15 @@ POINT MaxSize, MaxPos, MinTrack, MaxTrack; /* WinPosGetMinMaxInfo sends the WM_GETMINMAXINFO message */ - co_WinPosGetMinMaxInfo(Window, &MaxSize, &MaxPos, &MinTrack, - &MaxTrack); - if (MaxSize.x < Size.cx) - Size.cx = MaxSize.x; - if (MaxSize.y < Size.cy) - Size.cy = MaxSize.y; - if (Size.cx < MinTrack.x ) - Size.cx = MinTrack.x; - if (Size.cy < MinTrack.y ) - Size.cy = MinTrack.y; - if (Size.cx < 0) - Size.cx = 0; - if (Size.cy < 0) - Size.cy = 0; - } + co_WinPosGetMinMaxInfo(Window, &MaxSize, &MaxPos, &MinTrack, &MaxTrack); + if (Size.cx > MaxTrack.x) Size.cx = MaxTrack.x; + if (Size.cy > MaxTrack.y) Size.cy = MaxTrack.y; + if (Size.cx < MinTrack.x) Size.cx = MinTrack.x; + if (Size.cy < MinTrack.y) Size.cy = MinTrack.y; + } + + if (Size.cx < 0) Size.cx = 0; + if (Size.cy < 0) Size.cy = 0; Wnd->rcWindow.left = Pos.x; Wnd->rcWindow.top = Pos.y;

1 0

[gadamopoulos] 47280: [win32k] -Sync co_WinPosGetMinMaxInfo with wine
by gadamopoulos＠svn.reactos.org 19 May '10

19 May '10

Author: gadamopoulos Date: Wed May 19 20:47:39 2010 New Revision: 47280 URL: http://svn.reactos.org/svn/reactos?rev=47280&view=rev Log: [win32k] -Sync co_WinPosGetMinMaxInfo with wine Modified: trunk/reactos/subsystems/win32/win32k/ntuser/winpos.c Modified: trunk/reactos/subsystems/win32/win32k/ntuser/winpos.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/nt… ============================================================================== --- trunk/reactos/subsystems/win32/win32k/ntuser/winpos.c [iso-8859-1] (original) +++ trunk/reactos/subsystems/win32/win32k/ntuser/winpos.c [iso-8859-1] Wed May 19 20:47:39 2010 @@ -466,21 +466,25 @@ return TRUE; } -static -VOID FASTCALL -WinPosFillMinMaxInfoStruct(PWINDOW_OBJECT Window, MINMAXINFO *Info) -{ +UINT FASTCALL +co_WinPosGetMinMaxInfo(PWINDOW_OBJECT Window, POINT* MaxSize, POINT* MaxPos, + POINT* MinTrack, POINT* MaxTrack) +{ + MINMAXINFO MinMax; + PMONITOR monitor; INT xinc, yinc; LONG style = Window->Wnd->style; LONG adjustedStyle; LONG exstyle = Window->Wnd->ExStyle; RECT rc; + ASSERT_REFS_CO(Window); + /* Compute default values */ rc = Window->Wnd->rcWindow; - Info->ptReserved.x = rc.left; - Info->ptReserved.y = rc.top; + MinMax.ptReserved.x = rc.left; + MinMax.ptReserved.y = rc.top; if ((style & WS_CAPTION) == WS_CAPTION) adjustedStyle = style & ~WS_BORDER; /* WS_CAPTION = WS_DLGFRAME | WS_BORDER */ @@ -494,37 +498,53 @@ xinc = -rc.left; yinc = -rc.top; - Info->ptMaxSize.x = rc.right - rc.left; - Info->ptMaxSize.y = rc.bottom - rc.top; + MinMax.ptMaxSize.x = rc.right - rc.left; + MinMax.ptMaxSize.y = rc.bottom - rc.top; if (style & (WS_DLGFRAME | WS_BORDER)) { - Info->ptMinTrackSize.x = UserGetSystemMetrics(SM_CXMINTRACK); - Info->ptMinTrackSize.y = UserGetSystemMetrics(SM_CYMINTRACK); + MinMax.ptMinTrackSize.x = UserGetSystemMetrics(SM_CXMINTRACK); + MinMax.ptMinTrackSize.y = UserGetSystemMetrics(SM_CYMINTRACK); } else { - Info->ptMinTrackSize.x = 2 * xinc; - Info->ptMinTrackSize.y = 2 * yinc; + MinMax.ptMinTrackSize.x = 2 * xinc; + MinMax.ptMinTrackSize.y = 2 * yinc; } - Info->ptMaxTrackSize.x = UserGetSystemMetrics(SM_CXMAXTRACK); - Info->ptMaxTrackSize.y = UserGetSystemMetrics(SM_CYMAXTRACK); - Info->ptMaxPosition.x = -xinc; - Info->ptMaxPosition.y = -yinc; + MinMax.ptMaxTrackSize.x = UserGetSystemMetrics(SM_CXMAXTRACK); + MinMax.ptMaxTrackSize.y = UserGetSystemMetrics(SM_CYMAXTRACK); + MinMax.ptMaxPosition.x = -xinc; + MinMax.ptMaxPosition.y = -yinc; //if (!EMPTYPOINT(win->max_pos)) MinMax.ptMaxPosition = win->max_pos; -} - -UINT FASTCALL -co_WinPosGetMinMaxInfo(PWINDOW_OBJECT Window, POINT* MaxSize, POINT* MaxPos, - POINT* MinTrack, POINT* MaxTrack) -{ - MINMAXINFO MinMax; - - ASSERT_REFS_CO(Window); - - WinPosFillMinMaxInfoStruct(Window, &MinMax); co_IntSendMessage(Window->hSelf, WM_GETMINMAXINFO, 0, (LPARAM)&MinMax); + + /* if the app didn't change the values, adapt them for the current monitor */ + if ((monitor = IntGetPrimaryMonitor())) + { + RECT rc_work; + + rc_work = monitor->rcMonitor; + + if (style & WS_MAXIMIZEBOX) + { + if ((style & WS_CAPTION) == WS_CAPTION || !(style & (WS_CHILD | WS_POPUP))) + rc_work = monitor->rcWork; + } + + if (MinMax.ptMaxSize.x == UserGetSystemMetrics(SM_CXSCREEN) + 2 * xinc && + MinMax.ptMaxSize.y == UserGetSystemMetrics(SM_CYSCREEN) + 2 * yinc) + { + MinMax.ptMaxSize.x = (rc_work.right - rc_work.left) + 2 * xinc; + MinMax.ptMaxSize.y = (rc_work.bottom - rc_work.top) + 2 * yinc; + } + if (MinMax.ptMaxPosition.x == -xinc && MinMax.ptMaxPosition.y == -yinc) + { + MinMax.ptMaxPosition.x = rc_work.left - xinc; + MinMax.ptMaxPosition.y = rc_work.top - yinc; + } + } + MinMax.ptMaxTrackSize.x = max(MinMax.ptMaxTrackSize.x, MinMax.ptMinTrackSize.x); @@ -1827,15 +1847,9 @@ WinPosInitInternalPos(Window, &Size, &Wnd->rcWindow); - if(SendMessage) - { - co_WinPosGetMinMaxInfo(Window, &SafeMinMax.ptMaxSize, &SafeMinMax.ptMaxPosition, - &SafeMinMax.ptMinTrackSize, &SafeMinMax.ptMaxTrackSize); - } - else - { - WinPosFillMinMaxInfoStruct(Window, &SafeMinMax); - } + co_WinPosGetMinMaxInfo(Window, &SafeMinMax.ptMaxSize, &SafeMinMax.ptMaxPosition, + &SafeMinMax.ptMinTrackSize, &SafeMinMax.ptMaxTrackSize); + Status = MmCopyToCaller(MinMaxInfo, &SafeMinMax, sizeof(MINMAXINFO)); if(!NT_SUCCESS(Status)) {

1 0

[jgardou] 47279: [WIN32K] Some cleanup, no code change.
by jgardou＠svn.reactos.org 19 May '10

19 May '10

Author: jgardou Date: Wed May 19 19:41:56 2010 New Revision: 47279 URL: http://svn.reactos.org/svn/reactos?rev=47279&view=rev Log: [WIN32K] Some cleanup, no code change. Modified: branches/reactos-yarotows/subsystems/win32/win32k/ntuser/monitor.c branches/reactos-yarotows/subsystems/win32/win32k/ntuser/painting.c branches/reactos-yarotows/subsystems/win32/win32k/objects/cliprgn.c branches/reactos-yarotows/subsystems/win32/win32k/objects/region.c Modified: branches/reactos-yarotows/subsystems/win32/win32k/ntuser/monitor.c URL: http://svn.reactos.org/svn/reactos/branches/reactos-yarotows/subsystems/win… ============================================================================== --- branches/reactos-yarotows/subsystems/win32/win32k/ntuser/monitor.c [iso-8859-1] (original) +++ branches/reactos-yarotows/subsystems/win32/win32k/ntuser/monitor.c [iso-8859-1] Wed May 19 19:41:56 2010 @@ -506,7 +506,7 @@ /* FIXME: setlasterror? */ return -1; } - dcVisRgn = ((PROSRGNDATA)dc->prgnVis)->BaseObject.hHmgr; + dcVisRgn = dc->prgnVis->BaseObject.hHmgr; DC_UnlockDc(dc); regionType = NtGdiGetRgnBox(dcVisRgn, &dcRect); Modified: branches/reactos-yarotows/subsystems/win32/win32k/ntuser/painting.c URL: http://svn.reactos.org/svn/reactos/branches/reactos-yarotows/subsystems/win… ============================================================================== --- branches/reactos-yarotows/subsystems/win32/win32k/ntuser/painting.c [iso-8859-1] (original) +++ branches/reactos-yarotows/subsystems/win32/win32k/ntuser/painting.c [iso-8859-1] Wed May 19 19:41:56 2010 @@ -1206,7 +1206,7 @@ { return FALSE; } - hrgnVisible = ((PROSRGNDATA)pDC->prgnVis)->BaseObject.hHmgr; // pDC->prgnRao? + hrgnVisible = pDC->prgnVis->BaseObject.hHmgr; // pDC->prgnRao? DC_UnlockDc(pDC); /* Begin with the shifted and then clipped scroll rect */ Modified: branches/reactos-yarotows/subsystems/win32/win32k/objects/cliprgn.c URL: http://svn.reactos.org/svn/reactos/branches/reactos-yarotows/subsystems/win… ============================================================================== --- branches/reactos-yarotows/subsystems/win32/win32k/objects/cliprgn.c [iso-8859-1] (original) +++ branches/reactos-yarotows/subsystems/win32/win32k/objects/cliprgn.c [iso-8859-1] Wed May 19 19:41:56 2010 @@ -37,7 +37,7 @@ } else { - hRgnVis = ((PROSRGNDATA)Dc->prgnVis)->BaseObject.hHmgr ; + hRgnVis = Dc->prgnVis->BaseObject.hHmgr ; } @@ -94,13 +94,13 @@ if (dc->prgnVis == NULL) { dc->prgnVis = IntSysCreateRectpRgn(0, 0, 0, 0); - GDIOBJ_CopyOwnership(hdc, ((PROSRGNDATA)dc->prgnVis)->BaseObject.hHmgr); - } - - retval = NtGdiCombineRgn(((PROSRGNDATA)dc->prgnVis)->BaseObject.hHmgr, hrgn, 0, RGN_COPY); + GDIOBJ_CopyOwnership(hdc, dc->prgnVis->BaseObject.hHmgr); + } + + retval = NtGdiCombineRgn(dc->prgnVis->BaseObject.hHmgr, hrgn, 0, RGN_COPY); if ( retval != ERROR ) { - NtGdiOffsetRgn(((PROSRGNDATA)dc->prgnVis)->BaseObject.hHmgr, -dc->ptlDCOrig.x, -dc->ptlDCOrig.y); + IntGdiOffsetRgn(dc->prgnVis, -dc->ptlDCOrig.x, -dc->ptlDCOrig.y); CLIPPING_UpdateGCRegion(dc); } DC_UnlockDc(dc); Modified: branches/reactos-yarotows/subsystems/win32/win32k/objects/region.c URL: http://svn.reactos.org/svn/reactos/branches/reactos-yarotows/subsystems/win… ============================================================================== --- branches/reactos-yarotows/subsystems/win32/win32k/objects/region.c [iso-8859-1] (original) +++ branches/reactos-yarotows/subsystems/win32/win32k/objects/region.c [iso-8859-1] Wed May 19 19:41:56 2010 @@ -3691,7 +3691,7 @@ else if (pDC->dclevel.prgnMeta) hSrc = ((PROSRGNDATA)pDC->dclevel.prgnMeta)->BaseObject.hHmgr; break; case SYSRGN: - if (pDC->prgnVis) hSrc = ((PROSRGNDATA)pDC->prgnVis)->BaseObject.hHmgr; + if (pDC->prgnVis) hSrc = pDC->prgnVis->BaseObject.hHmgr; break; default: hSrc = 0;

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs