Ros-diffs

ros-diffs@reactos.org

81390 discussions

[dreimer] 41665: Fix two RosBE bugs: - clean did not remove the makefile in the PS Version. - ssvn did not work, because RosBE creates the logdir before the folder emptyness test. Plz test.
by dreimer＠svn.reactos.org 28 Jun '09

28 Jun '09

Author: dreimer Date: Sun Jun 28 18:23:17 2009 New Revision: 41665 URL: http://svn.reactos.org/svn/reactos?rev=41665&view=rev Log: Fix two RosBE bugs: - clean did not remove the makefile in the PS Version. - ssvn did not work, because RosBE creates the logdir before the folder emptyness test. Plz test. Modified: trunk/tools/RosBE/RosBE-Windows/Powershell/Clean.ps1 trunk/tools/RosBE/RosBE-Windows/Powershell/sSVN.ps1 trunk/tools/RosBE/RosBE-Windows/Root/sSVN.cmd Modified: trunk/tools/RosBE/RosBE-Windows/Powershell/Clean.ps1 URL: http://svn.reactos.org/svn/reactos/trunk/tools/RosBE/RosBE-Windows/Powershe… ============================================================================== --- trunk/tools/RosBE/RosBE-Windows/Powershell/Clean.ps1 [iso-8859-1] (original) +++ trunk/tools/RosBE/RosBE-Windows/Powershell/Clean.ps1 [iso-8859-1] Sun Jun 28 18:23:17 2009 @@ -38,9 +38,9 @@ } if ($ENV:ROS_ARCH -eq "i386") { + $MAKEFILE = "$_ROSBE_ROSSOURCEDIR\makefile.auto" + } else { $MAKEFILE = "$_ROSBE_ROSSOURCEDIR\makefile-$ENV:ROS_ARCH.auto" - } else { - $MAKEFILE = "$_ROSBE_ROSSOURCEDIR\makefile.auto" } if (Test-Path "$MAKEFILE") { Modified: trunk/tools/RosBE/RosBE-Windows/Powershell/sSVN.ps1 URL: http://svn.reactos.org/svn/reactos/trunk/tools/RosBE/RosBE-Windows/Powershe… ============================================================================== --- trunk/tools/RosBE/RosBE-Windows/Powershell/sSVN.ps1 [iso-8859-1] (original) +++ trunk/tools/RosBE/RosBE-Windows/Powershell/sSVN.ps1 [iso-8859-1] Sun Jun 28 18:23:17 2009 @@ -73,6 +73,7 @@ if (Test-Path ".svn\.") { "ERROR: Folder already contains a repository." } else { + $null = (Remove-Item "$_ROSBE_LOGDIR" -recurse -force) $dir = get-childitem if ($dir -eq $null) { IEX "&'$_ROSBE_BASEDIR\Tools\svn.exe' checkout svn://svn.reactos.org/reactos/trunk/reactos ." Modified: trunk/tools/RosBE/RosBE-Windows/Root/sSVN.cmd URL: http://svn.reactos.org/svn/reactos/trunk/tools/RosBE/RosBE-Windows/Root/sSV… ============================================================================== --- trunk/tools/RosBE/RosBE-Windows/Root/sSVN.cmd [iso-8859-1] (original) +++ trunk/tools/RosBE/RosBE-Windows/Root/sSVN.cmd [iso-8859-1] Sun Jun 28 18:23:17 2009 @@ -46,7 +46,7 @@ echo ERROR: Folder already contains a repository. goto :EOC ) - + rd /s /q "%_ROSBE_LOGDIR%" 1> NUL 2> NUL dir /b 2>nul | findstr "." >nul if errorlevel 1 ( "%_ROSBE_BASEDIR%\Tools\svn.exe" checkout svn://svn.reactos.org/reactos/trunk/reactos .

1 0

[hyperion] 41664: modified base/applications/taskmgr/affinity.c modified base/applications/taskmgr/debug.c modified base/applications/taskmgr/endproc.c modified base/applications/taskmgr/priority.c Arch Blackmann has never heard of exotic features of the C language such as "subroutines" modified base/applications/taskmgr/dbgchnl.c modified base/applications/taskmgr/procpage.c modified base/applications/taskmgr/procpage.h Did you know that Task Manager killed the wrong process when using the cont
by hyperion＠svn.reactos.org 28 Jun '09

28 Jun '09

Author: hyperion Date: Sun Jun 28 18:22:09 2009 New Revision: 41664 URL: http://svn.reactos.org/svn/reactos?rev=41664&view=rev Log: modified base/applications/taskmgr/affinity.c modified base/applications/taskmgr/debug.c modified base/applications/taskmgr/endproc.c modified base/applications/taskmgr/priority.c Arch Blackmann has never heard of exotic features of the C language such as "subroutines" modified base/applications/taskmgr/dbgchnl.c modified base/applications/taskmgr/procpage.c modified base/applications/taskmgr/procpage.h Did you know that Task Manager killed the wrong process when using the context menu? Fixed by using a sophisticated "subroutine" that reads the process entry index from the currently selected list item's client data, replacing the copy-pasted code that used the index of the list entry as the process entry index (which only worked before due to no sorting) Save the sort column and order modified base/applications/taskmgr/taskmgr.c Sort by image name by default Modified: trunk/reactos/base/applications/taskmgr/affinity.c trunk/reactos/base/applications/taskmgr/dbgchnl.c trunk/reactos/base/applications/taskmgr/debug.c trunk/reactos/base/applications/taskmgr/endproc.c trunk/reactos/base/applications/taskmgr/priority.c trunk/reactos/base/applications/taskmgr/procpage.c trunk/reactos/base/applications/taskmgr/procpage.h trunk/reactos/base/applications/taskmgr/taskmgr.c Modified: trunk/reactos/base/applications/taskmgr/affinity.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/taskmgr/… ============================================================================== --- trunk/reactos/base/applications/taskmgr/affinity.c [iso-8859-1] (original) +++ trunk/reactos/base/applications/taskmgr/affinity.c [iso-8859-1] Sun Jun 28 18:22:09 2009 @@ -40,24 +40,15 @@ void ProcessPage_OnSetAffinity(void) { - LV_ITEM lvitem; - ULONG Index; DWORD dwProcessId; WCHAR strErrorText[260]; WCHAR szTitle[256]; - for (Index=0; Index<(ULONG)ListView_GetItemCount(hProcessPageListCtrl); Index++) { - memset(&lvitem, 0, sizeof(LV_ITEM)); - lvitem.mask = LVIF_STATE; - lvitem.stateMask = LVIS_SELECTED; - lvitem.iItem = Index; - (void)ListView_GetItem(hProcessPageListCtrl, &lvitem); - if (lvitem.state & LVIS_SELECTED) - break; - } - dwProcessId = PerfDataGetProcessId(Index); - if ((ListView_GetSelectedCount(hProcessPageListCtrl) != 1) || (dwProcessId == 0)) + dwProcessId = GetSelectedProcessId(); + + if (dwProcessId == 0) return; + hProcessAffinityHandle = OpenProcess(PROCESS_QUERY_INFORMATION|PROCESS_SET_INFORMATION, FALSE, dwProcessId); if (!hProcessAffinityHandle) { GetLastErrorText(strErrorText, sizeof(strErrorText) / sizeof(WCHAR)); Modified: trunk/reactos/base/applications/taskmgr/dbgchnl.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/taskmgr/… ============================================================================== --- trunk/reactos/base/applications/taskmgr/dbgchnl.c [iso-8859-1] (original) +++ trunk/reactos/base/applications/taskmgr/dbgchnl.c [iso-8859-1] Sun Jun 28 18:22:09 2009 @@ -40,33 +40,6 @@ return TRUE; #endif return FALSE; -} - -static DWORD get_selected_pid(void) -{ - LVITEM lvitem; - ULONG Index; - DWORD dwProcessId; - - for (Index=0; Index<(ULONG)ListView_GetItemCount(hProcessPageListCtrl); Index++) - { - memset(&lvitem, 0, sizeof(LVITEM)); - - lvitem.mask = LVIF_STATE; - lvitem.stateMask = LVIS_SELECTED; - lvitem.iItem = Index; - - (void)ListView_GetItem(hProcessPageListCtrl, &lvitem); - - if (lvitem.state & LVIS_SELECTED) - break; - } - - dwProcessId = PerfDataGetProcessId(Index); - - if ((ListView_GetSelectedCount(hProcessPageListCtrl) != 1) || (dwProcessId == 0)) - return 0; - return dwProcessId; } static int list_channel_CB(HANDLE hProcess, void* addr, WCHAR* buffer, void* user) @@ -290,7 +263,7 @@ (void)ListView_DeleteAllItems(hChannelLV); - hProcess = OpenProcess(PROCESS_VM_OPERATION | PROCESS_VM_READ, FALSE, get_selected_pid()); + hProcess = OpenProcess(PROCESS_VM_OPERATION | PROCESS_VM_READ, FALSE, GetSelectedProcessId()); if (!hProcess) return; /* FIXME messagebox */ SendMessageW(hChannelLV, WM_SETREDRAW, FALSE, 0); enum_channel(hProcess, list_channel_CB, (void*)hChannelLV, TRUE); @@ -350,7 +323,7 @@ HANDLE hProcess; NMITEMACTIVATE* nmia = (NMITEMACTIVATE*)lParam; - hProcess = OpenProcess(PROCESS_VM_OPERATION | PROCESS_VM_READ | PROCESS_VM_WRITE, FALSE, get_selected_pid()); + hProcess = OpenProcess(PROCESS_VM_OPERATION | PROCESS_VM_READ | PROCESS_VM_WRITE, FALSE, GetSelectedProcessId()); if (!hProcess) return; /* FIXME message box */ lhti.pt = nmia->ptAction; hChannelLV = GetDlgItem(hDlg, IDC_DEBUG_CHANNELS_LIST); Modified: trunk/reactos/base/applications/taskmgr/debug.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/taskmgr/… ============================================================================== --- trunk/reactos/base/applications/taskmgr/debug.c [iso-8859-1] (original) +++ trunk/reactos/base/applications/taskmgr/debug.c [iso-8859-1] Sun Jun 28 18:22:09 2009 @@ -25,8 +25,6 @@ void ProcessPage_OnDebug(void) { - LVITEM lvitem; - ULONG Index; DWORD dwProcessId; WCHAR strErrorText[260]; HKEY hKey; @@ -39,24 +37,9 @@ WCHAR szTemp[256]; WCHAR szTempA[256]; + dwProcessId = GetSelectedProcessId(); - for (Index=0; Index<(ULONG)ListView_GetItemCount(hProcessPageListCtrl); Index++) - { - memset(&lvitem, 0, sizeof(LVITEM)); - - lvitem.mask = LVIF_STATE; - lvitem.stateMask = LVIS_SELECTED; - lvitem.iItem = Index; - - (void)ListView_GetItem(hProcessPageListCtrl, &lvitem); - - if (lvitem.state & LVIS_SELECTED) - break; - } - - dwProcessId = PerfDataGetProcessId(Index); - - if ((ListView_GetSelectedCount(hProcessPageListCtrl) != 1) || (dwProcessId == 0)) + if (dwProcessId == 0) return; LoadStringW(hInst, IDS_MSG_WARNINGDEBUG, szTemp, 256); Modified: trunk/reactos/base/applications/taskmgr/endproc.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/taskmgr/… ============================================================================== --- trunk/reactos/base/applications/taskmgr/endproc.c [iso-8859-1] (original) +++ trunk/reactos/base/applications/taskmgr/endproc.c [iso-8859-1] Sun Jun 28 18:22:09 2009 @@ -25,30 +25,14 @@ void ProcessPage_OnEndProcess(void) { - LVITEM lvitem; - ULONG Index; DWORD dwProcessId; HANDLE hProcess; WCHAR szTitle[256]; WCHAR strErrorText[260]; - for (Index=0; Index<(ULONG)ListView_GetItemCount(hProcessPageListCtrl); Index++) - { - memset(&lvitem, 0, sizeof(LVITEM)); + dwProcessId = GetSelectedProcessId(); - lvitem.mask = LVIF_STATE; - lvitem.stateMask = LVIS_SELECTED; - lvitem.iItem = Index; - - (void)ListView_GetItem(hProcessPageListCtrl, &lvitem); - - if (lvitem.state & LVIS_SELECTED) - break; - } - - dwProcessId = PerfDataGetProcessId(Index); - - if ((ListView_GetSelectedCount(hProcessPageListCtrl) != 1) || (dwProcessId == 0)) + if (dwProcessId == 0) return; LoadStringW(hInst, IDS_MSG_WARNINGTERMINATING, strErrorText, 256); @@ -78,30 +62,14 @@ void ProcessPage_OnEndProcessTree(void) { - LVITEM lvitem; - ULONG Index; DWORD dwProcessId; HANDLE hProcess; WCHAR szTitle[256]; WCHAR strErrorText[260]; - for (Index=0; Index<(ULONG)ListView_GetItemCount(hProcessPageListCtrl); Index++) - { - memset(&lvitem, 0, sizeof(LVITEM)); + dwProcessId = GetSelectedProcessId(); - lvitem.mask = LVIF_STATE; - lvitem.stateMask = LVIS_SELECTED; - lvitem.iItem = Index; - - (void)ListView_GetItem(hProcessPageListCtrl, &lvitem); - - if (lvitem.state & LVIS_SELECTED) - break; - } - - dwProcessId = PerfDataGetProcessId(Index); - - if ((ListView_GetSelectedCount(hProcessPageListCtrl) != 1) || (dwProcessId == 0)) + if (dwProcessId == 0) return; LoadStringW(hInst, IDS_MSG_WARNINGTERMINATING, strErrorText, 256); Modified: trunk/reactos/base/applications/taskmgr/priority.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/taskmgr/… ============================================================================== --- trunk/reactos/base/applications/taskmgr/priority.c [iso-8859-1] (original) +++ trunk/reactos/base/applications/taskmgr/priority.c [iso-8859-1] Sun Jun 28 18:22:09 2009 @@ -25,30 +25,14 @@ void DoSetPriority(DWORD priority) { - LVITEM lvitem; - ULONG Index; DWORD dwProcessId; HANDLE hProcess; WCHAR szText[260]; WCHAR szTitle[256]; - for (Index=0; Index<(ULONG)ListView_GetItemCount(hProcessPageListCtrl); Index++) - { - ZeroMemory(&lvitem, sizeof(LVITEM)); + dwProcessId = GetSelectedProcessId(); - lvitem.mask = LVIF_STATE; - lvitem.stateMask = LVIS_SELECTED; - lvitem.iItem = Index; - - (void)ListView_GetItem(hProcessPageListCtrl, &lvitem); - - if (lvitem.state & LVIS_SELECTED) - break; - } - - dwProcessId = PerfDataGetProcessId(Index); - - if ((ListView_GetSelectedCount(hProcessPageListCtrl) != 1) || (dwProcessId == 0)) + if (dwProcessId == 0) return; LoadStringW(hInst, IDS_MSG_TASKMGRWARNING, szTitle, 256); Modified: trunk/reactos/base/applications/taskmgr/procpage.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/taskmgr/… ============================================================================== --- trunk/reactos/base/applications/taskmgr/procpage.c [iso-8859-1] (original) +++ trunk/reactos/base/applications/taskmgr/procpage.c [iso-8859-1] Sun Jun 28 18:22:09 2009 @@ -40,10 +40,7 @@ static int nProcessPageWidth; static int nProcessPageHeight; -static BOOL bProcessSort = FALSE; -static BOOL bProcessSortAscending = FALSE; static HANDLE hProcessPageEvent = NULL; /* When this event becomes signaled then we refresh the process list */ -static ULONG ProcessSortColumnIndex = 0; int CALLBACK ProcessPageCompareFunc(LPARAM lParam1, LPARAM lParam2, LPARAM lParamSort); void AddProcess(ULONG Index); @@ -55,6 +52,29 @@ BOOL PerfDataGetText(ULONG Index, ULONG ColumnIndex, LPTSTR lpText, int nMaxCount); DWORD WINAPI ProcessPageRefreshThread(void *lpParameter); +DWORD GetSelectedProcessId(void) +{ + int Index; + LVITEM lvitem; + + if(ListView_GetSelectedCount(hProcessPageListCtrl) == 1) + { + Index = ListView_GetSelectionMark(hProcessPageListCtrl); + + memset(&lvitem, 0, sizeof(LVITEM)); + + lvitem.mask = LVIF_PARAM; + lvitem.iItem = Index; + + (void)ListView_GetItem(hProcessPageListCtrl, &lvitem); + + if (lvitem.lParam) + return PerfDataGetProcessId(((LPPROCESS_PAGE_LIST_ITEM)lvitem.lParam)->Index); + } + + return 0; +} + INT_PTR CALLBACK ProcessPageWndProc(HWND hDlg, UINT message, WPARAM wParam, LPARAM lParam) { @@ -171,7 +191,6 @@ LPNMLISTVIEW pnmv; NMLVDISPINFO* pnmdi; LPNMHEADER pnmhdr; - LVITEM lvitem; ULONG Index; ULONG ColumnIndex; LPPROCESS_PAGE_LIST_ITEM pData; @@ -207,26 +226,7 @@ case NM_RCLICK: - for (Index=0; Index<(ULONG)ListView_GetItemCount(hProcessPageListCtrl); Index++) - { - memset(&lvitem, 0, sizeof(LVITEM)); - - lvitem.mask = LVIF_STATE; - lvitem.stateMask = LVIS_SELECTED; - lvitem.iItem = Index; - - (void)ListView_GetItem(hProcessPageListCtrl, &lvitem); - - if (lvitem.state & LVIS_SELECTED) - break; - } - - if ((ListView_GetSelectedCount(hProcessPageListCtrl) == 1) && - (PerfDataGetProcessId(Index) != 0)) - { - ProcessPageShowContextMenu(PerfDataGetProcessId(Index)); - } - + ProcessPageShowContextMenu(GetSelectedProcessId()); break; } @@ -237,10 +237,9 @@ { case HDN_ITEMCLICK: - ProcessSortColumnIndex = pnmhdr->iItem; - bProcessSortAscending = !bProcessSortAscending; + TaskManagerSettings.SortColumn = ColumnDataHints[pnmhdr->iItem]; + TaskManagerSettings.SortAscending = !TaskManagerSettings.SortAscending; (void)ListView_SortItems(hProcessPageListCtrl, ProcessPageCompareFunc, NULL); - bProcessSort = TRUE; break; @@ -447,7 +446,7 @@ { AddProcess(l); } - if (bProcessSort) + if (TaskManagerSettings.SortColumn != -1) { (void)ListView_SortItems(hProcessPageListCtrl, ProcessPageCompareFunc, NULL); } @@ -674,7 +673,6 @@ int ret = 0; LPPROCESS_PAGE_LIST_ITEM Param1; LPPROCESS_PAGE_LIST_ITEM Param2; - ULONG ColumnIndex; WCHAR text1[260]; WCHAR text2[260]; ULONG l1; @@ -686,130 +684,129 @@ ULONGLONG ull1; ULONGLONG ull2; - if (bProcessSortAscending) { + if (TaskManagerSettings.SortAscending) { Param1 = (LPPROCESS_PAGE_LIST_ITEM)lParam1; Param2 = (LPPROCESS_PAGE_LIST_ITEM)lParam2; } else { Param1 = (LPPROCESS_PAGE_LIST_ITEM)lParam2; Param2 = (LPPROCESS_PAGE_LIST_ITEM)lParam1; } - ColumnIndex = ProcessSortColumnIndex; - - if (ColumnDataHints[ColumnIndex] == COLUMN_IMAGENAME) + + if (TaskManagerSettings.SortColumn == COLUMN_IMAGENAME) { PerfDataGetImageName(Param1->Index, text1, sizeof (text1) / sizeof (*text1)); PerfDataGetImageName(Param2->Index, text2, sizeof (text2) / sizeof (*text2)); ret = _wcsicmp(text1, text2); } - else if (ColumnDataHints[ColumnIndex] == COLUMN_PID) + else if (TaskManagerSettings.SortColumn == COLUMN_PID) { l1 = PerfDataGetProcessId(Param1->Index); l2 = PerfDataGetProcessId(Param2->Index); ret = CMP(l1, l2); } - else if (ColumnDataHints[ColumnIndex] == COLUMN_USERNAME) + else if (TaskManagerSettings.SortColumn == COLUMN_USERNAME) { PerfDataGetUserName(Param1->Index, text1, sizeof (text1) / sizeof (*text1)); PerfDataGetUserName(Param2->Index, text2, sizeof (text2) / sizeof (*text2)); ret = _wcsicmp(text1, text2); } - else if (ColumnDataHints[ColumnIndex] == COLUMN_SESSIONID) + else if (TaskManagerSettings.SortColumn == COLUMN_SESSIONID) { l1 = PerfDataGetSessionId(Param1->Index); l2 = PerfDataGetSessionId(Param2->Index); ret = CMP(l1, l2); } - else if (ColumnDataHints[ColumnIndex] == COLUMN_CPUUSAGE) + else if (TaskManagerSettings.SortColumn == COLUMN_CPUUSAGE) { l1 = PerfDataGetCPUUsage(Param1->Index); l2 = PerfDataGetCPUUsage(Param2->Index); ret = CMP(l1, l2); } - else if (ColumnDataHints[ColumnIndex] == COLUMN_CPUTIME) + else if (TaskManagerSettings.SortColumn == COLUMN_CPUTIME) { time1 = PerfDataGetCPUTime(Param1->Index); time2 = PerfDataGetCPUTime(Param2->Index); ret = largeintcmp(time1, time2); } - else if (ColumnDataHints[ColumnIndex] == COLUMN_MEMORYUSAGE) + else if (TaskManagerSettings.SortColumn == COLUMN_MEMORYUSAGE) { l1 = PerfDataGetWorkingSetSizeBytes(Param1->Index); l2 = PerfDataGetWorkingSetSizeBytes(Param2->Index); ret = CMP(l1, l2); } - else if (ColumnDataHints[ColumnIndex] == COLUMN_PEAKMEMORYUSAGE) + else if (TaskManagerSettings.SortColumn == COLUMN_PEAKMEMORYUSAGE) { l1 = PerfDataGetPeakWorkingSetSizeBytes(Param1->Index); l2 = PerfDataGetPeakWorkingSetSizeBytes(Param2->Index); ret = CMP(l1, l2); } - else if (ColumnDataHints[ColumnIndex] == COLUMN_MEMORYUSAGEDELTA) + else if (TaskManagerSettings.SortColumn == COLUMN_MEMORYUSAGEDELTA) { l1 = PerfDataGetWorkingSetSizeDelta(Param1->Index); l2 = PerfDataGetWorkingSetSizeDelta(Param2->Index); ret = CMP(l1, l2); } - else if (ColumnDataHints[ColumnIndex] == COLUMN_PAGEFAULTS) + else if (TaskManagerSettings.SortColumn == COLUMN_PAGEFAULTS) { l1 = PerfDataGetPageFaultCount(Param1->Index); l2 = PerfDataGetPageFaultCount(Param2->Index); ret = CMP(l1, l2); } - else if (ColumnDataHints[ColumnIndex] == COLUMN_PAGEFAULTSDELTA) + else if (TaskManagerSettings.SortColumn == COLUMN_PAGEFAULTSDELTA) { l1 = PerfDataGetPageFaultCountDelta(Param1->Index); l2 = PerfDataGetPageFaultCountDelta(Param2->Index); ret = CMP(l1, l2); } - else if (ColumnDataHints[ColumnIndex] == COLUMN_VIRTUALMEMORYSIZE) + else if (TaskManagerSettings.SortColumn == COLUMN_VIRTUALMEMORYSIZE) { l1 = PerfDataGetVirtualMemorySizeBytes(Param1->Index); l2 = PerfDataGetVirtualMemorySizeBytes(Param2->Index); ret = CMP(l1, l2); } - else if (ColumnDataHints[ColumnIndex] == COLUMN_PAGEDPOOL) + else if (TaskManagerSettings.SortColumn == COLUMN_PAGEDPOOL) { l1 = PerfDataGetPagedPoolUsagePages(Param1->Index); l2 = PerfDataGetPagedPoolUsagePages(Param2->Index); ret = CMP(l1, l2); } - else if (ColumnDataHints[ColumnIndex] == COLUMN_NONPAGEDPOOL) + else if (TaskManagerSettings.SortColumn == COLUMN_NONPAGEDPOOL) { l1 = PerfDataGetNonPagedPoolUsagePages(Param1->Index); l2 = PerfDataGetNonPagedPoolUsagePages(Param2->Index); ret = CMP(l1, l2); } - else if (ColumnDataHints[ColumnIndex] == COLUMN_BASEPRIORITY) + else if (TaskManagerSettings.SortColumn == COLUMN_BASEPRIORITY) { l1 = PerfDataGetBasePriority(Param1->Index); l2 = PerfDataGetBasePriority(Param2->Index); ret = CMP(l1, l2); } - else if (ColumnDataHints[ColumnIndex] == COLUMN_HANDLECOUNT) + else if (TaskManagerSettings.SortColumn == COLUMN_HANDLECOUNT) { l1 = PerfDataGetHandleCount(Param1->Index); l2 = PerfDataGetHandleCount(Param2->Index); ret = CMP(l1, l2); } - else if (ColumnDataHints[ColumnIndex] == COLUMN_THREADCOUNT) + else if (TaskManagerSettings.SortColumn == COLUMN_THREADCOUNT) { l1 = PerfDataGetThreadCount(Param1->Index); l2 = PerfDataGetThreadCount(Param2->Index); ret = CMP(l1, l2); } - else if (ColumnDataHints[ColumnIndex] == COLUMN_USEROBJECTS) + else if (TaskManagerSettings.SortColumn == COLUMN_USEROBJECTS) { l1 = PerfDataGetUSERObjectCount(Param1->Index); l2 = PerfDataGetUSERObjectCount(Param2->Index); ret = CMP(l1, l2); } - else if (ColumnDataHints[ColumnIndex] == COLUMN_GDIOBJECTS) + else if (TaskManagerSettings.SortColumn == COLUMN_GDIOBJECTS) { l1 = PerfDataGetGDIObjectCount(Param1->Index); l2 = PerfDataGetGDIObjectCount(Param2->Index); ret = CMP(l1, l2); } - else if (ColumnDataHints[ColumnIndex] == COLUMN_IOREADS) + else if (TaskManagerSettings.SortColumn == COLUMN_IOREADS) { PerfDataGetIOCounters(Param1->Index, &iocounters1); PerfDataGetIOCounters(Param2->Index, &iocounters2); @@ -817,7 +814,7 @@ ull2 = iocounters2.ReadOperationCount; ret = CMP(ull1, ull2); } - else if (ColumnDataHints[ColumnIndex] == COLUMN_IOWRITES) + else if (TaskManagerSettings.SortColumn == COLUMN_IOWRITES) { PerfDataGetIOCounters(Param1->Index, &iocounters1); PerfDataGetIOCounters(Param2->Index, &iocounters2); @@ -825,7 +822,7 @@ ull2 = iocounters2.WriteOperationCount; ret = CMP(ull1, ull2); } - else if (ColumnDataHints[ColumnIndex] == COLUMN_IOOTHER) + else if (TaskManagerSettings.SortColumn == COLUMN_IOOTHER) { PerfDataGetIOCounters(Param1->Index, &iocounters1); PerfDataGetIOCounters(Param2->Index, &iocounters2); @@ -833,7 +830,7 @@ ull2 = iocounters2.OtherOperationCount; ret = CMP(ull1, ull2); } - else if (ColumnDataHints[ColumnIndex] == COLUMN_IOREADBYTES) + else if (TaskManagerSettings.SortColumn == COLUMN_IOREADBYTES) { PerfDataGetIOCounters(Param1->Index, &iocounters1); PerfDataGetIOCounters(Param2->Index, &iocounters2); @@ -841,7 +838,7 @@ ull2 = iocounters2.ReadTransferCount; ret = CMP(ull1, ull2); } - else if (ColumnDataHints[ColumnIndex] == COLUMN_IOWRITEBYTES) + else if (TaskManagerSettings.SortColumn == COLUMN_IOWRITEBYTES) { PerfDataGetIOCounters(Param1->Index, &iocounters1); PerfDataGetIOCounters(Param2->Index, &iocounters2); @@ -849,7 +846,7 @@ ull2 = iocounters2.WriteTransferCount; ret = CMP(ull1, ull2); } - else if (ColumnDataHints[ColumnIndex] == COLUMN_IOOTHERBYTES) + else if (TaskManagerSettings.SortColumn == COLUMN_IOOTHERBYTES) { PerfDataGetIOCounters(Param1->Index, &iocounters1); PerfDataGetIOCounters(Param2->Index, &iocounters2); Modified: trunk/reactos/base/applications/taskmgr/procpage.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/taskmgr/… ============================================================================== --- trunk/reactos/base/applications/taskmgr/procpage.h [iso-8859-1] (original) +++ trunk/reactos/base/applications/taskmgr/procpage.h [iso-8859-1] Sun Jun 28 18:22:09 2009 @@ -31,5 +31,6 @@ INT_PTR CALLBACK ProcessPageWndProc(HWND hDlg, UINT message, WPARAM wParam, LPARAM lParam); void RefreshProcessPage(void); +DWORD GetSelectedProcessId(void); #endif /* __PROCESSPAGE_H */ Modified: trunk/reactos/base/applications/taskmgr/taskmgr.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/taskmgr/… ============================================================================== --- trunk/reactos/base/applications/taskmgr/taskmgr.c [iso-8859-1] (original) +++ trunk/reactos/base/applications/taskmgr/taskmgr.c [iso-8859-1] Sun Jun 28 18:22:09 2009 @@ -706,7 +706,7 @@ TaskManagerSettings.ColumnSizeArray[i] = ColumnPresets[i].size; } - TaskManagerSettings.SortColumn = 1; + TaskManagerSettings.SortColumn = COLUMN_IMAGENAME; TaskManagerSettings.SortAscending = TRUE; /* Performance page settings */

1 0

[janderwald] 41663: - Fix build
by janderwald＠svn.reactos.org 28 Jun '09

28 Jun '09

Author: janderwald Date: Sun Jun 28 18:12:58 2009 New Revision: 41663 URL: http://svn.reactos.org/svn/reactos?rev=41663&view=rev Log: - Fix build Modified: trunk/reactos/include/ddk/strmini.h Modified: trunk/reactos/include/ddk/strmini.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/ddk/strmini.h?rev=… ============================================================================== --- trunk/reactos/include/ddk/strmini.h [iso-8859-1] (original) +++ trunk/reactos/include/ddk/strmini.h [iso-8859-1] Sun Jun 28 18:12:58 2009 @@ -451,7 +451,7 @@ IN ULONG AssertValue ); -VOID +VOID __cdecl StreamClassDebugPrint( IN STREAM_DEBUG_LEVEL DebugPrintLevel, @@ -464,7 +464,10 @@ StreamClassDeviceNotification( IN STREAM_MINIDRIVER_DEVICE_NOTIFICATION_TYPE NotificationType, IN PVOID HwDeviceExtension, - ... + IN PHW_STREAM_REQUEST_BLOCK pSrb, + IN PKSEVENT_ENTRY EventEntry, + IN GUID *EventSet, + IN ULONG EventId ); VOID

1 0

[janderwald] 41662: - Start implementing the stream class driver - Implemented StreamClassRegisterAdapter, StreamClassReenumerateStreams, StreamClassDebugAssert, StreamClassDebugPrint, StreamClassGetDmaBuffer - Drivers using stream class driver should now be able to initialize
by janderwald＠svn.reactos.org 28 Jun '09

28 Jun '09

Author: janderwald Date: Sun Jun 28 17:58:47 2009 New Revision: 41662 URL: http://svn.reactos.org/svn/reactos?rev=41662&view=rev Log: - Start implementing the stream class driver - Implemented StreamClassRegisterAdapter, StreamClassReenumerateStreams, StreamClassDebugAssert, StreamClassDebugPrint, StreamClassGetDmaBuffer - Drivers using stream class driver should now be able to initialize Added: trunk/reactos/drivers/wdm/audio/legacy/stream/ (with props) trunk/reactos/drivers/wdm/audio/legacy/stream/control.c (with props) trunk/reactos/drivers/wdm/audio/legacy/stream/dll.c (with props) trunk/reactos/drivers/wdm/audio/legacy/stream/driver.c (with props) trunk/reactos/drivers/wdm/audio/legacy/stream/filter.c (with props) trunk/reactos/drivers/wdm/audio/legacy/stream/helper.c (with props) trunk/reactos/drivers/wdm/audio/legacy/stream/pnp.c (with props) trunk/reactos/drivers/wdm/audio/legacy/stream/stream.h (with props) trunk/reactos/drivers/wdm/audio/legacy/stream/stream.rbuild (with props) trunk/reactos/drivers/wdm/audio/legacy/stream/stream.rc (with props) trunk/reactos/drivers/wdm/audio/legacy/stream/stream.spec (with props) Modified: trunk/reactos/drivers/wdm/audio/legacy/directory.rbuild Modified: trunk/reactos/drivers/wdm/audio/legacy/directory.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/wdm/audio/legacy/d… ============================================================================== --- trunk/reactos/drivers/wdm/audio/legacy/directory.rbuild [iso-8859-1] (original) +++ trunk/reactos/drivers/wdm/audio/legacy/directory.rbuild [iso-8859-1] Sun Jun 28 17:58:47 2009 @@ -4,4 +4,8 @@ <directory name="wdmaud"> <xi:include href="wdmaud/wdmaud.rbuild" /> </directory> + <directory name="stream"> + <xi:include href="stream/stream.rbuild" /> + </directory> + </group> Propchange: trunk/reactos/drivers/wdm/audio/legacy/stream/ ------------------------------------------------------------------------------ --- bugtraq:logregex (added) +++ bugtraq:logregex Sun Jun 28 17:58:47 2009 @@ -1,0 +1,2 @@ +([Ii]ssue|[Bb]ug)s? #?(\d+)(,? ?#?(\d+))*(,? ?(and |or )?#?(\d+))? +(\d+) Propchange: trunk/reactos/drivers/wdm/audio/legacy/stream/ ------------------------------------------------------------------------------ bugtraq:message = See issue #%BUGID% for more details. Propchange: trunk/reactos/drivers/wdm/audio/legacy/stream/ ------------------------------------------------------------------------------ bugtraq:url = http://www.reactos.org/bugzilla/show_bug.cgi?id=%BUGID% Propchange: trunk/reactos/drivers/wdm/audio/legacy/stream/ ------------------------------------------------------------------------------ tsvn:logminsize = 10 Added: trunk/reactos/drivers/wdm/audio/legacy/stream/control.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/wdm/audio/legacy/s… ============================================================================== --- trunk/reactos/drivers/wdm/audio/legacy/stream/control.c (added) +++ trunk/reactos/drivers/wdm/audio/legacy/stream/control.c [iso-8859-1] Sun Jun 28 17:58:47 2009 @@ -1,0 +1,71 @@ +/* + * COPYRIGHT: See COPYING in the top level directory + * PROJECT: ReactOS Kernel Streaming + * FILE: drivers/wdm/audio/legacy/stream/dll.c + * PURPOSE: kernel mode driver initialization + * PROGRAMMER: Johannes Anderwald + */ + + +#include "stream.h" + + +NTSTATUS +NTAPI +StreamClassPower( + IN PDEVICE_OBJECT DeviceObject, + IN PIRP Irp) +{ + Irp->IoStatus.Information = 0; + Irp->IoStatus.Status = STATUS_SUCCESS; + IoCompleteRequest(Irp, IO_NO_INCREMENT); + return STATUS_SUCCESS; +} + +NTSTATUS +NTAPI +StreamClassSystemControl( + IN PDEVICE_OBJECT DeviceObject, + IN PIRP Irp) +{ + Irp->IoStatus.Information = 0; + Irp->IoStatus.Status = STATUS_SUCCESS; + IoCompleteRequest(Irp, IO_NO_INCREMENT); + return STATUS_SUCCESS; +} + +NTSTATUS +NTAPI +StreamClassCleanup( + IN PDEVICE_OBJECT DeviceObject, + IN PIRP Irp) +{ + Irp->IoStatus.Information = 0; + Irp->IoStatus.Status = STATUS_SUCCESS; + IoCompleteRequest(Irp, IO_NO_INCREMENT); + return STATUS_SUCCESS; +} + +NTSTATUS +NTAPI +StreamClassFlushBuffers( + IN PDEVICE_OBJECT DeviceObject, + IN PIRP Irp) +{ + Irp->IoStatus.Information = 0; + Irp->IoStatus.Status = STATUS_SUCCESS; + IoCompleteRequest(Irp, IO_NO_INCREMENT); + return STATUS_SUCCESS; +} + +NTSTATUS +NTAPI +StreamClassDeviceControl( + IN PDEVICE_OBJECT DeviceObject, + IN PIRP Irp) +{ + Irp->IoStatus.Information = 0; + Irp->IoStatus.Status = STATUS_SUCCESS; + IoCompleteRequest(Irp, IO_NO_INCREMENT); + return STATUS_SUCCESS; +} Propchange: trunk/reactos/drivers/wdm/audio/legacy/stream/control.c ------------------------------------------------------------------------------ svn:eol-style = native Added: trunk/reactos/drivers/wdm/audio/legacy/stream/dll.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/wdm/audio/legacy/s… ============================================================================== --- trunk/reactos/drivers/wdm/audio/legacy/stream/dll.c (added) +++ trunk/reactos/drivers/wdm/audio/legacy/stream/dll.c [iso-8859-1] Sun Jun 28 17:58:47 2009 @@ -1,0 +1,30 @@ +/* + * COPYRIGHT: See COPYING in the top level directory + * PROJECT: ReactOS Kernel Streaming + * FILE: drivers/wdm/audio/legacy/stream/dll.c + * PURPOSE: kernel mode driver initialization + * PROGRAMMER: Johannes Anderwald + */ + + +#include "stream.h" + +/* + * @implemented + */ +ULONG +NTAPI +DllInitialize(ULONG Unknown) +{ + return 0; +} + +/* + * @implemented + */ +ULONG +NTAPI +DllUnload(VOID) +{ + return 0; +} Propchange: trunk/reactos/drivers/wdm/audio/legacy/stream/dll.c ------------------------------------------------------------------------------ svn:eol-style = native Added: trunk/reactos/drivers/wdm/audio/legacy/stream/driver.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/wdm/audio/legacy/s… ============================================================================== --- trunk/reactos/drivers/wdm/audio/legacy/stream/driver.c (added) +++ trunk/reactos/drivers/wdm/audio/legacy/stream/driver.c [iso-8859-1] Sun Jun 28 17:58:47 2009 @@ -1,0 +1,299 @@ +/* + * COPYRIGHT: See COPYING in the top level directory + * PROJECT: ReactOS Kernel Streaming + * FILE: drivers/wdm/audio/legacy/stream/driver.c + * PURPOSE: WDM Codec Class Driver + * PROGRAMMER: Johannes Anderwald + */ + +#include "stream.h" + +NTSTATUS +NTAPI +StreamClassAddDevice( + IN PDRIVER_OBJECT DriverObject, + IN PDEVICE_OBJECT PhysicalDeviceObject) +{ + PSTREAM_CLASS_DRIVER_EXTENSION DriverObjectExtension; + PDEVICE_OBJECT DeviceObject, LowerDeviceObject; + PSTREAM_DEVICE_EXTENSION DeviceExtension; + PKSOBJECT_CREATE_ITEM ItemList; + NTSTATUS Status; + + /* Fetch driver object extension */ + DriverObjectExtension = IoGetDriverObjectExtension(DriverObject, (PVOID)StreamClassAddDevice); + if (!DriverObjectExtension) + { + /* Failed to get driver extension */ + return STATUS_DEVICE_DOES_NOT_EXIST; + } + /* Allocate Create Item */ + ItemList = ExAllocatePool(NonPagedPool, sizeof(KSOBJECT_CREATE_ITEM)); + if (!ItemList) + { + /* Failed to allocated Create Item */ + return STATUS_INSUFFICIENT_RESOURCES; + } + + /* Create the FDO */ + Status = IoCreateDevice(DriverObject, DriverObjectExtension->Data.DeviceExtensionSize + sizeof(STREAM_DEVICE_EXTENSION), NULL, FILE_DEVICE_KS, FILE_AUTOGENERATED_DEVICE_NAME | FILE_DEVICE_SECURE_OPEN, 0, &DeviceObject); + if (!NT_SUCCESS(Status)) + { + /* Failed to create the FDO */ + ExFreePool(ItemList); + return Status; + } + + /* Attach to device stack */ + LowerDeviceObject = IoAttachDeviceToDeviceStack(DeviceObject, PhysicalDeviceObject); + if (!LowerDeviceObject) + { + /* Failed to attach */ + IoDeleteDevice(DeviceObject); + return STATUS_UNSUCCESSFUL; + } + + /* Zero Create item */ + RtlZeroMemory(ItemList, sizeof(KSOBJECT_CREATE_ITEM)); + /* Setup object class */ + RtlInitUnicodeString(&ItemList->ObjectClass, L"STREAMCLASS"); + /* Setup CreateDispatch routine */ + ItemList->Create = StreamClassCreateFilter; + + /* Get device extension */ + DeviceExtension = (PSTREAM_DEVICE_EXTENSION)DeviceObject->DeviceExtension; + /* Zero device extension */ + RtlZeroMemory(DeviceExtension, sizeof(STREAM_DEVICE_EXTENSION)); + /* Initialize Ks streaming */ + Status = KsAllocateDeviceHeader(&DeviceExtension->Header, 1, ItemList); + if (!NT_SUCCESS(Status)) + { + /* Cleanup resources */ + IoDetachDevice(LowerDeviceObject); + IoDeleteDevice(DeviceObject); + ExFreePool(ItemList); + return Status; + } + + /* Store lower device object */ + DeviceExtension->LowerDeviceObject = LowerDeviceObject; + + /* Store physical device object */ + DeviceExtension->PhysicalDeviceObject = PhysicalDeviceObject; + /* Store driver object extension */ + DeviceExtension->DriverExtension = DriverObjectExtension; + /* Initialize memory list */ + InitializeListHead(&DeviceExtension->MemoryResourceList); + /* Setup device extension */ + DeviceExtension->DeviceExtension = (PVOID) (DeviceExtension + 1); + /* Init interrupt dpc */ + KeInitializeDpc(&DeviceExtension->InterruptDpc, StreamClassInterruptDpc, (PVOID)DeviceExtension); + + /* Set device transfer method */ + DeviceObject->Flags |= DO_DIRECT_IO | DO_POWER_PAGABLE; + /* Clear init flag */ + DeviceObject->Flags &= ~ DO_DEVICE_INITIALIZING; + + return Status; +} + +/* + *@implemented + */ +NTSTATUS +STREAMAPI +StreamClassRegisterAdapter( + IN PVOID Argument1, + IN PVOID Argument2, + IN PHW_INITIALIZATION_DATA HwInitializationData) +{ + NTSTATUS Status; + PSTREAM_CLASS_DRIVER_EXTENSION DriverObjectExtension; + PDRIVER_OBJECT DriverObject = (PDRIVER_OBJECT)Argument1; + + /* Allocate driver extension */ + Status = IoAllocateDriverObjectExtension(DriverObject, (PVOID)StreamClassAddDevice, sizeof(STREAM_CLASS_DRIVER_EXTENSION), (PVOID*)&DriverObjectExtension); + if (!NT_SUCCESS(Status)) + { + /* Failed to allocate */ + return STATUS_INSUFFICIENT_RESOURCES; + } + + /* Zero driver object extension */ + RtlZeroMemory(DriverObjectExtension, sizeof(STREAM_CLASS_DRIVER_EXTENSION)); + + /* copy HwInitializationData */ + RtlCopyMemory(&DriverObjectExtension->Data, HwInitializationData, sizeof(HW_INITIALIZATION_DATA)); + + /* Setup device init methods */ + DriverObject->DriverExtension->AddDevice = StreamClassAddDevice; + DriverObject->DriverUnload = KsNullDriverUnload; + + /* Setup irp handlers */ + DriverObject->MajorFunction[IRP_MJ_PNP] = StreamClassPnp; + DriverObject->MajorFunction[IRP_MJ_POWER] = StreamClassPower; + DriverObject->MajorFunction[IRP_MJ_SYSTEM_CONTROL] = StreamClassSystemControl; + DriverObject->MajorFunction[IRP_MJ_CLEANUP] = StreamClassCleanup; + DriverObject->MajorFunction[IRP_MJ_FLUSH_BUFFERS] = StreamClassFlushBuffers; + DriverObject->MajorFunction[IRP_MJ_DEVICE_CONTROL] = StreamClassDeviceControl; + + /* Let Ks handle these */ + KsSetMajorFunctionHandler(DriverObject, IRP_MJ_CREATE); + KsSetMajorFunctionHandler(DriverObject, IRP_MJ_CLOSE); + + return STATUS_SUCCESS; +} + +/* + *@implemented + */ + +VOID +NTAPI +StreamClassReenumerateStreams( + IN PVOID HwDeviceExtension, + IN ULONG StreamDescriptorSize) +{ + HW_STREAM_REQUEST_BLOCK_EXT RequestBlock; + PSTREAM_DEVICE_EXTENSION DeviceExtension; + PHW_STREAM_DESCRIPTOR StreamDescriptor; + + if (!HwDeviceExtension || !StreamDescriptorSize) + return; + + StreamDescriptor = ExAllocatePool(NonPagedPool, StreamDescriptorSize); + if (!StreamDescriptor) + return; + + /* Zero stream descriptor */ + RtlZeroMemory(StreamDescriptor, StreamDescriptorSize); + + /* Get our DeviceExtension */ + DeviceExtension = (PSTREAM_DEVICE_EXTENSION) ((ULONG_PTR)HwDeviceExtension - sizeof(STREAM_DEVICE_EXTENSION)); + ASSERT(DeviceExtension->DeviceExtension == HwDeviceExtension); + + + /* Zero RequestBlock */ + RtlZeroMemory(&RequestBlock, sizeof(HW_STREAM_REQUEST_BLOCK_EXT)); + + /* Setup get stream info struct */ + RequestBlock.Block.SizeOfThisPacket = sizeof(HW_STREAM_REQUEST_BLOCK); + RequestBlock.Block.Command = SRB_GET_STREAM_INFO; + RequestBlock.Block.CommandData.StreamBuffer = StreamDescriptor; + KeInitializeEvent(&RequestBlock.Event, SynchronizationEvent, FALSE); + + /* FIXME SYNCHRONIZATION */ + + /* Send the request */ + DeviceExtension->DriverExtension->Data.HwReceivePacket ((PHW_STREAM_REQUEST_BLOCK)&RequestBlock); + + /* Is the device already completed? */ + if (RequestBlock.Block.Status == STATUS_PENDING) + { + /* Request is pending, wait for result */ + KeWaitForSingleObject(&RequestBlock.Event, Executive, KernelMode, FALSE, NULL); + } + + if (!NT_SUCCESS(RequestBlock.Block.Status)) + { + /* Release Stream descriptor */ + ExFreePool(StreamDescriptor); + } + else + { + if (DeviceExtension->StreamDescriptor) + { + /* Release old stream descriptor */ + ExFreePool(DeviceExtension->StreamDescriptor); + } + + /* Store stream descriptor */ + DeviceExtension->StreamDescriptor = StreamDescriptor; + DeviceExtension->StreamDescriptorSize = StreamDescriptorSize; + } + +} + +/* + *@implemented + */ + +VOID +NTAPI +StreamClassDebugAssert( + IN PCHAR File, + IN ULONG Line, + IN PCHAR AssertText, + IN ULONG AssertValue) +{ +#ifdef DBG + DbgBreakPoint(); +#endif +} + +/* + *@implemented + */ +VOID +__cdecl +StreamClassDebugPrint( + IN STREAM_DEBUG_LEVEL DebugPrintLevel, + IN PCCHAR DebugMessage, + ...) +{ +#ifdef DBG + va_list ap; + + if (DebugPrintLevel <=STREAMDEBUG_LEVEL) + { + va_start(ap, DebugMessage); + + DbgPrint(DebugMessage, ap); + + va_end(ap); + } +#endif + +} + +/* + *@unimplemented + */ +VOID +__cdecl +StreamClassDeviceNotification( + IN STREAM_MINIDRIVER_DEVICE_NOTIFICATION_TYPE NotificationType, + IN PVOID HwDeviceExtension, + IN PHW_STREAM_REQUEST_BLOCK pSrb, + IN PKSEVENT_ENTRY EventEntry, + IN GUID *EventSet, + IN ULONG EventId) +{ + PHW_STREAM_REQUEST_BLOCK_EXT RequestBlock; + if (NotificationType == DeviceRequestComplete) + { + RequestBlock = (PHW_STREAM_REQUEST_BLOCK_EXT)pSrb; + + KeSetEvent(&RequestBlock->Event, 0, FALSE); + return; + } + + UNIMPLEMENTED +} + +/* + *@implemented + */ +PVOID +STREAMAPI +StreamClassGetDmaBuffer( + IN PVOID HwDeviceExtension) +{ + PSTREAM_DEVICE_EXTENSION DeviceExtension; + /* Get our DeviceExtension */ + DeviceExtension = (PSTREAM_DEVICE_EXTENSION) ((ULONG_PTR)HwDeviceExtension - sizeof(STREAM_DEVICE_EXTENSION)); + ASSERT(DeviceExtension->DeviceExtension == HwDeviceExtension); + + return DeviceExtension->DmaCommonBuffer; +} + Propchange: trunk/reactos/drivers/wdm/audio/legacy/stream/driver.c ------------------------------------------------------------------------------ svn:eol-style = native Added: trunk/reactos/drivers/wdm/audio/legacy/stream/filter.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/wdm/audio/legacy/s… ============================================================================== --- trunk/reactos/drivers/wdm/audio/legacy/stream/filter.c (added) +++ trunk/reactos/drivers/wdm/audio/legacy/stream/filter.c [iso-8859-1] Sun Jun 28 17:58:47 2009 @@ -1,0 +1,194 @@ +/* + * COPYRIGHT: See COPYING in the top level directory + * PROJECT: ReactOS Kernel Streaming + * FILE: drivers/wdm/audio/legacy/stream/filter.c + * PURPOSE: filter instance handling + * PROGRAMMER: Johannes Anderwald + */ + + +#include "stream.h" + +NTSTATUS +NTAPI +FilterDispatch_fnDeviceIoControl( + PDEVICE_OBJECT DeviceObject, + PIRP Irp) +{ + DPRINT1("FilterDispatch Called\n"); + + Irp->IoStatus.Status = STATUS_SUCCESS; + Irp->IoStatus.Information = 0; + IoCompleteRequest(Irp, IO_NO_INCREMENT); + return STATUS_SUCCESS; +} + + +NTSTATUS +NTAPI +FilterDispatch_fnClose( + PDEVICE_OBJECT DeviceObject, + PIRP Irp) +{ + NTSTATUS Status = STATUS_SUCCESS; + PSTREAM_DEVICE_EXTENSION DeviceExtension; + HW_STREAM_REQUEST_BLOCK_EXT RequestBlock; + + /* Get device extension */ + DeviceExtension = (PSTREAM_DEVICE_EXTENSION)DeviceObject->DeviceExtension; + + if (!DeviceExtension->DriverExtension->Data.FilterInstanceExtensionSize) + { + /* driver supports only one instance */ + if (DeviceExtension->InstanceCount) + { + /* there is already one instance open */ + return STATUS_UNSUCCESSFUL; + } + } + else + { + /* driver supports more than one filter instance */ + RtlZeroMemory(&RequestBlock, sizeof(HW_STREAM_REQUEST_BLOCK_EXT)); + + /* set up request block */ + RequestBlock.Block.Command = SRB_CLOSE_DEVICE_INSTANCE; + RequestBlock.Block.HwDeviceExtension = DeviceExtension->DeviceExtension; + RequestBlock.Block.Irp = Irp; + KeInitializeEvent(&RequestBlock.Event, SynchronizationEvent, FALSE); + + /*FIXME SYNCHRONIZATION */ + + /* Send the request */ + DeviceExtension->DriverExtension->Data.HwReceivePacket((PHW_STREAM_REQUEST_BLOCK)&RequestBlock); + if (RequestBlock.Block.Status == STATUS_PENDING) + { + /* Wait for the request */ + KeWaitForSingleObject(&RequestBlock.Event, Executive, KernelMode, FALSE, NULL); + } + } + + /* Increment total instance count */ + InterlockedDecrement(&DeviceExtension->InstanceCount); + + Irp->IoStatus.Status = Status; + Irp->IoStatus.Information = 0; + IoCompleteRequest(Irp, IO_NO_INCREMENT); + return Status; +} + +static KSDISPATCH_TABLE DispatchTable = +{ + FilterDispatch_fnDeviceIoControl, + KsDispatchInvalidDeviceRequest, + KsDispatchInvalidDeviceRequest, + KsDispatchInvalidDeviceRequest, + FilterDispatch_fnClose, + NULL, + NULL, + NULL, + NULL, + NULL +}; + +NTSTATUS +InitializeFilterWithKs( + IN PDEVICE_OBJECT DeviceObject, + IN PIRP Irp) +{ + NTSTATUS Status; + PSTREAM_DEVICE_EXTENSION DeviceExtension; + KSOBJECT_HEADER ObjectHeader; + PKSOBJECT_CREATE_ITEM CreateItem; + PIO_STACK_LOCATION IoStack; + HW_STREAM_REQUEST_BLOCK_EXT RequestBlock; + + /* Get device extension */ + DeviceExtension = (PSTREAM_DEVICE_EXTENSION)DeviceObject->DeviceExtension; + + if (!DeviceExtension->DriverExtension->Data.FilterInstanceExtensionSize) + { + /* driver supports only one instance */ + if (DeviceExtension->InstanceCount) + { + /* there is already one instance open */ + return STATUS_UNSUCCESSFUL; + } + } + else + { + /* driver supports more than one filter instance */ + RtlZeroMemory(&RequestBlock, sizeof(HW_STREAM_REQUEST_BLOCK_EXT)); + + /* set up request block */ + RequestBlock.Block.Command = SRB_OPEN_DEVICE_INSTANCE; + RequestBlock.Block.HwDeviceExtension = DeviceExtension->DeviceExtension; + RequestBlock.Block.Irp = Irp; + KeInitializeEvent(&RequestBlock.Event, SynchronizationEvent, FALSE); + + /*FIXME SYNCHRONIZATION */ + + /* Send the request */ + DeviceExtension->DriverExtension->Data.HwReceivePacket((PHW_STREAM_REQUEST_BLOCK)&RequestBlock); + if (RequestBlock.Block.Status == STATUS_PENDING) + { + /* Wait for the request */ + KeWaitForSingleObject(&RequestBlock.Event, Executive, KernelMode, FALSE, NULL); + } + /* Check for success */ + if (!NT_SUCCESS(RequestBlock.Block.Status)) + { + /* Resource is not available */ + return RequestBlock.Block.Status; + } + } + + /* Allocate create item */ + CreateItem = ExAllocatePool(NonPagedPool, sizeof(KSOBJECT_CREATE_ITEM)); + if (!CreateItem) + { + /* not enough memory */ + return STATUS_INSUFFICIENT_RESOURCES; + } + /* Zero create item */ + RtlZeroMemory(CreateItem, sizeof(KSOBJECT_CREATE_ITEM)); + /* Set item class */ + RtlInitUnicodeString(&CreateItem->ObjectClass, L"STREAMCLASS"); + /* Get current irp stack location */ + IoStack = IoGetCurrentIrpStackLocation(Irp); + /* Create Ks streaming object header */ + Status = KsAllocateObjectHeader(&ObjectHeader, 1, CreateItem, Irp, &DispatchTable); + if (!NT_SUCCESS(Status)) + { + /* Failed to create header */ + ExFreePool(CreateItem); + return Status; + } + /* Increment total instance count */ + InterlockedIncrement(&DeviceExtension->InstanceCount); + /* Return result */ + return Status; + +} + +NTSTATUS +NTAPI +StreamClassCreateFilter( + IN PDEVICE_OBJECT DeviceObject, + IN PIRP Irp) +{ + NTSTATUS Status; + DPRINT1("StreamClassCreateFilter Called\n"); + + /* FIXME Support Pins/Clocks */ + /* Init filter */ + Status = InitializeFilterWithKs(DeviceObject, Irp); + + Irp->IoStatus.Status = Status; + Irp->IoStatus.Information = 0; + IoCompleteRequest(Irp, IO_NO_INCREMENT); + return Status; +} + + + Propchange: trunk/reactos/drivers/wdm/audio/legacy/stream/filter.c ------------------------------------------------------------------------------ svn:eol-style = native Added: trunk/reactos/drivers/wdm/audio/legacy/stream/helper.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/wdm/audio/legacy/s… ============================================================================== --- trunk/reactos/drivers/wdm/audio/legacy/stream/helper.c (added) +++ trunk/reactos/drivers/wdm/audio/legacy/stream/helper.c [iso-8859-1] Sun Jun 28 17:58:47 2009 @@ -1,0 +1,56 @@ +/* + * COPYRIGHT: See COPYING in the top level directory + * PROJECT: ReactOS Kernel Streaming + * FILE: drivers/wdm/audio/legacy/stream/helper.c + * PURPOSE: irp helper routines + * PROGRAMMER: Johannes Anderwald + */ + + +#include "stream.h" + +NTSTATUS +NTAPI +CompletionRoutine( + IN PDEVICE_OBJECT DeviceObject, + IN PIRP Irp, + IN PVOID Context) +{ + if (Irp->PendingReturned == TRUE) + { + KeSetEvent ((PKEVENT) Context, IO_NO_INCREMENT, FALSE); + } + return STATUS_MORE_PROCESSING_REQUIRED; +} + + +NTSTATUS +NTAPI +ForwardIrpSynchronous( + IN PDEVICE_OBJECT DeviceObject, + IN PIRP Irp) +{ + KEVENT Event; + PSTREAM_DEVICE_EXTENSION DeviceExt; + NTSTATUS Status; + + DeviceExt = (PSTREAM_DEVICE_EXTENSION)DeviceObject->DeviceExtension; + + /* initialize the notification event */ + KeInitializeEvent(&Event, NotificationEvent, FALSE); + + IoCopyCurrentIrpStackLocationToNext(Irp); + + IoSetCompletionRoutine(Irp, CompletionRoutine, (PVOID)&Event, TRUE, TRUE, TRUE); + + /* now call the driver */ + Status = IoCallDriver(DeviceExt->LowerDeviceObject, Irp); + /* did the request complete yet */ + if (Status == STATUS_PENDING) + { + /* not yet, lets wait a bit */ + KeWaitForSingleObject(&Event, Executive, KernelMode, FALSE, NULL); + Status = Irp->IoStatus.Status; + } + return Status; +} Propchange: trunk/reactos/drivers/wdm/audio/legacy/stream/helper.c ------------------------------------------------------------------------------ svn:eol-style = native Added: trunk/reactos/drivers/wdm/audio/legacy/stream/pnp.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/wdm/audio/legacy/s… ============================================================================== --- trunk/reactos/drivers/wdm/audio/legacy/stream/pnp.c (added) +++ trunk/reactos/drivers/wdm/audio/legacy/stream/pnp.c [iso-8859-1] Sun Jun 28 17:58:47 2009 @@ -1,0 +1,465 @@ +/* + * COPYRIGHT: See COPYING in the top level directory + * PROJECT: ReactOS Kernel Streaming + * FILE: drivers/wdm/audio/legacy/stream/pnp.c + * PURPOSE: pnp handling + * PROGRAMMER: Johannes Anderwald + */ + +#include "stream.h" + +VOID +CompleteIrp( + IN PIRP Irp, + IN NTSTATUS Status, + IN ULONG_PTR Information) +{ + Irp->IoStatus.Status = Status; + Irp->IoStatus.Information = Information; + IoCompleteRequest(Irp, IO_NO_INCREMENT); +} + +VOID +NTAPI +StreamClassReleaseResources( + IN PDEVICE_OBJECT DeviceObject) +{ + PSTREAM_DEVICE_EXTENSION DeviceExtension; + PLIST_ENTRY Entry; + PMEMORY_RESOURCE_LIST Mem; + + /* Get device extension */ + DeviceExtension = (PSTREAM_DEVICE_EXTENSION)DeviceObject->DeviceExtension; + + /* Disconnect interrupt */ + if (DeviceExtension->Interrupt) + { + IoDisconnectInterrupt(DeviceExtension->Interrupt); + DeviceExtension->Interrupt = NULL; + } + + /* Release DmaAdapter */ + if (DeviceExtension->DmaAdapter) + { + DeviceExtension->DmaAdapter->DmaOperations->PutDmaAdapter(DeviceExtension->DmaAdapter); + DeviceExtension->DmaAdapter = NULL; + } + + /* Release mem mapped I/O */ + while(!IsListEmpty(&DeviceExtension->MemoryResourceList)) + { + Entry = RemoveHeadList(&DeviceExtension->MemoryResourceList); + Mem = (PMEMORY_RESOURCE_LIST)CONTAINING_RECORD(Entry, MEMORY_RESOURCE_LIST, Entry); + + MmUnmapIoSpace(Mem->Start, Mem->Length); + ExFreePool(Entry); + } +} + +BOOLEAN +NTAPI +StreamClassSynchronize( + IN PKINTERRUPT Interrupt, + IN PKSYNCHRONIZE_ROUTINE SynchronizeRoutine, + IN PVOID SynchronizeContext) +{ + /* This function is used when the driver either implements synchronization on its own + * or if there is no interrupt assigned + */ + return SynchronizeRoutine(SynchronizeContext); +} + +VOID +NTAPI +StreamClassInterruptDpc( + IN PKDPC Dpc, + IN PVOID DeferredContext, + IN PVOID SystemArgument1, + IN PVOID SystemArgument2) +{ + //TODO + //read/write data +} + + +BOOLEAN +NTAPI +StreamClassInterruptRoutine( + IN PKINTERRUPT Interrupt, + IN PVOID ServiceContext) +{ + BOOLEAN Ret = FALSE; + PSTREAM_DEVICE_EXTENSION DeviceExtension = (PSTREAM_DEVICE_EXTENSION)ServiceContext; + + /* Does the driver implement HwInterrupt routine */ + if (DeviceExtension->DriverExtension->Data.HwInterrupt) + { + /* Check if the interrupt was coming from this device */ + Ret = DeviceExtension->DriverExtension->Data.HwInterrupt(DeviceExtension->DeviceExtension); + if (Ret) + { + /* Interrupt has from this device, schedule a Dpc for us */ + KeInsertQueueDpc(&DeviceExtension->InterruptDpc, NULL, NULL); + } + } + /* Return result */ + return Ret; +} + + + +NTSTATUS +NTAPI +StreamClassStartDevice( + IN PDEVICE_OBJECT DeviceObject, + IN PIRP Irp) +{ + PHW_STREAM_REQUEST_BLOCK_EXT RequestBlock; + PPORT_CONFIGURATION_INFORMATION Config; + PSTREAM_DEVICE_EXTENSION DeviceExtension; + PIO_STACK_LOCATION IoStack; + PCM_RESOURCE_LIST List; + PCM_PARTIAL_RESOURCE_DESCRIPTOR Descriptor; + PSTREAM_CLASS_DRIVER_EXTENSION DriverObjectExtension; + PDMA_ADAPTER Adapter; + DEVICE_DESCRIPTION DeviceDesc; + NTSTATUS Status = STATUS_SUCCESS; + ULONG ResultLength, Index; + BOOLEAN bUseDMA, bUseInterrupt; + ULONG MapRegisters; + KAFFINITY Affinity = 0; + PHW_STREAM_DESCRIPTOR StreamDescriptor; + PACCESS_RANGE Range; + PVOID MappedAddr; + PMEMORY_RESOURCE_LIST Mem; + + /* Get current stack location */ + IoStack = IoGetCurrentIrpStackLocation(Irp); + + /* Get resource list */ + List = IoStack->Parameters.StartDevice.AllocatedResourcesTranslated; + /* Calculate request length */ + ResultLength = sizeof(HW_STREAM_REQUEST_BLOCK_EXT) + sizeof(PPORT_CONFIGURATION_INFORMATION) + List->List[0].PartialResourceList.Count * sizeof(ACCESS_RANGE); + + /* Allocate Request Block */ + RequestBlock = ExAllocatePool(NonPagedPool, ResultLength); + + if (!RequestBlock) + { + /* Not enough memory */ + CompleteIrp(Irp, STATUS_INSUFFICIENT_RESOURCES, 0); + return STATUS_INSUFFICIENT_RESOURCES; + } + + /* Get device extension */ + DeviceExtension = (PSTREAM_DEVICE_EXTENSION)DeviceObject->DeviceExtension; + + /* Get driver object extension */ + DriverObjectExtension = IoGetDriverObjectExtension(DeviceObject->DriverObject, (PVOID)StreamClassAddDevice); + + /* Zero request block */ + RtlZeroMemory(RequestBlock, ResultLength); + + /* Locate Config struct */ + Config = (PPORT_CONFIGURATION_INFORMATION) (RequestBlock + 1); + Range = (PACCESS_RANGE) (Config + 1); + + /* Initialize Request */ + RequestBlock->Block.SizeOfThisPacket = sizeof(HW_STREAM_REQUEST_BLOCK); + RequestBlock->Block.Command = SRB_INITIALIZE_DEVICE; + RequestBlock->Block.CommandData.ConfigInfo = Config; + KeInitializeEvent(&RequestBlock->Event, SynchronizationEvent, FALSE); + + Config->SizeOfThisPacket = sizeof(PPORT_CONFIGURATION_INFORMATION); + Config->HwDeviceExtension = (PVOID) (DeviceExtension + 1); + Config->ClassDeviceObject = DeviceObject; + Config->PhysicalDeviceObject = DeviceExtension->LowerDeviceObject; + Config->RealPhysicalDeviceObject = DeviceExtension->PhysicalDeviceObject; + Config->AccessRanges = Range; + + IoGetDeviceProperty(DeviceObject, DevicePropertyBusNumber, sizeof(ULONG), (PVOID)&Config->SystemIoBusNumber, &ResultLength); + IoGetDeviceProperty(DeviceObject, DevicePropertyLegacyBusType, sizeof(INTERFACE_TYPE), (PVOID)&Config->AdapterInterfaceType, &ResultLength); + + /* Get resource list */ + List = IoStack->Parameters.StartDevice.AllocatedResourcesTranslated; + + /* Scan the translated resources */ + bUseDMA = FALSE; + bUseInterrupt = FALSE; + + Range = (PACCESS_RANGE) (Config + 1); + + for(Index = 0; Index < List->List[0].PartialResourceList.Count; Index++) + { + /* Locate partial descriptor */ + Descriptor = &List->List[0].PartialResourceList.PartialDescriptors[Index]; + + switch(Descriptor->Type) + { + case CmResourceTypePort: + { + /* Store resource information in AccessRange struct */ + Range[Config->NumberOfAccessRanges].RangeLength = Descriptor->u.Port.Length; + Range[Config->NumberOfAccessRanges].RangeStart.QuadPart = Descriptor->u.Port.Start.QuadPart; + Range[Config->NumberOfAccessRanges].RangeInMemory = FALSE; + Config->NumberOfAccessRanges++; + break; + } + case CmResourceTypeInterrupt: + { + /* Store resource information */ + Config->BusInterruptLevel = Descriptor->u.Interrupt.Level; + Config->BusInterruptVector = Descriptor->u.Interrupt.Vector; + Config->InterruptMode = Descriptor->Flags; + Affinity = Descriptor->u.Interrupt.Affinity; + bUseInterrupt = TRUE; + break; + } + case CmResourceTypeMemory: + { + Mem = ExAllocatePool(NonPagedPool, sizeof(MEMORY_RESOURCE_LIST)); + MappedAddr = MmMapIoSpace(Descriptor->u.Memory.Start, Descriptor->u.Memory.Length, MmNonCached); + if (!MappedAddr || !Mem) + { + if (Mem) + { + /* Release Memory resource descriptor */ + ExFreePool(Mem); + } + + if (MappedAddr) + { + /* Release mem mapped I/O */ + MmUnmapIoSpace(MappedAddr, Descriptor->u.Memory.Length); + } + + /* Release resources */ + StreamClassReleaseResources(DeviceObject); + /* Complete irp */ + CompleteIrp(Irp, STATUS_INSUFFICIENT_RESOURCES, 0); + ExFreePool(RequestBlock); + return STATUS_INSUFFICIENT_RESOURCES; + } + /* Store range for driver */ + Range[Config->NumberOfAccessRanges].RangeLength = Descriptor->u.Memory.Length; + Range[Config->NumberOfAccessRanges].RangeStart.QuadPart = Descriptor->u.Memory.Start.QuadPart; + Range[Config->NumberOfAccessRanges].RangeInMemory = TRUE; + Config->NumberOfAccessRanges++; + /* Initialize Memory resource descriptor */ + Mem->Length = Descriptor->u.Memory.Length; + Mem->Start = MappedAddr; + InsertTailList(&DeviceExtension->MemoryResourceList, &Mem->Entry); + break; + } + case CmResourceTypeDma: + { + bUseDMA = TRUE; + Config->DmaChannel = Descriptor->u.Dma.Channel; + break; + } + } + } + + if (!!bUseInterrupt || DriverObjectExtension->Data.HwInterrupt == NULL || Config->BusInterruptLevel == 0 || Config->BusInterruptVector == 0) + { + /* requirements not satisfied */ + DeviceExtension->SynchronizeFunction = StreamClassSynchronize; + } + else + { + /* use real sync routine */ + DeviceExtension->SynchronizeFunction = KeSynchronizeExecution; + + /* connect interrupt */ + Status = IoConnectInterrupt(&DeviceExtension->Interrupt, + StreamClassInterruptRoutine, + (PVOID)DeviceExtension, + NULL, + Config->BusInterruptVector, + Config->BusInterruptLevel, + Config->BusInterruptLevel, + Config->InterruptMode, + TRUE, + Affinity, + FALSE); + if (!NT_SUCCESS(Status)) + { + /* Release resources */ + StreamClassReleaseResources(DeviceObject); + /* Failed to connect interrupt */ + CompleteIrp(Irp, Status, 0); + /* Release request block */ + ExFreePool(RequestBlock); + return Status; + } + + /* store interrupt object */ + Config->InterruptObject = DeviceExtension->Interrupt; + } + + /* does the device use DMA */ + if (bUseDMA && DriverObjectExtension->Data.BusMasterDMA) + { + /* Zero device description */ + RtlZeroMemory(&DeviceDesc, sizeof(DEVICE_DESCRIPTION)); + + DeviceDesc.Version = DEVICE_DESCRIPTION_VERSION; + DeviceDesc.Master = TRUE; + DeviceDesc.ScatterGather = TRUE; + DeviceDesc.AutoInitialize = FALSE; + DeviceDesc.DmaChannel = Config->DmaChannel; + DeviceDesc.InterfaceType = Config->AdapterInterfaceType; + DeviceDesc.DmaWidth = Width32Bits; + DeviceDesc.DmaSpeed = Compatible; + DeviceDesc.MaximumLength = (ULONG)-1; + DeviceDesc.Dma32BitAddresses = DriverObjectExtension->Data.Dma24BitAddresses; + + Adapter = IoGetDmaAdapter(DeviceExtension->PhysicalDeviceObject, &DeviceDesc, &MapRegisters); + if (!Adapter) + { + /* Failed to claim DMA Adapter */ + CompleteIrp(Irp, Status, 0); + /* Release resources */ + StreamClassReleaseResources(DeviceObject); + /* Release request block */ + ExFreePool(RequestBlock); + return Status; + } + + if (DeviceExtension->DriverExtension->Data.DmaBufferSize) + { + DeviceExtension->DmaCommonBuffer = Adapter->DmaOperations->AllocateCommonBuffer(Adapter, DeviceExtension->DriverExtension->Data.DmaBufferSize, &DeviceExtension->DmaPhysicalAddress, FALSE); + if (!DeviceExtension->DmaCommonBuffer) + { + /* Failed to allocate a common buffer */ + CompleteIrp(Irp, Status, 0); + /* Release resources */ + StreamClassReleaseResources(DeviceObject); + /* Release request block */ + ExFreePool(RequestBlock); + return Status; + } + } + + + DeviceExtension->MapRegisters = MapRegisters; + DeviceExtension->DmaAdapter = Adapter; + Config->DmaAdapterObject = (PADAPTER_OBJECT)Adapter; + } + + + /* First forward the request to lower attached device object */ + Status = ForwardIrpSynchronous(DeviceObject, Irp); + if (!NT_SUCCESS(Status)) + { + /* Failed to start lower devices */ + CompleteIrp(Irp, Status, 0); + /* Release resources */ + StreamClassReleaseResources(DeviceObject); + /* Release request block */ + ExFreePool(RequestBlock); + return Status; + } + + Config->Irp = Irp; + + /* FIXME SYNCHRONIZATION */ + + /* Send the request */ + DriverObjectExtension->Data.HwReceivePacket((PHW_STREAM_REQUEST_BLOCK)RequestBlock); + if (RequestBlock->Block.Status == STATUS_PENDING) + { + /* Request is pending, wait for result */ + KeWaitForSingleObject(&RequestBlock->Event, Executive, KernelMode, FALSE, NULL); + /* Get final status code */ + Status = RequestBlock->Block.Status; + } + + /* Copy stream descriptor size */ + DeviceExtension->StreamDescriptorSize = Config->StreamDescriptorSize; + + /* check if the request has succeeded or if stream size is valid*/ + if (!NT_SUCCESS(Status)|| !Config->StreamDescriptorSize) + { + /* Failed to start device */ + CompleteIrp(Irp, Status, 0); + /* Release resources */ + StreamClassReleaseResources(DeviceObject); + /* Release request block */ + ExFreePool(RequestBlock); + return Status; + } + + /* Allocate a stream Descriptor */ + StreamDescriptor = ExAllocatePool(NonPagedPool, DeviceExtension->StreamDescriptorSize); + if (!StreamDescriptor) + { + /* Not enough memory */ + CompleteIrp(Irp, STATUS_INSUFFICIENT_RESOURCES, 0); + /* Release resources */ + StreamClassReleaseResources(DeviceObject); + /* Release request block */ + ExFreePool(RequestBlock); + return STATUS_INSUFFICIENT_RESOURCES; + } + + /* Zero stream descriptor */ + RtlZeroMemory(StreamDescriptor, DeviceExtension->StreamDescriptorSize); + + /* Setup get stream info struct */ + RequestBlock->Block.Command = SRB_GET_STREAM_INFO; + RequestBlock->Block.CommandData.StreamBuffer = StreamDescriptor; + KeResetEvent(&RequestBlock->Event); + + /* send the request */ + DriverObjectExtension->Data.HwReceivePacket((PHW_STREAM_REQUEST_BLOCK)RequestBlock); + if (RequestBlock->Block.Status == STATUS_PENDING) + { + /* Request is pending, wait for result */ + KeWaitForSingleObject(&RequestBlock->Event, Executive, KernelMode, FALSE, NULL); + /* Get final status code */ + Status = RequestBlock->Block.Status; + } + + if (NT_SUCCESS(Status)) + { + /* store stream descriptor */ + DeviceExtension->StreamDescriptor = StreamDescriptor; + } + else + { + /* cleanup resources */ + ExFreePool(StreamDescriptor); + } + + ExFreePool(RequestBlock); + /* Complete Irp */ + CompleteIrp(Irp, Status, 0); + /* Return result */ + return Status; +} + +NTSTATUS +NTAPI +StreamClassPnp( + IN PDEVICE_OBJECT DeviceObject, + IN PIRP Irp) +{ + PIO_STACK_LOCATION IoStack; + + /* Get current irp stack location */ + IoStack = IoGetCurrentIrpStackLocation(Irp); + + switch (IoStack->MinorFunction) + { + case IRP_MN_START_DEVICE: + { + return StreamClassStartDevice(DeviceObject, Irp); + } + } + + IoCompleteRequest(Irp, IO_NO_INCREMENT); + return STATUS_NOT_SUPPORTED; +} + + Propchange: trunk/reactos/drivers/wdm/audio/legacy/stream/pnp.c ------------------------------------------------------------------------------ svn:eol-style = native Added: trunk/reactos/drivers/wdm/audio/legacy/stream/stream.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/wdm/audio/legacy/s… ============================================================================== --- trunk/reactos/drivers/wdm/audio/legacy/stream/stream.h (added) +++ trunk/reactos/drivers/wdm/audio/legacy/stream/stream.h [iso-8859-1] Sun Jun 28 17:58:47 2009 @@ -1,0 +1,140 @@ +#ifndef STREAM_H__ +#define STREAM_H__ + +#include <strmini.h> +#define YDEBUG +#include <debug.h> + +#define STREAMDEBUG_LEVEL DebugLevelMaximum + +typedef BOOLEAN (NTAPI *SYNCHRONIZE_FUNC) (IN PKINTERRUPT Interrupt, IN PKSYNCHRONIZE_ROUTINE SynchronizeRoutine, IN PVOID SynchronizeContext); + +typedef struct +{ + HW_INITIALIZATION_DATA Data; + +}STREAM_CLASS_DRIVER_EXTENSION, *PSTREAM_CLASS_DRIVER_EXTENSION; + +typedef struct +{ + LIST_ENTRY Entry; + PVOID Start; + ULONG Length; +}MEMORY_RESOURCE_LIST, *PMEMORY_RESOURCE_LIST; + +typedef struct +{ + KSDEVICE_HEADER Header; + PDEVICE_OBJECT LowerDeviceObject; + PDEVICE_OBJECT PhysicalDeviceObject; + + SYNCHRONIZE_FUNC SynchronizeFunction; + + ULONG MapRegisters; + PDMA_ADAPTER DmaAdapter; + PVOID DmaCommonBuffer; + PHYSICAL_ADDRESS DmaPhysicalAddress; + + PKINTERRUPT Interrupt; + KDPC InterruptDpc; + + LIST_ENTRY MemoryResourceList; + + ULONG StreamDescriptorSize; + PHW_STREAM_DESCRIPTOR StreamDescriptor; + PSTREAM_CLASS_DRIVER_EXTENSION DriverExtension; + + PVOID DeviceExtension; + LONG InstanceCount; + +}STREAM_DEVICE_EXTENSION, *PSTREAM_DEVICE_EXTENSION; + +typedef struct +{ + HW_STREAM_REQUEST_BLOCK Block; + KEVENT Event; +}HW_STREAM_REQUEST_BLOCK_EXT, *PHW_STREAM_REQUEST_BLOCK_EXT; + +NTSTATUS +NTAPI +StreamClassCreateFilter( + IN PDEVICE_OBJECT DeviceObject, + IN PIRP Irp); + +NTSTATUS +NTAPI +StreamClassPnp( + IN PDEVICE_OBJECT DeviceObject, + IN PIRP Irp); + +NTSTATUS +NTAPI +StreamClassPower( + IN PDEVICE_OBJECT DeviceObject, + IN PIRP Irp); + +NTSTATUS +NTAPI +StreamClassSystemControl( + IN PDEVICE_OBJECT DeviceObject, + IN PIRP Irp); + +NTSTATUS +NTAPI +StreamClassCleanup( + IN PDEVICE_OBJECT DeviceObject, + IN PIRP Irp); + +NTSTATUS +NTAPI +StreamClassFlushBuffers( + IN PDEVICE_OBJECT DeviceObject, + IN PIRP Irp); + +NTSTATUS +NTAPI +StreamClassDeviceControl( + IN PDEVICE_OBJECT DeviceObject, + IN PIRP Irp); + +NTSTATUS +NTAPI +StreamClassAddDevice( + IN PDRIVER_OBJECT DriverObject, + IN PDEVICE_OBJECT PhysicalDeviceObject); + + +NTSTATUS +NTAPI +ForwardIrpSynchronous( + IN PDEVICE_OBJECT DeviceObject, + IN PIRP Irp); + +BOOLEAN +NTAPI +StreamClassSynchronize( + IN PKINTERRUPT Interrupt, + IN PKSYNCHRONIZE_ROUTINE SynchronizeRoutine, + IN PVOID SynchronizeContext); + +BOOLEAN +NTAPI +StreamClassInterruptRoutine( + IN PKINTERRUPT Interrupt, + IN PVOID ServiceContext); + +VOID +NTAPI +StreamClassInterruptDpc( + IN PKDPC Dpc, + IN PVOID DeferredContext, + IN PVOID SystemArgument1, + IN PVOID SystemArgument2); + +VOID +CompleteIrp( + IN PIRP Irp, + IN NTSTATUS Status, + IN ULONG_PTR Information); + +#endif Propchange: trunk/reactos/drivers/wdm/audio/legacy/stream/stream.h ------------------------------------------------------------------------------ svn:eol-style = native Added: trunk/reactos/drivers/wdm/audio/legacy/stream/stream.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/wdm/audio/legacy/s… ============================================================================== --- trunk/reactos/drivers/wdm/audio/legacy/stream/stream.rbuild (added) +++ trunk/reactos/drivers/wdm/audio/legacy/stream/stream.rbuild [iso-8859-1] Sun Jun 28 17:58:47 2009 @@ -1,0 +1,17 @@ +<?xml version="1.0"?> +<!DOCTYPE module SYSTEM "../../../../../tools/rbuild/project.dtd"> +<module name="stream" type="kernelmodedriver" installbase="system32/drivers" installname="stream.sys" entrypoint="0"> + <include base="stream">.</include> + <define name="_COMDDK_" /> + <importlibrary definition="stream.spec" /> + <library>ntoskrnl</library> + <library>ks</library> + <library>pseh</library> + <file>control.c</file> + <file>driver.c</file> + <file>dll.c</file> + <file>filter.c</file> + <file>helper.c</file> + <file>pnp.c</file> + <file>stream.rc</file> +</module> Propchange: trunk/reactos/drivers/wdm/audio/legacy/stream/stream.rbuild ------------------------------------------------------------------------------ svn:eol-style = native Added: trunk/reactos/drivers/wdm/audio/legacy/stream/stream.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/wdm/audio/legacy/s… ============================================================================== --- trunk/reactos/drivers/wdm/audio/legacy/stream/stream.rc (added) +++ trunk/reactos/drivers/wdm/audio/legacy/stream/stream.rc [iso-8859-1] Sun Jun 28 17:58:47 2009 @@ -1,0 +1,5 @@ +#define REACTOS_VERSION_DLL +#define REACTOS_STR_FILE_DESCRIPTION "WDM CODEC Class Device Driver 2.0\0" +#define REACTOS_STR_INTERNAL_NAME "stream.sys\0" +#define REACTOS_STR_ORIGINAL_FILENAME "stream.sys\0" +#include <reactos/version.rc> Propchange: trunk/reactos/drivers/wdm/audio/legacy/stream/stream.rc ------------------------------------------------------------------------------ svn:eol-style = native Added: trunk/reactos/drivers/wdm/audio/legacy/stream/stream.spec URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/wdm/audio/legacy/s… ============================================================================== --- trunk/reactos/drivers/wdm/audio/legacy/stream/stream.spec (added) +++ trunk/reactos/drivers/wdm/audio/legacy/stream/stream.spec [iso-8859-1] Sun Jun 28 17:58:47 2009 @@ -1,0 +1,8 @@ +@ stdcall DllInitialize(long) +@ stdcall DllUnload() +@ stdcall StreamClassRegisterAdapter(ptr ptr ptr) +@ stdcall StreamClassReenumerateStreams(ptr long) +@ stdcall StreamClassDebugAssert(long long ptr long) +@ cdecl StreamClassDebugPrint (long str) +@ cdecl StreamClassDeviceNotification(long ptr) +@ stdcall StreamClassGetDmaBuffer(ptr) Propchange: trunk/reactos/drivers/wdm/audio/legacy/stream/stream.spec ------------------------------------------------------------------------------ svn:eol-style = native

1 0

[cwittich] 41661: fix formatting
by cwittich＠svn.reactos.org 28 Jun '09

28 Jun '09

Author: cwittich Date: Sun Jun 28 17:52:27 2009 New Revision: 41661 URL: http://svn.reactos.org/svn/reactos?rev=41661&view=rev Log: fix formatting Modified: trunk/reactos/lib/sdk/crt/stdio/popen.c Modified: trunk/reactos/lib/sdk/crt/stdio/popen.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/sdk/crt/stdio/popen.c?… ============================================================================== --- trunk/reactos/lib/sdk/crt/stdio/popen.c [iso-8859-1] (original) +++ trunk/reactos/lib/sdk/crt/stdio/popen.c [iso-8859-1] Sun Jun 28 17:52:27 2009 @@ -1,20 +1,20 @@ /* - * COPYRIGHT: See COPYING in the top level directory - * PROJECT: ReactOS system libraries - * FILE: lib/crt/?????? - * PURPOSE: Unknown - * PROGRAMER: Unknown - * UPDATE HISTORY: - * 25/11/05: Created - */ +* COPYRIGHT: See COPYING in the top level directory +* PROJECT: ReactOS system libraries +* FILE: lib/crt/?????? +* PURPOSE: Unknown +* PROGRAMER: Unknown +* UPDATE HISTORY: +* 25/11/05: Created +*/ #include <precomp.h> #include <tchar.h> #ifdef _UNICODE - #define sT "S" +#define sT "S" #else - #define sT "s" +#define sT "s" #endif #define MK_STR(s) #s @@ -27,104 +27,102 @@ */ FILE *_tpopen (const _TCHAR *cm, const _TCHAR *md) /* program name, pipe mode */ { - _TCHAR *szCmdLine=NULL; - _TCHAR *szComSpec=NULL; - _TCHAR *s; - FILE *pf; - HANDLE hReadPipe, hWritePipe; - BOOL result; - STARTUPINFO StartupInfo; - PROCESS_INFORMATION ProcessInformation; - SECURITY_ATTRIBUTES sa = {sizeof(SECURITY_ATTRIBUTES), NULL, TRUE}; + _TCHAR *szCmdLine=NULL; + _TCHAR *szComSpec=NULL; + _TCHAR *s; + FILE *pf; + HANDLE hReadPipe, hWritePipe; + BOOL result; + STARTUPINFO StartupInfo; + PROCESS_INFORMATION ProcessInformation; + SECURITY_ATTRIBUTES sa = {sizeof(SECURITY_ATTRIBUTES), NULL, TRUE}; - TRACE(MK_STR(_tpopen)"('%"sT"', '%"sT"')\n", cm, md); + TRACE(MK_STR(_tpopen)"('%"sT"', '%"sT"')\n", cm, md); - if (cm == NULL) - return( NULL ); + if (cm == NULL) + return( NULL ); - szComSpec = _tgetenv(_T("COMSPEC")); - if (szComSpec == NULL) - { - szComSpec = _T("cmd.exe"); - } - - s = max(_tcsrchr(szComSpec, '\\'), _tcsrchr(szComSpec, '/')); - if (s == NULL) - s = szComSpec; - else - s++; - - szCmdLine = malloc((_tcslen(s) + 4 + _tcslen(cm) + 1) * sizeof(_TCHAR)); - if (szCmdLine == NULL) - { - return NULL; - } - - _tcscpy(szCmdLine, s); - s = _tcsrchr(szCmdLine, '.'); - if (s) - *s = 0; - _tcscat(szCmdLine, _T(" /C ")); - _tcscat(szCmdLine, cm); - - if ( !CreatePipe(&hReadPipe,&hWritePipe,&sa,1024)) - { - free (szCmdLine); - return NULL; - } - - memset(&StartupInfo, 0, sizeof(STARTUPINFO)); - StartupInfo.cb = sizeof(STARTUPINFO); - - if (*md == 'r' ) { - StartupInfo.hStdInput = GetStdHandle(STD_INPUT_HANDLE); - StartupInfo.hStdOutput = hWritePipe; - StartupInfo.dwFlags |= STARTF_USESTDHANDLES; - } - else if ( *md == 'w' ) { - StartupInfo.hStdInput = hReadPipe; - StartupInfo.hStdOutput = GetStdHandle(STD_OUTPUT_HANDLE); - StartupInfo.dwFlags |= STARTF_USESTDHANDLES; - } - - if (StartupInfo.dwFlags & STARTF_USESTDHANDLES) - StartupInfo.hStdError = GetStdHandle(STD_ERROR_HANDLE); - - result = CreateProcess(szComSpec, - szCmdLine, - NULL, - NULL, - TRUE, - 0, - NULL, - NULL, - &StartupInfo, - &ProcessInformation); - free (szCmdLine); - - if (result == FALSE) - { - CloseHandle(hReadPipe); - CloseHandle(hWritePipe); - return NULL; - } - - CloseHandle(ProcessInformation.hThread); - - if ( *md == 'r' ) + szComSpec = _tgetenv(_T("COMSPEC")); + if (szComSpec == NULL) { - pf = _tfdopen(alloc_fd(hReadPipe, split_oflags(_fmode)) , _T("r")); - CloseHandle(hWritePipe); - } - else - { - pf = _tfdopen( alloc_fd(hWritePipe, split_oflags(_fmode)) , _T("w")); - CloseHandle(hReadPipe); + szComSpec = _T("cmd.exe"); } - //pf->_tmpfname = ProcessInformation.hProcess; + s = max(_tcsrchr(szComSpec, '\\'), _tcsrchr(szComSpec, '/')); + if (s == NULL) + s = szComSpec; + else + s++; - return( pf ); + szCmdLine = malloc((_tcslen(s) + 4 + _tcslen(cm) + 1) * sizeof(_TCHAR)); + if (szCmdLine == NULL) + { + return NULL; + } + + _tcscpy(szCmdLine, s); + s = _tcsrchr(szCmdLine, '.'); + if (s) + *s = 0; + _tcscat(szCmdLine, _T(" /C ")); + _tcscat(szCmdLine, cm); + + if ( !CreatePipe(&hReadPipe,&hWritePipe,&sa,1024)) + { + free (szCmdLine); + return NULL; + } + + memset(&StartupInfo, 0, sizeof(STARTUPINFO)); + StartupInfo.cb = sizeof(STARTUPINFO); + + if (*md == 'r' ) { + StartupInfo.hStdInput = GetStdHandle(STD_INPUT_HANDLE); + StartupInfo.hStdOutput = hWritePipe; + StartupInfo.dwFlags |= STARTF_USESTDHANDLES; + } + else if ( *md == 'w' ) { + StartupInfo.hStdInput = hReadPipe; + StartupInfo.hStdOutput = GetStdHandle(STD_OUTPUT_HANDLE); + StartupInfo.dwFlags |= STARTF_USESTDHANDLES; + } + + if (StartupInfo.dwFlags & STARTF_USESTDHANDLES) + StartupInfo.hStdError = GetStdHandle(STD_ERROR_HANDLE); + + result = CreateProcess(szComSpec, + szCmdLine, + NULL, + NULL, + TRUE, + 0, + NULL, + NULL, + &StartupInfo, + &ProcessInformation); + free (szCmdLine); + + if (result == FALSE) + { + CloseHandle(hReadPipe); + CloseHandle(hWritePipe); + return NULL; + } + + CloseHandle(ProcessInformation.hThread); + + if ( *md == 'r' ) + { + pf = _tfdopen(alloc_fd(hReadPipe, split_oflags(_fmode)) , _T("r")); + CloseHandle(hWritePipe); + } + else + { + pf = _tfdopen( alloc_fd(hWritePipe, split_oflags(_fmode)) , _T("w")); + CloseHandle(hReadPipe); + } + + return( pf ); } #ifndef _UNICODE @@ -134,12 +132,12 @@ */ int _pclose (FILE *pp) { - TRACE("_pclose(%x)",pp); + TRACE("_pclose(%x)",pp); - fclose(pp); - //if (!TerminateProcess(pp->_tmpfname ,0)) - // return( -1 ); - return( 0 ); + fclose(pp); + //if (!TerminateProcess(pp->_tmpfname ,0)) + // return( -1 ); + return( 0 ); } #endif

1 0

[dchapyshev] 41660: - Change icon for msiexec to Tango icon
by dchapyshev＠svn.reactos.org 28 Jun '09

28 Jun '09

Author: dchapyshev Date: Sun Jun 28 13:21:47 2009 New Revision: 41660 URL: http://svn.reactos.org/svn/reactos?rev=41660&view=rev Log: - Change icon for msiexec to Tango icon Modified: trunk/reactos/base/system/msiexec/msiexec.ico Modified: trunk/reactos/base/system/msiexec/msiexec.ico URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/system/msiexec/msiexe… ============================================================================== Binary files - no diff available.

1 0

[ros-arm-bringup] 41659: - Create mmsup.c in ReactOS memory manager directory. It hosts misc support functions: - Copy kmap.c here, since it's the very definition of "misc support function" - Copy some exported functions in mm.c which were listed as "misc functions" - Warn that current implementation of MmIsNonPagedSystemAddressValid will kill kittens. - Rename mm.c to mmfault.c, since other than the misc functions now in mmsup.c, it was all routines to handle page/access faults. - Warn that MmI
by ros-arm-bringup＠svn.reactos.org 28 Jun '09

28 Jun '09

Author: ros-arm-bringup Date: Sun Jun 28 11:52:30 2009 New Revision: 41659 URL: http://svn.reactos.org/svn/reactos?rev=41659&view=rev Log: - Create mmsup.c in ReactOS memory manager directory. It hosts misc support functions: - Copy kmap.c here, since it's the very definition of "misc support function" - Copy some exported functions in mm.c which were listed as "misc functions" - Warn that current implementation of MmIsNonPagedSystemAddressValid will kill kittens. - Rename mm.c to mmfault.c, since other than the misc functions now in mmsup.c, it was all routines to handle page/access faults. - Warn that MmIsAddressValid, as currently implemented, kills puppies. - Move WriteWatch functions to virtual.c since they're part of the Virtual API system call set already hosted there. - Move the global variables that people had been throwing in here to mminit.c, which is slightly more appropriate. - Move wset.c's MmTrimUserMemory to balance.c, since that's where all other similar functions are located. - Incidentally, kill wset.c, as this was the only function present. - No functional changes, just refactoring and cleanup (other than warning the critter murder the two broken functions will achieve if called). Added: trunk/reactos/ntoskrnl/mm/mmfault.c - copied, changed from r41647, trunk/reactos/ntoskrnl/mm/mm.c trunk/reactos/ntoskrnl/mm/mmsup.c (with props) Removed: trunk/reactos/ntoskrnl/mm/kmap.c trunk/reactos/ntoskrnl/mm/mm.c trunk/reactos/ntoskrnl/mm/wset.c Modified: trunk/reactos/ntoskrnl/mm/balance.c trunk/reactos/ntoskrnl/mm/mminit.c trunk/reactos/ntoskrnl/mm/virtual.c trunk/reactos/ntoskrnl/ntoskrnl-generic.rbuild Modified: trunk/reactos/ntoskrnl/mm/balance.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/balance.c?rev=… ============================================================================== --- trunk/reactos/ntoskrnl/mm/balance.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/mm/balance.c [iso-8859-1] Sun Jun 28 11:52:30 2009 @@ -161,6 +161,38 @@ { MiMemoryConsumers[Consumer].Trim(Target, 0, &NrFreedPages); } +} + +NTSTATUS +MmTrimUserMemory(ULONG Target, ULONG Priority, PULONG NrFreedPages) +{ + PFN_TYPE CurrentPage; + PFN_TYPE NextPage; + NTSTATUS Status; + + (*NrFreedPages) = 0; + + CurrentPage = MmGetLRUFirstUserPage(); + while (CurrentPage != 0 && Target > 0) + { + NextPage = MmGetLRUNextUserPage(CurrentPage); + + Status = MmPageOutPhysicalAddress(CurrentPage); + if (NT_SUCCESS(Status)) + { + DPRINT("Succeeded\n"); + Target--; + (*NrFreedPages)++; + } + else if (Status == STATUS_PAGEFILE_QUOTA) + { + MmRemoveLRUUserPage(CurrentPage); + MmInsertLRULastUserPage(CurrentPage); + } + + CurrentPage = NextPage; + } + return(STATUS_SUCCESS); } VOID Removed: trunk/reactos/ntoskrnl/mm/kmap.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/kmap.c?rev=416… ============================================================================== --- trunk/reactos/ntoskrnl/mm/kmap.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/mm/kmap.c (removed) @@ -1,58 +1,0 @@ -/* - * COPYRIGHT: See COPYING in the top level directory - * PROJECT: ReactOS kernel - * FILE: ntoskrnl/mm/kmap.c - * PURPOSE: Implements the kernel memory pool - * - * PROGRAMMERS: David Welch (welch(a)cwcom.net) - */ - -/* INCLUDES ****************************************************************/ - -#include <ntoskrnl.h> -#define NDEBUG -#include <debug.h> - -/* GLOBALS *****************************************************************/ - -/* FUNCTIONS ***************************************************************/ - -NTSTATUS -NTAPI -MiZeroPage(PFN_TYPE Page) -{ - KIRQL Irql; - PVOID TempAddress; - - Irql = KeRaiseIrqlToDpcLevel(); - TempAddress = MiMapPageToZeroInHyperSpace(Page); - if (TempAddress == NULL) - { - return(STATUS_NO_MEMORY); - } - memset(TempAddress, 0, PAGE_SIZE); - MiUnmapPagesInZeroSpace(TempAddress, 1); - KeLowerIrql(Irql); - return(STATUS_SUCCESS); -} - -NTSTATUS -NTAPI -MiCopyFromUserPage(PFN_TYPE DestPage, PVOID SourceAddress) -{ - PEPROCESS Process; - KIRQL Irql; - PVOID TempAddress; - - Process = PsGetCurrentProcess(); - TempAddress = MiMapPageInHyperSpace(Process, DestPage, &Irql); - if (TempAddress == NULL) - { - return(STATUS_NO_MEMORY); - } - memcpy(TempAddress, SourceAddress, PAGE_SIZE); - MiUnmapPageInHyperSpace(Process, TempAddress, Irql); - return(STATUS_SUCCESS); -} - -/* EOF */ Removed: trunk/reactos/ntoskrnl/mm/mm.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/mm.c?rev=41658… ============================================================================== --- trunk/reactos/ntoskrnl/mm/mm.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/mm/mm.c (removed) @@ -1,491 +1,0 @@ -/* - * COPYRIGHT: See COPYING in the top directory - * PROJECT: ReactOS kernel - * FILE: ntoskrnl/mm/mm.c - * PURPOSE: Kernel memory managment functions - * PROGRAMMERS: David Welch (welch(a)cwcom.net) - */ - -/* INCLUDES *****************************************************************/ - -#include <ntoskrnl.h> -#define NDEBUG -#include <debug.h> - -/* GLOBALS *****************************************************************/ - -ULONG MmUserProbeAddress = 0; -PVOID MmHighestUserAddress = NULL; -PBOOLEAN Mm64BitPhysicalAddress = FALSE; -PVOID MmSystemRangeStart = NULL; -ULONG MmReadClusterSize; - -MM_STATS MmStats; - -PMMSUPPORT MmKernelAddressSpace; - -/* FUNCTIONS ****************************************************************/ - -VOID -FASTCALL -MiSyncForProcessAttach(IN PKTHREAD Thread, - IN PEPROCESS Process) -{ - PETHREAD Ethread = CONTAINING_RECORD(Thread, ETHREAD, Tcb); - - /* Hack Sync because Mm is broken */ - MmUpdatePageDir(Process, Ethread, sizeof(ETHREAD)); - MmUpdatePageDir(Process, Ethread->ThreadsProcess, sizeof(EPROCESS)); - MmUpdatePageDir(Process, - (PVOID)Thread->StackLimit, - Thread->LargeStack ? - KERNEL_LARGE_STACK_SIZE : KERNEL_STACK_SIZE); -} - -VOID -FASTCALL -MiSyncForContextSwitch(IN PKTHREAD Thread) -{ - PVOID Process = PsGetCurrentProcess(); - PETHREAD Ethread = CONTAINING_RECORD(Thread, ETHREAD, Tcb); - - /* Hack Sync because Mm is broken */ - MmUpdatePageDir(Process, Ethread->ThreadsProcess, sizeof(EPROCESS)); - MmUpdatePageDir(Process, - (PVOID)Thread->StackLimit, - Thread->LargeStack ? - KERNEL_LARGE_STACK_SIZE : KERNEL_STACK_SIZE); -} - -/* - * @implemented - */ -BOOLEAN NTAPI MmIsNonPagedSystemAddressValid(PVOID VirtualAddress) -{ - return MmIsAddressValid(VirtualAddress); -} - -/* - * @implemented - */ -BOOLEAN NTAPI MmIsAddressValid(PVOID VirtualAddress) -/* - * FUNCTION: Checks whether the given address is valid for a read or write - * ARGUMENTS: - * VirtualAddress = address to check - * RETURNS: True if the access would be valid - * False if the access would cause a page fault - * NOTES: This function checks whether a byte access to the page would - * succeed. Is this realistic for RISC processors which don't - * allow byte granular access? - */ -{ - MEMORY_AREA* MemoryArea; - PMMSUPPORT AddressSpace; - - if (VirtualAddress >= MmSystemRangeStart) - { - AddressSpace = MmGetKernelAddressSpace(); - } - else - { - AddressSpace = &PsGetCurrentProcess()->Vm; - } - - MmLockAddressSpace(AddressSpace); - MemoryArea = MmLocateMemoryAreaByAddress(AddressSpace, - VirtualAddress); - - if (MemoryArea == NULL || MemoryArea->DeleteInProgress) - { - MmUnlockAddressSpace(AddressSpace); - return(FALSE); - } - MmUnlockAddressSpace(AddressSpace); - return(TRUE); -} - -NTSTATUS -NTAPI -MmpAccessFault(KPROCESSOR_MODE Mode, - ULONG_PTR Address, - BOOLEAN FromMdl) -{ - PMMSUPPORT AddressSpace; - MEMORY_AREA* MemoryArea; - NTSTATUS Status; - BOOLEAN Locked = FromMdl; - - DPRINT("MmAccessFault(Mode %d, Address %x)\n", Mode, Address); - - if (KeGetCurrentIrql() >= DISPATCH_LEVEL) - { - DPRINT1("Page fault at high IRQL was %d\n", KeGetCurrentIrql()); - return(STATUS_UNSUCCESSFUL); - } - if (PsGetCurrentProcess() == NULL) - { - DPRINT("No current process\n"); - return(STATUS_UNSUCCESSFUL); - } - - /* - * Find the memory area for the faulting address - */ - if (Address >= (ULONG_PTR)MmSystemRangeStart) - { - /* - * Check permissions - */ - if (Mode != KernelMode) - { - DPRINT1("MmAccessFault(Mode %d, Address %x)\n", Mode, Address); - return(STATUS_ACCESS_VIOLATION); - } - AddressSpace = MmGetKernelAddressSpace(); - } - else - { - AddressSpace = &PsGetCurrentProcess()->Vm; - } - - if (!FromMdl) - { - MmLockAddressSpace(AddressSpace); - } - do - { - MemoryArea = MmLocateMemoryAreaByAddress(AddressSpace, (PVOID)Address); - if (MemoryArea == NULL || MemoryArea->DeleteInProgress) - { - if (!FromMdl) - { - MmUnlockAddressSpace(AddressSpace); - } - return (STATUS_ACCESS_VIOLATION); - } - - switch (MemoryArea->Type) - { - case MEMORY_AREA_SYSTEM: - Status = STATUS_ACCESS_VIOLATION; - break; - - case MEMORY_AREA_PAGED_POOL: - Status = STATUS_SUCCESS; - break; - - case MEMORY_AREA_SECTION_VIEW: - Status = MmAccessFaultSectionView(AddressSpace, - MemoryArea, - (PVOID)Address, - Locked); - break; - - case MEMORY_AREA_VIRTUAL_MEMORY: - Status = STATUS_ACCESS_VIOLATION; - break; - - case MEMORY_AREA_SHARED_DATA: - Status = STATUS_ACCESS_VIOLATION; - break; - - default: - Status = STATUS_ACCESS_VIOLATION; - break; - } - } - while (Status == STATUS_MM_RESTART_OPERATION); - - DPRINT("Completed page fault handling\n"); - if (!FromMdl) - { - MmUnlockAddressSpace(AddressSpace); - } - return(Status); -} - -NTSTATUS -NTAPI -MmNotPresentFault(KPROCESSOR_MODE Mode, - ULONG_PTR Address, - BOOLEAN FromMdl) -{ - PMMSUPPORT AddressSpace; - MEMORY_AREA* MemoryArea; - NTSTATUS Status; - BOOLEAN Locked = FromMdl; - PFN_TYPE Pfn; - - DPRINT("MmNotPresentFault(Mode %d, Address %x)\n", Mode, Address); - - if (KeGetCurrentIrql() >= DISPATCH_LEVEL) - { - DPRINT1("Page fault at high IRQL was %d, address %x\n", KeGetCurrentIrql(), Address); - return(STATUS_UNSUCCESSFUL); - } - - /* - * Find the memory area for the faulting address - */ - if (Address >= (ULONG_PTR)MmSystemRangeStart) - { - /* - * Check permissions - */ - if (Mode != KernelMode) - { - DPRINT1("Address: %x\n", Address); - return(STATUS_ACCESS_VIOLATION); - } - AddressSpace = MmGetKernelAddressSpace(); - } - else - { - AddressSpace = &PsGetCurrentProcess()->Vm; - } - - if (!FromMdl) - { - MmLockAddressSpace(AddressSpace); - } - - /* - * Call the memory area specific fault handler - */ - do - { - MemoryArea = MmLocateMemoryAreaByAddress(AddressSpace, (PVOID)Address); - if (MemoryArea == NULL || MemoryArea->DeleteInProgress) - { - if (!FromMdl) - { - MmUnlockAddressSpace(AddressSpace); - } - return (STATUS_ACCESS_VIOLATION); - } - - switch (MemoryArea->Type) - { - case MEMORY_AREA_PAGED_POOL: - { - Status = MmCommitPagedPoolAddress((PVOID)Address, Locked); - break; - } - - case MEMORY_AREA_SYSTEM: - Status = STATUS_ACCESS_VIOLATION; - break; - - case MEMORY_AREA_SECTION_VIEW: - Status = MmNotPresentFaultSectionView(AddressSpace, - MemoryArea, - (PVOID)Address, - Locked); - break; - - case MEMORY_AREA_VIRTUAL_MEMORY: - case MEMORY_AREA_PEB_OR_TEB: - Status = MmNotPresentFaultVirtualMemory(AddressSpace, - MemoryArea, - (PVOID)Address, - Locked); - break; - - case MEMORY_AREA_SHARED_DATA: - Pfn = MmGetPhysicalAddress((PVOID)PCR).LowPart >> PAGE_SHIFT; - Pfn++; - Status = - MmCreateVirtualMapping(PsGetCurrentProcess(), - (PVOID)PAGE_ROUND_DOWN(Address), - PAGE_READONLY, - &Pfn, - 1); - break; - - default: - Status = STATUS_ACCESS_VIOLATION; - break; - } - } - while (Status == STATUS_MM_RESTART_OPERATION); - - DPRINT("Completed page fault handling\n"); - if (!FromMdl) - { - MmUnlockAddressSpace(AddressSpace); - } - return(Status); -} - -extern BOOLEAN Mmi386MakeKernelPageTableGlobal(PVOID Address); - -NTSTATUS -NTAPI -MmAccessFault(IN BOOLEAN StoreInstruction, - IN PVOID Address, - IN KPROCESSOR_MODE Mode, - IN PVOID TrapInformation) -{ - /* Cute little hack for ROS */ - if ((ULONG_PTR)Address >= (ULONG_PTR)MmSystemRangeStart) - { -#ifdef _M_IX86 - /* Check for an invalid page directory in kernel mode */ - if (Mmi386MakeKernelPageTableGlobal(Address)) - { - /* All is well with the world */ - return STATUS_SUCCESS; - } -#endif - } - - /* Keep same old ReactOS Behaviour */ - if (StoreInstruction) - { - /* Call access fault */ - return MmpAccessFault(Mode, (ULONG_PTR)Address, TrapInformation ? FALSE : TRUE); - } - else - { - /* Call not present */ - return MmNotPresentFault(Mode, (ULONG_PTR)Address, TrapInformation ? FALSE : TRUE); - } -} - -NTSTATUS -NTAPI -MmCommitPagedPoolAddress(PVOID Address, BOOLEAN Locked) -{ - NTSTATUS Status; - PFN_TYPE AllocatedPage; - Status = MmRequestPageMemoryConsumer(MC_PPOOL, FALSE, &AllocatedPage); - if (!NT_SUCCESS(Status)) - { - MmUnlockAddressSpace(MmGetKernelAddressSpace()); - Status = MmRequestPageMemoryConsumer(MC_PPOOL, TRUE, &AllocatedPage); - MmLockAddressSpace(MmGetKernelAddressSpace()); - } - Status = - MmCreateVirtualMapping(NULL, - (PVOID)PAGE_ROUND_DOWN(Address), - PAGE_READWRITE, - &AllocatedPage, - 1); - if (Locked) - { - MmLockPage(AllocatedPage); - } - return(Status); -} - - - -/* Miscellanea functions: they may fit somewhere else */ - -/* - * @implemented - */ -BOOLEAN -NTAPI -MmIsRecursiveIoFault (VOID) -{ - PETHREAD Thread = PsGetCurrentThread(); - - return (Thread->DisablePageFaultClustering | Thread->ForwardClusterOnly); -} - -/* - * @unimplemented - */ -NTSTATUS -NTAPI -MmMapUserAddressesToPage(IN PVOID BaseAddress, - IN SIZE_T NumberOfBytes, - IN PVOID PageAddress) -{ - UNIMPLEMENTED; - return STATUS_NOT_IMPLEMENTED; -} - -/* - * @unimplemented - */ -ULONG NTAPI -MmAdjustWorkingSetSize (ULONG Unknown0, - ULONG Unknown1, - ULONG Unknown2, - ULONG Unknown3) -{ - UNIMPLEMENTED; - return (0); -} - -/* - * @unimplemented - */ -BOOLEAN -NTAPI -MmSetAddressRangeModified ( - IN PVOID Address, - IN ULONG Length -) -{ - UNIMPLEMENTED; - return (FALSE); -} - -/* - * @unimplemented - */ -NTSTATUS -NTAPI -NtGetWriteWatch(IN HANDLE ProcessHandle, - IN ULONG Flags, - IN PVOID BaseAddress, - IN ULONG RegionSize, - IN PVOID *UserAddressArray, - OUT PULONG EntriesInUserAddressArray, - OUT PULONG Granularity) -{ - if (!EntriesInUserAddressArray || !Granularity) - { - return STATUS_ACCESS_VIOLATION; - } - - if (!*EntriesInUserAddressArray || !RegionSize) - { - return STATUS_INVALID_PARAMETER; - } - - if (!UserAddressArray) - { - return STATUS_ACCESS_VIOLATION; - } - - /* HACK: Set granularity to PAGE_SIZE */ - *Granularity = PAGE_SIZE; - - UNIMPLEMENTED; - return STATUS_NOT_IMPLEMENTED; -} - -/* - * @unimplemented - */ -NTSTATUS -NTAPI -NtResetWriteWatch(IN HANDLE ProcessHandle, - IN PVOID BaseAddress, - IN ULONG RegionSize) -{ - if (!RegionSize) - { - return STATUS_INVALID_PARAMETER; - } - - UNIMPLEMENTED; - return STATUS_NOT_IMPLEMENTED; -} - -/* EOF */ Copied: trunk/reactos/ntoskrnl/mm/mmfault.c (from r41647, trunk/reactos/ntoskrnl/mm/mm.c) URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/mmfault.c?p2=t… ============================================================================== --- trunk/reactos/ntoskrnl/mm/mm.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/mm/mmfault.c [iso-8859-1] Sun Jun 28 11:52:30 2009 @@ -1,30 +1,18 @@ /* * COPYRIGHT: See COPYING in the top directory * PROJECT: ReactOS kernel - * FILE: ntoskrnl/mm/mm.c + * FILE: ntoskrnl/mm/mmfault.c * PURPOSE: Kernel memory managment functions * PROGRAMMERS: David Welch (welch(a)cwcom.net) */ -/* INCLUDES *****************************************************************/ +/* INCLUDES *******************************************************************/ #include <ntoskrnl.h> #define NDEBUG #include <debug.h> -/* GLOBALS *****************************************************************/ - -ULONG MmUserProbeAddress = 0; -PVOID MmHighestUserAddress = NULL; -PBOOLEAN Mm64BitPhysicalAddress = FALSE; -PVOID MmSystemRangeStart = NULL; -ULONG MmReadClusterSize; - -MM_STATS MmStats; - -PMMSUPPORT MmKernelAddressSpace; - -/* FUNCTIONS ****************************************************************/ +/* PRIVATE FUNCTIONS **********************************************************/ VOID FASTCALL @@ -55,54 +43,6 @@ (PVOID)Thread->StackLimit, Thread->LargeStack ? KERNEL_LARGE_STACK_SIZE : KERNEL_STACK_SIZE); -} - -/* - * @implemented - */ -BOOLEAN NTAPI MmIsNonPagedSystemAddressValid(PVOID VirtualAddress) -{ - return MmIsAddressValid(VirtualAddress); -} - -/* - * @implemented - */ -BOOLEAN NTAPI MmIsAddressValid(PVOID VirtualAddress) -/* - * FUNCTION: Checks whether the given address is valid for a read or write - * ARGUMENTS: - * VirtualAddress = address to check - * RETURNS: True if the access would be valid - * False if the access would cause a page fault - * NOTES: This function checks whether a byte access to the page would - * succeed. Is this realistic for RISC processors which don't - * allow byte granular access? - */ -{ - MEMORY_AREA* MemoryArea; - PMMSUPPORT AddressSpace; - - if (VirtualAddress >= MmSystemRangeStart) - { - AddressSpace = MmGetKernelAddressSpace(); - } - else - { - AddressSpace = &PsGetCurrentProcess()->Vm; - } - - MmLockAddressSpace(AddressSpace); - MemoryArea = MmLocateMemoryAreaByAddress(AddressSpace, - VirtualAddress); - - if (MemoryArea == NULL || MemoryArea->DeleteInProgress) - { - MmUnlockAddressSpace(AddressSpace); - return(FALSE); - } - MmUnlockAddressSpace(AddressSpace); - return(TRUE); } NTSTATUS @@ -379,113 +319,40 @@ return(Status); } - - -/* Miscellanea functions: they may fit somewhere else */ +/* PUBLIC FUNCTIONS ***********************************************************/ /* * @implemented */ BOOLEAN NTAPI -MmIsRecursiveIoFault (VOID) -{ - PETHREAD Thread = PsGetCurrentThread(); - - return (Thread->DisablePageFaultClustering | Thread->ForwardClusterOnly); -} - -/* - * @unimplemented - */ -NTSTATUS -NTAPI -MmMapUserAddressesToPage(IN PVOID BaseAddress, - IN SIZE_T NumberOfBytes, - IN PVOID PageAddress) -{ - UNIMPLEMENTED; - return STATUS_NOT_IMPLEMENTED; -} - -/* - * @unimplemented - */ -ULONG NTAPI -MmAdjustWorkingSetSize (ULONG Unknown0, - ULONG Unknown1, - ULONG Unknown2, - ULONG Unknown3) -{ - UNIMPLEMENTED; - return (0); -} - -/* - * @unimplemented - */ -BOOLEAN -NTAPI -MmSetAddressRangeModified ( - IN PVOID Address, - IN ULONG Length -) -{ - UNIMPLEMENTED; - return (FALSE); -} - -/* - * @unimplemented - */ -NTSTATUS -NTAPI -NtGetWriteWatch(IN HANDLE ProcessHandle, - IN ULONG Flags, - IN PVOID BaseAddress, - IN ULONG RegionSize, - IN PVOID *UserAddressArray, - OUT PULONG EntriesInUserAddressArray, - OUT PULONG Granularity) -{ - if (!EntriesInUserAddressArray || !Granularity) - { - return STATUS_ACCESS_VIOLATION; - } - - if (!*EntriesInUserAddressArray || !RegionSize) - { - return STATUS_INVALID_PARAMETER; - } - - if (!UserAddressArray) - { - return STATUS_ACCESS_VIOLATION; - } - - /* HACK: Set granularity to PAGE_SIZE */ - *Granularity = PAGE_SIZE; - - UNIMPLEMENTED; - return STATUS_NOT_IMPLEMENTED; -} - -/* - * @unimplemented - */ -NTSTATUS -NTAPI -NtResetWriteWatch(IN HANDLE ProcessHandle, - IN PVOID BaseAddress, - IN ULONG RegionSize) -{ - if (!RegionSize) - { - return STATUS_INVALID_PARAMETER; - } - - UNIMPLEMENTED; - return STATUS_NOT_IMPLEMENTED; +MmIsAddressValid(IN PVOID VirtualAddress) +{ + MEMORY_AREA* MemoryArea; + PMMSUPPORT AddressSpace; + + DPRINT1("WARNING: %s returns bogus result\n", __FUNCTION__); + + if (VirtualAddress >= MmSystemRangeStart) + { + AddressSpace = MmGetKernelAddressSpace(); + } + else + { + AddressSpace = &PsGetCurrentProcess()->Vm; + } + + MmLockAddressSpace(AddressSpace); + MemoryArea = MmLocateMemoryAreaByAddress(AddressSpace, + VirtualAddress); + + if (MemoryArea == NULL || MemoryArea->DeleteInProgress) + { + MmUnlockAddressSpace(AddressSpace); + return(FALSE); + } + MmUnlockAddressSpace(AddressSpace); + return(TRUE); } /* EOF */ Modified: trunk/reactos/ntoskrnl/mm/mminit.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/mminit.c?rev=4… ============================================================================== --- trunk/reactos/ntoskrnl/mm/mminit.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/mm/mminit.c [iso-8859-1] Sun Jun 28 11:52:30 2009 @@ -55,6 +55,13 @@ ULONG_PTR MmPfnDatabaseEnd; PMEMORY_ALLOCATION_DESCRIPTOR MiFreeDescriptor; MEMORY_ALLOCATION_DESCRIPTOR MiFreeDescriptorOrg; +ULONG MmUserProbeAddress = 0; +PVOID MmHighestUserAddress = NULL; +PBOOLEAN Mm64BitPhysicalAddress = FALSE; +PVOID MmSystemRangeStart = NULL; +ULONG MmReadClusterSize; +MM_STATS MmStats; +PMMSUPPORT MmKernelAddressSpace; extern KMUTANT MmSystemLoadLock; extern HANDLE MpwThreadHandle; extern BOOLEAN MpwThreadShouldTerminate; Added: trunk/reactos/ntoskrnl/mm/mmsup.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/mmsup.c?rev=41… ============================================================================== --- trunk/reactos/ntoskrnl/mm/mmsup.c (added) +++ trunk/reactos/ntoskrnl/mm/mmsup.c [iso-8859-1] Sun Jun 28 11:52:30 2009 @@ -1,0 +1,120 @@ +/* + * COPYRIGHT: See COPYING in the top directory + * PROJECT: ReactOS kernel + * FILE: ntoskrnl/mm/mmsup.c + * PURPOSE: Kernel memory managment functions + * PROGRAMMERS: David Welch (welch(a)cwcom.net) + */ + +/* INCLUDES *******************************************************************/ + +#include <ntoskrnl.h> +#define NDEBUG +#include <debug.h> + +/* PRIVATE FUNCTIONS **********************************************************/ + +NTSTATUS +NTAPI +MiZeroPage(PFN_TYPE Page) +{ + KIRQL Irql; + PVOID TempAddress; + + Irql = KeRaiseIrqlToDpcLevel(); + TempAddress = MiMapPageToZeroInHyperSpace(Page); + if (TempAddress == NULL) + { + return(STATUS_NO_MEMORY); + } + memset(TempAddress, 0, PAGE_SIZE); + MiUnmapPagesInZeroSpace(TempAddress, 1); + KeLowerIrql(Irql); + return(STATUS_SUCCESS); +} + +NTSTATUS +NTAPI +MiCopyFromUserPage(PFN_TYPE DestPage, PVOID SourceAddress) +{ + PEPROCESS Process; + KIRQL Irql; + PVOID TempAddress; + + Process = PsGetCurrentProcess(); + TempAddress = MiMapPageInHyperSpace(Process, DestPage, &Irql); + if (TempAddress == NULL) + { + return(STATUS_NO_MEMORY); + } + memcpy(TempAddress, SourceAddress, PAGE_SIZE); + MiUnmapPageInHyperSpace(Process, TempAddress, Irql); + return(STATUS_SUCCESS); +} + +/* PRIVATE FUNCTIONS **********************************************************/ + +/* Miscellanea functions: they may fit somewhere else */ + +/* + * @implemented + */ +BOOLEAN +NTAPI +MmIsRecursiveIoFault (VOID) +{ + PETHREAD Thread = PsGetCurrentThread(); + + return (Thread->DisablePageFaultClustering | Thread->ForwardClusterOnly); +} + +/* + * @unimplemented + */ +NTSTATUS +NTAPI +MmMapUserAddressesToPage(IN PVOID BaseAddress, + IN SIZE_T NumberOfBytes, + IN PVOID PageAddress) +{ + UNIMPLEMENTED; + return STATUS_NOT_IMPLEMENTED; +} + +/* + * @unimplemented + */ +ULONG NTAPI +MmAdjustWorkingSetSize (ULONG Unknown0, + ULONG Unknown1, + ULONG Unknown2, + ULONG Unknown3) +{ + UNIMPLEMENTED; + return (0); +} + +/* + * @unimplemented + */ +BOOLEAN +NTAPI +MmSetAddressRangeModified ( + IN PVOID Address, + IN ULONG Length +) +{ + UNIMPLEMENTED; + return (FALSE); +} + +/* + * @implemented + */ +BOOLEAN NTAPI MmIsNonPagedSystemAddressValid(PVOID VirtualAddress) +{ + DPRINT1("WARNING: %s returns bogus result\n", __FUNCTION__); + return MmIsAddressValid(VirtualAddress); +} + +/* EOF */ Propchange: trunk/reactos/ntoskrnl/mm/mmsup.c ------------------------------------------------------------------------------ svn:eol-style = native Propchange: trunk/reactos/ntoskrnl/mm/mmsup.c ------------------------------------------------------------------------------ svn:mime-type = text/plain Modified: trunk/reactos/ntoskrnl/mm/virtual.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/virtual.c?rev=… ============================================================================== --- trunk/reactos/ntoskrnl/mm/virtual.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/mm/virtual.c [iso-8859-1] Sun Jun 28 11:52:30 2009 @@ -1151,4 +1151,57 @@ return STATUS_SUCCESS; } +/* + * @unimplemented + */ +NTSTATUS +NTAPI +NtGetWriteWatch(IN HANDLE ProcessHandle, + IN ULONG Flags, + IN PVOID BaseAddress, + IN ULONG RegionSize, + IN PVOID *UserAddressArray, + OUT PULONG EntriesInUserAddressArray, + OUT PULONG Granularity) +{ + if (!EntriesInUserAddressArray || !Granularity) + { + return STATUS_ACCESS_VIOLATION; + } + + if (!*EntriesInUserAddressArray || !RegionSize) + { + return STATUS_INVALID_PARAMETER; + } + + if (!UserAddressArray) + { + return STATUS_ACCESS_VIOLATION; + } + + /* HACK: Set granularity to PAGE_SIZE */ + *Granularity = PAGE_SIZE; + + UNIMPLEMENTED; + return STATUS_NOT_IMPLEMENTED; +} + +/* + * @unimplemented + */ +NTSTATUS +NTAPI +NtResetWriteWatch(IN HANDLE ProcessHandle, + IN PVOID BaseAddress, + IN ULONG RegionSize) +{ + if (!RegionSize) + { + return STATUS_INVALID_PARAMETER; + } + + UNIMPLEMENTED; + return STATUS_NOT_IMPLEMENTED; +} + /* EOF */ Removed: trunk/reactos/ntoskrnl/mm/wset.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/wset.c?rev=416… ============================================================================== --- trunk/reactos/ntoskrnl/mm/wset.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/mm/wset.c (removed) @@ -1,48 +1,0 @@ -/* - * COPYRIGHT: See COPYING in the top level directory - * PROJECT: ReactOS kernel - * FILE: ntoskrnl/mm/wset.c - * PURPOSE: Manages working sets - * - * PROGRAMMERS: David Welch (welch(a)cwcom.net) - */ - -/* INCLUDES *****************************************************************/ - -#include <ntoskrnl.h> -#define NDEBUG -#include <debug.h> - -/* FUNCTIONS *****************************************************************/ - -NTSTATUS -MmTrimUserMemory(ULONG Target, ULONG Priority, PULONG NrFreedPages) -{ - PFN_TYPE CurrentPage; - PFN_TYPE NextPage; - NTSTATUS Status; - - (*NrFreedPages) = 0; - - CurrentPage = MmGetLRUFirstUserPage(); - while (CurrentPage != 0 && Target > 0) - { - NextPage = MmGetLRUNextUserPage(CurrentPage); - - Status = MmPageOutPhysicalAddress(CurrentPage); - if (NT_SUCCESS(Status)) - { - DPRINT("Succeeded\n"); - Target--; - (*NrFreedPages)++; - } - else if (Status == STATUS_PAGEFILE_QUOTA) - { - MmRemoveLRUUserPage(CurrentPage); - MmInsertLRULastUserPage(CurrentPage); - } - - CurrentPage = NextPage; - } - return(STATUS_SUCCESS); -} Modified: trunk/reactos/ntoskrnl/ntoskrnl-generic.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ntoskrnl-generic.… ============================================================================== --- trunk/reactos/ntoskrnl/ntoskrnl-generic.rbuild [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/ntoskrnl-generic.rbuild [iso-8859-1] Sun Jun 28 11:52:30 2009 @@ -374,10 +374,10 @@ <file>balance.c</file> <file>dbgpool.c</file> <file>freelist.c</file> - <file>kmap.c</file> <file>marea.c</file> <file>mdlsup.c</file> - <file>mm.c</file> + <file>mmfault.c</file> + <file>mmsup.c</file> <file>mminit.c</file> <file>mpw.c</file> <file>ncache.c</file> @@ -393,7 +393,6 @@ <file>section.c</file> <file>sysldr.c</file> <file>virtual.c</file> - <file>wset.c</file> <if property="_ELF_" value="1"> <file>elf32.c</file> <file>elf64.c</file>

1 0

[ros-arm-bringup] 41658: - Move all the functions from drvlck.c and verifier.c to ARM3's drvmgmt.c: - "Managing driver managing" (by David Welch) is no more... the routines have been properly renamed and cleaned up. - Also moved Driver Verifier helper routines in here, and fixed a couple of bugs: - Do not allow hooking of the kernel or HAL image (tested on Windows Server 2003) - Cleanup some useless variable redefinitions and code complexity. - Documented what some of the Mm Lock/Unlock Pageable
by ros-arm-bringup＠svn.reactos.org 28 Jun '09

28 Jun '09

Author: ros-arm-bringup Date: Sun Jun 28 11:32:52 2009 New Revision: 41658 URL: http://svn.reactos.org/svn/reactos?rev=41658&view=rev Log: - Move all the functions from drvlck.c and verifier.c to ARM3's drvmgmt.c: - "Managing driver managing" (by David Welch) is no more... the routines have been properly renamed and cleaned up. - Also moved Driver Verifier helper routines in here, and fixed a couple of bugs: - Do not allow hooking of the kernel or HAL image (tested on Windows Server 2003) - Cleanup some useless variable redefinitions and code complexity. - Documented what some of the Mm Lock/Unlock Pageable Section/Driver functions should do, for later if needed. - Made aliasses so the typo "Pagable" functions redirect to the correct "Pageable" functions. - No functional change -- the Verifier functions were unused, and the drvlock.c functions were unimplemented (and still are). - Also move one more *Pageable* function from wset.c to ARM3's drvmgmt.c -- it seemed to have been a lost orphan (Also unimplemented). Added: trunk/reactos/ntoskrnl/mm/ARM3/drvmgmt.c - copied, changed from r41647, trunk/reactos/ntoskrnl/mm/drvlck.c Removed: trunk/reactos/ntoskrnl/mm/drvlck.c trunk/reactos/ntoskrnl/mm/verifier.c Modified: trunk/reactos/ntoskrnl/mm/ARM3/miarm.h trunk/reactos/ntoskrnl/mm/wset.c trunk/reactos/ntoskrnl/ntoskrnl-generic.rbuild trunk/reactos/ntoskrnl/ntoskrnl.pspec Copied: trunk/reactos/ntoskrnl/mm/ARM3/drvmgmt.c (from r41647, trunk/reactos/ntoskrnl/mm/drvlck.c) URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/ARM3/drvmgmt.c… ============================================================================== --- trunk/reactos/ntoskrnl/mm/drvlck.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/mm/ARM3/drvmgmt.c [iso-8859-1] Sun Jun 28 11:32:52 2009 @@ -1,102 +1,324 @@ /* - * COPYRIGHT: See COPYING in the top level directory - * PROJECT: ReactOS kernel - * FILE: ntoskrnl/mm/drvlck.c - * PURPOSE: Managing driver managing - * - * PROGRAMMERS: David Welch (welch(a)mcmail.com) - */ - -/* INCLUDES *****************************************************************/ + * PROJECT: ReactOS Kernel + * LICENSE: BSD - See COPYING.ARM in the top level directory + * FILE: ntoskrnl/mm/ARM3/drvmgmt.c + * PURPOSE: ARM Memory Manager Driver Management + * PROGRAMMERS: ReactOS Portable Systems Group + */ + +/* INCLUDES *******************************************************************/ #include <ntoskrnl.h> +#define NDEBUG #include <debug.h> -/* FUNCTIONS *****************************************************************/ - -#undef MmLockPagableDataSection - -#if 0 +#line 15 "ARMÂ³::DRVMGMT" +#define MODULE_INVOLVED_IN_ARM3 +#include "../ARM3/miarm.h" + +/* GLOBALS *******************************************************************/ + +MM_DRIVER_VERIFIER_DATA MmVerifierData; +LIST_ENTRY MiVerifierDriverAddedThunkListHead; +KMUTANT MmSystemLoadLock; +ULONG MiActiveVerifierThunks; +extern LIST_ENTRY PsLoadedModuleList; + +/* PRIVATE FUNCTIONS *********************************************************/ + +PLDR_DATA_TABLE_ENTRY +NTAPI +MiLookupDataTableEntry(IN PVOID Address) +{ + PLDR_DATA_TABLE_ENTRY LdrEntry, FoundEntry = NULL; + PLIST_ENTRY NextEntry; + PAGED_CODE(); + + // + // Loop entries + // + NextEntry = PsLoadedModuleList.Flink; + do + { + // + // Get the loader entry + // + LdrEntry = CONTAINING_RECORD(NextEntry, + LDR_DATA_TABLE_ENTRY, + InLoadOrderLinks); + + // + // Check if the address matches + // + if ((Address >= LdrEntry->DllBase) && + (Address < (PVOID)((ULONG_PTR)LdrEntry->DllBase + + LdrEntry->SizeOfImage))) + { + // + // Found a match + // + FoundEntry = LdrEntry; + break; + } + + // + // Move on + // + NextEntry = NextEntry->Flink; + } while(NextEntry != &PsLoadedModuleList); + + // + // Return the entry + // + return FoundEntry; +} + +/* PUBLIC FUNCTIONS ***********************************************************/ + +/* + * @unimplemented + */ VOID -MmUnlockPagableImageSection(IN PVOID ImageSectionHandle) -/* - * FUNCTION: Releases a section of driver code or driver data, previously - * locked into system space with MmLockPagableCodeSection, - * MmLockPagableDataSection or MmLockPagableSectionByHandle - * ARGUMENTS: - * ImageSectionHandle = Handle returned by MmLockPagableCodeSection or - * MmLockPagableDataSection - */ -{ - // MmUnlockMemoryArea((MEMORY_AREA *)ImageSectionHandle); - UNIMPLEMENTED; -} -#endif - - -/* - * @unimplemented - */ -VOID NTAPI -MmLockPagableSectionByHandle(IN PVOID ImageSectionHandle) -{ - UNIMPLEMENTED; -} - - -#if 0 +NTAPI +MmUnlockPageableImageSection(IN PVOID ImageSectionHandle) +{ + UNIMPLEMENTED; +} + +/* + * @unimplemented + */ +VOID +NTAPI +MmLockPageableSectionByHandle(IN PVOID ImageSectionHandle) +{ + UNIMPLEMENTED; +} + +/* + * @unimplemented + */ PVOID -MmLockPagableCodeSection(IN PVOID AddressWithinSection) -{ - PVOID Handle; - Handle = MmLocateMemoryAreaByAddress(NULL,AddressWithinSection); - MmLockPagableSectionByHandle(Handle); - return(Handle); -} -#endif - +NTAPI +MmLockPageableDataSection(IN PVOID AddressWithinSection) +{ + // + // We should just find the section and call MmLockPageableSectionByHandle + // + UNIMPLEMENTED; + return AddressWithinSection; +} + +/* + * @unimplemented + */ +PVOID +NTAPI +MmPageEntireDriver(IN PVOID AddressWithinSection) +{ + // + // We should find the driver loader entry and return its base address + // + UNIMPLEMENTED; + return NULL; +} + +/* + * @unimplemented + */ +VOID +NTAPI +MmResetDriverPaging(IN PVOID AddressWithinSection) +{ + UNIMPLEMENTED; +} + +/* + * @unimplemented + */ +ULONG +NTAPI +MmTrimAllSystemPageableMemory(IN ULONG PurgeTransitionList) +{ + UNIMPLEMENTED; + return 0; +} /* * @implemented */ -PVOID NTAPI -MmLockPagableDataSection(IN PVOID AddressWithinSection) -{ - PVOID Handle; - Handle = MmLocateMemoryAreaByAddress(MmGetKernelAddressSpace(), - AddressWithinSection); - MmLockPagableSectionByHandle(Handle); - return(Handle); -} - - -/* - * @unimplemented - */ -VOID NTAPI -MmUnlockPagableImageSection(IN PVOID ImageSectionHandle) -{ - UNIMPLEMENTED; -} - -/* - * @unimplemented - */ -PVOID NTAPI -MmPageEntireDriver(IN PVOID AddressWithinSection) -{ - UNIMPLEMENTED; - return NULL; -} - - -/* - * @unimplemented - */ -VOID NTAPI -MmResetDriverPaging(IN PVOID AddressWithinSection) -{ - UNIMPLEMENTED; +NTSTATUS +NTAPI +MmAddVerifierThunks(IN PVOID ThunkBuffer, + IN ULONG ThunkBufferSize) +{ + PDRIVER_VERIFIER_THUNK_PAIRS ThunkTable; + ULONG ThunkCount; + PDRIVER_SPECIFIED_VERIFIER_THUNKS DriverThunks; + PLDR_DATA_TABLE_ENTRY LdrEntry; + PVOID ModuleBase, ModuleEnd; + ULONG i; + NTSTATUS Status = STATUS_SUCCESS; + PAGED_CODE(); + + // + // Make sure the driver verifier is initialized + // + if (!MiVerifierDriverAddedThunkListHead.Flink) return STATUS_NOT_SUPPORTED; + + // + // Get the thunk pairs and count them + // + ThunkCount = ThunkBufferSize / sizeof(DRIVER_VERIFIER_THUNK_PAIRS); + if (!ThunkCount) return STATUS_INVALID_PARAMETER_1; + + // + // Now allocate our own thunk table + // + DriverThunks = ExAllocatePoolWithTag(PagedPool, + sizeof(*DriverThunks) + + ThunkCount * + sizeof(DRIVER_VERIFIER_THUNK_PAIRS), + 'tVmM'); + if (!DriverThunks) return STATUS_INSUFFICIENT_RESOURCES; + + // + // Now copy the driver-fed part + // + ThunkTable = (PDRIVER_VERIFIER_THUNK_PAIRS)(DriverThunks + 1); + RtlCopyMemory(ThunkTable, + ThunkBuffer, + ThunkCount * sizeof(DRIVER_VERIFIER_THUNK_PAIRS)); + + // + // Acquire the system load lock + // + KeEnterCriticalRegion(); + KeWaitForSingleObject(&MmSystemLoadLock, + WrVirtualMemory, + KernelMode, + FALSE, + NULL); + + // + // Get the loader entry + // + LdrEntry = MiLookupDataTableEntry(ThunkTable->PristineRoutine); + if (!LdrEntry) + { + // + // Fail + // + Status = STATUS_INVALID_PARAMETER_2; + goto Cleanup; + } + + // + // Get driver base and end + // + ModuleBase = LdrEntry->DllBase; + ModuleEnd = (PVOID)((ULONG_PTR)LdrEntry->DllBase + LdrEntry->SizeOfImage); + + // + // Don't allow hooking the kernel or HAL + // + if (ModuleBase < (PVOID)(KSEG0_BASE + MmBootImageSize)) + { + // + // Fail + // + Status = STATUS_INVALID_PARAMETER_2; + goto Cleanup; + } + + // + // Loop all the thunks + // + for (i = 0; i < ThunkCount; i++) + { + // + // Make sure it's in the driver + // + if (((ULONG_PTR)ThunkTable->PristineRoutine < (ULONG_PTR)ModuleBase) || + ((ULONG_PTR)ThunkTable->PristineRoutine >= (ULONG_PTR)ModuleEnd)) + { + // + // Nope, fail + // + Status = STATUS_INVALID_PARAMETER_2; + goto Cleanup; + } + } + + // + // Otherwise, add this entry + // + DriverThunks->DataTableEntry = LdrEntry; + DriverThunks->NumberOfThunks = ThunkCount; + MiActiveVerifierThunks++; + InsertTailList(&MiVerifierDriverAddedThunkListHead, + &DriverThunks->ListEntry); + DriverThunks = NULL; + +Cleanup: + // + // Release the lock + // + KeReleaseMutant(&MmSystemLoadLock, 1, FALSE, FALSE); + KeLeaveCriticalRegion(); + + // + // Free the table if we failed and return status + // + if (DriverThunks) ExFreePool(DriverThunks); + return Status; +} + +/* + * @implemented + */ +LOGICAL +NTAPI +MmIsDriverVerifying(IN PDRIVER_OBJECT DriverObject) +{ + PLDR_DATA_TABLE_ENTRY LdrEntry; + + // + // Get the loader entry + // + LdrEntry = (PLDR_DATA_TABLE_ENTRY)DriverObject->DriverSection; + if (!LdrEntry) return FALSE; + + // + // Check if we're verifying or not + // + return (LdrEntry->Flags & LDRP_IMAGE_VERIFYING) ? TRUE: FALSE; +} + +/* + * @implemented + */ +NTSTATUS +NTAPI +MmIsVerifierEnabled(OUT PULONG VerifierFlags) +{ + // + // Check if we've actually added anything to the list + // + if (MiVerifierDriverAddedThunkListHead.Flink) + { + // + // We have, read the verifier level + // + *VerifierFlags = MmVerifierData.Level; + return STATUS_SUCCESS; + } + + // + // Otherwise, we're disabled + // + *VerifierFlags = 0; + return STATUS_NOT_SUPPORTED; } /* EOF */ Modified: trunk/reactos/ntoskrnl/mm/ARM3/miarm.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/ARM3/miarm.h?r… ============================================================================== --- trunk/reactos/ntoskrnl/mm/ARM3/miarm.h [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/mm/ARM3/miarm.h [iso-8859-1] Sun Jun 28 11:32:52 2009 @@ -52,6 +52,7 @@ extern PMMPTE MiFirstReservedZeroingPte; extern MI_PFN_CACHE_ATTRIBUTE MiPlatformCacheAttributes[2][MmMaximumCacheType]; extern PPHYSICAL_MEMORY_DESCRIPTOR MmPhysicalMemoryBlock; +extern ULONG MmBootImageSize; VOID NTAPI Removed: trunk/reactos/ntoskrnl/mm/drvlck.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/drvlck.c?rev=4… ============================================================================== --- trunk/reactos/ntoskrnl/mm/drvlck.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/mm/drvlck.c (removed) @@ -1,102 +1,0 @@ -/* - * COPYRIGHT: See COPYING in the top level directory - * PROJECT: ReactOS kernel - * FILE: ntoskrnl/mm/drvlck.c - * PURPOSE: Managing driver managing - * - * PROGRAMMERS: David Welch (welch(a)mcmail.com) - */ - -/* INCLUDES *****************************************************************/ - -#include <ntoskrnl.h> -#include <debug.h> - -/* FUNCTIONS *****************************************************************/ - -#undef MmLockPagableDataSection - -#if 0 -VOID -MmUnlockPagableImageSection(IN PVOID ImageSectionHandle) -/* - * FUNCTION: Releases a section of driver code or driver data, previously - * locked into system space with MmLockPagableCodeSection, - * MmLockPagableDataSection or MmLockPagableSectionByHandle - * ARGUMENTS: - * ImageSectionHandle = Handle returned by MmLockPagableCodeSection or - * MmLockPagableDataSection - */ -{ - // MmUnlockMemoryArea((MEMORY_AREA *)ImageSectionHandle); - UNIMPLEMENTED; -} -#endif - - -/* - * @unimplemented - */ -VOID NTAPI -MmLockPagableSectionByHandle(IN PVOID ImageSectionHandle) -{ - UNIMPLEMENTED; -} - - -#if 0 -PVOID -MmLockPagableCodeSection(IN PVOID AddressWithinSection) -{ - PVOID Handle; - Handle = MmLocateMemoryAreaByAddress(NULL,AddressWithinSection); - MmLockPagableSectionByHandle(Handle); - return(Handle); -} -#endif - - -/* - * @implemented - */ -PVOID NTAPI -MmLockPagableDataSection(IN PVOID AddressWithinSection) -{ - PVOID Handle; - Handle = MmLocateMemoryAreaByAddress(MmGetKernelAddressSpace(), - AddressWithinSection); - MmLockPagableSectionByHandle(Handle); - return(Handle); -} - - -/* - * @unimplemented - */ -VOID NTAPI -MmUnlockPagableImageSection(IN PVOID ImageSectionHandle) -{ - UNIMPLEMENTED; -} - -/* - * @unimplemented - */ -PVOID NTAPI -MmPageEntireDriver(IN PVOID AddressWithinSection) -{ - UNIMPLEMENTED; - return NULL; -} - - -/* - * @unimplemented - */ -VOID NTAPI -MmResetDriverPaging(IN PVOID AddressWithinSection) -{ - UNIMPLEMENTED; -} - -/* EOF */ Removed: trunk/reactos/ntoskrnl/mm/verifier.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/verifier.c?rev… ============================================================================== --- trunk/reactos/ntoskrnl/mm/verifier.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/mm/verifier.c (removed) @@ -1,190 +1,0 @@ -/* -* PROJECT: ReactOS Kernel -* LICENSE: GPL - See COPYING in the top level directory -* FILE: ntoskrnl/mm/verifier.c -* PURPOSE: Mm Driver Verifier Routines -* PROGRAMMERS: Alex Ionescu (alex.ionescu(a)reactos.org) -*/ - -/* INCLUDES ******************************************************************/ - -#include <ntoskrnl.h> -#define NDEBUG -#include <debug.h> - -/* GLOBALS *******************************************************************/ - -MM_DRIVER_VERIFIER_DATA MmVerifierData; -LIST_ENTRY MiVerifierDriverAddedThunkListHead; -KMUTANT MmSystemLoadLock; -ULONG MiActiveVerifierThunks; - -extern LIST_ENTRY PsLoadedModuleList; - -/* PRIVATE FUNCTIONS *********************************************************/ - -PLDR_DATA_TABLE_ENTRY -NTAPI -MiLookupDataTableEntry(IN PVOID Address) -{ - PLDR_DATA_TABLE_ENTRY LdrEntry, FoundEntry = NULL; - PLIST_ENTRY NextEntry; - PAGED_CODE(); - - /* Loop entries */ - NextEntry = PsLoadedModuleList.Flink; - do - { - /* Get the loader entry */ - LdrEntry = CONTAINING_RECORD(NextEntry, - LDR_DATA_TABLE_ENTRY, - InLoadOrderLinks); - - /* Check if the address matches */ - if ((Address >= LdrEntry->DllBase) && - (Address < (PVOID)((ULONG_PTR)LdrEntry->DllBase + LdrEntry->SizeOfImage))) - { - /* Found a match */ - FoundEntry = LdrEntry; - break; - } - - /* Move on */ - NextEntry = NextEntry->Flink; - } while(NextEntry != &PsLoadedModuleList); - - /* Return the entry */ - return FoundEntry; -} - -/* PUBLIC FUNCTIONS **********************************************************/ - -/* - * @implemented - */ -NTSTATUS -NTAPI -MmAddVerifierThunks(IN PVOID ThunkBuffer, - IN ULONG ThunkBufferSize) -{ - PDRIVER_VERIFIER_THUNK_PAIRS ThunkPairs, DriverThunkTable; - ULONG ThunkCount; - PDRIVER_SPECIFIED_VERIFIER_THUNKS ThunkTable; - PLDR_DATA_TABLE_ENTRY LdrEntry; - PVOID ModuleBase, ModuleEnd; - ULONG i; - NTSTATUS Status = STATUS_SUCCESS; - PAGED_CODE(); - - /* Make sure the driver verifier is initialized */ - if (!MiVerifierDriverAddedThunkListHead.Flink) return STATUS_NOT_SUPPORTED; - - /* Get the thunk pairs and count them */ - ThunkPairs = (PDRIVER_VERIFIER_THUNK_PAIRS)ThunkBuffer; - ThunkCount = ThunkBufferSize / sizeof(DRIVER_VERIFIER_THUNK_PAIRS); - if (!ThunkCount) return STATUS_INVALID_PARAMETER_1; - - /* Now allocate our own thunk table */ - ThunkTable = ExAllocatePoolWithTag(PagedPool, - sizeof(DRIVER_SPECIFIED_VERIFIER_THUNKS) + - ThunkCount * - sizeof(DRIVER_VERIFIER_THUNK_PAIRS), - TAG('M', 'm', 'V', 't')); - if (!ThunkTable) return STATUS_INSUFFICIENT_RESOURCES; - - /* Now copy the driver-fed part */ - DriverThunkTable = (PDRIVER_VERIFIER_THUNK_PAIRS)(ThunkTable + 1); - RtlCopyMemory(DriverThunkTable, - ThunkPairs, - ThunkCount * sizeof(DRIVER_VERIFIER_THUNK_PAIRS)); - - /* Acquire the system load lock */ - KeEnterCriticalRegion(); - KeWaitForSingleObject(&MmSystemLoadLock, - WrVirtualMemory, - KernelMode, - FALSE, - NULL); - - /* Get the loader entry */ - LdrEntry = MiLookupDataTableEntry(DriverThunkTable->PristineRoutine); - if (!LdrEntry) - { - /* Fail */ - Status = STATUS_INVALID_PARAMETER_2; - goto Cleanup; - } - - /* Get driver base and end */ - ModuleBase = LdrEntry->DllBase; - ModuleEnd = (PVOID)((ULONG_PTR)LdrEntry->DllBase + LdrEntry->SizeOfImage); - - /* Loop all the thunks */ - for (i = 0; i < ThunkCount; i++) - { - /* Make sure it's in the driver */ - if (((ULONG_PTR)DriverThunkTable->PristineRoutine < (ULONG_PTR)ModuleBase) || - ((ULONG_PTR)DriverThunkTable->PristineRoutine >= (ULONG_PTR)ModuleEnd)) - { - /* Nope, fail */ - Status = STATUS_INVALID_PARAMETER_2; - goto Cleanup; - } - } - - /* Otherwise, add this entry */ - ThunkTable->DataTableEntry = LdrEntry; - ThunkTable->NumberOfThunks = ThunkCount; - MiActiveVerifierThunks++; - InsertTailList(&MiVerifierDriverAddedThunkListHead, - &ThunkTable->ListEntry); - ThunkTable = NULL; - -Cleanup: - /* Release the lock */ - KeReleaseMutant(&MmSystemLoadLock, 1, FALSE, FALSE); - KeLeaveCriticalRegion(); - - /* Free the table if we failed and return status */ - if (ThunkTable) ExFreePool(ThunkTable); - return Status; -} - -/* - * @implemented - */ -LOGICAL -NTAPI -MmIsDriverVerifying(IN PDRIVER_OBJECT DriverObject) -{ - PLDR_DATA_TABLE_ENTRY LdrEntry; - - /* Get the loader entry */ - LdrEntry = (PLDR_DATA_TABLE_ENTRY)DriverObject->DriverSection; - if (!LdrEntry) return FALSE; - - /* Check if we're verifying or not */ - return (LdrEntry->Flags & LDRP_IMAGE_VERIFYING) ? TRUE: FALSE; -} - -/* - * @implemented - */ -NTSTATUS -NTAPI -MmIsVerifierEnabled(OUT PULONG VerifierFlags) -{ - /* Check if we've actually added anything to the list */ - if (MiVerifierDriverAddedThunkListHead.Flink) - { - /* We have, read the verifier level */ - *VerifierFlags = MmVerifierData.Level; - return STATUS_SUCCESS; - } - - /* Otherwise, we're disabled */ - *VerifierFlags = 0; - return STATUS_NOT_SUPPORTED; -} - -/* EOF */ Modified: trunk/reactos/ntoskrnl/mm/wset.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/wset.c?rev=416… ============================================================================== --- trunk/reactos/ntoskrnl/mm/wset.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/mm/wset.c [iso-8859-1] Sun Jun 28 11:32:52 2009 @@ -46,16 +46,3 @@ } return(STATUS_SUCCESS); } - -/* - * @unimplemented - */ -ULONG -NTAPI -MmTrimAllSystemPagableMemory ( - IN ULONG PurgeTransitionList - ) -{ - UNIMPLEMENTED; - return 0; -} Modified: trunk/reactos/ntoskrnl/ntoskrnl-generic.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ntoskrnl-generic.… ============================================================================== --- trunk/reactos/ntoskrnl/ntoskrnl-generic.rbuild [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/ntoskrnl-generic.rbuild [iso-8859-1] Sun Jun 28 11:32:52 2009 @@ -361,6 +361,7 @@ </if> <directory name="ARM3"> <file>contmem.c</file> + <file>drvmgmt.c</file> <file>dynamic.c</file> <file>hypermap.c</file> <file>init.c</file> @@ -372,7 +373,6 @@ <file>anonmem.c</file> <file>balance.c</file> <file>dbgpool.c</file> - <file>drvlck.c</file> <file>freelist.c</file> <file>kmap.c</file> <file>marea.c</file> @@ -392,7 +392,6 @@ <file>rmap.c</file> <file>section.c</file> <file>sysldr.c</file> - <file>verifier.c</file> <file>virtual.c</file> <file>wset.c</file> <if property="_ELF_" value="1"> Modified: trunk/reactos/ntoskrnl/ntoskrnl.pspec URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ntoskrnl.pspec?re… ============================================================================== --- trunk/reactos/ntoskrnl/ntoskrnl.pspec [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/ntoskrnl.pspec [iso-8859-1] Sun Jun 28 11:32:52 2009 @@ -771,9 +771,9 @@ @ stdcall MmIsRecursiveIoFault() @ stdcall MmIsThisAnNtAsSystem() @ stdcall MmIsVerifierEnabled(ptr) -@ stdcall MmLockPagableDataSection(ptr) -@ stdcall MmLockPagableImageSection(ptr) MmLockPagableDataSection -@ stdcall MmLockPagableSectionByHandle(ptr) +@ stdcall MmLockPagableDataSection(ptr) MmLockPageableDataSection +@ stdcall MmLockPagableImageSection(ptr) MmLockPageableDataSection +@ stdcall MmLockPagableSectionByHandle(ptr) MmLockPageableSectionByHandle @ stdcall MmMapIoSpace(long long long long) @ stdcall MmMapLockedPages(ptr long) @ stdcall MmMapLockedPagesSpecifyCache(ptr long long ptr long long) @@ -801,8 +801,8 @@ @ stdcall MmSetBankedSection(long long long long long long) @ stdcall MmSizeOfMdl(ptr long) @ extern MmSystemRangeStart -@ stdcall MmTrimAllSystemPagableMemory(long) -@ stdcall MmUnlockPagableImageSection(ptr) +@ stdcall MmTrimAllSystemPagableMemory(long) MmTrimAllSystemPageableMemory +@ stdcall MmUnlockPagableImageSection(ptr) MmUnlockPageableImageSection @ stdcall MmUnlockPages(ptr) @ stdcall MmUnmapIoSpace(ptr long) @ stdcall MmUnmapLockedPages(ptr ptr)

1 0

[ros-arm-bringup] 41657: - Reimplement MmAllocateContiguousMemory, MmAllocateContiguousMemorySpecifyCache, MmFreeContiguousMemory, MmFreeContiguousMemorySpecifyCache: - Use a smarter algorithm (as described here: http://www.microsoft.com/whdc/Driver/tips/ContigMem.mspx) to first try to satisfy the allocation by a simple nonpaged pool allocation (for cached requests only). - This range is then checked for physical continuity, since it's not guaranteed for non-initial-pool allocations (and right n
by ros-arm-bringup＠svn.reactos.org 28 Jun '09

28 Jun '09

Author: ros-arm-bringup Date: Sun Jun 28 09:43:12 2009 New Revision: 41657 URL: http://svn.reactos.org/svn/reactos?rev=41657&view=rev Log: - Reimplement MmAllocateContiguousMemory, MmAllocateContiguousMemorySpecifyCache, MmFreeContiguousMemory, MmFreeContiguousMemorySpecifyCache: - Use a smarter algorithm (as described here: http://www.microsoft.com/whdc/Driver/tips/ContigMem.mspx) to first try to satisfy the allocation by a simple nonpaged pool allocation (for cached requests only). - This range is then checked for physical continuity, since it's not guaranteed for non-initial-pool allocations (and right now in ReactOS, it never is). - As a fallback, Windows NT then attempts to scan free nonpaged pool pages. This is not yet implemented since the ReactOS nonpaged pool is not usually contiguous (to the level that NT's is). - When the ARM pool is implemented and replaces nonpaged pool, this code path will have to be implemented. - As a last resort, the actual PFN database is scanned for contiguous free pages. - ReactOS used MmGetContiguousPages for this, which blindly scanned the PFN database. New MiFindContinuousPages will scan the physical memory descriptor block recently implemented, which avoids going over pages we already know are going to be unusable. - The ReactOS function also held the PFN lock for the entire duration of the scan, which is significant on systems with large memory. Instead, we make an initial unsafe scan first, and only lock when we think we've found a correct range (and we'll then reconfirm the ranges). - Finally, the older function actually did a double-scan to try to avoid using memory ranges under 16MB, which was useless on today's systems and also rather inefficient. - Other than that, the actual setup of the PFN entry is copy-pasted from the old ReactOS function, so nothing's changed there -- the page still looks the same, but the selection algorithm is faster and more accurate. - Once the pages are found, we piggyback on the new I/O mapping mechanism (which uses System PTEs) instead of doing it all over by hand as before. - Since the underlying support is still System PTEs, once again, optimizations to that component will yield significant improvements here too. Added: trunk/reactos/ntoskrnl/mm/ARM3/contmem.c - copied, changed from r41647, trunk/reactos/ntoskrnl/mm/cont.c Removed: trunk/reactos/ntoskrnl/mm/cont.c Modified: trunk/reactos/ntoskrnl/mm/ARM3/miarm.h trunk/reactos/ntoskrnl/mm/freelist.c trunk/reactos/ntoskrnl/ntoskrnl-generic.rbuild Copied: trunk/reactos/ntoskrnl/mm/ARM3/contmem.c (from r41647, trunk/reactos/ntoskrnl/mm/cont.c) URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/ARM3/contmem.c… ============================================================================== --- trunk/reactos/ntoskrnl/mm/cont.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/mm/ARM3/contmem.c [iso-8859-1] Sun Jun 28 09:43:12 2009 @@ -1,241 +1,440 @@ /* - * COPYRIGHT: See COPYING in the top level directory - * PROJECT: ReactOS kernel - * FILE: ntoskrnl/mm/cont.c - * PURPOSE: Manages continuous memory - * - * PROGRAMMERS: David Welch (welch(a)cwcom.net) + * PROJECT: ReactOS Kernel + * LICENSE: BSD - See COPYING.ARM in the top level directory + * FILE: ntoskrnl/mm/ARM3/contmem.c + * PURPOSE: ARM Memory Manager Contiguous Memory Allocator + * PROGRAMMERS: ReactOS Portable Systems Group */ -/* INCLUDES *****************************************************************/ +/* INCLUDES *******************************************************************/ #include <ntoskrnl.h> #define NDEBUG #include <debug.h> -/* FUNCTIONS *****************************************************************/ - -static VOID -MmFreeContinuousPage(PVOID Context, MEMORY_AREA* MemoryArea, PVOID Address, - PFN_TYPE Page, SWAPENTRY SwapEntry, - BOOLEAN Dirty) -{ - ASSERT(SwapEntry == 0); - if (Page != 0) - { - MmReleasePageMemoryConsumer(MC_NPPOOL, Page); - } -} - -/********************************************************************** - * NAME EXPORTED - * MmAllocateContiguousMemorySpecifyCache@32 - * - * DESCRIPTION - * Allocates a range of physically contiguous memory - * with a cache parameter. - * - * ARGUMENTS - * NumberOfBytes - * Size of the memory block to allocate; - * - * LowestAcceptableAddress - * Lowest address valid for the caller. - * - * HighestAcceptableAddress - * Highest address valid for the caller. - * - * BoundaryAddressMultiple - * Address multiple not to be crossed by allocated buffer (optional). - * - * CacheType - * Type of caching to use. - * - * RETURN VALUE - * The virtual address of the memory block on success; - * NULL on error. - * - * REVISIONS - * +#line 15 "ARMÂ³::CONTMEM" +#define MODULE_INVOLVED_IN_ARM3 +#include "../ARM3/miarm.h" + +/* PRIVATE FUNCTIONS **********************************************************/ + +PVOID +NTAPI +MiCheckForContiguousMemory(IN PVOID BaseAddress, + IN PFN_NUMBER BaseAddressPages, + IN PFN_NUMBER SizeInPages, + IN PFN_NUMBER LowestPfn, + IN PFN_NUMBER HighestPfn, + IN PFN_NUMBER BoundaryPfn, + IN MI_PFN_CACHE_ATTRIBUTE CacheAttribute) +{ + PMMPTE StartPte, EndPte; + PFN_NUMBER PreviousPage = 0, Page, HighPage, BoundaryMask, Pages = 0; + + // + // Okay, first of all check if the PFNs match our restrictions + // + if (LowestPfn > HighestPfn) return NULL; + if (LowestPfn + SizeInPages <= LowestPfn) return NULL; + if (LowestPfn + SizeInPages - 1 > HighestPfn) return NULL; + if (BaseAddressPages < SizeInPages) return NULL; + + // + // This is the last page we need to get to and the boundary requested + // + HighPage = HighestPfn + 1 - SizeInPages; + BoundaryMask = ~(BoundaryPfn - 1); + + // + // And here's the PTEs for this allocation. Let's go scan them. + // + StartPte = MiAddressToPte(BaseAddress); + EndPte = StartPte + BaseAddressPages; + while (StartPte < EndPte) + { + // + // Get this PTE's page number + // + ASSERT (StartPte->u.Hard.Valid == 1); + Page = PFN_FROM_PTE(StartPte); + + // + // Is this the beginning of our adventure? + // + if (!Pages) + { + // + // Check if this PFN is within our range + // + if ((Page >= LowestPfn) && (Page <= HighPage)) + { + // + // It is! Do you care about boundary (alignment)? + // + if (!(BoundaryPfn) || + (!((Page ^ (Page + SizeInPages - 1)) & BoundaryMask))) + { + // + // You don't care, or you do care but we deliver + // + Pages++; + } + } + + // + // Have we found all the pages we need by now? + // Incidently, this means you only wanted one page + // + if (Pages == SizeInPages) + { + // + // Mission complete + // + return MiPteToAddress(StartPte); + } + } + else + { + // + // Have we found a page that doesn't seem to be contiguous? + // + if (Page != (PreviousPage + 1)) + { + // + // Ah crap, we have to start over + // + Pages = 0; + continue; + } + + // + // Otherwise, we're still in the game. Do we have all our pages? + // + if (++Pages == SizeInPages) + { + // + // We do! This entire range was contiguous, so we'll return it! + // + return MiPteToAddress(StartPte - Pages + 1); + } + } + + // + // Try with the next PTE, remember this PFN + // + PreviousPage = Page; + StartPte++; + continue; + } + + // + // All good returns are within the loop... + // + return NULL; +} + +PVOID +NTAPI +MiFindContiguousMemory(IN PFN_NUMBER LowestPfn, + IN PFN_NUMBER HighestPfn, + IN PFN_NUMBER BoundaryPfn, + IN PFN_NUMBER SizeInPages, + IN MEMORY_CACHING_TYPE CacheType) +{ + PFN_NUMBER Page; + PHYSICAL_ADDRESS PhysicalAddress; + PAGED_CODE (); + ASSERT(SizeInPages != 0); + + // + // Our last hope is to scan the free page list for contiguous pages + // + Page = MiFindContiguousPages(LowestPfn, + HighestPfn, + BoundaryPfn, + SizeInPages, + CacheType); + if (!Page) return NULL; + + // + // We'll just piggyback on the I/O memory mapper + // + PhysicalAddress.QuadPart = Page << PAGE_SHIFT; + return MmMapIoSpace(PhysicalAddress, SizeInPages << PAGE_SHIFT, CacheType); +} + +PVOID +NTAPI +MiAllocateContiguousMemory(IN SIZE_T NumberOfBytes, + IN PFN_NUMBER LowestAcceptablePfn, + IN PFN_NUMBER HighestAcceptablePfn, + IN PFN_NUMBER BoundaryPfn, + IN MEMORY_CACHING_TYPE CacheType) +{ + PVOID BaseAddress; + PFN_NUMBER SizeInPages; + MI_PFN_CACHE_ATTRIBUTE CacheAttribute; + ASSERT(NumberOfBytes != 0); + + // + // Compute size requested + // + SizeInPages = BYTES_TO_PAGES(NumberOfBytes); + + // + // Convert the cache attribute and check for cached requests + // + CacheAttribute = MiPlatformCacheAttributes[FALSE][CacheType]; + if (CacheAttribute == MiCached) + { + // + // Because initial nonpaged pool is supposed to be contiguous, go ahead + // and try making a nonpaged pool allocation first. + // + BaseAddress = ExAllocatePoolWithTag(NonPagedPoolCacheAligned, + NumberOfBytes, + 'mCmM'); + if (BaseAddress) + { + // + // Now make sure it's actually contiguous (if it came from expansion + // it might not be). + // + if (MiCheckForContiguousMemory(BaseAddress, + SizeInPages, + SizeInPages, + LowestAcceptablePfn, + HighestAcceptablePfn, + BoundaryPfn, + CacheAttribute)) + { + // + // Sweet, we're in business! + // + return BaseAddress; + } + + // + // No such luck + // + ExFreePool(BaseAddress); + } + } + + // + // According to MSDN, the system won't try anything else if you're higher + // than APC level. + // + if (KeGetCurrentIrql() > APC_LEVEL) return NULL; + + // + // Otherwise, we'll go try to find some + // + return MiFindContiguousMemory(LowestAcceptablePfn, + HighestAcceptablePfn, + BoundaryPfn, + SizeInPages, + CacheType); +} + +VOID +NTAPI +MiFreeContiguousMemory(IN PVOID BaseAddress) +{ + KIRQL OldIrql; + PFN_NUMBER PageFrameIndex, LastPage, PageCount; + PMMPFN Pfn1, StartPfn; + PAGED_CODE(); + + // + // First, check if the memory came from initial nonpaged pool, or expansion + // + if (((BaseAddress >= MmNonPagedPoolStart) && + (BaseAddress < (PVOID)((ULONG_PTR)MmNonPagedPoolStart + + MmSizeOfNonPagedPoolInBytes))) || + ((BaseAddress >= MmNonPagedPoolExpansionStart) && + (BaseAddress < MmNonPagedPoolEnd))) + { + // + // It did, so just use the pool to free this + // + ExFreePool(BaseAddress); + return; + } + + // + // Otherwise, get the PTE and page number for the allocation + // + PageFrameIndex = PFN_FROM_PTE(MiAddressToPte(BaseAddress)); + + // + // Now get the PFN entry for this, and make sure it's the correct one + // + Pfn1 = MiGetPfnEntry(PageFrameIndex); + if (Pfn1->u3.e1.StartOfAllocation == 0) + { + // + // This probably means you did a free on an address that was in between + // + KeBugCheckEx (BAD_POOL_CALLER, + 0x60, + (ULONG_PTR)BaseAddress, + 0, + 0); + } + + // + // Now this PFN isn't the start of any allocation anymore, it's going out + // + StartPfn = Pfn1; + Pfn1->u3.e1.StartOfAllocation = 0; + + // + // Look the PFNs + // + do + { + // + // Until we find the one that marks the end of the allocation + // + } while (Pfn1++->u3.e1.EndOfAllocation == 0); + + // + // Found it, unmark it + // + Pfn1--; + Pfn1->u3.e1.EndOfAllocation = 0; + + // + // Now compute how many pages this represents + // + PageCount = (ULONG)(Pfn1 - StartPfn + 1); + + // + // So we can know how much to unmap (recall we piggyback on I/O mappings) + // + MmUnmapIoSpace(BaseAddress, PageCount << PAGE_SHIFT); + + // + // Lock the PFN database + // + OldIrql = KeAcquireQueuedSpinLock(LockQueuePfnLock); + + // + // Loop all the pages + // + LastPage = PageFrameIndex + PageCount; + do + { + // + // Free each one, and move on + // + MmReleasePageMemoryConsumer(MC_NPPOOL, PageFrameIndex); + } while (++PageFrameIndex < LastPage); + + // + // Release the PFN lock + // + KeReleaseQueuedSpinLock(LockQueuePfnLock, OldIrql); +} + +/* PUBLIC FUNCTIONS ***********************************************************/ + +/* * @implemented */ -PVOID NTAPI +PVOID +NTAPI MmAllocateContiguousMemorySpecifyCache(IN SIZE_T NumberOfBytes, IN PHYSICAL_ADDRESS LowestAcceptableAddress OPTIONAL, IN PHYSICAL_ADDRESS HighestAcceptableAddress, IN PHYSICAL_ADDRESS BoundaryAddressMultiple OPTIONAL, IN MEMORY_CACHING_TYPE CacheType OPTIONAL) { - PMEMORY_AREA MArea; - NTSTATUS Status; - PVOID BaseAddress = NULL; - PFN_TYPE PBase; - ULONG Protect; - ULONG i; - - Protect = PAGE_EXECUTE_READWRITE | PAGE_SYSTEM; - if (CacheType == MmNonCached || CacheType == MmWriteCombined) - { - Protect |= PAGE_NOCACHE; - } - if (CacheType == MmWriteCombined) - { - Protect |= PAGE_WRITECOMBINE; - } - - MmLockAddressSpace(MmGetKernelAddressSpace()); - Status = MmCreateMemoryArea(MmGetKernelAddressSpace(), - MEMORY_AREA_CONTINUOUS_MEMORY, - &BaseAddress, - NumberOfBytes, - PAGE_READWRITE, - &MArea, - FALSE, - 0, - RtlConvertLongToLargeInteger(0)); - MmUnlockAddressSpace(MmGetKernelAddressSpace()); - - if (!NT_SUCCESS(Status)) - { - return(NULL); - } - DPRINT( "Base = %x\n", BaseAddress ); - PBase = MmGetContinuousPages(NumberOfBytes, - LowestAcceptableAddress, - HighestAcceptableAddress, - BoundaryAddressMultiple, - TRUE); - if (PBase == 0) - { - MmLockAddressSpace(MmGetKernelAddressSpace()); - MmFreeMemoryArea(MmGetKernelAddressSpace(), - MArea, - NULL, - NULL); - MmUnlockAddressSpace(MmGetKernelAddressSpace()); - return(NULL); - } - for (i = 0; i < (PAGE_ROUND_UP(NumberOfBytes) / PAGE_SIZE); i++, PBase++) - { - MmCreateVirtualMapping(NULL, - (char*)BaseAddress + (i * PAGE_SIZE), - Protect, - &PBase, - 1); - } - return(BaseAddress); -} - -/********************************************************************** - * NAME EXPORTED - * MmAllocateContiguousMemory@12 - * - * DESCRIPTION - * Allocates a range of physically contiguous cache aligned - * memory from the non-paged pool. - * - * ARGUMENTS - * NumberOfBytes - * Size of the memory block to allocate; - * - * HighestAcceptableAddress - * Highest address valid for the caller. - * - * RETURN VALUE - * The virtual address of the memory block on success; - * NULL on error. - * - * NOTE - * Description taken from include/ddk/mmfuncs.h. - * Code taken from ntoskrnl/mm/special.c. - * - * REVISIONS - * + PFN_NUMBER LowestPfn, HighestPfn, BoundaryPfn; + ASSERT (NumberOfBytes != 0); + + // + // Convert the lowest address into a PFN + // + LowestPfn = (PFN_NUMBER)(LowestAcceptableAddress.QuadPart >> PAGE_SHIFT); + if (BYTE_OFFSET(LowestAcceptableAddress.LowPart)) LowestPfn++; + + // + // Convert and validate the boundary address into a PFN + // + if (BYTE_OFFSET(BoundaryAddressMultiple.LowPart)) return NULL; + BoundaryPfn = (PFN_NUMBER)(BoundaryAddressMultiple.QuadPart >> PAGE_SHIFT); + + // + // Convert the highest address into a PFN + // + HighestPfn = (PFN_NUMBER)(HighestAcceptableAddress.QuadPart >> PAGE_SHIFT); + if (HighestPfn > MmHighestPhysicalPage) HighestPfn = MmHighestPhysicalPage; + + // + // Validate the PFN bounds + // + if (LowestPfn > HighestPfn) return NULL; + + // + // Let the contiguous memory allocator handle it + // + return MiAllocateContiguousMemory(NumberOfBytes, + LowestPfn, + HighestPfn, + BoundaryPfn, + CacheType); +} + +/* * @implemented */ -PVOID NTAPI -MmAllocateContiguousMemory (IN ULONG NumberOfBytes, - IN PHYSICAL_ADDRESS HighestAcceptableAddress) -{ - return MmAllocateContiguousMemorySpecifyCache(NumberOfBytes, - RtlConvertLongToLargeInteger(0), - HighestAcceptableAddress, - RtlConvertLongToLargeInteger(0), - MmCached); -} - - -/********************************************************************** - * NAME EXPORTED - * MmFreeContiguousMemory@4 - * - * DESCRIPTION - * Releases a range of physically contiguous memory allocated - * with MmAllocateContiguousMemory. - * - * ARGUMENTS - * BaseAddress - * Virtual address of the memory to be freed. - * - * RETURN VALUE - * None. - * - * NOTE - * Description taken from include/ddk/mmfuncs.h. - * Code taken from ntoskrnl/mm/special.c. - * - * REVISIONS - * +PVOID +NTAPI +MmAllocateContiguousMemory(IN ULONG NumberOfBytes, + IN PHYSICAL_ADDRESS HighestAcceptableAddress) +{ + PFN_NUMBER HighestPfn; + + // + // Convert and normalize the highest address into a PFN + // + HighestPfn = (PFN_NUMBER)(HighestAcceptableAddress.QuadPart >> PAGE_SHIFT); + if (HighestPfn > MmHighestPhysicalPage) HighestPfn = MmHighestPhysicalPage; + + // + // Let the contiguous memory allocator handle it + // + return MiAllocateContiguousMemory(NumberOfBytes, 0, HighestPfn, 0, MmCached); +} + +/* * @implemented */ -VOID NTAPI +VOID +NTAPI MmFreeContiguousMemory(IN PVOID BaseAddress) { - MmLockAddressSpace(MmGetKernelAddressSpace()); - MmFreeMemoryAreaByPtr(MmGetKernelAddressSpace(), - BaseAddress, - MmFreeContinuousPage, - NULL); - MmUnlockAddressSpace(MmGetKernelAddressSpace()); -} - -/********************************************************************** - * NAME EXPORTED - * MmFreeContiguousMemorySpecifyCache@12 - * - * DESCRIPTION - * Releases a range of physically contiguous memory allocated - * with MmAllocateContiguousMemorySpecifyCache. - * - * ARGUMENTS - * BaseAddress - * Virtual address of the memory to be freed. - * - * NumberOfBytes - * Size of the memory block to free. - * - * CacheType - * Type of caching used. - * - * RETURN VALUE - * None. - * - * REVISIONS - * + // + // Let the contiguous memory allocator handle it + // + MiFreeContiguousMemory(BaseAddress); +} + +/* * @implemented */ -VOID NTAPI +VOID +NTAPI MmFreeContiguousMemorySpecifyCache(IN PVOID BaseAddress, IN ULONG NumberOfBytes, IN MEMORY_CACHING_TYPE CacheType) { - MmLockAddressSpace(MmGetKernelAddressSpace()); - MmFreeMemoryAreaByPtr(MmGetKernelAddressSpace(), - BaseAddress, - MmFreeContinuousPage, - NULL); - MmUnlockAddressSpace(MmGetKernelAddressSpace()); -} - + // + // Just call the non-cached version (there's no cache issues for freeing) + // + MiFreeContiguousMemory(BaseAddress); +} /* EOF */ Modified: trunk/reactos/ntoskrnl/mm/ARM3/miarm.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/ARM3/miarm.h?r… ============================================================================== --- trunk/reactos/ntoskrnl/mm/ARM3/miarm.h [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/mm/ARM3/miarm.h [iso-8859-1] Sun Jun 28 09:43:12 2009 @@ -47,8 +47,10 @@ extern ULONG MmMaximumNonPagedPoolInBytes; extern PVOID MmNonPagedPoolStart; extern PVOID MmNonPagedPoolExpansionStart; +extern PVOID MmNonPagedPoolEnd; extern PMMPTE MmFirstReservedMappingPte, MmLastReservedMappingPte; extern PMMPTE MiFirstReservedZeroingPte; +extern MI_PFN_CACHE_ATTRIBUTE MiPlatformCacheAttributes[2][MmMaximumCacheType]; extern PPHYSICAL_MEMORY_DESCRIPTOR MmPhysicalMemoryBlock; VOID @@ -80,4 +82,27 @@ IN MMSYSTEM_PTE_POOL_TYPE SystemPtePoolType ); + +PFN_NUMBER +NTAPI +MiFindContiguousPages( + IN PFN_NUMBER LowestPfn, + IN PFN_NUMBER HighestPfn, + IN PFN_NUMBER BoundaryPfn, + IN PFN_NUMBER SizeInPages, + IN MEMORY_CACHING_TYPE CacheType +); + +PVOID +NTAPI +MiCheckForContiguousMemory( + IN PVOID BaseAddress, + IN PFN_NUMBER BaseAddressPages, + IN PFN_NUMBER SizeInPages, + IN PFN_NUMBER LowestPfn, + IN PFN_NUMBER HighestPfn, + IN PFN_NUMBER BoundaryPfn, + IN MI_PFN_CACHE_ATTRIBUTE CacheAttribute +); + /* EOF */ Removed: trunk/reactos/ntoskrnl/mm/cont.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/cont.c?rev=416… ============================================================================== --- trunk/reactos/ntoskrnl/mm/cont.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/mm/cont.c (removed) @@ -1,241 +1,0 @@ -/* - * COPYRIGHT: See COPYING in the top level directory - * PROJECT: ReactOS kernel - * FILE: ntoskrnl/mm/cont.c - * PURPOSE: Manages continuous memory - * - * PROGRAMMERS: David Welch (welch(a)cwcom.net) - */ - -/* INCLUDES *****************************************************************/ - -#include <ntoskrnl.h> -#define NDEBUG -#include <debug.h> - -/* FUNCTIONS *****************************************************************/ - -static VOID -MmFreeContinuousPage(PVOID Context, MEMORY_AREA* MemoryArea, PVOID Address, - PFN_TYPE Page, SWAPENTRY SwapEntry, - BOOLEAN Dirty) -{ - ASSERT(SwapEntry == 0); - if (Page != 0) - { - MmReleasePageMemoryConsumer(MC_NPPOOL, Page); - } -} - -/********************************************************************** - * NAME EXPORTED - * MmAllocateContiguousMemorySpecifyCache@32 - * - * DESCRIPTION - * Allocates a range of physically contiguous memory - * with a cache parameter. - * - * ARGUMENTS - * NumberOfBytes - * Size of the memory block to allocate; - * - * LowestAcceptableAddress - * Lowest address valid for the caller. - * - * HighestAcceptableAddress - * Highest address valid for the caller. - * - * BoundaryAddressMultiple - * Address multiple not to be crossed by allocated buffer (optional). - * - * CacheType - * Type of caching to use. - * - * RETURN VALUE - * The virtual address of the memory block on success; - * NULL on error. - * - * REVISIONS - * - * @implemented - */ -PVOID NTAPI -MmAllocateContiguousMemorySpecifyCache(IN SIZE_T NumberOfBytes, - IN PHYSICAL_ADDRESS LowestAcceptableAddress OPTIONAL, - IN PHYSICAL_ADDRESS HighestAcceptableAddress, - IN PHYSICAL_ADDRESS BoundaryAddressMultiple OPTIONAL, - IN MEMORY_CACHING_TYPE CacheType OPTIONAL) -{ - PMEMORY_AREA MArea; - NTSTATUS Status; - PVOID BaseAddress = NULL; - PFN_TYPE PBase; - ULONG Protect; - ULONG i; - - Protect = PAGE_EXECUTE_READWRITE | PAGE_SYSTEM; - if (CacheType == MmNonCached || CacheType == MmWriteCombined) - { - Protect |= PAGE_NOCACHE; - } - if (CacheType == MmWriteCombined) - { - Protect |= PAGE_WRITECOMBINE; - } - - MmLockAddressSpace(MmGetKernelAddressSpace()); - Status = MmCreateMemoryArea(MmGetKernelAddressSpace(), - MEMORY_AREA_CONTINUOUS_MEMORY, - &BaseAddress, - NumberOfBytes, - PAGE_READWRITE, - &MArea, - FALSE, - 0, - RtlConvertLongToLargeInteger(0)); - MmUnlockAddressSpace(MmGetKernelAddressSpace()); - - if (!NT_SUCCESS(Status)) - { - return(NULL); - } - DPRINT( "Base = %x\n", BaseAddress ); - PBase = MmGetContinuousPages(NumberOfBytes, - LowestAcceptableAddress, - HighestAcceptableAddress, - BoundaryAddressMultiple, - TRUE); - if (PBase == 0) - { - MmLockAddressSpace(MmGetKernelAddressSpace()); - MmFreeMemoryArea(MmGetKernelAddressSpace(), - MArea, - NULL, - NULL); - MmUnlockAddressSpace(MmGetKernelAddressSpace()); - return(NULL); - } - for (i = 0; i < (PAGE_ROUND_UP(NumberOfBytes) / PAGE_SIZE); i++, PBase++) - { - MmCreateVirtualMapping(NULL, - (char*)BaseAddress + (i * PAGE_SIZE), - Protect, - &PBase, - 1); - } - return(BaseAddress); -} - -/********************************************************************** - * NAME EXPORTED - * MmAllocateContiguousMemory@12 - * - * DESCRIPTION - * Allocates a range of physically contiguous cache aligned - * memory from the non-paged pool. - * - * ARGUMENTS - * NumberOfBytes - * Size of the memory block to allocate; - * - * HighestAcceptableAddress - * Highest address valid for the caller. - * - * RETURN VALUE - * The virtual address of the memory block on success; - * NULL on error. - * - * NOTE - * Description taken from include/ddk/mmfuncs.h. - * Code taken from ntoskrnl/mm/special.c. - * - * REVISIONS - * - * @implemented - */ -PVOID NTAPI -MmAllocateContiguousMemory (IN ULONG NumberOfBytes, - IN PHYSICAL_ADDRESS HighestAcceptableAddress) -{ - return MmAllocateContiguousMemorySpecifyCache(NumberOfBytes, - RtlConvertLongToLargeInteger(0), - HighestAcceptableAddress, - RtlConvertLongToLargeInteger(0), - MmCached); -} - - -/********************************************************************** - * NAME EXPORTED - * MmFreeContiguousMemory@4 - * - * DESCRIPTION - * Releases a range of physically contiguous memory allocated - * with MmAllocateContiguousMemory. - * - * ARGUMENTS - * BaseAddress - * Virtual address of the memory to be freed. - * - * RETURN VALUE - * None. - * - * NOTE - * Description taken from include/ddk/mmfuncs.h. - * Code taken from ntoskrnl/mm/special.c. - * - * REVISIONS - * - * @implemented - */ -VOID NTAPI -MmFreeContiguousMemory(IN PVOID BaseAddress) -{ - MmLockAddressSpace(MmGetKernelAddressSpace()); - MmFreeMemoryAreaByPtr(MmGetKernelAddressSpace(), - BaseAddress, - MmFreeContinuousPage, - NULL); - MmUnlockAddressSpace(MmGetKernelAddressSpace()); -} - -/********************************************************************** - * NAME EXPORTED - * MmFreeContiguousMemorySpecifyCache@12 - * - * DESCRIPTION - * Releases a range of physically contiguous memory allocated - * with MmAllocateContiguousMemorySpecifyCache. - * - * ARGUMENTS - * BaseAddress - * Virtual address of the memory to be freed. - * - * NumberOfBytes - * Size of the memory block to free. - * - * CacheType - * Type of caching used. - * - * RETURN VALUE - * None. - * - * REVISIONS - * - * @implemented - */ -VOID NTAPI -MmFreeContiguousMemorySpecifyCache(IN PVOID BaseAddress, - IN ULONG NumberOfBytes, - IN MEMORY_CACHING_TYPE CacheType) -{ - MmLockAddressSpace(MmGetKernelAddressSpace()); - MmFreeMemoryAreaByPtr(MmGetKernelAddressSpace(), - BaseAddress, - MmFreeContinuousPage, - NULL); - MmUnlockAddressSpace(MmGetKernelAddressSpace()); -} - - -/* EOF */ Modified: trunk/reactos/ntoskrnl/mm/freelist.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/freelist.c?rev… ============================================================================== --- trunk/reactos/ntoskrnl/mm/freelist.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/mm/freelist.c [iso-8859-1] Sun Jun 28 09:43:12 2009 @@ -18,6 +18,8 @@ #pragma alloc_text(INIT, MmInitializePageList) #endif +#define MODULE_INVOLVED_IN_ARM3 +#include "ARM3/miarm.h" /* TYPES *******************************************************************/ @@ -235,6 +237,206 @@ } KeReleaseQueuedSpinLock(LockQueuePfnLock, oldIrql); return 0; +} + +PFN_NUMBER +NTAPI +MiFindContiguousPages(IN PFN_NUMBER LowestPfn, + IN PFN_NUMBER HighestPfn, + IN PFN_NUMBER BoundaryPfn, + IN PFN_NUMBER SizeInPages, + IN MEMORY_CACHING_TYPE CacheType) +{ + PFN_NUMBER Page, PageCount, LastPage, Length, BoundaryMask; + ULONG i = 0; + PMMPFN Pfn1, EndPfn; + KIRQL OldIrql; + PAGED_CODE (); + ASSERT(SizeInPages != 0); + + // + // Convert the boundary PFN into an alignment mask + // + BoundaryMask = ~(BoundaryPfn - 1); + + // + // Loop all the physical memory blocks + // + do + { + // + // Capture the base page and length of this memory block + // + Page = MmPhysicalMemoryBlock->Run[i].BasePage; + PageCount = MmPhysicalMemoryBlock->Run[i].PageCount; + + // + // Check how far this memory block will go + // + LastPage = Page + PageCount; + + // + // Trim it down to only the PFNs we're actually interested in + // + if ((LastPage - 1) > HighestPfn) LastPage = HighestPfn + 1; + if (Page < LowestPfn) Page = LowestPfn; + + // + // Skip this run if it's empty or fails to contain all the pages we need + // + if (!(PageCount) || ((Page + SizeInPages) > LastPage)) continue; + + // + // Now scan all the relevant PFNs in this run + // + Length = 0; + for (Pfn1 = MiGetPfnEntry(Page); Page < LastPage; Page++, Pfn1++) + { + // + // If this PFN is in use, ignore it + // + if (Pfn1->Flags.Type != MM_PHYSICAL_PAGE_FREE) continue; + + // + // If we haven't chosen a start PFN yet and the caller specified an + // alignment, make sure the page matches the alignment restriction + // + if ((!(Length) && (BoundaryPfn)) && + (((Page ^ (Page + SizeInPages - 1)) & BoundaryMask))) + { + // + // It does not, so bail out + // + continue; + } + + // + // Increase the number of valid pages, and check if we have enough + // + if (++Length == SizeInPages) + { + // + // It appears we've amassed enough legitimate pages, rollback + // + Pfn1 -= (Length - 1); + Page -= (Length - 1); + + // + // Acquire the PFN lock + // + OldIrql = KeAcquireQueuedSpinLock(LockQueuePfnLock); + do + { + // + // Things might've changed for us. Is the page still free? + // + if (Pfn1->Flags.Type != MM_PHYSICAL_PAGE_FREE) break; + + // + // So far so good. Is this the last confirmed valid page? + // + if (!--Length) + { + // + // Sanity check that we didn't go out of bounds + // + ASSERT(i != MmPhysicalMemoryBlock->NumberOfRuns); + + // + // Loop until all PFN entries have been processed + // + EndPfn = Pfn1 - SizeInPages + 1; + do + { + // + // If this was an unzeroed page, there are now less + // + if (Pfn1->Flags.Zero == 0) UnzeroedPageCount--; + + // + // One less free page, one more system page + // + MmStats.NrFreePages--; + MmStats.NrSystemPages++; + + // + // This PFN is now a used page, set it up + // + RemoveEntryList(&Pfn1->ListEntry); + Pfn1->Flags.Type = MM_PHYSICAL_PAGE_USED; + Pfn1->Flags.Consumer = MC_NPPOOL; + Pfn1->ReferenceCount = 1; + Pfn1->LockCount = 0; + Pfn1->MapCount = 0; + Pfn1->SavedSwapEntry = 0; + + // + // Check if it was already zeroed + // + if (Pfn1->Flags.Zero == 0) + { + // + // It wasn't, so zero it + // + MiZeroPage(MiGetPfnEntryIndex(Pfn1)); + } + + // + // Check if this is the last PFN, otherwise go on + // + if (Pfn1 == EndPfn) break; + Pfn1--; + } while (TRUE); + + // + // Mark the first and last PFN so we can find them later + // + Pfn1->Flags.StartOfAllocation = 1; + (Pfn1 + SizeInPages - 1)->Flags.EndOfAllocation = 1; + + // + // Now it's safe to let go of the PFN lock + // + KeReleaseQueuedSpinLock(LockQueuePfnLock, OldIrql); + + // + // Quick sanity check that the last PFN is consistent + // + EndPfn = Pfn1 + SizeInPages; + ASSERT(EndPfn == MiGetPfnEntry(Page + 1)); + + // + // Compute the first page, and make sure it's consistent + // + Page -= SizeInPages - 1; + ASSERT(Pfn1 == MiGetPfnEntry(Page)); + ASSERT(Page != 0); + return Page; + } + + // + // Keep going. The purpose of this loop is to reconfirm that + // after acquiring the PFN lock these pages are still usable + // + Pfn1++; + Page++; + } while (TRUE); + + // + // If we got here, something changed while we hadn't acquired + // the PFN lock yet, so we'll have to restart + // + KeReleaseQueuedSpinLock(LockQueuePfnLock, OldIrql); + Length = 0; + } + } + } while (++i != MmPhysicalMemoryBlock->NumberOfRuns); + + + // + // And if we get here, it means no suitable physical memory runs were found + // + return 0; } PFN_TYPE Modified: trunk/reactos/ntoskrnl/ntoskrnl-generic.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ntoskrnl-generic.… ============================================================================== --- trunk/reactos/ntoskrnl/ntoskrnl-generic.rbuild [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/ntoskrnl-generic.rbuild [iso-8859-1] Sun Jun 28 09:43:12 2009 @@ -360,6 +360,7 @@ </directory> </if> <directory name="ARM3"> + <file>contmem.c</file> <file>dynamic.c</file> <file>hypermap.c</file> <file>init.c</file> @@ -370,7 +371,6 @@ </directory> <file>anonmem.c</file> <file>balance.c</file> - <file>cont.c</file> <file>dbgpool.c</file> <file>drvlck.c</file> <file>freelist.c</file>

1 0

[jimtabor] 41656: - Add more hooks, where wine has them placed. Fixed user32 hooks for win32k.
by jimtabor＠svn.reactos.org 28 Jun '09

28 Jun '09

Author: jimtabor Date: Sun Jun 28 07:02:15 2009 New Revision: 41656 URL: http://svn.reactos.org/svn/reactos?rev=41656&view=rev Log: - Add more hooks, where wine has them placed. Fixed user32 hooks for win32k. Modified: trunk/reactos/dll/win32/user32/windows/defwnd.c trunk/reactos/include/reactos/win32k/ntuser.h trunk/reactos/subsystems/win32/win32k/ntuser/defwnd.c trunk/reactos/subsystems/win32/win32k/ntuser/focus.c trunk/reactos/subsystems/win32/win32k/ntuser/winpos.c Modified: trunk/reactos/dll/win32/user32/windows/defwnd.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/d… ============================================================================== --- trunk/reactos/dll/win32/user32/windows/defwnd.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/user32/windows/defwnd.c [iso-8859-1] Sun Jun 28 07:02:15 2009 @@ -682,13 +682,13 @@ DeleteObject(DesktopRgn); } } -#if 0 - if (ISITHOOKED(WH_CBT)) +//#if 0 +// if (ISITHOOKED(WH_CBT)) { - if (NtUserMessageCall( hWnd, WM_SYSCOMMAND, wParam, (LPARAM)&sizingRect, 0, FNID_DEFWINDOWPROC, FALSE)) + if (NtUserMessageCall( hwnd, WM_CBT, HCBT_MOVESIZE, (LPARAM)&sizingRect, 0, FNID_DEFWINDOWPROC, FALSE)) moved = FALSE; } -#endif +//#endif (void)NtUserSetGUIThreadHandle(MSQ_STATE_MOVESIZE, NULL); SendMessageA( hwnd, WM_EXITSIZEMOVE, 0, 0 ); SendMessageA( hwnd, WM_SETVISIBLE, !IsIconic(hwnd), 0L); @@ -768,13 +768,15 @@ WINDOWPLACEMENT wp; POINT Pt; -#if 0 - if (ISITHOOKED(WH_CBT)) + if (!IsWindowEnabled( hWnd )) return 0; + +//#if 0 +// if (ISITHOOKED(WH_CBT)) { if (NtUserMessageCall( hWnd, WM_SYSCOMMAND, wParam, lParam, 0, FNID_DEFWINDOWPROC, FALSE)) return 0; } -#endif +//#endif switch (wParam & 0xfff0) { case SC_MOVE: @@ -806,8 +808,8 @@ } break; case SC_CLOSE: - SendMessageA(hWnd, WM_CLOSE, 0, 0); - break; + return SendMessageW(hWnd, WM_CLOSE, 0, 0); + case SC_MOUSEMENU: { Pt.x = (short)LOWORD(lParam); Modified: trunk/reactos/include/reactos/win32k/ntuser.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/reactos/win32k/ntu… ============================================================================== --- trunk/reactos/include/reactos/win32k/ntuser.h [iso-8859-1] (original) +++ trunk/reactos/include/reactos/win32k/ntuser.h [iso-8859-1] Sun Jun 28 07:02:15 2009 @@ -559,6 +559,7 @@ // #define WM_SYSTIMER 280 #define WM_POPUPSYSTEMMENU 787 +#define WM_CBT 1023 // ReactOS only. // // Non SDK DCE types. Modified: trunk/reactos/subsystems/win32/win32k/ntuser/defwnd.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/nt… ============================================================================== --- trunk/reactos/subsystems/win32/win32k/ntuser/defwnd.c [iso-8859-1] (original) +++ trunk/reactos/subsystems/win32/win32k/ntuser/defwnd.c [iso-8859-1] Sun Jun 28 07:02:15 2009 @@ -12,25 +12,6 @@ #define NDEBUG #include <debug.h> -LRESULT FASTCALL -IntDefWinHandleSysCommand( PWINDOW_OBJECT Window, WPARAM wParam, LPARAM lParam , BOOL Ansi) -{ - DPRINT1("hwnd %p WM_SYSCOMMAND %lx %lx\n", Window->hSelf, wParam, lParam ); - - if (!ISITHOOKED(WH_CBT)) return 0; - -// if (!UserCallNextHookEx(WH_CBT, HCBT_SYSCOMMAND, wParam, lParam, Ansi)) - return 0; - - switch (wParam & 0xfff0) - { - case SC_MOVE: - case SC_SIZE: - // return UserCallNextHookEx(WH_CBT, HCBT_MOVESIZE, (WPARAM)Window->hSelf, lParam, Ansi); - break; - } - return 1; -} /* Win32k counterpart of User DefWindowProc */ @@ -54,7 +35,9 @@ { case WM_SYSCOMMAND: { - lResult = IntDefWinHandleSysCommand( Window, wParam, lParam, Ansi ); + DPRINT1("hwnd %p WM_SYSCOMMAND %lx %lx\n", Window->hSelf, wParam, lParam ); + if (!ISITHOOKED(WH_CBT)) break; + lResult = co_HOOK_CallHooks(WH_CBT, HCBT_SYSCOMMAND, wParam, lParam); break; } case WM_SHOWWINDOW: @@ -76,8 +59,43 @@ } } break; + case WM_CBT: + { + if (!ISITHOOKED(WH_CBT)) break; + + switch (wParam) + { + case HCBT_MOVESIZE: + { + RECTL rt; + + if (lParam) + { + _SEH2_TRY + { + ProbeForRead((PVOID)lParam, + sizeof(RECT), + 1); + + RtlCopyMemory(&rt, + (PVOID)lParam, + sizeof(RECT)); + } + _SEH2_EXCEPT(EXCEPTION_EXECUTE_HANDLER) + { + lResult = 1; + } + _SEH2_END; + } + if (!lResult) + lResult = co_HOOK_CallHooks(WH_CBT, HCBT_MOVESIZE, (WPARAM)Window->hSelf, lParam ? (LPARAM)&rt : 0); + } + break; + } + break; + } + break; } - return lResult; } Modified: trunk/reactos/subsystems/win32/win32k/ntuser/focus.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/nt… ============================================================================== --- trunk/reactos/subsystems/win32/win32k/ntuser/focus.c [iso-8859-1] (original) +++ trunk/reactos/subsystems/win32/win32k/ntuser/focus.c [iso-8859-1] Sun Jun 28 07:02:15 2009 @@ -320,6 +320,7 @@ HWND hWndPrev; HWND hWnd = 0; PWINDOW Wnd; + CBTACTIVATESTRUCT cbt; if (Window) ASSERT_REFS_CO(Window); @@ -346,7 +347,11 @@ return hWndPrev; } - /* FIXME: Call hooks. */ + /* call CBT hook chain */ + cbt.fMouse = FALSE; + cbt.hWndActive = hWndPrev; + if (co_HOOK_CallHooks( WH_CBT, HCBT_ACTIVATE, (WPARAM)hWnd, (LPARAM)&cbt)) + return 0; ThreadQueue->ActiveWindow = hWnd; @@ -382,6 +387,9 @@ return hWndPrev; } + if (co_HOOK_CallHooks( WH_CBT, HCBT_SETFOCUS, (WPARAM)Window->hSelf, (LPARAM)hWndPrev)) + return 0; + ThreadQueue->FocusWindow = Window->hSelf; co_IntSendKillFocusMessages(hWndPrev, Window->hSelf); @@ -390,6 +398,9 @@ else { ThreadQueue->FocusWindow = 0; + + if (co_HOOK_CallHooks( WH_CBT, HCBT_SETFOCUS, (WPARAM)0, (LPARAM)hWndPrev)) + return 0; co_IntSendKillFocusMessages(hWndPrev, 0); } Modified: trunk/reactos/subsystems/win32/win32k/ntuser/winpos.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/nt… ============================================================================== --- trunk/reactos/subsystems/win32/win32k/ntuser/winpos.c [iso-8859-1] (original) +++ trunk/reactos/subsystems/win32/win32k/ntuser/winpos.c [iso-8859-1] Sun Jun 28 07:02:15 2009 @@ -307,6 +307,9 @@ Size.x = Wnd->WindowRect.left; Size.y = Wnd->WindowRect.top; WinPosInitInternalPos(Window, &Size, &Wnd->WindowRect); + + if (co_HOOK_CallHooks( WH_CBT, HCBT_MINMAX, (WPARAM)Window->hSelf, ShowFlag)) + return SWP_NOSIZE | SWP_NOMOVE; if (Wnd->Style & WS_MINIMIZE) {

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs