Ros-diffs

ros-diffs@reactos.org

81390 discussions

[fireball] 39623: - Add declarations for unsafe fastmutex functions.
by fireball＠svn.reactos.org 16 Feb '09

16 Feb '09

Author: fireball Date: Mon Feb 16 06:10:08 2009 New Revision: 39623 URL: http://svn.reactos.org/svn/reactos?rev=39623&view=rev Log: - Add declarations for unsafe fastmutex functions. Modified: trunk/reactos/include/ddk/wdm.h Modified: trunk/reactos/include/ddk/wdm.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/ddk/wdm.h?rev=3962… ============================================================================== --- trunk/reactos/include/ddk/wdm.h [iso-8859-1] (original) +++ trunk/reactos/include/ddk/wdm.h [iso-8859-1] Mon Feb 16 06:10:08 2009 @@ -2464,6 +2464,18 @@ IN OUT PFAST_MUTEX FastMutex); NTKERNELAPI +VOID +FASTCALL +ExAcquireFastMutexUnsafe( + IN OUT PFAST_MUTEX FastMutex); + +NTKERNELAPI +VOID +FASTCALL +ExReleaseFastMutexUnsafe( + IN OUT PFAST_MUTEX FastMutex); + +NTKERNELAPI BOOLEAN NTAPI ExAcquireResourceExclusiveLite(

1 0

[dchapyshev] 39622: - Reimplement RtlLargeIntegerToChar (based on Wine code with my changes). It fixes all large_int Wine tests
by dchapyshev＠svn.reactos.org 16 Feb '09

16 Feb '09

Author: dchapyshev Date: Mon Feb 16 06:07:27 2009 New Revision: 39622 URL: http://svn.reactos.org/svn/reactos?rev=39622&view=rev Log: - Reimplement RtlLargeIntegerToChar (based on Wine code with my changes). It fixes all large_int Wine tests Modified: trunk/reactos/lib/rtl/unicode.c Modified: trunk/reactos/lib/rtl/unicode.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/rtl/unicode.c?rev=3962… ============================================================================== --- trunk/reactos/lib/rtl/unicode.c [iso-8859-1] (original) +++ trunk/reactos/lib/rtl/unicode.c [iso-8859-1] Mon Feb 16 06:07:27 2009 @@ -1559,56 +1559,56 @@ IN ULONG Length, IN OUT PCHAR String) { - NTSTATUS Status = STATUS_SUCCESS; - ULONG Radix; - CHAR temp[65]; - ULONGLONG v = Value->QuadPart; - ULONG i; - PCHAR tp; - PCHAR sp; - - Radix = Base; - if (Radix == 0) - Radix = 10; - - if ((Radix != 2) && (Radix != 8) && - (Radix != 10) && (Radix != 16)) - return STATUS_INVALID_PARAMETER; - - tp = temp; - while (v || tp == temp) - { - i = v % Radix; - v = v / Radix; - if (i < 10) - *tp = i + '0'; - else - *tp = i + 'A' - 10; - tp++; - } - - if ((ULONG)((ULONG_PTR)tp - (ULONG_PTR)temp) > Length) - return STATUS_BUFFER_OVERFLOW; - - //_SEH2_TRY - { - sp = String; - while (tp > temp) - *sp++ = *--tp; - - if((ULONG)((ULONG_PTR)sp - (ULONG_PTR)String) < Length) - *sp = 0; - } -#if 0 - _SEH2_EXCEPT(EXCEPTION_EXECUTE_HANDLER) - { - /* Get the error code */ - Status = _SEH2_GetExceptionCode(); - } - _SEH2_END; -#endif - - return Status; + ULONGLONG Val = Value->QuadPart; + NTSTATUS Status = STATUS_SUCCESS; + CHAR Buffer[65]; + CHAR Digit; + ULONG Len; + PCHAR Pos; + + if (Base == 0) Base = 10; + + if ((Base != 2) && (Base != 8) && + (Base != 10) && (Base != 16)) + { + return STATUS_INVALID_PARAMETER; + } + + Pos = &Buffer[64]; + *Pos = '\0'; + + do + { + Pos--; + Digit = Val % Base; + Val = Val / Base; + if (Digit < 10) + *Pos = '0' + Digit; + else + *Pos = 'A' + Digit - 10; + } + while (Val != 0L); + + Len = &Buffer[64] - Pos; + + if (Len > Length) + return STATUS_BUFFER_OVERFLOW; + + _SEH2_TRY + { + if (Len == Length) + RtlCopyMemory(String, Pos, Len); + else + RtlCopyMemory(String, Pos, Len + 1); + } + _SEH2_EXCEPT(EXCEPTION_EXECUTE_HANDLER) + { + /* Get the error code */ + Status = _SEH2_GetExceptionCode(); + } + _SEH2_END; + + return Status; } /*

1 0

[fireball] 39621: - Fix small formatting leftover from r39422.
by fireball＠svn.reactos.org 16 Feb '09

16 Feb '09

Author: fireball Date: Mon Feb 16 05:18:37 2009 New Revision: 39621 URL: http://svn.reactos.org/svn/reactos?rev=39621&view=rev Log: - Fix small formatting leftover from r39422. Modified: trunk/reactos/ntoskrnl/config/cmkcbncb.c Modified: trunk/reactos/ntoskrnl/config/cmkcbncb.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/config/cmkcbncb.c… ============================================================================== --- trunk/reactos/ntoskrnl/config/cmkcbncb.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/config/cmkcbncb.c [iso-8859-1] Mon Feb 16 05:18:37 2009 @@ -196,7 +196,7 @@ Ncb = CONTAINING_RECORD(HashEntry, CM_NAME_CONTROL_BLOCK, NameHash); /* Check if the hash matches */ - if (ConvKey == HashEntry->ConvKey && Length == Ncb->NameLength) + if ((ConvKey == HashEntry->ConvKey) && (Length == Ncb->NameLength)) { /* Assume success */ Found = TRUE;

1 0

[dchapyshev] 39620: - Fix copypaste typo in IopUpdateOperationCount
by dchapyshev＠svn.reactos.org 16 Feb '09

16 Feb '09

Author: dchapyshev Date: Mon Feb 16 05:02:23 2009 New Revision: 39620 URL: http://svn.reactos.org/svn/reactos?rev=39620&view=rev Log: - Fix copypaste typo in IopUpdateOperationCount Modified: trunk/reactos/ntoskrnl/include/internal/io_x.h Modified: trunk/reactos/ntoskrnl/include/internal/io_x.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/include/internal/… ============================================================================== --- trunk/reactos/ntoskrnl/include/internal/io_x.h [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/include/internal/io_x.h [iso-8859-1] Mon Feb 16 05:02:23 2009 @@ -75,13 +75,13 @@ { /* Increase write count */ IoWriteOperationCount++; - CountToChange = &PsGetCurrentProcess()->ReadOperationCount; + CountToChange = &PsGetCurrentProcess()->WriteOperationCount; } else { /* Increase other count */ IoOtherOperationCount++; - CountToChange = &PsGetCurrentProcess()->ReadOperationCount; + CountToChange = &PsGetCurrentProcess()->OtherOperationCount; } /* Increase the process-wide count */

1 0

[mkupfer] 39619: define IDC_STATIC as -1 instead of 100 (prevent confusing warnings)
by mkupfer＠svn.reactos.org 16 Feb '09

16 Feb '09

Author: mkupfer Date: Mon Feb 16 04:10:44 2009 New Revision: 39619 URL: http://svn.reactos.org/svn/reactos?rev=39619&view=rev Log: define IDC_STATIC as -1 instead of 100 (prevent confusing warnings) Modified: trunk/reactos/subsystems/win32/csrss/win32csr/resource.h Modified: trunk/reactos/subsystems/win32/csrss/win32csr/resource.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/csrss/win… ============================================================================== --- trunk/reactos/subsystems/win32/csrss/win32csr/resource.h [iso-8859-1] (original) +++ trunk/reactos/subsystems/win32/csrss/win32csr/resource.h [iso-8859-1] Mon Feb 16 04:10:44 2009 @@ -13,7 +13,7 @@ #define IDD_NOT_RESPONDING 11 #define IDD_SWITCH_APP 12 -#define IDC_STATIC 100 +#define IDC_STATIC -1 #define IDC_PROGRESS 101 #define IDC_END_NOW 102 #define IDC_STATIC_CUR_APP 103

1 0

[jmorlan] 39618: SET /A improvements: - Strip quotes from expression - Use _tcstol instead of _ttoi to parse numbers, allowing hex/octal numbers to be used - Skip space after an identifier - Don't echo result when in a batch file
by jmorlan＠svn.reactos.org 16 Feb '09

16 Feb '09

Author: jmorlan Date: Sun Feb 15 21:00:27 2009 New Revision: 39618 URL: http://svn.reactos.org/svn/reactos?rev=39618&view=rev Log: SET /A improvements: - Strip quotes from expression - Use _tcstol instead of _ttoi to parse numbers, allowing hex/octal numbers to be used - Skip space after an identifier - Don't echo result when in a batch file Modified: trunk/reactos/base/shell/cmd/set.c Modified: trunk/reactos/base/shell/cmd/set.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/shell/cmd/set.c?rev=3… ============================================================================== --- trunk/reactos/base/shell/cmd/set.c [iso-8859-1] (original) +++ trunk/reactos/base/shell/cmd/set.c [iso-8859-1] Sun Feb 15 21:00:27 2009 @@ -106,7 +106,9 @@ /* the /A does *NOT* have to be followed by a whitespace */ if ( !_tcsnicmp (param, _T("/A"), 2) ) { - BOOL Success = seta_eval ( skip_ws(param+2) ); + BOOL Success; + StripQuotes(param); + Success = seta_eval ( skip_ws(param+2) ); if(!Success) { /*might seem random but this is what windows xp does */ @@ -230,7 +232,7 @@ *result = 0; return FALSE; } - *result = _ttoi ( identVal ); + *result = _tcstol ( identVal, NULL, 0 ); return TRUE; } @@ -283,18 +285,16 @@ p = skip_ws ( p + 1 ); if ( !seta_stmt ( &p, &rval ) ) return FALSE; - if ( *p != _T(')') ) + if ( *p++ != _T(')') ) { ConErrResPuts ( STRING_EXPECTED_CLOSE_PAREN ); return FALSE; } *result = rval; - p = skip_ws ( p + 1 ); } else if ( isdigit(*p) ) { - *result = _ttoi ( p ); - p = skip_ws ( p + _tcsspn ( p, _T("1234567890") ) ); + *result = _tcstol ( p, (LPTSTR *)&p, 0 ); } else if ( __iscsymf(*p) ) { @@ -309,7 +309,7 @@ ConErrResPuts ( STRING_EXPECTED_NUMBER_OR_VARIABLE ); return FALSE; } - *p_ = p; + *p_ = skip_ws ( p ); return TRUE; } @@ -447,6 +447,7 @@ PARSE_IDENT(ident,identlen,p); if ( identlen ) { + p = skip_ws(p); if ( *p == _T('=') ) op = *p, p = skip_ws(p+1); else if ( _tcschr ( _T("*/%+-&^|"), *p ) && p[1] == _T('=') ) @@ -531,7 +532,8 @@ } if ( !seta_stmt ( &p, &rval ) ) return FALSE; - ConOutPrintf ( _T("%i"), rval ); + if ( !bc ) + ConOutPrintf ( _T("%i"), rval ); return TRUE; }

1 0

[khornicek] 39617: - add more pixel formats
by khornicek＠svn.reactos.org 15 Feb '09

15 Feb '09

Author: khornicek Date: Sun Feb 15 16:32:41 2009 New Revision: 39617 URL: http://svn.reactos.org/svn/reactos?rev=39617&view=rev Log: - add more pixel formats Modified: branches/reactx/reactos/dll/win32/gdi32/misc/gdientryhelgl.c Modified: branches/reactx/reactos/dll/win32/gdi32/misc/gdientryhelgl.c URL: http://svn.reactos.org/svn/reactos/branches/reactx/reactos/dll/win32/gdi32/… ============================================================================== --- branches/reactx/reactos/dll/win32/gdi32/misc/gdientryhelgl.c [iso-8859-1] (original) +++ branches/reactx/reactos/dll/win32/gdi32/misc/gdientryhelgl.c [iso-8859-1] Sun Feb 15 16:32:41 2009 @@ -197,9 +197,13 @@ WINAPI DdUnlock(LPDDHAL_UNLOCKDATA Unlock) { + /* Fixme for opengl hel emulations */ + HEL_OGL_STUB; +#if 0 /* Call win32k */ return NtGdiDdUnlock((HANDLE)Unlock->lpDDSurface->hDDSurface, (PDD_UNLOCKDATA)Unlock); +#endif } /* @@ -1648,6 +1652,28 @@ switch(WineD3DFormat) { + case WINED3DFMT_P8: + ddpf->dwFlags |= DDPF_PALETTEINDEXED8; + ddpf->dwRGBBitCount = 8; + ddpf->dwRBitMask = 0x00000000; + ddpf->dwGBitMask = 0x00000000; + ddpf->dwBBitMask = 0x00000000; + break; + + case WINED3DFMT_R5G6B5: + ddpf->dwRGBBitCount = 16; + ddpf->dwRBitMask = 0x0000f800; + ddpf->dwGBitMask = 0x000007e0; + ddpf->dwBBitMask = 0x0000001f; + break; + + case WINED3DFMT_R8G8B8: + ddpf->dwRGBBitCount = 24; + ddpf->dwRBitMask = 0x00ff0000; + ddpf->dwGBitMask = 0x0000ff00; + ddpf->dwBBitMask = 0x000000ff; + break; + case WINED3DFMT_X8R8G8B8: ddpf->dwRGBBitCount = 32; ddpf->dwRBitMask = 0x00ff0000; @@ -1852,6 +1878,12 @@ /* Convert all the data */ pHalInfo->dwSize = sizeof(DDHALINFO); + + if(!pD3DDevice) + { + CreateWineD3DDevice(pDirectDrawGlobal); + pD3DDevice = (IWineD3DDevice*) pDirectDrawGlobal->dwUnused3; + } IWineD3DDevice_GetDisplayMode(pD3DDevice, 0, &Mode); GetPixelFormatData(&pHalInfo->vmiData.ddpfDisplay, Mode.Format);

1 0

[arty] 39616: Remove an assert that doesn't belong.
by arty＠svn.reactos.org 15 Feb '09

15 Feb '09

Author: arty Date: Sun Feb 15 16:16:20 2009 New Revision: 39616 URL: http://svn.reactos.org/svn/reactos?rev=39616&view=rev Log: Remove an assert that doesn't belong. Modified: trunk/reactos/lib/drivers/ip/network/address.c Modified: trunk/reactos/lib/drivers/ip/network/address.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/drivers/ip/network/add… ============================================================================== --- trunk/reactos/lib/drivers/ip/network/address.c [iso-8859-1] (original) +++ trunk/reactos/lib/drivers/ip/network/address.c [iso-8859-1] Sun Feb 15 16:16:20 2009 @@ -223,7 +223,6 @@ { if (Address1->Type != Address2->Type) { DbgPrint("AddrIsEqual: Unequal Address Types\n"); - ASSERT(FALSE); return FALSE; }

1 0

[tkreuzer] 39615: - switch license to LGPL - fix a typo
by tkreuzer＠svn.reactos.org 15 Feb '09

15 Feb '09

Author: tkreuzer Date: Sun Feb 15 16:15:15 2009 New Revision: 39615 URL: http://svn.reactos.org/svn/reactos?rev=39615&view=rev Log: - switch license to LGPL - fix a typo Modified: trunk/reactos/subsystems/win32/win32k/eng/i386/floatobj.S Modified: trunk/reactos/subsystems/win32/win32k/eng/i386/floatobj.S URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/en… ============================================================================== --- trunk/reactos/subsystems/win32/win32k/eng/i386/floatobj.S [iso-8859-1] (original) +++ trunk/reactos/subsystems/win32/win32k/eng/i386/floatobj.S [iso-8859-1] Sun Feb 15 16:15:15 2009 @@ -1,5 +1,5 @@ /* - * COPYRIGHT: See COPYING in the top level directory + * COPYRIGHT: LGPL, see LGPL.txt in the top level directory * PROJECT: ReactOS Win32 subsystem * PURPOSE: FLOATOBJ floating point emulation functions for x86 * FILE: subsystems/win32/win32k/objects/i386/floatobj.S @@ -33,7 +33,7 @@ * Optimization notes: * * - shld is slow (4 cycles) and not pairable, mov + shl is faster - * - esp is used, beacuse it's available earlier + * - esp is used, because it's available earlier * - bsr is very slow on old cpus (up to 72 cycles on a p1) while being much * faster on modern cpus (2-11 cycles). Workarounds using branch trees or * table lookups are of no use nowadays.

1 0

[tkreuzer] 39614: Add a header
by tkreuzer＠svn.reactos.org 15 Feb '09

15 Feb '09

Author: tkreuzer Date: Sun Feb 15 16:14:32 2009 New Revision: 39614 URL: http://svn.reactos.org/svn/reactos?rev=39614&view=rev Log: Add a header Modified: trunk/reactos/tools/hpp/hpp.c Modified: trunk/reactos/tools/hpp/hpp.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/tools/hpp/hpp.c?rev=39614&… ============================================================================== --- trunk/reactos/tools/hpp/hpp.c [iso-8859-1] (original) +++ trunk/reactos/tools/hpp/hpp.c [iso-8859-1] Sun Feb 15 16:14:32 2009 @@ -1,3 +1,11 @@ +/* + * COPYRIGHT: See COPYING in the top level directory + * PROJECT: Header preprocessor + * PURPOSE: Generates header files from other header files + * PROGRAMMER; Timo Kreuzer + * + */ + #include <stdio.h> #include <stdlib.h> #include <stdarg.h>

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs