Ros-diffs

ros-diffs@reactos.org

81390 discussions

[cwittich] 38933: Use "Small Fonts" (96 dpi) by default patch by <aspotashev at gmail dot com> See issue #4011 for more details.
by cwittich＠svn.reactos.org 19 Jan '09

19 Jan '09

Author: cwittich Date: Mon Jan 19 04:51:58 2009 New Revision: 38933 URL: http://svn.reactos.org/svn/reactos?rev=38933&view=rev Log: Use "Small Fonts" (96 dpi) by default patch by <aspotashev at gmail dot com> See issue #4011 for more details. Modified: trunk/reactos/subsystems/win32/win32k/objects/freetype.c Modified: trunk/reactos/subsystems/win32/win32k/objects/freetype.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/ob… ============================================================================== --- trunk/reactos/subsystems/win32/win32k/objects/freetype.c [iso-8859-1] (original) +++ trunk/reactos/subsystems/win32/win32k/objects/freetype.c [iso-8859-1] Mon Jan 19 04:51:58 2009 @@ -644,8 +644,8 @@ TM->tmWeight = pOS2->usWeightClass; TM->tmOverhang = 0; - TM->tmDigitizedAspectX = 300; - TM->tmDigitizedAspectY = 300; + TM->tmDigitizedAspectX = 96; + TM->tmDigitizedAspectY = 96; TM->tmFirstChar = pOS2->usFirstCharIndex; TM->tmLastChar = pOS2->usLastCharIndex; TM->tmDefaultChar = pOS2->usDefaultChar;

1 0

[cwittich] 38932: don't let VirtualProtect play with not committed memory
by cwittich＠svn.reactos.org 19 Jan '09

19 Jan '09

Author: cwittich Date: Mon Jan 19 04:27:59 2009 New Revision: 38932 URL: http://svn.reactos.org/svn/reactos?rev=38932&view=rev Log: don't let VirtualProtect play with not committed memory Modified: trunk/reactos/ntoskrnl/mm/anonmem.c Modified: trunk/reactos/ntoskrnl/mm/anonmem.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/anonmem.c?rev=… ============================================================================== --- trunk/reactos/ntoskrnl/mm/anonmem.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/mm/anonmem.c [iso-8859-1] Mon Jan 19 04:27:59 2009 @@ -1028,11 +1028,20 @@ Region = MmFindRegion(MemoryArea->StartingAddress, &MemoryArea->Data.VirtualMemoryData.RegionListHead, BaseAddress, NULL); - *OldProtect = Region->Protect; - Status = MmAlterRegion(AddressSpace, MemoryArea->StartingAddress, - &MemoryArea->Data.VirtualMemoryData.RegionListHead, - BaseAddress, Length, Region->Type, Protect, - MmModifyAttributes); + if (Region->Type == MEM_COMMIT) + { + /* FIXME: check if the whole range is committed + * before altering the memory */ + *OldProtect = Region->Protect; + Status = MmAlterRegion(AddressSpace, MemoryArea->StartingAddress, + &MemoryArea->Data.VirtualMemoryData.RegionListHead, + BaseAddress, Length, Region->Type, Protect, + MmModifyAttributes); + } + else + { + Status = STATUS_NOT_COMMITTED; + } return(Status); }

1 0

[cwittich] 38931: fix typo (spotted by Ged)
by cwittich＠svn.reactos.org 19 Jan '09

19 Jan '09

Author: cwittich Date: Mon Jan 19 03:22:59 2009 New Revision: 38931 URL: http://svn.reactos.org/svn/reactos?rev=38931&view=rev Log: fix typo (spotted by Ged) Modified: trunk/reactos/ntoskrnl/mm/anonmem.c Modified: trunk/reactos/ntoskrnl/mm/anonmem.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/anonmem.c?rev=… ============================================================================== --- trunk/reactos/ntoskrnl/mm/anonmem.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/mm/anonmem.c [iso-8859-1] Mon Jan 19 03:22:59 2009 @@ -569,7 +569,7 @@ Protect); /* Check for valid protection flags */ - if ((!Protect & PAGE_FLAGS_VALID_FROM_USER_MODE)) + if (!(Protect & PAGE_FLAGS_VALID_FROM_USER_MODE)) { DPRINT1("Invalid page protection\n"); return STATUS_INVALID_PAGE_PROTECTION;

1 0

[cwittich] 38930: trim leading zeros in GetNumberFormat patch by <zooba at aanet dot com dot au> See issue #3400 for more details.
by cwittich＠svn.reactos.org 19 Jan '09

19 Jan '09

Author: cwittich Date: Mon Jan 19 03:04:56 2009 New Revision: 38930 URL: http://svn.reactos.org/svn/reactos?rev=38930&view=rev Log: trim leading zeros in GetNumberFormat patch by <zooba at aanet dot com dot au> See issue #3400 for more details. Modified: trunk/reactos/dll/win32/kernel32/misc/lcformat.c Modified: trunk/reactos/dll/win32/kernel32/misc/lcformat.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/misc/lc… ============================================================================== --- trunk/reactos/dll/win32/kernel32/misc/lcformat.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/kernel32/misc/lcformat.c [iso-8859-1] Mon Jan 19 03:04:56 2009 @@ -1013,6 +1013,7 @@ WCHAR szNegBuff[8]; const WCHAR *lpszNeg = NULL, *lpszNegStart, *szSrc; DWORD dwState = 0, dwDecimals = 0, dwGroupCount = 0, dwCurrentGroupCount = 0; + DWORD dwLeadingZeros = 0; INT iRet; TRACE("(0x%04lx,0x%08lx,%S,%p,%p,%d)\n", lcid, dwFlags, lpszValue, @@ -1063,7 +1064,11 @@ /* Check the number for validity */ while (*szSrc) { - if (*szSrc >= '0' && *szSrc <= '9') + if (*szSrc == '0' && !(dwState & NF_DIGITS)) + { + dwLeadingZeros++; + } + else if ((*szSrc >= '1' && *szSrc <= '9') || (*szSrc == '0' && (dwState & NF_DIGITS))) { dwState |= NF_DIGITS; if (dwState & NF_ISREAL) @@ -1176,7 +1181,7 @@ dwGroupCount = lpFormat->Grouping == 32 ? 3 : lpFormat->Grouping; /* Write the remaining whole number digits, including grouping chars */ - while (szSrc >= lpszValue && *szSrc >= '0' && *szSrc <= '9') + while (szSrc >= (lpszValue + dwLeadingZeros) && *szSrc >= '0' && *szSrc <= '9') { if (dwState & NF_ROUND) { @@ -1194,7 +1199,7 @@ dwState |= NF_DIGITS_OUT; dwCurrentGroupCount++; - if (szSrc >= lpszValue && dwCurrentGroupCount == dwGroupCount && *szSrc != '-') + if (szSrc >= (lpszValue + dwLeadingZeros) && dwCurrentGroupCount == dwGroupCount && *szSrc != '-') { LPWSTR lpszGrp = lpFormat->lpThousandSep + strlenW(lpFormat->lpThousandSep) - 1;

1 0

[cwittich] 38929: fix some more kernel32 virtual tests
by cwittich＠svn.reactos.org 19 Jan '09

19 Jan '09

Author: cwittich Date: Mon Jan 19 02:35:51 2009 New Revision: 38929 URL: http://svn.reactos.org/svn/reactos?rev=38929&view=rev Log: fix some more kernel32 virtual tests Modified: trunk/reactos/ntoskrnl/mm/section.c Modified: trunk/reactos/ntoskrnl/mm/section.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/section.c?rev=… ============================================================================== --- trunk/reactos/ntoskrnl/mm/section.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/mm/section.c [iso-8859-1] Mon Jan 19 02:35:51 2009 @@ -4538,13 +4538,10 @@ ASSERT(Process); - if (Protect != PAGE_READONLY && - Protect != PAGE_READWRITE && - Protect != PAGE_WRITECOPY && - Protect != PAGE_EXECUTE && - Protect != PAGE_EXECUTE_READ && - Protect != PAGE_EXECUTE_READWRITE && - Protect != PAGE_EXECUTE_WRITECOPY) + if (!(Protect & (PAGE_READONLY | PAGE_READWRITE | + PAGE_WRITECOPY | PAGE_EXECUTE | + PAGE_EXECUTE_READ | PAGE_EXECUTE_READWRITE | + PAGE_EXECUTE_WRITECOPY | PAGE_NOACCESS))) { return STATUS_INVALID_PAGE_PROTECTION; }

1 0

[cwittich] 38928: fix some kernel32 virtual winetests
by cwittich＠svn.reactos.org 19 Jan '09

19 Jan '09

Author: cwittich Date: Mon Jan 19 02:02:26 2009 New Revision: 38928 URL: http://svn.reactos.org/svn/reactos?rev=38928&view=rev Log: fix some kernel32 virtual winetests Modified: trunk/reactos/ntoskrnl/mm/anonmem.c Modified: trunk/reactos/ntoskrnl/mm/anonmem.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/anonmem.c?rev=… ============================================================================== --- trunk/reactos/ntoskrnl/mm/anonmem.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/mm/anonmem.c [iso-8859-1] Mon Jan 19 02:02:26 2009 @@ -569,7 +569,7 @@ Protect); /* Check for valid protection flags */ - if ((Protect & PAGE_FLAGS_VALID_FROM_USER_MODE) != Protect) + if ((!Protect & PAGE_FLAGS_VALID_FROM_USER_MODE)) { DPRINT1("Invalid page protection\n"); return STATUS_INVALID_PAGE_PROTECTION; @@ -944,6 +944,12 @@ "*PRegionSize %x, FreeType %x)\n",ProcessHandle,*PBaseAddress, *PRegionSize,FreeType); + if (!(FreeType & (MEM_RELEASE | MEM_DECOMMIT))) + { + DPRINT1("Invalid FreeType\n"); + return STATUS_INVALID_PARAMETER_4; + } + BaseAddress = (PVOID)PAGE_ROUND_DOWN((*PBaseAddress)); RegionSize = PAGE_ROUND_UP((ULONG_PTR)(*PBaseAddress) + (*PRegionSize)) - PAGE_ROUND_DOWN((*PBaseAddress));

1 0

[cwittich] 38927: fix handle leaks
by cwittich＠svn.reactos.org 19 Jan '09

19 Jan '09

Author: cwittich Date: Sun Jan 18 23:08:11 2009 New Revision: 38927 URL: http://svn.reactos.org/svn/reactos?rev=38927&view=rev Log: fix handle leaks Modified: trunk/rostests/rosautotest/winetests.c Modified: trunk/rostests/rosautotest/winetests.c URL: http://svn.reactos.org/svn/reactos/trunk/rostests/rosautotest/winetests.c?r… ============================================================================== --- trunk/rostests/rosautotest/winetests.c [iso-8859-1] (original) +++ trunk/rostests/rosautotest/winetests.c [iso-8859-1] Sun Jan 18 23:08:11 2009 @@ -116,6 +116,10 @@ } } while(!BreakLoop); + + /* Close the process handles */ + CloseHandle(ProcessInfo.hProcess); + CloseHandle(ProcessInfo.hThread); if(AppOptions.Submit) { @@ -216,6 +220,10 @@ StringOut("WaitForSingleObject failed for the test list\n"); return FALSE; } + + /* Close the process handles */ + CloseHandle(ProcessInfo.hProcess); + CloseHandle(ProcessInfo.hThread); /* Read the output data into a buffer */ if(!PeekNamedPipe(hReadPipe, NULL, 0, NULL, &BytesAvailable, NULL))

1 0

[cwittich] 38926: hack: skipping RegisterWaitForSingleObject tests as they don't finish
by cwittich＠svn.reactos.org 19 Jan '09

19 Jan '09

Author: cwittich Date: Sun Jan 18 22:20:06 2009 New Revision: 38926 URL: http://svn.reactos.org/svn/reactos?rev=38926&view=rev Log: hack: skipping RegisterWaitForSingleObject tests as they don't finish Modified: trunk/rostests/winetests/kernel32/thread.c Modified: trunk/rostests/winetests/kernel32/thread.c URL: http://svn.reactos.org/svn/reactos/trunk/rostests/winetests/kernel32/thread… ============================================================================== --- trunk/rostests/winetests/kernel32/thread.c [iso-8859-1] (original) +++ trunk/rostests/winetests/kernel32/thread.c [iso-8859-1] Sun Jan 18 22:20:06 2009 @@ -979,6 +979,9 @@ return; } + skip("ROS-HACK: Skipping RegisterWaitForSingleObject tests\n"); + return; + /* test signaled case */ handle = CreateEvent(NULL, TRUE, TRUE, NULL);

1 0

[jimtabor] 38925: - Add QS_RAWINPUT.
by jimtabor＠svn.reactos.org 19 Jan '09

19 Jan '09

Author: jimtabor Date: Sun Jan 18 18:03:51 2009 New Revision: 38925 URL: http://svn.reactos.org/svn/reactos?rev=38925&view=rev Log: - Add QS_RAWINPUT. Modified: trunk/reactos/include/psdk/winuser.h Modified: trunk/reactos/include/psdk/winuser.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/psdk/winuser.h?rev… ============================================================================== --- trunk/reactos/include/psdk/winuser.h [iso-8859-1] (original) +++ trunk/reactos/include/psdk/winuser.h [iso-8859-1] Sun Jan 18 18:03:51 2009 @@ -840,6 +840,7 @@ #if (_WIN32_WINNT >= 0x0501) #define QS_ALLEVENTS 1215 #define QS_ALLINPUT 1279 +#define QS_RAWINPUT 1024 #else #define QS_ALLEVENTS 191 #define QS_ALLINPUT 255

1 0

[sginsberg] 38924: - Fix a comment
by sginsberg＠svn.reactos.org 18 Jan '09

18 Jan '09

Author: sginsberg Date: Sun Jan 18 17:53:22 2009 New Revision: 38924 URL: http://svn.reactos.org/svn/reactos?rev=38924&view=rev Log: - Fix a comment Modified: trunk/reactos/include/ddk/winddk.h trunk/reactos/include/reactos/arm/armddk.h Modified: trunk/reactos/include/ddk/winddk.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/ddk/winddk.h?rev=3… ============================================================================== --- trunk/reactos/include/ddk/winddk.h [iso-8859-1] (original) +++ trunk/reactos/include/ddk/winddk.h [iso-8859-1] Sun Jan 18 17:53:22 2009 @@ -5505,7 +5505,7 @@ } CONTEXT; // -// Types to use to contain PFNs and their counts. +// Used to contain PFNs and PFN counts // typedef ULONG PFN_COUNT; typedef ULONG PFN_NUMBER, *PPFN_NUMBER; @@ -5615,7 +5615,7 @@ #elif defined(__x86_64__) // -// Types to use to contain PFNs and their counts. +// Used to contain PFNs and PFN counts // typedef ULONG PFN_COUNT; typedef ULONG64 PFN_NUMBER, *PPFN_NUMBER; @@ -5735,7 +5735,7 @@ #elif defined(__PowerPC__) // -// Types to use to contain PFNs and their counts. +// Used to contain PFNs and PFN counts // typedef ULONG PFN_COUNT; typedef ULONG PFN_NUMBER, *PPFN_NUMBER; @@ -5813,7 +5813,7 @@ #error MIPS Headers are totally incorrect // -// Types to use to contain PFNs and their counts. +// Used to contain PFNs and PFN counts // typedef ULONG PFN_COUNT; typedef ULONG PFN_NUMBER, *PPFN_NUMBER; Modified: trunk/reactos/include/reactos/arm/armddk.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/reactos/arm/armddk… ============================================================================== --- trunk/reactos/include/reactos/arm/armddk.h [iso-8859-1] (original) +++ trunk/reactos/include/reactos/arm/armddk.h [iso-8859-1] Sun Jan 18 17:53:22 2009 @@ -44,7 +44,7 @@ // -// Types to use to contain PFNs and their counts. +// Used to contain PFNs and PFN counts // typedef ULONG PFN_COUNT; typedef ULONG PFN_NUMBER, *PPFN_NUMBER;

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs