Ros-diffs

ros-diffs@reactos.org

81390 discussions

[cfinck] 38000: - Introduce the "shared" directory containing web components shared among several subsystems. This greatly reduces the amount of duplicated code and makes writing new subsystems easier. So far the components contain CSS files, an include file for easily giving a subsystem the ReactOS Website look & feel and a small AJAX library used by getbuilds and peoplemap now. Work on the Online Test Manager can begin now... :-) - Replace the ROSCMS_PATH define by a ROOT_PATH define, which is
by cfinck＠svn.reactos.org 10 Dec '08

10 Dec '08

1 0

[sginsberg] 37999: - Disable crashing advapi32 tests -- add print and notes
by sginsberg＠svn.reactos.org 10 Dec '08

10 Dec '08

Author: sginsberg Date: Wed Dec 10 11:32:31 2008 New Revision: 37999 URL: http://svn.reactos.org/svn/reactos?rev=37999&view=rev Log: - Disable crashing advapi32 tests -- add print and notes Added: trunk/rostests/winetests/advapi32/roshack.diff Modified: trunk/rostests/winetests/advapi32/security.c Added: trunk/rostests/winetests/advapi32/roshack.diff URL: http://svn.reactos.org/svn/reactos/trunk/rostests/winetests/advapi32/roshac… ============================================================================== --- trunk/rostests/winetests/advapi32/roshack.diff (added) +++ trunk/rostests/winetests/advapi32/roshack.diff [iso-8859-1] Wed Dec 10 11:32:31 2008 @@ -1,0 +1,23 @@ +Index: security.c +=================================================================== +--- security.c (revision 37998) ++++ security.c (working copy) +@@ -2665,13 +2665,17 @@ + return; + } + ++ /* ReactOS Hack: ros' Security Descriptor string parsing sucks */ ++ skip("ROS-HACK: Skipping 'test_PrivateObjectSecurity' -- ros' SID string parsing sucks\n"); ++ return; ++ + ok(pConvertStringSecurityDescriptorToSecurityDescriptorA( + "O:SY" + "G:S-1-5-21-93476-23408-4576" + "D:(A;NP;GAGXGWGR;;;SU)(A;IOID;CCDC;;;SU)" + "(D;OICI;0xffffffff;;;S-1-5-21-93476-23408-4576)" + "S:(AU;OICINPIOIDSAFA;CCDCLCSWRPRC;;;SU)(AU;NPSA;0x12019f;;;SU)", +- SDDL_REVISION_1, &sec, &dwDescSize), "Creating descriptor failed\n"); ++ SDDL_REVISION_1, &sec, &dwDescSize), "Creating descriptor failed\n"); // FIXME: ConvertStringSecurityDescriptorToSecurityDescriptor fails and 'sec' isn't set + + test_SetSecurityDescriptorControl(sec); + Modified: trunk/rostests/winetests/advapi32/security.c URL: http://svn.reactos.org/svn/reactos/trunk/rostests/winetests/advapi32/securi… ============================================================================== --- trunk/rostests/winetests/advapi32/security.c [iso-8859-1] (original) +++ trunk/rostests/winetests/advapi32/security.c [iso-8859-1] Wed Dec 10 11:32:31 2008 @@ -2665,13 +2665,17 @@ return; } + /* ReactOS Hack: ros' Security Descriptor string parsing sucks */ + skip("ROS-HACK: Skipping 'test_PrivateObjectSecurity' -- ros' SID string parsing sucks\n"); + return; + ok(pConvertStringSecurityDescriptorToSecurityDescriptorA( "O:SY" "G:S-1-5-21-93476-23408-4576" "D:(A;NP;GAGXGWGR;;;SU)(A;IOID;CCDC;;;SU)" "(D;OICI;0xffffffff;;;S-1-5-21-93476-23408-4576)" "S:(AU;OICINPIOIDSAFA;CCDCLCSWRPRC;;;SU)(AU;NPSA;0x12019f;;;SU)", - SDDL_REVISION_1, &sec, &dwDescSize), "Creating descriptor failed\n"); + SDDL_REVISION_1, &sec, &dwDescSize), "Creating descriptor failed\n"); // FIXME: ConvertStringSecurityDescriptorToSecurityDescriptor fails and 'sec' isn't set test_SetSecurityDescriptorControl(sec);

1 0

[fireball] 37998: - Impersonation level should be indeed higher that the lowest one. Fix the check accordingly. Spotted by Dmitry Gorbachev and GCC. See issue #3939 for more details.
by fireball＠svn.reactos.org 10 Dec '08

10 Dec '08

Author: fireball Date: Wed Dec 10 09:24:55 2008 New Revision: 37998 URL: http://svn.reactos.org/svn/reactos?rev=37998&view=rev Log: - Impersonation level should be indeed higher that the lowest one. Fix the check accordingly. Spotted by Dmitry Gorbachev and GCC. See issue #3939 for more details. Modified: trunk/reactos/ntoskrnl/se/semgr.c Modified: trunk/reactos/ntoskrnl/se/semgr.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/se/semgr.c?rev=37… ============================================================================== --- trunk/reactos/ntoskrnl/se/semgr.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/se/semgr.c [iso-8859-1] Wed Dec 10 09:24:55 2008 @@ -667,7 +667,7 @@ } /* Check impersonation level */ - if (Token->ImpersonationLevel < SecurityAnonymous) + if (Token->ImpersonationLevel < SecurityIdentification) { DPRINT1("Invalid impersonation level\n"); ObDereferenceObject(Token);

1 0

[dgorbachev] 37997: Update NLS files.
by dgorbachev＠svn.reactos.org 10 Dec '08

10 Dec '08

Author: dgorbachev Date: Wed Dec 10 06:07:43 2008 New Revision: 37997 URL: http://svn.reactos.org/svn/reactos?rev=37997&view=rev Log: Update NLS files. Modified: trunk/reactos/media/nls/c_932.nls trunk/reactos/media/nls/c_936.nls trunk/reactos/media/nls/c_949.nls trunk/reactos/media/nls/c_950.nls Modified: trunk/reactos/media/nls/c_932.nls URL: http://svn.reactos.org/svn/reactos/trunk/reactos/media/nls/c_932.nls?rev=37… ============================================================================== Binary files - no diff available. Modified: trunk/reactos/media/nls/c_936.nls URL: http://svn.reactos.org/svn/reactos/trunk/reactos/media/nls/c_936.nls?rev=37… ============================================================================== Binary files - no diff available. Modified: trunk/reactos/media/nls/c_949.nls URL: http://svn.reactos.org/svn/reactos/trunk/reactos/media/nls/c_949.nls?rev=37… ============================================================================== Binary files - no diff available. Modified: trunk/reactos/media/nls/c_950.nls URL: http://svn.reactos.org/svn/reactos/trunk/reactos/media/nls/c_950.nls?rev=37… ============================================================================== Binary files - no diff available.

1 0

[cwittich] 37996: fail when there are no sub authorities
by cwittich＠svn.reactos.org 10 Dec '08

10 Dec '08

Author: cwittich Date: Wed Dec 10 02:29:03 2008 New Revision: 37996 URL: http://svn.reactos.org/svn/reactos?rev=37996&view=rev Log: fail when there are no sub authorities Modified: trunk/reactos/dll/win32/advapi32/sec/sid.c Modified: trunk/reactos/dll/win32/advapi32/sec/sid.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/advapi32/sec/sid… ============================================================================== --- trunk/reactos/dll/win32/advapi32/sec/sid.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/advapi32/sec/sid.c [iso-8859-1] Wed Dec 10 02:29:03 2008 @@ -1820,7 +1820,7 @@ } i = 0; ret = FALSE; - csubauth = ((cBytes - sizeof(SID)) / sizeof(DWORD)) + 1; + csubauth = ((cBytes - GetSidLengthRequired(0)) / sizeof(DWORD)); StringSid += 2; /* Advance to Revision */ pisid->Revision = atoiW(StringSid);

1 0

[cwittich] 37995: use constant instead of value to avoid further "hm?" from Alex
by cwittich＠svn.reactos.org 10 Dec '08

10 Dec '08

Author: cwittich Date: Wed Dec 10 01:34:02 2008 New Revision: 37995 URL: http://svn.reactos.org/svn/reactos?rev=37995&view=rev Log: use constant instead of value to avoid further "hm?" from Alex Modified: trunk/reactos/dll/win32/advapi32/sec/misc.c Modified: trunk/reactos/dll/win32/advapi32/sec/misc.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/advapi32/sec/mis… ============================================================================== --- trunk/reactos/dll/win32/advapi32/sec/misc.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/advapi32/sec/misc.c [iso-8859-1] Wed Dec 10 01:34:02 2008 @@ -1463,7 +1463,7 @@ { if (0 == wcsicmp(PrivName, DefaultPrivNames[Priv])) { - Luid->LowPart = Priv + 2; + Luid->LowPart = Priv + SE_MIN_WELL_KNOWN_PRIVILEGE; Luid->HighPart = 0; return TRUE; }

1 0

[dreimer] 37994: Bug 3942: "Translate update norwegian" by Lars Martin Hambro Small sidenote: I accidently commited a patch for XBox Support from Martin_sW in r31325 ~1 year ago... It adds handover XBox HDD information to ROS Kernel into freeldr and is needed for new ROS Versions to start on XBox. This + xbox hal + xbox vbe driver + moddded bootvid driver (not commited yet (/me looks at Fireball)) makes ROS boot on XBox.
by dreimer＠svn.reactos.org 10 Dec '08

10 Dec '08

Author: dreimer Date: Wed Dec 10 01:08:31 2008 New Revision: 37994 URL: http://svn.reactos.org/svn/reactos?rev=37994&view=rev Log: Bug 3942: "Translate update norwegian" by Lars Martin Hambro Small sidenote: I accidently commited a patch for XBox Support from Martin_sW in r31325 ~1 year ago... It adds handover XBox HDD information to ROS Kernel into freeldr and is needed for new ROS Versions to start on XBox. This + xbox hal + xbox vbe driver + moddded bootvid driver (not commited yet (/me looks at Fireball)) makes ROS boot on XBox. Modified: trunk/reactos/base/applications/games/solitaire/lang/no-NO.rc trunk/reactos/base/setup/reactos/lang/no-NO.rc trunk/reactos/dll/win32/netshell/lang/no-NO.rc Modified: trunk/reactos/base/applications/games/solitaire/lang/no-NO.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/games/so… ============================================================================== --- trunk/reactos/base/applications/games/solitaire/lang/no-NO.rc [iso-8859-1] (original) +++ trunk/reactos/base/applications/games/solitaire/lang/no-NO.rc [iso-8859-1] Wed Dec 10 01:08:31 2008 @@ -51,7 +51,7 @@ IDS_SOL_ABOUT "Kabal av J Brown\n\nCardLib versjon 1.0." IDS_SOL_QUIT "Slutt nåværende spill?" IDS_SOL_WIN "Gratulerer, du vant!!" - IDS_SOL_DEAL "Deal again?" + IDS_SOL_DEAL "Del ut igjen?" END Modified: trunk/reactos/base/setup/reactos/lang/no-NO.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/setup/reactos/lang/no… ============================================================================== --- trunk/reactos/base/setup/reactos/lang/no-NO.rc [iso-8859-1] (original) +++ trunk/reactos/base/setup/reactos/lang/no-NO.rc [iso-8859-1] Wed Dec 10 01:08:31 2008 @@ -60,12 +60,29 @@ LISTBOX IDC_PARTITION, 20,12,278,142,LBS_HASSTRINGS | WS_VSCROLL PUSHBUTTON "&Opprett", IDC_PARTCREATE, 20,155,50,15 PUSHBUTTON "&Slett", IDC_PARTDELETE, 76,155,50,15 + PUSHBUTTON "S&tasjon", IDC_DEVICEDRIVER, 162,155,50,15, WS_DISABLED PUSHBUTTON "&Avansert valg...", IDC_PARTMOREOPTS, 218,155,80,15 LTEXT "Trykk på Neste for å starte installasjon prosessen.", IDC_STATIC, 10, 180 ,277, 20 END +IDD_PARTITION DIALOGEX DISCARDABLE 0, 0, 145, 90 +STYLE WS_VISIBLE|WS_CAPTION|WS_THICKFRAME +CAPTION "Opprett partisjon" +FONT 8, "MS Shell Dlg" +BEGIN + CONTROL "",IDC_UPDOWN1,"msctls_updown32", WS_VISIBLE,104,22,9,13 + CONTROL "Opprett og formater partisjon",IDC_STATIC,"Button",BS_GROUPBOX,7,5,129,57 + LTEXT "Størrelse:",IDC_STATIC, 13,24,27,9 + EDITTEXT IDC_PARTSIZE,52,23,53,13, WS_VISIBLE|WS_TABSTOP + LTEXT "GB",IDC_UNIT, 117,24,14,9 + LTEXT "Filsystem:",IDC_STATIC,13,46,35,9 + CONTROL "",IDC_FSTYPE,"ComboBox",WS_VISIBLE|WS_TABSTOP|CBS_DROPDOWNLIST,52,42,79,50 + PUSHBUTTON "&OK",IDOK,35,68,47,15, WS_VISIBLE|WS_TABSTOP + PUSHBUTTON "&Avbryt",IDCANCEL,87,68,47,15, WS_VISIBLE|WS_TABSTOP +END + IDD_BOOTOPTIONS DIALOGEX DISCARDABLE 0, 0, 305, 105 -STYLE WS_VISIBLE|WS_CAPTION|WS_SYSMENU|WS_THICKFRAME +STYLE WS_VISIBLE|WS_CAPTION|WS_THICKFRAME CAPTION "Avansert partisjon innstillinger" FONT 8, "MS Shell Dlg" BEGIN @@ -77,7 +94,16 @@ CONTROL "Installer oppstartslaster på harddiskens (MBR)", IDC_INSTFREELDR, "Button", BS_AUTORADIOBUTTON | WS_TABSTOP, 10,46,278,11 CONTROL "Ikke installer oppstartslaster", IDC_NOINSTFREELDR, "Button", BS_AUTORADIOBUTTON | WS_TABSTOP | WS_DISABLED , 10,57,278,11 PUSHBUTTON "&OK", IDOK, 180,83,50,15, WS_TABSTOP | WS_VISIBLE - PUSHBUTTON "&Cancel", IDCANCEL, 240,83,50,15, WS_TABSTOP | WS_VISIBLE + PUSHBUTTON "&Avbryt", IDCANCEL, 240,83,50,15, WS_TABSTOP | WS_VISIBLE +END + +IDD_SUMMARYPAGE DIALOGEX 0, 0, 317, 193 +STYLE DS_SHELLFONT | DS_MODALFRAME | WS_POPUP | WS_VISIBLE | WS_CAPTION | WS_SYSMENU +CAPTION "ReactOS installering" +FONT 8, "MS Shell Dlg" +BEGIN + CONTROL "Installasjon oppsumering", IDC_ACTION, "Button", BS_GROUPBOX, 10,0,297,172 + LTEXT "Trykk på Neste for å starte installasjon prosessen.", IDC_STATIC, 10, 180 ,277, 20 END IDD_PROCESSPAGE DIALOGEX 0, 0, 317, 193 @@ -103,13 +129,13 @@ LTEXT "Når du trykker Fullført, vil din datamaskin starte på nytt.", IDC_STATIC, 20, 80, 277, 10 CONTROL "", IDC_RESTART_PROGRESS, "msctls_progress32", PBS_SMOOTH | WS_CHILD | WS_VISIBLE | WS_BORDER, 20, 120, 277, 8 - LTEXT "Hvis du fortsatt har CD platen i stasjon, fjern denne. Også, for å starte din datamaskin på nytt, trykk på Fullført.", IDC_STATIC, 10, 180, 297, 20 + LTEXT "Hvis du fortsatt har CD platen i stasjon, fjern denne. For å starte din datamaskin på nytt, trykk på Fullført.", IDC_STATIC, 10, 180, 297, 20 END STRINGTABLE BEGIN - IDS_LANGTITLE "Språk valg" + IDS_LANGTITLE "Språkvalg" IDS_LANGSUBTITLE "Velg språk for installering og til ferdig system." IDS_TYPETITLE "Velkommen til ReactOS installering" IDS_TYPESUBTITLE "Velg installering type." @@ -121,6 +147,8 @@ IDS_PROCESSSUBTITLE "Opprett og formater partisjon, kopier filer, installere og sett opp oppstartlaster" IDS_RESTARTTITLE "Første steget av installering er fullført" IDS_RESTARTSUBTITLE "Første steget av installering har blitt fullført, start på nytt for å fortsette til andre steget" + IDS_SUMMARYTITLE "Installasjon oppsumering" + IDS_SUMMARYSUBTITLE "Sjekk listen av installasjon egenskapene før du fortsetter installasjon av enhetene" IDS_ABORTSETUP "ReactOS er ikke fullstendig installert på datamaskinen. Hvis du avslutter nå, trenger du å kjøre installeringen på nytt for å installere Reactos. Vil du virkelig avslutte?" IDS_ABORTSETUP2 "Avbryt installasjonen?" END Modified: trunk/reactos/dll/win32/netshell/lang/no-NO.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/netshell/lang/no… ============================================================================== --- trunk/reactos/dll/win32/netshell/lang/no-NO.rc [iso-8859-1] (original) +++ trunk/reactos/dll/win32/netshell/lang/no-NO.rc [iso-8859-1] Wed Dec 10 01:08:31 2008 @@ -73,18 +73,18 @@ IDD_LAN_NETSTATUSDETAILS DIALOGEX DISCARDABLE 0, 0, 200,200 STYLE DS_SHELLFONT | WS_POPUP | WS_CAPTION -CAPTION "Network Connection Details" +CAPTION "Nettverk tilkobling detaljer" FONT 8, "MS Shell Dlg" BEGIN - LTEXT "Network Connection &Details:", -1, 15, 9, 170, 12 + LTEXT "Nettverk tilkobling &detaljer:", -1, 15, 9, 170, 12 CONTROL "", IDC_DETAILS, "SysListView32", LVS_REPORT | LVS_SINGLESEL | LVS_SHOWSELALWAYS | LVS_NOSORTHEADER | WS_BORDER | WS_TABSTOP, 15, 25, 170, 130 - PUSHBUTTON "&Close", IDC_CLOSE, 125, 165, 62, 14 + PUSHBUTTON "&Lukk", IDC_CLOSE, 125, 165, 62, 14 END STRINGTABLE DISCARDABLE BEGIN IDS_PHYSICAL_ADDRESS "Physical Address" - IDS_IP_ADDRESS "IP Address" + IDS_IP_ADDRESS "IP addresse" IDS_SUBNET_MASK "Subnet Mask" IDS_DEF_GATEWAY "Default Gateway" IDS_DHCP_SERVER "DHCP Server"

1 0

[cgutman] 37993: - Unregister the interface before destroying it
by cgutman＠svn.reactos.org 10 Dec '08

10 Dec '08

Author: cgutman Date: Tue Dec 9 19:51:32 2008 New Revision: 37993 URL: http://svn.reactos.org/svn/reactos?rev=37993&view=rev Log: - Unregister the interface before destroying it Modified: branches/aicom-network-fixes/drivers/network/tcpip/datalink/lan.c Modified: branches/aicom-network-fixes/drivers/network/tcpip/datalink/lan.c URL: http://svn.reactos.org/svn/reactos/branches/aicom-network-fixes/drivers/net… ============================================================================== --- branches/aicom-network-fixes/drivers/network/tcpip/datalink/lan.c [iso-8859-1] (original) +++ branches/aicom-network-fixes/drivers/network/tcpip/datalink/lan.c [iso-8859-1] Tue Dec 9 19:51:32 2008 @@ -991,6 +991,7 @@ if (NdisStatus != NDIS_STATUS_SUCCESS) { TI_DbgPrint(DEBUG_DATALINK, ("Could not set packet filter (0x%X).\n", NdisStatus)); + IPUnregisterInterface(IF); IPDestroyInterface(IF); return FALSE; }

1 0

[tkreuzer] 37992: Goodbye kdbg, hello WINKD
by tkreuzer＠svn.reactos.org 10 Dec '08

10 Dec '08

Author: tkreuzer Date: Tue Dec 9 19:27:58 2008 New Revision: 37992 URL: http://svn.reactos.org/svn/reactos?rev=37992&view=rev Log: Goodbye kdbg, hello WINKD Modified: branches/ros-amd64-bringup/reactos/config-amd64.template.rbuild Modified: branches/ros-amd64-bringup/reactos/config-amd64.template.rbuild URL: http://svn.reactos.org/svn/reactos/branches/ros-amd64-bringup/reactos/confi… ============================================================================== --- branches/ros-amd64-bringup/reactos/config-amd64.template.rbuild [iso-8859-1] (original) +++ branches/ros-amd64-bringup/reactos/config-amd64.template.rbuild [iso-8859-1] Tue Dec 9 19:27:58 2008 @@ -43,7 +43,7 @@  -<property name="KDBG" value="1" /> +<property name="KDBG" value="0" />  -<property name="_WINKD_" value="0" /> +<property name="_WINKD_" value="1" /> <!-- Whether to compile support for ELF files. Do not enable unless you know what

1 0

[tkreuzer] 37991: Fix hal build
by tkreuzer＠svn.reactos.org 10 Dec '08

10 Dec '08

Author: tkreuzer Date: Tue Dec 9 19:26:44 2008 New Revision: 37991 URL: http://svn.reactos.org/svn/reactos?rev=37991&view=rev Log: Fix hal build Modified: branches/ros-amd64-bringup/reactos/hal/halx86/include/apic.h Modified: branches/ros-amd64-bringup/reactos/hal/halx86/include/apic.h URL: http://svn.reactos.org/svn/reactos/branches/ros-amd64-bringup/reactos/hal/h… ============================================================================== --- branches/ros-amd64-bringup/reactos/hal/halx86/include/apic.h [iso-8859-1] (original) +++ branches/ros-amd64-bringup/reactos/hal/halx86/include/apic.h [iso-8859-1] Tue Dec 9 19:26:44 2008 @@ -186,7 +186,7 @@ { PULONG p; - p = (PULONG)((ULONG)APICBase + Offset); + p = (PULONG)((ULONG_PTR)APICBase + Offset); return *p; } @@ -196,7 +196,7 @@ { PULONG p; - p = (PULONG)((ULONG)APICBase + Offset); + p = (PULONG)((ULONG_PTR)APICBase + Offset); *p = Value; } @@ -210,7 +210,7 @@ lastregw[CPU] = Offset; lastvalw[CPU] = Value; - p = (PULONG)((ULONG)APICBase + Offset); + p = (PULONG)((ULONG_PTR)APICBase + Offset); *p = Value; } @@ -221,7 +221,7 @@ { PULONG p; - p = (PULONG)((ULONG)APICBase + Offset); + p = (PULONG)((ULONG_PTR)APICBase + Offset); return *p; } #else @@ -233,7 +233,7 @@ lastregr[CPU] = Offset; lastvalr[CPU] = 0; - p = (PULONG)((ULONG)APICBase + Offset); + p = (PULONG)((ULONG_PTR)APICBase + Offset); lastvalr[CPU] = *p; return lastvalr[CPU];

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs