Ros-diffs

ros-diffs@reactos.org

81390 discussions

[amunger] 35660: Allocate buffer from Non-paged pool, like most everything else in KDBG.
by amunger＠svn.reactos.org 26 Aug '08

26 Aug '08

Author: amunger Date: Tue Aug 26 04:38:12 2008 New Revision: 35660 URL: http://svn.reactos.org/svn/reactos?rev=35660&view=rev Log: Allocate buffer from Non-paged pool, like most everything else in KDBG. Modified: trunk/reactos/ntoskrnl/kdbg/kdb_symbols.c Modified: trunk/reactos/ntoskrnl/kdbg/kdb_symbols.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/kdbg/kdb_symbols.… ============================================================================== --- trunk/reactos/ntoskrnl/kdbg/kdb_symbols.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/kdbg/kdb_symbols.c [iso-8859-1] Tue Aug 26 04:38:12 2008 @@ -510,7 +510,7 @@ KernelName.MaximumLength = sizeof(Prefix) + LdrModule->FullDllName.Length; KernelName.Length = KernelName.MaximumLength - sizeof(WCHAR); - KernelName.Buffer = ExAllocatePoolWithTag(PagedPool, KernelName.MaximumLength, TAG_KDBS); + KernelName.Buffer = ExAllocatePoolWithTag(NonPagedPool, KernelName.MaximumLength, TAG_KDBS); if (NULL == KernelName.Buffer) { return;

1 0

[janderwald] 35659: - Add a small hack for executing shortcuts to cpl files - Remove unneeded CLSID_UnixFolder registration - Fix Bitbucket, Nethood shell folder registration attributes
by janderwald＠svn.reactos.org 26 Aug '08

26 Aug '08

Author: janderwald Date: Tue Aug 26 01:24:33 2008 New Revision: 35659 URL: http://svn.reactos.org/svn/reactos?rev=35659&view=rev Log: - Add a small hack for executing shortcuts to cpl files - Remove unneeded CLSID_UnixFolder registration - Fix Bitbucket, Nethood shell folder registration attributes Modified: trunk/reactos/dll/win32/shell32/regsvr.c trunk/reactos/dll/win32/shell32/shelllink.c Modified: trunk/reactos/dll/win32/shell32/regsvr.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/regsvr.c… ============================================================================== --- trunk/reactos/dll/win32/shell32/regsvr.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/shell32/regsvr.c [iso-8859-1] Tue Aug 26 01:24:33 2008 @@ -626,8 +626,8 @@ NULL, "shell32.dll", "Apartment", - SHELLFOLDER_ATTRIBUTES, - SFGAO_FOLDER, + SHELLFOLDER_ATTRIBUTES|SHELLFOLDER_CALLFORATTRIBUTES, + SFGAO_FOLDER|SFGAO_HASPROPSHEET, 0, NULL, NULL, @@ -674,17 +674,19 @@ "shell32.dll", "Apartment", }, - { &CLSID_UnixFolder, - "/", + { &CLSID_FolderShortcut, + "Foldershortcut", 0, NULL, "shell32.dll", "Apartment", - SHELLFOLDER_WANTSFORPARSING - }, - { &CLSID_UnixDosFolder, - "/", - 0, + SHELLFOLDER_ATTRIBUTES|SHELLFOLDER_CALLFORATTRIBUTES, + SFGAO_FILESYSTEM|SFGAO_FOLDER|SFGAO_LINK, + SFGAO_HASSUBFOLDER|SFGAO_FILESYSTEM|SFGAO_FOLDER|SFGAO_FILESYSANCESTOR + }, + { &CLSID_MyDocuments, + "My Documents", + IDS_PERSONAL, NULL, "shell32.dll", "Apartment", @@ -692,33 +694,13 @@ SFGAO_FILESYSANCESTOR|SFGAO_FOLDER|SFGAO_HASSUBFOLDER, SFGAO_FILESYSTEM }, - { &CLSID_FolderShortcut, - "Foldershortcut", - 0, + { &CLSID_RecycleBin, + "Trash", + IDS_RECYCLEBIN_FOLDER_NAME, NULL, "shell32.dll", "Apartment", SHELLFOLDER_ATTRIBUTES|SHELLFOLDER_CALLFORATTRIBUTES, - SFGAO_FILESYSTEM|SFGAO_FOLDER|SFGAO_LINK, - SFGAO_HASSUBFOLDER|SFGAO_FILESYSTEM|SFGAO_FOLDER|SFGAO_FILESYSANCESTOR - }, - { &CLSID_MyDocuments, - "My Documents", - IDS_PERSONAL, - NULL, - "shell32.dll", - "Apartment", - SHELLFOLDER_WANTSFORPARSING|SHELLFOLDER_ATTRIBUTES|SHELLFOLDER_CALLFORATTRIBUTES, - SFGAO_FILESYSANCESTOR|SFGAO_FOLDER|SFGAO_HASSUBFOLDER, - SFGAO_FILESYSTEM - }, - { &CLSID_RecycleBin, - "Trash", - IDS_RECYCLEBIN_FOLDER_NAME, - NULL, - "shell32.dll", - "Apartment", - SHELLFOLDER_ATTRIBUTES, SFGAO_FOLDER|SFGAO_DROPTARGET|SFGAO_HASPROPSHEET, 0, NULL, Modified: trunk/reactos/dll/win32/shell32/shelllink.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/shelllin… ============================================================================== --- trunk/reactos/dll/win32/shell32/shelllink.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/shell32/shelllink.c [iso-8859-1] Tue Aug 26 01:24:33 2008 @@ -2512,7 +2512,7 @@ mii.fType = MFT_STRING; if (!InsertMenuItemW( hmenu, indexMenu, TRUE, &mii )) return E_FAIL; - This->iIdOpen = 0; + This->iIdOpen = 1; return MAKE_HRESULT( SEVERITY_SUCCESS, 0, id ); } @@ -2788,7 +2788,8 @@ ShellLink_InvokeCommand( IContextMenu* iface, LPCMINVOKECOMMANDINFO lpici ) { IShellLinkImpl *This = impl_from_IContextMenu(iface); - static const WCHAR szOpen[] = { 'O','p','e','n',0 }; + static const WCHAR szOpen[] = { 'o','p','e','n',0 }; + static const WCHAR szCplOpen[] = { 'c','p','l','o','p','e','n',0 }; SHELLEXECUTEINFOW sei; HWND hwnd = NULL; /* FIXME: get using interface set from IObjectWithSite */ LPWSTR args = NULL; @@ -2800,16 +2801,12 @@ if ( lpici->cbSize < sizeof (CMINVOKECOMMANDINFO) ) return E_INVALIDARG; - if ( lpici->lpVerb != MAKEINTRESOURCEA(This->iIdOpen) ) - { - ERR("Unknown id %d != %d\n", (INT)lpici->lpVerb, This->iIdOpen ); - return E_INVALIDARG; - } - r = IShellLinkW_Resolve( (IShellLinkW*)&(This->lpvtblw), hwnd, 0 ); if ( FAILED( r ) ) + { + TRACE("failed to resolve component with error 0x%08x", r); return r; - + } if ( This->sComponent ) { path = shelllink_get_msi_component_path( This->sComponent ); @@ -2847,10 +2844,15 @@ sei.fMask = SEE_MASK_UNICODE | (lpici->fMask & (SEE_MASK_NOASYNC|SEE_MASK_ASYNCOK|SEE_MASK_FLAG_NO_UI)); sei.lpFile = path; sei.nShow = This->iShowCmd; - sei.lpIDList = This->pPidl; sei.lpDirectory = This->sWorkDir; sei.lpParameters = args; sei.lpVerb = szOpen; + + // HACK for ShellExecuteExW + if (!wcsstr(This->sPath, L".cpl")) + sei.lpVerb = szOpen; + else + sei.lpVerb = szCplOpen; if( ShellExecuteExW( &sei ) ) r = S_OK;

1 0

[cgutman] 35658: - Merge r35656 from aicom-network-fixes - Fixes more leaks during general network use
by cgutman＠svn.reactos.org 26 Aug '08

26 Aug '08

Author: cgutman Date: Mon Aug 25 23:19:07 2008 New Revision: 35658 URL: http://svn.reactos.org/svn/reactos?rev=35658&view=rev Log: - Merge r35656 from aicom-network-fixes - Fixes more leaks during general network use Modified: trunk/reactos/lib/drivers/ip/transport/tcp/tcp.c Modified: trunk/reactos/lib/drivers/ip/transport/tcp/tcp.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/drivers/ip/transport/t… ============================================================================== --- trunk/reactos/lib/drivers/ip/transport/tcp/tcp.c [iso-8859-1] (original) +++ trunk/reactos/lib/drivers/ip/transport/tcp/tcp.c [iso-8859-1] Mon Aug 25 23:19:07 2008 @@ -89,8 +89,10 @@ if( Status == STATUS_PENDING ) { InsertHeadList( &Connection->ListenRequest, &Bucket->Entry ); break; - } else + } else { Complete( Bucket->Request.RequestContext, Status, 0 ); + PoolFreeBuffer( Bucket ); + } } } @@ -141,6 +143,7 @@ Complete( Bucket->Request.RequestContext, STATUS_SUCCESS, Received ); + PoolFreeBuffer( Bucket ); } else if( Status == STATUS_PENDING ) { InsertHeadList ( &Connection->ReceiveRequest, &Bucket->Entry ); @@ -150,6 +153,7 @@ ("Completing Receive request: %x %x\n", Bucket->Request, Status)); Complete( Bucket->Request.RequestContext, Status, 0 ); + PoolFreeBuffer( Bucket ); } } } @@ -198,6 +202,7 @@ Complete( Bucket->Request.RequestContext, STATUS_SUCCESS, Sent ); + PoolFreeBuffer( Bucket ); } else if( Status == STATUS_PENDING ) { InsertHeadList ( &Connection->SendRequest, &Bucket->Entry ); @@ -207,6 +212,7 @@ ("Completing Send request: %x %x\n", Bucket->Request, Status)); Complete( Bucket->Request.RequestContext, Status, 0 ); + PoolFreeBuffer( Bucket ); } } } @@ -225,13 +231,15 @@ ListsToErase[2] = &Connection->ConnectRequest; IrpStatus [2] = STATUS_UNSUCCESSFUL; ListsToErase[3] = 0; + IrpStatus [3] = 0; for( i = 0; ListsToErase[i]; i++ ) { while( !IsListEmpty( ListsToErase[i] ) ) { Entry = RemoveHeadList( ListsToErase[i] ); Bucket = CONTAINING_RECORD( Entry, TDI_BUCKET, Entry ); Complete = Bucket->Request.RequestNotifyObject; - Complete( Bucket->Request.RequestContext, STATUS_SUCCESS, 0 ); + Complete( Bucket->Request.RequestContext, IrpStatus[i], 0 ); + PoolFreeBuffer( Bucket ); } } }

1 0

[sserapion] 35657: Fix tcpsvcs build.
by sserapion＠svn.reactos.org 26 Aug '08

26 Aug '08

Author: sserapion Date: Mon Aug 25 23:12:02 2008 New Revision: 35657 URL: http://svn.reactos.org/svn/reactos?rev=35657&view=rev Log: Fix tcpsvcs build. Modified: branches/ros-amd64-bringup/reactos/base/services/tcpsvcs/chargen.c branches/ros-amd64-bringup/reactos/base/services/tcpsvcs/daytime.c branches/ros-amd64-bringup/reactos/base/services/tcpsvcs/discard.c branches/ros-amd64-bringup/reactos/base/services/tcpsvcs/echo.c branches/ros-amd64-bringup/reactos/base/services/tcpsvcs/qotd.c branches/ros-amd64-bringup/reactos/base/services/tcpsvcs/skelserver.c Modified: branches/ros-amd64-bringup/reactos/base/services/tcpsvcs/chargen.c URL: http://svn.reactos.org/svn/reactos/branches/ros-amd64-bringup/reactos/base/… ============================================================================== --- branches/ros-amd64-bringup/reactos/base/services/tcpsvcs/chargen.c [iso-8859-1] (original) +++ branches/ros-amd64-bringup/reactos/base/services/tcpsvcs/chargen.c [iso-8859-1] Mon Aug 25 23:12:02 2008 @@ -96,7 +96,7 @@ ChargenHandler(VOID* sock_) { INT retVal = 0; - SOCKET sock = (SOCKET)sock_; + SOCKET sock = (SOCKET)(UINT_PTR)sock_; if (!GenerateChars(sock)) { Modified: branches/ros-amd64-bringup/reactos/base/services/tcpsvcs/daytime.c URL: http://svn.reactos.org/svn/reactos/branches/ros-amd64-bringup/reactos/base/… ============================================================================== --- branches/ros-amd64-bringup/reactos/base/services/tcpsvcs/daytime.c [iso-8859-1] (original) +++ branches/ros-amd64-bringup/reactos/base/services/tcpsvcs/daytime.c [iso-8859-1] Mon Aug 25 23:12:02 2008 @@ -30,7 +30,7 @@ time_t aclock; CHAR *pszTime; DWORD retVal = 0; - SOCKET Sock = (SOCKET)Sock_; + SOCKET Sock = (SOCKET)(UINT_PTR)Sock_; time(&aclock); localTime = localtime(&aclock); Modified: branches/ros-amd64-bringup/reactos/base/services/tcpsvcs/discard.c URL: http://svn.reactos.org/svn/reactos/branches/ros-amd64-bringup/reactos/base/… ============================================================================== --- branches/ros-amd64-bringup/reactos/base/services/tcpsvcs/discard.c [iso-8859-1] (original) +++ branches/ros-amd64-bringup/reactos/base/services/tcpsvcs/discard.c [iso-8859-1] Mon Aug 25 23:12:02 2008 @@ -44,7 +44,7 @@ DiscardHandler(VOID* sock_) { DWORD retVal = 0; - SOCKET sock = (SOCKET)sock_; + SOCKET sock = (SOCKET)(UINT_PTR)sock_; if (!RecieveIncomingPackets(sock)) { Modified: branches/ros-amd64-bringup/reactos/base/services/tcpsvcs/echo.c URL: http://svn.reactos.org/svn/reactos/branches/ros-amd64-bringup/reactos/base/… ============================================================================== --- branches/ros-amd64-bringup/reactos/base/services/tcpsvcs/echo.c [iso-8859-1] (original) +++ branches/ros-amd64-bringup/reactos/base/services/tcpsvcs/echo.c [iso-8859-1] Mon Aug 25 23:12:02 2008 @@ -69,7 +69,7 @@ EchoHandler(VOID* sock_) { DWORD retVal = 0; - SOCKET sock = (SOCKET)sock_; + SOCKET sock = (SOCKET)(UINT_PTR)sock_; if (!EchoIncomingPackets(sock)) { Modified: branches/ros-amd64-bringup/reactos/base/services/tcpsvcs/qotd.c URL: http://svn.reactos.org/svn/reactos/branches/ros-amd64-bringup/reactos/base/… ============================================================================== --- branches/ros-amd64-bringup/reactos/base/services/tcpsvcs/qotd.c [iso-8859-1] (original) +++ branches/ros-amd64-bringup/reactos/base/services/tcpsvcs/qotd.c [iso-8859-1] Mon Aug 25 23:12:02 2008 @@ -128,7 +128,7 @@ DWORD WINAPI QotdHandler(VOID* sock_) { - SOCKET sock = (SOCKET)sock_; + SOCKET sock = (SOCKET)(UINT_PTR)sock_; DWORD retVal = 0; if (!RetrieveQuote(sock)) Modified: branches/ros-amd64-bringup/reactos/base/services/tcpsvcs/skelserver.c URL: http://svn.reactos.org/svn/reactos/branches/ros-amd64-bringup/reactos/base/… ============================================================================== --- branches/ros-amd64-bringup/reactos/base/services/tcpsvcs/skelserver.c [iso-8859-1] (original) +++ branches/ros-amd64-bringup/reactos/base/services/tcpsvcs/skelserver.c [iso-8859-1] Mon Aug 25 23:12:02 2008 @@ -95,7 +95,7 @@ if (!bShutdown) { - hThread = CreateThread(0, 0, lpService, (void*)sock, 0, NULL); + hThread = CreateThread(0, 0, lpService, (PVOID)(UINT_PTR)sock, 0, NULL); if (hThread != NULL) { CloseHandle(hThread);

1 0

[cgutman] 35656: - Fix many memory leaks - Complete with the correct status
by cgutman＠svn.reactos.org 26 Aug '08

26 Aug '08

Author: cgutman Date: Mon Aug 25 21:57:12 2008 New Revision: 35656 URL: http://svn.reactos.org/svn/reactos?rev=35656&view=rev Log: - Fix many memory leaks - Complete with the correct status Modified: branches/aicom-network-fixes/lib/drivers/ip/transport/tcp/tcp.c Modified: branches/aicom-network-fixes/lib/drivers/ip/transport/tcp/tcp.c URL: http://svn.reactos.org/svn/reactos/branches/aicom-network-fixes/lib/drivers… ============================================================================== --- branches/aicom-network-fixes/lib/drivers/ip/transport/tcp/tcp.c [iso-8859-1] (original) +++ branches/aicom-network-fixes/lib/drivers/ip/transport/tcp/tcp.c [iso-8859-1] Mon Aug 25 21:57:12 2008 @@ -89,8 +89,10 @@ if( Status == STATUS_PENDING ) { InsertHeadList( &Connection->ListenRequest, &Bucket->Entry ); break; - } else + } else { Complete( Bucket->Request.RequestContext, Status, 0 ); + PoolFreeBuffer( Bucket ); + } } } @@ -141,6 +143,7 @@ Complete( Bucket->Request.RequestContext, STATUS_SUCCESS, Received ); + PoolFreeBuffer( Bucket ); } else if( Status == STATUS_PENDING ) { InsertHeadList ( &Connection->ReceiveRequest, &Bucket->Entry ); @@ -150,6 +153,7 @@ ("Completing Receive request: %x %x\n", Bucket->Request, Status)); Complete( Bucket->Request.RequestContext, Status, 0 ); + PoolFreeBuffer( Bucket ); } } } @@ -198,6 +202,7 @@ Complete( Bucket->Request.RequestContext, STATUS_SUCCESS, Sent ); + PoolFreeBuffer( Bucket ); } else if( Status == STATUS_PENDING ) { InsertHeadList ( &Connection->SendRequest, &Bucket->Entry ); @@ -207,6 +212,7 @@ ("Completing Send request: %x %x\n", Bucket->Request, Status)); Complete( Bucket->Request.RequestContext, Status, 0 ); + PoolFreeBuffer( Bucket ); } } } @@ -225,13 +231,15 @@ ListsToErase[2] = &Connection->ConnectRequest; IrpStatus [2] = STATUS_UNSUCCESSFUL; ListsToErase[3] = 0; + IrpStatus [3] = 0; for( i = 0; ListsToErase[i]; i++ ) { while( !IsListEmpty( ListsToErase[i] ) ) { Entry = RemoveHeadList( ListsToErase[i] ); Bucket = CONTAINING_RECORD( Entry, TDI_BUCKET, Entry ); Complete = Bucket->Request.RequestNotifyObject; - Complete( Bucket->Request.RequestContext, STATUS_SUCCESS, 0 ); + Complete( Bucket->Request.RequestContext, IrpStatus[i], 0 ); + PoolFreeBuffer( Bucket ); } } }

1 0

[sserapion] 35655: Remove unneeded msvcrt dependancies(all win32 modules depend on msvcrt already) dbghelp: Don't use old style parameter lists. kernel32: Remove stdcall decorations from amd64 asm. user32: Convert to spec file. console: Convert to spec file. Misc WIN64 fixes.
by sserapion＠svn.reactos.org 26 Aug '08

26 Aug '08

Author: sserapion Date: Mon Aug 25 21:19:29 2008 New Revision: 35655 URL: http://svn.reactos.org/svn/reactos?rev=35655&view=rev Log: Remove unneeded msvcrt dependancies(all win32 modules depend on msvcrt already) dbghelp: Don't use old style parameter lists. kernel32: Remove stdcall decorations from amd64 asm. user32: Convert to spec file. console: Convert to spec file. Misc WIN64 fixes. Added: branches/ros-amd64-bringup/reactos/dll/cpl/console/console.spec (with props) branches/ros-amd64-bringup/reactos/dll/win32/user32/user32.spec (with props) branches/ros-amd64-bringup/reactos/dll/win32/ws2_32/ws2_32.spec (with props) Removed: branches/ros-amd64-bringup/reactos/dll/cpl/console/console.def branches/ros-amd64-bringup/reactos/dll/win32/user32/user32.def Modified: branches/ros-amd64-bringup/reactos/dll/3rdparty/mesa32/mesa32.rbuild branches/ros-amd64-bringup/reactos/dll/cpl/appwiz-new/appwiz.rbuild branches/ros-amd64-bringup/reactos/dll/cpl/appwiz/appwiz.rbuild branches/ros-amd64-bringup/reactos/dll/cpl/desk/desk.rbuild branches/ros-amd64-bringup/reactos/dll/cpl/input/input.rbuild branches/ros-amd64-bringup/reactos/dll/cpl/intl/intl.rbuild branches/ros-amd64-bringup/reactos/dll/cpl/joy/joy.rbuild branches/ros-amd64-bringup/reactos/dll/cpl/main/main.rbuild branches/ros-amd64-bringup/reactos/dll/cpl/mmsys/mmsys.rbuild branches/ros-amd64-bringup/reactos/dll/cpl/odbccp32/odbccp32.rbuild branches/ros-amd64-bringup/reactos/dll/cpl/powercfg/powercfg.rbuild branches/ros-amd64-bringup/reactos/dll/cpl/sysdm/sysdm.rbuild branches/ros-amd64-bringup/reactos/dll/cpl/telephon/telephon.rbuild branches/ros-amd64-bringup/reactos/dll/cpl/timedate/timedate.rbuild branches/ros-amd64-bringup/reactos/dll/cpl/usrmgr/usrmgr.rbuild branches/ros-amd64-bringup/reactos/dll/directx/ddraw/ddraw.rbuild branches/ros-amd64-bringup/reactos/dll/directx/directx.rbuild branches/ros-amd64-bringup/reactos/dll/directx/dsound/dsound.rbuild branches/ros-amd64-bringup/reactos/dll/ntdll/def/ntdll_amd64.def branches/ros-amd64-bringup/reactos/dll/shellext/deskadp/deskadp.rbuild branches/ros-amd64-bringup/reactos/dll/shellext/deskmon/deskmon.rbuild branches/ros-amd64-bringup/reactos/dll/shellext/fontext/fontext.rbuild branches/ros-amd64-bringup/reactos/dll/win32/advapi32/advapi32.spec branches/ros-amd64-bringup/reactos/dll/win32/advapi32/sec/misc.c branches/ros-amd64-bringup/reactos/dll/win32/dbghelp/regex.c branches/ros-amd64-bringup/reactos/dll/win32/dhcpcsvc/dhcpcsvc.rbuild branches/ros-amd64-bringup/reactos/dll/win32/dnsapi/dnsapi.rbuild branches/ros-amd64-bringup/reactos/dll/win32/gdi32/gdi32.rbuild branches/ros-amd64-bringup/reactos/dll/win32/glu32/glu32.rbuild branches/ros-amd64-bringup/reactos/dll/win32/icmp/icmp.rbuild branches/ros-amd64-bringup/reactos/dll/win32/kernel32/kernel32.spec branches/ros-amd64-bringup/reactos/dll/win32/kernel32/misc/dllmain.c branches/ros-amd64-bringup/reactos/dll/win32/kernel32/misc/errormsg.c branches/ros-amd64-bringup/reactos/dll/win32/kernel32/misc/toolhelp.c branches/ros-amd64-bringup/reactos/dll/win32/kernel32/synch/critical.c branches/ros-amd64-bringup/reactos/dll/win32/kernel32/thread/amd64/fiber.S branches/ros-amd64-bringup/reactos/dll/win32/kernel32/thread/amd64/thread.S branches/ros-amd64-bringup/reactos/dll/win32/msvcrt/msvcrt.def branches/ros-amd64-bringup/reactos/dll/win32/opengl32/opengl32.h branches/ros-amd64-bringup/reactos/dll/win32/shell32/autocomplete.c branches/ros-amd64-bringup/reactos/dll/win32/shell32/changenotify.c branches/ros-amd64-bringup/reactos/dll/win32/user32/include/dde_private.h branches/ros-amd64-bringup/reactos/dll/win32/user32/include/user32.h branches/ros-amd64-bringup/reactos/dll/win32/user32/misc/dde.c branches/ros-amd64-bringup/reactos/dll/win32/user32/misc/ddeserver.c branches/ros-amd64-bringup/reactos/dll/win32/user32/user32.rbuild branches/ros-amd64-bringup/reactos/dll/win32/user32/windows/draw.c branches/ros-amd64-bringup/reactos/dll/win32/user32/windows/menu.c branches/ros-amd64-bringup/reactos/dll/win32/winmm/midimap/midimap.rbuild branches/ros-amd64-bringup/reactos/dll/win32/ws2_32/misc/stubs.c branches/ros-amd64-bringup/reactos/dll/win32/ws2_32/ws2_32.rbuild [This mail would be too long, it was shortened to contain the URLs only.] Modified: branches/ros-amd64-bringup/reactos/dll/3rdparty/mesa32/mesa32.rbuild URL: http://svn.reactos.org/svn/reactos/branches/ros-amd64-bringup/reactos/dll/3… Modified: branches/ros-amd64-bringup/reactos/dll/cpl/appwiz-new/appwiz.rbuild URL: http://svn.reactos.org/svn/reactos/branches/ros-amd64-bringup/reactos/dll/c… Modified: branches/ros-amd64-bringup/reactos/dll/cpl/appwiz/appwiz.rbuild URL: http://svn.reactos.org/svn/reactos/branches/ros-amd64-bringup/reactos/dll/c… Removed: branches/ros-amd64-bringup/reactos/dll/cpl/console/console.def URL: http://svn.reactos.org/svn/reactos/branches/ros-amd64-bringup/reactos/dll/c… Added: branches/ros-amd64-bringup/reactos/dll/cpl/console/console.spec URL: http://svn.reactos.org/svn/reactos/branches/ros-amd64-bringup/reactos/dll/c… Modified: branches/ros-amd64-bringup/reactos/dll/cpl/desk/desk.rbuild URL: http://svn.reactos.org/svn/reactos/branches/ros-amd64-bringup/reactos/dll/c… Modified: branches/ros-amd64-bringup/reactos/dll/cpl/input/input.rbuild URL: http://svn.reactos.org/svn/reactos/branches/ros-amd64-bringup/reactos/dll/c… Modified: branches/ros-amd64-bringup/reactos/dll/cpl/intl/intl.rbuild URL: http://svn.reactos.org/svn/reactos/branches/ros-amd64-bringup/reactos/dll/c… Modified: branches/ros-amd64-bringup/reactos/dll/cpl/joy/joy.rbuild URL: http://svn.reactos.org/svn/reactos/branches/ros-amd64-bringup/reactos/dll/c… Modified: branches/ros-amd64-bringup/reactos/dll/cpl/main/main.rbuild URL: http://svn.reactos.org/svn/reactos/branches/ros-amd64-bringup/reactos/dll/c… Modified: branches/ros-amd64-bringup/reactos/dll/cpl/mmsys/mmsys.rbuild URL: http://svn.reactos.org/svn/reactos/branches/ros-amd64-bringup/reactos/dll/c… Modified: branches/ros-amd64-bringup/reactos/dll/cpl/odbccp32/odbccp32.rbuild URL: http://svn.reactos.org/svn/reactos/branches/ros-amd64-bringup/reactos/dll/c… Modified: branches/ros-amd64-bringup/reactos/dll/cpl/powercfg/powercfg.rbuild URL: http://svn.reactos.org/svn/reactos/branches/ros-amd64-bringup/reactos/dll/c… Modified: branches/ros-amd64-bringup/reactos/dll/cpl/sysdm/sysdm.rbuild URL: http://svn.reactos.org/svn/reactos/branches/ros-amd64-bringup/reactos/dll/c… Modified: branches/ros-amd64-bringup/reactos/dll/cpl/telephon/telephon.rbuild URL: http://svn.reactos.org/svn/reactos/branches/ros-amd64-bringup/reactos/dll/c… Modified: branches/ros-amd64-bringup/reactos/dll/cpl/timedate/timedate.rbuild URL: http://svn.reactos.org/svn/reactos/branches/ros-amd64-bringup/reactos/dll/c… Modified: branches/ros-amd64-bringup/reactos/dll/cpl/usrmgr/usrmgr.rbuild URL: http://svn.reactos.org/svn/reactos/branches/ros-amd64-bringup/reactos/dll/c… Modified: branches/ros-amd64-bringup/reactos/dll/directx/ddraw/ddraw.rbuild URL: http://svn.reactos.org/svn/reactos/branches/ros-amd64-bringup/reactos/dll/d… Modified: branches/ros-amd64-bringup/reactos/dll/directx/directx.rbuild URL: http://svn.reactos.org/svn/reactos/branches/ros-amd64-bringup/reactos/dll/d… Modified: branches/ros-amd64-bringup/reactos/dll/directx/dsound/dsound.rbuild URL: http://svn.reactos.org/svn/reactos/branches/ros-amd64-bringup/reactos/dll/d… Modified: branches/ros-amd64-bringup/reactos/dll/ntdll/def/ntdll_amd64.def URL: http://svn.reactos.org/svn/reactos/branches/ros-amd64-bringup/reactos/dll/n… Modified: branches/ros-amd64-bringup/reactos/dll/shellext/deskadp/deskadp.rbuild URL: http://svn.reactos.org/svn/reactos/branches/ros-amd64-bringup/reactos/dll/s… Modified: branches/ros-amd64-bringup/reactos/dll/shellext/deskmon/deskmon.rbuild URL: http://svn.reactos.org/svn/reactos/branches/ros-amd64-bringup/reactos/dll/s… Modified: branches/ros-amd64-bringup/reactos/dll/shellext/fontext/fontext.rbuild URL: http://svn.reactos.org/svn/reactos/branches/ros-amd64-bringup/reactos/dll/s… Modified: branches/ros-amd64-bringup/reactos/dll/win32/advapi32/advapi32.spec URL: http://svn.reactos.org/svn/reactos/branches/ros-amd64-bringup/reactos/dll/w… Modified: branches/ros-amd64-bringup/reactos/dll/win32/advapi32/sec/misc.c URL: http://svn.reactos.org/svn/reactos/branches/ros-amd64-bringup/reactos/dll/w… Modified: branches/ros-amd64-bringup/reactos/dll/win32/dbghelp/regex.c URL: http://svn.reactos.org/svn/reactos/branches/ros-amd64-bringup/reactos/dll/w… Modified: branches/ros-amd64-bringup/reactos/dll/win32/dhcpcsvc/dhcpcsvc.rbuild URL: http://svn.reactos.org/svn/reactos/branches/ros-amd64-bringup/reactos/dll/w… Modified: branches/ros-amd64-bringup/reactos/dll/win32/dnsapi/dnsapi.rbuild URL: http://svn.reactos.org/svn/reactos/branches/ros-amd64-bringup/reactos/dll/w… Modified: branches/ros-amd64-bringup/reactos/dll/win32/gdi32/gdi32.rbuild URL: http://svn.reactos.org/svn/reactos/branches/ros-amd64-bringup/reactos/dll/w… Modified: branches/ros-amd64-bringup/reactos/dll/win32/glu32/glu32.rbuild URL: http://svn.reactos.org/svn/reactos/branches/ros-amd64-bringup/reactos/dll/w… Modified: branches/ros-amd64-bringup/reactos/dll/win32/icmp/icmp.rbuild URL: http://svn.reactos.org/svn/reactos/branches/ros-amd64-bringup/reactos/dll/w… Modified: branches/ros-amd64-bringup/reactos/dll/win32/kernel32/kernel32.spec URL: http://svn.reactos.org/svn/reactos/branches/ros-amd64-bringup/reactos/dll/w… Modified: branches/ros-amd64-bringup/reactos/dll/win32/kernel32/misc/dllmain.c URL: http://svn.reactos.org/svn/reactos/branches/ros-amd64-bringup/reactos/dll/w… Modified: branches/ros-amd64-bringup/reactos/dll/win32/kernel32/misc/errormsg.c URL: http://svn.reactos.org/svn/reactos/branches/ros-amd64-bringup/reactos/dll/w… Modified: branches/ros-amd64-bringup/reactos/dll/win32/kernel32/misc/toolhelp.c URL: http://svn.reactos.org/svn/reactos/branches/ros-amd64-bringup/reactos/dll/w… Modified: branches/ros-amd64-bringup/reactos/dll/win32/kernel32/synch/critical.c URL: http://svn.reactos.org/svn/reactos/branches/ros-amd64-bringup/reactos/dll/w… Modified: branches/ros-amd64-bringup/reactos/dll/win32/kernel32/thread/amd64/fiber.S URL: http://svn.reactos.org/svn/reactos/branches/ros-amd64-bringup/reactos/dll/w… Modified: branches/ros-amd64-bringup/reactos/dll/win32/kernel32/thread/amd64/thread.S URL: http://svn.reactos.org/svn/reactos/branches/ros-amd64-bringup/reactos/dll/w… Modified: branches/ros-amd64-bringup/reactos/dll/win32/msvcrt/msvcrt.def URL: http://svn.reactos.org/svn/reactos/branches/ros-amd64-bringup/reactos/dll/w… Modified: branches/ros-amd64-bringup/reactos/dll/win32/opengl32/opengl32.h URL: http://svn.reactos.org/svn/reactos/branches/ros-amd64-bringup/reactos/dll/w… Modified: branches/ros-amd64-bringup/reactos/dll/win32/shell32/autocomplete.c URL: http://svn.reactos.org/svn/reactos/branches/ros-amd64-bringup/reactos/dll/w… Modified: branches/ros-amd64-bringup/reactos/dll/win32/shell32/changenotify.c URL: http://svn.reactos.org/svn/reactos/branches/ros-amd64-bringup/reactos/dll/w… Modified: branches/ros-amd64-bringup/reactos/dll/win32/user32/include/dde_private.h URL: http://svn.reactos.org/svn/reactos/branches/ros-amd64-bringup/reactos/dll/w… Modified: branches/ros-amd64-bringup/reactos/dll/win32/user32/include/user32.h URL: http://svn.reactos.org/svn/reactos/branches/ros-amd64-bringup/reactos/dll/w… Modified: branches/ros-amd64-bringup/reactos/dll/win32/user32/misc/dde.c URL: http://svn.reactos.org/svn/reactos/branches/ros-amd64-bringup/reactos/dll/w… Modified: branches/ros-amd64-bringup/reactos/dll/win32/user32/misc/ddeserver.c URL: http://svn.reactos.org/svn/reactos/branches/ros-amd64-bringup/reactos/dll/w… Removed: branches/ros-amd64-bringup/reactos/dll/win32/user32/user32.def URL: http://svn.reactos.org/svn/reactos/branches/ros-amd64-bringup/reactos/dll/w… Modified: branches/ros-amd64-bringup/reactos/dll/win32/user32/user32.rbuild URL: http://svn.reactos.org/svn/reactos/branches/ros-amd64-bringup/reactos/dll/w… Added: branches/ros-amd64-bringup/reactos/dll/win32/user32/user32.spec URL: http://svn.reactos.org/svn/reactos/branches/ros-amd64-bringup/reactos/dll/w… Modified: branches/ros-amd64-bringup/reactos/dll/win32/user32/windows/draw.c URL: http://svn.reactos.org/svn/reactos/branches/ros-amd64-bringup/reactos/dll/w… Modified: branches/ros-amd64-bringup/reactos/dll/win32/user32/windows/menu.c URL: http://svn.reactos.org/svn/reactos/branches/ros-amd64-bringup/reactos/dll/w… Modified: branches/ros-amd64-bringup/reactos/dll/win32/winmm/midimap/midimap.rbuild URL: http://svn.reactos.org/svn/reactos/branches/ros-amd64-bringup/reactos/dll/w… Modified: branches/ros-amd64-bringup/reactos/dll/win32/ws2_32/misc/stubs.c URL: http://svn.reactos.org/svn/reactos/branches/ros-amd64-bringup/reactos/dll/w… Modified: branches/ros-amd64-bringup/reactos/dll/win32/ws2_32/ws2_32.rbuild URL: http://svn.reactos.org/svn/reactos/branches/ros-amd64-bringup/reactos/dll/w… Added: branches/ros-amd64-bringup/reactos/dll/win32/ws2_32/ws2_32.spec URL: http://svn.reactos.org/svn/reactos/branches/ros-amd64-bringup/reactos/dll/w…

1 0

[cgutman] 35654: - Merge r35653 from aicom-network-fixes - Fixes a major leak when closing Firefox
by cgutman＠svn.reactos.org 26 Aug '08

26 Aug '08

Author: cgutman Date: Mon Aug 25 21:11:40 2008 New Revision: 35654 URL: http://svn.reactos.org/svn/reactos?rev=35654&view=rev Log: - Merge r35653 from aicom-network-fixes - Fixes a major leak when closing Firefox Modified: trunk/reactos/lib/drivers/ip/transport/tcp/tcp.c Modified: trunk/reactos/lib/drivers/ip/transport/tcp/tcp.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/drivers/ip/transport/t… ============================================================================== --- trunk/reactos/lib/drivers/ip/transport/tcp/tcp.c [iso-8859-1] (original) +++ trunk/reactos/lib/drivers/ip/transport/tcp/tcp.c [iso-8859-1] Mon Aug 25 21:11:40 2008 @@ -836,6 +836,7 @@ if( Bucket->Request.RequestContext == Irp ) { RemoveEntryList( &Bucket->Entry ); + PoolFreeBuffer( Bucket ); break; } }

1 0

[cgutman] 35653: - Fix a memory leak
by cgutman＠svn.reactos.org 26 Aug '08

26 Aug '08

Author: cgutman Date: Mon Aug 25 19:47:22 2008 New Revision: 35653 URL: http://svn.reactos.org/svn/reactos?rev=35653&view=rev Log: - Fix a memory leak Modified: branches/aicom-network-fixes/lib/drivers/ip/transport/tcp/tcp.c Modified: branches/aicom-network-fixes/lib/drivers/ip/transport/tcp/tcp.c URL: http://svn.reactos.org/svn/reactos/branches/aicom-network-fixes/lib/drivers… ============================================================================== --- branches/aicom-network-fixes/lib/drivers/ip/transport/tcp/tcp.c [iso-8859-1] (original) +++ branches/aicom-network-fixes/lib/drivers/ip/transport/tcp/tcp.c [iso-8859-1] Mon Aug 25 19:47:22 2008 @@ -836,6 +836,7 @@ if( Bucket->Request.RequestContext == Irp ) { RemoveEntryList( &Bucket->Entry ); + PoolFreeBuffer( Bucket ); break; } }

1 0

[sserapion] 35652: More header fixes.
by sserapion＠svn.reactos.org 26 Aug '08

26 Aug '08

Author: sserapion Date: Mon Aug 25 19:26:42 2008 New Revision: 35652 URL: http://svn.reactos.org/svn/reactos?rev=35652&view=rev Log: More header fixes. Modified: branches/ros-amd64-bringup/reactos/include/psdk/prsht.h branches/ros-amd64-bringup/reactos/include/psdk/shellapi.h Modified: branches/ros-amd64-bringup/reactos/include/psdk/prsht.h URL: http://svn.reactos.org/svn/reactos/branches/ros-amd64-bringup/reactos/inclu… ============================================================================== --- branches/ros-amd64-bringup/reactos/include/psdk/prsht.h [iso-8859-1] (original) +++ branches/ros-amd64-bringup/reactos/include/psdk/prsht.h [iso-8859-1] Mon Aug 25 19:26:42 2008 @@ -287,8 +287,8 @@ HPROPSHEETPAGE WINAPI CreatePropertySheetPageA(LPCPROPSHEETPAGEA); HPROPSHEETPAGE WINAPI CreatePropertySheetPageW(LPCPROPSHEETPAGEW); BOOL WINAPI DestroyPropertySheetPage(HPROPSHEETPAGE); -int WINAPI PropertySheetA(LPCPROPSHEETHEADERA); -int WINAPI PropertySheetW(LPCPROPSHEETHEADERW); +INT_PTR WINAPI PropertySheetA(LPCPROPSHEETHEADERA); +INT_PTR WINAPI PropertySheetW(LPCPROPSHEETHEADERW); #define PropSheet_AddPage(d,p) SendMessage(d,PSM_ADDPAGE,0,(LPARAM)p) #define PropSheet_Apply(d) SendMessage(d,PSM_APPLY,0,0) #define PropSheet_CancelToClose(d) SendMessage(d,PSM_CANCELTOCLOSE,0,0) Modified: branches/ros-amd64-bringup/reactos/include/psdk/shellapi.h URL: http://svn.reactos.org/svn/reactos/branches/ros-amd64-bringup/reactos/inclu… ============================================================================== --- branches/ros-amd64-bringup/reactos/include/psdk/shellapi.h [iso-8859-1] (original) +++ branches/ros-amd64-bringup/reactos/include/psdk/shellapi.h [iso-8859-1] Mon Aug 25 19:26:42 2008 @@ -334,8 +334,8 @@ int WINAPI SHFileOperationA(LPSHFILEOPSTRUCTA); int WINAPI SHFileOperationW(LPSHFILEOPSTRUCTW); void WINAPI SHFreeNameMappings(HANDLE); -DWORD WINAPI SHGetFileInfoA(LPCSTR,DWORD,SHFILEINFOA*,UINT,UINT); -DWORD WINAPI SHGetFileInfoW(LPCWSTR,DWORD,SHFILEINFOW*,UINT,UINT); +DWORD_PTR WINAPI SHGetFileInfoA(LPCSTR,DWORD,SHFILEINFOA*,UINT,UINT); +DWORD_PTR WINAPI SHGetFileInfoW(LPCWSTR,DWORD,SHFILEINFOW*,UINT,UINT); BOOL WINAPI SHGetNewLinkInfoA(LPCSTR,LPCSTR,LPSTR,BOOL*,UINT); BOOL WINAPI SHGetNewLinkInfoW(LPCWSTR,LPCWSTR,LPWSTR,BOOL*,UINT); HRESULT WINAPI SHQueryRecycleBinA(LPCSTR, LPSHQUERYRBINFO);

1 0

[sserapion] 35651: Don't error on non-32bit builds. Still needs port.
by sserapion＠svn.reactos.org 25 Aug '08

25 Aug '08

Author: sserapion Date: Mon Aug 25 18:57:51 2008 New Revision: 35651 URL: http://svn.reactos.org/svn/reactos?rev=35651&view=rev Log: Don't error on non-32bit builds. Still needs port. Modified: branches/ros-amd64-bringup/reactos/tools/widl/server.c Modified: branches/ros-amd64-bringup/reactos/tools/widl/server.c URL: http://svn.reactos.org/svn/reactos/branches/ros-amd64-bringup/reactos/tools… ============================================================================== --- branches/ros-amd64-bringup/reactos/tools/widl/server.c [iso-8859-1] (original) +++ branches/ros-amd64-bringup/reactos/tools/widl/server.c [iso-8859-1] Mon Aug 25 18:57:51 2008 @@ -442,7 +442,7 @@ write_function_stubs(iface->iface, &proc_offset); print_server("#if !defined(__RPC_WIN32__)\n"); - print_server("#error Invalid build platform for this stub.\n"); + print_server("//#error Invalid build platform for this stub.\n"); print_server("#endif\n"); fprintf(server, "\n");

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs