Ros-diffs

ros-diffs@reactos.org

81390 discussions

[jimtabor] 34286: Add warning for GetLastActivePopup.
by jimtabor＠svn.reactos.org 03 Jul '08

03 Jul '08

Author: jimtabor Date: Thu Jul 3 13:19:16 2008 New Revision: 34286 URL: http://svn.reactos.org/svn/reactos?rev=34286&view=rev Log: Add warning for GetLastActivePopup. Modified: trunk/reactos/dll/win32/user32/windows/window.c Modified: trunk/reactos/dll/win32/user32/windows/window.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/w… ============================================================================== --- trunk/reactos/dll/win32/user32/windows/window.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/user32/windows/window.c [iso-8859-1] Thu Jul 3 13:19:16 2008 @@ -923,7 +923,7 @@ { PWINDOW Wnd, WndParent; HWND Ret = NULL; - + WARN("Not fully implemented!"); Wnd = ValidateHwnd(hWnd); if (Wnd != NULL) {

1 0

[janderwald] 34285: - add an empty dialog resource - implement initializing the dialog - fixes bug 3443
by janderwald＠svn.reactos.org 03 Jul '08

03 Jul '08

Author: janderwald Date: Thu Jul 3 11:46:39 2008 New Revision: 34285 URL: http://svn.reactos.org/svn/reactos?rev=34285&view=rev Log: - add an empty dialog resource - implement initializing the dialog - fixes bug 3443 Modified: trunk/reactos/dll/cpl/telephon/lang/bg-BG.rc trunk/reactos/dll/cpl/telephon/lang/de-DE.rc trunk/reactos/dll/cpl/telephon/lang/el-GR.rc trunk/reactos/dll/cpl/telephon/lang/en-US.rc trunk/reactos/dll/cpl/telephon/lang/es-ES.rc trunk/reactos/dll/cpl/telephon/lang/fr-FR.rc trunk/reactos/dll/cpl/telephon/lang/it-IT.rc trunk/reactos/dll/cpl/telephon/lang/pl-PL.rc trunk/reactos/dll/cpl/telephon/lang/ru-RU.rc trunk/reactos/dll/cpl/telephon/lang/sk-SK.rc trunk/reactos/dll/cpl/telephon/lang/uk-UA.rc trunk/reactos/dll/cpl/telephon/resource.h trunk/reactos/dll/cpl/telephon/telephon.c Modified: trunk/reactos/dll/cpl/telephon/lang/bg-BG.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/cpl/telephon/lang/bg-B… ============================================================================== --- trunk/reactos/dll/cpl/telephon/lang/bg-BG.rc [iso-8859-1] (original) +++ trunk/reactos/dll/cpl/telephon/lang/bg-BG.rc [iso-8859-1] Thu Jul 3 11:46:39 2008 @@ -1,4 +1,11 @@ LANGUAGE LANG_BULGARIAN, SUBLANG_DEFAULT + +IDD_PROPPAGE DIALOGEX 0, 0, 246, 230 +STYLE DS_SHELLFONT | WS_CHILD | WS_DISABLED | WS_CAPTION +CAPTION "" +FONT 8, "MS Shell Dlg" +BEGIN +END STRINGTABLE BEGIN Modified: trunk/reactos/dll/cpl/telephon/lang/de-DE.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/cpl/telephon/lang/de-D… ============================================================================== --- trunk/reactos/dll/cpl/telephon/lang/de-DE.rc [iso-8859-1] (original) +++ trunk/reactos/dll/cpl/telephon/lang/de-DE.rc [iso-8859-1] Thu Jul 3 11:46:39 2008 @@ -1,4 +1,11 @@ LANGUAGE LANG_GERMAN, SUBLANG_NEUTRAL + +IDD_PROPPAGE DIALOGEX 0, 0, 246, 230 +STYLE DS_SHELLFONT | WS_CHILD | WS_DISABLED | WS_CAPTION +CAPTION "" +FONT 8, "MS Shell Dlg" +BEGIN +END STRINGTABLE BEGIN Modified: trunk/reactos/dll/cpl/telephon/lang/el-GR.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/cpl/telephon/lang/el-G… ============================================================================== --- trunk/reactos/dll/cpl/telephon/lang/el-GR.rc [iso-8859-1] (original) +++ trunk/reactos/dll/cpl/telephon/lang/el-GR.rc [iso-8859-1] Thu Jul 3 11:46:39 2008 @@ -1,4 +1,11 @@ LANGUAGE LANG_GREEK, SUBLANG_DEFAULT + +IDD_PROPPAGE DIALOGEX 0, 0, 246, 230 +STYLE DS_SHELLFONT | WS_CHILD | WS_DISABLED | WS_CAPTION +CAPTION "" +FONT 8, "MS Shell Dlg" +BEGIN +END STRINGTABLE BEGIN Modified: trunk/reactos/dll/cpl/telephon/lang/en-US.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/cpl/telephon/lang/en-U… ============================================================================== --- trunk/reactos/dll/cpl/telephon/lang/en-US.rc [iso-8859-1] (original) +++ trunk/reactos/dll/cpl/telephon/lang/en-US.rc [iso-8859-1] Thu Jul 3 11:46:39 2008 @@ -1,4 +1,11 @@ LANGUAGE LANG_ENGLISH, SUBLANG_ENGLISH_US + +IDD_PROPPAGE DIALOGEX 0, 0, 246, 230 +STYLE DS_SHELLFONT | WS_CHILD | WS_DISABLED | WS_CAPTION +CAPTION "" +FONT 8, "MS Shell Dlg" +BEGIN +END STRINGTABLE BEGIN Modified: trunk/reactos/dll/cpl/telephon/lang/es-ES.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/cpl/telephon/lang/es-E… ============================================================================== --- trunk/reactos/dll/cpl/telephon/lang/es-ES.rc [iso-8859-1] (original) +++ trunk/reactos/dll/cpl/telephon/lang/es-ES.rc [iso-8859-1] Thu Jul 3 11:46:39 2008 @@ -1,4 +1,11 @@ LANGUAGE LANG_SPANISH, SUBLANG_NEUTRAL + +IDD_PROPPAGE DIALOGEX 0, 0, 246, 230 +STYLE DS_SHELLFONT | WS_CHILD | WS_DISABLED | WS_CAPTION +CAPTION "" +FONT 8, "MS Shell Dlg" +BEGIN +END STRINGTABLE BEGIN Modified: trunk/reactos/dll/cpl/telephon/lang/fr-FR.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/cpl/telephon/lang/fr-F… ============================================================================== --- trunk/reactos/dll/cpl/telephon/lang/fr-FR.rc [iso-8859-1] (original) +++ trunk/reactos/dll/cpl/telephon/lang/fr-FR.rc [iso-8859-1] Thu Jul 3 11:46:39 2008 @@ -1,4 +1,11 @@ LANGUAGE LANG_FRENCH, SUBLANG_NEUTRAL + +IDD_PROPPAGE DIALOGEX 0, 0, 246, 230 +STYLE DS_SHELLFONT | WS_CHILD | WS_DISABLED | WS_CAPTION +CAPTION "" +FONT 8, "MS Shell Dlg" +BEGIN +END STRINGTABLE BEGIN Modified: trunk/reactos/dll/cpl/telephon/lang/it-IT.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/cpl/telephon/lang/it-I… ============================================================================== --- trunk/reactos/dll/cpl/telephon/lang/it-IT.rc [iso-8859-1] (original) +++ trunk/reactos/dll/cpl/telephon/lang/it-IT.rc [iso-8859-1] Thu Jul 3 11:46:39 2008 @@ -1,4 +1,11 @@ LANGUAGE LANG_ITALIAN, SUBLANG_NEUTRAL + +IDD_PROPPAGE DIALOGEX 0, 0, 246, 230 +STYLE DS_SHELLFONT | WS_CHILD | WS_DISABLED | WS_CAPTION +CAPTION "" +FONT 8, "MS Shell Dlg" +BEGIN +END STRINGTABLE BEGIN Modified: trunk/reactos/dll/cpl/telephon/lang/pl-PL.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/cpl/telephon/lang/pl-P… ============================================================================== --- trunk/reactos/dll/cpl/telephon/lang/pl-PL.rc [iso-8859-1] (original) +++ trunk/reactos/dll/cpl/telephon/lang/pl-PL.rc [iso-8859-1] Thu Jul 3 11:46:39 2008 @@ -7,6 +7,13 @@ LANGUAGE LANG_POLISH, SUBLANG_DEFAULT +IDD_PROPPAGE DIALOGEX 0, 0, 246, 230 +STYLE DS_SHELLFONT | WS_CHILD | WS_DISABLED | WS_CAPTION +CAPTION "" +FONT 8, "MS Shell Dlg" +BEGIN +END + STRINGTABLE BEGIN IDS_CPLSYSTEMNAME "Opcje telefonu i modemu" Modified: trunk/reactos/dll/cpl/telephon/lang/ru-RU.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/cpl/telephon/lang/ru-R… ============================================================================== --- trunk/reactos/dll/cpl/telephon/lang/ru-RU.rc [iso-8859-1] (original) +++ trunk/reactos/dll/cpl/telephon/lang/ru-RU.rc [iso-8859-1] Thu Jul 3 11:46:39 2008 @@ -1,4 +1,11 @@ LANGUAGE LANG_RUSSIAN, SUBLANG_DEFAULT + +IDD_PROPPAGE DIALOGEX 0, 0, 246, 230 +STYLE DS_SHELLFONT | WS_CHILD | WS_DISABLED | WS_CAPTION +CAPTION "" +FONT 8, "MS Shell Dlg" +BEGIN +END STRINGTABLE BEGIN Modified: trunk/reactos/dll/cpl/telephon/lang/sk-SK.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/cpl/telephon/lang/sk-S… ============================================================================== --- trunk/reactos/dll/cpl/telephon/lang/sk-SK.rc [iso-8859-1] (original) +++ trunk/reactos/dll/cpl/telephon/lang/sk-SK.rc [iso-8859-1] Thu Jul 3 11:46:39 2008 @@ -1,4 +1,11 @@ LANGUAGE LANG_SLOVAK, SUBLANG_DEFAULT + +IDD_PROPPAGE DIALOGEX 0, 0, 246, 230 +STYLE DS_SHELLFONT | WS_CHILD | WS_DISABLED | WS_CAPTION +CAPTION "" +FONT 8, "MS Shell Dlg" +BEGIN +END STRINGTABLE BEGIN Modified: trunk/reactos/dll/cpl/telephon/lang/uk-UA.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/cpl/telephon/lang/uk-U… ============================================================================== --- trunk/reactos/dll/cpl/telephon/lang/uk-UA.rc [iso-8859-1] (original) +++ trunk/reactos/dll/cpl/telephon/lang/uk-UA.rc [iso-8859-1] Thu Jul 3 11:46:39 2008 @@ -8,6 +8,13 @@ LANGUAGE LANG_UKRAINIAN, SUBLANG_DEFAULT +IDD_PROPPAGE DIALOGEX 0, 0, 246, 230 +STYLE DS_SHELLFONT | WS_CHILD | WS_DISABLED | WS_CAPTION +CAPTION "" +FONT 8, "MS Shell Dlg" +BEGIN +END + STRINGTABLE BEGIN IDS_CPLSYSTEMNAME "Òåëåôîí ³ ìîäåì" Modified: trunk/reactos/dll/cpl/telephon/resource.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/cpl/telephon/resource.… ============================================================================== --- trunk/reactos/dll/cpl/telephon/resource.h [iso-8859-1] (original) +++ trunk/reactos/dll/cpl/telephon/resource.h [iso-8859-1] Thu Jul 3 11:46:39 2008 @@ -4,6 +4,8 @@ /* icons */ #define IDI_CPLSYSTEM 100 +/* dialogs */ +#define IDD_PROPPAGE 200 /* strings */ #define IDS_CPLSYSTEMNAME 1001 #define IDS_CPLSYSTEMDESCRIPTION 2001 Modified: trunk/reactos/dll/cpl/telephon/telephon.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/cpl/telephon/telephon.… ============================================================================== --- trunk/reactos/dll/cpl/telephon/telephon.c [iso-8859-1] (original) +++ trunk/reactos/dll/cpl/telephon/telephon.c [iso-8859-1] Thu Jul 3 11:46:39 2008 @@ -41,6 +41,39 @@ {IDI_CPLSYSTEM, IDS_CPLSYSTEMNAME, IDS_CPLSYSTEMDESCRIPTION, SystemApplet} }; +/* Property page dialog callback */ +INT_PTR CALLBACK +TelephonPageProc(HWND hwndDlg, + UINT uMsg, + WPARAM wParam, + LPARAM lParam) +{ + UNREFERENCED_PARAMETER(lParam); + UNREFERENCED_PARAMETER(wParam); + + switch (uMsg) + { + case WM_INITDIALOG: + return TRUE; + } + + return FALSE; +} + + + +static VOID +InitPropSheetPage(PROPSHEETPAGE *psp, WORD idDlg, DLGPROC DlgProc) +{ + ZeroMemory(psp, sizeof(PROPSHEETPAGE)); + psp->dwSize = sizeof(PROPSHEETPAGE); + psp->dwFlags = PSP_DEFAULT; + psp->hInstance = hApplet; + psp->pszTemplate = MAKEINTRESOURCE(idDlg); + psp->pfnDlgProc = DlgProc; +} + + /* First Applet */ LONG CALLBACK SystemApplet(VOID) @@ -63,7 +96,7 @@ psh.ppsp = psp; psh.pfnCallback = NULL; - //InitPropSheetPage(&psp[0], IDD_PROPPAGE, (DLGPROC)PageProc); + InitPropSheetPage(&psp[0], IDD_PROPPAGE, (DLGPROC)TelephonPageProc); return (LONG)(PropertySheet(&psh) != -1); }

1 0

[jmorlan] 34284: Fix menu leaks in explorer
by jmorlan＠svn.reactos.org 03 Jul '08

03 Jul '08

Author: jmorlan Date: Thu Jul 3 10:58:37 2008 New Revision: 34284 URL: http://svn.reactos.org/svn/reactos?rev=34284&view=rev Log: Fix menu leaks in explorer Modified: trunk/reactos/base/shell/explorer/desktop/desktop.cpp trunk/reactos/base/shell/explorer/explorer.cpp trunk/reactos/base/shell/explorer/utility/shellclasses.cpp trunk/reactos/base/shell/explorer/utility/utility.h Modified: trunk/reactos/base/shell/explorer/desktop/desktop.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/shell/explorer/deskto… ============================================================================== --- trunk/reactos/base/shell/explorer/desktop/desktop.cpp [iso-8859-1] (original) +++ trunk/reactos/base/shell/explorer/desktop/desktop.cpp [iso-8859-1] Thu Jul 3 10:58:37 2008 @@ -656,6 +656,7 @@ } } else _cm_ifs.reset(); + DestroyMenu(hmenu); } pcm->Release(); Modified: trunk/reactos/base/shell/explorer/explorer.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/shell/explorer/explor… ============================================================================== --- trunk/reactos/base/shell/explorer/explorer.cpp [iso-8859-1] (original) +++ trunk/reactos/base/shell/explorer/explorer.cpp [iso-8859-1] Thu Jul 3 10:58:37 2008 @@ -855,6 +855,8 @@ { HMENU hMenu = LoadMenu(g_Globals._hInstance, MAKEINTRESOURCE(nid)); _hmenu = GetSubMenu(hMenu, 0); + RemoveMenu(hMenu, 0, MF_BYPOSITION); + DestroyMenu(hMenu); } Modified: trunk/reactos/base/shell/explorer/utility/shellclasses.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/shell/explorer/utilit… ============================================================================== --- trunk/reactos/base/shell/explorer/utility/shellclasses.cpp [iso-8859-1] (original) +++ trunk/reactos/base/shell/explorer/utility/shellclasses.cpp [iso-8859-1] Thu Jul 3 10:58:37 2008 @@ -566,6 +566,7 @@ } } else cm_ifs.reset(); + DestroyMenu(hmenu); } pcm->Release(); Modified: trunk/reactos/base/shell/explorer/utility/utility.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/shell/explorer/utilit… ============================================================================== --- trunk/reactos/base/shell/explorer/utility/utility.h [iso-8859-1] (original) +++ trunk/reactos/base/shell/explorer/utility/utility.h [iso-8859-1] Thu Jul 3 10:58:37 2008 @@ -663,6 +663,11 @@ { } + ~PopupMenu() + { + DestroyMenu(_hmenu); + } + PopupMenu(UINT nid); operator HMENU() {return _hmenu;}

1 0

[jmorlan] 34283: Don't use msvcrt functions in kernel32; it will cause bug 3373 to reappear
by jmorlan＠svn.reactos.org 03 Jul '08

03 Jul '08

Author: jmorlan Date: Thu Jul 3 09:57:37 2008 New Revision: 34283 URL: http://svn.reactos.org/svn/reactos?rev=34283&view=rev Log: Don't use msvcrt functions in kernel32; it will cause bug 3373 to reappear Modified: trunk/reactos/dll/win32/kernel32/misc/computername.c Modified: trunk/reactos/dll/win32/kernel32/misc/computername.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/misc/co… ============================================================================== --- trunk/reactos/dll/win32/kernel32/misc/computername.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/kernel32/misc/computername.c [iso-8859-1] Thu Jul 3 09:57:37 2008 @@ -298,7 +298,7 @@ p = (PWCHAR)lpComputerName; while (*p != 0) { - if (!(iswalnum(*p) || *p == L'!' || *p == L'@' || *p == L'#' || + if (!(iswctype(*p, _ALPHA | _DIGIT) || *p == L'!' || *p == L'@' || *p == L'#' || *p == L'$' || *p == L'%' || *p == L'^' || *p == L'&' || *p == L'\'' || *p == L')' || *p == L'(' || *p == L'.' || *p == L'-' || *p == L'_' || *p == L'{' || *p == L'}' || *p == L'~'))

1 0

[fireball] 34282: - Fix double linking of snprintf (_snprintf should be used in CRT). - Add a #undef guard for snprintf in consistency with how it previously was implemented in CRT.
by fireball＠svn.reactos.org 03 Jul '08

03 Jul '08

Author: fireball Date: Thu Jul 3 07:07:12 2008 New Revision: 34282 URL: http://svn.reactos.org/svn/reactos?rev=34282&view=rev Log: - Fix double linking of snprintf (_snprintf should be used in CRT). - Add a #undef guard for snprintf in consistency with how it previously was implemented in CRT. Modified: trunk/reactos/lib/sdk/crt/locale/locale.c trunk/reactos/lib/sdk/crt/string/wcs.c Modified: trunk/reactos/lib/sdk/crt/locale/locale.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/sdk/crt/locale/locale.… ============================================================================== --- trunk/reactos/lib/sdk/crt/locale/locale.c [iso-8859-1] (original) +++ trunk/reactos/lib/sdk/crt/locale/locale.c [iso-8859-1] Thu Jul 3 07:07:12 2008 @@ -489,7 +489,7 @@ MSVCRT_current_lc_all_lcid = lcid; - snprintf(MSVCRT_current_lc_all,MAX_LOCALE_LENGTH,"%s_%s.%s", + _snprintf(MSVCRT_current_lc_all,MAX_LOCALE_LENGTH,"%s_%s.%s", lc.found_language,lc.found_country,lc.found_codepage); switch (category) { Modified: trunk/reactos/lib/sdk/crt/string/wcs.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/sdk/crt/string/wcs.c?r… ============================================================================== --- trunk/reactos/lib/sdk/crt/string/wcs.c [iso-8859-1] (original) +++ trunk/reactos/lib/sdk/crt/string/wcs.c [iso-8859-1] Thu Jul 3 07:07:12 2008 @@ -48,6 +48,7 @@ #undef sprintf #undef wsprintf +#undef snprintf #undef vsnprintf #undef vprintf #undef vwprintf

1 0

[cwittich] 34281: fix a typo
by cwittich＠svn.reactos.org 03 Jul '08

03 Jul '08

Author: cwittich Date: Thu Jul 3 05:19:12 2008 New Revision: 34281 URL: http://svn.reactos.org/svn/reactos?rev=34281&view=rev Log: fix a typo Modified: trunk/reactos/base/applications/sndvol32/sndvol32.c Modified: trunk/reactos/base/applications/sndvol32/sndvol32.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/sndvol32… ============================================================================== --- trunk/reactos/base/applications/sndvol32/sndvol32.c [iso-8859-1] (original) +++ trunk/reactos/base/applications/sndvol32/sndvol32.c [iso-8859-1] Thu Jul 3 05:19:12 2008 @@ -848,7 +848,7 @@ } else { - DPRINT("Failed to creat application window (LastError: %d)!\n", GetLastError()); + DPRINT("Failed to create application window (LastError: %d)!\n", GetLastError()); } UnregisterApplicationClasses();

1 0

[pschweitzer] 34280: Stubbed NtfsGetNetworkOpenInformation
by pschweitzer＠svn.reactos.org 03 Jul '08

03 Jul '08

Author: pschweitzer Date: Thu Jul 3 04:15:46 2008 New Revision: 34280 URL: http://svn.reactos.org/svn/reactos?rev=34280&view=rev Log: Stubbed NtfsGetNetworkOpenInformation Modified: branches/pierre-fsd/drivers/filesystems/ntfs/finfo.c Modified: branches/pierre-fsd/drivers/filesystems/ntfs/finfo.c URL: http://svn.reactos.org/svn/reactos/branches/pierre-fsd/drivers/filesystems/… ============================================================================== --- branches/pierre-fsd/drivers/filesystems/ntfs/finfo.c [iso-8859-1] (original) +++ branches/pierre-fsd/drivers/filesystems/ntfs/finfo.c [iso-8859-1] Thu Jul 3 04:15:46 2008 @@ -177,10 +177,19 @@ return(STATUS_SUCCESS); } +static NTSTATUS +NtfsGetNetworkOpenInformation(PNTFS_FCB Fcb, + PNTFS_VCB Vcb, + PFILE_NETWORK_OPEN_INFORMATION NetworkInfo, + PULONG BufferLength) +{ + UNIMPLEMENTED; + return STATUS_SUCCESS; +} NTSTATUS NTAPI NtfsFsdQueryInformation(PDEVICE_OBJECT DeviceObject, - PIRP Irp) + PIRP Irp) /* * FUNCTION: Retrieve the specified file information */ @@ -189,6 +198,7 @@ PIO_STACK_LOCATION Stack; PFILE_OBJECT FileObject; PNTFS_FCB Fcb; + PNTFS_VCB Vcb; PVOID SystemBuffer; ULONG BufferLength; @@ -200,6 +210,7 @@ FileInformationClass = Stack->Parameters.QueryFile.FileInformationClass; FileObject = Stack->FileObject; Fcb = FileObject->FsContext; + Vcb = DeviceObject->DeviceExtension; SystemBuffer = Irp->AssociatedIrp.SystemBuffer; BufferLength = Stack->Parameters.QueryFile.Length; @@ -240,6 +251,12 @@ SystemBuffer, &BufferLength); break; + case FileNetworkOpenInformation: + Status = NtfsGetNetworkOpenInformation(Fcb, + Vcb, + SystemBuffer, + &BufferLength); + break; case FileAlternateNameInformation: case FileAllInformation:

1 0

[cwittich] 34279: fix a typo
by cwittich＠svn.reactos.org 03 Jul '08

03 Jul '08

Author: cwittich Date: Thu Jul 3 03:16:34 2008 New Revision: 34279 URL: http://svn.reactos.org/svn/reactos?rev=34279&view=rev Log: fix a typo Modified: trunk/reactos/drivers/base/kdcom/kdbg.c Modified: trunk/reactos/drivers/base/kdcom/kdbg.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/base/kdcom/kdbg.c?… ============================================================================== --- trunk/reactos/drivers/base/kdcom/kdbg.c [iso-8859-1] (original) +++ trunk/reactos/drivers/base/kdcom/kdbg.c [iso-8859-1] Thu Jul 3 03:16:34 2008 @@ -275,7 +275,7 @@ sprintf(buffer, "\nSerial port COM%ld found at 0x%lx\n", PortInformation->ComPort, - ComPortBase]; + ComPortBase); HalDisplayString(buffer); #endif /* NDEBUG */

1 0

[pschweitzer] 34278: Apply same fix to trunk, but without commented out code. This fixes ReactOS freezes when installing VMware driver using vmwinst and browsing a NTFS volume...
by pschweitzer＠svn.reactos.org 03 Jul '08

03 Jul '08

Author: pschweitzer Date: Thu Jul 3 02:32:14 2008 New Revision: 34278 URL: http://svn.reactos.org/svn/reactos?rev=34278&view=rev Log: Apply same fix to trunk, but without commented out code. This fixes ReactOS freezes when installing VMware driver using vmwinst and browsing a NTFS volume... Modified: trunk/reactos/drivers/filesystems/ntfs/fcb.c Modified: trunk/reactos/drivers/filesystems/ntfs/fcb.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/ntfs/f… ============================================================================== --- trunk/reactos/drivers/filesystems/ntfs/fcb.c [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/ntfs/fcb.c [iso-8859-1] Thu Jul 3 02:32:14 2008 @@ -99,8 +99,6 @@ ExInitializeResourceLite(&Fcb->MainResource); Fcb->RFCB.Resource = &(Fcb->MainResource); - - InsertTailList(&(Vcb->FcbListHead), &(Fcb->FcbListEntry)); return(Fcb); } @@ -113,8 +111,6 @@ ASSERT(Fcb->Identifier.Type == NTFS_TYPE_FCB); ExDeleteResourceLite(&Fcb->MainResource); - - RemoveEntryList(&(Fcb->FcbListEntry)); ExFreePool(Fcb); }

1 0

[pschweitzer] 34277: When dealing with FCBs list, it must be done synchronized. Because it still freezes, it's commented out. Lists won't be used yet.
by pschweitzer＠svn.reactos.org 03 Jul '08

03 Jul '08

Author: pschweitzer Date: Thu Jul 3 02:30:50 2008 New Revision: 34277 URL: http://svn.reactos.org/svn/reactos?rev=34277&view=rev Log: When dealing with FCBs list, it must be done synchronized. Because it still freezes, it's commented out. Lists won't be used yet. Modified: branches/pierre-fsd/drivers/filesystems/ntfs/fcb.c Modified: branches/pierre-fsd/drivers/filesystems/ntfs/fcb.c URL: http://svn.reactos.org/svn/reactos/branches/pierre-fsd/drivers/filesystems/… ============================================================================== --- branches/pierre-fsd/drivers/filesystems/ntfs/fcb.c [iso-8859-1] (original) +++ branches/pierre-fsd/drivers/filesystems/ntfs/fcb.c [iso-8859-1] Thu Jul 3 02:30:50 2008 @@ -97,10 +97,11 @@ } ExInitializeResourceLite(&Fcb->MainResource); - Fcb->RFCB.Resource = &(Fcb->MainResource); - - InsertTailList(&(Vcb->FcbListHead), &(Fcb->FcbListEntry)); + +#if 0 + ExInterlockedInsertTailList(&(Vcb->FcbListHead), &(Fcb->FcbListEntry), &(Vcb->FcbListLock)); +#endif return(Fcb); } @@ -109,12 +110,20 @@ VOID NtfsDestroyFCB(PNTFS_FCB Fcb) { +#if 0 + KIRQL oldIrql; +#endif + ASSERT(Fcb); ASSERT(Fcb->Identifier.Type == NTFS_TYPE_FCB); ExDeleteResourceLite(&Fcb->MainResource); +#if 0 + KeAcquireSpinLock(&(Fcb->Vcb->FcbListLock), &oldIrql); RemoveEntryList(&(Fcb->FcbListEntry)); + KeReleaseSpinLock(&(Fcb->Vcb->FcbListLock), oldIrql); +#endif ExFreePool(Fcb); }

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs