Ros-diffs

ros-diffs@reactos.org

81390 discussions

[hpoussin] 33311: Fix indentation
by hpoussin＠svn.reactos.org 06 May '08

06 May '08

Author: hpoussin Date: Tue May 6 01:57:05 2008 New Revision: 33311 URL: http://svn.reactos.org/svn/reactos?rev=33311&view=rev Log: Fix indentation Modified: trunk/reactos/drivers/filesystems/fastfat/dirwr.c Modified: trunk/reactos/drivers/filesystems/fastfat/dirwr.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/fastfa… ============================================================================== --- trunk/reactos/drivers/filesystems/fastfat/dirwr.c [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/fastfat/dirwr.c [iso-8859-1] Tue May 6 01:57:05 2008 @@ -11,728 +11,718 @@ #define NDEBUG #include "vfat.h" -NTSTATUS -VfatUpdateEntry (PVFATFCB pFcb) /* * update an existing FAT entry */ +NTSTATUS +VfatUpdateEntry( + IN PVFATFCB pFcb) { - PVOID Context; - PDIR_ENTRY PinEntry; - LARGE_INTEGER Offset; - ULONG SizeDirEntry; - ULONG dirIndex; - - ASSERT(pFcb); - ASSERT(pFcb->parentFcb); - - if (pFcb->Flags & FCB_IS_FATX_ENTRY) - { - SizeDirEntry = sizeof(FATX_DIR_ENTRY); - dirIndex = pFcb->startIndex; - } - else - { - SizeDirEntry = sizeof(FAT_DIR_ENTRY); - dirIndex = pFcb->dirIndex; - } - - DPRINT ("updEntry dirIndex %d, PathName \'%wZ\'\n", dirIndex, &pFcb->PathNameU); - - if (vfatFCBIsRoot(pFcb) || (pFcb->Flags & (FCB_IS_FAT|FCB_IS_VOLUME))) - { - return STATUS_SUCCESS; - } - - ASSERT (pFcb->parentFcb); - - Offset.u.HighPart = 0; - Offset.u.LowPart = dirIndex * SizeDirEntry; - if (CcPinRead (pFcb->parentFcb->FileObject, &Offset, SizeDirEntry, - TRUE, &Context, (PVOID*)&PinEntry)) - { - pFcb->Flags &= ~FCB_IS_DIRTY; - RtlCopyMemory(PinEntry, &pFcb->entry, SizeDirEntry); - CcSetDirtyPinnedData(Context, NULL); - CcUnpinData(Context); - return STATUS_SUCCESS; - } - else - { - DPRINT1 ("Failed write to \'%wZ\'.\n", &pFcb->parentFcb->PathNameU); - return STATUS_UNSUCCESSFUL; + PVOID Context; + PDIR_ENTRY PinEntry; + LARGE_INTEGER Offset; + ULONG SizeDirEntry; + ULONG dirIndex; + + ASSERT(pFcb); + ASSERT(pFcb->parentFcb); + + if (pFcb->Flags & FCB_IS_FATX_ENTRY) + { + SizeDirEntry = sizeof(FATX_DIR_ENTRY); + dirIndex = pFcb->startIndex; + } + else + { + SizeDirEntry = sizeof(FAT_DIR_ENTRY); + dirIndex = pFcb->dirIndex; + } + + DPRINT("updEntry dirIndex %d, PathName \'%wZ\'\n", dirIndex, &pFcb->PathNameU); + + if (vfatFCBIsRoot(pFcb) || (pFcb->Flags & (FCB_IS_FAT|FCB_IS_VOLUME))) + { + return STATUS_SUCCESS; + } + + ASSERT(pFcb->parentFcb); + + Offset.u.HighPart = 0; + Offset.u.LowPart = dirIndex * SizeDirEntry; + if (CcPinRead(pFcb->parentFcb->FileObject, &Offset, SizeDirEntry, + TRUE, &Context, (PVOID*)&PinEntry)) + { + pFcb->Flags &= ~FCB_IS_DIRTY; + RtlCopyMemory(PinEntry, &pFcb->entry, SizeDirEntry); + CcSetDirtyPinnedData(Context, NULL); + CcUnpinData(Context); + return STATUS_SUCCESS; + } + else + { + DPRINT1("Failed write to \'%wZ\'.\n", &pFcb->parentFcb->PathNameU); + return STATUS_UNSUCCESSFUL; } } -BOOLEAN -vfatFindDirSpace(PDEVICE_EXTENSION DeviceExt, - PVFATFCB pDirFcb, - ULONG nbSlots, - PULONG start) -{ /* * try to find contiguous entries frees in directory, * extend a directory if is neccesary */ - LARGE_INTEGER FileOffset; - ULONG i, count, size, nbFree = 0; - PDIR_ENTRY pFatEntry; - PVOID Context = NULL; - NTSTATUS Status; - ULONG SizeDirEntry; - FileOffset.QuadPart = 0; - - if (DeviceExt->Flags & VCB_IS_FATX) - SizeDirEntry = sizeof(FATX_DIR_ENTRY); - else - SizeDirEntry = sizeof(FAT_DIR_ENTRY); - - count = pDirFcb->RFCB.FileSize.u.LowPart / SizeDirEntry; - size = DeviceExt->FatInfo.BytesPerCluster / SizeDirEntry; - for (i = 0; i < count; i++, pFatEntry = (PDIR_ENTRY)((ULONG_PTR)pFatEntry + SizeDirEntry)) - { - if (Context == NULL || (i % size) == 0) - { - if (Context) - { +BOOLEAN +vfatFindDirSpace( + IN PDEVICE_EXTENSION DeviceExt, + IN PVFATFCB pDirFcb, + IN ULONG nbSlots, + OUT PULONG start) +{ + LARGE_INTEGER FileOffset; + ULONG i, count, size, nbFree = 0; + PDIR_ENTRY pFatEntry; + PVOID Context = NULL; + NTSTATUS Status; + ULONG SizeDirEntry; + FileOffset.QuadPart = 0; + + if (DeviceExt->Flags & VCB_IS_FATX) + SizeDirEntry = sizeof(FATX_DIR_ENTRY); + else + SizeDirEntry = sizeof(FAT_DIR_ENTRY); + + count = pDirFcb->RFCB.FileSize.u.LowPart / SizeDirEntry; + size = DeviceExt->FatInfo.BytesPerCluster / SizeDirEntry; + for (i = 0; i < count; i++, pFatEntry = (PDIR_ENTRY)((ULONG_PTR)pFatEntry + SizeDirEntry)) + { + if (Context == NULL || (i % size) == 0) + { + if (Context) + { + CcUnpinData(Context); + } + /* FIXME: check return value */ + CcPinRead(pDirFcb->FileObject, &FileOffset, DeviceExt->FatInfo.BytesPerCluster, + TRUE, &Context, (PVOID*)&pFatEntry); + FileOffset.u.LowPart += DeviceExt->FatInfo.BytesPerCluster; + } + if (ENTRY_END(DeviceExt, pFatEntry)) + { + break; + } + if (ENTRY_DELETED(DeviceExt, pFatEntry)) + { + nbFree++; + } + else + { + nbFree = 0; + } + if (nbFree == nbSlots) + { + break; + } + } + if (Context) + { CcUnpinData(Context); - } - // FIXME: check return value - CcPinRead (pDirFcb->FileObject, &FileOffset, DeviceExt->FatInfo.BytesPerCluster, - TRUE, &Context, (PVOID*)&pFatEntry); - FileOffset.u.LowPart += DeviceExt->FatInfo.BytesPerCluster; - } - if (ENTRY_END(DeviceExt, pFatEntry)) - { - break; - } - if (ENTRY_DELETED(DeviceExt, pFatEntry)) - { - nbFree++; - } - else - { - nbFree = 0; + Context = NULL; } if (nbFree == nbSlots) { - break; - } - } - if (Context) - { - CcUnpinData(Context); - Context = NULL; - } - if (nbFree == nbSlots) - { - // found enough contiguous free slots - *start = i - nbSlots + 1; - } - else - { - *start = i - nbFree; - if (*start + nbSlots > count) - { - LARGE_INTEGER AllocationSize; - CHECKPOINT; - // extend the directory - if (vfatFCBIsRoot(pDirFcb) && DeviceExt->FatInfo.FatType != FAT32) - { - // We can't extend a root directory on a FAT12/FAT16/FATX partition - return FALSE; - } - AllocationSize.QuadPart = pDirFcb->RFCB.FileSize.u.LowPart + DeviceExt->FatInfo.BytesPerCluster; - Status = VfatSetAllocationSizeInformation(pDirFcb->FileObject, pDirFcb, - DeviceExt, &AllocationSize); - if (!NT_SUCCESS(Status)) - { - return FALSE; - } - // clear the new dir cluster - FileOffset.u.LowPart = (ULONG)(pDirFcb->RFCB.FileSize.QuadPart - - DeviceExt->FatInfo.BytesPerCluster); - CcPinRead (pDirFcb->FileObject, &FileOffset, DeviceExt->FatInfo.BytesPerCluster, - TRUE, &Context, (PVOID*)&pFatEntry); - if (DeviceExt->Flags & VCB_IS_FATX) - memset(pFatEntry, 0xff, DeviceExt->FatInfo.BytesPerCluster); - else - RtlZeroMemory(pFatEntry, DeviceExt->FatInfo.BytesPerCluster); - } - else if (*start + nbSlots < count) - { - // clear the entry after the last new entry - FileOffset.u.LowPart = (*start + nbSlots) * SizeDirEntry; - CcPinRead (pDirFcb->FileObject, &FileOffset, SizeDirEntry, - TRUE, &Context, (PVOID*)&pFatEntry); - if (DeviceExt->Flags & VCB_IS_FATX) - memset(pFatEntry, 0xff, SizeDirEntry); - else - RtlZeroMemory(pFatEntry, SizeDirEntry); - } - if (Context) - { - CcSetDirtyPinnedData(Context, NULL); - CcUnpinData(Context); - } - } - DPRINT ("nbSlots %d nbFree %d, entry number %d\n", nbSlots, nbFree, *start); - return TRUE; + /* found enough contiguous free slots */ + *start = i - nbSlots + 1; + } + else + { + *start = i - nbFree; + if (*start + nbSlots > count) + { + LARGE_INTEGER AllocationSize; + CHECKPOINT; + /* extend the directory */ + if (vfatFCBIsRoot(pDirFcb) && DeviceExt->FatInfo.FatType != FAT32) + { + /* We can't extend a root directory on a FAT12/FAT16/FATX partition */ + return FALSE; + } + AllocationSize.QuadPart = pDirFcb->RFCB.FileSize.u.LowPart + DeviceExt->FatInfo.BytesPerCluster; + Status = VfatSetAllocationSizeInformation(pDirFcb->FileObject, pDirFcb, + DeviceExt, &AllocationSize); + if (!NT_SUCCESS(Status)) + { + return FALSE; + } + /* clear the new dir cluster */ + FileOffset.u.LowPart = (ULONG)(pDirFcb->RFCB.FileSize.QuadPart - + DeviceExt->FatInfo.BytesPerCluster); + CcPinRead(pDirFcb->FileObject, &FileOffset, DeviceExt->FatInfo.BytesPerCluster, + TRUE, &Context, (PVOID*)&pFatEntry); + if (DeviceExt->Flags & VCB_IS_FATX) + memset(pFatEntry, 0xff, DeviceExt->FatInfo.BytesPerCluster); + else + RtlZeroMemory(pFatEntry, DeviceExt->FatInfo.BytesPerCluster); + } + else if (*start + nbSlots < count) + { + /* clear the entry after the last new entry */ + FileOffset.u.LowPart = (*start + nbSlots) * SizeDirEntry; + CcPinRead(pDirFcb->FileObject, &FileOffset, SizeDirEntry, + TRUE, &Context, (PVOID*)&pFatEntry); + if (DeviceExt->Flags & VCB_IS_FATX) + memset(pFatEntry, 0xff, SizeDirEntry); + else + RtlZeroMemory(pFatEntry, SizeDirEntry); + } + if (Context) + { + CcSetDirtyPinnedData(Context, NULL); + CcUnpinData(Context); + } + } + DPRINT("nbSlots %d nbFree %d, entry number %d\n", nbSlots, nbFree, *start); + return TRUE; } -static NTSTATUS -FATAddEntry (PDEVICE_EXTENSION DeviceExt, - PUNICODE_STRING NameU, - PVFATFCB* Fcb, - PVFATFCB ParentFcb, - ULONG RequestedOptions, - UCHAR ReqAttr) /* create a new FAT entry */ +static NTSTATUS +FATAddEntry( + IN PDEVICE_EXTENSION DeviceExt, + IN PUNICODE_STRING NameU, + IN PVFATFCB* Fcb, + IN PVFATFCB ParentFcb, + IN ULONG RequestedOptions, + IN UCHAR ReqAttr) { - PVOID Context = NULL; - PFAT_DIR_ENTRY pFatEntry; - slot *pSlots; - USHORT nbSlots = 0, j, posCar; - PUCHAR Buffer; - BOOLEAN needTilde = FALSE, needLong = FALSE; - BOOLEAN lCaseBase = FALSE, uCaseBase, lCaseExt = FALSE, uCaseExt; - ULONG CurrentCluster; - LARGE_INTEGER SystemTime, FileOffset; - NTSTATUS Status = STATUS_SUCCESS; - ULONG size; - long i; - - OEM_STRING NameA; - CHAR aName[13]; - BOOLEAN IsNameLegal; - BOOLEAN SpacesFound; - - VFAT_DIRENTRY_CONTEXT DirContext; - WCHAR LongNameBuffer[LONGNAME_MAX_LENGTH + 1]; - WCHAR ShortNameBuffer[13]; - - DPRINT ("addEntry: Name='%wZ', Dir='%wZ'\n", NameU, &ParentFcb->PathNameU); - - DirContext.LongNameU = *NameU; - - nbSlots = (DirContext.LongNameU.Length / sizeof(WCHAR) + 12) / 13 + 1; //nb of entry needed for long name+normal entry - DPRINT ("NameLen= %d, nbSlots =%d\n", DirContext.LongNameU.Length / sizeof(WCHAR), nbSlots); - Buffer = ExAllocatePoolWithTag (NonPagedPool, (nbSlots - 1) * sizeof (FAT_DIR_ENTRY), TAG_VFAT); - if (Buffer == NULL) - { - return STATUS_INSUFFICIENT_RESOURCES; - } - RtlZeroMemory (Buffer, (nbSlots - 1) * sizeof (FAT_DIR_ENTRY)); - pSlots = (slot *) Buffer; - - NameA.Buffer = aName; - NameA.Length = 0; - NameA.MaximumLength = sizeof(aName); - - DirContext.ShortNameU.Buffer = ShortNameBuffer; - DirContext.ShortNameU.Length = 0; - DirContext.ShortNameU.MaximumLength = sizeof(ShortNameBuffer); - - RtlZeroMemory(&DirContext.DirEntry.Fat, sizeof(FAT_DIR_ENTRY)); - - IsNameLegal = RtlIsNameLegalDOS8Dot3(&DirContext.LongNameU, &NameA, &SpacesFound); - - if (!IsNameLegal || SpacesFound) - { - GENERATE_NAME_CONTEXT NameContext; - VFAT_DIRENTRY_CONTEXT SearchContext; - WCHAR ShortSearchName[13]; - needTilde = TRUE; - needLong = TRUE; - RtlZeroMemory(&NameContext, sizeof(GENERATE_NAME_CONTEXT)); - SearchContext.LongNameU.Buffer = LongNameBuffer; - SearchContext.LongNameU.MaximumLength = sizeof(LongNameBuffer); - SearchContext.ShortNameU.Buffer = ShortSearchName; - SearchContext.ShortNameU.MaximumLength = sizeof(ShortSearchName); - - for (i = 0; i < 100; i++) - { - RtlGenerate8dot3Name(&DirContext.LongNameU, FALSE, &NameContext, &DirContext.ShortNameU); - DirContext.ShortNameU.Buffer[DirContext.ShortNameU.Length / sizeof(WCHAR)] = 0; - SearchContext.DirIndex = 0; - Status = FindFile (DeviceExt, ParentFcb, &DirContext.ShortNameU, &SearchContext, TRUE); - if (!NT_SUCCESS(Status)) - { - break; - } - } - if (i == 100) /* FIXME : what to do after this ? */ - { - ExFreePool (Buffer); - CHECKPOINT; - return STATUS_UNSUCCESSFUL; - } - IsNameLegal = RtlIsNameLegalDOS8Dot3(&DirContext.ShortNameU, &NameA, &SpacesFound); - aName[NameA.Length]=0; - } - else - { - aName[NameA.Length] = 0; - for (posCar = 0; posCar < DirContext.LongNameU.Length / sizeof(WCHAR); posCar++) - { - if (DirContext.LongNameU.Buffer[posCar] == L'.') - { - break; - } - } - /* check if the name and the extension contains upper case characters */ - RtlDowncaseUnicodeString(&DirContext.ShortNameU, &DirContext.LongNameU, FALSE); - DirContext.ShortNameU.Buffer[DirContext.ShortNameU.Length / sizeof(WCHAR)] = 0; - uCaseBase = wcsncmp(DirContext.LongNameU.Buffer, - DirContext.ShortNameU.Buffer, posCar) ? TRUE : FALSE; - if (posCar < DirContext.LongNameU.Length/sizeof(WCHAR)) - { - i = DirContext.LongNameU.Length / sizeof(WCHAR) - posCar; - uCaseExt = wcsncmp(DirContext.LongNameU.Buffer + posCar, - DirContext.ShortNameU.Buffer + posCar, i) ? TRUE : FALSE; - } - else - { - uCaseExt = FALSE; - } - /* check if the name and the extension contains lower case characters */ - RtlUpcaseUnicodeString(&DirContext.ShortNameU, &DirContext.LongNameU, FALSE); - DirContext.ShortNameU.Buffer[DirContext.ShortNameU.Length / sizeof(WCHAR)] = 0; - lCaseBase = wcsncmp(DirContext.LongNameU.Buffer, - DirContext.ShortNameU.Buffer, posCar) ? TRUE : FALSE; - if (posCar < DirContext.LongNameU.Length / sizeof(WCHAR)) - { - i = DirContext.LongNameU.Length / sizeof(WCHAR) - posCar; - lCaseExt = wcsncmp(DirContext.LongNameU.Buffer + posCar, - DirContext.ShortNameU.Buffer + posCar, i) ? TRUE : FALSE; - } - else - { - lCaseExt = FALSE; - } - if ((lCaseBase && uCaseBase) || (lCaseExt && uCaseExt)) - { - needLong = TRUE; - } - } - DPRINT ("'%s', '%wZ', needTilde=%d, needLong=%d\n", - aName, &DirContext.LongNameU, needTilde, needLong); - memset(DirContext.DirEntry.Fat.ShortName, ' ', 11); - for (i = 0; i < 8 && aName[i] && aName[i] != '.'; i++) - { - DirContext.DirEntry.Fat.Filename[i] = aName[i]; - } - if (aName[i] == '.') - { - i++; - for (j = 0; j < 3 && aName[i]; j++, i++) - { - DirContext.DirEntry.Fat.Ext[j] = aName[i]; - } - } - if (DirContext.DirEntry.Fat.Filename[0] == 0xe5) - { - DirContext.DirEntry.Fat.Filename[0] = 0x05; - } - - if (needLong) - { - RtlCopyMemory(LongNameBuffer, DirContext.LongNameU.Buffer, DirContext.LongNameU.Length); - DirContext.LongNameU.Buffer = LongNameBuffer; - DirContext.LongNameU.MaximumLength = sizeof(LongNameBuffer); - DirContext.LongNameU.Buffer[DirContext.LongNameU.Length / sizeof(WCHAR)] = 0; - memset(DirContext.LongNameU.Buffer + DirContext.LongNameU.Length / sizeof(WCHAR) + 1, 0xff, - DirContext.LongNameU.MaximumLength - DirContext.LongNameU.Length - sizeof(WCHAR)); - } - else - { - nbSlots = 1; - if (lCaseBase) - { - DirContext.DirEntry.Fat.lCase |= VFAT_CASE_LOWER_BASE; - } - if (lCaseExt) - { - DirContext.DirEntry.Fat.lCase |= VFAT_CASE_LOWER_EXT; - } - } - - DPRINT ("dos name=%11.11s\n", DirContext.DirEntry.Fat.Filename); - - /* set attributes */ - DirContext.DirEntry.Fat.Attrib = ReqAttr; - if (RequestedOptions & FILE_DIRECTORY_FILE) - { - DirContext.DirEntry.Fat.Attrib |= FILE_ATTRIBUTE_DIRECTORY; - } - /* set dates and times */ - KeQuerySystemTime (&SystemTime); -#if 0 - { - TIME_FIELDS tf; - RtlTimeToTimeFields (&SystemTime, &tf); - DPRINT1("%d.%d.%d %02d:%02d:%02d.%03d '%wZ'\n", - tf.Day, tf.Month, tf.Year, tf.Hour, - tf.Minute, tf.Second, tf.Milliseconds, - NameU); - } -#endif - FsdSystemTimeToDosDateTime (DeviceExt, &SystemTime, &DirContext.DirEntry.Fat.CreationDate, - &DirContext.DirEntry.Fat.CreationTime); - DirContext.DirEntry.Fat.UpdateDate = DirContext.DirEntry.Fat.CreationDate; - DirContext.DirEntry.Fat.UpdateTime = DirContext.DirEntry.Fat.CreationTime; - DirContext.DirEntry.Fat.AccessDate = DirContext.DirEntry.Fat.CreationDate; - - if (needLong) - { - /* calculate checksum for 8.3 name */ - for (pSlots[0].alias_checksum = 0, i = 0; i < 11; i++) - { - pSlots[0].alias_checksum = (((pSlots[0].alias_checksum & 1) << 7 - | ((pSlots[0].alias_checksum & 0xfe) >> 1)) - + DirContext.DirEntry.Fat.Filename[i]); - } - /* construct slots and entry */ - for (i = nbSlots - 2; i >= 0; i--) - { - DPRINT ("construct slot %d\n", i); - pSlots[i].attr = 0xf; - if (i) - { - pSlots[i].id = (unsigned char)(nbSlots - i - 1); - } - else - { - pSlots[i].id = (unsigned char)(nbSlots - i - 1 + 0x40); - } - pSlots[i].alias_checksum = pSlots[0].alias_checksum; - RtlCopyMemory (pSlots[i].name0_4, DirContext.LongNameU.Buffer + (nbSlots - i - 2) * 13, 10); - RtlCopyMemory (pSlots[i].name5_10, DirContext.LongNameU.Buffer + (nbSlots - i - 2) * 13 + 5, 12); - RtlCopyMemory (pSlots[i].name11_12, DirContext.LongNameU.Buffer + (nbSlots - i - 2) * 13 + 11, 4); - } - } - /* try to find nbSlots contiguous entries frees in directory */ - if (!vfatFindDirSpace(DeviceExt, ParentFcb, nbSlots, &DirContext.StartIndex)) - { - ExFreePool (Buffer); - return STATUS_DISK_FULL; - } - DirContext.DirIndex = DirContext.StartIndex + nbSlots - 1; - if (RequestedOptions & FILE_DIRECTORY_FILE) - { - CurrentCluster = 0; - Status = NextCluster (DeviceExt, 0, &CurrentCluster, TRUE); - if (CurrentCluster == 0xffffffff || !NT_SUCCESS(Status)) - { - ExFreePool (Buffer); - if (!NT_SUCCESS(Status)) - { - return Status; - } - return STATUS_DISK_FULL; - } - if (DeviceExt->FatInfo.FatType == FAT32) - { - DirContext.DirEntry.Fat.FirstClusterHigh = (unsigned short)(CurrentCluster >> 16); - } - DirContext.DirEntry.Fat.FirstCluster = (unsigned short)CurrentCluster; - } - - i = DeviceExt->FatInfo.BytesPerCluster / sizeof(FAT_DIR_ENTRY); - FileOffset.u.HighPart = 0; - FileOffset.u.LowPart = DirContext.StartIndex * sizeof(FAT_DIR_ENTRY); - if (DirContext.StartIndex / i == DirContext.DirIndex / i) - { - /* one cluster */ - CHECKPOINT; - CcPinRead (ParentFcb->FileObject, &FileOffset, nbSlots * sizeof(FAT_DIR_ENTRY), - TRUE, &Context, (PVOID*)&pFatEntry); - if (nbSlots > 1) - { - RtlCopyMemory(pFatEntry, Buffer, (nbSlots - 1) * sizeof(FAT_DIR_ENTRY)); - } - RtlCopyMemory(pFatEntry + (nbSlots - 1), &DirContext.DirEntry.Fat, sizeof(FAT_DIR_ENTRY)); - } - else - { - /* two clusters */ - CHECKPOINT; - size = DeviceExt->FatInfo.BytesPerCluster - - (DirContext.StartIndex * sizeof(FAT_DIR_ENTRY)) % DeviceExt->FatInfo.BytesPerCluster; - i = size / sizeof(FAT_DIR_ENTRY); - CcPinRead (ParentFcb->FileObject, &FileOffset, size, TRUE, - &Context, (PVOID*)&pFatEntry); - RtlCopyMemory(pFatEntry, Buffer, size); - CcSetDirtyPinnedData(Context, NULL); - CcUnpinData(Context); - FileOffset.u.LowPart += size; - CcPinRead (ParentFcb->FileObject, &FileOffset, - nbSlots * sizeof(FAT_DIR_ENTRY) - size, - TRUE, &Context, (PVOID*)&pFatEntry); - if (nbSlots - 1 > i) - { - RtlCopyMemory(pFatEntry, (PVOID)(Buffer + size), (nbSlots - 1 - i) * sizeof(FAT_DIR_ENTRY)); - } - RtlCopyMemory(pFatEntry + nbSlots - 1 - i, &DirContext.DirEntry.Fat, sizeof(FAT_DIR_ENTRY)); - } - CcSetDirtyPinnedData(Context, NULL); - CcUnpinData(Context); - - /* FIXME: check status */ - vfatMakeFCBFromDirEntry (DeviceExt, ParentFcb, &DirContext, Fcb); - - DPRINT ("new : entry=%11.11s\n", (*Fcb)->entry.Fat.Filename); - DPRINT ("new : entry=%11.11s\n", DirContext.DirEntry.Fat.Filename); - - if (RequestedOptions & FILE_DIRECTORY_FILE) - { - FileOffset.QuadPart = 0; - CcMapData ((*Fcb)->FileObject, &FileOffset, DeviceExt->FatInfo.BytesPerCluster, TRUE, - &Context, (PVOID*)&pFatEntry); - /* clear the new directory cluster */ - RtlZeroMemory (pFatEntry, DeviceExt->FatInfo.BytesPerCluster); - /* create '.' and '..' */ - RtlCopyMemory (&pFatEntry[0].Attrib, &DirContext.DirEntry.Fat.Attrib, sizeof(FAT_DIR_ENTRY) - 11); - RtlCopyMemory (pFatEntry[0].ShortName, ". ", 11); - RtlCopyMemory (&pFatEntry[1].Attrib, &DirContext.DirEntry.Fat.Attrib, sizeof(FAT_DIR_ENTRY) - 11); - RtlCopyMemory (pFatEntry[1].ShortName, ".. ", 11); - pFatEntry[1].FirstCluster = ParentFcb->entry.Fat.FirstCluster; - pFatEntry[1].FirstClusterHigh = ParentFcb->entry.Fat.FirstClusterHigh; - if (vfatFCBIsRoot(ParentFcb)) - { - pFatEntry[1].FirstCluster = 0; - pFatEntry[1].FirstClusterHigh = 0; - } - CcSetDirtyPinnedData(Context, NULL); - CcUnpinData(Context); - } - ExFreePool (Buffer); - DPRINT ("addentry ok\n"); - return STATUS_SUCCESS; + PVOID Context = NULL; + PFAT_DIR_ENTRY pFatEntry; + slot *pSlots; + USHORT nbSlots = 0, j, posCar; + PUCHAR Buffer; + BOOLEAN needTilde = FALSE, needLong = FALSE; + BOOLEAN lCaseBase = FALSE, uCaseBase, lCaseExt = FALSE, uCaseExt; + ULONG CurrentCluster; + LARGE_INTEGER SystemTime, FileOffset; + NTSTATUS Status = STATUS_SUCCESS; + ULONG size; + long i; + + OEM_STRING NameA; + CHAR aName[13]; + BOOLEAN IsNameLegal; + BOOLEAN SpacesFound; + + VFAT_DIRENTRY_CONTEXT DirContext; + WCHAR LongNameBuffer[LONGNAME_MAX_LENGTH + 1]; + WCHAR ShortNameBuffer[13]; + + DPRINT("addEntry: Name='%wZ', Dir='%wZ'\n", NameU, &ParentFcb->PathNameU); + + DirContext.LongNameU = *NameU; + + /* nb of entry needed for long name+normal entry */ + nbSlots = (DirContext.LongNameU.Length / sizeof(WCHAR) + 12) / 13 + 1; + DPRINT("NameLen= %d, nbSlots =%d\n", DirContext.LongNameU.Length / sizeof(WCHAR), nbSlots); + Buffer = ExAllocatePoolWithTag(NonPagedPool, (nbSlots - 1) * sizeof(FAT_DIR_ENTRY), TAG_VFAT); + if (Buffer == NULL) + { + return STATUS_INSUFFICIENT_RESOURCES; + } + RtlZeroMemory(Buffer, (nbSlots - 1) * sizeof(FAT_DIR_ENTRY)); + pSlots = (slot *) Buffer; + + NameA.Buffer = aName; + NameA.Length = 0; + NameA.MaximumLength = sizeof(aName); + + DirContext.ShortNameU.Buffer = ShortNameBuffer; + DirContext.ShortNameU.Length = 0; + DirContext.ShortNameU.MaximumLength = sizeof(ShortNameBuffer); + + RtlZeroMemory(&DirContext.DirEntry.Fat, sizeof(FAT_DIR_ENTRY)); + + IsNameLegal = RtlIsNameLegalDOS8Dot3(&DirContext.LongNameU, &NameA, &SpacesFound); + + if (!IsNameLegal || SpacesFound) + { + GENERATE_NAME_CONTEXT NameContext; + VFAT_DIRENTRY_CONTEXT SearchContext; + WCHAR ShortSearchName[13]; + needTilde = TRUE; + needLong = TRUE; + RtlZeroMemory(&NameContext, sizeof(GENERATE_NAME_CONTEXT)); + SearchContext.LongNameU.Buffer = LongNameBuffer; + SearchContext.LongNameU.MaximumLength = sizeof(LongNameBuffer); + SearchContext.ShortNameU.Buffer = ShortSearchName; + SearchContext.ShortNameU.MaximumLength = sizeof(ShortSearchName); + + for (i = 0; i < 100; i++) + { + RtlGenerate8dot3Name(&DirContext.LongNameU, FALSE, &NameContext, &DirContext.ShortNameU); + DirContext.ShortNameU.Buffer[DirContext.ShortNameU.Length / sizeof(WCHAR)] = 0; + SearchContext.DirIndex = 0; + Status = FindFile(DeviceExt, ParentFcb, &DirContext.ShortNameU, &SearchContext, TRUE); + if (!NT_SUCCESS(Status)) + { + break; + } + } + if (i == 100) /* FIXME : what to do after this ? */ + { + ExFreePoolWithTag(Buffer, TAG_VFAT); + CHECKPOINT; + return STATUS_UNSUCCESSFUL; + } + IsNameLegal = RtlIsNameLegalDOS8Dot3(&DirContext.ShortNameU, &NameA, &SpacesFound); + aName[NameA.Length]=0; + } + else + { + aName[NameA.Length] = 0; + for (posCar = 0; posCar < DirContext.LongNameU.Length / sizeof(WCHAR); posCar++) + { + if (DirContext.LongNameU.Buffer[posCar] == L'.') + { + break; + } + } + /* check if the name and the extension contains upper case characters */ + RtlDowncaseUnicodeString(&DirContext.ShortNameU, &DirContext.LongNameU, FALSE); + DirContext.ShortNameU.Buffer[DirContext.ShortNameU.Length / sizeof(WCHAR)] = 0; + uCaseBase = wcsncmp(DirContext.LongNameU.Buffer, + DirContext.ShortNameU.Buffer, posCar) ? TRUE : FALSE; + if (posCar < DirContext.LongNameU.Length/sizeof(WCHAR)) + { + i = DirContext.LongNameU.Length / sizeof(WCHAR) - posCar; + uCaseExt = wcsncmp(DirContext.LongNameU.Buffer + posCar, + DirContext.ShortNameU.Buffer + posCar, i) ? TRUE : FALSE; + } + else + { + uCaseExt = FALSE; + } + /* check if the name and the extension contains lower case characters */ + RtlUpcaseUnicodeString(&DirContext.ShortNameU, &DirContext.LongNameU, FALSE); + DirContext.ShortNameU.Buffer[DirContext.ShortNameU.Length / sizeof(WCHAR)] = 0; + lCaseBase = wcsncmp(DirContext.LongNameU.Buffer, + DirContext.ShortNameU.Buffer, posCar) ? TRUE : FALSE; + if (posCar < DirContext.LongNameU.Length / sizeof(WCHAR)) + { + i = DirContext.LongNameU.Length / sizeof(WCHAR) - posCar; + lCaseExt = wcsncmp(DirContext.LongNameU.Buffer + posCar, + DirContext.ShortNameU.Buffer + posCar, i) ? TRUE : FALSE; + } + else + { + lCaseExt = FALSE; + } + if ((lCaseBase && uCaseBase) || (lCaseExt && uCaseExt)) + { + needLong = TRUE; + } + } + DPRINT("'%s', '%wZ', needTilde=%d, needLong=%d\n", + aName, &DirContext.LongNameU, needTilde, needLong); + memset(DirContext.DirEntry.Fat.ShortName, ' ', 11); + for (i = 0; i < 8 && aName[i] && aName[i] != '.'; i++) + { + DirContext.DirEntry.Fat.Filename[i] = aName[i]; + } + if (aName[i] == '.') + { + i++; + for (j = 0; j < 3 && aName[i]; j++, i++) + { + DirContext.DirEntry.Fat.Ext[j] = aName[i]; + } + } + if (DirContext.DirEntry.Fat.Filename[0] == 0xe5) + { + DirContext.DirEntry.Fat.Filename[0] = 0x05; + } + + if (needLong) + { + RtlCopyMemory(LongNameBuffer, DirContext.LongNameU.Buffer, DirContext.LongNameU.Length); + DirContext.LongNameU.Buffer = LongNameBuffer; + DirContext.LongNameU.MaximumLength = sizeof(LongNameBuffer); + DirContext.LongNameU.Buffer[DirContext.LongNameU.Length / sizeof(WCHAR)] = 0; + memset(DirContext.LongNameU.Buffer + DirContext.LongNameU.Length / sizeof(WCHAR) + 1, 0xff, + DirContext.LongNameU.MaximumLength - DirContext.LongNameU.Length - sizeof(WCHAR)); + } + else + { + nbSlots = 1; + if (lCaseBase) + { + DirContext.DirEntry.Fat.lCase |= VFAT_CASE_LOWER_BASE; + } + if (lCaseExt) + { + DirContext.DirEntry.Fat.lCase |= VFAT_CASE_LOWER_EXT; + } + } + + DPRINT ("dos name=%11.11s\n", DirContext.DirEntry.Fat.Filename); + + /* set attributes */ + DirContext.DirEntry.Fat.Attrib = ReqAttr; + if (RequestedOptions & FILE_DIRECTORY_FILE) + { + DirContext.DirEntry.Fat.Attrib |= FILE_ATTRIBUTE_DIRECTORY; + } + /* set dates and times */ + KeQuerySystemTime(&SystemTime); + FsdSystemTimeToDosDateTime(DeviceExt, &SystemTime, &DirContext.DirEntry.Fat.CreationDate, + &DirContext.DirEntry.Fat.CreationTime); + DirContext.DirEntry.Fat.UpdateDate = DirContext.DirEntry.Fat.CreationDate; + DirContext.DirEntry.Fat.UpdateTime = DirContext.DirEntry.Fat.CreationTime; + DirContext.DirEntry.Fat.AccessDate = DirContext.DirEntry.Fat.CreationDate; + + if (needLong) + { + /* calculate checksum for 8.3 name */ + for (pSlots[0].alias_checksum = 0, i = 0; i < 11; i++) + { + pSlots[0].alias_checksum = (((pSlots[0].alias_checksum & 1) << 7 + | ((pSlots[0].alias_checksum & 0xfe) >> 1)) + + DirContext.DirEntry.Fat.Filename[i]); + } + /* construct slots and entry */ + for (i = nbSlots - 2; i >= 0; i--) + { + DPRINT("construct slot %d\n", i); + pSlots[i].attr = 0xf; + if (i) + { + pSlots[i].id = (unsigned char)(nbSlots - i - 1); + } + else + { + pSlots[i].id = (unsigned char)(nbSlots - i - 1 + 0x40); + } + pSlots[i].alias_checksum = pSlots[0].alias_checksum; + RtlCopyMemory(pSlots[i].name0_4, DirContext.LongNameU.Buffer + (nbSlots - i - 2) * 13, 10); + RtlCopyMemory(pSlots[i].name5_10, DirContext.LongNameU.Buffer + (nbSlots - i - 2) * 13 + 5, 12); + RtlCopyMemory(pSlots[i].name11_12, DirContext.LongNameU.Buffer + (nbSlots - i - 2) * 13 + 11, 4); + } + } + /* try to find nbSlots contiguous entries frees in directory */ + if (!vfatFindDirSpace(DeviceExt, ParentFcb, nbSlots, &DirContext.StartIndex)) + { + ExFreePoolWithTag(Buffer, TAG_VFAT); + return STATUS_DISK_FULL; + } + DirContext.DirIndex = DirContext.StartIndex + nbSlots - 1; + if (RequestedOptions & FILE_DIRECTORY_FILE) + { + CurrentCluster = 0; + Status = NextCluster(DeviceExt, 0, &CurrentCluster, TRUE); + if (CurrentCluster == 0xffffffff || !NT_SUCCESS(Status)) + { + ExFreePoolWithTag(Buffer, TAG_VFAT); + if (!NT_SUCCESS(Status)) + { + return Status; + } + return STATUS_DISK_FULL; + } + if (DeviceExt->FatInfo.FatType == FAT32) + { + DirContext.DirEntry.Fat.FirstClusterHigh = (unsigned short)(CurrentCluster >> 16); + } + DirContext.DirEntry.Fat.FirstCluster = (unsigned short)CurrentCluster; + } + + i = DeviceExt->FatInfo.BytesPerCluster / sizeof(FAT_DIR_ENTRY); + FileOffset.u.HighPart = 0; + FileOffset.u.LowPart = DirContext.StartIndex * sizeof(FAT_DIR_ENTRY); + if (DirContext.StartIndex / i == DirContext.DirIndex / i) + { + /* one cluster */ + CHECKPOINT; + CcPinRead(ParentFcb->FileObject, &FileOffset, nbSlots * sizeof(FAT_DIR_ENTRY), + TRUE, &Context, (PVOID*)&pFatEntry); + if (nbSlots > 1) + { + RtlCopyMemory(pFatEntry, Buffer, (nbSlots - 1) * sizeof(FAT_DIR_ENTRY)); + } + RtlCopyMemory(pFatEntry + (nbSlots - 1), &DirContext.DirEntry.Fat, sizeof(FAT_DIR_ENTRY)); + } + else + { + /* two clusters */ + CHECKPOINT; + size = DeviceExt->FatInfo.BytesPerCluster - + (DirContext.StartIndex * sizeof(FAT_DIR_ENTRY)) % DeviceExt->FatInfo.BytesPerCluster; + i = size / sizeof(FAT_DIR_ENTRY); + CcPinRead(ParentFcb->FileObject, &FileOffset, size, TRUE, + &Context, (PVOID*)&pFatEntry); + RtlCopyMemory(pFatEntry, Buffer, size); + CcSetDirtyPinnedData(Context, NULL); + CcUnpinData(Context); + FileOffset.u.LowPart += size; + CcPinRead(ParentFcb->FileObject, &FileOffset, + nbSlots * sizeof(FAT_DIR_ENTRY) - size, + TRUE, &Context, (PVOID*)&pFatEntry); + if (nbSlots - 1 > i) + { + RtlCopyMemory(pFatEntry, (PVOID)(Buffer + size), (nbSlots - 1 - i) * sizeof(FAT_DIR_ENTRY)); + } + RtlCopyMemory(pFatEntry + nbSlots - 1 - i, &DirContext.DirEntry.Fat, sizeof(FAT_DIR_ENTRY)); + } + CcSetDirtyPinnedData(Context, NULL); + CcUnpinData(Context); + + /* FIXME: check status */ + vfatMakeFCBFromDirEntry(DeviceExt, ParentFcb, &DirContext, Fcb); + + DPRINT("new : entry=%11.11s\n", (*Fcb)->entry.Fat.Filename); + DPRINT("new : entry=%11.11s\n", DirContext.DirEntry.Fat.Filename); + + if (RequestedOptions & FILE_DIRECTORY_FILE) + { + FileOffset.QuadPart = 0; + CcMapData((*Fcb)->FileObject, &FileOffset, DeviceExt->FatInfo.BytesPerCluster, TRUE, + &Context, (PVOID*)&pFatEntry); + /* clear the new directory cluster */ + RtlZeroMemory(pFatEntry, DeviceExt->FatInfo.BytesPerCluster); + /* create '.' and '..' */ + RtlCopyMemory(&pFatEntry[0].Attrib, &DirContext.DirEntry.Fat.Attrib, sizeof(FAT_DIR_ENTRY) - 11); + RtlCopyMemory(pFatEntry[0].ShortName, ". ", 11); + RtlCopyMemory(&pFatEntry[1].Attrib, &DirContext.DirEntry.Fat.Attrib, sizeof(FAT_DIR_ENTRY) - 11); + RtlCopyMemory(pFatEntry[1].ShortName, ".. ", 11); + pFatEntry[1].FirstCluster = ParentFcb->entry.Fat.FirstCluster; + pFatEntry[1].FirstClusterHigh = ParentFcb->entry.Fat.FirstClusterHigh; + if (vfatFCBIsRoot(ParentFcb)) + { + pFatEntry[1].FirstCluster = 0; + pFatEntry[1].FirstClusterHigh = 0; + } + CcSetDirtyPinnedData(Context, NULL); + CcUnpinData(Context); + } + ExFreePoolWithTag(Buffer, TAG_VFAT); + DPRINT("addentry ok\n"); + return STATUS_SUCCESS; } -static NTSTATUS -FATXAddEntry (PDEVICE_EXTENSION DeviceExt, - PUNICODE_STRING NameU, - PVFATFCB* Fcb, - PVFATFCB ParentFcb, - ULONG RequestedOptions, - UCHAR ReqAttr) /* create a new FAT entry */ +static NTSTATUS +FATXAddEntry( + IN PDEVICE_EXTENSION DeviceExt, + IN PUNICODE_STRING NameU, + IN PVFATFCB* Fcb, + IN PVFATFCB ParentFcb, + IN ULONG RequestedOptions, + IN UCHAR ReqAttr) { - PVOID Context = NULL; - LARGE_INTEGER SystemTime, FileOffset; - OEM_STRING NameA; - VFAT_DIRENTRY_CONTEXT DirContext; - PFATX_DIR_ENTRY pFatXDirEntry; - ULONG Index; - - DPRINT ("addEntry: Name='%wZ', Dir='%wZ'\n", NameU, &ParentFcb->PathNameU); - - DirContext.LongNameU = *NameU; - - if (DirContext.LongNameU.Length / sizeof(WCHAR) > 42) - { - /* name too long */ - CHECKPOINT; - return STATUS_NAME_TOO_LONG; - } - - /* try to find 1 entry free in directory */ - if (!vfatFindDirSpace(DeviceExt, ParentFcb, 1, &DirContext.StartIndex)) - { - return STATUS_DISK_FULL; - } - Index = DirContext.DirIndex = DirContext.StartIndex; - if (!vfatFCBIsRoot(ParentFcb)) - { - DirContext.DirIndex += 2; - DirContext.StartIndex += 2; - } - - DirContext.ShortNameU.Buffer = 0; - DirContext.ShortNameU.Length = 0; - DirContext.ShortNameU.MaximumLength = 0; - RtlZeroMemory(&DirContext.DirEntry.FatX, sizeof(FATX_DIR_ENTRY)); - memset(DirContext.DirEntry.FatX.Filename, 0xff, 42); - DirContext.DirEntry.FatX.FirstCluster = 0; - DirContext.DirEntry.FatX.FileSize = 0; - - /* set file name */ - NameA.Buffer = (PCHAR)DirContext.DirEntry.FatX.Filename; - NameA.Length = 0; - NameA.MaximumLength = 42; - RtlUnicodeStringToOemString(&NameA, &DirContext.LongNameU, FALSE); - DirContext.DirEntry.FatX.FilenameLength = (unsigned char)NameA.Length; - - /* set attributes */ - DirContext.DirEntry.FatX.Attrib = ReqAttr; - if (RequestedOptions & FILE_DIRECTORY_FILE) - { - DirContext.DirEntry.FatX.Attrib |= FILE_ATTRIBUTE_DIRECTORY; - } - - /* set dates and times */ - KeQuerySystemTime (&SystemTime); -#if 0 - { - TIME_FIELDS tf; - RtlTimeToTimeFields (&SystemTime, &tf); - DPRINT1("%d.%d.%d %02d:%02d:%02d.%03d '%wZ'\n", - tf.Day, tf.Month, tf.Year, tf.Hour, - tf.Minute, tf.Second, tf.Milliseconds, - NameU); - } -#endif - - - FsdSystemTimeToDosDateTime(DeviceExt, &SystemTime, &DirContext.DirEntry.FatX.CreationDate, - &DirContext.DirEntry.FatX.CreationTime); - DirContext.DirEntry.FatX.UpdateDate = DirContext.DirEntry.FatX.CreationDate; - DirContext.DirEntry.FatX.UpdateTime = DirContext.DirEntry.FatX.CreationTime; - DirContext.DirEntry.FatX.AccessDate = DirContext.DirEntry.FatX.CreationDate; - DirContext.DirEntry.FatX.AccessTime = DirContext.DirEntry.FatX.CreationTime; - - /* add entry into parent directory */ - FileOffset.u.HighPart = 0; - FileOffset.u.LowPart = Index * sizeof(FATX_DIR_ENTRY); - CcPinRead(ParentFcb->FileObject, &FileOffset, sizeof(FATX_DIR_ENTRY), - TRUE, &Context, (PVOID*)&pFatXDirEntry); - RtlCopyMemory(pFatXDirEntry, &DirContext.DirEntry.FatX, sizeof(FATX_DIR_ENTRY)); - CcSetDirtyPinnedData(Context, NULL); - CcUnpinData(Context); - - /* FIXME: check status */ - vfatMakeFCBFromDirEntry(DeviceExt, ParentFcb, &DirContext, Fcb); - - DPRINT("addentry ok\n"); - return STATUS_SUCCESS; + PVOID Context = NULL; + LARGE_INTEGER SystemTime, FileOffset; + OEM_STRING NameA; + VFAT_DIRENTRY_CONTEXT DirContext; + PFATX_DIR_ENTRY pFatXDirEntry; + ULONG Index; + + DPRINT("addEntry: Name='%wZ', Dir='%wZ'\n", NameU, &ParentFcb->PathNameU); + + DirContext.LongNameU = *NameU; + + if (DirContext.LongNameU.Length / sizeof(WCHAR) > 42) + { + /* name too long */ + CHECKPOINT; + return STATUS_NAME_TOO_LONG; + } + + /* try to find 1 entry free in directory */ + if (!vfatFindDirSpace(DeviceExt, ParentFcb, 1, &DirContext.StartIndex)) + { + return STATUS_DISK_FULL; + } + Index = DirContext.DirIndex = DirContext.StartIndex; + if (!vfatFCBIsRoot(ParentFcb)) + { + DirContext.DirIndex += 2; + DirContext.StartIndex += 2; + } + + DirContext.ShortNameU.Buffer = 0; + DirContext.ShortNameU.Length = 0; + DirContext.ShortNameU.MaximumLength = 0; + RtlZeroMemory(&DirContext.DirEntry.FatX, sizeof(FATX_DIR_ENTRY)); + memset(DirContext.DirEntry.FatX.Filename, 0xff, 42); + DirContext.DirEntry.FatX.FirstCluster = 0; + DirContext.DirEntry.FatX.FileSize = 0; + + /* set file name */ + NameA.Buffer = (PCHAR)DirContext.DirEntry.FatX.Filename; + NameA.Length = 0; + NameA.MaximumLength = 42; + RtlUnicodeStringToOemString(&NameA, &DirContext.LongNameU, FALSE); + DirContext.DirEntry.FatX.FilenameLength = (unsigned char)NameA.Length; + + /* set attributes */ + DirContext.DirEntry.FatX.Attrib = ReqAttr; + if (RequestedOptions & FILE_DIRECTORY_FILE) + { + DirContext.DirEntry.FatX.Attrib |= FILE_ATTRIBUTE_DIRECTORY; + } + + /* set dates and times */ + KeQuerySystemTime(&SystemTime); + FsdSystemTimeToDosDateTime(DeviceExt, &SystemTime, &DirContext.DirEntry.FatX.CreationDate, + &DirContext.DirEntry.FatX.CreationTime); + DirContext.DirEntry.FatX.UpdateDate = DirContext.DirEntry.FatX.CreationDate; + DirContext.DirEntry.FatX.UpdateTime = DirContext.DirEntry.FatX.CreationTime; + DirContext.DirEntry.FatX.AccessDate = DirContext.DirEntry.FatX.CreationDate; + DirContext.DirEntry.FatX.AccessTime = DirContext.DirEntry.FatX.CreationTime; + + /* add entry into parent directory */ + FileOffset.u.HighPart = 0; + FileOffset.u.LowPart = Index * sizeof(FATX_DIR_ENTRY); + CcPinRead(ParentFcb->FileObject, &FileOffset, sizeof(FATX_DIR_ENTRY), + TRUE, &Context, (PVOID*)&pFatXDirEntry); + RtlCopyMemory(pFatXDirEntry, &DirContext.DirEntry.FatX, sizeof(FATX_DIR_ENTRY)); + CcSetDirtyPinnedData(Context, NULL); + CcUnpinData(Context); + + /* FIXME: check status */ + vfatMakeFCBFromDirEntry(DeviceExt, ParentFcb, &DirContext, Fcb); + + DPRINT("addentry ok\n"); + return STATUS_SUCCESS; } NTSTATUS -VfatAddEntry (PDEVICE_EXTENSION DeviceExt, - PUNICODE_STRING NameU, - PVFATFCB *Fcb, - PVFATFCB ParentFcb, - ULONG RequestedOptions, - UCHAR ReqAttr) +VfatAddEntry( + IN PDEVICE_EXTENSION DeviceExt, + IN PUNICODE_STRING NameU, + IN PVFATFCB *Fcb, + IN PVFATFCB ParentFcb, + IN ULONG RequestedOptions, + IN UCHAR ReqAttr) { - if (DeviceExt->Flags & VCB_IS_FATX) - return FATXAddEntry(DeviceExt, NameU, Fcb, ParentFcb, RequestedOptions, ReqAttr); - else - return FATAddEntry(DeviceExt, NameU, Fcb, ParentFcb, RequestedOptions, ReqAttr); + if (DeviceExt->Flags & VCB_IS_FATX) + return FATXAddEntry(DeviceExt, NameU, Fcb, ParentFcb, RequestedOptions, ReqAttr); + else + return FATAddEntry(DeviceExt, NameU, Fcb, ParentFcb, RequestedOptions, ReqAttr); } -static NTSTATUS -FATDelEntry (PDEVICE_EXTENSION DeviceExt, PVFATFCB pFcb) /* * deleting an existing FAT entry */ +static NTSTATUS +FATDelEntry( + IN PDEVICE_EXTENSION DeviceExt, + IN PVFATFCB pFcb) { - ULONG CurrentCluster = 0, NextCluster, i; - PVOID Context = NULL; - LARGE_INTEGER Offset; - PFAT_DIR_ENTRY pDirEntry; - - ASSERT(pFcb); - ASSERT(pFcb->parentFcb); - - DPRINT ("delEntry PathName \'%wZ\'\n", &pFcb->PathNameU); - DPRINT ("delete entry: %d to %d\n", pFcb->startIndex, pFcb->dirIndex); - Offset.u.HighPart = 0; - for (i = pFcb->startIndex; i <= pFcb->dirIndex; i++) - { - if (Context == NULL || ((i * sizeof(FAT_DIR_ENTRY)) % PAGE_SIZE) == 0) - { - if (Context) - { - CcSetDirtyPinnedData(Context, NULL); - CcUnpinData(Context); - } - Offset.u.LowPart = (i * sizeof(FAT_DIR_ENTRY) / PAGE_SIZE) * PAGE_SIZE; - CcPinRead (pFcb->parentFcb->FileObject, &Offset, PAGE_SIZE, TRUE, - &Context, (PVOID*)&pDirEntry); - } - pDirEntry[i % (PAGE_SIZE / sizeof(FAT_DIR_ENTRY))].Filename[0] = 0xe5; - if (i == pFcb->dirIndex) - { - CurrentCluster = - vfatDirEntryGetFirstCluster (DeviceExt, - (PDIR_ENTRY)&pDirEntry[i % (PAGE_SIZE / sizeof(FAT_DIR_ENTRY))]); - } - } - if (Context) - { - CcSetDirtyPinnedData(Context, NULL); - CcUnpinData(Context); - } - - while (CurrentCluster && CurrentCluster != 0xffffffff) - { - GetNextCluster (DeviceExt, CurrentCluster, &NextCluster); - /* FIXME: check status */ - WriteCluster(DeviceExt, CurrentCluster, 0); - CurrentCluster = NextCluster; - } - return STATUS_SUCCESS; + ULONG CurrentCluster = 0, NextCluster, i; + PVOID Context = NULL; + LARGE_INTEGER Offset; + PFAT_DIR_ENTRY pDirEntry; + + ASSERT(pFcb); + ASSERT(pFcb->parentFcb); + + DPRINT("delEntry PathName \'%wZ\'\n", &pFcb->PathNameU); + DPRINT("delete entry: %d to %d\n", pFcb->startIndex, pFcb->dirIndex); + Offset.u.HighPart = 0; + for (i = pFcb->startIndex; i <= pFcb->dirIndex; i++) + { + if (Context == NULL || ((i * sizeof(FAT_DIR_ENTRY)) % PAGE_SIZE) == 0) + { + if (Context) + { + CcSetDirtyPinnedData(Context, NULL); + CcUnpinData(Context); + } + Offset.u.LowPart = (i * sizeof(FAT_DIR_ENTRY) / PAGE_SIZE) * PAGE_SIZE; + CcPinRead(pFcb->parentFcb->FileObject, &Offset, PAGE_SIZE, TRUE, + &Context, (PVOID*)&pDirEntry); + } + pDirEntry[i % (PAGE_SIZE / sizeof(FAT_DIR_ENTRY))].Filename[0] = 0xe5; + if (i == pFcb->dirIndex) + { + CurrentCluster = + vfatDirEntryGetFirstCluster(DeviceExt, + (PDIR_ENTRY)&pDirEntry[i % (PAGE_SIZE / sizeof(FAT_DIR_ENTRY))]); + } + } + if (Context) + { + CcSetDirtyPinnedData(Context, NULL); + CcUnpinData(Context); + } + + while (CurrentCluster && CurrentCluster != 0xffffffff) + { + GetNextCluster(DeviceExt, CurrentCluster, &NextCluster); + /* FIXME: check status */ + WriteCluster(DeviceExt, CurrentCluster, 0); + CurrentCluster = NextCluster; + } + return STATUS_SUCCESS; } -static NTSTATUS -FATXDelEntry (PDEVICE_EXTENSION DeviceExt, PVFATFCB pFcb) /* * deleting an existing FAT entry */ +static NTSTATUS +FATXDelEntry( + IN PDEVICE_EXTENSION DeviceExt, + IN PVFATFCB pFcb) { - ULONG CurrentCluster = 0, NextCluster; - PVOID Context = NULL; - LARGE_INTEGER Offset; - PFATX_DIR_ENTRY pDirEntry; - ULONG StartIndex; - - ASSERT(pFcb); - ASSERT(pFcb->parentFcb); - ASSERT(pFcb->Flags & FCB_IS_FATX_ENTRY); - - StartIndex = pFcb->startIndex; - - DPRINT ("delEntry PathName \'%wZ\'\n", &pFcb->PathNameU); - DPRINT ("delete entry: %d\n", StartIndex); - Offset.u.HighPart = 0; - Offset.u.LowPart = (StartIndex * sizeof(FATX_DIR_ENTRY) / PAGE_SIZE) * PAGE_SIZE; - if (!CcPinRead (pFcb->parentFcb->FileObject, &Offset, PAGE_SIZE, TRUE, - &Context, (PVOID*)&pDirEntry)) - { - DPRINT1("CcPinRead(Offset %x:%x, Length %d) failed\n", Offset.u.HighPart, Offset.u.LowPart, PAGE_SIZE); - return STATUS_UNSUCCESSFUL; - } - pDirEntry = &pDirEntry[StartIndex % (PAGE_SIZE / sizeof(FATX_DIR_ENTRY))]; - pDirEntry->FilenameLength = 0xe5; - CurrentCluster = vfatDirEntryGetFirstCluster (DeviceExt, - (PDIR_ENTRY)pDirEntry); - CcSetDirtyPinnedData(Context, NULL); - CcUnpinData(Context); - - while (CurrentCluster && CurrentCluster != 0xffffffff) - { - GetNextCluster (DeviceExt, CurrentCluster, &NextCluster); - /* FIXME: check status */ - WriteCluster(DeviceExt, CurrentCluster, 0); - CurrentCluster = NextCluster; - } - return STATUS_SUCCESS; + ULONG CurrentCluster = 0, NextCluster; + PVOID Context = NULL; + LARGE_INTEGER Offset; + PFATX_DIR_ENTRY pDirEntry; + ULONG StartIndex; + + ASSERT(pFcb); + ASSERT(pFcb->parentFcb); + ASSERT(pFcb->Flags & FCB_IS_FATX_ENTRY); + + StartIndex = pFcb->startIndex; + + DPRINT("delEntry PathName \'%wZ\'\n", &pFcb->PathNameU); + DPRINT("delete entry: %d\n", StartIndex); + Offset.u.HighPart = 0; + Offset.u.LowPart = (StartIndex * sizeof(FATX_DIR_ENTRY) / PAGE_SIZE) * PAGE_SIZE; + if (!CcPinRead(pFcb->parentFcb->FileObject, &Offset, PAGE_SIZE, TRUE, + &Context, (PVOID*)&pDirEntry)) + { + DPRINT1("CcPinRead(Offset %x:%x, Length %d) failed\n", Offset.u.HighPart, Offset.u.LowPart, PAGE_SIZE); + return STATUS_UNSUCCESSFUL; + } + pDirEntry = &pDirEntry[StartIndex % (PAGE_SIZE / sizeof(FATX_DIR_ENTRY))]; + pDirEntry->FilenameLength = 0xe5; + CurrentCluster = vfatDirEntryGetFirstCluster(DeviceExt, + (PDIR_ENTRY)pDirEntry); + CcSetDirtyPinnedData(Context, NULL); + CcUnpinData(Context); + + while (CurrentCluster && CurrentCluster != 0xffffffff) + { + GetNextCluster(DeviceExt, CurrentCluster, &NextCluster); + /* FIXME: check status */ + WriteCluster(DeviceExt, CurrentCluster, 0); + CurrentCluster = NextCluster; + } + return STATUS_SUCCESS; } NTSTATUS -VfatDelEntry (PDEVICE_EXTENSION DeviceExt, PVFATFCB pFcb) +VfatDelEntry( + IN PDEVICE_EXTENSION DeviceExt, + IN PVFATFCB pFcb) { - if (DeviceExt->Flags & VCB_IS_FATX) - return FATXDelEntry(DeviceExt, pFcb); - else - return FATDelEntry(DeviceExt, pFcb); + if (DeviceExt->Flags & VCB_IS_FATX) + return FATXDelEntry(DeviceExt, pFcb); + else + return FATDelEntry(DeviceExt, pFcb); } /* EOF */

1 0

[jimtabor] 33310: Quick implementation of DxEngCreateMemoryDC and DxEngCleanDC. It compiles. 8^D
by jimtabor＠svn.reactos.org 06 May '08

06 May '08

Author: jimtabor Date: Mon May 5 23:22:49 2008 New Revision: 33310 URL: http://svn.reactos.org/svn/reactos?rev=33310&view=rev Log: Quick implementation of DxEngCreateMemoryDC and DxEngCleanDC. It compiles. 8^D Modified: trunk/reactos/subsystems/win32/win32k/include/dc.h trunk/reactos/subsystems/win32/win32k/ntddraw/dxeng.c trunk/reactos/subsystems/win32/win32k/objects/dc.c Modified: trunk/reactos/subsystems/win32/win32k/include/dc.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/in… ============================================================================== --- trunk/reactos/subsystems/win32/win32k/include/dc.h [iso-8859-1] (original) +++ trunk/reactos/subsystems/win32/win32k/include/dc.h [iso-8859-1] Mon May 5 23:22:49 2008 @@ -263,5 +263,7 @@ INT STDCALL IntGdiSetStretchBltMode(HDC hDC, INT stretchBltMode); VOID FASTCALL IntGdiReferencePdev(PGDIDEVICE pPDev); VOID FASTCALL IntGdiUnreferencePdev(PGDIDEVICE pPDev, DWORD CleanUpType); +HDC FASTCALL IntGdiCreateDisplayDC(HDEV hDev, ULONG DcType, BOOL EmptyDC); +BOOL FASTCALL IntGdiCleanDC(HDC hDC); #endif /* not __WIN32K_DC_H */ Modified: trunk/reactos/subsystems/win32/win32k/ntddraw/dxeng.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/nt… ============================================================================== --- trunk/reactos/subsystems/win32/win32k/ntddraw/dxeng.c [iso-8859-1] (original) +++ trunk/reactos/subsystems/win32/win32k/ntddraw/dxeng.c [iso-8859-1] Mon May 5 23:22:49 2008 @@ -654,8 +654,7 @@ STDCALL DxEngCreateMemoryDC(HDEV hDev) { - UNIMPLEMENTED; - return NULL; + return IntGdiCreateDisplayDC(hDev, DC_TYPE_MEMORY, FALSE); } /************************************************************************/ @@ -732,8 +731,7 @@ STDCALL DxEngCleanDC(HDC hdc) { - UNIMPLEMENTED; - return FALSE; + return IntGdiCleanDC(hdc); } /************************************************************************/ Modified: trunk/reactos/subsystems/win32/win32k/objects/dc.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/ob… ============================================================================== --- trunk/reactos/subsystems/win32/win32k/objects/dc.c [iso-8859-1] (original) +++ trunk/reactos/subsystems/win32/win32k/objects/dc.c [iso-8859-1] Mon May 5 23:22:49 2008 @@ -31,6 +31,7 @@ static GDIDEVICE PrimarySurface; static KEVENT VideoDriverNeedsPreparation; static KEVENT VideoDriverPrepared; +static PDC defaultDCstate = NULL; EDD_DIRECTDRAW_GLOBAL edd_DdirectDraw_Global; NTSTATUS FASTCALL @@ -926,6 +927,47 @@ return Ret; +} + + +HDC FASTCALL +IntGdiCreateDisplayDC(HDEV hDev, ULONG DcType, BOOL EmptyDC) +{ + HDC hDC; + UNICODE_STRING DriverName; + RtlInitUnicodeString(&DriverName, L"DISPLAY"); + + if (DcType != DC_TYPE_MEMORY) + hDC = IntGdiCreateDC(&DriverName, NULL, NULL, NULL, (DcType == DC_TYPE_INFO)); + else + hDC = NtGdiCreateCompatibleDC(NULL); // OH~ Yuck! I think I taste vomit in my mouth! +// +// There is room to grow here~ +// + +// +// If NULL, first time through! Build the default (was window) dc! +// + if (hDC && !defaultDCstate) // Ultra HAX! Dedicated to GvG! + { // This is a cheesy way to do this. + PDC dc = DC_LockDc ( hDC ); + defaultDCstate = ExAllocatePoolWithTag(PagedPool, sizeof(DC), TAG_DC); + RtlZeroMemory(defaultDCstate, sizeof(DC)); + IntGdiCopyToSaveState(dc, defaultDCstate); + DC_UnlockDc( dc ); + } + return hDC; +} + +BOOL FASTCALL +IntGdiCleanDC(HDC hDC) +{ + PDC dc; + dc = DC_LockDc ( hDC ); + // Clean the DC + if (defaultDCstate) IntGdiCopyFromSaveState(dc, defaultDCstate, hDC ); + DC_UnlockDc(dc); + return TRUE; } //

1 0

[jimtabor] 33309: Win32k: - Rewrite EngAcquire/ReleaseSemaphore. - Add internal fastcalls for them and tag. - Fix DxEngUn/LockShareSem. - Tested with Qemu. Needs Dx testing.
by jimtabor＠svn.reactos.org 06 May '08

06 May '08

Author: jimtabor Date: Mon May 5 22:40:38 2008 New Revision: 33309 URL: http://svn.reactos.org/svn/reactos?rev=33309&view=rev Log: Win32k: - Rewrite EngAcquire/ReleaseSemaphore. - Add internal fastcalls for them and tag. - Fix DxEngUn/LockShareSem. - Tested with Qemu. Needs Dx testing. Modified: trunk/reactos/subsystems/win32/win32k/eng/semaphor.c trunk/reactos/subsystems/win32/win32k/include/eng.h trunk/reactos/subsystems/win32/win32k/include/tags.h trunk/reactos/subsystems/win32/win32k/include/win32.h trunk/reactos/subsystems/win32/win32k/ntddraw/dxeng.c trunk/reactos/subsystems/win32/win32k/objects/dc.c Modified: trunk/reactos/subsystems/win32/win32k/eng/semaphor.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/en… ============================================================================== --- trunk/reactos/subsystems/win32/win32k/eng/semaphor.c [iso-8859-1] (original) +++ trunk/reactos/subsystems/win32/win32k/eng/semaphor.c [iso-8859-1] Mon May 5 22:40:38 2008 @@ -11,7 +11,7 @@ EngCreateSemaphore ( VOID ) { // www.osr.com/ddk/graphics/gdifncs_95lz.htm - PERESOURCE psem = ExAllocatePool ( NonPagedPool, sizeof(ERESOURCE) ); + PERESOURCE psem = ExAllocatePoolWithTag( NonPagedPool, sizeof(ERESOURCE), TAG_GSEM ); if ( !psem ) return NULL; if ( !NT_SUCCESS(ExInitializeResourceLite ( psem )) ) @@ -22,6 +22,14 @@ return (HSEMAPHORE)psem; } +VOID +FASTCALL +IntGdiAcquireSemaphore ( HSEMAPHORE hsem ) +{ + KeEnterCriticalRegion(); + ExAcquireResourceExclusiveLite ( (PERESOURCE)hsem, TRUE ); +} + /* * @implemented */ @@ -30,9 +38,20 @@ EngAcquireSemaphore ( IN HSEMAPHORE hsem ) { // www.osr.com/ddk/graphics/gdifncs_14br.htm + PW32THREAD W32Thread; ASSERT(hsem); - KeEnterCriticalRegion(); - ExAcquireResourceExclusiveLite ( (PERESOURCE)hsem, TRUE ); + IntGdiAcquireSemaphore ( hsem ); + W32Thread = PsGetThreadWin32Thread(PsGetCurrentThread()); + if (W32Thread) W32Thread->dwEngAcquireCount++; +} + + +VOID +FASTCALL +IntGdiReleaseSemaphore ( HSEMAPHORE hsem ) +{ + ExReleaseResourceLite ( (PERESOURCE)hsem ); + KeLeaveCriticalRegion(); } /* @@ -43,9 +62,11 @@ EngReleaseSemaphore ( IN HSEMAPHORE hsem ) { // www.osr.com/ddk/graphics/gdifncs_5u3r.htm + PW32THREAD W32Thread; ASSERT(hsem); - ExReleaseResourceLite ( (PERESOURCE)hsem ); - KeLeaveCriticalRegion(); + W32Thread = PsGetThreadWin32Thread(PsGetCurrentThread()); + if (W32Thread) --W32Thread->dwEngAcquireCount; + IntGdiReleaseSemaphore ( hsem ); } /* Modified: trunk/reactos/subsystems/win32/win32k/include/eng.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/in… ============================================================================== --- trunk/reactos/subsystems/win32/win32k/include/eng.h [iso-8859-1] (original) +++ trunk/reactos/subsystems/win32/win32k/include/eng.h [iso-8859-1] Mon May 5 22:40:38 2008 @@ -20,4 +20,7 @@ PWINDOW_OBJECT Window, FLONG flChanged); +VOID FASTCALL IntGdiAcquireSemaphore ( HSEMAPHORE hsem ); +VOID FASTCALL IntGdiReleaseSemaphore ( HSEMAPHORE hsem ); + #endif /* _WIN32K_ENG_H */ Modified: trunk/reactos/subsystems/win32/win32k/include/tags.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/in… ============================================================================== --- trunk/reactos/subsystems/win32/win32k/include/tags.h [iso-8859-1] (original) +++ trunk/reactos/subsystems/win32/win32k/include/tags.h [iso-8859-1] Mon May 5 22:40:38 2008 @@ -81,6 +81,7 @@ #define TAG_WNDOBJ TAG('W', 'N', 'D', 'O') /* window object */ #define TAG_XLATEOBJ TAG('X', 'L', 'A', 'O') /* xlate object */ #define TAG_BITMAPOBJ TAG('B', 'M', 'P', 'O') /* bitmap object */ +#define TAG_GSEM TAG('G', 's', 'e', 'm') /* Gdi Semaphore */ /* misc */ #define TAG_DRIVER TAG('G', 'D', 'R', 'V') /* video drivers */ Modified: trunk/reactos/subsystems/win32/win32k/include/win32.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/in… ============================================================================== --- trunk/reactos/subsystems/win32/win32k/include/win32.h [iso-8859-1] (original) +++ trunk/reactos/subsystems/win32/win32k/include/win32.h [iso-8859-1] Mon May 5 22:40:38 2008 @@ -13,6 +13,7 @@ HANDLE hDesktop; PVOID pgdiDcattr; PVOID pgdiBrushAttr; + DWORD dwEngAcquireCount; BOOLEAN IsExiting; SINGLE_LIST_ENTRY ReferencesList; ULONG Hooks; Modified: trunk/reactos/subsystems/win32/win32k/ntddraw/dxeng.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/nt… ============================================================================== --- trunk/reactos/subsystems/win32/win32k/ntddraw/dxeng.c [iso-8859-1] (original) +++ trunk/reactos/subsystems/win32/win32k/ntddraw/dxeng.c [iso-8859-1] Mon May 5 22:40:38 2008 @@ -9,7 +9,7 @@ #include <w32k.h> #include <debug.h> -ERESOURCE ghsemShareDevLock; +HSEMAPHORE ghsemShareDevLock = NULL; ULONG gcEngFuncs = DXENG_INDEX_DxEngLoadImage + 1; DRVFN gaEngFuncs [] = @@ -171,23 +171,17 @@ * * @remarks. * It is being used in various ntuser* functions and ntgdi* -* ReactOS specific: It is not in use yet. +* ReactOS specific: It is not in use yet? *SystemResourcesList *--*/ BOOLEAN STDCALL DxEngLockShareSem() { - BOOLEAN retVal = FALSE; DPRINT1("ReactX Calling : DxEngLockShareSem\n"); -#if 0 - if (ExIsResourceAcquiredExclusiveLite(&ghsemShareDevLock) == FALSE) - { - KeEnterCriticalRegion(); - retVal = ExAcquireResourceExclusiveLite(&ghsemShareDevLock, TRUE); - } -#endif - return retVal; + if(!ghsemShareDevLock) ghsemShareDevLock = EngCreateSemaphore(); // Hax, should be in dllmain.c + IntGdiAcquireSemaphore(ghsemShareDevLock); + return TRUE; } /*++ @@ -200,7 +194,7 @@ * This function returns TRUE no matter what. * * @remarks. -* ReactOS specific: It is not in use yet. +* ReactOS specific: It is not in use yet? * *--*/ BOOLEAN @@ -208,14 +202,7 @@ DxEngUnlockShareSem() { DPRINT1("ReactX Calling : DxEngUnlockShareSem\n"); - -#if 0 - if (ExIsResourceAcquiredExclusiveLite(&ghsemShareDevLock) == TRUE) - { - ExReleaseResourceLite(&ghsemShareDevLock); - KeLeaveCriticalRegion(); - } -#endif + IntGdiReleaseSemaphore(ghsemShareDevLock); return TRUE; } Modified: trunk/reactos/subsystems/win32/win32k/objects/dc.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/ob… ============================================================================== --- trunk/reactos/subsystems/win32/win32k/objects/dc.c [iso-8859-1] (original) +++ trunk/reactos/subsystems/win32/win32k/objects/dc.c [iso-8859-1] Mon May 5 22:40:38 2008 @@ -2705,21 +2705,21 @@ IntGdiReferencePdev(PGDIDEVICE pPDev) { if(!hsemDriverMgmt) hsemDriverMgmt = EngCreateSemaphore(); // Hax, should be in dllmain.c - EngAcquireSemaphore(hsemDriverMgmt); + IntGdiAcquireSemaphore(hsemDriverMgmt); pPDev->cPdevRefs++; - EngReleaseSemaphore(hsemDriverMgmt); + IntGdiReleaseSemaphore(hsemDriverMgmt); } VOID FASTCALL IntGdiUnreferencePdev(PGDIDEVICE pPDev, DWORD CleanUpType) { - EngAcquireSemaphore(hsemDriverMgmt); + IntGdiAcquireSemaphore(hsemDriverMgmt); pPDev->cPdevRefs--; if (!pPDev->cPdevRefs) { // Handle the destruction of pPDev or GDIDEVICE or PDEVOBJ or PDEV etc. } - EngReleaseSemaphore(hsemDriverMgmt); + IntGdiReleaseSemaphore(hsemDriverMgmt); }

1 0

[mpiulachs] 33308: -solve msi circular dependency warning and avoid unnecessary msi.dll rebuilds See issue #3131 for more details.
by mpiulachs＠svn.reactos.org 05 May '08

05 May '08

Author: mpiulachs Date: Mon May 5 18:19:38 2008 New Revision: 33308 URL: http://svn.reactos.org/svn/reactos?rev=33308&view=rev Log: -solve msi circular dependency warning and avoid unnecessary msi.dll rebuilds See issue #3131 for more details. Modified: trunk/reactos/dll/win32/msi/msi.rbuild Modified: trunk/reactos/dll/win32/msi/msi.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/msi/msi.rbuild?r… ============================================================================== --- trunk/reactos/dll/win32/msi/msi.rbuild [iso-8859-1] (original) +++ trunk/reactos/dll/win32/msi/msi.rbuild [iso-8859-1] Mon May 5 18:19:38 2008 @@ -50,7 +50,6 @@ <file>update.c</file> <file>upgrade.c</file> <file>where.c</file> - <file>msiserver.idl</file> <file>msi.rc</file> <include base="msi" root="intermediate">.</include> <file>msi.spec</file> @@ -72,8 +71,12 @@ <library>uuid</library> <library>ntdll</library> <dependency>msi_msiserver_typelib</dependency> + <dependency>msiheader</dependency> </module> <module name="msi_msiserver_typelib" type="embeddedtypelib" allowwarnings="true"> <file>msiserver.idl</file> </module> +<module name="msiheader" type="idlheader"> + <file>msiserver.idl</file> +</module> </group>

1 0

[fireball] 33307: - Buffer size is in bytes, not in pages. Fixes boot breakage.
by fireball＠svn.reactos.org 05 May '08

05 May '08

Author: fireball Date: Mon May 5 16:07:32 2008 New Revision: 33307 URL: http://svn.reactos.org/svn/reactos?rev=33307&view=rev Log: - Buffer size is in bytes, not in pages. Fixes boot breakage. Modified: trunk/reactos/ntoskrnl/mm/virtual.c Modified: trunk/reactos/ntoskrnl/mm/virtual.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/virtual.c?rev=… ============================================================================== --- trunk/reactos/ntoskrnl/mm/virtual.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/mm/virtual.c [iso-8859-1] Mon May 5 16:07:32 2008 @@ -80,8 +80,8 @@ PAGED_CODE(); /* Calculate the maximum amount of data to move */ - TotalSize = MI_MAPPED_COPY_PAGES - 2; - if (BufferSize <= (MI_MAPPED_COPY_PAGES - 2)) TotalSize = BufferSize; + TotalSize = (MI_MAPPED_COPY_PAGES - 2) * PAGE_SIZE; + if (BufferSize <= TotalSize) TotalSize = BufferSize; CurrentSize = BufferSize; RemainingSize = TotalSize;

1 0

[hpoussin] 33306: Initialize size field of the OLEINPLACEFRAMEINFO structure. This should prevent Explorer to disappear when user doesn't want to download the Mozilla ActiveX control. See issue #3126 for more details.
by hpoussin＠svn.reactos.org 05 May '08

05 May '08

Author: hpoussin Date: Mon May 5 15:16:34 2008 New Revision: 33306 URL: http://svn.reactos.org/svn/reactos?rev=33306&view=rev Log: Initialize size field of the OLEINPLACEFRAMEINFO structure. This should prevent Explorer to disappear when user doesn't want to download the Mozilla ActiveX control. See issue #3126 for more details. Modified: trunk/reactos/dll/win32/shdocvw/oleobject.c Modified: trunk/reactos/dll/win32/shdocvw/oleobject.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shdocvw/oleobjec… ============================================================================== --- trunk/reactos/dll/win32/shdocvw/oleobject.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/shdocvw/oleobject.c [iso-8859-1] Mon May 5 15:16:34 2008 @@ -706,6 +706,7 @@ memset(&This->pos_rect, 0, sizeof(RECT)); memset(&This->clip_rect, 0, sizeof(RECT)); memset(&This->frameinfo, 0, sizeof(OLEINPLACEFRAMEINFO)); + This->frameinfo.cb = sizeof(OLEINPLACEFRAMEINFO); } void WebBrowser_OleObject_Destroy(WebBrowser *This)

1 0

[greatlrd] 33305: bye bye DXG_GET_INDEX_FUNCTION patch from Stefan Ginsberg stefan__100__at hotmail dot com it remove the bad macro DXG_GET_INDEX_FUNCTION that never worked as it should.
by greatlrd＠svn.reactos.org 05 May '08

05 May '08

Author: greatlrd Date: Mon May 5 14:42:23 2008 New Revision: 33305 URL: http://svn.reactos.org/svn/reactos?rev=33305&view=rev Log: bye bye DXG_GET_INDEX_FUNCTION patch from Stefan Ginsberg stefan__100__at hotmail dot com it remove the bad macro DXG_GET_INDEX_FUNCTION that never worked as it should. Modified: trunk/reactos/subsystems/win32/win32k/include/intddraw.h trunk/reactos/subsystems/win32/win32k/ntddraw/dvp.c Modified: trunk/reactos/subsystems/win32/win32k/include/intddraw.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/in… ============================================================================== --- trunk/reactos/subsystems/win32/win32k/include/intddraw.h [iso-8859-1] (original) +++ trunk/reactos/subsystems/win32/win32k/include/intddraw.h [iso-8859-1] Mon May 5 14:42:23 2008 @@ -108,18 +108,6 @@ typedef PDD_SURFACE_LOCAL (NTAPI *PGD_ENGLOCKDIRECTDRAWSURFACE)(HANDLE); typedef BOOL (NTAPI *PGD_ENGUNLOCKDIRECTDRAWSURFACE)(PDD_SURFACE_LOCAL); - -/* Standard macro */ -#define DXG_GET_INDEX_FUNCTION(INDEX, FUNCTION) \ - for (i = 0; i <= DXG_INDEX_DxDdIoctl; i++) \ - { \ - if (gpDxFuncs[i].iFunc == INDEX) \ - { \ - FUNCTION = (VOID *)gpDxFuncs[i].pfn; \ - break; \ - } \ - } - /* Gammaramp internal prototype */ BOOL FASTCALL IntGetDeviceGammaRamp(HDEV hPDev, PGAMMARAMP Ramp); BOOL FASTCALL IntSetDeviceGammaRamp(HDEV hPDev, PGAMMARAMP Ramp, BOOL); Modified: trunk/reactos/subsystems/win32/win32k/ntddraw/dvp.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/nt… ============================================================================== --- trunk/reactos/subsystems/win32/win32k/ntddraw/dvp.c [iso-8859-1] (original) +++ trunk/reactos/subsystems/win32/win32k/ntddraw/dvp.c [iso-8859-1] Mon May 5 14:42:23 2008 @@ -1,4 +1,3 @@ - /* * COPYRIGHT: See COPYING in the top level directory * PROJECT: ReactOS kernel @@ -187,10 +186,7 @@ NtGdiDvpGetVideoPortLine(HANDLE hVideoPort, PDD_GETVPORTLINEDATA puGetVPortLineData) { - PGD_DXDVPGETVIDEOPORTLINE pfnDvpGetVideoPortLine = NULL; - INT i; - - DXG_GET_INDEX_FUNCTION(DXG_INDEX_DxDvpGetVideoPortLine, pfnDvpGetVideoPortLine); + PGD_DXDVPGETVIDEOPORTLINE pfnDvpGetVideoPortLine = (PGD_DXDVPGETVIDEOPORTLINE)gpDxFuncs[DXG_INDEX_DxDvpGetVideoPortLine].pfn; if (pfnDvpGetVideoPortLine == NULL) { @@ -211,10 +207,7 @@ NtGdiDvpGetVideoPortOutputFormats(HANDLE hVideoPort, PDD_GETVPORTOUTPUTFORMATDATA puGetVPortOutputFormatData) { - PGD_DXDVPGETVIDEOPORTOUTPUTFORMATS pfnDvpGetVideoPortOutputFormats = NULL; - INT i; - - DXG_GET_INDEX_FUNCTION(DXG_INDEX_DxDvpGetVideoPortOutputFormats, puGetVPortOutputFormatData); + PGD_DXDVPGETVIDEOPORTOUTPUTFORMATS pfnDvpGetVideoPortOutputFormats = (PGD_DXDVPGETVIDEOPORTOUTPUTFORMATS)gpDxFuncs[DXG_INDEX_DxDvpGetVideoPortOutputFormats].pfn; if (pfnDvpGetVideoPortOutputFormats == NULL) { @@ -236,10 +229,7 @@ NtGdiDvpGetVideoPortConnectInfo(HANDLE hDirectDraw, PDD_GETVPORTCONNECTDATA puGetVPortConnectData) { - PGD_DXDVPGETVIDEOPORTCONNECTINFO pfnDvpGetVideoPortConnectInfo = NULL; - INT i; - - DXG_GET_INDEX_FUNCTION(DXG_INDEX_DxDvpGetVideoPortConnectInfo, pfnDvpGetVideoPortConnectInfo); + PGD_DXDVPGETVIDEOPORTCONNECTINFO pfnDvpGetVideoPortConnectInfo = (PGD_DXDVPGETVIDEOPORTCONNECTINFO)gpDxFuncs[DXG_INDEX_DxDvpGetVideoPortConnectInfo].pfn; if (pfnDvpGetVideoPortConnectInfo == NULL) { @@ -260,10 +250,7 @@ NtGdiDvpGetVideoSignalStatus(HANDLE hVideoPort, PDD_GETVPORTSIGNALDATA puGetVPortSignalData) { - PGD_DXDVPGETVIDEOSIGNALSTATUS pfnDvpGetVideoSignalStatus = NULL; - INT i; - - DXG_GET_INDEX_FUNCTION(DXG_INDEX_DxDvpGetVideoSignalStatus, pfnDvpGetVideoSignalStatus); + PGD_DXDVPGETVIDEOSIGNALSTATUS pfnDvpGetVideoSignalStatus = (PGD_DXDVPGETVIDEOSIGNALSTATUS)gpDxFuncs[DXG_INDEX_DxDvpGetVideoSignalStatus].pfn; if (pfnDvpGetVideoSignalStatus == NULL) { @@ -287,10 +274,7 @@ HANDLE* phSurfaceVbi, PDD_UPDATEVPORTDATA puUpdateVPortData) { - PGD_DXDVPUPDATEVIDEOPORT pfnDvpUpdateVideoPort = NULL; - INT i; - - DXG_GET_INDEX_FUNCTION(DXG_INDEX_DxDvpUpdateVideoPort, pfnDvpUpdateVideoPort); + PGD_DXDVPUPDATEVIDEOPORT pfnDvpUpdateVideoPort = (PGD_DXDVPUPDATEVIDEOPORT)gpDxFuncs[DXG_INDEX_DxDvpUpdateVideoPort].pfn; if (pfnDvpUpdateVideoPort == NULL) { @@ -312,10 +296,7 @@ NtGdiDvpWaitForVideoPortSync(HANDLE hVideoPort, PDD_WAITFORVPORTSYNCDATA puWaitForVPortSyncData) { - PGD_DXDVPWAITFORVIDEOPORTSYNC pfnDvpWaitForVideoPortSync = NULL; - INT i; - - DXG_GET_INDEX_FUNCTION(DXG_INDEX_DxDvpWaitForVideoPortSync, pfnDvpWaitForVideoPortSync); + PGD_DXDVPWAITFORVIDEOPORTSYNC pfnDvpWaitForVideoPortSync = (PGD_DXDVPWAITFORVIDEOPORTSYNC)gpDxFuncs[DXG_INDEX_DxDvpWaitForVideoPortSync].pfn; if (pfnDvpWaitForVideoPortSync == NULL) { @@ -337,10 +318,7 @@ HANDLE* hEvent, LPDDVIDEOPORTNOTIFY pNotify) { - PGD_DXDVPACQUIRENOTIFICATION pfnDvpAcquireNotification = NULL; - INT i; - - DXG_GET_INDEX_FUNCTION(DXG_INDEX_DxDvpAcquireNotification, pfnDvpAcquireNotification); + PGD_DXDVPACQUIRENOTIFICATION pfnDvpAcquireNotification = (PGD_DXDVPACQUIRENOTIFICATION)gpDxFuncs[DXG_INDEX_DxDvpAcquireNotification].pfn; if (pfnDvpAcquireNotification == NULL) { @@ -361,10 +339,7 @@ NtGdiDvpReleaseNotification(HANDLE hVideoPort, HANDLE hEvent) { - PGD_DXDVPRELEASENOTIFICATION pfnDvpReleaseNotification = NULL; - INT i; - - DXG_GET_INDEX_FUNCTION(DXG_INDEX_DxDvpReleaseNotification, pfnDvpReleaseNotification); + PGD_DXDVPRELEASENOTIFICATION pfnDvpReleaseNotification = (PGD_DXDVPRELEASENOTIFICATION)gpDxFuncs[DXG_INDEX_DxDvpReleaseNotification].pfn; if (pfnDvpReleaseNotification == NULL) { @@ -386,10 +361,7 @@ NtGdiDvpGetVideoPortField(HANDLE hVideoPort, PDD_GETVPORTFIELDDATA puGetVPortFieldData) { - PGD_DXDVPGETVIDEOPORTFIELD pfnDvpGetVideoPortField = NULL; - INT i; - - DXG_GET_INDEX_FUNCTION(DXG_INDEX_DxDvpGetVideoPortField, pfnDvpGetVideoPortField); + PGD_DXDVPGETVIDEOPORTFIELD pfnDvpGetVideoPortField = (PGD_DXDVPGETVIDEOPORTFIELD)gpDxFuncs[DXG_INDEX_DxDvpGetVideoPortField].pfn; if (pfnDvpGetVideoPortField == NULL) { @@ -401,4 +373,3 @@ return pfnDvpGetVideoPortField(hVideoPort, puGetVPortFieldData); } -

1 0

[gbrunmar] 33304: Made IDirect3DDevice9::GetAvailableTextureMem() less error prone, based on feedback from GreatLord
by gbrunmar＠svn.reactos.org 05 May '08

05 May '08

Author: gbrunmar Date: Mon May 5 14:32:41 2008 New Revision: 33304 URL: http://svn.reactos.org/svn/reactos?rev=33304&view=rev Log: Made IDirect3DDevice9::GetAvailableTextureMem() less error prone, based on feedback from GreatLord Modified: trunk/reactos/dll/directx/d3d9/d3d9_device.c Modified: trunk/reactos/dll/directx/d3d9/d3d9_device.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/directx/d3d9/d3d9_devi… ============================================================================== --- trunk/reactos/dll/directx/d3d9/d3d9_device.c [iso-8859-1] (original) +++ trunk/reactos/dll/directx/d3d9/d3d9_device.c [iso-8859-1] Mon May 5 14:32:41 2008 @@ -95,6 +95,7 @@ memset(&ddGetAvailDriverMemoryData, 0, sizeof(ddGetAvailDriverMemoryData)); ddGetAvailDriverMemoryData.lpDD = (LPDDRAWI_DIRECTDRAW_GBL)&This->DeviceData[0].pUnknown6BC->hDD; + ddGetAvailDriverMemoryData.ddRVal = DDERR_GENERIC; if (DDHAL_DRIVER_HANDLED == (*This->DeviceData[0].D3D9Callbacks.DdGetAvailDriverMemory)(&ddGetAvailDriverMemoryData)) {

1 0

[gbrunmar] 33303: Changed struct in IDirect3DDevice9::GetAvailableTextureMem() based on feedback from GreatLord
by gbrunmar＠svn.reactos.org 05 May '08

05 May '08

Author: gbrunmar Date: Mon May 5 14:15:26 2008 New Revision: 33303 URL: http://svn.reactos.org/svn/reactos?rev=33303&view=rev Log: Changed struct in IDirect3DDevice9::GetAvailableTextureMem() based on feedback from GreatLord Modified: trunk/reactos/dll/directx/d3d9/d3d9_device.c trunk/reactos/dll/directx/d3d9/d3d9_private.h Modified: trunk/reactos/dll/directx/d3d9/d3d9_device.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/directx/d3d9/d3d9_devi… ============================================================================== --- trunk/reactos/dll/directx/d3d9/d3d9_device.c [iso-8859-1] (original) +++ trunk/reactos/dll/directx/d3d9/d3d9_device.c [iso-8859-1] Mon May 5 14:15:26 2008 @@ -88,13 +88,13 @@ static UINT WINAPI IDirect3DDevice9Impl_GetAvailableTextureMem(LPDIRECT3DDEVICE9 iface) { UINT AvailableTextureMemory = 0; - DD_GETAVAILDRIVERMEMORYDATA ddGetAvailDriverMemoryData; + DDHAL_GETAVAILDRIVERMEMORYDATA ddGetAvailDriverMemoryData; LPDIRECT3DDEVICE9_INT This = impl_from_IDirect3DDevice9(iface); LOCK_D3DDEVICE9(); memset(&ddGetAvailDriverMemoryData, 0, sizeof(ddGetAvailDriverMemoryData)); - ddGetAvailDriverMemoryData.lpDD = (PDD_DIRECTDRAW_GLOBAL)&This->DeviceData[0].pUnknown6BC->hDD; + ddGetAvailDriverMemoryData.lpDD = (LPDDRAWI_DIRECTDRAW_GBL)&This->DeviceData[0].pUnknown6BC->hDD; if (DDHAL_DRIVER_HANDLED == (*This->DeviceData[0].D3D9Callbacks.DdGetAvailDriverMemory)(&ddGetAvailDriverMemoryData)) { Modified: trunk/reactos/dll/directx/d3d9/d3d9_private.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/directx/d3d9/d3d9_priv… ============================================================================== --- trunk/reactos/dll/directx/d3d9/d3d9_private.h [iso-8859-1] (original) +++ trunk/reactos/dll/directx/d3d9/d3d9_private.h [iso-8859-1] Mon May 5 14:15:26 2008 @@ -10,7 +10,7 @@ #include <windows.h> #include <ddraw.h> -#include <ddrawint.h> +#include <ddrawi.h> #define D3D9_INT_MAX_NUM_ADAPTERS 12 @@ -108,7 +108,7 @@ /* 0x0044 */ DWORD DdFlip; /* 0x0048 */ DWORD DdGetBltStatus; /* 0x004c */ DWORD DdGetFlipStatus; -/* 0x0050 */ PDD_GETAVAILDRIVERMEMORY DdGetAvailDriverMemory; +/* 0x0050 */ LPDDHAL_GETAVAILDRIVERMEMORY DdGetAvailDriverMemory; /* 0x0054 */ DWORD unknown0115; /* 0x0058 */ DWORD DdSetMode; /* 0x005c */ DWORD DdSetExclusiveMode;

1 0

[greatlrd] 33302: patch from Stefan Ginsberg stefan__100__at hotmail dot com it remove the bad macro DXG_GET_INDEX_FUNCTION that never worked as it should.
by greatlrd＠svn.reactos.org 05 May '08

05 May '08

Author: greatlrd Date: Mon May 5 13:30:14 2008 New Revision: 33302 URL: http://svn.reactos.org/svn/reactos?rev=33302&view=rev Log: patch from Stefan Ginsberg stefan__100__at hotmail dot com it remove the bad macro DXG_GET_INDEX_FUNCTION that never worked as it should. Modified: trunk/reactos/subsystems/win32/win32k/ntddraw/mocomp.c Modified: trunk/reactos/subsystems/win32/win32k/ntddraw/mocomp.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/nt… ============================================================================== --- trunk/reactos/subsystems/win32/win32k/ntddraw/mocomp.c [iso-8859-1] (original) +++ trunk/reactos/subsystems/win32/win32k/ntddraw/mocomp.c [iso-8859-1] Mon May 5 13:30:14 2008 @@ -20,10 +20,7 @@ NtGdiDdBeginMoCompFrame(HANDLE hMoComp, PDD_BEGINMOCOMPFRAMEDATA puBeginFrameData) { - PGD_DDBEGINMOCOMPFRAME pfnDdBeginMoCompFrame = NULL; - INT i; - - DXG_GET_INDEX_FUNCTION(DXG_INDEX_DxDdBeginMoCompFrame, pfnDdBeginMoCompFrame); + PGD_DDBEGINMOCOMPFRAME pfnDdBeginMoCompFrame = (PGD_DDBEGINMOCOMPFRAME)gpDxFuncs[DXG_INDEX_DxDdBeginMoCompFrame].pfn; if (pfnDdBeginMoCompFrame == NULL) { @@ -42,10 +39,7 @@ STDCALL NtGdiDdCreateMoComp(HANDLE hDirectDraw, PDD_CREATEMOCOMPDATA puCreateMoCompData) { - PGD_DXDDCREATEMOCOMP pfnDdCreateMoComp = NULL; - INT i; - - DXG_GET_INDEX_FUNCTION(DXG_INDEX_DxDdCreateMoComp, pfnDdCreateMoComp); + PGD_DXDDCREATEMOCOMP pfnDdCreateMoComp = (PGD_DXDDCREATEMOCOMP)gpDxFuncs[DXG_INDEX_DxDdCreateMoComp].pfn; if (pfnDdCreateMoComp == NULL) { @@ -65,10 +59,7 @@ NtGdiDdDestroyMoComp(HANDLE hMoComp, PDD_DESTROYMOCOMPDATA puBeginFrameData) { - PGD_DXDDDESTROYMOCOMP pfnDxDdDestroyMoComp = NULL; - INT i; - - DXG_GET_INDEX_FUNCTION(DXG_INDEX_DxDdDestroyMoComp, pfnDxDdDestroyMoComp); + PGD_DXDDDESTROYMOCOMP pfnDxDdDestroyMoComp = (PGD_DXDDDESTROYMOCOMP)gpDxFuncs[DXG_INDEX_DxDdDestroyMoComp].pfn; if (pfnDxDdDestroyMoComp == NULL) { @@ -88,10 +79,7 @@ NtGdiDdEndMoCompFrame(HANDLE hMoComp, PDD_ENDMOCOMPFRAMEDATA puEndFrameData) { - PGD_DXDDENDMOCOMPFRAME pfnDdEndMoCompFrame = NULL; - INT i; - - DXG_GET_INDEX_FUNCTION(DXG_INDEX_DxDdEndMoCompFrame, pfnDdEndMoCompFrame); + PGD_DXDDENDMOCOMPFRAME pfnDdEndMoCompFrame = (PGD_DXDDENDMOCOMPFRAME)gpDxFuncs[DXG_INDEX_DxDdEndMoCompFrame].pfn; if (pfnDdEndMoCompFrame == NULL) { @@ -111,10 +99,7 @@ NtGdiDdGetInternalMoCompInfo(HANDLE hDirectDraw, PDD_GETINTERNALMOCOMPDATA puGetInternalData) { - PGD_DXDDGETINTERNALMOCOMPINFO pfnDdGetInternalMoCompInfo = NULL; - INT i; - - DXG_GET_INDEX_FUNCTION(DXG_INDEX_DxDdGetInternalMoCompInfo, pfnDdGetInternalMoCompInfo); + PGD_DXDDGETINTERNALMOCOMPINFO pfnDdGetInternalMoCompInfo = (PGD_DXDDGETINTERNALMOCOMPINFO)gpDxFuncs[DXG_INDEX_DxDdGetInternalMoCompInfo].pfn; if (pfnDdGetInternalMoCompInfo == NULL) { @@ -135,10 +120,7 @@ NtGdiDdGetMoCompBuffInfo(HANDLE hDirectDraw, PDD_GETMOCOMPCOMPBUFFDATA puGetBuffData) { - PGD_DXDDGETMOCOMPBUFFINFO pfnDdGetMoCompBuffInfo = NULL; - INT i; - - DXG_GET_INDEX_FUNCTION(DXG_INDEX_DxDdGetMoCompBuffInfo, pfnDdGetMoCompBuffInfo); + PGD_DXDDGETMOCOMPBUFFINFO pfnDdGetMoCompBuffInfo = (PGD_DXDDGETMOCOMPBUFFINFO)gpDxFuncs[DXG_INDEX_DxDdGetMoCompBuffInfo].pfn; if (pfnDdGetMoCompBuffInfo == NULL) { @@ -158,10 +140,7 @@ NtGdiDdGetMoCompFormats(HANDLE hDirectDraw, PDD_GETMOCOMPFORMATSDATA puGetMoCompFormatsData) { - PGD_DXDDGETMOCOMPFORMATS pfnDdGetMoCompFormats = NULL; - INT i; - - DXG_GET_INDEX_FUNCTION(DXG_INDEX_DxDdGetMoCompFormats, pfnDdGetMoCompFormats); + PGD_DXDDGETMOCOMPFORMATS pfnDdGetMoCompFormats = (PGD_DXDDGETMOCOMPFORMATS)gpDxFuncs[DXG_INDEX_DxDdGetMoCompFormats].pfn; if (pfnDdGetMoCompFormats == NULL) { @@ -182,10 +161,7 @@ NtGdiDdGetMoCompGuids(HANDLE hDirectDraw, PDD_GETMOCOMPGUIDSDATA puGetMoCompGuidsData) { - PGD_DXDDGETMOCOMPGUIDS pfnDdGetMoCompGuids = NULL; - INT i; - - DXG_GET_INDEX_FUNCTION(DXG_INDEX_DxDdGetMoCompGuids, pfnDdGetMoCompGuids); + PGD_DXDDGETMOCOMPGUIDS pfnDdGetMoCompGuids = (PGD_DXDDGETMOCOMPGUIDS)gpDxFuncs[DXG_INDEX_DxDdGetMoCompGuids].pfn; if (pfnDdGetMoCompGuids == NULL) { @@ -207,10 +183,7 @@ NtGdiDdQueryMoCompStatus(HANDLE hMoComp, PDD_QUERYMOCOMPSTATUSDATA puQueryMoCompStatusData) { - PGD_DXDDQUERYMOCOMPSTATUS pfnDdQueryMoCompStatus = NULL; - INT i; - - DXG_GET_INDEX_FUNCTION(DXG_INDEX_DxDdQueryMoCompStatus, pfnDdQueryMoCompStatus); + PGD_DXDDQUERYMOCOMPSTATUS pfnDdQueryMoCompStatus = (PGD_DXDDQUERYMOCOMPSTATUS)gpDxFuncs[DXG_INDEX_DxDdQueryMoCompStatus].pfn; if (pfnDdQueryMoCompStatus == NULL) { @@ -231,10 +204,7 @@ NtGdiDdRenderMoComp(HANDLE hMoComp, PDD_RENDERMOCOMPDATA puRenderMoCompData) { - PGD_DXDDRENDERMOCOMP pfnDdRenderMoComp = NULL; - INT i; - - DXG_GET_INDEX_FUNCTION(DXG_INDEX_DxDdRenderMoComp, pfnDdRenderMoComp); + PGD_DXDDRENDERMOCOMP pfnDdRenderMoComp = (PGD_DXDDRENDERMOCOMP)gpDxFuncs[DXG_INDEX_DxDdRenderMoComp].pfn; if (pfnDdRenderMoComp == NULL) { @@ -246,5 +216,3 @@ return pfnDdRenderMoComp(hMoComp, puRenderMoCompData); } - -

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs