Ros-diffs

ros-diffs@reactos.org

81390 discussions

[dreimer] 32156: Why easy if you can get it difficult. Removed two Variables I used in charch. Add a security check for title setting. Check if RosBE Version got declared.
by dreimer＠svn.reactos.org 06 Feb '08

06 Feb '08

Author: dreimer Date: Wed Feb 6 14:00:24 2008 New Revision: 32156 URL: http://svn.reactos.org/svn/reactos?rev=32156&view=rev Log: Why easy if you can get it difficult. Removed two Variables I used in charch. Add a security check for title setting. Check if RosBE Version got declared. Modified: trunk/tools/RosBE/RosBE-Windows/Root/Build.cmd trunk/tools/RosBE/RosBE-Windows/Root/Clean.cmd trunk/tools/RosBE/RosBE-Windows/Root/Config.cmd trunk/tools/RosBE/RosBE-Windows/Root/Help.cmd trunk/tools/RosBE/RosBE-Windows/Root/charch.cmd trunk/tools/RosBE/RosBE-Windows/Root/chdefdir.cmd trunk/tools/RosBE/RosBE-Windows/Root/options.cmd trunk/tools/RosBE/RosBE-Windows/Root/reladdr2line.cmd trunk/tools/RosBE/RosBE-Windows/Root/sSVN.cmd trunk/tools/RosBE/RosBE-Windows/Root/scut.cmd Modified: trunk/tools/RosBE/RosBE-Windows/Root/Build.cmd URL: http://svn.reactos.org/svn/reactos/trunk/tools/RosBE/RosBE-Windows/Root/Bui… ============================================================================== --- trunk/tools/RosBE/RosBE-Windows/Root/Build.cmd (original) +++ trunk/tools/RosBE/RosBE-Windows/Root/Build.cmd Wed Feb 6 14:00:24 2008 @@ -163,7 +163,9 @@ :: "%_ROSBE_BASEDIR%\Tools\flash.exe" -title ReactOS Build Environment %_ROSBE_VERSION% +if defined _ROSBE_VERSION ( + title ReactOS Build Environment %_ROSBE_VERSION% +) :: :: Unload all used Vars. Modified: trunk/tools/RosBE/RosBE-Windows/Root/Clean.cmd URL: http://svn.reactos.org/svn/reactos/trunk/tools/RosBE/RosBE-Windows/Root/Cle… ============================================================================== --- trunk/tools/RosBE/RosBE-Windows/Root/Clean.cmd (original) +++ trunk/tools/RosBE/RosBE-Windows/Root/Clean.cmd Wed Feb 6 14:00:24 2008 @@ -73,5 +73,6 @@ ) goto :EOF -:EOC -title ReactOS Build Environment %_ROSBE_VERSION% +:EOCif defined _ROSBE_VERSION ( + title ReactOS Build Environment %_ROSBE_VERSION% +) Modified: trunk/tools/RosBE/RosBE-Windows/Root/Config.cmd URL: http://svn.reactos.org/svn/reactos/trunk/tools/RosBE/RosBE-Windows/Root/Con… ============================================================================== --- trunk/tools/RosBE/RosBE-Windows/Root/Config.cmd (original) +++ trunk/tools/RosBE/RosBE-Windows/Root/Config.cmd Wed Feb 6 14:00:24 2008 @@ -248,7 +248,9 @@ goto :NOK :NOK -title ReactOS Build Environment %_ROSBE_VERSION% +if defined _ROSBE_VERSION ( + title ReactOS Build Environment %_ROSBE_VERSION% +) :: :: Unload all used Vars. Modified: trunk/tools/RosBE/RosBE-Windows/Root/Help.cmd URL: http://svn.reactos.org/svn/reactos/trunk/tools/RosBE/RosBE-Windows/Root/Hel… ============================================================================== --- trunk/tools/RosBE/RosBE-Windows/Root/Help.cmd (original) +++ trunk/tools/RosBE/RosBE-Windows/Root/Help.cmd Wed Feb 6 14:00:24 2008 @@ -107,7 +107,6 @@ echo Change the ReactOS source directory for the current RosBE session. echo Possible Architectures are: x86, ppc, arm. echo. - echo previous - Switch to the previous ReactOS source directory. goto :EOC ) ) @@ -203,4 +202,6 @@ ) :EOC -title ReactOS Build Environment %_ROSBE_VERSION% +if defined _ROSBE_VERSION ( + title ReactOS Build Environment %_ROSBE_VERSION% +) Modified: trunk/tools/RosBE/RosBE-Windows/Root/charch.cmd URL: http://svn.reactos.org/svn/reactos/trunk/tools/RosBE/RosBE-Windows/Root/cha… ============================================================================== --- trunk/tools/RosBE/RosBE-Windows/Root/charch.cmd (original) +++ trunk/tools/RosBE/RosBE-Windows/Root/charch.cmd Wed Feb 6 14:00:24 2008 @@ -15,28 +15,28 @@ :: :: Parse the command line arguments. +:: ROS_ARCH: Set to x86, ppc or arm. +:: ROS_PREFIX: Default is mingw32. ppc could be mingw32-ppc, arm mingw32-arm. :: + if "%1" == "" ( call :INTERACTIVE ) else ( set _1=%1 ) -if /i "%_1%" == "previous" ( - popd -) if /i "%_1%" == "x86" ( - set _ROSBE_ARCH%=x86 - set _ROSBE_PREFIX=mingw32 + set ROS_ARCH= + set ROS_PREFIX= goto :EOC ) if /i "%_1%" == "arm" ( - set _ROSBE_ARCH%=arm - set _ROSBE_PREFIX=mingwarm + set ROS_ARCH=arm + set ROS_PREFIX=mingw32-arm goto :EOC ) if /i "%_1%" == "ppc" ( - set _ROSBE_ARCH%=ppc - set _ROSBE_PREFIX=mingwppc + set ROS_ARCH==ppc + set ROS_PREFIX=mingw32-ppc goto :EOC ) if not "%_1%" == "" ( @@ -57,27 +57,8 @@ goto :EOF :EOC -pushd %_1% - -:: -:: Set to x86, ppc or arm. -:: -set ROS_ARCH=%_ROSBE_ARCH% - -:: -:: Default is mingw32. ppc could be mingwppc, arm mingwarm. -:: -set ROS_PREFIX=%_ROSBE_PREFIX% - REM chdefgcc %PATH% -REM Maybe another way to set the compiler... if defined _ROSBE_VERSION ( title ReactOS Build Environment %_ROSBE_VERSION% ) - -:: -:: Unload all used Vars. -:: -set _ROSBE_ARCH= -set _ROSBE_PREFIX= Modified: trunk/tools/RosBE/RosBE-Windows/Root/chdefdir.cmd URL: http://svn.reactos.org/svn/reactos/trunk/tools/RosBE/RosBE-Windows/Root/chd… ============================================================================== --- trunk/tools/RosBE/RosBE-Windows/Root/chdefdir.cmd (original) +++ trunk/tools/RosBE/RosBE-Windows/Root/chdefdir.cmd Wed Feb 6 14:00:24 2008 @@ -48,7 +48,9 @@ goto :EOF :EOC -title ReactOS Build Environment %_ROSBE_VERSION% +if defined _ROSBE_VERSION ( + title ReactOS Build Environment %_ROSBE_VERSION% +) :: :: Unload all used Vars. Modified: trunk/tools/RosBE/RosBE-Windows/Root/options.cmd URL: http://svn.reactos.org/svn/reactos/trunk/tools/RosBE/RosBE-Windows/Root/opt… ============================================================================== --- trunk/tools/RosBE/RosBE-Windows/Root/options.cmd (original) +++ trunk/tools/RosBE/RosBE-Windows/Root/options.cmd Wed Feb 6 14:00:24 2008 @@ -28,4 +28,6 @@ echo ERROR: options.exe was not found. ) -title ReactOS Build Environment %_ROSBE_VERSION% +if defined _ROSBE_VERSION ( + title ReactOS Build Environment %_ROSBE_VERSION% +) Modified: trunk/tools/RosBE/RosBE-Windows/Root/reladdr2line.cmd URL: http://svn.reactos.org/svn/reactos/trunk/tools/RosBE/RosBE-Windows/Root/rel… ============================================================================== --- trunk/tools/RosBE/RosBE-Windows/Root/reladdr2line.cmd (original) +++ trunk/tools/RosBE/RosBE-Windows/Root/reladdr2line.cmd Wed Feb 6 14:00:24 2008 @@ -84,7 +84,9 @@ goto :EOF :EOC -title ReactOS Build Environment %_ROSBE_VERSION% +if defined _ROSBE_VERSION ( + title ReactOS Build Environment %_ROSBE_VERSION% +) :: :: Unload all used Vars. Modified: trunk/tools/RosBE/RosBE-Windows/Root/sSVN.cmd URL: http://svn.reactos.org/svn/reactos/trunk/tools/RosBE/RosBE-Windows/Root/sSV… ============================================================================== --- trunk/tools/RosBE/RosBE-Windows/Root/sSVN.cmd (original) +++ trunk/tools/RosBE/RosBE-Windows/Root/sSVN.cmd Wed Feb 6 14:00:24 2008 @@ -90,7 +90,9 @@ if /i "%UP%"=="no" goto :EOC :EOC -title ReactOS Build Environment %_ROSBE_VERSION% +if defined _ROSBE_VERSION ( + title ReactOS Build Environment %_ROSBE_VERSION% +) :: :: Unload all used Vars. Modified: trunk/tools/RosBE/RosBE-Windows/Root/scut.cmd URL: http://svn.reactos.org/svn/reactos/trunk/tools/RosBE/RosBE-Windows/Root/scu… ============================================================================== --- trunk/tools/RosBE/RosBE-Windows/Root/scut.cmd (original) +++ trunk/tools/RosBE/RosBE-Windows/Root/scut.cmd Wed Feb 6 14:00:24 2008 @@ -38,4 +38,6 @@ call "%_ROSBE_BASEDIR%\Tools\scut.exe" "%1" %2 %3 :EOC -title ReactOS Build Environment %_ROSBE_VERSION% +if defined _ROSBE_VERSION ( + title ReactOS Build Environment %_ROSBE_VERSION% +)

1 0

[hpoussin] 32155: Fix typo
by hpoussin＠svn.reactos.org 06 Feb '08

06 Feb '08

Author: hpoussin Date: Wed Feb 6 13:37:21 2008 New Revision: 32155 URL: http://svn.reactos.org/svn/reactos?rev=32155&view=rev Log: Fix typo Modified: trunk/reactos/boot/freeldr/freeldr/reactos/reactos.c Modified: trunk/reactos/boot/freeldr/freeldr/reactos/reactos.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/react… ============================================================================== --- trunk/reactos/boot/freeldr/freeldr/reactos/reactos.c (original) +++ trunk/reactos/boot/freeldr/freeldr/reactos/reactos.c Wed Feb 6 13:37:21 2008 @@ -717,7 +717,7 @@ */ if (!FsOpenSystemVolume(SystemPath, szBootPath, &LoaderBlock.BootDevice)) { - UiMessageBox("Failed to open boot drive."); + UiMessageBox("Failed to open system drive."); return; }

1 0

[gedmurphy] 32154: fix indentation
by gedmurphy＠svn.reactos.org 06 Feb '08

06 Feb '08

Author: gedmurphy Date: Wed Feb 6 13:34:03 2008 New Revision: 32154 URL: http://svn.reactos.org/svn/reactos?rev=32154&view=rev Log: fix indentation Modified: trunk/reactos/boot/freeldr/freeldr/freeldr_arch.rbuild Modified: trunk/reactos/boot/freeldr/freeldr/freeldr_arch.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/freel… ============================================================================== --- trunk/reactos/boot/freeldr/freeldr/freeldr_arch.rbuild (original) +++ trunk/reactos/boot/freeldr/freeldr/freeldr_arch.rbuild Wed Feb 6 13:34:03 2008 @@ -59,8 +59,8 @@ <file>ofw.c</file> <file>ofw_util.s</file> <file>ofw_calls.s</file> - <file>ofwdisk.c</file> - <file>ofw_method.c</file> + <file>ofwdisk.c</file> + <file>ofw_method.c</file> <file>prep.c</file> <file>prep_ide.c</file> <file>prep_pci.c</file> @@ -103,7 +103,7 @@ <file>boot.s</file> <file>ferouart.c</file> <file>macharm.c</file> - <file>stubs.c</file> + <file>stubs.c</file> </module> </if> </directory>

1 0

[fireball] 32153: - Make i8042Flush flush both output and input buffers. - Make i8042Flush apply only KBD_OBF flag (applying MOU_OBF leads to an infinite loop trying to flush the buffer). - Fix a bug in i8042Write, where instead of waiting by polling a PollingIterations times (~10000), it was using ResendIterations (=3), thus giving 8042 very small chance of processing the data. - Make i8042BasicDetect resend CTRL_SELF_TEST sequence, if controller asks so. Maximum resend iterations are limited b
by fireball＠svn.reactos.org 06 Feb '08

06 Feb '08

Author: fireball Date: Wed Feb 6 12:46:38 2008 New Revision: 32153 URL: http://svn.reactos.org/svn/reactos?rev=32153&view=rev Log: - Make i8042Flush flush both output and input buffers. - Make i8042Flush apply only KBD_OBF flag (applying MOU_OBF leads to an infinite loop trying to flush the buffer). - Fix a bug in i8042Write, where instead of waiting by polling a PollingIterations times (~10000), it was using ResendIterations (=3), thus giving 8042 very small chance of processing the data. - Make i8042BasicDetect resend CTRL_SELF_TEST sequence, if controller asks so. Maximum resend iterations are limited by ResendIterations variable. - Reinsert debug-messages hack, since this is an early-loading driver, and it's not possible to break in to KDBG to change debug filter values. - As a result, keyboard and mouse work on real hardware again. See issue #3036 for more details. Modified: trunk/reactos/drivers/input/i8042prt/i8042prt.c trunk/reactos/drivers/input/i8042prt/pnp.c trunk/reactos/drivers/input/i8042prt/readwrite.c Modified: trunk/reactos/drivers/input/i8042prt/i8042prt.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/input/i8042prt/i80… ============================================================================== --- trunk/reactos/drivers/input/i8042prt/i8042prt.c (original) +++ trunk/reactos/drivers/input/i8042prt/i8042prt.c Wed Feb 6 12:46:38 2008 @@ -475,6 +475,17 @@ ULONG i; NTSTATUS Status; + /* ROS Hack: ideally, we shouldn't have to initialize debug level this way, + but since the only way is to change it via KDBG, it's better to leave + it here too. */ +#if 0 + DbgSetDebugFilterState( + DPFLTR_I8042PRT_ID, + (1 << DPFLTR_ERROR_LEVEL) | (1 << DPFLTR_WARNING_LEVEL) | + (1 << DPFLTR_TRACE_LEVEL) /*| (1 << DPFLTR_INFO_LEVEL)*/ | DPFLTR_MASK, + TRUE); +#endif + Status = IoAllocateDriverObjectExtension( DriverObject, DriverObject, Modified: trunk/reactos/drivers/input/i8042prt/pnp.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/input/i8042prt/pnp… ============================================================================== --- trunk/reactos/drivers/input/i8042prt/pnp.c (original) +++ trunk/reactos/drivers/input/i8042prt/pnp.c Wed Feb 6 12:46:38 2008 @@ -75,6 +75,7 @@ IN PPORT_DEVICE_EXTENSION DeviceExtension) { NTSTATUS Status; + ULONG ResendIterations; UCHAR Value = 0; /* Don't enable keyboard and mouse interrupts, disable keyboard/mouse */ @@ -83,23 +84,33 @@ i8042Flush(DeviceExtension); - if (!i8042Write(DeviceExtension, DeviceExtension->ControlPort, CTRL_SELF_TEST)) - { - WARN_(I8042PRT, "Writing CTRL_SELF_TEST command failed\n"); - return STATUS_IO_TIMEOUT; - } - - Status = i8042ReadDataWait(DeviceExtension, &Value); - if (!NT_SUCCESS(Status)) - { - WARN_(I8042PRT, "Failed to read CTRL_SELF_TEST response, status 0x%08lx\n", Status); - return Status; - } - - if (Value != 0x55) - { - WARN_(I8042PRT, "Got 0x%02x instead of 0x55\n", Value); - return STATUS_IO_DEVICE_ERROR; + ResendIterations = DeviceExtension->Settings.ResendIterations + 1; + while (ResendIterations--) + { + if (!i8042Write(DeviceExtension, DeviceExtension->ControlPort, CTRL_SELF_TEST)) + { + WARN_(I8042PRT, "Writing CTRL_SELF_TEST command failed\n"); + return STATUS_IO_TIMEOUT; + } + + Status = i8042ReadDataWait(DeviceExtension, &Value); + if (!NT_SUCCESS(Status)) + { + WARN_(I8042PRT, "Failed to read CTRL_SELF_TEST response, status 0x%08lx\n", Status); + return Status; + } + + if (Value == KBD_RESEND) + { + TRACE_(I8042PRT, "Resending...\n", Value); + KeStallExecutionProcessor(50); + continue; + } + else if (Value != 0x55) + { + WARN_(I8042PRT, "Got 0x%02x instead of 0x55\n", Value); + return STATUS_IO_DEVICE_ERROR; + } } /* Modified: trunk/reactos/drivers/input/i8042prt/readwrite.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/input/i8042prt/rea… ============================================================================== --- trunk/reactos/drivers/input/i8042prt/readwrite.c (original) +++ trunk/reactos/drivers/input/i8042prt/readwrite.c Wed Feb 6 12:46:38 2008 @@ -21,8 +21,16 @@ { UCHAR Ignore; - while (NT_SUCCESS(i8042ReadData(DeviceExtension, KBD_OBF | MOU_OBF, &Ignore))) { - INFO_(I8042PRT, "Data flushed\n"); /* drop */ + /* Flush output buffer */ + while (NT_SUCCESS(i8042ReadData(DeviceExtension, KBD_OBF /* | MOU_OBF*/, &Ignore))) { + KeStallExecutionProcessor(50); + TRACE_(I8042PRT, "Output data flushed\n"); + } + + /* Flush input buffer */ + while (NT_SUCCESS(i8042ReadData(DeviceExtension, KBD_IBF, &Ignore))) { + KeStallExecutionProcessor(50); + TRACE_(I8042PRT, "Input data flushed\n"); } } @@ -189,20 +197,20 @@ IN PUCHAR addr, IN UCHAR data) { - ULONG ResendIterations; + ULONG Counter; ASSERT(addr); ASSERT(DeviceExtension->ControlPort != NULL); - ResendIterations = DeviceExtension->Settings.ResendIterations; + Counter = DeviceExtension->Settings.PollingIterations; while ((KBD_IBF & READ_PORT_UCHAR(DeviceExtension->ControlPort)) && - (ResendIterations--)) - { - KeStallExecutionProcessor(50); - } - - if (ResendIterations) + (Counter--)) + { + KeStallExecutionProcessor(50); + } + + if (Counter) { WRITE_PORT_UCHAR(addr, data); INFO_(I8042PRT, "Sent 0x%x to port %p\n", data, addr);

1 0

[dreimer] 32152: first step to add multiple Arches selection to RosBE
by dreimer＠svn.reactos.org 06 Feb '08

06 Feb '08

Author: dreimer Date: Wed Feb 6 11:37:56 2008 New Revision: 32152 URL: http://svn.reactos.org/svn/reactos?rev=32152&view=rev Log: first step to add multiple Arches selection to RosBE Added: trunk/tools/RosBE/RosBE-Windows/Root/charch.cmd (with props) Modified: trunk/tools/RosBE/RosBE-Windows/Root/ChangeLog.txt trunk/tools/RosBE/RosBE-Windows/Root/Help.cmd trunk/tools/RosBE/RosBE-Windows/Root/RosBE.cmd trunk/tools/RosBE/RosBE-Windows/Root/RosBE.mac Modified: trunk/tools/RosBE/RosBE-Windows/Root/ChangeLog.txt URL: http://svn.reactos.org/svn/reactos/trunk/tools/RosBE/RosBE-Windows/Root/Cha… ============================================================================== --- trunk/tools/RosBE/RosBE-Windows/Root/ChangeLog.txt (original) +++ trunk/tools/RosBE/RosBE-Windows/Root/ChangeLog.txt Wed Feb 6 11:37:56 2008 @@ -1,3 +1,7 @@ +*** XXX xxrd, 2008 - RosBE 1.3 Released + +- Added: Tool to set the Architecture to build ROS for. (Daniel Reimer) + *** January 23rd, 2008 - RosBE 1.2 Released - Updated: NASM to 2.01 (Peter Ward) Modified: trunk/tools/RosBE/RosBE-Windows/Root/Help.cmd URL: http://svn.reactos.org/svn/reactos/trunk/tools/RosBE/RosBE-Windows/Root/Hel… ============================================================================== --- trunk/tools/RosBE/RosBE-Windows/Root/Help.cmd (original) +++ trunk/tools/RosBE/RosBE-Windows/Root/Help.cmd Wed Feb 6 11:37:56 2008 @@ -27,6 +27,11 @@ echo with the appropriate number. echo basedir - Switch back to the ReactOS source directory. + if exist "%_ROSBE_BASEDIR%\charch.cmd" ( + echo chdefdir [OPTIONS] - Change the Architecture to build for for the + echo current RosBE session. + ) + if exist "%_ROSBE_BASEDIR%\chdefdir.cmd" ( echo chdefdir [OPTIONS] - Change the ReactOS source directory for the echo current RosBE session. @@ -96,6 +101,16 @@ echo Switches back to the ReactOS source directory. goto :EOC ) +if exist "%_ROSBE_BASEDIR%\charch.cmd" ( + if /i "%1" == "charch" ( + echo Usage: charch [OPTIONS] + echo Change the ReactOS source directory for the current RosBE session. + echo Possible Architectures are: x86, ppc, arm. + echo. + echo previous - Switch to the previous ReactOS source directory. + goto :EOC + ) +) if exist "%_ROSBE_BASEDIR%\chdefdir.cmd" ( if /i "%1" == "chdefdir" ( echo Usage: chdefdir [OPTIONS] Modified: trunk/tools/RosBE/RosBE-Windows/Root/RosBE.cmd URL: http://svn.reactos.org/svn/reactos/trunk/tools/RosBE/RosBE-Windows/Root/Ros… ============================================================================== --- trunk/tools/RosBE/RosBE-Windows/Root/RosBE.cmd (original) +++ trunk/tools/RosBE/RosBE-Windows/Root/RosBE.cmd Wed Feb 6 11:37:56 2008 @@ -138,6 +138,7 @@ if not exist "%_ROSBE_BASEDIR%\chdefdir.cmd" ( doskey CHDEFDIR= ) if not exist "%_ROSBE_BASEDIR%\chdefgcc.cmd" ( doskey CHDEFGCC= ) + if not exist "%_ROSBE_BASEDIR%\charch.cmd" ( doskey CHARCH= ) if not exist "%_ROSBE_BASEDIR%\Config.cmd" ( doskey CONFIG= ) if not exist "%_ROSBE_BASEDIR%\reladdr2line.cmd" ( doskey RADDR2LINE= ) if not exist "%_ROSBE_BASEDIR%\scut.cmd" ( doskey SCUT= ) Modified: trunk/tools/RosBE/RosBE-Windows/Root/RosBE.mac URL: http://svn.reactos.org/svn/reactos/trunk/tools/RosBE/RosBE-Windows/Root/Ros… ============================================================================== --- trunk/tools/RosBE/RosBE-Windows/Root/RosBE.mac (original) +++ trunk/tools/RosBE/RosBE-Windows/Root/RosBE.mac Wed Feb 6 11:37:56 2008 @@ -1,6 +1,7 @@ BASEDIR = cd /d "%_ROSBE_ROSSOURCEDIR%" CHDEFDIR = "%_ROSBE_BASEDIR%\chdefdir.cmd" $* CHDEFGCC = "%_ROSBE_BASEDIR%\chdefgcc.cmd" $* +CHARCH = "%_ROSBE_BASEDIR%\charch.cmd" $* CLEAN = "%_ROSBE_BASEDIR%\Clean.cmd" $* CONFIG = "%_ROSBE_BASEDIR%\Config.cmd" $* ENV = set Added: trunk/tools/RosBE/RosBE-Windows/Root/charch.cmd URL: http://svn.reactos.org/svn/reactos/trunk/tools/RosBE/RosBE-Windows/Root/cha… ============================================================================== --- trunk/tools/RosBE/RosBE-Windows/Root/charch.cmd (added) +++ trunk/tools/RosBE/RosBE-Windows/Root/charch.cmd Wed Feb 6 11:37:56 2008 @@ -1,0 +1,83 @@ +:: +:: PROJECT: RosBE - ReactOS Build Environment for Windows +:: LICENSE: GNU General Public License v2. (see LICENSE.txt) +:: FILE: Root/charch.cmd +:: PURPOSE: Tool to change the current Arch to build ROS for in RosBE. +:: COPYRIGHT: Copyright 2008 Daniel Reimer <reimer.daniel(a)freenet.de> +:: +@echo off +if not defined _ROSBE_DEBUG set _ROSBE_DEBUG=0 +if %_ROSBE_DEBUG% == 1 ( + @echo on +) + +title Change the Architecture to build for... + +:: +:: Parse the command line arguments. +:: +if "%1" == "" ( + call :INTERACTIVE +) else ( + set _1=%1 +) +if /i "%_1%" == "previous" ( + popd +) +if /i "%_1%" == "x86" ( + set _ROSBE_ARCH%=x86 + set _ROSBE_PREFIX=mingw32 + goto :EOC +) +if /i "%_1%" == "arm" ( + set _ROSBE_ARCH%=arm + set _ROSBE_PREFIX=mingwarm + goto :EOC +) +if /i "%_1%" == "ppc" ( + set _ROSBE_ARCH%=ppc + set _ROSBE_PREFIX=mingwppc + goto :EOC +) +if not "%_1%" == "" ( + echo Unknown parameter specified. Try 'help [COMMAND]'. + goto :EOC +) +goto :EOC + +:: +:: If Parameters were set, parse them, if not, ask the user to add them. +:: +:INTERACTIVE + set /p _1="Please enter a Architecture you want to build ReactOS for: " + if "%_1%" == "" ( + echo ERROR: You must enter a Architecture. + goto :EOC + ) +goto :EOF + +:EOC +pushd %_1% + +:: +:: Set to x86, ppc or arm. +:: +set ROS_ARCH=%_ROSBE_ARCH% + +:: +:: Default is mingw32. ppc could be mingwppc, arm mingwarm. +:: +set ROS_PREFIX=%_ROSBE_PREFIX% + +REM chdefgcc %PATH% +REM Maybe another way to set the compiler... + +if defined _ROSBE_VERSION ( + title ReactOS Build Environment %_ROSBE_VERSION% +) + +:: +:: Unload all used Vars. +:: +set _ROSBE_ARCH= +set _ROSBE_PREFIX= Propchange: trunk/tools/RosBE/RosBE-Windows/Root/charch.cmd ------------------------------------------------------------------------------ svn:eol-style = native

1 0

[ros-arm-bringup] 32151: We implemented console support (through serial port), for the current board types supported (Feroceon, using UART 16550). We added a new ClockRate member to the ARM Board Block structure. We now print out the FreeLDR header after initialization to give some output to the user that we are alive. Started putting shared stuff in headers. Fixed copy/paste leftovers from file headers (wrong file names, implementation details, author).
by ros-arm-bringup＠svn.reactos.org 06 Feb '08

06 Feb '08

Author: ros-arm-bringup Date: Wed Feb 6 10:32:47 2008 New Revision: 32151 URL: http://svn.reactos.org/svn/reactos?rev=32151&view=rev Log: We implemented console support (through serial port), for the current board types supported (Feroceon, using UART 16550). We added a new ClockRate member to the ARM Board Block structure. We now print out the FreeLDR header after initialization to give some output to the user that we are alive. Started putting shared stuff in headers. Fixed copy/paste leftovers from file headers (wrong file names, implementation details, author). Added: trunk/reactos/boot/freeldr/freeldr/arch/arm/ferouart.c (with props) Modified: trunk/reactos/boot/freeldr/freeldr/arch/arm/boot.s trunk/reactos/boot/freeldr/freeldr/arch/arm/macharm.c trunk/reactos/boot/freeldr/freeldr/arch/arm/stubs.c trunk/reactos/boot/freeldr/freeldr/disk/ramdisk.c trunk/reactos/boot/freeldr/freeldr/freeldr_arch.rbuild trunk/reactos/boot/freeldr/freeldr/include/arch/arm/hardware.h trunk/reactos/boot/freeldr/freeldr/include/ramdisk.h Modified: trunk/reactos/boot/freeldr/freeldr/arch/arm/boot.s URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/arch/… ============================================================================== --- trunk/reactos/boot/freeldr/freeldr/arch/arm/boot.s (original) +++ trunk/reactos/boot/freeldr/freeldr/arch/arm/boot.s Wed Feb 6 10:32:47 2008 @@ -3,7 +3,7 @@ * LICENSE: GPL - See COPYING in the top level directory * FILE: boot/freeldr/arch/arm/boot.s * PURPOSE: Implements the entry point for ARM machines - * PROGRAMMERS: alex(a)winsiderss.com + * PROGRAMMERS: ReactOS Portable Systems Group */ /* INCLUDES *******************************************************************/ Added: trunk/reactos/boot/freeldr/freeldr/arch/arm/ferouart.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/arch/… ============================================================================== --- trunk/reactos/boot/freeldr/freeldr/arch/arm/ferouart.c (added) +++ trunk/reactos/boot/freeldr/freeldr/arch/arm/ferouart.c Wed Feb 6 10:32:47 2008 @@ -1,0 +1,130 @@ +/* + * PROJECT: ReactOS Boot Loader + * LICENSE: GPL - See COPYING in the top level directory + * FILE: boot/freeldr/arch/arm/ferouart.c + * PURPOSE: Implements code for Feroceon boards using the 16550 UART + * PROGRAMMERS: ReactOS Portable Systems Group + */ + +/* INCLUDES *******************************************************************/ + +#include <freeldr.h> + +/* GLOBALS ********************************************************************/ + +// +// UART Registers +// +#define UART0_RBR (ArmBoardBlock->UartRegisterBase + 0x00) +#define UART0_THR UART0_RBR +#define UART0_IER (ArmBoardBlock->UartRegisterBase + 0x04) +#define UART0_FCR (ArmBoardBlock->UartRegisterBase + 0x08) +#define UART0_LCR (ArmBoardBlock->UartRegisterBase + 0x0C) +#define UART0_MCR (ArmBoardBlock->UartRegisterBase + 0x10) +#define UART0_LSR (ArmBoardBlock->UartRegisterBase + 0x14) +#define UART0_MSR (ArmBoardBlock->UartRegisterBase + 0x18) +#define UART0_SCR (ArmBoardBlock->UartRegisterBase + 0x1C) + +// +// When we enable the divisor latch +// +#define UART0_DLL UART0_RBR +#define UART0_DLM UART0_IER + +// +// FCR Values +// +#define FCR_FIFO_EN 0x01 +#define FCR_RXSR 0x02 +#define FCR_TXSR 0x04 + +// +// LCR Values +// +#define LCR_WLS_8 0x03 +#define LCR_1_STB 0x00 +#define LCR_DIVL_EN 0x80 +#define LCR_NO_PAR 0x00 + +// +// LSR Values +// +#define LSR_DR 0x01 +#define LSR_THRE 0x20 + +/* FUNCTIONS ******************************************************************/ + +VOID +ArmFeroSerialInit(IN ULONG Baudrate) +{ + ULONG BaudClock; + + // + // Calculate baudrate clock divider to set the baud rate + // + BaudClock = (ArmBoardBlock->ClockRate / 16) / Baudrate; + + // + // Disable interrupts + // + WRITE_REGISTER_UCHAR(UART0_IER, 0); + + // + // Set the baud rate to 115200 bps + // + WRITE_REGISTER_UCHAR(UART0_LCR, LCR_DIVL_EN); + WRITE_REGISTER_UCHAR(UART0_DLL, BaudClock); + WRITE_REGISTER_UCHAR(UART0_DLM, (BaudClock >> 8) & 0xFF); + + // + // Set 8 bits for data, 1 stop bit, no parity + // + WRITE_REGISTER_UCHAR(UART0_LCR, LCR_WLS_8 | LCR_1_STB | LCR_NO_PAR); + + // + // Clear and enable FIFO + // + WRITE_REGISTER_UCHAR(UART0_FCR, FCR_FIFO_EN | FCR_RXSR | FCR_TXSR); +} + +VOID +ArmFeroPutChar(IN INT Char) +{ + // + // Properly support new-lines + // + if (Char == '\n') ArmFeroPutChar('\r'); + + // + // Wait for ready + // + while ((READ_REGISTER_UCHAR(UART0_LSR) & LSR_THRE) == 0); + + // + // Send the character + // + WRITE_REGISTER_UCHAR(UART0_THR, Char); +} + +INT +ArmFeroGetCh(VOID) +{ + // + // Wait for ready + // + while ((READ_REGISTER_UCHAR(UART0_LSR) & LSR_DR) == 0); + + // + // Read the character + // + return READ_REGISTER_UCHAR(UART0_RBR); +} + +BOOLEAN +ArmFeroKbHit(VOID) +{ + // + // Return if something is ready + // + return ((READ_REGISTER_UCHAR(UART0_LSR) & LSR_DR) != 0); +} Propchange: trunk/reactos/boot/freeldr/freeldr/arch/arm/ferouart.c ------------------------------------------------------------------------------ svn:eol-style = native Propchange: trunk/reactos/boot/freeldr/freeldr/arch/arm/ferouart.c ------------------------------------------------------------------------------ svn:mime-type = text/plain Modified: trunk/reactos/boot/freeldr/freeldr/arch/arm/macharm.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/arch/… ============================================================================== --- trunk/reactos/boot/freeldr/freeldr/arch/arm/macharm.c (original) +++ trunk/reactos/boot/freeldr/freeldr/arch/arm/macharm.c Wed Feb 6 10:32:47 2008 @@ -2,8 +2,8 @@ * PROJECT: ReactOS Boot Loader * LICENSE: GPL - See COPYING in the top level directory * FILE: boot/freeldr/arch/arm/marcharm.c - * PURPOSE: Implements ARM-specific machine initialization - * PROGRAMMERS: alex(a)winsiderss.com + * PURPOSE: Provides abstraction between the ARM Boot Loader and FreeLDR + * PROGRAMMERS: ReactOS Portable Systems Group */ /* INCLUDES *******************************************************************/ @@ -12,37 +12,9 @@ /* GLOBALS ********************************************************************/ -// -// The only things we support -// -typedef enum _ARM_BOARD_TYPE -{ - // - // Marvell Feroceon-based SoC: - // Buffalo Linkstation, KuroBox Pro, D-Link DS323 and others - // - ARM_FEROCEON = 1, -} ARM_BOARD_TYPE; - -// -// Compatible boot-loaders should return us this information -// -#define ARM_BOARD_CONFIGURATION_MAJOR_VERSION 1 -#define ARM_BOARD_CONFIGURATION_MINOR_VERSION 1 -typedef struct _ARM_BOARD_CONFIGURATION_BLOCK -{ - ULONG MajorVersion; - ULONG MinorVersion; - ARM_BOARD_TYPE BoardType; - ULONG TimerRegisterBase; - ULONG UartRegisterBase; - PBIOS_MEMORY_MAP MemoryMap; - CHAR CommandLine[256]; -} ARM_BOARD_CONFIGURATION_BLOCK, *PARM_BOARD_CONFIGURATION_BLOCK; +PARM_BOARD_CONFIGURATION_BLOCK ArmBoardBlock; /* FUNCTIONS ******************************************************************/ - -PARM_BOARD_CONFIGURATION_BLOCK ArmBoardBlock; VOID ArmInit(IN PARM_BOARD_CONFIGURATION_BLOCK BootContext) Modified: trunk/reactos/boot/freeldr/freeldr/arch/arm/stubs.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/arch/… ============================================================================== --- trunk/reactos/boot/freeldr/freeldr/arch/arm/stubs.c (original) +++ trunk/reactos/boot/freeldr/freeldr/arch/arm/stubs.c Wed Feb 6 10:32:47 2008 @@ -3,7 +3,7 @@ * LICENSE: GPL - See COPYING in the top level directory * FILE: boot/freeldr/arch/arm/stubs.c * PURPOSE: Non-completed ARM hardware-specific routines - * PROGRAMMERS: alex(a)winsiderss.com + * PROGRAMMERS: ReactOS Portable Systems Group */ /* INCLUDES *******************************************************************/ @@ -22,26 +22,6 @@ // // Start the OS // -} - -VOID -ArmConsPutChar(INT Char) -{ - while (TRUE); -} - -BOOLEAN -ArmConsKbHit(VOID) -{ - while (TRUE); - return FALSE; -} - -INT -ArmConsGetCh(VOID) -{ - while (TRUE); - return FALSE; } BOOLEAN @@ -155,11 +135,31 @@ MachInit(IN PCCH CommandLine) { // - // Setup ARM routines + // Setup board-specific ARM routines // - MachVtbl.ConsPutChar = ArmConsPutChar; - MachVtbl.ConsKbHit = ArmConsKbHit; - MachVtbl.ConsGetCh = ArmConsGetCh; + switch (ArmBoardBlock->BoardType) + { + // + // Check for Feroceon-base boards + // + case ARM_FEROCEON: + + // + // These boards use a UART16550. Set us up for 115200 bps + // + ArmFeroSerialInit(115200); + MachVtbl.ConsPutChar = ArmFeroPutChar; + MachVtbl.ConsKbHit = ArmFeroKbHit; + MachVtbl.ConsGetCh = ArmFeroGetCh; + break; + + default: + ASSERT(FALSE); + } + + // + // Setup generic ARM routines + // MachVtbl.PrepareForReactOS = ArmPrepareForReactOS; MachVtbl.GetMemoryMap = ArmMemGetMemoryMap; MachVtbl.DiskGetBootVolume = ArmDiskGetBootVolume; @@ -173,4 +173,9 @@ MachVtbl.DiskGetDriveGeometry = ArmDiskGetDriveGeometry; MachVtbl.DiskGetCacheableBlockCount = ArmDiskGetCacheableBlockCount; MachVtbl.HwDetect = ArmHwDetect; + + // + // We can now print to the console + // + TuiPrintf("%s for ARM\n", GetFreeLoaderVersionString()); } Modified: trunk/reactos/boot/freeldr/freeldr/disk/ramdisk.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/disk/… ============================================================================== --- trunk/reactos/boot/freeldr/freeldr/disk/ramdisk.c (original) +++ trunk/reactos/boot/freeldr/freeldr/disk/ramdisk.c Wed Feb 6 10:32:47 2008 @@ -3,7 +3,7 @@ * LICENSE: GPL - See COPYING in the top level directory * FILE: boot/freeldr/arch/i386/ramdisk.c * PURPOSE: Implements routines to support booting from a RAM Disk - * PROGRAMMERS: alex(a)winsiderss.com + * PROGRAMMERS: ReactOS Portable Systems Group */ /* INCLUDES *******************************************************************/ Modified: trunk/reactos/boot/freeldr/freeldr/freeldr_arch.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/freel… ============================================================================== --- trunk/reactos/boot/freeldr/freeldr/freeldr_arch.rbuild (original) +++ trunk/reactos/boot/freeldr/freeldr/freeldr_arch.rbuild Wed Feb 6 10:32:47 2008 @@ -101,6 +101,7 @@ <define name="DEBUG" /> <define name="_NTHAL_" /> <file>boot.s</file> + <file>ferouart.c</file> <file>macharm.c</file> <file>stubs.c</file> </module> Modified: trunk/reactos/boot/freeldr/freeldr/include/arch/arm/hardware.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/inclu… ============================================================================== --- trunk/reactos/boot/freeldr/freeldr/include/arch/arm/hardware.h (original) +++ trunk/reactos/boot/freeldr/freeldr/include/arch/arm/hardware.h Wed Feb 6 10:32:47 2008 @@ -2,8 +2,8 @@ * PROJECT: ReactOS Boot Loader * LICENSE: GPL - See COPYING in the top level directory * FILE: boot/freeldr/include/arch/arm/hardware.h - * PURPOSE: Implements routines to support booting from a RAM Disk - * PROGRAMMERS: alex(a)winsiderss.com + * PURPOSE: Header for ARC definitions (to be cleaned up) + * PROGRAMMERS: ReactOS Portable Systems Group */ #ifndef _ARM_HARDWARE_ @@ -12,6 +12,35 @@ #ifndef __REGISTRY_H #include "../../reactos/registry.h" #endif + +// +// The only things we support +// +typedef enum _ARM_BOARD_TYPE +{ + // + // Marvell Feroceon-based SoC: + // Buffalo Linkstation, KuroBox Pro, D-Link DS323 and others + // + ARM_FEROCEON = 1, +} ARM_BOARD_TYPE; + +// +// Compatible boot-loaders should return us this information +// +#define ARM_BOARD_CONFIGURATION_MAJOR_VERSION 1 +#define ARM_BOARD_CONFIGURATION_MINOR_VERSION 1 +typedef struct _ARM_BOARD_CONFIGURATION_BLOCK +{ + ULONG MajorVersion; + ULONG MinorVersion; + ARM_BOARD_TYPE BoardType; + ULONG ClockRate; + ULONG TimerRegisterBase; + ULONG UartRegisterBase; + PBIOS_MEMORY_MAP MemoryMap; + CHAR CommandLine[256]; +} ARM_BOARD_CONFIGURATION_BLOCK, *PARM_BOARD_CONFIGURATION_BLOCK; // // Static heap for ARC Hardware Component Tree @@ -63,4 +92,18 @@ IN ULONG Size ); +VOID +ArmFeroSerialInit(IN ULONG Baudrate); + +VOID +ArmFeroPutChar(IN INT Char); + +INT +ArmFeroGetCh(VOID); + +BOOLEAN +ArmFeroKbHit(VOID); + +extern PARM_BOARD_CONFIGURATION_BLOCK ArmBoardBlock; + #endif Modified: trunk/reactos/boot/freeldr/freeldr/include/ramdisk.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/inclu… ============================================================================== --- trunk/reactos/boot/freeldr/freeldr/include/ramdisk.h (original) +++ trunk/reactos/boot/freeldr/freeldr/include/ramdisk.h Wed Feb 6 10:32:47 2008 @@ -3,7 +3,7 @@ * LICENSE: GPL - See COPYING in the top level directory * FILE: boot/freeldr/include/ramdisk.h * PURPOSE: Header file for ramdisk support - * PROGRAMMERS: alex(a)winsiderss.com + * PROGRAMMERS: ReactOS Portable Systems Group */ #ifndef _RAMDISK_

1 0

[ros-arm-bringup] 32150: We now make sure to build with the static version of libgcc. Previously, this resulted in FreeLDR having an import table and trying to import a .DLL file -- not a very wise attempt.
by ros-arm-bringup＠svn.reactos.org 06 Feb '08

06 Feb '08

Author: ros-arm-bringup Date: Wed Feb 6 10:19:13 2008 New Revision: 32150 URL: http://svn.reactos.org/svn/reactos?rev=32150&view=rev Log: We now make sure to build with the static version of libgcc. Previously, this resulted in FreeLDR having an import table and trying to import a .DLL file -- not a very wise attempt. Modified: trunk/reactos/boot/freeldr/freeldr/freeldr.rbuild Modified: trunk/reactos/boot/freeldr/freeldr/freeldr.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/freel… ============================================================================== --- trunk/reactos/boot/freeldr/freeldr/freeldr.rbuild (original) +++ trunk/reactos/boot/freeldr/freeldr/freeldr.rbuild Wed Feb 6 10:19:13 2008 @@ -13,8 +13,7 @@ <library>cmlib</library> <library>rtl</library> <library>libcntpr</library> - <linkerflag>-nostartfiles</linkerflag> - <linkerflag>-nostdlib</linkerflag> + <linkerflag>-static</linkerflag> <linkerflag>-lgcc</linkerflag> </module> </if> @@ -31,6 +30,7 @@ <library>rtl</library> <library>libcntpr</library> <linkerflag>-lgcc</linkerflag> + <linkerflag>-static</linkerflag> </module> </if> <if property="ARCH" value="powerpc">

1 0

[tkreuzer] 32149: - use intrinsic interlocked functions - add a function to get a full stackbacktrace including usermode
by tkreuzer＠svn.reactos.org 06 Feb '08

06 Feb '08

Author: tkreuzer Date: Wed Feb 6 08:09:26 2008 New Revision: 32149 URL: http://svn.reactos.org/svn/reactos?rev=32149&view=rev Log: - use intrinsic interlocked functions - add a function to get a full stackbacktrace including usermode Modified: trunk/reactos/subsystems/win32/win32k/objects/gdiobj.c Modified: trunk/reactos/subsystems/win32/win32k/objects/gdiobj.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/ob… ============================================================================== --- trunk/reactos/subsystems/win32/win32k/objects/gdiobj.c (original) +++ trunk/reactos/subsystems/win32/win32k/objects/gdiobj.c Wed Feb 6 08:09:26 2008 @@ -32,6 +32,7 @@ #ifdef GDI_DEBUG BOOLEAN STDCALL KiRosPrintAddress(PVOID Address); +NTSYSAPI ULONG NTAPI RtlWalkFrameChain(OUT PVOID *Callers, IN ULONG Count, IN ULONG Flags); #endif #define GDI_ENTRY_TO_INDEX(ht, e) \ @@ -170,7 +171,7 @@ } ShortDelay.QuadPart = -5000LL; /* FIXME - 0.5 ms? */ - + HandleTable->FirstFree = 0; HandleTable->FirstUnused = RESERVE_ENTRIES_COUNT; @@ -200,8 +201,8 @@ static int leak_reported = 0; #define GDI_STACK_LEVELS 12 -static ULONG GDIHandleAllocator[GDI_HANDLE_COUNT][GDI_STACK_LEVELS]; -static ULONG GDIHandleLocker[GDI_HANDLE_COUNT][GDI_STACK_LEVELS]; +static ULONG GDIHandleAllocator[GDI_HANDLE_COUNT][GDI_STACK_LEVELS+1]; +static ULONG GDIHandleLocker[GDI_HANDLE_COUNT][GDI_STACK_LEVELS+1]; struct DbgOpenGDIHandle { ULONG idx; @@ -287,6 +288,23 @@ if ( i < n && h[i].count == 1 ) DbgPrint ( "(list terminated - the remaining entries have 1 allocation only)\n" ); } + +ULONG +CaptureStackBackTace(PVOID* pFrames, ULONG nFramesToCapture) +{ + ULONG nFrameCount; + + memset(pFrames, 0x00, (nFramesToCapture + 1) * sizeof(PVOID)); + + nFrameCount = RtlCaptureStackBackTrace(1, nFramesToCapture, pFrames, NULL); + + if (nFrameCount < nFramesToCapture) + { + nFrameCount += RtlWalkFrameChain(pFrames + nFrameCount, nFramesToCapture - nFrameCount, 1); + } + + return nFrameCount; +} #endif /* GDI_DEBUG */ @@ -334,7 +352,7 @@ idxNextFree = (ULONG)pFreeEntry->KernelData; idxPrev = (ULONG)_InterlockedCompareExchange((LONG*)&HandleTable->FirstFree, idxNextFree, idxFirstFree); } - else + else { idxFirstFree = HandleTable->FirstUnused; idxNextFree = idxFirstFree + 1; @@ -470,7 +488,7 @@ Entry = &HandleTable->Entries[Index]; LockHandle: - PrevProcId = InterlockedCompareExchangePointer(&Entry->ProcessId, LockedProcessId, 0); + PrevProcId = _InterlockedCompareExchangePointer((PVOID*)&Entry->ProcessId, LockedProcessId, 0); if(PrevProcId == NULL) { HGDIOBJ Handle; @@ -485,16 +503,15 @@ Entry->Type = TypeInfo; /* unlock the entry */ - (void)InterlockedExchangePointer(&Entry->ProcessId, CurrentProcessId); - -#ifdef GDI_DEBUG - memset ( GDIHandleAllocator[Index], 0x00, GDI_STACK_LEVELS * sizeof(ULONG) ); - RtlCaptureStackBackTrace(1, GDI_STACK_LEVELS, (PVOID*)GDIHandleAllocator[Index], NULL); + (void)_InterlockedExchangePointer((PVOID*)&Entry->ProcessId, CurrentProcessId); + +#ifdef GDI_DEBUG + CaptureStackBackTace((PVOID*)GDIHandleAllocator[Index], GDI_STACK_LEVELS); #endif /* GDI_DEBUG */ if(W32Process != NULL) { - InterlockedIncrement(&W32Process->GDIObjects); + _InterlockedIncrement(&W32Process->GDIObjects); } Handle = (HGDIOBJ)((Index & 0xFFFF) | (TypeInfo << GDI_ENTRY_UPPER_SHIFT)); @@ -586,8 +603,12 @@ HandleType != ExpectedType) || HandleType == 0 ) { - DPRINT1("Attempted to free object 0x%x of wrong type (Handle: 0x%x, expected: 0x%x)\n", - hObj, HandleType, ExpectedType); + DPRINT1("Attempted to free object 0x%x of wrong type (Handle: 0x%x, expected: 0x%x)\n", + hObj, HandleType, ExpectedType); +#ifdef GDI_DEBUG + DPRINT1("-> called from:\n"); + KeRosDumpStackFrames(NULL, 20); +#endif return FALSE; } @@ -596,7 +617,7 @@ LockHandle: /* lock the object, we must not delete global objects, so don't exchange the locking process ID to zero when attempting to lock a global object... */ - PrevProcId = InterlockedCompareExchangePointer(&Entry->ProcessId, LockedProcessId, ProcessId); + PrevProcId = _InterlockedCompareExchangePointer((PVOID*)&Entry->ProcessId, LockedProcessId, ProcessId); if(PrevProcId == ProcessId) { if( (Entry->KernelData != NULL) && @@ -616,14 +637,14 @@ Entry->Type = (Entry->Type + GDI_ENTRY_REUSE_INC) & ~GDI_ENTRY_BASETYPE_MASK; /* unlock the handle slot */ - (void)InterlockedExchangePointer(&Entry->ProcessId, NULL); + (void)_InterlockedExchangePointer((PVOID*)&Entry->ProcessId, NULL); /* push this entry to the free list */ InterlockedPushFreeEntry(HandleTable, GDI_ENTRY_TO_INDEX(HandleTable, Entry)); if(W32Process != NULL) { - InterlockedDecrement(&W32Process->GDIObjects); + _InterlockedDecrement(&W32Process->GDIObjects); } /* call the cleanup routine. */ @@ -662,7 +683,7 @@ else { LockErrorDebugOutput(hObj, Entry, "GDIOBJ_FreeObj"); - (void)InterlockedExchangePointer(&Entry->ProcessId, PrevProcId); + (void)_InterlockedExchangePointer((PVOID*)&Entry->ProcessId, PrevProcId); } } else if(PrevProcId == LockedProcessId) @@ -883,7 +904,7 @@ { /* Lock the handle table entry. */ LockedProcessId = (HANDLE)((ULONG_PTR)HandleProcessId | 0x1); - PrevProcId = InterlockedCompareExchangePointer(&Entry->ProcessId, + PrevProcId = _InterlockedCompareExchangePointer((PVOID*)&Entry->ProcessId, LockedProcessId, HandleProcessId); @@ -905,20 +926,19 @@ GdiHdr->LockingThread = Thread; GdiHdr->Locks = 1; #ifdef GDI_DEBUG - memset(GDIHandleLocker[GDI_HANDLE_GET_INDEX(hObj)], 0x00, GDI_STACK_LEVELS * sizeof(ULONG)); - RtlCaptureStackBackTrace(1, GDI_STACK_LEVELS, (PVOID*)GDIHandleLocker[GDI_HANDLE_GET_INDEX(hObj)], NULL); + CaptureStackBackTace((PVOID*)GDIHandleLocker[GDI_HANDLE_GET_INDEX(hObj)], GDI_STACK_LEVELS); #endif Object = Entry->KernelData; } else { - InterlockedIncrement((PLONG)&GdiHdr->Locks); + _InterlockedIncrement((PLONG)&GdiHdr->Locks); if (GdiHdr->LockingThread != Thread) { - InterlockedDecrement((PLONG)&GdiHdr->Locks); + _InterlockedDecrement((PLONG)&GdiHdr->Locks); /* Unlock the handle table entry. */ - (void)InterlockedExchangePointer(&Entry->ProcessId, PrevProcId); + (void)_InterlockedExchangePointer((PVOID*)&Entry->ProcessId, PrevProcId); DelayExecution(); continue; @@ -941,7 +961,7 @@ } /* Unlock the handle table entry. */ - (void)InterlockedExchangePointer(&Entry->ProcessId, PrevProcId); + (void)_InterlockedExchangePointer((PVOID*)&Entry->ProcessId, PrevProcId); break; } @@ -1028,7 +1048,7 @@ { /* Lock the handle table entry. */ LockedProcessId = (HANDLE)((ULONG_PTR)HandleProcessId | 0x1); - PrevProcId = InterlockedCompareExchangePointer(&Entry->ProcessId, + PrevProcId = _InterlockedCompareExchangePointer((PVOID*)&Entry->ProcessId, LockedProcessId, HandleProcessId); @@ -1045,13 +1065,13 @@ PGDIOBJHDR GdiHdr = GDIBdyToHdr(Entry->KernelData); #ifdef GDI_DEBUG - if (InterlockedIncrement((PLONG)&GdiHdr->Locks) == 1) + if (_InterlockedIncrement((PLONG)&GdiHdr->Locks) == 1) { memset(GDIHandleLocker[HandleIndex], 0x00, GDI_STACK_LEVELS * sizeof(ULONG)); RtlCaptureStackBackTrace(1, GDI_STACK_LEVELS, (PVOID*)GDIHandleLocker[HandleIndex], NULL); } #else - InterlockedIncrement((PLONG)&GdiHdr->Locks); + _InterlockedIncrement((PLONG)&GdiHdr->Locks); #endif Object = Entry->KernelData; } @@ -1070,7 +1090,7 @@ } /* Unlock the handle table entry. */ - (void)InterlockedExchangePointer(&Entry->ProcessId, PrevProcId); + (void)_InterlockedExchangePointer((PVOID*)&Entry->ProcessId, PrevProcId); break; } @@ -1102,13 +1122,13 @@ { PGDIOBJHDR GdiHdr = GDIBdyToHdr(Object); #ifdef GDI_DEBUG - if (InterlockedDecrement((PLONG)&GdiHdr->Locks) == 0) + if (_InterlockedDecrement((PLONG)&GdiHdr->Locks) == 0) { memset(GDIHandleLocker[GDI_HANDLE_GET_INDEX(Object)], 0x00, GDI_STACK_LEVELS * sizeof(ULONG)); RtlCaptureStackBackTrace(1, GDI_STACK_LEVELS, (PVOID*)GDIHandleLocker[GDI_HANDLE_GET_INDEX(Object)], NULL); } #else - if (InterlockedDecrement((PLONG)&GdiHdr->Locks) < 0) + if (_InterlockedDecrement((PLONG)&GdiHdr->Locks) < 0) DPRINT1("Trying to unlock non-existant object\n"); #endif } @@ -1168,7 +1188,7 @@ LockHandle: /* lock the object, we must not convert stock objects, so don't check!!! */ - PrevProcId = InterlockedCompareExchangePointer(&Entry->ProcessId, LockedProcessId, ProcessId); + PrevProcId = _InterlockedCompareExchangePointer((PVOID*)&Entry->ProcessId, LockedProcessId, ProcessId); if(PrevProcId == ProcessId) { LONG NewType, PrevType, OldType; @@ -1188,7 +1208,7 @@ NewType = OldType | GDI_ENTRY_STOCK_MASK; /* Try to exchange the type field - but only if the old (previous type) matches! */ - PrevType = InterlockedCompareExchange(&Entry->Type, NewType, OldType); + PrevType = _InterlockedCompareExchange(&Entry->Type, NewType, OldType); if(PrevType == OldType && Entry->KernelData != NULL) { PETHREAD PrevThread; @@ -1217,14 +1237,14 @@ W32Process = (PW32PROCESS)OldProcess->Win32Process; if(W32Process != NULL) { - InterlockedDecrement(&W32Process->GDIObjects); + _InterlockedDecrement(&W32Process->GDIObjects); } ObDereferenceObject(OldProcess); } } /* remove the process id lock and make it global */ - (void)InterlockedExchangePointer(&Entry->ProcessId, GDI_GLOBAL_PROCESS); + (void)_InterlockedExchangePointer((PVOID*)&Entry->ProcessId, GDI_GLOBAL_PROCESS); hObj = (HGDIOBJ)((ULONG)(hObj) | GDI_HANDLE_STOCK_MASK); *phObj = hObj; @@ -1246,7 +1266,7 @@ /* WTF?! The object is already locked by a different thread! Release the lock, wait a bit and try again! FIXME - we should give up after some time unless we want to wait forever! */ - (void)InterlockedExchangePointer(&Entry->ProcessId, PrevProcId); + (void)_InterlockedExchangePointer((PVOID*)&Entry->ProcessId, PrevProcId); DelayExecution(); goto LockHandle; @@ -1304,7 +1324,7 @@ LockHandle: /* lock the object, we must not convert stock objects, so don't check!!! */ - PrevProcId = InterlockedCompareExchangePointer(&Entry->ProcessId, ProcessId, LockedProcessId); + PrevProcId = _InterlockedCompareExchangePointer((PVOID*)&Entry->ProcessId, ProcessId, LockedProcessId); if(PrevProcId == ProcessId) { PETHREAD PrevThread; @@ -1330,7 +1350,7 @@ W32Process = (PW32PROCESS)OldProcess->Win32Process; if(W32Process != NULL) { - InterlockedDecrement(&W32Process->GDIObjects); + _InterlockedDecrement(&W32Process->GDIObjects); } ObDereferenceObject(OldProcess); } @@ -1344,14 +1364,14 @@ W32Process = (PW32PROCESS)NewOwner->Win32Process; if(W32Process != NULL) { - InterlockedIncrement(&W32Process->GDIObjects); + _InterlockedIncrement(&W32Process->GDIObjects); } } else ProcessId = 0; /* remove the process id lock and change it to the new process id */ - (void)InterlockedExchangePointer(&Entry->ProcessId, ProcessId); + (void)_InterlockedExchangePointer((PVOID*)&Entry->ProcessId, ProcessId); /* we're done! */ return; @@ -1370,7 +1390,7 @@ being deleted in the meantime (because we don't have aquired a reference at this point). FIXME - we should give up after some time unless we want to wait forever! */ - (void)InterlockedExchangePointer(&Entry->ProcessId, PrevProcId); + (void)_InterlockedExchangePointer((PVOID*)&Entry->ProcessId, PrevProcId); DelayExecution(); goto LockHandle; @@ -1437,7 +1457,7 @@ LockHandleFrom: /* lock the object, we must not convert stock objects, so don't check!!! */ - FromPrevProcId = InterlockedCompareExchangePointer(&FromEntry->ProcessId, FromProcessId, FromLockedProcessId); + FromPrevProcId = _InterlockedCompareExchangePointer((PVOID*)&FromEntry->ProcessId, FromProcessId, FromLockedProcessId); if(FromPrevProcId == FromProcessId) { PETHREAD PrevThread; @@ -1470,7 +1490,7 @@ GDIOBJ_SetOwnership(HandleTable, CopyTo, NULL); } - (void)InterlockedExchangePointer(&FromEntry->ProcessId, FromPrevProcId); + (void)_InterlockedExchangePointer((PVOID*)&FromEntry->ProcessId, FromPrevProcId); } else { @@ -1486,7 +1506,7 @@ being deleted in the meantime (because we don't have aquired a reference at this point). FIXME - we should give up after some time unless we want to wait forever! */ - (void)InterlockedExchangePointer(&FromEntry->ProcessId, FromPrevProcId); + (void)_InterlockedExchangePointer((PVOID*)&FromEntry->ProcessId, FromPrevProcId); DelayExecution(); goto LockHandleFrom;

1 0

[ros-arm-bringup] 32148: Implement a proper ARM startup routine. We disable the FIQ and IRQ lines, then disable and flush D and I caches, set up a temporary boot stack, and call ArmInit. In ArmInit we define the structure that a compatible bootloader has to send us and currently make some assertions on it, before dropping into the common, portable, freeldr startup (BootMain). This would be the place where we would want to setup UART0 for serial support later on, as well as TIMER0. In MachInit, w
by ros-arm-bringup＠svn.reactos.org 06 Feb '08

06 Feb '08

Author: ros-arm-bringup Date: Wed Feb 6 07:48:22 2008 New Revision: 32148 URL: http://svn.reactos.org/svn/reactos?rev=32148&view=rev Log: Implement a proper ARM startup routine. We disable the FIQ and IRQ lines, then disable and flush D and I caches, set up a temporary boot stack, and call ArmInit. In ArmInit we define the structure that a compatible bootloader has to send us and currently make some assertions on it, before dropping into the common, portable, freeldr startup (BootMain). This would be the place where we would want to setup UART0 for serial support later on, as well as TIMER0. In MachInit, we now define the required ARM routines we'll need, all which simply loop for now. Also fix a bug in RamDiskInit, which could do reads from NULL pointers. Modified: trunk/reactos/boot/freeldr/freeldr/arch/arm/boot.s trunk/reactos/boot/freeldr/freeldr/arch/arm/macharm.c trunk/reactos/boot/freeldr/freeldr/arch/arm/stubs.c trunk/reactos/boot/freeldr/freeldr/disk/ramdisk.c Modified: trunk/reactos/boot/freeldr/freeldr/arch/arm/boot.s URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/arch/… ============================================================================== --- trunk/reactos/boot/freeldr/freeldr/arch/arm/boot.s (original) +++ trunk/reactos/boot/freeldr/freeldr/arch/arm/boot.s Wed Feb 6 07:48:22 2008 @@ -10,12 +10,70 @@ //#include <kxarm.h> +#define CPSR_IRQ_DISABLE 0x80 +#define CPSR_FIQ_DISABLE 0x40 +#define CPSR_THUMB_ENABLE 0x20 + +#define C1_MMU_CONTROL 0x01 +#define C1_ALIGNMENT_CONTROL 0x02 +#define C1_DCACHE_CONTROL 0x04 +#define C1_ICACHE_CONTROL 0x1000 +#define C1_VECTOR_CONTROL 0x2000 + /* GLOBALS ********************************************************************/ .global _start .section startup + +/* BOOT CODE ******************************************************************/ + +_start: + // + // C entrypoint + // + ldr lr, L_ArmInit + + // + // Turn off FIQs and IRQs + // FreeLDR runs without interrupts, and without paging, just like on x86 + // + mrs r1, cpsr + orr r1, r1, #CPSR_IRQ_DISABLE | CPSR_FIQ_DISABLE + msr cpsr, r1 -/* BOOT CODE ******************************************************************/ + // + // Turn off caches + // + mrc p15, 0, r1, c1, c0, 0 + bic r1, r1, #C1_DCACHE_CONTROL + bic r1, r1, #C1_ICACHE_CONTROL + mcr p15, 0, r1, c1, c0, 0 + + // + // Flush everything away + // + mov r1, #0 + mcr p15, 0, r1, c7, c7, 0 + + // + // Okay, now give us a stack + // + ldr sp, L_BootStackEnd -_start: - b . + // + // Go ahead and call the C initialization code + // r0 contains the ARM_BOARD_CONFIGURATION_DATA structure + // + bx lr + +L_BootStackEnd: + .long BootStackEnd + +L_ArmInit: + .long ArmInit + + .align 4 +BootStack: + .space 0x4000 +BootStackEnd: + .long 0 Modified: trunk/reactos/boot/freeldr/freeldr/arch/arm/macharm.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/arch/… ============================================================================== --- trunk/reactos/boot/freeldr/freeldr/arch/arm/macharm.c (original) +++ trunk/reactos/boot/freeldr/freeldr/arch/arm/macharm.c Wed Feb 6 07:48:22 2008 @@ -12,12 +12,60 @@ /* GLOBALS ********************************************************************/ +// +// The only things we support +// +typedef enum _ARM_BOARD_TYPE +{ + // + // Marvell Feroceon-based SoC: + // Buffalo Linkstation, KuroBox Pro, D-Link DS323 and others + // + ARM_FEROCEON = 1, +} ARM_BOARD_TYPE; + +// +// Compatible boot-loaders should return us this information +// +#define ARM_BOARD_CONFIGURATION_MAJOR_VERSION 1 +#define ARM_BOARD_CONFIGURATION_MINOR_VERSION 1 +typedef struct _ARM_BOARD_CONFIGURATION_BLOCK +{ + ULONG MajorVersion; + ULONG MinorVersion; + ARM_BOARD_TYPE BoardType; + ULONG TimerRegisterBase; + ULONG UartRegisterBase; + PBIOS_MEMORY_MAP MemoryMap; + CHAR CommandLine[256]; +} ARM_BOARD_CONFIGURATION_BLOCK, *PARM_BOARD_CONFIGURATION_BLOCK; + /* FUNCTIONS ******************************************************************/ +PARM_BOARD_CONFIGURATION_BLOCK ArmBoardBlock; + VOID -MachInit(IN PCCH CommandLine) +ArmInit(IN PARM_BOARD_CONFIGURATION_BLOCK BootContext) { // - // Setup ARM routines + // Remember the pointer // + ArmBoardBlock = BootContext; + + // + // Let's make sure we understand the boot-loader + // + ASSERT(ArmBoardBlock->MajorVersion == ARM_BOARD_CONFIGURATION_MAJOR_VERSION); + ASSERT(ArmBoardBlock->MinorVersion == ARM_BOARD_CONFIGURATION_MINOR_VERSION); + + // + // This should probably go away once we support more boards + // + ASSERT(ArmBoardBlock->BoardType == ARM_FEROCEON); + + // + // Call FreeLDR's portable entrypoint with our command-line + // + BootMain(ArmBoardBlock->CommandLine); } + Modified: trunk/reactos/boot/freeldr/freeldr/arch/arm/stubs.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/arch/… ============================================================================== --- trunk/reactos/boot/freeldr/freeldr/arch/arm/stubs.c (original) +++ trunk/reactos/boot/freeldr/freeldr/arch/arm/stubs.c Wed Feb 6 07:48:22 2008 @@ -23,3 +23,154 @@ // Start the OS // } + +VOID +ArmConsPutChar(INT Char) +{ + while (TRUE); +} + +BOOLEAN +ArmConsKbHit(VOID) +{ + while (TRUE); + return FALSE; +} + +INT +ArmConsGetCh(VOID) +{ + while (TRUE); + return FALSE; +} + +BOOLEAN +ArmDiskGetBootVolume(IN PULONG DriveNumber, + IN PULONGLONG StartSector, + IN PULONGLONG SectorCount, + OUT PINT FsType) +{ + while (TRUE); + return FALSE; +} + +VOID +ArmDiskGetBootDevice(OUT PULONG BootDevice) +{ + while (TRUE); +} + +BOOLEAN +ArmDiskBootingFromFloppy(VOID) +{ + while (TRUE); + return FALSE; +} + +BOOLEAN +ArmDiskGetSystemVolume(IN PCHAR SystemPath, + OUT PCHAR RemainingPath, + OUT PULONG Device, + OUT PULONG DriveNumber, + OUT PULONGLONG StartSector, + OUT PULONGLONG SectorCount, + OUT PINT FsType) +{ + while (TRUE); + return FALSE; +} + +BOOLEAN +ArmDiskGetBootPath(IN PCHAR BootPath, + IN unsigned Size) +{ + while (TRUE); + return FALSE; +} + +BOOLEAN +ArmDiskNormalizeSystemPath(IN PCHAR SystemPath, + IN unsigned Size) +{ + while (TRUE); + return FALSE; +} + +BOOLEAN +ArmDiskGetDriveGeometry(IN ULONG DriveNumber, + OUT PGEOMETRY Geometry) +{ + while (TRUE); + return FALSE; +} + +BOOLEAN +ArmDiskGetPartitionEntry(IN ULONG DriveNumber, + IN ULONG PartitionNumber, + OUT PPARTITION_TABLE_ENTRY PartitionTableEntry) +{ + while (TRUE); + return FALSE; +} + +BOOLEAN +ArmDiskReadLogicalSectors(IN ULONG DriveNumber, + IN ULONGLONG SectorNumber, + IN ULONG SectorCount, + IN PVOID Buffer) +{ + while (TRUE); + return FALSE; +} + +ULONG +ArmDiskGetCacheableBlockCount(IN ULONG DriveNumber) +{ + while (TRUE); + return FALSE; +} + +VOID +ArmPrepareForReactOS(IN BOOLEAN Setup) +{ + while (TRUE); +} + +PCONFIGURATION_COMPONENT_DATA +ArmHwDetect(VOID) +{ + while (TRUE); + return NULL; +} + +ULONG +ArmMemGetMemoryMap(OUT PBIOS_MEMORY_MAP BiosMemoryMap, + IN ULONG MaxMemoryMapSize) +{ + while (TRUE); + return FALSE; +} + +VOID +MachInit(IN PCCH CommandLine) +{ + // + // Setup ARM routines + // + MachVtbl.ConsPutChar = ArmConsPutChar; + MachVtbl.ConsKbHit = ArmConsKbHit; + MachVtbl.ConsGetCh = ArmConsGetCh; + MachVtbl.PrepareForReactOS = ArmPrepareForReactOS; + MachVtbl.GetMemoryMap = ArmMemGetMemoryMap; + MachVtbl.DiskGetBootVolume = ArmDiskGetBootVolume; + MachVtbl.DiskGetSystemVolume = ArmDiskGetSystemVolume; + MachVtbl.DiskGetBootPath = ArmDiskGetBootPath; + MachVtbl.DiskGetBootDevice = ArmDiskGetBootDevice; + MachVtbl.DiskBootingFromFloppy = ArmDiskBootingFromFloppy; + MachVtbl.DiskNormalizeSystemPath = ArmDiskNormalizeSystemPath; + MachVtbl.DiskReadLogicalSectors = ArmDiskReadLogicalSectors; + MachVtbl.DiskGetPartitionEntry = ArmDiskGetPartitionEntry; + MachVtbl.DiskGetDriveGeometry = ArmDiskGetDriveGeometry; + MachVtbl.DiskGetCacheableBlockCount = ArmDiskGetCacheableBlockCount; + MachVtbl.HwDetect = ArmHwDetect; +} Modified: trunk/reactos/boot/freeldr/freeldr/disk/ramdisk.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/disk/… ============================================================================== --- trunk/reactos/boot/freeldr/freeldr/disk/ramdisk.c (original) +++ trunk/reactos/boot/freeldr/freeldr/disk/ramdisk.c Wed Feb 6 07:48:22 2008 @@ -168,9 +168,13 @@ NTAPI RamDiskInit(IN PCHAR CmdLine) { + PCHAR Setting; + // // Get RAM disk parameters // - gRamDiskBase = (PVOID)atoi(strstr(CmdLine, "rdbase=")); - gRamDiskSize = atoi(strstr(CmdLine, "rdsize=")); + Setting = strstr(CmdLine, "rdbase="); + if (Setting) gRamDiskBase = (PVOID)atoi(Setting); + Setting = strstr(CmdLine, "rdsize="); + if (Setting) gRamDiskSize = atoi(Setting); }

1 0

[tkreuzer] 32147: Windows doesn't store a hbrBack, when creating a window
by tkreuzer＠svn.reactos.org 06 Feb '08

06 Feb '08

Author: tkreuzer Date: Wed Feb 6 07:01:02 2008 New Revision: 32147 URL: http://svn.reactos.org/svn/reactos?rev=32147&view=rev Log: Windows doesn't store a hbrBack, when creating a window Modified: trunk/reactos/subsystems/win32/win32k/ntuser/menu.c Modified: trunk/reactos/subsystems/win32/win32k/ntuser/menu.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/nt… ============================================================================== --- trunk/reactos/subsystems/win32/win32k/ntuser/menu.c (original) +++ trunk/reactos/subsystems/win32/win32k/ntuser/menu.c Wed Feb 6 07:01:02 2008 @@ -346,7 +346,7 @@ Menu->MenuInfo.fMask = 0; /* not used */ Menu->MenuInfo.dwStyle = 0; /* FIXME */ Menu->MenuInfo.cyMax = 0; /* default */ - Menu->MenuInfo.hbrBack = IntGetSysColorBrush(COLOR_MENU); + Menu->MenuInfo.hbrBack = NULL; /* no brush */ Menu->MenuInfo.dwContextHelpID = 0; /* default */ Menu->MenuInfo.dwMenuData = 0; /* default */ Menu->MenuInfo.Self = *Handle;

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs