Ros-diffs

ros-diffs@reactos.org

81390 discussions

[fireball] 32016: - Revert 32007 by Alex's request. Explanations in the ros-dev mailing list.
by fireball＠svn.reactos.org 26 Jan '08

26 Jan '08

Author: fireball Date: Sat Jan 26 19:50:31 2008 New Revision: 32016 URL: http://svn.reactos.org/svn/reactos?rev=32016&view=rev Log: - Revert 32007 by Alex's request. Explanations in the ros-dev mailing list. Modified: trunk/reactos/ntoskrnl/dbgk/dbgkobj.c Modified: trunk/reactos/ntoskrnl/dbgk/dbgkobj.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/dbgk/dbgkobj.c?re… ============================================================================== --- trunk/reactos/ntoskrnl/dbgk/dbgkobj.c (original) +++ trunk/reactos/ntoskrnl/dbgk/dbgkobj.c Sat Jan 26 19:50:31 2008 @@ -1065,17 +1065,6 @@ VOID NTAPI -DbgkpDelayedTerminateProcess(PVOID Arg) -{ - PWORK_QUEUE_ITEM WorkItem = (PWORK_QUEUE_ITEM)Arg; - PEPROCESS OwnerProcess = *((PEPROCESS *)&WorkItem[1]); - ExFreePool(WorkItem); - /* Terminate the process */ - PsTerminateProcess(OwnerProcess, STATUS_DEBUGGER_INACTIVE); -} - -VOID -NTAPI DbgkpCloseObject(IN PEPROCESS OwnerProcess OPTIONAL, IN PVOID ObjectBody, IN ACCESS_MASK GrantedAccess, @@ -1140,16 +1129,8 @@ /* Check if we terminate on exit */ if (DebugObject->KillProcessOnExit) { - PWORK_QUEUE_ITEM WorkItem = - ExAllocatePool - (NonPagedPool, - sizeof(WORK_QUEUE_ITEM) + sizeof(PVOID)); - ExInitializeWorkItem - (WorkItem, - DbgkpDelayedTerminateProcess, - WorkItem); - *((PEPROCESS *)&WorkItem[1]) = OwnerProcess; - ExQueueWorkItem(WorkItem, CriticalWorkQueue); + /* Terminate the process */ + PsTerminateProcess(OwnerProcess, STATUS_DEBUGGER_INACTIVE); } /* Dereference the debug object */

1 0

[cwittich] 32015: hackfix PSEH for gcc > 4.2 this will hide uninitialized variable warnings in the following code
by cwittich＠svn.reactos.org 26 Jan '08

26 Jan '08

Author: cwittich Date: Sat Jan 26 17:36:52 2008 New Revision: 32015 URL: http://svn.reactos.org/svn/reactos?rev=32015&view=rev Log: hackfix PSEH for gcc > 4.2 this will hide uninitialized variable warnings in the following code Modified: trunk/reactos/include/reactos/libs/pseh/framebased.h Modified: trunk/reactos/include/reactos/libs/pseh/framebased.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/reactos/libs/pseh/… ============================================================================== --- trunk/reactos/include/reactos/libs/pseh/framebased.h (original) +++ trunk/reactos/include/reactos/libs/pseh/framebased.h Sat Jan 26 17:36:52 2008 @@ -22,6 +22,11 @@ #ifndef KJK_PSEH_FRAMEBASED_H_ #define KJK_PSEH_FRAMEBASED_H_ + +#if ((__GNUC__ > 4) && (__GNUC_MINOR__ > 1)) +/* warning: this will hide uninitialized variable warnings in the following code */ +# pragma GCC diagnostic ignored "-Wuninitialized" +#endif #include <pseh/framebased/internal.h> #include <pseh/excpt.h>

1 0

[dreimer] 32014: Bug 3005: Italian translation update (devotip@tiscali.it)
by dreimer＠svn.reactos.org 26 Jan '08

26 Jan '08

Author: dreimer Date: Sat Jan 26 17:27:11 2008 New Revision: 32014 URL: http://svn.reactos.org/svn/reactos?rev=32014&view=rev Log: Bug 3005: Italian translation update (devotip(a)tiscali.it) Added: trunk/reactos/dll/win32/shellext/deskadp/lang/it-IT.rc (with props) Modified: trunk/reactos/base/setup/usetup/lang/it-IT.h trunk/reactos/dll/win32/shell32/lang/it-IT.rc trunk/reactos/dll/win32/shellext/deskadp/rsrc.rc trunk/reactos/dll/win32/syssetup/lang/it-IT.rc Modified: trunk/reactos/base/setup/usetup/lang/it-IT.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/setup/usetup/lang/it-… ============================================================================== --- trunk/reactos/base/setup/usetup/lang/it-IT.h (original) +++ trunk/reactos/base/setup/usetup/lang/it-IT.h Sat Jan 26 17:27:11 2008 @@ -30,7 +30,7 @@ { 8, 13, - "\x07 Questa lingua sara' quella predefinita per il sistema finale.", + "\x07 Questa lingua sarà quella predefinita per il sistema finale.", TEXT_NORMAL }, { @@ -958,7 +958,7 @@ { 0, 0, - " \xB3 Please wait... ", + " \xB3 Attendere prego... ", TEXT_STATUS }, { @@ -1044,7 +1044,7 @@ { 8, 13, - "\x07 Premere ESC per tornare allapagina precedente senza modificare", + "\x07 Premere ESC per tornare alla pagina precedente senza modificare", TEXT_NORMAL }, { @@ -1460,12 +1460,12 @@ { //ERROR_ADDING_CODEPAGE, "Setup non ha potuto aggiungere la codepage al registry.\n" - "ENTER = Reboot computer" + "INVIO = Riavviare il computer" }, { //ERROR_UPDATE_LOCALESETTINGS, "Setup non ha potuto impostare la regionalizzazione del sistema.\n" - "ENTER = Reboot computer" + "INVIO = Riavviare il computer" }, { NULL, @@ -1578,3 +1578,4 @@ + Modified: trunk/reactos/dll/win32/shell32/lang/it-IT.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/lang/it-… ============================================================================== --- trunk/reactos/dll/win32/shell32/lang/it-IT.rc (original) +++ trunk/reactos/dll/win32/shell32/lang/it-IT.rc Sat Jan 26 17:27:11 2008 @@ -192,9 +192,9 @@ CAPTION "Proprietà avanzate" FONT 8, "MS Shell Dlg", 0, 0, 0x0 BEGIN - LTEXT "Scegliere le impostazioni avanzate per questa scorciatoia.", -1, 5, 30, 210, 10 + LTEXT "Scegliere le impostazioni avanzate per questo collegamento.", -1, 5, 30, 210, 10 CHECKBOX "Eseguire con credenziali diverse", 14000, 25, 50, 150, 10 - LTEXT "Questa opzione permette l'esecuzione della scorciatoia come se si fosse un altro utente o di proteggere il computer e i dati da attività non autorizzate del programma.", -1, 50, 60, 175, 40 + LTEXT "Questa opzione permette l'esecuzione del collegamento come se si fosse un altro utente o di proteggere il computer e i dati da attività non autorizzate del programma.", -1, 50, 60, 175, 40 CHECKBOX "Eseguire in uno spazio di memoria separato", 14001, 25, 100, 90, 10, WS_DISABLED PUSHBUTTON "OK", 1, 63, 124, 50, 15, WS_VISIBLE PUSHBUTTON "Annulla", 2, 120, 124, 50, 15, WS_VISIBLE Added: trunk/reactos/dll/win32/shellext/deskadp/lang/it-IT.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shellext/deskadp… ============================================================================== --- trunk/reactos/dll/win32/shellext/deskadp/lang/it-IT.rc (added) +++ trunk/reactos/dll/win32/shellext/deskadp/lang/it-IT.rc Sat Jan 26 17:27:11 2008 @@ -1,0 +1,48 @@ +LANGUAGE LANG_ITALIAN, SUBLANG_NEUTRAL + +IDD_DISPLAYADAPTER DIALOGEX 0, 0, 252, 226 +STYLE DS_SHELLFONT | WS_CHILD | WS_DISABLED | WS_CAPTION +CAPTION "Adattatore" +FONT 8, "MS Shell Dlg", 0, 0, 0x0 +BEGIN + GROUPBOX "Tipo di adattatore", -1, 7, 3, 237, 50 + LTEXT "", IDC_ADAPTERNAME, 40, 17, 190, 20, SS_NOPREFIX + PUSHBUTTON "&Proprietà", IDC_ADAPTERPROPERTIES, 177, 33, 59, 14 + GROUPBOX "Informazioni sul'adattatore", -1, 7, 56, 237, 75 + LTEXT "Tipo di Chip:", -1, 13, 68, 58, 8 + LTEXT "", IDC_CHIPTYPE, 71, 68, 160, 8, SS_NOPREFIX + LTEXT "Tipo di DAC:", -1, 13, 80, 58, 8 + LTEXT "", IDC_DACTYPE, 71, 80, 160, 8, SS_NOPREFIX + LTEXT "Quantità di memoria:", -1, 13, 92, 58, 8 + LTEXT "", IDC_MEMORYSIZE, 71, 92, 160, 8, SS_NOPREFIX + LTEXT "Testo dell'adattatore:", -1, 13, 104, 58, 8 + LTEXT "", IDC_ADAPTERSTRING, 71, 104, 160, 8, SS_NOPREFIX + LTEXT "Informazioni sul BIOS:", -1, 13, 116, 58, 8 + LTEXT "", IDC_BIOSINFORMATION, 71, 116, 160, 8, SS_NOPREFIX + PUSHBUTTON "&Elenco di tutte le modalità...", IDC_LISTALLMODES, 7, 139, 75, 14 +END + +IDD_LISTALLMODES DIALOGEX 0, 0, 225, 135 +STYLE DS_SHELLFONT | DS_MODALFRAME | WS_POPUPWINDOW | WS_VISIBLE | WS_DLGFRAME +CAPTION "Elenco di tutte le modalità" +FONT 8, "MS Shell Dlg", 0, 0, 0x0 +BEGIN + DEFPUSHBUTTON "OK", IDOK, 112, 115, 50, 15 + PUSHBUTTON "Annulla", IDCANCEL, 167, 115, 50, 15 + GROUPBOX "Elenco delle modalità valide", -1, 6, 7, 212, 98 + LISTBOX IDC_ALLVALIDMODES, 10, 20, 204, 87, LBS_NOTIFY | WS_VSCROLL +END + +STRINGTABLE +BEGIN + IDS_MODEFMT "%d by %d, %s, %s" + IDS_DEFREFRESHRATE "Rinfresco predefinito" + IDES_REFRESHRATEFMT "%d Hertz" + IDS_4BPP "16 Colori" + IDS_8BPP "256 Colori" + IDS_15BPP "High Color (15 bit)" + IDS_16BPP "High Color (16 bit)" + IDS_24BPP "True Color (24 bit)" + IDS_32BPP "True Color (32 bit)" +END + Propchange: trunk/reactos/dll/win32/shellext/deskadp/lang/it-IT.rc ------------------------------------------------------------------------------ svn:eol-style = native Modified: trunk/reactos/dll/win32/shellext/deskadp/rsrc.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shellext/deskadp… ============================================================================== --- trunk/reactos/dll/win32/shellext/deskadp/rsrc.rc (original) +++ trunk/reactos/dll/win32/shellext/deskadp/rsrc.rc Sat Jan 26 17:27:11 2008 @@ -10,3 +10,4 @@ #include "lang/sk-SK.rc" #include "lang/uk-UA.rc" #include "lang/ru-RU.rc" +#include "lang/it-IT.rc" Modified: trunk/reactos/dll/win32/syssetup/lang/it-IT.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/syssetup/lang/it… ============================================================================== --- trunk/reactos/dll/win32/syssetup/lang/it-IT.rc (original) +++ trunk/reactos/dll/win32/syssetup/lang/it-IT.rc Sat Jan 26 17:27:11 2008 @@ -176,8 +176,8 @@ IDS_LOCALESUBTITLE "È possibile personalizzare ReactOS per regioni e lingue differenti." IDS_DATETIMETITLE "Data e ora" IDS_DATETIMESUBTITLE "Impostare la data e l'ora corrette per il proprio computer." - IDS_PROCESSTITLE "Titolo della pagina di avanzamento" - IDS_PROCESSSUBTITLE "Sottotitolo della pagina di avanzamento" + IDS_PROCESSTITLE "Registrazione dei componenti" + IDS_PROCESSSUBTITLE "Attendere prego..." END STRINGTABLE @@ -197,7 +197,7 @@ IDS_CMT_SCREENSHOT "Salva una schermata" IDS_CMT_DEVMGMT "Lancia la Gestione periferiche" IDS_CMT_SERVMAN "Lancia la Gestione dei servizi" - IDS_CMT_RDESKTOP "Launch Remote Desktop" + IDS_CMT_RDESKTOP "Aviia il Desktop remoto" END STRINGTABLE

1 0

[fireball] 32013: - Set LoaderPagesSpanned field in the extension.
by fireball＠svn.reactos.org 26 Jan '08

26 Jan '08

Author: fireball Date: Sat Jan 26 16:57:55 2008 New Revision: 32013 URL: http://svn.reactos.org/svn/reactos?rev=32013&view=rev Log: - Set LoaderPagesSpanned field in the extension. Modified: trunk/reactos/boot/freeldr/freeldr/windows/winldr.c Modified: trunk/reactos/boot/freeldr/freeldr/windows/winldr.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/windo… ============================================================================== --- trunk/reactos/boot/freeldr/freeldr/windows/winldr.c (original) +++ trunk/reactos/boot/freeldr/freeldr/windows/winldr.c Sat Jan 26 16:57:55 2008 @@ -190,6 +190,7 @@ Extension->Size = sizeof(LOADER_PARAMETER_EXTENSION); Extension->MajorVersion = (VersionToBoot & 0xFF00) >> 8; Extension->MinorVersion = VersionToBoot & 0xFF; + Extension->LoaderPagesSpanned = LOADER_HIGH_ZONE; LoaderBlock->Extension = PaToVa(Extension);

1 0

[gedmurphy] 32012: fix typo
by gedmurphy＠svn.reactos.org 26 Jan '08

26 Jan '08

Author: gedmurphy Date: Sat Jan 26 16:05:39 2008 New Revision: 32012 URL: http://svn.reactos.org/svn/reactos?rev=32012&view=rev Log: fix typo Modified: trunk/reactos/subsystems/win32/win32k/ntuser/class.c Modified: trunk/reactos/subsystems/win32/win32k/ntuser/class.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/nt… ============================================================================== --- trunk/reactos/subsystems/win32/win32k/ntuser/class.c (original) +++ trunk/reactos/subsystems/win32/win32k/ntuser/class.c Sat Jan 26 16:05:39 2008 @@ -2159,7 +2159,7 @@ PUNICODE_STRING ClassName, LPWNDCLASSEXW lpWndClassEx, LPWSTR *ppszMenuName, - BOOL Ansi); + BOOL Ansi) { UNICODE_STRING CapturedClassName; PWINDOWCLASS Class;

1 0

[fireball] 32011: - Display string identifiers in debug log too.
by fireball＠svn.reactos.org 26 Jan '08

26 Jan '08

Author: fireball Date: Sat Jan 26 16:03:32 2008 New Revision: 32011 URL: http://svn.reactos.org/svn/reactos?rev=32011&view=rev Log: - Display string identifiers in debug log too. Modified: trunk/reactos/boot/freeldr/freeldr/windows/conversion.c Modified: trunk/reactos/boot/freeldr/freeldr/windows/conversion.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/windo… ============================================================================== --- trunk/reactos/boot/freeldr/freeldr/windows/conversion.c (original) +++ trunk/reactos/boot/freeldr/freeldr/windows/conversion.c Sat Jan 26 16:03:32 2008 @@ -90,8 +90,8 @@ if (Child->ComponentEntry.Identifier) Child->ComponentEntry.Identifier = PaToVa(Child->ComponentEntry.Identifier); - DbgPrint((DPRINT_WINDOWS, "Device 0x%X class %d type %d id %p, parent %p\n", Child, - Child->ComponentEntry.Class, Child->ComponentEntry.Type, Child->ComponentEntry.Identifier, Child->Parent)); + DbgPrint((DPRINT_WINDOWS, "Device 0x%X class %d type %d id '%s', parent %p\n", Child, + Child->ComponentEntry.Class, Child->ComponentEntry.Type, VaToPa(Child->ComponentEntry.Identifier), Child->Parent)); // Go through siblings list Sibling = VaToPa(Child->Sibling); @@ -112,8 +112,8 @@ if (Sibling->ComponentEntry.Identifier) Sibling->ComponentEntry.Identifier = PaToVa(Sibling->ComponentEntry.Identifier); - DbgPrint((DPRINT_WINDOWS, "Device 0x%X class %d type %d id %p, parent %p\n", Sibling, - Sibling->ComponentEntry.Class, Sibling->ComponentEntry.Type, Sibling->ComponentEntry.Identifier, Sibling->Parent)); + DbgPrint((DPRINT_WINDOWS, "Device 0x%X class %d type %d id '%s', parent %p\n", Sibling, + Sibling->ComponentEntry.Class, Sibling->ComponentEntry.Type, VaToPa(Sibling->ComponentEntry.Identifier), Sibling->Parent)); // Recurse into the Child tree if (VaToPa(Sibling->Child) != NULL)

1 0

[gedmurphy] 32010: - fix number of params in 3 win32k syscalls - patch by Stefan Ginsberg (stefan__100__@hotmail.com) (NtUserGetClassInfo params advised by myself)
by gedmurphy＠svn.reactos.org 26 Jan '08

26 Jan '08

Author: gedmurphy Date: Sat Jan 26 15:55:46 2008 New Revision: 32010 URL: http://svn.reactos.org/svn/reactos?rev=32010&view=rev Log: - fix number of params in 3 win32k syscalls - patch by Stefan Ginsberg (stefan__100__(a)hotmail.com) (NtUserGetClassInfo params advised by myself) Modified: trunk/reactos/dll/win32/user32/windows/class.c trunk/reactos/include/reactos/win32k/ntuser.h trunk/reactos/subsystems/win32/win32k/ntuser/class.c trunk/reactos/subsystems/win32/win32k/ntuser/ntstubs.c trunk/reactos/subsystems/win32/win32k/w32ksvc.db Modified: trunk/reactos/dll/win32/user32/windows/class.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/c… ============================================================================== --- trunk/reactos/dll/win32/user32/windows/class.c (original) +++ trunk/reactos/dll/win32/user32/windows/class.c Sat Jan 26 15:55:46 2008 @@ -63,6 +63,7 @@ Ret = NtUserGetClassInfo(hInstance, &ClassName, (LPWNDCLASSEXW)lpwcx, + NULL, TRUE); if (!IS_ATOM(lpszClass)) @@ -118,6 +119,7 @@ return NtUserGetClassInfo(hInstance, &ClassName, lpwcx, + NULL, FALSE); } @@ -1226,7 +1228,8 @@ ClassName.Buffer = (PWSTR)((ULONG_PTR)lpClassName); Ret = NtUserUnregisterClass(&ClassName, - hInstance); + hInstance, + 0); if (!IS_ATOM(lpClassName)) RtlFreeUnicodeString(&ClassName); @@ -1260,7 +1263,8 @@ ClassName.Buffer = (PWSTR)((ULONG_PTR)lpClassName); return NtUserUnregisterClass(&ClassName, - hInstance); + hInstance, + 0); } /* EOF */ Modified: trunk/reactos/include/reactos/win32k/ntuser.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/reactos/win32k/ntu… ============================================================================== --- trunk/reactos/include/reactos/win32k/ntuser.h (original) +++ trunk/reactos/include/reactos/win32k/ntuser.h Sat Jan 26 15:55:46 2008 @@ -1099,6 +1099,7 @@ NtUserGetClassInfo(HINSTANCE hInstance, PUNICODE_STRING ClassName, LPWNDCLASSEXW wcex, + LPWSTR *ppszMenuName, BOOL Ansi); INT @@ -1496,7 +1497,8 @@ DWORD Unknown7, DWORD Unknown8, DWORD Unknown9, - DWORD Unknown10); + DWORD Unknown10, + DWORD Unknown11); INT NTAPI @@ -2422,7 +2424,8 @@ NTAPI NtUserUnregisterClass( PUNICODE_STRING ClassNameOrAtom, - HINSTANCE hInstance); + HINSTANCE hInstance, + DWORD Unknown); BOOL NTAPI Modified: trunk/reactos/subsystems/win32/win32k/ntuser/class.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/nt… ============================================================================== --- trunk/reactos/subsystems/win32/win32k/ntuser/class.c (original) +++ trunk/reactos/subsystems/win32/win32k/ntuser/class.c Sat Jan 26 15:55:46 2008 @@ -2104,7 +2104,8 @@ BOOL NTAPI NtUserUnregisterClass(IN PUNICODE_STRING ClassNameOrAtom, - IN HINSTANCE hInstance) + IN HINSTANCE hInstance, + DWORD Unknown) { UNICODE_STRING CapturedClassName; BOOL Ret = FALSE; @@ -2157,7 +2158,8 @@ HINSTANCE hInstance, PUNICODE_STRING ClassName, LPWNDCLASSEXW lpWndClassEx, - BOOL Ansi) + LPWSTR *ppszMenuName, + BOOL Ansi); { UNICODE_STRING CapturedClassName; PWINDOWCLASS Class; Modified: trunk/reactos/subsystems/win32/win32k/ntuser/ntstubs.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/nt… ============================================================================== --- trunk/reactos/subsystems/win32/win32k/ntuser/ntstubs.c (original) +++ trunk/reactos/subsystems/win32/win32k/ntuser/ntstubs.c Sat Jan 26 15:55:46 2008 @@ -414,7 +414,8 @@ DWORD Unknown7, DWORD Unknown8, DWORD Unknown9, - DWORD Unknown10) + DWORD Unknown10, + DWORD Unknown11) { UNIMPLEMENTED Modified: trunk/reactos/subsystems/win32/win32k/w32ksvc.db URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/w3… ============================================================================== --- trunk/reactos/subsystems/win32/win32k/w32ksvc.db (original) +++ trunk/reactos/subsystems/win32/win32k/w32ksvc.db Sat Jan 26 15:55:46 2008 @@ -391,8 +391,7 @@ NtUserGetAtomName 2 NtUserGetCaretBlinkTime 0 NtUserGetCaretPos 1 -# NtUserGetClassInfo 5 Wrong number of param ? -NtUserGetClassInfo 4 +NtUserGetClassInfo 5 NtUserGetClassName 3 NtUserGetClipboardData 2 NtUserGetClipboardFormatName 3 @@ -453,8 +452,7 @@ NtUserImpersonateDdeClientWindow 2 NtUserInitialize 3 NtUserInitializeClientPfnArrays 4 -# NtUserInitTask 12 Wrong number of param ? -NtUserInitTask 11 +NtUserInitTask 12 NtUserInternalGetWindowText 3 NtUserInvalidateRect 3 NtUserInvalidateRgn 3 @@ -580,8 +578,7 @@ NtUserUnhookWinEvent 1 NtUserUnloadKeyboardLayout 1 NtUserUnlockWindowStation 1 -# NtUserUnregisterClass 3 Wrong number of param ? -NtUserUnregisterClass 2 +NtUserUnregisterClass 3 NtUserUnregisterUserApiHook 0 NtUserUnregisterHotKey 2 NtUserUpdateInputContext 3

1 0

[cwittich] 32009: allowwarnings="true" (req. by gcc 4.3.0)
by cwittich＠svn.reactos.org 26 Jan '08

26 Jan '08

Author: cwittich Date: Sat Jan 26 13:40:53 2008 New Revision: 32009 URL: http://svn.reactos.org/svn/reactos?rev=32009&view=rev Log: allowwarnings="true" (req. by gcc 4.3.0) Modified: trunk/reactos/base/applications/winhelp/winhelp.rbuild Modified: trunk/reactos/base/applications/winhelp/winhelp.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/winhelp/… ============================================================================== --- trunk/reactos/base/applications/winhelp/winhelp.rbuild (original) +++ trunk/reactos/base/applications/winhelp/winhelp.rbuild Sat Jan 26 13:40:53 2008 @@ -1,6 +1,6 @@ <?xml version="1.0"?> <!DOCTYPE module SYSTEM "../../../tools/rbuild/project.dtd"> -<module name="winhelp" type="win32gui" installbase="system32" installname="winhelp.exe" unicode="no"> +<module name="winhelp" type="win32gui" installbase="system32" installname="winhelp.exe" unicode="no" allowwarnings="true"> <include base="winhelp">.</include> <define name="_WIN32_IE">0x0600</define> <define name="_WIN32_WINNT">0x0501</define>

1 0

[cwittich] 32008: the address of gpDxFuncs will always evaluate as true
by cwittich＠svn.reactos.org 26 Jan '08

26 Jan '08

Author: cwittich Date: Sat Jan 26 13:10:43 2008 New Revision: 32008 URL: http://svn.reactos.org/svn/reactos?rev=32008&view=rev Log: the address of gpDxFuncs will always evaluate as true Modified: trunk/reactos/subsystems/win32/win32k/include/intddraw.h Modified: trunk/reactos/subsystems/win32/win32k/include/intddraw.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/in… ============================================================================== --- trunk/reactos/subsystems/win32/win32k/include/intddraw.h (original) +++ trunk/reactos/subsystems/win32/win32k/include/intddraw.h Sat Jan 26 13:10:43 2008 @@ -109,16 +109,13 @@ /* Standard macro */ #define DXG_GET_INDEX_FUNCTION(INDEX, FUNCTION) \ - if (gpDxFuncs) \ + for (i = 0; i <= DXG_INDEX_DxDdIoctl; i++) \ { \ - for (i = 0; i <= DXG_INDEX_DxDdIoctl; i++) \ + if (gpDxFuncs[i].iFunc == INDEX) \ { \ - if (gpDxFuncs[i].iFunc == INDEX) \ - { \ - FUNCTION = (VOID *)gpDxFuncs[i].pfn; \ - break; \ - } \ - } \ + FUNCTION = (VOID *)gpDxFuncs[i].pfn; \ + break; \ + } \ } /* Gammaramp internal prototype */

1 0

[arty] 32007: Fix termination of process under debug.
by arty＠svn.reactos.org 26 Jan '08

26 Jan '08

Author: arty Date: Sat Jan 26 12:20:56 2008 New Revision: 32007 URL: http://svn.reactos.org/svn/reactos?rev=32007&view=rev Log: Fix termination of process under debug. Modified: trunk/reactos/ntoskrnl/dbgk/dbgkobj.c Modified: trunk/reactos/ntoskrnl/dbgk/dbgkobj.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/dbgk/dbgkobj.c?re… ============================================================================== --- trunk/reactos/ntoskrnl/dbgk/dbgkobj.c (original) +++ trunk/reactos/ntoskrnl/dbgk/dbgkobj.c Sat Jan 26 12:20:56 2008 @@ -1065,6 +1065,17 @@ VOID NTAPI +DbgkpDelayedTerminateProcess(PVOID Arg) +{ + PWORK_QUEUE_ITEM WorkItem = (PWORK_QUEUE_ITEM)Arg; + PEPROCESS OwnerProcess = *((PEPROCESS *)&WorkItem[1]); + ExFreePool(WorkItem); + /* Terminate the process */ + PsTerminateProcess(OwnerProcess, STATUS_DEBUGGER_INACTIVE); +} + +VOID +NTAPI DbgkpCloseObject(IN PEPROCESS OwnerProcess OPTIONAL, IN PVOID ObjectBody, IN ACCESS_MASK GrantedAccess, @@ -1079,6 +1090,8 @@ DBGKTRACE(DBGK_OBJECT_DEBUG, "OwnerProcess: %p DebugObject: %p\n", OwnerProcess, DebugObject); + DPRINT("APC DISABLE: %d\n", ((PETHREAD)KeGetCurrentThread())->Tcb.CombinedApcDisable); + /* If this isn't the last handle, do nothing */ if (SystemHandleCount > 1) return; @@ -1127,8 +1140,16 @@ /* Check if we terminate on exit */ if (DebugObject->KillProcessOnExit) { - /* Terminate the process */ - PsTerminateProcess(OwnerProcess, STATUS_DEBUGGER_INACTIVE); + PWORK_QUEUE_ITEM WorkItem = + ExAllocatePool + (NonPagedPool, + sizeof(WORK_QUEUE_ITEM) + sizeof(PVOID)); + ExInitializeWorkItem + (WorkItem, + DbgkpDelayedTerminateProcess, + WorkItem); + *((PEPROCESS *)&WorkItem[1]) = OwnerProcess; + ExQueueWorkItem(WorkItem, CriticalWorkQueue); } /* Dereference the debug object */

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs