Ros-diffs

ros-diffs@reactos.org

81390 discussions

[hpoussin] 31722: Fix 2nd stage hang
by hpoussin＠svn.reactos.org 11 Jan '08

11 Jan '08

Author: hpoussin Date: Fri Jan 11 18:37:43 2008 New Revision: 31722 URL: http://svn.reactos.org/svn/reactos?rev=31722&view=rev Log: Fix 2nd stage hang Modified: trunk/reactos/base/services/umpnpmgr/umpnpmgr.c Modified: trunk/reactos/base/services/umpnpmgr/umpnpmgr.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/services/umpnpmgr/ump… ============================================================================== --- trunk/reactos/base/services/umpnpmgr/umpnpmgr.c (original) +++ trunk/reactos/base/services/umpnpmgr/umpnpmgr.c Fri Jan 11 18:37:43 2008 @@ -1848,7 +1848,7 @@ DPRINT("Umpnpmgr: main() started\n"); - hInstallEvent = CreateEvent(NULL, TRUE, FALSE, NULL); + hInstallEvent = CreateEvent(NULL, TRUE, SetupIsActive()/*FALSE*/, NULL); if (hInstallEvent == NULL) { dwError = GetLastError();

1 0

[fireball] 31721: - Merge leftovers.
by fireball＠svn.reactos.org 11 Jan '08

11 Jan '08

Author: fireball Date: Fri Jan 11 18:28:28 2008 New Revision: 31721 URL: http://svn.reactos.org/svn/reactos?rev=31721&view=rev Log: - Merge leftovers. Modified: trunk/reactos/dll/win32/rpcrt4/rpc_server.c trunk/reactos/dll/win32/rpcrt4/rpc_transport.c trunk/reactos/dll/win32/rpcrt4/rpcrt4_ros.diff Modified: trunk/reactos/dll/win32/rpcrt4/rpc_server.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/rpcrt4/rpc_serve… ============================================================================== --- trunk/reactos/dll/win32/rpcrt4/rpc_server.c (original) +++ trunk/reactos/dll/win32/rpcrt4/rpc_server.c Fri Jan 11 18:28:28 2008 @@ -1019,7 +1019,7 @@ */ RPC_STATUS WINAPI RpcMgmtWaitServerListen( void ) { - TRACE("()\n"); + RpcServerProtseq *cps; EnterCriticalSection(&listen_cs); @@ -1027,10 +1027,18 @@ LeaveCriticalSection(&listen_cs); return RPC_S_NOT_LISTENING; } - + + do + { + LeaveCriticalSection(&listen_cs); + + LIST_FOR_EACH_ENTRY(cps, &protseqs, RpcServerProtseq, entry) + WaitForSingleObject(cps->server_ready_event, INFINITE); + + EnterCriticalSection(&listen_cs); + } while (!std_listen); + LeaveCriticalSection(&listen_cs); - - FIXME("not waiting for server calls to finish\n"); return RPC_S_OK; } Modified: trunk/reactos/dll/win32/rpcrt4/rpc_transport.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/rpcrt4/rpc_trans… ============================================================================== --- trunk/reactos/dll/win32/rpcrt4/rpc_transport.c (original) +++ trunk/reactos/dll/win32/rpcrt4/rpc_transport.c Fri Jan 11 18:28:28 2008 @@ -375,7 +375,7 @@ break; ret = GetOverlappedResult(npc->pipe, &npc->ovl[0], &bytes_read, TRUE); - if (!ret /*&& GetLastError() != ERROR_MORE_DATA*/) + if (!ret && GetLastError() != ERROR_MORE_DATA) break; bytes_left -= bytes_read; @@ -400,7 +400,7 @@ break; ret = GetOverlappedResult(npc->pipe, &npc->ovl[1], &bytes_written, TRUE); - if (!ret /*&& GetLastError() != ERROR_MORE_DATA*/) + if (!ret && GetLastError() != ERROR_MORE_DATA) break; bytes_left -= bytes_written; Modified: trunk/reactos/dll/win32/rpcrt4/rpcrt4_ros.diff URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/rpcrt4/rpcrt4_ro… ============================================================================== --- trunk/reactos/dll/win32/rpcrt4/rpcrt4_ros.diff (original) +++ trunk/reactos/dll/win32/rpcrt4/rpcrt4_ros.diff Fri Jan 11 18:28:28 2008 @@ -1,5 +1,40 @@ ---- H:\Working Copies\wine\dlls\rpcrt4\rpc_transport.c Sun Jan 06 19:27:38 2008 -+++ H:\Working Copies\ReactOS\trunk\reactos\dll\win32\rpcrt4\rpc_transport.c Mon Jan 07 16:02:15 2008 +--- rpc_server.c Tue Jan 01 13:09:34 2008 ++++ rpc_server.c Fri Jan 11 15:58:57 2008 +@@ -1017,22 +1017,30 @@ + /*********************************************************************** + * RpcMgmtServerWaitListen (RPCRT4.@) + */ + RPC_STATUS WINAPI RpcMgmtWaitServerListen( void ) + { +- TRACE("()\n"); ++ RpcServerProtseq *cps; + + EnterCriticalSection(&listen_cs); + + if (!std_listen) { + LeaveCriticalSection(&listen_cs); + return RPC_S_NOT_LISTENING; + } + ++ do ++ { + LeaveCriticalSection(&listen_cs); + +- FIXME("not waiting for server calls to finish\n"); ++ LIST_FOR_EACH_ENTRY(cps, &protseqs, RpcServerProtseq, entry) ++ WaitForSingleObject(cps->server_ready_event, INFINITE); ++ ++ EnterCriticalSection(&listen_cs); ++ } while (!std_listen); ++ ++ LeaveCriticalSection(&listen_cs); + + return RPC_S_OK; + } + + /*********************************************************************** +--- rpc_transport.c Sun Jan 06 19:27:38 2008 ++++ rpc_transport.c Fri Jan 11 15:59:32 2008 @@ -54,10 +54,13 @@ #endif #ifdef HAVE_SYS_POLL_H @@ -127,7 +162,7 @@ break; + + ret = GetOverlappedResult(npc->pipe, &npc->ovl[0], &bytes_read, TRUE); -+ if (!ret /*&& GetLastError() != ERROR_MORE_DATA*/) ++ if (!ret && GetLastError() != ERROR_MORE_DATA) + break; + bytes_left -= bytes_read; @@ -148,7 +183,7 @@ break; + + ret = GetOverlappedResult(npc->pipe, &npc->ovl[1], &bytes_written, TRUE); -+ if (!ret /*&& GetLastError() != ERROR_MORE_DATA*/) ++ if (!ret && GetLastError() != ERROR_MORE_DATA) + break; + bytes_left -= bytes_written;

1 0

[fireball] 31720: - Update wine sync doc. - Add rpcrt4_winetest to the install CD.
by fireball＠svn.reactos.org 11 Jan '08

11 Jan '08

Author: fireball Date: Fri Jan 11 18:16:33 2008 New Revision: 31720 URL: http://svn.reactos.org/svn/reactos?rev=31720&view=rev Log: - Update wine sync doc. - Add rpcrt4_winetest to the install CD. Modified: trunk/reactos/boot/bootdata/packages/reactos.dff trunk/reactos/media/doc/README.WINE Modified: trunk/reactos/boot/bootdata/packages/reactos.dff URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/bootdata/packages/rea… ============================================================================== --- trunk/reactos/boot/bootdata/packages/reactos.dff (original) +++ trunk/reactos/boot/bootdata/packages/reactos.dff Fri Jan 11 18:16:33 2008 @@ -547,6 +547,7 @@ modules\rostests\winetests\ntdll\ntdll_winetest.exe 7 optional modules\rostests\winetests\powrprof\powrprof_winetest.exe 7 optional modules\rostests\winetests\psapi\psapi_winetest.exe 7 optional +modules\rostests\winetests\rpcrt4\rpcrt4_winetest.exe 7 optional modules\rostests\winetests\setupapi\setupapi_winetest.exe 7 optional modules\rostests\winetests\shell32\shell32_winetest.exe 7 optional modules\rostests\winetests\shlwapi\shlwapi_winetest.exe 7 optional Modified: trunk/reactos/media/doc/README.WINE URL: http://svn.reactos.org/svn/reactos/trunk/reactos/media/doc/README.WINE?rev=… ============================================================================== --- trunk/reactos/media/doc/README.WINE (original) +++ trunk/reactos/media/doc/README.WINE Fri Jan 11 18:16:33 2008 @@ -27,7 +27,7 @@ reactos/tools/winebuild # Synced to Wine-20071217 reactos/tools/wmc # Synced to Wine-20071201 reactos/tools/wrc # Synced to Wine-0_9_5 -reactos/tools/widl # Synced to Wine-20060729 +reactos/tools/widl # Synced to Wine-20080105 The following libraries are shared with Wine. @@ -71,7 +71,7 @@ reactos/dll/win32/powrprof # Autosync reactos/dll/win32/riched20 # Autosync reactos/dll/win32/riched32 # Autosync -reactos/dll/win32/rpcrt4 # Synced to Wine-0_9_10 +reactos/dll/win32/rpcrt4 # Synced to Wine-20080105 reactos/dll/win32/rsabase # Autosync reactos/dll/win32/rsaenh # Autosync reactos/dll/win32/schannel # Autosync

1 0

[fireball] 31719: - Correct fix for the obj-i386 dependent path hack, by hpoussin.
by fireball＠svn.reactos.org 11 Jan '08

11 Jan '08

Author: fireball Date: Fri Jan 11 18:12:54 2008 New Revision: 31719 URL: http://svn.reactos.org/svn/reactos?rev=31719&view=rev Log: - Correct fix for the obj-i386 dependent path hack, by hpoussin. Modified: trunk/rostests/winetests/rpcrt4/rpcrt4.rbuild trunk/rostests/winetests/rpcrt4/server.c Modified: trunk/rostests/winetests/rpcrt4/rpcrt4.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/rostests/winetests/rpcrt4/rpcrt4.r… ============================================================================== --- trunk/rostests/winetests/rpcrt4/rpcrt4.rbuild (original) +++ trunk/rostests/winetests/rpcrt4/rpcrt4.rbuild Fri Jan 11 18:12:54 2008 @@ -6,6 +6,7 @@ </module> <module name="rpcrt4_winetest" type="win32cui" installbase="bin" installname="rpcrt4_winetest.exe" allowwarnings="true"> <include base="rpcrt4_winetest">.</include> + <include root="intermediate" base="rpcrt4_winetest">.</include> <define name="__USE_W32API" /> <library>wine</library> <library>pseh</library> Modified: trunk/rostests/winetests/rpcrt4/server.c URL: http://svn.reactos.org/svn/reactos/trunk/rostests/winetests/rpcrt4/server.c… ============================================================================== --- trunk/rostests/winetests/rpcrt4/server.c (original) +++ trunk/rostests/winetests/rpcrt4/server.c Fri Jan 11 18:12:54 2008 @@ -20,7 +20,7 @@ #include <windows.h> #include "wine/test.h" -#include "obj-i386/modules/rostests/winetests/rpcrt4/server.h" +#include "server_s.h" #include "server_defines.h" #include <stddef.h>

1 0

[cfinck] 31718: Trying to fix the build on Unix hosts by only using host headers in widl
by cfinck＠svn.reactos.org 11 Jan '08

11 Jan '08

Author: cfinck Date: Fri Jan 11 17:46:27 2008 New Revision: 31718 URL: http://svn.reactos.org/svn/reactos?rev=31718&view=rev Log: Trying to fix the build on Unix hosts by only using host headers in widl Modified: trunk/reactos/tools/widl/hash.c trunk/reactos/tools/widl/typelib.c trunk/reactos/tools/widl/widltypes.h trunk/reactos/tools/widl/write_msft.c Modified: trunk/reactos/tools/widl/hash.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/tools/widl/hash.c?rev=3171… ============================================================================== --- trunk/reactos/tools/widl/hash.c (original) +++ trunk/reactos/tools/widl/hash.c Fri Jan 11 17:46:27 2008 @@ -21,9 +21,7 @@ #include <stdio.h> #include <stdarg.h> -#include "windef.h" -#include "winbase.h" -#include "winnls.h" +#include <host/nls.h> #include "hash.h" Modified: trunk/reactos/tools/widl/typelib.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/tools/widl/typelib.c?rev=3… ============================================================================== --- trunk/reactos/tools/widl/typelib.c (original) +++ trunk/reactos/tools/widl/typelib.c Fri Jan 11 17:46:27 2008 @@ -35,8 +35,7 @@ #define NONAMELESSUNION #define NONAMELESSSTRUCT -#include "windef.h" -#include "winbase.h" +#include <host/typedefs.h> #include "widl.h" #include "utils.h" Modified: trunk/reactos/tools/widl/widltypes.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/tools/widl/widltypes.h?rev… ============================================================================== --- trunk/reactos/tools/widl/widltypes.h (original) +++ trunk/reactos/tools/widl/widltypes.h Fri Jan 11 17:46:27 2008 @@ -20,6 +20,13 @@ #ifndef __WIDL_WIDLTYPES_H #define __WIDL_WIDLTYPES_H + +#define S_OK 0 +#define S_FALSE 1 +#define E_OUTOFMEMORY ((HRESULT)0x8007000EL) +#define TYPE_E_IOERROR ((HRESULT)0x80028CA2L) + +#define max(a, b) ((a) > (b) ? a : b) #include <stdarg.h> #include "guiddef.h" Modified: trunk/reactos/tools/widl/write_msft.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/tools/widl/write_msft.c?re… ============================================================================== --- trunk/reactos/tools/widl/write_msft.c (original) +++ trunk/reactos/tools/widl/write_msft.c Fri Jan 11 17:46:27 2008 @@ -40,10 +40,8 @@ #define NONAMELESSUNION #define NONAMELESSSTRUCT -#include "winerror.h" -#include "windef.h" -#include "winbase.h" -#include "winnls.h" +#include <host/typedefs.h> +#include <host/nls.h> #include "widltypes.h" #include "typelib.h"

1 0

[fireball] 31717: - Switch to the new widl and new rpcrt4. - Old widl had some more patches applies, and old rpcrt4 had Saveliy Tretiakov's patches applied. They were not explicitly added into this update (some of them might be reworked and got accepted by Wine).
by fireball＠svn.reactos.org 11 Jan '08

11 Jan '08

Author: fireball Date: Fri Jan 11 16:46:33 2008 New Revision: 31717 URL: http://svn.reactos.org/svn/reactos?rev=31717&view=rev Log: - Switch to the new widl and new rpcrt4. - Old widl had some more patches applies, and old rpcrt4 had Saveliy Tretiakov's patches applied. They were not explicitly added into this update (some of them might be reworked and got accepted by Wine). Added: trunk/reactos/dll/win32/rpcrt4/cproxy.c - copied unchanged from r31674, trunk/reactos/dll/win32/rpcrt4_new/cproxy.c trunk/reactos/dll/win32/rpcrt4/cpsf.c - copied unchanged from r31674, trunk/reactos/dll/win32/rpcrt4_new/cpsf.c trunk/reactos/dll/win32/rpcrt4/cpsf.h - copied unchanged from r31674, trunk/reactos/dll/win32/rpcrt4_new/cpsf.h trunk/reactos/dll/win32/rpcrt4/cstub.c - copied unchanged from r31674, trunk/reactos/dll/win32/rpcrt4_new/cstub.c trunk/reactos/dll/win32/rpcrt4/epm_towers.h - copied unchanged from r31674, trunk/reactos/dll/win32/rpcrt4_new/epm_towers.h trunk/reactos/dll/win32/rpcrt4/ncastatus.h - copied unchanged from r31674, trunk/reactos/dll/win32/rpcrt4_new/ncastatus.h trunk/reactos/dll/win32/rpcrt4/ndr_clientserver.c - copied unchanged from r31674, trunk/reactos/dll/win32/rpcrt4_new/ndr_clientserver.c trunk/reactos/dll/win32/rpcrt4/ndr_contexthandle.c - copied unchanged from r31674, trunk/reactos/dll/win32/rpcrt4_new/ndr_contexthandle.c trunk/reactos/dll/win32/rpcrt4/ndr_fullpointer.c - copied unchanged from r31674, trunk/reactos/dll/win32/rpcrt4_new/ndr_fullpointer.c trunk/reactos/dll/win32/rpcrt4/ndr_marshall.c - copied unchanged from r31674, trunk/reactos/dll/win32/rpcrt4_new/ndr_marshall.c trunk/reactos/dll/win32/rpcrt4/ndr_misc.h - copied unchanged from r31674, trunk/reactos/dll/win32/rpcrt4_new/ndr_misc.h trunk/reactos/dll/win32/rpcrt4/ndr_ole.c - copied unchanged from r31674, trunk/reactos/dll/win32/rpcrt4_new/ndr_ole.c trunk/reactos/dll/win32/rpcrt4/ndr_stubless.c - copied unchanged from r31674, trunk/reactos/dll/win32/rpcrt4_new/ndr_stubless.c trunk/reactos/dll/win32/rpcrt4/ndr_stubless.h - copied unchanged from r31674, trunk/reactos/dll/win32/rpcrt4_new/ndr_stubless.h trunk/reactos/dll/win32/rpcrt4/rpc_assoc.c - copied unchanged from r31674, trunk/reactos/dll/win32/rpcrt4_new/rpc_assoc.c trunk/reactos/dll/win32/rpcrt4/rpc_assoc.h - copied unchanged from r31674, trunk/reactos/dll/win32/rpcrt4_new/rpc_assoc.h trunk/reactos/dll/win32/rpcrt4/rpc_binding.c - copied unchanged from r31674, trunk/reactos/dll/win32/rpcrt4_new/rpc_binding.c trunk/reactos/dll/win32/rpcrt4/rpc_binding.h - copied unchanged from r31674, trunk/reactos/dll/win32/rpcrt4_new/rpc_binding.h trunk/reactos/dll/win32/rpcrt4/rpc_defs.h - copied unchanged from r31674, trunk/reactos/dll/win32/rpcrt4_new/rpc_defs.h trunk/reactos/dll/win32/rpcrt4/rpc_epmap.c - copied unchanged from r31674, trunk/reactos/dll/win32/rpcrt4_new/rpc_epmap.c trunk/reactos/dll/win32/rpcrt4/rpc_message.c - copied unchanged from r31674, trunk/reactos/dll/win32/rpcrt4_new/rpc_message.c trunk/reactos/dll/win32/rpcrt4/rpc_message.h - copied unchanged from r31674, trunk/reactos/dll/win32/rpcrt4_new/rpc_message.h trunk/reactos/dll/win32/rpcrt4/rpc_server.c - copied unchanged from r31674, trunk/reactos/dll/win32/rpcrt4_new/rpc_server.c trunk/reactos/dll/win32/rpcrt4/rpc_server.h - copied unchanged from r31674, trunk/reactos/dll/win32/rpcrt4_new/rpc_server.h trunk/reactos/dll/win32/rpcrt4/rpc_transport.c - copied unchanged from r31674, trunk/reactos/dll/win32/rpcrt4_new/rpc_transport.c trunk/reactos/dll/win32/rpcrt4/rpcrt4.rbuild - copied unchanged from r31674, trunk/reactos/dll/win32/rpcrt4_new/rpcrt4.rbuild trunk/reactos/dll/win32/rpcrt4/rpcrt4.rc - copied unchanged from r31674, trunk/reactos/dll/win32/rpcrt4_new/rpcrt4.rc trunk/reactos/dll/win32/rpcrt4/rpcrt4.spec - copied unchanged from r31674, trunk/reactos/dll/win32/rpcrt4_new/rpcrt4.spec trunk/reactos/dll/win32/rpcrt4/rpcrt4_main.c - copied unchanged from r31674, trunk/reactos/dll/win32/rpcrt4_new/rpcrt4_main.c trunk/reactos/dll/win32/rpcrt4/rpcrt4_ros.diff - copied unchanged from r31674, trunk/reactos/dll/win32/rpcrt4_new/rpcrt4_ros.diff trunk/reactos/dll/win32/rpcrt4/rpcss_np_client.c - copied unchanged from r31674, trunk/reactos/dll/win32/rpcrt4_new/rpcss_np_client.c trunk/reactos/dll/win32/rpcrt4/rpcss_np_client.h - copied unchanged from r31674, trunk/reactos/dll/win32/rpcrt4_new/rpcss_np_client.h trunk/reactos/dll/win32/rpcrt4/unix_func.c - copied unchanged from r31674, trunk/reactos/dll/win32/rpcrt4_new/unix_func.c trunk/reactos/dll/win32/rpcrt4/unix_func.h - copied unchanged from r31674, trunk/reactos/dll/win32/rpcrt4_new/unix_func.h trunk/reactos/tools/widl/client.c - copied unchanged from r31674, trunk/reactos/tools/widl_20080105/client.c trunk/reactos/tools/widl/hash.c - copied unchanged from r31674, trunk/reactos/tools/widl_20080105/hash.c trunk/reactos/tools/widl/hash.h - copied unchanged from r31674, trunk/reactos/tools/widl_20080105/hash.h trunk/reactos/tools/widl/header.c - copied unchanged from r31674, trunk/reactos/tools/widl_20080105/header.c trunk/reactos/tools/widl/header.h - copied unchanged from r31674, trunk/reactos/tools/widl_20080105/header.h trunk/reactos/tools/widl/parser.h - copied unchanged from r31674, trunk/reactos/tools/widl_20080105/parser.h trunk/reactos/tools/widl/parser.l - copied unchanged from r31674, trunk/reactos/tools/widl_20080105/parser.l trunk/reactos/tools/widl/parser.tab.c - copied unchanged from r31674, trunk/reactos/tools/widl_20080105/parser.tab.c trunk/reactos/tools/widl/parser.tab.h - copied unchanged from r31674, trunk/reactos/tools/widl_20080105/parser.tab.h trunk/reactos/tools/widl/parser.y - copied unchanged from r31674, trunk/reactos/tools/widl_20080105/parser.y trunk/reactos/tools/widl/parser.yy.c - copied unchanged from r31674, trunk/reactos/tools/widl_20080105/parser.yy.c trunk/reactos/tools/widl/proxy.c - copied unchanged from r31674, trunk/reactos/tools/widl_20080105/proxy.c trunk/reactos/tools/widl/server.c - copied unchanged from r31674, trunk/reactos/tools/widl_20080105/server.c trunk/reactos/tools/widl/typegen.c - copied unchanged from r31674, trunk/reactos/tools/widl_20080105/typegen.c trunk/reactos/tools/widl/typegen.h - copied unchanged from r31674, trunk/reactos/tools/widl_20080105/typegen.h trunk/reactos/tools/widl/typelib.c - copied unchanged from r31674, trunk/reactos/tools/widl_20080105/typelib.c trunk/reactos/tools/widl/typelib.h - copied unchanged from r31674, trunk/reactos/tools/widl_20080105/typelib.h trunk/reactos/tools/widl/typelib_struct.h - copied unchanged from r31674, trunk/reactos/tools/widl_20080105/typelib_struct.h trunk/reactos/tools/widl/utils.c - copied unchanged from r31674, trunk/reactos/tools/widl_20080105/utils.c trunk/reactos/tools/widl/utils.h - copied unchanged from r31674, trunk/reactos/tools/widl_20080105/utils.h trunk/reactos/tools/widl/widl.c - copied unchanged from r31674, trunk/reactos/tools/widl_20080105/widl.c trunk/reactos/tools/widl/widl.h - copied unchanged from r31674, trunk/reactos/tools/widl_20080105/widl.h trunk/reactos/tools/widl/widl.mak - copied unchanged from r31674, trunk/reactos/tools/widl_20080105/widl.mak trunk/reactos/tools/widl/widl_ros.diff - copied unchanged from r31674, trunk/reactos/tools/widl_20080105/widl_ros.diff trunk/reactos/tools/widl/widltypes.h - copied unchanged from r31674, trunk/reactos/tools/widl_20080105/widltypes.h trunk/reactos/tools/widl/write_msft.c - copied unchanged from r31674, trunk/reactos/tools/widl_20080105/write_msft.c Removed: trunk/reactos/dll/win32/rpcrt4/ndr_contexth.c trunk/reactos/dll/win32/rpcrt4/ndr_contexth.h trunk/reactos/dll/win32/rpcrt4/ndr_midl.c trunk/reactos/dll/win32/rpcrt4/rpc_misc.h trunk/reactos/dll/win32/rpcrt4_new/ trunk/reactos/tools/widl/ChangeLog trunk/reactos/tools/widl/Makefile.in trunk/reactos/tools/widl/lex.yy.c trunk/reactos/tools/widl/widl.man.in trunk/reactos/tools/widl_20080105/ trunk/reactos/tools/widl_new/ Modified: trunk/reactos/dll/win32/shdocvw/shdocvw.h [This mail would be too long, it was shortened to contain the URLs only.] Removed: trunk/reactos/dll/win32/rpcrt4/ndr_contexth.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/rpcrt4/ndr_conte… Removed: trunk/reactos/dll/win32/rpcrt4/ndr_contexth.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/rpcrt4/ndr_conte… Removed: trunk/reactos/dll/win32/rpcrt4/ndr_midl.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/rpcrt4/ndr_midl.… Removed: trunk/reactos/dll/win32/rpcrt4/rpc_misc.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/rpcrt4/rpc_misc.… Modified: trunk/reactos/dll/win32/shdocvw/shdocvw.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shdocvw/shdocvw.… Removed: trunk/reactos/tools/widl/ChangeLog URL: http://svn.reactos.org/svn/reactos/trunk/reactos/tools/widl/ChangeLog?rev=3… Removed: trunk/reactos/tools/widl/Makefile.in URL: http://svn.reactos.org/svn/reactos/trunk/reactos/tools/widl/Makefile.in?rev… Removed: trunk/reactos/tools/widl/lex.yy.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/tools/widl/lex.yy.c?rev=31… Removed: trunk/reactos/tools/widl/widl.man.in URL: http://svn.reactos.org/svn/reactos/trunk/reactos/tools/widl/widl.man.in?rev…

1 0

[fireball] 31716: - Add missing \n to the debug print.
by fireball＠svn.reactos.org 11 Jan '08

11 Jan '08

Author: fireball Date: Fri Jan 11 16:15:53 2008 New Revision: 31716 URL: http://svn.reactos.org/svn/reactos?rev=31716&view=rev Log: - Add missing \n to the debug print. Modified: trunk/reactos/dll/win32/lsasrv/lsarpc.c Modified: trunk/reactos/dll/win32/lsasrv/lsarpc.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/lsasrv/lsarpc.c?… ============================================================================== --- trunk/reactos/dll/win32/lsasrv/lsarpc.c (original) +++ trunk/reactos/dll/win32/lsasrv/lsarpc.c Fri Jan 11 16:15:53 2008 @@ -118,7 +118,7 @@ return; } - DPRINT("LsarStartRpcServer() done"); + DPRINT("LsarStartRpcServer() done\n"); } /* Function 0 */

1 0

[fireball] 31715: - Apply adapted patch by Damjan Jovanovic <damjan.jov@gmail.com> "Make RpcMgmtWaitServerListen wait for the server to stop listening, like it is supposed to". Rob Shearman commented that "it prevented the dispatching of simultaneous RPCs on an endpoint", however it's enough for ReactOS for now, until a better patch is made. - Uncomment commented out error checks. - Update rpcrt4_ros.diff accordingly.
by fireball＠svn.reactos.org 11 Jan '08

11 Jan '08

Author: fireball Date: Fri Jan 11 16:13:05 2008 New Revision: 31715 URL: http://svn.reactos.org/svn/reactos?rev=31715&view=rev Log: - Apply adapted patch by Damjan Jovanovic <damjan.jov(a)gmail.com> "Make RpcMgmtWaitServerListen wait for the server to stop listening, like it is supposed to". Rob Shearman commented that "it prevented the dispatching of simultaneous RPCs on an endpoint", however it's enough for ReactOS for now, until a better patch is made. - Uncomment commented out error checks. - Update rpcrt4_ros.diff accordingly. Modified: trunk/reactos/dll/win32/rpcrt4_new/rpc_server.c trunk/reactos/dll/win32/rpcrt4_new/rpc_transport.c trunk/reactos/dll/win32/rpcrt4_new/rpcrt4_ros.diff Modified: trunk/reactos/dll/win32/rpcrt4_new/rpc_server.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/rpcrt4_new/rpc_s… ============================================================================== --- trunk/reactos/dll/win32/rpcrt4_new/rpc_server.c (original) +++ trunk/reactos/dll/win32/rpcrt4_new/rpc_server.c Fri Jan 11 16:13:05 2008 @@ -1019,7 +1019,7 @@ */ RPC_STATUS WINAPI RpcMgmtWaitServerListen( void ) { - TRACE("()\n"); + RpcServerProtseq *cps; EnterCriticalSection(&listen_cs); @@ -1027,10 +1027,18 @@ LeaveCriticalSection(&listen_cs); return RPC_S_NOT_LISTENING; } - + + do + { + LeaveCriticalSection(&listen_cs); + + LIST_FOR_EACH_ENTRY(cps, &protseqs, RpcServerProtseq, entry) + WaitForSingleObject(cps->server_ready_event, INFINITE); + + EnterCriticalSection(&listen_cs); + } while (!std_listen); + LeaveCriticalSection(&listen_cs); - - FIXME("not waiting for server calls to finish\n"); return RPC_S_OK; } Modified: trunk/reactos/dll/win32/rpcrt4_new/rpc_transport.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/rpcrt4_new/rpc_t… ============================================================================== --- trunk/reactos/dll/win32/rpcrt4_new/rpc_transport.c (original) +++ trunk/reactos/dll/win32/rpcrt4_new/rpc_transport.c Fri Jan 11 16:13:05 2008 @@ -375,7 +375,7 @@ break; ret = GetOverlappedResult(npc->pipe, &npc->ovl[0], &bytes_read, TRUE); - if (!ret /*&& GetLastError() != ERROR_MORE_DATA*/) + if (!ret && GetLastError() != ERROR_MORE_DATA) break; bytes_left -= bytes_read; @@ -400,7 +400,7 @@ break; ret = GetOverlappedResult(npc->pipe, &npc->ovl[1], &bytes_written, TRUE); - if (!ret /*&& GetLastError() != ERROR_MORE_DATA*/) + if (!ret && GetLastError() != ERROR_MORE_DATA) break; bytes_left -= bytes_written; Modified: trunk/reactos/dll/win32/rpcrt4_new/rpcrt4_ros.diff URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/rpcrt4_new/rpcrt… ============================================================================== --- trunk/reactos/dll/win32/rpcrt4_new/rpcrt4_ros.diff (original) +++ trunk/reactos/dll/win32/rpcrt4_new/rpcrt4_ros.diff Fri Jan 11 16:13:05 2008 @@ -1,5 +1,40 @@ ---- H:\Working Copies\wine\dlls\rpcrt4\rpc_transport.c Sun Jan 06 19:27:38 2008 -+++ H:\Working Copies\ReactOS\trunk\reactos\dll\win32\rpcrt4\rpc_transport.c Mon Jan 07 16:02:15 2008 +--- rpc_server.c Tue Jan 01 13:09:34 2008 ++++ rpc_server.c Fri Jan 11 15:58:57 2008 +@@ -1017,22 +1017,30 @@ + /*********************************************************************** + * RpcMgmtServerWaitListen (RPCRT4.@) + */ + RPC_STATUS WINAPI RpcMgmtWaitServerListen( void ) + { +- TRACE("()\n"); ++ RpcServerProtseq *cps; + + EnterCriticalSection(&listen_cs); + + if (!std_listen) { + LeaveCriticalSection(&listen_cs); + return RPC_S_NOT_LISTENING; + } + ++ do ++ { + LeaveCriticalSection(&listen_cs); + +- FIXME("not waiting for server calls to finish\n"); ++ LIST_FOR_EACH_ENTRY(cps, &protseqs, RpcServerProtseq, entry) ++ WaitForSingleObject(cps->server_ready_event, INFINITE); ++ ++ EnterCriticalSection(&listen_cs); ++ } while (!std_listen); ++ ++ LeaveCriticalSection(&listen_cs); + + return RPC_S_OK; + } + + /*********************************************************************** +--- rpc_transport.c Sun Jan 06 19:27:38 2008 ++++ rpc_transport.c Fri Jan 11 15:59:32 2008 @@ -54,10 +54,13 @@ #endif #ifdef HAVE_SYS_POLL_H @@ -127,7 +162,7 @@ break; + + ret = GetOverlappedResult(npc->pipe, &npc->ovl[0], &bytes_read, TRUE); -+ if (!ret /*&& GetLastError() != ERROR_MORE_DATA*/) ++ if (!ret && GetLastError() != ERROR_MORE_DATA) + break; + bytes_left -= bytes_read; @@ -148,7 +183,7 @@ break; + + ret = GetOverlappedResult(npc->pipe, &npc->ovl[1], &bytes_written, TRUE); -+ if (!ret /*&& GetLastError() != ERROR_MORE_DATA*/) ++ if (!ret && GetLastError() != ERROR_MORE_DATA) + break; + bytes_left -= bytes_written;

1 0

[hpoussin] 31714: Display hardware wizard only after user logged in. It still needs improvement, to first try once to install without user intervention, and then, once an admin is logged on, ask it for still not installed devices.
by hpoussin＠svn.reactos.org 11 Jan '08

11 Jan '08

Author: hpoussin Date: Fri Jan 11 16:00:44 2008 New Revision: 31714 URL: http://svn.reactos.org/svn/reactos?rev=31714&view=rev Log: Display hardware wizard only after user logged in. It still needs improvement, to first try once to install without user intervention, and then, once an admin is logged on, ask it for still not installed devices. Modified: trunk/reactos/base/services/umpnpmgr/umpnpmgr.c Modified: trunk/reactos/base/services/umpnpmgr/umpnpmgr.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/services/umpnpmgr/ump… ============================================================================== --- trunk/reactos/base/services/umpnpmgr/umpnpmgr.c (original) +++ trunk/reactos/base/services/umpnpmgr/umpnpmgr.c Fri Jan 11 16:00:44 2008 @@ -207,6 +207,9 @@ DPRINT("PNP_ReportLogOn(%u, %u) called\n", Admin, ProcessId); + if (hInstallEvent != NULL) + SetEvent(hInstallEvent); + /* Get the users token */ hProcess = OpenProcess(PROCESS_ALL_ACCESS, TRUE, @@ -226,8 +229,8 @@ } /* Trigger the installer thread */ - if (hInstallEvent != NULL) - SetEvent(hInstallEvent); + /*if (hInstallEvent != NULL) + SetEvent(hInstallEvent);*/ return CR_SUCCESS; } @@ -1679,6 +1682,8 @@ BOOL showWizard; UNREFERENCED_PARAMETER(lpParameter); + + WaitForSingleObject(hInstallEvent, INFINITE); showWizard = !SetupIsActive() && !IsConsoleBoot();

1 0

[hpoussin] 31713: Add missing \n
by hpoussin＠svn.reactos.org 11 Jan '08

11 Jan '08

Author: hpoussin Date: Fri Jan 11 14:35:44 2008 New Revision: 31713 URL: http://svn.reactos.org/svn/reactos?rev=31713&view=rev Log: Add missing \n Modified: trunk/reactos/drivers/input/i8042prt/keyboard.c Modified: trunk/reactos/drivers/input/i8042prt/keyboard.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/input/i8042prt/key… ============================================================================== --- trunk/reactos/drivers/input/i8042prt/keyboard.c (original) +++ trunk/reactos/drivers/input/i8042prt/keyboard.c Fri Jan 11 14:35:44 2008 @@ -131,7 +131,7 @@ case IOCTL_KEYBOARD_SET_INDICATORS: { TRACE_(I8042PRT, "IOCTL_KEYBOARD_SET_INDICATORS\n"); - INFO_(I8042PRT, "Leds: {%s%s%s }", + INFO_(I8042PRT, "Leds: {%s%s%s }\n", DeviceExtension->KeyboardIndicators.LedFlags & KEYBOARD_CAPS_LOCK_ON ? " CAPSLOCK" : "", DeviceExtension->KeyboardIndicators.LedFlags & KEYBOARD_NUM_LOCK_ON ? " NUMLOCK" : "", DeviceExtension->KeyboardIndicators.LedFlags & KEYBOARD_SCROLL_LOCK_ON ? " SCROLLLOCK" : "");

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs